blob: 21aecb2249ed6dcbab57cc7f8e9bc1d818647859 [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2012 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Darin Petkov6a5b3222010-07-13 14:55:28 -070016
Alex Deymo8427b4a2014-11-05 14:00:32 -080017#include "update_engine/omaha_request_action.h"
18
Ben Chan9abb7632014-08-07 00:10:53 -070019#include <stdint.h>
20
Ben Chanab5a0af2017-10-12 14:57:50 -070021#include <memory>
Darin Petkov6a5b3222010-07-13 14:55:28 -070022#include <string>
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080023#include <utility>
Darin Petkov6a5b3222010-07-13 14:55:28 -070024#include <vector>
Darin Petkov0dc8e9a2010-07-14 14:51:57 -070025
Alex Deymo60ca1a72015-06-18 18:19:15 -070026#include <base/bind.h>
Alex Deymo110e0302015-10-19 20:35:21 -070027#include <base/files/file_util.h>
Sen Jiang297e5832016-03-17 14:45:51 -070028#include <base/files/scoped_temp_dir.h>
Ben Chan5c02c132017-06-27 07:10:36 -070029#include <base/memory/ptr_util.h>
Alex Deymo8e18f932015-03-27 16:16:59 -070030#include <base/strings/string_number_conversions.h>
Alex Vakulenko75039d72014-03-25 12:36:28 -070031#include <base/strings/string_util.h>
32#include <base/strings/stringprintf.h>
33#include <base/time/time.h>
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -070034#include <brillo/bind_lambda.h>
35#include <brillo/message_loops/fake_message_loop.h>
36#include <brillo/message_loops/message_loop.h>
37#include <brillo/message_loops/message_loop_utils.h>
Alex Deymoe1e3afe2014-10-30 13:02:49 -070038#include <gtest/gtest.h>
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080039#include <policy/libpolicy.h>
40#include <policy/mock_libpolicy.h>
Jay Srinivasand29695d2013-04-08 15:08:05 -070041
Alex Deymo39910dc2015-11-09 17:04:30 -080042#include "update_engine/common/action_pipe.h"
43#include "update_engine/common/constants.h"
44#include "update_engine/common/fake_prefs.h"
45#include "update_engine/common/hash_calculator.h"
46#include "update_engine/common/mock_http_fetcher.h"
47#include "update_engine/common/platform_constants.h"
48#include "update_engine/common/prefs.h"
49#include "update_engine/common/test_utils.h"
Alex Deymoc1c17b42015-11-23 03:53:15 -030050#include "update_engine/fake_system_state.h"
Tianjie Xu282aa1f2017-09-05 13:42:45 -070051#include "update_engine/metrics_reporter_interface.h"
Chris Sosa77f79e82014-06-02 18:16:24 -070052#include "update_engine/mock_connection_manager.h"
Gilad Arnold74b5f552014-10-07 08:17:16 -070053#include "update_engine/mock_payload_state.h"
Darin Petkova4a8a8c2010-07-15 22:21:12 -070054#include "update_engine/omaha_request_params.h"
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080055#include "update_engine/update_manager/rollback_prefs.h"
Darin Petkov6a5b3222010-07-13 14:55:28 -070056
Darin Petkov1cbd78f2010-07-29 12:38:34 -070057using base::Time;
58using base::TimeDelta;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080059using chromeos_update_manager::kRollforwardInfinity;
Darin Petkov6a5b3222010-07-13 14:55:28 -070060using std::string;
61using std::vector;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070062using testing::AllOf;
Alex Deymof329b932014-10-30 01:37:48 -070063using testing::AnyNumber;
Jay Srinivasan34b5d862012-07-23 11:43:22 -070064using testing::DoAll;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070065using testing::Ge;
66using testing::Le;
Darin Petkov9c096d62010-11-17 14:49:04 -080067using testing::NiceMock;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070068using testing::Return;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080069using testing::ReturnRef;
Gilad Arnold74b5f552014-10-07 08:17:16 -070070using testing::ReturnPointee;
71using testing::SaveArg;
Ben Chan672c1f52017-10-23 15:41:39 -070072using testing::SetArgPointee;
Alex Deymof329b932014-10-30 01:37:48 -070073using testing::_;
Darin Petkov6a5b3222010-07-13 14:55:28 -070074
Alex Deymo8e18f932015-03-27 16:16:59 -070075namespace {
76
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080077static_assert(kRollforwardInfinity == 0xfffffffe,
78 "Don't change the value of kRollforward infinity unless its "
79 "size has been changed in firmware.");
80
Alex Deymo85616652015-10-15 18:48:31 -070081const char kTestAppId[] = "test-app-id";
Aaron Wood7dcdedf2017-09-06 17:17:41 -070082const char kTestAppId2[] = "test-app2-id";
Alex Deymo85616652015-10-15 18:48:31 -070083
Alex Deymo8e18f932015-03-27 16:16:59 -070084// This is a helper struct to allow unit tests build an update response with the
85// values they care about.
86struct FakeUpdateResponse {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -070087 string GetRollbackVersionAttributes() const {
88 return (rollback ? " _rollback=\"true\"" : "") +
89 (!rollback_firmware_version.empty()
90 ? " _firmware_version=\"" + rollback_firmware_version + "\""
91 : "") +
92 (!rollback_kernel_version.empty()
93 ? " _kernel_version=\"" + rollback_kernel_version + "\""
94 : "");
95 }
96
Alex Deymo8e18f932015-03-27 16:16:59 -070097 string GetNoUpdateResponse() const {
98 string entity_str;
99 if (include_entity)
100 entity_str = "<!DOCTYPE response [<!ENTITY CrOS \"ChromeOS\">]>";
Sen Jiang81259682017-03-30 15:11:30 -0700101 return "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" + entity_str +
102 "<response protocol=\"3.0\">"
103 "<daystart elapsed_seconds=\"100\"/>"
104 "<app appid=\"" +
105 app_id + "\" " +
106 (include_cohorts
107 ? "cohort=\"" + cohort + "\" cohorthint=\"" + cohorthint +
108 "\" cohortname=\"" + cohortname + "\" "
109 : "") +
110 " status=\"ok\">"
111 "<ping status=\"ok\"/>"
112 "<updatecheck status=\"noupdate\"/></app>" +
113 (multi_app_no_update
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700114 ? "<app appid=\"" + app_id2 +
115 "\"><updatecheck status=\"noupdate\"/></app>"
Sen Jiang81259682017-03-30 15:11:30 -0700116 : "") +
117 "</response>";
Alex Deymo8e18f932015-03-27 16:16:59 -0700118 }
119
120 string GetUpdateResponse() const {
Sen Jiang2703ef42017-03-16 13:36:21 -0700121 return "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
122 "protocol=\"3.0\">"
123 "<daystart elapsed_seconds=\"100\"" +
124 (elapsed_days.empty() ? ""
125 : (" elapsed_days=\"" + elapsed_days + "\"")) +
126 "/>"
127 "<app appid=\"" +
128 app_id + "\" " +
129 (include_cohorts
130 ? "cohort=\"" + cohort + "\" cohorthint=\"" + cohorthint +
131 "\" cohortname=\"" + cohortname + "\" "
132 : "") +
133 " status=\"ok\">"
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700134 "<ping status=\"ok\"/><updatecheck status=\"ok\"" +
135 GetRollbackVersionAttributes() + ">" + "<urls><url codebase=\"" +
Sen Jiang2703ef42017-03-16 13:36:21 -0700136 codebase +
137 "\"/></urls>"
138 "<manifest version=\"" +
139 version +
140 "\">"
141 "<packages><package hash=\"not-used\" name=\"" +
142 filename + "\" size=\"" + base::Int64ToString(size) +
Sen Jiang0affc2c2017-02-10 15:55:05 -0800143 "\" hash_sha256=\"" + hash + "\"/>" +
144 (multi_package ? "<package name=\"package2\" size=\"222\" "
145 "hash_sha256=\"hash2\"/>"
146 : "") +
147 "</packages>"
Sen Jiang81259682017-03-30 15:11:30 -0700148 "<actions><action event=\"postinstall\" MetadataSize=\"11" +
149 (multi_package ? ":22" : "") + "\" ChromeOSVersion=\"" + version +
150 "\" MoreInfo=\"" + more_info_url + "\" Prompt=\"" + prompt +
Sen Jiang2703ef42017-03-16 13:36:21 -0700151 "\" "
152 "IsDelta=\"true\" "
Sen Jiangcdd52062017-05-18 15:33:10 -0700153 "IsDeltaPayload=\"true" +
154 (multi_package ? ":false" : "") +
155 "\" "
Sen Jiang2703ef42017-03-16 13:36:21 -0700156 "MaxDaysToScatter=\"" +
157 max_days_to_scatter +
158 "\" "
159 "sha256=\"not-used\" "
160 "needsadmin=\"" +
161 needsadmin + "\" " +
162 (deadline.empty() ? "" : ("deadline=\"" + deadline + "\" ")) +
163 (disable_p2p_for_downloading ? "DisableP2PForDownloading=\"true\" "
164 : "") +
165 (disable_p2p_for_sharing ? "DisableP2PForSharing=\"true\" " : "") +
Sen Jiangfe284402018-03-21 14:03:50 -0700166 (powerwash ? "Powerwash=\"true\" " : "") +
Sen Jiang81259682017-03-30 15:11:30 -0700167 "/></actions></manifest></updatecheck></app>" +
168 (multi_app
Sen Jiangb1e063a2017-09-15 17:44:31 -0700169 ? "<app appid=\"" + app_id2 + "\"" +
170 (include_cohorts ? " cohort=\"cohort2\"" : "") +
171 "><updatecheck status=\"ok\"><urls><url codebase=\"" +
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700172 codebase2 + "\"/></urls><manifest version=\"" + version2 +
173 "\"><packages>"
Sen Jiang81259682017-03-30 15:11:30 -0700174 "<package name=\"package3\" size=\"333\" "
175 "hash_sha256=\"hash3\"/></packages>"
Sen Jiang00adf7b2017-06-26 15:57:29 -0700176 "<actions><action event=\"postinstall\" " +
177 (multi_app_self_update
178 ? "noupdate=\"true\" IsDeltaPayload=\"true\" "
179 : "IsDeltaPayload=\"false\" ") +
180 "MetadataSize=\"33\"/></actions>"
Sen Jiang81259682017-03-30 15:11:30 -0700181 "</manifest></updatecheck></app>"
182 : "") +
183 (multi_app_no_update
184 ? "<app><updatecheck status=\"noupdate\"/></app>"
185 : "") +
186 "</response>";
Alex Deymo8e18f932015-03-27 16:16:59 -0700187 }
188
189 // Return the payload URL, which is split in two fields in the XML response.
190 string GetPayloadUrl() {
191 return codebase + filename;
192 }
193
Alex Deymo85616652015-10-15 18:48:31 -0700194 string app_id = kTestAppId;
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700195 string app_id2 = kTestAppId2;
Alex Deymo8e18f932015-03-27 16:16:59 -0700196 string version = "1.2.3.4";
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700197 string version2 = "2.3.4.5";
Alex Deymo8e18f932015-03-27 16:16:59 -0700198 string more_info_url = "http://more/info";
199 string prompt = "true";
200 string codebase = "http://code/base/";
Sen Jiang81259682017-03-30 15:11:30 -0700201 string codebase2 = "http://code/base/2/";
Alex Deymo8e18f932015-03-27 16:16:59 -0700202 string filename = "file.signed";
Sen Jiang2703ef42017-03-16 13:36:21 -0700203 string hash = "4841534831323334";
Alex Deymo8e18f932015-03-27 16:16:59 -0700204 string needsadmin = "false";
Sen Jiang0affc2c2017-02-10 15:55:05 -0800205 uint64_t size = 123;
Alex Deymo8e18f932015-03-27 16:16:59 -0700206 string deadline = "";
207 string max_days_to_scatter = "7";
208 string elapsed_days = "42";
209
210 // P2P setting defaults to allowed.
211 bool disable_p2p_for_downloading = false;
212 bool disable_p2p_for_sharing = false;
213
Sen Jiangfe284402018-03-21 14:03:50 -0700214 bool powerwash = false;
215
Alex Deymo8e18f932015-03-27 16:16:59 -0700216 // Omaha cohorts settings.
217 bool include_cohorts = false;
218 string cohort = "";
219 string cohorthint = "";
220 string cohortname = "";
221
222 // Whether to include the CrOS <!ENTITY> in the XML response.
223 bool include_entity = false;
Sen Jiang0affc2c2017-02-10 15:55:05 -0800224
Sen Jiang81259682017-03-30 15:11:30 -0700225 // Whether to include more than one app.
226 bool multi_app = false;
Sen Jiang00adf7b2017-06-26 15:57:29 -0700227 // Whether to include an app with noupdate="true".
228 bool multi_app_self_update = false;
229 // Whether to include an additional app with status="noupdate".
Sen Jiang81259682017-03-30 15:11:30 -0700230 bool multi_app_no_update = false;
231 // Whether to include more than one package in an app.
Sen Jiang0affc2c2017-02-10 15:55:05 -0800232 bool multi_package = false;
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700233
234 // Whether the payload is a rollback.
235 bool rollback = false;
236 // The verified boot firmware key version for the rollback image.
237 string rollback_firmware_version = "";
238 // The verified boot kernel key version for the rollback image.
239 string rollback_kernel_version = "";
Alex Deymo8e18f932015-03-27 16:16:59 -0700240};
241
242} // namespace
243
Darin Petkov6a5b3222010-07-13 14:55:28 -0700244namespace chromeos_update_engine {
245
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700246class OmahaRequestActionTest : public ::testing::Test {
247 protected:
Alex Deymo610277e2014-11-11 21:18:11 -0800248 void SetUp() override {
Marton Hunyady2abda312018-04-24 18:21:49 +0200249 request_params_.set_os_sp("service_pack");
250 request_params_.set_os_board("x86-generic");
251 request_params_.set_app_id(kTestAppId);
252 request_params_.set_app_version("0.1.0.0");
253 request_params_.set_app_lang("en-US");
254 request_params_.set_current_channel("unittest");
255 request_params_.set_target_channel("unittest");
256 request_params_.set_hwid("OEM MODEL 09235 7471");
257 request_params_.set_fw_version("ChromeOSFirmware.1.0");
258 request_params_.set_ec_version("0X0A1");
259 request_params_.set_delta_okay(true);
260 request_params_.set_interactive(false);
261 request_params_.set_update_url("http://url");
262 request_params_.set_target_version_prefix("");
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200263 request_params_.set_rollback_allowed(false);
Marton Hunyady2abda312018-04-24 18:21:49 +0200264 request_params_.set_is_powerwash_allowed(false);
265
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700266 fake_system_state_.set_request_params(&request_params_);
267 fake_system_state_.set_prefs(&fake_prefs_);
268 }
269
270 // Returns true iff an output response was obtained from the
Alex Deymo8427b4a2014-11-05 14:00:32 -0800271 // OmahaRequestAction. |prefs| may be null, in which case a local MockPrefs
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700272 // is used. |payload_state| may be null, in which case a local mock is used.
273 // |p2p_manager| may be null, in which case a local mock is used.
274 // |connection_manager| may be null, in which case a local mock is used.
275 // out_response may be null. If |fail_http_response_code| is non-negative,
276 // the transfer will fail with that code. |ping_only| is passed through to the
277 // OmahaRequestAction constructor. out_post_data may be null; if non-null, the
278 // post-data received by the mock HttpFetcher is returned.
279 //
280 // The |expected_check_result|, |expected_check_reaction| and
281 // |expected_error_code| parameters are for checking expectations
282 // about reporting UpdateEngine.Check.{Result,Reaction,DownloadError}
283 // UMA statistics. Use the appropriate ::kUnset value to specify that
284 // the given metric should not be reported.
Marton Hunyady2abda312018-04-24 18:21:49 +0200285 bool TestUpdateCheck(const string& http_response,
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700286 int fail_http_response_code,
287 bool ping_only,
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800288 bool is_consumer_device,
289 int rollback_allowed_milestones,
290 bool is_policy_loaded,
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700291 ErrorCode expected_code,
292 metrics::CheckResult expected_check_result,
293 metrics::CheckReaction expected_check_reaction,
294 metrics::DownloadErrorCode expected_download_error_code,
295 OmahaResponse* out_response,
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700296 brillo::Blob* out_post_data);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700297
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800298 // Overload of TestUpdateCheck that does not supply |is_consumer_device| or
299 // |rollback_allowed_milestones| which are only required for rollback tests.
300 bool TestUpdateCheck(const string& http_response,
301 int fail_http_response_code,
302 bool ping_only,
303 ErrorCode expected_code,
304 metrics::CheckResult expected_check_result,
305 metrics::CheckReaction expected_check_reaction,
306 metrics::DownloadErrorCode expected_download_error_code,
307 OmahaResponse* out_response,
308 brillo::Blob* out_post_data);
309
310 void TestRollbackCheck(bool is_consumer_device,
311 int rollback_allowed_milestones,
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700312 bool is_policy_loaded,
313 OmahaResponse* out_response);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800314
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -0800315 // Runs and checks a ping test. |ping_only| indicates whether it should send
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700316 // only a ping or also an updatecheck.
317 void PingTest(bool ping_only);
318
319 // InstallDate test helper function.
Alex Deymof329b932014-10-30 01:37:48 -0700320 bool InstallDateParseHelper(const string &elapsed_days,
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700321 OmahaResponse *response);
322
323 // P2P test helper function.
324 void P2PTest(
325 bool initial_allow_p2p_for_downloading,
326 bool initial_allow_p2p_for_sharing,
327 bool omaha_disable_p2p_for_downloading,
328 bool omaha_disable_p2p_for_sharing,
329 bool payload_state_allow_p2p_attempt,
330 bool expect_p2p_client_lookup,
331 const string& p2p_client_result_url,
332 bool expected_allow_p2p_for_downloading,
333 bool expected_allow_p2p_for_sharing,
334 const string& expected_p2p_url);
335
336 FakeSystemState fake_system_state_;
Alex Deymo8e18f932015-03-27 16:16:59 -0700337 FakeUpdateResponse fake_update_response_;
Marton Hunyady2abda312018-04-24 18:21:49 +0200338 // Used by all tests.
339 OmahaRequestParams request_params_{&fake_system_state_};
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700340
341 FakePrefs fake_prefs_;
342};
Darin Petkov6a5b3222010-07-13 14:55:28 -0700343
344namespace {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700345class OmahaRequestActionTestProcessorDelegate : public ActionProcessorDelegate {
346 public:
347 OmahaRequestActionTestProcessorDelegate()
Alex Deymo60ca1a72015-06-18 18:19:15 -0700348 : expected_code_(ErrorCode::kSuccess) {}
Alex Deymo610277e2014-11-11 21:18:11 -0800349 ~OmahaRequestActionTestProcessorDelegate() override {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700350 }
Yunlian Jiang35866ed2015-01-29 13:09:20 -0800351 void ProcessingDone(const ActionProcessor* processor,
352 ErrorCode code) override {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700353 brillo::MessageLoop::current()->BreakLoop();
Darin Petkov6a5b3222010-07-13 14:55:28 -0700354 }
355
Yunlian Jiang35866ed2015-01-29 13:09:20 -0800356 void ActionCompleted(ActionProcessor* processor,
357 AbstractAction* action,
358 ErrorCode code) override {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700359 // make sure actions always succeed
360 if (action->Type() == OmahaRequestAction::StaticType())
Darin Petkovc1a8b422010-07-19 11:34:49 -0700361 EXPECT_EQ(expected_code_, code);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700362 else
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700363 EXPECT_EQ(ErrorCode::kSuccess, code);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700364 }
David Zeuthena99981f2013-04-29 13:42:47 -0700365 ErrorCode expected_code_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700366};
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700367} // namespace
Darin Petkov6a5b3222010-07-13 14:55:28 -0700368
369class OutputObjectCollectorAction;
370
371template<>
372class ActionTraits<OutputObjectCollectorAction> {
373 public:
374 // Does not take an object for input
375 typedef OmahaResponse InputObjectType;
376 // On success, puts the output path on output
377 typedef NoneType OutputObjectType;
378};
379
380class OutputObjectCollectorAction : public Action<OutputObjectCollectorAction> {
381 public:
382 OutputObjectCollectorAction() : has_input_object_(false) {}
383 void PerformAction() {
384 // copy input object
385 has_input_object_ = HasInputObject();
386 if (has_input_object_)
387 omaha_response_ = GetInputObject();
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700388 processor_->ActionComplete(this, ErrorCode::kSuccess);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700389 }
390 // Should never be called
391 void TerminateProcessing() {
392 CHECK(false);
393 }
394 // Debugging/logging
Alex Deymof329b932014-10-30 01:37:48 -0700395 static string StaticType() {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700396 return "OutputObjectCollectorAction";
397 }
Alex Deymof329b932014-10-30 01:37:48 -0700398 string Type() const { return StaticType(); }
Alex Vakulenko0057daa2016-01-23 16:22:50 -0800399 using InputObjectType =
400 ActionTraits<OutputObjectCollectorAction>::InputObjectType;
401 using OutputObjectType =
402 ActionTraits<OutputObjectCollectorAction>::OutputObjectType;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700403 bool has_input_object_;
404 OmahaResponse omaha_response_;
405};
406
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700407bool OmahaRequestActionTest::TestUpdateCheck(
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700408 const string& http_response,
409 int fail_http_response_code,
410 bool ping_only,
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800411 bool is_consumer_device,
412 int rollback_allowed_milestones,
413 bool is_policy_loaded,
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700414 ErrorCode expected_code,
415 metrics::CheckResult expected_check_result,
416 metrics::CheckReaction expected_check_reaction,
417 metrics::DownloadErrorCode expected_download_error_code,
418 OmahaResponse* out_response,
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700419 brillo::Blob* out_post_data) {
420 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700421 loop.SetAsCurrent();
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700422 MockHttpFetcher* fetcher = new MockHttpFetcher(http_response.data(),
Andrew de los Reyes45168102010-11-22 11:13:50 -0800423 http_response.size(),
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700424 nullptr);
Darin Petkovedc522e2010-11-05 09:35:17 -0700425 if (fail_http_response_code >= 0) {
426 fetcher->FailTransfer(fail_http_response_code);
427 }
Marton Hunyady2abda312018-04-24 18:21:49 +0200428 // This ensures the tests didn't forget to update fake_system_state_ if they
429 // are not using the default request_params_.
430 EXPECT_EQ(&request_params_, fake_system_state_.request_params());
431
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700432 OmahaRequestAction action(&fake_system_state_,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700433 nullptr,
Ben Chan5c02c132017-06-27 07:10:36 -0700434 base::WrapUnique(fetcher),
Darin Petkov265f2902011-05-09 15:17:40 -0700435 ping_only);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800436 auto mock_policy_provider =
437 std::make_unique<NiceMock<policy::MockPolicyProvider>>();
438 EXPECT_CALL(*mock_policy_provider, IsConsumerDevice())
439 .WillRepeatedly(Return(is_consumer_device));
440
441 EXPECT_CALL(*mock_policy_provider, device_policy_is_loaded())
442 .WillRepeatedly(Return(is_policy_loaded));
443
444 const policy::MockDevicePolicy device_policy;
445 const bool get_allowed_milestone_succeeds = rollback_allowed_milestones >= 0;
446 EXPECT_CALL(device_policy, GetRollbackAllowedMilestones(_))
447 .WillRepeatedly(DoAll(SetArgPointee<0>(rollback_allowed_milestones),
448 Return(get_allowed_milestone_succeeds)));
449
450 EXPECT_CALL(*mock_policy_provider, GetDevicePolicy())
451 .WillRepeatedly(ReturnRef(device_policy));
452
453 action.policy_provider_ = std::move(mock_policy_provider);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700454 OmahaRequestActionTestProcessorDelegate delegate;
Darin Petkovc1a8b422010-07-19 11:34:49 -0700455 delegate.expected_code_ = expected_code;
Darin Petkova4a8a8c2010-07-15 22:21:12 -0700456
Darin Petkov6a5b3222010-07-13 14:55:28 -0700457 ActionProcessor processor;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700458 processor.set_delegate(&delegate);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700459 processor.EnqueueAction(&action);
460
461 OutputObjectCollectorAction collector_action;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700462 BondActions(&action, &collector_action);
463 processor.EnqueueAction(&collector_action);
464
Tianjie Xu282aa1f2017-09-05 13:42:45 -0700465 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
466 ReportUpdateCheckMetrics(_, _, _, _))
David Zeuthen33bae492014-02-25 16:16:18 -0800467 .Times(AnyNumber());
Tianjie Xu282aa1f2017-09-05 13:42:45 -0700468
469 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
470 ReportUpdateCheckMetrics(_,
471 expected_check_result,
472 expected_check_reaction,
473 expected_download_error_code))
474 .Times(ping_only ? 0 : 1);
David Zeuthen33bae492014-02-25 16:16:18 -0800475
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700476 loop.PostTask(base::Bind(
477 [](ActionProcessor* processor) { processor->StartProcessing(); },
478 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700479 loop.Run();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700480 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -0700481 if (collector_action.has_input_object_ && out_response)
482 *out_response = collector_action.omaha_response_;
483 if (out_post_data)
484 *out_post_data = fetcher->post_data();
485 return collector_action.has_input_object_;
486}
487
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800488bool OmahaRequestActionTest::TestUpdateCheck(
489 const string& http_response,
490 int fail_http_response_code,
491 bool ping_only,
492 ErrorCode expected_code,
493 metrics::CheckResult expected_check_result,
494 metrics::CheckReaction expected_check_reaction,
495 metrics::DownloadErrorCode expected_download_error_code,
496 OmahaResponse* out_response,
497 brillo::Blob* out_post_data) {
498 return TestUpdateCheck(http_response,
499 fail_http_response_code,
500 ping_only,
501 true, // is_consumer_device
502 0, // rollback_allowed_milestones
503 false, // is_policy_loaded
504 expected_code,
505 expected_check_result,
506 expected_check_reaction,
507 expected_download_error_code,
508 out_response,
509 out_post_data);
510}
511
512void OmahaRequestActionTest::TestRollbackCheck(bool is_consumer_device,
513 int rollback_allowed_milestones,
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700514 bool is_policy_loaded,
515 OmahaResponse* out_response) {
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800516 fake_update_response_.deadline = "20101020";
517 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
518 -1,
519 false, // ping_only
520 is_consumer_device,
521 rollback_allowed_milestones,
522 is_policy_loaded,
523 ErrorCode::kSuccess,
524 metrics::CheckResult::kUpdateAvailable,
525 metrics::CheckReaction::kUpdating,
526 metrics::DownloadErrorCode::kUnset,
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700527 out_response,
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800528 nullptr));
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700529 ASSERT_TRUE(out_response->update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800530}
531
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700532// Tests Event requests -- they should always succeed. |out_post_data|
533// may be null; if non-null, the post-data received by the mock
534// HttpFetcher is returned.
Marton Hunyady2abda312018-04-24 18:21:49 +0200535void TestEvent(OmahaEvent* event,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700536 const string& http_response,
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700537 brillo::Blob* out_post_data) {
538 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700539 loop.SetAsCurrent();
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700540 MockHttpFetcher* fetcher = new MockHttpFetcher(http_response.data(),
Andrew de los Reyes45168102010-11-22 11:13:50 -0800541 http_response.size(),
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700542 nullptr);
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700543 FakeSystemState fake_system_state;
Alex Deymoc1c17b42015-11-23 03:53:15 -0300544 OmahaRequestAction action(&fake_system_state,
545 event,
Ben Chan5c02c132017-06-27 07:10:36 -0700546 base::WrapUnique(fetcher),
Alex Deymoc1c17b42015-11-23 03:53:15 -0300547 false);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700548 OmahaRequestActionTestProcessorDelegate delegate;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700549 ActionProcessor processor;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700550 processor.set_delegate(&delegate);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700551 processor.EnqueueAction(&action);
552
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700553 loop.PostTask(base::Bind(
554 [](ActionProcessor* processor) { processor->StartProcessing(); },
555 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700556 loop.Run();
Alex Deymo72a25672016-03-23 15:44:39 -0700557 EXPECT_FALSE(loop.PendingTasks());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700558
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700559 if (out_post_data)
560 *out_post_data = fetcher->post_data();
561}
562
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700563TEST_F(OmahaRequestActionTest, RejectEntities) {
David Zeuthenf3e28012014-08-26 18:23:52 -0400564 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -0700565 fake_update_response_.include_entity = true;
Marton Hunyady2abda312018-04-24 18:21:49 +0200566 ASSERT_FALSE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
567 -1,
568 false, // ping_only
569 ErrorCode::kOmahaRequestXMLHasEntityDecl,
570 metrics::CheckResult::kParsingError,
571 metrics::CheckReaction::kUnset,
572 metrics::DownloadErrorCode::kUnset,
573 &response,
574 nullptr));
David Zeuthenf3e28012014-08-26 18:23:52 -0400575 EXPECT_FALSE(response.update_exists);
576}
577
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700578TEST_F(OmahaRequestActionTest, NoUpdateTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700579 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +0200580 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
581 -1,
582 false, // ping_only
583 ErrorCode::kSuccess,
584 metrics::CheckResult::kNoUpdateAvailable,
585 metrics::CheckReaction::kUnset,
586 metrics::DownloadErrorCode::kUnset,
587 &response,
588 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700589 EXPECT_FALSE(response.update_exists);
590}
591
Sen Jiang81259682017-03-30 15:11:30 -0700592TEST_F(OmahaRequestActionTest, MultiAppNoUpdateTest) {
593 OmahaResponse response;
594 fake_update_response_.multi_app_no_update = true;
Marton Hunyady2abda312018-04-24 18:21:49 +0200595 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
Sen Jiang81259682017-03-30 15:11:30 -0700596 -1,
597 false, // ping_only
598 ErrorCode::kSuccess,
599 metrics::CheckResult::kNoUpdateAvailable,
600 metrics::CheckReaction::kUnset,
601 metrics::DownloadErrorCode::kUnset,
602 &response,
603 nullptr));
604 EXPECT_FALSE(response.update_exists);
605}
606
Sen Jiang00adf7b2017-06-26 15:57:29 -0700607TEST_F(OmahaRequestActionTest, MultiAppNoPartialUpdateTest) {
608 OmahaResponse response;
609 fake_update_response_.multi_app_no_update = true;
Marton Hunyady2abda312018-04-24 18:21:49 +0200610 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiang00adf7b2017-06-26 15:57:29 -0700611 -1,
612 false, // ping_only
613 ErrorCode::kSuccess,
614 metrics::CheckResult::kNoUpdateAvailable,
615 metrics::CheckReaction::kUnset,
616 metrics::DownloadErrorCode::kUnset,
617 &response,
618 nullptr));
619 EXPECT_FALSE(response.update_exists);
620}
621
622TEST_F(OmahaRequestActionTest, NoSelfUpdateTest) {
623 OmahaResponse response;
624 ASSERT_TRUE(TestUpdateCheck(
Sen Jiang00adf7b2017-06-26 15:57:29 -0700625 "<response><app><updatecheck status=\"ok\"><manifest><actions><action "
626 "event=\"postinstall\" noupdate=\"true\"/></actions>"
627 "</manifest></updatecheck></app></response>",
628 -1,
629 false, // ping_only
630 ErrorCode::kSuccess,
631 metrics::CheckResult::kNoUpdateAvailable,
632 metrics::CheckReaction::kUnset,
633 metrics::DownloadErrorCode::kUnset,
634 &response,
635 nullptr));
636 EXPECT_FALSE(response.update_exists);
637}
638
Alex Deymo8e18f932015-03-27 16:16:59 -0700639// Test that all the values in the response are parsed in a normal update
640// response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700641TEST_F(OmahaRequestActionTest, ValidUpdateTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -0700642 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -0700643 fake_update_response_.deadline = "20101020";
Marton Hunyady2abda312018-04-24 18:21:49 +0200644 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
645 -1,
646 false, // ping_only
647 ErrorCode::kSuccess,
648 metrics::CheckResult::kUpdateAvailable,
649 metrics::CheckReaction::kUpdating,
650 metrics::DownloadErrorCode::kUnset,
651 &response,
652 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700653 EXPECT_TRUE(response.update_exists);
Alex Deymo8e18f932015-03-27 16:16:59 -0700654 EXPECT_EQ(fake_update_response_.version, response.version);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700655 EXPECT_EQ("", response.system_version);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800656 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
657 response.packages[0].payload_urls[0]);
Alex Deymo8e18f932015-03-27 16:16:59 -0700658 EXPECT_EQ(fake_update_response_.more_info_url, response.more_info_url);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800659 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
660 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700661 EXPECT_EQ(true, response.packages[0].is_delta);
Alex Deymo8e18f932015-03-27 16:16:59 -0700662 EXPECT_EQ(fake_update_response_.prompt == "true", response.prompt);
663 EXPECT_EQ(fake_update_response_.deadline, response.deadline);
Sen Jiangfe284402018-03-21 14:03:50 -0700664 EXPECT_FALSE(response.powerwash_required);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700665 // Omaha cohort attributes are not set in the response, so they should not be
Alex Deymo8e18f932015-03-27 16:16:59 -0700666 // persisted.
667 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohort));
668 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortHint));
669 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortName));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700670}
671
Sen Jiang0affc2c2017-02-10 15:55:05 -0800672TEST_F(OmahaRequestActionTest, MultiPackageUpdateTest) {
673 OmahaResponse response;
674 fake_update_response_.multi_package = true;
Marton Hunyady2abda312018-04-24 18:21:49 +0200675 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiang0affc2c2017-02-10 15:55:05 -0800676 -1,
677 false, // ping_only
678 ErrorCode::kSuccess,
679 metrics::CheckResult::kUpdateAvailable,
680 metrics::CheckReaction::kUpdating,
681 metrics::DownloadErrorCode::kUnset,
682 &response,
683 nullptr));
684 EXPECT_TRUE(response.update_exists);
685 EXPECT_EQ(fake_update_response_.version, response.version);
686 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
687 response.packages[0].payload_urls[0]);
688 EXPECT_EQ(fake_update_response_.codebase + "package2",
689 response.packages[1].payload_urls[0]);
690 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
691 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700692 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700693 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800694 ASSERT_EQ(2u, response.packages.size());
Sen Jiang81259682017-03-30 15:11:30 -0700695 EXPECT_EQ(string("hash2"), response.packages[1].hash);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800696 EXPECT_EQ(222u, response.packages[1].size);
Sen Jiang81259682017-03-30 15:11:30 -0700697 EXPECT_EQ(22u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700698 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700699}
700
701TEST_F(OmahaRequestActionTest, MultiAppUpdateTest) {
702 OmahaResponse response;
703 fake_update_response_.multi_app = true;
Marton Hunyady2abda312018-04-24 18:21:49 +0200704 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiang81259682017-03-30 15:11:30 -0700705 -1,
706 false, // ping_only
707 ErrorCode::kSuccess,
708 metrics::CheckResult::kUpdateAvailable,
709 metrics::CheckReaction::kUpdating,
710 metrics::DownloadErrorCode::kUnset,
711 &response,
712 nullptr));
713 EXPECT_TRUE(response.update_exists);
714 EXPECT_EQ(fake_update_response_.version, response.version);
715 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
716 response.packages[0].payload_urls[0]);
717 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
718 response.packages[1].payload_urls[0]);
719 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
720 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
721 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700722 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700723 ASSERT_EQ(2u, response.packages.size());
724 EXPECT_EQ(string("hash3"), response.packages[1].hash);
725 EXPECT_EQ(333u, response.packages[1].size);
726 EXPECT_EQ(33u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700727 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700728}
729
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700730TEST_F(OmahaRequestActionTest, MultiAppAndSystemUpdateTest) {
731 OmahaResponse response;
732 fake_update_response_.multi_app = true;
733 // trigger the lining up of the app and system versions
734 request_params_.set_system_app_id(fake_update_response_.app_id2);
735
Marton Hunyady2abda312018-04-24 18:21:49 +0200736 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700737 -1,
738 false, // ping_only
739 ErrorCode::kSuccess,
740 metrics::CheckResult::kUpdateAvailable,
741 metrics::CheckReaction::kUpdating,
742 metrics::DownloadErrorCode::kUnset,
743 &response,
744 nullptr));
745 EXPECT_TRUE(response.update_exists);
746 EXPECT_EQ(fake_update_response_.version, response.version);
747 EXPECT_EQ(fake_update_response_.version2, response.system_version);
748 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
749 response.packages[0].payload_urls[0]);
750 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
751 response.packages[1].payload_urls[0]);
752 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
753 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
754 EXPECT_EQ(11u, response.packages[0].metadata_size);
755 EXPECT_EQ(true, response.packages[0].is_delta);
756 ASSERT_EQ(2u, response.packages.size());
757 EXPECT_EQ(string("hash3"), response.packages[1].hash);
758 EXPECT_EQ(333u, response.packages[1].size);
759 EXPECT_EQ(33u, response.packages[1].metadata_size);
760 EXPECT_EQ(false, response.packages[1].is_delta);
761}
762
Sen Jiang81259682017-03-30 15:11:30 -0700763TEST_F(OmahaRequestActionTest, MultiAppPartialUpdateTest) {
764 OmahaResponse response;
Sen Jiang00adf7b2017-06-26 15:57:29 -0700765 fake_update_response_.multi_app = true;
766 fake_update_response_.multi_app_self_update = true;
Marton Hunyady2abda312018-04-24 18:21:49 +0200767 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiang81259682017-03-30 15:11:30 -0700768 -1,
769 false, // ping_only
770 ErrorCode::kSuccess,
771 metrics::CheckResult::kUpdateAvailable,
772 metrics::CheckReaction::kUpdating,
773 metrics::DownloadErrorCode::kUnset,
774 &response,
775 nullptr));
776 EXPECT_TRUE(response.update_exists);
777 EXPECT_EQ(fake_update_response_.version, response.version);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700778 EXPECT_EQ("", response.system_version);
Sen Jiang81259682017-03-30 15:11:30 -0700779 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
780 response.packages[0].payload_urls[0]);
781 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
782 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
783 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiang00adf7b2017-06-26 15:57:29 -0700784 ASSERT_EQ(2u, response.packages.size());
785 EXPECT_EQ(string("hash3"), response.packages[1].hash);
786 EXPECT_EQ(333u, response.packages[1].size);
787 EXPECT_EQ(33u, response.packages[1].metadata_size);
788 EXPECT_EQ(true, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700789}
790
791TEST_F(OmahaRequestActionTest, MultiAppMultiPackageUpdateTest) {
792 OmahaResponse response;
793 fake_update_response_.multi_app = true;
794 fake_update_response_.multi_package = true;
Marton Hunyady2abda312018-04-24 18:21:49 +0200795 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiang81259682017-03-30 15:11:30 -0700796 -1,
797 false, // ping_only
798 ErrorCode::kSuccess,
799 metrics::CheckResult::kUpdateAvailable,
800 metrics::CheckReaction::kUpdating,
801 metrics::DownloadErrorCode::kUnset,
802 &response,
803 nullptr));
804 EXPECT_TRUE(response.update_exists);
805 EXPECT_EQ(fake_update_response_.version, response.version);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700806 EXPECT_EQ("", response.system_version);
Sen Jiang81259682017-03-30 15:11:30 -0700807 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
808 response.packages[0].payload_urls[0]);
809 EXPECT_EQ(fake_update_response_.codebase + "package2",
810 response.packages[1].payload_urls[0]);
811 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
812 response.packages[2].payload_urls[0]);
813 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
814 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
815 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700816 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700817 ASSERT_EQ(3u, response.packages.size());
818 EXPECT_EQ(string("hash2"), response.packages[1].hash);
819 EXPECT_EQ(222u, response.packages[1].size);
820 EXPECT_EQ(22u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700821 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700822 EXPECT_EQ(string("hash3"), response.packages[2].hash);
823 EXPECT_EQ(333u, response.packages[2].size);
824 EXPECT_EQ(33u, response.packages[2].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700825 EXPECT_EQ(false, response.packages[2].is_delta);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800826}
827
Sen Jiangfe284402018-03-21 14:03:50 -0700828TEST_F(OmahaRequestActionTest, PowerwashTest) {
829 OmahaResponse response;
830 fake_update_response_.powerwash = true;
Amin Hassani3538a882018-05-31 14:11:30 -0700831 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiangfe284402018-03-21 14:03:50 -0700832 -1,
833 false, // ping_only
834 ErrorCode::kSuccess,
835 metrics::CheckResult::kUpdateAvailable,
836 metrics::CheckReaction::kUpdating,
837 metrics::DownloadErrorCode::kUnset,
838 &response,
839 nullptr));
840 EXPECT_TRUE(response.update_exists);
841 EXPECT_TRUE(response.powerwash_required);
842}
843
Alex Deymo14ad88e2016-06-29 12:30:14 -0700844TEST_F(OmahaRequestActionTest, ExtraHeadersSentTest) {
845 const string http_response = "<?xml invalid response";
846 request_params_.set_interactive(true);
847
848 brillo::FakeMessageLoop loop(nullptr);
849 loop.SetAsCurrent();
850
851 MockHttpFetcher* fetcher =
852 new MockHttpFetcher(http_response.data(), http_response.size(), nullptr);
Ben Chan5c02c132017-06-27 07:10:36 -0700853 OmahaRequestAction action(&fake_system_state_, nullptr,
854 base::WrapUnique(fetcher), false);
Alex Deymo14ad88e2016-06-29 12:30:14 -0700855 ActionProcessor processor;
856 processor.EnqueueAction(&action);
857
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700858 loop.PostTask(base::Bind(
859 [](ActionProcessor* processor) { processor->StartProcessing(); },
860 base::Unretained(&processor)));
Alex Deymo14ad88e2016-06-29 12:30:14 -0700861 loop.Run();
862 EXPECT_FALSE(loop.PendingTasks());
863
864 // Check that the headers were set in the fetcher during the action. Note that
865 // we set this request as "interactive".
Sen Jiang42fa45e2018-03-12 11:02:14 -0700866 EXPECT_EQ("fg", fetcher->GetHeader("X-Goog-Update-Interactivity"));
867 EXPECT_EQ(kTestAppId, fetcher->GetHeader("X-Goog-Update-AppId"));
868 EXPECT_NE("", fetcher->GetHeader("X-Goog-Update-Updater"));
Alex Deymo14ad88e2016-06-29 12:30:14 -0700869}
870
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700871TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByConnection) {
Chris Sosa77f79e82014-06-02 18:16:24 -0700872 OmahaResponse response;
873 // Set up a connection manager that doesn't allow a valid update over
874 // the current ethernet connection.
Alex Deymof6ee0162015-07-31 12:35:22 -0700875 MockConnectionManager mock_cm;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700876 fake_system_state_.set_connection_manager(&mock_cm);
877
Alex Deymo30534502015-07-20 15:06:33 -0700878 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
879 .WillRepeatedly(
Ben Chan672c1f52017-10-23 15:41:39 -0700880 DoAll(SetArgPointee<0>(ConnectionType::kEthernet),
881 SetArgPointee<1>(ConnectionTethering::kUnknown),
Alex Deymo30534502015-07-20 15:06:33 -0700882 Return(true)));
Sen Jiang255e22b2016-05-20 16:15:29 -0700883 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kEthernet, _))
884 .WillRepeatedly(Return(false));
Chris Sosa77f79e82014-06-02 18:16:24 -0700885
Marton Hunyady2abda312018-04-24 18:21:49 +0200886 ASSERT_FALSE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
887 -1,
888 false, // ping_only
889 ErrorCode::kOmahaUpdateIgnoredPerPolicy,
890 metrics::CheckResult::kUpdateAvailable,
891 metrics::CheckReaction::kIgnored,
892 metrics::DownloadErrorCode::kUnset,
893 &response,
894 nullptr));
Chris Sosa77f79e82014-06-02 18:16:24 -0700895 EXPECT_FALSE(response.update_exists);
896}
897
Weidong Guo421ff332017-04-17 10:08:38 -0700898TEST_F(OmahaRequestActionTest, ValidUpdateOverCellularAllowedByDevicePolicy) {
899 // This test tests that update over cellular is allowed as device policy
900 // says yes.
901 OmahaResponse response;
902 MockConnectionManager mock_cm;
903
904 fake_system_state_.set_connection_manager(&mock_cm);
905
906 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
907 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
908 SetArgPointee<1>(ConnectionTethering::kUnknown),
909 Return(true)));
910 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
911 .WillRepeatedly(Return(true));
912 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
913 .WillRepeatedly(Return(true));
914
Marton Hunyady2abda312018-04-24 18:21:49 +0200915 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Weidong Guo421ff332017-04-17 10:08:38 -0700916 -1,
917 false, // ping_only
918 ErrorCode::kSuccess,
919 metrics::CheckResult::kUpdateAvailable,
920 metrics::CheckReaction::kUpdating,
921 metrics::DownloadErrorCode::kUnset,
922 &response,
923 nullptr));
924 EXPECT_TRUE(response.update_exists);
925}
926
927TEST_F(OmahaRequestActionTest, ValidUpdateOverCellularBlockedByDevicePolicy) {
928 // This test tests that update over cellular is blocked as device policy
929 // says no.
930 OmahaResponse response;
931 MockConnectionManager mock_cm;
932
933 fake_system_state_.set_connection_manager(&mock_cm);
934
935 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
936 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
937 SetArgPointee<1>(ConnectionTethering::kUnknown),
938 Return(true)));
939 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
940 .WillRepeatedly(Return(true));
941 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
942 .WillRepeatedly(Return(false));
943
Marton Hunyady2abda312018-04-24 18:21:49 +0200944 ASSERT_FALSE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Weidong Guo421ff332017-04-17 10:08:38 -0700945 -1,
946 false, // ping_only
947 ErrorCode::kOmahaUpdateIgnoredPerPolicy,
948 metrics::CheckResult::kUpdateAvailable,
949 metrics::CheckReaction::kIgnored,
950 metrics::DownloadErrorCode::kUnset,
951 &response,
952 nullptr));
953 EXPECT_FALSE(response.update_exists);
954}
955
956TEST_F(OmahaRequestActionTest,
957 ValidUpdateOverCellularAllowedByUserPermissionTrue) {
958 // This test tests that, when device policy is not set, update over cellular
959 // is allowed as permission for update over cellular is set to true.
960 OmahaResponse response;
961 MockConnectionManager mock_cm;
962
963 fake_prefs_.SetBoolean(kPrefsUpdateOverCellularPermission, true);
964 fake_system_state_.set_connection_manager(&mock_cm);
965
966 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
967 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
968 SetArgPointee<1>(ConnectionTethering::kUnknown),
969 Return(true)));
970 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
971 .WillRepeatedly(Return(false));
972 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
973 .WillRepeatedly(Return(true));
974
Marton Hunyady2abda312018-04-24 18:21:49 +0200975 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Weidong Guo421ff332017-04-17 10:08:38 -0700976 -1,
977 false, // ping_only
978 ErrorCode::kSuccess,
979 metrics::CheckResult::kUpdateAvailable,
980 metrics::CheckReaction::kUpdating,
981 metrics::DownloadErrorCode::kUnset,
982 &response,
983 nullptr));
984 EXPECT_TRUE(response.update_exists);
985}
986
987TEST_F(OmahaRequestActionTest,
988 ValidUpdateOverCellularBlockedByUpdateTargetNotMatch) {
989 // This test tests that, when device policy is not set and permission for
990 // update over cellular is set to false or does not exist, update over
991 // cellular is blocked as update target does not match the omaha response.
992 OmahaResponse response;
993 MockConnectionManager mock_cm;
994 // A version different from the version in omaha response.
995 string diff_version = "99.99.99";
996 // A size different from the size in omaha response.
997 int64_t diff_size = 999;
998
999 fake_prefs_.SetString(kPrefsUpdateOverCellularTargetVersion, diff_version);
1000 fake_prefs_.SetInt64(kPrefsUpdateOverCellularTargetSize, diff_size);
1001 // This test tests cellular (3G) being the only connection type being allowed.
1002 fake_system_state_.set_connection_manager(&mock_cm);
1003
1004 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
1005 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
1006 SetArgPointee<1>(ConnectionTethering::kUnknown),
1007 Return(true)));
1008 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
1009 .WillRepeatedly(Return(false));
1010 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
1011 .WillRepeatedly(Return(true));
1012
Marton Hunyady2abda312018-04-24 18:21:49 +02001013 ASSERT_FALSE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Weidong Guo421ff332017-04-17 10:08:38 -07001014 -1,
1015 false, // ping_only
1016 ErrorCode::kOmahaUpdateIgnoredOverCellular,
1017 metrics::CheckResult::kUpdateAvailable,
1018 metrics::CheckReaction::kIgnored,
1019 metrics::DownloadErrorCode::kUnset,
1020 &response,
1021 nullptr));
1022 EXPECT_FALSE(response.update_exists);
1023}
1024
1025TEST_F(OmahaRequestActionTest,
1026 ValidUpdateOverCellularAllowedByUpdateTargetMatch) {
1027 // This test tests that, when device policy is not set and permission for
1028 // update over cellular is set to false or does not exist, update over
1029 // cellular is allowed as update target matches the omaha response.
1030 OmahaResponse response;
1031 MockConnectionManager mock_cm;
1032 // A version same as the version in omaha response.
1033 string new_version = fake_update_response_.version;
1034 // A size same as the size in omaha response.
1035 int64_t new_size = fake_update_response_.size;
1036
1037 fake_prefs_.SetString(kPrefsUpdateOverCellularTargetVersion, new_version);
1038 fake_prefs_.SetInt64(kPrefsUpdateOverCellularTargetSize, new_size);
1039 fake_system_state_.set_connection_manager(&mock_cm);
1040
1041 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
1042 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
1043 SetArgPointee<1>(ConnectionTethering::kUnknown),
1044 Return(true)));
1045 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
1046 .WillRepeatedly(Return(false));
1047 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
1048 .WillRepeatedly(Return(true));
1049
Marton Hunyady2abda312018-04-24 18:21:49 +02001050 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Weidong Guo421ff332017-04-17 10:08:38 -07001051 -1,
1052 false, // ping_only
1053 ErrorCode::kSuccess,
1054 metrics::CheckResult::kUpdateAvailable,
1055 metrics::CheckReaction::kUpdating,
1056 metrics::DownloadErrorCode::kUnset,
1057 &response,
1058 nullptr));
1059 EXPECT_TRUE(response.update_exists);
1060}
1061
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001062TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByRollback) {
Chris Sosa77f79e82014-06-02 18:16:24 -07001063 string rollback_version = "1234.0.0";
1064 OmahaResponse response;
1065
1066 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001067 fake_system_state_.set_payload_state(&mock_payload_state);
1068
Chris Sosa77f79e82014-06-02 18:16:24 -07001069 EXPECT_CALL(mock_payload_state, GetRollbackVersion())
1070 .WillRepeatedly(Return(rollback_version));
1071
Alex Deymo8e18f932015-03-27 16:16:59 -07001072 fake_update_response_.version = rollback_version;
Marton Hunyady2abda312018-04-24 18:21:49 +02001073 ASSERT_FALSE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1074 -1,
1075 false, // ping_only
1076 ErrorCode::kOmahaUpdateIgnoredPerPolicy,
1077 metrics::CheckResult::kUpdateAvailable,
1078 metrics::CheckReaction::kIgnored,
1079 metrics::DownloadErrorCode::kUnset,
1080 &response,
1081 nullptr));
Chris Sosa77f79e82014-06-02 18:16:24 -07001082 EXPECT_FALSE(response.update_exists);
1083}
1084
Marton Hunyadyc2882062018-05-14 17:28:25 +02001085// Verify that update checks called during OOBE will not try to download an
1086// update if the response doesn't include the deadline field.
Kevin Cernekee2494e282016-03-29 18:03:53 -07001087TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBE) {
1088 OmahaResponse response;
Marton Hunyadyc2882062018-05-14 17:28:25 +02001089 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Kevin Cernekee2494e282016-03-29 18:03:53 -07001090
Sen Jiang8cd42342018-01-31 12:06:59 -08001091 // TODO(senj): set better default value for metrics::checkresult in
Tianjie Xu282aa1f2017-09-05 13:42:45 -07001092 // OmahaRequestAction::ActionCompleted.
Marton Hunyady2abda312018-04-24 18:21:49 +02001093 ASSERT_FALSE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Tianjie Xu282aa1f2017-09-05 13:42:45 -07001094 -1,
1095 false, // ping_only
1096 ErrorCode::kNonCriticalUpdateInOOBE,
1097 metrics::CheckResult::kParsingError,
1098 metrics::CheckReaction::kUnset,
1099 metrics::DownloadErrorCode::kUnset,
1100 &response,
1101 nullptr));
Kevin Cernekee2494e282016-03-29 18:03:53 -07001102 EXPECT_FALSE(response.update_exists);
Marton Hunyadyc2882062018-05-14 17:28:25 +02001103}
Kevin Cernekee2494e282016-03-29 18:03:53 -07001104
Marton Hunyadyc2882062018-05-14 17:28:25 +02001105// Verify that the IsOOBEComplete() value is ignored when the OOBE flow is not
1106// enabled.
1107TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBEDisabled) {
1108 OmahaResponse response;
1109 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Alex Deymo46a9aae2016-05-04 20:20:11 -07001110 fake_system_state_.fake_hardware()->SetIsOOBEEnabled(false);
Alex Deymo46a9aae2016-05-04 20:20:11 -07001111
Marton Hunyady2abda312018-04-24 18:21:49 +02001112 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1113 -1,
1114 false, // ping_only
1115 ErrorCode::kSuccess,
1116 metrics::CheckResult::kUpdateAvailable,
1117 metrics::CheckReaction::kUpdating,
1118 metrics::DownloadErrorCode::kUnset,
1119 &response,
1120 nullptr));
Kevin Cernekee2494e282016-03-29 18:03:53 -07001121 EXPECT_TRUE(response.update_exists);
1122}
1123
Marton Hunyadyc2882062018-05-14 17:28:25 +02001124// Verify that update checks called during OOBE will still try to download an
1125// update if the response includes the deadline field.
1126TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBEDeadlineSet) {
1127 OmahaResponse response;
1128 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1129 fake_update_response_.deadline = "20101020";
1130
1131 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1132 -1,
1133 false, // ping_only
1134 ErrorCode::kSuccess,
1135 metrics::CheckResult::kUpdateAvailable,
1136 metrics::CheckReaction::kUpdating,
1137 metrics::DownloadErrorCode::kUnset,
1138 &response,
1139 nullptr));
1140 EXPECT_TRUE(response.update_exists);
1141}
1142
1143// Verify that update checks called during OOBE will not try to download an
1144// update if a rollback happened, even when the response includes the deadline
1145// field.
1146TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBERollback) {
1147 OmahaResponse response;
1148 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1149 fake_update_response_.deadline = "20101020";
1150 EXPECT_CALL(*(fake_system_state_.mock_payload_state()), GetRollbackHappened())
1151 .WillOnce(Return(true));
1152
1153 ASSERT_FALSE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1154 -1,
1155 false, // ping_only
1156 ErrorCode::kNonCriticalUpdateInOOBE,
1157 metrics::CheckResult::kParsingError,
1158 metrics::CheckReaction::kUnset,
1159 metrics::DownloadErrorCode::kUnset,
1160 &response,
1161 nullptr));
1162 EXPECT_FALSE(response.update_exists);
1163}
1164
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001165TEST_F(OmahaRequestActionTest, WallClockBasedWaitAloneCausesScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001166 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001167 request_params_.set_wall_clock_based_wait_enabled(true);
1168 request_params_.set_update_check_count_wait_enabled(false);
1169 request_params_.set_waiting_period(TimeDelta::FromDays(2));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001170
Marton Hunyady2abda312018-04-24 18:21:49 +02001171 ASSERT_FALSE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1172 -1,
1173 false, // ping_only
1174 ErrorCode::kOmahaUpdateDeferredPerPolicy,
1175 metrics::CheckResult::kUpdateAvailable,
1176 metrics::CheckReaction::kDeferring,
1177 metrics::DownloadErrorCode::kUnset,
1178 &response,
1179 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001180 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -07001181
1182 // Verify if we are interactive check we don't defer.
Marton Hunyady2abda312018-04-24 18:21:49 +02001183 request_params_.set_interactive(true);
1184 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1185 -1,
1186 false, // ping_only
1187 ErrorCode::kSuccess,
1188 metrics::CheckResult::kUpdateAvailable,
1189 metrics::CheckReaction::kUpdating,
1190 metrics::DownloadErrorCode::kUnset,
1191 &response,
1192 nullptr));
Chris Sosa968d0572013-08-23 14:46:02 -07001193 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001194}
1195
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001196TEST_F(OmahaRequestActionTest, NoWallClockBasedWaitCausesNoScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001197 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001198 request_params_.set_wall_clock_based_wait_enabled(false);
1199 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1200 request_params_.set_update_check_count_wait_enabled(true);
1201 request_params_.set_min_update_checks_needed(1);
1202 request_params_.set_max_update_checks_allowed(8);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001203
Marton Hunyady2abda312018-04-24 18:21:49 +02001204 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1205 -1,
1206 false, // ping_only
1207 ErrorCode::kSuccess,
1208 metrics::CheckResult::kUpdateAvailable,
1209 metrics::CheckReaction::kUpdating,
1210 metrics::DownloadErrorCode::kUnset,
1211 &response,
1212 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001213 EXPECT_TRUE(response.update_exists);
1214}
1215
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001216TEST_F(OmahaRequestActionTest, ZeroMaxDaysToScatterCausesNoScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001217 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001218 request_params_.set_wall_clock_based_wait_enabled(true);
1219 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1220 request_params_.set_update_check_count_wait_enabled(true);
1221 request_params_.set_min_update_checks_needed(1);
1222 request_params_.set_max_update_checks_allowed(8);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001223
Alex Deymo8e18f932015-03-27 16:16:59 -07001224 fake_update_response_.max_days_to_scatter = "0";
Marton Hunyady2abda312018-04-24 18:21:49 +02001225 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1226 -1,
1227 false, // ping_only
1228 ErrorCode::kSuccess,
1229 metrics::CheckResult::kUpdateAvailable,
1230 metrics::CheckReaction::kUpdating,
1231 metrics::DownloadErrorCode::kUnset,
1232 &response,
1233 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001234 EXPECT_TRUE(response.update_exists);
1235}
1236
1237
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001238TEST_F(OmahaRequestActionTest, ZeroUpdateCheckCountCausesNoScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001239 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001240 request_params_.set_wall_clock_based_wait_enabled(true);
1241 request_params_.set_waiting_period(TimeDelta());
1242 request_params_.set_update_check_count_wait_enabled(true);
1243 request_params_.set_min_update_checks_needed(0);
1244 request_params_.set_max_update_checks_allowed(0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001245
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001246 ASSERT_TRUE(TestUpdateCheck(
Alex Deymo8e18f932015-03-27 16:16:59 -07001247 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001248 -1,
1249 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001250 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001251 metrics::CheckResult::kUpdateAvailable,
1252 metrics::CheckReaction::kUpdating,
1253 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001254 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001255 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001256
Ben Chan9abb7632014-08-07 00:10:53 -07001257 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001258 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001259 ASSERT_EQ(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001260 EXPECT_TRUE(response.update_exists);
1261}
1262
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001263TEST_F(OmahaRequestActionTest, NonZeroUpdateCheckCountCausesScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001264 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001265 request_params_.set_wall_clock_based_wait_enabled(true);
1266 request_params_.set_waiting_period(TimeDelta());
1267 request_params_.set_update_check_count_wait_enabled(true);
1268 request_params_.set_min_update_checks_needed(1);
1269 request_params_.set_max_update_checks_allowed(8);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001270
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001271 ASSERT_FALSE(TestUpdateCheck(
Alex Deymo8e18f932015-03-27 16:16:59 -07001272 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001273 -1,
1274 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001275 ErrorCode::kOmahaUpdateDeferredPerPolicy,
David Zeuthen33bae492014-02-25 16:16:18 -08001276 metrics::CheckResult::kUpdateAvailable,
1277 metrics::CheckReaction::kDeferring,
1278 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001279 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001280 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001281
Ben Chan9abb7632014-08-07 00:10:53 -07001282 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001283 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001284 ASSERT_GT(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001285 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -07001286
1287 // Verify if we are interactive check we don't defer.
Marton Hunyady2abda312018-04-24 18:21:49 +02001288 request_params_.set_interactive(true);
1289 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1290 -1,
1291 false, // ping_only
1292 ErrorCode::kSuccess,
1293 metrics::CheckResult::kUpdateAvailable,
1294 metrics::CheckReaction::kUpdating,
1295 metrics::DownloadErrorCode::kUnset,
1296 &response,
1297 nullptr));
Chris Sosa968d0572013-08-23 14:46:02 -07001298 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001299}
1300
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001301TEST_F(OmahaRequestActionTest, ExistingUpdateCheckCountCausesScattering) {
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001302 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001303 request_params_.set_wall_clock_based_wait_enabled(true);
1304 request_params_.set_waiting_period(TimeDelta());
1305 request_params_.set_update_check_count_wait_enabled(true);
1306 request_params_.set_min_update_checks_needed(1);
1307 request_params_.set_max_update_checks_allowed(8);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001308
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001309 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsUpdateCheckCount, 5));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001310
1311 ASSERT_FALSE(TestUpdateCheck(
Alex Deymo8e18f932015-03-27 16:16:59 -07001312 fake_update_response_.GetUpdateResponse(),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001313 -1,
1314 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001315 ErrorCode::kOmahaUpdateDeferredPerPolicy,
David Zeuthen33bae492014-02-25 16:16:18 -08001316 metrics::CheckResult::kUpdateAvailable,
1317 metrics::CheckReaction::kDeferring,
1318 metrics::DownloadErrorCode::kUnset,
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001319 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001320 nullptr));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001321
Ben Chan9abb7632014-08-07 00:10:53 -07001322 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001323 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001324 // count remains the same, as the decrementing happens in update_attempter
1325 // which this test doesn't exercise.
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001326 ASSERT_EQ(count, 5);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001327 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -07001328
1329 // Verify if we are interactive check we don't defer.
Marton Hunyady2abda312018-04-24 18:21:49 +02001330 request_params_.set_interactive(true);
1331 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1332 -1,
1333 false, // ping_only
1334 ErrorCode::kSuccess,
1335 metrics::CheckResult::kUpdateAvailable,
1336 metrics::CheckReaction::kUpdating,
1337 metrics::DownloadErrorCode::kUnset,
1338 &response,
1339 nullptr));
Chris Sosa968d0572013-08-23 14:46:02 -07001340 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001341}
Jay Srinivasan0a708742012-03-20 11:26:12 -07001342
Alex Deymo8e18f932015-03-27 16:16:59 -07001343TEST_F(OmahaRequestActionTest, CohortsArePersisted) {
1344 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -07001345 fake_update_response_.include_cohorts = true;
1346 fake_update_response_.cohort = "s/154454/8479665";
1347 fake_update_response_.cohorthint = "please-put-me-on-beta";
1348 fake_update_response_.cohortname = "stable";
1349
Marton Hunyady2abda312018-04-24 18:21:49 +02001350 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Alex Deymo8e18f932015-03-27 16:16:59 -07001351 -1,
1352 false, // ping_only
1353 ErrorCode::kSuccess,
1354 metrics::CheckResult::kUpdateAvailable,
1355 metrics::CheckReaction::kUpdating,
1356 metrics::DownloadErrorCode::kUnset,
1357 &response,
1358 nullptr));
1359
1360 string value;
1361 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1362 EXPECT_EQ(fake_update_response_.cohort, value);
1363
1364 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1365 EXPECT_EQ(fake_update_response_.cohorthint, value);
1366
1367 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1368 EXPECT_EQ(fake_update_response_.cohortname, value);
1369}
1370
1371TEST_F(OmahaRequestActionTest, CohortsAreUpdated) {
1372 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -07001373 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
1374 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortHint, "old_hint"));
1375 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortName, "old_name"));
1376 fake_update_response_.include_cohorts = true;
1377 fake_update_response_.cohort = "s/154454/8479665";
1378 fake_update_response_.cohorthint = "please-put-me-on-beta";
1379 fake_update_response_.cohortname = "";
1380
Marton Hunyady2abda312018-04-24 18:21:49 +02001381 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Alex Deymo8e18f932015-03-27 16:16:59 -07001382 -1,
1383 false, // ping_only
1384 ErrorCode::kSuccess,
1385 metrics::CheckResult::kUpdateAvailable,
1386 metrics::CheckReaction::kUpdating,
1387 metrics::DownloadErrorCode::kUnset,
1388 &response,
1389 nullptr));
1390
1391 string value;
1392 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1393 EXPECT_EQ(fake_update_response_.cohort, value);
1394
1395 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1396 EXPECT_EQ(fake_update_response_.cohorthint, value);
1397
1398 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1399}
1400
1401TEST_F(OmahaRequestActionTest, CohortsAreNotModifiedWhenMissing) {
1402 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -07001403 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
1404
Marton Hunyady2abda312018-04-24 18:21:49 +02001405 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Alex Deymo8e18f932015-03-27 16:16:59 -07001406 -1,
1407 false, // ping_only
1408 ErrorCode::kSuccess,
1409 metrics::CheckResult::kUpdateAvailable,
1410 metrics::CheckReaction::kUpdating,
1411 metrics::DownloadErrorCode::kUnset,
1412 &response,
1413 nullptr));
1414
1415 string value;
1416 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1417 EXPECT_EQ("old_value", value);
1418
1419 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1420 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1421}
1422
Alex Deymo00d79ac2015-06-29 15:41:49 -07001423TEST_F(OmahaRequestActionTest, CohortsArePersistedWhenNoUpdate) {
1424 OmahaResponse response;
Alex Deymo00d79ac2015-06-29 15:41:49 -07001425 fake_update_response_.include_cohorts = true;
1426 fake_update_response_.cohort = "s/154454/8479665";
1427 fake_update_response_.cohorthint = "please-put-me-on-beta";
1428 fake_update_response_.cohortname = "stable";
1429
Marton Hunyady2abda312018-04-24 18:21:49 +02001430 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
Alex Deymo00d79ac2015-06-29 15:41:49 -07001431 -1,
1432 false, // ping_only
1433 ErrorCode::kSuccess,
1434 metrics::CheckResult::kNoUpdateAvailable,
1435 metrics::CheckReaction::kUnset,
1436 metrics::DownloadErrorCode::kUnset,
1437 &response,
1438 nullptr));
1439
1440 string value;
1441 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1442 EXPECT_EQ(fake_update_response_.cohort, value);
1443
1444 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1445 EXPECT_EQ(fake_update_response_.cohorthint, value);
1446
1447 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1448 EXPECT_EQ(fake_update_response_.cohortname, value);
1449}
1450
Sen Jiangb1e063a2017-09-15 17:44:31 -07001451TEST_F(OmahaRequestActionTest, MultiAppCohortTest) {
1452 OmahaResponse response;
Sen Jiangb1e063a2017-09-15 17:44:31 -07001453 fake_update_response_.multi_app = true;
1454 fake_update_response_.include_cohorts = true;
1455 fake_update_response_.cohort = "s/154454/8479665";
1456 fake_update_response_.cohorthint = "please-put-me-on-beta";
1457 fake_update_response_.cohortname = "stable";
1458
Marton Hunyady2abda312018-04-24 18:21:49 +02001459 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiangb1e063a2017-09-15 17:44:31 -07001460 -1,
1461 false, // ping_only
1462 ErrorCode::kSuccess,
1463 metrics::CheckResult::kUpdateAvailable,
1464 metrics::CheckReaction::kUpdating,
1465 metrics::DownloadErrorCode::kUnset,
1466 &response,
1467 nullptr));
1468
1469 string value;
1470 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1471 EXPECT_EQ(fake_update_response_.cohort, value);
1472
1473 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1474 EXPECT_EQ(fake_update_response_.cohorthint, value);
1475
1476 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1477 EXPECT_EQ(fake_update_response_.cohortname, value);
1478}
1479
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001480TEST_F(OmahaRequestActionTest, NoOutputPipeTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001481 const string http_response(fake_update_response_.GetNoUpdateResponse());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001482
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001483 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -07001484 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001485
Ben Chan5c02c132017-06-27 07:10:36 -07001486 OmahaRequestAction action(
1487 &fake_system_state_,
1488 nullptr,
Ben Chanab5a0af2017-10-12 14:57:50 -07001489 std::make_unique<MockHttpFetcher>(http_response.data(),
Ben Chan5c02c132017-06-27 07:10:36 -07001490 http_response.size(),
1491 nullptr),
1492 false);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001493 OmahaRequestActionTestProcessorDelegate delegate;
Darin Petkov6a5b3222010-07-13 14:55:28 -07001494 ActionProcessor processor;
1495 processor.set_delegate(&delegate);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001496 processor.EnqueueAction(&action);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001497
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -07001498 loop.PostTask(base::Bind(
1499 [](ActionProcessor* processor) { processor->StartProcessing(); },
1500 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -07001501 loop.Run();
1502 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001503 EXPECT_FALSE(processor.IsRunning());
1504}
1505
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001506TEST_F(OmahaRequestActionTest, InvalidXmlTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001507 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001508 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
1509 -1,
1510 false, // ping_only
1511 ErrorCode::kOmahaRequestXMLParseError,
1512 metrics::CheckResult::kParsingError,
1513 metrics::CheckReaction::kUnset,
1514 metrics::DownloadErrorCode::kUnset,
1515 &response,
1516 nullptr));
Darin Petkovedc522e2010-11-05 09:35:17 -07001517 EXPECT_FALSE(response.update_exists);
1518}
1519
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001520TEST_F(OmahaRequestActionTest, EmptyResponseTest) {
Darin Petkovedc522e2010-11-05 09:35:17 -07001521 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001522 ASSERT_FALSE(TestUpdateCheck("",
1523 -1,
1524 false, // ping_only
1525 ErrorCode::kOmahaRequestEmptyResponseError,
1526 metrics::CheckResult::kParsingError,
1527 metrics::CheckReaction::kUnset,
1528 metrics::DownloadErrorCode::kUnset,
1529 &response,
1530 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001531 EXPECT_FALSE(response.update_exists);
1532}
1533
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001534TEST_F(OmahaRequestActionTest, MissingStatusTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001535 OmahaResponse response;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001536 ASSERT_FALSE(TestUpdateCheck(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001537 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1538 "<daystart elapsed_seconds=\"100\"/>"
1539 "<app appid=\"foo\" status=\"ok\">"
1540 "<ping status=\"ok\"/>"
1541 "<updatecheck/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001542 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001543 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001544 ErrorCode::kOmahaResponseInvalid,
David Zeuthen33bae492014-02-25 16:16:18 -08001545 metrics::CheckResult::kParsingError,
1546 metrics::CheckReaction::kUnset,
1547 metrics::DownloadErrorCode::kUnset,
Darin Petkov6a5b3222010-07-13 14:55:28 -07001548 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001549 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001550 EXPECT_FALSE(response.update_exists);
1551}
1552
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001553TEST_F(OmahaRequestActionTest, InvalidStatusTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001554 OmahaResponse response;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001555 ASSERT_FALSE(TestUpdateCheck(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001556 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1557 "<daystart elapsed_seconds=\"100\"/>"
1558 "<app appid=\"foo\" status=\"ok\">"
1559 "<ping status=\"ok\"/>"
1560 "<updatecheck status=\"InvalidStatusTest\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001561 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001562 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001563 ErrorCode::kOmahaResponseInvalid,
David Zeuthen33bae492014-02-25 16:16:18 -08001564 metrics::CheckResult::kParsingError,
1565 metrics::CheckReaction::kUnset,
1566 metrics::DownloadErrorCode::kUnset,
Darin Petkov6a5b3222010-07-13 14:55:28 -07001567 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001568 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001569 EXPECT_FALSE(response.update_exists);
1570}
1571
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001572TEST_F(OmahaRequestActionTest, MissingNodesetTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001573 OmahaResponse response;
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001574 ASSERT_FALSE(TestUpdateCheck(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001575 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1576 "<daystart elapsed_seconds=\"100\"/>"
1577 "<app appid=\"foo\" status=\"ok\">"
1578 "<ping status=\"ok\"/>"
1579 "</app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001580 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001581 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001582 ErrorCode::kOmahaResponseInvalid,
David Zeuthen33bae492014-02-25 16:16:18 -08001583 metrics::CheckResult::kParsingError,
1584 metrics::CheckReaction::kUnset,
1585 metrics::DownloadErrorCode::kUnset,
Darin Petkov6a5b3222010-07-13 14:55:28 -07001586 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001587 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001588 EXPECT_FALSE(response.update_exists);
1589}
1590
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001591TEST_F(OmahaRequestActionTest, MissingFieldTest) {
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001592 string input_response =
1593 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1594 "<daystart elapsed_seconds=\"100\"/>"
Aaron Wood7dcdedf2017-09-06 17:17:41 -07001595 // the appid needs to match that in the request params
1596 "<app appid=\"" +
1597 fake_update_response_.app_id +
1598 "\" status=\"ok\">"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001599 "<updatecheck status=\"ok\">"
1600 "<urls><url codebase=\"http://missing/field/test/\"/></urls>"
Chris Sosa3b748432013-06-20 16:42:59 -07001601 "<manifest version=\"10.2.3.4\">"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001602 "<packages><package hash=\"not-used\" name=\"f\" "
Sen Jiang2703ef42017-03-16 13:36:21 -07001603 "size=\"587\" hash_sha256=\"lkq34j5345\"/></packages>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001604 "<actions><action event=\"postinstall\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001605 "ChromeOSVersion=\"10.2.3.4\" "
1606 "Prompt=\"false\" "
1607 "IsDelta=\"true\" "
Jay Srinivasand671e972013-01-11 17:17:19 -08001608 "IsDeltaPayload=\"false\" "
Sen Jiang2703ef42017-03-16 13:36:21 -07001609 "sha256=\"not-used\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001610 "needsadmin=\"true\" "
1611 "/></actions></manifest></updatecheck></app></response>";
1612 LOG(INFO) << "Input Response = " << input_response;
1613
Darin Petkov6a5b3222010-07-13 14:55:28 -07001614 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001615 ASSERT_TRUE(TestUpdateCheck(input_response,
Darin Petkovedc522e2010-11-05 09:35:17 -07001616 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001617 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001618 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08001619 metrics::CheckResult::kUpdateAvailable,
1620 metrics::CheckReaction::kUpdating,
1621 metrics::DownloadErrorCode::kUnset,
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001622 &response,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001623 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001624 EXPECT_TRUE(response.update_exists);
Chris Sosa3b748432013-06-20 16:42:59 -07001625 EXPECT_EQ("10.2.3.4", response.version);
Sen Jiang0affc2c2017-02-10 15:55:05 -08001626 EXPECT_EQ("http://missing/field/test/f",
1627 response.packages[0].payload_urls[0]);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001628 EXPECT_EQ("", response.more_info_url);
Sen Jiang0affc2c2017-02-10 15:55:05 -08001629 EXPECT_EQ("lkq34j5345", response.packages[0].hash);
1630 EXPECT_EQ(587u, response.packages[0].size);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001631 EXPECT_FALSE(response.prompt);
Darin Petkov6c118642010-10-21 12:06:30 -07001632 EXPECT_TRUE(response.deadline.empty());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001633}
1634
1635namespace {
1636class TerminateEarlyTestProcessorDelegate : public ActionProcessorDelegate {
1637 public:
1638 void ProcessingStopped(const ActionProcessor* processor) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001639 brillo::MessageLoop::current()->BreakLoop();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001640 }
Darin Petkov6a5b3222010-07-13 14:55:28 -07001641};
1642
Alex Deymo60ca1a72015-06-18 18:19:15 -07001643void TerminateTransferTestStarter(ActionProcessor* processor) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001644 processor->StartProcessing();
1645 CHECK(processor->IsRunning());
1646 processor->StopProcessing();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001647}
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001648} // namespace
Darin Petkov6a5b3222010-07-13 14:55:28 -07001649
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001650TEST_F(OmahaRequestActionTest, TerminateTransferTest) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001651 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -07001652 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001653
Alex Deymo60ca1a72015-06-18 18:19:15 -07001654 string http_response("doesn't matter");
Ben Chan5c02c132017-06-27 07:10:36 -07001655 OmahaRequestAction action(
1656 &fake_system_state_,
1657 nullptr,
Ben Chanab5a0af2017-10-12 14:57:50 -07001658 std::make_unique<MockHttpFetcher>(http_response.data(),
Ben Chan5c02c132017-06-27 07:10:36 -07001659 http_response.size(),
1660 nullptr),
1661 false);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001662 TerminateEarlyTestProcessorDelegate delegate;
Darin Petkov6a5b3222010-07-13 14:55:28 -07001663 ActionProcessor processor;
1664 processor.set_delegate(&delegate);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001665 processor.EnqueueAction(&action);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001666
Alex Deymo60ca1a72015-06-18 18:19:15 -07001667 loop.PostTask(base::Bind(&TerminateTransferTestStarter, &processor));
1668 loop.Run();
1669 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001670}
1671
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001672TEST_F(OmahaRequestActionTest, XmlEncodeTest) {
Alex Deymob0d74eb2015-03-30 17:59:17 -07001673 string output;
1674 EXPECT_TRUE(XmlEncode("ab", &output));
1675 EXPECT_EQ("ab", output);
1676 EXPECT_TRUE(XmlEncode("a<b", &output));
1677 EXPECT_EQ("a&lt;b", output);
Alex Deymocc457852015-06-18 18:35:50 -07001678 EXPECT_TRUE(XmlEncode("<&>\"\'\\", &output));
1679 EXPECT_EQ("&lt;&amp;&gt;&quot;&apos;\\", output);
Alex Deymob0d74eb2015-03-30 17:59:17 -07001680 EXPECT_TRUE(XmlEncode("&lt;&amp;&gt;", &output));
1681 EXPECT_EQ("&amp;lt;&amp;amp;&amp;gt;", output);
Alex Deymocc457852015-06-18 18:35:50 -07001682 // Check that unterminated UTF-8 strings are handled properly.
Alex Deymob0d74eb2015-03-30 17:59:17 -07001683 EXPECT_FALSE(XmlEncode("\xc2", &output));
1684 // Fail with invalid ASCII-7 chars.
1685 EXPECT_FALSE(XmlEncode("This is an 'n' with a tilde: \xc3\xb1", &output));
1686}
Darin Petkov6a5b3222010-07-13 14:55:28 -07001687
Alex Deymob0d74eb2015-03-30 17:59:17 -07001688TEST_F(OmahaRequestActionTest, XmlEncodeWithDefaultTest) {
1689 EXPECT_EQ("&lt;&amp;&gt;", XmlEncodeWithDefault("<&>", "something else"));
1690 EXPECT_EQ("<not escaped>", XmlEncodeWithDefault("\xc2", "<not escaped>"));
1691}
1692
1693TEST_F(OmahaRequestActionTest, XmlEncodeIsUsedForParams) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001694 brillo::Blob post_data;
Darin Petkov6a5b3222010-07-13 14:55:28 -07001695
1696 // Make sure XML Encode is being called on the params
Marton Hunyady2abda312018-04-24 18:21:49 +02001697 request_params_.set_os_sp("testtheservice_pack>");
1698 request_params_.set_os_board("x86 generic<id");
1699 request_params_.set_current_channel("unittest_track&lt;");
1700 request_params_.set_target_channel("unittest_track&lt;");
1701 request_params_.set_hwid("<OEM MODEL>");
Alex Deymo8e18f932015-03-27 16:16:59 -07001702 fake_prefs_.SetString(kPrefsOmahaCohort, "evil\nstring");
1703 fake_prefs_.SetString(kPrefsOmahaCohortHint, "evil&string\\");
1704 fake_prefs_.SetString(kPrefsOmahaCohortName,
Alex Vakulenko0103c362016-01-20 07:56:15 -08001705 base::JoinString(
1706 vector<string>(100, "My spoon is too big."), " "));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001707 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02001708 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
1709 -1,
1710 false, // ping_only
1711 ErrorCode::kOmahaRequestXMLParseError,
1712 metrics::CheckResult::kParsingError,
1713 metrics::CheckReaction::kUnset,
1714 metrics::DownloadErrorCode::kUnset,
1715 &response,
1716 &post_data));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001717 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001718 string post_str(post_data.begin(), post_data.end());
Alex Deymo8e18f932015-03-27 16:16:59 -07001719 EXPECT_NE(string::npos, post_str.find("testtheservice_pack&gt;"));
1720 EXPECT_EQ(string::npos, post_str.find("testtheservice_pack>"));
1721 EXPECT_NE(string::npos, post_str.find("x86 generic&lt;id"));
1722 EXPECT_EQ(string::npos, post_str.find("x86 generic<id"));
1723 EXPECT_NE(string::npos, post_str.find("unittest_track&amp;lt;"));
1724 EXPECT_EQ(string::npos, post_str.find("unittest_track&lt;"));
1725 EXPECT_NE(string::npos, post_str.find("&lt;OEM MODEL&gt;"));
1726 EXPECT_EQ(string::npos, post_str.find("<OEM MODEL>"));
1727 EXPECT_NE(string::npos, post_str.find("cohort=\"evil\nstring\""));
1728 EXPECT_EQ(string::npos, post_str.find("cohorthint=\"evil&string\\\""));
1729 EXPECT_NE(string::npos, post_str.find("cohorthint=\"evil&amp;string\\\""));
1730 // Values from Prefs that are too big are removed from the XML instead of
1731 // encoded.
1732 EXPECT_EQ(string::npos, post_str.find("cohortname="));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001733}
1734
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001735TEST_F(OmahaRequestActionTest, XmlDecodeTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001736 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -07001737 fake_update_response_.deadline = "&lt;20110101";
1738 fake_update_response_.more_info_url = "testthe&lt;url";
1739 fake_update_response_.codebase = "testthe&amp;codebase/";
Marton Hunyady2abda312018-04-24 18:21:49 +02001740 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1741 -1,
1742 false, // ping_only
1743 ErrorCode::kSuccess,
1744 metrics::CheckResult::kUpdateAvailable,
1745 metrics::CheckReaction::kUpdating,
1746 metrics::DownloadErrorCode::kUnset,
1747 &response,
1748 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001749
Sen Jiang0affc2c2017-02-10 15:55:05 -08001750 EXPECT_EQ("testthe<url", response.more_info_url);
1751 EXPECT_EQ("testthe&codebase/file.signed",
1752 response.packages[0].payload_urls[0]);
1753 EXPECT_EQ("<20110101", response.deadline);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001754}
1755
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001756TEST_F(OmahaRequestActionTest, ParseIntTest) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001757 OmahaResponse response;
Alex Deymo8e18f932015-03-27 16:16:59 -07001758 // overflows int32_t:
Sen Jiang0affc2c2017-02-10 15:55:05 -08001759 fake_update_response_.size = 123123123123123ull;
Marton Hunyady2abda312018-04-24 18:21:49 +02001760 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
1761 -1,
1762 false, // ping_only
1763 ErrorCode::kSuccess,
1764 metrics::CheckResult::kUpdateAvailable,
1765 metrics::CheckReaction::kUpdating,
1766 metrics::DownloadErrorCode::kUnset,
1767 &response,
1768 nullptr));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001769
Sen Jiang0affc2c2017-02-10 15:55:05 -08001770 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001771}
1772
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001773TEST_F(OmahaRequestActionTest, FormatUpdateCheckOutputTest) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001774 brillo::Blob post_data;
Alex Deymo8427b4a2014-11-05 14:00:32 -08001775 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001776 fake_system_state_.set_prefs(&prefs);
1777
Darin Petkov95508da2011-01-05 12:42:29 -08001778 EXPECT_CALL(prefs, GetString(kPrefsPreviousVersion, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001779 .WillOnce(DoAll(SetArgPointee<1>(string("")), Return(true)));
Alex Deymoefb9d832015-11-02 18:39:02 -08001780 // An existing but empty previous version means that we didn't reboot to a new
1781 // update, therefore, no need to update the previous version.
1782 EXPECT_CALL(prefs, SetString(kPrefsPreviousVersion, _)).Times(0);
Marton Hunyady2abda312018-04-24 18:21:49 +02001783 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001784 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001785 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001786 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001787 metrics::CheckResult::kParsingError,
1788 metrics::CheckReaction::kUnset,
1789 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001790 nullptr, // response
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001791 &post_data));
1792 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001793 string post_str(post_data.begin(), post_data.end());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001794 EXPECT_NE(
1795 post_str.find(" <ping active=\"1\" a=\"-1\" r=\"-1\"></ping>\n"
1796 " <updatecheck></updatecheck>\n"),
Jay Srinivasan0a708742012-03-20 11:26:12 -07001797 string::npos);
Darin Petkovfbb40092010-07-29 17:05:50 -07001798 EXPECT_NE(post_str.find("hardware_class=\"OEM MODEL 09235 7471\""),
1799 string::npos);
Chris Sosac1972482013-04-30 22:31:10 -07001800 EXPECT_NE(post_str.find("fw_version=\"ChromeOSFirmware.1.0\""),
1801 string::npos);
1802 EXPECT_NE(post_str.find("ec_version=\"0X0A1\""),
1803 string::npos);
Alex Deymoefb9d832015-11-02 18:39:02 -08001804 // No <event> tag should be sent if we didn't reboot to an update.
1805 EXPECT_EQ(post_str.find("<event"), string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001806}
1807
Jay Srinivasan0a708742012-03-20 11:26:12 -07001808
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001809TEST_F(OmahaRequestActionTest, FormatSuccessEventOutputTest) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001810 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02001811 TestEvent(new OmahaEvent(OmahaEvent::kTypeUpdateDownloadStarted),
Darin Petkove17f86b2010-07-20 09:12:01 -07001812 "invalid xml>",
1813 &post_data);
1814 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001815 string post_str(post_data.begin(), post_data.end());
Alex Vakulenko75039d72014-03-25 12:36:28 -07001816 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001817 " <event eventtype=\"%d\" eventresult=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001818 OmahaEvent::kTypeUpdateDownloadStarted,
1819 OmahaEvent::kResultSuccess);
1820 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001821 EXPECT_EQ(post_str.find("ping"), string::npos);
1822 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkove17f86b2010-07-20 09:12:01 -07001823}
1824
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001825TEST_F(OmahaRequestActionTest, FormatErrorEventOutputTest) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001826 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02001827 TestEvent(new OmahaEvent(OmahaEvent::kTypeDownloadComplete,
Darin Petkove17f86b2010-07-20 09:12:01 -07001828 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001829 ErrorCode::kError),
Darin Petkove17f86b2010-07-20 09:12:01 -07001830 "invalid xml>",
1831 &post_data);
1832 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001833 string post_str(post_data.begin(), post_data.end());
Alex Vakulenko75039d72014-03-25 12:36:28 -07001834 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001835 " <event eventtype=\"%d\" eventresult=\"%d\" "
1836 "errorcode=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001837 OmahaEvent::kTypeDownloadComplete,
1838 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001839 static_cast<int>(ErrorCode::kError));
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001840 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001841 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001842}
1843
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001844TEST_F(OmahaRequestActionTest, IsEventTest) {
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001845 string http_response("doesn't matter");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001846 OmahaRequestAction update_check_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001847 &fake_system_state_,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001848 nullptr,
Ben Chanab5a0af2017-10-12 14:57:50 -07001849 std::make_unique<MockHttpFetcher>(http_response.data(),
Ben Chan5c02c132017-06-27 07:10:36 -07001850 http_response.size(),
1851 nullptr),
Thieu Le116fda32011-04-19 11:01:54 -07001852 false);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001853 EXPECT_FALSE(update_check_action.IsEvent());
1854
1855 OmahaRequestAction event_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001856 &fake_system_state_,
Darin Petkove17f86b2010-07-20 09:12:01 -07001857 new OmahaEvent(OmahaEvent::kTypeUpdateComplete),
Ben Chanab5a0af2017-10-12 14:57:50 -07001858 std::make_unique<MockHttpFetcher>(http_response.data(),
Ben Chan5c02c132017-06-27 07:10:36 -07001859 http_response.size(),
1860 nullptr),
Thieu Le116fda32011-04-19 11:01:54 -07001861 false);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001862 EXPECT_TRUE(event_action.IsEvent());
1863}
1864
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001865TEST_F(OmahaRequestActionTest, FormatDeltaOkayOutputTest) {
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001866 for (int i = 0; i < 2; i++) {
1867 bool delta_okay = i == 1;
1868 const char* delta_okay_str = delta_okay ? "true" : "false";
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001869 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02001870
1871 request_params_.set_delta_okay(delta_okay);
1872
1873 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
Darin Petkovedc522e2010-11-05 09:35:17 -07001874 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07001875 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001876 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001877 metrics::CheckResult::kParsingError,
1878 metrics::CheckReaction::kUnset,
1879 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001880 nullptr,
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001881 &post_data));
1882 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001883 string post_str(post_data.begin(), post_data.end());
Alex Vakulenko75039d72014-03-25 12:36:28 -07001884 EXPECT_NE(post_str.find(base::StringPrintf(" delta_okay=\"%s\"",
1885 delta_okay_str)),
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001886 string::npos)
1887 << "i = " << i;
1888 }
1889}
1890
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001891TEST_F(OmahaRequestActionTest, FormatInteractiveOutputTest) {
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001892 for (int i = 0; i < 2; i++) {
1893 bool interactive = i == 1;
Gilad Arnold8a659d82013-01-24 11:26:00 -08001894 const char* interactive_str = interactive ? "ondemandupdate" : "scheduler";
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001895 brillo::Blob post_data;
Gilad Arnold5bb4c902014-04-10 12:32:13 -07001896 FakeSystemState fake_system_state;
Marton Hunyady2abda312018-04-24 18:21:49 +02001897
1898 request_params_.set_interactive(interactive);
1899
1900 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001901 -1,
1902 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001903 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08001904 metrics::CheckResult::kParsingError,
1905 metrics::CheckReaction::kUnset,
1906 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001907 nullptr,
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001908 &post_data));
1909 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08001910 string post_str(post_data.begin(), post_data.end());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001911 EXPECT_NE(post_str.find(
1912 base::StringPrintf("installsource=\"%s\"", interactive_str)),
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001913 string::npos)
1914 << "i = " << i;
1915 }
1916}
1917
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001918TEST_F(OmahaRequestActionTest, FormatTargetVersionPrefixOutputTest) {
1919 for (int i = 0; i < 2; i++) {
1920 bool target_version_set = i == 1;
1921 const char* target_version_prefix = target_version_set ? "10032." : "";
1922 brillo::Blob post_data;
1923 FakeSystemState fake_system_state;
1924
1925 request_params_.set_target_version_prefix(target_version_prefix);
1926
1927 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
1928 -1,
1929 false, // ping_only
1930 ErrorCode::kOmahaRequestXMLParseError,
1931 metrics::CheckResult::kParsingError,
1932 metrics::CheckReaction::kUnset,
1933 metrics::DownloadErrorCode::kUnset,
1934 nullptr,
1935 &post_data));
1936 // convert post_data to string
1937 string post_str(post_data.begin(), post_data.end());
1938 if (target_version_set) {
1939 EXPECT_NE(post_str.find("<updatecheck targetversionprefix=\"10032.\">"),
1940 string::npos)
1941 << "i = " << i;
1942 } else {
1943 EXPECT_EQ(post_str.find("targetversionprefix"), string::npos)
1944 << "i = " << i;
1945 }
1946 }
1947}
1948
1949TEST_F(OmahaRequestActionTest, FormatRollbackAllowedOutputTest) {
1950 for (int i = 0; i < 4; i++) {
1951 bool rollback_allowed = i / 2 == 0;
1952 bool target_version_set = i % 2 == 0;
1953 brillo::Blob post_data;
1954 FakeSystemState fake_system_state;
1955
1956 request_params_.set_target_version_prefix(target_version_set ? "10032."
1957 : "");
1958 request_params_.set_rollback_allowed(rollback_allowed);
1959
1960 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
1961 -1,
1962 false, // ping_only
1963 ErrorCode::kOmahaRequestXMLParseError,
1964 metrics::CheckResult::kParsingError,
1965 metrics::CheckReaction::kUnset,
1966 metrics::DownloadErrorCode::kUnset,
1967 nullptr,
1968 &post_data));
1969 // convert post_data to string
1970 string post_str(post_data.begin(), post_data.end());
1971 if (rollback_allowed && target_version_set) {
1972 EXPECT_NE(post_str.find("rollback_allowed=\"true\""), string::npos)
1973 << "i = " << i;
1974 } else {
1975 EXPECT_EQ(post_str.find("rollback_allowed"), string::npos) << "i = " << i;
1976 }
1977 }
1978}
1979
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001980TEST_F(OmahaRequestActionTest, OmahaEventTest) {
Darin Petkove17f86b2010-07-20 09:12:01 -07001981 OmahaEvent default_event;
1982 EXPECT_EQ(OmahaEvent::kTypeUnknown, default_event.type);
1983 EXPECT_EQ(OmahaEvent::kResultError, default_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001984 EXPECT_EQ(ErrorCode::kError, default_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001985
1986 OmahaEvent success_event(OmahaEvent::kTypeUpdateDownloadStarted);
1987 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadStarted, success_event.type);
1988 EXPECT_EQ(OmahaEvent::kResultSuccess, success_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001989 EXPECT_EQ(ErrorCode::kSuccess, success_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001990
1991 OmahaEvent error_event(OmahaEvent::kTypeUpdateDownloadFinished,
1992 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001993 ErrorCode::kError);
Darin Petkove17f86b2010-07-20 09:12:01 -07001994 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadFinished, error_event.type);
1995 EXPECT_EQ(OmahaEvent::kResultError, error_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001996 EXPECT_EQ(ErrorCode::kError, error_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001997}
1998
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001999void OmahaRequestActionTest::PingTest(bool ping_only) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002000 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002001 fake_system_state_.set_prefs(&prefs);
2002 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
2003 .Times(AnyNumber());
2004 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
2005 // Add a few hours to the day difference to test no rounding, etc.
2006 int64_t five_days_ago =
2007 (Time::Now() - TimeDelta::FromHours(5 * 24 + 13)).ToInternalValue();
2008 int64_t six_days_ago =
2009 (Time::Now() - TimeDelta::FromHours(6 * 24 + 11)).ToInternalValue();
2010 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002011 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002012 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002013 .WillOnce(DoAll(SetArgPointee<1>(six_days_ago), Return(true)));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002014 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002015 .WillOnce(DoAll(SetArgPointee<1>(five_days_ago), Return(true)));
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002016 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002017 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
Tianjie Xu282aa1f2017-09-05 13:42:45 -07002018 -1,
2019 ping_only,
2020 ErrorCode::kSuccess,
2021 metrics::CheckResult::kNoUpdateAvailable,
2022 metrics::CheckReaction::kUnset,
2023 metrics::DownloadErrorCode::kUnset,
2024 nullptr,
2025 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08002026 string post_str(post_data.begin(), post_data.end());
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002027 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"6\" r=\"5\"></ping>"),
2028 string::npos);
2029 if (ping_only) {
2030 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
2031 EXPECT_EQ(post_str.find("previousversion"), string::npos);
2032 } else {
2033 EXPECT_NE(post_str.find("updatecheck"), string::npos);
2034 EXPECT_NE(post_str.find("previousversion"), string::npos);
Darin Petkov265f2902011-05-09 15:17:40 -07002035 }
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002036}
2037
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002038TEST_F(OmahaRequestActionTest, PingTestSendOnlyAPing) {
2039 PingTest(true /* ping_only */);
2040}
2041
2042TEST_F(OmahaRequestActionTest, PingTestSendAlsoAnUpdateCheck) {
2043 PingTest(false /* ping_only */);
2044}
2045
2046TEST_F(OmahaRequestActionTest, ActivePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002047 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002048 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002049 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
2050 .Times(AnyNumber());
2051 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002052 int64_t three_days_ago =
2053 (Time::Now() - TimeDelta::FromHours(3 * 24 + 12)).ToInternalValue();
2054 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08002055 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002056 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002057 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002058 .WillOnce(DoAll(SetArgPointee<1>(three_days_ago), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002059 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002060 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002061 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002062 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
2063 -1,
2064 false, // ping_only
2065 ErrorCode::kSuccess,
2066 metrics::CheckResult::kNoUpdateAvailable,
2067 metrics::CheckReaction::kUnset,
2068 metrics::DownloadErrorCode::kUnset,
2069 nullptr,
2070 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08002071 string post_str(post_data.begin(), post_data.end());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002072 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"3\"></ping>"),
Thieu Le116fda32011-04-19 11:01:54 -07002073 string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002074}
2075
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002076TEST_F(OmahaRequestActionTest, RollCallPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002077 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002078 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002079 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
2080 .Times(AnyNumber());
2081 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002082 int64_t four_days_ago =
2083 (Time::Now() - TimeDelta::FromHours(4 * 24)).ToInternalValue();
2084 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08002085 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002086 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002087 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002088 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002089 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002090 .WillOnce(DoAll(SetArgPointee<1>(four_days_ago), Return(true)));
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002091 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002092 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
2093 -1,
2094 false, // ping_only
2095 ErrorCode::kSuccess,
2096 metrics::CheckResult::kNoUpdateAvailable,
2097 metrics::CheckReaction::kUnset,
2098 metrics::DownloadErrorCode::kUnset,
2099 nullptr,
2100 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08002101 string post_str(post_data.begin(), post_data.end());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002102 EXPECT_NE(post_str.find("<ping active=\"1\" r=\"4\"></ping>\n"),
Thieu Le116fda32011-04-19 11:01:54 -07002103 string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002104}
2105
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002106TEST_F(OmahaRequestActionTest, NoPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002107 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002108 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002109 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
2110 .Times(AnyNumber());
2111 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002112 int64_t one_hour_ago =
2113 (Time::Now() - TimeDelta::FromHours(1)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08002114 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002115 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002116 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002117 .WillOnce(DoAll(SetArgPointee<1>(one_hour_ago), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002118 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002119 .WillOnce(DoAll(SetArgPointee<1>(one_hour_ago), Return(true)));
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002120 // LastActivePingDay and PrefsLastRollCallPingDay are set even if we didn't
2121 // send a ping.
2122 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
2123 .WillOnce(Return(true));
2124 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
2125 .WillOnce(Return(true));
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002126 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002127 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
2128 -1,
2129 false, // ping_only
2130 ErrorCode::kSuccess,
2131 metrics::CheckResult::kNoUpdateAvailable,
2132 metrics::CheckReaction::kUnset,
2133 metrics::DownloadErrorCode::kUnset,
2134 nullptr,
2135 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08002136 string post_str(post_data.begin(), post_data.end());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002137 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002138}
2139
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002140TEST_F(OmahaRequestActionTest, IgnoreEmptyPingTest) {
Thieu Leb44e9e82011-06-06 14:34:04 -07002141 // This test ensures that we ignore empty ping only requests.
Alex Deymo8427b4a2014-11-05 14:00:32 -08002142 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002143 fake_system_state_.set_prefs(&prefs);
Thieu Leb44e9e82011-06-06 14:34:04 -07002144 int64_t now = Time::Now().ToInternalValue();
2145 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002146 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Thieu Leb44e9e82011-06-06 14:34:04 -07002147 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002148 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Thieu Leb44e9e82011-06-06 14:34:04 -07002149 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
2150 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002151 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002152 EXPECT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
2153 -1,
2154 true, // ping_only
2155 ErrorCode::kSuccess,
2156 metrics::CheckResult::kUnset,
2157 metrics::CheckReaction::kUnset,
2158 metrics::DownloadErrorCode::kUnset,
2159 nullptr,
2160 &post_data));
Alex Deymo80f70ff2016-02-10 16:08:11 -08002161 EXPECT_EQ(0U, post_data.size());
Thieu Leb44e9e82011-06-06 14:34:04 -07002162}
2163
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002164TEST_F(OmahaRequestActionTest, BackInTimePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002165 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002166 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002167 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
2168 .Times(AnyNumber());
2169 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002170 int64_t future =
2171 (Time::Now() + TimeDelta::FromHours(3 * 24 + 4)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08002172 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002173 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002174 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002175 .WillOnce(DoAll(SetArgPointee<1>(future), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002176 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07002177 .WillOnce(DoAll(SetArgPointee<1>(future), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002178 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
2179 .WillOnce(Return(true));
2180 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
2181 .WillOnce(Return(true));
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002182 brillo::Blob post_data;
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002183 ASSERT_TRUE(
Marton Hunyady2abda312018-04-24 18:21:49 +02002184 TestUpdateCheck("<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002185 "protocol=\"3.0\"><daystart elapsed_seconds=\"100\"/>"
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002186 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002187 "<updatecheck status=\"noupdate\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07002188 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07002189 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002190 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08002191 metrics::CheckResult::kNoUpdateAvailable,
2192 metrics::CheckReaction::kUnset,
2193 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07002194 nullptr,
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002195 &post_data));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08002196 string post_str(post_data.begin(), post_data.end());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002197 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002198}
2199
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002200TEST_F(OmahaRequestActionTest, LastPingDayUpdateTest) {
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002201 // This test checks that the action updates the last ping day to now
Darin Petkov84c763c2010-07-29 16:27:58 -07002202 // minus 200 seconds with a slack of 5 seconds. Therefore, the test
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002203 // may fail if it runs for longer than 5 seconds. It shouldn't run
2204 // that long though.
2205 int64_t midnight =
2206 (Time::Now() - TimeDelta::FromSeconds(200)).ToInternalValue();
2207 int64_t midnight_slack =
2208 (Time::Now() - TimeDelta::FromSeconds(195)).ToInternalValue();
Alex Deymo8427b4a2014-11-05 14:00:32 -08002209 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002210 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002211 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
2212 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002213 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay,
2214 AllOf(Ge(midnight), Le(midnight_slack))))
2215 .WillOnce(Return(true));
2216 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay,
2217 AllOf(Ge(midnight), Le(midnight_slack))))
2218 .WillOnce(Return(true));
2219 ASSERT_TRUE(
Marton Hunyady2abda312018-04-24 18:21:49 +02002220 TestUpdateCheck("<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002221 "protocol=\"3.0\"><daystart elapsed_seconds=\"200\"/>"
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002222 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002223 "<updatecheck status=\"noupdate\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07002224 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07002225 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002226 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08002227 metrics::CheckResult::kNoUpdateAvailable,
2228 metrics::CheckReaction::kUnset,
2229 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07002230 nullptr,
2231 nullptr));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002232}
2233
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002234TEST_F(OmahaRequestActionTest, NoElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002235 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002236 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002237 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
2238 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002239 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
2240 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
2241 ASSERT_TRUE(
Marton Hunyady2abda312018-04-24 18:21:49 +02002242 TestUpdateCheck("<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002243 "protocol=\"3.0\"><daystart blah=\"200\"/>"
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002244 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002245 "<updatecheck status=\"noupdate\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07002246 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07002247 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002248 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08002249 metrics::CheckResult::kNoUpdateAvailable,
2250 metrics::CheckReaction::kUnset,
2251 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07002252 nullptr,
2253 nullptr));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002254}
2255
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002256TEST_F(OmahaRequestActionTest, BadElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002257 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002258 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002259 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
2260 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002261 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
2262 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
2263 ASSERT_TRUE(
Marton Hunyady2abda312018-04-24 18:21:49 +02002264 TestUpdateCheck("<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002265 "protocol=\"3.0\"><daystart elapsed_seconds=\"x\"/>"
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002266 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07002267 "<updatecheck status=\"noupdate\"/></app></response>",
Darin Petkovedc522e2010-11-05 09:35:17 -07002268 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07002269 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002270 ErrorCode::kSuccess,
David Zeuthen33bae492014-02-25 16:16:18 -08002271 metrics::CheckResult::kNoUpdateAvailable,
2272 metrics::CheckReaction::kUnset,
2273 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07002274 nullptr,
2275 nullptr));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002276}
2277
Alex Deymob3fa53b2016-04-18 19:57:58 -07002278TEST_F(OmahaRequestActionTest, ParseUpdateCheckAttributesTest) {
2279 // Test that the "eol" flags is only parsed from the "_eol" attribute and not
2280 // the "eol" attribute.
2281 ASSERT_TRUE(
Marton Hunyady2abda312018-04-24 18:21:49 +02002282 TestUpdateCheck("<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
Alex Deymob3fa53b2016-04-18 19:57:58 -07002283 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2284 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
2285 "_eol=\"security-only\" eol=\"eol\" _foo=\"bar\"/>"
2286 "</app></response>",
2287 -1,
2288 false, // ping_only
2289 ErrorCode::kSuccess,
2290 metrics::CheckResult::kNoUpdateAvailable,
2291 metrics::CheckReaction::kUnset,
2292 metrics::DownloadErrorCode::kUnset,
2293 nullptr,
2294 nullptr));
2295 string eol_pref;
2296 EXPECT_TRUE(
2297 fake_system_state_.prefs()->GetString(kPrefsOmahaEolStatus, &eol_pref));
2298 // Note that the eol="eol" attribute should be ignored and the _eol should be
2299 // used instead.
2300 EXPECT_EQ("security-only", eol_pref);
2301}
2302
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002303TEST_F(OmahaRequestActionTest, NoUniqueIDTest) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002304 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002305 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
Darin Petkovedc522e2010-11-05 09:35:17 -07002306 -1,
Darin Petkov265f2902011-05-09 15:17:40 -07002307 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002308 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08002309 metrics::CheckResult::kParsingError,
2310 metrics::CheckReaction::kUnset,
2311 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07002312 nullptr, // response
Darin Petkov84c763c2010-07-29 16:27:58 -07002313 &post_data));
2314 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08002315 string post_str(post_data.begin(), post_data.end());
Darin Petkov84c763c2010-07-29 16:27:58 -07002316 EXPECT_EQ(post_str.find("machineid="), string::npos);
2317 EXPECT_EQ(post_str.find("userid="), string::npos);
2318}
2319
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002320TEST_F(OmahaRequestActionTest, NetworkFailureTest) {
Darin Petkovedc522e2010-11-05 09:35:17 -07002321 OmahaResponse response;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002322 const int http_error_code =
2323 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 501;
Marton Hunyady2abda312018-04-24 18:21:49 +02002324 ASSERT_FALSE(TestUpdateCheck("",
2325 501,
2326 false, // ping_only
2327 static_cast<ErrorCode>(http_error_code),
2328 metrics::CheckResult::kDownloadError,
2329 metrics::CheckReaction::kUnset,
2330 static_cast<metrics::DownloadErrorCode>(501),
2331 &response,
2332 nullptr));
Darin Petkovedc522e2010-11-05 09:35:17 -07002333 EXPECT_FALSE(response.update_exists);
2334}
2335
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002336TEST_F(OmahaRequestActionTest, NetworkFailureBadHTTPCodeTest) {
Darin Petkovedc522e2010-11-05 09:35:17 -07002337 OmahaResponse response;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002338 const int http_error_code =
2339 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 999;
Marton Hunyady2abda312018-04-24 18:21:49 +02002340 ASSERT_FALSE(TestUpdateCheck("",
2341 1500,
2342 false, // ping_only
2343 static_cast<ErrorCode>(http_error_code),
2344 metrics::CheckResult::kDownloadError,
2345 metrics::CheckReaction::kUnset,
2346 metrics::DownloadErrorCode::kHttpStatusOther,
2347 &response,
2348 nullptr));
Darin Petkovedc522e2010-11-05 09:35:17 -07002349 EXPECT_FALSE(response.update_exists);
2350}
2351
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002352TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsPersistedFirstTime) {
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002353 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02002354 request_params_.set_wall_clock_based_wait_enabled(true);
2355 request_params_.set_waiting_period(TimeDelta().FromDays(1));
2356 request_params_.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002357
Sen Jiang7c1171e2016-06-23 11:35:40 -07002358 Time arbitrary_date;
Eric Caruso761be2c2018-05-22 16:23:33 -07002359 ASSERT_TRUE(Time::FromString("6/4/1989", &arbitrary_date));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002360 fake_system_state_.fake_clock()->SetWallclockTime(arbitrary_date);
Marton Hunyady2abda312018-04-24 18:21:49 +02002361 ASSERT_FALSE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiang7c1171e2016-06-23 11:35:40 -07002362 -1,
2363 false, // ping_only
2364 ErrorCode::kOmahaUpdateDeferredPerPolicy,
2365 metrics::CheckResult::kUpdateAvailable,
2366 metrics::CheckReaction::kDeferring,
2367 metrics::DownloadErrorCode::kUnset,
2368 &response,
2369 nullptr));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002370
Ben Chan9abb7632014-08-07 00:10:53 -07002371 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002372 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002373 EXPECT_EQ(arbitrary_date.ToInternalValue(), timestamp);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002374 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -07002375
2376 // Verify if we are interactive check we don't defer.
Marton Hunyady2abda312018-04-24 18:21:49 +02002377 request_params_.set_interactive(true);
2378 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiang7c1171e2016-06-23 11:35:40 -07002379 -1,
2380 false, // ping_only
2381 ErrorCode::kSuccess,
2382 metrics::CheckResult::kUpdateAvailable,
2383 metrics::CheckReaction::kUpdating,
2384 metrics::DownloadErrorCode::kUnset,
2385 &response,
2386 nullptr));
Chris Sosa968d0572013-08-23 14:46:02 -07002387 EXPECT_TRUE(response.update_exists);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002388}
2389
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002390TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsUsedIfAlreadyPresent) {
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002391 OmahaResponse response;
Marton Hunyady2abda312018-04-24 18:21:49 +02002392 request_params_.set_wall_clock_based_wait_enabled(true);
2393 request_params_.set_waiting_period(TimeDelta().FromDays(1));
2394 request_params_.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002395
Sen Jiang7c1171e2016-06-23 11:35:40 -07002396 Time t1, t2;
Eric Caruso761be2c2018-05-22 16:23:33 -07002397 ASSERT_TRUE(Time::FromString("1/1/2012", &t1));
2398 ASSERT_TRUE(Time::FromString("1/3/2012", &t2));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002399 ASSERT_TRUE(
2400 fake_prefs_.SetInt64(kPrefsUpdateFirstSeenAt, t1.ToInternalValue()));
2401 fake_system_state_.fake_clock()->SetWallclockTime(t2);
Marton Hunyady2abda312018-04-24 18:21:49 +02002402 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
Sen Jiang7c1171e2016-06-23 11:35:40 -07002403 -1,
2404 false, // ping_only
2405 ErrorCode::kSuccess,
2406 metrics::CheckResult::kUpdateAvailable,
2407 metrics::CheckReaction::kUpdating,
2408 metrics::DownloadErrorCode::kUnset,
2409 &response,
2410 nullptr));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002411
2412 EXPECT_TRUE(response.update_exists);
2413
2414 // Make sure the timestamp t1 is unchanged showing that it was reused.
Ben Chan9abb7632014-08-07 00:10:53 -07002415 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002416 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002417 ASSERT_TRUE(timestamp == t1.ToInternalValue());
2418}
2419
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002420TEST_F(OmahaRequestActionTest, TestChangingToMoreStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002421 // Create a uniquely named test directory.
Sen Jiang297e5832016-03-17 14:45:51 -07002422 base::ScopedTempDir tempdir;
2423 ASSERT_TRUE(tempdir.CreateUniqueTempDir());
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002424
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002425 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002426 request_params_.set_root(tempdir.GetPath().value());
2427 request_params_.set_app_id("{22222222-2222-2222-2222-222222222222}");
2428 request_params_.set_app_version("1.2.3.4");
2429 request_params_.set_product_components("o.bundle=1");
2430 request_params_.set_current_channel("canary-channel");
2431 EXPECT_TRUE(
2432 request_params_.SetTargetChannel("stable-channel", true, nullptr));
2433 request_params_.UpdateDownloadChannel();
2434 EXPECT_TRUE(request_params_.ShouldPowerwash());
2435 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002436 -1,
2437 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002438 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08002439 metrics::CheckResult::kParsingError,
2440 metrics::CheckReaction::kUnset,
2441 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07002442 nullptr, // response
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002443 &post_data));
2444 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08002445 string post_str(post_data.begin(), post_data.end());
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002446 EXPECT_NE(string::npos, post_str.find(
2447 "appid=\"{22222222-2222-2222-2222-222222222222}\" "
2448 "version=\"0.0.0.0\" from_version=\"1.2.3.4\" "
2449 "track=\"stable-channel\" from_track=\"canary-channel\" "));
Sen Jiang8cd42342018-01-31 12:06:59 -08002450 EXPECT_EQ(string::npos, post_str.find("o.bundle"));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002451}
2452
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002453TEST_F(OmahaRequestActionTest, TestChangingToLessStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002454 // Create a uniquely named test directory.
Sen Jiang297e5832016-03-17 14:45:51 -07002455 base::ScopedTempDir tempdir;
2456 ASSERT_TRUE(tempdir.CreateUniqueTempDir());
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002457
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002458 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002459 request_params_.set_root(tempdir.GetPath().value());
2460 request_params_.set_app_id("{11111111-1111-1111-1111-111111111111}");
2461 request_params_.set_app_version("5.6.7.8");
2462 request_params_.set_product_components("o.bundle=1");
2463 request_params_.set_current_channel("stable-channel");
2464 EXPECT_TRUE(
2465 request_params_.SetTargetChannel("canary-channel", false, nullptr));
2466 request_params_.UpdateDownloadChannel();
2467 EXPECT_FALSE(request_params_.ShouldPowerwash());
2468 ASSERT_FALSE(TestUpdateCheck("invalid xml>",
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002469 -1,
2470 false, // ping_only
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002471 ErrorCode::kOmahaRequestXMLParseError,
David Zeuthen33bae492014-02-25 16:16:18 -08002472 metrics::CheckResult::kParsingError,
2473 metrics::CheckReaction::kUnset,
2474 metrics::DownloadErrorCode::kUnset,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07002475 nullptr, // response
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002476 &post_data));
2477 // convert post_data to string
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08002478 string post_str(post_data.begin(), post_data.end());
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002479 EXPECT_NE(string::npos, post_str.find(
2480 "appid=\"{11111111-1111-1111-1111-111111111111}\" "
2481 "version=\"5.6.7.8\" "
2482 "track=\"canary-channel\" from_track=\"stable-channel\""));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002483 EXPECT_EQ(string::npos, post_str.find("from_version"));
Sen Jiang8cd42342018-01-31 12:06:59 -08002484 EXPECT_NE(string::npos, post_str.find("o.bundle.version=\"1\""));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002485}
2486
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002487// Checks that the initial ping with a=-1 r=-1 is not send when the device
2488// was powerwashed.
2489TEST_F(OmahaRequestActionTest, PingWhenPowerwashed) {
2490 fake_prefs_.SetString(kPrefsPreviousVersion, "");
2491
2492 // Flag that the device was powerwashed in the past.
2493 fake_system_state_.fake_hardware()->SetPowerwashCount(1);
2494
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07002495 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002496 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
2497 -1,
2498 false, // ping_only
2499 ErrorCode::kSuccess,
2500 metrics::CheckResult::kNoUpdateAvailable,
2501 metrics::CheckReaction::kUnset,
2502 metrics::DownloadErrorCode::kUnset,
2503 nullptr,
2504 &post_data));
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002505 // We shouldn't send a ping in this case since powerwash > 0.
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -08002506 string post_str(post_data.begin(), post_data.end());
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002507 EXPECT_EQ(string::npos, post_str.find("<ping"));
2508}
2509
Amin Hassani1677e812017-06-21 13:36:36 -07002510// Checks that the initial ping with a=-1 r=-1 is not send when the device
2511// first_active_omaha_ping_sent is set.
2512TEST_F(OmahaRequestActionTest, PingWhenFirstActiveOmahaPingIsSent) {
2513 fake_prefs_.SetString(kPrefsPreviousVersion, "");
2514
2515 // Flag that the device was not powerwashed in the past.
2516 fake_system_state_.fake_hardware()->SetPowerwashCount(0);
2517
2518 // Flag that the device has sent first active ping in the past.
2519 fake_system_state_.fake_hardware()->SetFirstActiveOmahaPingSent();
2520
2521 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002522 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
2523 -1,
2524 false, // ping_only
2525 ErrorCode::kSuccess,
2526 metrics::CheckResult::kNoUpdateAvailable,
2527 metrics::CheckReaction::kUnset,
2528 metrics::DownloadErrorCode::kUnset,
2529 nullptr,
2530 &post_data));
Amin Hassani1677e812017-06-21 13:36:36 -07002531 // We shouldn't send a ping in this case since
2532 // first_active_omaha_ping_sent=true
2533 string post_str(post_data.begin(), post_data.end());
2534 EXPECT_EQ(string::npos, post_str.find("<ping"));
2535}
2536
Alex Deymo9fded1e2015-11-05 12:31:19 -08002537// Checks that the event 54 is sent on a reboot to a new update.
2538TEST_F(OmahaRequestActionTest, RebootAfterUpdateEvent) {
2539 // Flag that the device was updated in a previous boot.
2540 fake_prefs_.SetString(kPrefsPreviousVersion, "1.2.3.4");
2541
2542 brillo::Blob post_data;
Marton Hunyady2abda312018-04-24 18:21:49 +02002543 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetNoUpdateResponse(),
2544 -1,
2545 false, // ping_only
2546 ErrorCode::kSuccess,
2547 metrics::CheckResult::kNoUpdateAvailable,
2548 metrics::CheckReaction::kUnset,
2549 metrics::DownloadErrorCode::kUnset,
2550 nullptr,
2551 &post_data));
Alex Deymo9fded1e2015-11-05 12:31:19 -08002552 string post_str(post_data.begin(), post_data.end());
2553
2554 // An event 54 is included and has the right version.
2555 EXPECT_NE(string::npos,
2556 post_str.find(base::StringPrintf(
2557 "<event eventtype=\"%d\"",
2558 OmahaEvent::kTypeRebootedAfterUpdate)));
2559 EXPECT_NE(string::npos,
2560 post_str.find("previousversion=\"1.2.3.4\"></event>"));
2561
2562 // The previous version flag should have been removed.
2563 EXPECT_TRUE(fake_prefs_.Exists(kPrefsPreviousVersion));
2564 string prev_version;
2565 EXPECT_TRUE(fake_prefs_.GetString(kPrefsPreviousVersion, &prev_version));
2566 EXPECT_TRUE(prev_version.empty());
2567}
2568
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002569void OmahaRequestActionTest::P2PTest(
2570 bool initial_allow_p2p_for_downloading,
2571 bool initial_allow_p2p_for_sharing,
2572 bool omaha_disable_p2p_for_downloading,
2573 bool omaha_disable_p2p_for_sharing,
2574 bool payload_state_allow_p2p_attempt,
2575 bool expect_p2p_client_lookup,
2576 const string& p2p_client_result_url,
2577 bool expected_allow_p2p_for_downloading,
2578 bool expected_allow_p2p_for_sharing,
2579 const string& expected_p2p_url) {
David Zeuthen8f191b22013-08-06 12:27:50 -07002580 OmahaResponse response;
Gilad Arnold74b5f552014-10-07 08:17:16 -07002581 bool actual_allow_p2p_for_downloading = initial_allow_p2p_for_downloading;
2582 bool actual_allow_p2p_for_sharing = initial_allow_p2p_for_sharing;
2583 string actual_p2p_url;
David Zeuthen8f191b22013-08-06 12:27:50 -07002584
2585 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002586 fake_system_state_.set_payload_state(&mock_payload_state);
David Zeuthen8f191b22013-08-06 12:27:50 -07002587 EXPECT_CALL(mock_payload_state, P2PAttemptAllowed())
2588 .WillRepeatedly(Return(payload_state_allow_p2p_attempt));
Gilad Arnold74b5f552014-10-07 08:17:16 -07002589 EXPECT_CALL(mock_payload_state, GetUsingP2PForDownloading())
2590 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_downloading));
2591 EXPECT_CALL(mock_payload_state, GetUsingP2PForSharing())
2592 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_sharing));
2593 EXPECT_CALL(mock_payload_state, SetUsingP2PForDownloading(_))
2594 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_downloading));
2595 EXPECT_CALL(mock_payload_state, SetUsingP2PForSharing(_))
2596 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_sharing));
2597 EXPECT_CALL(mock_payload_state, SetP2PUrl(_))
2598 .WillRepeatedly(SaveArg<0>(&actual_p2p_url));
2599
David Zeuthen8f191b22013-08-06 12:27:50 -07002600 MockP2PManager mock_p2p_manager;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002601 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -07002602 mock_p2p_manager.fake().SetLookupUrlForFileResult(p2p_client_result_url);
2603
David Zeuthen4cc5ed22014-01-15 12:35:03 -08002604 TimeDelta timeout = TimeDelta::FromSeconds(kMaxP2PNetworkWaitTimeSeconds);
2605 EXPECT_CALL(mock_p2p_manager, LookupUrlForFile(_, _, timeout, _))
David Zeuthen8f191b22013-08-06 12:27:50 -07002606 .Times(expect_p2p_client_lookup ? 1 : 0);
2607
Alex Deymo8e18f932015-03-27 16:16:59 -07002608 fake_update_response_.disable_p2p_for_downloading =
2609 omaha_disable_p2p_for_downloading;
2610 fake_update_response_.disable_p2p_for_sharing = omaha_disable_p2p_for_sharing;
Marton Hunyady2abda312018-04-24 18:21:49 +02002611 ASSERT_TRUE(TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
2612 -1,
2613 false, // ping_only
2614 ErrorCode::kSuccess,
2615 metrics::CheckResult::kUpdateAvailable,
2616 metrics::CheckReaction::kUpdating,
2617 metrics::DownloadErrorCode::kUnset,
2618 &response,
2619 nullptr));
David Zeuthen8f191b22013-08-06 12:27:50 -07002620 EXPECT_TRUE(response.update_exists);
2621
Gilad Arnold74b5f552014-10-07 08:17:16 -07002622 EXPECT_EQ(omaha_disable_p2p_for_downloading,
2623 response.disable_p2p_for_downloading);
2624 EXPECT_EQ(omaha_disable_p2p_for_sharing,
2625 response.disable_p2p_for_sharing);
David Zeuthen8f191b22013-08-06 12:27:50 -07002626
Gilad Arnold74b5f552014-10-07 08:17:16 -07002627 EXPECT_EQ(expected_allow_p2p_for_downloading,
2628 actual_allow_p2p_for_downloading);
2629 EXPECT_EQ(expected_allow_p2p_for_sharing, actual_allow_p2p_for_sharing);
2630 EXPECT_EQ(expected_p2p_url, actual_p2p_url);
David Zeuthen8f191b22013-08-06 12:27:50 -07002631}
2632
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002633TEST_F(OmahaRequestActionTest, P2PWithPeer) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002634 P2PTest(true, // initial_allow_p2p_for_downloading
2635 true, // initial_allow_p2p_for_sharing
2636 false, // omaha_disable_p2p_for_downloading
2637 false, // omaha_disable_p2p_for_sharing
2638 true, // payload_state_allow_p2p_attempt
2639 true, // expect_p2p_client_lookup
2640 "http://1.3.5.7/p2p", // p2p_client_result_url
2641 true, // expected_allow_p2p_for_downloading
2642 true, // expected_allow_p2p_for_sharing
2643 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002644}
2645
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002646TEST_F(OmahaRequestActionTest, P2PWithoutPeer) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002647 P2PTest(true, // initial_allow_p2p_for_downloading
2648 true, // initial_allow_p2p_for_sharing
2649 false, // omaha_disable_p2p_for_downloading
2650 false, // omaha_disable_p2p_for_sharing
2651 true, // payload_state_allow_p2p_attempt
2652 true, // expect_p2p_client_lookup
2653 "", // p2p_client_result_url
2654 false, // expected_allow_p2p_for_downloading
2655 true, // expected_allow_p2p_for_sharing
2656 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002657}
2658
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002659TEST_F(OmahaRequestActionTest, P2PDownloadNotAllowed) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002660 P2PTest(false, // initial_allow_p2p_for_downloading
2661 true, // initial_allow_p2p_for_sharing
2662 false, // omaha_disable_p2p_for_downloading
2663 false, // omaha_disable_p2p_for_sharing
2664 true, // payload_state_allow_p2p_attempt
2665 false, // expect_p2p_client_lookup
2666 "unset", // p2p_client_result_url
2667 false, // expected_allow_p2p_for_downloading
2668 true, // expected_allow_p2p_for_sharing
2669 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002670}
2671
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002672TEST_F(OmahaRequestActionTest, P2PWithPeerDownloadDisabledByOmaha) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002673 P2PTest(true, // initial_allow_p2p_for_downloading
2674 true, // initial_allow_p2p_for_sharing
2675 true, // omaha_disable_p2p_for_downloading
2676 false, // omaha_disable_p2p_for_sharing
2677 true, // payload_state_allow_p2p_attempt
2678 false, // expect_p2p_client_lookup
2679 "unset", // p2p_client_result_url
2680 false, // expected_allow_p2p_for_downloading
2681 true, // expected_allow_p2p_for_sharing
2682 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002683}
2684
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002685TEST_F(OmahaRequestActionTest, P2PWithPeerSharingDisabledByOmaha) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002686 P2PTest(true, // initial_allow_p2p_for_downloading
2687 true, // initial_allow_p2p_for_sharing
2688 false, // omaha_disable_p2p_for_downloading
2689 true, // omaha_disable_p2p_for_sharing
2690 true, // payload_state_allow_p2p_attempt
2691 true, // expect_p2p_client_lookup
2692 "http://1.3.5.7/p2p", // p2p_client_result_url
2693 true, // expected_allow_p2p_for_downloading
2694 false, // expected_allow_p2p_for_sharing
2695 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002696}
2697
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002698TEST_F(OmahaRequestActionTest, P2PWithPeerBothDisabledByOmaha) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002699 P2PTest(true, // initial_allow_p2p_for_downloading
2700 true, // initial_allow_p2p_for_sharing
2701 true, // omaha_disable_p2p_for_downloading
2702 true, // omaha_disable_p2p_for_sharing
2703 true, // payload_state_allow_p2p_attempt
2704 false, // expect_p2p_client_lookup
2705 "unset", // p2p_client_result_url
2706 false, // expected_allow_p2p_for_downloading
2707 false, // expected_allow_p2p_for_sharing
2708 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002709}
2710
Alex Deymof329b932014-10-30 01:37:48 -07002711bool OmahaRequestActionTest::InstallDateParseHelper(const string &elapsed_days,
2712 OmahaResponse *response) {
Alex Deymo8e18f932015-03-27 16:16:59 -07002713 fake_update_response_.elapsed_days = elapsed_days;
Marton Hunyady2abda312018-04-24 18:21:49 +02002714 return TestUpdateCheck(fake_update_response_.GetUpdateResponse(),
2715 -1,
2716 false, // ping_only
2717 ErrorCode::kSuccess,
2718 metrics::CheckResult::kUpdateAvailable,
2719 metrics::CheckReaction::kUpdating,
2720 metrics::DownloadErrorCode::kUnset,
2721 response,
2722 nullptr);
David Zeuthen639aa362014-02-03 16:23:44 -08002723}
2724
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002725TEST_F(OmahaRequestActionTest, ParseInstallDateFromResponse) {
David Zeuthen639aa362014-02-03 16:23:44 -08002726 OmahaResponse response;
David Zeuthen639aa362014-02-03 16:23:44 -08002727
Kevin Cernekee2494e282016-03-29 18:03:53 -07002728 // Simulate a successful update check that happens during OOBE. The
2729 // deadline in the response is needed to force the update attempt to
2730 // occur; responses without a deadline seen during OOBE will normally
2731 // return ErrorCode::kNonCriticalUpdateInOOBE.
2732 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
2733 fake_update_response_.deadline = "20101020";
2734
David Zeuthen639aa362014-02-03 16:23:44 -08002735 // Check that we parse elapsed_days in the Omaha Response correctly.
2736 // and that the kPrefsInstallDateDays value is written to.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002737 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2738 EXPECT_TRUE(InstallDateParseHelper("42", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002739 EXPECT_TRUE(response.update_exists);
2740 EXPECT_EQ(42, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002741 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002742 int64_t prefs_days;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002743 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002744 EXPECT_EQ(prefs_days, 42);
2745
2746 // If there already is a value set, we shouldn't do anything.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002747 EXPECT_TRUE(InstallDateParseHelper("7", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002748 EXPECT_TRUE(response.update_exists);
2749 EXPECT_EQ(7, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002750 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002751 EXPECT_EQ(prefs_days, 42);
2752
2753 // Note that elapsed_days is not necessarily divisible by 7 so check
2754 // that we round down correctly when populating kPrefsInstallDateDays.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002755 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2756 EXPECT_TRUE(InstallDateParseHelper("23", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002757 EXPECT_TRUE(response.update_exists);
2758 EXPECT_EQ(23, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002759 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002760 EXPECT_EQ(prefs_days, 21);
2761
2762 // Check that we correctly handle elapsed_days not being included in
2763 // the Omaha Response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002764 EXPECT_TRUE(InstallDateParseHelper("", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002765 EXPECT_TRUE(response.update_exists);
2766 EXPECT_EQ(-1, response.install_date_days);
David Zeuthen639aa362014-02-03 16:23:44 -08002767}
2768
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002769// If there is no prefs and OOBE is not complete, we should not
2770// report anything to Omaha.
2771TEST_F(OmahaRequestActionTest, GetInstallDateWhenNoPrefsNorOOBE) {
Kevin Cernekee2494e282016-03-29 18:03:53 -07002772 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002773 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2774 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2775}
David Zeuthen639aa362014-02-03 16:23:44 -08002776
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002777// If OOBE is complete and happened on a valid date (e.g. after Jan
2778// 1 2007 0:00 PST), that date should be used and written to
2779// prefs. However, first try with an invalid date and check we do
2780// nothing.
2781TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithInvalidDate) {
2782 Time oobe_date = Time::FromTimeT(42); // Dec 31, 1969 16:00:42 PST.
2783 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2784 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2785 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2786}
David Zeuthen639aa362014-02-03 16:23:44 -08002787
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002788// Then check with a valid date. The date Jan 20, 2007 0:00 PST
2789// should yield an InstallDate of 14.
2790TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithValidDate) {
2791 Time oobe_date = Time::FromTimeT(1169280000); // Jan 20, 2007 0:00 PST.
2792 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2793 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
2794 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002795
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002796 int64_t prefs_days;
2797 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2798 EXPECT_EQ(prefs_days, 14);
2799}
David Zeuthen639aa362014-02-03 16:23:44 -08002800
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002801// Now that we have a valid date in prefs, check that we keep using
2802// that even if OOBE date reports something else. The date Jan 30,
2803// 2007 0:00 PST should yield an InstallDate of 28... but since
2804// there's a prefs file, we should still get 14.
2805TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedDateChanges) {
2806 // Set a valid date in the prefs first.
2807 EXPECT_TRUE(fake_prefs_.SetInt64(kPrefsInstallDateDays, 14));
David Zeuthen639aa362014-02-03 16:23:44 -08002808
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002809 Time oobe_date = Time::FromTimeT(1170144000); // Jan 30, 2007 0:00 PST.
2810 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2811 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002812
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002813 int64_t prefs_days;
2814 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2815 EXPECT_EQ(prefs_days, 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002816
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002817 // If we delete the prefs file, we should get 28 days.
2818 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2819 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 28);
2820 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2821 EXPECT_EQ(prefs_days, 28);
David Zeuthen639aa362014-02-03 16:23:44 -08002822}
2823
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002824// Verifies that a device with no device policy, and is not a consumer
2825// device sets the max kernel key version to the current version.
2826// ie. the same behavior as if rollback is enabled.
2827TEST_F(OmahaRequestActionTest, NoPolicyEnterpriseDevicesSetMaxRollback) {
2828 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2829
2830 // Setup and verify some initial default values for the kernel TPM
2831 // values that control verified boot and rollback.
2832 const int min_kernel_version = 4;
2833 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2834 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2835 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2836 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2837
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002838 EXPECT_CALL(
2839 *fake_system_state_.mock_metrics_reporter(),
2840 ReportKeyVersionMetrics(min_kernel_version, min_kernel_version, true))
2841 .Times(1);
2842
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002843 OmahaResponse response;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002844 TestRollbackCheck(false /* is_consumer_device */,
2845 3 /* rollback_allowed_milestones */,
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002846 false /* is_policy_loaded */,
2847 &response);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002848
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002849 // Verify kernel_max_rollforward was set to the current minimum
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002850 // kernel key version. This has the effect of freezing roll
2851 // forwards indefinitely. This will hold the rollback window
2852 // open until a future change will be able to move this forward
2853 // relative the configured window.
2854 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2855 EXPECT_EQ(min_kernel_version, fake_hw->GetMaxKernelKeyRollforward());
2856}
2857
2858// Verifies that a conmsumer device with no device policy sets the
2859// max kernel key version to the current version. ie. the same
2860// behavior as if rollback is enabled.
2861TEST_F(OmahaRequestActionTest, NoPolicyConsumerDevicesSetMaxRollback) {
2862 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2863
2864 // Setup and verify some initial default values for the kernel TPM
2865 // values that control verified boot and rollback.
2866 const int min_kernel_version = 3;
2867 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2868 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2869 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2870 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2871
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002872 EXPECT_CALL(
2873 *fake_system_state_.mock_metrics_reporter(),
2874 ReportKeyVersionMetrics(min_kernel_version, kRollforwardInfinity, true))
2875 .Times(1);
2876
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002877 OmahaResponse response;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002878 TestRollbackCheck(true /* is_consumer_device */,
2879 3 /* rollback_allowed_milestones */,
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002880 false /* is_policy_loaded */,
2881 &response);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002882
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002883 // Verify that with rollback disabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002884 // was set to logical infinity. This is the expected behavior for
2885 // consumer devices and matches the existing behavior prior to the
2886 // rollback features.
2887 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2888 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2889}
2890
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002891// Verifies that a device with rollback enabled sets kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002892// in the TPM to prevent roll forward.
2893TEST_F(OmahaRequestActionTest, RollbackEnabledDevicesSetMaxRollback) {
2894 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2895
2896 // Setup and verify some initial default values for the kernel TPM
2897 // values that control verified boot and rollback.
2898 const int allowed_milestones = 4;
2899 const int min_kernel_version = 3;
2900 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2901 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2902 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2903 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2904
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002905 EXPECT_CALL(
2906 *fake_system_state_.mock_metrics_reporter(),
2907 ReportKeyVersionMetrics(min_kernel_version, min_kernel_version, true))
2908 .Times(1);
2909
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002910 OmahaResponse response;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002911 TestRollbackCheck(false /* is_consumer_device */,
2912 allowed_milestones,
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002913 true /* is_policy_loaded */,
2914 &response);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002915
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002916 // Verify that with rollback enabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002917 // was set to the current minimum kernel key version. This has
2918 // the effect of freezing roll forwards indefinitely. This will
2919 // hold the rollback window open until a future change will
2920 // be able to move this forward relative the configured window.
2921 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2922 EXPECT_EQ(min_kernel_version, fake_hw->GetMaxKernelKeyRollforward());
2923}
2924
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002925// Verifies that a device with rollback disabled sets kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002926// in the TPM to logical infinity, to allow roll forward.
2927TEST_F(OmahaRequestActionTest, RollbackDisabledDevicesSetMaxRollback) {
2928 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2929
2930 // Setup and verify some initial default values for the kernel TPM
2931 // values that control verified boot and rollback.
2932 const int allowed_milestones = 0;
2933 const int min_kernel_version = 3;
2934 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2935 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2936 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2937 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2938
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002939 EXPECT_CALL(
2940 *fake_system_state_.mock_metrics_reporter(),
2941 ReportKeyVersionMetrics(min_kernel_version, kRollforwardInfinity, true))
2942 .Times(1);
2943
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002944 OmahaResponse response;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002945 TestRollbackCheck(false /* is_consumer_device */,
2946 allowed_milestones,
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002947 true /* is_policy_loaded */,
2948 &response);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002949
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002950 // Verify that with rollback disabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002951 // was set to logical infinity.
2952 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2953 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2954}
2955
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002956TEST_F(OmahaRequestActionTest, RollbackResponseParsedNoEntries) {
2957 OmahaResponse response;
2958 fake_update_response_.rollback = true;
2959 TestRollbackCheck(false /* is_consumer_device */,
2960 4 /* rollback_allowed_milestones */,
2961 true /* is_policy_loaded */,
2962 &response);
2963 EXPECT_TRUE(response.is_rollback);
2964}
2965
2966TEST_F(OmahaRequestActionTest, RollbackResponseValidVersionsParsed) {
2967 OmahaResponse response;
2968 fake_update_response_.rollback_firmware_version = "1.2";
2969 fake_update_response_.rollback_kernel_version = "3.4";
2970 fake_update_response_.rollback = true;
2971 TestRollbackCheck(false /* is_consumer_device */,
2972 4 /* rollback_allowed_milestones */,
2973 true /* is_policy_loaded */,
2974 &response);
2975 EXPECT_TRUE(response.is_rollback);
2976 EXPECT_EQ(1, response.rollback_key_version.firmware_key);
2977 EXPECT_EQ(2, response.rollback_key_version.firmware);
2978 EXPECT_EQ(3, response.rollback_key_version.kernel_key);
2979 EXPECT_EQ(4, response.rollback_key_version.kernel);
2980}
2981
Darin Petkov6a5b3222010-07-13 14:55:28 -07002982} // namespace chromeos_update_engine