blob: c3842b85e1865ffbce25f16901be298a8387a0f0 [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2012 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Darin Petkov6a5b3222010-07-13 14:55:28 -070016
Amin Hassaniec7bc112020-10-29 16:47:58 -070017#include "update_engine/cros/omaha_request_action.h"
Alex Deymo8427b4a2014-11-05 14:00:32 -080018
Ben Chan9abb7632014-08-07 00:10:53 -070019#include <stdint.h>
20
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070021#include <limits>
Ben Chanab5a0af2017-10-12 14:57:50 -070022#include <memory>
Darin Petkov6a5b3222010-07-13 14:55:28 -070023#include <string>
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080024#include <utility>
Darin Petkov6a5b3222010-07-13 14:55:28 -070025#include <vector>
Darin Petkov0dc8e9a2010-07-14 14:51:57 -070026
Alex Deymo60ca1a72015-06-18 18:19:15 -070027#include <base/bind.h>
Alex Deymo110e0302015-10-19 20:35:21 -070028#include <base/files/file_util.h>
Sen Jiang297e5832016-03-17 14:45:51 -070029#include <base/files/scoped_temp_dir.h>
Ben Chan5c02c132017-06-27 07:10:36 -070030#include <base/memory/ptr_util.h>
Alex Deymo8e18f932015-03-27 16:16:59 -070031#include <base/strings/string_number_conversions.h>
Alex Vakulenko75039d72014-03-25 12:36:28 -070032#include <base/strings/string_util.h>
33#include <base/strings/stringprintf.h>
34#include <base/time/time.h>
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -070035#include <brillo/message_loops/fake_message_loop.h>
36#include <brillo/message_loops/message_loop.h>
37#include <brillo/message_loops/message_loop_utils.h>
Andrewe045aef2020-01-08 16:29:22 -080038#include <expat.h>
Alex Deymoe1e3afe2014-10-30 13:02:49 -070039#include <gtest/gtest.h>
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080040#include <policy/libpolicy.h>
41#include <policy/mock_libpolicy.h>
Jay Srinivasand29695d2013-04-08 15:08:05 -070042
Alex Deymo39910dc2015-11-09 17:04:30 -080043#include "update_engine/common/action_pipe.h"
44#include "update_engine/common/constants.h"
45#include "update_engine/common/fake_prefs.h"
46#include "update_engine/common/hash_calculator.h"
Amin Hassaniec7bc112020-10-29 16:47:58 -070047#include "update_engine/common/metrics_reporter_interface.h"
Jae Hoon Kim694eeb02020-06-01 14:24:08 -070048#include "update_engine/common/mock_excluder.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080049#include "update_engine/common/mock_http_fetcher.h"
50#include "update_engine/common/platform_constants.h"
51#include "update_engine/common/prefs.h"
52#include "update_engine/common/test_utils.h"
Amin Hassaniec7bc112020-10-29 16:47:58 -070053#include "update_engine/cros/fake_system_state.h"
54#include "update_engine/cros/mock_connection_manager.h"
55#include "update_engine/cros/mock_payload_state.h"
56#include "update_engine/cros/omaha_request_builder_xml.h"
57#include "update_engine/cros/omaha_request_params.h"
58#include "update_engine/cros/omaha_utils.h"
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080059#include "update_engine/update_manager/rollback_prefs.h"
Darin Petkov6a5b3222010-07-13 14:55:28 -070060
Darin Petkov1cbd78f2010-07-29 12:38:34 -070061using base::Time;
62using base::TimeDelta;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080063using chromeos_update_manager::kRollforwardInfinity;
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070064using std::pair;
Darin Petkov6a5b3222010-07-13 14:55:28 -070065using std::string;
66using std::vector;
Amin Hassani7cc8bb02019-01-14 16:29:47 -080067using testing::_;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070068using testing::AllOf;
Alex Deymof329b932014-10-30 01:37:48 -070069using testing::AnyNumber;
Jay Srinivasan34b5d862012-07-23 11:43:22 -070070using testing::DoAll;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070071using testing::Ge;
72using testing::Le;
Darin Petkov9c096d62010-11-17 14:49:04 -080073using testing::NiceMock;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070074using testing::Return;
Gilad Arnold74b5f552014-10-07 08:17:16 -070075using testing::ReturnPointee;
Amin Hassani7cc8bb02019-01-14 16:29:47 -080076using testing::ReturnRef;
Gilad Arnold74b5f552014-10-07 08:17:16 -070077using testing::SaveArg;
Ben Chan672c1f52017-10-23 15:41:39 -070078using testing::SetArgPointee;
Jae Hoon Kim694eeb02020-06-01 14:24:08 -070079using testing::StrictMock;
Darin Petkov6a5b3222010-07-13 14:55:28 -070080
Alex Deymo8e18f932015-03-27 16:16:59 -070081namespace {
82
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080083static_assert(kRollforwardInfinity == 0xfffffffe,
84 "Don't change the value of kRollforward infinity unless its "
85 "size has been changed in firmware.");
86
Xiaochu Liu6310be62018-10-11 15:09:03 -070087const char kCurrentVersion[] = "0.1.0.0";
Alex Deymo85616652015-10-15 18:48:31 -070088const char kTestAppId[] = "test-app-id";
Aaron Wood7dcdedf2017-09-06 17:17:41 -070089const char kTestAppId2[] = "test-app2-id";
Xiaochu Liu6310be62018-10-11 15:09:03 -070090const char kTestAppIdSkipUpdatecheck[] = "test-app-id-skip-updatecheck";
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -080091const char kDlcId1[] = "dlc-id-1";
92const char kDlcId2[] = "dlc-id-2";
Alex Deymo85616652015-10-15 18:48:31 -070093
Alex Deymo8e18f932015-03-27 16:16:59 -070094// This is a helper struct to allow unit tests build an update response with the
95// values they care about.
96struct FakeUpdateResponse {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -070097 string GetRollbackVersionAttributes() const {
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070098 string num_milestones;
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070099 num_milestones = base::NumberToString(rollback_allowed_milestones);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -0700100 const string rollback_version =
101 " _firmware_version_" + num_milestones + "=\"" +
102 past_rollback_key_version.first + "\"" + " _kernel_version_" +
103 num_milestones + "=\"" + past_rollback_key_version.second + "\"";
104
105 return (rollback ? " _rollback=\"true\"" : "") + rollback_version +
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700106 (!rollback_firmware_version.empty()
107 ? " _firmware_version=\"" + rollback_firmware_version + "\""
108 : "") +
109 (!rollback_kernel_version.empty()
110 ? " _kernel_version=\"" + rollback_kernel_version + "\""
111 : "");
112 }
113
Alex Deymo8e18f932015-03-27 16:16:59 -0700114 string GetNoUpdateResponse() const {
115 string entity_str;
116 if (include_entity)
117 entity_str = "<!DOCTYPE response [<!ENTITY CrOS \"ChromeOS\">]>";
Sen Jiang81259682017-03-30 15:11:30 -0700118 return "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" + entity_str +
119 "<response protocol=\"3.0\">"
120 "<daystart elapsed_seconds=\"100\"/>"
121 "<app appid=\"" +
122 app_id + "\" " +
123 (include_cohorts
124 ? "cohort=\"" + cohort + "\" cohorthint=\"" + cohorthint +
125 "\" cohortname=\"" + cohortname + "\" "
126 : "") +
127 " status=\"ok\">"
128 "<ping status=\"ok\"/>"
129 "<updatecheck status=\"noupdate\"/></app>" +
130 (multi_app_no_update
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700131 ? "<app appid=\"" + app_id2 +
132 "\"><updatecheck status=\"noupdate\"/></app>"
Sen Jiang81259682017-03-30 15:11:30 -0700133 : "") +
134 "</response>";
Alex Deymo8e18f932015-03-27 16:16:59 -0700135 }
136
137 string GetUpdateResponse() const {
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800138 chromeos_update_engine::OmahaRequestParams request_params{nullptr};
139 request_params.set_app_id(app_id);
Sen Jiang2703ef42017-03-16 13:36:21 -0700140 return "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
141 "protocol=\"3.0\">"
142 "<daystart elapsed_seconds=\"100\"" +
143 (elapsed_days.empty() ? ""
144 : (" elapsed_days=\"" + elapsed_days + "\"")) +
145 "/>"
146 "<app appid=\"" +
147 app_id + "\" " +
148 (include_cohorts
149 ? "cohort=\"" + cohort + "\" cohorthint=\"" + cohorthint +
150 "\" cohortname=\"" + cohortname + "\" "
151 : "") +
152 " status=\"ok\">"
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700153 "<ping status=\"ok\"/><updatecheck status=\"ok\"" +
154 GetRollbackVersionAttributes() + ">" + "<urls><url codebase=\"" +
Sen Jiang2703ef42017-03-16 13:36:21 -0700155 codebase +
156 "\"/></urls>"
157 "<manifest version=\"" +
158 version +
159 "\">"
160 "<packages><package hash=\"not-used\" name=\"" +
Qijiang Fan0b6501c2020-05-21 05:19:12 +0900161 filename + "\" size=\"" + base::NumberToString(size) +
Sen Jiang0affc2c2017-02-10 15:55:05 -0800162 "\" hash_sha256=\"" + hash + "\"/>" +
163 (multi_package ? "<package name=\"package2\" size=\"222\" "
164 "hash_sha256=\"hash2\"/>"
165 : "") +
166 "</packages>"
Sen Jiang81259682017-03-30 15:11:30 -0700167 "<actions><action event=\"postinstall\" MetadataSize=\"11" +
Amin Hassanic482bbd2018-09-21 16:07:20 -0700168 (multi_package ? ":22" : "") + "\" MoreInfo=\"" + more_info_url +
169 "\" Prompt=\"" + prompt +
Sen Jiang2703ef42017-03-16 13:36:21 -0700170 "\" "
Sen Jiangcdd52062017-05-18 15:33:10 -0700171 "IsDeltaPayload=\"true" +
172 (multi_package ? ":false" : "") +
173 "\" "
Sen Jiang2703ef42017-03-16 13:36:21 -0700174 "MaxDaysToScatter=\"" +
175 max_days_to_scatter +
176 "\" "
Amin Hassanic482bbd2018-09-21 16:07:20 -0700177 "sha256=\"not-used\" " +
Sen Jiang2703ef42017-03-16 13:36:21 -0700178 (deadline.empty() ? "" : ("deadline=\"" + deadline + "\" ")) +
179 (disable_p2p_for_downloading ? "DisableP2PForDownloading=\"true\" "
180 : "") +
181 (disable_p2p_for_sharing ? "DisableP2PForSharing=\"true\" " : "") +
Sen Jiangfe284402018-03-21 14:03:50 -0700182 (powerwash ? "Powerwash=\"true\" " : "") +
Sen Jiang81259682017-03-30 15:11:30 -0700183 "/></actions></manifest></updatecheck></app>" +
184 (multi_app
Sen Jiangb1e063a2017-09-15 17:44:31 -0700185 ? "<app appid=\"" + app_id2 + "\"" +
186 (include_cohorts ? " cohort=\"cohort2\"" : "") +
187 "><updatecheck status=\"ok\"><urls><url codebase=\"" +
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700188 codebase2 + "\"/></urls><manifest version=\"" + version2 +
189 "\"><packages>"
Sen Jiang81259682017-03-30 15:11:30 -0700190 "<package name=\"package3\" size=\"333\" "
191 "hash_sha256=\"hash3\"/></packages>"
Sen Jiang00adf7b2017-06-26 15:57:29 -0700192 "<actions><action event=\"postinstall\" " +
193 (multi_app_self_update
194 ? "noupdate=\"true\" IsDeltaPayload=\"true\" "
195 : "IsDeltaPayload=\"false\" ") +
196 "MetadataSize=\"33\"/></actions>"
Sen Jiang81259682017-03-30 15:11:30 -0700197 "</manifest></updatecheck></app>"
198 : "") +
199 (multi_app_no_update
200 ? "<app><updatecheck status=\"noupdate\"/></app>"
201 : "") +
Xiaochu Liu6310be62018-10-11 15:09:03 -0700202 (multi_app_skip_updatecheck
203 ? "<app appid=\"" + app_id_skip_updatecheck + "\"></app>"
204 : "") +
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800205 (dlc_app_update
206 ? "<app appid=\"" + request_params.GetDlcAppId(kDlcId1) +
207 "\" status=\"ok\">"
208 "<updatecheck status=\"ok\"><urls><url codebase=\"" +
Jae Hoon Kim694eeb02020-06-01 14:24:08 -0700209 codebase + "\"/><url codebase=\"" + codebase2 +
210 "\"/></urls><manifest version=\"" + version +
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800211 "\"><packages><package name=\"package3\" size=\"333\" "
212 "hash_sha256=\"hash3\"/></packages><actions>"
213 "<action event=\"install\" run=\".signed\"/>"
214 "<action event=\"postinstall\" MetadataSize=\"33\"/>"
215 "</actions></manifest></updatecheck></app>"
216 : "") +
217 (dlc_app_no_update
218 ? "<app appid=\"" + request_params.GetDlcAppId(kDlcId2) +
219 "\"><updatecheck status=\"noupdate\"/></app>"
220 : "") +
Sen Jiang81259682017-03-30 15:11:30 -0700221 "</response>";
Alex Deymo8e18f932015-03-27 16:16:59 -0700222 }
223
224 // Return the payload URL, which is split in two fields in the XML response.
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800225 string GetPayloadUrl() { return codebase + filename; }
Alex Deymo8e18f932015-03-27 16:16:59 -0700226
Alex Deymo85616652015-10-15 18:48:31 -0700227 string app_id = kTestAppId;
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700228 string app_id2 = kTestAppId2;
Xiaochu Liu6310be62018-10-11 15:09:03 -0700229 string app_id_skip_updatecheck = kTestAppIdSkipUpdatecheck;
230 string current_version = kCurrentVersion;
Alex Deymo8e18f932015-03-27 16:16:59 -0700231 string version = "1.2.3.4";
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700232 string version2 = "2.3.4.5";
Alex Deymo8e18f932015-03-27 16:16:59 -0700233 string more_info_url = "http://more/info";
234 string prompt = "true";
235 string codebase = "http://code/base/";
Sen Jiang81259682017-03-30 15:11:30 -0700236 string codebase2 = "http://code/base/2/";
Alex Deymo8e18f932015-03-27 16:16:59 -0700237 string filename = "file.signed";
Sen Jiang2703ef42017-03-16 13:36:21 -0700238 string hash = "4841534831323334";
Sen Jiang0affc2c2017-02-10 15:55:05 -0800239 uint64_t size = 123;
Alex Deymo8e18f932015-03-27 16:16:59 -0700240 string deadline = "";
241 string max_days_to_scatter = "7";
242 string elapsed_days = "42";
243
244 // P2P setting defaults to allowed.
245 bool disable_p2p_for_downloading = false;
246 bool disable_p2p_for_sharing = false;
247
Sen Jiangfe284402018-03-21 14:03:50 -0700248 bool powerwash = false;
249
Alex Deymo8e18f932015-03-27 16:16:59 -0700250 // Omaha cohorts settings.
251 bool include_cohorts = false;
252 string cohort = "";
253 string cohorthint = "";
254 string cohortname = "";
255
256 // Whether to include the CrOS <!ENTITY> in the XML response.
257 bool include_entity = false;
Sen Jiang0affc2c2017-02-10 15:55:05 -0800258
Sen Jiang81259682017-03-30 15:11:30 -0700259 // Whether to include more than one app.
260 bool multi_app = false;
Sen Jiang00adf7b2017-06-26 15:57:29 -0700261 // Whether to include an app with noupdate="true".
262 bool multi_app_self_update = false;
263 // Whether to include an additional app with status="noupdate".
Sen Jiang81259682017-03-30 15:11:30 -0700264 bool multi_app_no_update = false;
Xiaochu Liu6310be62018-10-11 15:09:03 -0700265 // Whether to include an additional app with no updatecheck tag.
266 bool multi_app_skip_updatecheck = false;
Sen Jiang81259682017-03-30 15:11:30 -0700267 // Whether to include more than one package in an app.
Sen Jiang0affc2c2017-02-10 15:55:05 -0800268 bool multi_package = false;
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800269 // Whether to include a DLC app with updatecheck tag.
270 bool dlc_app_update = false;
271 // Whether to include a DLC app with no updatecheck tag.
272 bool dlc_app_no_update = false;
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700273
274 // Whether the payload is a rollback.
275 bool rollback = false;
276 // The verified boot firmware key version for the rollback image.
277 string rollback_firmware_version = "";
278 // The verified boot kernel key version for the rollback image.
279 string rollback_kernel_version = "";
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -0700280 // The number of milestones back that the verified boot key version has been
281 // supplied.
282 uint32_t rollback_allowed_milestones = 0;
283 // The verified boot key version for the
284 // |current - rollback_allowed_milestones| most recent release.
285 // The pair contains <firmware_key_version, kernel_key_version> each
286 // of which is in the form "key_version.version".
287 pair<string, string> past_rollback_key_version;
Alex Deymo8e18f932015-03-27 16:16:59 -0700288};
289
290} // namespace
291
Darin Petkov6a5b3222010-07-13 14:55:28 -0700292namespace chromeos_update_engine {
293
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700294class OmahaRequestActionTestProcessorDelegate : public ActionProcessorDelegate {
295 public:
296 OmahaRequestActionTestProcessorDelegate()
297 : expected_code_(ErrorCode::kSuccess),
298 interactive_(false),
299 test_http_fetcher_headers_(false) {}
300 ~OmahaRequestActionTestProcessorDelegate() override = default;
301
302 void ProcessingDone(const ActionProcessor* processor,
303 ErrorCode code) override {
304 brillo::MessageLoop::current()->BreakLoop();
305 }
306
307 void ActionCompleted(ActionProcessor* processor,
308 AbstractAction* action,
309 ErrorCode code) override {
310 // Make sure actions always succeed.
311 if (action->Type() == OmahaRequestAction::StaticType()) {
312 EXPECT_EQ(expected_code_, code);
313 // Check that the headers were set in the fetcher during the action. Note
314 // that we set this request as "interactive".
315 auto fetcher = static_cast<const MockHttpFetcher*>(
316 static_cast<OmahaRequestAction*>(action)->http_fetcher_.get());
317
318 if (test_http_fetcher_headers_) {
319 EXPECT_EQ(interactive_ ? "fg" : "bg",
320 fetcher->GetHeader("X-Goog-Update-Interactivity"));
321 EXPECT_EQ(kTestAppId, fetcher->GetHeader("X-Goog-Update-AppId"));
322 EXPECT_NE("", fetcher->GetHeader("X-Goog-Update-Updater"));
323 }
324 post_data_ = fetcher->post_data();
325 } else if (action->Type() ==
326 ObjectCollectorAction<OmahaResponse>::StaticType()) {
327 EXPECT_EQ(ErrorCode::kSuccess, code);
328 auto collector_action =
329 static_cast<ObjectCollectorAction<OmahaResponse>*>(action);
330 omaha_response_.reset(new OmahaResponse(collector_action->object()));
331 EXPECT_TRUE(omaha_response_);
332 } else {
333 EXPECT_EQ(ErrorCode::kSuccess, code);
334 }
335 }
336 ErrorCode expected_code_;
337 brillo::Blob post_data_;
338 bool interactive_;
339 bool test_http_fetcher_headers_;
340 std::unique_ptr<OmahaResponse> omaha_response_;
341};
342
Amin Hassani41ac04b2019-03-29 11:31:03 -0700343struct TestUpdateCheckParams {
344 string http_response;
345 int fail_http_response_code;
346 bool ping_only;
347 bool is_consumer_device;
348 int rollback_allowed_milestones;
349 bool is_policy_loaded;
350 ErrorCode expected_code;
351 metrics::CheckResult expected_check_result;
352 metrics::CheckReaction expected_check_reaction;
353 metrics::DownloadErrorCode expected_download_error_code;
Jae Hoon Kimedb65502019-06-14 11:52:17 -0700354 string session_id;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700355};
356
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700357class OmahaRequestActionTest : public ::testing::Test {
358 protected:
Alex Deymo610277e2014-11-11 21:18:11 -0800359 void SetUp() override {
Marton Hunyady2abda312018-04-24 18:21:49 +0200360 request_params_.set_os_sp("service_pack");
361 request_params_.set_os_board("x86-generic");
362 request_params_.set_app_id(kTestAppId);
Xiaochu Liu6310be62018-10-11 15:09:03 -0700363 request_params_.set_app_version(kCurrentVersion);
Marton Hunyady2abda312018-04-24 18:21:49 +0200364 request_params_.set_app_lang("en-US");
365 request_params_.set_current_channel("unittest");
366 request_params_.set_target_channel("unittest");
367 request_params_.set_hwid("OEM MODEL 09235 7471");
Marton Hunyady2abda312018-04-24 18:21:49 +0200368 request_params_.set_delta_okay(true);
369 request_params_.set_interactive(false);
370 request_params_.set_update_url("http://url");
371 request_params_.set_target_version_prefix("");
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200372 request_params_.set_rollback_allowed(false);
Marton Hunyady2abda312018-04-24 18:21:49 +0200373 request_params_.set_is_powerwash_allowed(false);
Xiaochu Liu6310be62018-10-11 15:09:03 -0700374 request_params_.set_is_install(false);
Andrewe045aef2020-01-08 16:29:22 -0800375 request_params_.set_dlc_apps_params({});
Marton Hunyady2abda312018-04-24 18:21:49 +0200376
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700377 fake_system_state_.set_request_params(&request_params_);
378 fake_system_state_.set_prefs(&fake_prefs_);
Amin Hassani41ac04b2019-03-29 11:31:03 -0700379
380 // Setting the default update check params. Lookup |TestUpdateCheck()|.
381 tuc_params_ = {
382 .http_response = "",
383 .fail_http_response_code = -1,
384 .ping_only = false,
385 .is_consumer_device = true,
386 .rollback_allowed_milestones = 0,
387 .is_policy_loaded = false,
388 .expected_code = ErrorCode::kSuccess,
389 .expected_check_result = metrics::CheckResult::kUpdateAvailable,
390 .expected_check_reaction = metrics::CheckReaction::kUpdating,
391 .expected_download_error_code = metrics::DownloadErrorCode::kUnset,
392 };
Jae Hoon Kim694eeb02020-06-01 14:24:08 -0700393
394 ON_CALL(*fake_system_state_.mock_update_attempter(), GetExcluder())
395 .WillByDefault(Return(&mock_excluder_));
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700396 }
397
Andrewe045aef2020-01-08 16:29:22 -0800398 // This function uses the parameters in |tuc_params_| to do an update check.
399 // It will fill out |post_str| with the result data and |response| with
Amin Hassani41ac04b2019-03-29 11:31:03 -0700400 // |OmahaResponse|. Returns true iff an output response was obtained from the
401 // |OmahaRequestAction|. If |fail_http_response_code| is non-negative, the
402 // transfer will fail with that code. |ping_only| is passed through to the
403 // |OmahaRequestAction| constructor.
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700404 //
405 // The |expected_check_result|, |expected_check_reaction| and
Amin Hassani41ac04b2019-03-29 11:31:03 -0700406 // |expected_error_code| parameters are for checking expectations about
407 // reporting UpdateEngine.Check.{Result,Reaction,DownloadError} UMA
408 // statistics. Use the appropriate ::kUnset value to specify that the given
409 // metric should not be reported.
410 bool TestUpdateCheck();
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700411
Amin Hassani41ac04b2019-03-29 11:31:03 -0700412 // Tests events using |event| and |https_response|. It will fill up |post_str|
413 // with the result data.
414 void TestEvent(OmahaEvent* event, const string& http_response);
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700415
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -0800416 // Runs and checks a ping test. |ping_only| indicates whether it should send
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700417 // only a ping or also an updatecheck.
418 void PingTest(bool ping_only);
419
420 // InstallDate test helper function.
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800421 bool InstallDateParseHelper(const string& elapsed_days,
422 OmahaResponse* response);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700423
424 // P2P test helper function.
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800425 void P2PTest(bool initial_allow_p2p_for_downloading,
426 bool initial_allow_p2p_for_sharing,
427 bool omaha_disable_p2p_for_downloading,
428 bool omaha_disable_p2p_for_sharing,
429 bool payload_state_allow_p2p_attempt,
430 bool expect_p2p_client_lookup,
431 const string& p2p_client_result_url,
432 bool expected_allow_p2p_for_downloading,
433 bool expected_allow_p2p_for_sharing,
434 const string& expected_p2p_url);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700435
Jae Hoon Kim694eeb02020-06-01 14:24:08 -0700436 StrictMock<MockExcluder> mock_excluder_;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700437 FakeSystemState fake_system_state_;
Alex Deymo8e18f932015-03-27 16:16:59 -0700438 FakeUpdateResponse fake_update_response_;
Marton Hunyady2abda312018-04-24 18:21:49 +0200439 // Used by all tests.
440 OmahaRequestParams request_params_{&fake_system_state_};
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700441
442 FakePrefs fake_prefs_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700443
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700444 OmahaRequestActionTestProcessorDelegate delegate_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700445
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700446 bool test_http_fetcher_headers_{false};
Amin Hassani41ac04b2019-03-29 11:31:03 -0700447
448 TestUpdateCheckParams tuc_params_;
449
450 // TODO(ahassani): Add trailing _ to these two variables.
451 OmahaResponse response;
452 string post_str;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700453};
454
Andrew065d78d2020-04-07 15:43:07 -0700455class OmahaRequestActionDlcPingTest : public OmahaRequestActionTest {
456 protected:
457 void SetUp() override {
458 OmahaRequestActionTest::SetUp();
459 dlc_id_ = "dlc0";
460 active_key_ = PrefsInterface::CreateSubKey(
Jae Hoon Kimc1f36922020-05-11 18:20:18 -0700461 {kDlcPrefsSubDir, dlc_id_, kPrefsPingActive});
Andrew065d78d2020-04-07 15:43:07 -0700462 last_active_key_ = PrefsInterface::CreateSubKey(
Jae Hoon Kimc1f36922020-05-11 18:20:18 -0700463 {kDlcPrefsSubDir, dlc_id_, kPrefsPingLastActive});
Andrew065d78d2020-04-07 15:43:07 -0700464 last_rollcall_key_ = PrefsInterface::CreateSubKey(
Jae Hoon Kimc1f36922020-05-11 18:20:18 -0700465 {kDlcPrefsSubDir, dlc_id_, kPrefsPingLastRollcall});
Andrew065d78d2020-04-07 15:43:07 -0700466
467 tuc_params_.http_response =
468 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
469 "protocol=\"3.0\"><daystart elapsed_days=\"4763\" "
470 "elapsed_seconds=\"36540\"/><app appid=\"test-app-id\" status=\"ok\">\""
471 "<updatecheck status=\"noupdate\"/></app><app "
472 "appid=\"test-app-id_dlc0\" "
473 "status=\"ok\"><ping status=\"ok\"/><updatecheck status=\"noupdate\"/>"
474 "</app></response>";
475 tuc_params_.expected_check_result =
476 metrics::CheckResult::kNoUpdateAvailable;
477 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
478 }
479
480 std::string dlc_id_;
481 std::string active_key_;
482 std::string last_active_key_;
483 std::string last_rollcall_key_;
484};
Amin Hassani41ac04b2019-03-29 11:31:03 -0700485bool OmahaRequestActionTest::TestUpdateCheck() {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700486 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700487 loop.SetAsCurrent();
Amin Hassani41ac04b2019-03-29 11:31:03 -0700488 auto fetcher =
489 std::make_unique<MockHttpFetcher>(tuc_params_.http_response.data(),
490 tuc_params_.http_response.size(),
491 nullptr);
492 if (tuc_params_.fail_http_response_code >= 0) {
493 fetcher->FailTransfer(tuc_params_.fail_http_response_code);
Darin Petkovedc522e2010-11-05 09:35:17 -0700494 }
Marton Hunyady2abda312018-04-24 18:21:49 +0200495 // This ensures the tests didn't forget to update fake_system_state_ if they
496 // are not using the default request_params_.
497 EXPECT_EQ(&request_params_, fake_system_state_.request_params());
498
Jae Hoon Kimedb65502019-06-14 11:52:17 -0700499 auto omaha_request_action =
500 std::make_unique<OmahaRequestAction>(&fake_system_state_,
501 nullptr,
502 std::move(fetcher),
503 tuc_params_.ping_only,
504 tuc_params_.session_id);
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700505
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800506 auto mock_policy_provider =
507 std::make_unique<NiceMock<policy::MockPolicyProvider>>();
508 EXPECT_CALL(*mock_policy_provider, IsConsumerDevice())
Amin Hassani41ac04b2019-03-29 11:31:03 -0700509 .WillRepeatedly(Return(tuc_params_.is_consumer_device));
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800510
511 EXPECT_CALL(*mock_policy_provider, device_policy_is_loaded())
Amin Hassani41ac04b2019-03-29 11:31:03 -0700512 .WillRepeatedly(Return(tuc_params_.is_policy_loaded));
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800513
514 const policy::MockDevicePolicy device_policy;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700515 const bool get_allowed_milestone_succeeds =
516 tuc_params_.rollback_allowed_milestones >= 0;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800517 EXPECT_CALL(device_policy, GetRollbackAllowedMilestones(_))
Amin Hassani41ac04b2019-03-29 11:31:03 -0700518 .WillRepeatedly(
519 DoAll(SetArgPointee<0>(tuc_params_.rollback_allowed_milestones),
520 Return(get_allowed_milestone_succeeds)));
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800521
522 EXPECT_CALL(*mock_policy_provider, GetDevicePolicy())
523 .WillRepeatedly(ReturnRef(device_policy));
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700524 omaha_request_action->policy_provider_ = std::move(mock_policy_provider);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800525
Amin Hassani41ac04b2019-03-29 11:31:03 -0700526 delegate_.expected_code_ = tuc_params_.expected_code;
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700527 delegate_.interactive_ = request_params_.interactive();
528 delegate_.test_http_fetcher_headers_ = test_http_fetcher_headers_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700529 ActionProcessor processor;
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700530 processor.set_delegate(&delegate_);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700531
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700532 auto collector_action =
533 std::make_unique<ObjectCollectorAction<OmahaResponse>>();
534 BondActions(omaha_request_action.get(), collector_action.get());
535 processor.EnqueueAction(std::move(omaha_request_action));
536 processor.EnqueueAction(std::move(collector_action));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700537
Tianjie Xu282aa1f2017-09-05 13:42:45 -0700538 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
539 ReportUpdateCheckMetrics(_, _, _, _))
David Zeuthen33bae492014-02-25 16:16:18 -0800540 .Times(AnyNumber());
Tianjie Xu282aa1f2017-09-05 13:42:45 -0700541
Amin Hassani41ac04b2019-03-29 11:31:03 -0700542 EXPECT_CALL(
543 *fake_system_state_.mock_metrics_reporter(),
544 ReportUpdateCheckMetrics(_,
545 tuc_params_.expected_check_result,
546 tuc_params_.expected_check_reaction,
547 tuc_params_.expected_download_error_code))
548 .Times(tuc_params_.ping_only ? 0 : 1);
David Zeuthen33bae492014-02-25 16:16:18 -0800549
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700550 loop.PostTask(base::Bind(
551 [](ActionProcessor* processor) { processor->StartProcessing(); },
552 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700553 loop.Run();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700554 EXPECT_FALSE(loop.PendingTasks());
Amin Hassani41ac04b2019-03-29 11:31:03 -0700555 if (delegate_.omaha_response_)
556 response = *delegate_.omaha_response_;
557 post_str = string(delegate_.post_data_.begin(), delegate_.post_data_.end());
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700558 return delegate_.omaha_response_ != nullptr;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700559}
560
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700561// Tests Event requests -- they should always succeed. |out_post_data| may be
562// null; if non-null, the post-data received by the mock HttpFetcher is
563// returned.
564void OmahaRequestActionTest::TestEvent(OmahaEvent* event,
Amin Hassani41ac04b2019-03-29 11:31:03 -0700565 const string& http_response) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700566 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700567 loop.SetAsCurrent();
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700568
569 auto action = std::make_unique<OmahaRequestAction>(
570 &fake_system_state_,
571 event,
572 std::make_unique<MockHttpFetcher>(
573 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -0700574 false,
575 "");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700576 ActionProcessor processor;
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700577 processor.set_delegate(&delegate_);
578 processor.EnqueueAction(std::move(action));
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700579
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700580 loop.PostTask(base::Bind(
581 [](ActionProcessor* processor) { processor->StartProcessing(); },
582 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700583 loop.Run();
Alex Deymo72a25672016-03-23 15:44:39 -0700584 EXPECT_FALSE(loop.PendingTasks());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700585
Amin Hassani41ac04b2019-03-29 11:31:03 -0700586 post_str = string(delegate_.post_data_.begin(), delegate_.post_data_.end());
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700587}
588
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700589TEST_F(OmahaRequestActionTest, RejectEntities) {
Alex Deymo8e18f932015-03-27 16:16:59 -0700590 fake_update_response_.include_entity = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700591 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
592 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLHasEntityDecl;
593 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
594 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
595
596 ASSERT_FALSE(TestUpdateCheck());
David Zeuthenf3e28012014-08-26 18:23:52 -0400597 EXPECT_FALSE(response.update_exists);
598}
599
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700600TEST_F(OmahaRequestActionTest, NoUpdateTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -0700601 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
602 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
603 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
604
605 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -0700606 EXPECT_FALSE(response.update_exists);
607}
608
Sen Jiang81259682017-03-30 15:11:30 -0700609TEST_F(OmahaRequestActionTest, MultiAppNoUpdateTest) {
Sen Jiang81259682017-03-30 15:11:30 -0700610 fake_update_response_.multi_app_no_update = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700611 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
612 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
613 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
614
615 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang81259682017-03-30 15:11:30 -0700616 EXPECT_FALSE(response.update_exists);
617}
618
Sen Jiang00adf7b2017-06-26 15:57:29 -0700619TEST_F(OmahaRequestActionTest, MultiAppNoPartialUpdateTest) {
Sen Jiang00adf7b2017-06-26 15:57:29 -0700620 fake_update_response_.multi_app_no_update = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700621 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
622 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
623 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
624
625 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang00adf7b2017-06-26 15:57:29 -0700626 EXPECT_FALSE(response.update_exists);
627}
628
629TEST_F(OmahaRequestActionTest, NoSelfUpdateTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -0700630 tuc_params_.http_response =
Sen Jiang00adf7b2017-06-26 15:57:29 -0700631 "<response><app><updatecheck status=\"ok\"><manifest><actions><action "
632 "event=\"postinstall\" noupdate=\"true\"/></actions>"
Amin Hassani41ac04b2019-03-29 11:31:03 -0700633 "</manifest></updatecheck></app></response>";
634 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
635 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
636
637 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang00adf7b2017-06-26 15:57:29 -0700638 EXPECT_FALSE(response.update_exists);
639}
640
Alex Deymo8e18f932015-03-27 16:16:59 -0700641// Test that all the values in the response are parsed in a normal update
642// response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700643TEST_F(OmahaRequestActionTest, ValidUpdateTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -0700644 fake_update_response_.deadline = "20101020";
Amin Hassani41ac04b2019-03-29 11:31:03 -0700645 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
646
647 ASSERT_TRUE(TestUpdateCheck());
648
Darin Petkov6a5b3222010-07-13 14:55:28 -0700649 EXPECT_TRUE(response.update_exists);
Alex Deymo8e18f932015-03-27 16:16:59 -0700650 EXPECT_EQ(fake_update_response_.version, response.version);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800651 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
652 response.packages[0].payload_urls[0]);
Alex Deymo8e18f932015-03-27 16:16:59 -0700653 EXPECT_EQ(fake_update_response_.more_info_url, response.more_info_url);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800654 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
655 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700656 EXPECT_EQ(true, response.packages[0].is_delta);
Alex Deymo8e18f932015-03-27 16:16:59 -0700657 EXPECT_EQ(fake_update_response_.prompt == "true", response.prompt);
658 EXPECT_EQ(fake_update_response_.deadline, response.deadline);
Sen Jiangfe284402018-03-21 14:03:50 -0700659 EXPECT_FALSE(response.powerwash_required);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700660 // Omaha cohort attributes are not set in the response, so they should not be
Alex Deymo8e18f932015-03-27 16:16:59 -0700661 // persisted.
662 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohort));
663 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortHint));
664 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortName));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700665}
666
Sen Jiang0affc2c2017-02-10 15:55:05 -0800667TEST_F(OmahaRequestActionTest, MultiPackageUpdateTest) {
Sen Jiang0affc2c2017-02-10 15:55:05 -0800668 fake_update_response_.multi_package = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700669 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
670
671 ASSERT_TRUE(TestUpdateCheck());
672
Sen Jiang0affc2c2017-02-10 15:55:05 -0800673 EXPECT_TRUE(response.update_exists);
674 EXPECT_EQ(fake_update_response_.version, response.version);
675 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
676 response.packages[0].payload_urls[0]);
677 EXPECT_EQ(fake_update_response_.codebase + "package2",
678 response.packages[1].payload_urls[0]);
679 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
680 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700681 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700682 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800683 ASSERT_EQ(2u, response.packages.size());
Sen Jiang81259682017-03-30 15:11:30 -0700684 EXPECT_EQ(string("hash2"), response.packages[1].hash);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800685 EXPECT_EQ(222u, response.packages[1].size);
Sen Jiang81259682017-03-30 15:11:30 -0700686 EXPECT_EQ(22u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700687 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700688}
689
690TEST_F(OmahaRequestActionTest, MultiAppUpdateTest) {
Sen Jiang81259682017-03-30 15:11:30 -0700691 fake_update_response_.multi_app = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700692 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
693
694 ASSERT_TRUE(TestUpdateCheck());
695
Sen Jiang81259682017-03-30 15:11:30 -0700696 EXPECT_TRUE(response.update_exists);
697 EXPECT_EQ(fake_update_response_.version, response.version);
698 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
699 response.packages[0].payload_urls[0]);
700 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
701 response.packages[1].payload_urls[0]);
702 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
703 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
704 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700705 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700706 ASSERT_EQ(2u, response.packages.size());
707 EXPECT_EQ(string("hash3"), response.packages[1].hash);
708 EXPECT_EQ(333u, response.packages[1].size);
709 EXPECT_EQ(33u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700710 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700711}
712
713TEST_F(OmahaRequestActionTest, MultiAppPartialUpdateTest) {
Sen Jiang00adf7b2017-06-26 15:57:29 -0700714 fake_update_response_.multi_app = true;
715 fake_update_response_.multi_app_self_update = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700716 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
717
718 ASSERT_TRUE(TestUpdateCheck());
719
Sen Jiang81259682017-03-30 15:11:30 -0700720 EXPECT_TRUE(response.update_exists);
721 EXPECT_EQ(fake_update_response_.version, response.version);
722 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
723 response.packages[0].payload_urls[0]);
724 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
725 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
726 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiang00adf7b2017-06-26 15:57:29 -0700727 ASSERT_EQ(2u, response.packages.size());
728 EXPECT_EQ(string("hash3"), response.packages[1].hash);
729 EXPECT_EQ(333u, response.packages[1].size);
730 EXPECT_EQ(33u, response.packages[1].metadata_size);
731 EXPECT_EQ(true, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700732}
733
734TEST_F(OmahaRequestActionTest, MultiAppMultiPackageUpdateTest) {
Sen Jiang81259682017-03-30 15:11:30 -0700735 fake_update_response_.multi_app = true;
736 fake_update_response_.multi_package = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700737 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
738
739 ASSERT_TRUE(TestUpdateCheck());
740
Sen Jiang81259682017-03-30 15:11:30 -0700741 EXPECT_TRUE(response.update_exists);
742 EXPECT_EQ(fake_update_response_.version, response.version);
743 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
744 response.packages[0].payload_urls[0]);
745 EXPECT_EQ(fake_update_response_.codebase + "package2",
746 response.packages[1].payload_urls[0]);
747 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
748 response.packages[2].payload_urls[0]);
749 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
750 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
751 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700752 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700753 ASSERT_EQ(3u, response.packages.size());
754 EXPECT_EQ(string("hash2"), response.packages[1].hash);
755 EXPECT_EQ(222u, response.packages[1].size);
756 EXPECT_EQ(22u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700757 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700758 EXPECT_EQ(string("hash3"), response.packages[2].hash);
759 EXPECT_EQ(333u, response.packages[2].size);
760 EXPECT_EQ(33u, response.packages[2].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700761 EXPECT_EQ(false, response.packages[2].is_delta);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800762}
763
Sen Jiangfe284402018-03-21 14:03:50 -0700764TEST_F(OmahaRequestActionTest, PowerwashTest) {
Sen Jiangfe284402018-03-21 14:03:50 -0700765 fake_update_response_.powerwash = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700766 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
767
768 ASSERT_TRUE(TestUpdateCheck());
769
Sen Jiangfe284402018-03-21 14:03:50 -0700770 EXPECT_TRUE(response.update_exists);
771 EXPECT_TRUE(response.powerwash_required);
772}
773
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700774TEST_F(OmahaRequestActionTest, ExtraHeadersSentInteractiveTest) {
Alex Deymo14ad88e2016-06-29 12:30:14 -0700775 request_params_.set_interactive(true);
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700776 test_http_fetcher_headers_ = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700777 tuc_params_.http_response = "invalid xml>";
778 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
779 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
780 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
781
782 ASSERT_FALSE(TestUpdateCheck());
783
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700784 EXPECT_FALSE(response.update_exists);
785}
Alex Deymo14ad88e2016-06-29 12:30:14 -0700786
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700787TEST_F(OmahaRequestActionTest, ExtraHeadersSentNoInteractiveTest) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700788 request_params_.set_interactive(false);
789 test_http_fetcher_headers_ = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700790 tuc_params_.http_response = "invalid xml>";
791 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
792 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
793 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
794
795 ASSERT_FALSE(TestUpdateCheck());
796
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700797 EXPECT_FALSE(response.update_exists);
Alex Deymo14ad88e2016-06-29 12:30:14 -0700798}
799
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700800TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByConnection) {
Chris Sosa77f79e82014-06-02 18:16:24 -0700801 // Set up a connection manager that doesn't allow a valid update over
802 // the current ethernet connection.
Alex Deymof6ee0162015-07-31 12:35:22 -0700803 MockConnectionManager mock_cm;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700804 fake_system_state_.set_connection_manager(&mock_cm);
805
Alex Deymo30534502015-07-20 15:06:33 -0700806 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800807 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kEthernet),
808 SetArgPointee<1>(ConnectionTethering::kUnknown),
809 Return(true)));
Sen Jiang255e22b2016-05-20 16:15:29 -0700810 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kEthernet, _))
811 .WillRepeatedly(Return(false));
Chris Sosa77f79e82014-06-02 18:16:24 -0700812
Amin Hassani41ac04b2019-03-29 11:31:03 -0700813 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
814 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredPerPolicy;
815 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
816
817 ASSERT_FALSE(TestUpdateCheck());
818
Chris Sosa77f79e82014-06-02 18:16:24 -0700819 EXPECT_FALSE(response.update_exists);
820}
821
Weidong Guo421ff332017-04-17 10:08:38 -0700822TEST_F(OmahaRequestActionTest, ValidUpdateOverCellularAllowedByDevicePolicy) {
823 // This test tests that update over cellular is allowed as device policy
824 // says yes.
Weidong Guo421ff332017-04-17 10:08:38 -0700825 MockConnectionManager mock_cm;
Weidong Guo421ff332017-04-17 10:08:38 -0700826 fake_system_state_.set_connection_manager(&mock_cm);
827
828 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
829 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
830 SetArgPointee<1>(ConnectionTethering::kUnknown),
831 Return(true)));
832 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
833 .WillRepeatedly(Return(true));
834 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
835 .WillRepeatedly(Return(true));
836
Amin Hassani41ac04b2019-03-29 11:31:03 -0700837 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
838
839 ASSERT_TRUE(TestUpdateCheck());
840
Weidong Guo421ff332017-04-17 10:08:38 -0700841 EXPECT_TRUE(response.update_exists);
842}
843
844TEST_F(OmahaRequestActionTest, ValidUpdateOverCellularBlockedByDevicePolicy) {
845 // This test tests that update over cellular is blocked as device policy
846 // says no.
Weidong Guo421ff332017-04-17 10:08:38 -0700847 MockConnectionManager mock_cm;
Weidong Guo421ff332017-04-17 10:08:38 -0700848 fake_system_state_.set_connection_manager(&mock_cm);
849
850 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
851 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
852 SetArgPointee<1>(ConnectionTethering::kUnknown),
853 Return(true)));
854 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
855 .WillRepeatedly(Return(true));
856 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
857 .WillRepeatedly(Return(false));
858
Amin Hassani41ac04b2019-03-29 11:31:03 -0700859 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
860 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredPerPolicy;
861 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
862
863 ASSERT_FALSE(TestUpdateCheck());
864
Weidong Guo421ff332017-04-17 10:08:38 -0700865 EXPECT_FALSE(response.update_exists);
866}
867
868TEST_F(OmahaRequestActionTest,
869 ValidUpdateOverCellularAllowedByUserPermissionTrue) {
870 // This test tests that, when device policy is not set, update over cellular
871 // is allowed as permission for update over cellular is set to true.
Weidong Guo421ff332017-04-17 10:08:38 -0700872 MockConnectionManager mock_cm;
Weidong Guo421ff332017-04-17 10:08:38 -0700873 fake_prefs_.SetBoolean(kPrefsUpdateOverCellularPermission, true);
874 fake_system_state_.set_connection_manager(&mock_cm);
875
876 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
877 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
878 SetArgPointee<1>(ConnectionTethering::kUnknown),
879 Return(true)));
880 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
881 .WillRepeatedly(Return(false));
882 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
883 .WillRepeatedly(Return(true));
884
Amin Hassani41ac04b2019-03-29 11:31:03 -0700885 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
886
887 ASSERT_TRUE(TestUpdateCheck());
888
Weidong Guo421ff332017-04-17 10:08:38 -0700889 EXPECT_TRUE(response.update_exists);
890}
891
892TEST_F(OmahaRequestActionTest,
893 ValidUpdateOverCellularBlockedByUpdateTargetNotMatch) {
894 // This test tests that, when device policy is not set and permission for
895 // update over cellular is set to false or does not exist, update over
896 // cellular is blocked as update target does not match the omaha response.
Weidong Guo421ff332017-04-17 10:08:38 -0700897 MockConnectionManager mock_cm;
898 // A version different from the version in omaha response.
899 string diff_version = "99.99.99";
900 // A size different from the size in omaha response.
901 int64_t diff_size = 999;
902
903 fake_prefs_.SetString(kPrefsUpdateOverCellularTargetVersion, diff_version);
904 fake_prefs_.SetInt64(kPrefsUpdateOverCellularTargetSize, diff_size);
905 // This test tests cellular (3G) being the only connection type being allowed.
906 fake_system_state_.set_connection_manager(&mock_cm);
907
908 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
909 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
910 SetArgPointee<1>(ConnectionTethering::kUnknown),
911 Return(true)));
912 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
913 .WillRepeatedly(Return(false));
914 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
915 .WillRepeatedly(Return(true));
916
Amin Hassani41ac04b2019-03-29 11:31:03 -0700917 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
918 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredOverCellular;
919 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
920
921 ASSERT_FALSE(TestUpdateCheck());
922
Weidong Guo421ff332017-04-17 10:08:38 -0700923 EXPECT_FALSE(response.update_exists);
924}
925
926TEST_F(OmahaRequestActionTest,
927 ValidUpdateOverCellularAllowedByUpdateTargetMatch) {
928 // This test tests that, when device policy is not set and permission for
929 // update over cellular is set to false or does not exist, update over
930 // cellular is allowed as update target matches the omaha response.
Weidong Guo421ff332017-04-17 10:08:38 -0700931 MockConnectionManager mock_cm;
932 // A version same as the version in omaha response.
933 string new_version = fake_update_response_.version;
934 // A size same as the size in omaha response.
935 int64_t new_size = fake_update_response_.size;
936
937 fake_prefs_.SetString(kPrefsUpdateOverCellularTargetVersion, new_version);
938 fake_prefs_.SetInt64(kPrefsUpdateOverCellularTargetSize, new_size);
939 fake_system_state_.set_connection_manager(&mock_cm);
940
941 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
942 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
943 SetArgPointee<1>(ConnectionTethering::kUnknown),
944 Return(true)));
945 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
946 .WillRepeatedly(Return(false));
947 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
948 .WillRepeatedly(Return(true));
949
Amin Hassani41ac04b2019-03-29 11:31:03 -0700950 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
951
952 ASSERT_TRUE(TestUpdateCheck());
953
Weidong Guo421ff332017-04-17 10:08:38 -0700954 EXPECT_TRUE(response.update_exists);
955}
956
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700957TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByRollback) {
Chris Sosa77f79e82014-06-02 18:16:24 -0700958 string rollback_version = "1234.0.0";
Chris Sosa77f79e82014-06-02 18:16:24 -0700959 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700960 fake_system_state_.set_payload_state(&mock_payload_state);
Amin Hassani41ac04b2019-03-29 11:31:03 -0700961 fake_update_response_.version = rollback_version;
962 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
963 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredPerPolicy;
964 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700965
Chris Sosa77f79e82014-06-02 18:16:24 -0700966 EXPECT_CALL(mock_payload_state, GetRollbackVersion())
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800967 .WillRepeatedly(Return(rollback_version));
Chris Sosa77f79e82014-06-02 18:16:24 -0700968
Amin Hassani41ac04b2019-03-29 11:31:03 -0700969 ASSERT_FALSE(TestUpdateCheck());
970
Chris Sosa77f79e82014-06-02 18:16:24 -0700971 EXPECT_FALSE(response.update_exists);
972}
973
Marton Hunyadyc2882062018-05-14 17:28:25 +0200974// Verify that update checks called during OOBE will not try to download an
975// update if the response doesn't include the deadline field.
Kevin Cernekee2494e282016-03-29 18:03:53 -0700976TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBE) {
Marton Hunyadyc2882062018-05-14 17:28:25 +0200977 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Amin Hassani41ac04b2019-03-29 11:31:03 -0700978 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
979 tuc_params_.expected_code = ErrorCode::kNonCriticalUpdateInOOBE;
980 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
981 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Kevin Cernekee2494e282016-03-29 18:03:53 -0700982
Sen Jiang8cd42342018-01-31 12:06:59 -0800983 // TODO(senj): set better default value for metrics::checkresult in
Tianjie Xu282aa1f2017-09-05 13:42:45 -0700984 // OmahaRequestAction::ActionCompleted.
Amin Hassani41ac04b2019-03-29 11:31:03 -0700985 ASSERT_FALSE(TestUpdateCheck());
986
Kevin Cernekee2494e282016-03-29 18:03:53 -0700987 EXPECT_FALSE(response.update_exists);
Marton Hunyadyc2882062018-05-14 17:28:25 +0200988}
Kevin Cernekee2494e282016-03-29 18:03:53 -0700989
Marton Hunyadyc2882062018-05-14 17:28:25 +0200990// Verify that the IsOOBEComplete() value is ignored when the OOBE flow is not
991// enabled.
992TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBEDisabled) {
Marton Hunyadyc2882062018-05-14 17:28:25 +0200993 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Alex Deymo46a9aae2016-05-04 20:20:11 -0700994 fake_system_state_.fake_hardware()->SetIsOOBEEnabled(false);
Amin Hassani41ac04b2019-03-29 11:31:03 -0700995 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo46a9aae2016-05-04 20:20:11 -0700996
Amin Hassani41ac04b2019-03-29 11:31:03 -0700997 ASSERT_TRUE(TestUpdateCheck());
998
Kevin Cernekee2494e282016-03-29 18:03:53 -0700999 EXPECT_TRUE(response.update_exists);
1000}
1001
Marton Hunyadyc2882062018-05-14 17:28:25 +02001002// Verify that update checks called during OOBE will still try to download an
1003// update if the response includes the deadline field.
1004TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBEDeadlineSet) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001005 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1006 fake_update_response_.deadline = "20101020";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001007 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Marton Hunyadyc2882062018-05-14 17:28:25 +02001008
Amin Hassani41ac04b2019-03-29 11:31:03 -07001009 ASSERT_TRUE(TestUpdateCheck());
1010
Marton Hunyadyc2882062018-05-14 17:28:25 +02001011 EXPECT_TRUE(response.update_exists);
1012}
1013
1014// Verify that update checks called during OOBE will not try to download an
1015// update if a rollback happened, even when the response includes the deadline
1016// field.
1017TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBERollback) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001018 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1019 fake_update_response_.deadline = "20101020";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001020 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1021 tuc_params_.expected_code = ErrorCode::kNonCriticalUpdateInOOBE;
1022 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1023 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1024
Marton Hunyadyc2882062018-05-14 17:28:25 +02001025 EXPECT_CALL(*(fake_system_state_.mock_payload_state()), GetRollbackHappened())
1026 .WillOnce(Return(true));
1027
Amin Hassani41ac04b2019-03-29 11:31:03 -07001028 ASSERT_FALSE(TestUpdateCheck());
1029
Marton Hunyadyc2882062018-05-14 17:28:25 +02001030 EXPECT_FALSE(response.update_exists);
1031}
1032
Toni Barzic61544e62018-10-11 14:37:30 -07001033// Verify that non-critical updates are skipped by reporting the
1034// kNonCriticalUpdateInOOBE error code when attempted over cellular network -
1035// i.e. when the update would need user permission. Note that reporting
1036// kOmahaUpdateIgnoredOverCellular error in this case might cause undesired UX
1037// in OOBE (warning the user about an update that will be skipped).
1038TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesInOOBEOverCellular) {
Toni Barzic61544e62018-10-11 14:37:30 -07001039 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1040
1041 MockConnectionManager mock_cm;
1042 fake_system_state_.set_connection_manager(&mock_cm);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001043 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1044 tuc_params_.expected_code = ErrorCode::kNonCriticalUpdateInOOBE;
1045 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1046 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Toni Barzic61544e62018-10-11 14:37:30 -07001047
1048 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
1049 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
1050 SetArgPointee<1>(ConnectionTethering::kUnknown),
1051 Return(true)));
1052 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
1053 .WillRepeatedly(Return(false));
1054
Amin Hassani41ac04b2019-03-29 11:31:03 -07001055 ASSERT_FALSE(TestUpdateCheck());
1056
Toni Barzic61544e62018-10-11 14:37:30 -07001057 EXPECT_FALSE(response.update_exists);
1058}
1059
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001060TEST_F(OmahaRequestActionTest, WallClockBasedWaitAloneCausesScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001061 request_params_.set_wall_clock_based_wait_enabled(true);
1062 request_params_.set_update_check_count_wait_enabled(false);
1063 request_params_.set_waiting_period(TimeDelta::FromDays(2));
May Lippert60aa3ca2018-08-15 16:55:29 -07001064 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001065 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1066 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1067 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
May Lippert60aa3ca2018-08-15 16:55:29 -07001068
Amin Hassani41ac04b2019-03-29 11:31:03 -07001069 ASSERT_FALSE(TestUpdateCheck());
1070
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001071 EXPECT_FALSE(response.update_exists);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001072}
1073
1074TEST_F(OmahaRequestActionTest,
1075 WallClockBasedWaitAloneCausesScatteringInteractive) {
1076 request_params_.set_wall_clock_based_wait_enabled(true);
1077 request_params_.set_update_check_count_wait_enabled(false);
1078 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1079 request_params_.set_interactive(true);
1080 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1081 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Chris Sosa968d0572013-08-23 14:46:02 -07001082
1083 // Verify if we are interactive check we don't defer.
Amin Hassani41ac04b2019-03-29 11:31:03 -07001084 ASSERT_TRUE(TestUpdateCheck());
1085
Chris Sosa968d0572013-08-23 14:46:02 -07001086 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001087}
1088
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001089TEST_F(OmahaRequestActionTest, NoWallClockBasedWaitCausesNoScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001090 request_params_.set_wall_clock_based_wait_enabled(false);
1091 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1092 request_params_.set_update_check_count_wait_enabled(true);
1093 request_params_.set_min_update_checks_needed(1);
1094 request_params_.set_max_update_checks_allowed(8);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001095 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001096
Amin Hassani41ac04b2019-03-29 11:31:03 -07001097 ASSERT_TRUE(TestUpdateCheck());
1098
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001099 EXPECT_TRUE(response.update_exists);
1100}
1101
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001102TEST_F(OmahaRequestActionTest, ZeroMaxDaysToScatterCausesNoScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001103 request_params_.set_wall_clock_based_wait_enabled(true);
1104 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1105 request_params_.set_update_check_count_wait_enabled(true);
1106 request_params_.set_min_update_checks_needed(1);
1107 request_params_.set_max_update_checks_allowed(8);
Alex Deymo8e18f932015-03-27 16:16:59 -07001108 fake_update_response_.max_days_to_scatter = "0";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001109 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1110
1111 ASSERT_TRUE(TestUpdateCheck());
1112
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001113 EXPECT_TRUE(response.update_exists);
1114}
1115
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001116TEST_F(OmahaRequestActionTest, ZeroUpdateCheckCountCausesNoScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001117 request_params_.set_wall_clock_based_wait_enabled(true);
1118 request_params_.set_waiting_period(TimeDelta());
1119 request_params_.set_update_check_count_wait_enabled(true);
1120 request_params_.set_min_update_checks_needed(0);
1121 request_params_.set_max_update_checks_allowed(0);
May Lippert60aa3ca2018-08-15 16:55:29 -07001122 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001123 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
May Lippert60aa3ca2018-08-15 16:55:29 -07001124
Amin Hassani41ac04b2019-03-29 11:31:03 -07001125 ASSERT_TRUE(TestUpdateCheck());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001126
Ben Chan9abb7632014-08-07 00:10:53 -07001127 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001128 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001129 ASSERT_EQ(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001130 EXPECT_TRUE(response.update_exists);
1131}
1132
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001133TEST_F(OmahaRequestActionTest, NonZeroUpdateCheckCountCausesScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001134 request_params_.set_wall_clock_based_wait_enabled(true);
1135 request_params_.set_waiting_period(TimeDelta());
1136 request_params_.set_update_check_count_wait_enabled(true);
1137 request_params_.set_min_update_checks_needed(1);
1138 request_params_.set_max_update_checks_allowed(8);
May Lippert60aa3ca2018-08-15 16:55:29 -07001139 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001140 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1141 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1142 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
May Lippert60aa3ca2018-08-15 16:55:29 -07001143
Amin Hassani41ac04b2019-03-29 11:31:03 -07001144 ASSERT_FALSE(TestUpdateCheck());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001145
Ben Chan9abb7632014-08-07 00:10:53 -07001146 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001147 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001148 ASSERT_GT(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001149 EXPECT_FALSE(response.update_exists);
1150}
1151
Amin Hassani41ac04b2019-03-29 11:31:03 -07001152TEST_F(OmahaRequestActionTest,
1153 NonZeroUpdateCheckCountCausesScatteringInteractive) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001154 request_params_.set_wall_clock_based_wait_enabled(true);
1155 request_params_.set_waiting_period(TimeDelta());
1156 request_params_.set_update_check_count_wait_enabled(true);
1157 request_params_.set_min_update_checks_needed(1);
1158 request_params_.set_max_update_checks_allowed(8);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001159 request_params_.set_interactive(true);
May Lippert60aa3ca2018-08-15 16:55:29 -07001160 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001161 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1162
1163 // Verify if we are interactive check we don't defer.
1164 ASSERT_TRUE(TestUpdateCheck());
1165
1166 EXPECT_TRUE(response.update_exists);
1167}
1168
1169TEST_F(OmahaRequestActionTest, ExistingUpdateCheckCountCausesScattering) {
1170 request_params_.set_wall_clock_based_wait_enabled(true);
1171 request_params_.set_waiting_period(TimeDelta());
1172 request_params_.set_update_check_count_wait_enabled(true);
1173 request_params_.set_min_update_checks_needed(1);
1174 request_params_.set_max_update_checks_allowed(8);
1175 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1176 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1177 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1178 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
May Lippert60aa3ca2018-08-15 16:55:29 -07001179
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001180 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsUpdateCheckCount, 5));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001181 ASSERT_FALSE(TestUpdateCheck());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001182
Ben Chan9abb7632014-08-07 00:10:53 -07001183 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001184 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001185 // |count| remains the same, as the decrementing happens in update_attempter
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001186 // which this test doesn't exercise.
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001187 ASSERT_EQ(count, 5);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001188 EXPECT_FALSE(response.update_exists);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001189}
1190
1191TEST_F(OmahaRequestActionTest,
1192 ExistingUpdateCheckCountCausesScatteringInteractive) {
1193 request_params_.set_wall_clock_based_wait_enabled(true);
1194 request_params_.set_waiting_period(TimeDelta());
1195 request_params_.set_update_check_count_wait_enabled(true);
1196 request_params_.set_min_update_checks_needed(1);
1197 request_params_.set_max_update_checks_allowed(8);
1198 request_params_.set_interactive(true);
1199 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1200 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1201
1202 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsUpdateCheckCount, 5));
Chris Sosa968d0572013-08-23 14:46:02 -07001203
1204 // Verify if we are interactive check we don't defer.
Amin Hassani41ac04b2019-03-29 11:31:03 -07001205 ASSERT_TRUE(TestUpdateCheck());
Chris Sosa968d0572013-08-23 14:46:02 -07001206 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001207}
Jay Srinivasan0a708742012-03-20 11:26:12 -07001208
Adolfo Victoria497044c2018-07-18 07:51:42 -07001209TEST_F(OmahaRequestActionTest, StagingTurnedOnCausesScattering) {
1210 // If staging is on, the value for max days to scatter should be ignored, and
1211 // staging's scatter value should be used.
Adolfo Victoria497044c2018-07-18 07:51:42 -07001212 request_params_.set_wall_clock_based_wait_enabled(true);
1213 request_params_.set_waiting_period(TimeDelta::FromDays(6));
1214 request_params_.set_update_check_count_wait_enabled(false);
May Lippert60aa3ca2018-08-15 16:55:29 -07001215 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1216
Adolfo Victoria497044c2018-07-18 07:51:42 -07001217 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsWallClockStagingWaitPeriod, 6));
1218 // This should not prevent scattering due to staging.
1219 fake_update_response_.max_days_to_scatter = "0";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001220 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1221 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1222 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
1223
1224 ASSERT_FALSE(TestUpdateCheck());
1225
Adolfo Victoria497044c2018-07-18 07:51:42 -07001226 EXPECT_FALSE(response.update_exists);
1227
1228 // Interactive updates should not be affected.
1229 request_params_.set_interactive(true);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001230 tuc_params_.expected_code = ErrorCode::kSuccess;
1231 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUpdating;
1232
1233 ASSERT_TRUE(TestUpdateCheck());
1234
Adolfo Victoria497044c2018-07-18 07:51:42 -07001235 EXPECT_TRUE(response.update_exists);
1236}
1237
Alex Deymo8e18f932015-03-27 16:16:59 -07001238TEST_F(OmahaRequestActionTest, CohortsArePersisted) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001239 fake_update_response_.include_cohorts = true;
1240 fake_update_response_.cohort = "s/154454/8479665";
1241 fake_update_response_.cohorthint = "please-put-me-on-beta";
1242 fake_update_response_.cohortname = "stable";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001243 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo8e18f932015-03-27 16:16:59 -07001244
Amin Hassani41ac04b2019-03-29 11:31:03 -07001245 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo8e18f932015-03-27 16:16:59 -07001246
1247 string value;
1248 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1249 EXPECT_EQ(fake_update_response_.cohort, value);
1250
1251 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1252 EXPECT_EQ(fake_update_response_.cohorthint, value);
1253
1254 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1255 EXPECT_EQ(fake_update_response_.cohortname, value);
1256}
1257
1258TEST_F(OmahaRequestActionTest, CohortsAreUpdated) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001259 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
1260 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortHint, "old_hint"));
1261 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortName, "old_name"));
1262 fake_update_response_.include_cohorts = true;
1263 fake_update_response_.cohort = "s/154454/8479665";
1264 fake_update_response_.cohorthint = "please-put-me-on-beta";
1265 fake_update_response_.cohortname = "";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001266 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo8e18f932015-03-27 16:16:59 -07001267
Amin Hassani41ac04b2019-03-29 11:31:03 -07001268 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo8e18f932015-03-27 16:16:59 -07001269
1270 string value;
1271 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1272 EXPECT_EQ(fake_update_response_.cohort, value);
1273
1274 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1275 EXPECT_EQ(fake_update_response_.cohorthint, value);
1276
1277 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1278}
1279
1280TEST_F(OmahaRequestActionTest, CohortsAreNotModifiedWhenMissing) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001281 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo8e18f932015-03-27 16:16:59 -07001282
Amin Hassani41ac04b2019-03-29 11:31:03 -07001283 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
1284 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo8e18f932015-03-27 16:16:59 -07001285
1286 string value;
1287 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1288 EXPECT_EQ("old_value", value);
1289
1290 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1291 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1292}
1293
Alex Deymo00d79ac2015-06-29 15:41:49 -07001294TEST_F(OmahaRequestActionTest, CohortsArePersistedWhenNoUpdate) {
Alex Deymo00d79ac2015-06-29 15:41:49 -07001295 fake_update_response_.include_cohorts = true;
1296 fake_update_response_.cohort = "s/154454/8479665";
1297 fake_update_response_.cohorthint = "please-put-me-on-beta";
1298 fake_update_response_.cohortname = "stable";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001299 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1300 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1301 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Alex Deymo00d79ac2015-06-29 15:41:49 -07001302
Amin Hassani41ac04b2019-03-29 11:31:03 -07001303 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo00d79ac2015-06-29 15:41:49 -07001304
1305 string value;
1306 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1307 EXPECT_EQ(fake_update_response_.cohort, value);
1308
1309 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1310 EXPECT_EQ(fake_update_response_.cohorthint, value);
1311
1312 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1313 EXPECT_EQ(fake_update_response_.cohortname, value);
1314}
1315
Sen Jiangb1e063a2017-09-15 17:44:31 -07001316TEST_F(OmahaRequestActionTest, MultiAppCohortTest) {
Sen Jiangb1e063a2017-09-15 17:44:31 -07001317 fake_update_response_.multi_app = true;
1318 fake_update_response_.include_cohorts = true;
1319 fake_update_response_.cohort = "s/154454/8479665";
1320 fake_update_response_.cohorthint = "please-put-me-on-beta";
1321 fake_update_response_.cohortname = "stable";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001322 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Sen Jiangb1e063a2017-09-15 17:44:31 -07001323
Amin Hassani41ac04b2019-03-29 11:31:03 -07001324 ASSERT_TRUE(TestUpdateCheck());
Sen Jiangb1e063a2017-09-15 17:44:31 -07001325
1326 string value;
1327 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1328 EXPECT_EQ(fake_update_response_.cohort, value);
1329
1330 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1331 EXPECT_EQ(fake_update_response_.cohorthint, value);
1332
1333 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1334 EXPECT_EQ(fake_update_response_.cohortname, value);
1335}
1336
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001337TEST_F(OmahaRequestActionTest, NoOutputPipeTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001338 const string http_response(fake_update_response_.GetNoUpdateResponse());
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001339 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -07001340 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001341
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001342 auto action = std::make_unique<OmahaRequestAction>(
Ben Chan5c02c132017-06-27 07:10:36 -07001343 &fake_system_state_,
1344 nullptr,
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001345 std::make_unique<MockHttpFetcher>(
1346 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001347 false,
1348 "");
Darin Petkov6a5b3222010-07-13 14:55:28 -07001349 ActionProcessor processor;
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001350 processor.set_delegate(&delegate_);
1351 processor.EnqueueAction(std::move(action));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001352
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -07001353 loop.PostTask(base::Bind(
1354 [](ActionProcessor* processor) { processor->StartProcessing(); },
1355 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -07001356 loop.Run();
1357 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001358 EXPECT_FALSE(processor.IsRunning());
1359}
1360
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001361TEST_F(OmahaRequestActionTest, InvalidXmlTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001362 tuc_params_.http_response = "invalid xml>";
1363 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1364 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1365 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1366
1367 ASSERT_FALSE(TestUpdateCheck());
Darin Petkovedc522e2010-11-05 09:35:17 -07001368 EXPECT_FALSE(response.update_exists);
1369}
1370
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001371TEST_F(OmahaRequestActionTest, EmptyResponseTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001372 tuc_params_.expected_code = ErrorCode::kOmahaRequestEmptyResponseError;
1373 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1374 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1375
1376 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001377 EXPECT_FALSE(response.update_exists);
1378}
1379
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001380TEST_F(OmahaRequestActionTest, MissingStatusTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001381 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001382 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1383 "<daystart elapsed_seconds=\"100\"/>"
1384 "<app appid=\"foo\" status=\"ok\">"
1385 "<ping status=\"ok\"/>"
Amin Hassani41ac04b2019-03-29 11:31:03 -07001386 "<updatecheck/></app></response>";
1387 tuc_params_.expected_code = ErrorCode::kOmahaResponseInvalid;
1388 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1389 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1390
1391 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001392 EXPECT_FALSE(response.update_exists);
1393}
1394
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001395TEST_F(OmahaRequestActionTest, InvalidStatusTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001396 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001397 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1398 "<daystart elapsed_seconds=\"100\"/>"
1399 "<app appid=\"foo\" status=\"ok\">"
1400 "<ping status=\"ok\"/>"
Amin Hassani41ac04b2019-03-29 11:31:03 -07001401 "<updatecheck status=\"InvalidStatusTest\"/></app></response>";
1402 tuc_params_.expected_code = ErrorCode::kOmahaResponseInvalid;
1403 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1404 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1405
1406 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001407 EXPECT_FALSE(response.update_exists);
1408}
1409
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001410TEST_F(OmahaRequestActionTest, MissingNodesetTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001411 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001412 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1413 "<daystart elapsed_seconds=\"100\"/>"
1414 "<app appid=\"foo\" status=\"ok\">"
1415 "<ping status=\"ok\"/>"
Amin Hassani41ac04b2019-03-29 11:31:03 -07001416 "</app></response>";
1417 tuc_params_.expected_code = ErrorCode::kOmahaResponseInvalid;
1418 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1419 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1420
1421 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001422 EXPECT_FALSE(response.update_exists);
1423}
1424
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001425TEST_F(OmahaRequestActionTest, MissingFieldTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001426 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001427 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1428 "<daystart elapsed_seconds=\"100\"/>"
Aaron Wood7dcdedf2017-09-06 17:17:41 -07001429 // the appid needs to match that in the request params
1430 "<app appid=\"" +
1431 fake_update_response_.app_id +
1432 "\" status=\"ok\">"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001433 "<updatecheck status=\"ok\">"
1434 "<urls><url codebase=\"http://missing/field/test/\"/></urls>"
Chris Sosa3b748432013-06-20 16:42:59 -07001435 "<manifest version=\"10.2.3.4\">"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001436 "<packages><package hash=\"not-used\" name=\"f\" "
Sen Jiang2703ef42017-03-16 13:36:21 -07001437 "size=\"587\" hash_sha256=\"lkq34j5345\"/></packages>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001438 "<actions><action event=\"postinstall\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001439 "Prompt=\"false\" "
Jay Srinivasand671e972013-01-11 17:17:19 -08001440 "IsDeltaPayload=\"false\" "
Sen Jiang2703ef42017-03-16 13:36:21 -07001441 "sha256=\"not-used\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001442 "/></actions></manifest></updatecheck></app></response>";
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001443
Amin Hassani41ac04b2019-03-29 11:31:03 -07001444 ASSERT_TRUE(TestUpdateCheck());
1445
Darin Petkov6a5b3222010-07-13 14:55:28 -07001446 EXPECT_TRUE(response.update_exists);
Chris Sosa3b748432013-06-20 16:42:59 -07001447 EXPECT_EQ("10.2.3.4", response.version);
Sen Jiang0affc2c2017-02-10 15:55:05 -08001448 EXPECT_EQ("http://missing/field/test/f",
1449 response.packages[0].payload_urls[0]);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001450 EXPECT_EQ("", response.more_info_url);
Sen Jiang0affc2c2017-02-10 15:55:05 -08001451 EXPECT_EQ("lkq34j5345", response.packages[0].hash);
1452 EXPECT_EQ(587u, response.packages[0].size);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001453 EXPECT_FALSE(response.prompt);
Darin Petkov6c118642010-10-21 12:06:30 -07001454 EXPECT_TRUE(response.deadline.empty());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001455}
1456
1457namespace {
1458class TerminateEarlyTestProcessorDelegate : public ActionProcessorDelegate {
1459 public:
1460 void ProcessingStopped(const ActionProcessor* processor) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001461 brillo::MessageLoop::current()->BreakLoop();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001462 }
Darin Petkov6a5b3222010-07-13 14:55:28 -07001463};
1464
Alex Deymo60ca1a72015-06-18 18:19:15 -07001465void TerminateTransferTestStarter(ActionProcessor* processor) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001466 processor->StartProcessing();
1467 CHECK(processor->IsRunning());
1468 processor->StopProcessing();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001469}
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001470} // namespace
Darin Petkov6a5b3222010-07-13 14:55:28 -07001471
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001472TEST_F(OmahaRequestActionTest, TerminateTransferTest) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001473 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -07001474 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001475
Alex Deymo60ca1a72015-06-18 18:19:15 -07001476 string http_response("doesn't matter");
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001477 auto action = std::make_unique<OmahaRequestAction>(
Ben Chan5c02c132017-06-27 07:10:36 -07001478 &fake_system_state_,
1479 nullptr,
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001480 std::make_unique<MockHttpFetcher>(
1481 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001482 false,
1483 "");
Darin Petkov6a5b3222010-07-13 14:55:28 -07001484 TerminateEarlyTestProcessorDelegate delegate;
Darin Petkov6a5b3222010-07-13 14:55:28 -07001485 ActionProcessor processor;
1486 processor.set_delegate(&delegate);
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001487 processor.EnqueueAction(std::move(action));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001488
Alex Deymo60ca1a72015-06-18 18:19:15 -07001489 loop.PostTask(base::Bind(&TerminateTransferTestStarter, &processor));
1490 loop.Run();
1491 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001492}
1493
Alex Deymob0d74eb2015-03-30 17:59:17 -07001494TEST_F(OmahaRequestActionTest, XmlEncodeIsUsedForParams) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001495 // Make sure XML Encode is being called on the params.
Marton Hunyady2abda312018-04-24 18:21:49 +02001496 request_params_.set_os_sp("testtheservice_pack>");
1497 request_params_.set_os_board("x86 generic<id");
1498 request_params_.set_current_channel("unittest_track&lt;");
1499 request_params_.set_target_channel("unittest_track&lt;");
Amin Hassani37b67232020-08-13 09:29:48 -07001500 request_params_.set_lts_tag("unittest_hint&lt;");
Marton Hunyady2abda312018-04-24 18:21:49 +02001501 request_params_.set_hwid("<OEM MODEL>");
Alex Deymo8e18f932015-03-27 16:16:59 -07001502 fake_prefs_.SetString(kPrefsOmahaCohort, "evil\nstring");
1503 fake_prefs_.SetString(kPrefsOmahaCohortHint, "evil&string\\");
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001504 fake_prefs_.SetString(
1505 kPrefsOmahaCohortName,
1506 base::JoinString(vector<string>(100, "My spoon is too big."), " "));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001507 tuc_params_.http_response = "invalid xml>";
1508 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1509 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1510 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1511
1512 ASSERT_FALSE(TestUpdateCheck());
1513
Alex Deymo8e18f932015-03-27 16:16:59 -07001514 EXPECT_NE(string::npos, post_str.find("testtheservice_pack&gt;"));
1515 EXPECT_EQ(string::npos, post_str.find("testtheservice_pack>"));
1516 EXPECT_NE(string::npos, post_str.find("x86 generic&lt;id"));
1517 EXPECT_EQ(string::npos, post_str.find("x86 generic<id"));
1518 EXPECT_NE(string::npos, post_str.find("unittest_track&amp;lt;"));
1519 EXPECT_EQ(string::npos, post_str.find("unittest_track&lt;"));
Amin Hassani37b67232020-08-13 09:29:48 -07001520 EXPECT_NE(string::npos, post_str.find("unittest_hint&amp;lt;"));
1521 EXPECT_EQ(string::npos, post_str.find("unittest_hint&lt;"));
Alex Deymo8e18f932015-03-27 16:16:59 -07001522 EXPECT_NE(string::npos, post_str.find("&lt;OEM MODEL&gt;"));
1523 EXPECT_EQ(string::npos, post_str.find("<OEM MODEL>"));
1524 EXPECT_NE(string::npos, post_str.find("cohort=\"evil\nstring\""));
1525 EXPECT_EQ(string::npos, post_str.find("cohorthint=\"evil&string\\\""));
1526 EXPECT_NE(string::npos, post_str.find("cohorthint=\"evil&amp;string\\\""));
1527 // Values from Prefs that are too big are removed from the XML instead of
1528 // encoded.
1529 EXPECT_EQ(string::npos, post_str.find("cohortname="));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001530}
1531
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001532TEST_F(OmahaRequestActionTest, XmlDecodeTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001533 fake_update_response_.deadline = "&lt;20110101";
1534 fake_update_response_.more_info_url = "testthe&lt;url";
1535 fake_update_response_.codebase = "testthe&amp;codebase/";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001536 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1537
1538 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001539
Sen Jiang0affc2c2017-02-10 15:55:05 -08001540 EXPECT_EQ("testthe<url", response.more_info_url);
1541 EXPECT_EQ("testthe&codebase/file.signed",
1542 response.packages[0].payload_urls[0]);
1543 EXPECT_EQ("<20110101", response.deadline);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001544}
1545
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001546TEST_F(OmahaRequestActionTest, ParseIntTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001547 // overflows int32_t:
Sen Jiang0affc2c2017-02-10 15:55:05 -08001548 fake_update_response_.size = 123123123123123ull;
Amin Hassani41ac04b2019-03-29 11:31:03 -07001549 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001550
Amin Hassani41ac04b2019-03-29 11:31:03 -07001551 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang0affc2c2017-02-10 15:55:05 -08001552 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001553}
1554
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001555TEST_F(OmahaRequestActionTest, FormatUpdateCheckOutputTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001556 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001557 fake_system_state_.set_prefs(&prefs);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001558 tuc_params_.http_response = "invalid xml>";
1559 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1560 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1561 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001562
Darin Petkov95508da2011-01-05 12:42:29 -08001563 EXPECT_CALL(prefs, GetString(kPrefsPreviousVersion, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001564 .WillOnce(DoAll(SetArgPointee<1>(string("")), Return(true)));
Alex Deymoefb9d832015-11-02 18:39:02 -08001565 // An existing but empty previous version means that we didn't reboot to a new
1566 // update, therefore, no need to update the previous version.
1567 EXPECT_CALL(prefs, SetString(kPrefsPreviousVersion, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001568 ASSERT_FALSE(TestUpdateCheck());
1569
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001570 EXPECT_NE(
1571 post_str.find(" <ping active=\"1\" a=\"-1\" r=\"-1\"></ping>\n"
1572 " <updatecheck></updatecheck>\n"),
Jay Srinivasan0a708742012-03-20 11:26:12 -07001573 string::npos);
Darin Petkovfbb40092010-07-29 17:05:50 -07001574 EXPECT_NE(post_str.find("hardware_class=\"OEM MODEL 09235 7471\""),
1575 string::npos);
Alex Deymoefb9d832015-11-02 18:39:02 -08001576 // No <event> tag should be sent if we didn't reboot to an update.
1577 EXPECT_EQ(post_str.find("<event"), string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001578}
1579
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001580TEST_F(OmahaRequestActionTest, FormatSuccessEventOutputTest) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001581 TestEvent(new OmahaEvent(OmahaEvent::kTypeUpdateDownloadStarted),
Amin Hassani41ac04b2019-03-29 11:31:03 -07001582 "invalid xml>");
1583
Alex Vakulenko75039d72014-03-25 12:36:28 -07001584 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001585 " <event eventtype=\"%d\" eventresult=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001586 OmahaEvent::kTypeUpdateDownloadStarted,
1587 OmahaEvent::kResultSuccess);
1588 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001589 EXPECT_EQ(post_str.find("ping"), string::npos);
1590 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkove17f86b2010-07-20 09:12:01 -07001591}
1592
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001593TEST_F(OmahaRequestActionTest, FormatErrorEventOutputTest) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001594 TestEvent(new OmahaEvent(OmahaEvent::kTypeDownloadComplete,
Darin Petkove17f86b2010-07-20 09:12:01 -07001595 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001596 ErrorCode::kError),
Amin Hassani41ac04b2019-03-29 11:31:03 -07001597 "invalid xml>");
1598
Alex Vakulenko75039d72014-03-25 12:36:28 -07001599 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001600 " <event eventtype=\"%d\" eventresult=\"%d\" "
1601 "errorcode=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001602 OmahaEvent::kTypeDownloadComplete,
1603 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001604 static_cast<int>(ErrorCode::kError));
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001605 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001606 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001607}
1608
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001609TEST_F(OmahaRequestActionTest, IsEventTest) {
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001610 string http_response("doesn't matter");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001611 OmahaRequestAction update_check_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001612 &fake_system_state_,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001613 nullptr,
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001614 std::make_unique<MockHttpFetcher>(
1615 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001616 false,
1617 "");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001618 EXPECT_FALSE(update_check_action.IsEvent());
1619
1620 OmahaRequestAction event_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001621 &fake_system_state_,
Darin Petkove17f86b2010-07-20 09:12:01 -07001622 new OmahaEvent(OmahaEvent::kTypeUpdateComplete),
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001623 std::make_unique<MockHttpFetcher>(
1624 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001625 false,
1626 "");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001627 EXPECT_TRUE(event_action.IsEvent());
1628}
1629
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001630TEST_F(OmahaRequestActionTest, FormatDeltaOkayOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001631 tuc_params_.http_response = "invalid xml>";
1632 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1633 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1634 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1635
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001636 for (int i = 0; i < 2; i++) {
1637 bool delta_okay = i == 1;
1638 const char* delta_okay_str = delta_okay ? "true" : "false";
Marton Hunyady2abda312018-04-24 18:21:49 +02001639 request_params_.set_delta_okay(delta_okay);
1640
Amin Hassani41ac04b2019-03-29 11:31:03 -07001641 ASSERT_FALSE(TestUpdateCheck());
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001642 EXPECT_NE(
1643 post_str.find(base::StringPrintf(" delta_okay=\"%s\"", delta_okay_str)),
1644 string::npos)
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001645 << "i = " << i;
1646 }
1647}
1648
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001649TEST_F(OmahaRequestActionTest, FormatInteractiveOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001650 tuc_params_.http_response = "invalid xml>";
1651 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1652 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1653 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1654
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001655 for (int i = 0; i < 2; i++) {
1656 bool interactive = i == 1;
Gilad Arnold8a659d82013-01-24 11:26:00 -08001657 const char* interactive_str = interactive ? "ondemandupdate" : "scheduler";
Marton Hunyady2abda312018-04-24 18:21:49 +02001658 request_params_.set_interactive(interactive);
1659
Amin Hassani41ac04b2019-03-29 11:31:03 -07001660 ASSERT_FALSE(TestUpdateCheck());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001661 EXPECT_NE(post_str.find(
1662 base::StringPrintf("installsource=\"%s\"", interactive_str)),
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001663 string::npos)
1664 << "i = " << i;
1665 }
1666}
1667
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001668TEST_F(OmahaRequestActionTest, FormatTargetVersionPrefixOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001669 tuc_params_.http_response = "invalid xml>";
1670 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1671 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1672 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1673
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001674 for (int i = 0; i < 2; i++) {
1675 bool target_version_set = i == 1;
1676 const char* target_version_prefix = target_version_set ? "10032." : "";
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001677 request_params_.set_target_version_prefix(target_version_prefix);
1678
Amin Hassani41ac04b2019-03-29 11:31:03 -07001679 ASSERT_FALSE(TestUpdateCheck());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001680 if (target_version_set) {
1681 EXPECT_NE(post_str.find("<updatecheck targetversionprefix=\"10032.\">"),
1682 string::npos)
1683 << "i = " << i;
1684 } else {
1685 EXPECT_EQ(post_str.find("targetversionprefix"), string::npos)
1686 << "i = " << i;
1687 }
1688 }
1689}
1690
1691TEST_F(OmahaRequestActionTest, FormatRollbackAllowedOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001692 tuc_params_.http_response = "invalid xml>";
1693 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1694 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1695 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1696
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001697 for (int i = 0; i < 4; i++) {
1698 bool rollback_allowed = i / 2 == 0;
1699 bool target_version_set = i % 2 == 0;
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001700 request_params_.set_target_version_prefix(target_version_set ? "10032."
1701 : "");
1702 request_params_.set_rollback_allowed(rollback_allowed);
1703
Amin Hassani41ac04b2019-03-29 11:31:03 -07001704 ASSERT_FALSE(TestUpdateCheck());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001705 if (rollback_allowed && target_version_set) {
1706 EXPECT_NE(post_str.find("rollback_allowed=\"true\""), string::npos)
1707 << "i = " << i;
1708 } else {
1709 EXPECT_EQ(post_str.find("rollback_allowed"), string::npos) << "i = " << i;
1710 }
1711 }
1712}
1713
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001714TEST_F(OmahaRequestActionTest, OmahaEventTest) {
Darin Petkove17f86b2010-07-20 09:12:01 -07001715 OmahaEvent default_event;
1716 EXPECT_EQ(OmahaEvent::kTypeUnknown, default_event.type);
1717 EXPECT_EQ(OmahaEvent::kResultError, default_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001718 EXPECT_EQ(ErrorCode::kError, default_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001719
1720 OmahaEvent success_event(OmahaEvent::kTypeUpdateDownloadStarted);
1721 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadStarted, success_event.type);
1722 EXPECT_EQ(OmahaEvent::kResultSuccess, success_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001723 EXPECT_EQ(ErrorCode::kSuccess, success_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001724
1725 OmahaEvent error_event(OmahaEvent::kTypeUpdateDownloadFinished,
1726 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001727 ErrorCode::kError);
Darin Petkove17f86b2010-07-20 09:12:01 -07001728 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadFinished, error_event.type);
1729 EXPECT_EQ(OmahaEvent::kResultError, error_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001730 EXPECT_EQ(ErrorCode::kError, error_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001731}
1732
Askar Aitzhan570ca872019-04-24 11:16:12 +02001733TEST_F(OmahaRequestActionTest, DeviceQuickFixBuildTokenIsSetTest) {
Askar Aitzhan18fff842019-06-21 23:24:37 +02001734 // If DeviceQuickFixBuildToken value is set it takes precedence over pref
1735 // value.
1736 constexpr char autoupdate_token[] = "autoupdate_token>";
1737 constexpr char xml_encoded_autoupdate_token[] = "autoupdate_token&gt;";
1738 constexpr char omaha_cohort_hint[] = "cohort_hint";
Askar Aitzhan570ca872019-04-24 11:16:12 +02001739
1740 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1741 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1742 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1743 request_params_.set_autoupdate_token(autoupdate_token);
Askar Aitzhan18fff842019-06-21 23:24:37 +02001744 fake_prefs_.SetString(kPrefsOmahaCohortHint, omaha_cohort_hint);
Askar Aitzhan570ca872019-04-24 11:16:12 +02001745
1746 ASSERT_TRUE(TestUpdateCheck());
1747
Askar Aitzhan18fff842019-06-21 23:24:37 +02001748 EXPECT_NE(string::npos,
1749 post_str.find("cohorthint=\"" +
1750 string(xml_encoded_autoupdate_token) + "\""));
1751 EXPECT_EQ(string::npos, post_str.find(autoupdate_token));
1752 EXPECT_EQ(string::npos, post_str.find(omaha_cohort_hint));
1753}
1754
1755TEST_F(OmahaRequestActionTest, DeviceQuickFixBuildTokenIsNotSetTest) {
1756 // If DeviceQuickFixBuildToken is not set, pref value will be provided in
1757 // cohorthint attribute.
1758 constexpr char omaha_cohort_hint[] = "evil_string>";
1759 constexpr char xml_encoded_cohort_hint[] = "evil_string&gt;";
1760
1761 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1762 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1763 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1764 fake_prefs_.SetString(kPrefsOmahaCohortHint, omaha_cohort_hint);
1765
1766 ASSERT_TRUE(TestUpdateCheck());
1767
1768 EXPECT_NE(
1769 string::npos,
1770 post_str.find("cohorthint=\"" + string(xml_encoded_cohort_hint) + "\""));
1771 EXPECT_EQ(string::npos, post_str.find(omaha_cohort_hint));
Askar Aitzhan570ca872019-04-24 11:16:12 +02001772}
1773
Amin Hassani37b67232020-08-13 09:29:48 -07001774TEST_F(OmahaRequestActionTest, TargetChannelHintTest) {
1775 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1776 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1777 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1778 request_params_.set_lts_tag("hint>");
1779
1780 ASSERT_TRUE(TestUpdateCheck());
1781
1782 EXPECT_NE(string::npos, post_str.find("ltstag=\"hint&gt;\""));
1783}
1784
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001785void OmahaRequestActionTest::PingTest(bool ping_only) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001786 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001787 fake_system_state_.set_prefs(&prefs);
1788 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001789 .Times(AnyNumber());
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001790 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
1791 // Add a few hours to the day difference to test no rounding, etc.
1792 int64_t five_days_ago =
1793 (Time::Now() - TimeDelta::FromHours(5 * 24 + 13)).ToInternalValue();
1794 int64_t six_days_ago =
1795 (Time::Now() - TimeDelta::FromHours(6 * 24 + 11)).ToInternalValue();
1796 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001797 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001798 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001799 .WillOnce(DoAll(SetArgPointee<1>(six_days_ago), Return(true)));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001800 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001801 .WillOnce(DoAll(SetArgPointee<1>(five_days_ago), Return(true)));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001802
1803 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1804 tuc_params_.ping_only = ping_only;
1805 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1806 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1807
1808 ASSERT_TRUE(TestUpdateCheck());
1809
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001810 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"6\" r=\"5\"></ping>"),
1811 string::npos);
1812 if (ping_only) {
1813 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
1814 EXPECT_EQ(post_str.find("previousversion"), string::npos);
1815 } else {
1816 EXPECT_NE(post_str.find("updatecheck"), string::npos);
1817 EXPECT_NE(post_str.find("previousversion"), string::npos);
Darin Petkov265f2902011-05-09 15:17:40 -07001818 }
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001819}
1820
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001821TEST_F(OmahaRequestActionTest, PingTestSendOnlyAPing) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001822 PingTest(true /* ping_only */);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001823}
1824
1825TEST_F(OmahaRequestActionTest, PingTestSendAlsoAnUpdateCheck) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001826 PingTest(false /* ping_only */);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001827}
1828
1829TEST_F(OmahaRequestActionTest, ActivePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001830 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001831 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001832 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001833 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001834 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001835 int64_t three_days_ago =
1836 (Time::Now() - TimeDelta::FromHours(3 * 24 + 12)).ToInternalValue();
1837 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001838 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001839 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001840 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001841 .WillOnce(DoAll(SetArgPointee<1>(three_days_ago), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001842 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001843 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001844
1845 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1846 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1847 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1848
1849 ASSERT_TRUE(TestUpdateCheck());
1850
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001851 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"3\"></ping>"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001852}
1853
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001854TEST_F(OmahaRequestActionTest, RollCallPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001855 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001856 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001857 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001858 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001859 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001860 int64_t four_days_ago =
1861 (Time::Now() - TimeDelta::FromHours(4 * 24)).ToInternalValue();
1862 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001863 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001864 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001865 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001866 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001867 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001868 .WillOnce(DoAll(SetArgPointee<1>(four_days_ago), Return(true)));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001869
1870 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1871 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1872 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1873
1874 ASSERT_TRUE(TestUpdateCheck());
1875
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001876 EXPECT_NE(post_str.find("<ping active=\"1\" r=\"4\"></ping>\n"),
Thieu Le116fda32011-04-19 11:01:54 -07001877 string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001878}
1879
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001880TEST_F(OmahaRequestActionTest, NoPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001881 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001882 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001883 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001884 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001885 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001886 int64_t one_hour_ago =
1887 (Time::Now() - TimeDelta::FromHours(1)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001888 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001889 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001890 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001891 .WillOnce(DoAll(SetArgPointee<1>(one_hour_ago), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001892 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001893 .WillOnce(DoAll(SetArgPointee<1>(one_hour_ago), Return(true)));
Alex Deymoebbe7ef2014-10-30 13:02:49 -07001894 // LastActivePingDay and PrefsLastRollCallPingDay are set even if we didn't
1895 // send a ping.
1896 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
1897 .WillOnce(Return(true));
1898 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
1899 .WillOnce(Return(true));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001900
1901 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1902 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1903 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1904
1905 ASSERT_TRUE(TestUpdateCheck());
1906
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001907 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001908}
1909
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001910TEST_F(OmahaRequestActionTest, IgnoreEmptyPingTest) {
Thieu Leb44e9e82011-06-06 14:34:04 -07001911 // This test ensures that we ignore empty ping only requests.
Alex Deymo8427b4a2014-11-05 14:00:32 -08001912 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001913 fake_system_state_.set_prefs(&prefs);
Thieu Leb44e9e82011-06-06 14:34:04 -07001914 int64_t now = Time::Now().ToInternalValue();
1915 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001916 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Thieu Leb44e9e82011-06-06 14:34:04 -07001917 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001918 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Thieu Leb44e9e82011-06-06 14:34:04 -07001919 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
1920 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001921
1922 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1923 tuc_params_.ping_only = true;
1924 tuc_params_.expected_check_result = metrics::CheckResult::kUnset;
1925 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1926
1927 EXPECT_TRUE(TestUpdateCheck());
1928 EXPECT_TRUE(post_str.empty());
Thieu Leb44e9e82011-06-06 14:34:04 -07001929}
1930
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001931TEST_F(OmahaRequestActionTest, BackInTimePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001932 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001933 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001934 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001935 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001936 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001937 int64_t future =
1938 (Time::Now() + TimeDelta::FromHours(3 * 24 + 4)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001939 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001940 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001941 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001942 .WillOnce(DoAll(SetArgPointee<1>(future), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001943 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001944 .WillOnce(DoAll(SetArgPointee<1>(future), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001945 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
1946 .WillOnce(Return(true));
1947 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
1948 .WillOnce(Return(true));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001949
1950 tuc_params_.http_response =
1951 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
1952 "protocol=\"3.0\"><daystart elapsed_seconds=\"100\"/>"
1953 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
1954 "<updatecheck status=\"noupdate\"/></app></response>";
1955 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1956 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1957
1958 ASSERT_TRUE(TestUpdateCheck());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001959 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001960}
1961
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001962TEST_F(OmahaRequestActionTest, LastPingDayUpdateTest) {
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001963 // This test checks that the action updates the last ping day to now
Darin Petkov84c763c2010-07-29 16:27:58 -07001964 // minus 200 seconds with a slack of 5 seconds. Therefore, the test
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001965 // may fail if it runs for longer than 5 seconds. It shouldn't run
1966 // that long though.
1967 int64_t midnight =
1968 (Time::Now() - TimeDelta::FromSeconds(200)).ToInternalValue();
1969 int64_t midnight_slack =
1970 (Time::Now() - TimeDelta::FromSeconds(195)).ToInternalValue();
Alex Deymo8427b4a2014-11-05 14:00:32 -08001971 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001972 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001973 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
1974 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001975 EXPECT_CALL(prefs,
1976 SetInt64(kPrefsLastActivePingDay,
1977 AllOf(Ge(midnight), Le(midnight_slack))))
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001978 .WillOnce(Return(true));
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001979 EXPECT_CALL(prefs,
1980 SetInt64(kPrefsLastRollCallPingDay,
1981 AllOf(Ge(midnight), Le(midnight_slack))))
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001982 .WillOnce(Return(true));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001983
1984 tuc_params_.http_response =
1985 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
1986 "protocol=\"3.0\"><daystart elapsed_seconds=\"200\"/>"
1987 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
1988 "<updatecheck status=\"noupdate\"/></app></response>";
1989 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1990 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1991
1992 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001993}
1994
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001995TEST_F(OmahaRequestActionTest, NoElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001996 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001997 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001998 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
1999 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002000 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
2001 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002002
2003 tuc_params_.http_response =
2004 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2005 "protocol=\"3.0\"><daystart blah=\"200\"/>"
2006 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
2007 "<updatecheck status=\"noupdate\"/></app></response>";
2008 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2009 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2010
2011 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002012}
2013
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002014TEST_F(OmahaRequestActionTest, BadElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002015 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002016 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002017 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
2018 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002019 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
2020 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002021
2022 tuc_params_.http_response =
2023 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2024 "protocol=\"3.0\"><daystart elapsed_seconds=\"x\"/>"
2025 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
2026 "<updatecheck status=\"noupdate\"/></app></response>";
2027 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2028 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2029
2030 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002031}
2032
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002033TEST_F(OmahaRequestActionTest, NoUniqueIDTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07002034 tuc_params_.http_response = "invalid xml>";
2035 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
2036 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
2037 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2038
2039 ASSERT_FALSE(TestUpdateCheck());
2040
Darin Petkov84c763c2010-07-29 16:27:58 -07002041 EXPECT_EQ(post_str.find("machineid="), string::npos);
2042 EXPECT_EQ(post_str.find("userid="), string::npos);
2043}
2044
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002045TEST_F(OmahaRequestActionTest, NetworkFailureTest) {
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002046 const int http_error_code =
2047 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 501;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002048 tuc_params_.fail_http_response_code = 501;
2049 tuc_params_.expected_code = static_cast<ErrorCode>(http_error_code);
2050 tuc_params_.expected_check_result = metrics::CheckResult::kDownloadError;
2051 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2052 tuc_params_.expected_download_error_code =
2053 static_cast<metrics::DownloadErrorCode>(501);
2054
2055 ASSERT_FALSE(TestUpdateCheck());
2056
Darin Petkovedc522e2010-11-05 09:35:17 -07002057 EXPECT_FALSE(response.update_exists);
2058}
2059
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002060TEST_F(OmahaRequestActionTest, NetworkFailureBadHTTPCodeTest) {
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002061 const int http_error_code =
2062 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 999;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002063
2064 tuc_params_.fail_http_response_code = 1500;
2065 tuc_params_.expected_code = static_cast<ErrorCode>(http_error_code);
2066 tuc_params_.expected_check_result = metrics::CheckResult::kDownloadError;
2067 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2068 tuc_params_.expected_download_error_code =
2069 metrics::DownloadErrorCode::kHttpStatusOther;
2070
2071 ASSERT_FALSE(TestUpdateCheck());
Darin Petkovedc522e2010-11-05 09:35:17 -07002072 EXPECT_FALSE(response.update_exists);
2073}
2074
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002075TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsPersistedFirstTime) {
Marton Hunyady2abda312018-04-24 18:21:49 +02002076 request_params_.set_wall_clock_based_wait_enabled(true);
2077 request_params_.set_waiting_period(TimeDelta().FromDays(1));
2078 request_params_.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002079
Sen Jiang7c1171e2016-06-23 11:35:40 -07002080 Time arbitrary_date;
Eric Caruso761be2c2018-05-22 16:23:33 -07002081 ASSERT_TRUE(Time::FromString("6/4/1989", &arbitrary_date));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002082 fake_system_state_.fake_clock()->SetWallclockTime(arbitrary_date);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002083
2084 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2085 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
2086 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
2087
2088 ASSERT_FALSE(TestUpdateCheck());
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002089
Ben Chan9abb7632014-08-07 00:10:53 -07002090 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002091 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002092 EXPECT_EQ(arbitrary_date.ToInternalValue(), timestamp);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002093 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -07002094
2095 // Verify if we are interactive check we don't defer.
Marton Hunyady2abda312018-04-24 18:21:49 +02002096 request_params_.set_interactive(true);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002097 tuc_params_.expected_code = ErrorCode::kSuccess;
2098 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUpdating;
2099
2100 ASSERT_TRUE(TestUpdateCheck());
Chris Sosa968d0572013-08-23 14:46:02 -07002101 EXPECT_TRUE(response.update_exists);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002102}
2103
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002104TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsUsedIfAlreadyPresent) {
Marton Hunyady2abda312018-04-24 18:21:49 +02002105 request_params_.set_wall_clock_based_wait_enabled(true);
2106 request_params_.set_waiting_period(TimeDelta().FromDays(1));
2107 request_params_.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002108
Sen Jiang7c1171e2016-06-23 11:35:40 -07002109 Time t1, t2;
Eric Caruso761be2c2018-05-22 16:23:33 -07002110 ASSERT_TRUE(Time::FromString("1/1/2012", &t1));
2111 ASSERT_TRUE(Time::FromString("1/3/2012", &t2));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002112 ASSERT_TRUE(
2113 fake_prefs_.SetInt64(kPrefsUpdateFirstSeenAt, t1.ToInternalValue()));
2114 fake_system_state_.fake_clock()->SetWallclockTime(t2);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002115
Amin Hassani41ac04b2019-03-29 11:31:03 -07002116 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2117
2118 ASSERT_TRUE(TestUpdateCheck());
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002119 EXPECT_TRUE(response.update_exists);
2120
2121 // Make sure the timestamp t1 is unchanged showing that it was reused.
Ben Chan9abb7632014-08-07 00:10:53 -07002122 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002123 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002124 ASSERT_TRUE(timestamp == t1.ToInternalValue());
2125}
2126
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002127TEST_F(OmahaRequestActionTest, TestChangingToMoreStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002128 // Create a uniquely named test directory.
Sen Jiang297e5832016-03-17 14:45:51 -07002129 base::ScopedTempDir tempdir;
2130 ASSERT_TRUE(tempdir.CreateUniqueTempDir());
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002131
Marton Hunyady2abda312018-04-24 18:21:49 +02002132 request_params_.set_root(tempdir.GetPath().value());
2133 request_params_.set_app_id("{22222222-2222-2222-2222-222222222222}");
2134 request_params_.set_app_version("1.2.3.4");
2135 request_params_.set_product_components("o.bundle=1");
2136 request_params_.set_current_channel("canary-channel");
2137 EXPECT_TRUE(
2138 request_params_.SetTargetChannel("stable-channel", true, nullptr));
2139 request_params_.UpdateDownloadChannel();
2140 EXPECT_TRUE(request_params_.ShouldPowerwash());
Amin Hassani41ac04b2019-03-29 11:31:03 -07002141
2142 tuc_params_.http_response = "invalid xml>";
2143 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
2144 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
2145 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2146
2147 ASSERT_FALSE(TestUpdateCheck());
2148
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002149 EXPECT_NE(
2150 string::npos,
2151 post_str.find("appid=\"{22222222-2222-2222-2222-222222222222}\" "
2152 "version=\"0.0.0.0\" from_version=\"1.2.3.4\" "
2153 "track=\"stable-channel\" from_track=\"canary-channel\" "));
Sen Jiang8cd42342018-01-31 12:06:59 -08002154 EXPECT_EQ(string::npos, post_str.find("o.bundle"));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002155}
2156
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002157TEST_F(OmahaRequestActionTest, TestChangingToLessStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002158 // Create a uniquely named test directory.
Sen Jiang297e5832016-03-17 14:45:51 -07002159 base::ScopedTempDir tempdir;
2160 ASSERT_TRUE(tempdir.CreateUniqueTempDir());
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002161
Marton Hunyady2abda312018-04-24 18:21:49 +02002162 request_params_.set_root(tempdir.GetPath().value());
2163 request_params_.set_app_id("{11111111-1111-1111-1111-111111111111}");
2164 request_params_.set_app_version("5.6.7.8");
2165 request_params_.set_product_components("o.bundle=1");
2166 request_params_.set_current_channel("stable-channel");
2167 EXPECT_TRUE(
2168 request_params_.SetTargetChannel("canary-channel", false, nullptr));
2169 request_params_.UpdateDownloadChannel();
2170 EXPECT_FALSE(request_params_.ShouldPowerwash());
Amin Hassani41ac04b2019-03-29 11:31:03 -07002171
2172 tuc_params_.http_response = "invalid xml>";
2173 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
2174 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
2175 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2176
2177 ASSERT_FALSE(TestUpdateCheck());
2178
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002179 EXPECT_NE(
2180 string::npos,
2181 post_str.find("appid=\"{11111111-1111-1111-1111-111111111111}\" "
2182 "version=\"5.6.7.8\" "
2183 "track=\"canary-channel\" from_track=\"stable-channel\""));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002184 EXPECT_EQ(string::npos, post_str.find("from_version"));
Sen Jiang8cd42342018-01-31 12:06:59 -08002185 EXPECT_NE(string::npos, post_str.find("o.bundle.version=\"1\""));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002186}
2187
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002188// Checks that the initial ping with a=-1 r=-1 is not send when the device
2189// was powerwashed.
2190TEST_F(OmahaRequestActionTest, PingWhenPowerwashed) {
2191 fake_prefs_.SetString(kPrefsPreviousVersion, "");
2192
2193 // Flag that the device was powerwashed in the past.
2194 fake_system_state_.fake_hardware()->SetPowerwashCount(1);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002195 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2196 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2197 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002198
Amin Hassani41ac04b2019-03-29 11:31:03 -07002199 ASSERT_TRUE(TestUpdateCheck());
2200
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002201 // We shouldn't send a ping in this case since powerwash > 0.
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002202 EXPECT_EQ(string::npos, post_str.find("<ping"));
2203}
2204
Amin Hassani1677e812017-06-21 13:36:36 -07002205// Checks that the initial ping with a=-1 r=-1 is not send when the device
2206// first_active_omaha_ping_sent is set.
2207TEST_F(OmahaRequestActionTest, PingWhenFirstActiveOmahaPingIsSent) {
2208 fake_prefs_.SetString(kPrefsPreviousVersion, "");
2209
2210 // Flag that the device was not powerwashed in the past.
2211 fake_system_state_.fake_hardware()->SetPowerwashCount(0);
2212
2213 // Flag that the device has sent first active ping in the past.
2214 fake_system_state_.fake_hardware()->SetFirstActiveOmahaPingSent();
2215
Amin Hassani41ac04b2019-03-29 11:31:03 -07002216 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2217 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2218 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2219
2220 ASSERT_TRUE(TestUpdateCheck());
2221
Amin Hassani1677e812017-06-21 13:36:36 -07002222 // We shouldn't send a ping in this case since
2223 // first_active_omaha_ping_sent=true
Amin Hassani1677e812017-06-21 13:36:36 -07002224 EXPECT_EQ(string::npos, post_str.find("<ping"));
2225}
2226
Alex Deymo9fded1e2015-11-05 12:31:19 -08002227// Checks that the event 54 is sent on a reboot to a new update.
2228TEST_F(OmahaRequestActionTest, RebootAfterUpdateEvent) {
2229 // Flag that the device was updated in a previous boot.
2230 fake_prefs_.SetString(kPrefsPreviousVersion, "1.2.3.4");
2231
Amin Hassani41ac04b2019-03-29 11:31:03 -07002232 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2233 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2234 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2235
2236 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo9fded1e2015-11-05 12:31:19 -08002237
2238 // An event 54 is included and has the right version.
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002239 EXPECT_NE(
2240 string::npos,
2241 post_str.find(base::StringPrintf("<event eventtype=\"%d\"",
2242 OmahaEvent::kTypeRebootedAfterUpdate)));
Alex Deymo9fded1e2015-11-05 12:31:19 -08002243 EXPECT_NE(string::npos,
2244 post_str.find("previousversion=\"1.2.3.4\"></event>"));
2245
2246 // The previous version flag should have been removed.
2247 EXPECT_TRUE(fake_prefs_.Exists(kPrefsPreviousVersion));
2248 string prev_version;
2249 EXPECT_TRUE(fake_prefs_.GetString(kPrefsPreviousVersion, &prev_version));
2250 EXPECT_TRUE(prev_version.empty());
2251}
2252
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002253void OmahaRequestActionTest::P2PTest(bool initial_allow_p2p_for_downloading,
2254 bool initial_allow_p2p_for_sharing,
2255 bool omaha_disable_p2p_for_downloading,
2256 bool omaha_disable_p2p_for_sharing,
2257 bool payload_state_allow_p2p_attempt,
2258 bool expect_p2p_client_lookup,
2259 const string& p2p_client_result_url,
2260 bool expected_allow_p2p_for_downloading,
2261 bool expected_allow_p2p_for_sharing,
2262 const string& expected_p2p_url) {
Gilad Arnold74b5f552014-10-07 08:17:16 -07002263 bool actual_allow_p2p_for_downloading = initial_allow_p2p_for_downloading;
2264 bool actual_allow_p2p_for_sharing = initial_allow_p2p_for_sharing;
2265 string actual_p2p_url;
David Zeuthen8f191b22013-08-06 12:27:50 -07002266
2267 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002268 fake_system_state_.set_payload_state(&mock_payload_state);
David Zeuthen8f191b22013-08-06 12:27:50 -07002269 EXPECT_CALL(mock_payload_state, P2PAttemptAllowed())
2270 .WillRepeatedly(Return(payload_state_allow_p2p_attempt));
Gilad Arnold74b5f552014-10-07 08:17:16 -07002271 EXPECT_CALL(mock_payload_state, GetUsingP2PForDownloading())
2272 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_downloading));
2273 EXPECT_CALL(mock_payload_state, GetUsingP2PForSharing())
2274 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_sharing));
2275 EXPECT_CALL(mock_payload_state, SetUsingP2PForDownloading(_))
2276 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_downloading));
2277 EXPECT_CALL(mock_payload_state, SetUsingP2PForSharing(_))
2278 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_sharing));
2279 EXPECT_CALL(mock_payload_state, SetP2PUrl(_))
2280 .WillRepeatedly(SaveArg<0>(&actual_p2p_url));
2281
David Zeuthen8f191b22013-08-06 12:27:50 -07002282 MockP2PManager mock_p2p_manager;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002283 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -07002284 mock_p2p_manager.fake().SetLookupUrlForFileResult(p2p_client_result_url);
2285
David Zeuthen4cc5ed22014-01-15 12:35:03 -08002286 TimeDelta timeout = TimeDelta::FromSeconds(kMaxP2PNetworkWaitTimeSeconds);
2287 EXPECT_CALL(mock_p2p_manager, LookupUrlForFile(_, _, timeout, _))
David Zeuthen8f191b22013-08-06 12:27:50 -07002288 .Times(expect_p2p_client_lookup ? 1 : 0);
2289
Alex Deymo8e18f932015-03-27 16:16:59 -07002290 fake_update_response_.disable_p2p_for_downloading =
2291 omaha_disable_p2p_for_downloading;
2292 fake_update_response_.disable_p2p_for_sharing = omaha_disable_p2p_for_sharing;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002293
2294 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2295 tuc_params_.expected_check_result = metrics::CheckResult::kUpdateAvailable;
2296
2297 ASSERT_TRUE(TestUpdateCheck());
David Zeuthen8f191b22013-08-06 12:27:50 -07002298 EXPECT_TRUE(response.update_exists);
2299
Gilad Arnold74b5f552014-10-07 08:17:16 -07002300 EXPECT_EQ(omaha_disable_p2p_for_downloading,
2301 response.disable_p2p_for_downloading);
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002302 EXPECT_EQ(omaha_disable_p2p_for_sharing, response.disable_p2p_for_sharing);
David Zeuthen8f191b22013-08-06 12:27:50 -07002303
Gilad Arnold74b5f552014-10-07 08:17:16 -07002304 EXPECT_EQ(expected_allow_p2p_for_downloading,
2305 actual_allow_p2p_for_downloading);
2306 EXPECT_EQ(expected_allow_p2p_for_sharing, actual_allow_p2p_for_sharing);
2307 EXPECT_EQ(expected_p2p_url, actual_p2p_url);
David Zeuthen8f191b22013-08-06 12:27:50 -07002308}
2309
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002310TEST_F(OmahaRequestActionTest, P2PWithPeer) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002311 P2PTest(true, // initial_allow_p2p_for_downloading
2312 true, // initial_allow_p2p_for_sharing
2313 false, // omaha_disable_p2p_for_downloading
2314 false, // omaha_disable_p2p_for_sharing
2315 true, // payload_state_allow_p2p_attempt
2316 true, // expect_p2p_client_lookup
2317 "http://1.3.5.7/p2p", // p2p_client_result_url
2318 true, // expected_allow_p2p_for_downloading
2319 true, // expected_allow_p2p_for_sharing
2320 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002321}
2322
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002323TEST_F(OmahaRequestActionTest, P2PWithoutPeer) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002324 P2PTest(true, // initial_allow_p2p_for_downloading
2325 true, // initial_allow_p2p_for_sharing
2326 false, // omaha_disable_p2p_for_downloading
2327 false, // omaha_disable_p2p_for_sharing
2328 true, // payload_state_allow_p2p_attempt
2329 true, // expect_p2p_client_lookup
2330 "", // p2p_client_result_url
2331 false, // expected_allow_p2p_for_downloading
2332 true, // expected_allow_p2p_for_sharing
2333 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002334}
2335
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002336TEST_F(OmahaRequestActionTest, P2PDownloadNotAllowed) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002337 P2PTest(false, // initial_allow_p2p_for_downloading
2338 true, // initial_allow_p2p_for_sharing
2339 false, // omaha_disable_p2p_for_downloading
2340 false, // omaha_disable_p2p_for_sharing
2341 true, // payload_state_allow_p2p_attempt
2342 false, // expect_p2p_client_lookup
2343 "unset", // p2p_client_result_url
2344 false, // expected_allow_p2p_for_downloading
2345 true, // expected_allow_p2p_for_sharing
2346 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002347}
2348
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002349TEST_F(OmahaRequestActionTest, P2PWithPeerDownloadDisabledByOmaha) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002350 P2PTest(true, // initial_allow_p2p_for_downloading
2351 true, // initial_allow_p2p_for_sharing
2352 true, // omaha_disable_p2p_for_downloading
2353 false, // omaha_disable_p2p_for_sharing
2354 true, // payload_state_allow_p2p_attempt
2355 false, // expect_p2p_client_lookup
2356 "unset", // p2p_client_result_url
2357 false, // expected_allow_p2p_for_downloading
2358 true, // expected_allow_p2p_for_sharing
2359 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002360}
2361
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002362TEST_F(OmahaRequestActionTest, P2PWithPeerSharingDisabledByOmaha) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002363 P2PTest(true, // initial_allow_p2p_for_downloading
2364 true, // initial_allow_p2p_for_sharing
2365 false, // omaha_disable_p2p_for_downloading
2366 true, // omaha_disable_p2p_for_sharing
2367 true, // payload_state_allow_p2p_attempt
2368 true, // expect_p2p_client_lookup
2369 "http://1.3.5.7/p2p", // p2p_client_result_url
2370 true, // expected_allow_p2p_for_downloading
2371 false, // expected_allow_p2p_for_sharing
2372 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002373}
2374
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002375TEST_F(OmahaRequestActionTest, P2PWithPeerBothDisabledByOmaha) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002376 P2PTest(true, // initial_allow_p2p_for_downloading
2377 true, // initial_allow_p2p_for_sharing
2378 true, // omaha_disable_p2p_for_downloading
2379 true, // omaha_disable_p2p_for_sharing
2380 true, // payload_state_allow_p2p_attempt
2381 false, // expect_p2p_client_lookup
2382 "unset", // p2p_client_result_url
2383 false, // expected_allow_p2p_for_downloading
2384 false, // expected_allow_p2p_for_sharing
2385 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002386}
2387
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002388bool OmahaRequestActionTest::InstallDateParseHelper(const string& elapsed_days,
2389 OmahaResponse* response) {
Alex Deymo8e18f932015-03-27 16:16:59 -07002390 fake_update_response_.elapsed_days = elapsed_days;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002391 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2392
2393 return TestUpdateCheck();
David Zeuthen639aa362014-02-03 16:23:44 -08002394}
2395
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002396TEST_F(OmahaRequestActionTest, ParseInstallDateFromResponse) {
Kevin Cernekee2494e282016-03-29 18:03:53 -07002397 // Simulate a successful update check that happens during OOBE. The
2398 // deadline in the response is needed to force the update attempt to
2399 // occur; responses without a deadline seen during OOBE will normally
2400 // return ErrorCode::kNonCriticalUpdateInOOBE.
2401 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
2402 fake_update_response_.deadline = "20101020";
2403
David Zeuthen639aa362014-02-03 16:23:44 -08002404 // Check that we parse elapsed_days in the Omaha Response correctly.
2405 // and that the kPrefsInstallDateDays value is written to.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002406 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2407 EXPECT_TRUE(InstallDateParseHelper("42", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002408 EXPECT_TRUE(response.update_exists);
2409 EXPECT_EQ(42, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002410 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002411 int64_t prefs_days;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002412 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002413 EXPECT_EQ(prefs_days, 42);
2414
2415 // If there already is a value set, we shouldn't do anything.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002416 EXPECT_TRUE(InstallDateParseHelper("7", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002417 EXPECT_TRUE(response.update_exists);
2418 EXPECT_EQ(7, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002419 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002420 EXPECT_EQ(prefs_days, 42);
2421
2422 // Note that elapsed_days is not necessarily divisible by 7 so check
2423 // that we round down correctly when populating kPrefsInstallDateDays.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002424 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2425 EXPECT_TRUE(InstallDateParseHelper("23", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002426 EXPECT_TRUE(response.update_exists);
2427 EXPECT_EQ(23, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002428 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002429 EXPECT_EQ(prefs_days, 21);
2430
2431 // Check that we correctly handle elapsed_days not being included in
2432 // the Omaha Response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002433 EXPECT_TRUE(InstallDateParseHelper("", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002434 EXPECT_TRUE(response.update_exists);
2435 EXPECT_EQ(-1, response.install_date_days);
David Zeuthen639aa362014-02-03 16:23:44 -08002436}
2437
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002438// If there is no prefs and OOBE is not complete, we should not
2439// report anything to Omaha.
2440TEST_F(OmahaRequestActionTest, GetInstallDateWhenNoPrefsNorOOBE) {
Kevin Cernekee2494e282016-03-29 18:03:53 -07002441 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002442 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2443 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2444}
David Zeuthen639aa362014-02-03 16:23:44 -08002445
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002446// If OOBE is complete and happened on a valid date (e.g. after Jan
2447// 1 2007 0:00 PST), that date should be used and written to
2448// prefs. However, first try with an invalid date and check we do
2449// nothing.
2450TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithInvalidDate) {
2451 Time oobe_date = Time::FromTimeT(42); // Dec 31, 1969 16:00:42 PST.
2452 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2453 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2454 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2455}
David Zeuthen639aa362014-02-03 16:23:44 -08002456
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002457// Then check with a valid date. The date Jan 20, 2007 0:00 PST
2458// should yield an InstallDate of 14.
2459TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithValidDate) {
2460 Time oobe_date = Time::FromTimeT(1169280000); // Jan 20, 2007 0:00 PST.
2461 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2462 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
2463 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002464
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002465 int64_t prefs_days;
2466 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2467 EXPECT_EQ(prefs_days, 14);
2468}
David Zeuthen639aa362014-02-03 16:23:44 -08002469
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002470// Now that we have a valid date in prefs, check that we keep using
2471// that even if OOBE date reports something else. The date Jan 30,
2472// 2007 0:00 PST should yield an InstallDate of 28... but since
2473// there's a prefs file, we should still get 14.
2474TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedDateChanges) {
2475 // Set a valid date in the prefs first.
2476 EXPECT_TRUE(fake_prefs_.SetInt64(kPrefsInstallDateDays, 14));
David Zeuthen639aa362014-02-03 16:23:44 -08002477
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002478 Time oobe_date = Time::FromTimeT(1170144000); // Jan 30, 2007 0:00 PST.
2479 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2480 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002481
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002482 int64_t prefs_days;
2483 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2484 EXPECT_EQ(prefs_days, 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002485
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002486 // If we delete the prefs file, we should get 28 days.
2487 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2488 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 28);
2489 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2490 EXPECT_EQ(prefs_days, 28);
David Zeuthen639aa362014-02-03 16:23:44 -08002491}
2492
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002493// Verifies that a device with no device policy, and is not a consumer
2494// device sets the max kernel key version to the current version.
2495// ie. the same behavior as if rollback is enabled.
2496TEST_F(OmahaRequestActionTest, NoPolicyEnterpriseDevicesSetMaxRollback) {
2497 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2498
2499 // Setup and verify some initial default values for the kernel TPM
2500 // values that control verified boot and rollback.
2501 const int min_kernel_version = 4;
2502 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2503 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2504 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2505 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2506
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002507 EXPECT_CALL(
2508 *fake_system_state_.mock_metrics_reporter(),
2509 ReportKeyVersionMetrics(min_kernel_version, min_kernel_version, true))
2510 .Times(1);
2511
Amin Hassani41ac04b2019-03-29 11:31:03 -07002512 fake_update_response_.deadline = "20101020";
2513 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2514 tuc_params_.is_consumer_device = false;
2515 tuc_params_.rollback_allowed_milestones = 3;
2516
2517 EXPECT_TRUE(TestUpdateCheck());
2518 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002519
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002520 // Verify kernel_max_rollforward was set to the current minimum
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002521 // kernel key version. This has the effect of freezing roll
2522 // forwards indefinitely. This will hold the rollback window
2523 // open until a future change will be able to move this forward
2524 // relative the configured window.
2525 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2526 EXPECT_EQ(min_kernel_version, fake_hw->GetMaxKernelKeyRollforward());
2527}
2528
2529// Verifies that a conmsumer device with no device policy sets the
2530// max kernel key version to the current version. ie. the same
2531// behavior as if rollback is enabled.
2532TEST_F(OmahaRequestActionTest, NoPolicyConsumerDevicesSetMaxRollback) {
2533 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2534
2535 // Setup and verify some initial default values for the kernel TPM
2536 // values that control verified boot and rollback.
2537 const int min_kernel_version = 3;
2538 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2539 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2540 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2541 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2542
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002543 EXPECT_CALL(
2544 *fake_system_state_.mock_metrics_reporter(),
2545 ReportKeyVersionMetrics(min_kernel_version, kRollforwardInfinity, true))
2546 .Times(1);
2547
Amin Hassani41ac04b2019-03-29 11:31:03 -07002548 fake_update_response_.deadline = "20101020";
2549 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2550 tuc_params_.is_consumer_device = true;
2551 tuc_params_.rollback_allowed_milestones = 3;
2552
2553 EXPECT_TRUE(TestUpdateCheck());
2554 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002555
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002556 // Verify that with rollback disabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002557 // was set to logical infinity. This is the expected behavior for
2558 // consumer devices and matches the existing behavior prior to the
2559 // rollback features.
2560 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2561 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2562}
2563
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002564// Verifies that a device with rollback enabled sets kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002565// in the TPM to prevent roll forward.
2566TEST_F(OmahaRequestActionTest, RollbackEnabledDevicesSetMaxRollback) {
2567 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2568
2569 // Setup and verify some initial default values for the kernel TPM
2570 // values that control verified boot and rollback.
2571 const int allowed_milestones = 4;
2572 const int min_kernel_version = 3;
2573 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2574 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2575 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2576 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2577
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002578 EXPECT_CALL(
2579 *fake_system_state_.mock_metrics_reporter(),
2580 ReportKeyVersionMetrics(min_kernel_version, min_kernel_version, true))
2581 .Times(1);
2582
Amin Hassani41ac04b2019-03-29 11:31:03 -07002583 fake_update_response_.deadline = "20101020";
2584 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2585 tuc_params_.is_consumer_device = false;
2586 tuc_params_.rollback_allowed_milestones = allowed_milestones;
2587 tuc_params_.is_policy_loaded = true;
2588
2589 EXPECT_TRUE(TestUpdateCheck());
2590 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002591
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002592 // Verify that with rollback enabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002593 // was set to the current minimum kernel key version. This has
2594 // the effect of freezing roll forwards indefinitely. This will
2595 // hold the rollback window open until a future change will
2596 // be able to move this forward relative the configured window.
2597 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2598 EXPECT_EQ(min_kernel_version, fake_hw->GetMaxKernelKeyRollforward());
2599}
2600
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002601// Verifies that a device with rollback disabled sets kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002602// in the TPM to logical infinity, to allow roll forward.
2603TEST_F(OmahaRequestActionTest, RollbackDisabledDevicesSetMaxRollback) {
2604 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2605
2606 // Setup and verify some initial default values for the kernel TPM
2607 // values that control verified boot and rollback.
2608 const int allowed_milestones = 0;
2609 const int min_kernel_version = 3;
2610 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2611 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2612 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2613 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2614
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002615 EXPECT_CALL(
2616 *fake_system_state_.mock_metrics_reporter(),
2617 ReportKeyVersionMetrics(min_kernel_version, kRollforwardInfinity, true))
2618 .Times(1);
2619
Amin Hassani41ac04b2019-03-29 11:31:03 -07002620 fake_update_response_.deadline = "20101020";
2621 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2622 tuc_params_.is_consumer_device = false;
2623 tuc_params_.rollback_allowed_milestones = allowed_milestones;
2624 tuc_params_.is_policy_loaded = true;
2625
2626 EXPECT_TRUE(TestUpdateCheck());
2627 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002628
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002629 // Verify that with rollback disabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002630 // was set to logical infinity.
2631 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2632 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2633}
2634
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002635TEST_F(OmahaRequestActionTest, RollbackResponseParsedNoEntries) {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002636 fake_update_response_.rollback = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002637 fake_update_response_.deadline = "20101020";
2638 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2639 tuc_params_.is_consumer_device = false;
2640 tuc_params_.rollback_allowed_milestones = 4;
2641 tuc_params_.is_policy_loaded = true;
2642
2643 EXPECT_TRUE(TestUpdateCheck());
2644 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002645 EXPECT_TRUE(response.is_rollback);
2646}
2647
2648TEST_F(OmahaRequestActionTest, RollbackResponseValidVersionsParsed) {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002649 fake_update_response_.rollback_firmware_version = "1.2";
2650 fake_update_response_.rollback_kernel_version = "3.4";
2651 fake_update_response_.rollback = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002652 fake_update_response_.deadline = "20101020";
2653 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2654 tuc_params_.is_consumer_device = false;
2655 tuc_params_.rollback_allowed_milestones = 4;
2656 tuc_params_.is_policy_loaded = true;
2657
2658 EXPECT_TRUE(TestUpdateCheck());
2659 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002660 EXPECT_TRUE(response.is_rollback);
2661 EXPECT_EQ(1, response.rollback_key_version.firmware_key);
2662 EXPECT_EQ(2, response.rollback_key_version.firmware);
2663 EXPECT_EQ(3, response.rollback_key_version.kernel_key);
2664 EXPECT_EQ(4, response.rollback_key_version.kernel);
2665}
2666
May Lippert60aa3ca2018-08-15 16:55:29 -07002667TEST_F(OmahaRequestActionTest,
2668 TestUpdateFirstSeenAtPrefPersistedIfUpdateExists) {
2669 FakeClock fake_clock;
2670 Time now = Time::Now();
2671 fake_clock.SetWallclockTime(now);
2672 fake_system_state_.set_clock(&fake_clock);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002673 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
May Lippert60aa3ca2018-08-15 16:55:29 -07002674
Amin Hassani41ac04b2019-03-29 11:31:03 -07002675 ASSERT_TRUE(TestUpdateCheck());
2676
May Lippert60aa3ca2018-08-15 16:55:29 -07002677 EXPECT_TRUE(response.update_exists);
2678 EXPECT_TRUE(fake_prefs_.Exists(kPrefsUpdateFirstSeenAt));
2679
2680 int64_t stored_first_seen_at_time;
2681 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt,
2682 &stored_first_seen_at_time));
2683 EXPECT_EQ(now.ToInternalValue(), stored_first_seen_at_time);
2684}
2685
2686TEST_F(OmahaRequestActionTest,
2687 TestUpdateFirstSeenAtPrefNotPersistedIfUpdateFails) {
2688 FakeClock fake_clock;
2689 Time now = Time::Now();
2690 fake_clock.SetWallclockTime(now);
2691 fake_system_state_.set_clock(&fake_clock);
2692
Amin Hassani41ac04b2019-03-29 11:31:03 -07002693 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2694 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2695 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2696
2697 ASSERT_TRUE(TestUpdateCheck());
2698
May Lippert60aa3ca2018-08-15 16:55:29 -07002699 EXPECT_FALSE(response.update_exists);
2700 EXPECT_FALSE(fake_prefs_.Exists(kPrefsUpdateFirstSeenAt));
2701}
2702
Xiaochu Liu88d90382018-08-29 16:09:11 -07002703TEST_F(OmahaRequestActionTest, InstallTest) {
Xiaochu Liu6310be62018-10-11 15:09:03 -07002704 request_params_.set_is_install(true);
Andrewe045aef2020-01-08 16:29:22 -08002705 request_params_.set_dlc_apps_params(
2706 {{request_params_.GetDlcAppId("dlc_no_0"), {.name = "dlc_no_0"}},
2707 {request_params_.GetDlcAppId("dlc_no_1"), {.name = "dlc_no_1"}}});
Amin Hassani41ac04b2019-03-29 11:31:03 -07002708 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2709
2710 ASSERT_TRUE(TestUpdateCheck());
2711
Andrewe045aef2020-01-08 16:29:22 -08002712 for (const auto& it : request_params_.dlc_apps_params()) {
2713 EXPECT_NE(string::npos, post_str.find("appid=\"" + it.first + "\""));
Xiaochu Liu88d90382018-08-29 16:09:11 -07002714 }
Xiaochu Liu6310be62018-10-11 15:09:03 -07002715 EXPECT_NE(string::npos,
2716 post_str.find("appid=\"" + fake_update_response_.app_id + "\""));
2717
2718 // Count number of updatecheck tag in response.
2719 int updatecheck_count = 0;
2720 size_t pos = 0;
2721 while ((pos = post_str.find("<updatecheck", pos)) != string::npos) {
2722 updatecheck_count++;
2723 pos++;
2724 }
Andrewe045aef2020-01-08 16:29:22 -08002725 EXPECT_EQ(request_params_.dlc_apps_params().size(), updatecheck_count);
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002726 EXPECT_TRUE(response.update_exists);
Xiaochu Liu6310be62018-10-11 15:09:03 -07002727}
2728
2729TEST_F(OmahaRequestActionTest, InstallMissingPlatformVersionTest) {
2730 fake_update_response_.multi_app_skip_updatecheck = true;
2731 fake_update_response_.multi_app_no_update = false;
2732 request_params_.set_is_install(true);
Andrewe045aef2020-01-08 16:29:22 -08002733 request_params_.set_dlc_apps_params(
2734 {{request_params_.GetDlcAppId("dlc_no_0"), {.name = "dlc_no_0"}},
2735 {request_params_.GetDlcAppId("dlc_no_1"), {.name = "dlc_no_1"}}});
Xiaochu Liu6310be62018-10-11 15:09:03 -07002736 request_params_.set_app_id(fake_update_response_.app_id_skip_updatecheck);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002737 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2738
2739 ASSERT_TRUE(TestUpdateCheck());
2740
Xiaochu Liu6310be62018-10-11 15:09:03 -07002741 EXPECT_TRUE(response.update_exists);
2742 EXPECT_EQ(fake_update_response_.current_version, response.version);
Xiaochu Liu88d90382018-08-29 16:09:11 -07002743}
2744
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002745TEST_F(OmahaRequestActionTest, UpdateWithDlcTest) {
2746 request_params_.set_dlc_apps_params(
2747 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}}});
2748 fake_update_response_.dlc_app_update = true;
2749 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002750 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002751 ASSERT_TRUE(TestUpdateCheck());
2752
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002753 EXPECT_EQ(response.packages.size(), 2u);
2754 // Two candidate URLs.
2755 EXPECT_EQ(response.packages[1].payload_urls.size(), 2u);
2756 EXPECT_TRUE(response.update_exists);
2757}
2758
2759TEST_F(OmahaRequestActionTest, UpdateWithPartiallyExcludedDlcTest) {
Jae Hoon Kim3e69b4c2020-06-16 09:23:39 -07002760 const string kDlcAppId = request_params_.GetDlcAppId(kDlcId1);
2761 request_params_.set_dlc_apps_params({{kDlcAppId, {.name = kDlcId1}}});
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002762 fake_update_response_.dlc_app_update = true;
2763 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2764 // The first DLC candidate URL is excluded.
2765 EXPECT_CALL(mock_excluder_, IsExcluded(_))
2766 .WillOnce(Return(true))
2767 .WillOnce(Return(false));
2768 ASSERT_TRUE(TestUpdateCheck());
2769
2770 EXPECT_EQ(response.packages.size(), 2u);
2771 // One candidate URL.
2772 EXPECT_EQ(response.packages[1].payload_urls.size(), 1u);
2773 EXPECT_TRUE(response.update_exists);
Jae Hoon Kim3e69b4c2020-06-16 09:23:39 -07002774 EXPECT_TRUE(request_params_.dlc_apps_params().at(kDlcAppId).updated);
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002775}
2776
2777TEST_F(OmahaRequestActionTest, UpdateWithExcludedDlcTest) {
Jae Hoon Kim3e69b4c2020-06-16 09:23:39 -07002778 const string kDlcAppId = request_params_.GetDlcAppId(kDlcId1);
2779 request_params_.set_dlc_apps_params({{kDlcAppId, {.name = kDlcId1}}});
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002780 fake_update_response_.dlc_app_update = true;
2781 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2782 // Both DLC candidate URLs are excluded.
2783 EXPECT_CALL(mock_excluder_, IsExcluded(_))
2784 .WillOnce(Return(true))
2785 .WillOnce(Return(true));
2786 ASSERT_TRUE(TestUpdateCheck());
2787
2788 EXPECT_EQ(response.packages.size(), 1u);
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002789 EXPECT_TRUE(response.update_exists);
Jae Hoon Kim3e69b4c2020-06-16 09:23:39 -07002790 EXPECT_FALSE(request_params_.dlc_apps_params().at(kDlcAppId).updated);
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002791}
2792
2793TEST_F(OmahaRequestActionTest, UpdateWithDeprecatedDlcTest) {
2794 request_params_.set_dlc_apps_params(
2795 {{request_params_.GetDlcAppId(kDlcId2), {.name = kDlcId2}}});
2796 fake_update_response_.dlc_app_no_update = true;
2797 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002798 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002799 ASSERT_TRUE(TestUpdateCheck());
2800
2801 EXPECT_TRUE(response.update_exists);
2802}
2803
2804TEST_F(OmahaRequestActionTest, UpdateWithDlcAndDeprecatedDlcTest) {
2805 request_params_.set_dlc_apps_params(
2806 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}},
2807 {request_params_.GetDlcAppId(kDlcId2), {.name = kDlcId2}}});
2808 fake_update_response_.dlc_app_update = true;
2809 fake_update_response_.dlc_app_no_update = true;
2810 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002811 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002812 ASSERT_TRUE(TestUpdateCheck());
2813
2814 EXPECT_TRUE(response.update_exists);
2815}
2816
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002817TEST_F(OmahaRequestActionTest, PastRollbackVersionsNoEntries) {
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002818 fake_update_response_.rollback = true;
2819 fake_update_response_.rollback_allowed_milestones = 4;
2820 request_params_.set_rollback_allowed_milestones(4);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002821 fake_update_response_.deadline = "20101020";
2822 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2823 tuc_params_.is_consumer_device = false;
2824 tuc_params_.rollback_allowed_milestones = 4;
2825 tuc_params_.is_policy_loaded = true;
2826
2827 EXPECT_TRUE(TestUpdateCheck());
2828 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002829 EXPECT_TRUE(response.is_rollback);
2830 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2831 response.past_rollback_key_version.firmware_key);
2832 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2833 response.past_rollback_key_version.firmware);
2834 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2835 response.past_rollback_key_version.kernel_key);
2836 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2837 response.past_rollback_key_version.kernel);
2838}
2839
2840TEST_F(OmahaRequestActionTest, PastRollbackVersionsValidEntries) {
Bailey Berrof3ce47f2019-02-25 18:22:17 -08002841 request_params_.set_rollback_allowed_milestones(4);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002842 fake_update_response_.rollback = true;
2843 fake_update_response_.rollback_allowed_milestones = 4;
2844 fake_update_response_.rollback_firmware_version = "4.3";
2845 fake_update_response_.rollback_kernel_version = "2.1";
2846 fake_update_response_.past_rollback_key_version =
2847 std::make_pair("16.15", "14.13");
Amin Hassani41ac04b2019-03-29 11:31:03 -07002848 fake_update_response_.deadline = "20101020";
2849 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2850 tuc_params_.is_consumer_device = false;
2851 tuc_params_.rollback_allowed_milestones = 4;
2852 tuc_params_.is_policy_loaded = true;
2853
2854 EXPECT_TRUE(TestUpdateCheck());
2855 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002856 EXPECT_TRUE(response.is_rollback);
2857 EXPECT_EQ(16, response.past_rollback_key_version.firmware_key);
2858 EXPECT_EQ(15, response.past_rollback_key_version.firmware);
2859 EXPECT_EQ(14, response.past_rollback_key_version.kernel_key);
2860 EXPECT_EQ(13, response.past_rollback_key_version.kernel);
2861}
2862
2863TEST_F(OmahaRequestActionTest, MismatchNumberOfVersions) {
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002864 fake_update_response_.rollback = true;
2865 fake_update_response_.rollback_allowed_milestones = 2;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002866 fake_update_response_.deadline = "20101020";
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002867 request_params_.set_rollback_allowed_milestones(4);
2868
2869 // Since |request_params_.rollback_allowed_milestones| is 4 but the response
2870 // is constructed with |fake_update_response_.rollback_allowed_milestones| set
2871 // to 2, OmahaRequestAction will look for the key values of N-4 version but
2872 // only the N-2 version will exist.
Amin Hassani41ac04b2019-03-29 11:31:03 -07002873 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2874 tuc_params_.is_consumer_device = false;
2875 tuc_params_.rollback_allowed_milestones = 2;
2876 tuc_params_.is_policy_loaded = true;
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002877
Amin Hassani41ac04b2019-03-29 11:31:03 -07002878 EXPECT_TRUE(TestUpdateCheck());
2879 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002880 EXPECT_TRUE(response.is_rollback);
2881 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2882 response.past_rollback_key_version.firmware_key);
2883 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2884 response.past_rollback_key_version.firmware);
2885 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2886 response.past_rollback_key_version.kernel_key);
2887 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2888 response.past_rollback_key_version.kernel);
2889}
2890
Matt Ziegelbaumaa8e1a42019-05-09 21:41:58 -04002891TEST_F(OmahaRequestActionTest, IncludeRequisitionTest) {
2892 request_params_.set_device_requisition("remora");
2893 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2894 ASSERT_TRUE(TestUpdateCheck());
2895 EXPECT_NE(string::npos, post_str.find("requisition=\"remora\""));
2896}
2897
2898TEST_F(OmahaRequestActionTest, NoIncludeRequisitionTest) {
2899 request_params_.set_device_requisition("");
2900 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2901 ASSERT_TRUE(TestUpdateCheck());
2902 EXPECT_EQ(string::npos, post_str.find("requisition"));
2903}
2904
Amin Hassani2cbb0692019-10-30 13:36:17 -07002905TEST_F(OmahaRequestActionTest, PersistEolDateTest) {
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002906 tuc_params_.http_response =
2907 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2908 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2909 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
Amin Hassani2cbb0692019-10-30 13:36:17 -07002910 "_eol_date=\"200\" _foo=\"bar\"/></app></response>";
2911 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2912 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2913
2914 ASSERT_TRUE(TestUpdateCheck());
2915
2916 string eol_date;
2917 EXPECT_TRUE(
2918 fake_system_state_.prefs()->GetString(kPrefsOmahaEolDate, &eol_date));
2919 EXPECT_EQ("200", eol_date);
2920}
2921
2922TEST_F(OmahaRequestActionTest, PersistEolMissingDateTest) {
2923 tuc_params_.http_response =
2924 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2925 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2926 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002927 "_foo=\"bar\"/></app></response>";
2928 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2929 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2930
Jae Hoon Kimb3146742019-11-07 13:24:24 -08002931 const string kDate = "123";
2932 fake_system_state_.prefs()->SetString(kPrefsOmahaEolDate, kDate);
2933
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002934 ASSERT_TRUE(TestUpdateCheck());
2935
Amin Hassani2cbb0692019-10-30 13:36:17 -07002936 string eol_date;
Jae Hoon Kimb3146742019-11-07 13:24:24 -08002937 EXPECT_TRUE(
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002938 fake_system_state_.prefs()->GetString(kPrefsOmahaEolDate, &eol_date));
Jae Hoon Kimb3146742019-11-07 13:24:24 -08002939 EXPECT_EQ(kDate, eol_date);
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002940}
2941
Amin Hassani2cbb0692019-10-30 13:36:17 -07002942TEST_F(OmahaRequestActionTest, PersistEolBadDateTest) {
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002943 tuc_params_.http_response =
2944 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2945 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2946 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
Amin Hassani2cbb0692019-10-30 13:36:17 -07002947 "_eol_date=\"bad\" foo=\"bar\"/></app></response>";
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002948 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2949 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2950
2951 ASSERT_TRUE(TestUpdateCheck());
2952
Amin Hassani2cbb0692019-10-30 13:36:17 -07002953 string eol_date;
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002954 EXPECT_TRUE(
2955 fake_system_state_.prefs()->GetString(kPrefsOmahaEolDate, &eol_date));
2956 EXPECT_EQ(kEolDateInvalid, StringToEolDate(eol_date));
2957}
2958
Andrew065d78d2020-04-07 15:43:07 -07002959TEST_F(OmahaRequestActionDlcPingTest, StorePingReplyNoPing) {
2960 OmahaRequestParams::AppParams app_param = {.name = dlc_id_};
Andrewe045aef2020-01-08 16:29:22 -08002961 request_params_.set_dlc_apps_params(
Andrew065d78d2020-04-07 15:43:07 -07002962 {{request_params_.GetDlcAppId(dlc_id_), app_param}});
Andrewe045aef2020-01-08 16:29:22 -08002963
2964 ASSERT_TRUE(TestUpdateCheck());
Andrew065d78d2020-04-07 15:43:07 -07002965
2966 int64_t temp_int;
Andrewe045aef2020-01-08 16:29:22 -08002967 // If there was no ping, the metadata files shouldn't exist yet.
Andrew065d78d2020-04-07 15:43:07 -07002968 EXPECT_FALSE(fake_prefs_.GetInt64(active_key_, &temp_int));
2969 EXPECT_FALSE(fake_prefs_.GetInt64(last_active_key_, &temp_int));
2970 EXPECT_FALSE(fake_prefs_.GetInt64(last_rollcall_key_, &temp_int));
Andrewe045aef2020-01-08 16:29:22 -08002971}
2972
Andrew065d78d2020-04-07 15:43:07 -07002973TEST_F(OmahaRequestActionDlcPingTest, StorePingReplyActiveTest) {
Andrewe045aef2020-01-08 16:29:22 -08002974 // Create Active value
Andrew065d78d2020-04-07 15:43:07 -07002975 fake_prefs_.SetInt64(active_key_, 0);
Andrewe045aef2020-01-08 16:29:22 -08002976
2977 OmahaRequestParams::AppParams app_param = {
2978 .active_counting_type = OmahaRequestParams::kDateBased,
Andrew065d78d2020-04-07 15:43:07 -07002979 .name = dlc_id_,
Andrewe045aef2020-01-08 16:29:22 -08002980 .ping_active = 1,
2981 .send_ping = true};
2982 request_params_.set_dlc_apps_params(
Andrew065d78d2020-04-07 15:43:07 -07002983 {{request_params_.GetDlcAppId(dlc_id_), app_param}});
Andrewe045aef2020-01-08 16:29:22 -08002984
Andrew065d78d2020-04-07 15:43:07 -07002985 int64_t temp_int;
2986 string temp_str;
Andrewe045aef2020-01-08 16:29:22 -08002987 ASSERT_TRUE(TestUpdateCheck());
Andrew065d78d2020-04-07 15:43:07 -07002988 EXPECT_TRUE(fake_prefs_.GetInt64(active_key_, &temp_int));
Andrewe045aef2020-01-08 16:29:22 -08002989 EXPECT_EQ(temp_int, kPingInactiveValue);
Andrew065d78d2020-04-07 15:43:07 -07002990 EXPECT_TRUE(fake_prefs_.GetString(last_active_key_, &temp_str));
2991 EXPECT_EQ(temp_str, "4763");
2992 EXPECT_TRUE(fake_prefs_.GetString(last_rollcall_key_, &temp_str));
2993 EXPECT_EQ(temp_str, "4763");
Andrewe045aef2020-01-08 16:29:22 -08002994}
2995
Andrew065d78d2020-04-07 15:43:07 -07002996TEST_F(OmahaRequestActionDlcPingTest, StorePingReplyInactiveTest) {
Andrewe045aef2020-01-08 16:29:22 -08002997 // Create Active value
Andrew065d78d2020-04-07 15:43:07 -07002998 fake_prefs_.SetInt64(active_key_, 0);
Andrewe045aef2020-01-08 16:29:22 -08002999
3000 OmahaRequestParams::AppParams app_param = {
3001 .active_counting_type = OmahaRequestParams::kDateBased,
Andrew065d78d2020-04-07 15:43:07 -07003002 .name = dlc_id_,
Andrewe045aef2020-01-08 16:29:22 -08003003 .ping_active = 0,
3004 .send_ping = true};
3005 request_params_.set_dlc_apps_params(
Andrew065d78d2020-04-07 15:43:07 -07003006 {{request_params_.GetDlcAppId(dlc_id_), app_param}});
Andrewe045aef2020-01-08 16:29:22 -08003007
3008 // Set the previous active value to an older value than 4763.
Andrew065d78d2020-04-07 15:43:07 -07003009 fake_prefs_.SetString(last_active_key_, "555");
Andrewe045aef2020-01-08 16:29:22 -08003010
Andrew065d78d2020-04-07 15:43:07 -07003011 int64_t temp_int;
Andrewe045aef2020-01-08 16:29:22 -08003012 ASSERT_TRUE(TestUpdateCheck());
Andrew065d78d2020-04-07 15:43:07 -07003013 EXPECT_TRUE(fake_prefs_.GetInt64(active_key_, &temp_int));
Andrewe045aef2020-01-08 16:29:22 -08003014 EXPECT_EQ(temp_int, kPingInactiveValue);
Andrew065d78d2020-04-07 15:43:07 -07003015 string temp_str;
3016 EXPECT_TRUE(fake_prefs_.GetString(last_active_key_, &temp_str));
3017 EXPECT_EQ(temp_str, "555");
3018 EXPECT_TRUE(fake_prefs_.GetString(last_rollcall_key_, &temp_str));
3019 EXPECT_EQ(temp_str, "4763");
Andrewe045aef2020-01-08 16:29:22 -08003020}
3021
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07003022TEST_F(OmahaRequestActionTest, OmahaResponseUpdateCanExcludeCheck) {
3023 request_params_.set_dlc_apps_params(
3024 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}}});
3025 fake_update_response_.dlc_app_update = true;
3026 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
3027
3028 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
3029 ASSERT_TRUE(TestUpdateCheck());
3030 ASSERT_TRUE(delegate_.omaha_response_);
3031 const auto& packages = delegate_.omaha_response_->packages;
3032 ASSERT_EQ(packages.size(), 2);
3033
3034 EXPECT_FALSE(packages[0].can_exclude);
3035 EXPECT_TRUE(packages[1].can_exclude);
3036}
3037
3038TEST_F(OmahaRequestActionTest, OmahaResponseInstallCannotExcludeCheck) {
3039 request_params_.set_is_install(true);
3040 request_params_.set_dlc_apps_params(
3041 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}}});
3042 fake_update_response_.dlc_app_update = true;
3043 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
3044
3045 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
3046 ASSERT_TRUE(TestUpdateCheck());
3047 ASSERT_TRUE(delegate_.omaha_response_);
3048 const auto& packages = delegate_.omaha_response_->packages;
3049 ASSERT_EQ(packages.size(), 2);
3050
3051 EXPECT_FALSE(packages[0].can_exclude);
3052 EXPECT_FALSE(packages[1].can_exclude);
3053}
3054
Darin Petkov6a5b3222010-07-13 14:55:28 -07003055} // namespace chromeos_update_engine