blob: 61e988bb26e18859818e3c6c70430c6b2cf6b72b [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2012 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Darin Petkov6a5b3222010-07-13 14:55:28 -070016
Alex Deymo8427b4a2014-11-05 14:00:32 -080017#include "update_engine/omaha_request_action.h"
18
Ben Chan9abb7632014-08-07 00:10:53 -070019#include <stdint.h>
20
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070021#include <limits>
Ben Chanab5a0af2017-10-12 14:57:50 -070022#include <memory>
Darin Petkov6a5b3222010-07-13 14:55:28 -070023#include <string>
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080024#include <utility>
Darin Petkov6a5b3222010-07-13 14:55:28 -070025#include <vector>
Darin Petkov0dc8e9a2010-07-14 14:51:57 -070026
Alex Deymo60ca1a72015-06-18 18:19:15 -070027#include <base/bind.h>
Alex Deymo110e0302015-10-19 20:35:21 -070028#include <base/files/file_util.h>
Sen Jiang297e5832016-03-17 14:45:51 -070029#include <base/files/scoped_temp_dir.h>
Ben Chan5c02c132017-06-27 07:10:36 -070030#include <base/memory/ptr_util.h>
Alex Deymo8e18f932015-03-27 16:16:59 -070031#include <base/strings/string_number_conversions.h>
Alex Vakulenko75039d72014-03-25 12:36:28 -070032#include <base/strings/string_util.h>
33#include <base/strings/stringprintf.h>
34#include <base/time/time.h>
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -070035#include <brillo/message_loops/fake_message_loop.h>
36#include <brillo/message_loops/message_loop.h>
37#include <brillo/message_loops/message_loop_utils.h>
Andrewe045aef2020-01-08 16:29:22 -080038#include <expat.h>
Alex Deymoe1e3afe2014-10-30 13:02:49 -070039#include <gtest/gtest.h>
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080040#include <policy/libpolicy.h>
41#include <policy/mock_libpolicy.h>
Jay Srinivasand29695d2013-04-08 15:08:05 -070042
Alex Deymo39910dc2015-11-09 17:04:30 -080043#include "update_engine/common/action_pipe.h"
44#include "update_engine/common/constants.h"
45#include "update_engine/common/fake_prefs.h"
46#include "update_engine/common/hash_calculator.h"
Jae Hoon Kim694eeb02020-06-01 14:24:08 -070047#include "update_engine/common/mock_excluder.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080048#include "update_engine/common/mock_http_fetcher.h"
49#include "update_engine/common/platform_constants.h"
50#include "update_engine/common/prefs.h"
51#include "update_engine/common/test_utils.h"
Alex Deymoc1c17b42015-11-23 03:53:15 -030052#include "update_engine/fake_system_state.h"
Tianjie Xu282aa1f2017-09-05 13:42:45 -070053#include "update_engine/metrics_reporter_interface.h"
Chris Sosa77f79e82014-06-02 18:16:24 -070054#include "update_engine/mock_connection_manager.h"
Gilad Arnold74b5f552014-10-07 08:17:16 -070055#include "update_engine/mock_payload_state.h"
Amin Hassani7fca2862019-03-28 16:09:22 -070056#include "update_engine/omaha_request_builder_xml.h"
Darin Petkova4a8a8c2010-07-15 22:21:12 -070057#include "update_engine/omaha_request_params.h"
Jae Hoon Kim051627a2019-09-03 12:56:32 -070058#include "update_engine/omaha_utils.h"
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080059#include "update_engine/update_manager/rollback_prefs.h"
Darin Petkov6a5b3222010-07-13 14:55:28 -070060
Darin Petkov1cbd78f2010-07-29 12:38:34 -070061using base::Time;
62using base::TimeDelta;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080063using chromeos_update_manager::kRollforwardInfinity;
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070064using std::pair;
Darin Petkov6a5b3222010-07-13 14:55:28 -070065using std::string;
66using std::vector;
Amin Hassani7cc8bb02019-01-14 16:29:47 -080067using testing::_;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070068using testing::AllOf;
Alex Deymof329b932014-10-30 01:37:48 -070069using testing::AnyNumber;
Jay Srinivasan34b5d862012-07-23 11:43:22 -070070using testing::DoAll;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070071using testing::Ge;
72using testing::Le;
Darin Petkov9c096d62010-11-17 14:49:04 -080073using testing::NiceMock;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070074using testing::Return;
Gilad Arnold74b5f552014-10-07 08:17:16 -070075using testing::ReturnPointee;
Amin Hassani7cc8bb02019-01-14 16:29:47 -080076using testing::ReturnRef;
Gilad Arnold74b5f552014-10-07 08:17:16 -070077using testing::SaveArg;
Ben Chan672c1f52017-10-23 15:41:39 -070078using testing::SetArgPointee;
Jae Hoon Kim694eeb02020-06-01 14:24:08 -070079using testing::StrictMock;
Darin Petkov6a5b3222010-07-13 14:55:28 -070080
Alex Deymo8e18f932015-03-27 16:16:59 -070081namespace {
82
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080083static_assert(kRollforwardInfinity == 0xfffffffe,
84 "Don't change the value of kRollforward infinity unless its "
85 "size has been changed in firmware.");
86
Xiaochu Liu6310be62018-10-11 15:09:03 -070087const char kCurrentVersion[] = "0.1.0.0";
Alex Deymo85616652015-10-15 18:48:31 -070088const char kTestAppId[] = "test-app-id";
Aaron Wood7dcdedf2017-09-06 17:17:41 -070089const char kTestAppId2[] = "test-app2-id";
Xiaochu Liu6310be62018-10-11 15:09:03 -070090const char kTestAppIdSkipUpdatecheck[] = "test-app-id-skip-updatecheck";
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -080091const char kDlcId1[] = "dlc-id-1";
92const char kDlcId2[] = "dlc-id-2";
Alex Deymo85616652015-10-15 18:48:31 -070093
Alex Deymo8e18f932015-03-27 16:16:59 -070094// This is a helper struct to allow unit tests build an update response with the
95// values they care about.
96struct FakeUpdateResponse {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -070097 string GetRollbackVersionAttributes() const {
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070098 string num_milestones;
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070099 num_milestones = base::NumberToString(rollback_allowed_milestones);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -0700100 const string rollback_version =
101 " _firmware_version_" + num_milestones + "=\"" +
102 past_rollback_key_version.first + "\"" + " _kernel_version_" +
103 num_milestones + "=\"" + past_rollback_key_version.second + "\"";
104
105 return (rollback ? " _rollback=\"true\"" : "") + rollback_version +
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700106 (!rollback_firmware_version.empty()
107 ? " _firmware_version=\"" + rollback_firmware_version + "\""
108 : "") +
109 (!rollback_kernel_version.empty()
110 ? " _kernel_version=\"" + rollback_kernel_version + "\""
111 : "");
112 }
113
Alex Deymo8e18f932015-03-27 16:16:59 -0700114 string GetNoUpdateResponse() const {
115 string entity_str;
116 if (include_entity)
117 entity_str = "<!DOCTYPE response [<!ENTITY CrOS \"ChromeOS\">]>";
Sen Jiang81259682017-03-30 15:11:30 -0700118 return "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" + entity_str +
119 "<response protocol=\"3.0\">"
120 "<daystart elapsed_seconds=\"100\"/>"
121 "<app appid=\"" +
122 app_id + "\" " +
123 (include_cohorts
124 ? "cohort=\"" + cohort + "\" cohorthint=\"" + cohorthint +
125 "\" cohortname=\"" + cohortname + "\" "
126 : "") +
127 " status=\"ok\">"
128 "<ping status=\"ok\"/>"
129 "<updatecheck status=\"noupdate\"/></app>" +
130 (multi_app_no_update
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700131 ? "<app appid=\"" + app_id2 +
132 "\"><updatecheck status=\"noupdate\"/></app>"
Sen Jiang81259682017-03-30 15:11:30 -0700133 : "") +
134 "</response>";
Alex Deymo8e18f932015-03-27 16:16:59 -0700135 }
136
137 string GetUpdateResponse() const {
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800138 chromeos_update_engine::OmahaRequestParams request_params{nullptr};
139 request_params.set_app_id(app_id);
Sen Jiang2703ef42017-03-16 13:36:21 -0700140 return "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
141 "protocol=\"3.0\">"
142 "<daystart elapsed_seconds=\"100\"" +
143 (elapsed_days.empty() ? ""
144 : (" elapsed_days=\"" + elapsed_days + "\"")) +
145 "/>"
146 "<app appid=\"" +
147 app_id + "\" " +
148 (include_cohorts
149 ? "cohort=\"" + cohort + "\" cohorthint=\"" + cohorthint +
150 "\" cohortname=\"" + cohortname + "\" "
151 : "") +
152 " status=\"ok\">"
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700153 "<ping status=\"ok\"/><updatecheck status=\"ok\"" +
154 GetRollbackVersionAttributes() + ">" + "<urls><url codebase=\"" +
Sen Jiang2703ef42017-03-16 13:36:21 -0700155 codebase +
156 "\"/></urls>"
157 "<manifest version=\"" +
158 version +
159 "\">"
160 "<packages><package hash=\"not-used\" name=\"" +
Qijiang Fan0b6501c2020-05-21 05:19:12 +0900161 filename + "\" size=\"" + base::NumberToString(size) +
Sen Jiang0affc2c2017-02-10 15:55:05 -0800162 "\" hash_sha256=\"" + hash + "\"/>" +
163 (multi_package ? "<package name=\"package2\" size=\"222\" "
164 "hash_sha256=\"hash2\"/>"
165 : "") +
166 "</packages>"
Sen Jiang81259682017-03-30 15:11:30 -0700167 "<actions><action event=\"postinstall\" MetadataSize=\"11" +
Amin Hassanic482bbd2018-09-21 16:07:20 -0700168 (multi_package ? ":22" : "") + "\" MoreInfo=\"" + more_info_url +
169 "\" Prompt=\"" + prompt +
Sen Jiang2703ef42017-03-16 13:36:21 -0700170 "\" "
Sen Jiangcdd52062017-05-18 15:33:10 -0700171 "IsDeltaPayload=\"true" +
172 (multi_package ? ":false" : "") +
173 "\" "
Sen Jiang2703ef42017-03-16 13:36:21 -0700174 "MaxDaysToScatter=\"" +
175 max_days_to_scatter +
176 "\" "
Amin Hassanic482bbd2018-09-21 16:07:20 -0700177 "sha256=\"not-used\" " +
Sen Jiang2703ef42017-03-16 13:36:21 -0700178 (deadline.empty() ? "" : ("deadline=\"" + deadline + "\" ")) +
179 (disable_p2p_for_downloading ? "DisableP2PForDownloading=\"true\" "
180 : "") +
181 (disable_p2p_for_sharing ? "DisableP2PForSharing=\"true\" " : "") +
Sen Jiangfe284402018-03-21 14:03:50 -0700182 (powerwash ? "Powerwash=\"true\" " : "") +
Sen Jiang81259682017-03-30 15:11:30 -0700183 "/></actions></manifest></updatecheck></app>" +
184 (multi_app
Sen Jiangb1e063a2017-09-15 17:44:31 -0700185 ? "<app appid=\"" + app_id2 + "\"" +
186 (include_cohorts ? " cohort=\"cohort2\"" : "") +
187 "><updatecheck status=\"ok\"><urls><url codebase=\"" +
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700188 codebase2 + "\"/></urls><manifest version=\"" + version2 +
189 "\"><packages>"
Sen Jiang81259682017-03-30 15:11:30 -0700190 "<package name=\"package3\" size=\"333\" "
191 "hash_sha256=\"hash3\"/></packages>"
Sen Jiang00adf7b2017-06-26 15:57:29 -0700192 "<actions><action event=\"postinstall\" " +
193 (multi_app_self_update
194 ? "noupdate=\"true\" IsDeltaPayload=\"true\" "
195 : "IsDeltaPayload=\"false\" ") +
196 "MetadataSize=\"33\"/></actions>"
Sen Jiang81259682017-03-30 15:11:30 -0700197 "</manifest></updatecheck></app>"
198 : "") +
199 (multi_app_no_update
200 ? "<app><updatecheck status=\"noupdate\"/></app>"
201 : "") +
Xiaochu Liu6310be62018-10-11 15:09:03 -0700202 (multi_app_skip_updatecheck
203 ? "<app appid=\"" + app_id_skip_updatecheck + "\"></app>"
204 : "") +
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800205 (dlc_app_update
206 ? "<app appid=\"" + request_params.GetDlcAppId(kDlcId1) +
207 "\" status=\"ok\">"
208 "<updatecheck status=\"ok\"><urls><url codebase=\"" +
Jae Hoon Kim694eeb02020-06-01 14:24:08 -0700209 codebase + "\"/><url codebase=\"" + codebase2 +
210 "\"/></urls><manifest version=\"" + version +
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800211 "\"><packages><package name=\"package3\" size=\"333\" "
212 "hash_sha256=\"hash3\"/></packages><actions>"
213 "<action event=\"install\" run=\".signed\"/>"
214 "<action event=\"postinstall\" MetadataSize=\"33\"/>"
215 "</actions></manifest></updatecheck></app>"
216 : "") +
217 (dlc_app_no_update
218 ? "<app appid=\"" + request_params.GetDlcAppId(kDlcId2) +
219 "\"><updatecheck status=\"noupdate\"/></app>"
220 : "") +
Sen Jiang81259682017-03-30 15:11:30 -0700221 "</response>";
Alex Deymo8e18f932015-03-27 16:16:59 -0700222 }
223
224 // Return the payload URL, which is split in two fields in the XML response.
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800225 string GetPayloadUrl() { return codebase + filename; }
Alex Deymo8e18f932015-03-27 16:16:59 -0700226
Alex Deymo85616652015-10-15 18:48:31 -0700227 string app_id = kTestAppId;
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700228 string app_id2 = kTestAppId2;
Xiaochu Liu6310be62018-10-11 15:09:03 -0700229 string app_id_skip_updatecheck = kTestAppIdSkipUpdatecheck;
230 string current_version = kCurrentVersion;
Alex Deymo8e18f932015-03-27 16:16:59 -0700231 string version = "1.2.3.4";
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700232 string version2 = "2.3.4.5";
Alex Deymo8e18f932015-03-27 16:16:59 -0700233 string more_info_url = "http://more/info";
234 string prompt = "true";
235 string codebase = "http://code/base/";
Sen Jiang81259682017-03-30 15:11:30 -0700236 string codebase2 = "http://code/base/2/";
Alex Deymo8e18f932015-03-27 16:16:59 -0700237 string filename = "file.signed";
Sen Jiang2703ef42017-03-16 13:36:21 -0700238 string hash = "4841534831323334";
Sen Jiang0affc2c2017-02-10 15:55:05 -0800239 uint64_t size = 123;
Alex Deymo8e18f932015-03-27 16:16:59 -0700240 string deadline = "";
241 string max_days_to_scatter = "7";
242 string elapsed_days = "42";
243
244 // P2P setting defaults to allowed.
245 bool disable_p2p_for_downloading = false;
246 bool disable_p2p_for_sharing = false;
247
Sen Jiangfe284402018-03-21 14:03:50 -0700248 bool powerwash = false;
249
Alex Deymo8e18f932015-03-27 16:16:59 -0700250 // Omaha cohorts settings.
251 bool include_cohorts = false;
252 string cohort = "";
253 string cohorthint = "";
254 string cohortname = "";
255
256 // Whether to include the CrOS <!ENTITY> in the XML response.
257 bool include_entity = false;
Sen Jiang0affc2c2017-02-10 15:55:05 -0800258
Sen Jiang81259682017-03-30 15:11:30 -0700259 // Whether to include more than one app.
260 bool multi_app = false;
Sen Jiang00adf7b2017-06-26 15:57:29 -0700261 // Whether to include an app with noupdate="true".
262 bool multi_app_self_update = false;
263 // Whether to include an additional app with status="noupdate".
Sen Jiang81259682017-03-30 15:11:30 -0700264 bool multi_app_no_update = false;
Xiaochu Liu6310be62018-10-11 15:09:03 -0700265 // Whether to include an additional app with no updatecheck tag.
266 bool multi_app_skip_updatecheck = false;
Sen Jiang81259682017-03-30 15:11:30 -0700267 // Whether to include more than one package in an app.
Sen Jiang0affc2c2017-02-10 15:55:05 -0800268 bool multi_package = false;
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800269 // Whether to include a DLC app with updatecheck tag.
270 bool dlc_app_update = false;
271 // Whether to include a DLC app with no updatecheck tag.
272 bool dlc_app_no_update = false;
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700273
274 // Whether the payload is a rollback.
275 bool rollback = false;
276 // The verified boot firmware key version for the rollback image.
277 string rollback_firmware_version = "";
278 // The verified boot kernel key version for the rollback image.
279 string rollback_kernel_version = "";
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -0700280 // The number of milestones back that the verified boot key version has been
281 // supplied.
282 uint32_t rollback_allowed_milestones = 0;
283 // The verified boot key version for the
284 // |current - rollback_allowed_milestones| most recent release.
285 // The pair contains <firmware_key_version, kernel_key_version> each
286 // of which is in the form "key_version.version".
287 pair<string, string> past_rollback_key_version;
Alex Deymo8e18f932015-03-27 16:16:59 -0700288};
289
290} // namespace
291
Darin Petkov6a5b3222010-07-13 14:55:28 -0700292namespace chromeos_update_engine {
293
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700294class OmahaRequestActionTestProcessorDelegate : public ActionProcessorDelegate {
295 public:
296 OmahaRequestActionTestProcessorDelegate()
297 : expected_code_(ErrorCode::kSuccess),
298 interactive_(false),
299 test_http_fetcher_headers_(false) {}
300 ~OmahaRequestActionTestProcessorDelegate() override = default;
301
302 void ProcessingDone(const ActionProcessor* processor,
303 ErrorCode code) override {
304 brillo::MessageLoop::current()->BreakLoop();
305 }
306
307 void ActionCompleted(ActionProcessor* processor,
308 AbstractAction* action,
309 ErrorCode code) override {
310 // Make sure actions always succeed.
311 if (action->Type() == OmahaRequestAction::StaticType()) {
312 EXPECT_EQ(expected_code_, code);
313 // Check that the headers were set in the fetcher during the action. Note
314 // that we set this request as "interactive".
315 auto fetcher = static_cast<const MockHttpFetcher*>(
316 static_cast<OmahaRequestAction*>(action)->http_fetcher_.get());
317
318 if (test_http_fetcher_headers_) {
319 EXPECT_EQ(interactive_ ? "fg" : "bg",
320 fetcher->GetHeader("X-Goog-Update-Interactivity"));
321 EXPECT_EQ(kTestAppId, fetcher->GetHeader("X-Goog-Update-AppId"));
322 EXPECT_NE("", fetcher->GetHeader("X-Goog-Update-Updater"));
323 }
324 post_data_ = fetcher->post_data();
325 } else if (action->Type() ==
326 ObjectCollectorAction<OmahaResponse>::StaticType()) {
327 EXPECT_EQ(ErrorCode::kSuccess, code);
328 auto collector_action =
329 static_cast<ObjectCollectorAction<OmahaResponse>*>(action);
330 omaha_response_.reset(new OmahaResponse(collector_action->object()));
331 EXPECT_TRUE(omaha_response_);
332 } else {
333 EXPECT_EQ(ErrorCode::kSuccess, code);
334 }
335 }
336 ErrorCode expected_code_;
337 brillo::Blob post_data_;
338 bool interactive_;
339 bool test_http_fetcher_headers_;
340 std::unique_ptr<OmahaResponse> omaha_response_;
341};
342
Amin Hassani41ac04b2019-03-29 11:31:03 -0700343struct TestUpdateCheckParams {
344 string http_response;
345 int fail_http_response_code;
346 bool ping_only;
347 bool is_consumer_device;
348 int rollback_allowed_milestones;
349 bool is_policy_loaded;
350 ErrorCode expected_code;
351 metrics::CheckResult expected_check_result;
352 metrics::CheckReaction expected_check_reaction;
353 metrics::DownloadErrorCode expected_download_error_code;
Jae Hoon Kimedb65502019-06-14 11:52:17 -0700354 string session_id;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700355};
356
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700357class OmahaRequestActionTest : public ::testing::Test {
358 protected:
Alex Deymo610277e2014-11-11 21:18:11 -0800359 void SetUp() override {
Marton Hunyady2abda312018-04-24 18:21:49 +0200360 request_params_.set_os_sp("service_pack");
361 request_params_.set_os_board("x86-generic");
362 request_params_.set_app_id(kTestAppId);
Xiaochu Liu6310be62018-10-11 15:09:03 -0700363 request_params_.set_app_version(kCurrentVersion);
Marton Hunyady2abda312018-04-24 18:21:49 +0200364 request_params_.set_app_lang("en-US");
365 request_params_.set_current_channel("unittest");
366 request_params_.set_target_channel("unittest");
367 request_params_.set_hwid("OEM MODEL 09235 7471");
Marton Hunyady2abda312018-04-24 18:21:49 +0200368 request_params_.set_delta_okay(true);
369 request_params_.set_interactive(false);
370 request_params_.set_update_url("http://url");
371 request_params_.set_target_version_prefix("");
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200372 request_params_.set_rollback_allowed(false);
Marton Hunyady2abda312018-04-24 18:21:49 +0200373 request_params_.set_is_powerwash_allowed(false);
Xiaochu Liu6310be62018-10-11 15:09:03 -0700374 request_params_.set_is_install(false);
Andrewe045aef2020-01-08 16:29:22 -0800375 request_params_.set_dlc_apps_params({});
Marton Hunyady2abda312018-04-24 18:21:49 +0200376
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700377 fake_system_state_.set_request_params(&request_params_);
378 fake_system_state_.set_prefs(&fake_prefs_);
Amin Hassani41ac04b2019-03-29 11:31:03 -0700379
380 // Setting the default update check params. Lookup |TestUpdateCheck()|.
381 tuc_params_ = {
382 .http_response = "",
383 .fail_http_response_code = -1,
384 .ping_only = false,
385 .is_consumer_device = true,
386 .rollback_allowed_milestones = 0,
387 .is_policy_loaded = false,
388 .expected_code = ErrorCode::kSuccess,
389 .expected_check_result = metrics::CheckResult::kUpdateAvailable,
390 .expected_check_reaction = metrics::CheckReaction::kUpdating,
391 .expected_download_error_code = metrics::DownloadErrorCode::kUnset,
392 };
Jae Hoon Kim694eeb02020-06-01 14:24:08 -0700393
394 ON_CALL(*fake_system_state_.mock_update_attempter(), GetExcluder())
395 .WillByDefault(Return(&mock_excluder_));
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700396 }
397
Andrewe045aef2020-01-08 16:29:22 -0800398 // This function uses the parameters in |tuc_params_| to do an update check.
399 // It will fill out |post_str| with the result data and |response| with
Amin Hassani41ac04b2019-03-29 11:31:03 -0700400 // |OmahaResponse|. Returns true iff an output response was obtained from the
401 // |OmahaRequestAction|. If |fail_http_response_code| is non-negative, the
402 // transfer will fail with that code. |ping_only| is passed through to the
403 // |OmahaRequestAction| constructor.
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700404 //
405 // The |expected_check_result|, |expected_check_reaction| and
Amin Hassani41ac04b2019-03-29 11:31:03 -0700406 // |expected_error_code| parameters are for checking expectations about
407 // reporting UpdateEngine.Check.{Result,Reaction,DownloadError} UMA
408 // statistics. Use the appropriate ::kUnset value to specify that the given
409 // metric should not be reported.
410 bool TestUpdateCheck();
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700411
Amin Hassani41ac04b2019-03-29 11:31:03 -0700412 // Tests events using |event| and |https_response|. It will fill up |post_str|
413 // with the result data.
414 void TestEvent(OmahaEvent* event, const string& http_response);
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700415
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -0800416 // Runs and checks a ping test. |ping_only| indicates whether it should send
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700417 // only a ping or also an updatecheck.
418 void PingTest(bool ping_only);
419
420 // InstallDate test helper function.
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800421 bool InstallDateParseHelper(const string& elapsed_days,
422 OmahaResponse* response);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700423
424 // P2P test helper function.
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800425 void P2PTest(bool initial_allow_p2p_for_downloading,
426 bool initial_allow_p2p_for_sharing,
427 bool omaha_disable_p2p_for_downloading,
428 bool omaha_disable_p2p_for_sharing,
429 bool payload_state_allow_p2p_attempt,
430 bool expect_p2p_client_lookup,
431 const string& p2p_client_result_url,
432 bool expected_allow_p2p_for_downloading,
433 bool expected_allow_p2p_for_sharing,
434 const string& expected_p2p_url);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700435
Jae Hoon Kim694eeb02020-06-01 14:24:08 -0700436 StrictMock<MockExcluder> mock_excluder_;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700437 FakeSystemState fake_system_state_;
Alex Deymo8e18f932015-03-27 16:16:59 -0700438 FakeUpdateResponse fake_update_response_;
Marton Hunyady2abda312018-04-24 18:21:49 +0200439 // Used by all tests.
440 OmahaRequestParams request_params_{&fake_system_state_};
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700441
442 FakePrefs fake_prefs_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700443
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700444 OmahaRequestActionTestProcessorDelegate delegate_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700445
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700446 bool test_http_fetcher_headers_{false};
Amin Hassani41ac04b2019-03-29 11:31:03 -0700447
448 TestUpdateCheckParams tuc_params_;
449
450 // TODO(ahassani): Add trailing _ to these two variables.
451 OmahaResponse response;
452 string post_str;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700453};
454
Andrew065d78d2020-04-07 15:43:07 -0700455class OmahaRequestActionDlcPingTest : public OmahaRequestActionTest {
456 protected:
457 void SetUp() override {
458 OmahaRequestActionTest::SetUp();
459 dlc_id_ = "dlc0";
460 active_key_ = PrefsInterface::CreateSubKey(
Jae Hoon Kimc1f36922020-05-11 18:20:18 -0700461 {kDlcPrefsSubDir, dlc_id_, kPrefsPingActive});
Andrew065d78d2020-04-07 15:43:07 -0700462 last_active_key_ = PrefsInterface::CreateSubKey(
Jae Hoon Kimc1f36922020-05-11 18:20:18 -0700463 {kDlcPrefsSubDir, dlc_id_, kPrefsPingLastActive});
Andrew065d78d2020-04-07 15:43:07 -0700464 last_rollcall_key_ = PrefsInterface::CreateSubKey(
Jae Hoon Kimc1f36922020-05-11 18:20:18 -0700465 {kDlcPrefsSubDir, dlc_id_, kPrefsPingLastRollcall});
Andrew065d78d2020-04-07 15:43:07 -0700466
467 tuc_params_.http_response =
468 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
469 "protocol=\"3.0\"><daystart elapsed_days=\"4763\" "
470 "elapsed_seconds=\"36540\"/><app appid=\"test-app-id\" status=\"ok\">\""
471 "<updatecheck status=\"noupdate\"/></app><app "
472 "appid=\"test-app-id_dlc0\" "
473 "status=\"ok\"><ping status=\"ok\"/><updatecheck status=\"noupdate\"/>"
474 "</app></response>";
475 tuc_params_.expected_check_result =
476 metrics::CheckResult::kNoUpdateAvailable;
477 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
478 }
479
480 std::string dlc_id_;
481 std::string active_key_;
482 std::string last_active_key_;
483 std::string last_rollcall_key_;
484};
Amin Hassani41ac04b2019-03-29 11:31:03 -0700485bool OmahaRequestActionTest::TestUpdateCheck() {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700486 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700487 loop.SetAsCurrent();
Amin Hassani41ac04b2019-03-29 11:31:03 -0700488 auto fetcher =
489 std::make_unique<MockHttpFetcher>(tuc_params_.http_response.data(),
490 tuc_params_.http_response.size(),
491 nullptr);
492 if (tuc_params_.fail_http_response_code >= 0) {
493 fetcher->FailTransfer(tuc_params_.fail_http_response_code);
Darin Petkovedc522e2010-11-05 09:35:17 -0700494 }
Marton Hunyady2abda312018-04-24 18:21:49 +0200495 // This ensures the tests didn't forget to update fake_system_state_ if they
496 // are not using the default request_params_.
497 EXPECT_EQ(&request_params_, fake_system_state_.request_params());
498
Jae Hoon Kimedb65502019-06-14 11:52:17 -0700499 auto omaha_request_action =
500 std::make_unique<OmahaRequestAction>(&fake_system_state_,
501 nullptr,
502 std::move(fetcher),
503 tuc_params_.ping_only,
504 tuc_params_.session_id);
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700505
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800506 auto mock_policy_provider =
507 std::make_unique<NiceMock<policy::MockPolicyProvider>>();
508 EXPECT_CALL(*mock_policy_provider, IsConsumerDevice())
Amin Hassani41ac04b2019-03-29 11:31:03 -0700509 .WillRepeatedly(Return(tuc_params_.is_consumer_device));
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800510
511 EXPECT_CALL(*mock_policy_provider, device_policy_is_loaded())
Amin Hassani41ac04b2019-03-29 11:31:03 -0700512 .WillRepeatedly(Return(tuc_params_.is_policy_loaded));
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800513
514 const policy::MockDevicePolicy device_policy;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700515 const bool get_allowed_milestone_succeeds =
516 tuc_params_.rollback_allowed_milestones >= 0;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800517 EXPECT_CALL(device_policy, GetRollbackAllowedMilestones(_))
Amin Hassani41ac04b2019-03-29 11:31:03 -0700518 .WillRepeatedly(
519 DoAll(SetArgPointee<0>(tuc_params_.rollback_allowed_milestones),
520 Return(get_allowed_milestone_succeeds)));
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800521
522 EXPECT_CALL(*mock_policy_provider, GetDevicePolicy())
523 .WillRepeatedly(ReturnRef(device_policy));
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700524 omaha_request_action->policy_provider_ = std::move(mock_policy_provider);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800525
Amin Hassani41ac04b2019-03-29 11:31:03 -0700526 delegate_.expected_code_ = tuc_params_.expected_code;
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700527 delegate_.interactive_ = request_params_.interactive();
528 delegate_.test_http_fetcher_headers_ = test_http_fetcher_headers_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700529 ActionProcessor processor;
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700530 processor.set_delegate(&delegate_);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700531
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700532 auto collector_action =
533 std::make_unique<ObjectCollectorAction<OmahaResponse>>();
534 BondActions(omaha_request_action.get(), collector_action.get());
535 processor.EnqueueAction(std::move(omaha_request_action));
536 processor.EnqueueAction(std::move(collector_action));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700537
Tianjie Xu282aa1f2017-09-05 13:42:45 -0700538 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
539 ReportUpdateCheckMetrics(_, _, _, _))
David Zeuthen33bae492014-02-25 16:16:18 -0800540 .Times(AnyNumber());
Tianjie Xu282aa1f2017-09-05 13:42:45 -0700541
Amin Hassani41ac04b2019-03-29 11:31:03 -0700542 EXPECT_CALL(
543 *fake_system_state_.mock_metrics_reporter(),
544 ReportUpdateCheckMetrics(_,
545 tuc_params_.expected_check_result,
546 tuc_params_.expected_check_reaction,
547 tuc_params_.expected_download_error_code))
548 .Times(tuc_params_.ping_only ? 0 : 1);
David Zeuthen33bae492014-02-25 16:16:18 -0800549
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700550 loop.PostTask(base::Bind(
551 [](ActionProcessor* processor) { processor->StartProcessing(); },
552 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700553 loop.Run();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700554 EXPECT_FALSE(loop.PendingTasks());
Amin Hassani41ac04b2019-03-29 11:31:03 -0700555 if (delegate_.omaha_response_)
556 response = *delegate_.omaha_response_;
557 post_str = string(delegate_.post_data_.begin(), delegate_.post_data_.end());
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700558 return delegate_.omaha_response_ != nullptr;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700559}
560
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700561// Tests Event requests -- they should always succeed. |out_post_data| may be
562// null; if non-null, the post-data received by the mock HttpFetcher is
563// returned.
564void OmahaRequestActionTest::TestEvent(OmahaEvent* event,
Amin Hassani41ac04b2019-03-29 11:31:03 -0700565 const string& http_response) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700566 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700567 loop.SetAsCurrent();
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700568
569 auto action = std::make_unique<OmahaRequestAction>(
570 &fake_system_state_,
571 event,
572 std::make_unique<MockHttpFetcher>(
573 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -0700574 false,
575 "");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700576 ActionProcessor processor;
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700577 processor.set_delegate(&delegate_);
578 processor.EnqueueAction(std::move(action));
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700579
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700580 loop.PostTask(base::Bind(
581 [](ActionProcessor* processor) { processor->StartProcessing(); },
582 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700583 loop.Run();
Alex Deymo72a25672016-03-23 15:44:39 -0700584 EXPECT_FALSE(loop.PendingTasks());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700585
Amin Hassani41ac04b2019-03-29 11:31:03 -0700586 post_str = string(delegate_.post_data_.begin(), delegate_.post_data_.end());
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700587}
588
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700589TEST_F(OmahaRequestActionTest, RejectEntities) {
Alex Deymo8e18f932015-03-27 16:16:59 -0700590 fake_update_response_.include_entity = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700591 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
592 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLHasEntityDecl;
593 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
594 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
595
596 ASSERT_FALSE(TestUpdateCheck());
David Zeuthenf3e28012014-08-26 18:23:52 -0400597 EXPECT_FALSE(response.update_exists);
598}
599
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700600TEST_F(OmahaRequestActionTest, NoUpdateTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -0700601 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
602 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
603 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
604
605 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -0700606 EXPECT_FALSE(response.update_exists);
607}
608
Sen Jiang81259682017-03-30 15:11:30 -0700609TEST_F(OmahaRequestActionTest, MultiAppNoUpdateTest) {
Sen Jiang81259682017-03-30 15:11:30 -0700610 fake_update_response_.multi_app_no_update = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700611 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
612 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
613 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
614
615 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang81259682017-03-30 15:11:30 -0700616 EXPECT_FALSE(response.update_exists);
617}
618
Sen Jiang00adf7b2017-06-26 15:57:29 -0700619TEST_F(OmahaRequestActionTest, MultiAppNoPartialUpdateTest) {
Sen Jiang00adf7b2017-06-26 15:57:29 -0700620 fake_update_response_.multi_app_no_update = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700621 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
622 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
623 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
624
625 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang00adf7b2017-06-26 15:57:29 -0700626 EXPECT_FALSE(response.update_exists);
627}
628
629TEST_F(OmahaRequestActionTest, NoSelfUpdateTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -0700630 tuc_params_.http_response =
Sen Jiang00adf7b2017-06-26 15:57:29 -0700631 "<response><app><updatecheck status=\"ok\"><manifest><actions><action "
632 "event=\"postinstall\" noupdate=\"true\"/></actions>"
Amin Hassani41ac04b2019-03-29 11:31:03 -0700633 "</manifest></updatecheck></app></response>";
634 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
635 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
636
637 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang00adf7b2017-06-26 15:57:29 -0700638 EXPECT_FALSE(response.update_exists);
639}
640
Alex Deymo8e18f932015-03-27 16:16:59 -0700641// Test that all the values in the response are parsed in a normal update
642// response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700643TEST_F(OmahaRequestActionTest, ValidUpdateTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -0700644 fake_update_response_.deadline = "20101020";
Amin Hassani41ac04b2019-03-29 11:31:03 -0700645 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
646
647 ASSERT_TRUE(TestUpdateCheck());
648
Darin Petkov6a5b3222010-07-13 14:55:28 -0700649 EXPECT_TRUE(response.update_exists);
Alex Deymo8e18f932015-03-27 16:16:59 -0700650 EXPECT_EQ(fake_update_response_.version, response.version);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700651 EXPECT_EQ("", response.system_version);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800652 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
653 response.packages[0].payload_urls[0]);
Alex Deymo8e18f932015-03-27 16:16:59 -0700654 EXPECT_EQ(fake_update_response_.more_info_url, response.more_info_url);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800655 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
656 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700657 EXPECT_EQ(true, response.packages[0].is_delta);
Alex Deymo8e18f932015-03-27 16:16:59 -0700658 EXPECT_EQ(fake_update_response_.prompt == "true", response.prompt);
659 EXPECT_EQ(fake_update_response_.deadline, response.deadline);
Sen Jiangfe284402018-03-21 14:03:50 -0700660 EXPECT_FALSE(response.powerwash_required);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700661 // Omaha cohort attributes are not set in the response, so they should not be
Alex Deymo8e18f932015-03-27 16:16:59 -0700662 // persisted.
663 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohort));
664 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortHint));
665 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortName));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700666}
667
Sen Jiang0affc2c2017-02-10 15:55:05 -0800668TEST_F(OmahaRequestActionTest, MultiPackageUpdateTest) {
Sen Jiang0affc2c2017-02-10 15:55:05 -0800669 fake_update_response_.multi_package = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700670 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
671
672 ASSERT_TRUE(TestUpdateCheck());
673
Sen Jiang0affc2c2017-02-10 15:55:05 -0800674 EXPECT_TRUE(response.update_exists);
675 EXPECT_EQ(fake_update_response_.version, response.version);
676 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
677 response.packages[0].payload_urls[0]);
678 EXPECT_EQ(fake_update_response_.codebase + "package2",
679 response.packages[1].payload_urls[0]);
680 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
681 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700682 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700683 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800684 ASSERT_EQ(2u, response.packages.size());
Sen Jiang81259682017-03-30 15:11:30 -0700685 EXPECT_EQ(string("hash2"), response.packages[1].hash);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800686 EXPECT_EQ(222u, response.packages[1].size);
Sen Jiang81259682017-03-30 15:11:30 -0700687 EXPECT_EQ(22u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700688 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700689}
690
691TEST_F(OmahaRequestActionTest, MultiAppUpdateTest) {
Sen Jiang81259682017-03-30 15:11:30 -0700692 fake_update_response_.multi_app = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700693 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
694
695 ASSERT_TRUE(TestUpdateCheck());
696
Sen Jiang81259682017-03-30 15:11:30 -0700697 EXPECT_TRUE(response.update_exists);
698 EXPECT_EQ(fake_update_response_.version, response.version);
699 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
700 response.packages[0].payload_urls[0]);
701 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
702 response.packages[1].payload_urls[0]);
703 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
704 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
705 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700706 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700707 ASSERT_EQ(2u, response.packages.size());
708 EXPECT_EQ(string("hash3"), response.packages[1].hash);
709 EXPECT_EQ(333u, response.packages[1].size);
710 EXPECT_EQ(33u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700711 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700712}
713
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700714TEST_F(OmahaRequestActionTest, MultiAppAndSystemUpdateTest) {
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700715 fake_update_response_.multi_app = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700716 // Trigger the lining up of the app and system versions.
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700717 request_params_.set_system_app_id(fake_update_response_.app_id2);
Amin Hassani41ac04b2019-03-29 11:31:03 -0700718 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700719
Amin Hassani41ac04b2019-03-29 11:31:03 -0700720 ASSERT_TRUE(TestUpdateCheck());
721
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700722 EXPECT_TRUE(response.update_exists);
723 EXPECT_EQ(fake_update_response_.version, response.version);
724 EXPECT_EQ(fake_update_response_.version2, response.system_version);
725 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
726 response.packages[0].payload_urls[0]);
727 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
728 response.packages[1].payload_urls[0]);
729 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
730 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
731 EXPECT_EQ(11u, response.packages[0].metadata_size);
732 EXPECT_EQ(true, response.packages[0].is_delta);
733 ASSERT_EQ(2u, response.packages.size());
734 EXPECT_EQ(string("hash3"), response.packages[1].hash);
735 EXPECT_EQ(333u, response.packages[1].size);
736 EXPECT_EQ(33u, response.packages[1].metadata_size);
737 EXPECT_EQ(false, response.packages[1].is_delta);
738}
739
Sen Jiang81259682017-03-30 15:11:30 -0700740TEST_F(OmahaRequestActionTest, MultiAppPartialUpdateTest) {
Sen Jiang00adf7b2017-06-26 15:57:29 -0700741 fake_update_response_.multi_app = true;
742 fake_update_response_.multi_app_self_update = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700743 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
744
745 ASSERT_TRUE(TestUpdateCheck());
746
Sen Jiang81259682017-03-30 15:11:30 -0700747 EXPECT_TRUE(response.update_exists);
748 EXPECT_EQ(fake_update_response_.version, response.version);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700749 EXPECT_EQ("", response.system_version);
Sen Jiang81259682017-03-30 15:11:30 -0700750 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
751 response.packages[0].payload_urls[0]);
752 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
753 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
754 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiang00adf7b2017-06-26 15:57:29 -0700755 ASSERT_EQ(2u, response.packages.size());
756 EXPECT_EQ(string("hash3"), response.packages[1].hash);
757 EXPECT_EQ(333u, response.packages[1].size);
758 EXPECT_EQ(33u, response.packages[1].metadata_size);
759 EXPECT_EQ(true, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700760}
761
762TEST_F(OmahaRequestActionTest, MultiAppMultiPackageUpdateTest) {
Sen Jiang81259682017-03-30 15:11:30 -0700763 fake_update_response_.multi_app = true;
764 fake_update_response_.multi_package = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700765 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
766
767 ASSERT_TRUE(TestUpdateCheck());
768
Sen Jiang81259682017-03-30 15:11:30 -0700769 EXPECT_TRUE(response.update_exists);
770 EXPECT_EQ(fake_update_response_.version, response.version);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700771 EXPECT_EQ("", response.system_version);
Sen Jiang81259682017-03-30 15:11:30 -0700772 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
773 response.packages[0].payload_urls[0]);
774 EXPECT_EQ(fake_update_response_.codebase + "package2",
775 response.packages[1].payload_urls[0]);
776 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
777 response.packages[2].payload_urls[0]);
778 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
779 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
780 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700781 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700782 ASSERT_EQ(3u, response.packages.size());
783 EXPECT_EQ(string("hash2"), response.packages[1].hash);
784 EXPECT_EQ(222u, response.packages[1].size);
785 EXPECT_EQ(22u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700786 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700787 EXPECT_EQ(string("hash3"), response.packages[2].hash);
788 EXPECT_EQ(333u, response.packages[2].size);
789 EXPECT_EQ(33u, response.packages[2].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700790 EXPECT_EQ(false, response.packages[2].is_delta);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800791}
792
Sen Jiangfe284402018-03-21 14:03:50 -0700793TEST_F(OmahaRequestActionTest, PowerwashTest) {
Sen Jiangfe284402018-03-21 14:03:50 -0700794 fake_update_response_.powerwash = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700795 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
796
797 ASSERT_TRUE(TestUpdateCheck());
798
Sen Jiangfe284402018-03-21 14:03:50 -0700799 EXPECT_TRUE(response.update_exists);
800 EXPECT_TRUE(response.powerwash_required);
801}
802
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700803TEST_F(OmahaRequestActionTest, ExtraHeadersSentInteractiveTest) {
Alex Deymo14ad88e2016-06-29 12:30:14 -0700804 request_params_.set_interactive(true);
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700805 test_http_fetcher_headers_ = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700806 tuc_params_.http_response = "invalid xml>";
807 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
808 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
809 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
810
811 ASSERT_FALSE(TestUpdateCheck());
812
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700813 EXPECT_FALSE(response.update_exists);
814}
Alex Deymo14ad88e2016-06-29 12:30:14 -0700815
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700816TEST_F(OmahaRequestActionTest, ExtraHeadersSentNoInteractiveTest) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700817 request_params_.set_interactive(false);
818 test_http_fetcher_headers_ = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700819 tuc_params_.http_response = "invalid xml>";
820 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
821 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
822 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
823
824 ASSERT_FALSE(TestUpdateCheck());
825
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700826 EXPECT_FALSE(response.update_exists);
Alex Deymo14ad88e2016-06-29 12:30:14 -0700827}
828
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700829TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByConnection) {
Chris Sosa77f79e82014-06-02 18:16:24 -0700830 // Set up a connection manager that doesn't allow a valid update over
831 // the current ethernet connection.
Alex Deymof6ee0162015-07-31 12:35:22 -0700832 MockConnectionManager mock_cm;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700833 fake_system_state_.set_connection_manager(&mock_cm);
834
Alex Deymo30534502015-07-20 15:06:33 -0700835 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800836 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kEthernet),
837 SetArgPointee<1>(ConnectionTethering::kUnknown),
838 Return(true)));
Sen Jiang255e22b2016-05-20 16:15:29 -0700839 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kEthernet, _))
840 .WillRepeatedly(Return(false));
Chris Sosa77f79e82014-06-02 18:16:24 -0700841
Amin Hassani41ac04b2019-03-29 11:31:03 -0700842 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
843 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredPerPolicy;
844 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
845
846 ASSERT_FALSE(TestUpdateCheck());
847
Chris Sosa77f79e82014-06-02 18:16:24 -0700848 EXPECT_FALSE(response.update_exists);
849}
850
Weidong Guo421ff332017-04-17 10:08:38 -0700851TEST_F(OmahaRequestActionTest, ValidUpdateOverCellularAllowedByDevicePolicy) {
852 // This test tests that update over cellular is allowed as device policy
853 // says yes.
Weidong Guo421ff332017-04-17 10:08:38 -0700854 MockConnectionManager mock_cm;
Weidong Guo421ff332017-04-17 10:08:38 -0700855 fake_system_state_.set_connection_manager(&mock_cm);
856
857 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
858 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
859 SetArgPointee<1>(ConnectionTethering::kUnknown),
860 Return(true)));
861 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
862 .WillRepeatedly(Return(true));
863 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
864 .WillRepeatedly(Return(true));
865
Amin Hassani41ac04b2019-03-29 11:31:03 -0700866 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
867
868 ASSERT_TRUE(TestUpdateCheck());
869
Weidong Guo421ff332017-04-17 10:08:38 -0700870 EXPECT_TRUE(response.update_exists);
871}
872
873TEST_F(OmahaRequestActionTest, ValidUpdateOverCellularBlockedByDevicePolicy) {
874 // This test tests that update over cellular is blocked as device policy
875 // says no.
Weidong Guo421ff332017-04-17 10:08:38 -0700876 MockConnectionManager mock_cm;
Weidong Guo421ff332017-04-17 10:08:38 -0700877 fake_system_state_.set_connection_manager(&mock_cm);
878
879 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
880 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
881 SetArgPointee<1>(ConnectionTethering::kUnknown),
882 Return(true)));
883 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
884 .WillRepeatedly(Return(true));
885 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
886 .WillRepeatedly(Return(false));
887
Amin Hassani41ac04b2019-03-29 11:31:03 -0700888 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
889 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredPerPolicy;
890 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
891
892 ASSERT_FALSE(TestUpdateCheck());
893
Weidong Guo421ff332017-04-17 10:08:38 -0700894 EXPECT_FALSE(response.update_exists);
895}
896
897TEST_F(OmahaRequestActionTest,
898 ValidUpdateOverCellularAllowedByUserPermissionTrue) {
899 // This test tests that, when device policy is not set, update over cellular
900 // is allowed as permission for update over cellular is set to true.
Weidong Guo421ff332017-04-17 10:08:38 -0700901 MockConnectionManager mock_cm;
Weidong Guo421ff332017-04-17 10:08:38 -0700902 fake_prefs_.SetBoolean(kPrefsUpdateOverCellularPermission, true);
903 fake_system_state_.set_connection_manager(&mock_cm);
904
905 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
906 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
907 SetArgPointee<1>(ConnectionTethering::kUnknown),
908 Return(true)));
909 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
910 .WillRepeatedly(Return(false));
911 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
912 .WillRepeatedly(Return(true));
913
Amin Hassani41ac04b2019-03-29 11:31:03 -0700914 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
915
916 ASSERT_TRUE(TestUpdateCheck());
917
Weidong Guo421ff332017-04-17 10:08:38 -0700918 EXPECT_TRUE(response.update_exists);
919}
920
921TEST_F(OmahaRequestActionTest,
922 ValidUpdateOverCellularBlockedByUpdateTargetNotMatch) {
923 // This test tests that, when device policy is not set and permission for
924 // update over cellular is set to false or does not exist, update over
925 // cellular is blocked as update target does not match the omaha response.
Weidong Guo421ff332017-04-17 10:08:38 -0700926 MockConnectionManager mock_cm;
927 // A version different from the version in omaha response.
928 string diff_version = "99.99.99";
929 // A size different from the size in omaha response.
930 int64_t diff_size = 999;
931
932 fake_prefs_.SetString(kPrefsUpdateOverCellularTargetVersion, diff_version);
933 fake_prefs_.SetInt64(kPrefsUpdateOverCellularTargetSize, diff_size);
934 // This test tests cellular (3G) being the only connection type being allowed.
935 fake_system_state_.set_connection_manager(&mock_cm);
936
937 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
938 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
939 SetArgPointee<1>(ConnectionTethering::kUnknown),
940 Return(true)));
941 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
942 .WillRepeatedly(Return(false));
943 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
944 .WillRepeatedly(Return(true));
945
Amin Hassani41ac04b2019-03-29 11:31:03 -0700946 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
947 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredOverCellular;
948 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
949
950 ASSERT_FALSE(TestUpdateCheck());
951
Weidong Guo421ff332017-04-17 10:08:38 -0700952 EXPECT_FALSE(response.update_exists);
953}
954
955TEST_F(OmahaRequestActionTest,
956 ValidUpdateOverCellularAllowedByUpdateTargetMatch) {
957 // This test tests that, when device policy is not set and permission for
958 // update over cellular is set to false or does not exist, update over
959 // cellular is allowed as update target matches the omaha response.
Weidong Guo421ff332017-04-17 10:08:38 -0700960 MockConnectionManager mock_cm;
961 // A version same as the version in omaha response.
962 string new_version = fake_update_response_.version;
963 // A size same as the size in omaha response.
964 int64_t new_size = fake_update_response_.size;
965
966 fake_prefs_.SetString(kPrefsUpdateOverCellularTargetVersion, new_version);
967 fake_prefs_.SetInt64(kPrefsUpdateOverCellularTargetSize, new_size);
968 fake_system_state_.set_connection_manager(&mock_cm);
969
970 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
971 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
972 SetArgPointee<1>(ConnectionTethering::kUnknown),
973 Return(true)));
974 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
975 .WillRepeatedly(Return(false));
976 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
977 .WillRepeatedly(Return(true));
978
Amin Hassani41ac04b2019-03-29 11:31:03 -0700979 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
980
981 ASSERT_TRUE(TestUpdateCheck());
982
Weidong Guo421ff332017-04-17 10:08:38 -0700983 EXPECT_TRUE(response.update_exists);
984}
985
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700986TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByRollback) {
Chris Sosa77f79e82014-06-02 18:16:24 -0700987 string rollback_version = "1234.0.0";
Chris Sosa77f79e82014-06-02 18:16:24 -0700988 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700989 fake_system_state_.set_payload_state(&mock_payload_state);
Amin Hassani41ac04b2019-03-29 11:31:03 -0700990 fake_update_response_.version = rollback_version;
991 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
992 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredPerPolicy;
993 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700994
Chris Sosa77f79e82014-06-02 18:16:24 -0700995 EXPECT_CALL(mock_payload_state, GetRollbackVersion())
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800996 .WillRepeatedly(Return(rollback_version));
Chris Sosa77f79e82014-06-02 18:16:24 -0700997
Amin Hassani41ac04b2019-03-29 11:31:03 -0700998 ASSERT_FALSE(TestUpdateCheck());
999
Chris Sosa77f79e82014-06-02 18:16:24 -07001000 EXPECT_FALSE(response.update_exists);
1001}
1002
Marton Hunyadyc2882062018-05-14 17:28:25 +02001003// Verify that update checks called during OOBE will not try to download an
1004// update if the response doesn't include the deadline field.
Kevin Cernekee2494e282016-03-29 18:03:53 -07001005TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBE) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001006 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Amin Hassani41ac04b2019-03-29 11:31:03 -07001007 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1008 tuc_params_.expected_code = ErrorCode::kNonCriticalUpdateInOOBE;
1009 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1010 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Kevin Cernekee2494e282016-03-29 18:03:53 -07001011
Sen Jiang8cd42342018-01-31 12:06:59 -08001012 // TODO(senj): set better default value for metrics::checkresult in
Tianjie Xu282aa1f2017-09-05 13:42:45 -07001013 // OmahaRequestAction::ActionCompleted.
Amin Hassani41ac04b2019-03-29 11:31:03 -07001014 ASSERT_FALSE(TestUpdateCheck());
1015
Kevin Cernekee2494e282016-03-29 18:03:53 -07001016 EXPECT_FALSE(response.update_exists);
Marton Hunyadyc2882062018-05-14 17:28:25 +02001017}
Kevin Cernekee2494e282016-03-29 18:03:53 -07001018
Marton Hunyadyc2882062018-05-14 17:28:25 +02001019// Verify that the IsOOBEComplete() value is ignored when the OOBE flow is not
1020// enabled.
1021TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBEDisabled) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001022 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Alex Deymo46a9aae2016-05-04 20:20:11 -07001023 fake_system_state_.fake_hardware()->SetIsOOBEEnabled(false);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001024 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo46a9aae2016-05-04 20:20:11 -07001025
Amin Hassani41ac04b2019-03-29 11:31:03 -07001026 ASSERT_TRUE(TestUpdateCheck());
1027
Kevin Cernekee2494e282016-03-29 18:03:53 -07001028 EXPECT_TRUE(response.update_exists);
1029}
1030
Marton Hunyadyc2882062018-05-14 17:28:25 +02001031// Verify that update checks called during OOBE will still try to download an
1032// update if the response includes the deadline field.
1033TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBEDeadlineSet) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001034 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1035 fake_update_response_.deadline = "20101020";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001036 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Marton Hunyadyc2882062018-05-14 17:28:25 +02001037
Amin Hassani41ac04b2019-03-29 11:31:03 -07001038 ASSERT_TRUE(TestUpdateCheck());
1039
Marton Hunyadyc2882062018-05-14 17:28:25 +02001040 EXPECT_TRUE(response.update_exists);
1041}
1042
1043// Verify that update checks called during OOBE will not try to download an
1044// update if a rollback happened, even when the response includes the deadline
1045// field.
1046TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBERollback) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001047 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1048 fake_update_response_.deadline = "20101020";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001049 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1050 tuc_params_.expected_code = ErrorCode::kNonCriticalUpdateInOOBE;
1051 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1052 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1053
Marton Hunyadyc2882062018-05-14 17:28:25 +02001054 EXPECT_CALL(*(fake_system_state_.mock_payload_state()), GetRollbackHappened())
1055 .WillOnce(Return(true));
1056
Amin Hassani41ac04b2019-03-29 11:31:03 -07001057 ASSERT_FALSE(TestUpdateCheck());
1058
Marton Hunyadyc2882062018-05-14 17:28:25 +02001059 EXPECT_FALSE(response.update_exists);
1060}
1061
Toni Barzic61544e62018-10-11 14:37:30 -07001062// Verify that non-critical updates are skipped by reporting the
1063// kNonCriticalUpdateInOOBE error code when attempted over cellular network -
1064// i.e. when the update would need user permission. Note that reporting
1065// kOmahaUpdateIgnoredOverCellular error in this case might cause undesired UX
1066// in OOBE (warning the user about an update that will be skipped).
1067TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesInOOBEOverCellular) {
Toni Barzic61544e62018-10-11 14:37:30 -07001068 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1069
1070 MockConnectionManager mock_cm;
1071 fake_system_state_.set_connection_manager(&mock_cm);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001072 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1073 tuc_params_.expected_code = ErrorCode::kNonCriticalUpdateInOOBE;
1074 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1075 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Toni Barzic61544e62018-10-11 14:37:30 -07001076
1077 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
1078 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
1079 SetArgPointee<1>(ConnectionTethering::kUnknown),
1080 Return(true)));
1081 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
1082 .WillRepeatedly(Return(false));
1083
Amin Hassani41ac04b2019-03-29 11:31:03 -07001084 ASSERT_FALSE(TestUpdateCheck());
1085
Toni Barzic61544e62018-10-11 14:37:30 -07001086 EXPECT_FALSE(response.update_exists);
1087}
1088
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001089TEST_F(OmahaRequestActionTest, WallClockBasedWaitAloneCausesScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001090 request_params_.set_wall_clock_based_wait_enabled(true);
1091 request_params_.set_update_check_count_wait_enabled(false);
1092 request_params_.set_waiting_period(TimeDelta::FromDays(2));
May Lippert60aa3ca2018-08-15 16:55:29 -07001093 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001094 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1095 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1096 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
May Lippert60aa3ca2018-08-15 16:55:29 -07001097
Amin Hassani41ac04b2019-03-29 11:31:03 -07001098 ASSERT_FALSE(TestUpdateCheck());
1099
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001100 EXPECT_FALSE(response.update_exists);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001101}
1102
1103TEST_F(OmahaRequestActionTest,
1104 WallClockBasedWaitAloneCausesScatteringInteractive) {
1105 request_params_.set_wall_clock_based_wait_enabled(true);
1106 request_params_.set_update_check_count_wait_enabled(false);
1107 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1108 request_params_.set_interactive(true);
1109 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1110 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Chris Sosa968d0572013-08-23 14:46:02 -07001111
1112 // Verify if we are interactive check we don't defer.
Amin Hassani41ac04b2019-03-29 11:31:03 -07001113 ASSERT_TRUE(TestUpdateCheck());
1114
Chris Sosa968d0572013-08-23 14:46:02 -07001115 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001116}
1117
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001118TEST_F(OmahaRequestActionTest, NoWallClockBasedWaitCausesNoScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001119 request_params_.set_wall_clock_based_wait_enabled(false);
1120 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1121 request_params_.set_update_check_count_wait_enabled(true);
1122 request_params_.set_min_update_checks_needed(1);
1123 request_params_.set_max_update_checks_allowed(8);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001124 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001125
Amin Hassani41ac04b2019-03-29 11:31:03 -07001126 ASSERT_TRUE(TestUpdateCheck());
1127
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001128 EXPECT_TRUE(response.update_exists);
1129}
1130
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001131TEST_F(OmahaRequestActionTest, ZeroMaxDaysToScatterCausesNoScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001132 request_params_.set_wall_clock_based_wait_enabled(true);
1133 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1134 request_params_.set_update_check_count_wait_enabled(true);
1135 request_params_.set_min_update_checks_needed(1);
1136 request_params_.set_max_update_checks_allowed(8);
Alex Deymo8e18f932015-03-27 16:16:59 -07001137 fake_update_response_.max_days_to_scatter = "0";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001138 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1139
1140 ASSERT_TRUE(TestUpdateCheck());
1141
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001142 EXPECT_TRUE(response.update_exists);
1143}
1144
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001145TEST_F(OmahaRequestActionTest, ZeroUpdateCheckCountCausesNoScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001146 request_params_.set_wall_clock_based_wait_enabled(true);
1147 request_params_.set_waiting_period(TimeDelta());
1148 request_params_.set_update_check_count_wait_enabled(true);
1149 request_params_.set_min_update_checks_needed(0);
1150 request_params_.set_max_update_checks_allowed(0);
May Lippert60aa3ca2018-08-15 16:55:29 -07001151 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001152 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
May Lippert60aa3ca2018-08-15 16:55:29 -07001153
Amin Hassani41ac04b2019-03-29 11:31:03 -07001154 ASSERT_TRUE(TestUpdateCheck());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001155
Ben Chan9abb7632014-08-07 00:10:53 -07001156 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001157 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001158 ASSERT_EQ(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001159 EXPECT_TRUE(response.update_exists);
1160}
1161
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001162TEST_F(OmahaRequestActionTest, NonZeroUpdateCheckCountCausesScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001163 request_params_.set_wall_clock_based_wait_enabled(true);
1164 request_params_.set_waiting_period(TimeDelta());
1165 request_params_.set_update_check_count_wait_enabled(true);
1166 request_params_.set_min_update_checks_needed(1);
1167 request_params_.set_max_update_checks_allowed(8);
May Lippert60aa3ca2018-08-15 16:55:29 -07001168 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001169 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1170 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1171 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
May Lippert60aa3ca2018-08-15 16:55:29 -07001172
Amin Hassani41ac04b2019-03-29 11:31:03 -07001173 ASSERT_FALSE(TestUpdateCheck());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001174
Ben Chan9abb7632014-08-07 00:10:53 -07001175 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001176 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001177 ASSERT_GT(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001178 EXPECT_FALSE(response.update_exists);
1179}
1180
Amin Hassani41ac04b2019-03-29 11:31:03 -07001181TEST_F(OmahaRequestActionTest,
1182 NonZeroUpdateCheckCountCausesScatteringInteractive) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001183 request_params_.set_wall_clock_based_wait_enabled(true);
1184 request_params_.set_waiting_period(TimeDelta());
1185 request_params_.set_update_check_count_wait_enabled(true);
1186 request_params_.set_min_update_checks_needed(1);
1187 request_params_.set_max_update_checks_allowed(8);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001188 request_params_.set_interactive(true);
May Lippert60aa3ca2018-08-15 16:55:29 -07001189 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001190 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1191
1192 // Verify if we are interactive check we don't defer.
1193 ASSERT_TRUE(TestUpdateCheck());
1194
1195 EXPECT_TRUE(response.update_exists);
1196}
1197
1198TEST_F(OmahaRequestActionTest, ExistingUpdateCheckCountCausesScattering) {
1199 request_params_.set_wall_clock_based_wait_enabled(true);
1200 request_params_.set_waiting_period(TimeDelta());
1201 request_params_.set_update_check_count_wait_enabled(true);
1202 request_params_.set_min_update_checks_needed(1);
1203 request_params_.set_max_update_checks_allowed(8);
1204 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1205 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1206 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1207 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
May Lippert60aa3ca2018-08-15 16:55:29 -07001208
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001209 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsUpdateCheckCount, 5));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001210 ASSERT_FALSE(TestUpdateCheck());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001211
Ben Chan9abb7632014-08-07 00:10:53 -07001212 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001213 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001214 // |count| remains the same, as the decrementing happens in update_attempter
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001215 // which this test doesn't exercise.
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001216 ASSERT_EQ(count, 5);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001217 EXPECT_FALSE(response.update_exists);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001218}
1219
1220TEST_F(OmahaRequestActionTest,
1221 ExistingUpdateCheckCountCausesScatteringInteractive) {
1222 request_params_.set_wall_clock_based_wait_enabled(true);
1223 request_params_.set_waiting_period(TimeDelta());
1224 request_params_.set_update_check_count_wait_enabled(true);
1225 request_params_.set_min_update_checks_needed(1);
1226 request_params_.set_max_update_checks_allowed(8);
1227 request_params_.set_interactive(true);
1228 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1229 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1230
1231 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsUpdateCheckCount, 5));
Chris Sosa968d0572013-08-23 14:46:02 -07001232
1233 // Verify if we are interactive check we don't defer.
Amin Hassani41ac04b2019-03-29 11:31:03 -07001234 ASSERT_TRUE(TestUpdateCheck());
Chris Sosa968d0572013-08-23 14:46:02 -07001235 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001236}
Jay Srinivasan0a708742012-03-20 11:26:12 -07001237
Adolfo Victoria497044c2018-07-18 07:51:42 -07001238TEST_F(OmahaRequestActionTest, StagingTurnedOnCausesScattering) {
1239 // If staging is on, the value for max days to scatter should be ignored, and
1240 // staging's scatter value should be used.
Adolfo Victoria497044c2018-07-18 07:51:42 -07001241 request_params_.set_wall_clock_based_wait_enabled(true);
1242 request_params_.set_waiting_period(TimeDelta::FromDays(6));
1243 request_params_.set_update_check_count_wait_enabled(false);
May Lippert60aa3ca2018-08-15 16:55:29 -07001244 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1245
Adolfo Victoria497044c2018-07-18 07:51:42 -07001246 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsWallClockStagingWaitPeriod, 6));
1247 // This should not prevent scattering due to staging.
1248 fake_update_response_.max_days_to_scatter = "0";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001249 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1250 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1251 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
1252
1253 ASSERT_FALSE(TestUpdateCheck());
1254
Adolfo Victoria497044c2018-07-18 07:51:42 -07001255 EXPECT_FALSE(response.update_exists);
1256
1257 // Interactive updates should not be affected.
1258 request_params_.set_interactive(true);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001259 tuc_params_.expected_code = ErrorCode::kSuccess;
1260 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUpdating;
1261
1262 ASSERT_TRUE(TestUpdateCheck());
1263
Adolfo Victoria497044c2018-07-18 07:51:42 -07001264 EXPECT_TRUE(response.update_exists);
1265}
1266
Alex Deymo8e18f932015-03-27 16:16:59 -07001267TEST_F(OmahaRequestActionTest, CohortsArePersisted) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001268 fake_update_response_.include_cohorts = true;
1269 fake_update_response_.cohort = "s/154454/8479665";
1270 fake_update_response_.cohorthint = "please-put-me-on-beta";
1271 fake_update_response_.cohortname = "stable";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001272 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo8e18f932015-03-27 16:16:59 -07001273
Amin Hassani41ac04b2019-03-29 11:31:03 -07001274 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo8e18f932015-03-27 16:16:59 -07001275
1276 string value;
1277 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1278 EXPECT_EQ(fake_update_response_.cohort, value);
1279
1280 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1281 EXPECT_EQ(fake_update_response_.cohorthint, value);
1282
1283 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1284 EXPECT_EQ(fake_update_response_.cohortname, value);
1285}
1286
1287TEST_F(OmahaRequestActionTest, CohortsAreUpdated) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001288 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
1289 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortHint, "old_hint"));
1290 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortName, "old_name"));
1291 fake_update_response_.include_cohorts = true;
1292 fake_update_response_.cohort = "s/154454/8479665";
1293 fake_update_response_.cohorthint = "please-put-me-on-beta";
1294 fake_update_response_.cohortname = "";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001295 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo8e18f932015-03-27 16:16:59 -07001296
Amin Hassani41ac04b2019-03-29 11:31:03 -07001297 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo8e18f932015-03-27 16:16:59 -07001298
1299 string value;
1300 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1301 EXPECT_EQ(fake_update_response_.cohort, value);
1302
1303 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1304 EXPECT_EQ(fake_update_response_.cohorthint, value);
1305
1306 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1307}
1308
1309TEST_F(OmahaRequestActionTest, CohortsAreNotModifiedWhenMissing) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001310 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo8e18f932015-03-27 16:16:59 -07001311
Amin Hassani41ac04b2019-03-29 11:31:03 -07001312 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
1313 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo8e18f932015-03-27 16:16:59 -07001314
1315 string value;
1316 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1317 EXPECT_EQ("old_value", value);
1318
1319 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1320 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1321}
1322
Alex Deymo00d79ac2015-06-29 15:41:49 -07001323TEST_F(OmahaRequestActionTest, CohortsArePersistedWhenNoUpdate) {
Alex Deymo00d79ac2015-06-29 15:41:49 -07001324 fake_update_response_.include_cohorts = true;
1325 fake_update_response_.cohort = "s/154454/8479665";
1326 fake_update_response_.cohorthint = "please-put-me-on-beta";
1327 fake_update_response_.cohortname = "stable";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001328 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1329 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1330 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Alex Deymo00d79ac2015-06-29 15:41:49 -07001331
Amin Hassani41ac04b2019-03-29 11:31:03 -07001332 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo00d79ac2015-06-29 15:41:49 -07001333
1334 string value;
1335 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1336 EXPECT_EQ(fake_update_response_.cohort, value);
1337
1338 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1339 EXPECT_EQ(fake_update_response_.cohorthint, value);
1340
1341 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1342 EXPECT_EQ(fake_update_response_.cohortname, value);
1343}
1344
Sen Jiangb1e063a2017-09-15 17:44:31 -07001345TEST_F(OmahaRequestActionTest, MultiAppCohortTest) {
Sen Jiangb1e063a2017-09-15 17:44:31 -07001346 fake_update_response_.multi_app = true;
1347 fake_update_response_.include_cohorts = true;
1348 fake_update_response_.cohort = "s/154454/8479665";
1349 fake_update_response_.cohorthint = "please-put-me-on-beta";
1350 fake_update_response_.cohortname = "stable";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001351 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Sen Jiangb1e063a2017-09-15 17:44:31 -07001352
Amin Hassani41ac04b2019-03-29 11:31:03 -07001353 ASSERT_TRUE(TestUpdateCheck());
Sen Jiangb1e063a2017-09-15 17:44:31 -07001354
1355 string value;
1356 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1357 EXPECT_EQ(fake_update_response_.cohort, value);
1358
1359 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1360 EXPECT_EQ(fake_update_response_.cohorthint, value);
1361
1362 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1363 EXPECT_EQ(fake_update_response_.cohortname, value);
1364}
1365
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001366TEST_F(OmahaRequestActionTest, NoOutputPipeTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001367 const string http_response(fake_update_response_.GetNoUpdateResponse());
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001368 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -07001369 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001370
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001371 auto action = std::make_unique<OmahaRequestAction>(
Ben Chan5c02c132017-06-27 07:10:36 -07001372 &fake_system_state_,
1373 nullptr,
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001374 std::make_unique<MockHttpFetcher>(
1375 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001376 false,
1377 "");
Darin Petkov6a5b3222010-07-13 14:55:28 -07001378 ActionProcessor processor;
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001379 processor.set_delegate(&delegate_);
1380 processor.EnqueueAction(std::move(action));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001381
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -07001382 loop.PostTask(base::Bind(
1383 [](ActionProcessor* processor) { processor->StartProcessing(); },
1384 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -07001385 loop.Run();
1386 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001387 EXPECT_FALSE(processor.IsRunning());
1388}
1389
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001390TEST_F(OmahaRequestActionTest, InvalidXmlTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001391 tuc_params_.http_response = "invalid xml>";
1392 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1393 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1394 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1395
1396 ASSERT_FALSE(TestUpdateCheck());
Darin Petkovedc522e2010-11-05 09:35:17 -07001397 EXPECT_FALSE(response.update_exists);
1398}
1399
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001400TEST_F(OmahaRequestActionTest, EmptyResponseTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001401 tuc_params_.expected_code = ErrorCode::kOmahaRequestEmptyResponseError;
1402 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1403 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1404
1405 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001406 EXPECT_FALSE(response.update_exists);
1407}
1408
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001409TEST_F(OmahaRequestActionTest, MissingStatusTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001410 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001411 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1412 "<daystart elapsed_seconds=\"100\"/>"
1413 "<app appid=\"foo\" status=\"ok\">"
1414 "<ping status=\"ok\"/>"
Amin Hassani41ac04b2019-03-29 11:31:03 -07001415 "<updatecheck/></app></response>";
1416 tuc_params_.expected_code = ErrorCode::kOmahaResponseInvalid;
1417 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1418 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1419
1420 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001421 EXPECT_FALSE(response.update_exists);
1422}
1423
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001424TEST_F(OmahaRequestActionTest, InvalidStatusTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001425 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001426 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1427 "<daystart elapsed_seconds=\"100\"/>"
1428 "<app appid=\"foo\" status=\"ok\">"
1429 "<ping status=\"ok\"/>"
Amin Hassani41ac04b2019-03-29 11:31:03 -07001430 "<updatecheck status=\"InvalidStatusTest\"/></app></response>";
1431 tuc_params_.expected_code = ErrorCode::kOmahaResponseInvalid;
1432 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1433 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1434
1435 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001436 EXPECT_FALSE(response.update_exists);
1437}
1438
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001439TEST_F(OmahaRequestActionTest, MissingNodesetTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001440 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001441 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1442 "<daystart elapsed_seconds=\"100\"/>"
1443 "<app appid=\"foo\" status=\"ok\">"
1444 "<ping status=\"ok\"/>"
Amin Hassani41ac04b2019-03-29 11:31:03 -07001445 "</app></response>";
1446 tuc_params_.expected_code = ErrorCode::kOmahaResponseInvalid;
1447 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1448 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1449
1450 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001451 EXPECT_FALSE(response.update_exists);
1452}
1453
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001454TEST_F(OmahaRequestActionTest, MissingFieldTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001455 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001456 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1457 "<daystart elapsed_seconds=\"100\"/>"
Aaron Wood7dcdedf2017-09-06 17:17:41 -07001458 // the appid needs to match that in the request params
1459 "<app appid=\"" +
1460 fake_update_response_.app_id +
1461 "\" status=\"ok\">"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001462 "<updatecheck status=\"ok\">"
1463 "<urls><url codebase=\"http://missing/field/test/\"/></urls>"
Chris Sosa3b748432013-06-20 16:42:59 -07001464 "<manifest version=\"10.2.3.4\">"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001465 "<packages><package hash=\"not-used\" name=\"f\" "
Sen Jiang2703ef42017-03-16 13:36:21 -07001466 "size=\"587\" hash_sha256=\"lkq34j5345\"/></packages>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001467 "<actions><action event=\"postinstall\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001468 "Prompt=\"false\" "
Jay Srinivasand671e972013-01-11 17:17:19 -08001469 "IsDeltaPayload=\"false\" "
Sen Jiang2703ef42017-03-16 13:36:21 -07001470 "sha256=\"not-used\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001471 "/></actions></manifest></updatecheck></app></response>";
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001472
Amin Hassani41ac04b2019-03-29 11:31:03 -07001473 ASSERT_TRUE(TestUpdateCheck());
1474
Darin Petkov6a5b3222010-07-13 14:55:28 -07001475 EXPECT_TRUE(response.update_exists);
Chris Sosa3b748432013-06-20 16:42:59 -07001476 EXPECT_EQ("10.2.3.4", response.version);
Sen Jiang0affc2c2017-02-10 15:55:05 -08001477 EXPECT_EQ("http://missing/field/test/f",
1478 response.packages[0].payload_urls[0]);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001479 EXPECT_EQ("", response.more_info_url);
Sen Jiang0affc2c2017-02-10 15:55:05 -08001480 EXPECT_EQ("lkq34j5345", response.packages[0].hash);
1481 EXPECT_EQ(587u, response.packages[0].size);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001482 EXPECT_FALSE(response.prompt);
Darin Petkov6c118642010-10-21 12:06:30 -07001483 EXPECT_TRUE(response.deadline.empty());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001484}
1485
1486namespace {
1487class TerminateEarlyTestProcessorDelegate : public ActionProcessorDelegate {
1488 public:
1489 void ProcessingStopped(const ActionProcessor* processor) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001490 brillo::MessageLoop::current()->BreakLoop();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001491 }
Darin Petkov6a5b3222010-07-13 14:55:28 -07001492};
1493
Alex Deymo60ca1a72015-06-18 18:19:15 -07001494void TerminateTransferTestStarter(ActionProcessor* processor) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001495 processor->StartProcessing();
1496 CHECK(processor->IsRunning());
1497 processor->StopProcessing();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001498}
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001499} // namespace
Darin Petkov6a5b3222010-07-13 14:55:28 -07001500
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001501TEST_F(OmahaRequestActionTest, TerminateTransferTest) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001502 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -07001503 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001504
Alex Deymo60ca1a72015-06-18 18:19:15 -07001505 string http_response("doesn't matter");
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001506 auto action = std::make_unique<OmahaRequestAction>(
Ben Chan5c02c132017-06-27 07:10:36 -07001507 &fake_system_state_,
1508 nullptr,
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001509 std::make_unique<MockHttpFetcher>(
1510 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001511 false,
1512 "");
Darin Petkov6a5b3222010-07-13 14:55:28 -07001513 TerminateEarlyTestProcessorDelegate delegate;
Darin Petkov6a5b3222010-07-13 14:55:28 -07001514 ActionProcessor processor;
1515 processor.set_delegate(&delegate);
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001516 processor.EnqueueAction(std::move(action));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001517
Alex Deymo60ca1a72015-06-18 18:19:15 -07001518 loop.PostTask(base::Bind(&TerminateTransferTestStarter, &processor));
1519 loop.Run();
1520 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001521}
1522
Alex Deymob0d74eb2015-03-30 17:59:17 -07001523TEST_F(OmahaRequestActionTest, XmlEncodeIsUsedForParams) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001524 // Make sure XML Encode is being called on the params.
Marton Hunyady2abda312018-04-24 18:21:49 +02001525 request_params_.set_os_sp("testtheservice_pack>");
1526 request_params_.set_os_board("x86 generic<id");
1527 request_params_.set_current_channel("unittest_track&lt;");
1528 request_params_.set_target_channel("unittest_track&lt;");
Amin Hassani37b67232020-08-13 09:29:48 -07001529 request_params_.set_lts_tag("unittest_hint&lt;");
Marton Hunyady2abda312018-04-24 18:21:49 +02001530 request_params_.set_hwid("<OEM MODEL>");
Alex Deymo8e18f932015-03-27 16:16:59 -07001531 fake_prefs_.SetString(kPrefsOmahaCohort, "evil\nstring");
1532 fake_prefs_.SetString(kPrefsOmahaCohortHint, "evil&string\\");
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001533 fake_prefs_.SetString(
1534 kPrefsOmahaCohortName,
1535 base::JoinString(vector<string>(100, "My spoon is too big."), " "));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001536 tuc_params_.http_response = "invalid xml>";
1537 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1538 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1539 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1540
1541 ASSERT_FALSE(TestUpdateCheck());
1542
Alex Deymo8e18f932015-03-27 16:16:59 -07001543 EXPECT_NE(string::npos, post_str.find("testtheservice_pack&gt;"));
1544 EXPECT_EQ(string::npos, post_str.find("testtheservice_pack>"));
1545 EXPECT_NE(string::npos, post_str.find("x86 generic&lt;id"));
1546 EXPECT_EQ(string::npos, post_str.find("x86 generic<id"));
1547 EXPECT_NE(string::npos, post_str.find("unittest_track&amp;lt;"));
1548 EXPECT_EQ(string::npos, post_str.find("unittest_track&lt;"));
Amin Hassani37b67232020-08-13 09:29:48 -07001549 EXPECT_NE(string::npos, post_str.find("unittest_hint&amp;lt;"));
1550 EXPECT_EQ(string::npos, post_str.find("unittest_hint&lt;"));
Alex Deymo8e18f932015-03-27 16:16:59 -07001551 EXPECT_NE(string::npos, post_str.find("&lt;OEM MODEL&gt;"));
1552 EXPECT_EQ(string::npos, post_str.find("<OEM MODEL>"));
1553 EXPECT_NE(string::npos, post_str.find("cohort=\"evil\nstring\""));
1554 EXPECT_EQ(string::npos, post_str.find("cohorthint=\"evil&string\\\""));
1555 EXPECT_NE(string::npos, post_str.find("cohorthint=\"evil&amp;string\\\""));
1556 // Values from Prefs that are too big are removed from the XML instead of
1557 // encoded.
1558 EXPECT_EQ(string::npos, post_str.find("cohortname="));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001559}
1560
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001561TEST_F(OmahaRequestActionTest, XmlDecodeTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001562 fake_update_response_.deadline = "&lt;20110101";
1563 fake_update_response_.more_info_url = "testthe&lt;url";
1564 fake_update_response_.codebase = "testthe&amp;codebase/";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001565 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1566
1567 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001568
Sen Jiang0affc2c2017-02-10 15:55:05 -08001569 EXPECT_EQ("testthe<url", response.more_info_url);
1570 EXPECT_EQ("testthe&codebase/file.signed",
1571 response.packages[0].payload_urls[0]);
1572 EXPECT_EQ("<20110101", response.deadline);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001573}
1574
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001575TEST_F(OmahaRequestActionTest, ParseIntTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001576 // overflows int32_t:
Sen Jiang0affc2c2017-02-10 15:55:05 -08001577 fake_update_response_.size = 123123123123123ull;
Amin Hassani41ac04b2019-03-29 11:31:03 -07001578 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001579
Amin Hassani41ac04b2019-03-29 11:31:03 -07001580 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang0affc2c2017-02-10 15:55:05 -08001581 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001582}
1583
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001584TEST_F(OmahaRequestActionTest, FormatUpdateCheckOutputTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001585 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001586 fake_system_state_.set_prefs(&prefs);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001587 tuc_params_.http_response = "invalid xml>";
1588 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1589 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1590 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001591
Darin Petkov95508da2011-01-05 12:42:29 -08001592 EXPECT_CALL(prefs, GetString(kPrefsPreviousVersion, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001593 .WillOnce(DoAll(SetArgPointee<1>(string("")), Return(true)));
Alex Deymoefb9d832015-11-02 18:39:02 -08001594 // An existing but empty previous version means that we didn't reboot to a new
1595 // update, therefore, no need to update the previous version.
1596 EXPECT_CALL(prefs, SetString(kPrefsPreviousVersion, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001597 ASSERT_FALSE(TestUpdateCheck());
1598
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001599 EXPECT_NE(
1600 post_str.find(" <ping active=\"1\" a=\"-1\" r=\"-1\"></ping>\n"
1601 " <updatecheck></updatecheck>\n"),
Jay Srinivasan0a708742012-03-20 11:26:12 -07001602 string::npos);
Darin Petkovfbb40092010-07-29 17:05:50 -07001603 EXPECT_NE(post_str.find("hardware_class=\"OEM MODEL 09235 7471\""),
1604 string::npos);
Alex Deymoefb9d832015-11-02 18:39:02 -08001605 // No <event> tag should be sent if we didn't reboot to an update.
1606 EXPECT_EQ(post_str.find("<event"), string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001607}
1608
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001609TEST_F(OmahaRequestActionTest, FormatSuccessEventOutputTest) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001610 TestEvent(new OmahaEvent(OmahaEvent::kTypeUpdateDownloadStarted),
Amin Hassani41ac04b2019-03-29 11:31:03 -07001611 "invalid xml>");
1612
Alex Vakulenko75039d72014-03-25 12:36:28 -07001613 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001614 " <event eventtype=\"%d\" eventresult=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001615 OmahaEvent::kTypeUpdateDownloadStarted,
1616 OmahaEvent::kResultSuccess);
1617 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001618 EXPECT_EQ(post_str.find("ping"), string::npos);
1619 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkove17f86b2010-07-20 09:12:01 -07001620}
1621
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001622TEST_F(OmahaRequestActionTest, FormatErrorEventOutputTest) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001623 TestEvent(new OmahaEvent(OmahaEvent::kTypeDownloadComplete,
Darin Petkove17f86b2010-07-20 09:12:01 -07001624 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001625 ErrorCode::kError),
Amin Hassani41ac04b2019-03-29 11:31:03 -07001626 "invalid xml>");
1627
Alex Vakulenko75039d72014-03-25 12:36:28 -07001628 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001629 " <event eventtype=\"%d\" eventresult=\"%d\" "
1630 "errorcode=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001631 OmahaEvent::kTypeDownloadComplete,
1632 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001633 static_cast<int>(ErrorCode::kError));
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001634 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001635 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001636}
1637
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001638TEST_F(OmahaRequestActionTest, IsEventTest) {
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001639 string http_response("doesn't matter");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001640 OmahaRequestAction update_check_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001641 &fake_system_state_,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001642 nullptr,
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001643 std::make_unique<MockHttpFetcher>(
1644 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001645 false,
1646 "");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001647 EXPECT_FALSE(update_check_action.IsEvent());
1648
1649 OmahaRequestAction event_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001650 &fake_system_state_,
Darin Petkove17f86b2010-07-20 09:12:01 -07001651 new OmahaEvent(OmahaEvent::kTypeUpdateComplete),
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001652 std::make_unique<MockHttpFetcher>(
1653 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001654 false,
1655 "");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001656 EXPECT_TRUE(event_action.IsEvent());
1657}
1658
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001659TEST_F(OmahaRequestActionTest, FormatDeltaOkayOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001660 tuc_params_.http_response = "invalid xml>";
1661 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1662 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1663 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1664
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001665 for (int i = 0; i < 2; i++) {
1666 bool delta_okay = i == 1;
1667 const char* delta_okay_str = delta_okay ? "true" : "false";
Marton Hunyady2abda312018-04-24 18:21:49 +02001668 request_params_.set_delta_okay(delta_okay);
1669
Amin Hassani41ac04b2019-03-29 11:31:03 -07001670 ASSERT_FALSE(TestUpdateCheck());
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001671 EXPECT_NE(
1672 post_str.find(base::StringPrintf(" delta_okay=\"%s\"", delta_okay_str)),
1673 string::npos)
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001674 << "i = " << i;
1675 }
1676}
1677
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001678TEST_F(OmahaRequestActionTest, FormatInteractiveOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001679 tuc_params_.http_response = "invalid xml>";
1680 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1681 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1682 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1683
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001684 for (int i = 0; i < 2; i++) {
1685 bool interactive = i == 1;
Gilad Arnold8a659d82013-01-24 11:26:00 -08001686 const char* interactive_str = interactive ? "ondemandupdate" : "scheduler";
Marton Hunyady2abda312018-04-24 18:21:49 +02001687 request_params_.set_interactive(interactive);
1688
Amin Hassani41ac04b2019-03-29 11:31:03 -07001689 ASSERT_FALSE(TestUpdateCheck());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001690 EXPECT_NE(post_str.find(
1691 base::StringPrintf("installsource=\"%s\"", interactive_str)),
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001692 string::npos)
1693 << "i = " << i;
1694 }
1695}
1696
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001697TEST_F(OmahaRequestActionTest, FormatTargetVersionPrefixOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001698 tuc_params_.http_response = "invalid xml>";
1699 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1700 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1701 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1702
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001703 for (int i = 0; i < 2; i++) {
1704 bool target_version_set = i == 1;
1705 const char* target_version_prefix = target_version_set ? "10032." : "";
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001706 request_params_.set_target_version_prefix(target_version_prefix);
1707
Amin Hassani41ac04b2019-03-29 11:31:03 -07001708 ASSERT_FALSE(TestUpdateCheck());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001709 if (target_version_set) {
1710 EXPECT_NE(post_str.find("<updatecheck targetversionprefix=\"10032.\">"),
1711 string::npos)
1712 << "i = " << i;
1713 } else {
1714 EXPECT_EQ(post_str.find("targetversionprefix"), string::npos)
1715 << "i = " << i;
1716 }
1717 }
1718}
1719
1720TEST_F(OmahaRequestActionTest, FormatRollbackAllowedOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001721 tuc_params_.http_response = "invalid xml>";
1722 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1723 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1724 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1725
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001726 for (int i = 0; i < 4; i++) {
1727 bool rollback_allowed = i / 2 == 0;
1728 bool target_version_set = i % 2 == 0;
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001729 request_params_.set_target_version_prefix(target_version_set ? "10032."
1730 : "");
1731 request_params_.set_rollback_allowed(rollback_allowed);
1732
Amin Hassani41ac04b2019-03-29 11:31:03 -07001733 ASSERT_FALSE(TestUpdateCheck());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001734 if (rollback_allowed && target_version_set) {
1735 EXPECT_NE(post_str.find("rollback_allowed=\"true\""), string::npos)
1736 << "i = " << i;
1737 } else {
1738 EXPECT_EQ(post_str.find("rollback_allowed"), string::npos) << "i = " << i;
1739 }
1740 }
1741}
1742
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001743TEST_F(OmahaRequestActionTest, OmahaEventTest) {
Darin Petkove17f86b2010-07-20 09:12:01 -07001744 OmahaEvent default_event;
1745 EXPECT_EQ(OmahaEvent::kTypeUnknown, default_event.type);
1746 EXPECT_EQ(OmahaEvent::kResultError, default_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001747 EXPECT_EQ(ErrorCode::kError, default_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001748
1749 OmahaEvent success_event(OmahaEvent::kTypeUpdateDownloadStarted);
1750 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadStarted, success_event.type);
1751 EXPECT_EQ(OmahaEvent::kResultSuccess, success_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001752 EXPECT_EQ(ErrorCode::kSuccess, success_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001753
1754 OmahaEvent error_event(OmahaEvent::kTypeUpdateDownloadFinished,
1755 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001756 ErrorCode::kError);
Darin Petkove17f86b2010-07-20 09:12:01 -07001757 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadFinished, error_event.type);
1758 EXPECT_EQ(OmahaEvent::kResultError, error_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001759 EXPECT_EQ(ErrorCode::kError, error_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001760}
1761
Askar Aitzhan570ca872019-04-24 11:16:12 +02001762TEST_F(OmahaRequestActionTest, DeviceQuickFixBuildTokenIsSetTest) {
Askar Aitzhan18fff842019-06-21 23:24:37 +02001763 // If DeviceQuickFixBuildToken value is set it takes precedence over pref
1764 // value.
1765 constexpr char autoupdate_token[] = "autoupdate_token>";
1766 constexpr char xml_encoded_autoupdate_token[] = "autoupdate_token&gt;";
1767 constexpr char omaha_cohort_hint[] = "cohort_hint";
Askar Aitzhan570ca872019-04-24 11:16:12 +02001768
1769 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1770 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1771 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1772 request_params_.set_autoupdate_token(autoupdate_token);
Askar Aitzhan18fff842019-06-21 23:24:37 +02001773 fake_prefs_.SetString(kPrefsOmahaCohortHint, omaha_cohort_hint);
Askar Aitzhan570ca872019-04-24 11:16:12 +02001774
1775 ASSERT_TRUE(TestUpdateCheck());
1776
Askar Aitzhan18fff842019-06-21 23:24:37 +02001777 EXPECT_NE(string::npos,
1778 post_str.find("cohorthint=\"" +
1779 string(xml_encoded_autoupdate_token) + "\""));
1780 EXPECT_EQ(string::npos, post_str.find(autoupdate_token));
1781 EXPECT_EQ(string::npos, post_str.find(omaha_cohort_hint));
1782}
1783
1784TEST_F(OmahaRequestActionTest, DeviceQuickFixBuildTokenIsNotSetTest) {
1785 // If DeviceQuickFixBuildToken is not set, pref value will be provided in
1786 // cohorthint attribute.
1787 constexpr char omaha_cohort_hint[] = "evil_string>";
1788 constexpr char xml_encoded_cohort_hint[] = "evil_string&gt;";
1789
1790 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1791 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1792 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1793 fake_prefs_.SetString(kPrefsOmahaCohortHint, omaha_cohort_hint);
1794
1795 ASSERT_TRUE(TestUpdateCheck());
1796
1797 EXPECT_NE(
1798 string::npos,
1799 post_str.find("cohorthint=\"" + string(xml_encoded_cohort_hint) + "\""));
1800 EXPECT_EQ(string::npos, post_str.find(omaha_cohort_hint));
Askar Aitzhan570ca872019-04-24 11:16:12 +02001801}
1802
Amin Hassani37b67232020-08-13 09:29:48 -07001803TEST_F(OmahaRequestActionTest, TargetChannelHintTest) {
1804 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1805 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1806 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1807 request_params_.set_lts_tag("hint>");
1808
1809 ASSERT_TRUE(TestUpdateCheck());
1810
1811 EXPECT_NE(string::npos, post_str.find("ltstag=\"hint&gt;\""));
1812}
1813
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001814void OmahaRequestActionTest::PingTest(bool ping_only) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001815 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001816 fake_system_state_.set_prefs(&prefs);
1817 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001818 .Times(AnyNumber());
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001819 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
1820 // Add a few hours to the day difference to test no rounding, etc.
1821 int64_t five_days_ago =
1822 (Time::Now() - TimeDelta::FromHours(5 * 24 + 13)).ToInternalValue();
1823 int64_t six_days_ago =
1824 (Time::Now() - TimeDelta::FromHours(6 * 24 + 11)).ToInternalValue();
1825 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001826 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001827 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001828 .WillOnce(DoAll(SetArgPointee<1>(six_days_ago), Return(true)));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001829 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001830 .WillOnce(DoAll(SetArgPointee<1>(five_days_ago), Return(true)));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001831
1832 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1833 tuc_params_.ping_only = ping_only;
1834 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1835 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1836
1837 ASSERT_TRUE(TestUpdateCheck());
1838
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001839 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"6\" r=\"5\"></ping>"),
1840 string::npos);
1841 if (ping_only) {
1842 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
1843 EXPECT_EQ(post_str.find("previousversion"), string::npos);
1844 } else {
1845 EXPECT_NE(post_str.find("updatecheck"), string::npos);
1846 EXPECT_NE(post_str.find("previousversion"), string::npos);
Darin Petkov265f2902011-05-09 15:17:40 -07001847 }
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001848}
1849
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001850TEST_F(OmahaRequestActionTest, PingTestSendOnlyAPing) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001851 PingTest(true /* ping_only */);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001852}
1853
1854TEST_F(OmahaRequestActionTest, PingTestSendAlsoAnUpdateCheck) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001855 PingTest(false /* ping_only */);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001856}
1857
1858TEST_F(OmahaRequestActionTest, ActivePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001859 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001860 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001861 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001862 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001863 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001864 int64_t three_days_ago =
1865 (Time::Now() - TimeDelta::FromHours(3 * 24 + 12)).ToInternalValue();
1866 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001867 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001868 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001869 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001870 .WillOnce(DoAll(SetArgPointee<1>(three_days_ago), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001871 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001872 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001873
1874 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1875 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1876 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1877
1878 ASSERT_TRUE(TestUpdateCheck());
1879
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001880 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"3\"></ping>"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001881}
1882
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001883TEST_F(OmahaRequestActionTest, RollCallPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001884 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001885 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001886 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001887 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001888 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001889 int64_t four_days_ago =
1890 (Time::Now() - TimeDelta::FromHours(4 * 24)).ToInternalValue();
1891 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001892 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001893 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001894 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001895 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001896 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001897 .WillOnce(DoAll(SetArgPointee<1>(four_days_ago), Return(true)));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001898
1899 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1900 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1901 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1902
1903 ASSERT_TRUE(TestUpdateCheck());
1904
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001905 EXPECT_NE(post_str.find("<ping active=\"1\" r=\"4\"></ping>\n"),
Thieu Le116fda32011-04-19 11:01:54 -07001906 string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001907}
1908
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001909TEST_F(OmahaRequestActionTest, NoPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001910 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001911 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001912 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001913 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001914 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001915 int64_t one_hour_ago =
1916 (Time::Now() - TimeDelta::FromHours(1)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001917 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001918 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001919 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001920 .WillOnce(DoAll(SetArgPointee<1>(one_hour_ago), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001921 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001922 .WillOnce(DoAll(SetArgPointee<1>(one_hour_ago), Return(true)));
Alex Deymoebbe7ef2014-10-30 13:02:49 -07001923 // LastActivePingDay and PrefsLastRollCallPingDay are set even if we didn't
1924 // send a ping.
1925 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
1926 .WillOnce(Return(true));
1927 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
1928 .WillOnce(Return(true));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001929
1930 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1931 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1932 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1933
1934 ASSERT_TRUE(TestUpdateCheck());
1935
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001936 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001937}
1938
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001939TEST_F(OmahaRequestActionTest, IgnoreEmptyPingTest) {
Thieu Leb44e9e82011-06-06 14:34:04 -07001940 // This test ensures that we ignore empty ping only requests.
Alex Deymo8427b4a2014-11-05 14:00:32 -08001941 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001942 fake_system_state_.set_prefs(&prefs);
Thieu Leb44e9e82011-06-06 14:34:04 -07001943 int64_t now = Time::Now().ToInternalValue();
1944 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001945 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Thieu Leb44e9e82011-06-06 14:34:04 -07001946 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001947 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Thieu Leb44e9e82011-06-06 14:34:04 -07001948 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
1949 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001950
1951 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1952 tuc_params_.ping_only = true;
1953 tuc_params_.expected_check_result = metrics::CheckResult::kUnset;
1954 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1955
1956 EXPECT_TRUE(TestUpdateCheck());
1957 EXPECT_TRUE(post_str.empty());
Thieu Leb44e9e82011-06-06 14:34:04 -07001958}
1959
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001960TEST_F(OmahaRequestActionTest, BackInTimePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001961 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001962 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001963 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001964 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001965 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001966 int64_t future =
1967 (Time::Now() + TimeDelta::FromHours(3 * 24 + 4)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001968 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001969 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001970 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001971 .WillOnce(DoAll(SetArgPointee<1>(future), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001972 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001973 .WillOnce(DoAll(SetArgPointee<1>(future), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001974 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
1975 .WillOnce(Return(true));
1976 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
1977 .WillOnce(Return(true));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001978
1979 tuc_params_.http_response =
1980 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
1981 "protocol=\"3.0\"><daystart elapsed_seconds=\"100\"/>"
1982 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
1983 "<updatecheck status=\"noupdate\"/></app></response>";
1984 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1985 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1986
1987 ASSERT_TRUE(TestUpdateCheck());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001988 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001989}
1990
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001991TEST_F(OmahaRequestActionTest, LastPingDayUpdateTest) {
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001992 // This test checks that the action updates the last ping day to now
Darin Petkov84c763c2010-07-29 16:27:58 -07001993 // minus 200 seconds with a slack of 5 seconds. Therefore, the test
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001994 // may fail if it runs for longer than 5 seconds. It shouldn't run
1995 // that long though.
1996 int64_t midnight =
1997 (Time::Now() - TimeDelta::FromSeconds(200)).ToInternalValue();
1998 int64_t midnight_slack =
1999 (Time::Now() - TimeDelta::FromSeconds(195)).ToInternalValue();
Alex Deymo8427b4a2014-11-05 14:00:32 -08002000 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002001 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002002 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
2003 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002004 EXPECT_CALL(prefs,
2005 SetInt64(kPrefsLastActivePingDay,
2006 AllOf(Ge(midnight), Le(midnight_slack))))
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002007 .WillOnce(Return(true));
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002008 EXPECT_CALL(prefs,
2009 SetInt64(kPrefsLastRollCallPingDay,
2010 AllOf(Ge(midnight), Le(midnight_slack))))
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002011 .WillOnce(Return(true));
Amin Hassani41ac04b2019-03-29 11:31:03 -07002012
2013 tuc_params_.http_response =
2014 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2015 "protocol=\"3.0\"><daystart elapsed_seconds=\"200\"/>"
2016 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
2017 "<updatecheck status=\"noupdate\"/></app></response>";
2018 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2019 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2020
2021 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002022}
2023
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002024TEST_F(OmahaRequestActionTest, NoElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002025 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002026 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002027 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
2028 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002029 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
2030 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002031
2032 tuc_params_.http_response =
2033 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2034 "protocol=\"3.0\"><daystart blah=\"200\"/>"
2035 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
2036 "<updatecheck status=\"noupdate\"/></app></response>";
2037 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2038 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2039
2040 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002041}
2042
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002043TEST_F(OmahaRequestActionTest, BadElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002044 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002045 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002046 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
2047 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002048 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
2049 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002050
2051 tuc_params_.http_response =
2052 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2053 "protocol=\"3.0\"><daystart elapsed_seconds=\"x\"/>"
2054 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
2055 "<updatecheck status=\"noupdate\"/></app></response>";
2056 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2057 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2058
2059 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002060}
2061
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002062TEST_F(OmahaRequestActionTest, NoUniqueIDTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07002063 tuc_params_.http_response = "invalid xml>";
2064 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
2065 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
2066 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2067
2068 ASSERT_FALSE(TestUpdateCheck());
2069
Darin Petkov84c763c2010-07-29 16:27:58 -07002070 EXPECT_EQ(post_str.find("machineid="), string::npos);
2071 EXPECT_EQ(post_str.find("userid="), string::npos);
2072}
2073
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002074TEST_F(OmahaRequestActionTest, NetworkFailureTest) {
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002075 const int http_error_code =
2076 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 501;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002077 tuc_params_.fail_http_response_code = 501;
2078 tuc_params_.expected_code = static_cast<ErrorCode>(http_error_code);
2079 tuc_params_.expected_check_result = metrics::CheckResult::kDownloadError;
2080 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2081 tuc_params_.expected_download_error_code =
2082 static_cast<metrics::DownloadErrorCode>(501);
2083
2084 ASSERT_FALSE(TestUpdateCheck());
2085
Darin Petkovedc522e2010-11-05 09:35:17 -07002086 EXPECT_FALSE(response.update_exists);
2087}
2088
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002089TEST_F(OmahaRequestActionTest, NetworkFailureBadHTTPCodeTest) {
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002090 const int http_error_code =
2091 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 999;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002092
2093 tuc_params_.fail_http_response_code = 1500;
2094 tuc_params_.expected_code = static_cast<ErrorCode>(http_error_code);
2095 tuc_params_.expected_check_result = metrics::CheckResult::kDownloadError;
2096 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2097 tuc_params_.expected_download_error_code =
2098 metrics::DownloadErrorCode::kHttpStatusOther;
2099
2100 ASSERT_FALSE(TestUpdateCheck());
Darin Petkovedc522e2010-11-05 09:35:17 -07002101 EXPECT_FALSE(response.update_exists);
2102}
2103
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002104TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsPersistedFirstTime) {
Marton Hunyady2abda312018-04-24 18:21:49 +02002105 request_params_.set_wall_clock_based_wait_enabled(true);
2106 request_params_.set_waiting_period(TimeDelta().FromDays(1));
2107 request_params_.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002108
Sen Jiang7c1171e2016-06-23 11:35:40 -07002109 Time arbitrary_date;
Eric Caruso761be2c2018-05-22 16:23:33 -07002110 ASSERT_TRUE(Time::FromString("6/4/1989", &arbitrary_date));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002111 fake_system_state_.fake_clock()->SetWallclockTime(arbitrary_date);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002112
2113 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2114 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
2115 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
2116
2117 ASSERT_FALSE(TestUpdateCheck());
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002118
Ben Chan9abb7632014-08-07 00:10:53 -07002119 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002120 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002121 EXPECT_EQ(arbitrary_date.ToInternalValue(), timestamp);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002122 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -07002123
2124 // Verify if we are interactive check we don't defer.
Marton Hunyady2abda312018-04-24 18:21:49 +02002125 request_params_.set_interactive(true);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002126 tuc_params_.expected_code = ErrorCode::kSuccess;
2127 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUpdating;
2128
2129 ASSERT_TRUE(TestUpdateCheck());
Chris Sosa968d0572013-08-23 14:46:02 -07002130 EXPECT_TRUE(response.update_exists);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002131}
2132
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002133TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsUsedIfAlreadyPresent) {
Marton Hunyady2abda312018-04-24 18:21:49 +02002134 request_params_.set_wall_clock_based_wait_enabled(true);
2135 request_params_.set_waiting_period(TimeDelta().FromDays(1));
2136 request_params_.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002137
Sen Jiang7c1171e2016-06-23 11:35:40 -07002138 Time t1, t2;
Eric Caruso761be2c2018-05-22 16:23:33 -07002139 ASSERT_TRUE(Time::FromString("1/1/2012", &t1));
2140 ASSERT_TRUE(Time::FromString("1/3/2012", &t2));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002141 ASSERT_TRUE(
2142 fake_prefs_.SetInt64(kPrefsUpdateFirstSeenAt, t1.ToInternalValue()));
2143 fake_system_state_.fake_clock()->SetWallclockTime(t2);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002144
Amin Hassani41ac04b2019-03-29 11:31:03 -07002145 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2146
2147 ASSERT_TRUE(TestUpdateCheck());
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002148 EXPECT_TRUE(response.update_exists);
2149
2150 // Make sure the timestamp t1 is unchanged showing that it was reused.
Ben Chan9abb7632014-08-07 00:10:53 -07002151 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002152 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002153 ASSERT_TRUE(timestamp == t1.ToInternalValue());
2154}
2155
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002156TEST_F(OmahaRequestActionTest, TestChangingToMoreStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002157 // Create a uniquely named test directory.
Sen Jiang297e5832016-03-17 14:45:51 -07002158 base::ScopedTempDir tempdir;
2159 ASSERT_TRUE(tempdir.CreateUniqueTempDir());
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002160
Marton Hunyady2abda312018-04-24 18:21:49 +02002161 request_params_.set_root(tempdir.GetPath().value());
2162 request_params_.set_app_id("{22222222-2222-2222-2222-222222222222}");
2163 request_params_.set_app_version("1.2.3.4");
2164 request_params_.set_product_components("o.bundle=1");
2165 request_params_.set_current_channel("canary-channel");
2166 EXPECT_TRUE(
2167 request_params_.SetTargetChannel("stable-channel", true, nullptr));
2168 request_params_.UpdateDownloadChannel();
2169 EXPECT_TRUE(request_params_.ShouldPowerwash());
Amin Hassani41ac04b2019-03-29 11:31:03 -07002170
2171 tuc_params_.http_response = "invalid xml>";
2172 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
2173 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
2174 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2175
2176 ASSERT_FALSE(TestUpdateCheck());
2177
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002178 EXPECT_NE(
2179 string::npos,
2180 post_str.find("appid=\"{22222222-2222-2222-2222-222222222222}\" "
2181 "version=\"0.0.0.0\" from_version=\"1.2.3.4\" "
2182 "track=\"stable-channel\" from_track=\"canary-channel\" "));
Sen Jiang8cd42342018-01-31 12:06:59 -08002183 EXPECT_EQ(string::npos, post_str.find("o.bundle"));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002184}
2185
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002186TEST_F(OmahaRequestActionTest, TestChangingToLessStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002187 // Create a uniquely named test directory.
Sen Jiang297e5832016-03-17 14:45:51 -07002188 base::ScopedTempDir tempdir;
2189 ASSERT_TRUE(tempdir.CreateUniqueTempDir());
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002190
Marton Hunyady2abda312018-04-24 18:21:49 +02002191 request_params_.set_root(tempdir.GetPath().value());
2192 request_params_.set_app_id("{11111111-1111-1111-1111-111111111111}");
2193 request_params_.set_app_version("5.6.7.8");
2194 request_params_.set_product_components("o.bundle=1");
2195 request_params_.set_current_channel("stable-channel");
2196 EXPECT_TRUE(
2197 request_params_.SetTargetChannel("canary-channel", false, nullptr));
2198 request_params_.UpdateDownloadChannel();
2199 EXPECT_FALSE(request_params_.ShouldPowerwash());
Amin Hassani41ac04b2019-03-29 11:31:03 -07002200
2201 tuc_params_.http_response = "invalid xml>";
2202 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
2203 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
2204 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2205
2206 ASSERT_FALSE(TestUpdateCheck());
2207
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002208 EXPECT_NE(
2209 string::npos,
2210 post_str.find("appid=\"{11111111-1111-1111-1111-111111111111}\" "
2211 "version=\"5.6.7.8\" "
2212 "track=\"canary-channel\" from_track=\"stable-channel\""));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002213 EXPECT_EQ(string::npos, post_str.find("from_version"));
Sen Jiang8cd42342018-01-31 12:06:59 -08002214 EXPECT_NE(string::npos, post_str.find("o.bundle.version=\"1\""));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002215}
2216
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002217// Checks that the initial ping with a=-1 r=-1 is not send when the device
2218// was powerwashed.
2219TEST_F(OmahaRequestActionTest, PingWhenPowerwashed) {
2220 fake_prefs_.SetString(kPrefsPreviousVersion, "");
2221
2222 // Flag that the device was powerwashed in the past.
2223 fake_system_state_.fake_hardware()->SetPowerwashCount(1);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002224 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2225 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2226 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002227
Amin Hassani41ac04b2019-03-29 11:31:03 -07002228 ASSERT_TRUE(TestUpdateCheck());
2229
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002230 // We shouldn't send a ping in this case since powerwash > 0.
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002231 EXPECT_EQ(string::npos, post_str.find("<ping"));
2232}
2233
Amin Hassani1677e812017-06-21 13:36:36 -07002234// Checks that the initial ping with a=-1 r=-1 is not send when the device
2235// first_active_omaha_ping_sent is set.
2236TEST_F(OmahaRequestActionTest, PingWhenFirstActiveOmahaPingIsSent) {
2237 fake_prefs_.SetString(kPrefsPreviousVersion, "");
2238
2239 // Flag that the device was not powerwashed in the past.
2240 fake_system_state_.fake_hardware()->SetPowerwashCount(0);
2241
2242 // Flag that the device has sent first active ping in the past.
2243 fake_system_state_.fake_hardware()->SetFirstActiveOmahaPingSent();
2244
Amin Hassani41ac04b2019-03-29 11:31:03 -07002245 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2246 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2247 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2248
2249 ASSERT_TRUE(TestUpdateCheck());
2250
Amin Hassani1677e812017-06-21 13:36:36 -07002251 // We shouldn't send a ping in this case since
2252 // first_active_omaha_ping_sent=true
Amin Hassani1677e812017-06-21 13:36:36 -07002253 EXPECT_EQ(string::npos, post_str.find("<ping"));
2254}
2255
Alex Deymo9fded1e2015-11-05 12:31:19 -08002256// Checks that the event 54 is sent on a reboot to a new update.
2257TEST_F(OmahaRequestActionTest, RebootAfterUpdateEvent) {
2258 // Flag that the device was updated in a previous boot.
2259 fake_prefs_.SetString(kPrefsPreviousVersion, "1.2.3.4");
2260
Amin Hassani41ac04b2019-03-29 11:31:03 -07002261 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2262 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2263 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2264
2265 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo9fded1e2015-11-05 12:31:19 -08002266
2267 // An event 54 is included and has the right version.
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002268 EXPECT_NE(
2269 string::npos,
2270 post_str.find(base::StringPrintf("<event eventtype=\"%d\"",
2271 OmahaEvent::kTypeRebootedAfterUpdate)));
Alex Deymo9fded1e2015-11-05 12:31:19 -08002272 EXPECT_NE(string::npos,
2273 post_str.find("previousversion=\"1.2.3.4\"></event>"));
2274
2275 // The previous version flag should have been removed.
2276 EXPECT_TRUE(fake_prefs_.Exists(kPrefsPreviousVersion));
2277 string prev_version;
2278 EXPECT_TRUE(fake_prefs_.GetString(kPrefsPreviousVersion, &prev_version));
2279 EXPECT_TRUE(prev_version.empty());
2280}
2281
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002282void OmahaRequestActionTest::P2PTest(bool initial_allow_p2p_for_downloading,
2283 bool initial_allow_p2p_for_sharing,
2284 bool omaha_disable_p2p_for_downloading,
2285 bool omaha_disable_p2p_for_sharing,
2286 bool payload_state_allow_p2p_attempt,
2287 bool expect_p2p_client_lookup,
2288 const string& p2p_client_result_url,
2289 bool expected_allow_p2p_for_downloading,
2290 bool expected_allow_p2p_for_sharing,
2291 const string& expected_p2p_url) {
Gilad Arnold74b5f552014-10-07 08:17:16 -07002292 bool actual_allow_p2p_for_downloading = initial_allow_p2p_for_downloading;
2293 bool actual_allow_p2p_for_sharing = initial_allow_p2p_for_sharing;
2294 string actual_p2p_url;
David Zeuthen8f191b22013-08-06 12:27:50 -07002295
2296 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002297 fake_system_state_.set_payload_state(&mock_payload_state);
David Zeuthen8f191b22013-08-06 12:27:50 -07002298 EXPECT_CALL(mock_payload_state, P2PAttemptAllowed())
2299 .WillRepeatedly(Return(payload_state_allow_p2p_attempt));
Gilad Arnold74b5f552014-10-07 08:17:16 -07002300 EXPECT_CALL(mock_payload_state, GetUsingP2PForDownloading())
2301 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_downloading));
2302 EXPECT_CALL(mock_payload_state, GetUsingP2PForSharing())
2303 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_sharing));
2304 EXPECT_CALL(mock_payload_state, SetUsingP2PForDownloading(_))
2305 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_downloading));
2306 EXPECT_CALL(mock_payload_state, SetUsingP2PForSharing(_))
2307 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_sharing));
2308 EXPECT_CALL(mock_payload_state, SetP2PUrl(_))
2309 .WillRepeatedly(SaveArg<0>(&actual_p2p_url));
2310
David Zeuthen8f191b22013-08-06 12:27:50 -07002311 MockP2PManager mock_p2p_manager;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002312 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -07002313 mock_p2p_manager.fake().SetLookupUrlForFileResult(p2p_client_result_url);
2314
David Zeuthen4cc5ed22014-01-15 12:35:03 -08002315 TimeDelta timeout = TimeDelta::FromSeconds(kMaxP2PNetworkWaitTimeSeconds);
2316 EXPECT_CALL(mock_p2p_manager, LookupUrlForFile(_, _, timeout, _))
David Zeuthen8f191b22013-08-06 12:27:50 -07002317 .Times(expect_p2p_client_lookup ? 1 : 0);
2318
Alex Deymo8e18f932015-03-27 16:16:59 -07002319 fake_update_response_.disable_p2p_for_downloading =
2320 omaha_disable_p2p_for_downloading;
2321 fake_update_response_.disable_p2p_for_sharing = omaha_disable_p2p_for_sharing;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002322
2323 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2324 tuc_params_.expected_check_result = metrics::CheckResult::kUpdateAvailable;
2325
2326 ASSERT_TRUE(TestUpdateCheck());
David Zeuthen8f191b22013-08-06 12:27:50 -07002327 EXPECT_TRUE(response.update_exists);
2328
Gilad Arnold74b5f552014-10-07 08:17:16 -07002329 EXPECT_EQ(omaha_disable_p2p_for_downloading,
2330 response.disable_p2p_for_downloading);
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002331 EXPECT_EQ(omaha_disable_p2p_for_sharing, response.disable_p2p_for_sharing);
David Zeuthen8f191b22013-08-06 12:27:50 -07002332
Gilad Arnold74b5f552014-10-07 08:17:16 -07002333 EXPECT_EQ(expected_allow_p2p_for_downloading,
2334 actual_allow_p2p_for_downloading);
2335 EXPECT_EQ(expected_allow_p2p_for_sharing, actual_allow_p2p_for_sharing);
2336 EXPECT_EQ(expected_p2p_url, actual_p2p_url);
David Zeuthen8f191b22013-08-06 12:27:50 -07002337}
2338
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002339TEST_F(OmahaRequestActionTest, P2PWithPeer) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002340 P2PTest(true, // initial_allow_p2p_for_downloading
2341 true, // initial_allow_p2p_for_sharing
2342 false, // omaha_disable_p2p_for_downloading
2343 false, // omaha_disable_p2p_for_sharing
2344 true, // payload_state_allow_p2p_attempt
2345 true, // expect_p2p_client_lookup
2346 "http://1.3.5.7/p2p", // p2p_client_result_url
2347 true, // expected_allow_p2p_for_downloading
2348 true, // expected_allow_p2p_for_sharing
2349 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002350}
2351
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002352TEST_F(OmahaRequestActionTest, P2PWithoutPeer) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002353 P2PTest(true, // initial_allow_p2p_for_downloading
2354 true, // initial_allow_p2p_for_sharing
2355 false, // omaha_disable_p2p_for_downloading
2356 false, // omaha_disable_p2p_for_sharing
2357 true, // payload_state_allow_p2p_attempt
2358 true, // expect_p2p_client_lookup
2359 "", // p2p_client_result_url
2360 false, // expected_allow_p2p_for_downloading
2361 true, // expected_allow_p2p_for_sharing
2362 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002363}
2364
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002365TEST_F(OmahaRequestActionTest, P2PDownloadNotAllowed) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002366 P2PTest(false, // initial_allow_p2p_for_downloading
2367 true, // initial_allow_p2p_for_sharing
2368 false, // omaha_disable_p2p_for_downloading
2369 false, // omaha_disable_p2p_for_sharing
2370 true, // payload_state_allow_p2p_attempt
2371 false, // expect_p2p_client_lookup
2372 "unset", // p2p_client_result_url
2373 false, // expected_allow_p2p_for_downloading
2374 true, // expected_allow_p2p_for_sharing
2375 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002376}
2377
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002378TEST_F(OmahaRequestActionTest, P2PWithPeerDownloadDisabledByOmaha) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002379 P2PTest(true, // initial_allow_p2p_for_downloading
2380 true, // initial_allow_p2p_for_sharing
2381 true, // omaha_disable_p2p_for_downloading
2382 false, // omaha_disable_p2p_for_sharing
2383 true, // payload_state_allow_p2p_attempt
2384 false, // expect_p2p_client_lookup
2385 "unset", // p2p_client_result_url
2386 false, // expected_allow_p2p_for_downloading
2387 true, // expected_allow_p2p_for_sharing
2388 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002389}
2390
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002391TEST_F(OmahaRequestActionTest, P2PWithPeerSharingDisabledByOmaha) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002392 P2PTest(true, // initial_allow_p2p_for_downloading
2393 true, // initial_allow_p2p_for_sharing
2394 false, // omaha_disable_p2p_for_downloading
2395 true, // omaha_disable_p2p_for_sharing
2396 true, // payload_state_allow_p2p_attempt
2397 true, // expect_p2p_client_lookup
2398 "http://1.3.5.7/p2p", // p2p_client_result_url
2399 true, // expected_allow_p2p_for_downloading
2400 false, // expected_allow_p2p_for_sharing
2401 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002402}
2403
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002404TEST_F(OmahaRequestActionTest, P2PWithPeerBothDisabledByOmaha) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002405 P2PTest(true, // initial_allow_p2p_for_downloading
2406 true, // initial_allow_p2p_for_sharing
2407 true, // omaha_disable_p2p_for_downloading
2408 true, // omaha_disable_p2p_for_sharing
2409 true, // payload_state_allow_p2p_attempt
2410 false, // expect_p2p_client_lookup
2411 "unset", // p2p_client_result_url
2412 false, // expected_allow_p2p_for_downloading
2413 false, // expected_allow_p2p_for_sharing
2414 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002415}
2416
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002417bool OmahaRequestActionTest::InstallDateParseHelper(const string& elapsed_days,
2418 OmahaResponse* response) {
Alex Deymo8e18f932015-03-27 16:16:59 -07002419 fake_update_response_.elapsed_days = elapsed_days;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002420 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2421
2422 return TestUpdateCheck();
David Zeuthen639aa362014-02-03 16:23:44 -08002423}
2424
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002425TEST_F(OmahaRequestActionTest, ParseInstallDateFromResponse) {
Kevin Cernekee2494e282016-03-29 18:03:53 -07002426 // Simulate a successful update check that happens during OOBE. The
2427 // deadline in the response is needed to force the update attempt to
2428 // occur; responses without a deadline seen during OOBE will normally
2429 // return ErrorCode::kNonCriticalUpdateInOOBE.
2430 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
2431 fake_update_response_.deadline = "20101020";
2432
David Zeuthen639aa362014-02-03 16:23:44 -08002433 // Check that we parse elapsed_days in the Omaha Response correctly.
2434 // and that the kPrefsInstallDateDays value is written to.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002435 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2436 EXPECT_TRUE(InstallDateParseHelper("42", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002437 EXPECT_TRUE(response.update_exists);
2438 EXPECT_EQ(42, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002439 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002440 int64_t prefs_days;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002441 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002442 EXPECT_EQ(prefs_days, 42);
2443
2444 // If there already is a value set, we shouldn't do anything.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002445 EXPECT_TRUE(InstallDateParseHelper("7", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002446 EXPECT_TRUE(response.update_exists);
2447 EXPECT_EQ(7, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002448 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002449 EXPECT_EQ(prefs_days, 42);
2450
2451 // Note that elapsed_days is not necessarily divisible by 7 so check
2452 // that we round down correctly when populating kPrefsInstallDateDays.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002453 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2454 EXPECT_TRUE(InstallDateParseHelper("23", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002455 EXPECT_TRUE(response.update_exists);
2456 EXPECT_EQ(23, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002457 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002458 EXPECT_EQ(prefs_days, 21);
2459
2460 // Check that we correctly handle elapsed_days not being included in
2461 // the Omaha Response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002462 EXPECT_TRUE(InstallDateParseHelper("", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002463 EXPECT_TRUE(response.update_exists);
2464 EXPECT_EQ(-1, response.install_date_days);
David Zeuthen639aa362014-02-03 16:23:44 -08002465}
2466
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002467// If there is no prefs and OOBE is not complete, we should not
2468// report anything to Omaha.
2469TEST_F(OmahaRequestActionTest, GetInstallDateWhenNoPrefsNorOOBE) {
Kevin Cernekee2494e282016-03-29 18:03:53 -07002470 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002471 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2472 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2473}
David Zeuthen639aa362014-02-03 16:23:44 -08002474
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002475// If OOBE is complete and happened on a valid date (e.g. after Jan
2476// 1 2007 0:00 PST), that date should be used and written to
2477// prefs. However, first try with an invalid date and check we do
2478// nothing.
2479TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithInvalidDate) {
2480 Time oobe_date = Time::FromTimeT(42); // Dec 31, 1969 16:00:42 PST.
2481 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2482 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2483 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2484}
David Zeuthen639aa362014-02-03 16:23:44 -08002485
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002486// Then check with a valid date. The date Jan 20, 2007 0:00 PST
2487// should yield an InstallDate of 14.
2488TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithValidDate) {
2489 Time oobe_date = Time::FromTimeT(1169280000); // Jan 20, 2007 0:00 PST.
2490 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2491 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
2492 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002493
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002494 int64_t prefs_days;
2495 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2496 EXPECT_EQ(prefs_days, 14);
2497}
David Zeuthen639aa362014-02-03 16:23:44 -08002498
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002499// Now that we have a valid date in prefs, check that we keep using
2500// that even if OOBE date reports something else. The date Jan 30,
2501// 2007 0:00 PST should yield an InstallDate of 28... but since
2502// there's a prefs file, we should still get 14.
2503TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedDateChanges) {
2504 // Set a valid date in the prefs first.
2505 EXPECT_TRUE(fake_prefs_.SetInt64(kPrefsInstallDateDays, 14));
David Zeuthen639aa362014-02-03 16:23:44 -08002506
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002507 Time oobe_date = Time::FromTimeT(1170144000); // Jan 30, 2007 0:00 PST.
2508 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2509 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002510
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002511 int64_t prefs_days;
2512 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2513 EXPECT_EQ(prefs_days, 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002514
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002515 // If we delete the prefs file, we should get 28 days.
2516 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2517 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 28);
2518 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2519 EXPECT_EQ(prefs_days, 28);
David Zeuthen639aa362014-02-03 16:23:44 -08002520}
2521
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002522// Verifies that a device with no device policy, and is not a consumer
2523// device sets the max kernel key version to the current version.
2524// ie. the same behavior as if rollback is enabled.
2525TEST_F(OmahaRequestActionTest, NoPolicyEnterpriseDevicesSetMaxRollback) {
2526 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2527
2528 // Setup and verify some initial default values for the kernel TPM
2529 // values that control verified boot and rollback.
2530 const int min_kernel_version = 4;
2531 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2532 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2533 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2534 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2535
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002536 EXPECT_CALL(
2537 *fake_system_state_.mock_metrics_reporter(),
2538 ReportKeyVersionMetrics(min_kernel_version, min_kernel_version, true))
2539 .Times(1);
2540
Amin Hassani41ac04b2019-03-29 11:31:03 -07002541 fake_update_response_.deadline = "20101020";
2542 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2543 tuc_params_.is_consumer_device = false;
2544 tuc_params_.rollback_allowed_milestones = 3;
2545
2546 EXPECT_TRUE(TestUpdateCheck());
2547 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002548
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002549 // Verify kernel_max_rollforward was set to the current minimum
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002550 // kernel key version. This has the effect of freezing roll
2551 // forwards indefinitely. This will hold the rollback window
2552 // open until a future change will be able to move this forward
2553 // relative the configured window.
2554 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2555 EXPECT_EQ(min_kernel_version, fake_hw->GetMaxKernelKeyRollforward());
2556}
2557
2558// Verifies that a conmsumer device with no device policy sets the
2559// max kernel key version to the current version. ie. the same
2560// behavior as if rollback is enabled.
2561TEST_F(OmahaRequestActionTest, NoPolicyConsumerDevicesSetMaxRollback) {
2562 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2563
2564 // Setup and verify some initial default values for the kernel TPM
2565 // values that control verified boot and rollback.
2566 const int min_kernel_version = 3;
2567 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2568 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2569 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2570 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2571
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002572 EXPECT_CALL(
2573 *fake_system_state_.mock_metrics_reporter(),
2574 ReportKeyVersionMetrics(min_kernel_version, kRollforwardInfinity, true))
2575 .Times(1);
2576
Amin Hassani41ac04b2019-03-29 11:31:03 -07002577 fake_update_response_.deadline = "20101020";
2578 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2579 tuc_params_.is_consumer_device = true;
2580 tuc_params_.rollback_allowed_milestones = 3;
2581
2582 EXPECT_TRUE(TestUpdateCheck());
2583 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002584
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002585 // Verify that with rollback disabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002586 // was set to logical infinity. This is the expected behavior for
2587 // consumer devices and matches the existing behavior prior to the
2588 // rollback features.
2589 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2590 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2591}
2592
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002593// Verifies that a device with rollback enabled sets kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002594// in the TPM to prevent roll forward.
2595TEST_F(OmahaRequestActionTest, RollbackEnabledDevicesSetMaxRollback) {
2596 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2597
2598 // Setup and verify some initial default values for the kernel TPM
2599 // values that control verified boot and rollback.
2600 const int allowed_milestones = 4;
2601 const int min_kernel_version = 3;
2602 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2603 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2604 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2605 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2606
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002607 EXPECT_CALL(
2608 *fake_system_state_.mock_metrics_reporter(),
2609 ReportKeyVersionMetrics(min_kernel_version, min_kernel_version, true))
2610 .Times(1);
2611
Amin Hassani41ac04b2019-03-29 11:31:03 -07002612 fake_update_response_.deadline = "20101020";
2613 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2614 tuc_params_.is_consumer_device = false;
2615 tuc_params_.rollback_allowed_milestones = allowed_milestones;
2616 tuc_params_.is_policy_loaded = true;
2617
2618 EXPECT_TRUE(TestUpdateCheck());
2619 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002620
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002621 // Verify that with rollback enabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002622 // was set to the current minimum kernel key version. This has
2623 // the effect of freezing roll forwards indefinitely. This will
2624 // hold the rollback window open until a future change will
2625 // be able to move this forward relative the configured window.
2626 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2627 EXPECT_EQ(min_kernel_version, fake_hw->GetMaxKernelKeyRollforward());
2628}
2629
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002630// Verifies that a device with rollback disabled sets kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002631// in the TPM to logical infinity, to allow roll forward.
2632TEST_F(OmahaRequestActionTest, RollbackDisabledDevicesSetMaxRollback) {
2633 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2634
2635 // Setup and verify some initial default values for the kernel TPM
2636 // values that control verified boot and rollback.
2637 const int allowed_milestones = 0;
2638 const int min_kernel_version = 3;
2639 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2640 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2641 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2642 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2643
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002644 EXPECT_CALL(
2645 *fake_system_state_.mock_metrics_reporter(),
2646 ReportKeyVersionMetrics(min_kernel_version, kRollforwardInfinity, true))
2647 .Times(1);
2648
Amin Hassani41ac04b2019-03-29 11:31:03 -07002649 fake_update_response_.deadline = "20101020";
2650 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2651 tuc_params_.is_consumer_device = false;
2652 tuc_params_.rollback_allowed_milestones = allowed_milestones;
2653 tuc_params_.is_policy_loaded = true;
2654
2655 EXPECT_TRUE(TestUpdateCheck());
2656 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002657
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002658 // Verify that with rollback disabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002659 // was set to logical infinity.
2660 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2661 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2662}
2663
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002664TEST_F(OmahaRequestActionTest, RollbackResponseParsedNoEntries) {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002665 fake_update_response_.rollback = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002666 fake_update_response_.deadline = "20101020";
2667 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2668 tuc_params_.is_consumer_device = false;
2669 tuc_params_.rollback_allowed_milestones = 4;
2670 tuc_params_.is_policy_loaded = true;
2671
2672 EXPECT_TRUE(TestUpdateCheck());
2673 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002674 EXPECT_TRUE(response.is_rollback);
2675}
2676
2677TEST_F(OmahaRequestActionTest, RollbackResponseValidVersionsParsed) {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002678 fake_update_response_.rollback_firmware_version = "1.2";
2679 fake_update_response_.rollback_kernel_version = "3.4";
2680 fake_update_response_.rollback = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002681 fake_update_response_.deadline = "20101020";
2682 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2683 tuc_params_.is_consumer_device = false;
2684 tuc_params_.rollback_allowed_milestones = 4;
2685 tuc_params_.is_policy_loaded = true;
2686
2687 EXPECT_TRUE(TestUpdateCheck());
2688 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002689 EXPECT_TRUE(response.is_rollback);
2690 EXPECT_EQ(1, response.rollback_key_version.firmware_key);
2691 EXPECT_EQ(2, response.rollback_key_version.firmware);
2692 EXPECT_EQ(3, response.rollback_key_version.kernel_key);
2693 EXPECT_EQ(4, response.rollback_key_version.kernel);
2694}
2695
May Lippert60aa3ca2018-08-15 16:55:29 -07002696TEST_F(OmahaRequestActionTest,
2697 TestUpdateFirstSeenAtPrefPersistedIfUpdateExists) {
2698 FakeClock fake_clock;
2699 Time now = Time::Now();
2700 fake_clock.SetWallclockTime(now);
2701 fake_system_state_.set_clock(&fake_clock);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002702 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
May Lippert60aa3ca2018-08-15 16:55:29 -07002703
Amin Hassani41ac04b2019-03-29 11:31:03 -07002704 ASSERT_TRUE(TestUpdateCheck());
2705
May Lippert60aa3ca2018-08-15 16:55:29 -07002706 EXPECT_TRUE(response.update_exists);
2707 EXPECT_TRUE(fake_prefs_.Exists(kPrefsUpdateFirstSeenAt));
2708
2709 int64_t stored_first_seen_at_time;
2710 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt,
2711 &stored_first_seen_at_time));
2712 EXPECT_EQ(now.ToInternalValue(), stored_first_seen_at_time);
2713}
2714
2715TEST_F(OmahaRequestActionTest,
2716 TestUpdateFirstSeenAtPrefNotPersistedIfUpdateFails) {
2717 FakeClock fake_clock;
2718 Time now = Time::Now();
2719 fake_clock.SetWallclockTime(now);
2720 fake_system_state_.set_clock(&fake_clock);
2721
Amin Hassani41ac04b2019-03-29 11:31:03 -07002722 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2723 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2724 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2725
2726 ASSERT_TRUE(TestUpdateCheck());
2727
May Lippert60aa3ca2018-08-15 16:55:29 -07002728 EXPECT_FALSE(response.update_exists);
2729 EXPECT_FALSE(fake_prefs_.Exists(kPrefsUpdateFirstSeenAt));
2730}
2731
Xiaochu Liu88d90382018-08-29 16:09:11 -07002732TEST_F(OmahaRequestActionTest, InstallTest) {
Xiaochu Liu6310be62018-10-11 15:09:03 -07002733 request_params_.set_is_install(true);
Andrewe045aef2020-01-08 16:29:22 -08002734 request_params_.set_dlc_apps_params(
2735 {{request_params_.GetDlcAppId("dlc_no_0"), {.name = "dlc_no_0"}},
2736 {request_params_.GetDlcAppId("dlc_no_1"), {.name = "dlc_no_1"}}});
Amin Hassani41ac04b2019-03-29 11:31:03 -07002737 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2738
2739 ASSERT_TRUE(TestUpdateCheck());
2740
Andrewe045aef2020-01-08 16:29:22 -08002741 for (const auto& it : request_params_.dlc_apps_params()) {
2742 EXPECT_NE(string::npos, post_str.find("appid=\"" + it.first + "\""));
Xiaochu Liu88d90382018-08-29 16:09:11 -07002743 }
Xiaochu Liu6310be62018-10-11 15:09:03 -07002744 EXPECT_NE(string::npos,
2745 post_str.find("appid=\"" + fake_update_response_.app_id + "\""));
2746
2747 // Count number of updatecheck tag in response.
2748 int updatecheck_count = 0;
2749 size_t pos = 0;
2750 while ((pos = post_str.find("<updatecheck", pos)) != string::npos) {
2751 updatecheck_count++;
2752 pos++;
2753 }
Andrewe045aef2020-01-08 16:29:22 -08002754 EXPECT_EQ(request_params_.dlc_apps_params().size(), updatecheck_count);
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002755 EXPECT_TRUE(response.update_exists);
Xiaochu Liu6310be62018-10-11 15:09:03 -07002756}
2757
2758TEST_F(OmahaRequestActionTest, InstallMissingPlatformVersionTest) {
2759 fake_update_response_.multi_app_skip_updatecheck = true;
2760 fake_update_response_.multi_app_no_update = false;
2761 request_params_.set_is_install(true);
Andrewe045aef2020-01-08 16:29:22 -08002762 request_params_.set_dlc_apps_params(
2763 {{request_params_.GetDlcAppId("dlc_no_0"), {.name = "dlc_no_0"}},
2764 {request_params_.GetDlcAppId("dlc_no_1"), {.name = "dlc_no_1"}}});
Xiaochu Liu6310be62018-10-11 15:09:03 -07002765 request_params_.set_app_id(fake_update_response_.app_id_skip_updatecheck);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002766 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2767
2768 ASSERT_TRUE(TestUpdateCheck());
2769
Xiaochu Liu6310be62018-10-11 15:09:03 -07002770 EXPECT_TRUE(response.update_exists);
2771 EXPECT_EQ(fake_update_response_.current_version, response.version);
Xiaochu Liu88d90382018-08-29 16:09:11 -07002772}
2773
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002774TEST_F(OmahaRequestActionTest, UpdateWithDlcTest) {
2775 request_params_.set_dlc_apps_params(
2776 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}}});
2777 fake_update_response_.dlc_app_update = true;
2778 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002779 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002780 ASSERT_TRUE(TestUpdateCheck());
2781
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002782 EXPECT_EQ(response.packages.size(), 2u);
2783 // Two candidate URLs.
2784 EXPECT_EQ(response.packages[1].payload_urls.size(), 2u);
2785 EXPECT_TRUE(response.update_exists);
2786}
2787
2788TEST_F(OmahaRequestActionTest, UpdateWithPartiallyExcludedDlcTest) {
Jae Hoon Kim3e69b4c2020-06-16 09:23:39 -07002789 const string kDlcAppId = request_params_.GetDlcAppId(kDlcId1);
2790 request_params_.set_dlc_apps_params({{kDlcAppId, {.name = kDlcId1}}});
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002791 fake_update_response_.dlc_app_update = true;
2792 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2793 // The first DLC candidate URL is excluded.
2794 EXPECT_CALL(mock_excluder_, IsExcluded(_))
2795 .WillOnce(Return(true))
2796 .WillOnce(Return(false));
2797 ASSERT_TRUE(TestUpdateCheck());
2798
2799 EXPECT_EQ(response.packages.size(), 2u);
2800 // One candidate URL.
2801 EXPECT_EQ(response.packages[1].payload_urls.size(), 1u);
2802 EXPECT_TRUE(response.update_exists);
Jae Hoon Kim3e69b4c2020-06-16 09:23:39 -07002803 EXPECT_TRUE(request_params_.dlc_apps_params().at(kDlcAppId).updated);
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002804}
2805
2806TEST_F(OmahaRequestActionTest, UpdateWithExcludedDlcTest) {
Jae Hoon Kim3e69b4c2020-06-16 09:23:39 -07002807 const string kDlcAppId = request_params_.GetDlcAppId(kDlcId1);
2808 request_params_.set_dlc_apps_params({{kDlcAppId, {.name = kDlcId1}}});
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002809 fake_update_response_.dlc_app_update = true;
2810 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2811 // Both DLC candidate URLs are excluded.
2812 EXPECT_CALL(mock_excluder_, IsExcluded(_))
2813 .WillOnce(Return(true))
2814 .WillOnce(Return(true));
2815 ASSERT_TRUE(TestUpdateCheck());
2816
2817 EXPECT_EQ(response.packages.size(), 1u);
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002818 EXPECT_TRUE(response.update_exists);
Jae Hoon Kim3e69b4c2020-06-16 09:23:39 -07002819 EXPECT_FALSE(request_params_.dlc_apps_params().at(kDlcAppId).updated);
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002820}
2821
2822TEST_F(OmahaRequestActionTest, UpdateWithDeprecatedDlcTest) {
2823 request_params_.set_dlc_apps_params(
2824 {{request_params_.GetDlcAppId(kDlcId2), {.name = kDlcId2}}});
2825 fake_update_response_.dlc_app_no_update = true;
2826 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002827 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002828 ASSERT_TRUE(TestUpdateCheck());
2829
2830 EXPECT_TRUE(response.update_exists);
2831}
2832
2833TEST_F(OmahaRequestActionTest, UpdateWithDlcAndDeprecatedDlcTest) {
2834 request_params_.set_dlc_apps_params(
2835 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}},
2836 {request_params_.GetDlcAppId(kDlcId2), {.name = kDlcId2}}});
2837 fake_update_response_.dlc_app_update = true;
2838 fake_update_response_.dlc_app_no_update = true;
2839 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07002840 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002841 ASSERT_TRUE(TestUpdateCheck());
2842
2843 EXPECT_TRUE(response.update_exists);
2844}
2845
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002846TEST_F(OmahaRequestActionTest, PastRollbackVersionsNoEntries) {
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002847 fake_update_response_.rollback = true;
2848 fake_update_response_.rollback_allowed_milestones = 4;
2849 request_params_.set_rollback_allowed_milestones(4);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002850 fake_update_response_.deadline = "20101020";
2851 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2852 tuc_params_.is_consumer_device = false;
2853 tuc_params_.rollback_allowed_milestones = 4;
2854 tuc_params_.is_policy_loaded = true;
2855
2856 EXPECT_TRUE(TestUpdateCheck());
2857 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002858 EXPECT_TRUE(response.is_rollback);
2859 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2860 response.past_rollback_key_version.firmware_key);
2861 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2862 response.past_rollback_key_version.firmware);
2863 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2864 response.past_rollback_key_version.kernel_key);
2865 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2866 response.past_rollback_key_version.kernel);
2867}
2868
2869TEST_F(OmahaRequestActionTest, PastRollbackVersionsValidEntries) {
Bailey Berrof3ce47f2019-02-25 18:22:17 -08002870 request_params_.set_rollback_allowed_milestones(4);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002871 fake_update_response_.rollback = true;
2872 fake_update_response_.rollback_allowed_milestones = 4;
2873 fake_update_response_.rollback_firmware_version = "4.3";
2874 fake_update_response_.rollback_kernel_version = "2.1";
2875 fake_update_response_.past_rollback_key_version =
2876 std::make_pair("16.15", "14.13");
Amin Hassani41ac04b2019-03-29 11:31:03 -07002877 fake_update_response_.deadline = "20101020";
2878 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2879 tuc_params_.is_consumer_device = false;
2880 tuc_params_.rollback_allowed_milestones = 4;
2881 tuc_params_.is_policy_loaded = true;
2882
2883 EXPECT_TRUE(TestUpdateCheck());
2884 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002885 EXPECT_TRUE(response.is_rollback);
2886 EXPECT_EQ(16, response.past_rollback_key_version.firmware_key);
2887 EXPECT_EQ(15, response.past_rollback_key_version.firmware);
2888 EXPECT_EQ(14, response.past_rollback_key_version.kernel_key);
2889 EXPECT_EQ(13, response.past_rollback_key_version.kernel);
2890}
2891
2892TEST_F(OmahaRequestActionTest, MismatchNumberOfVersions) {
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002893 fake_update_response_.rollback = true;
2894 fake_update_response_.rollback_allowed_milestones = 2;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002895 fake_update_response_.deadline = "20101020";
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002896 request_params_.set_rollback_allowed_milestones(4);
2897
2898 // Since |request_params_.rollback_allowed_milestones| is 4 but the response
2899 // is constructed with |fake_update_response_.rollback_allowed_milestones| set
2900 // to 2, OmahaRequestAction will look for the key values of N-4 version but
2901 // only the N-2 version will exist.
Amin Hassani41ac04b2019-03-29 11:31:03 -07002902 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2903 tuc_params_.is_consumer_device = false;
2904 tuc_params_.rollback_allowed_milestones = 2;
2905 tuc_params_.is_policy_loaded = true;
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002906
Amin Hassani41ac04b2019-03-29 11:31:03 -07002907 EXPECT_TRUE(TestUpdateCheck());
2908 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002909 EXPECT_TRUE(response.is_rollback);
2910 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2911 response.past_rollback_key_version.firmware_key);
2912 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2913 response.past_rollback_key_version.firmware);
2914 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2915 response.past_rollback_key_version.kernel_key);
2916 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2917 response.past_rollback_key_version.kernel);
2918}
2919
Matt Ziegelbaumaa8e1a42019-05-09 21:41:58 -04002920TEST_F(OmahaRequestActionTest, IncludeRequisitionTest) {
2921 request_params_.set_device_requisition("remora");
2922 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2923 ASSERT_TRUE(TestUpdateCheck());
2924 EXPECT_NE(string::npos, post_str.find("requisition=\"remora\""));
2925}
2926
2927TEST_F(OmahaRequestActionTest, NoIncludeRequisitionTest) {
2928 request_params_.set_device_requisition("");
2929 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2930 ASSERT_TRUE(TestUpdateCheck());
2931 EXPECT_EQ(string::npos, post_str.find("requisition"));
2932}
2933
Amin Hassani2cbb0692019-10-30 13:36:17 -07002934TEST_F(OmahaRequestActionTest, PersistEolDateTest) {
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002935 tuc_params_.http_response =
2936 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2937 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2938 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
Amin Hassani2cbb0692019-10-30 13:36:17 -07002939 "_eol_date=\"200\" _foo=\"bar\"/></app></response>";
2940 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2941 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2942
2943 ASSERT_TRUE(TestUpdateCheck());
2944
2945 string eol_date;
2946 EXPECT_TRUE(
2947 fake_system_state_.prefs()->GetString(kPrefsOmahaEolDate, &eol_date));
2948 EXPECT_EQ("200", eol_date);
2949}
2950
2951TEST_F(OmahaRequestActionTest, PersistEolMissingDateTest) {
2952 tuc_params_.http_response =
2953 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2954 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2955 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002956 "_foo=\"bar\"/></app></response>";
2957 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2958 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2959
Jae Hoon Kimb3146742019-11-07 13:24:24 -08002960 const string kDate = "123";
2961 fake_system_state_.prefs()->SetString(kPrefsOmahaEolDate, kDate);
2962
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002963 ASSERT_TRUE(TestUpdateCheck());
2964
Amin Hassani2cbb0692019-10-30 13:36:17 -07002965 string eol_date;
Jae Hoon Kimb3146742019-11-07 13:24:24 -08002966 EXPECT_TRUE(
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002967 fake_system_state_.prefs()->GetString(kPrefsOmahaEolDate, &eol_date));
Jae Hoon Kimb3146742019-11-07 13:24:24 -08002968 EXPECT_EQ(kDate, eol_date);
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002969}
2970
Amin Hassani2cbb0692019-10-30 13:36:17 -07002971TEST_F(OmahaRequestActionTest, PersistEolBadDateTest) {
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002972 tuc_params_.http_response =
2973 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2974 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2975 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
Amin Hassani2cbb0692019-10-30 13:36:17 -07002976 "_eol_date=\"bad\" foo=\"bar\"/></app></response>";
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002977 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2978 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2979
2980 ASSERT_TRUE(TestUpdateCheck());
2981
Amin Hassani2cbb0692019-10-30 13:36:17 -07002982 string eol_date;
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002983 EXPECT_TRUE(
2984 fake_system_state_.prefs()->GetString(kPrefsOmahaEolDate, &eol_date));
2985 EXPECT_EQ(kEolDateInvalid, StringToEolDate(eol_date));
2986}
2987
Andrew065d78d2020-04-07 15:43:07 -07002988TEST_F(OmahaRequestActionDlcPingTest, StorePingReplyNoPing) {
2989 OmahaRequestParams::AppParams app_param = {.name = dlc_id_};
Andrewe045aef2020-01-08 16:29:22 -08002990 request_params_.set_dlc_apps_params(
Andrew065d78d2020-04-07 15:43:07 -07002991 {{request_params_.GetDlcAppId(dlc_id_), app_param}});
Andrewe045aef2020-01-08 16:29:22 -08002992
2993 ASSERT_TRUE(TestUpdateCheck());
Andrew065d78d2020-04-07 15:43:07 -07002994
2995 int64_t temp_int;
Andrewe045aef2020-01-08 16:29:22 -08002996 // If there was no ping, the metadata files shouldn't exist yet.
Andrew065d78d2020-04-07 15:43:07 -07002997 EXPECT_FALSE(fake_prefs_.GetInt64(active_key_, &temp_int));
2998 EXPECT_FALSE(fake_prefs_.GetInt64(last_active_key_, &temp_int));
2999 EXPECT_FALSE(fake_prefs_.GetInt64(last_rollcall_key_, &temp_int));
Andrewe045aef2020-01-08 16:29:22 -08003000}
3001
Andrew065d78d2020-04-07 15:43:07 -07003002TEST_F(OmahaRequestActionDlcPingTest, StorePingReplyActiveTest) {
Andrewe045aef2020-01-08 16:29:22 -08003003 // Create Active value
Andrew065d78d2020-04-07 15:43:07 -07003004 fake_prefs_.SetInt64(active_key_, 0);
Andrewe045aef2020-01-08 16:29:22 -08003005
3006 OmahaRequestParams::AppParams app_param = {
3007 .active_counting_type = OmahaRequestParams::kDateBased,
Andrew065d78d2020-04-07 15:43:07 -07003008 .name = dlc_id_,
Andrewe045aef2020-01-08 16:29:22 -08003009 .ping_active = 1,
3010 .send_ping = true};
3011 request_params_.set_dlc_apps_params(
Andrew065d78d2020-04-07 15:43:07 -07003012 {{request_params_.GetDlcAppId(dlc_id_), app_param}});
Andrewe045aef2020-01-08 16:29:22 -08003013
Andrew065d78d2020-04-07 15:43:07 -07003014 int64_t temp_int;
3015 string temp_str;
Andrewe045aef2020-01-08 16:29:22 -08003016 ASSERT_TRUE(TestUpdateCheck());
Andrew065d78d2020-04-07 15:43:07 -07003017 EXPECT_TRUE(fake_prefs_.GetInt64(active_key_, &temp_int));
Andrewe045aef2020-01-08 16:29:22 -08003018 EXPECT_EQ(temp_int, kPingInactiveValue);
Andrew065d78d2020-04-07 15:43:07 -07003019 EXPECT_TRUE(fake_prefs_.GetString(last_active_key_, &temp_str));
3020 EXPECT_EQ(temp_str, "4763");
3021 EXPECT_TRUE(fake_prefs_.GetString(last_rollcall_key_, &temp_str));
3022 EXPECT_EQ(temp_str, "4763");
Andrewe045aef2020-01-08 16:29:22 -08003023}
3024
Andrew065d78d2020-04-07 15:43:07 -07003025TEST_F(OmahaRequestActionDlcPingTest, StorePingReplyInactiveTest) {
Andrewe045aef2020-01-08 16:29:22 -08003026 // Create Active value
Andrew065d78d2020-04-07 15:43:07 -07003027 fake_prefs_.SetInt64(active_key_, 0);
Andrewe045aef2020-01-08 16:29:22 -08003028
3029 OmahaRequestParams::AppParams app_param = {
3030 .active_counting_type = OmahaRequestParams::kDateBased,
Andrew065d78d2020-04-07 15:43:07 -07003031 .name = dlc_id_,
Andrewe045aef2020-01-08 16:29:22 -08003032 .ping_active = 0,
3033 .send_ping = true};
3034 request_params_.set_dlc_apps_params(
Andrew065d78d2020-04-07 15:43:07 -07003035 {{request_params_.GetDlcAppId(dlc_id_), app_param}});
Andrewe045aef2020-01-08 16:29:22 -08003036
3037 // Set the previous active value to an older value than 4763.
Andrew065d78d2020-04-07 15:43:07 -07003038 fake_prefs_.SetString(last_active_key_, "555");
Andrewe045aef2020-01-08 16:29:22 -08003039
Andrew065d78d2020-04-07 15:43:07 -07003040 int64_t temp_int;
Andrewe045aef2020-01-08 16:29:22 -08003041 ASSERT_TRUE(TestUpdateCheck());
Andrew065d78d2020-04-07 15:43:07 -07003042 EXPECT_TRUE(fake_prefs_.GetInt64(active_key_, &temp_int));
Andrewe045aef2020-01-08 16:29:22 -08003043 EXPECT_EQ(temp_int, kPingInactiveValue);
Andrew065d78d2020-04-07 15:43:07 -07003044 string temp_str;
3045 EXPECT_TRUE(fake_prefs_.GetString(last_active_key_, &temp_str));
3046 EXPECT_EQ(temp_str, "555");
3047 EXPECT_TRUE(fake_prefs_.GetString(last_rollcall_key_, &temp_str));
3048 EXPECT_EQ(temp_str, "4763");
Andrewe045aef2020-01-08 16:29:22 -08003049}
3050
Jae Hoon Kim694eeb02020-06-01 14:24:08 -07003051TEST_F(OmahaRequestActionTest, OmahaResponseUpdateCanExcludeCheck) {
3052 request_params_.set_dlc_apps_params(
3053 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}}});
3054 fake_update_response_.dlc_app_update = true;
3055 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
3056
3057 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
3058 ASSERT_TRUE(TestUpdateCheck());
3059 ASSERT_TRUE(delegate_.omaha_response_);
3060 const auto& packages = delegate_.omaha_response_->packages;
3061 ASSERT_EQ(packages.size(), 2);
3062
3063 EXPECT_FALSE(packages[0].can_exclude);
3064 EXPECT_TRUE(packages[1].can_exclude);
3065}
3066
3067TEST_F(OmahaRequestActionTest, OmahaResponseInstallCannotExcludeCheck) {
3068 request_params_.set_is_install(true);
3069 request_params_.set_dlc_apps_params(
3070 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}}});
3071 fake_update_response_.dlc_app_update = true;
3072 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
3073
3074 EXPECT_CALL(mock_excluder_, IsExcluded(_)).WillRepeatedly(Return(false));
3075 ASSERT_TRUE(TestUpdateCheck());
3076 ASSERT_TRUE(delegate_.omaha_response_);
3077 const auto& packages = delegate_.omaha_response_->packages;
3078 ASSERT_EQ(packages.size(), 2);
3079
3080 EXPECT_FALSE(packages[0].can_exclude);
3081 EXPECT_FALSE(packages[1].can_exclude);
3082}
3083
Darin Petkov6a5b3222010-07-13 14:55:28 -07003084} // namespace chromeos_update_engine