blob: 262e8bc0738e144f9f749a58b7bba8b838f0ae02 [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2012 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070016
Alex Deymo39910dc2015-11-09 17:04:30 -080017#include "update_engine/payload_consumer/delta_performer.h"
Darin Petkovd7061ab2010-10-06 14:37:09 -070018
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070019#include <errno.h>
Alex Deymo79715ad2015-10-02 14:27:53 -070020#include <linux/fs.h>
Darin Petkovd7061ab2010-10-06 14:37:09 -070021
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070022#include <algorithm>
23#include <cstring>
Yifan Hong537802d2018-08-15 13:15:42 -070024#include <map>
Ben Chan02f7c1d2014-10-18 15:18:02 -070025#include <memory>
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070026#include <string>
Amin Hassanid87304c2017-08-29 11:40:03 -070027#include <utility>
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070028#include <vector>
29
Ben Chan06c76a42014-09-05 08:21:06 -070030#include <base/files/file_util.h>
Alex Deymo161c4a12014-05-16 15:56:21 -070031#include <base/format_macros.h>
Lann Martin39f57142017-07-14 09:18:42 -060032#include <base/metrics/histogram_macros.h>
Alex Deymo67140842016-06-15 13:28:59 -070033#include <base/strings/string_number_conversions.h>
Alex Vakulenko75039d72014-03-25 12:36:28 -070034#include <base/strings/string_util.h>
35#include <base/strings/stringprintf.h>
Lann Martin39f57142017-07-14 09:18:42 -060036#include <base/time/time.h>
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -070037#include <brillo/data_encoding.h>
Alex Deymo6765a682017-05-19 13:13:54 -070038#include <bsdiff/bspatch.h>
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070039#include <google/protobuf/repeated_field.h>
Amin Hassani02855c22017-09-06 22:34:50 -070040#include <puffin/puffpatch.h>
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070041
Alex Deymo39910dc2015-11-09 17:04:30 -080042#include "update_engine/common/constants.h"
43#include "update_engine/common/hardware_interface.h"
Alex Deymo542c19b2015-12-03 07:43:31 -030044#include "update_engine/common/prefs_interface.h"
45#include "update_engine/common/subprocess.h"
46#include "update_engine/common/terminator.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080047#include "update_engine/payload_consumer/bzip_extent_writer.h"
Amin Hassania3fc20a2017-09-19 17:19:34 -070048#include "update_engine/payload_consumer/cached_file_descriptor.h"
Alex Deymo542c19b2015-12-03 07:43:31 -030049#include "update_engine/payload_consumer/download_action.h"
Amin Hassanidb56be92017-09-06 12:41:23 -070050#include "update_engine/payload_consumer/extent_reader.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080051#include "update_engine/payload_consumer/extent_writer.h"
Alex Deymo51c264e2016-11-04 15:49:53 -070052#if USE_FEC
53#include "update_engine/payload_consumer/fec_file_descriptor.h"
54#endif // USE_FEC
Alex Deymoa48f6302016-11-04 15:49:53 -070055#include "update_engine/payload_consumer/file_descriptor_utils.h"
HÃ¥kan Kvist4e13cf42018-01-23 12:57:55 +010056#include "update_engine/payload_consumer/mount_history.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080057#include "update_engine/payload_consumer/payload_constants.h"
58#include "update_engine/payload_consumer/payload_verifier.h"
59#include "update_engine/payload_consumer/xz_extent_writer.h"
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070060
Alex Deymo161c4a12014-05-16 15:56:21 -070061using google::protobuf::RepeatedPtrField;
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070062using std::min;
63using std::string;
64using std::vector;
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070065
66namespace chromeos_update_engine {
Gilad Arnold8a86fa52013-01-15 12:35:05 -080067const unsigned DeltaPerformer::kProgressLogMaxChunks = 10;
68const unsigned DeltaPerformer::kProgressLogTimeoutSeconds = 30;
69const unsigned DeltaPerformer::kProgressDownloadWeight = 50;
70const unsigned DeltaPerformer::kProgressOperationsWeight = 50;
Colin Howes0e452c92018-11-02 13:18:44 -070071const uint64_t DeltaPerformer::kCheckpointFrequencySeconds = 1;
Darin Petkovabc7bc02011-02-23 14:39:43 -080072
Andrew de los Reyes09e56d62010-04-23 13:45:53 -070073namespace {
Darin Petkov73058b42010-10-06 16:32:19 -070074const int kUpdateStateOperationInvalid = -1;
Darin Petkov61426142010-10-08 11:04:55 -070075const int kMaxResumedUpdateFailures = 10;
Nam T. Nguyenf1d582e2014-12-08 15:07:17 -080076
Amin Hassania3fc20a2017-09-19 17:19:34 -070077const uint64_t kCacheSize = 1024 * 1024; // 1MB
78
Nam T. Nguyenf1d582e2014-12-08 15:07:17 -080079// Opens path for read/write. On success returns an open FileDescriptor
80// and sets *err to 0. On failure, sets *err to errno and returns nullptr.
Amin Hassania3fc20a2017-09-19 17:19:34 -070081FileDescriptorPtr OpenFile(const char* path,
82 int mode,
83 bool cache_writes,
84 int* err) {
Alex Deymo5fb356c2016-03-25 18:48:22 -070085 // Try to mark the block device read-only based on the mode. Ignore any
86 // failure since this won't work when passing regular files.
Amin Hassania3fc20a2017-09-19 17:19:34 -070087 bool read_only = (mode & O_ACCMODE) == O_RDONLY;
88 utils::SetBlockDeviceReadOnly(path, read_only);
Alex Deymo5fb356c2016-03-25 18:48:22 -070089
Brian Norris7b428f52019-06-26 10:03:35 -070090 FileDescriptorPtr fd(new EintrSafeFileDescriptor());
Amin Hassania3fc20a2017-09-19 17:19:34 -070091 if (cache_writes && !read_only) {
92 fd = FileDescriptorPtr(new CachedFileDescriptor(fd, kCacheSize));
93 LOG(INFO) << "Caching writes.";
94 }
Nam T. Nguyena78b28c2015-03-06 22:30:12 -080095 if (!fd->Open(path, mode, 000)) {
Nam T. Nguyenf1d582e2014-12-08 15:07:17 -080096 *err = errno;
97 PLOG(ERROR) << "Unable to open file " << path;
98 return nullptr;
99 }
100 *err = 0;
101 return fd;
102}
Alex Deymob86787c2016-05-12 18:46:25 -0700103
104// Discard the tail of the block device referenced by |fd|, from the offset
105// |data_size| until the end of the block device. Returns whether the data was
106// discarded.
Chih-Hung Hsieh5c6bb1d2016-07-27 13:33:15 -0700107bool DiscardPartitionTail(const FileDescriptorPtr& fd, uint64_t data_size) {
Alex Deymob86787c2016-05-12 18:46:25 -0700108 uint64_t part_size = fd->BlockDevSize();
109 if (!part_size || part_size <= data_size)
110 return false;
111
Alex Deymo72a68d82016-06-15 16:31:04 -0700112 struct blkioctl_request {
113 int number;
114 const char* name;
115 };
116 const vector<blkioctl_request> blkioctl_requests = {
Alex Deymo72a68d82016-06-15 16:31:04 -0700117 {BLKDISCARD, "BLKDISCARD"},
Amin Hassani41555202017-06-23 12:42:00 -0700118 {BLKSECDISCARD, "BLKSECDISCARD"},
Alex Deymob86787c2016-05-12 18:46:25 -0700119#ifdef BLKZEROOUT
Alex Deymo72a68d82016-06-15 16:31:04 -0700120 {BLKZEROOUT, "BLKZEROOUT"},
Alex Deymob86787c2016-05-12 18:46:25 -0700121#endif
122 };
Alex Deymo72a68d82016-06-15 16:31:04 -0700123 for (const auto& req : blkioctl_requests) {
Alex Deymob86787c2016-05-12 18:46:25 -0700124 int error = 0;
Alex Deymo72a68d82016-06-15 16:31:04 -0700125 if (fd->BlkIoctl(req.number, data_size, part_size - data_size, &error) &&
Alex Deymob86787c2016-05-12 18:46:25 -0700126 error == 0) {
127 return true;
128 }
129 LOG(WARNING) << "Error discarding the last "
130 << (part_size - data_size) / 1024 << " KiB using ioctl("
Alex Deymo72a68d82016-06-15 16:31:04 -0700131 << req.name << ")";
Alex Deymob86787c2016-05-12 18:46:25 -0700132 }
133 return false;
134}
135
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700136} // namespace
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700137
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800138// Computes the ratio of |part| and |total|, scaled to |norm|, using integer
139// arithmetic.
140static uint64_t IntRatio(uint64_t part, uint64_t total, uint64_t norm) {
141 return part * norm / total;
142}
143
144void DeltaPerformer::LogProgress(const char* message_prefix) {
145 // Format operations total count and percentage.
146 string total_operations_str("?");
147 string completed_percentage_str("");
148 if (num_total_operations_) {
Alex Deymoc00c98a2015-03-17 17:38:00 -0700149 total_operations_str = std::to_string(num_total_operations_);
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800150 // Upcasting to 64-bit to avoid overflow, back to size_t for formatting.
Amin Hassani008c4582019-01-13 16:22:47 -0800151 completed_percentage_str = base::StringPrintf(
152 " (%" PRIu64 "%%)",
153 IntRatio(next_operation_num_, num_total_operations_, 100));
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800154 }
155
156 // Format download total count and percentage.
Sen Jiang0affc2c2017-02-10 15:55:05 -0800157 size_t payload_size = payload_->size;
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800158 string payload_size_str("?");
159 string downloaded_percentage_str("");
160 if (payload_size) {
Alex Deymoc00c98a2015-03-17 17:38:00 -0700161 payload_size_str = std::to_string(payload_size);
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800162 // Upcasting to 64-bit to avoid overflow, back to size_t for formatting.
Amin Hassani008c4582019-01-13 16:22:47 -0800163 downloaded_percentage_str = base::StringPrintf(
164 " (%" PRIu64 "%%)", IntRatio(total_bytes_received_, payload_size, 100));
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800165 }
166
167 LOG(INFO) << (message_prefix ? message_prefix : "") << next_operation_num_
168 << "/" << total_operations_str << " operations"
Amin Hassani008c4582019-01-13 16:22:47 -0800169 << completed_percentage_str << ", " << total_bytes_received_ << "/"
170 << payload_size_str << " bytes downloaded"
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800171 << downloaded_percentage_str << ", overall progress "
172 << overall_progress_ << "%";
173}
174
175void DeltaPerformer::UpdateOverallProgress(bool force_log,
176 const char* message_prefix) {
177 // Compute our download and overall progress.
178 unsigned new_overall_progress = 0;
Alex Vakulenko0103c362016-01-20 07:56:15 -0800179 static_assert(kProgressDownloadWeight + kProgressOperationsWeight == 100,
180 "Progress weights don't add up");
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800181 // Only consider download progress if its total size is known; otherwise
182 // adjust the operations weight to compensate for the absence of download
183 // progress. Also, make sure to cap the download portion at
184 // kProgressDownloadWeight, in case we end up downloading more than we
185 // initially expected (this indicates a problem, but could generally happen).
186 // TODO(garnold) the correction of operations weight when we do not have the
187 // total payload size, as well as the conditional guard below, should both be
188 // eliminated once we ensure that the payload_size in the install plan is
189 // always given and is non-zero. This currently isn't the case during unit
190 // tests (see chromium-os:37969).
Sen Jiang0affc2c2017-02-10 15:55:05 -0800191 size_t payload_size = payload_->size;
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800192 unsigned actual_operations_weight = kProgressOperationsWeight;
193 if (payload_size)
Amin Hassani008c4582019-01-13 16:22:47 -0800194 new_overall_progress +=
195 min(static_cast<unsigned>(IntRatio(
196 total_bytes_received_, payload_size, kProgressDownloadWeight)),
197 kProgressDownloadWeight);
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800198 else
199 actual_operations_weight += kProgressDownloadWeight;
200
201 // Only add completed operations if their total number is known; we definitely
202 // expect an update to have at least one operation, so the expectation is that
203 // this will eventually reach |actual_operations_weight|.
204 if (num_total_operations_)
Amin Hassani008c4582019-01-13 16:22:47 -0800205 new_overall_progress += IntRatio(
206 next_operation_num_, num_total_operations_, actual_operations_weight);
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800207
208 // Progress ratio cannot recede, unless our assumptions about the total
209 // payload size, total number of operations, or the monotonicity of progress
210 // is breached.
211 if (new_overall_progress < overall_progress_) {
212 LOG(WARNING) << "progress counter receded from " << overall_progress_
213 << "% down to " << new_overall_progress << "%; this is a bug";
214 force_log = true;
215 }
216 overall_progress_ = new_overall_progress;
217
218 // Update chunk index, log as needed: if forced by called, or we completed a
219 // progress chunk, or a timeout has expired.
Sen Jiang53c2ec52019-01-10 15:27:59 -0800220 base::TimeTicks curr_time = base::TimeTicks::Now();
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800221 unsigned curr_progress_chunk =
222 overall_progress_ * kProgressLogMaxChunks / 100;
223 if (force_log || curr_progress_chunk > last_progress_chunk_ ||
224 curr_time > forced_progress_log_time_) {
225 forced_progress_log_time_ = curr_time + forced_progress_log_wait_;
226 LogProgress(message_prefix);
227 }
228 last_progress_chunk_ = curr_progress_chunk;
229}
230
Amin Hassani008c4582019-01-13 16:22:47 -0800231size_t DeltaPerformer::CopyDataToBuffer(const char** bytes_p,
232 size_t* count_p,
Gilad Arnoldfe133932014-01-14 12:25:50 -0800233 size_t max) {
234 const size_t count = *count_p;
235 if (!count)
236 return 0; // Special case shortcut.
Alex Deymof329b932014-10-30 01:37:48 -0700237 size_t read_len = min(count, max - buffer_.size());
Gilad Arnoldfe133932014-01-14 12:25:50 -0800238 const char* bytes_start = *bytes_p;
239 const char* bytes_end = bytes_start + read_len;
Sen Jiangbe19a242017-11-17 11:48:17 -0800240 buffer_.reserve(max);
Gilad Arnoldfe133932014-01-14 12:25:50 -0800241 buffer_.insert(buffer_.end(), bytes_start, bytes_end);
242 *bytes_p = bytes_end;
243 *count_p = count - read_len;
244 return read_len;
245}
246
Amin Hassani008c4582019-01-13 16:22:47 -0800247bool DeltaPerformer::HandleOpResult(bool op_result,
248 const char* op_type_name,
Gilad Arnoldfe133932014-01-14 12:25:50 -0800249 ErrorCode* error) {
250 if (op_result)
251 return true;
252
Alex Deymo3d009062016-05-13 15:51:25 -0700253 size_t partition_first_op_num =
254 current_partition_ ? acc_num_operations_[current_partition_ - 1] : 0;
Gilad Arnoldfe133932014-01-14 12:25:50 -0800255 LOG(ERROR) << "Failed to perform " << op_type_name << " operation "
Alex Deymo3d009062016-05-13 15:51:25 -0700256 << next_operation_num_ << ", which is the operation "
257 << next_operation_num_ - partition_first_op_num
258 << " in partition \""
259 << partitions_[current_partition_].partition_name() << "\"";
Sen Jiangbe2c47b2016-06-15 14:09:27 -0700260 if (*error == ErrorCode::kSuccess)
261 *error = ErrorCode::kDownloadOperationExecutionError;
Gilad Arnoldfe133932014-01-14 12:25:50 -0800262 return false;
263}
264
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700265int DeltaPerformer::Close() {
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700266 int err = -CloseCurrentPartition();
Amin Hassani008c4582019-01-13 16:22:47 -0800267 LOG_IF(ERROR,
268 !payload_hash_calculator_.Finalize() ||
269 !signed_hash_calculator_.Finalize())
Sen Jiangf6813802015-11-03 21:27:29 -0800270 << "Unable to finalize the hash.";
Darin Petkov934bb412010-11-18 11:21:35 -0800271 if (!buffer_.empty()) {
Jay Srinivasan1c0fe792013-03-28 16:45:25 -0700272 LOG(INFO) << "Discarding " << buffer_.size() << " unused downloaded bytes";
273 if (err >= 0)
Darin Petkov934bb412010-11-18 11:21:35 -0800274 err = 1;
Darin Petkov934bb412010-11-18 11:21:35 -0800275 }
Andrew de los Reyesf4c7ef12010-04-30 10:37:00 -0700276 return -err;
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700277}
278
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700279int DeltaPerformer::CloseCurrentPartition() {
280 int err = 0;
281 if (source_fd_ && !source_fd_->Close()) {
282 err = errno;
283 PLOG(ERROR) << "Error closing source partition";
284 if (!err)
285 err = 1;
286 }
287 source_fd_.reset();
Alex Deymo51c264e2016-11-04 15:49:53 -0700288 if (source_ecc_fd_ && !source_ecc_fd_->Close()) {
289 err = errno;
290 PLOG(ERROR) << "Error closing ECC source partition";
291 if (!err)
292 err = 1;
293 }
294 source_ecc_fd_.reset();
295 source_ecc_open_failure_ = false;
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700296 source_path_.clear();
297
298 if (target_fd_ && !target_fd_->Close()) {
299 err = errno;
300 PLOG(ERROR) << "Error closing target partition";
301 if (!err)
302 err = 1;
303 }
304 target_fd_.reset();
305 target_path_.clear();
306 return -err;
307}
308
309bool DeltaPerformer::OpenCurrentPartition() {
310 if (current_partition_ >= partitions_.size())
311 return false;
312
313 const PartitionUpdate& partition = partitions_[current_partition_];
Sen Jiangd2ff2a02017-04-06 14:53:31 -0700314 size_t num_previous_partitions =
315 install_plan_->partitions.size() - partitions_.size();
316 const InstallPlan::Partition& install_part =
317 install_plan_->partitions[num_previous_partitions + current_partition_];
Amin Hassani0f59a9a2019-09-27 10:24:31 -0700318 // Open source fds if we have a delta payload.
319 if (payload_->type == InstallPayloadType::kDelta) {
Sen Jiangd2ff2a02017-04-06 14:53:31 -0700320 source_path_ = install_part.source_path;
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700321 int err;
Amin Hassania3fc20a2017-09-19 17:19:34 -0700322 source_fd_ = OpenFile(source_path_.c_str(), O_RDONLY, false, &err);
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700323 if (!source_fd_) {
324 LOG(ERROR) << "Unable to open source partition "
325 << partition.partition_name() << " on slot "
326 << BootControlInterface::SlotName(install_plan_->source_slot)
327 << ", file " << source_path_;
328 return false;
329 }
330 }
331
Sen Jiangd2ff2a02017-04-06 14:53:31 -0700332 target_path_ = install_part.target_path;
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700333 int err;
Grant Grundlera763c2d2017-05-10 11:12:52 -0700334
Amin Hassani7ecda262017-07-11 17:10:50 -0700335 int flags = O_RDWR;
Amin Hassanied37d682018-04-06 13:22:00 -0700336 if (!interactive_)
Amin Hassani7ecda262017-07-11 17:10:50 -0700337 flags |= O_DSYNC;
338
339 LOG(INFO) << "Opening " << target_path_ << " partition with"
Amin Hassanied37d682018-04-06 13:22:00 -0700340 << (interactive_ ? "out" : "") << " O_DSYNC";
Amin Hassani7ecda262017-07-11 17:10:50 -0700341
Amin Hassania3fc20a2017-09-19 17:19:34 -0700342 target_fd_ = OpenFile(target_path_.c_str(), flags, true, &err);
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700343 if (!target_fd_) {
344 LOG(ERROR) << "Unable to open target partition "
345 << partition.partition_name() << " on slot "
346 << BootControlInterface::SlotName(install_plan_->target_slot)
347 << ", file " << target_path_;
348 return false;
349 }
Alex Deymob86787c2016-05-12 18:46:25 -0700350
351 LOG(INFO) << "Applying " << partition.operations().size()
352 << " operations to partition \"" << partition.partition_name()
353 << "\"";
354
355 // Discard the end of the partition, but ignore failures.
Sen Jiangd2ff2a02017-04-06 14:53:31 -0700356 DiscardPartitionTail(target_fd_, install_part.target_size);
Alex Deymob86787c2016-05-12 18:46:25 -0700357
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700358 return true;
359}
360
Alex Deymo51c264e2016-11-04 15:49:53 -0700361bool DeltaPerformer::OpenCurrentECCPartition() {
362 if (source_ecc_fd_)
363 return true;
364
365 if (source_ecc_open_failure_)
366 return false;
367
368 if (current_partition_ >= partitions_.size())
369 return false;
370
Amin Hassani0f59a9a2019-09-27 10:24:31 -0700371 // No support for ECC for full payloads.
372 if (payload_->type == InstallPayloadType::kFull)
Alex Deymo51c264e2016-11-04 15:49:53 -0700373 return false;
374
375#if USE_FEC
376 const PartitionUpdate& partition = partitions_[current_partition_];
377 size_t num_previous_partitions =
378 install_plan_->partitions.size() - partitions_.size();
379 const InstallPlan::Partition& install_part =
380 install_plan_->partitions[num_previous_partitions + current_partition_];
381 string path = install_part.source_path;
382 FileDescriptorPtr fd(new FecFileDescriptor());
383 if (!fd->Open(path.c_str(), O_RDONLY, 0)) {
384 PLOG(ERROR) << "Unable to open ECC source partition "
385 << partition.partition_name() << " on slot "
386 << BootControlInterface::SlotName(install_plan_->source_slot)
387 << ", file " << path;
388 source_ecc_open_failure_ = true;
389 return false;
390 }
391 source_ecc_fd_ = fd;
392#else
393 // No support for ECC compiled.
394 source_ecc_open_failure_ = true;
395#endif // USE_FEC
396
397 return !source_ecc_open_failure_;
398}
399
Andrew de los Reyes89f17be2010-10-22 13:39:09 -0700400namespace {
401
402void LogPartitionInfoHash(const PartitionInfo& info, const string& tag) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700403 string sha256 = brillo::data_encoding::Base64Encode(info.hash());
Alex Vakulenko981a9fb2015-02-09 12:51:24 -0800404 LOG(INFO) << "PartitionInfo " << tag << " sha256: " << sha256
405 << " size: " << info.size();
Andrew de los Reyes89f17be2010-10-22 13:39:09 -0700406}
407
Alex Deymo39910dc2015-11-09 17:04:30 -0800408void LogPartitionInfo(const vector<PartitionUpdate>& partitions) {
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700409 for (const PartitionUpdate& partition : partitions) {
Sen Jiang7b9a5872018-01-17 13:25:06 -0800410 if (partition.has_old_partition_info()) {
411 LogPartitionInfoHash(partition.old_partition_info(),
412 "old " + partition.partition_name());
413 }
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700414 LogPartitionInfoHash(partition.new_partition_info(),
415 "new " + partition.partition_name());
416 }
Andrew de los Reyes89f17be2010-10-22 13:39:09 -0700417}
418
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700419} // namespace
Andrew de los Reyes89f17be2010-10-22 13:39:09 -0700420
Allie Woodfdf00512015-03-02 13:34:55 -0800421uint32_t DeltaPerformer::GetMinorVersion() const {
422 if (manifest_.has_minor_version()) {
423 return manifest_.minor_version();
Allie Woodfdf00512015-03-02 13:34:55 -0800424 }
Sen Jiangf1236632018-05-11 16:03:23 -0700425 return payload_->type == InstallPayloadType::kDelta
426 ? kMaxSupportedMinorPayloadVersion
427 : kFullPayloadMinorVersion;
Allie Woodfdf00512015-03-02 13:34:55 -0800428}
429
Sen Jiangb8060e42015-09-24 17:30:50 -0700430bool DeltaPerformer::IsHeaderParsed() const {
431 return metadata_size_ != 0;
432}
Jay Srinivasanf4318702012-09-24 11:56:24 -0700433
Sen Jiang9c89e842018-02-02 13:51:21 -0800434MetadataParseResult DeltaPerformer::ParsePayloadMetadata(
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700435 const brillo::Blob& payload, ErrorCode* error) {
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700436 *error = ErrorCode::kSuccess;
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700437
Sen Jiangb8060e42015-09-24 17:30:50 -0700438 if (!IsHeaderParsed()) {
Sen Jiangf1236632018-05-11 16:03:23 -0700439 MetadataParseResult result =
Amin Hassanifac20222020-01-21 11:32:50 -0800440 payload_metadata_.ParsePayloadHeader(payload, hardware_, error);
Sen Jiang9c89e842018-02-02 13:51:21 -0800441 if (result != MetadataParseResult::kSuccess)
442 return result;
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700443
Sen Jiang9c89e842018-02-02 13:51:21 -0800444 metadata_size_ = payload_metadata_.GetMetadataSize();
445 metadata_signature_size_ = payload_metadata_.GetMetadataSignatureSize();
446 major_payload_version_ = payload_metadata_.GetMajorVersion();
Gilad Arnoldfe133932014-01-14 12:25:50 -0800447
448 // If the metadata size is present in install plan, check for it immediately
449 // even before waiting for that many number of bytes to be downloaded in the
450 // payload. This will prevent any attack which relies on us downloading data
451 // beyond the expected metadata size.
Gilad Arnoldfe133932014-01-14 12:25:50 -0800452 if (install_plan_->hash_checks_mandatory) {
Sen Jiang0affc2c2017-02-10 15:55:05 -0800453 if (payload_->metadata_size != metadata_size_) {
Gilad Arnoldfe133932014-01-14 12:25:50 -0800454 LOG(ERROR) << "Mandatory metadata size in Omaha response ("
Sen Jiang0affc2c2017-02-10 15:55:05 -0800455 << payload_->metadata_size
Gilad Arnoldfe133932014-01-14 12:25:50 -0800456 << ") is missing/incorrect, actual = " << metadata_size_;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700457 *error = ErrorCode::kDownloadInvalidMetadataSize;
Sen Jiang9c89e842018-02-02 13:51:21 -0800458 return MetadataParseResult::kError;
Gilad Arnoldfe133932014-01-14 12:25:50 -0800459 }
460 }
Andrew3a7dc262019-12-19 11:38:08 -0800461
462 // Check that the |metadata signature size_| and |metadata_size_| are not
463 // very big numbers. This is necessary since |update_engine| needs to write
464 // these values into the buffer before being able to use them, and if an
465 // attacker sets these values to a very big number, the buffer will overflow
466 // and |update_engine| will crash. A simple way of solving this is to check
467 // that the size of both values is smaller than the payload itself.
468 if (metadata_size_ + metadata_signature_size_ > payload_->size) {
469 LOG(ERROR) << "The size of the metadata_size(" << metadata_size_ << ")"
470 << " or metadata signature(" << metadata_signature_size_ << ")"
471 << " is greater than the size of the payload"
472 << "(" << payload_->size << ")";
473 *error = ErrorCode::kDownloadInvalidMetadataSize;
474 return MetadataParseResult::kError;
475 }
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700476 }
477
478 // Now that we have validated the metadata size, we should wait for the full
Sen Jiang76bfa742015-10-12 17:13:26 -0700479 // metadata and its signature (if exist) to be read in before we can parse it.
480 if (payload.size() < metadata_size_ + metadata_signature_size_)
Sen Jiang9c89e842018-02-02 13:51:21 -0800481 return MetadataParseResult::kInsufficientData;
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700482
483 // Log whether we validated the size or simply trusting what's in the payload
Jay Srinivasanf4318702012-09-24 11:56:24 -0700484 // here. This is logged here (after we received the full metadata data) so
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700485 // that we just log once (instead of logging n times) if it takes n
486 // DeltaPerformer::Write calls to download the full manifest.
Sen Jiang0affc2c2017-02-10 15:55:05 -0800487 if (payload_->metadata_size == metadata_size_) {
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700488 LOG(INFO) << "Manifest size in payload matches expected value from Omaha";
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800489 } else {
490 // For mandatory-cases, we'd have already returned a kMetadataParseError
491 // above. We'll be here only for non-mandatory cases. Just send a UMA stat.
492 LOG(WARNING) << "Ignoring missing/incorrect metadata size ("
Sen Jiang0affc2c2017-02-10 15:55:05 -0800493 << payload_->metadata_size
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800494 << ") in Omaha response as validation is not mandatory. "
Gilad Arnoldfe133932014-01-14 12:25:50 -0800495 << "Trusting metadata size in payload = " << metadata_size_;
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800496 }
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700497
Sen Jiang08c6da12019-01-07 18:28:56 -0800498 string public_key;
499 if (!GetPublicKey(&public_key)) {
500 LOG(ERROR) << "Failed to get public key.";
501 *error = ErrorCode::kDownloadMetadataSignatureVerificationError;
502 return MetadataParseResult::kError;
503 }
Sen Jiang9c89e842018-02-02 13:51:21 -0800504
Jay Srinivasanf4318702012-09-24 11:56:24 -0700505 // We have the full metadata in |payload|. Verify its integrity
506 // and authenticity based on the information we have in Omaha response.
Sen Jiang9c89e842018-02-02 13:51:21 -0800507 *error = payload_metadata_.ValidateMetadataSignature(
Sen Jiang08c6da12019-01-07 18:28:56 -0800508 payload, payload_->metadata_signature, public_key);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700509 if (*error != ErrorCode::kSuccess) {
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800510 if (install_plan_->hash_checks_mandatory) {
David Zeuthenbc27aac2013-11-26 11:17:48 -0800511 // The autoupdate_CatchBadSignatures test checks for this string
512 // in log-files. Keep in sync.
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800513 LOG(ERROR) << "Mandatory metadata signature validation failed";
Sen Jiang9c89e842018-02-02 13:51:21 -0800514 return MetadataParseResult::kError;
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800515 }
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700516
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800517 // For non-mandatory cases, just send a UMA stat.
518 LOG(WARNING) << "Ignoring metadata signature validation failures";
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700519 *error = ErrorCode::kSuccess;
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700520 }
521
Gilad Arnolddaa27402014-01-23 11:56:17 -0800522 // The payload metadata is deemed valid, it's safe to parse the protobuf.
Sen Jiang9c89e842018-02-02 13:51:21 -0800523 if (!payload_metadata_.GetManifest(payload, &manifest_)) {
Darin Petkov9574f7e2011-01-13 10:48:12 -0800524 LOG(ERROR) << "Unable to parse manifest in update file.";
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700525 *error = ErrorCode::kDownloadManifestParseError;
Sen Jiang9c89e842018-02-02 13:51:21 -0800526 return MetadataParseResult::kError;
Darin Petkov9574f7e2011-01-13 10:48:12 -0800527 }
Gilad Arnolddaa27402014-01-23 11:56:17 -0800528
529 manifest_parsed_ = true;
Sen Jiang9c89e842018-02-02 13:51:21 -0800530 return MetadataParseResult::kSuccess;
Darin Petkov9574f7e2011-01-13 10:48:12 -0800531}
532
Amin Hassani008c4582019-01-13 16:22:47 -0800533#define OP_DURATION_HISTOGRAM(_op_name, _start_time) \
534 LOCAL_HISTOGRAM_CUSTOM_TIMES( \
535 "UpdateEngine.DownloadAction.InstallOperation::" _op_name ".Duration", \
536 base::TimeTicks::Now() - _start_time, \
537 base::TimeDelta::FromMilliseconds(10), \
538 base::TimeDelta::FromMinutes(5), \
539 20);
Lann Martin39f57142017-07-14 09:18:42 -0600540
Don Garrette410e0f2011-11-10 15:39:01 -0800541// Wrapper around write. Returns true if all requested bytes
Jay Srinivasan2b5a0f02012-12-19 17:25:56 -0800542// were written, or false on any error, regardless of progress
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700543// and stores an action exit code in |error|.
Amin Hassani008c4582019-01-13 16:22:47 -0800544bool DeltaPerformer::Write(const void* bytes, size_t count, ErrorCode* error) {
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700545 *error = ErrorCode::kSuccess;
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700546 const char* c_bytes = reinterpret_cast<const char*>(bytes);
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800547
548 // Update the total byte downloaded count and the progress logs.
549 total_bytes_received_ += count;
550 UpdateOverallProgress(false, "Completed ");
551
Gilad Arnoldfe133932014-01-14 12:25:50 -0800552 while (!manifest_valid_) {
Sen Jiangb8060e42015-09-24 17:30:50 -0700553 // Read data up to the needed limit; this is either maximium payload header
554 // size, or the full metadata size (once it becomes known).
555 const bool do_read_header = !IsHeaderParsed();
Amin Hassani008c4582019-01-13 16:22:47 -0800556 CopyDataToBuffer(
557 &c_bytes,
558 &count,
559 (do_read_header ? kMaxPayloadHeaderSize
560 : metadata_size_ + metadata_signature_size_));
Gilad Arnoldfe133932014-01-14 12:25:50 -0800561
Gilad Arnolddaa27402014-01-23 11:56:17 -0800562 MetadataParseResult result = ParsePayloadMetadata(buffer_, error);
Sen Jiang9c89e842018-02-02 13:51:21 -0800563 if (result == MetadataParseResult::kError)
Don Garrette410e0f2011-11-10 15:39:01 -0800564 return false;
Sen Jiang9c89e842018-02-02 13:51:21 -0800565 if (result == MetadataParseResult::kInsufficientData) {
Gilad Arnoldfe133932014-01-14 12:25:50 -0800566 // If we just processed the header, make an attempt on the manifest.
Sen Jiangb8060e42015-09-24 17:30:50 -0700567 if (do_read_header && IsHeaderParsed())
Gilad Arnoldfe133932014-01-14 12:25:50 -0800568 continue;
569
Don Garrette410e0f2011-11-10 15:39:01 -0800570 return true;
Gilad Arnoldfe133932014-01-14 12:25:50 -0800571 }
Gilad Arnold21504f02013-05-24 08:51:22 -0700572
573 // Checks the integrity of the payload manifest.
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700574 if ((*error = ValidateManifest()) != ErrorCode::kSuccess)
Gilad Arnold21504f02013-05-24 08:51:22 -0700575 return false;
Gilad Arnolddaa27402014-01-23 11:56:17 -0800576 manifest_valid_ = true;
Gilad Arnold21504f02013-05-24 08:51:22 -0700577
Gilad Arnoldfe133932014-01-14 12:25:50 -0800578 // Clear the download buffer.
Sen Jiangf6813802015-11-03 21:27:29 -0800579 DiscardBuffer(false, metadata_size_);
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700580
Sen Jiang57f91802017-11-14 17:42:13 -0800581 block_size_ = manifest_.block_size();
582
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700583 // This populates |partitions_| and the |install_plan.partitions| with the
584 // list of partitions from the manifest.
585 if (!ParseManifestPartitions(error))
586 return false;
587
Sen Jiang5ae865b2017-04-18 14:24:40 -0700588 // |install_plan.partitions| was filled in, nothing need to be done here if
589 // the payload was already applied, returns false to terminate http fetcher,
590 // but keep |error| as ErrorCode::kSuccess.
591 if (payload_->already_applied)
592 return false;
593
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700594 num_total_operations_ = 0;
595 for (const auto& partition : partitions_) {
596 num_total_operations_ += partition.operations_size();
597 acc_num_operations_.push_back(num_total_operations_);
598 }
599
Amin Hassani008c4582019-01-13 16:22:47 -0800600 LOG_IF(WARNING,
601 !prefs_->SetInt64(kPrefsManifestMetadataSize, metadata_size_))
Darin Petkov73058b42010-10-06 16:32:19 -0700602 << "Unable to save the manifest metadata size.";
Amin Hassani008c4582019-01-13 16:22:47 -0800603 LOG_IF(WARNING,
604 !prefs_->SetInt64(kPrefsManifestSignatureSize,
605 metadata_signature_size_))
Alex Deymof25eb492016-02-26 00:20:08 -0800606 << "Unable to save the manifest signature size.";
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700607
Darin Petkov9b230572010-10-08 10:20:09 -0700608 if (!PrimeUpdateState()) {
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700609 *error = ErrorCode::kDownloadStateInitializationError;
Darin Petkov9b230572010-10-08 10:20:09 -0700610 LOG(ERROR) << "Unable to prime the update state.";
Don Garrette410e0f2011-11-10 15:39:01 -0800611 return false;
Darin Petkov9b230572010-10-08 10:20:09 -0700612 }
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800613
Yifan Hong537802d2018-08-15 13:15:42 -0700614 if (next_operation_num_ < acc_num_operations_[current_partition_]) {
615 if (!OpenCurrentPartition()) {
616 *error = ErrorCode::kInstallDeviceOpenError;
617 return false;
618 }
Allie Woodfdf00512015-03-02 13:34:55 -0800619 }
620
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800621 if (next_operation_num_ > 0)
622 UpdateOverallProgress(true, "Resuming after ");
623 LOG(INFO) << "Starting to apply update payload operations";
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700624 }
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800625
626 while (next_operation_num_ < num_total_operations_) {
Jay Srinivasan1c0fe792013-03-28 16:45:25 -0700627 // Check if we should cancel the current attempt for any reason.
628 // In this case, *error will have already been populated with the reason
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700629 // why we're canceling.
Alex Deymo542c19b2015-12-03 07:43:31 -0300630 if (download_delegate_ && download_delegate_->ShouldCancel(error))
Jay Srinivasan1c0fe792013-03-28 16:45:25 -0700631 return false;
632
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700633 // We know there are more operations to perform because we didn't reach the
634 // |num_total_operations_| limit yet.
Yifan Hong537802d2018-08-15 13:15:42 -0700635 if (next_operation_num_ >= acc_num_operations_[current_partition_]) {
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700636 CloseCurrentPartition();
Yifan Hong537802d2018-08-15 13:15:42 -0700637 // Skip until there are operations for current_partition_.
638 while (next_operation_num_ >= acc_num_operations_[current_partition_]) {
639 current_partition_++;
640 }
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700641 if (!OpenCurrentPartition()) {
642 *error = ErrorCode::kInstallDeviceOpenError;
643 return false;
644 }
645 }
Amin Hassani008c4582019-01-13 16:22:47 -0800646 const size_t partition_operation_num =
647 next_operation_num_ -
648 (current_partition_ ? acc_num_operations_[current_partition_ - 1] : 0);
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700649
Alex Deymoa12ee112015-08-12 22:19:32 -0700650 const InstallOperation& op =
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700651 partitions_[current_partition_].operations(partition_operation_num);
Gilad Arnoldfe133932014-01-14 12:25:50 -0800652
653 CopyDataToBuffer(&c_bytes, &count, op.data_length());
654
655 // Check whether we received all of the next operation's data payload.
656 if (!CanPerformInstallOperation(op))
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700657 return true;
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700658
Jay Srinivasanf4318702012-09-24 11:56:24 -0700659 // Validate the operation only if the metadata signature is present.
Jay Srinivasan00f76b62012-09-17 18:48:36 -0700660 // Otherwise, keep the old behavior. This serves as a knob to disable
661 // the validation logic in case we find some regression after rollout.
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800662 // NOTE: If hash checks are mandatory and if metadata_signature is empty,
663 // we would have already failed in ParsePayloadMetadata method and thus not
664 // even be here. So no need to handle that case again here.
Sen Jiang0affc2c2017-02-10 15:55:05 -0800665 if (!payload_->metadata_signature.empty()) {
Jay Srinivasan00f76b62012-09-17 18:48:36 -0700666 // Note: Validate must be called only if CanPerformInstallOperation is
667 // called. Otherwise, we might be failing operations before even if there
668 // isn't sufficient data to compute the proper hash.
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800669 *error = ValidateOperationHash(op);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700670 if (*error != ErrorCode::kSuccess) {
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800671 if (install_plan_->hash_checks_mandatory) {
672 LOG(ERROR) << "Mandatory operation hash check failed";
673 return false;
674 }
Jay Srinivasanf0572052012-10-23 18:12:56 -0700675
Jay Srinivasan738fdf32012-12-07 17:40:54 -0800676 // For non-mandatory cases, just send a UMA stat.
677 LOG(WARNING) << "Ignoring operation validation errors";
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700678 *error = ErrorCode::kSuccess;
Jay Srinivasan00f76b62012-09-17 18:48:36 -0700679 }
Jay Srinivasan51dcf262012-09-13 17:24:32 -0700680 }
681
Darin Petkov45580e42010-10-08 14:02:40 -0700682 // Makes sure we unblock exit when this operation completes.
Darin Petkov9c0baf82010-10-07 13:44:48 -0700683 ScopedTerminatorExitUnblocker exit_unblocker =
684 ScopedTerminatorExitUnblocker(); // Avoids a compiler unused var bug.
Gilad Arnoldfe133932014-01-14 12:25:50 -0800685
Lann Martin39f57142017-07-14 09:18:42 -0600686 base::TimeTicks op_start_time = base::TimeTicks::Now();
687
Gilad Arnoldfe133932014-01-14 12:25:50 -0800688 bool op_result;
Alex Deymo2d621a32015-10-01 11:09:01 -0700689 switch (op.type()) {
690 case InstallOperation::REPLACE:
691 case InstallOperation::REPLACE_BZ:
692 case InstallOperation::REPLACE_XZ:
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700693 op_result = PerformReplaceOperation(op);
Lann Martin39f57142017-07-14 09:18:42 -0600694 OP_DURATION_HISTOGRAM("REPLACE", op_start_time);
Alex Deymo2d621a32015-10-01 11:09:01 -0700695 break;
Alex Deymo79715ad2015-10-02 14:27:53 -0700696 case InstallOperation::ZERO:
697 case InstallOperation::DISCARD:
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700698 op_result = PerformZeroOrDiscardOperation(op);
Lann Martin39f57142017-07-14 09:18:42 -0600699 OP_DURATION_HISTOGRAM("ZERO_OR_DISCARD", op_start_time);
Alex Deymo79715ad2015-10-02 14:27:53 -0700700 break;
Alex Deymo2d621a32015-10-01 11:09:01 -0700701 case InstallOperation::SOURCE_COPY:
Sen Jiangbe2c47b2016-06-15 14:09:27 -0700702 op_result = PerformSourceCopyOperation(op, error);
Lann Martin39f57142017-07-14 09:18:42 -0600703 OP_DURATION_HISTOGRAM("SOURCE_COPY", op_start_time);
Alex Deymo2d621a32015-10-01 11:09:01 -0700704 break;
705 case InstallOperation::SOURCE_BSDIFF:
Amin Hassaniefa62d92017-11-09 13:46:56 -0800706 case InstallOperation::BROTLI_BSDIFF:
Sen Jiangbe2c47b2016-06-15 14:09:27 -0700707 op_result = PerformSourceBsdiffOperation(op, error);
Lann Martin39f57142017-07-14 09:18:42 -0600708 OP_DURATION_HISTOGRAM("SOURCE_BSDIFF", op_start_time);
Alex Deymo2d621a32015-10-01 11:09:01 -0700709 break;
Amin Hassani49fdb092017-08-04 13:10:59 -0700710 case InstallOperation::PUFFDIFF:
Amin Hassani02855c22017-09-06 22:34:50 -0700711 op_result = PerformPuffDiffOperation(op, error);
712 OP_DURATION_HISTOGRAM("PUFFDIFF", op_start_time);
Sen Jiangbc3e6b02016-01-19 18:39:26 +0800713 break;
Alex Deymo2d621a32015-10-01 11:09:01 -0700714 default:
Alex Deymoeecb0a52017-05-19 15:15:08 -0700715 op_result = false;
Alex Deymo2d621a32015-10-01 11:09:01 -0700716 }
717 if (!HandleOpResult(op_result, InstallOperationTypeName(op.type()), error))
Gilad Arnoldfe133932014-01-14 12:25:50 -0800718 return false;
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800719
Amin Hassani5192fe52017-08-28 10:28:46 -0700720 if (!target_fd_->Flush()) {
721 return false;
722 }
723
Andrew de los Reyesf4c7ef12010-04-30 10:37:00 -0700724 next_operation_num_++;
Gilad Arnold8a86fa52013-01-15 12:35:05 -0800725 UpdateOverallProgress(false, "Completed ");
Sen Jiang3a25dc22019-01-10 14:14:41 -0800726 CheckpointUpdateProgress(false);
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700727 }
Sen Jiangf6813802015-11-03 21:27:29 -0800728
729 // In major version 2, we don't add dummy operation to the payload.
Alex Deymof25eb492016-02-26 00:20:08 -0800730 // If we already extracted the signature we should skip this step.
Amin Hassanifac20222020-01-21 11:32:50 -0800731 if (major_payload_version_ == kBrilloMajorPayloadVersion &&
732 manifest_.has_signatures_offset() && manifest_.has_signatures_size() &&
Alex Deymof25eb492016-02-26 00:20:08 -0800733 signatures_message_data_.empty()) {
Sen Jiangf6813802015-11-03 21:27:29 -0800734 if (manifest_.signatures_offset() != buffer_offset_) {
735 LOG(ERROR) << "Payload signatures offset points to blob offset "
736 << manifest_.signatures_offset()
Amin Hassani008c4582019-01-13 16:22:47 -0800737 << " but signatures are expected at offset " << buffer_offset_;
Sen Jiangf6813802015-11-03 21:27:29 -0800738 *error = ErrorCode::kDownloadPayloadVerificationError;
739 return false;
740 }
741 CopyDataToBuffer(&c_bytes, &count, manifest_.signatures_size());
742 // Needs more data to cover entire signature.
743 if (buffer_.size() < manifest_.signatures_size())
744 return true;
745 if (!ExtractSignatureMessage()) {
746 LOG(ERROR) << "Extract payload signature failed.";
747 *error = ErrorCode::kDownloadPayloadVerificationError;
748 return false;
749 }
750 DiscardBuffer(true, 0);
Alex Deymof25eb492016-02-26 00:20:08 -0800751 // Since we extracted the SignatureMessage we need to advance the
752 // checkpoint, otherwise we would reload the signature and try to extract
753 // it again.
Sen Jiang3a25dc22019-01-10 14:14:41 -0800754 // This is the last checkpoint for an update, force this checkpoint to be
755 // saved.
756 CheckpointUpdateProgress(true);
Sen Jiangf6813802015-11-03 21:27:29 -0800757 }
758
Don Garrette410e0f2011-11-10 15:39:01 -0800759 return true;
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700760}
761
David Zeuthen8f191b22013-08-06 12:27:50 -0700762bool DeltaPerformer::IsManifestValid() {
763 return manifest_valid_;
764}
765
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700766bool DeltaPerformer::ParseManifestPartitions(ErrorCode* error) {
Amin Hassanifac20222020-01-21 11:32:50 -0800767 if (major_payload_version_ == kBrilloMajorPayloadVersion) {
768 partitions_.clear();
769 for (const PartitionUpdate& partition : manifest_.partitions()) {
770 partitions_.push_back(partition);
771 }
772 manifest_.clear_partitions();
773 } else if (major_payload_version_ == kChromeOSMajorPayloadVersion) {
774 LOG(INFO) << "Converting update information from old format.";
775 PartitionUpdate root_part;
776 root_part.set_partition_name(kPartitionNameRoot);
777#ifdef __ANDROID__
778 LOG(WARNING) << "Legacy payload major version provided to an Android "
779 "build. Assuming no post-install. Please use major version "
780 "2 or newer.";
781 root_part.set_run_postinstall(false);
782#else
783 root_part.set_run_postinstall(true);
784#endif // __ANDROID__
785 if (manifest_.has_old_rootfs_info()) {
786 *root_part.mutable_old_partition_info() = manifest_.old_rootfs_info();
787 manifest_.clear_old_rootfs_info();
788 }
789 if (manifest_.has_new_rootfs_info()) {
790 *root_part.mutable_new_partition_info() = manifest_.new_rootfs_info();
791 manifest_.clear_new_rootfs_info();
792 }
793 *root_part.mutable_operations() = manifest_.install_operations();
794 manifest_.clear_install_operations();
795 partitions_.push_back(std::move(root_part));
796
797 PartitionUpdate kern_part;
798 kern_part.set_partition_name(kPartitionNameKernel);
799 kern_part.set_run_postinstall(false);
800 if (manifest_.has_old_kernel_info()) {
801 *kern_part.mutable_old_partition_info() = manifest_.old_kernel_info();
802 manifest_.clear_old_kernel_info();
803 }
804 if (manifest_.has_new_kernel_info()) {
805 *kern_part.mutable_new_partition_info() = manifest_.new_kernel_info();
806 manifest_.clear_new_kernel_info();
807 }
808 *kern_part.mutable_operations() = manifest_.kernel_install_operations();
809 manifest_.clear_kernel_install_operations();
810 partitions_.push_back(std::move(kern_part));
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700811 }
812
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700813 // Fill in the InstallPlan::partitions based on the partitions from the
814 // payload.
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700815 for (const auto& partition : partitions_) {
816 InstallPlan::Partition install_part;
817 install_part.name = partition.partition_name();
818 install_part.run_postinstall =
819 partition.has_run_postinstall() && partition.run_postinstall();
Alex Deymo390efed2016-02-18 11:00:40 -0800820 if (install_part.run_postinstall) {
821 install_part.postinstall_path =
822 (partition.has_postinstall_path() ? partition.postinstall_path()
823 : kPostinstallDefaultScript);
824 install_part.filesystem_type = partition.filesystem_type();
Alex Deymo5b91c6b2016-08-04 20:33:36 -0700825 install_part.postinstall_optional = partition.postinstall_optional();
Alex Deymo390efed2016-02-18 11:00:40 -0800826 }
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700827
828 if (partition.has_old_partition_info()) {
829 const PartitionInfo& info = partition.old_partition_info();
830 install_part.source_size = info.size();
831 install_part.source_hash.assign(info.hash().begin(), info.hash().end());
832 }
833
834 if (!partition.has_new_partition_info()) {
835 LOG(ERROR) << "Unable to get new partition hash info on partition "
836 << install_part.name << ".";
837 *error = ErrorCode::kDownloadNewPartitionInfoError;
838 return false;
839 }
840 const PartitionInfo& info = partition.new_partition_info();
841 install_part.target_size = info.size();
842 install_part.target_hash.assign(info.hash().begin(), info.hash().end());
843
Sen Jiang57f91802017-11-14 17:42:13 -0800844 install_part.block_size = block_size_;
845 if (partition.has_hash_tree_extent()) {
846 Extent extent = partition.hash_tree_data_extent();
847 install_part.hash_tree_data_offset = extent.start_block() * block_size_;
848 install_part.hash_tree_data_size = extent.num_blocks() * block_size_;
849 extent = partition.hash_tree_extent();
850 install_part.hash_tree_offset = extent.start_block() * block_size_;
851 install_part.hash_tree_size = extent.num_blocks() * block_size_;
852 uint64_t hash_tree_data_end =
853 install_part.hash_tree_data_offset + install_part.hash_tree_data_size;
854 if (install_part.hash_tree_offset < hash_tree_data_end) {
855 LOG(ERROR) << "Invalid hash tree extents, hash tree data ends at "
856 << hash_tree_data_end << ", but hash tree starts at "
857 << install_part.hash_tree_offset;
858 *error = ErrorCode::kDownloadNewPartitionInfoError;
859 return false;
860 }
861 install_part.hash_tree_algorithm = partition.hash_tree_algorithm();
862 install_part.hash_tree_salt.assign(partition.hash_tree_salt().begin(),
863 partition.hash_tree_salt().end());
864 }
865 if (partition.has_fec_extent()) {
866 Extent extent = partition.fec_data_extent();
867 install_part.fec_data_offset = extent.start_block() * block_size_;
868 install_part.fec_data_size = extent.num_blocks() * block_size_;
869 extent = partition.fec_extent();
870 install_part.fec_offset = extent.start_block() * block_size_;
871 install_part.fec_size = extent.num_blocks() * block_size_;
872 uint64_t fec_data_end =
873 install_part.fec_data_offset + install_part.fec_data_size;
874 if (install_part.fec_offset < fec_data_end) {
875 LOG(ERROR) << "Invalid fec extents, fec data ends at " << fec_data_end
876 << ", but fec starts at " << install_part.fec_offset;
877 *error = ErrorCode::kDownloadNewPartitionInfoError;
878 return false;
879 }
880 install_part.fec_roots = partition.fec_roots();
881 }
882
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700883 install_plan_->partitions.push_back(install_part);
884 }
885
Yifan Hong537802d2018-08-15 13:15:42 -0700886 if (install_plan_->target_slot != BootControlInterface::kInvalidSlot) {
Yifan Hong9acd9cb2018-10-19 14:52:45 -0700887 if (!InitPartitionMetadata()) {
Yifan Hong537802d2018-08-15 13:15:42 -0700888 *error = ErrorCode::kInstallDeviceOpenError;
889 return false;
890 }
891 }
892
Alex Deymo542c19b2015-12-03 07:43:31 -0300893 if (!install_plan_->LoadPartitionsFromSlots(boot_control_)) {
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700894 LOG(ERROR) << "Unable to determine all the partition devices.";
895 *error = ErrorCode::kInstallDeviceOpenError;
896 return false;
897 }
898 LogPartitionInfo(partitions_);
899 return true;
900}
901
Yifan Hong9acd9cb2018-10-19 14:52:45 -0700902bool DeltaPerformer::InitPartitionMetadata() {
Yifan Hong9acd9cb2018-10-19 14:52:45 -0700903 BootControlInterface::PartitionMetadata partition_metadata;
Yifan Hongd4db07e2018-10-18 17:46:27 -0700904 if (manifest_.has_dynamic_partition_metadata()) {
905 std::map<string, uint64_t> partition_sizes;
Yifan Hong1d9077f2018-12-07 12:09:37 -0800906 for (const auto& partition : install_plan_->partitions) {
Yifan Hongd4db07e2018-10-18 17:46:27 -0700907 partition_sizes.emplace(partition.name, partition.target_size);
908 }
909 for (const auto& group : manifest_.dynamic_partition_metadata().groups()) {
910 BootControlInterface::PartitionMetadata::Group e;
911 e.name = group.name();
912 e.size = group.size();
913 for (const auto& partition_name : group.partition_names()) {
914 auto it = partition_sizes.find(partition_name);
915 if (it == partition_sizes.end()) {
916 // TODO(tbao): Support auto-filling partition info for framework-only
917 // OTA.
918 LOG(ERROR) << "dynamic_partition_metadata contains partition "
919 << partition_name
920 << " but it is not part of the manifest. "
921 << "This is not supported.";
922 return false;
923 }
924 e.partitions.push_back({partition_name, it->second});
925 }
926 partition_metadata.groups.push_back(std::move(e));
927 }
Yifan Hong9acd9cb2018-10-19 14:52:45 -0700928 }
929
Tao Bao3406c772019-01-02 15:34:35 -0800930 bool metadata_updated = false;
931 prefs_->GetBoolean(kPrefsDynamicPartitionMetadataUpdated, &metadata_updated);
932 if (!boot_control_->InitPartitionMetadata(
933 install_plan_->target_slot, partition_metadata, !metadata_updated)) {
Yifan Hong9acd9cb2018-10-19 14:52:45 -0700934 LOG(ERROR) << "Unable to initialize partition metadata for slot "
935 << BootControlInterface::SlotName(install_plan_->target_slot);
936 return false;
937 }
Yifan Hong28e89702018-12-05 03:28:47 +0000938 TEST_AND_RETURN_FALSE(
Tao Bao3406c772019-01-02 15:34:35 -0800939 prefs_->SetBoolean(kPrefsDynamicPartitionMetadataUpdated, true));
Yifan Hong9acd9cb2018-10-19 14:52:45 -0700940 LOG(INFO) << "InitPartitionMetadata done.";
941
942 return true;
943}
944
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700945bool DeltaPerformer::CanPerformInstallOperation(
Alex Deymoa12ee112015-08-12 22:19:32 -0700946 const chromeos_update_engine::InstallOperation& operation) {
Alex Deymo0497d052016-03-23 09:16:59 -0700947 // If we don't have a data blob we can apply it right away.
948 if (!operation.has_data_offset() && !operation.has_data_length())
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700949 return true;
950
951 // See if we have the entire data blob in the buffer
952 if (operation.data_offset() < buffer_offset_) {
953 LOG(ERROR) << "we threw away data it seems?";
954 return false;
955 }
Darin Petkovd7061ab2010-10-06 14:37:09 -0700956
Gilad Arnoldfe133932014-01-14 12:25:50 -0800957 return (operation.data_offset() + operation.data_length() <=
958 buffer_offset_ + buffer_.size());
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700959}
960
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700961bool DeltaPerformer::PerformReplaceOperation(
962 const InstallOperation& operation) {
Alex Deymoa12ee112015-08-12 22:19:32 -0700963 CHECK(operation.type() == InstallOperation::REPLACE ||
Alex Deymo2d621a32015-10-01 11:09:01 -0700964 operation.type() == InstallOperation::REPLACE_BZ ||
965 operation.type() == InstallOperation::REPLACE_XZ);
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700966
967 // Since we delete data off the beginning of the buffer as we use it,
968 // the data we need should be exactly at the beginning of the buffer.
Darin Petkov9b230572010-10-08 10:20:09 -0700969 TEST_AND_RETURN_FALSE(buffer_offset_ == operation.data_offset());
970 TEST_AND_RETURN_FALSE(buffer_.size() >= operation.data_length());
Darin Petkovd7061ab2010-10-06 14:37:09 -0700971
Amin Hassanifac20222020-01-21 11:32:50 -0800972 // Extract the signature message if it's in this operation.
973 if (ExtractSignatureMessageFromOperation(operation)) {
974 // If this is dummy replace operation, we ignore it after extracting the
975 // signature.
976 DiscardBuffer(true, 0);
977 return true;
978 }
979
Alex Deymo05322872015-09-30 09:50:24 -0700980 // Setup the ExtentWriter stack based on the operation type.
Sen Jiang5e1af982018-11-01 15:01:45 -0700981 std::unique_ptr<ExtentWriter> writer = std::make_unique<DirectExtentWriter>();
Darin Petkovd7061ab2010-10-06 14:37:09 -0700982
Alex Deymo2d621a32015-10-01 11:09:01 -0700983 if (operation.type() == InstallOperation::REPLACE_BZ) {
Alex Deymo05322872015-09-30 09:50:24 -0700984 writer.reset(new BzipExtentWriter(std::move(writer)));
Alex Deymo2d621a32015-10-01 11:09:01 -0700985 } else if (operation.type() == InstallOperation::REPLACE_XZ) {
986 writer.reset(new XzExtentWriter(std::move(writer)));
987 }
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700988
Amin Hassanicd7edbe2017-09-18 17:05:02 -0700989 TEST_AND_RETURN_FALSE(
990 writer->Init(target_fd_, operation.dst_extents(), block_size_));
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -0800991 TEST_AND_RETURN_FALSE(writer->Write(buffer_.data(), operation.data_length()));
Darin Petkovd7061ab2010-10-06 14:37:09 -0700992
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700993 // Update buffer
Sen Jiangf6813802015-11-03 21:27:29 -0800994 DiscardBuffer(true, buffer_.size());
Andrew de los Reyes09e56d62010-04-23 13:45:53 -0700995 return true;
996}
997
Alex Deymo79715ad2015-10-02 14:27:53 -0700998bool DeltaPerformer::PerformZeroOrDiscardOperation(
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700999 const InstallOperation& operation) {
Alex Deymo79715ad2015-10-02 14:27:53 -07001000 CHECK(operation.type() == InstallOperation::DISCARD ||
1001 operation.type() == InstallOperation::ZERO);
1002
1003 // These operations have no blob.
1004 TEST_AND_RETURN_FALSE(!operation.has_data_offset());
1005 TEST_AND_RETURN_FALSE(!operation.has_data_length());
1006
Alex Deymo05e0e382015-12-07 20:18:16 -08001007#ifdef BLKZEROOUT
1008 bool attempt_ioctl = true;
Alex Deymo79715ad2015-10-02 14:27:53 -07001009 int request =
1010 (operation.type() == InstallOperation::ZERO ? BLKZEROOUT : BLKDISCARD);
Amin Hassani008c4582019-01-13 16:22:47 -08001011#else // !defined(BLKZEROOUT)
Alex Deymo05e0e382015-12-07 20:18:16 -08001012 bool attempt_ioctl = false;
1013 int request = 0;
1014#endif // !defined(BLKZEROOUT)
Alex Deymo79715ad2015-10-02 14:27:53 -07001015
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001016 brillo::Blob zeros;
Chih-Hung Hsieh5c6bb1d2016-07-27 13:33:15 -07001017 for (const Extent& extent : operation.dst_extents()) {
Alex Deymo79715ad2015-10-02 14:27:53 -07001018 const uint64_t start = extent.start_block() * block_size_;
1019 const uint64_t length = extent.num_blocks() * block_size_;
1020 if (attempt_ioctl) {
1021 int result = 0;
Alex Deymoe5e5fe92015-10-05 09:28:19 -07001022 if (target_fd_->BlkIoctl(request, start, length, &result) && result == 0)
Alex Deymo79715ad2015-10-02 14:27:53 -07001023 continue;
1024 attempt_ioctl = false;
Alex Deymo79715ad2015-10-02 14:27:53 -07001025 }
1026 // In case of failure, we fall back to writing 0 to the selected region.
Tianjie Xu06bbe492018-01-12 12:37:48 -08001027 zeros.resize(16 * block_size_);
Alex Deymo79715ad2015-10-02 14:27:53 -07001028 for (uint64_t offset = 0; offset < length; offset += zeros.size()) {
Amin Hassani008c4582019-01-13 16:22:47 -08001029 uint64_t chunk_length =
1030 min(length - offset, static_cast<uint64_t>(zeros.size()));
Amin Hassanid87304c2017-08-29 11:40:03 -07001031 TEST_AND_RETURN_FALSE(utils::PWriteAll(
1032 target_fd_, zeros.data(), chunk_length, start + offset));
Alex Deymo79715ad2015-10-02 14:27:53 -07001033 }
1034 }
1035 return true;
1036}
1037
Sen Jiang8371c1c2018-02-01 13:46:39 -08001038bool DeltaPerformer::ValidateSourceHash(const brillo::Blob& calculated_hash,
1039 const InstallOperation& operation,
1040 const FileDescriptorPtr source_fd,
1041 ErrorCode* error) {
Sen Jiang2ec4aab2015-11-13 15:04:03 -08001042 brillo::Blob expected_source_hash(operation.src_sha256_hash().begin(),
1043 operation.src_sha256_hash().end());
1044 if (calculated_hash != expected_source_hash) {
Alex Deymo67140842016-06-15 13:28:59 -07001045 LOG(ERROR) << "The hash of the source data on disk for this operation "
1046 << "doesn't match the expected value. This could mean that the "
1047 << "delta update payload was targeted for another version, or "
1048 << "that the source partition was modified after it was "
1049 << "installed, for example, by mounting a filesystem.";
1050 LOG(ERROR) << "Expected: sha256|hex = "
1051 << base::HexEncode(expected_source_hash.data(),
1052 expected_source_hash.size());
1053 LOG(ERROR) << "Calculated: sha256|hex = "
1054 << base::HexEncode(calculated_hash.data(),
1055 calculated_hash.size());
1056
1057 vector<string> source_extents;
1058 for (const Extent& ext : operation.src_extents()) {
Tamas Berghammer9d66d762016-07-15 14:19:04 +01001059 source_extents.push_back(
1060 base::StringPrintf("%" PRIu64 ":%" PRIu64,
1061 static_cast<uint64_t>(ext.start_block()),
1062 static_cast<uint64_t>(ext.num_blocks())));
Alex Deymo67140842016-06-15 13:28:59 -07001063 }
1064 LOG(ERROR) << "Operation source (offset:size) in blocks: "
1065 << base::JoinString(source_extents, ",");
Sen Jiangbe2c47b2016-06-15 14:09:27 -07001066
HÃ¥kan Kvist4e13cf42018-01-23 12:57:55 +01001067 // Log remount history if this device is an ext4 partition.
1068 LogMountHistory(source_fd);
1069
Sen Jiangbe2c47b2016-06-15 14:09:27 -07001070 *error = ErrorCode::kDownloadStateInitializationError;
Sen Jiang2ec4aab2015-11-13 15:04:03 -08001071 return false;
1072 }
1073 return true;
1074}
1075
Allie Wood9f6f0a52015-03-30 11:25:47 -07001076bool DeltaPerformer::PerformSourceCopyOperation(
Sen Jiangbe2c47b2016-06-15 14:09:27 -07001077 const InstallOperation& operation, ErrorCode* error) {
Allie Wood9f6f0a52015-03-30 11:25:47 -07001078 if (operation.has_src_length())
1079 TEST_AND_RETURN_FALSE(operation.src_length() % block_size_ == 0);
1080 if (operation.has_dst_length())
1081 TEST_AND_RETURN_FALSE(operation.dst_length() % block_size_ == 0);
1082
Sen Jiang2ec4aab2015-11-13 15:04:03 -08001083 if (operation.has_src_sha256_hash()) {
Alex Deymo51c264e2016-11-04 15:49:53 -07001084 brillo::Blob source_hash;
1085 brillo::Blob expected_source_hash(operation.src_sha256_hash().begin(),
1086 operation.src_sha256_hash().end());
Sen Jiang2ec4aab2015-11-13 15:04:03 -08001087
Alex Deymo51c264e2016-11-04 15:49:53 -07001088 // We fall back to use the error corrected device if the hash of the raw
1089 // device doesn't match or there was an error reading the source partition.
1090 // Note that this code will also fall back if writing the target partition
1091 // fails.
1092 bool read_ok = fd_utils::CopyAndHashExtents(source_fd_,
1093 operation.src_extents(),
1094 target_fd_,
1095 operation.dst_extents(),
1096 block_size_,
1097 &source_hash);
1098 if (read_ok && expected_source_hash == source_hash)
1099 return true;
1100
1101 if (!OpenCurrentECCPartition()) {
1102 // The following function call will return false since the source hash
1103 // mismatches, but we still want to call it so it prints the appropriate
1104 // log message.
1105 return ValidateSourceHash(source_hash, operation, source_fd_, error);
1106 }
1107
1108 LOG(WARNING) << "Source hash from RAW device mismatched: found "
1109 << base::HexEncode(source_hash.data(), source_hash.size())
1110 << ", expected "
1111 << base::HexEncode(expected_source_hash.data(),
1112 expected_source_hash.size());
1113
1114 TEST_AND_RETURN_FALSE(fd_utils::CopyAndHashExtents(source_ecc_fd_,
1115 operation.src_extents(),
1116 target_fd_,
1117 operation.dst_extents(),
1118 block_size_,
1119 &source_hash));
1120 TEST_AND_RETURN_FALSE(
1121 ValidateSourceHash(source_hash, operation, source_ecc_fd_, error));
1122 // At this point reading from the the error corrected device worked, but
1123 // reading from the raw device failed, so this is considered a recovered
1124 // failure.
1125 source_ecc_recovered_failures_++;
1126 } else {
1127 // When the operation doesn't include a source hash, we attempt the error
1128 // corrected device first since we can't verify the block in the raw device
1129 // at this point, but we fall back to the raw device since the error
1130 // corrected device can be shorter or not available.
1131 if (OpenCurrentECCPartition() &&
1132 fd_utils::CopyAndHashExtents(source_ecc_fd_,
1133 operation.src_extents(),
1134 target_fd_,
1135 operation.dst_extents(),
1136 block_size_,
1137 nullptr)) {
1138 return true;
1139 }
1140 TEST_AND_RETURN_FALSE(fd_utils::CopyAndHashExtents(source_fd_,
1141 operation.src_extents(),
1142 target_fd_,
1143 operation.dst_extents(),
1144 block_size_,
1145 nullptr));
1146 }
Allie Wood9f6f0a52015-03-30 11:25:47 -07001147 return true;
1148}
1149
Sen Jiang77ab7bd2018-05-22 17:24:23 -07001150FileDescriptorPtr DeltaPerformer::ChooseSourceFD(
1151 const InstallOperation& operation, ErrorCode* error) {
1152 if (!operation.has_src_sha256_hash()) {
1153 // When the operation doesn't include a source hash, we attempt the error
1154 // corrected device first since we can't verify the block in the raw device
1155 // at this point, but we first need to make sure all extents are readable
1156 // since the error corrected device can be shorter or not available.
1157 if (OpenCurrentECCPartition() &&
1158 fd_utils::ReadAndHashExtents(
1159 source_ecc_fd_, operation.src_extents(), block_size_, nullptr)) {
1160 return source_ecc_fd_;
1161 }
1162 return source_fd_;
1163 }
1164
1165 brillo::Blob source_hash;
1166 brillo::Blob expected_source_hash(operation.src_sha256_hash().begin(),
1167 operation.src_sha256_hash().end());
1168 if (fd_utils::ReadAndHashExtents(
1169 source_fd_, operation.src_extents(), block_size_, &source_hash) &&
1170 source_hash == expected_source_hash) {
1171 return source_fd_;
1172 }
1173 // We fall back to use the error corrected device if the hash of the raw
1174 // device doesn't match or there was an error reading the source partition.
1175 if (!OpenCurrentECCPartition()) {
1176 // The following function call will return false since the source hash
1177 // mismatches, but we still want to call it so it prints the appropriate
1178 // log message.
1179 ValidateSourceHash(source_hash, operation, source_fd_, error);
1180 return nullptr;
1181 }
1182 LOG(WARNING) << "Source hash from RAW device mismatched: found "
1183 << base::HexEncode(source_hash.data(), source_hash.size())
1184 << ", expected "
1185 << base::HexEncode(expected_source_hash.data(),
1186 expected_source_hash.size());
1187
1188 if (fd_utils::ReadAndHashExtents(
1189 source_ecc_fd_, operation.src_extents(), block_size_, &source_hash) &&
1190 ValidateSourceHash(source_hash, operation, source_ecc_fd_, error)) {
1191 // At this point reading from the the error corrected device worked, but
1192 // reading from the raw device failed, so this is considered a recovered
1193 // failure.
1194 source_ecc_recovered_failures_++;
1195 return source_ecc_fd_;
1196 }
1197 return nullptr;
1198}
1199
Andrew de los Reyes09e56d62010-04-23 13:45:53 -07001200bool DeltaPerformer::ExtentsToBsdiffPositionsString(
1201 const RepeatedPtrField<Extent>& extents,
1202 uint64_t block_size,
1203 uint64_t full_length,
1204 string* positions_string) {
1205 string ret;
1206 uint64_t length = 0;
Chih-Hung Hsieh5c6bb1d2016-07-27 13:33:15 -07001207 for (const Extent& extent : extents) {
Allie Wood56873452015-03-27 17:48:40 -07001208 int64_t start = extent.start_block() * block_size;
Tamas Berghammer9d66d762016-07-15 14:19:04 +01001209 uint64_t this_length =
1210 min(full_length - length,
1211 static_cast<uint64_t>(extent.num_blocks()) * block_size);
Alex Vakulenko75039d72014-03-25 12:36:28 -07001212 ret += base::StringPrintf("%" PRIi64 ":%" PRIu64 ",", start, this_length);
Andrew de los Reyes09e56d62010-04-23 13:45:53 -07001213 length += this_length;
1214 }
1215 TEST_AND_RETURN_FALSE(length == full_length);
1216 if (!ret.empty())
1217 ret.resize(ret.size() - 1); // Strip trailing comma off
1218 *positions_string = ret;
1219 return true;
1220}
1221
Amin Hassanid9cb2902017-09-20 12:11:39 -07001222namespace {
1223
1224class BsdiffExtentFile : public bsdiff::FileInterface {
1225 public:
1226 BsdiffExtentFile(std::unique_ptr<ExtentReader> reader, size_t size)
1227 : BsdiffExtentFile(std::move(reader), nullptr, size) {}
1228 BsdiffExtentFile(std::unique_ptr<ExtentWriter> writer, size_t size)
1229 : BsdiffExtentFile(nullptr, std::move(writer), size) {}
1230
1231 ~BsdiffExtentFile() override = default;
1232
1233 bool Read(void* buf, size_t count, size_t* bytes_read) override {
1234 TEST_AND_RETURN_FALSE(reader_->Read(buf, count));
1235 *bytes_read = count;
1236 offset_ += count;
1237 return true;
1238 }
1239
1240 bool Write(const void* buf, size_t count, size_t* bytes_written) override {
1241 TEST_AND_RETURN_FALSE(writer_->Write(buf, count));
1242 *bytes_written = count;
1243 offset_ += count;
1244 return true;
1245 }
1246
1247 bool Seek(off_t pos) override {
1248 if (reader_ != nullptr) {
1249 TEST_AND_RETURN_FALSE(reader_->Seek(pos));
1250 offset_ = pos;
1251 } else {
1252 // For writes technically there should be no change of position, or it
1253 // should be equivalent of current offset.
1254 TEST_AND_RETURN_FALSE(offset_ == static_cast<uint64_t>(pos));
1255 }
1256 return true;
1257 }
1258
Sen Jiang5e1af982018-11-01 15:01:45 -07001259 bool Close() override { return true; }
Amin Hassanid9cb2902017-09-20 12:11:39 -07001260
1261 bool GetSize(uint64_t* size) override {
1262 *size = size_;
1263 return true;
1264 }
1265
1266 private:
1267 BsdiffExtentFile(std::unique_ptr<ExtentReader> reader,
1268 std::unique_ptr<ExtentWriter> writer,
1269 size_t size)
1270 : reader_(std::move(reader)),
1271 writer_(std::move(writer)),
1272 size_(size),
1273 offset_(0) {}
1274
1275 std::unique_ptr<ExtentReader> reader_;
1276 std::unique_ptr<ExtentWriter> writer_;
1277 uint64_t size_;
1278 uint64_t offset_;
1279
1280 DISALLOW_COPY_AND_ASSIGN(BsdiffExtentFile);
1281};
1282
1283} // namespace
1284
Allie Wood9f6f0a52015-03-30 11:25:47 -07001285bool DeltaPerformer::PerformSourceBsdiffOperation(
Sen Jiangbe2c47b2016-06-15 14:09:27 -07001286 const InstallOperation& operation, ErrorCode* error) {
Allie Wood9f6f0a52015-03-30 11:25:47 -07001287 // Since we delete data off the beginning of the buffer as we use it,
1288 // the data we need should be exactly at the beginning of the buffer.
1289 TEST_AND_RETURN_FALSE(buffer_offset_ == operation.data_offset());
1290 TEST_AND_RETURN_FALSE(buffer_.size() >= operation.data_length());
1291 if (operation.has_src_length())
1292 TEST_AND_RETURN_FALSE(operation.src_length() % block_size_ == 0);
1293 if (operation.has_dst_length())
1294 TEST_AND_RETURN_FALSE(operation.dst_length() % block_size_ == 0);
1295
Sen Jiang77ab7bd2018-05-22 17:24:23 -07001296 FileDescriptorPtr source_fd = ChooseSourceFD(operation, error);
1297 TEST_AND_RETURN_FALSE(source_fd != nullptr);
Sen Jiang2ec4aab2015-11-13 15:04:03 -08001298
Amin Hassanid9cb2902017-09-20 12:11:39 -07001299 auto reader = std::make_unique<DirectExtentReader>();
1300 TEST_AND_RETURN_FALSE(
Sen Jiang77ab7bd2018-05-22 17:24:23 -07001301 reader->Init(source_fd, operation.src_extents(), block_size_));
Amin Hassanid9cb2902017-09-20 12:11:39 -07001302 auto src_file = std::make_unique<BsdiffExtentFile>(
1303 std::move(reader),
1304 utils::BlocksInExtents(operation.src_extents()) * block_size_);
Allie Wood9f6f0a52015-03-30 11:25:47 -07001305
Amin Hassanid9cb2902017-09-20 12:11:39 -07001306 auto writer = std::make_unique<DirectExtentWriter>();
1307 TEST_AND_RETURN_FALSE(
1308 writer->Init(target_fd_, operation.dst_extents(), block_size_));
1309 auto dst_file = std::make_unique<BsdiffExtentFile>(
1310 std::move(writer),
1311 utils::BlocksInExtents(operation.dst_extents()) * block_size_);
1312
1313 TEST_AND_RETURN_FALSE(bsdiff::bspatch(std::move(src_file),
1314 std::move(dst_file),
Sen Jiang7a659092016-05-10 15:31:46 -07001315 buffer_.data(),
Amin Hassanid9cb2902017-09-20 12:11:39 -07001316 buffer_.size()) == 0);
Sen Jiangbc3e6b02016-01-19 18:39:26 +08001317 DiscardBuffer(true, buffer_.size());
1318 return true;
1319}
1320
Amin Hassani02855c22017-09-06 22:34:50 -07001321namespace {
1322
1323// A class to be passed to |puffpatch| for reading from |source_fd_| and writing
1324// into |target_fd_|.
1325class PuffinExtentStream : public puffin::StreamInterface {
1326 public:
1327 // Constructor for creating a stream for reading from an |ExtentReader|.
Amin Hassani678a68f2018-02-28 11:54:47 -08001328 PuffinExtentStream(std::unique_ptr<ExtentReader> reader, uint64_t size)
Amin Hassani02855c22017-09-06 22:34:50 -07001329 : PuffinExtentStream(std::move(reader), nullptr, size) {}
1330
1331 // Constructor for creating a stream for writing to an |ExtentWriter|.
Amin Hassani678a68f2018-02-28 11:54:47 -08001332 PuffinExtentStream(std::unique_ptr<ExtentWriter> writer, uint64_t size)
Amin Hassani02855c22017-09-06 22:34:50 -07001333 : PuffinExtentStream(nullptr, std::move(writer), size) {}
1334
1335 ~PuffinExtentStream() override = default;
1336
Amin Hassani678a68f2018-02-28 11:54:47 -08001337 bool GetSize(uint64_t* size) const override {
Amin Hassani02855c22017-09-06 22:34:50 -07001338 *size = size_;
1339 return true;
1340 }
1341
Amin Hassani678a68f2018-02-28 11:54:47 -08001342 bool GetOffset(uint64_t* offset) const override {
Amin Hassani02855c22017-09-06 22:34:50 -07001343 *offset = offset_;
1344 return true;
1345 }
1346
Amin Hassani678a68f2018-02-28 11:54:47 -08001347 bool Seek(uint64_t offset) override {
Amin Hassani02855c22017-09-06 22:34:50 -07001348 if (is_read_) {
1349 TEST_AND_RETURN_FALSE(reader_->Seek(offset));
1350 offset_ = offset;
1351 } else {
1352 // For writes technically there should be no change of position, or it
1353 // should equivalent of current offset.
1354 TEST_AND_RETURN_FALSE(offset_ == offset);
1355 }
1356 return true;
1357 }
1358
1359 bool Read(void* buffer, size_t count) override {
1360 TEST_AND_RETURN_FALSE(is_read_);
1361 TEST_AND_RETURN_FALSE(reader_->Read(buffer, count));
1362 offset_ += count;
1363 return true;
1364 }
1365
1366 bool Write(const void* buffer, size_t count) override {
1367 TEST_AND_RETURN_FALSE(!is_read_);
1368 TEST_AND_RETURN_FALSE(writer_->Write(buffer, count));
1369 offset_ += count;
1370 return true;
1371 }
1372
Sen Jiang5e1af982018-11-01 15:01:45 -07001373 bool Close() override { return true; }
Amin Hassani02855c22017-09-06 22:34:50 -07001374
1375 private:
1376 PuffinExtentStream(std::unique_ptr<ExtentReader> reader,
1377 std::unique_ptr<ExtentWriter> writer,
Amin Hassani678a68f2018-02-28 11:54:47 -08001378 uint64_t size)
Amin Hassani02855c22017-09-06 22:34:50 -07001379 : reader_(std::move(reader)),
1380 writer_(std::move(writer)),
1381 size_(size),
1382 offset_(0),
1383 is_read_(reader_ ? true : false) {}
1384
1385 std::unique_ptr<ExtentReader> reader_;
1386 std::unique_ptr<ExtentWriter> writer_;
1387 uint64_t size_;
1388 uint64_t offset_;
1389 bool is_read_;
1390
1391 DISALLOW_COPY_AND_ASSIGN(PuffinExtentStream);
1392};
1393
1394} // namespace
1395
1396bool DeltaPerformer::PerformPuffDiffOperation(const InstallOperation& operation,
1397 ErrorCode* error) {
1398 // Since we delete data off the beginning of the buffer as we use it,
1399 // the data we need should be exactly at the beginning of the buffer.
1400 TEST_AND_RETURN_FALSE(buffer_offset_ == operation.data_offset());
1401 TEST_AND_RETURN_FALSE(buffer_.size() >= operation.data_length());
1402
Sen Jiang77ab7bd2018-05-22 17:24:23 -07001403 FileDescriptorPtr source_fd = ChooseSourceFD(operation, error);
1404 TEST_AND_RETURN_FALSE(source_fd != nullptr);
Amin Hassani02855c22017-09-06 22:34:50 -07001405
1406 auto reader = std::make_unique<DirectExtentReader>();
1407 TEST_AND_RETURN_FALSE(
Sen Jiang77ab7bd2018-05-22 17:24:23 -07001408 reader->Init(source_fd, operation.src_extents(), block_size_));
Amin Hassani02855c22017-09-06 22:34:50 -07001409 puffin::UniqueStreamPtr src_stream(new PuffinExtentStream(
1410 std::move(reader),
1411 utils::BlocksInExtents(operation.src_extents()) * block_size_));
1412
1413 auto writer = std::make_unique<DirectExtentWriter>();
1414 TEST_AND_RETURN_FALSE(
1415 writer->Init(target_fd_, operation.dst_extents(), block_size_));
1416 puffin::UniqueStreamPtr dst_stream(new PuffinExtentStream(
1417 std::move(writer),
1418 utils::BlocksInExtents(operation.dst_extents()) * block_size_));
1419
1420 const size_t kMaxCacheSize = 5 * 1024 * 1024; // Total 5MB cache.
1421 TEST_AND_RETURN_FALSE(puffin::PuffPatch(std::move(src_stream),
1422 std::move(dst_stream),
1423 buffer_.data(),
1424 buffer_.size(),
1425 kMaxCacheSize));
Allie Wood9f6f0a52015-03-30 11:25:47 -07001426 DiscardBuffer(true, buffer_.size());
Alex Deymoa12ee112015-08-12 22:19:32 -07001427 return true;
1428}
Darin Petkovd7061ab2010-10-06 14:37:09 -07001429
Amin Hassanifac20222020-01-21 11:32:50 -08001430bool DeltaPerformer::ExtractSignatureMessageFromOperation(
1431 const InstallOperation& operation) {
1432 if (operation.type() != InstallOperation::REPLACE ||
1433 !manifest_.has_signatures_offset() ||
1434 manifest_.signatures_offset() != operation.data_offset()) {
1435 return false;
1436 }
1437 TEST_AND_RETURN_FALSE(manifest_.has_signatures_size() &&
1438 manifest_.signatures_size() == operation.data_length());
1439 TEST_AND_RETURN_FALSE(ExtractSignatureMessage());
1440 return true;
1441}
1442
Sen Jiangf6813802015-11-03 21:27:29 -08001443bool DeltaPerformer::ExtractSignatureMessage() {
Darin Petkovd7061ab2010-10-06 14:37:09 -07001444 TEST_AND_RETURN_FALSE(signatures_message_data_.empty());
1445 TEST_AND_RETURN_FALSE(buffer_offset_ == manifest_.signatures_offset());
1446 TEST_AND_RETURN_FALSE(buffer_.size() >= manifest_.signatures_size());
Darin Petkov4f0a07b2011-05-25 16:47:20 -07001447 signatures_message_data_.assign(
Amin Hassani008c4582019-01-13 16:22:47 -08001448 buffer_.begin(), buffer_.begin() + manifest_.signatures_size());
Darin Petkov4f0a07b2011-05-25 16:47:20 -07001449
1450 // Save the signature blob because if the update is interrupted after the
1451 // download phase we don't go through this path anymore. Some alternatives to
1452 // consider:
1453 //
1454 // 1. On resume, re-download the signature blob from the server and re-verify
1455 // it.
1456 //
1457 // 2. Verify the signature as soon as it's received and don't checkpoint the
1458 // blob and the signed sha-256 context.
Amin Hassani008c4582019-01-13 16:22:47 -08001459 LOG_IF(WARNING,
1460 !prefs_->SetString(kPrefsUpdateStateSignatureBlob,
1461 string(signatures_message_data_.begin(),
1462 signatures_message_data_.end())))
Darin Petkov4f0a07b2011-05-25 16:47:20 -07001463 << "Unable to store the signature blob.";
Sen Jiangf6813802015-11-03 21:27:29 -08001464
Darin Petkovd7061ab2010-10-06 14:37:09 -07001465 LOG(INFO) << "Extracted signature data of size "
1466 << manifest_.signatures_size() << " at "
1467 << manifest_.signatures_offset();
1468 return true;
1469}
1470
Sen Jiang08c6da12019-01-07 18:28:56 -08001471bool DeltaPerformer::GetPublicKey(string* out_public_key) {
1472 out_public_key->clear();
David Zeuthene7f89172013-10-31 10:21:04 -07001473
Sen Jiang08c6da12019-01-07 18:28:56 -08001474 if (utils::FileExists(public_key_path_.c_str())) {
1475 LOG(INFO) << "Verifying using public key: " << public_key_path_;
1476 return utils::ReadFile(public_key_path_, out_public_key);
1477 }
1478
1479 // If this is an official build then we are not allowed to use public key from
1480 // Omaha response.
1481 if (!hardware_->IsOfficialBuild() && !install_plan_->public_key_rsa.empty()) {
1482 LOG(INFO) << "Verifying using public key from Omaha response.";
1483 return brillo::data_encoding::Base64Decode(install_plan_->public_key_rsa,
1484 out_public_key);
1485 }
David Zeuthene7f89172013-10-31 10:21:04 -07001486
1487 return true;
1488}
1489
Gilad Arnold21504f02013-05-24 08:51:22 -07001490ErrorCode DeltaPerformer::ValidateManifest() {
Don Garrettb8dd1d92013-11-22 17:40:02 -08001491 // Perform assorted checks to sanity check the manifest, make sure it
1492 // matches data from other sources, and that it is a supported version.
Don Garrettb8dd1d92013-11-22 17:40:02 -08001493
Amin Hassanifac20222020-01-21 11:32:50 -08001494 bool has_old_fields =
1495 (manifest_.has_old_kernel_info() || manifest_.has_old_rootfs_info());
1496 for (const PartitionUpdate& partition : manifest_.partitions()) {
1497 has_old_fields = has_old_fields || partition.has_old_partition_info();
1498 }
Sen Jiangc8f6b7a2015-10-21 11:09:59 -07001499
Alex Deymo64d98782016-02-05 18:03:48 -08001500 // The presence of an old partition hash is the sole indicator for a delta
1501 // update.
1502 InstallPayloadType actual_payload_type =
1503 has_old_fields ? InstallPayloadType::kDelta : InstallPayloadType::kFull;
1504
Sen Jiangcdd52062017-05-18 15:33:10 -07001505 if (payload_->type == InstallPayloadType::kUnknown) {
Alex Deymo64d98782016-02-05 18:03:48 -08001506 LOG(INFO) << "Detected a '"
1507 << InstallPayloadTypeToString(actual_payload_type)
1508 << "' payload.";
Sen Jiangcdd52062017-05-18 15:33:10 -07001509 payload_->type = actual_payload_type;
1510 } else if (payload_->type != actual_payload_type) {
Alex Deymo64d98782016-02-05 18:03:48 -08001511 LOG(ERROR) << "InstallPlan expected a '"
Sen Jiangcdd52062017-05-18 15:33:10 -07001512 << InstallPayloadTypeToString(payload_->type)
Alex Deymo64d98782016-02-05 18:03:48 -08001513 << "' payload but the downloaded manifest contains a '"
1514 << InstallPayloadTypeToString(actual_payload_type)
1515 << "' payload.";
1516 return ErrorCode::kPayloadMismatchedType;
1517 }
1518
1519 // Check that the minor version is compatible.
1520 if (actual_payload_type == InstallPayloadType::kFull) {
Don Garrettb8dd1d92013-11-22 17:40:02 -08001521 if (manifest_.minor_version() != kFullPayloadMinorVersion) {
1522 LOG(ERROR) << "Manifest contains minor version "
1523 << manifest_.minor_version()
1524 << ", but all full payloads should have version "
1525 << kFullPayloadMinorVersion << ".";
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001526 return ErrorCode::kUnsupportedMinorPayloadVersion;
Don Garrettb8dd1d92013-11-22 17:40:02 -08001527 }
1528 } else {
Sen Jiangf1236632018-05-11 16:03:23 -07001529 if (manifest_.minor_version() < kMinSupportedMinorPayloadVersion ||
1530 manifest_.minor_version() > kMaxSupportedMinorPayloadVersion) {
Don Garrettb8dd1d92013-11-22 17:40:02 -08001531 LOG(ERROR) << "Manifest contains minor version "
1532 << manifest_.minor_version()
Sen Jiangf1236632018-05-11 16:03:23 -07001533 << " not in the range of supported minor versions ["
1534 << kMinSupportedMinorPayloadVersion << ", "
1535 << kMaxSupportedMinorPayloadVersion << "].";
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001536 return ErrorCode::kUnsupportedMinorPayloadVersion;
Don Garrettb8dd1d92013-11-22 17:40:02 -08001537 }
Gilad Arnold21504f02013-05-24 08:51:22 -07001538 }
1539
Amin Hassanifac20222020-01-21 11:32:50 -08001540 if (major_payload_version_ != kChromeOSMajorPayloadVersion) {
1541 if (manifest_.has_old_rootfs_info() || manifest_.has_new_rootfs_info() ||
1542 manifest_.has_old_kernel_info() || manifest_.has_new_kernel_info() ||
1543 manifest_.install_operations_size() != 0 ||
1544 manifest_.kernel_install_operations_size() != 0) {
1545 LOG(ERROR) << "Manifest contains deprecated field only supported in "
1546 << "major payload version 1, but the payload major version is "
1547 << major_payload_version_;
1548 return ErrorCode::kPayloadMismatchedType;
1549 }
Sen Jiang3e728fe2015-11-05 11:37:23 -08001550 }
1551
Sen Jiang8e768e92017-06-28 17:13:19 -07001552 if (manifest_.max_timestamp() < hardware_->GetBuildTimestamp()) {
1553 LOG(ERROR) << "The current OS build timestamp ("
1554 << hardware_->GetBuildTimestamp()
1555 << ") is newer than the maximum timestamp in the manifest ("
1556 << manifest_.max_timestamp() << ")";
1557 return ErrorCode::kPayloadTimestampError;
1558 }
1559
Amin Hassanifac20222020-01-21 11:32:50 -08001560 if (major_payload_version_ == kChromeOSMajorPayloadVersion) {
1561 if (manifest_.has_dynamic_partition_metadata()) {
1562 LOG(ERROR)
1563 << "Should not contain dynamic_partition_metadata for major version "
1564 << kChromeOSMajorPayloadVersion
1565 << ". Please use major version 2 or above.";
1566 return ErrorCode::kPayloadMismatchedType;
1567 }
1568 }
1569
Amin Hassani55c75412019-10-07 11:20:39 -07001570 // TODO(crbug.com/37661) we should be adding more and more manifest checks,
1571 // such as partition boundaries, etc.
Gilad Arnold21504f02013-05-24 08:51:22 -07001572
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001573 return ErrorCode::kSuccess;
Gilad Arnold21504f02013-05-24 08:51:22 -07001574}
1575
David Zeuthena99981f2013-04-29 13:42:47 -07001576ErrorCode DeltaPerformer::ValidateOperationHash(
Alex Deymoa12ee112015-08-12 22:19:32 -07001577 const InstallOperation& operation) {
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001578 if (!operation.data_sha256_hash().size()) {
1579 if (!operation.data_length()) {
1580 // Operations that do not have any data blob won't have any operation hash
1581 // either. So, these operations are always considered validated since the
Jay Srinivasanf4318702012-09-24 11:56:24 -07001582 // metadata that contains all the non-data-blob portions of the operation
Jay Srinivasan738fdf32012-12-07 17:40:54 -08001583 // has already been validated. This is true for both HTTP and HTTPS cases.
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001584 return ErrorCode::kSuccess;
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001585 }
1586
Jay Srinivasan738fdf32012-12-07 17:40:54 -08001587 // No hash is present for an operation that has data blobs. This shouldn't
1588 // happen normally for any client that has this code, because the
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001589 // corresponding update should have been produced with the operation
Jay Srinivasan738fdf32012-12-07 17:40:54 -08001590 // hashes. So if it happens it means either we've turned operation hash
1591 // generation off in DeltaDiffGenerator or it's a regression of some sort.
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001592 // One caveat though: The last operation is a dummy signature operation
1593 // that doesn't have a hash at the time the manifest is created. So we
1594 // should not complaint about that operation. This operation can be
1595 // recognized by the fact that it's offset is mentioned in the manifest.
1596 if (manifest_.signatures_offset() &&
1597 manifest_.signatures_offset() == operation.data_offset()) {
1598 LOG(INFO) << "Skipping hash verification for signature operation "
1599 << next_operation_num_ + 1;
1600 } else {
Jay Srinivasan738fdf32012-12-07 17:40:54 -08001601 if (install_plan_->hash_checks_mandatory) {
1602 LOG(ERROR) << "Missing mandatory operation hash for operation "
1603 << next_operation_num_ + 1;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001604 return ErrorCode::kDownloadOperationHashMissingError;
Jay Srinivasan738fdf32012-12-07 17:40:54 -08001605 }
1606
Jay Srinivasan738fdf32012-12-07 17:40:54 -08001607 LOG(WARNING) << "Cannot validate operation " << next_operation_num_ + 1
1608 << " as there's no operation hash in manifest";
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001609 }
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001610 return ErrorCode::kSuccess;
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001611 }
1612
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001613 brillo::Blob expected_op_hash;
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001614 expected_op_hash.assign(operation.data_sha256_hash().data(),
1615 (operation.data_sha256_hash().data() +
1616 operation.data_sha256_hash().size()));
1617
Sen Jiang2703ef42017-03-16 13:36:21 -07001618 brillo::Blob calculated_op_hash;
1619 if (!HashCalculator::RawHashOfBytes(
1620 buffer_.data(), operation.data_length(), &calculated_op_hash)) {
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001621 LOG(ERROR) << "Unable to compute actual hash of operation "
1622 << next_operation_num_;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001623 return ErrorCode::kDownloadOperationHashVerificationError;
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001624 }
1625
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001626 if (calculated_op_hash != expected_op_hash) {
1627 LOG(ERROR) << "Hash verification failed for operation "
1628 << next_operation_num_ << ". Expected hash = ";
1629 utils::HexDumpVector(expected_op_hash);
1630 LOG(ERROR) << "Calculated hash over " << operation.data_length()
1631 << " bytes at offset: " << operation.data_offset() << " = ";
1632 utils::HexDumpVector(calculated_op_hash);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001633 return ErrorCode::kDownloadOperationHashMismatch;
Jay Srinivasan00f76b62012-09-17 18:48:36 -07001634 }
1635
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001636 return ErrorCode::kSuccess;
Jay Srinivasan51dcf262012-09-13 17:24:32 -07001637}
1638
Amin Hassani008c4582019-01-13 16:22:47 -08001639#define TEST_AND_RETURN_VAL(_retval, _condition) \
1640 do { \
1641 if (!(_condition)) { \
1642 LOG(ERROR) << "VerifyPayload failure: " << #_condition; \
1643 return _retval; \
1644 } \
Andrew de los Reyes771e1bd2011-08-30 14:47:23 -07001645 } while (0);
Andrew de los Reyesfb830ba2011-04-04 11:42:43 -07001646
David Zeuthena99981f2013-04-29 13:42:47 -07001647ErrorCode DeltaPerformer::VerifyPayload(
Sen Jiang2703ef42017-03-16 13:36:21 -07001648 const brillo::Blob& update_check_response_hash,
Andrew de los Reyes771e1bd2011-08-30 14:47:23 -07001649 const uint64_t update_check_response_size) {
Sen Jiang08c6da12019-01-07 18:28:56 -08001650 string public_key;
1651 if (!GetPublicKey(&public_key)) {
1652 LOG(ERROR) << "Failed to get public key.";
1653 return ErrorCode::kDownloadPayloadPubKeyVerificationError;
1654 }
Darin Petkov437adc42010-10-07 13:12:24 -07001655
Jay Srinivasan0d8fb402012-05-07 19:19:38 -07001656 // Verifies the download size.
Sen Jiang3a25dc22019-01-10 14:14:41 -08001657 if (update_check_response_size !=
1658 metadata_size_ + metadata_signature_size_ + buffer_offset_) {
1659 LOG(ERROR) << "update_check_response_size (" << update_check_response_size
1660 << ") doesn't match metadata_size (" << metadata_size_
1661 << ") + metadata_signature_size (" << metadata_signature_size_
1662 << ") + buffer_offset (" << buffer_offset_ << ").";
1663 return ErrorCode::kPayloadSizeMismatchError;
1664 }
Jay Srinivasan0d8fb402012-05-07 19:19:38 -07001665
Jay Srinivasan51dcf262012-09-13 17:24:32 -07001666 // Verifies the payload hash.
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001667 TEST_AND_RETURN_VAL(ErrorCode::kDownloadPayloadVerificationError,
Sen Jiang2703ef42017-03-16 13:36:21 -07001668 !payload_hash_calculator_.raw_hash().empty());
1669 TEST_AND_RETURN_VAL(
1670 ErrorCode::kPayloadHashMismatchError,
1671 payload_hash_calculator_.raw_hash() == update_check_response_hash);
Darin Petkov437adc42010-10-07 13:12:24 -07001672
Darin Petkov437adc42010-10-07 13:12:24 -07001673 // Verifies the signed payload hash.
Sen Jiang08c6da12019-01-07 18:28:56 -08001674 if (public_key.empty()) {
Darin Petkov437adc42010-10-07 13:12:24 -07001675 LOG(WARNING) << "Not verifying signed delta payload -- missing public key.";
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001676 return ErrorCode::kSuccess;
Darin Petkovd7061ab2010-10-06 14:37:09 -07001677 }
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001678 TEST_AND_RETURN_VAL(ErrorCode::kSignedDeltaPayloadExpectedError,
Andrew de los Reyes771e1bd2011-08-30 14:47:23 -07001679 !signatures_message_data_.empty());
Sen Jiangf6813802015-11-03 21:27:29 -08001680 brillo::Blob hash_data = signed_hash_calculator_.raw_hash();
Alex Deymob552a682015-09-30 09:36:49 -07001681 TEST_AND_RETURN_VAL(ErrorCode::kDownloadPayloadPubKeyVerificationError,
1682 PayloadVerifier::PadRSA2048SHA256Hash(&hash_data));
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001683 TEST_AND_RETURN_VAL(ErrorCode::kDownloadPayloadPubKeyVerificationError,
Andrew de los Reyes771e1bd2011-08-30 14:47:23 -07001684 !hash_data.empty());
Alex Deymob552a682015-09-30 09:36:49 -07001685
1686 if (!PayloadVerifier::VerifySignature(
Sen Jiang08c6da12019-01-07 18:28:56 -08001687 signatures_message_data_, public_key, hash_data)) {
David Zeuthenbc27aac2013-11-26 11:17:48 -08001688 // The autoupdate_CatchBadSignatures test checks for this string
1689 // in log-files. Keep in sync.
Alex Deymob552a682015-09-30 09:36:49 -07001690 LOG(ERROR) << "Public key verification failed, thus update failed.";
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001691 return ErrorCode::kDownloadPayloadPubKeyVerificationError;
Andrew de los Reyesfb830ba2011-04-04 11:42:43 -07001692 }
Jay Srinivasan2b5a0f02012-12-19 17:25:56 -08001693
David Zeuthene7f89172013-10-31 10:21:04 -07001694 LOG(INFO) << "Payload hash matches value in payload.";
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001695 return ErrorCode::kSuccess;
Darin Petkovd7061ab2010-10-06 14:37:09 -07001696}
1697
Sen Jiangf6813802015-11-03 21:27:29 -08001698void DeltaPerformer::DiscardBuffer(bool do_advance_offset,
1699 size_t signed_hash_buffer_size) {
Gilad Arnoldfe133932014-01-14 12:25:50 -08001700 // Update the buffer offset.
Gilad Arnolddaa27402014-01-23 11:56:17 -08001701 if (do_advance_offset)
Gilad Arnoldfe133932014-01-14 12:25:50 -08001702 buffer_offset_ += buffer_.size();
1703
1704 // Hash the content.
Sen Jiangf6813802015-11-03 21:27:29 -08001705 payload_hash_calculator_.Update(buffer_.data(), buffer_.size());
1706 signed_hash_calculator_.Update(buffer_.data(), signed_hash_buffer_size);
Gilad Arnoldfe133932014-01-14 12:25:50 -08001707
1708 // Swap content with an empty vector to ensure that all memory is released.
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001709 brillo::Blob().swap(buffer_);
Darin Petkovd7061ab2010-10-06 14:37:09 -07001710}
1711
Darin Petkov0406e402010-10-06 21:33:11 -07001712bool DeltaPerformer::CanResumeUpdate(PrefsInterface* prefs,
Chih-Hung Hsieh5c6bb1d2016-07-27 13:33:15 -07001713 const string& update_check_response_hash) {
Darin Petkov0406e402010-10-06 21:33:11 -07001714 int64_t next_operation = kUpdateStateOperationInvalid;
Alex Deymo3310b222015-03-30 15:59:07 -07001715 if (!(prefs->GetInt64(kPrefsUpdateStateNextOperation, &next_operation) &&
Amin Hassani008c4582019-01-13 16:22:47 -08001716 next_operation != kUpdateStateOperationInvalid && next_operation > 0))
Alex Deymo3310b222015-03-30 15:59:07 -07001717 return false;
Darin Petkov0406e402010-10-06 21:33:11 -07001718
1719 string interrupted_hash;
Alex Deymo3310b222015-03-30 15:59:07 -07001720 if (!(prefs->GetString(kPrefsUpdateCheckResponseHash, &interrupted_hash) &&
1721 !interrupted_hash.empty() &&
1722 interrupted_hash == update_check_response_hash))
1723 return false;
Darin Petkov0406e402010-10-06 21:33:11 -07001724
Darin Petkov61426142010-10-08 11:04:55 -07001725 int64_t resumed_update_failures;
Alex Deymof25eb492016-02-26 00:20:08 -08001726 // Note that storing this value is optional, but if it is there it should not
1727 // be more than the limit.
1728 if (prefs->GetInt64(kPrefsResumedUpdateFailures, &resumed_update_failures) &&
1729 resumed_update_failures > kMaxResumedUpdateFailures)
Alex Deymo3310b222015-03-30 15:59:07 -07001730 return false;
Darin Petkov61426142010-10-08 11:04:55 -07001731
Darin Petkov0406e402010-10-06 21:33:11 -07001732 // Sanity check the rest.
1733 int64_t next_data_offset = -1;
Alex Deymo3310b222015-03-30 15:59:07 -07001734 if (!(prefs->GetInt64(kPrefsUpdateStateNextDataOffset, &next_data_offset) &&
1735 next_data_offset >= 0))
1736 return false;
Darin Petkov0406e402010-10-06 21:33:11 -07001737
Darin Petkov437adc42010-10-07 13:12:24 -07001738 string sha256_context;
Alex Deymo3310b222015-03-30 15:59:07 -07001739 if (!(prefs->GetString(kPrefsUpdateStateSHA256Context, &sha256_context) &&
1740 !sha256_context.empty()))
1741 return false;
Darin Petkov0406e402010-10-06 21:33:11 -07001742
1743 int64_t manifest_metadata_size = 0;
Alex Deymo3310b222015-03-30 15:59:07 -07001744 if (!(prefs->GetInt64(kPrefsManifestMetadataSize, &manifest_metadata_size) &&
1745 manifest_metadata_size > 0))
1746 return false;
Darin Petkov0406e402010-10-06 21:33:11 -07001747
Alex Deymof25eb492016-02-26 00:20:08 -08001748 int64_t manifest_signature_size = 0;
1749 if (!(prefs->GetInt64(kPrefsManifestSignatureSize,
1750 &manifest_signature_size) &&
1751 manifest_signature_size >= 0))
1752 return false;
1753
Darin Petkov0406e402010-10-06 21:33:11 -07001754 return true;
1755}
1756
Darin Petkov9b230572010-10-08 10:20:09 -07001757bool DeltaPerformer::ResetUpdateProgress(PrefsInterface* prefs, bool quick) {
Darin Petkov0406e402010-10-06 21:33:11 -07001758 TEST_AND_RETURN_FALSE(prefs->SetInt64(kPrefsUpdateStateNextOperation,
1759 kUpdateStateOperationInvalid));
Darin Petkov9b230572010-10-08 10:20:09 -07001760 if (!quick) {
Darin Petkov9b230572010-10-08 10:20:09 -07001761 prefs->SetInt64(kPrefsUpdateStateNextDataOffset, -1);
David Zeuthen41996ad2013-09-24 15:43:24 -07001762 prefs->SetInt64(kPrefsUpdateStateNextDataLength, 0);
Darin Petkov9b230572010-10-08 10:20:09 -07001763 prefs->SetString(kPrefsUpdateStateSHA256Context, "");
1764 prefs->SetString(kPrefsUpdateStateSignedSHA256Context, "");
Darin Petkov4f0a07b2011-05-25 16:47:20 -07001765 prefs->SetString(kPrefsUpdateStateSignatureBlob, "");
Darin Petkov9b230572010-10-08 10:20:09 -07001766 prefs->SetInt64(kPrefsManifestMetadataSize, -1);
Alex Deymof25eb492016-02-26 00:20:08 -08001767 prefs->SetInt64(kPrefsManifestSignatureSize, -1);
Darin Petkov61426142010-10-08 11:04:55 -07001768 prefs->SetInt64(kPrefsResumedUpdateFailures, 0);
Sen Jiangfe522822017-10-31 15:14:11 -07001769 prefs->Delete(kPrefsPostInstallSucceeded);
Sen Jiang3eeaf7d2018-10-11 13:55:32 -07001770 prefs->Delete(kPrefsVerityWritten);
Tao Bao3406c772019-01-02 15:34:35 -08001771 prefs->Delete(kPrefsDynamicPartitionMetadataUpdated);
Darin Petkov9b230572010-10-08 10:20:09 -07001772 }
Darin Petkov73058b42010-10-06 16:32:19 -07001773 return true;
1774}
1775
Sen Jiang3a25dc22019-01-10 14:14:41 -08001776bool DeltaPerformer::CheckpointUpdateProgress(bool force) {
Sen Jiang53c2ec52019-01-10 15:27:59 -08001777 base::TimeTicks curr_time = base::TimeTicks::Now();
Sen Jiang3a25dc22019-01-10 14:14:41 -08001778 if (force || curr_time > update_checkpoint_time_) {
Colin Howes0e452c92018-11-02 13:18:44 -07001779 update_checkpoint_time_ = curr_time + update_checkpoint_wait_;
1780 } else {
1781 return false;
1782 }
1783
Darin Petkov9c0baf82010-10-07 13:44:48 -07001784 Terminator::set_exit_blocked(true);
Darin Petkov0406e402010-10-06 21:33:11 -07001785 if (last_updated_buffer_offset_ != buffer_offset_) {
Darin Petkov9c0baf82010-10-07 13:44:48 -07001786 // Resets the progress in case we die in the middle of the state update.
Darin Petkov9b230572010-10-08 10:20:09 -07001787 ResetUpdateProgress(prefs_, true);
Amin Hassani008c4582019-01-13 16:22:47 -08001788 TEST_AND_RETURN_FALSE(prefs_->SetString(
1789 kPrefsUpdateStateSHA256Context, payload_hash_calculator_.GetContext()));
Sen Jiangf6813802015-11-03 21:27:29 -08001790 TEST_AND_RETURN_FALSE(
1791 prefs_->SetString(kPrefsUpdateStateSignedSHA256Context,
1792 signed_hash_calculator_.GetContext()));
Amin Hassani008c4582019-01-13 16:22:47 -08001793 TEST_AND_RETURN_FALSE(
1794 prefs_->SetInt64(kPrefsUpdateStateNextDataOffset, buffer_offset_));
Darin Petkov0406e402010-10-06 21:33:11 -07001795 last_updated_buffer_offset_ = buffer_offset_;
David Zeuthen41996ad2013-09-24 15:43:24 -07001796
1797 if (next_operation_num_ < num_total_operations_) {
Alex Deymoe5e5fe92015-10-05 09:28:19 -07001798 size_t partition_index = current_partition_;
1799 while (next_operation_num_ >= acc_num_operations_[partition_index])
1800 partition_index++;
Amin Hassani008c4582019-01-13 16:22:47 -08001801 const size_t partition_operation_num =
1802 next_operation_num_ -
1803 (partition_index ? acc_num_operations_[partition_index - 1] : 0);
Alex Deymoa12ee112015-08-12 22:19:32 -07001804 const InstallOperation& op =
Alex Deymoe5e5fe92015-10-05 09:28:19 -07001805 partitions_[partition_index].operations(partition_operation_num);
Amin Hassani008c4582019-01-13 16:22:47 -08001806 TEST_AND_RETURN_FALSE(
1807 prefs_->SetInt64(kPrefsUpdateStateNextDataLength, op.data_length()));
David Zeuthen41996ad2013-09-24 15:43:24 -07001808 } else {
Amin Hassani008c4582019-01-13 16:22:47 -08001809 TEST_AND_RETURN_FALSE(
1810 prefs_->SetInt64(kPrefsUpdateStateNextDataLength, 0));
David Zeuthen41996ad2013-09-24 15:43:24 -07001811 }
Darin Petkov0406e402010-10-06 21:33:11 -07001812 }
Amin Hassani008c4582019-01-13 16:22:47 -08001813 TEST_AND_RETURN_FALSE(
1814 prefs_->SetInt64(kPrefsUpdateStateNextOperation, next_operation_num_));
Darin Petkov73058b42010-10-06 16:32:19 -07001815 return true;
1816}
1817
Darin Petkov9b230572010-10-08 10:20:09 -07001818bool DeltaPerformer::PrimeUpdateState() {
1819 CHECK(manifest_valid_);
Darin Petkov9b230572010-10-08 10:20:09 -07001820
1821 int64_t next_operation = kUpdateStateOperationInvalid;
1822 if (!prefs_->GetInt64(kPrefsUpdateStateNextOperation, &next_operation) ||
Amin Hassani008c4582019-01-13 16:22:47 -08001823 next_operation == kUpdateStateOperationInvalid || next_operation <= 0) {
Darin Petkov9b230572010-10-08 10:20:09 -07001824 // Initiating a new update, no more state needs to be initialized.
1825 return true;
1826 }
1827 next_operation_num_ = next_operation;
1828
1829 // Resuming an update -- load the rest of the update state.
1830 int64_t next_data_offset = -1;
Amin Hassani008c4582019-01-13 16:22:47 -08001831 TEST_AND_RETURN_FALSE(
1832 prefs_->GetInt64(kPrefsUpdateStateNextDataOffset, &next_data_offset) &&
1833 next_data_offset >= 0);
Darin Petkov9b230572010-10-08 10:20:09 -07001834 buffer_offset_ = next_data_offset;
1835
Darin Petkov4f0a07b2011-05-25 16:47:20 -07001836 // The signed hash context and the signature blob may be empty if the
1837 // interrupted update didn't reach the signature.
Sen Jiangf6813802015-11-03 21:27:29 -08001838 string signed_hash_context;
1839 if (prefs_->GetString(kPrefsUpdateStateSignedSHA256Context,
1840 &signed_hash_context)) {
1841 TEST_AND_RETURN_FALSE(
1842 signed_hash_calculator_.SetContext(signed_hash_context));
1843 }
1844
Darin Petkov4f0a07b2011-05-25 16:47:20 -07001845 string signature_blob;
1846 if (prefs_->GetString(kPrefsUpdateStateSignatureBlob, &signature_blob)) {
1847 signatures_message_data_.assign(signature_blob.begin(),
1848 signature_blob.end());
1849 }
Darin Petkov9b230572010-10-08 10:20:09 -07001850
1851 string hash_context;
Amin Hassani008c4582019-01-13 16:22:47 -08001852 TEST_AND_RETURN_FALSE(
1853 prefs_->GetString(kPrefsUpdateStateSHA256Context, &hash_context) &&
1854 payload_hash_calculator_.SetContext(hash_context));
Darin Petkov9b230572010-10-08 10:20:09 -07001855
1856 int64_t manifest_metadata_size = 0;
Amin Hassani008c4582019-01-13 16:22:47 -08001857 TEST_AND_RETURN_FALSE(
1858 prefs_->GetInt64(kPrefsManifestMetadataSize, &manifest_metadata_size) &&
1859 manifest_metadata_size > 0);
Gilad Arnoldfe133932014-01-14 12:25:50 -08001860 metadata_size_ = manifest_metadata_size;
Darin Petkov9b230572010-10-08 10:20:09 -07001861
Alex Deymof25eb492016-02-26 00:20:08 -08001862 int64_t manifest_signature_size = 0;
1863 TEST_AND_RETURN_FALSE(
1864 prefs_->GetInt64(kPrefsManifestSignatureSize, &manifest_signature_size) &&
1865 manifest_signature_size >= 0);
1866 metadata_signature_size_ = manifest_signature_size;
1867
Gilad Arnold8a86fa52013-01-15 12:35:05 -08001868 // Advance the download progress to reflect what doesn't need to be
1869 // re-downloaded.
1870 total_bytes_received_ += buffer_offset_;
1871
Darin Petkov61426142010-10-08 11:04:55 -07001872 // Speculatively count the resume as a failure.
1873 int64_t resumed_update_failures;
1874 if (prefs_->GetInt64(kPrefsResumedUpdateFailures, &resumed_update_failures)) {
1875 resumed_update_failures++;
1876 } else {
1877 resumed_update_failures = 1;
1878 }
1879 prefs_->SetInt64(kPrefsResumedUpdateFailures, resumed_update_failures);
Darin Petkov9b230572010-10-08 10:20:09 -07001880 return true;
1881}
1882
Andrew de los Reyes09e56d62010-04-23 13:45:53 -07001883} // namespace chromeos_update_engine