blob: 6049991308e67150e78d81b2c774389ce6c9e193 [file] [log] [blame]
Victor Hsieh51789de2021-08-06 16:50:49 -07001/*
2 * Copyright (C) 2021 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Alan Stokesfadcef22022-01-24 17:00:59 +000017use anyhow::{anyhow, bail, Context, Result};
Victor Hsieh616f8222022-01-14 13:06:32 -080018use log::{debug, info, warn};
Victor Hsieh51789de2021-08-06 16:50:49 -070019use minijail::{self, Minijail};
Alan Stokes92472512022-01-04 11:48:38 +000020use regex::Regex;
Alan Stokes2d2e4db2022-01-28 16:41:52 +000021use rustutils::system_properties;
Alan Stokesfadcef22022-01-24 17:00:59 +000022use std::collections::HashMap;
Victor Hsiehf9968692021-11-18 11:34:39 -080023use std::env;
Alan Stokes92472512022-01-04 11:48:38 +000024use std::ffi::OsString;
Alan Stokes35bac3c2021-12-16 14:37:24 +000025use std::path::{self, Path, PathBuf};
Alan Stokes92472512022-01-04 11:48:38 +000026use std::process::Command;
Victor Hsieh51789de2021-08-06 16:50:49 -070027
28use authfs_aidl_interface::aidl::com::android::virt::fs::{
Victor Hsieh015bcb52021-11-17 17:28:01 -080029 AuthFsConfig::{
Victor Hsiehf9968692021-11-18 11:34:39 -080030 AuthFsConfig, InputDirFdAnnotation::InputDirFdAnnotation,
Victor Hsieh616f8222022-01-14 13:06:32 -080031 OutputDirFdAnnotation::OutputDirFdAnnotation,
Victor Hsieh015bcb52021-11-17 17:28:01 -080032 },
Victor Hsieh015bcb52021-11-17 17:28:01 -080033 IAuthFsService::IAuthFsService,
Victor Hsieh51789de2021-08-06 16:50:49 -070034};
Alan Stokesfadcef22022-01-24 17:00:59 +000035use authfs_aidl_interface::binder::Strong;
Alan Stokes2d2e4db2022-01-28 16:41:52 +000036use compos_aidl_interface::aidl::com::android::compos::ICompOsService::CompilationMode::CompilationMode;
Alan Stokes46a1dff2021-12-14 10:56:05 +000037use compos_common::odrefresh::ExitCode;
Victor Hsieh51789de2021-08-06 16:50:49 -070038
Victor Hsiehf9968692021-11-18 11:34:39 -080039const FD_SERVER_PORT: i32 = 3264; // TODO: support dynamic port
40
Alan Stokes46a1dff2021-12-14 10:56:05 +000041pub struct OdrefreshContext<'a> {
Alan Stokes2d2e4db2022-01-28 16:41:52 +000042 compilation_mode: CompilationMode,
Victor Hsiehf9968692021-11-18 11:34:39 -080043 system_dir_fd: i32,
44 output_dir_fd: i32,
Alan Stokes9646db92021-12-14 13:22:33 +000045 staging_dir_fd: i32,
Alan Stokes46a1dff2021-12-14 10:56:05 +000046 target_dir_name: &'a str,
47 zygote_arch: &'a str,
Victor Hsieh9bfbc5f2021-12-16 11:45:10 -080048 system_server_compiler_filter: &'a str,
Alan Stokes46a1dff2021-12-14 10:56:05 +000049}
50
51impl<'a> OdrefreshContext<'a> {
52 pub fn new(
Alan Stokes2d2e4db2022-01-28 16:41:52 +000053 compilation_mode: CompilationMode,
Alan Stokes46a1dff2021-12-14 10:56:05 +000054 system_dir_fd: i32,
55 output_dir_fd: i32,
56 staging_dir_fd: i32,
57 target_dir_name: &'a str,
58 zygote_arch: &'a str,
Victor Hsieh9bfbc5f2021-12-16 11:45:10 -080059 system_server_compiler_filter: &'a str,
Alan Stokes46a1dff2021-12-14 10:56:05 +000060 ) -> Result<Self> {
Alan Stokes2d2e4db2022-01-28 16:41:52 +000061 if compilation_mode != CompilationMode::NORMAL_COMPILE {
Alan Stokeseba7e652022-02-03 14:48:56 +000062 let debuggable = is_property_set("ro.boot.microdroid.debuggable")
63 || is_property_set("ro.boot.logd.enabled")
64 || is_property_set("ro.boot.adb.enabled");
Alan Stokes2d2e4db2022-01-28 16:41:52 +000065 if !debuggable {
66 bail!("Requested compilation mode only available in debuggable VMs");
67 }
68 }
69
Alan Stokes46a1dff2021-12-14 10:56:05 +000070 if system_dir_fd < 0 || output_dir_fd < 0 || staging_dir_fd < 0 {
71 bail!("The remote FDs are expected to be non-negative");
72 }
Victor Hsieh9bfbc5f2021-12-16 11:45:10 -080073 if !matches!(zygote_arch, "zygote64" | "zygote64_32") {
Alan Stokes46a1dff2021-12-14 10:56:05 +000074 bail!("Invalid zygote arch");
75 }
Alan Stokes35bac3c2021-12-16 14:37:24 +000076 // Disallow any sort of path traversal
77 if target_dir_name.contains(path::MAIN_SEPARATOR) {
78 bail!("Invalid target directory {}", target_dir_name);
79 }
80
Victor Hsieh9bfbc5f2021-12-16 11:45:10 -080081 // We're not validating/allowlisting the compiler filter, and just assume the compiler will
82 // reject an invalid string. We need to accept "verify" filter anyway, and potential
83 // performance degration by the attacker is not currently in scope. This also allows ART to
84 // specify new compiler filter and configure through system property without change to
85 // CompOS.
86
87 Ok(Self {
Alan Stokes2d2e4db2022-01-28 16:41:52 +000088 compilation_mode,
Victor Hsieh9bfbc5f2021-12-16 11:45:10 -080089 system_dir_fd,
90 output_dir_fd,
91 staging_dir_fd,
92 target_dir_name,
93 zygote_arch,
94 system_server_compiler_filter,
95 })
Alan Stokes46a1dff2021-12-14 10:56:05 +000096 }
97}
98
Alan Stokeseba7e652022-02-03 14:48:56 +000099// Return whether the named property is definitely enabled. Deliberately conservative; returns
100// false if the property does not exist or cannot be read or is malformed.
101fn is_property_set(name: &str) -> bool {
102 system_properties::read_bool(name, false).unwrap_or(false)
103}
104
Victor Hsiehec38ae22022-02-10 00:06:26 +0000105pub fn odrefresh<F>(
Alan Stokes46a1dff2021-12-14 10:56:05 +0000106 odrefresh_path: &Path,
107 context: OdrefreshContext,
Victor Hsiehf9968692021-11-18 11:34:39 -0800108 authfs_service: Strong<dyn IAuthFsService>,
Victor Hsiehec38ae22022-02-10 00:06:26 +0000109 success_fn: F,
110) -> Result<ExitCode>
111where
112 F: FnOnce(PathBuf) -> Result<()>,
113{
Victor Hsiehf9968692021-11-18 11:34:39 -0800114 // Mount authfs (via authfs_service). The authfs instance unmounts once the `authfs` variable
115 // is out of scope.
116 let authfs_config = AuthFsConfig {
117 port: FD_SERVER_PORT,
118 inputDirFdAnnotations: vec![InputDirFdAnnotation {
Alan Stokes46a1dff2021-12-14 10:56:05 +0000119 fd: context.system_dir_fd,
Victor Hsieh99782572022-01-05 15:38:33 -0800120 // 0 is the index of extra_apks in vm_config_extra_apk.json
121 manifestPath: "/mnt/extra-apk/0/assets/build_manifest.pb".to_string(),
122 prefix: "system/".to_string(),
Victor Hsiehf9968692021-11-18 11:34:39 -0800123 }],
Alan Stokes9646db92021-12-14 13:22:33 +0000124 outputDirFdAnnotations: vec![
Alan Stokes46a1dff2021-12-14 10:56:05 +0000125 OutputDirFdAnnotation { fd: context.output_dir_fd },
126 OutputDirFdAnnotation { fd: context.staging_dir_fd },
Alan Stokes9646db92021-12-14 13:22:33 +0000127 ],
Victor Hsiehf9968692021-11-18 11:34:39 -0800128 ..Default::default()
129 };
130 let authfs = authfs_service.mount(&authfs_config)?;
131 let mountpoint = PathBuf::from(authfs.getMountPoint()?);
132
Alan Stokesfadcef22022-01-24 17:00:59 +0000133 // Make a copy of our environment as the basis of the one we will give odrefresh
134 let mut odrefresh_vars = EnvMap::from_current_env();
135
Victor Hsiehf9968692021-11-18 11:34:39 -0800136 let mut android_root = mountpoint.clone();
Alan Stokes46a1dff2021-12-14 10:56:05 +0000137 android_root.push(context.system_dir_fd.to_string());
Victor Hsiehf9968692021-11-18 11:34:39 -0800138 android_root.push("system");
Alan Stokesfadcef22022-01-24 17:00:59 +0000139 odrefresh_vars.set("ANDROID_ROOT", path_to_str(&android_root)?);
Alan Stokes46a1dff2021-12-14 10:56:05 +0000140 debug!("ANDROID_ROOT={:?}", &android_root);
Victor Hsiehf9968692021-11-18 11:34:39 -0800141
Alan Stokes46a1dff2021-12-14 10:56:05 +0000142 let art_apex_data = mountpoint.join(context.output_dir_fd.to_string());
Alan Stokesfadcef22022-01-24 17:00:59 +0000143 odrefresh_vars.set("ART_APEX_DATA", path_to_str(&art_apex_data)?);
Alan Stokes46a1dff2021-12-14 10:56:05 +0000144 debug!("ART_APEX_DATA={:?}", &art_apex_data);
Victor Hsieh64df53d2021-11-30 17:09:51 -0800145
Alan Stokes46a1dff2021-12-14 10:56:05 +0000146 let staging_dir = mountpoint.join(context.staging_dir_fd.to_string());
Victor Hsiehf9968692021-11-18 11:34:39 -0800147
Alan Stokesfadcef22022-01-24 17:00:59 +0000148 set_classpaths(&mut odrefresh_vars, &android_root)?;
Alan Stokes92472512022-01-04 11:48:38 +0000149
Victor Hsieh9bfbc5f2021-12-16 11:45:10 -0800150 let mut args = vec![
Victor Hsiehf9968692021-11-18 11:34:39 -0800151 "odrefresh".to_string(),
Alan Stokes48c1d2b2022-01-10 15:54:04 +0000152 "--compilation-os-mode".to_string(),
Alan Stokes46a1dff2021-12-14 10:56:05 +0000153 format!("--zygote-arch={}", context.zygote_arch),
154 format!("--dalvik-cache={}", context.target_dir_name),
Victor Hsiehf9968692021-11-18 11:34:39 -0800155 format!("--staging-dir={}", staging_dir.display()),
Victor Hsieh9bfbc5f2021-12-16 11:45:10 -0800156 "--no-refresh".to_string(),
Victor Hsiehf9968692021-11-18 11:34:39 -0800157 ];
Victor Hsieh9bfbc5f2021-12-16 11:45:10 -0800158
159 if !context.system_server_compiler_filter.is_empty() {
160 args.push(format!(
161 "--system-server-compiler-filter={}",
162 context.system_server_compiler_filter
163 ));
164 }
Alan Stokes48c1d2b2022-01-10 15:54:04 +0000165
Alan Stokes2d2e4db2022-01-28 16:41:52 +0000166 let compile_flag = match context.compilation_mode {
167 CompilationMode::NORMAL_COMPILE => "--compile",
168 CompilationMode::TEST_COMPILE => "--force-compile",
169 other => bail!("Unknown compilation mode {:?}", other),
170 };
171 args.push(compile_flag.to_string());
Victor Hsieh9bfbc5f2021-12-16 11:45:10 -0800172
Alan Stokes9646db92021-12-14 13:22:33 +0000173 debug!("Running odrefresh with args: {:?}", &args);
Alan Stokesfadcef22022-01-24 17:00:59 +0000174 let jail = spawn_jailed_task(odrefresh_path, &args, &odrefresh_vars.into_env())
Victor Hsiehf9968692021-11-18 11:34:39 -0800175 .context("Spawn odrefresh")?;
Alan Stokes46a1dff2021-12-14 10:56:05 +0000176 let exit_code = match jail.wait() {
Alan Stokes2d2e4db2022-01-28 16:41:52 +0000177 Ok(_) => 0,
178 Err(minijail::Error::ReturnCode(exit_code)) => exit_code,
179 Err(e) => bail!("Unexpected minijail error: {}", e),
180 };
Alan Stokes46a1dff2021-12-14 10:56:05 +0000181
Alan Stokes126fd512021-12-16 15:00:01 +0000182 let exit_code = ExitCode::from_i32(exit_code.into())?;
Alan Stokes46a1dff2021-12-14 10:56:05 +0000183 info!("odrefresh exited with {:?}", exit_code);
184
185 if exit_code == ExitCode::CompilationSuccess {
Alan Stokes46a1dff2021-12-14 10:56:05 +0000186 let target_dir = art_apex_data.join(context.target_dir_name);
Victor Hsiehec38ae22022-02-10 00:06:26 +0000187 success_fn(target_dir)?;
Victor Hsiehf9968692021-11-18 11:34:39 -0800188 }
Alan Stokes46a1dff2021-12-14 10:56:05 +0000189
190 Ok(exit_code)
191}
192
Alan Stokesfadcef22022-01-24 17:00:59 +0000193fn path_to_str(path: &Path) -> Result<&str> {
194 path.to_str().ok_or_else(|| anyhow!("Bad path {:?}", path))
195}
196
197fn set_classpaths(odrefresh_vars: &mut EnvMap, android_root: &Path) -> Result<()> {
Alan Stokes92472512022-01-04 11:48:38 +0000198 let export_lines = run_derive_classpath(android_root)?;
Alan Stokesfadcef22022-01-24 17:00:59 +0000199 load_classpath_vars(odrefresh_vars, &export_lines)
Alan Stokes92472512022-01-04 11:48:38 +0000200}
201
202fn run_derive_classpath(android_root: &Path) -> Result<String> {
203 let classpaths_root = android_root.join("etc/classpaths");
204
205 let mut bootclasspath_arg = OsString::new();
206 bootclasspath_arg.push("--bootclasspath-fragment=");
207 bootclasspath_arg.push(classpaths_root.join("bootclasspath.pb"));
208
209 let mut systemserverclasspath_arg = OsString::new();
210 systemserverclasspath_arg.push("--systemserverclasspath-fragment=");
211 systemserverclasspath_arg.push(classpaths_root.join("systemserverclasspath.pb"));
212
213 let result = Command::new("/apex/com.android.sdkext/bin/derive_classpath")
214 .arg(bootclasspath_arg)
215 .arg(systemserverclasspath_arg)
216 .arg("/proc/self/fd/1")
217 .output()
218 .context("Failed to run derive_classpath")?;
219
220 if !result.status.success() {
221 bail!("derive_classpath returned {}", result.status);
222 }
223
224 String::from_utf8(result.stdout).context("Converting derive_classpath output")
225}
226
Alan Stokesfadcef22022-01-24 17:00:59 +0000227fn load_classpath_vars(odrefresh_vars: &mut EnvMap, export_lines: &str) -> Result<()> {
Alan Stokes92472512022-01-04 11:48:38 +0000228 // Each line should be in the format "export <var name> <value>"
229 let pattern = Regex::new(r"^export ([^ ]+) ([^ ]+)$").context("Failed to construct Regex")?;
230 for line in export_lines.lines() {
231 if let Some(captures) = pattern.captures(line) {
232 let name = &captures[1];
233 let value = &captures[2];
Alan Stokesfadcef22022-01-24 17:00:59 +0000234 odrefresh_vars.set(name, value);
Alan Stokes92472512022-01-04 11:48:38 +0000235 } else {
236 warn!("Malformed line from derive_classpath: {}", line);
237 }
238 }
239
240 Ok(())
241}
242
Alan Stokesfadcef22022-01-24 17:00:59 +0000243fn spawn_jailed_task(executable: &Path, args: &[String], env_vars: &[String]) -> Result<Minijail> {
Victor Hsieh51789de2021-08-06 16:50:49 -0700244 // TODO(b/185175567): Run in a more restricted sandbox.
245 let jail = Minijail::new()?;
Alan Stokesfadcef22022-01-24 17:00:59 +0000246 let keep_fds = [];
247 let command = minijail::Command::new_for_path(executable, &keep_fds, args, Some(env_vars))?;
248 let _pid = jail.run_command(command)?;
Victor Hsieh51789de2021-08-06 16:50:49 -0700249 Ok(jail)
250}
Alan Stokesfadcef22022-01-24 17:00:59 +0000251
252struct EnvMap(HashMap<String, String>);
253
254impl EnvMap {
255 fn from_current_env() -> Self {
256 Self(env::vars().collect())
257 }
258
259 fn set(&mut self, key: &str, value: &str) {
260 self.0.insert(key.to_owned(), value.to_owned());
261 }
262
263 fn into_env(self) -> Vec<String> {
264 // execve() expects an array of "k=v" strings, rather than a list of (k, v) pairs.
265 self.0.into_iter().map(|(k, v)| k + "=" + &v).collect()
266 }
267}