Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2021 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 17 | use anyhow::{anyhow, bail, Context, Result}; |
Victor Hsieh | 616f822 | 2022-01-14 13:06:32 -0800 | [diff] [blame] | 18 | use log::{debug, info, warn}; |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 19 | use minijail::{self, Minijail}; |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 20 | use regex::Regex; |
Alan Stokes | 2d2e4db | 2022-01-28 16:41:52 +0000 | [diff] [blame] | 21 | use rustutils::system_properties; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 22 | use std::collections::HashMap; |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 23 | use std::env; |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 24 | use std::ffi::OsString; |
Alan Stokes | 35bac3c | 2021-12-16 14:37:24 +0000 | [diff] [blame] | 25 | use std::path::{self, Path, PathBuf}; |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 26 | use std::process::Command; |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 27 | |
| 28 | use authfs_aidl_interface::aidl::com::android::virt::fs::{ |
Victor Hsieh | 015bcb5 | 2021-11-17 17:28:01 -0800 | [diff] [blame] | 29 | AuthFsConfig::{ |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 30 | AuthFsConfig, InputDirFdAnnotation::InputDirFdAnnotation, |
Victor Hsieh | 616f822 | 2022-01-14 13:06:32 -0800 | [diff] [blame] | 31 | OutputDirFdAnnotation::OutputDirFdAnnotation, |
Victor Hsieh | 015bcb5 | 2021-11-17 17:28:01 -0800 | [diff] [blame] | 32 | }, |
Victor Hsieh | 015bcb5 | 2021-11-17 17:28:01 -0800 | [diff] [blame] | 33 | IAuthFsService::IAuthFsService, |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 34 | }; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 35 | use authfs_aidl_interface::binder::Strong; |
Alan Stokes | 2d2e4db | 2022-01-28 16:41:52 +0000 | [diff] [blame] | 36 | use compos_aidl_interface::aidl::com::android::compos::ICompOsService::CompilationMode::CompilationMode; |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 37 | use compos_common::odrefresh::ExitCode; |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 38 | |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 39 | const FD_SERVER_PORT: i32 = 3264; // TODO: support dynamic port |
| 40 | |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 41 | pub struct OdrefreshContext<'a> { |
Alan Stokes | 2d2e4db | 2022-01-28 16:41:52 +0000 | [diff] [blame] | 42 | compilation_mode: CompilationMode, |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 43 | system_dir_fd: i32, |
| 44 | output_dir_fd: i32, |
Alan Stokes | 9646db9 | 2021-12-14 13:22:33 +0000 | [diff] [blame] | 45 | staging_dir_fd: i32, |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 46 | target_dir_name: &'a str, |
| 47 | zygote_arch: &'a str, |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 48 | system_server_compiler_filter: &'a str, |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 49 | } |
| 50 | |
| 51 | impl<'a> OdrefreshContext<'a> { |
| 52 | pub fn new( |
Alan Stokes | 2d2e4db | 2022-01-28 16:41:52 +0000 | [diff] [blame] | 53 | compilation_mode: CompilationMode, |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 54 | system_dir_fd: i32, |
| 55 | output_dir_fd: i32, |
| 56 | staging_dir_fd: i32, |
| 57 | target_dir_name: &'a str, |
| 58 | zygote_arch: &'a str, |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 59 | system_server_compiler_filter: &'a str, |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 60 | ) -> Result<Self> { |
Alan Stokes | 2d2e4db | 2022-01-28 16:41:52 +0000 | [diff] [blame] | 61 | if compilation_mode != CompilationMode::NORMAL_COMPILE { |
Alan Stokes | eba7e65 | 2022-02-03 14:48:56 +0000 | [diff] [blame] | 62 | let debuggable = is_property_set("ro.boot.microdroid.debuggable") |
| 63 | || is_property_set("ro.boot.logd.enabled") |
| 64 | || is_property_set("ro.boot.adb.enabled"); |
Alan Stokes | 2d2e4db | 2022-01-28 16:41:52 +0000 | [diff] [blame] | 65 | if !debuggable { |
| 66 | bail!("Requested compilation mode only available in debuggable VMs"); |
| 67 | } |
| 68 | } |
| 69 | |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 70 | if system_dir_fd < 0 || output_dir_fd < 0 || staging_dir_fd < 0 { |
| 71 | bail!("The remote FDs are expected to be non-negative"); |
| 72 | } |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 73 | if !matches!(zygote_arch, "zygote64" | "zygote64_32") { |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 74 | bail!("Invalid zygote arch"); |
| 75 | } |
Alan Stokes | 35bac3c | 2021-12-16 14:37:24 +0000 | [diff] [blame] | 76 | // Disallow any sort of path traversal |
| 77 | if target_dir_name.contains(path::MAIN_SEPARATOR) { |
| 78 | bail!("Invalid target directory {}", target_dir_name); |
| 79 | } |
| 80 | |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 81 | // We're not validating/allowlisting the compiler filter, and just assume the compiler will |
| 82 | // reject an invalid string. We need to accept "verify" filter anyway, and potential |
| 83 | // performance degration by the attacker is not currently in scope. This also allows ART to |
| 84 | // specify new compiler filter and configure through system property without change to |
| 85 | // CompOS. |
| 86 | |
| 87 | Ok(Self { |
Alan Stokes | 2d2e4db | 2022-01-28 16:41:52 +0000 | [diff] [blame] | 88 | compilation_mode, |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 89 | system_dir_fd, |
| 90 | output_dir_fd, |
| 91 | staging_dir_fd, |
| 92 | target_dir_name, |
| 93 | zygote_arch, |
| 94 | system_server_compiler_filter, |
| 95 | }) |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 96 | } |
| 97 | } |
| 98 | |
Alan Stokes | eba7e65 | 2022-02-03 14:48:56 +0000 | [diff] [blame] | 99 | // Return whether the named property is definitely enabled. Deliberately conservative; returns |
| 100 | // false if the property does not exist or cannot be read or is malformed. |
| 101 | fn is_property_set(name: &str) -> bool { |
| 102 | system_properties::read_bool(name, false).unwrap_or(false) |
| 103 | } |
| 104 | |
Victor Hsieh | ec38ae2 | 2022-02-10 00:06:26 +0000 | [diff] [blame] | 105 | pub fn odrefresh<F>( |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 106 | odrefresh_path: &Path, |
| 107 | context: OdrefreshContext, |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 108 | authfs_service: Strong<dyn IAuthFsService>, |
Victor Hsieh | ec38ae2 | 2022-02-10 00:06:26 +0000 | [diff] [blame] | 109 | success_fn: F, |
| 110 | ) -> Result<ExitCode> |
| 111 | where |
| 112 | F: FnOnce(PathBuf) -> Result<()>, |
| 113 | { |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 114 | // Mount authfs (via authfs_service). The authfs instance unmounts once the `authfs` variable |
| 115 | // is out of scope. |
| 116 | let authfs_config = AuthFsConfig { |
| 117 | port: FD_SERVER_PORT, |
| 118 | inputDirFdAnnotations: vec![InputDirFdAnnotation { |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 119 | fd: context.system_dir_fd, |
Victor Hsieh | 9978257 | 2022-01-05 15:38:33 -0800 | [diff] [blame] | 120 | // 0 is the index of extra_apks in vm_config_extra_apk.json |
| 121 | manifestPath: "/mnt/extra-apk/0/assets/build_manifest.pb".to_string(), |
| 122 | prefix: "system/".to_string(), |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 123 | }], |
Alan Stokes | 9646db9 | 2021-12-14 13:22:33 +0000 | [diff] [blame] | 124 | outputDirFdAnnotations: vec![ |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 125 | OutputDirFdAnnotation { fd: context.output_dir_fd }, |
| 126 | OutputDirFdAnnotation { fd: context.staging_dir_fd }, |
Alan Stokes | 9646db9 | 2021-12-14 13:22:33 +0000 | [diff] [blame] | 127 | ], |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 128 | ..Default::default() |
| 129 | }; |
| 130 | let authfs = authfs_service.mount(&authfs_config)?; |
| 131 | let mountpoint = PathBuf::from(authfs.getMountPoint()?); |
| 132 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 133 | // Make a copy of our environment as the basis of the one we will give odrefresh |
| 134 | let mut odrefresh_vars = EnvMap::from_current_env(); |
| 135 | |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 136 | let mut android_root = mountpoint.clone(); |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 137 | android_root.push(context.system_dir_fd.to_string()); |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 138 | android_root.push("system"); |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 139 | odrefresh_vars.set("ANDROID_ROOT", path_to_str(&android_root)?); |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 140 | debug!("ANDROID_ROOT={:?}", &android_root); |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 141 | |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 142 | let art_apex_data = mountpoint.join(context.output_dir_fd.to_string()); |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 143 | odrefresh_vars.set("ART_APEX_DATA", path_to_str(&art_apex_data)?); |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 144 | debug!("ART_APEX_DATA={:?}", &art_apex_data); |
Victor Hsieh | 64df53d | 2021-11-30 17:09:51 -0800 | [diff] [blame] | 145 | |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 146 | let staging_dir = mountpoint.join(context.staging_dir_fd.to_string()); |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 147 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 148 | set_classpaths(&mut odrefresh_vars, &android_root)?; |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 149 | |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 150 | let mut args = vec![ |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 151 | "odrefresh".to_string(), |
Alan Stokes | 48c1d2b | 2022-01-10 15:54:04 +0000 | [diff] [blame] | 152 | "--compilation-os-mode".to_string(), |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 153 | format!("--zygote-arch={}", context.zygote_arch), |
| 154 | format!("--dalvik-cache={}", context.target_dir_name), |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 155 | format!("--staging-dir={}", staging_dir.display()), |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 156 | "--no-refresh".to_string(), |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 157 | ]; |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 158 | |
| 159 | if !context.system_server_compiler_filter.is_empty() { |
| 160 | args.push(format!( |
| 161 | "--system-server-compiler-filter={}", |
| 162 | context.system_server_compiler_filter |
| 163 | )); |
| 164 | } |
Alan Stokes | 48c1d2b | 2022-01-10 15:54:04 +0000 | [diff] [blame] | 165 | |
Alan Stokes | 2d2e4db | 2022-01-28 16:41:52 +0000 | [diff] [blame] | 166 | let compile_flag = match context.compilation_mode { |
| 167 | CompilationMode::NORMAL_COMPILE => "--compile", |
| 168 | CompilationMode::TEST_COMPILE => "--force-compile", |
| 169 | other => bail!("Unknown compilation mode {:?}", other), |
| 170 | }; |
| 171 | args.push(compile_flag.to_string()); |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 172 | |
Alan Stokes | 9646db9 | 2021-12-14 13:22:33 +0000 | [diff] [blame] | 173 | debug!("Running odrefresh with args: {:?}", &args); |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 174 | let jail = spawn_jailed_task(odrefresh_path, &args, &odrefresh_vars.into_env()) |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 175 | .context("Spawn odrefresh")?; |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 176 | let exit_code = match jail.wait() { |
Alan Stokes | 2d2e4db | 2022-01-28 16:41:52 +0000 | [diff] [blame] | 177 | Ok(_) => 0, |
| 178 | Err(minijail::Error::ReturnCode(exit_code)) => exit_code, |
| 179 | Err(e) => bail!("Unexpected minijail error: {}", e), |
| 180 | }; |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 181 | |
Alan Stokes | 126fd51 | 2021-12-16 15:00:01 +0000 | [diff] [blame] | 182 | let exit_code = ExitCode::from_i32(exit_code.into())?; |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 183 | info!("odrefresh exited with {:?}", exit_code); |
| 184 | |
| 185 | if exit_code == ExitCode::CompilationSuccess { |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 186 | let target_dir = art_apex_data.join(context.target_dir_name); |
Victor Hsieh | ec38ae2 | 2022-02-10 00:06:26 +0000 | [diff] [blame] | 187 | success_fn(target_dir)?; |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 188 | } |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 189 | |
| 190 | Ok(exit_code) |
| 191 | } |
| 192 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 193 | fn path_to_str(path: &Path) -> Result<&str> { |
| 194 | path.to_str().ok_or_else(|| anyhow!("Bad path {:?}", path)) |
| 195 | } |
| 196 | |
| 197 | fn set_classpaths(odrefresh_vars: &mut EnvMap, android_root: &Path) -> Result<()> { |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 198 | let export_lines = run_derive_classpath(android_root)?; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 199 | load_classpath_vars(odrefresh_vars, &export_lines) |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 200 | } |
| 201 | |
| 202 | fn run_derive_classpath(android_root: &Path) -> Result<String> { |
| 203 | let classpaths_root = android_root.join("etc/classpaths"); |
| 204 | |
| 205 | let mut bootclasspath_arg = OsString::new(); |
| 206 | bootclasspath_arg.push("--bootclasspath-fragment="); |
| 207 | bootclasspath_arg.push(classpaths_root.join("bootclasspath.pb")); |
| 208 | |
| 209 | let mut systemserverclasspath_arg = OsString::new(); |
| 210 | systemserverclasspath_arg.push("--systemserverclasspath-fragment="); |
| 211 | systemserverclasspath_arg.push(classpaths_root.join("systemserverclasspath.pb")); |
| 212 | |
| 213 | let result = Command::new("/apex/com.android.sdkext/bin/derive_classpath") |
| 214 | .arg(bootclasspath_arg) |
| 215 | .arg(systemserverclasspath_arg) |
| 216 | .arg("/proc/self/fd/1") |
| 217 | .output() |
| 218 | .context("Failed to run derive_classpath")?; |
| 219 | |
| 220 | if !result.status.success() { |
| 221 | bail!("derive_classpath returned {}", result.status); |
| 222 | } |
| 223 | |
| 224 | String::from_utf8(result.stdout).context("Converting derive_classpath output") |
| 225 | } |
| 226 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 227 | fn load_classpath_vars(odrefresh_vars: &mut EnvMap, export_lines: &str) -> Result<()> { |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 228 | // Each line should be in the format "export <var name> <value>" |
| 229 | let pattern = Regex::new(r"^export ([^ ]+) ([^ ]+)$").context("Failed to construct Regex")?; |
| 230 | for line in export_lines.lines() { |
| 231 | if let Some(captures) = pattern.captures(line) { |
| 232 | let name = &captures[1]; |
| 233 | let value = &captures[2]; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 234 | odrefresh_vars.set(name, value); |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 235 | } else { |
| 236 | warn!("Malformed line from derive_classpath: {}", line); |
| 237 | } |
| 238 | } |
| 239 | |
| 240 | Ok(()) |
| 241 | } |
| 242 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 243 | fn spawn_jailed_task(executable: &Path, args: &[String], env_vars: &[String]) -> Result<Minijail> { |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 244 | // TODO(b/185175567): Run in a more restricted sandbox. |
| 245 | let jail = Minijail::new()?; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 246 | let keep_fds = []; |
| 247 | let command = minijail::Command::new_for_path(executable, &keep_fds, args, Some(env_vars))?; |
| 248 | let _pid = jail.run_command(command)?; |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 249 | Ok(jail) |
| 250 | } |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 251 | |
| 252 | struct EnvMap(HashMap<String, String>); |
| 253 | |
| 254 | impl EnvMap { |
| 255 | fn from_current_env() -> Self { |
| 256 | Self(env::vars().collect()) |
| 257 | } |
| 258 | |
| 259 | fn set(&mut self, key: &str, value: &str) { |
| 260 | self.0.insert(key.to_owned(), value.to_owned()); |
| 261 | } |
| 262 | |
| 263 | fn into_env(self) -> Vec<String> { |
| 264 | // execve() expects an array of "k=v" strings, rather than a list of (k, v) pairs. |
| 265 | self.0.into_iter().map(|(k, v)| k + "=" + &v).collect() |
| 266 | } |
| 267 | } |