blob: 10c584871ec950d9321fb318c43a660d5ad54b9a [file] [log] [blame]
Ady Abrahamb0dbdaa2020-01-06 16:19:42 -08001/*
2 * Copyright 2019 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
ramindani0491e642023-11-16 17:42:14 -080017#include <common/test/FlagUtils.h>
Leon Scroggins III67388622023-02-06 20:36:20 -050018#include <ftl/fake_guard.h>
Ana Krulec0c8cd522018-08-31 12:27:28 -070019#include <gmock/gmock.h>
20#include <gtest/gtest.h>
Ana Krulec0c8cd522018-08-31 12:27:28 -070021#include <log/log.h>
22
Ana Krulece588e312018-09-18 12:32:24 -070023#include <mutex>
24
Ana Krulec0c8cd522018-08-31 12:27:28 -070025#include "Scheduler/EventThread.h"
Dominik Laskowskid82e0f02022-10-26 15:23:04 -040026#include "Scheduler/RefreshRateSelector.h"
ramindani0491e642023-11-16 17:42:14 -080027#include "Scheduler/VSyncPredictor.h"
Dominik Laskowski98041832019-08-01 18:35:59 -070028#include "TestableScheduler.h"
Dominik Laskowski983f2b52020-06-25 16:54:06 -070029#include "TestableSurfaceFlinger.h"
Dominik Laskowskib0054a22022-03-03 09:03:06 -080030#include "mock/DisplayHardware/MockDisplayMode.h"
Ana Krulec0c8cd522018-08-31 12:27:28 -070031#include "mock/MockEventThread.h"
Dominik Laskowski983f2b52020-06-25 16:54:06 -070032#include "mock/MockLayer.h"
Dominik Laskowski8b01cc02020-07-14 19:02:41 -070033#include "mock/MockSchedulerCallback.h"
Ana Krulec0c8cd522018-08-31 12:27:28 -070034
Ady Abraham822ecbd2023-07-07 16:16:09 -070035#include <FrontEnd/LayerHierarchy.h>
36
ramindani0491e642023-11-16 17:42:14 -080037#include <com_android_graphics_surfaceflinger_flags.h>
Ady Abraham822ecbd2023-07-07 16:16:09 -070038#include "FpsOps.h"
39
ramindani0491e642023-11-16 17:42:14 -080040using namespace com::android::graphics::surfaceflinger;
41
Dominik Laskowski068173d2021-08-11 17:22:59 -070042namespace android::scheduler {
43
Dominik Laskowskib0054a22022-03-03 09:03:06 -080044using android::mock::createDisplayMode;
ramindani0491e642023-11-16 17:42:14 -080045using android::mock::createVrrDisplayMode;
Dominik Laskowskib0054a22022-03-03 09:03:06 -080046
Ana Krulec0c8cd522018-08-31 12:27:28 -070047using testing::_;
48using testing::Return;
49
Dominik Laskowski8b01cc02020-07-14 19:02:41 -070050namespace {
Ana Krulec0c8cd522018-08-31 12:27:28 -070051
Dominik Laskowski068173d2021-08-11 17:22:59 -070052using MockEventThread = android::mock::EventThread;
53using MockLayer = android::mock::MockLayer;
54
Ady Abraham822ecbd2023-07-07 16:16:09 -070055using LayerHierarchy = surfaceflinger::frontend::LayerHierarchy;
56using LayerHierarchyBuilder = surfaceflinger::frontend::LayerHierarchyBuilder;
57using RequestedLayerState = surfaceflinger::frontend::RequestedLayerState;
58
Ana Krulec0c8cd522018-08-31 12:27:28 -070059class SchedulerTest : public testing::Test {
60protected:
Ana Krulec85c39af2018-12-26 17:29:57 -080061 class MockEventThreadConnection : public android::EventThreadConnection {
Ana Krulec0c8cd522018-08-31 12:27:28 -070062 public:
Ana Krulec85c39af2018-12-26 17:29:57 -080063 explicit MockEventThreadConnection(EventThread* eventThread)
Ady Abrahamf2851612023-09-25 17:19:00 -070064 : EventThreadConnection(eventThread, /*callingUid*/ static_cast<uid_t>(0)) {}
Ana Krulec0c8cd522018-08-31 12:27:28 -070065 ~MockEventThreadConnection() = default;
66
Huihong Luo6fac5232021-11-22 16:05:23 -080067 MOCK_METHOD1(stealReceiveChannel, binder::Status(gui::BitTube* outChannel));
68 MOCK_METHOD1(setVsyncRate, binder::Status(int count));
69 MOCK_METHOD0(requestNextVsync, binder::Status());
Ana Krulec0c8cd522018-08-31 12:27:28 -070070 };
71
Ana Krulec0c8cd522018-08-31 12:27:28 -070072 SchedulerTest();
Ana Krulec0c8cd522018-08-31 12:27:28 -070073
Dominik Laskowski530d6bd2022-10-10 16:55:54 -040074 static constexpr PhysicalDisplayId kDisplayId1 = PhysicalDisplayId::fromPort(255u);
Ady Abrahamace3d052022-11-17 16:25:05 -080075 static inline const ftl::NonNull<DisplayModePtr> kDisplay1Mode60 =
76 ftl::as_non_null(createDisplayMode(kDisplayId1, DisplayModeId(0), 60_Hz));
77 static inline const ftl::NonNull<DisplayModePtr> kDisplay1Mode120 =
78 ftl::as_non_null(createDisplayMode(kDisplayId1, DisplayModeId(1), 120_Hz));
Dominik Laskowski530d6bd2022-10-10 16:55:54 -040079 static inline const DisplayModes kDisplay1Modes = makeModes(kDisplay1Mode60, kDisplay1Mode120);
80
81 static constexpr PhysicalDisplayId kDisplayId2 = PhysicalDisplayId::fromPort(254u);
Ady Abrahamace3d052022-11-17 16:25:05 -080082 static inline const ftl::NonNull<DisplayModePtr> kDisplay2Mode60 =
83 ftl::as_non_null(createDisplayMode(kDisplayId2, DisplayModeId(0), 60_Hz));
84 static inline const ftl::NonNull<DisplayModePtr> kDisplay2Mode120 =
85 ftl::as_non_null(createDisplayMode(kDisplayId2, DisplayModeId(1), 120_Hz));
Dominik Laskowski530d6bd2022-10-10 16:55:54 -040086 static inline const DisplayModes kDisplay2Modes = makeModes(kDisplay2Mode60, kDisplay2Mode120);
87
88 static constexpr PhysicalDisplayId kDisplayId3 = PhysicalDisplayId::fromPort(253u);
Ady Abrahamace3d052022-11-17 16:25:05 -080089 static inline const ftl::NonNull<DisplayModePtr> kDisplay3Mode60 =
90 ftl::as_non_null(createDisplayMode(kDisplayId3, DisplayModeId(0), 60_Hz));
Dominik Laskowski530d6bd2022-10-10 16:55:54 -040091 static inline const DisplayModes kDisplay3Modes = makeModes(kDisplay3Mode60);
Marin Shalamanov2cde1002021-06-08 19:50:10 +020092
Dominik Laskowskid82e0f02022-10-26 15:23:04 -040093 std::shared_ptr<RefreshRateSelector> mSelector =
94 std::make_shared<RefreshRateSelector>(makeModes(kDisplay1Mode60),
95 kDisplay1Mode60->getId());
Dominik Laskowski983f2b52020-06-25 16:54:06 -070096
Dominik Laskowski8b01cc02020-07-14 19:02:41 -070097 mock::SchedulerCallback mSchedulerCallback;
Leon Scroggins III823d4ca2023-12-12 16:57:34 -050098 TestableSurfaceFlinger mFlinger;
ramindaniae645822024-01-11 10:57:29 -080099 TestableScheduler* mScheduler = new TestableScheduler{mSelector, mFlinger, mSchedulerCallback};
Vishnu Naira0292282023-12-16 14:32:00 -0800100 surfaceflinger::frontend::LayerHierarchyBuilder mLayerHierarchyBuilder;
Dominik Laskowski98041832019-08-01 18:35:59 -0700101
Dominik Laskowski068173d2021-08-11 17:22:59 -0700102 ConnectionHandle mConnectionHandle;
103 MockEventThread* mEventThread;
Ana Krulec0c8cd522018-08-31 12:27:28 -0700104 sp<MockEventThreadConnection> mEventThreadConnection;
Ana Krulec0c8cd522018-08-31 12:27:28 -0700105};
106
107SchedulerTest::SchedulerTest() {
Dominik Laskowski068173d2021-08-11 17:22:59 -0700108 auto eventThread = std::make_unique<MockEventThread>();
Ana Krulec0c8cd522018-08-31 12:27:28 -0700109 mEventThread = eventThread.get();
Ana Krulec85c39af2018-12-26 17:29:57 -0800110 EXPECT_CALL(*mEventThread, registerDisplayEventConnection(_)).WillOnce(Return(0));
111
Ady Abrahamd11bade2022-08-01 16:18:03 -0700112 mEventThreadConnection = sp<MockEventThreadConnection>::make(mEventThread);
Ana Krulec0c8cd522018-08-31 12:27:28 -0700113
114 // createConnection call to scheduler makes a createEventConnection call to EventThread. Make
115 // sure that call gets executed and returns an EventThread::Connection object.
Ady Abraham0f4a1b12019-06-04 16:04:04 -0700116 EXPECT_CALL(*mEventThread, createEventConnection(_, _))
Ana Krulec0c8cd522018-08-31 12:27:28 -0700117 .WillRepeatedly(Return(mEventThreadConnection));
118
Ady Abrahama0a16272021-03-03 15:23:35 -0800119 mConnectionHandle = mScheduler->createConnection(std::move(eventThread));
Dominik Laskowski98041832019-08-01 18:35:59 -0700120 EXPECT_TRUE(mConnectionHandle);
Ady Abrahama0a16272021-03-03 15:23:35 -0800121
122 mFlinger.resetScheduler(mScheduler);
Ana Krulec0c8cd522018-08-31 12:27:28 -0700123}
124
Dominik Laskowski8b01cc02020-07-14 19:02:41 -0700125} // namespace
Ana Krulec0c8cd522018-08-31 12:27:28 -0700126
Ana Krulec0c8cd522018-08-31 12:27:28 -0700127TEST_F(SchedulerTest, invalidConnectionHandle) {
Dominik Laskowski068173d2021-08-11 17:22:59 -0700128 ConnectionHandle handle;
Ana Krulec0c8cd522018-08-31 12:27:28 -0700129
Ady Abrahama0a16272021-03-03 15:23:35 -0800130 const sp<IDisplayEventConnection> connection = mScheduler->createDisplayEventConnection(handle);
Dominik Laskowski983f2b52020-06-25 16:54:06 -0700131
Dominik Laskowski98041832019-08-01 18:35:59 -0700132 EXPECT_FALSE(connection);
Ady Abrahama0a16272021-03-03 15:23:35 -0800133 EXPECT_FALSE(mScheduler->getEventConnection(handle));
Ana Krulec0c8cd522018-08-31 12:27:28 -0700134
135 // The EXPECT_CALLS make sure we don't call the functions on the subsequent event threads.
136 EXPECT_CALL(*mEventThread, onHotplugReceived(_, _)).Times(0);
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400137 mScheduler->onHotplugReceived(handle, kDisplayId1, false);
Ana Krulec0c8cd522018-08-31 12:27:28 -0700138
Dominik Laskowski98041832019-08-01 18:35:59 -0700139 std::string output;
Ana Krulec0c8cd522018-08-31 12:27:28 -0700140 EXPECT_CALL(*mEventThread, dump(_)).Times(0);
Ady Abrahama0a16272021-03-03 15:23:35 -0800141 mScheduler->dump(handle, output);
Dominik Laskowski98041832019-08-01 18:35:59 -0700142 EXPECT_TRUE(output.empty());
Ana Krulec0c8cd522018-08-31 12:27:28 -0700143
Ady Abraham9c53ee72020-07-22 21:16:18 -0700144 EXPECT_CALL(*mEventThread, setDuration(10ns, 20ns)).Times(0);
Ady Abrahama0a16272021-03-03 15:23:35 -0800145 mScheduler->setDuration(handle, 10ns, 20ns);
Ana Krulec0c8cd522018-08-31 12:27:28 -0700146}
147
148TEST_F(SchedulerTest, validConnectionHandle) {
Dominik Laskowski983f2b52020-06-25 16:54:06 -0700149 const sp<IDisplayEventConnection> connection =
Ady Abrahama0a16272021-03-03 15:23:35 -0800150 mScheduler->createDisplayEventConnection(mConnectionHandle);
Dominik Laskowski983f2b52020-06-25 16:54:06 -0700151
Dominik Laskowski98041832019-08-01 18:35:59 -0700152 ASSERT_EQ(mEventThreadConnection, connection);
Ady Abrahama0a16272021-03-03 15:23:35 -0800153 EXPECT_TRUE(mScheduler->getEventConnection(mConnectionHandle));
Ana Krulec0c8cd522018-08-31 12:27:28 -0700154
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400155 EXPECT_CALL(*mEventThread, onHotplugReceived(kDisplayId1, false)).Times(1);
156 mScheduler->onHotplugReceived(mConnectionHandle, kDisplayId1, false);
Ana Krulec0c8cd522018-08-31 12:27:28 -0700157
Dominik Laskowski98041832019-08-01 18:35:59 -0700158 std::string output("dump");
159 EXPECT_CALL(*mEventThread, dump(output)).Times(1);
Ady Abrahama0a16272021-03-03 15:23:35 -0800160 mScheduler->dump(mConnectionHandle, output);
Dominik Laskowski98041832019-08-01 18:35:59 -0700161 EXPECT_FALSE(output.empty());
Ana Krulec0c8cd522018-08-31 12:27:28 -0700162
Ady Abraham9c53ee72020-07-22 21:16:18 -0700163 EXPECT_CALL(*mEventThread, setDuration(10ns, 20ns)).Times(1);
Ady Abrahama0a16272021-03-03 15:23:35 -0800164 mScheduler->setDuration(mConnectionHandle, 10ns, 20ns);
Ana Krulec0c8cd522018-08-31 12:27:28 -0700165}
Dominik Laskowski98041832019-08-01 18:35:59 -0700166
Dominik Laskowski66295432023-03-14 12:25:36 -0400167TEST_F(SchedulerTest, registerDisplay) FTL_FAKE_GUARD(kMainThreadContext) {
Dominik Laskowski008bec02023-03-14 12:04:58 -0400168 // Hardware VSYNC should not change if the display is already registered.
Dominik Laskowski66295432023-03-14 12:25:36 -0400169 EXPECT_CALL(mSchedulerCallback, requestHardwareVsync(kDisplayId1, false)).Times(0);
Dominik Laskowski008bec02023-03-14 12:04:58 -0400170 mScheduler->registerDisplay(kDisplayId1,
171 std::make_shared<RefreshRateSelector>(kDisplay1Modes,
172 kDisplay1Mode60->getId()));
173
Dominik Laskowski66295432023-03-14 12:25:36 -0400174 // TODO(b/241285191): Restore once VsyncSchedule::getPendingHardwareVsyncState is called by
175 // Scheduler::setDisplayPowerMode rather than SF::setPowerModeInternal.
176#if 0
Dominik Laskowski008bec02023-03-14 12:04:58 -0400177 // Hardware VSYNC should be disabled for newly registered displays.
Dominik Laskowski66295432023-03-14 12:25:36 -0400178 EXPECT_CALL(mSchedulerCallback, requestHardwareVsync(kDisplayId2, false)).Times(1);
179 EXPECT_CALL(mSchedulerCallback, requestHardwareVsync(kDisplayId3, false)).Times(1);
180#endif
Dominik Laskowski008bec02023-03-14 12:04:58 -0400181
182 mScheduler->registerDisplay(kDisplayId2,
183 std::make_shared<RefreshRateSelector>(kDisplay2Modes,
184 kDisplay2Mode60->getId()));
185 mScheduler->registerDisplay(kDisplayId3,
186 std::make_shared<RefreshRateSelector>(kDisplay3Modes,
187 kDisplay3Mode60->getId()));
Dominik Laskowski66295432023-03-14 12:25:36 -0400188
189 EXPECT_FALSE(mScheduler->getVsyncSchedule(kDisplayId1)->getPendingHardwareVsyncState());
190 EXPECT_FALSE(mScheduler->getVsyncSchedule(kDisplayId2)->getPendingHardwareVsyncState());
191 EXPECT_FALSE(mScheduler->getVsyncSchedule(kDisplayId3)->getPendingHardwareVsyncState());
Dominik Laskowski008bec02023-03-14 12:04:58 -0400192}
193
Marin Shalamanov2cde1002021-06-08 19:50:10 +0200194TEST_F(SchedulerTest, chooseRefreshRateForContentIsNoopWhenModeSwitchingIsNotSupported) {
195 // The layer is registered at creation time and deregistered at destruction time.
Dominik Laskowski068173d2021-08-11 17:22:59 -0700196 sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
Dominik Laskowski983f2b52020-06-25 16:54:06 -0700197
Marin Shalamanov2cde1002021-06-08 19:50:10 +0200198 // recordLayerHistory should be a noop
Dominik Laskowski9c93d602021-10-07 19:38:26 -0700199 ASSERT_EQ(0u, mScheduler->getNumActiveLayers());
Vishnu Nair47b7bb42023-09-29 16:27:33 -0700200 mScheduler->recordLayerHistory(layer->getSequence(), layer->getLayerProps(), 0, 0,
Vishnu Nairef68d6d2023-02-28 06:18:27 +0000201 LayerHistory::LayerUpdateType::Buffer);
Dominik Laskowski9c93d602021-10-07 19:38:26 -0700202 ASSERT_EQ(0u, mScheduler->getNumActiveLayers());
Dominik Laskowski983f2b52020-06-25 16:54:06 -0700203
Rachel Lee6a9731d2022-06-06 17:08:14 -0700204 constexpr hal::PowerMode kPowerModeOn = hal::PowerMode::ON;
Leon Scroggins III67388622023-02-06 20:36:20 -0500205 FTL_FAKE_GUARD(kMainThreadContext, mScheduler->setDisplayPowerMode(kDisplayId1, kPowerModeOn));
Dominik Laskowski983f2b52020-06-25 16:54:06 -0700206
207 constexpr uint32_t kDisplayArea = 999'999;
Ady Abrahamed3290f2021-05-17 15:12:14 -0700208 mScheduler->onActiveDisplayAreaChanged(kDisplayArea);
Dominik Laskowski983f2b52020-06-25 16:54:06 -0700209
ramindani69b58e82022-09-26 16:48:36 -0700210 EXPECT_CALL(mSchedulerCallback, requestDisplayModes(_)).Times(0);
Ady Abraham822ecbd2023-07-07 16:16:09 -0700211 mScheduler->chooseRefreshRateForContent(/*LayerHierarchy*/ nullptr,
212 /*updateAttachedChoreographer*/ false);
Dominik Laskowski983f2b52020-06-25 16:54:06 -0700213}
214
Marin Shalamanov2cde1002021-06-08 19:50:10 +0200215TEST_F(SchedulerTest, updateDisplayModes) {
Dominik Laskowski9c93d602021-10-07 19:38:26 -0700216 ASSERT_EQ(0u, mScheduler->layerHistorySize());
Dominik Laskowski068173d2021-08-11 17:22:59 -0700217 sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
Dominik Laskowski9c93d602021-10-07 19:38:26 -0700218 ASSERT_EQ(1u, mScheduler->layerHistorySize());
Marin Shalamanov2cde1002021-06-08 19:50:10 +0200219
Dominik Laskowski596a2562022-10-28 11:26:12 -0400220 // Replace `mSelector` with a new `RefreshRateSelector` that has different display modes.
221 mScheduler->registerDisplay(kDisplayId1,
222 std::make_shared<RefreshRateSelector>(kDisplay1Modes,
223 kDisplay1Mode60->getId()));
Marin Shalamanov2cde1002021-06-08 19:50:10 +0200224
Dominik Laskowski9c93d602021-10-07 19:38:26 -0700225 ASSERT_EQ(0u, mScheduler->getNumActiveLayers());
Vishnu Nair47b7bb42023-09-29 16:27:33 -0700226 mScheduler->recordLayerHistory(layer->getSequence(), layer->getLayerProps(), 0, 0,
Vishnu Nairef68d6d2023-02-28 06:18:27 +0000227 LayerHistory::LayerUpdateType::Buffer);
Dominik Laskowski9c93d602021-10-07 19:38:26 -0700228 ASSERT_EQ(1u, mScheduler->getNumActiveLayers());
Marin Shalamanov2cde1002021-06-08 19:50:10 +0200229}
230
Dominik Laskowski068173d2021-08-11 17:22:59 -0700231TEST_F(SchedulerTest, dispatchCachedReportedMode) {
232 mScheduler->clearCachedReportedMode();
233
Ady Abraham690f4612021-07-01 23:24:03 -0700234 EXPECT_CALL(*mEventThread, onModeChanged(_)).Times(0);
Dominik Laskowski068173d2021-08-11 17:22:59 -0700235 EXPECT_NO_FATAL_FAILURE(mScheduler->dispatchCachedReportedMode());
Ana Krulec6ddd2612020-09-24 13:06:33 -0700236}
237
Marin Shalamanova7fe3042021-01-29 21:02:08 +0100238TEST_F(SchedulerTest, onNonPrimaryDisplayModeChanged_invalidParameters) {
Ady Abraham690f4612021-07-01 23:24:03 -0700239 const auto mode = DisplayMode::Builder(hal::HWConfigId(0))
240 .setId(DisplayModeId(111))
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400241 .setPhysicalDisplayId(kDisplayId1)
Ady Abraham690f4612021-07-01 23:24:03 -0700242 .setVsyncPeriod(111111)
243 .build();
Ana Krulec6ddd2612020-09-24 13:06:33 -0700244
245 // If the handle is incorrect, the function should return before
Marin Shalamanova7fe3042021-01-29 21:02:08 +0100246 // onModeChange is called.
Dominik Laskowski068173d2021-08-11 17:22:59 -0700247 ConnectionHandle invalidHandle = {.id = 123};
Ady Abrahamace3d052022-11-17 16:25:05 -0800248 EXPECT_NO_FATAL_FAILURE(
249 mScheduler->onNonPrimaryDisplayModeChanged(invalidHandle,
250 {90_Hz, ftl::as_non_null(mode)}));
Ady Abraham690f4612021-07-01 23:24:03 -0700251 EXPECT_CALL(*mEventThread, onModeChanged(_)).Times(0);
Ana Krulec6ddd2612020-09-24 13:06:33 -0700252}
253
Ady Abraham899dcdb2021-06-15 16:56:21 -0700254TEST_F(SchedulerTest, calculateMaxAcquiredBufferCount) {
Dominik Laskowski6eab42d2021-09-13 14:34:13 -0700255 EXPECT_EQ(1, mFlinger.calculateMaxAcquiredBufferCount(60_Hz, 30ms));
256 EXPECT_EQ(2, mFlinger.calculateMaxAcquiredBufferCount(90_Hz, 30ms));
257 EXPECT_EQ(3, mFlinger.calculateMaxAcquiredBufferCount(120_Hz, 30ms));
Ady Abraham564f9de2021-02-03 18:34:33 -0800258
Dominik Laskowski6eab42d2021-09-13 14:34:13 -0700259 EXPECT_EQ(2, mFlinger.calculateMaxAcquiredBufferCount(60_Hz, 40ms));
Ady Abraham564f9de2021-02-03 18:34:33 -0800260
Dominik Laskowski6eab42d2021-09-13 14:34:13 -0700261 EXPECT_EQ(1, mFlinger.calculateMaxAcquiredBufferCount(60_Hz, 10ms));
Lloyd Piquea1456c12023-05-17 12:11:15 -0700262
Lloyd Pique30db6402023-06-26 18:56:51 +0000263 const auto savedMinAcquiredBuffers = mFlinger.mutableMinAcquiredBuffers();
264 mFlinger.mutableMinAcquiredBuffers() = 2;
Lloyd Piquea1456c12023-05-17 12:11:15 -0700265 EXPECT_EQ(2, mFlinger.calculateMaxAcquiredBufferCount(60_Hz, 10ms));
Lloyd Pique30db6402023-06-26 18:56:51 +0000266 mFlinger.mutableMinAcquiredBuffers() = savedMinAcquiredBuffers;
Ady Abraham564f9de2021-02-03 18:34:33 -0800267}
268
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200269MATCHER(Is120Hz, "") {
Ady Abrahamace3d052022-11-17 16:25:05 -0800270 return isApproxEqual(arg.front().mode.fps, 120_Hz);
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200271}
272
273TEST_F(SchedulerTest, chooseRefreshRateForContentSelectsMaxRefreshRate) {
Dominik Laskowski596a2562022-10-28 11:26:12 -0400274 mScheduler->registerDisplay(kDisplayId1,
275 std::make_shared<RefreshRateSelector>(kDisplay1Modes,
276 kDisplay1Mode60->getId()));
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200277
Dominik Laskowski0c41ffa2021-12-24 16:45:12 -0800278 const sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
279 EXPECT_CALL(*layer, isVisible()).WillOnce(Return(true));
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200280
Vishnu Nair47b7bb42023-09-29 16:27:33 -0700281 mScheduler->recordLayerHistory(layer->getSequence(), layer->getLayerProps(), 0, systemTime(),
Vishnu Nairef68d6d2023-02-28 06:18:27 +0000282 LayerHistory::LayerUpdateType::Buffer);
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200283
Rachel Lee6a9731d2022-06-06 17:08:14 -0700284 constexpr hal::PowerMode kPowerModeOn = hal::PowerMode::ON;
Leon Scroggins III67388622023-02-06 20:36:20 -0500285 FTL_FAKE_GUARD(kMainThreadContext, mScheduler->setDisplayPowerMode(kDisplayId1, kPowerModeOn));
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200286
287 constexpr uint32_t kDisplayArea = 999'999;
Ady Abrahamed3290f2021-05-17 15:12:14 -0700288 mScheduler->onActiveDisplayAreaChanged(kDisplayArea);
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200289
ramindani69b58e82022-09-26 16:48:36 -0700290 EXPECT_CALL(mSchedulerCallback, requestDisplayModes(Is120Hz())).Times(1);
Ady Abraham822ecbd2023-07-07 16:16:09 -0700291 mScheduler->chooseRefreshRateForContent(/*LayerHierarchy*/ nullptr,
292 /*updateAttachedChoreographer*/ false);
Dominik Laskowski0c41ffa2021-12-24 16:45:12 -0800293
294 // No-op if layer requirements have not changed.
ramindani69b58e82022-09-26 16:48:36 -0700295 EXPECT_CALL(mSchedulerCallback, requestDisplayModes(_)).Times(0);
Ady Abraham822ecbd2023-07-07 16:16:09 -0700296 mScheduler->chooseRefreshRateForContent(/*LayerHierarchy*/ nullptr,
297 /*updateAttachedChoreographer*/ false);
Marin Shalamanov4c7831e2021-06-08 20:44:06 +0200298}
299
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400300TEST_F(SchedulerTest, chooseDisplayModesSingleDisplay) {
Dominik Laskowskib5a094b2022-10-27 12:00:12 -0400301 mScheduler->registerDisplay(kDisplayId1,
302 std::make_shared<RefreshRateSelector>(kDisplay1Modes,
303 kDisplay1Mode60->getId()));
ramindani69b58e82022-09-26 16:48:36 -0700304
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400305 std::vector<RefreshRateSelector::LayerRequirement> layers =
306 std::vector<RefreshRateSelector::LayerRequirement>({{.weight = 1.f}, {.weight = 1.f}});
ramindani69b58e82022-09-26 16:48:36 -0700307 mScheduler->setContentRequirements(layers);
308 GlobalSignals globalSignals = {.idle = true};
309 mScheduler->setTouchStateAndIdleTimerPolicy(globalSignals);
310
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400311 using DisplayModeChoice = TestableScheduler::DisplayModeChoice;
312
313 auto modeChoices = mScheduler->chooseDisplayModes();
314 ASSERT_EQ(1u, modeChoices.size());
315
316 auto choice = modeChoices.get(kDisplayId1);
317 ASSERT_TRUE(choice);
Ady Abrahamace3d052022-11-17 16:25:05 -0800318 EXPECT_EQ(choice->get(), DisplayModeChoice({60_Hz, kDisplay1Mode60}, globalSignals));
ramindani69b58e82022-09-26 16:48:36 -0700319
320 globalSignals = {.idle = false};
321 mScheduler->setTouchStateAndIdleTimerPolicy(globalSignals);
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400322
323 modeChoices = mScheduler->chooseDisplayModes();
324 ASSERT_EQ(1u, modeChoices.size());
325
326 choice = modeChoices.get(kDisplayId1);
327 ASSERT_TRUE(choice);
Ady Abrahamace3d052022-11-17 16:25:05 -0800328 EXPECT_EQ(choice->get(), DisplayModeChoice({120_Hz, kDisplay1Mode120}, globalSignals));
ramindani69b58e82022-09-26 16:48:36 -0700329
330 globalSignals = {.touch = true};
331 mScheduler->replaceTouchTimer(10);
332 mScheduler->setTouchStateAndIdleTimerPolicy(globalSignals);
ramindani69b58e82022-09-26 16:48:36 -0700333
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400334 modeChoices = mScheduler->chooseDisplayModes();
335 ASSERT_EQ(1u, modeChoices.size());
336
337 choice = modeChoices.get(kDisplayId1);
338 ASSERT_TRUE(choice);
Ady Abrahamace3d052022-11-17 16:25:05 -0800339 EXPECT_EQ(choice->get(), DisplayModeChoice({120_Hz, kDisplay1Mode120}, globalSignals));
ramindani69b58e82022-09-26 16:48:36 -0700340}
341
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400342TEST_F(SchedulerTest, chooseDisplayModesMultipleDisplays) {
Dominik Laskowskib5a094b2022-10-27 12:00:12 -0400343 mScheduler->registerDisplay(kDisplayId1,
344 std::make_shared<RefreshRateSelector>(kDisplay1Modes,
345 kDisplay1Mode60->getId()));
346 mScheduler->registerDisplay(kDisplayId2,
347 std::make_shared<RefreshRateSelector>(kDisplay2Modes,
348 kDisplay2Mode60->getId()));
ramindani69b58e82022-09-26 16:48:36 -0700349
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400350 using DisplayModeChoice = TestableScheduler::DisplayModeChoice;
351 TestableScheduler::DisplayModeChoiceMap expectedChoices;
ramindani69b58e82022-09-26 16:48:36 -0700352
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400353 {
354 const GlobalSignals globalSignals = {.idle = true};
355 expectedChoices =
356 ftl::init::map<const PhysicalDisplayId&,
Ady Abrahamace3d052022-11-17 16:25:05 -0800357 DisplayModeChoice>(kDisplayId1,
358 FrameRateMode{60_Hz, kDisplay1Mode60},
359 globalSignals)(kDisplayId2,
360 FrameRateMode{60_Hz,
361 kDisplay2Mode60},
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400362 globalSignals);
363
Dominik Laskowskid82e0f02022-10-26 15:23:04 -0400364 std::vector<RefreshRateSelector::LayerRequirement> layers = {{.weight = 1.f},
365 {.weight = 1.f}};
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400366 mScheduler->setContentRequirements(layers);
367 mScheduler->setTouchStateAndIdleTimerPolicy(globalSignals);
368
369 const auto actualChoices = mScheduler->chooseDisplayModes();
370 EXPECT_EQ(expectedChoices, actualChoices);
ramindani69b58e82022-09-26 16:48:36 -0700371 }
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400372 {
373 const GlobalSignals globalSignals = {.idle = false};
374 expectedChoices =
375 ftl::init::map<const PhysicalDisplayId&,
Ady Abrahamace3d052022-11-17 16:25:05 -0800376 DisplayModeChoice>(kDisplayId1,
377 FrameRateMode{120_Hz, kDisplay1Mode120},
378 globalSignals)(kDisplayId2,
379 FrameRateMode{120_Hz,
380 kDisplay2Mode120},
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400381 globalSignals);
ramindani69b58e82022-09-26 16:48:36 -0700382
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400383 mScheduler->setTouchStateAndIdleTimerPolicy(globalSignals);
ramindani69b58e82022-09-26 16:48:36 -0700384
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400385 const auto actualChoices = mScheduler->chooseDisplayModes();
386 EXPECT_EQ(expectedChoices, actualChoices);
ramindani69b58e82022-09-26 16:48:36 -0700387 }
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400388 {
389 const GlobalSignals globalSignals = {.touch = true};
390 mScheduler->replaceTouchTimer(10);
391 mScheduler->setTouchStateAndIdleTimerPolicy(globalSignals);
ramindani69b58e82022-09-26 16:48:36 -0700392
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400393 expectedChoices =
394 ftl::init::map<const PhysicalDisplayId&,
Ady Abrahamace3d052022-11-17 16:25:05 -0800395 DisplayModeChoice>(kDisplayId1,
396 FrameRateMode{120_Hz, kDisplay1Mode120},
397 globalSignals)(kDisplayId2,
398 FrameRateMode{120_Hz,
399 kDisplay2Mode120},
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400400 globalSignals);
401
402 const auto actualChoices = mScheduler->chooseDisplayModes();
403 EXPECT_EQ(expectedChoices, actualChoices);
ramindani69b58e82022-09-26 16:48:36 -0700404 }
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400405 {
ramindani22f2ead2023-04-21 10:27:11 -0700406 // The kDisplayId3 does not support 120Hz, The pacesetter display rate is chosen to be 120
407 // Hz. In this case only the display kDisplayId3 choose 60Hz as it does not support 120Hz.
Dominik Laskowskib5a094b2022-10-27 12:00:12 -0400408 mScheduler
409 ->registerDisplay(kDisplayId3,
410 std::make_shared<RefreshRateSelector>(kDisplay3Modes,
411 kDisplay3Mode60->getId()));
Dominik Laskowski327d6092022-10-11 18:05:08 -0400412
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400413 const GlobalSignals globalSignals = {.touch = true};
414 mScheduler->replaceTouchTimer(10);
415 mScheduler->setTouchStateAndIdleTimerPolicy(globalSignals);
ramindani7c487282022-10-10 16:17:51 -0700416
Ady Abrahamace3d052022-11-17 16:25:05 -0800417 expectedChoices = ftl::init::map<
418 const PhysicalDisplayId&,
ramindani22f2ead2023-04-21 10:27:11 -0700419 DisplayModeChoice>(kDisplayId1, FrameRateMode{120_Hz, kDisplay1Mode120},
420 globalSignals)(kDisplayId2,
421 FrameRateMode{120_Hz, kDisplay2Mode120},
422 globalSignals)(kDisplayId3,
423 FrameRateMode{60_Hz,
424 kDisplay3Mode60},
425 globalSignals);
426
427 const auto actualChoices = mScheduler->chooseDisplayModes();
428 EXPECT_EQ(expectedChoices, actualChoices);
429 }
430 {
431 // We should choose 60Hz despite the touch signal as pacesetter only supports 60Hz
432 mScheduler->setPacesetterDisplay(kDisplayId3);
433 const GlobalSignals globalSignals = {.touch = true};
434 mScheduler->replaceTouchTimer(10);
435 mScheduler->setTouchStateAndIdleTimerPolicy(globalSignals);
436
437 expectedChoices = ftl::init::map<
438 const PhysicalDisplayId&,
Ady Abrahamace3d052022-11-17 16:25:05 -0800439 DisplayModeChoice>(kDisplayId1, FrameRateMode{60_Hz, kDisplay1Mode60},
440 globalSignals)(kDisplayId2,
441 FrameRateMode{60_Hz, kDisplay2Mode60},
442 globalSignals)(kDisplayId3,
443 FrameRateMode{60_Hz,
444 kDisplay3Mode60},
445 globalSignals);
Dominik Laskowski530d6bd2022-10-10 16:55:54 -0400446
447 const auto actualChoices = mScheduler->chooseDisplayModes();
448 EXPECT_EQ(expectedChoices, actualChoices);
ramindani7c487282022-10-10 16:17:51 -0700449 }
ramindani69b58e82022-09-26 16:48:36 -0700450}
451
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400452TEST_F(SchedulerTest, onFrameSignalMultipleDisplays) {
453 mScheduler->registerDisplay(kDisplayId1,
454 std::make_shared<RefreshRateSelector>(kDisplay1Modes,
455 kDisplay1Mode60->getId()));
456 mScheduler->registerDisplay(kDisplayId2,
457 std::make_shared<RefreshRateSelector>(kDisplay2Modes,
458 kDisplay2Mode60->getId()));
459
460 using VsyncIds = std::vector<std::pair<PhysicalDisplayId, VsyncId>>;
461
462 struct Compositor final : ICompositor {
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500463 explicit Compositor(TestableScheduler& scheduler) : scheduler(scheduler) {}
464
465 TestableScheduler& scheduler;
466
467 struct {
468 PhysicalDisplayId commit;
469 PhysicalDisplayId composite;
470 } pacesetterIds;
471
472 struct {
473 VsyncIds commit;
474 VsyncIds composite;
475 } vsyncIds;
476
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400477 bool committed = true;
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500478 bool changePacesetter = false;
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400479
480 void configure() override {}
481
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500482 bool commit(PhysicalDisplayId pacesetterId,
483 const scheduler::FrameTargets& targets) override {
484 pacesetterIds.commit = pacesetterId;
485
486 vsyncIds.commit.clear();
487 vsyncIds.composite.clear();
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400488
489 for (const auto& [id, target] : targets) {
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500490 vsyncIds.commit.emplace_back(id, target->vsyncId());
491 }
492
493 if (changePacesetter) {
494 scheduler.setPacesetterDisplay(kDisplayId2);
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400495 }
496
497 return committed;
498 }
499
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500500 CompositeResultsPerDisplay composite(PhysicalDisplayId pacesetterId,
501 const scheduler::FrameTargeters& targeters) override {
502 pacesetterIds.composite = pacesetterId;
503
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400504 CompositeResultsPerDisplay results;
505
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500506 for (const auto& [id, targeter] : targeters) {
507 vsyncIds.composite.emplace_back(id, targeter->target().vsyncId());
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400508 results.try_emplace(id,
509 CompositeResult{.compositionCoverage =
510 CompositionCoverage::Hwc});
511 }
512
513 return results;
514 }
515
516 void sample() override {}
ramindaniae645822024-01-11 10:57:29 -0800517 void sendNotifyExpectedPresentHint(PhysicalDisplayId) override {}
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500518 } compositor(*mScheduler);
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400519
520 mScheduler->doFrameSignal(compositor, VsyncId(42));
521
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500522 const auto makeVsyncIds = [](VsyncId vsyncId, bool swap = false) -> VsyncIds {
523 if (swap) {
524 return {{kDisplayId2, vsyncId}, {kDisplayId1, vsyncId}};
525 } else {
526 return {{kDisplayId1, vsyncId}, {kDisplayId2, vsyncId}};
527 }
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400528 };
529
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500530 EXPECT_EQ(kDisplayId1, compositor.pacesetterIds.commit);
531 EXPECT_EQ(kDisplayId1, compositor.pacesetterIds.composite);
532 EXPECT_EQ(makeVsyncIds(VsyncId(42)), compositor.vsyncIds.commit);
533 EXPECT_EQ(makeVsyncIds(VsyncId(42)), compositor.vsyncIds.composite);
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400534
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500535 // FrameTargets should be updated despite the skipped commit.
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400536 compositor.committed = false;
537 mScheduler->doFrameSignal(compositor, VsyncId(43));
538
Dominik Laskowskifb4b7372023-11-22 09:56:54 -0500539 EXPECT_EQ(kDisplayId1, compositor.pacesetterIds.commit);
540 EXPECT_EQ(kDisplayId1, compositor.pacesetterIds.composite);
541 EXPECT_EQ(makeVsyncIds(VsyncId(43)), compositor.vsyncIds.commit);
542 EXPECT_TRUE(compositor.vsyncIds.composite.empty());
543
544 // The pacesetter may change during commit.
545 compositor.committed = true;
546 compositor.changePacesetter = true;
547 mScheduler->doFrameSignal(compositor, VsyncId(44));
548
549 EXPECT_EQ(kDisplayId1, compositor.pacesetterIds.commit);
550 EXPECT_EQ(kDisplayId2, compositor.pacesetterIds.composite);
551 EXPECT_EQ(makeVsyncIds(VsyncId(44)), compositor.vsyncIds.commit);
552 EXPECT_EQ(makeVsyncIds(VsyncId(44), true), compositor.vsyncIds.composite);
Dominik Laskowski50e2e4d2023-10-04 10:58:28 -0400553}
554
ramindani0491e642023-11-16 17:42:14 -0800555TEST_F(SchedulerTest, nextFrameIntervalTest) {
556 SET_FLAG_FOR_TEST(flags::vrr_config, true);
557
558 static constexpr size_t kHistorySize = 10;
559 static constexpr size_t kMinimumSamplesForPrediction = 6;
560 static constexpr size_t kOutlierTolerancePercent = 25;
561 const auto refreshRate = Fps::fromPeriodNsecs(500);
562 auto frameRate = Fps::fromPeriodNsecs(1000);
563
564 const ftl::NonNull<DisplayModePtr> kMode = ftl::as_non_null(
565 createVrrDisplayMode(DisplayModeId(0), refreshRate,
566 hal::VrrConfig{.minFrameIntervalNs = static_cast<int32_t>(
567 frameRate.getPeriodNsecs())}));
568 std::shared_ptr<VSyncPredictor> vrrTracker =
569 std::make_shared<VSyncPredictor>(kMode, kHistorySize, kMinimumSamplesForPrediction,
ramindaniae645822024-01-11 10:57:29 -0800570 kOutlierTolerancePercent);
ramindani0491e642023-11-16 17:42:14 -0800571 std::shared_ptr<RefreshRateSelector> vrrSelectorPtr =
572 std::make_shared<RefreshRateSelector>(makeModes(kMode), kMode->getId());
573 TestableScheduler scheduler{std::make_unique<android::mock::VsyncController>(),
574 vrrTracker,
575 vrrSelectorPtr,
Leon Scroggins III823d4ca2023-12-12 16:57:34 -0500576 mFlinger.getFactory(),
577 mFlinger.getTimeStats(),
ramindaniae645822024-01-11 10:57:29 -0800578 mSchedulerCallback};
ramindani0491e642023-11-16 17:42:14 -0800579
580 scheduler.registerDisplay(kMode->getPhysicalDisplayId(), vrrSelectorPtr, vrrTracker);
581 vrrSelectorPtr->setActiveMode(kMode->getId(), frameRate);
582 scheduler.setRenderRate(kMode->getPhysicalDisplayId(), frameRate);
583 vrrTracker->addVsyncTimestamp(0);
584
ramindani0491e642023-11-16 17:42:14 -0800585 EXPECT_EQ(Fps::fromPeriodNsecs(1000),
586 scheduler.getNextFrameInterval(kMode->getPhysicalDisplayId(),
Ady Abraham4335afd2023-12-18 19:10:47 -0800587 TimePoint::fromNs(1000)));
ramindani0491e642023-11-16 17:42:14 -0800588 EXPECT_EQ(Fps::fromPeriodNsecs(1000),
589 scheduler.getNextFrameInterval(kMode->getPhysicalDisplayId(),
Ady Abraham4335afd2023-12-18 19:10:47 -0800590 TimePoint::fromNs(2000)));
ramindani0491e642023-11-16 17:42:14 -0800591
Ady Abraham4335afd2023-12-18 19:10:47 -0800592 // Not crossing the min frame period
593 EXPECT_EQ(Fps::fromPeriodNsecs(1500),
594 scheduler.getNextFrameInterval(kMode->getPhysicalDisplayId(),
595 TimePoint::fromNs(2500)));
ramindani0491e642023-11-16 17:42:14 -0800596 // Change render rate
597 frameRate = Fps::fromPeriodNsecs(2000);
598 vrrSelectorPtr->setActiveMode(kMode->getId(), frameRate);
599 scheduler.setRenderRate(kMode->getPhysicalDisplayId(), frameRate);
600
601 EXPECT_EQ(Fps::fromPeriodNsecs(2000),
602 scheduler.getNextFrameInterval(kMode->getPhysicalDisplayId(),
Ady Abraham4335afd2023-12-18 19:10:47 -0800603 TimePoint::fromNs(2000)));
ramindani0491e642023-11-16 17:42:14 -0800604 EXPECT_EQ(Fps::fromPeriodNsecs(2000),
605 scheduler.getNextFrameInterval(kMode->getPhysicalDisplayId(),
Ady Abraham4335afd2023-12-18 19:10:47 -0800606 TimePoint::fromNs(4000)));
ramindani0491e642023-11-16 17:42:14 -0800607}
608
Leon Scroggins III792ea802023-11-27 17:32:51 -0500609TEST_F(SchedulerTest, resyncAllToHardwareVsync) FTL_FAKE_GUARD(kMainThreadContext) {
610 // resyncAllToHardwareVsync will result in requesting hardware VSYNC on both displays, since
611 // they are both on.
612 EXPECT_CALL(mScheduler->mockRequestHardwareVsync, Call(kDisplayId1, true)).Times(1);
613 EXPECT_CALL(mScheduler->mockRequestHardwareVsync, Call(kDisplayId2, true)).Times(1);
614
615 mScheduler->registerDisplay(kDisplayId2,
616 std::make_shared<RefreshRateSelector>(kDisplay2Modes,
617 kDisplay2Mode60->getId()));
618 mScheduler->setDisplayPowerMode(kDisplayId1, hal::PowerMode::ON);
619 mScheduler->setDisplayPowerMode(kDisplayId2, hal::PowerMode::ON);
620
621 static constexpr bool kDisallow = true;
622 mScheduler->disableHardwareVsync(kDisplayId1, kDisallow);
623 mScheduler->disableHardwareVsync(kDisplayId2, kDisallow);
624
625 static constexpr bool kAllowToEnable = true;
626 mScheduler->resyncAllToHardwareVsync(kAllowToEnable);
627}
628
629TEST_F(SchedulerTest, resyncAllDoNotAllow) FTL_FAKE_GUARD(kMainThreadContext) {
630 // Without setting allowToEnable to true, resyncAllToHardwareVsync does not
631 // result in requesting hardware VSYNC.
632 EXPECT_CALL(mScheduler->mockRequestHardwareVsync, Call(kDisplayId1, _)).Times(0);
633
634 mScheduler->setDisplayPowerMode(kDisplayId1, hal::PowerMode::ON);
635
636 static constexpr bool kDisallow = true;
637 mScheduler->disableHardwareVsync(kDisplayId1, kDisallow);
638
639 static constexpr bool kAllowToEnable = false;
640 mScheduler->resyncAllToHardwareVsync(kAllowToEnable);
641}
642
643TEST_F(SchedulerTest, resyncAllSkipsOffDisplays) FTL_FAKE_GUARD(kMainThreadContext) {
644 SET_FLAG_FOR_TEST(flags::multithreaded_present, true);
645
646 // resyncAllToHardwareVsync will result in requesting hardware VSYNC on display 1, which is on,
647 // but not on display 2, which is off.
648 EXPECT_CALL(mScheduler->mockRequestHardwareVsync, Call(kDisplayId1, true)).Times(1);
649 EXPECT_CALL(mScheduler->mockRequestHardwareVsync, Call(kDisplayId2, _)).Times(0);
650
651 mScheduler->setDisplayPowerMode(kDisplayId1, hal::PowerMode::ON);
652
653 mScheduler->registerDisplay(kDisplayId2,
654 std::make_shared<RefreshRateSelector>(kDisplay2Modes,
655 kDisplay2Mode60->getId()));
656 ASSERT_EQ(hal::PowerMode::OFF, mScheduler->getDisplayPowerMode(kDisplayId2));
657
658 static constexpr bool kDisallow = true;
659 mScheduler->disableHardwareVsync(kDisplayId1, kDisallow);
660 mScheduler->disableHardwareVsync(kDisplayId2, kDisallow);
661
662 static constexpr bool kAllowToEnable = true;
663 mScheduler->resyncAllToHardwareVsync(kAllowToEnable);
664}
665
666TEST_F(SchedulerTest, resyncAllLegacyAppliesToOffDisplays) FTL_FAKE_GUARD(kMainThreadContext) {
667 SET_FLAG_FOR_TEST(flags::multithreaded_present, false);
668
669 // In the legacy code, prior to the flag, resync applied to OFF displays.
670 EXPECT_CALL(mScheduler->mockRequestHardwareVsync, Call(kDisplayId1, true)).Times(1);
671 EXPECT_CALL(mScheduler->mockRequestHardwareVsync, Call(kDisplayId2, true)).Times(1);
672
673 mScheduler->setDisplayPowerMode(kDisplayId1, hal::PowerMode::ON);
674
675 mScheduler->registerDisplay(kDisplayId2,
676 std::make_shared<RefreshRateSelector>(kDisplay2Modes,
677 kDisplay2Mode60->getId()));
678 ASSERT_EQ(hal::PowerMode::OFF, mScheduler->getDisplayPowerMode(kDisplayId2));
679
680 static constexpr bool kDisallow = true;
681 mScheduler->disableHardwareVsync(kDisplayId1, kDisallow);
682 mScheduler->disableHardwareVsync(kDisplayId2, kDisallow);
683
684 static constexpr bool kAllowToEnable = true;
685 mScheduler->resyncAllToHardwareVsync(kAllowToEnable);
686}
687
Ady Abraham822ecbd2023-07-07 16:16:09 -0700688class AttachedChoreographerTest : public SchedulerTest {
689protected:
690 void frameRateTestScenario(Fps layerFps, int8_t frameRateCompatibility, Fps displayFps,
691 Fps expectedChoreographerFps);
692};
693
694TEST_F(AttachedChoreographerTest, registerSingle) {
695 EXPECT_TRUE(mScheduler->mutableAttachedChoreographers().empty());
696
697 const sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
698
699 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached);
700 const sp<IDisplayEventConnection> connection =
701 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, layer->getHandle());
702
703 EXPECT_EQ(1u, mScheduler->mutableAttachedChoreographers().size());
704 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(layer->getSequence()));
705 EXPECT_EQ(1u,
706 mScheduler->mutableAttachedChoreographers()[layer->getSequence()].connections.size());
707 EXPECT_FALSE(
708 mScheduler->mutableAttachedChoreographers()[layer->getSequence()].frameRate.isValid());
709}
710
711TEST_F(AttachedChoreographerTest, registerMultipleOnSameLayer) {
712 EXPECT_TRUE(mScheduler->mutableAttachedChoreographers().empty());
713
714 const sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
715 const auto handle = layer->getHandle();
716
717 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached).Times(2);
718
719 EXPECT_CALL(*mEventThread, registerDisplayEventConnection(_))
720 .WillOnce(Return(0))
721 .WillOnce(Return(0));
722
723 const auto mockConnection1 = sp<MockEventThreadConnection>::make(mEventThread);
724 const auto mockConnection2 = sp<MockEventThreadConnection>::make(mEventThread);
725 EXPECT_CALL(*mEventThread, createEventConnection(_, _))
726 .WillOnce(Return(mockConnection1))
727 .WillOnce(Return(mockConnection2));
728
729 const sp<IDisplayEventConnection> connection1 =
730 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, handle);
731 const sp<IDisplayEventConnection> connection2 =
732 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, handle);
733
734 EXPECT_EQ(1u, mScheduler->mutableAttachedChoreographers().size());
735 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(layer->getSequence()));
736 EXPECT_EQ(2u,
737 mScheduler->mutableAttachedChoreographers()[layer->getSequence()].connections.size());
738 EXPECT_FALSE(
739 mScheduler->mutableAttachedChoreographers()[layer->getSequence()].frameRate.isValid());
740}
741
742TEST_F(AttachedChoreographerTest, registerMultipleOnDifferentLayers) {
743 EXPECT_TRUE(mScheduler->mutableAttachedChoreographers().empty());
744
745 const sp<MockLayer> layer1 = sp<MockLayer>::make(mFlinger.flinger());
746 const sp<MockLayer> layer2 = sp<MockLayer>::make(mFlinger.flinger());
747
748 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached).Times(2);
749 const sp<IDisplayEventConnection> connection1 =
750 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, layer1->getHandle());
751 const sp<IDisplayEventConnection> connection2 =
752 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, layer2->getHandle());
753
754 EXPECT_EQ(2u, mScheduler->mutableAttachedChoreographers().size());
755
756 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(layer1->getSequence()));
757 EXPECT_EQ(1u,
758 mScheduler->mutableAttachedChoreographers()[layer1->getSequence()]
759 .connections.size());
760 EXPECT_FALSE(
761 mScheduler->mutableAttachedChoreographers()[layer1->getSequence()].frameRate.isValid());
762
763 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(layer2->getSequence()));
764 EXPECT_EQ(1u,
765 mScheduler->mutableAttachedChoreographers()[layer2->getSequence()]
766 .connections.size());
767 EXPECT_FALSE(
768 mScheduler->mutableAttachedChoreographers()[layer2->getSequence()].frameRate.isValid());
769}
770
771TEST_F(AttachedChoreographerTest, removedWhenConnectionIsGone) {
772 EXPECT_TRUE(mScheduler->mutableAttachedChoreographers().empty());
773
774 const sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
775
776 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached);
777
778 sp<IDisplayEventConnection> connection =
779 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, layer->getHandle());
780
781 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(layer->getSequence()));
782 EXPECT_EQ(1u,
783 mScheduler->mutableAttachedChoreographers()[layer->getSequence()].connections.size());
784
785 // The connection is used all over this test, so it is quite hard to release it from here.
786 // Instead, we just do a small shortcut.
787 {
788 EXPECT_CALL(*mEventThread, registerDisplayEventConnection(_)).WillOnce(Return(0));
789 sp<MockEventThreadConnection> mockConnection =
790 sp<MockEventThreadConnection>::make(mEventThread);
791 mScheduler->mutableAttachedChoreographers()[layer->getSequence()].connections.clear();
792 mScheduler->mutableAttachedChoreographers()[layer->getSequence()].connections.emplace(
793 mockConnection);
794 }
795
796 RequestedLayerState layerState(LayerCreationArgs(layer->getSequence()));
797 LayerHierarchy hierarchy(&layerState);
798 mScheduler->updateAttachedChoreographers(hierarchy, 60_Hz);
799 EXPECT_TRUE(mScheduler->mutableAttachedChoreographers().empty());
800}
801
802TEST_F(AttachedChoreographerTest, removedWhenLayerIsGone) {
803 EXPECT_TRUE(mScheduler->mutableAttachedChoreographers().empty());
804
805 sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
806
807 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached);
808 const sp<IDisplayEventConnection> connection =
809 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, layer->getHandle());
810
811 layer.clear();
812 mFlinger.mutableLayersPendingRemoval().clear();
813 EXPECT_TRUE(mScheduler->mutableAttachedChoreographers().empty());
814}
815
816void AttachedChoreographerTest::frameRateTestScenario(Fps layerFps, int8_t frameRateCompatibility,
817 Fps displayFps,
818 Fps expectedChoreographerFps) {
819 const sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
820
821 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached);
822 sp<IDisplayEventConnection> connection =
823 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, layer->getHandle());
824
825 RequestedLayerState layerState(LayerCreationArgs(layer->getSequence()));
826 LayerHierarchy hierarchy(&layerState);
827
828 layerState.frameRate = layerFps.getValue();
829 layerState.frameRateCompatibility = frameRateCompatibility;
830
831 mScheduler->updateAttachedChoreographers(hierarchy, displayFps);
832
833 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(layer->getSequence()));
834 EXPECT_EQ(expectedChoreographerFps,
835 mScheduler->mutableAttachedChoreographers()[layer->getSequence()].frameRate);
836 EXPECT_EQ(expectedChoreographerFps, mEventThreadConnection->frameRate);
837}
838
839TEST_F(AttachedChoreographerTest, setsFrameRateDefault) {
840 Fps layerFps = 30_Hz;
841 int8_t frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT;
842 Fps displayFps = 60_Hz;
843 Fps expectedChoreographerFps = 30_Hz;
844
845 frameRateTestScenario(layerFps, frameRateCompatibility, displayFps, expectedChoreographerFps);
846
847 layerFps = Fps::fromValue(32.7f);
848 frameRateTestScenario(layerFps, frameRateCompatibility, displayFps, expectedChoreographerFps);
849}
850
851TEST_F(AttachedChoreographerTest, setsFrameRateExact) {
852 Fps layerFps = 30_Hz;
853 int8_t frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_EXACT;
854 Fps displayFps = 60_Hz;
855 Fps expectedChoreographerFps = 30_Hz;
856
857 frameRateTestScenario(layerFps, frameRateCompatibility, displayFps, expectedChoreographerFps);
858
859 layerFps = Fps::fromValue(32.7f);
860 expectedChoreographerFps = {};
861 frameRateTestScenario(layerFps, frameRateCompatibility, displayFps, expectedChoreographerFps);
862}
863
864TEST_F(AttachedChoreographerTest, setsFrameRateExactOrMultiple) {
865 Fps layerFps = 30_Hz;
866 int8_t frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_FIXED_SOURCE;
867 Fps displayFps = 60_Hz;
868 Fps expectedChoreographerFps = 30_Hz;
869
870 frameRateTestScenario(layerFps, frameRateCompatibility, displayFps, expectedChoreographerFps);
871
872 layerFps = Fps::fromValue(32.7f);
873 expectedChoreographerFps = {};
874 frameRateTestScenario(layerFps, frameRateCompatibility, displayFps, expectedChoreographerFps);
875}
876
877TEST_F(AttachedChoreographerTest, setsFrameRateParent) {
878 const sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
879 const sp<MockLayer> parent = sp<MockLayer>::make(mFlinger.flinger());
880
881 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached);
882 sp<IDisplayEventConnection> connection =
883 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, parent->getHandle());
884
885 RequestedLayerState parentState(LayerCreationArgs(parent->getSequence()));
886 LayerHierarchy parentHierarchy(&parentState);
887
888 RequestedLayerState layerState(LayerCreationArgs(layer->getSequence()));
889 LayerHierarchy hierarchy(&layerState);
890 parentHierarchy.mChildren.push_back(
891 std::make_pair(&hierarchy, LayerHierarchy::Variant::Attached));
892
893 layerState.frameRate = (30_Hz).getValue();
894 layerState.frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT;
895
896 mScheduler->updateAttachedChoreographers(parentHierarchy, 120_Hz);
897
898 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(parent->getSequence()));
899
900 EXPECT_EQ(30_Hz, mScheduler->mutableAttachedChoreographers()[parent->getSequence()].frameRate);
901}
902
903TEST_F(AttachedChoreographerTest, setsFrameRateParent2Children) {
904 const sp<MockLayer> layer1 = sp<MockLayer>::make(mFlinger.flinger());
905 const sp<MockLayer> layer2 = sp<MockLayer>::make(mFlinger.flinger());
906 const sp<MockLayer> parent = sp<MockLayer>::make(mFlinger.flinger());
907
908 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached);
909 sp<IDisplayEventConnection> connection =
910 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, parent->getHandle());
911
912 RequestedLayerState parentState(LayerCreationArgs(parent->getSequence()));
913 LayerHierarchy parentHierarchy(&parentState);
914
915 RequestedLayerState layer1State(LayerCreationArgs(layer1->getSequence()));
916 LayerHierarchy layer1Hierarchy(&layer1State);
917 parentHierarchy.mChildren.push_back(
918 std::make_pair(&layer1Hierarchy, LayerHierarchy::Variant::Attached));
919
920 RequestedLayerState layer2State(LayerCreationArgs(layer1->getSequence()));
921 LayerHierarchy layer2Hierarchy(&layer2State);
922 parentHierarchy.mChildren.push_back(
923 std::make_pair(&layer2Hierarchy, LayerHierarchy::Variant::Attached));
924
925 layer1State.frameRate = (30_Hz).getValue();
926 layer1State.frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT;
927
928 layer2State.frameRate = (20_Hz).getValue();
929 layer2State.frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT;
930
931 mScheduler->updateAttachedChoreographers(parentHierarchy, 120_Hz);
932
933 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(parent->getSequence()));
934
935 EXPECT_EQ(60_Hz, mScheduler->mutableAttachedChoreographers()[parent->getSequence()].frameRate);
936}
937
938TEST_F(AttachedChoreographerTest, setsFrameRateParentConflictingChildren) {
939 const sp<MockLayer> layer1 = sp<MockLayer>::make(mFlinger.flinger());
940 const sp<MockLayer> layer2 = sp<MockLayer>::make(mFlinger.flinger());
941 const sp<MockLayer> parent = sp<MockLayer>::make(mFlinger.flinger());
942
943 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached);
944 sp<IDisplayEventConnection> connection =
945 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, parent->getHandle());
946
947 RequestedLayerState parentState(LayerCreationArgs(parent->getSequence()));
948 LayerHierarchy parentHierarchy(&parentState);
949
950 RequestedLayerState layer1State(LayerCreationArgs(layer1->getSequence()));
951 LayerHierarchy layer1Hierarchy(&layer1State);
952 parentHierarchy.mChildren.push_back(
953 std::make_pair(&layer1Hierarchy, LayerHierarchy::Variant::Attached));
954
955 RequestedLayerState layer2State(LayerCreationArgs(layer1->getSequence()));
956 LayerHierarchy layer2Hierarchy(&layer2State);
957 parentHierarchy.mChildren.push_back(
958 std::make_pair(&layer2Hierarchy, LayerHierarchy::Variant::Attached));
959
960 layer1State.frameRate = (30_Hz).getValue();
961 layer1State.frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT;
962
963 layer2State.frameRate = (25_Hz).getValue();
964 layer2State.frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT;
965
966 mScheduler->updateAttachedChoreographers(parentHierarchy, 120_Hz);
967
968 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(parent->getSequence()));
969
970 EXPECT_EQ(Fps(), mScheduler->mutableAttachedChoreographers()[parent->getSequence()].frameRate);
971}
972
973TEST_F(AttachedChoreographerTest, setsFrameRateChild) {
974 const sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
975 const sp<MockLayer> parent = sp<MockLayer>::make(mFlinger.flinger());
976
977 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached);
978 sp<IDisplayEventConnection> connection =
979 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, layer->getHandle());
980
981 RequestedLayerState parentState(LayerCreationArgs(parent->getSequence()));
982 LayerHierarchy parentHierarchy(&parentState);
983
984 RequestedLayerState layerState(LayerCreationArgs(layer->getSequence()));
985 LayerHierarchy hierarchy(&layerState);
986 parentHierarchy.mChildren.push_back(
987 std::make_pair(&hierarchy, LayerHierarchy::Variant::Attached));
988
989 parentState.frameRate = (30_Hz).getValue();
990 parentState.frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT;
991
992 mScheduler->updateAttachedChoreographers(parentHierarchy, 120_Hz);
993
994 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(layer->getSequence()));
995
996 EXPECT_EQ(30_Hz, mScheduler->mutableAttachedChoreographers()[layer->getSequence()].frameRate);
997}
998
999TEST_F(AttachedChoreographerTest, setsFrameRateChildNotOverriddenByParent) {
1000 const sp<MockLayer> layer = sp<MockLayer>::make(mFlinger.flinger());
1001 const sp<MockLayer> parent = sp<MockLayer>::make(mFlinger.flinger());
1002
1003 EXPECT_CALL(mSchedulerCallback, onChoreographerAttached);
1004 sp<IDisplayEventConnection> connection =
1005 mScheduler->createDisplayEventConnection(mConnectionHandle, {}, layer->getHandle());
1006
1007 RequestedLayerState parentState(LayerCreationArgs(parent->getSequence()));
1008 LayerHierarchy parentHierarchy(&parentState);
1009
1010 RequestedLayerState layerState(LayerCreationArgs(layer->getSequence()));
1011 LayerHierarchy hierarchy(&layerState);
1012 parentHierarchy.mChildren.push_back(
1013 std::make_pair(&hierarchy, LayerHierarchy::Variant::Attached));
1014
1015 parentState.frameRate = (30_Hz).getValue();
1016 parentState.frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT;
1017
1018 layerState.frameRate = (60_Hz).getValue();
1019 layerState.frameRateCompatibility = ANATIVEWINDOW_FRAME_RATE_COMPATIBILITY_DEFAULT;
1020
1021 mScheduler->updateAttachedChoreographers(parentHierarchy, 120_Hz);
1022
1023 ASSERT_EQ(1u, mScheduler->mutableAttachedChoreographers().count(layer->getSequence()));
1024
1025 EXPECT_EQ(60_Hz, mScheduler->mutableAttachedChoreographers()[layer->getSequence()].frameRate);
1026}
1027
Dominik Laskowski068173d2021-08-11 17:22:59 -07001028} // namespace android::scheduler