blob: 65c893af99eb5cce30083ad00d52a1e671493a77 [file] [log] [blame]
Robert Carr78c25dd2019-08-15 14:10:33 -07001/*
2 * Copyright (C) 2019 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Valerie Haud3b90d22019-11-06 09:37:31 -080017#undef LOG_TAG
18#define LOG_TAG "BLASTBufferQueue"
19
Valerie Haua32c5522019-12-09 10:11:08 -080020#define ATRACE_TAG ATRACE_TAG_GRAPHICS
Vishnu Naire1a42322020-10-02 17:42:04 -070021//#define LOG_NDEBUG 0
Valerie Haua32c5522019-12-09 10:11:08 -080022
Robert Carr78c25dd2019-08-15 14:10:33 -070023#include <gui/BLASTBufferQueue.h>
24#include <gui/BufferItemConsumer.h>
Vishnu Nair89496122020-12-14 17:14:53 -080025#include <gui/BufferQueueConsumer.h>
26#include <gui/BufferQueueCore.h>
27#include <gui/BufferQueueProducer.h>
Valerie Hau45e4b3b2019-12-03 10:49:17 -080028#include <gui/GLConsumer.h>
Vishnu Nair89496122020-12-14 17:14:53 -080029#include <gui/IProducerListener.h>
Robert Carr05086b22020-10-13 18:22:51 -070030#include <gui/Surface.h>
Vishnu Nair89496122020-12-14 17:14:53 -080031#include <utils/Singleton.h>
Robert Carr78c25dd2019-08-15 14:10:33 -070032
Valerie Haua32c5522019-12-09 10:11:08 -080033#include <utils/Trace.h>
34
Robert Carr78c25dd2019-08-15 14:10:33 -070035#include <chrono>
36
37using namespace std::chrono_literals;
38
Vishnu Nairdab94092020-09-29 16:09:04 -070039namespace {
40inline const char* toString(bool b) {
41 return b ? "true" : "false";
42}
43} // namespace
44
Robert Carr78c25dd2019-08-15 14:10:33 -070045namespace android {
46
Vishnu Nairdab94092020-09-29 16:09:04 -070047// Macros to include adapter info in log messages
48#define BQA_LOGV(x, ...) \
49 ALOGV("[%s](f:%u,a:%u) " x, mName.c_str(), mNumFrameAvailable, mNumAcquired, ##__VA_ARGS__)
Vishnu Nairc6f89ee2020-12-11 14:27:32 -080050// enable logs for a single layer
51//#define BQA_LOGV(x, ...) \
52// ALOGV_IF((strstr(mName.c_str(), "SurfaceView") != nullptr), "[%s](f:%u,a:%u) " x, \
53// mName.c_str(), mNumFrameAvailable, mNumAcquired, ##__VA_ARGS__)
Vishnu Nairdab94092020-09-29 16:09:04 -070054#define BQA_LOGE(x, ...) \
55 ALOGE("[%s](f:%u,a:%u) " x, mName.c_str(), mNumFrameAvailable, mNumAcquired, ##__VA_ARGS__)
56
Valerie Hau871d6352020-01-29 08:44:02 -080057void BLASTBufferItemConsumer::onDisconnect() {
Hongguang Chen621ec582021-02-16 15:42:35 -080058 Mutex::Autolock lock(mMutex);
Valerie Hau871d6352020-01-29 08:44:02 -080059 mPreviouslyConnected = mCurrentlyConnected;
60 mCurrentlyConnected = false;
61 if (mPreviouslyConnected) {
62 mDisconnectEvents.push(mCurrentFrameNumber);
63 }
64 mFrameEventHistory.onDisconnect();
65}
66
67void BLASTBufferItemConsumer::addAndGetFrameTimestamps(const NewFrameEventsEntry* newTimestamps,
68 FrameEventHistoryDelta* outDelta) {
Hongguang Chen621ec582021-02-16 15:42:35 -080069 Mutex::Autolock lock(mMutex);
Valerie Hau871d6352020-01-29 08:44:02 -080070 if (newTimestamps) {
71 // BufferQueueProducer only adds a new timestamp on
72 // queueBuffer
73 mCurrentFrameNumber = newTimestamps->frameNumber;
74 mFrameEventHistory.addQueue(*newTimestamps);
75 }
76 if (outDelta) {
77 // frame event histories will be processed
78 // only after the producer connects and requests
79 // deltas for the first time. Forward this intent
80 // to SF-side to turn event processing back on
81 mPreviouslyConnected = mCurrentlyConnected;
82 mCurrentlyConnected = true;
83 mFrameEventHistory.getAndResetDelta(outDelta);
84 }
85}
86
87void BLASTBufferItemConsumer::updateFrameTimestamps(uint64_t frameNumber, nsecs_t refreshStartTime,
88 const sp<Fence>& glDoneFence,
89 const sp<Fence>& presentFence,
90 const sp<Fence>& prevReleaseFence,
91 CompositorTiming compositorTiming,
92 nsecs_t latchTime, nsecs_t dequeueReadyTime) {
Hongguang Chen621ec582021-02-16 15:42:35 -080093 Mutex::Autolock lock(mMutex);
Valerie Hau871d6352020-01-29 08:44:02 -080094
95 // if the producer is not connected, don't bother updating,
96 // the next producer that connects won't access this frame event
97 if (!mCurrentlyConnected) return;
98 std::shared_ptr<FenceTime> glDoneFenceTime = std::make_shared<FenceTime>(glDoneFence);
99 std::shared_ptr<FenceTime> presentFenceTime = std::make_shared<FenceTime>(presentFence);
100 std::shared_ptr<FenceTime> releaseFenceTime = std::make_shared<FenceTime>(prevReleaseFence);
101
102 mFrameEventHistory.addLatch(frameNumber, latchTime);
103 mFrameEventHistory.addRelease(frameNumber, dequeueReadyTime, std::move(releaseFenceTime));
104 mFrameEventHistory.addPreComposition(frameNumber, refreshStartTime);
105 mFrameEventHistory.addPostComposition(frameNumber, glDoneFenceTime, presentFenceTime,
106 compositorTiming);
107}
108
109void BLASTBufferItemConsumer::getConnectionEvents(uint64_t frameNumber, bool* needsDisconnect) {
110 bool disconnect = false;
Hongguang Chen621ec582021-02-16 15:42:35 -0800111 Mutex::Autolock lock(mMutex);
Valerie Hau871d6352020-01-29 08:44:02 -0800112 while (!mDisconnectEvents.empty() && mDisconnectEvents.front() <= frameNumber) {
113 disconnect = true;
114 mDisconnectEvents.pop();
115 }
116 if (needsDisconnect != nullptr) *needsDisconnect = disconnect;
117}
118
Hongguang Chen621ec582021-02-16 15:42:35 -0800119void BLASTBufferItemConsumer::setBlastBufferQueue(BLASTBufferQueue* blastbufferqueue) {
120 Mutex::Autolock lock(mMutex);
121 mBLASTBufferQueue = blastbufferqueue;
122}
123
124void BLASTBufferItemConsumer::onSidebandStreamChanged() {
125 Mutex::Autolock lock(mMutex);
126 if (mBLASTBufferQueue != nullptr) {
127 sp<NativeHandle> stream = getSidebandStream();
128 mBLASTBufferQueue->setSidebandStream(stream);
129 }
130}
131
Vishnu Nairdab94092020-09-29 16:09:04 -0700132BLASTBufferQueue::BLASTBufferQueue(const std::string& name, const sp<SurfaceControl>& surface,
Vishnu Nairdebd1cb2021-03-16 10:06:01 -0700133 int width, int height, int32_t format)
Vishnu Nairdab94092020-09-29 16:09:04 -0700134 : mName(name),
135 mSurfaceControl(surface),
Vishnu Nairea0de002020-11-17 17:42:37 -0800136 mSize(width, height),
137 mRequestedSize(mSize),
chaviw565ee542021-01-14 10:21:23 -0800138 mFormat(format),
Valerie Haud3b90d22019-11-06 09:37:31 -0800139 mNextTransaction(nullptr) {
Vishnu Nair89496122020-12-14 17:14:53 -0800140 createBufferQueue(&mProducer, &mConsumer);
Valerie Hau0889c622020-02-19 15:04:47 -0800141 // since the adapter is in the client process, set dequeue timeout
142 // explicitly so that dequeueBuffer will block
143 mProducer->setDequeueTimeout(std::numeric_limits<int64_t>::max());
Valerie Hau65b8e872020-02-13 09:45:14 -0800144
Vishnu Nairdebd1cb2021-03-16 10:06:01 -0700145 // safe default, most producers are expected to override this
146 mProducer->setMaxDequeuedBufferCount(2);
Vishnu Nair1618c672021-02-05 13:08:26 -0800147 mBufferItemConsumer = new BLASTBufferItemConsumer(mConsumer,
148 GraphicBuffer::USAGE_HW_COMPOSER |
149 GraphicBuffer::USAGE_HW_TEXTURE,
150 1, false);
Valerie Haua32c5522019-12-09 10:11:08 -0800151 static int32_t id = 0;
Vishnu Nairdab94092020-09-29 16:09:04 -0700152 auto consumerName = mName + "(BLAST Consumer)" + std::to_string(id);
Valerie Haua32c5522019-12-09 10:11:08 -0800153 id++;
Vishnu Nairdab94092020-09-29 16:09:04 -0700154 mBufferItemConsumer->setName(String8(consumerName.c_str()));
Robert Carr78c25dd2019-08-15 14:10:33 -0700155 mBufferItemConsumer->setFrameAvailableListener(this);
156 mBufferItemConsumer->setBufferFreedListener(this);
Vishnu Nairea0de002020-11-17 17:42:37 -0800157 mBufferItemConsumer->setDefaultBufferSize(mSize.width, mSize.height);
chaviw497e81c2021-02-04 17:09:47 -0800158 mBufferItemConsumer->setDefaultBufferFormat(convertBufferFormat(format));
Hongguang Chen621ec582021-02-16 15:42:35 -0800159 mBufferItemConsumer->setBlastBufferQueue(this);
Robert Carr9f133d72020-04-01 15:51:46 -0700160
Valerie Hau2882e982020-01-23 13:33:10 -0800161 mTransformHint = mSurfaceControl->getTransformHint();
Robert Carr9f133d72020-04-01 15:51:46 -0700162 mBufferItemConsumer->setTransformHint(mTransformHint);
Vishnu Nairf6eddb62021-01-27 22:02:11 -0800163 SurfaceComposerClient::Transaction()
Robert Carr5b3b9142021-02-22 12:27:32 -0800164 .setFlags(surface, layer_state_t::eEnableBackpressure,
165 layer_state_t::eEnableBackpressure)
166 .apply();
Valerie Haud3b90d22019-11-06 09:37:31 -0800167
Valerie Haua32c5522019-12-09 10:11:08 -0800168 mNumAcquired = 0;
169 mNumFrameAvailable = 0;
Robert Carr78c25dd2019-08-15 14:10:33 -0700170}
171
Vishnu Nairc4a40c12020-12-23 09:14:32 -0800172BLASTBufferQueue::~BLASTBufferQueue() {
Hongguang Chen621ec582021-02-16 15:42:35 -0800173 mBufferItemConsumer->setBlastBufferQueue(nullptr);
Vishnu Nairc4a40c12020-12-23 09:14:32 -0800174 if (mPendingTransactions.empty()) {
175 return;
176 }
177 BQA_LOGE("Applying pending transactions on dtor %d",
178 static_cast<uint32_t>(mPendingTransactions.size()));
179 SurfaceComposerClient::Transaction t;
180 for (auto& [targetFrameNumber, transaction] : mPendingTransactions) {
181 t.merge(std::move(transaction));
182 }
183 t.apply();
184}
185
chaviw565ee542021-01-14 10:21:23 -0800186void BLASTBufferQueue::update(const sp<SurfaceControl>& surface, uint32_t width, uint32_t height,
187 int32_t format) {
Robert Carr78c25dd2019-08-15 14:10:33 -0700188 std::unique_lock _lock{mMutex};
Vishnu Nair5cc9ac02021-04-19 13:23:38 -0700189 BQA_LOGV("update width=%d height=%d format=%d", width, height, format);
chaviw565ee542021-01-14 10:21:23 -0800190 if (mFormat != format) {
191 mFormat = format;
chaviw497e81c2021-02-04 17:09:47 -0800192 mBufferItemConsumer->setDefaultBufferFormat(convertBufferFormat(format));
chaviw565ee542021-01-14 10:21:23 -0800193 }
194
Vishnu Nairf6eddb62021-01-27 22:02:11 -0800195 SurfaceComposerClient::Transaction t;
196 bool applyTransaction = false;
197 if (!SurfaceControl::isSameSurface(mSurfaceControl, surface)) {
198 mSurfaceControl = surface;
199 t.setFlags(mSurfaceControl, layer_state_t::eEnableBackpressure,
200 layer_state_t::eEnableBackpressure);
201 applyTransaction = true;
202 }
203
Vishnu Nairea0de002020-11-17 17:42:37 -0800204 ui::Size newSize(width, height);
205 if (mRequestedSize != newSize) {
206 mRequestedSize.set(newSize);
207 mBufferItemConsumer->setDefaultBufferSize(mRequestedSize.width, mRequestedSize.height);
Chavi Weingartena5aedbd2021-04-09 13:37:33 +0000208 if (mLastBufferInfo.scalingMode != NATIVE_WINDOW_SCALING_MODE_FREEZE) {
Vishnu Nair53c936c2020-12-03 11:46:37 -0800209 // If the buffer supports scaling, update the frame immediately since the client may
210 // want to scale the existing buffer to the new size.
211 mSize = mRequestedSize;
Chavi Weingartena5aedbd2021-04-09 13:37:33 +0000212 // We only need to update the scale if we've received at least one buffer. The reason
213 // for this is the scale is calculated based on the requested size and buffer size.
214 // If there's no buffer, the scale will always be 1.
215 if (mLastBufferInfo.hasBuffer) {
216 setMatrix(&t, mLastBufferInfo);
217 }
Vishnu Nairf6eddb62021-01-27 22:02:11 -0800218 applyTransaction = true;
Vishnu Nair53c936c2020-12-03 11:46:37 -0800219 }
Robert Carrfc416512020-04-02 12:32:44 -0700220 }
Vishnu Nairf6eddb62021-01-27 22:02:11 -0800221 if (applyTransaction) {
222 t.apply();
223 }
Robert Carr78c25dd2019-08-15 14:10:33 -0700224}
225
226static void transactionCallbackThunk(void* context, nsecs_t latchTime,
227 const sp<Fence>& presentFence,
228 const std::vector<SurfaceControlStats>& stats) {
229 if (context == nullptr) {
230 return;
231 }
Robert Carrfbcbb4c2020-11-02 14:14:34 -0800232 sp<BLASTBufferQueue> bq = static_cast<BLASTBufferQueue*>(context);
Robert Carr78c25dd2019-08-15 14:10:33 -0700233 bq->transactionCallback(latchTime, presentFence, stats);
234}
235
236void BLASTBufferQueue::transactionCallback(nsecs_t /*latchTime*/, const sp<Fence>& /*presentFence*/,
237 const std::vector<SurfaceControlStats>& stats) {
chaviw71c2cc42020-10-23 16:42:02 -0700238 std::function<void(int64_t)> transactionCompleteCallback = nullptr;
239 uint64_t currFrameNumber = 0;
Vishnu Nairdab94092020-09-29 16:09:04 -0700240
chaviw71c2cc42020-10-23 16:42:02 -0700241 {
242 std::unique_lock _lock{mMutex};
243 ATRACE_CALL();
244 BQA_LOGV("transactionCallback");
chaviw71c2cc42020-10-23 16:42:02 -0700245
Valerie Hau871d6352020-01-29 08:44:02 -0800246 if (!stats.empty()) {
chaviw71c2cc42020-10-23 16:42:02 -0700247 mTransformHint = stats[0].transformHint;
248 mBufferItemConsumer->setTransformHint(mTransformHint);
249 mBufferItemConsumer
250 ->updateFrameTimestamps(stats[0].frameEventStats.frameNumber,
251 stats[0].frameEventStats.refreshStartTime,
252 stats[0].frameEventStats.gpuCompositionDoneFence,
253 stats[0].presentFence, stats[0].previousReleaseFence,
254 stats[0].frameEventStats.compositorTiming,
255 stats[0].latchTime,
256 stats[0].frameEventStats.dequeueReadyTime);
Vishnu Nair1506b182021-02-22 14:35:15 -0800257 currFrameNumber = stats[0].frameEventStats.frameNumber;
258
259 if (mTransactionCompleteCallback &&
260 currFrameNumber >= mTransactionCompleteFrameNumber) {
261 if (currFrameNumber > mTransactionCompleteFrameNumber) {
262 BQA_LOGE("transactionCallback received for a newer framenumber=%" PRIu64
263 " than expected=%" PRIu64,
264 currFrameNumber, mTransactionCompleteFrameNumber);
265 }
266 transactionCompleteCallback = std::move(mTransactionCompleteCallback);
267 mTransactionCompleteFrameNumber = 0;
chaviw71c2cc42020-10-23 16:42:02 -0700268 }
Valerie Haua32c5522019-12-09 10:11:08 -0800269 }
chaviw71c2cc42020-10-23 16:42:02 -0700270
chaviw71c2cc42020-10-23 16:42:02 -0700271 decStrong((void*)transactionCallbackThunk);
Robert Carr78c25dd2019-08-15 14:10:33 -0700272 }
Valerie Haua32c5522019-12-09 10:11:08 -0800273
chaviw71c2cc42020-10-23 16:42:02 -0700274 if (transactionCompleteCallback) {
275 transactionCompleteCallback(currFrameNumber);
Valerie Haua32c5522019-12-09 10:11:08 -0800276 }
Robert Carr78c25dd2019-08-15 14:10:33 -0700277}
278
Vishnu Nair1506b182021-02-22 14:35:15 -0800279// Unlike transactionCallbackThunk the release buffer callback does not extend the life of the
280// BBQ. This is because if the BBQ is destroyed, then the buffers will be released by the client.
281// So we pass in a weak pointer to the BBQ and if it still alive, then we release the buffer.
282// Otherwise, this is a no-op.
283static void releaseBufferCallbackThunk(wp<BLASTBufferQueue> context, uint64_t graphicBufferId,
284 const sp<Fence>& releaseFence) {
285 sp<BLASTBufferQueue> blastBufferQueue = context.promote();
286 ALOGV("releaseBufferCallbackThunk graphicBufferId=%" PRIu64 " blastBufferQueue=%s",
287 graphicBufferId, blastBufferQueue ? "alive" : "dead");
288 if (blastBufferQueue) {
289 blastBufferQueue->releaseBufferCallback(graphicBufferId, releaseFence);
290 }
291}
292
293void BLASTBufferQueue::releaseBufferCallback(uint64_t graphicBufferId,
294 const sp<Fence>& releaseFence) {
295 ATRACE_CALL();
296 std::unique_lock _lock{mMutex};
297 BQA_LOGV("releaseBufferCallback graphicBufferId=%" PRIu64, graphicBufferId);
298
299 auto it = mSubmitted.find(graphicBufferId);
300 if (it == mSubmitted.end()) {
301 BQA_LOGE("ERROR: releaseBufferCallback without corresponding submitted buffer %" PRIu64,
302 graphicBufferId);
303 return;
304 }
305
306 mBufferItemConsumer->releaseBuffer(it->second, releaseFence);
307 mSubmitted.erase(it);
308 mNumAcquired--;
309 processNextBufferLocked(false /* useNextTransaction */);
310 mCallbackCV.notify_all();
311}
312
Robert Carr255acdc2020-04-17 14:08:55 -0700313void BLASTBufferQueue::processNextBufferLocked(bool useNextTransaction) {
Valerie Haua32c5522019-12-09 10:11:08 -0800314 ATRACE_CALL();
Vishnu Nair8b30dd12021-01-25 14:16:54 -0800315 // If the next transaction is set, we want to guarantee the our acquire will not fail, so don't
316 // include the extra buffer when checking if we can acquire the next buffer.
317 const bool includeExtraAcquire = !useNextTransaction;
318 if (mNumFrameAvailable == 0 || maxBuffersAcquired(includeExtraAcquire)) {
Vishnu Nairea0de002020-11-17 17:42:37 -0800319 mCallbackCV.notify_all();
Valerie Haud3b90d22019-11-06 09:37:31 -0800320 return;
321 }
322
Valerie Haua32c5522019-12-09 10:11:08 -0800323 if (mSurfaceControl == nullptr) {
Vishnu Nair670b3f72020-09-29 17:52:18 -0700324 BQA_LOGE("ERROR : surface control is null");
Valerie Haud3b90d22019-11-06 09:37:31 -0800325 return;
326 }
327
Robert Carr78c25dd2019-08-15 14:10:33 -0700328 SurfaceComposerClient::Transaction localTransaction;
329 bool applyTransaction = true;
330 SurfaceComposerClient::Transaction* t = &localTransaction;
Robert Carr255acdc2020-04-17 14:08:55 -0700331 if (mNextTransaction != nullptr && useNextTransaction) {
Robert Carr78c25dd2019-08-15 14:10:33 -0700332 t = mNextTransaction;
333 mNextTransaction = nullptr;
334 applyTransaction = false;
335 }
336
Valerie Haua32c5522019-12-09 10:11:08 -0800337 BufferItem bufferItem;
Valerie Haud3b90d22019-11-06 09:37:31 -0800338
Vishnu Nairc6f89ee2020-12-11 14:27:32 -0800339 status_t status =
340 mBufferItemConsumer->acquireBuffer(&bufferItem, 0 /* expectedPresent */, false);
Vishnu Nair8b30dd12021-01-25 14:16:54 -0800341 if (status == BufferQueue::NO_BUFFER_AVAILABLE) {
342 BQA_LOGV("Failed to acquire a buffer, err=NO_BUFFER_AVAILABLE");
343 return;
344 } else if (status != OK) {
Vishnu Nairbf255772020-10-16 10:54:41 -0700345 BQA_LOGE("Failed to acquire a buffer, err=%s", statusToString(status).c_str());
Robert Carr78c25dd2019-08-15 14:10:33 -0700346 return;
347 }
Valerie Haua32c5522019-12-09 10:11:08 -0800348 auto buffer = bufferItem.mGraphicBuffer;
349 mNumFrameAvailable--;
350
351 if (buffer == nullptr) {
352 mBufferItemConsumer->releaseBuffer(bufferItem, Fence::NO_FENCE);
Vishnu Nairbf255772020-10-16 10:54:41 -0700353 BQA_LOGE("Buffer was empty");
Valerie Haua32c5522019-12-09 10:11:08 -0800354 return;
355 }
356
Vishnu Nair670b3f72020-09-29 17:52:18 -0700357 if (rejectBuffer(bufferItem)) {
Vishnu Nairea0de002020-11-17 17:42:37 -0800358 BQA_LOGE("rejecting buffer:active_size=%dx%d, requested_size=%dx%d"
359 "buffer{size=%dx%d transform=%d}",
360 mSize.width, mSize.height, mRequestedSize.width, mRequestedSize.height,
361 buffer->getWidth(), buffer->getHeight(), bufferItem.mTransform);
362 mBufferItemConsumer->releaseBuffer(bufferItem, Fence::NO_FENCE);
363 processNextBufferLocked(useNextTransaction);
364 return;
Vishnu Nair670b3f72020-09-29 17:52:18 -0700365 }
366
Valerie Haua32c5522019-12-09 10:11:08 -0800367 mNumAcquired++;
Vishnu Nair1506b182021-02-22 14:35:15 -0800368 mSubmitted[buffer->getId()] = bufferItem;
Robert Carr78c25dd2019-08-15 14:10:33 -0700369
Valerie Hau871d6352020-01-29 08:44:02 -0800370 bool needsDisconnect = false;
371 mBufferItemConsumer->getConnectionEvents(bufferItem.mFrameNumber, &needsDisconnect);
372
373 // if producer disconnected before, notify SurfaceFlinger
374 if (needsDisconnect) {
375 t->notifyProducerDisconnect(mSurfaceControl);
376 }
377
Robert Carr78c25dd2019-08-15 14:10:33 -0700378 // Ensure BLASTBufferQueue stays alive until we receive the transaction complete callback.
379 incStrong((void*)transactionCallbackThunk);
380
Vishnu Nair5cc9ac02021-04-19 13:23:38 -0700381 Rect crop = computeCrop(bufferItem);
Vishnu Nairc4a40c12020-12-23 09:14:32 -0800382 mLastAcquiredFrameNumber = bufferItem.mFrameNumber;
Chavi Weingartena5aedbd2021-04-09 13:37:33 +0000383 mLastBufferInfo.update(true /* hasBuffer */, bufferItem.mGraphicBuffer->getWidth(),
384 bufferItem.mGraphicBuffer->getHeight(), bufferItem.mTransform,
Vishnu Nair5cc9ac02021-04-19 13:23:38 -0700385 bufferItem.mScalingMode, crop);
Vishnu Nair53c936c2020-12-03 11:46:37 -0800386
Vishnu Nair1506b182021-02-22 14:35:15 -0800387 auto releaseBufferCallback =
388 std::bind(releaseBufferCallbackThunk, wp<BLASTBufferQueue>(this) /* callbackContext */,
389 std::placeholders::_1, std::placeholders::_2);
390 t->setBuffer(mSurfaceControl, buffer, releaseBufferCallback);
John Reck137069e2020-12-10 22:07:37 -0500391 t->setDataspace(mSurfaceControl, static_cast<ui::Dataspace>(bufferItem.mDataSpace));
392 t->setHdrMetadata(mSurfaceControl, bufferItem.mHdrMetadata);
393 t->setSurfaceDamageRegion(mSurfaceControl, bufferItem.mSurfaceDamage);
Robert Carr78c25dd2019-08-15 14:10:33 -0700394 t->setAcquireFence(mSurfaceControl,
Valerie Haua32c5522019-12-09 10:11:08 -0800395 bufferItem.mFence ? new Fence(bufferItem.mFence->dup()) : Fence::NO_FENCE);
Robert Carr78c25dd2019-08-15 14:10:33 -0700396 t->addTransactionCompletedCallback(transactionCallbackThunk, static_cast<void*>(this));
397
Chavi Weingartena5aedbd2021-04-09 13:37:33 +0000398 setMatrix(t, mLastBufferInfo);
Vishnu Nair5cc9ac02021-04-19 13:23:38 -0700399 t->setCrop(mSurfaceControl, crop);
Valerie Haua32c5522019-12-09 10:11:08 -0800400 t->setTransform(mSurfaceControl, bufferItem.mTransform);
Valerie Hau2882e982020-01-23 13:33:10 -0800401 t->setTransformToDisplayInverse(mSurfaceControl, bufferItem.mTransformToDisplayInverse);
Ady Abrahamf0c56492020-12-17 18:04:15 -0800402 if (!bufferItem.mIsAutoTimestamp) {
403 t->setDesiredPresentTime(bufferItem.mTimestamp);
404 }
Vishnu Nair6b7c5c92020-09-29 17:27:05 -0700405 t->setFrameNumber(mSurfaceControl, bufferItem.mFrameNumber);
Robert Carr78c25dd2019-08-15 14:10:33 -0700406
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000407 if (!mNextFrameTimelineInfoQueue.empty()) {
Ady Abraham8db10102021-03-15 17:19:23 -0700408 t->setFrameTimelineInfo(mNextFrameTimelineInfoQueue.front());
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000409 mNextFrameTimelineInfoQueue.pop();
Jorim Jaggia3fe67b2020-12-01 00:24:33 +0100410 }
411
Vishnu Naircf26a0a2020-11-13 12:56:20 -0800412 if (mAutoRefresh != bufferItem.mAutoRefresh) {
413 t->setAutoRefresh(mSurfaceControl, bufferItem.mAutoRefresh);
414 mAutoRefresh = bufferItem.mAutoRefresh;
415 }
Vishnu Nairadf632b2021-01-07 14:05:08 -0800416 {
417 std::unique_lock _lock{mTimestampMutex};
418 auto dequeueTime = mDequeueTimestamps.find(buffer->getId());
419 if (dequeueTime != mDequeueTimestamps.end()) {
420 Parcel p;
421 p.writeInt64(dequeueTime->second);
422 t->setMetadata(mSurfaceControl, METADATA_DEQUEUE_TIME, p);
423 mDequeueTimestamps.erase(dequeueTime);
424 }
425 }
Vishnu Naircf26a0a2020-11-13 12:56:20 -0800426
Vishnu Nairc4a40c12020-12-23 09:14:32 -0800427 auto mergeTransaction =
428 [&t, currentFrameNumber = bufferItem.mFrameNumber](
429 std::tuple<uint64_t, SurfaceComposerClient::Transaction> pendingTransaction) {
430 auto& [targetFrameNumber, transaction] = pendingTransaction;
431 if (currentFrameNumber < targetFrameNumber) {
432 return false;
433 }
434 t->merge(std::move(transaction));
435 return true;
436 };
437
438 mPendingTransactions.erase(std::remove_if(mPendingTransactions.begin(),
439 mPendingTransactions.end(), mergeTransaction),
440 mPendingTransactions.end());
441
Robert Carr78c25dd2019-08-15 14:10:33 -0700442 if (applyTransaction) {
Vishnu Nair277142c2021-01-05 18:35:29 -0800443 t->setApplyToken(mApplyToken).apply();
Robert Carr78c25dd2019-08-15 14:10:33 -0700444 }
Vishnu Nairdab94092020-09-29 16:09:04 -0700445
446 BQA_LOGV("processNextBufferLocked size=%dx%d mFrameNumber=%" PRIu64
Vishnu Nair1506b182021-02-22 14:35:15 -0800447 " applyTransaction=%s mTimestamp=%" PRId64 "%s mPendingTransactions.size=%d"
448 " graphicBufferId=%" PRIu64,
Vishnu Nairea0de002020-11-17 17:42:37 -0800449 mSize.width, mSize.height, bufferItem.mFrameNumber, toString(applyTransaction),
Vishnu Nair1506b182021-02-22 14:35:15 -0800450 bufferItem.mTimestamp, bufferItem.mIsAutoTimestamp ? "(auto)" : "",
451 static_cast<uint32_t>(mPendingTransactions.size()),
452 bufferItem.mGraphicBuffer->getId());
Robert Carr78c25dd2019-08-15 14:10:33 -0700453}
454
Valerie Hau45e4b3b2019-12-03 10:49:17 -0800455Rect BLASTBufferQueue::computeCrop(const BufferItem& item) {
456 if (item.mScalingMode == NATIVE_WINDOW_SCALING_MODE_SCALE_CROP) {
Vishnu Nairea0de002020-11-17 17:42:37 -0800457 return GLConsumer::scaleDownCrop(item.mCrop, mSize.width, mSize.height);
Valerie Hau45e4b3b2019-12-03 10:49:17 -0800458 }
459 return item.mCrop;
460}
461
Vishnu Nairaef1de92020-10-22 12:15:53 -0700462void BLASTBufferQueue::onFrameAvailable(const BufferItem& item) {
Valerie Haua32c5522019-12-09 10:11:08 -0800463 ATRACE_CALL();
Valerie Hau0188adf2020-02-13 08:29:20 -0800464 std::unique_lock _lock{mMutex};
Valerie Haud3b90d22019-11-06 09:37:31 -0800465
Vishnu Nairdab94092020-09-29 16:09:04 -0700466 const bool nextTransactionSet = mNextTransaction != nullptr;
Vishnu Nair1506b182021-02-22 14:35:15 -0800467 if (nextTransactionSet) {
Vishnu Nair8b30dd12021-01-25 14:16:54 -0800468 while (mNumFrameAvailable > 0 || maxBuffersAcquired(false /* includeExtraAcquire */)) {
Vishnu Nair7eb670a2020-10-15 12:16:10 -0700469 BQA_LOGV("waiting in onFrameAvailable...");
Valerie Hau0188adf2020-02-13 08:29:20 -0800470 mCallbackCV.wait(_lock);
471 }
472 }
Valerie Haud3b90d22019-11-06 09:37:31 -0800473 // add to shadow queue
Valerie Haua32c5522019-12-09 10:11:08 -0800474 mNumFrameAvailable++;
Vishnu Nair1506b182021-02-22 14:35:15 -0800475
476 BQA_LOGV("onFrameAvailable framenumber=%" PRIu64 " nextTransactionSet=%s", item.mFrameNumber,
477 toString(nextTransactionSet));
Vishnu Nair8b30dd12021-01-25 14:16:54 -0800478 processNextBufferLocked(nextTransactionSet /* useNextTransaction */);
Valerie Haud3b90d22019-11-06 09:37:31 -0800479}
480
Vishnu Nairaef1de92020-10-22 12:15:53 -0700481void BLASTBufferQueue::onFrameReplaced(const BufferItem& item) {
482 BQA_LOGV("onFrameReplaced framenumber=%" PRIu64, item.mFrameNumber);
483 // Do nothing since we are not storing unacquired buffer items locally.
484}
485
Vishnu Nairadf632b2021-01-07 14:05:08 -0800486void BLASTBufferQueue::onFrameDequeued(const uint64_t bufferId) {
487 std::unique_lock _lock{mTimestampMutex};
488 mDequeueTimestamps[bufferId] = systemTime();
489};
490
491void BLASTBufferQueue::onFrameCancelled(const uint64_t bufferId) {
492 std::unique_lock _lock{mTimestampMutex};
493 mDequeueTimestamps.erase(bufferId);
494};
495
Robert Carr78c25dd2019-08-15 14:10:33 -0700496void BLASTBufferQueue::setNextTransaction(SurfaceComposerClient::Transaction* t) {
Valerie Haud3b90d22019-11-06 09:37:31 -0800497 std::lock_guard _lock{mMutex};
Robert Carr78c25dd2019-08-15 14:10:33 -0700498 mNextTransaction = t;
499}
500
Vishnu Nairea0de002020-11-17 17:42:37 -0800501bool BLASTBufferQueue::rejectBuffer(const BufferItem& item) {
Vishnu Nair670b3f72020-09-29 17:52:18 -0700502 if (item.mScalingMode != NATIVE_WINDOW_SCALING_MODE_FREEZE) {
Hongguang Chen33100282021-04-15 18:36:05 -0700503 mSize = mRequestedSize;
Vishnu Nair670b3f72020-09-29 17:52:18 -0700504 // Only reject buffers if scaling mode is freeze.
505 return false;
506 }
507
Vishnu Naire1a42322020-10-02 17:42:04 -0700508 uint32_t bufWidth = item.mGraphicBuffer->getWidth();
509 uint32_t bufHeight = item.mGraphicBuffer->getHeight();
510
511 // Take the buffer's orientation into account
512 if (item.mTransform & ui::Transform::ROT_90) {
513 std::swap(bufWidth, bufHeight);
514 }
Vishnu Nairea0de002020-11-17 17:42:37 -0800515 ui::Size bufferSize(bufWidth, bufHeight);
516 if (mRequestedSize != mSize && mRequestedSize == bufferSize) {
517 mSize = mRequestedSize;
518 return false;
519 }
Vishnu Naire1a42322020-10-02 17:42:04 -0700520
Vishnu Nair670b3f72020-09-29 17:52:18 -0700521 // reject buffers if the buffer size doesn't match.
Vishnu Nairea0de002020-11-17 17:42:37 -0800522 return mSize != bufferSize;
Vishnu Nair670b3f72020-09-29 17:52:18 -0700523}
Vishnu Nairbf255772020-10-16 10:54:41 -0700524
Chavi Weingartena5aedbd2021-04-09 13:37:33 +0000525void BLASTBufferQueue::setMatrix(SurfaceComposerClient::Transaction* t,
526 const BufferInfo& bufferInfo) {
Vishnu Nair5cc9ac02021-04-19 13:23:38 -0700527 uint32_t bufWidth = bufferInfo.crop.getWidth();
528 uint32_t bufHeight = bufferInfo.crop.getHeight();
Chavi Weingartena5aedbd2021-04-09 13:37:33 +0000529
Vishnu Nair5cc9ac02021-04-19 13:23:38 -0700530 float sx = mSize.width / static_cast<float>(bufWidth);
531 float sy = mSize.height / static_cast<float>(bufHeight);
Chavi Weingartena5aedbd2021-04-09 13:37:33 +0000532
Vishnu Nair5cc9ac02021-04-19 13:23:38 -0700533 t->setMatrix(mSurfaceControl, sx, 0, 0, sy);
534 // Update position based on crop.
535 t->setPosition(mSurfaceControl, bufferInfo.crop.left * sx * -1, bufferInfo.crop.top * sy * -1);
Chavi Weingartena5aedbd2021-04-09 13:37:33 +0000536}
537
chaviw71c2cc42020-10-23 16:42:02 -0700538void BLASTBufferQueue::setTransactionCompleteCallback(
539 uint64_t frameNumber, std::function<void(int64_t)>&& transactionCompleteCallback) {
540 std::lock_guard _lock{mMutex};
541 if (transactionCompleteCallback == nullptr) {
542 mTransactionCompleteCallback = nullptr;
543 } else {
544 mTransactionCompleteCallback = std::move(transactionCompleteCallback);
545 mTransactionCompleteFrameNumber = frameNumber;
546 }
547}
548
Vishnu Nairbf255772020-10-16 10:54:41 -0700549// Check if we have acquired the maximum number of buffers.
Vishnu Nair8b30dd12021-01-25 14:16:54 -0800550// Consumer can acquire an additional buffer if that buffer is not droppable. Set
551// includeExtraAcquire is true to include this buffer to the count. Since this depends on the state
552// of the buffer, the next acquire may return with NO_BUFFER_AVAILABLE.
553bool BLASTBufferQueue::maxBuffersAcquired(bool includeExtraAcquire) const {
554 int maxAcquiredBuffers = MAX_ACQUIRED_BUFFERS + (includeExtraAcquire ? 2 : 1);
Vishnu Nair1506b182021-02-22 14:35:15 -0800555 return mNumAcquired == maxAcquiredBuffers;
Vishnu Nairbf255772020-10-16 10:54:41 -0700556}
557
Robert Carr05086b22020-10-13 18:22:51 -0700558class BBQSurface : public Surface {
Robert Carr9c006e02020-10-14 13:41:57 -0700559private:
560 sp<BLASTBufferQueue> mBbq;
Robert Carr05086b22020-10-13 18:22:51 -0700561public:
Vishnu Nair992496b2020-10-22 17:27:21 -0700562 BBQSurface(const sp<IGraphicBufferProducer>& igbp, bool controlledByApp,
563 const sp<IBinder>& scHandle, const sp<BLASTBufferQueue>& bbq)
564 : Surface(igbp, controlledByApp, scHandle), mBbq(bbq) {}
Robert Carr9c006e02020-10-14 13:41:57 -0700565
Robert Carr05086b22020-10-13 18:22:51 -0700566 void allocateBuffers() override {
567 uint32_t reqWidth = mReqWidth ? mReqWidth : mUserWidth;
568 uint32_t reqHeight = mReqHeight ? mReqHeight : mUserHeight;
569 auto gbp = getIGraphicBufferProducer();
570 std::thread ([reqWidth, reqHeight, gbp=getIGraphicBufferProducer(),
571 reqFormat=mReqFormat, reqUsage=mReqUsage] () {
572 gbp->allocateBuffers(reqWidth, reqHeight,
573 reqFormat, reqUsage);
574
575 }).detach();
576 }
Robert Carr9c006e02020-10-14 13:41:57 -0700577
Marin Shalamanovc5986772021-03-16 16:09:49 +0100578 status_t setFrameRate(float frameRate, int8_t compatibility,
579 int8_t changeFrameRateStrategy) override {
580 if (!ValidateFrameRate(frameRate, compatibility, changeFrameRateStrategy,
581 "BBQSurface::setFrameRate")) {
Robert Carr9c006e02020-10-14 13:41:57 -0700582 return BAD_VALUE;
583 }
Marin Shalamanovc5986772021-03-16 16:09:49 +0100584 return mBbq->setFrameRate(frameRate, compatibility, changeFrameRateStrategy);
Robert Carr9c006e02020-10-14 13:41:57 -0700585 }
Robert Carr9b611b72020-10-19 12:00:23 -0700586
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000587 status_t setFrameTimelineInfo(const FrameTimelineInfo& frameTimelineInfo) override {
588 return mBbq->setFrameTimelineInfo(frameTimelineInfo);
Robert Carr9b611b72020-10-19 12:00:23 -0700589 }
Robert Carr05086b22020-10-13 18:22:51 -0700590};
591
Robert Carr9c006e02020-10-14 13:41:57 -0700592// TODO: Can we coalesce this with frame updates? Need to confirm
593// no timing issues.
Marin Shalamanov46084422020-10-13 12:33:42 +0200594status_t BLASTBufferQueue::setFrameRate(float frameRate, int8_t compatibility,
595 bool shouldBeSeamless) {
Robert Carr9c006e02020-10-14 13:41:57 -0700596 std::unique_lock _lock{mMutex};
597 SurfaceComposerClient::Transaction t;
598
Marin Shalamanov46084422020-10-13 12:33:42 +0200599 return t.setFrameRate(mSurfaceControl, frameRate, compatibility, shouldBeSeamless).apply();
Robert Carr9c006e02020-10-14 13:41:57 -0700600}
601
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000602status_t BLASTBufferQueue::setFrameTimelineInfo(const FrameTimelineInfo& frameTimelineInfo) {
Robert Carr9b611b72020-10-19 12:00:23 -0700603 std::unique_lock _lock{mMutex};
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000604 mNextFrameTimelineInfoQueue.push(frameTimelineInfo);
Jorim Jaggia3fe67b2020-12-01 00:24:33 +0100605 return OK;
Robert Carr9b611b72020-10-19 12:00:23 -0700606}
607
Hongguang Chen621ec582021-02-16 15:42:35 -0800608void BLASTBufferQueue::setSidebandStream(const sp<NativeHandle>& stream) {
609 std::unique_lock _lock{mMutex};
610 SurfaceComposerClient::Transaction t;
611
612 t.setSidebandStream(mSurfaceControl, stream).apply();
613}
614
Vishnu Nair992496b2020-10-22 17:27:21 -0700615sp<Surface> BLASTBufferQueue::getSurface(bool includeSurfaceControlHandle) {
616 std::unique_lock _lock{mMutex};
617 sp<IBinder> scHandle = nullptr;
618 if (includeSurfaceControlHandle && mSurfaceControl) {
619 scHandle = mSurfaceControl->getHandle();
620 }
621 return new BBQSurface(mProducer, true, scHandle, this);
Robert Carr05086b22020-10-13 18:22:51 -0700622}
623
Vishnu Nairc4a40c12020-12-23 09:14:32 -0800624void BLASTBufferQueue::mergeWithNextTransaction(SurfaceComposerClient::Transaction* t,
625 uint64_t frameNumber) {
626 std::lock_guard _lock{mMutex};
627 if (mLastAcquiredFrameNumber >= frameNumber) {
628 // Apply the transaction since we have already acquired the desired frame.
629 t->apply();
630 } else {
chaviwaad6cf52021-03-23 17:27:20 -0500631 mPendingTransactions.emplace_back(frameNumber, *t);
632 // Clear the transaction so it can't be applied elsewhere.
633 t->clear();
Vishnu Nairc4a40c12020-12-23 09:14:32 -0800634 }
635}
636
Vishnu Nair89496122020-12-14 17:14:53 -0800637// Maintains a single worker thread per process that services a list of runnables.
638class AsyncWorker : public Singleton<AsyncWorker> {
639private:
640 std::thread mThread;
641 bool mDone = false;
642 std::deque<std::function<void()>> mRunnables;
643 std::mutex mMutex;
644 std::condition_variable mCv;
645 void run() {
646 std::unique_lock<std::mutex> lock(mMutex);
647 while (!mDone) {
648 mCv.wait(lock);
649 while (!mRunnables.empty()) {
650 std::function<void()> runnable = mRunnables.front();
651 mRunnables.pop_front();
652 runnable();
653 }
654 }
655 }
656
657public:
658 AsyncWorker() : Singleton<AsyncWorker>() { mThread = std::thread(&AsyncWorker::run, this); }
659
660 ~AsyncWorker() {
661 mDone = true;
662 mCv.notify_all();
663 if (mThread.joinable()) {
664 mThread.join();
665 }
666 }
667
668 void post(std::function<void()> runnable) {
669 std::unique_lock<std::mutex> lock(mMutex);
670 mRunnables.emplace_back(std::move(runnable));
671 mCv.notify_one();
672 }
673};
674ANDROID_SINGLETON_STATIC_INSTANCE(AsyncWorker);
675
676// Asynchronously calls ProducerListener functions so we can emulate one way binder calls.
677class AsyncProducerListener : public BnProducerListener {
678private:
679 const sp<IProducerListener> mListener;
680
681public:
682 AsyncProducerListener(const sp<IProducerListener>& listener) : mListener(listener) {}
683
684 void onBufferReleased() override {
685 AsyncWorker::getInstance().post([listener = mListener]() { listener->onBufferReleased(); });
686 }
687
688 void onBuffersDiscarded(const std::vector<int32_t>& slots) override {
689 AsyncWorker::getInstance().post(
690 [listener = mListener, slots = slots]() { listener->onBuffersDiscarded(slots); });
691 }
692};
693
694// Extends the BufferQueueProducer to create a wrapper around the listener so the listener calls
695// can be non-blocking when the producer is in the client process.
696class BBQBufferQueueProducer : public BufferQueueProducer {
697public:
698 BBQBufferQueueProducer(const sp<BufferQueueCore>& core)
699 : BufferQueueProducer(core, false /* consumerIsSurfaceFlinger*/) {}
700
701 status_t connect(const sp<IProducerListener>& listener, int api, bool producerControlledByApp,
702 QueueBufferOutput* output) override {
703 if (!listener) {
704 return BufferQueueProducer::connect(listener, api, producerControlledByApp, output);
705 }
706
707 return BufferQueueProducer::connect(new AsyncProducerListener(listener), api,
708 producerControlledByApp, output);
709 }
Vishnu Nair17dde612020-12-28 11:39:59 -0800710
711 int query(int what, int* value) override {
712 if (what == NATIVE_WINDOW_QUEUES_TO_WINDOW_COMPOSER) {
713 *value = 1;
714 return NO_ERROR;
715 }
716 return BufferQueueProducer::query(what, value);
717 }
Vishnu Nair89496122020-12-14 17:14:53 -0800718};
719
720// Similar to BufferQueue::createBufferQueue but creates an adapter specific bufferqueue producer.
721// This BQP allows invoking client specified ProducerListeners and invoke them asynchronously,
722// emulating one way binder call behavior. Without this, if the listener calls back into the queue,
723// we can deadlock.
724void BLASTBufferQueue::createBufferQueue(sp<IGraphicBufferProducer>* outProducer,
725 sp<IGraphicBufferConsumer>* outConsumer) {
726 LOG_ALWAYS_FATAL_IF(outProducer == nullptr, "BLASTBufferQueue: outProducer must not be NULL");
727 LOG_ALWAYS_FATAL_IF(outConsumer == nullptr, "BLASTBufferQueue: outConsumer must not be NULL");
728
729 sp<BufferQueueCore> core(new BufferQueueCore());
730 LOG_ALWAYS_FATAL_IF(core == nullptr, "BLASTBufferQueue: failed to create BufferQueueCore");
731
732 sp<IGraphicBufferProducer> producer(new BBQBufferQueueProducer(core));
733 LOG_ALWAYS_FATAL_IF(producer == nullptr,
734 "BLASTBufferQueue: failed to create BBQBufferQueueProducer");
735
Vishnu Nair8b30dd12021-01-25 14:16:54 -0800736 sp<BufferQueueConsumer> consumer(new BufferQueueConsumer(core));
737 consumer->setAllowExtraAcquire(true);
Vishnu Nair89496122020-12-14 17:14:53 -0800738 LOG_ALWAYS_FATAL_IF(consumer == nullptr,
739 "BLASTBufferQueue: failed to create BufferQueueConsumer");
740
741 *outProducer = producer;
742 *outConsumer = consumer;
743}
744
chaviw497e81c2021-02-04 17:09:47 -0800745PixelFormat BLASTBufferQueue::convertBufferFormat(PixelFormat& format) {
746 PixelFormat convertedFormat = format;
747 switch (format) {
748 case PIXEL_FORMAT_TRANSPARENT:
749 case PIXEL_FORMAT_TRANSLUCENT:
750 convertedFormat = PIXEL_FORMAT_RGBA_8888;
751 break;
752 case PIXEL_FORMAT_OPAQUE:
753 convertedFormat = PIXEL_FORMAT_RGBX_8888;
754 break;
755 }
756 return convertedFormat;
757}
758
Robert Carr78c25dd2019-08-15 14:10:33 -0700759} // namespace android