blob: 7a95c7841471ff4e7f73b8adbd792320575a0fc3 [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Mark Salyzyna5e161b2016-09-29 08:08:05 -070016#define LOG_TAG "installed"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Alan Stokes753dc712017-10-16 10:56:00 +010018#include <array>
Jeff Sharkey90aff262016-12-12 14:28:24 -070019#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070020#include <stdlib.h>
21#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070022#include <sys/capability.h>
23#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070024#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070025#include <sys/time.h>
26#include <sys/types.h>
27#include <sys/resource.h>
28#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070029#include <unistd.h>
30
Alan Stokes753dc712017-10-16 10:56:00 +010031#include <android-base/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070032#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070033#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070034#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070035#include <android-base/strings.h>
36#include <android-base/unique_fd.h>
Calin Juravle80a21252017-01-17 14:43:25 -080037#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070038#include <cutils/properties.h>
39#include <cutils/sched_policy.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070040#include <log/log.h> // TODO: Move everything to base/logging.
Alan Stokes753dc712017-10-16 10:56:00 +010041#include <openssl/sha.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070042#include <private/android_filesystem_config.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070043#include <selinux/android.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070044#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070045
46#include "dexopt.h"
Jeff Sharkeyc1149c92017-09-21 14:51:09 -060047#include "globals.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070048#include "installd_deps.h"
49#include "otapreopt_utils.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070050#include "utils.h"
51
Jeff Sharkey90aff262016-12-12 14:28:24 -070052using android::base::EndsWith;
Alan Stokes753dc712017-10-16 10:56:00 +010053using android::base::ReadFully;
54using android::base::StringPrintf;
55using android::base::WriteFully;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080056using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070057
58namespace android {
59namespace installd {
60
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070061// Should minidebug info be included in compiled artifacts? Even if this value is
62// "true," usage might still be conditional to other constraints, e.g., system
63// property overrides.
64static constexpr bool kEnableMinidebugInfo = true;
65
66static constexpr const char* kMinidebugInfoSystemProperty = "dalvik.vm.dex2oat-minidebuginfo";
67static constexpr bool kMinidebugInfoSystemPropertyDefault = false;
68static constexpr const char* kMinidebugDex2oatFlag = "--generate-mini-debug-info";
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -080069static constexpr const char* kDisableCompactDexFlag = "--compact-dex-level=none";
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -070070
Calin Juravle114f0812017-03-08 19:05:07 -080071// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
72struct FreeDelete {
73 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
74 void operator()(const void* ptr) const {
75 free(const_cast<void*>(ptr));
76 }
77};
78
79// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
80template <typename T>
81using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
82
Calin Juravle1a0af3b2017-03-09 14:33:33 -080083static unique_fd invalid_unique_fd() {
84 return unique_fd(-1);
85}
86
Andreas Gampe6a9cf722017-07-24 16:49:10 -070087static bool is_debug_runtime() {
88 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
89}
90
David Sehra3b5ab62017-10-25 14:27:29 -070091static bool is_debuggable_build() {
92 return android::base::GetBoolProperty("ro.debuggable", false);
93}
94
Jeff Sharkey90aff262016-12-12 14:28:24 -070095static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -080096 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -070097 if (ufd.get() < 0) {
98 if (errno != ENOENT) {
99 PLOG(WARNING) << "Could not open profile " << profile;
100 return false;
101 } else {
102 // Nothing to clear. That's ok.
103 return true;
104 }
105 }
106
107 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
108 if (errno != EWOULDBLOCK) {
109 PLOG(WARNING) << "Error locking profile " << profile;
110 }
111 // This implies that the app owning this profile is running
112 // (and has acquired the lock).
113 //
114 // If we can't acquire the lock bail out since clearing is useless anyway
115 // (the app will write again to the profile).
116 //
117 // Note:
118 // This does not impact the this is not an issue for the profiling correctness.
119 // In case this is needed because of an app upgrade, profiles will still be
120 // eventually cleared by the app itself due to checksum mismatch.
121 // If this is needed because profman advised, then keeping the data around
122 // until the next run is again not an issue.
123 //
124 // If the app attempts to acquire a lock while we've held one here,
125 // it will simply skip the current write cycle.
126 return false;
127 }
128
129 bool truncated = ftruncate(ufd.get(), 0) == 0;
130 if (!truncated) {
131 PLOG(WARNING) << "Could not truncate " << profile;
132 }
133 if (flock(ufd.get(), LOCK_UN) != 0) {
134 PLOG(WARNING) << "Error unlocking profile " << profile;
135 }
136 return truncated;
137}
138
Calin Juravle114f0812017-03-08 19:05:07 -0800139// Clear the reference profile for the given location.
140// The location is the package name for primary apks or the dex path for secondary dex files.
141static bool clear_reference_profile(const std::string& location, bool is_secondary_dex) {
142 return clear_profile(create_reference_profile_path(location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700143}
144
Calin Juravle114f0812017-03-08 19:05:07 -0800145// Clear the reference profile for the given location.
146// The location is the package name for primary apks or the dex path for secondary dex files.
147static bool clear_current_profile(const std::string& pkgname, userid_t user,
148 bool is_secondary_dex) {
149 return clear_profile(create_current_profile_path(user, pkgname, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700150}
151
Calin Juravle114f0812017-03-08 19:05:07 -0800152// Clear the reference profile for the primary apk of the given package.
153bool clear_primary_reference_profile(const std::string& pkgname) {
154 return clear_reference_profile(pkgname, /*is_secondary_dex*/false);
155}
156
157// Clear all current profile for the primary apk of the given package.
158bool clear_primary_current_profiles(const std::string& pkgname) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700159 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800160 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700161 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
162 for (auto user : users) {
Calin Juravle114f0812017-03-08 19:05:07 -0800163 success &= clear_current_profile(pkgname, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700164 }
165 return success;
166}
167
Calin Juravle114f0812017-03-08 19:05:07 -0800168// Clear the current profile for the primary apk of the given package and user.
169bool clear_primary_current_profile(const std::string& pkgname, userid_t user) {
170 return clear_current_profile(pkgname, user, /*is_secondary_dex*/false);
171}
172
Jeff Sharkey90aff262016-12-12 14:28:24 -0700173static int split_count(const char *str)
174{
175 char *ctx;
176 int count = 0;
177 char buf[kPropertyValueMax];
178
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600179 strlcpy(buf, str, sizeof(buf));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700180 char *pBuf = buf;
181
182 while(strtok_r(pBuf, " ", &ctx) != NULL) {
183 count++;
184 pBuf = NULL;
185 }
186
187 return count;
188}
189
190static int split(char *buf, const char **argv)
191{
192 char *ctx;
193 int count = 0;
194 char *tok;
195 char *pBuf = buf;
196
197 while((tok = strtok_r(pBuf, " ", &ctx)) != NULL) {
198 argv[count++] = tok;
199 pBuf = NULL;
200 }
201
202 return count;
203}
204
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700205static const char* get_location_from_path(const char* path) {
206 static constexpr char kLocationSeparator = '/';
207 const char *location = strrchr(path, kLocationSeparator);
208 if (location == NULL) {
209 return path;
210 } else {
211 // Skip the separator character.
212 return location + 1;
213 }
214}
215
Jeff Sharkey90aff262016-12-12 14:28:24 -0700216static void run_dex2oat(int zip_fd, int oat_fd, int input_vdex_fd, int output_vdex_fd, int image_fd,
217 const char* input_file_name, const char* output_file_name, int swap_fd,
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100218 const char* instruction_set, const char* compiler_filter,
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700219 bool debuggable, bool post_bootcomplete, bool background_job_compile, int profile_fd,
David Sehra3b5ab62017-10-25 14:27:29 -0700220 const char* class_loader_context) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700221 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
222
223 if (strlen(instruction_set) >= MAX_INSTRUCTION_SET_LEN) {
224 ALOGE("Instruction set %s longer than max length of %d",
225 instruction_set, MAX_INSTRUCTION_SET_LEN);
226 return;
227 }
228
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700229 // Get the relative path to the input file.
230 const char* relative_input_file_name = get_location_from_path(input_file_name);
231
Jeff Sharkey90aff262016-12-12 14:28:24 -0700232 char dex2oat_Xms_flag[kPropertyValueMax];
233 bool have_dex2oat_Xms_flag = get_property("dalvik.vm.dex2oat-Xms", dex2oat_Xms_flag, NULL) > 0;
234
235 char dex2oat_Xmx_flag[kPropertyValueMax];
236 bool have_dex2oat_Xmx_flag = get_property("dalvik.vm.dex2oat-Xmx", dex2oat_Xmx_flag, NULL) > 0;
237
238 char dex2oat_threads_buf[kPropertyValueMax];
239 bool have_dex2oat_threads_flag = get_property(post_bootcomplete
240 ? "dalvik.vm.dex2oat-threads"
241 : "dalvik.vm.boot-dex2oat-threads",
242 dex2oat_threads_buf,
243 NULL) > 0;
244 char dex2oat_threads_arg[kPropertyValueMax + 2];
245 if (have_dex2oat_threads_flag) {
246 sprintf(dex2oat_threads_arg, "-j%s", dex2oat_threads_buf);
247 }
248
249 char dex2oat_isa_features_key[kPropertyKeyMax];
250 sprintf(dex2oat_isa_features_key, "dalvik.vm.isa.%s.features", instruction_set);
251 char dex2oat_isa_features[kPropertyValueMax];
252 bool have_dex2oat_isa_features = get_property(dex2oat_isa_features_key,
253 dex2oat_isa_features, NULL) > 0;
254
255 char dex2oat_isa_variant_key[kPropertyKeyMax];
256 sprintf(dex2oat_isa_variant_key, "dalvik.vm.isa.%s.variant", instruction_set);
257 char dex2oat_isa_variant[kPropertyValueMax];
258 bool have_dex2oat_isa_variant = get_property(dex2oat_isa_variant_key,
259 dex2oat_isa_variant, NULL) > 0;
260
261 const char *dex2oat_norelocation = "-Xnorelocate";
262 bool have_dex2oat_relocation_skip_flag = false;
263
264 char dex2oat_flags[kPropertyValueMax];
265 int dex2oat_flags_count = get_property("dalvik.vm.dex2oat-flags",
266 dex2oat_flags, NULL) <= 0 ? 0 : split_count(dex2oat_flags);
267 ALOGV("dalvik.vm.dex2oat-flags=%s\n", dex2oat_flags);
268
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100269 // If we are booting without the real /data, don't spend time compiling.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700270 char vold_decrypt[kPropertyValueMax];
271 bool have_vold_decrypt = get_property("vold.decrypt", vold_decrypt, "") > 0;
272 bool skip_compilation = (have_vold_decrypt &&
273 (strcmp(vold_decrypt, "trigger_restart_min_framework") == 0 ||
274 (strcmp(vold_decrypt, "1") == 0)));
275
276 bool generate_debug_info = property_get_bool("debug.generate-debug-info", false);
277
278 char app_image_format[kPropertyValueMax];
279 char image_format_arg[strlen("--image-format=") + kPropertyValueMax];
280 bool have_app_image_format =
281 image_fd >= 0 && get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
282 if (have_app_image_format) {
283 sprintf(image_format_arg, "--image-format=%s", app_image_format);
284 }
285
286 char dex2oat_large_app_threshold[kPropertyValueMax];
287 bool have_dex2oat_large_app_threshold =
288 get_property("dalvik.vm.dex2oat-very-large", dex2oat_large_app_threshold, NULL) > 0;
289 char dex2oat_large_app_threshold_arg[strlen("--very-large-app-threshold=") + kPropertyValueMax];
290 if (have_dex2oat_large_app_threshold) {
291 sprintf(dex2oat_large_app_threshold_arg,
292 "--very-large-app-threshold=%s",
293 dex2oat_large_app_threshold);
294 }
295
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700296 // If the runtime was requested to use libartd.so, we'll run dex2oatd, otherwise dex2oat.
David Sehra3b5ab62017-10-25 14:27:29 -0700297 const char* dex2oat_bin = "/system/bin/dex2oat";
298 static const char* kDex2oatDebugPath = "/system/bin/dex2oatd";
Andreas Gampea73a0cb2017-11-02 18:14:42 -0700299 if (is_debug_runtime() || (background_job_compile && is_debuggable_build())) {
David Sehra3b5ab62017-10-25 14:27:29 -0700300 DCHECK(access(kDex2oatDebugPath, X_OK) == 0);
301 dex2oat_bin = kDex2oatDebugPath;
302 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700303
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700304 bool generate_minidebug_info = kEnableMinidebugInfo &&
305 android::base::GetBoolProperty(kMinidebugInfoSystemProperty,
306 kMinidebugInfoSystemPropertyDefault);
307
Jeff Sharkey90aff262016-12-12 14:28:24 -0700308 static const char* RUNTIME_ARG = "--runtime-arg";
309
310 static const int MAX_INT_LEN = 12; // '-'+10dig+'\0' -OR- 0x+8dig
311
George Burgess IV36cebe772017-01-25 11:52:01 -0800312 // clang FORTIFY doesn't let us use strlen in constant array bounds, so we
313 // use arraysize instead.
314 char zip_fd_arg[arraysize("--zip-fd=") + MAX_INT_LEN];
315 char zip_location_arg[arraysize("--zip-location=") + PKG_PATH_MAX];
316 char input_vdex_fd_arg[arraysize("--input-vdex-fd=") + MAX_INT_LEN];
317 char output_vdex_fd_arg[arraysize("--output-vdex-fd=") + MAX_INT_LEN];
318 char oat_fd_arg[arraysize("--oat-fd=") + MAX_INT_LEN];
319 char oat_location_arg[arraysize("--oat-location=") + PKG_PATH_MAX];
320 char instruction_set_arg[arraysize("--instruction-set=") + MAX_INSTRUCTION_SET_LEN];
321 char instruction_set_variant_arg[arraysize("--instruction-set-variant=") + kPropertyValueMax];
322 char instruction_set_features_arg[arraysize("--instruction-set-features=") + kPropertyValueMax];
323 char dex2oat_Xms_arg[arraysize("-Xms") + kPropertyValueMax];
324 char dex2oat_Xmx_arg[arraysize("-Xmx") + kPropertyValueMax];
325 char dex2oat_compiler_filter_arg[arraysize("--compiler-filter=") + kPropertyValueMax];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700326 bool have_dex2oat_swap_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800327 char dex2oat_swap_fd[arraysize("--swap-fd=") + MAX_INT_LEN];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700328 bool have_dex2oat_image_fd = false;
George Burgess IV36cebe772017-01-25 11:52:01 -0800329 char dex2oat_image_fd[arraysize("--app-image-fd=") + MAX_INT_LEN];
Calin Juravle52c45822017-07-13 22:50:21 -0700330 size_t class_loader_context_size = arraysize("--class-loader-context=") + PKG_PATH_MAX;
331 char class_loader_context_arg[class_loader_context_size];
332 if (class_loader_context != nullptr) {
333 snprintf(class_loader_context_arg, class_loader_context_size, "--class-loader-context=%s",
334 class_loader_context);
335 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700336
337 sprintf(zip_fd_arg, "--zip-fd=%d", zip_fd);
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700338 sprintf(zip_location_arg, "--zip-location=%s", relative_input_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700339 sprintf(input_vdex_fd_arg, "--input-vdex-fd=%d", input_vdex_fd);
340 sprintf(output_vdex_fd_arg, "--output-vdex-fd=%d", output_vdex_fd);
341 sprintf(oat_fd_arg, "--oat-fd=%d", oat_fd);
342 sprintf(oat_location_arg, "--oat-location=%s", output_file_name);
343 sprintf(instruction_set_arg, "--instruction-set=%s", instruction_set);
344 sprintf(instruction_set_variant_arg, "--instruction-set-variant=%s", dex2oat_isa_variant);
345 sprintf(instruction_set_features_arg, "--instruction-set-features=%s", dex2oat_isa_features);
346 if (swap_fd >= 0) {
347 have_dex2oat_swap_fd = true;
348 sprintf(dex2oat_swap_fd, "--swap-fd=%d", swap_fd);
349 }
350 if (image_fd >= 0) {
351 have_dex2oat_image_fd = true;
352 sprintf(dex2oat_image_fd, "--app-image-fd=%d", image_fd);
353 }
354
355 if (have_dex2oat_Xms_flag) {
356 sprintf(dex2oat_Xms_arg, "-Xms%s", dex2oat_Xms_flag);
357 }
358 if (have_dex2oat_Xmx_flag) {
359 sprintf(dex2oat_Xmx_arg, "-Xmx%s", dex2oat_Xmx_flag);
360 }
361
362 // Compute compiler filter.
363
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100364 bool have_dex2oat_compiler_filter_flag = false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700365 if (skip_compilation) {
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600366 strlcpy(dex2oat_compiler_filter_arg, "--compiler-filter=extract",
367 sizeof(dex2oat_compiler_filter_arg));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700368 have_dex2oat_compiler_filter_flag = true;
369 have_dex2oat_relocation_skip_flag = true;
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100370 } else if (compiler_filter != nullptr) {
371 if (strlen(compiler_filter) + strlen("--compiler-filter=") <
Jeff Sharkey90aff262016-12-12 14:28:24 -0700372 arraysize(dex2oat_compiler_filter_arg)) {
Nicolas Geoffraybe6ecd62017-05-03 13:21:37 +0100373 sprintf(dex2oat_compiler_filter_arg, "--compiler-filter=%s", compiler_filter);
374 have_dex2oat_compiler_filter_flag = true;
375 } else {
376 ALOGW("Compiler filter name '%s' is too large (max characters is %zu)",
377 compiler_filter,
378 kPropertyValueMax);
379 }
380 }
381
382 if (!have_dex2oat_compiler_filter_flag) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700383 char dex2oat_compiler_filter_flag[kPropertyValueMax];
384 have_dex2oat_compiler_filter_flag = get_property("dalvik.vm.dex2oat-filter",
385 dex2oat_compiler_filter_flag, NULL) > 0;
386 if (have_dex2oat_compiler_filter_flag) {
387 sprintf(dex2oat_compiler_filter_arg,
388 "--compiler-filter=%s",
389 dex2oat_compiler_filter_flag);
390 }
391 }
392
393 // Check whether all apps should be compiled debuggable.
394 if (!debuggable) {
395 char prop_buf[kPropertyValueMax];
396 debuggable =
397 (get_property("dalvik.vm.always_debuggable", prop_buf, "0") > 0) &&
398 (prop_buf[0] == '1');
399 }
400 char profile_arg[strlen("--profile-file-fd=") + MAX_INT_LEN];
401 if (profile_fd != -1) {
402 sprintf(profile_arg, "--profile-file-fd=%d", profile_fd);
403 }
404
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700405 // Get the directory of the apk to pass as a base classpath directory.
406 char base_dir[arraysize("--classpath-dir=") + PKG_PATH_MAX];
407 std::string apk_dir(input_file_name);
408 unsigned long dir_index = apk_dir.rfind('/');
409 bool has_base_dir = dir_index != std::string::npos;
410 if (has_base_dir) {
411 apk_dir = apk_dir.substr(0, dir_index);
412 sprintf(base_dir, "--classpath-dir=%s", apk_dir.c_str());
413 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700414
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700415
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700416 ALOGV("Running %s in=%s out=%s\n", dex2oat_bin, relative_input_file_name, output_file_name);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700417
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800418 // Disable cdex if update input vdex is true since this combination of options is not
419 // supported.
420 const bool disable_cdex = input_vdex_fd == output_vdex_fd;
421
Jeff Sharkey90aff262016-12-12 14:28:24 -0700422 const char* argv[9 // program name, mandatory arguments and the final NULL
423 + (have_dex2oat_isa_variant ? 1 : 0)
424 + (have_dex2oat_isa_features ? 1 : 0)
425 + (have_dex2oat_Xms_flag ? 2 : 0)
426 + (have_dex2oat_Xmx_flag ? 2 : 0)
427 + (have_dex2oat_compiler_filter_flag ? 1 : 0)
428 + (have_dex2oat_threads_flag ? 1 : 0)
429 + (have_dex2oat_swap_fd ? 1 : 0)
430 + (have_dex2oat_image_fd ? 1 : 0)
431 + (have_dex2oat_relocation_skip_flag ? 2 : 0)
432 + (generate_debug_info ? 1 : 0)
433 + (debuggable ? 1 : 0)
434 + (have_app_image_format ? 1 : 0)
435 + dex2oat_flags_count
436 + (profile_fd == -1 ? 0 : 1)
Calin Juravle52c45822017-07-13 22:50:21 -0700437 + (class_loader_context != nullptr ? 1 : 0)
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700438 + (has_base_dir ? 1 : 0)
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700439 + (have_dex2oat_large_app_threshold ? 1 : 0)
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800440 + (disable_cdex ? 1 : 0)
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700441 + (generate_minidebug_info ? 1 : 0)];
Jeff Sharkey90aff262016-12-12 14:28:24 -0700442 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700443 argv[i++] = dex2oat_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700444 argv[i++] = zip_fd_arg;
445 argv[i++] = zip_location_arg;
446 argv[i++] = input_vdex_fd_arg;
447 argv[i++] = output_vdex_fd_arg;
448 argv[i++] = oat_fd_arg;
449 argv[i++] = oat_location_arg;
450 argv[i++] = instruction_set_arg;
451 if (have_dex2oat_isa_variant) {
452 argv[i++] = instruction_set_variant_arg;
453 }
454 if (have_dex2oat_isa_features) {
455 argv[i++] = instruction_set_features_arg;
456 }
457 if (have_dex2oat_Xms_flag) {
458 argv[i++] = RUNTIME_ARG;
459 argv[i++] = dex2oat_Xms_arg;
460 }
461 if (have_dex2oat_Xmx_flag) {
462 argv[i++] = RUNTIME_ARG;
463 argv[i++] = dex2oat_Xmx_arg;
464 }
465 if (have_dex2oat_compiler_filter_flag) {
466 argv[i++] = dex2oat_compiler_filter_arg;
467 }
468 if (have_dex2oat_threads_flag) {
469 argv[i++] = dex2oat_threads_arg;
470 }
471 if (have_dex2oat_swap_fd) {
472 argv[i++] = dex2oat_swap_fd;
473 }
474 if (have_dex2oat_image_fd) {
475 argv[i++] = dex2oat_image_fd;
476 }
477 if (generate_debug_info) {
478 argv[i++] = "--generate-debug-info";
479 }
480 if (debuggable) {
481 argv[i++] = "--debuggable";
482 }
483 if (have_app_image_format) {
484 argv[i++] = image_format_arg;
485 }
486 if (have_dex2oat_large_app_threshold) {
487 argv[i++] = dex2oat_large_app_threshold_arg;
488 }
489 if (dex2oat_flags_count) {
490 i += split(dex2oat_flags, argv + i);
491 }
492 if (have_dex2oat_relocation_skip_flag) {
493 argv[i++] = RUNTIME_ARG;
494 argv[i++] = dex2oat_norelocation;
495 }
496 if (profile_fd != -1) {
497 argv[i++] = profile_arg;
498 }
Jeff Hao10b8a6e2017-04-05 17:11:39 -0700499 if (has_base_dir) {
500 argv[i++] = base_dir;
501 }
Calin Juravle52c45822017-07-13 22:50:21 -0700502 if (class_loader_context != nullptr) {
503 argv[i++] = class_loader_context_arg;
504 }
Andreas Gampe2a2d7ba2017-11-02 19:39:29 -0700505 if (generate_minidebug_info) {
506 argv[i++] = kMinidebugDex2oatFlag;
507 }
Mathieu Chartierb41ffcc2018-01-09 00:02:17 -0800508 if (disable_cdex) {
509 argv[i++] = kDisableCompactDexFlag;
510 }
Calin Juravle52c45822017-07-13 22:50:21 -0700511
Jeff Sharkey90aff262016-12-12 14:28:24 -0700512 // Do not add after dex2oat_flags, they should override others for debugging.
513 argv[i] = NULL;
514
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700515 execv(dex2oat_bin, (char * const *)argv);
516 ALOGE("execv(%s) failed: %s\n", dex2oat_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700517}
518
519/*
520 * Whether dexopt should use a swap file when compiling an APK.
521 *
522 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
523 * itself, anyways).
524 *
525 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
526 *
527 * Otherwise, return true if this is a low-mem device.
528 *
529 * Otherwise, return default value.
530 */
531static bool kAlwaysProvideSwapFile = false;
532static bool kDefaultProvideSwapFile = true;
533
534static bool ShouldUseSwapFileForDexopt() {
535 if (kAlwaysProvideSwapFile) {
536 return true;
537 }
538
539 // Check the "override" property. If it exists, return value == "true".
540 char dex2oat_prop_buf[kPropertyValueMax];
541 if (get_property("dalvik.vm.dex2oat-swap", dex2oat_prop_buf, "") > 0) {
542 if (strcmp(dex2oat_prop_buf, "true") == 0) {
543 return true;
544 } else {
545 return false;
546 }
547 }
548
549 // Shortcut for default value. This is an implementation optimization for the process sketched
550 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
551 // as low-mem is never returning false. The compiler will optimize this away if it can.
552 if (kDefaultProvideSwapFile) {
553 return true;
554 }
555
556 bool is_low_mem = property_get_bool("ro.config.low_ram", false);
557 if (is_low_mem) {
558 return true;
559 }
560
561 // Default value must be false here.
562 return kDefaultProvideSwapFile;
563}
564
Richard Uhler76cc0272016-12-08 10:46:35 +0000565static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700566 if (set_to_bg) {
567 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
568 ALOGE("set_sched_policy failed: %s\n", strerror(errno));
569 exit(70);
570 }
571 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
572 ALOGE("setpriority failed: %s\n", strerror(errno));
573 exit(71);
574 }
575 }
576}
577
Calin Juravle29591732017-11-20 17:46:19 -0800578static unique_fd create_profile(uid_t uid, const std::string& profile, int32_t flags) {
579 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags, 0600)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800580 if (fd.get() < 0) {
Calin Juravle29591732017-11-20 17:46:19 -0800581 if (errno != EEXIST) {
Calin Juravle114f0812017-03-08 19:05:07 -0800582 PLOG(ERROR) << "Failed to create profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800583 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800584 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700585 }
Calin Juravle114f0812017-03-08 19:05:07 -0800586 // Profiles should belong to the app; make sure of that by giving ownership to
587 // the app uid. If we cannot do that, there's no point in returning the fd
588 // since dex2oat/profman will fail with SElinux denials.
589 if (fchown(fd.get(), uid, uid) < 0) {
590 PLOG(ERROR) << "Could not chwon profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800591 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800592 }
Calin Juravle29591732017-11-20 17:46:19 -0800593 return fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800594}
595
Calin Juravle29591732017-11-20 17:46:19 -0800596static unique_fd open_profile(uid_t uid, const std::string& profile, int32_t flags) {
Calin Juravle114f0812017-03-08 19:05:07 -0800597 // Do not follow symlinks when opening a profile:
598 // - primary profiles should not contain symlinks in their paths
599 // - secondary dex paths should have been already resolved and validated
600 flags |= O_NOFOLLOW;
601
Calin Juravle29591732017-11-20 17:46:19 -0800602 // Check if we need to create the profile
603 // Reference profiles and snapshots are created on the fly; so they might not exist beforehand.
604 unique_fd fd;
605 if ((flags & O_CREAT) != 0) {
606 fd = create_profile(uid, profile, flags);
607 } else {
608 fd.reset(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
609 }
610
Calin Juravle114f0812017-03-08 19:05:07 -0800611 if (fd.get() < 0) {
612 if (errno != ENOENT) {
613 // Profiles might be missing for various reasons. For example, in a
614 // multi-user environment, the profile directory for one user can be created
615 // after we start a merge. In this case the current profile for that user
616 // will not be found.
617 // Also, the secondary dex profiles might be deleted by the app at any time,
618 // so we can't we need to prepare if they are missing.
619 PLOG(ERROR) << "Failed to open profile " << profile;
620 }
621 return invalid_unique_fd();
622 }
623
Jeff Sharkey90aff262016-12-12 14:28:24 -0700624 return fd;
625}
626
Calin Juravle114f0812017-03-08 19:05:07 -0800627static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& location,
628 bool is_secondary_dex) {
629 std::string profile = create_current_profile_path(user, location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800630 return open_profile(uid, profile, O_RDONLY);
Calin Juravle114f0812017-03-08 19:05:07 -0800631}
632
633static unique_fd open_reference_profile(uid_t uid, const std::string& location, bool read_write,
634 bool is_secondary_dex) {
635 std::string profile = create_reference_profile_path(location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800636 return open_profile(uid, profile, read_write ? (O_CREAT | O_RDWR) : O_RDONLY);
637}
638
639static unique_fd open_spnashot_profile(uid_t uid, const std::string& package_name,
640 const std::string& code_path) {
641 std::string profile = create_snapshot_profile_path(package_name, code_path);
642 return open_profile(uid, profile, O_CREAT | O_RDWR | O_TRUNC);
Calin Juravle114f0812017-03-08 19:05:07 -0800643}
644
645static void open_profile_files(uid_t uid, const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800646 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700647 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle114f0812017-03-08 19:05:07 -0800648 *reference_profile_fd = open_reference_profile(uid, location, /*read_write*/ true,
649 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700650
Calin Juravle114f0812017-03-08 19:05:07 -0800651 // For secondary dex files, we don't really need the user but we use it for sanity checks.
652 // Note: the user owning the dex file should be the current user.
653 std::vector<userid_t> users;
654 if (is_secondary_dex){
655 users.push_back(multiuser_get_user_id(uid));
656 } else {
657 users = get_known_users(/*volume_uuid*/ nullptr);
658 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700659 for (auto user : users) {
Calin Juravle114f0812017-03-08 19:05:07 -0800660 unique_fd profile_fd = open_current_profile(uid, user, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700661 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800662 if (profile_fd.get() >= 0) {
663 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700664 }
665 }
666}
667
668static void drop_capabilities(uid_t uid) {
669 if (setgid(uid) != 0) {
670 ALOGE("setgid(%d) failed in installd during dexopt\n", uid);
671 exit(64);
672 }
673 if (setuid(uid) != 0) {
674 ALOGE("setuid(%d) failed in installd during dexopt\n", uid);
675 exit(65);
676 }
677 // drop capabilities
678 struct __user_cap_header_struct capheader;
679 struct __user_cap_data_struct capdata[2];
680 memset(&capheader, 0, sizeof(capheader));
681 memset(&capdata, 0, sizeof(capdata));
682 capheader.version = _LINUX_CAPABILITY_VERSION_3;
683 if (capset(&capheader, &capdata[0]) < 0) {
684 ALOGE("capset failed: %s\n", strerror(errno));
685 exit(66);
686 }
687}
688
689static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 0;
690static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION = 1;
691static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 2;
692static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 3;
693static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 4;
694
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800695static void run_profman_merge(const std::vector<unique_fd>& profiles_fd,
696 const unique_fd& reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700697 static const size_t MAX_INT_LEN = 32;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700698 const char* profman_bin = is_debug_runtime() ? "/system/bin/profmand" : "/system/bin/profman";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700699
700 std::vector<std::string> profile_args(profiles_fd.size());
701 char profile_buf[strlen("--profile-file-fd=") + MAX_INT_LEN];
702 for (size_t k = 0; k < profiles_fd.size(); k++) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800703 sprintf(profile_buf, "--profile-file-fd=%d", profiles_fd[k].get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700704 profile_args[k].assign(profile_buf);
705 }
706 char reference_profile_arg[strlen("--reference-profile-file-fd=") + MAX_INT_LEN];
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800707 sprintf(reference_profile_arg, "--reference-profile-file-fd=%d", reference_profile_fd.get());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700708
709 // program name, reference profile fd, the final NULL and the profile fds
710 const char* argv[3 + profiles_fd.size()];
711 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700712 argv[i++] = profman_bin;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700713 argv[i++] = reference_profile_arg;
714 for (size_t k = 0; k < profile_args.size(); k++) {
715 argv[i++] = profile_args[k].c_str();
716 }
717 // Do not add after dex2oat_flags, they should override others for debugging.
718 argv[i] = NULL;
719
Andreas Gampe6a9cf722017-07-24 16:49:10 -0700720 execv(profman_bin, (char * const *)argv);
721 ALOGE("execv(%s) failed: %s\n", profman_bin, strerror(errno));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700722 exit(68); /* only get here on exec failure */
723}
724
725// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800726// The location is the package name for primary apks or the dex path for secondary dex files.
727// Returns true if there is enough information in the current profiles that makes it
728// worth to recompile the given location.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700729// If the return value is true all the current profiles would have been merged into
730// the reference profiles accessible with open_reference_profile().
Calin Juravle114f0812017-03-08 19:05:07 -0800731static bool analyze_profiles(uid_t uid, const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800732 std::vector<unique_fd> profiles_fd;
733 unique_fd reference_profile_fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800734 open_profile_files(uid, location, is_secondary_dex, &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800735 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700736 // Skip profile guided compilation because no profiles were found.
737 // Or if the reference profile info couldn't be opened.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700738 return false;
739 }
740
Jeff Sharkey90aff262016-12-12 14:28:24 -0700741 pid_t pid = fork();
742 if (pid == 0) {
743 /* child -- drop privileges before continuing */
744 drop_capabilities(uid);
745 run_profman_merge(profiles_fd, reference_profile_fd);
746 exit(68); /* only get here on exec failure */
747 }
748 /* parent */
749 int return_code = wait_child(pid);
750 bool need_to_compile = false;
751 bool should_clear_current_profiles = false;
752 bool should_clear_reference_profile = false;
753 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800754 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700755 } else {
756 return_code = WEXITSTATUS(return_code);
757 switch (return_code) {
758 case PROFMAN_BIN_RETURN_CODE_COMPILE:
759 need_to_compile = true;
760 should_clear_current_profiles = true;
761 should_clear_reference_profile = false;
762 break;
763 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION:
764 need_to_compile = false;
765 should_clear_current_profiles = false;
766 should_clear_reference_profile = false;
767 break;
768 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800769 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700770 need_to_compile = false;
771 should_clear_current_profiles = true;
772 should_clear_reference_profile = true;
773 break;
774 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
775 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
776 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800777 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700778 need_to_compile = false;
779 should_clear_current_profiles = false;
780 should_clear_reference_profile = false;
781 break;
782 default:
783 // Unknown return code or error. Unlink profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800784 LOG(WARNING) << "Unknown error code while processing profiles for location "
785 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700786 need_to_compile = false;
787 should_clear_current_profiles = true;
788 should_clear_reference_profile = true;
789 break;
790 }
791 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800792
Jeff Sharkey90aff262016-12-12 14:28:24 -0700793 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800794 if (is_secondary_dex) {
795 // For secondary dex files, the owning user is the current user.
796 clear_current_profile(location, multiuser_get_user_id(uid), is_secondary_dex);
797 } else {
798 clear_primary_current_profiles(location);
799 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700800 }
801 if (should_clear_reference_profile) {
Calin Juravle114f0812017-03-08 19:05:07 -0800802 clear_reference_profile(location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700803 }
804 return need_to_compile;
805}
806
Calin Juravle114f0812017-03-08 19:05:07 -0800807// Decides if profile guided compilation is needed or not based on existing profiles.
808// The analysis is done for the primary apks of the given package.
809// Returns true if there is enough information in the current profiles that makes it
810// worth to recompile the package.
811// If the return value is true all the current profiles would have been merged into
812// the reference profiles accessible with open_reference_profile().
813bool analyze_primary_profiles(uid_t uid, const std::string& pkgname) {
814 return analyze_profiles(uid, pkgname, /*is_secondary_dex*/false);
815}
816
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800817static void run_profman_dump(const std::vector<unique_fd>& profile_fds,
818 const unique_fd& reference_profile_fd,
Jeff Sharkey90aff262016-12-12 14:28:24 -0700819 const std::vector<std::string>& dex_locations,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800820 const std::vector<unique_fd>& apk_fds,
821 const unique_fd& output_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700822 std::vector<std::string> profman_args;
823 static const char* PROFMAN_BIN = "/system/bin/profman";
824 profman_args.push_back(PROFMAN_BIN);
825 profman_args.push_back("--dump-only");
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800826 profman_args.push_back(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700827 if (reference_profile_fd != -1) {
828 profman_args.push_back(StringPrintf("--reference-profile-file-fd=%d",
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800829 reference_profile_fd.get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700830 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800831 for (size_t i = 0; i < profile_fds.size(); i++) {
832 profman_args.push_back(StringPrintf("--profile-file-fd=%d", profile_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700833 }
834 for (const std::string& dex_location : dex_locations) {
835 profman_args.push_back(StringPrintf("--dex-location=%s", dex_location.c_str()));
836 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800837 for (size_t i = 0; i < apk_fds.size(); i++) {
838 profman_args.push_back(StringPrintf("--apk-fd=%d", apk_fds[i].get()));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700839 }
840 const char **argv = new const char*[profman_args.size() + 1];
841 size_t i = 0;
842 for (const std::string& profman_arg : profman_args) {
843 argv[i++] = profman_arg.c_str();
844 }
845 argv[i] = NULL;
846
847 execv(PROFMAN_BIN, (char * const *)argv);
848 ALOGE("execv(%s) failed: %s\n", PROFMAN_BIN, strerror(errno));
849 exit(68); /* only get here on exec failure */
850}
851
Calin Juravle76268c52017-03-09 13:19:42 -0800852bool dump_profiles(int32_t uid, const std::string& pkgname, const char* code_paths) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800853 std::vector<unique_fd> profile_fds;
854 unique_fd reference_profile_fd;
Calin Juravle76268c52017-03-09 13:19:42 -0800855 std::string out_file_name = StringPrintf("/data/misc/profman/%s.txt", pkgname.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700856
Calin Juravle114f0812017-03-08 19:05:07 -0800857 open_profile_files(uid, pkgname, /*is_secondary_dex*/false,
858 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700859
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800860 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700861 const bool has_profiles = !profile_fds.empty();
862
863 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800864 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700865 return false;
866 }
867
Calin Juravle114f0812017-03-08 19:05:07 -0800868 unique_fd output_fd(open(out_file_name.c_str(),
869 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700870 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
871 ALOGE("installd cannot chmod '%s' dump_profile\n", out_file_name.c_str());
872 return false;
873 }
874 std::vector<std::string> code_full_paths = base::Split(code_paths, ";");
875 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800876 std::vector<unique_fd> apk_fds;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700877 for (const std::string& code_full_path : code_full_paths) {
878 const char* full_path = code_full_path.c_str();
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800879 unique_fd apk_fd(open(full_path, O_RDONLY | O_NOFOLLOW));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700880 if (apk_fd == -1) {
881 ALOGE("installd cannot open '%s'\n", full_path);
882 return false;
883 }
884 dex_locations.push_back(get_location_from_path(full_path));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800885 apk_fds.push_back(std::move(apk_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700886 }
887
888 pid_t pid = fork();
889 if (pid == 0) {
890 /* child -- drop privileges before continuing */
891 drop_capabilities(uid);
892 run_profman_dump(profile_fds, reference_profile_fd, dex_locations,
893 apk_fds, output_fd);
894 exit(68); /* only get here on exec failure */
895 }
896 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700897 int return_code = wait_child(pid);
898 if (!WIFEXITED(return_code)) {
899 LOG(WARNING) << "profman failed for package " << pkgname << ": "
900 << return_code;
901 return false;
902 }
903 return true;
904}
905
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700906bool copy_system_profile(const std::string& system_profile,
907 uid_t packageUid, const std::string& data_profile_location) {
908 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
909 unique_fd out_fd(open_reference_profile(packageUid,
910 data_profile_location,
911 /*read_write*/ true,
912 /*secondary*/ false));
913 if (in_fd.get() < 0) {
914 PLOG(WARNING) << "Could not open profile " << system_profile;
915 return false;
916 }
917 if (out_fd.get() < 0) {
918 PLOG(WARNING) << "Could not open profile " << data_profile_location;
919 return false;
920 }
921
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700922 // As a security measure we want to write the profile information with the reduced capabilities
923 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700924 pid_t pid = fork();
925 if (pid == 0) {
926 /* child -- drop privileges before continuing */
927 drop_capabilities(packageUid);
928
929 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
930 if (errno != EWOULDBLOCK) {
931 PLOG(WARNING) << "Error locking profile " << data_profile_location;
932 }
933 // This implies that the app owning this profile is running
934 // (and has acquired the lock).
935 //
936 // The app never acquires the lock for the reference profiles of primary apks.
937 // Only dex2oat from installd will do that. Since installd is single threaded
938 // we should not see this case. Nevertheless be prepared for it.
939 PLOG(WARNING) << "Failed to flock " << data_profile_location;
940 return false;
941 }
942
943 bool truncated = ftruncate(out_fd.get(), 0) == 0;
944 if (!truncated) {
945 PLOG(WARNING) << "Could not truncate " << data_profile_location;
946 }
947
948 // Copy over data.
949 static constexpr size_t kBufferSize = 4 * 1024;
950 char buffer[kBufferSize];
951 while (true) {
952 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
953 if (bytes == 0) {
954 break;
955 }
956 write(out_fd.get(), buffer, bytes);
957 }
958 if (flock(out_fd.get(), LOCK_UN) != 0) {
959 PLOG(WARNING) << "Error unlocking profile " << data_profile_location;
960 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700961 // Use _exit since we don't want to run the global destructors in the child.
962 // b/62597429
963 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700964 }
965 /* parent */
966 int return_code = wait_child(pid);
967 return return_code == 0;
968}
969
Jeff Sharkey90aff262016-12-12 14:28:24 -0700970static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
971 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
972 if (EndsWith(oat_path, ".dex")) {
973 std::string new_path = oat_path;
974 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
Elliott Hughes969e4f82017-12-20 12:34:09 -0800975 CHECK(EndsWith(new_path, new_ext));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700976 return new_path;
977 }
978
979 // An odex entry. Not that this may not be an extension, e.g., in the OTA
980 // case (where the base name will have an extension for the B artifact).
981 size_t odex_pos = oat_path.rfind(".odex");
982 if (odex_pos != std::string::npos) {
983 std::string new_path = oat_path;
984 new_path.replace(odex_pos, strlen(".odex"), new_ext);
985 CHECK_NE(new_path.find(new_ext), std::string::npos);
986 return new_path;
987 }
988
989 // Don't know how to handle this.
990 return "";
991}
992
993// Translate the given oat path to an art (app image) path. An empty string
994// denotes an error.
995static std::string create_image_filename(const std::string& oat_path) {
996 return replace_file_extension(oat_path, ".art");
997}
998
999// Translate the given oat path to a vdex path. An empty string denotes an error.
1000static std::string create_vdex_filename(const std::string& oat_path) {
1001 return replace_file_extension(oat_path, ".vdex");
1002}
1003
Jeff Sharkey90aff262016-12-12 14:28:24 -07001004static int open_output_file(const char* file_name, bool recreate, int permissions) {
1005 int flags = O_RDWR | O_CREAT;
1006 if (recreate) {
1007 if (unlink(file_name) < 0) {
1008 if (errno != ENOENT) {
1009 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
1010 }
1011 }
1012 flags |= O_EXCL;
1013 }
1014 return open(file_name, flags, permissions);
1015}
1016
Calin Juravle2289c0a2017-02-15 12:44:14 -08001017static bool set_permissions_and_ownership(
1018 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
1019 // Primary apks are owned by the system. Secondary dex files are owned by the app.
1020 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001021 if (fchmod(fd,
1022 S_IRUSR|S_IWUSR|S_IRGRP |
1023 (is_public ? S_IROTH : 0)) < 0) {
1024 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
1025 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001026 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001027 ALOGE("installd cannot chown '%s' during dexopt\n", path);
1028 return false;
1029 }
1030 return true;
1031}
1032
1033static bool IsOutputDalvikCache(const char* oat_dir) {
1034 // InstallerConnection.java (which invokes installd) transforms Java null arguments
1035 // into '!'. Play it safe by handling it both.
1036 // TODO: ensure we never get null.
1037 // TODO: pass a flag instead of inferring if the output is dalvik cache.
1038 return oat_dir == nullptr || oat_dir[0] == '!';
1039}
1040
Calin Juravled23dee72017-07-06 16:29:11 -07001041// Best-effort check whether we can fit the the path into our buffers.
1042// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
1043// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
1044// extension to the cache path (5 bytes).
1045// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
1046static bool validate_dex_path_size(const std::string& dex_path) {
1047 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
1048 LOG(ERROR) << "dex_path too long: " << dex_path;
1049 return false;
1050 }
1051 return true;
1052}
1053
Jeff Sharkey90aff262016-12-12 14:28:24 -07001054static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001055 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -07001056 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001057 return false;
1058 }
1059
1060 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001061 // Oat dirs for secondary dex files are already validated.
1062 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001063 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
1064 return false;
1065 }
1066 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
1067 return false;
1068 }
1069 } else {
1070 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
1071 return false;
1072 }
1073 }
1074 return true;
1075}
1076
1077// Helper for fd management. This is similar to a unique_fd in that it closes the file descriptor
1078// on destruction. It will also run the given cleanup (unless told not to) after closing.
1079//
1080// Usage example:
1081//
Calin Juravle7a570e82017-01-14 16:23:30 -08001082// Dex2oatFileWrapper file(open(...),
Jeff Sharkey90aff262016-12-12 14:28:24 -07001083// [name]() {
1084// unlink(name.c_str());
1085// });
1086// // Note: care needs to be taken about name, as it needs to have a lifetime longer than the
1087// wrapper if captured as a reference.
1088//
1089// if (file.get() == -1) {
1090// // Error opening...
1091// }
1092//
1093// ...
1094// if (error) {
1095// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will run
1096// // and delete the file (after the fd is closed).
1097// return -1;
1098// }
1099//
1100// (Success case)
1101// file.SetCleanup(false);
1102// // At this point, when the Dex2oatFileWrapper is destructed, the cleanup function will not run
1103// // (leaving the file around; after the fd is closed).
1104//
Jeff Sharkey90aff262016-12-12 14:28:24 -07001105class Dex2oatFileWrapper {
1106 public:
Calin Juravle7a570e82017-01-14 16:23:30 -08001107 Dex2oatFileWrapper() : value_(-1), cleanup_(), do_cleanup_(true), auto_close_(true) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001108 }
1109
Calin Juravle7a570e82017-01-14 16:23:30 -08001110 Dex2oatFileWrapper(int value, std::function<void ()> cleanup)
1111 : value_(value), cleanup_(cleanup), do_cleanup_(true), auto_close_(true) {}
1112
1113 Dex2oatFileWrapper(Dex2oatFileWrapper&& other) {
1114 value_ = other.value_;
1115 cleanup_ = other.cleanup_;
1116 do_cleanup_ = other.do_cleanup_;
1117 auto_close_ = other.auto_close_;
1118 other.release();
1119 }
1120
1121 Dex2oatFileWrapper& operator=(Dex2oatFileWrapper&& other) {
1122 value_ = other.value_;
1123 cleanup_ = other.cleanup_;
1124 do_cleanup_ = other.do_cleanup_;
1125 auto_close_ = other.auto_close_;
1126 other.release();
1127 return *this;
1128 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001129
1130 ~Dex2oatFileWrapper() {
1131 reset(-1);
1132 }
1133
1134 int get() {
1135 return value_;
1136 }
1137
1138 void SetCleanup(bool cleanup) {
1139 do_cleanup_ = cleanup;
1140 }
1141
1142 void reset(int new_value) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001143 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001144 close(value_);
1145 }
1146 if (do_cleanup_ && cleanup_ != nullptr) {
1147 cleanup_();
1148 }
1149
1150 value_ = new_value;
1151 }
1152
Calin Juravle7a570e82017-01-14 16:23:30 -08001153 void reset(int new_value, std::function<void ()> new_cleanup) {
1154 if (auto_close_ && value_ >= 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001155 close(value_);
1156 }
1157 if (do_cleanup_ && cleanup_ != nullptr) {
1158 cleanup_();
1159 }
1160
1161 value_ = new_value;
1162 cleanup_ = new_cleanup;
1163 }
1164
Calin Juravle7a570e82017-01-14 16:23:30 -08001165 void DisableAutoClose() {
1166 auto_close_ = false;
1167 }
1168
Jeff Sharkey90aff262016-12-12 14:28:24 -07001169 private:
Calin Juravle7a570e82017-01-14 16:23:30 -08001170 void release() {
1171 value_ = -1;
1172 do_cleanup_ = false;
1173 cleanup_ = nullptr;
1174 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001175 int value_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001176 std::function<void ()> cleanup_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001177 bool do_cleanup_;
Calin Juravle7a570e82017-01-14 16:23:30 -08001178 bool auto_close_;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001179};
1180
Calin Juravle7a570e82017-01-14 16:23:30 -08001181// (re)Creates the app image if needed.
1182Dex2oatFileWrapper maybe_open_app_image(const char* out_oat_path, bool profile_guided,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001183 bool is_public, int uid, bool is_secondary_dex) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001184
1185 // We don't create an image for secondary dex files.
1186 if (is_secondary_dex) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001187 return Dex2oatFileWrapper();
1188 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001189
Calin Juravle7a570e82017-01-14 16:23:30 -08001190 const std::string image_path = create_image_filename(out_oat_path);
1191 if (image_path.empty()) {
1192 // Happens when the out_oat_path has an unknown extension.
1193 return Dex2oatFileWrapper();
1194 }
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +01001195
1196 // Use app images only if it is enabled (by a set image format) and we are compiling
1197 // profile-guided (so the app image doesn't conservatively contain all classes).
1198 if (!profile_guided) {
1199 // In case there is a stale image, remove it now. Ignore any error.
1200 unlink(image_path.c_str());
1201 return Dex2oatFileWrapper();
1202 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001203 char app_image_format[kPropertyValueMax];
1204 bool have_app_image_format =
1205 get_property("dalvik.vm.appimageformat", app_image_format, NULL) > 0;
1206 if (!have_app_image_format) {
1207 return Dex2oatFileWrapper();
1208 }
1209 // Recreate is true since we do not want to modify a mapped image. If the app is
1210 // already running and we modify the image file, it can cause crashes (b/27493510).
1211 Dex2oatFileWrapper wrapper_fd(
1212 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
1213 [image_path]() { unlink(image_path.c_str()); });
1214 if (wrapper_fd.get() < 0) {
1215 // Could not create application image file. Go on since we can compile without it.
1216 LOG(ERROR) << "installd could not create '" << image_path
1217 << "' for image file during dexopt";
1218 // If we have a valid image file path but no image fd, explicitly erase the image file.
1219 if (unlink(image_path.c_str()) < 0) {
1220 if (errno != ENOENT) {
1221 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
1222 }
1223 }
1224 } else if (!set_permissions_and_ownership(
Calin Juravle2289c0a2017-02-15 12:44:14 -08001225 wrapper_fd.get(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001226 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
1227 wrapper_fd.reset(-1);
1228 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001229
Calin Juravle7a570e82017-01-14 16:23:30 -08001230 return wrapper_fd;
1231}
1232
1233// Creates the dexopt swap file if necessary and return its fd.
1234// Returns -1 if there's no need for a swap or in case of errors.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001235unique_fd maybe_open_dexopt_swap_file(const char* out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001236 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001237 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -08001238 }
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001239 auto swap_file_name = std::string(out_oat_path) + ".swap";
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001240 unique_fd swap_fd(open_output_file(
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001241 swap_file_name.c_str(), /*recreate*/true, /*permissions*/0600));
Calin Juravle7a570e82017-01-14 16:23:30 -08001242 if (swap_fd.get() < 0) {
1243 // Could not create swap file. Optimistically go on and hope that we can compile
1244 // without it.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001245 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name.c_str());
Calin Juravle7a570e82017-01-14 16:23:30 -08001246 } else {
1247 // Immediately unlink. We don't really want to hit flash.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06001248 if (unlink(swap_file_name.c_str()) < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001249 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
1250 }
1251 }
1252 return swap_fd;
1253}
1254
1255// Opens the reference profiles if needed.
1256// Note that the reference profile might not exist so it's OK if the fd will be -1.
Calin Juravle114f0812017-03-08 19:05:07 -08001257Dex2oatFileWrapper maybe_open_reference_profile(const std::string& pkgname,
1258 const std::string& dex_path, bool profile_guided, bool is_public, int uid,
1259 bool is_secondary_dex) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001260 // Public apps should not be compiled with profile information ever. Same goes for the special
1261 // package '*' used for the system server.
Calin Juravle114f0812017-03-08 19:05:07 -08001262 if (!profile_guided || is_public || (pkgname[0] == '*')) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001263 return Dex2oatFileWrapper();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001264 }
Calin Juravle114f0812017-03-08 19:05:07 -08001265
1266 // Open reference profile in read only mode as dex2oat does not get write permissions.
1267 const std::string location = is_secondary_dex ? dex_path : pkgname;
1268 unique_fd ufd = open_reference_profile(uid, location, /*read_write*/false, is_secondary_dex);
1269 const auto& cleanup = [location, is_secondary_dex]() {
1270 clear_reference_profile(location.c_str(), is_secondary_dex);
1271 };
1272 return Dex2oatFileWrapper(ufd.release(), cleanup);
Calin Juravle7a570e82017-01-14 16:23:30 -08001273}
Jeff Sharkey90aff262016-12-12 14:28:24 -07001274
Calin Juravle7a570e82017-01-14 16:23:30 -08001275// Opens the vdex files and assigns the input fd to in_vdex_wrapper_fd and the output fd to
1276// out_vdex_wrapper_fd. Returns true for success or false in case of errors.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001277bool open_vdex_files_for_dex2oat(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001278 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001279 bool profile_guided, Dex2oatFileWrapper* in_vdex_wrapper_fd,
Calin Juravle7a570e82017-01-14 16:23:30 -08001280 Dex2oatFileWrapper* out_vdex_wrapper_fd) {
1281 CHECK(in_vdex_wrapper_fd != nullptr);
1282 CHECK(out_vdex_wrapper_fd != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001283 // Open the existing VDEX. We do this before creating the new output VDEX, which will
1284 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +00001285 char in_odex_path[PKG_PATH_MAX];
1286 int dexopt_action = abs(dexopt_needed);
1287 bool is_odex_location = dexopt_needed < 0;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001288 std::string in_vdex_path_str;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001289
1290 // Infer the name of the output VDEX.
1291 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
1292 if (out_vdex_path_str.empty()) {
1293 return false;
1294 }
1295
1296 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001297 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001298 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1299 const char* path = nullptr;
1300 if (is_odex_location) {
1301 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1302 path = in_odex_path;
1303 } else {
1304 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001305 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001306 }
1307 } else {
1308 path = out_oat_path;
1309 }
1310 in_vdex_path_str = create_vdex_filename(path);
1311 if (in_vdex_path_str.empty()) {
1312 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001313 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001314 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001315 // We can update in place when all these conditions are met:
1316 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1317 // on /system typically cannot be updated in place).
1318 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1319 // cannot be currently used by a running process.
1320 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1321 // different vdex files to operate.
1322 update_vdex_in_place =
1323 (in_vdex_path_str == out_vdex_path_str) &&
1324 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1325 !profile_guided;
1326 if (update_vdex_in_place) {
1327 // Open the file read-write to be able to update it.
1328 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0));
1329 if (in_vdex_wrapper_fd->get() == -1) {
1330 // If we failed to open the file, we cannot update it in place.
1331 update_vdex_in_place = false;
1332 }
1333 } else {
1334 in_vdex_wrapper_fd->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0));
1335 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001336 }
1337
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001338 // If we are updating the vdex in place, we do not need to recreate a vdex,
1339 // and can use the same existing one.
1340 if (update_vdex_in_place) {
1341 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1342 // have bogus stale vdex files.
1343 out_vdex_wrapper_fd->reset(
1344 in_vdex_wrapper_fd->get(),
1345 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1346 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1347 // wrapper).
1348 in_vdex_wrapper_fd->DisableAutoClose();
1349 } else {
1350 out_vdex_wrapper_fd->reset(
1351 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
1352 [out_vdex_path_str]() { unlink(out_vdex_path_str.c_str()); });
1353 if (out_vdex_wrapper_fd->get() < 0) {
1354 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1355 return false;
1356 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001357 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001358 if (!set_permissions_and_ownership(out_vdex_wrapper_fd->get(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001359 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001360 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1361 return false;
1362 }
1363
1364 // If we got here we successfully opened the vdex files.
1365 return true;
1366}
1367
1368// Opens the output oat file for the given apk.
1369// If successful it stores the output path into out_oat_path and returns true.
1370Dex2oatFileWrapper open_oat_out_file(const char* apk_path, const char* oat_dir,
Calin Juravle80a21252017-01-17 14:43:25 -08001371 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex,
1372 char* out_oat_path) {
1373 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001374 return Dex2oatFileWrapper();
1375 }
1376 const std::string out_oat_path_str(out_oat_path);
1377 Dex2oatFileWrapper wrapper_fd(
1378 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
1379 [out_oat_path_str]() { unlink(out_oat_path_str.c_str()); });
1380 if (wrapper_fd.get() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001381 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001382 } else if (!set_permissions_and_ownership(
1383 wrapper_fd.get(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001384 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
1385 wrapper_fd.reset(-1);
1386 }
1387 return wrapper_fd;
1388}
1389
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001390// Creates RDONLY fds for oat and vdex files, if exist.
1391// Returns false if it fails to create oat out path for the given apk path.
1392// Note that the method returns true even if the files could not be opened.
1393bool maybe_open_oat_and_vdex_file(const std::string& apk_path,
1394 const std::string& oat_dir,
1395 const std::string& instruction_set,
1396 bool is_secondary_dex,
1397 unique_fd* oat_file_fd,
1398 unique_fd* vdex_file_fd) {
1399 char oat_path[PKG_PATH_MAX];
1400 if (!create_oat_out_path(apk_path.c_str(),
1401 instruction_set.c_str(),
1402 oat_dir.c_str(),
1403 is_secondary_dex,
1404 oat_path)) {
Calin Juravle46e27bc2017-09-04 15:57:10 -07001405 LOG(ERROR) << "Could not create oat out path for "
1406 << apk_path << " with oat dir " << oat_dir;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001407 return false;
1408 }
1409 oat_file_fd->reset(open(oat_path, O_RDONLY));
1410 if (oat_file_fd->get() < 0) {
1411 PLOG(INFO) << "installd cannot open oat file during dexopt" << oat_path;
1412 }
1413
1414 std::string vdex_filename = create_vdex_filename(oat_path);
1415 vdex_file_fd->reset(open(vdex_filename.c_str(), O_RDONLY));
1416 if (vdex_file_fd->get() < 0) {
1417 PLOG(INFO) << "installd cannot open vdex file during dexopt" << vdex_filename;
1418 }
1419
1420 return true;
1421}
1422
Calin Juravle7a570e82017-01-14 16:23:30 -08001423// Updates the access times of out_oat_path based on those from apk_path.
1424void update_out_oat_access_times(const char* apk_path, const char* out_oat_path) {
1425 struct stat input_stat;
1426 memset(&input_stat, 0, sizeof(input_stat));
1427 if (stat(apk_path, &input_stat) != 0) {
1428 PLOG(ERROR) << "Could not stat " << apk_path << " during dexopt";
1429 return;
1430 }
1431
1432 struct utimbuf ut;
1433 ut.actime = input_stat.st_atime;
1434 ut.modtime = input_stat.st_mtime;
1435 if (utime(out_oat_path, &ut) != 0) {
1436 PLOG(WARNING) << "Could not update access times for " << apk_path << " during dexopt";
1437 }
1438}
1439
Calin Juravle80a21252017-01-17 14:43:25 -08001440// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001441// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1442// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1443// the profile has changed.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001444static void exec_dexoptanalyzer(const std::string& dex_file, int vdex_fd, int oat_fd,
1445 int zip_fd, const std::string& instruction_set, const std::string& compiler_filter,
1446 bool profile_was_updated, bool downgrade,
Calin Juravle58cab072017-09-12 01:02:26 -07001447 const char* class_loader_context) {
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001448 CHECK_GE(zip_fd, 0);
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001449 const char* dexoptanalyzer_bin =
1450 is_debug_runtime()
1451 ? "/system/bin/dexoptanalyzerd"
1452 : "/system/bin/dexoptanalyzer";
Calin Juravle80a21252017-01-17 14:43:25 -08001453 static const unsigned int MAX_INSTRUCTION_SET_LEN = 7;
1454
Calin Juravled23dee72017-07-06 16:29:11 -07001455 if (instruction_set.size() >= MAX_INSTRUCTION_SET_LEN) {
1456 LOG(ERROR) << "Instruction set " << instruction_set
1457 << " longer than max length of " << MAX_INSTRUCTION_SET_LEN;
Calin Juravle80a21252017-01-17 14:43:25 -08001458 return;
1459 }
1460
Calin Juravled23dee72017-07-06 16:29:11 -07001461 std::string dex_file_arg = "--dex-file=" + dex_file;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001462 std::string oat_fd_arg = "--oat-fd=" + std::to_string(oat_fd);
1463 std::string vdex_fd_arg = "--vdex-fd=" + std::to_string(vdex_fd);
1464 std::string zip_fd_arg = "--zip-fd=" + std::to_string(zip_fd);
Calin Juravled23dee72017-07-06 16:29:11 -07001465 std::string isa_arg = "--isa=" + instruction_set;
1466 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
Calin Juravle114f0812017-03-08 19:05:07 -08001467 const char* assume_profile_changed = "--assume-profile-changed";
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001468 const char* downgrade_flag = "--downgrade";
Calin Juravle58cab072017-09-12 01:02:26 -07001469 std::string class_loader_context_arg = "--class-loader-context=";
1470 if (class_loader_context != nullptr) {
1471 class_loader_context_arg += class_loader_context;
1472 }
Calin Juravle80a21252017-01-17 14:43:25 -08001473
Calin Juravle80a21252017-01-17 14:43:25 -08001474 // program name, dex file, isa, filter, the final NULL
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001475 const int argc = 6 +
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001476 (profile_was_updated ? 1 : 0) +
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001477 (vdex_fd >= 0 ? 1 : 0) +
1478 (oat_fd >= 0 ? 1 : 0) +
Calin Juravle58cab072017-09-12 01:02:26 -07001479 (downgrade ? 1 : 0) +
1480 (class_loader_context != nullptr ? 1 : 0);
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001481 const char* argv[argc];
Calin Juravle80a21252017-01-17 14:43:25 -08001482 int i = 0;
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001483 argv[i++] = dexoptanalyzer_bin;
Calin Juravled23dee72017-07-06 16:29:11 -07001484 argv[i++] = dex_file_arg.c_str();
1485 argv[i++] = isa_arg.c_str();
1486 argv[i++] = compiler_filter_arg.c_str();
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001487 if (oat_fd >= 0) {
1488 argv[i++] = oat_fd_arg.c_str();
1489 }
1490 if (vdex_fd >= 0) {
1491 argv[i++] = vdex_fd_arg.c_str();
1492 }
1493 argv[i++] = zip_fd_arg.c_str();
Calin Juravle114f0812017-03-08 19:05:07 -08001494 if (profile_was_updated) {
1495 argv[i++] = assume_profile_changed;
1496 }
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001497 if (downgrade) {
1498 argv[i++] = downgrade_flag;
1499 }
Calin Juravle58cab072017-09-12 01:02:26 -07001500 if (class_loader_context != nullptr) {
Calin Juravle91501072017-10-26 15:44:53 -07001501 argv[i++] = class_loader_context_arg.c_str();
Calin Juravle58cab072017-09-12 01:02:26 -07001502 }
Calin Juravle80a21252017-01-17 14:43:25 -08001503 argv[i] = NULL;
1504
Andreas Gampe6a9cf722017-07-24 16:49:10 -07001505 execv(dexoptanalyzer_bin, (char * const *)argv);
1506 ALOGE("execv(%s) failed: %s\n", dexoptanalyzer_bin, strerror(errno));
Calin Juravle80a21252017-01-17 14:43:25 -08001507}
1508
1509// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001510static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
Calin Juravle46e27bc2017-09-04 15:57:10 -07001511 const char* instruction_set) {
Calin Juravle114f0812017-03-08 19:05:07 -08001512 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001513 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001514 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001515 return false;
1516 }
Calin Juravle114f0812017-03-08 19:05:07 -08001517 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001518
Calin Juravle80a21252017-01-17 14:43:25 -08001519 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001520 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1521 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001522 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001523 return false;
1524 }
1525
1526 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001527 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001528
Calin Juravle46e27bc2017-09-04 15:57:10 -07001529 if (prepare_app_cache_dir(oat_dir, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001530 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001531 return false;
1532 }
1533
1534 return true;
1535}
1536
Calin Juravle46e27bc2017-09-04 15:57:10 -07001537// Return codes for identifying the reason why dexoptanalyzer was not invoked when processing
1538// secondary dex files. This return codes are returned by the child process created for
1539// analyzing secondary dex files in process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001540
Calin Juravle46e27bc2017-09-04 15:57:10 -07001541// The dexoptanalyzer was not invoked because of validation or IO errors.
1542static int constexpr SECONDARY_DEX_DEXOPTANALYZER_SKIPPED = 200;
1543// The dexoptanalyzer was not invoked because the dex file does not exist anymore.
1544static int constexpr SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE = 201;
1545
1546// Verifies the result of analyzing secondary dex files from process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001547// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1548// Returns false for errors or unexpected result values.
Calin Juravle46e27bc2017-09-04 15:57:10 -07001549// The result is expected to be either one of SECONDARY_DEX_* codes or a valid exit code
1550// of dexoptanalyzer.
1551static bool process_secondary_dexoptanalyzer_result(const std::string& dex_path, int result,
Calin Juravle80a21252017-01-17 14:43:25 -08001552 int* dexopt_needed_out) {
1553 // The result values are defined in dexoptanalyzer.
1554 switch (result) {
Calin Juravle46e27bc2017-09-04 15:57:10 -07001555 case 0: // dexoptanalyzer: no_dexopt_needed
Calin Juravle80a21252017-01-17 14:43:25 -08001556 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
Calin Juravle46e27bc2017-09-04 15:57:10 -07001557 case 1: // dexoptanalyzer: dex2oat_from_scratch
Calin Juravle80a21252017-01-17 14:43:25 -08001558 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
Calin Juravle46e27bc2017-09-04 15:57:10 -07001559 case 5: // dexoptanalyzer: dex2oat_for_bootimage_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001560 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
Calin Juravle46e27bc2017-09-04 15:57:10 -07001561 case 6: // dexoptanalyzer: dex2oat_for_filter_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001562 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
Calin Juravle46e27bc2017-09-04 15:57:10 -07001563 case 7: // dexoptanalyzer: dex2oat_for_relocation_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001564 *dexopt_needed_out = -DEX2OAT_FOR_RELOCATION; return true;
Calin Juravle46e27bc2017-09-04 15:57:10 -07001565 case 2: // dexoptanalyzer: dex2oat_for_bootimage_oat
1566 case 3: // dexoptanalyzer: dex2oat_for_filter_oat
1567 case 4: // dexoptanalyzer: dex2oat_for_relocation_oat
Calin Juravlec9eab382017-01-25 01:17:17 -08001568 LOG(ERROR) << "Dexoptnalyzer return the status of an oat file."
1569 << " Expected odex file status for secondary dex " << dex_path
Calin Juravle80a21252017-01-17 14:43:25 -08001570 << " : dexoptanalyzer result=" << result;
1571 return false;
Calin Juravle46e27bc2017-09-04 15:57:10 -07001572 case SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE:
1573 // If the file does not exist there's no need for dexopt.
1574 *dexopt_needed_out = NO_DEXOPT_NEEDED;
1575 return true;
1576 case SECONDARY_DEX_DEXOPTANALYZER_SKIPPED:
1577 return false;
Calin Juravle80a21252017-01-17 14:43:25 -08001578 default:
Calin Juravle46e27bc2017-09-04 15:57:10 -07001579 LOG(ERROR) << "Unexpected result from analyzing secondary dex " << dex_path
1580 << " result=" << result;
Calin Juravle80a21252017-01-17 14:43:25 -08001581 return false;
1582 }
1583}
1584
Calin Juravle46e27bc2017-09-04 15:57:10 -07001585enum SecondaryDexAccess {
1586 kSecondaryDexAccessReadOk = 0,
1587 kSecondaryDexAccessDoesNotExist = 1,
1588 kSecondaryDexAccessPermissionError = 2,
1589 kSecondaryDexAccessIOError = 3
1590};
1591
1592static SecondaryDexAccess check_secondary_dex_access(const std::string& dex_path) {
1593 // Check if the path exists and can be read. If not, there's nothing to do.
1594 if (access(dex_path.c_str(), R_OK) == 0) {
1595 return kSecondaryDexAccessReadOk;
1596 } else {
1597 if (errno == ENOENT) {
1598 LOG(INFO) << "Secondary dex does not exist: " << dex_path;
1599 return kSecondaryDexAccessDoesNotExist;
1600 } else {
1601 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
1602 return errno == EACCES
1603 ? kSecondaryDexAccessPermissionError
1604 : kSecondaryDexAccessIOError;
1605 }
1606 }
1607}
1608
1609static bool is_file_public(const std::string& filename) {
1610 struct stat file_stat;
1611 if (stat(filename.c_str(), &file_stat) == 0) {
1612 return (file_stat.st_mode & S_IROTH) != 0;
1613 }
1614 return false;
1615}
1616
1617// Create the oat file structure for the secondary dex 'dex_path' and assign
1618// the individual path component to the 'out_' parameters.
1619static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
1620 char* out_oat_dir, char* out_oat_isa_dir, char* out_oat_path) {
1621 size_t dirIndex = dex_path.rfind('/');
1622 if (dirIndex == std::string::npos) {
1623 LOG(ERROR) << "Unexpected dir structure for dex file " << dex_path;
1624 return false;
1625 }
1626 // TODO(calin): we have similar computations in at lest 3 other places
1627 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1628 // using string append.
1629 std::string apk_dir = dex_path.substr(0, dirIndex);
1630 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1631 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1632
1633 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
1634 /*is_secondary_dex*/true, out_oat_path)) {
1635 LOG(ERROR) << "Could not create oat path for secondary dex " << dex_path;
1636 return false;
1637 }
1638 return true;
1639}
1640
1641// Validate that the dexopt_flags contain a valid storage flag and convert that to an installd
1642// recognized storage flags (FLAG_STORAGE_CE or FLAG_STORAGE_DE).
1643static bool validate_dexopt_storage_flags(int dexopt_flags, int* out_storage_flag) {
1644 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1645 *out_storage_flag = FLAG_STORAGE_CE;
1646 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1647 LOG(ERROR) << "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
1648 return false;
1649 }
1650 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1651 *out_storage_flag = FLAG_STORAGE_DE;
1652 } else {
1653 LOG(ERROR) << "Secondary dex storage flag must be set";
1654 return false;
1655 }
1656 return true;
1657}
1658
Calin Juravlec9eab382017-01-25 01:17:17 -08001659// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001660// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1661// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001662// When returning true, the output parameters will be:
1663// - is_public_out: whether or not the oat file should not be made public
1664// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1665// - oat_dir_out: the oat dir path where the oat file should be stored
Calin Juravle46e27bc2017-09-04 15:57:10 -07001666static bool process_secondary_dex_dexopt(const std::string& dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001667 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001668 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
Calin Juravle46e27bc2017-09-04 15:57:10 -07001669 std::string* oat_dir_out, bool downgrade, const char* class_loader_context) {
1670 LOG(DEBUG) << "Processing secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001671 int storage_flag;
Calin Juravle46e27bc2017-09-04 15:57:10 -07001672 if (!validate_dexopt_storage_flags(dexopt_flags, &storage_flag)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001673 return false;
1674 }
Calin Juravle46e27bc2017-09-04 15:57:10 -07001675 // Compute the oat dir as it's not easy to extract it from the child computation.
1676 char oat_path[PKG_PATH_MAX];
1677 char oat_dir[PKG_PATH_MAX];
1678 char oat_isa_dir[PKG_PATH_MAX];
1679 if (!create_secondary_dex_oat_layout(
1680 dex_path, instruction_set, oat_dir, oat_isa_dir, oat_path)) {
1681 LOG(ERROR) << "Could not create secondary odex layout: " << dex_path;
Calin Juravled23dee72017-07-06 16:29:11 -07001682 return false;
1683 }
Calin Juravle46e27bc2017-09-04 15:57:10 -07001684 oat_dir_out->assign(oat_dir);
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001685
Calin Juravle80a21252017-01-17 14:43:25 -08001686 pid_t pid = fork();
1687 if (pid == 0) {
1688 // child -- drop privileges before continuing.
1689 drop_capabilities(uid);
Calin Juravle46e27bc2017-09-04 15:57:10 -07001690
1691 // Validate the path structure.
1692 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
1693 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
1694 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1695 }
1696
1697 // Open the dex file.
1698 unique_fd zip_fd;
1699 zip_fd.reset(open(dex_path.c_str(), O_RDONLY));
1700 if (zip_fd.get() < 0) {
1701 if (errno == ENOENT) {
1702 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE);
1703 } else {
1704 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1705 }
1706 }
1707
1708 // Prepare the oat directories.
1709 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set)) {
1710 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1711 }
1712
1713 // Open the vdex/oat files if any.
1714 unique_fd oat_file_fd;
1715 unique_fd vdex_file_fd;
1716 if (!maybe_open_oat_and_vdex_file(dex_path,
1717 *oat_dir_out,
1718 instruction_set,
1719 true /* is_secondary_dex */,
1720 &oat_file_fd,
1721 &vdex_file_fd)) {
1722 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
1723 }
1724
1725 // Analyze profiles.
1726 bool profile_was_updated = analyze_profiles(uid, dex_path, /*is_secondary_dex*/true);
1727
1728 // Run dexoptanalyzer to get dexopt_needed code. This is not expected to return.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001729 exec_dexoptanalyzer(dex_path,
1730 vdex_file_fd.get(),
1731 oat_file_fd.get(),
1732 zip_fd.get(),
1733 instruction_set,
Calin Juravle46e27bc2017-09-04 15:57:10 -07001734 compiler_filter, profile_was_updated,
1735 downgrade,
1736 class_loader_context);
1737 PLOG(ERROR) << "Failed to exec dexoptanalyzer";
1738 _exit(SECONDARY_DEX_DEXOPTANALYZER_SKIPPED);
Calin Juravle80a21252017-01-17 14:43:25 -08001739 }
1740
1741 /* parent */
Calin Juravle80a21252017-01-17 14:43:25 -08001742 int result = wait_child(pid);
1743 if (!WIFEXITED(result)) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001744 LOG(ERROR) << "dexoptanalyzer failed for path " << dex_path << ": " << result;
Calin Juravle80a21252017-01-17 14:43:25 -08001745 return false;
1746 }
1747 result = WEXITSTATUS(result);
Calin Juravle46e27bc2017-09-04 15:57:10 -07001748 // Check that we successfully executed dexoptanalyzer.
1749 bool success = process_secondary_dexoptanalyzer_result(dex_path, result, dexopt_needed_out);
1750
1751 LOG(DEBUG) << "Processed secondary dex file " << dex_path << " result=" << result;
1752
Calin Juravle80a21252017-01-17 14:43:25 -08001753 // Run dexopt only if needed or forced.
Calin Juravle46e27bc2017-09-04 15:57:10 -07001754 // Note that dexoptanalyzer is executed even if force compilation is enabled (because it
1755 // makes the code simpler; force compilation is only needed during tests).
1756 if (success &&
1757 (result != SECONDARY_DEX_DEXOPTANALYZER_SKIPPED_NO_FILE) &&
1758 ((dexopt_flags & DEXOPT_FORCE) != 0)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001759 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
1760 }
1761
Calin Juravle46e27bc2017-09-04 15:57:10 -07001762 // Check if we should make the oat file public.
1763 // Note that if the dex file is not public the compiled code cannot be made public.
1764 // It is ok to check this flag outside in the parent process.
1765 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) && is_file_public(dex_path);
1766
Calin Juravle80a21252017-01-17 14:43:25 -08001767 return success;
1768}
1769
Calin Juravlec9eab382017-01-25 01:17:17 -08001770int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001771 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravle52c45822017-07-13 22:50:21 -07001772 const char* volume_uuid, const char* class_loader_context, const char* se_info,
Shubham Ajmera54ef8622017-06-22 11:10:27 -07001773 bool downgrade) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001774 CHECK(pkgname != nullptr);
1775 CHECK(pkgname[0] != 0);
1776 if ((dexopt_flags & ~DEXOPT_MASK) != 0) {
1777 LOG_FATAL("dexopt flags contains unknown fields\n");
1778 }
1779
Calin Juravled23dee72017-07-06 16:29:11 -07001780 if (!validate_dex_path_size(dex_path)) {
Calin Juravle52c45822017-07-13 22:50:21 -07001781 return -1;
1782 }
1783
1784 if (class_loader_context != nullptr && strlen(class_loader_context) > PKG_PATH_MAX) {
1785 LOG(ERROR) << "Class loader context exceeds the allowed size: " << class_loader_context;
1786 return -1;
Calin Juravled23dee72017-07-06 16:29:11 -07001787 }
1788
Calin Juravleebc8a792017-04-04 20:21:05 -07001789 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001790 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
1791 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
1792 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001793 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001794 bool background_job_compile = (dexopt_flags & DEXOPT_IDLE_BACKGROUND_JOB) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001795
1796 // Check if we're dealing with a secondary dex file and if we need to compile it.
1797 std::string oat_dir_str;
1798 if (is_secondary_dex) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001799 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07001800 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
Calin Juravle46e27bc2017-09-04 15:57:10 -07001801 downgrade, class_loader_context)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001802 oat_dir = oat_dir_str.c_str();
1803 if (dexopt_needed == NO_DEXOPT_NEEDED) {
1804 return 0; // Nothing to do, report success.
1805 }
1806 } else {
1807 return -1; // We had an error, logged in the process method.
1808 }
1809 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001810 // Currently these flags are only use for secondary dex files.
1811 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08001812 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
1813 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
1814 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001815
1816 // Open the input file.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001817 unique_fd input_fd(open(dex_path, O_RDONLY, 0));
Calin Juravle7a570e82017-01-14 16:23:30 -08001818 if (input_fd.get() < 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001819 ALOGE("installd cannot open '%s' for input during dexopt\n", dex_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001820 return -1;
1821 }
1822
1823 // Create the output OAT file.
1824 char out_oat_path[PKG_PATH_MAX];
Calin Juravlec9eab382017-01-25 01:17:17 -08001825 Dex2oatFileWrapper out_oat_fd = open_oat_out_file(dex_path, oat_dir, is_public, uid,
Calin Juravle80a21252017-01-17 14:43:25 -08001826 instruction_set, is_secondary_dex, out_oat_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001827 if (out_oat_fd.get() < 0) {
1828 return -1;
1829 }
1830
1831 // Open vdex files.
1832 Dex2oatFileWrapper in_vdex_fd;
1833 Dex2oatFileWrapper out_vdex_fd;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001834 if (!open_vdex_files_for_dex2oat(dex_path, out_oat_path, dexopt_needed, instruction_set,
1835 is_public, uid, is_secondary_dex, profile_guided, &in_vdex_fd, &out_vdex_fd)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001836 return -1;
1837 }
1838
Calin Juravlecb556e32017-04-04 20:22:50 -07001839 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
1840 // selinux context (we generate them on the fly during the dexopt invocation and they don't
1841 // fully inherit their parent context).
1842 // Note that for primary apk the oat files are created before, in a separate installd
1843 // call which also does the restorecon. TODO(calin): unify the paths.
1844 if (is_secondary_dex) {
1845 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
1846 SELINUX_ANDROID_RESTORECON_RECURSE)) {
1847 LOG(ERROR) << "Failed to restorecon " << oat_dir;
1848 return -1;
1849 }
1850 }
1851
Jeff Sharkey90aff262016-12-12 14:28:24 -07001852 // Create a swap file if necessary.
Calin Juravle1a0af3b2017-03-09 14:33:33 -08001853 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001854
Calin Juravle7a570e82017-01-14 16:23:30 -08001855 // Create the app image file if needed.
1856 Dex2oatFileWrapper image_fd =
Calin Juravle2289c0a2017-02-15 12:44:14 -08001857 maybe_open_app_image(out_oat_path, profile_guided, is_public, uid, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001858
Calin Juravle7a570e82017-01-14 16:23:30 -08001859 // Open the reference profile if needed.
Calin Juravle114f0812017-03-08 19:05:07 -08001860 Dex2oatFileWrapper reference_profile_fd = maybe_open_reference_profile(
1861 pkgname, dex_path, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08001862
Calin Juravlec9eab382017-01-25 01:17:17 -08001863 ALOGV("DexInv: --- BEGIN '%s' ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001864
1865 pid_t pid = fork();
1866 if (pid == 0) {
1867 /* child -- drop privileges before continuing */
1868 drop_capabilities(uid);
1869
Richard Uhler76cc0272016-12-08 10:46:35 +00001870 SetDex2OatScheduling(boot_complete);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001871 if (flock(out_oat_fd.get(), LOCK_EX | LOCK_NB) != 0) {
1872 ALOGE("flock(%s) failed: %s\n", out_oat_path, strerror(errno));
1873 _exit(67);
1874 }
1875
Richard Uhler76cc0272016-12-08 10:46:35 +00001876 run_dex2oat(input_fd.get(),
1877 out_oat_fd.get(),
1878 in_vdex_fd.get(),
Calin Juravle7a570e82017-01-14 16:23:30 -08001879 out_vdex_fd.get(),
Richard Uhler76cc0272016-12-08 10:46:35 +00001880 image_fd.get(),
Jeff Hao10b8a6e2017-04-05 17:11:39 -07001881 dex_path,
Richard Uhler76cc0272016-12-08 10:46:35 +00001882 out_oat_path,
1883 swap_fd.get(),
1884 instruction_set,
1885 compiler_filter,
Richard Uhler76cc0272016-12-08 10:46:35 +00001886 debuggable,
1887 boot_complete,
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001888 background_job_compile,
Richard Uhler76cc0272016-12-08 10:46:35 +00001889 reference_profile_fd.get(),
Calin Juravle52c45822017-07-13 22:50:21 -07001890 class_loader_context);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001891 _exit(68); /* only get here on exec failure */
1892 } else {
1893 int res = wait_child(pid);
1894 if (res == 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001895 ALOGV("DexInv: --- END '%s' (success) ---\n", dex_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001896 } else {
Calin Juravlec9eab382017-01-25 01:17:17 -08001897 ALOGE("DexInv: --- END '%s' --- status=0x%04x, process failed\n", dex_path, res);
Andreas Gampe013f02e2017-03-20 18:36:54 -07001898 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001899 }
1900 }
1901
Calin Juravlec9eab382017-01-25 01:17:17 -08001902 update_out_oat_access_times(dex_path, out_oat_path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001903
1904 // We've been successful, don't delete output.
1905 out_oat_fd.SetCleanup(false);
Calin Juravle7a570e82017-01-14 16:23:30 -08001906 out_vdex_fd.SetCleanup(false);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001907 image_fd.SetCleanup(false);
1908 reference_profile_fd.SetCleanup(false);
1909
1910 return 0;
1911}
1912
Calin Juravlec9eab382017-01-25 01:17:17 -08001913// Try to remove the given directory. Log an error if the directory exists
1914// and is empty but could not be removed.
1915static bool rmdir_if_empty(const char* dir) {
1916 if (rmdir(dir) == 0) {
1917 return true;
1918 }
1919 if (errno == ENOENT || errno == ENOTEMPTY) {
1920 return true;
1921 }
1922 PLOG(ERROR) << "Failed to remove dir: " << dir;
1923 return false;
1924}
1925
1926// Try to unlink the given file. Log an error if the file exists and could not
1927// be unlinked.
1928static bool unlink_if_exists(const std::string& file) {
1929 if (unlink(file.c_str()) == 0) {
1930 return true;
1931 }
1932 if (errno == ENOENT) {
1933 return true;
1934
1935 }
1936 PLOG(ERROR) << "Could not unlink: " << file;
1937 return false;
1938}
1939
Calin Juravle46e27bc2017-09-04 15:57:10 -07001940enum ReconcileSecondaryDexResult {
1941 kReconcileSecondaryDexExists = 0,
1942 kReconcileSecondaryDexCleanedUp = 1,
1943 kReconcileSecondaryDexValidationError = 2,
1944 kReconcileSecondaryDexCleanUpError = 3,
1945 kReconcileSecondaryDexAccessIOError = 4,
1946};
Calin Juravlec9eab382017-01-25 01:17:17 -08001947
1948// Reconcile the secondary dex 'dex_path' and its generated oat files.
1949// Return true if all the parameters are valid and the secondary dex file was
1950// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
1951// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
1952// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
1953// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
1954// Return false if there were errors during processing. In this case
1955// out_secondary_dex_exists will be set to false.
1956bool reconcile_secondary_dex_file(const std::string& dex_path,
1957 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
1958 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
1959 /*out*/bool* out_secondary_dex_exists) {
Calin Juravle46e27bc2017-09-04 15:57:10 -07001960 *out_secondary_dex_exists = false; // start by assuming the file does not exist.
Calin Juravlec9eab382017-01-25 01:17:17 -08001961 if (isas.size() == 0) {
1962 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
1963 return false;
1964 }
1965
Calin Juravle46e27bc2017-09-04 15:57:10 -07001966 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
1967 LOG(ERROR) << "reconcile_secondary_dex_file called with invalid storage_flag: "
1968 << storage_flag;
Calin Juravlec9eab382017-01-25 01:17:17 -08001969 return false;
1970 }
1971
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001972 // As a security measure we want to unlink art artifacts with the reduced capabilities
1973 // of the package user id. So we fork and drop capabilities in the child.
1974 pid_t pid = fork();
1975 if (pid == 0) {
Calin Juravle46e27bc2017-09-04 15:57:10 -07001976 /* child -- drop privileges before continuing */
1977 drop_capabilities(uid);
1978
1979 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
1980 if (!validate_secondary_dex_path(pkgname.c_str(), dex_path.c_str(), volume_uuid_cstr,
1981 uid, storage_flag)) {
1982 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
1983 _exit(kReconcileSecondaryDexValidationError);
1984 }
1985
1986 SecondaryDexAccess access_check = check_secondary_dex_access(dex_path);
1987 switch (access_check) {
1988 case kSecondaryDexAccessDoesNotExist:
1989 // File does not exist. Proceed with cleaning.
1990 break;
1991 case kSecondaryDexAccessReadOk: _exit(kReconcileSecondaryDexExists);
1992 case kSecondaryDexAccessIOError: _exit(kReconcileSecondaryDexAccessIOError);
1993 case kSecondaryDexAccessPermissionError: _exit(kReconcileSecondaryDexValidationError);
1994 default:
1995 LOG(ERROR) << "Unexpected result from check_secondary_dex_access: " << access_check;
1996 _exit(kReconcileSecondaryDexValidationError);
1997 }
1998
1999 // The secondary dex does not exist anymore or it's. Clear any generated files.
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002000 char oat_path[PKG_PATH_MAX];
2001 char oat_dir[PKG_PATH_MAX];
2002 char oat_isa_dir[PKG_PATH_MAX];
2003 bool result = true;
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002004 for (size_t i = 0; i < isas.size(); i++) {
Calin Juravle46e27bc2017-09-04 15:57:10 -07002005 if (!create_secondary_dex_oat_layout(
2006 dex_path,isas[i], oat_dir, oat_isa_dir, oat_path)) {
2007 LOG(ERROR) << "Could not create secondary odex layout: " << dex_path;
2008 _exit(kReconcileSecondaryDexValidationError);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002009 }
Calin Juravle51314092017-05-18 15:33:05 -07002010
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002011 // Delete oat/vdex/art files.
2012 result = unlink_if_exists(oat_path) && result;
2013 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
2014 result = unlink_if_exists(create_image_filename(oat_path)) && result;
Calin Juravlec9eab382017-01-25 01:17:17 -08002015
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002016 // Delete profiles.
2017 std::string current_profile = create_current_profile_path(
Calin Juravle51314092017-05-18 15:33:05 -07002018 multiuser_get_user_id(uid), dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002019 std::string reference_profile = create_reference_profile_path(
Calin Juravle51314092017-05-18 15:33:05 -07002020 dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002021 result = unlink_if_exists(current_profile) && result;
2022 result = unlink_if_exists(reference_profile) && result;
Calin Juravle51314092017-05-18 15:33:05 -07002023
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002024 // We upgraded once the location of current profile for secondary dex files.
2025 // Check for any previous left-overs and remove them as well.
2026 std::string old_current_profile = dex_path + ".prof";
2027 result = unlink_if_exists(old_current_profile);
Calin Juravle3760ad32017-07-27 16:31:55 -07002028
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002029 // Try removing the directories as well, they might be empty.
2030 result = rmdir_if_empty(oat_isa_dir) && result;
2031 result = rmdir_if_empty(oat_dir) && result;
2032 }
Calin Juravle46e27bc2017-09-04 15:57:10 -07002033 if (!result) {
2034 PLOG(ERROR) << "Failed to clean secondary dex artifacts for location " << dex_path;
2035 }
2036 _exit(result ? kReconcileSecondaryDexCleanedUp : kReconcileSecondaryDexAccessIOError);
Calin Juravlec9eab382017-01-25 01:17:17 -08002037 }
2038
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07002039 int return_code = wait_child(pid);
Calin Juravle46e27bc2017-09-04 15:57:10 -07002040 if (!WIFEXITED(return_code)) {
2041 LOG(WARNING) << "reconcile dex failed for location " << dex_path << ": " << return_code;
2042 } else {
2043 return_code = WEXITSTATUS(return_code);
2044 }
2045
2046 LOG(DEBUG) << "Reconcile secondary dex path " << dex_path << " result=" << return_code;
2047
2048 switch (return_code) {
2049 case kReconcileSecondaryDexCleanedUp:
2050 case kReconcileSecondaryDexValidationError:
2051 // If we couldn't validate assume the dex file does not exist.
2052 // This will purge the entry from the PM records.
2053 *out_secondary_dex_exists = false;
2054 return true;
2055 case kReconcileSecondaryDexExists:
2056 *out_secondary_dex_exists = true;
2057 return true;
2058 case kReconcileSecondaryDexAccessIOError:
2059 // We had an access IO error.
2060 // Return false so that we can try again.
2061 // The value of out_secondary_dex_exists does not matter in this case and by convention
2062 // is set to false.
2063 *out_secondary_dex_exists = false;
2064 return false;
2065 default:
2066 LOG(ERROR) << "Unexpected code from reconcile_secondary_dex_file: " << return_code;
2067 *out_secondary_dex_exists = false;
2068 return false;
2069 }
Calin Juravlec9eab382017-01-25 01:17:17 -08002070}
2071
Alan Stokes753dc712017-10-16 10:56:00 +01002072// Compute and return the hash (SHA-256) of the secondary dex file at dex_path.
2073// Returns true if all parameters are valid and the hash successfully computed and stored in
2074// out_secondary_dex_hash.
2075// Also returns true with an empty hash if the file does not currently exist or is not accessible to
2076// the app.
2077// For any other errors (e.g. if any of the parameters are invalid) returns false.
2078bool hash_secondary_dex_file(const std::string& dex_path, const std::string& pkgname, int uid,
2079 const std::unique_ptr<std::string>& volume_uuid, int storage_flag,
2080 std::vector<uint8_t>* out_secondary_dex_hash) {
2081 out_secondary_dex_hash->clear();
2082
2083 const char* volume_uuid_cstr = volume_uuid == nullptr ? nullptr : volume_uuid->c_str();
2084
2085 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2086 LOG(ERROR) << "hash_secondary_dex_file called with invalid storage_flag: "
2087 << storage_flag;
2088 return false;
2089 }
2090
2091 // Pipe to get the hash result back from our child process.
2092 unique_fd pipe_read, pipe_write;
2093 if (!Pipe(&pipe_read, &pipe_write)) {
2094 PLOG(ERROR) << "Failed to create pipe";
2095 return false;
2096 }
2097
2098 // Fork so that actual access to the files is done in the app's own UID, to ensure we only
2099 // access data the app itself can access.
2100 pid_t pid = fork();
2101 if (pid == 0) {
2102 // child -- drop privileges before continuing
2103 drop_capabilities(uid);
2104 pipe_read.reset();
2105
2106 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr, uid, storage_flag)) {
2107 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
2108 _exit(1);
2109 }
2110
2111 unique_fd fd(TEMP_FAILURE_RETRY(open(dex_path.c_str(), O_RDONLY | O_CLOEXEC | O_NOFOLLOW)));
2112 if (fd == -1) {
2113 if (errno == EACCES || errno == ENOENT) {
2114 // Not treated as an error.
2115 _exit(0);
2116 }
2117 PLOG(ERROR) << "Failed to open secondary dex " << dex_path;
2118 _exit(1);
2119 }
2120
2121 SHA256_CTX ctx;
2122 SHA256_Init(&ctx);
2123
2124 std::vector<uint8_t> buffer(65536);
2125 while (true) {
2126 ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer.data(), buffer.size()));
2127 if (bytes_read == 0) {
2128 break;
2129 } else if (bytes_read == -1) {
2130 PLOG(ERROR) << "Failed to read secondary dex " << dex_path;
2131 _exit(1);
2132 }
2133
2134 SHA256_Update(&ctx, buffer.data(), bytes_read);
2135 }
2136
2137 std::array<uint8_t, SHA256_DIGEST_LENGTH> hash;
2138 SHA256_Final(hash.data(), &ctx);
2139 if (!WriteFully(pipe_write, hash.data(), hash.size())) {
2140 _exit(1);
2141 }
2142
2143 _exit(0);
2144 }
2145
2146 // parent
2147 pipe_write.reset();
2148
2149 out_secondary_dex_hash->resize(SHA256_DIGEST_LENGTH);
2150 if (!ReadFully(pipe_read, out_secondary_dex_hash->data(), out_secondary_dex_hash->size())) {
2151 out_secondary_dex_hash->clear();
2152 }
2153 return wait_child(pid) == 0;
2154}
2155
Jeff Sharkey90aff262016-12-12 14:28:24 -07002156// Helper for move_ab, so that we can have common failure-case cleanup.
2157static bool unlink_and_rename(const char* from, const char* to) {
2158 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
2159 // return a failure.
2160 struct stat s;
2161 if (stat(to, &s) == 0) {
2162 if (!S_ISREG(s.st_mode)) {
2163 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
2164 return false;
2165 }
2166 if (unlink(to) != 0) {
2167 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
2168 return false;
2169 }
2170 } else {
2171 // This may be a permission problem. We could investigate the error code, but we'll just
2172 // let the rename failure do the work for us.
2173 }
2174
2175 // Try to rename "to" to "from."
2176 if (rename(from, to) != 0) {
2177 PLOG(ERROR) << "Could not rename " << from << " to " << to;
2178 return false;
2179 }
2180 return true;
2181}
2182
2183// Move/rename a B artifact (from) to an A artifact (to).
2184static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
2185 // Check whether B exists.
2186 {
2187 struct stat s;
2188 if (stat(b_path.c_str(), &s) != 0) {
2189 // Silently ignore for now. The service calling this isn't smart enough to understand
2190 // lack of artifacts at the moment.
2191 return false;
2192 }
2193 if (!S_ISREG(s.st_mode)) {
2194 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
2195 // Try to unlink, but swallow errors.
2196 unlink(b_path.c_str());
2197 return false;
2198 }
2199 }
2200
2201 // Rename B to A.
2202 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
2203 // Delete the b_path so we don't try again (or fail earlier).
2204 if (unlink(b_path.c_str()) != 0) {
2205 PLOG(ERROR) << "Could not unlink " << b_path;
2206 }
2207
2208 return false;
2209 }
2210
2211 return true;
2212}
2213
2214bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2215 // Get the current slot suffix. No suffix, no A/B.
2216 std::string slot_suffix;
2217 {
2218 char buf[kPropertyValueMax];
2219 if (get_property("ro.boot.slot_suffix", buf, nullptr) <= 0) {
2220 return false;
2221 }
2222 slot_suffix = buf;
2223
2224 if (!ValidateTargetSlotSuffix(slot_suffix)) {
2225 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
2226 return false;
2227 }
2228 }
2229
2230 // Validate other inputs.
2231 if (validate_apk_path(apk_path) != 0) {
2232 LOG(ERROR) << "Invalid apk_path: " << apk_path;
2233 return false;
2234 }
2235 if (validate_apk_path(oat_dir) != 0) {
2236 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
2237 return false;
2238 }
2239
2240 char a_path[PKG_PATH_MAX];
2241 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
2242 return false;
2243 }
2244 const std::string a_vdex_path = create_vdex_filename(a_path);
2245 const std::string a_image_path = create_image_filename(a_path);
2246
2247 // B path = A path + slot suffix.
2248 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
2249 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
2250 const std::string b_image_path = StringPrintf("%s.%s",
2251 a_image_path.c_str(),
2252 slot_suffix.c_str());
2253
2254 bool success = true;
2255 if (move_ab_path(b_path, a_path)) {
2256 if (move_ab_path(b_vdex_path, a_vdex_path)) {
2257 // Note: we can live without an app image. As such, ignore failure to move the image file.
2258 // If we decide to require the app image, or the app image being moved correctly,
2259 // then change accordingly.
2260 constexpr bool kIgnoreAppImageFailure = true;
2261
2262 if (!a_image_path.empty()) {
2263 if (!move_ab_path(b_image_path, a_image_path)) {
2264 unlink(a_image_path.c_str());
2265 if (!kIgnoreAppImageFailure) {
2266 success = false;
2267 }
2268 }
2269 }
2270 } else {
2271 // Cleanup: delete B image, ignore errors.
2272 unlink(b_image_path.c_str());
2273 success = false;
2274 }
2275 } else {
2276 // Cleanup: delete B image, ignore errors.
2277 unlink(b_vdex_path.c_str());
2278 unlink(b_image_path.c_str());
2279 success = false;
2280 }
2281 return success;
2282}
2283
2284bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2285 // Delete the oat/odex file.
2286 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08002287 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08002288 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07002289 return false;
2290 }
2291
2292 // In case of a permission failure report the issue. Otherwise just print a warning.
2293 auto unlink_and_check = [](const char* path) -> bool {
2294 int result = unlink(path);
2295 if (result != 0) {
2296 if (errno == EACCES || errno == EPERM) {
2297 PLOG(ERROR) << "Could not unlink " << path;
2298 return false;
2299 }
2300 PLOG(WARNING) << "Could not unlink " << path;
2301 }
2302 return true;
2303 };
2304
2305 // Delete the oat/odex file.
2306 bool return_value_oat = unlink_and_check(out_path);
2307
2308 // Derive and delete the app image.
2309 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
2310
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002311 // Derive and delete the vdex file.
2312 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
2313
Jeff Sharkey90aff262016-12-12 14:28:24 -07002314 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002315 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002316}
2317
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06002318static bool is_absolute_path(const std::string& path) {
2319 if (path.find('/') != 0 || path.find("..") != std::string::npos) {
2320 LOG(ERROR) << "Invalid absolute path " << path;
2321 return false;
2322 } else {
2323 return true;
2324 }
2325}
2326
2327static bool is_valid_instruction_set(const std::string& instruction_set) {
2328 // TODO: add explicit whitelisting of instruction sets
2329 if (instruction_set.find('/') != std::string::npos) {
2330 LOG(ERROR) << "Invalid instruction set " << instruction_set;
2331 return false;
2332 } else {
2333 return true;
2334 }
2335}
2336
2337bool calculate_oat_file_path_default(char path[PKG_PATH_MAX], const char *oat_dir,
2338 const char *apk_path, const char *instruction_set) {
2339 std::string oat_dir_ = oat_dir;
2340 std::string apk_path_ = apk_path;
2341 std::string instruction_set_ = instruction_set;
2342
2343 if (!is_absolute_path(oat_dir_)) return false;
2344 if (!is_absolute_path(apk_path_)) return false;
2345 if (!is_valid_instruction_set(instruction_set_)) return false;
2346
2347 std::string::size_type end = apk_path_.rfind('.');
2348 std::string::size_type start = apk_path_.rfind('/', end);
2349 if (end == std::string::npos || start == std::string::npos) {
2350 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2351 return false;
2352 }
2353
2354 std::string res_ = oat_dir_ + '/' + instruction_set + '/'
2355 + apk_path_.substr(start + 1, end - start - 1) + ".odex";
2356 const char* res = res_.c_str();
2357 if (strlen(res) >= PKG_PATH_MAX) {
2358 LOG(ERROR) << "Result too large";
2359 return false;
2360 } else {
2361 strlcpy(path, res, PKG_PATH_MAX);
2362 return true;
2363 }
2364}
2365
2366bool calculate_odex_file_path_default(char path[PKG_PATH_MAX], const char *apk_path,
2367 const char *instruction_set) {
2368 std::string apk_path_ = apk_path;
2369 std::string instruction_set_ = instruction_set;
2370
2371 if (!is_absolute_path(apk_path_)) return false;
2372 if (!is_valid_instruction_set(instruction_set_)) return false;
2373
2374 std::string::size_type end = apk_path_.rfind('.');
2375 std::string::size_type start = apk_path_.rfind('/', end);
2376 if (end == std::string::npos || start == std::string::npos) {
2377 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2378 return false;
2379 }
2380
2381 std::string oat_dir = apk_path_.substr(0, start + 1) + "oat";
2382 return calculate_oat_file_path_default(path, oat_dir.c_str(), apk_path, instruction_set);
2383}
2384
2385bool create_cache_path_default(char path[PKG_PATH_MAX], const char *src,
2386 const char *instruction_set) {
2387 std::string src_ = src;
2388 std::string instruction_set_ = instruction_set;
2389
2390 if (!is_absolute_path(src_)) return false;
2391 if (!is_valid_instruction_set(instruction_set_)) return false;
2392
2393 for (auto it = src_.begin() + 1; it < src_.end(); ++it) {
2394 if (*it == '/') {
2395 *it = '@';
2396 }
2397 }
2398
2399 std::string res_ = android_data_dir + DALVIK_CACHE + '/' + instruction_set_ + src_
2400 + DALVIK_CACHE_POSTFIX;
2401 const char* res = res_.c_str();
2402 if (strlen(res) >= PKG_PATH_MAX) {
2403 LOG(ERROR) << "Result too large";
2404 return false;
2405 } else {
2406 strlcpy(path, res, PKG_PATH_MAX);
2407 return true;
2408 }
2409}
2410
Calin Juravlec41dac22017-12-05 12:29:15 -08002411bool create_profile_snapshot(int32_t app_id, const std::string& package_name,
Calin Juravle29591732017-11-20 17:46:19 -08002412 const std::string& code_path) {
2413 int app_shared_gid = multiuser_get_shared_gid(/*user_id*/ 0, app_id);
2414
2415 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, code_path);
2416 if (snapshot_fd < 0) {
2417 return false;
2418 }
2419
2420 std::vector<unique_fd> profiles_fd;
2421 unique_fd reference_profile_fd;
2422 open_profile_files(app_shared_gid, package_name, /*is_secondary_dex*/ false, &profiles_fd,
2423 &reference_profile_fd);
2424 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
2425 return false;
2426 }
2427
2428 profiles_fd.push_back(std::move(reference_profile_fd));
2429
2430 pid_t pid = fork();
2431 if (pid == 0) {
2432 /* child -- drop privileges before continuing */
2433 drop_capabilities(app_shared_gid);
2434 run_profman_merge(profiles_fd, snapshot_fd);
2435 exit(42); /* only get here on exec failure */
2436 }
2437
2438 /* parent */
2439 int return_code = wait_child(pid);
2440 if (!WIFEXITED(return_code)) {
2441 LOG(WARNING) << "profman failed for " << package_name << ":" << code_path;
2442 return false;
2443 }
2444
2445 return true;
2446}
2447
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07002448} // namespace installd
2449} // namespace android