Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "compile/IdAssigner.h" |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 18 | |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 19 | #include "test/Test.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 20 | |
| 21 | namespace aapt { |
| 22 | |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 23 | struct IdAssignerTests : public ::testing::Test { |
| 24 | void SetUp() override { |
| 25 | context = test::ContextBuilder().SetCompilationPackage("android").SetPackageId(0x01).Build(); |
| 26 | } |
| 27 | std::unique_ptr<IAaptContext> context; |
| 28 | }; |
| 29 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 30 | ::testing::AssertionResult VerifyIds(ResourceTable* table); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 31 | |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 32 | TEST_F(IdAssignerTests, AssignIds) { |
| 33 | auto table = test::ResourceTableBuilder() |
| 34 | .AddSimple("android:attr/foo") |
| 35 | .AddSimple("android:attr/bar") |
| 36 | .AddSimple("android:id/foo") |
| 37 | .Build(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 38 | IdAssigner assigner; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 39 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 40 | ASSERT_TRUE(assigner.Consume(context.get(), table.get())); |
| 41 | ASSERT_TRUE(VerifyIds(table.get())); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 42 | } |
| 43 | |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 44 | TEST_F(IdAssignerTests, AssignIdsWithReservedIds) { |
| 45 | auto table = test::ResourceTableBuilder() |
| 46 | .AddSimple("android:id/foo", ResourceId(0x01010000)) |
| 47 | .AddSimple("android:dimen/two") |
| 48 | .AddSimple("android:integer/three") |
| 49 | .AddSimple("android:string/five") |
| 50 | .AddSimple("android:attr/fun", ResourceId(0x01040000)) |
| 51 | .AddSimple("android:attr/foo", ResourceId(0x01040006)) |
| 52 | .AddSimple("android:attr/bar") |
| 53 | .AddSimple("android:attr/baz") |
| 54 | .Build(); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 55 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 56 | IdAssigner assigner; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 57 | ASSERT_TRUE(assigner.Consume(context.get(), table.get())); |
| 58 | ASSERT_TRUE(VerifyIds(table.get())); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 59 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 60 | Maybe<ResourceTable::SearchResult> maybe_result; |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 61 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 62 | // Expect to fill in the gaps between 0x0101XXXX and 0x0104XXXX. |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 63 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 64 | maybe_result = table->FindResource(test::ParseNameOrDie("android:dimen/two")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame] | 65 | ASSERT_TRUE(maybe_result); |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 66 | EXPECT_EQ(make_value<ResourceId>(0x01020000), maybe_result.value().entry->id); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 67 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 68 | maybe_result = |
| 69 | table->FindResource(test::ParseNameOrDie("android:integer/three")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame] | 70 | ASSERT_TRUE(maybe_result); |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 71 | EXPECT_EQ(make_value<ResourceId>(0x01030000), maybe_result.value().entry->id); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 72 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 73 | // Expect to bypass the reserved 0x0104XXXX IDs and use the next 0x0105XXXX |
| 74 | // IDs. |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 75 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 76 | maybe_result = |
| 77 | table->FindResource(test::ParseNameOrDie("android:string/five")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame] | 78 | ASSERT_TRUE(maybe_result); |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 79 | EXPECT_EQ(make_value<ResourceId>(0x01050000), maybe_result.value().entry->id); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 80 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 81 | // Expect to fill in the gaps between 0x01040000 and 0x01040006. |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 82 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 83 | maybe_result = table->FindResource(test::ParseNameOrDie("android:attr/bar")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame] | 84 | ASSERT_TRUE(maybe_result); |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 85 | EXPECT_EQ(make_value<ResourceId>(0x01040001), maybe_result.value().entry->id); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 86 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 87 | maybe_result = table->FindResource(test::ParseNameOrDie("android:attr/baz")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame] | 88 | ASSERT_TRUE(maybe_result); |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 89 | EXPECT_EQ(make_value<ResourceId>(0x01040002), maybe_result.value().entry->id); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 90 | } |
| 91 | |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 92 | TEST_F(IdAssignerTests, FailWhenNonUniqueIdsAssigned) { |
| 93 | auto table = test::ResourceTableBuilder() |
| 94 | .AddSimple("android:attr/foo", ResourceId(0x01040006)) |
| 95 | .AddSimple("android:attr/bar", ResourceId(0x01040006)) |
| 96 | .Build(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 97 | IdAssigner assigner; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 98 | ASSERT_FALSE(assigner.Consume(context.get(), table.get())); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 99 | } |
| 100 | |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 101 | TEST_F(IdAssignerTests, AssignIdsWithIdMap) { |
| 102 | auto table = test::ResourceTableBuilder() |
| 103 | .AddSimple("android:attr/foo") |
| 104 | .AddSimple("android:attr/bar") |
| 105 | .Build(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 106 | std::unordered_map<ResourceName, ResourceId> id_map = { |
| 107 | {test::ParseNameOrDie("android:attr/foo"), ResourceId(0x01010002)}}; |
| 108 | IdAssigner assigner(&id_map); |
| 109 | ASSERT_TRUE(assigner.Consume(context.get(), table.get())); |
| 110 | ASSERT_TRUE(VerifyIds(table.get())); |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 111 | auto result = table->FindResource(test::ParseNameOrDie("android:attr/foo")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame] | 112 | ASSERT_TRUE(result); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 113 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 114 | const ResourceTable::SearchResult& search_result = result.value(); |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 115 | EXPECT_EQ(make_value<ResourceId>(0x01010002), search_result.entry->id); |
| 116 | } |
| 117 | |
| 118 | TEST_F(IdAssignerTests, UseAllEntryIds) { |
| 119 | ResourceTable table; |
| 120 | const size_t max_entry_id = std::numeric_limits<uint16_t>::max(); |
| 121 | for (size_t i = 0; i <= max_entry_id; i++) { |
| 122 | ASSERT_TRUE( |
| 123 | table.AddResource(NewResourceBuilder("android:attr/res" + std::to_string(i)).Build(), |
| 124 | context->GetDiagnostics())); |
| 125 | } |
| 126 | IdAssigner assigner; |
| 127 | ASSERT_TRUE(assigner.Consume(context.get(), &table)); |
| 128 | } |
| 129 | |
| 130 | TEST_F(IdAssignerTests, ExaustEntryIds) { |
| 131 | ResourceTable table; |
| 132 | const size_t max_entry_id = std::numeric_limits<uint16_t>::max() + 1u; |
| 133 | for (size_t i = 0; i <= max_entry_id; i++) { |
| 134 | ASSERT_TRUE( |
| 135 | table.AddResource(NewResourceBuilder("android:attr/res" + std::to_string(i)).Build(), |
| 136 | context->GetDiagnostics())); |
| 137 | } |
| 138 | IdAssigner assigner; |
| 139 | ASSERT_FALSE(assigner.Consume(context.get(), &table)); |
| 140 | } |
| 141 | |
| 142 | TEST_F(IdAssignerTests, ExaustEntryIdsLastIdIsPublic) { |
| 143 | ResourceTable table; |
| 144 | ASSERT_TRUE(table.AddResource(NewResourceBuilder("android:attr/res").SetId(0x0101ffff).Build(), |
| 145 | context->GetDiagnostics())); |
| 146 | const size_t max_entry_id = std::numeric_limits<uint16_t>::max(); |
| 147 | for (size_t i = 0; i <= max_entry_id; i++) { |
| 148 | ASSERT_TRUE( |
| 149 | table.AddResource(NewResourceBuilder("android:attr/res" + std::to_string(i)).Build(), |
| 150 | context->GetDiagnostics())); |
| 151 | } |
| 152 | IdAssigner assigner; |
| 153 | ASSERT_FALSE(assigner.Consume(context.get(), &table)); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 154 | } |
| 155 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 156 | ::testing::AssertionResult VerifyIds(ResourceTable* table) { |
| 157 | std::set<uint8_t> package_ids; |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 158 | auto table_view = table->GetPartitionedView(); |
| 159 | for (auto& package : table_view.packages) { |
| 160 | if (!package.id) { |
| 161 | return ::testing::AssertionFailure() << "package " << package.name << " has no ID"; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 162 | } |
| 163 | |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 164 | if (!package_ids.insert(package.id.value()).second) { |
| 165 | return ::testing::AssertionFailure() << "package " << package.name << " has non-unique ID " |
| 166 | << std::hex << (int)package.id.value() << std::dec; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 167 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 168 | } |
| 169 | |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 170 | for (auto& package : table_view.packages) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 171 | std::set<uint8_t> type_ids; |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 172 | for (auto& type : package.types) { |
| 173 | if (!type.id) { |
| 174 | return ::testing::AssertionFailure() |
| 175 | << "type " << type.type << " of package " << package.name << " has no ID"; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 176 | } |
| 177 | |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 178 | if (!type_ids.insert(type.id.value()).second) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 179 | return ::testing::AssertionFailure() |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 180 | << "type " << type.type << " of package " << package.name << " has non-unique ID " |
| 181 | << std::hex << (int)type.id.value() << std::dec; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 182 | } |
| 183 | } |
| 184 | |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 185 | for (auto& type : package.types) { |
| 186 | std::set<ResourceId> entry_ids; |
| 187 | for (auto& entry : type.entries) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 188 | if (!entry->id) { |
| 189 | return ::testing::AssertionFailure() |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 190 | << "entry " << entry->name << " of type " << type.type << " of package " |
| 191 | << package.name << " has no ID"; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 192 | } |
| 193 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 194 | if (!entry_ids.insert(entry->id.value()).second) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 195 | return ::testing::AssertionFailure() |
Ryan Mitchell | 1d008d1 | 2021-03-19 14:54:17 -0700 | [diff] [blame^] | 196 | << "entry " << entry->name << " of type " << type.type << " of package " |
| 197 | << package.name << " has non-unique ID " << std::hex << entry->id.value() |
| 198 | << std::dec; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 199 | } |
| 200 | } |
| 201 | } |
| 202 | } |
| 203 | return ::testing::AssertionSuccess() << "all IDs are unique and assigned"; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 204 | } |
| 205 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 206 | } // namespace aapt |