Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "compile/IdAssigner.h" |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 18 | |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 19 | #include "test/Test.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 20 | |
| 21 | namespace aapt { |
| 22 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 23 | ::testing::AssertionResult VerifyIds(ResourceTable* table); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 24 | |
| 25 | TEST(IdAssignerTest, AssignIds) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 26 | std::unique_ptr<ResourceTable> table = test::ResourceTableBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 27 | .AddSimple("android:attr/foo") |
| 28 | .AddSimple("android:attr/bar") |
| 29 | .AddSimple("android:id/foo") |
| 30 | .SetPackageId("android", 0x01) |
| 31 | .Build(); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 32 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 33 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 34 | IdAssigner assigner; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 35 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 36 | ASSERT_TRUE(assigner.Consume(context.get(), table.get())); |
| 37 | ASSERT_TRUE(VerifyIds(table.get())); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 38 | } |
| 39 | |
| 40 | TEST(IdAssignerTest, AssignIdsWithReservedIds) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 41 | std::unique_ptr<ResourceTable> table = |
| 42 | test::ResourceTableBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 43 | .AddSimple("android:id/foo", ResourceId(0x01010000)) |
| 44 | .AddSimple("android:dimen/two") |
| 45 | .AddSimple("android:integer/three") |
| 46 | .AddSimple("android:string/five") |
| 47 | .AddSimple("android:attr/fun", ResourceId(0x01040000)) |
| 48 | .AddSimple("android:attr/foo", ResourceId(0x01040006)) |
| 49 | .AddSimple("android:attr/bar") |
| 50 | .AddSimple("android:attr/baz") |
| 51 | .AddSimple("app:id/biz") |
| 52 | .SetPackageId("android", 0x01) |
| 53 | .SetPackageId("app", 0x7f) |
| 54 | .Build(); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 55 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 56 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 57 | IdAssigner assigner; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 58 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 59 | ASSERT_TRUE(assigner.Consume(context.get(), table.get())); |
| 60 | ASSERT_TRUE(VerifyIds(table.get())); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 61 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 62 | Maybe<ResourceTable::SearchResult> maybe_result; |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 63 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 64 | // Expect to fill in the gaps between 0x0101XXXX and 0x0104XXXX. |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 65 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 66 | maybe_result = table->FindResource(test::ParseNameOrDie("android:dimen/two")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame^] | 67 | ASSERT_TRUE(maybe_result); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 68 | EXPECT_EQ(make_value<uint8_t>(2), maybe_result.value().type->id); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 69 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 70 | maybe_result = |
| 71 | table->FindResource(test::ParseNameOrDie("android:integer/three")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame^] | 72 | ASSERT_TRUE(maybe_result); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 73 | EXPECT_EQ(make_value<uint8_t>(3), maybe_result.value().type->id); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 74 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 75 | // Expect to bypass the reserved 0x0104XXXX IDs and use the next 0x0105XXXX |
| 76 | // IDs. |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 77 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 78 | maybe_result = |
| 79 | table->FindResource(test::ParseNameOrDie("android:string/five")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame^] | 80 | ASSERT_TRUE(maybe_result); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 81 | EXPECT_EQ(make_value<uint8_t>(5), maybe_result.value().type->id); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 82 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 83 | // Expect to fill in the gaps between 0x01040000 and 0x01040006. |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 84 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 85 | maybe_result = table->FindResource(test::ParseNameOrDie("android:attr/bar")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame^] | 86 | ASSERT_TRUE(maybe_result); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 87 | EXPECT_EQ(make_value<uint16_t>(1), maybe_result.value().entry->id); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 88 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 89 | maybe_result = table->FindResource(test::ParseNameOrDie("android:attr/baz")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame^] | 90 | ASSERT_TRUE(maybe_result); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 91 | EXPECT_EQ(make_value<uint16_t>(2), maybe_result.value().entry->id); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 92 | } |
| 93 | |
| 94 | TEST(IdAssignerTest, FailWhenNonUniqueIdsAssigned) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 95 | std::unique_ptr<ResourceTable> table = |
| 96 | test::ResourceTableBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 97 | .AddSimple("android:attr/foo", ResourceId(0x01040006)) |
| 98 | .AddSimple("android:attr/bar", ResourceId(0x01040006)) |
| 99 | .SetPackageId("android", 0x01) |
| 100 | .SetPackageId("app", 0x7f) |
| 101 | .Build(); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 102 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 103 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 104 | IdAssigner assigner; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 105 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 106 | ASSERT_FALSE(assigner.Consume(context.get(), table.get())); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 107 | } |
| 108 | |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 109 | TEST(IdAssignerTest, AssignIdsWithIdMap) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 110 | std::unique_ptr<ResourceTable> table = test::ResourceTableBuilder() |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 111 | .AddSimple("android:attr/foo") |
| 112 | .AddSimple("android:attr/bar") |
| 113 | .SetPackageId("android", 0x01) |
| 114 | .Build(); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 115 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 116 | std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build(); |
| 117 | std::unordered_map<ResourceName, ResourceId> id_map = { |
| 118 | {test::ParseNameOrDie("android:attr/foo"), ResourceId(0x01010002)}}; |
| 119 | IdAssigner assigner(&id_map); |
| 120 | ASSERT_TRUE(assigner.Consume(context.get(), table.get())); |
| 121 | ASSERT_TRUE(VerifyIds(table.get())); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 122 | Maybe<ResourceTable::SearchResult> result = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 123 | table->FindResource(test::ParseNameOrDie("android:attr/foo")); |
Adam Lesinski | a45893a | 2017-05-30 15:19:02 -0700 | [diff] [blame^] | 124 | ASSERT_TRUE(result); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 125 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 126 | const ResourceTable::SearchResult& search_result = result.value(); |
| 127 | EXPECT_EQ(make_value<uint8_t>(0x01), search_result.package->id); |
| 128 | EXPECT_EQ(make_value<uint8_t>(0x01), search_result.type->id); |
| 129 | EXPECT_EQ(make_value<uint16_t>(0x0002), search_result.entry->id); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 130 | } |
| 131 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 132 | ::testing::AssertionResult VerifyIds(ResourceTable* table) { |
| 133 | std::set<uint8_t> package_ids; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 134 | for (auto& package : table->packages) { |
| 135 | if (!package->id) { |
| 136 | return ::testing::AssertionFailure() << "package " << package->name |
| 137 | << " has no ID"; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 138 | } |
| 139 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 140 | if (!package_ids.insert(package->id.value()).second) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 141 | return ::testing::AssertionFailure() |
| 142 | << "package " << package->name << " has non-unique ID " << std::hex |
| 143 | << (int)package->id.value() << std::dec; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 144 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 145 | } |
| 146 | |
| 147 | for (auto& package : table->packages) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 148 | std::set<uint8_t> type_ids; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 149 | for (auto& type : package->types) { |
| 150 | if (!type->id) { |
| 151 | return ::testing::AssertionFailure() << "type " << type->type |
| 152 | << " of package " << package->name |
| 153 | << " has no ID"; |
| 154 | } |
| 155 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 156 | if (!type_ids.insert(type->id.value()).second) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 157 | return ::testing::AssertionFailure() |
| 158 | << "type " << type->type << " of package " << package->name |
| 159 | << " has non-unique ID " << std::hex << (int)type->id.value() |
| 160 | << std::dec; |
| 161 | } |
| 162 | } |
| 163 | |
| 164 | for (auto& type : package->types) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 165 | std::set<uint16_t> entry_ids; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 166 | for (auto& entry : type->entries) { |
| 167 | if (!entry->id) { |
| 168 | return ::testing::AssertionFailure() |
| 169 | << "entry " << entry->name << " of type " << type->type |
| 170 | << " of package " << package->name << " has no ID"; |
| 171 | } |
| 172 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 173 | if (!entry_ids.insert(entry->id.value()).second) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 174 | return ::testing::AssertionFailure() |
| 175 | << "entry " << entry->name << " of type " << type->type |
| 176 | << " of package " << package->name << " has non-unique ID " |
| 177 | << std::hex << (int)entry->id.value() << std::dec; |
| 178 | } |
| 179 | } |
| 180 | } |
| 181 | } |
| 182 | return ::testing::AssertionSuccess() << "all IDs are unique and assigned"; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 183 | } |
| 184 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 185 | } // namespace aapt |