blob: 43cefbc00541de9ccb83b0bd8179365c5071e7d5 [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Park25fc6a92018-11-18 18:02:45 +090018 "io/ioutil"
19 "os"
Jooyung Han39edb6c2019-11-06 16:53:07 +090020 "path"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070021 "reflect"
Paul Duffinbf19a972020-05-26 13:21:35 +010022 "regexp"
Jooyung Han31c470b2019-10-18 16:26:59 +090023 "sort"
Jiyong Park25fc6a92018-11-18 18:02:45 +090024 "strings"
25 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090026
27 "github.com/google/blueprint/proptools"
28
29 "android/soong/android"
30 "android/soong/cc"
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +000031 "android/soong/dexpreopt"
Jaewoong Jungfccad6b2020-06-01 10:45:49 -070032 prebuilt_etc "android/soong/etc"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090033 "android/soong/java"
Jaewoong Jungfccad6b2020-06-01 10:45:49 -070034 "android/soong/sh"
Jiyong Park25fc6a92018-11-18 18:02:45 +090035)
36
Jaewoong Jung14f5ff62019-06-18 13:09:13 -070037var buildDir string
38
Jooyung Hand3639552019-08-09 12:57:43 +090039// names returns name list from white space separated string
40func names(s string) (ns []string) {
41 for _, n := range strings.Split(s, " ") {
42 if len(n) > 0 {
43 ns = append(ns, n)
44 }
45 }
46 return
47}
48
Jooyung Han344d5432019-08-23 11:17:39 +090049func testApexError(t *testing.T, pattern, bp string, handlers ...testCustomizer) {
50 t.Helper()
51 ctx, config := testApexContext(t, bp, handlers...)
Jooyung Han5c998b92019-06-27 11:30:33 +090052 _, errs := ctx.ParseFileList(".", []string{"Android.bp"})
53 if len(errs) > 0 {
54 android.FailIfNoMatchingErrors(t, pattern, errs)
55 return
56 }
57 _, errs = ctx.PrepareBuildActions(config)
58 if len(errs) > 0 {
59 android.FailIfNoMatchingErrors(t, pattern, errs)
60 return
61 }
62
63 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
64}
65
Jooyung Han344d5432019-08-23 11:17:39 +090066func testApex(t *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) {
67 t.Helper()
68 ctx, config := testApexContext(t, bp, handlers...)
Paul Duffinf642a312020-06-12 17:46:39 +010069 _, errs := ctx.ParseBlueprintsFiles(".")
Jooyung Han5c998b92019-06-27 11:30:33 +090070 android.FailIfErrored(t, errs)
71 _, errs = ctx.PrepareBuildActions(config)
72 android.FailIfErrored(t, errs)
Jaewoong Jung22f7d182019-07-16 18:25:41 -070073 return ctx, config
Jooyung Han5c998b92019-06-27 11:30:33 +090074}
75
Jooyung Han344d5432019-08-23 11:17:39 +090076type testCustomizer func(fs map[string][]byte, config android.Config)
77
78func withFiles(files map[string][]byte) testCustomizer {
79 return func(fs map[string][]byte, config android.Config) {
80 for k, v := range files {
81 fs[k] = v
82 }
83 }
84}
85
86func withTargets(targets map[android.OsType][]android.Target) testCustomizer {
87 return func(fs map[string][]byte, config android.Config) {
88 for k, v := range targets {
89 config.Targets[k] = v
90 }
91 }
92}
93
Jiyong Parkaf8998c2020-02-28 16:51:07 +090094func withManifestPackageNameOverrides(specs []string) testCustomizer {
95 return func(fs map[string][]byte, config android.Config) {
96 config.TestProductVariables.ManifestPackageNameOverrides = specs
97 }
98}
99
Sasha Smundakc4f0ff12020-05-27 16:36:07 -0700100func withBinder32bit(_ map[string][]byte, config android.Config) {
Jooyung Han31c470b2019-10-18 16:26:59 +0900101 config.TestProductVariables.Binder32bit = proptools.BoolPtr(true)
102}
103
Sasha Smundakc4f0ff12020-05-27 16:36:07 -0700104func withUnbundledBuild(_ map[string][]byte, config android.Config) {
Jiyong Park7cd10e32020-01-14 09:22:18 +0900105 config.TestProductVariables.Unbundled_build = proptools.BoolPtr(true)
106}
107
Sasha Smundakc4f0ff12020-05-27 16:36:07 -0700108func testApexContext(_ *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) {
Jooyung Han671f1ce2019-12-17 12:47:13 +0900109 android.ClearApexDependency()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900110
111 bp = bp + `
Jooyung Han54aca7b2019-11-20 02:26:02 +0900112 filegroup {
113 name: "myapex-file_contexts",
114 srcs: [
115 "system/sepolicy/apex/myapex-file_contexts",
116 ],
117 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900118 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800119
Colin Crossf9aabd72020-02-15 11:29:50 -0800120 bp = bp + cc.GatherRequiredDepsForTest(android.Android)
121
Dario Frenicde2a032019-10-27 00:29:22 +0100122 bp = bp + java.GatherRequiredDepsForTest()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900123
Jooyung Han344d5432019-08-23 11:17:39 +0900124 fs := map[string][]byte{
Jooyung Han54aca7b2019-11-20 02:26:02 +0900125 "a.java": nil,
126 "PrebuiltAppFoo.apk": nil,
127 "PrebuiltAppFooPriv.apk": nil,
128 "build/make/target/product/security": nil,
129 "apex_manifest.json": nil,
130 "AndroidManifest.xml": nil,
131 "system/sepolicy/apex/myapex-file_contexts": nil,
Jiyong Park9d677202020-02-19 16:29:35 +0900132 "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
Jiyong Park83dc74b2020-01-14 18:38:44 +0900133 "system/sepolicy/apex/myapex2-file_contexts": nil,
Jooyung Han54aca7b2019-11-20 02:26:02 +0900134 "system/sepolicy/apex/otherapex-file_contexts": nil,
135 "system/sepolicy/apex/commonapex-file_contexts": nil,
136 "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
Colin Cross98be1bb2019-12-13 20:41:13 -0800137 "mylib.cpp": nil,
138 "mylib_common.cpp": nil,
139 "mytest.cpp": nil,
140 "mytest1.cpp": nil,
141 "mytest2.cpp": nil,
142 "mytest3.cpp": nil,
143 "myprebuilt": nil,
144 "my_include": nil,
145 "foo/bar/MyClass.java": nil,
146 "prebuilt.jar": nil,
Paul Duffin3766cb72020-04-07 15:25:44 +0100147 "prebuilt.so": nil,
Colin Cross98be1bb2019-12-13 20:41:13 -0800148 "vendor/foo/devkeys/test.x509.pem": nil,
149 "vendor/foo/devkeys/test.pk8": nil,
150 "testkey.x509.pem": nil,
151 "testkey.pk8": nil,
152 "testkey.override.x509.pem": nil,
153 "testkey.override.pk8": nil,
154 "vendor/foo/devkeys/testkey.avbpubkey": nil,
155 "vendor/foo/devkeys/testkey.pem": nil,
156 "NOTICE": nil,
157 "custom_notice": nil,
Jiyong Park162e8442020-03-17 19:16:40 +0900158 "custom_notice_for_static_lib": nil,
Colin Cross98be1bb2019-12-13 20:41:13 -0800159 "testkey2.avbpubkey": nil,
160 "testkey2.pem": nil,
161 "myapex-arm64.apex": nil,
162 "myapex-arm.apex": nil,
Jaewoong Jung8cf307e2020-05-14 14:15:24 -0700163 "myapex.apks": nil,
Colin Cross98be1bb2019-12-13 20:41:13 -0800164 "frameworks/base/api/current.txt": nil,
165 "framework/aidl/a.aidl": nil,
166 "build/make/core/proguard.flags": nil,
167 "build/make/core/proguard_basic_keeps.flags": nil,
168 "dummy.txt": nil,
Sasha Smundakc4f0ff12020-05-27 16:36:07 -0700169 "AppSet.apks": nil,
Jooyung Han344d5432019-08-23 11:17:39 +0900170 }
171
Colin Crossf9aabd72020-02-15 11:29:50 -0800172 cc.GatherRequiredFilesForTest(fs)
173
Jooyung Han344d5432019-08-23 11:17:39 +0900174 for _, handler := range handlers {
Colin Cross98be1bb2019-12-13 20:41:13 -0800175 // The fs now needs to be populated before creating the config, call handlers twice
176 // for now, once to get any fs changes, and later after the config was created to
177 // set product variables or targets.
178 tempConfig := android.TestArchConfig(buildDir, nil, bp, fs)
179 handler(fs, tempConfig)
Jooyung Han344d5432019-08-23 11:17:39 +0900180 }
181
Colin Cross98be1bb2019-12-13 20:41:13 -0800182 config := android.TestArchConfig(buildDir, nil, bp, fs)
183 config.TestProductVariables.DeviceVndkVersion = proptools.StringPtr("current")
184 config.TestProductVariables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
185 config.TestProductVariables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
186 config.TestProductVariables.Platform_sdk_codename = proptools.StringPtr("Q")
187 config.TestProductVariables.Platform_sdk_final = proptools.BoolPtr(false)
188 config.TestProductVariables.Platform_vndk_version = proptools.StringPtr("VER")
189
190 for _, handler := range handlers {
191 // The fs now needs to be populated before creating the config, call handlers twice
192 // for now, earlier to get any fs changes, and now after the config was created to
193 // set product variables or targets.
194 tempFS := map[string][]byte{}
195 handler(tempFS, config)
196 }
197
198 ctx := android.NewTestArchContext()
Paul Duffinf642a312020-06-12 17:46:39 +0100199
200 // from android package
201 android.RegisterPackageBuildComponents(ctx)
202 ctx.PreArchMutators(android.RegisterVisibilityRuleChecker)
203
Colin Cross98be1bb2019-12-13 20:41:13 -0800204 ctx.RegisterModuleType("apex", BundleFactory)
205 ctx.RegisterModuleType("apex_test", testApexBundleFactory)
206 ctx.RegisterModuleType("apex_vndk", vndkApexBundleFactory)
207 ctx.RegisterModuleType("apex_key", ApexKeyFactory)
208 ctx.RegisterModuleType("apex_defaults", defaultsFactory)
209 ctx.RegisterModuleType("prebuilt_apex", PrebuiltFactory)
210 ctx.RegisterModuleType("override_apex", overrideApexFactory)
Jaewoong Jung8cf307e2020-05-14 14:15:24 -0700211 ctx.RegisterModuleType("apex_set", apexSetFactory)
Colin Cross98be1bb2019-12-13 20:41:13 -0800212
Jooyung Hana57af4a2020-01-23 05:36:59 +0000213 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
214 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
215
Paul Duffin77980a82019-12-19 16:01:36 +0000216 cc.RegisterRequiredBuildComponentsForTest(ctx)
Paul Duffinf642a312020-06-12 17:46:39 +0100217
218 // Register this after the prebuilt mutators have been registered (in
219 // cc.RegisterRequiredBuildComponentsForTest) to match what happens at runtime.
220 ctx.PreArchMutators(android.RegisterVisibilityRuleGatherer)
221 ctx.PostDepsMutators(android.RegisterVisibilityRuleEnforcer)
222
Colin Cross98be1bb2019-12-13 20:41:13 -0800223 ctx.RegisterModuleType("cc_test", cc.TestFactory)
Colin Cross98be1bb2019-12-13 20:41:13 -0800224 ctx.RegisterModuleType("vndk_prebuilt_shared", cc.VndkPrebuiltSharedFactory)
225 ctx.RegisterModuleType("vndk_libraries_txt", cc.VndkLibrariesTxtFactory)
Jaewoong Jungfccad6b2020-06-01 10:45:49 -0700226 ctx.RegisterModuleType("prebuilt_etc", prebuilt_etc.PrebuiltEtcFactory)
atrost6e126252020-01-27 17:01:16 +0000227 ctx.RegisterModuleType("platform_compat_config", java.PlatformCompatConfigFactory)
Jaewoong Jungfccad6b2020-06-01 10:45:49 -0700228 ctx.RegisterModuleType("sh_binary", sh.ShBinaryFactory)
Colin Cross98be1bb2019-12-13 20:41:13 -0800229 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Paul Duffinf9b1da02019-12-18 19:51:55 +0000230 java.RegisterJavaBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +0000231 java.RegisterSystemModulesBuildComponents(ctx)
Paul Duffinf9b1da02019-12-18 19:51:55 +0000232 java.RegisterAppBuildComponents(ctx)
Paul Duffinf642a312020-06-12 17:46:39 +0100233 java.RegisterSdkLibraryBuildComponents(ctx)
Colin Cross98be1bb2019-12-13 20:41:13 -0800234
Colin Cross98be1bb2019-12-13 20:41:13 -0800235 ctx.PreDepsMutators(RegisterPreDepsMutators)
Colin Cross98be1bb2019-12-13 20:41:13 -0800236 ctx.PostDepsMutators(RegisterPostDepsMutators)
Colin Cross98be1bb2019-12-13 20:41:13 -0800237
238 ctx.Register(config)
Jiyong Park25fc6a92018-11-18 18:02:45 +0900239
Jooyung Han5c998b92019-06-27 11:30:33 +0900240 return ctx, config
Jiyong Park25fc6a92018-11-18 18:02:45 +0900241}
242
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700243func setUp() {
244 var err error
245 buildDir, err = ioutil.TempDir("", "soong_apex_test")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900246 if err != nil {
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700247 panic(err)
Jiyong Park25fc6a92018-11-18 18:02:45 +0900248 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900249}
250
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700251func tearDown() {
Sasha Smundakc4f0ff12020-05-27 16:36:07 -0700252 _ = os.RemoveAll(buildDir)
Jiyong Park25fc6a92018-11-18 18:02:45 +0900253}
254
255// ensure that 'result' contains 'expected'
256func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900257 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900258 if !strings.Contains(result, expected) {
259 t.Errorf("%q is not found in %q", expected, result)
260 }
261}
262
263// ensures that 'result' does not contain 'notExpected'
264func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900265 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900266 if strings.Contains(result, notExpected) {
267 t.Errorf("%q is found in %q", notExpected, result)
268 }
269}
270
Sasha Smundakc4f0ff12020-05-27 16:36:07 -0700271func ensureMatches(t *testing.T, result string, expectedRex string) {
272 ok, err := regexp.MatchString(expectedRex, result)
273 if err != nil {
274 t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
275 return
276 }
277 if !ok {
278 t.Errorf("%s does not match regular expession %s", result, expectedRex)
279 }
280}
281
Jiyong Park25fc6a92018-11-18 18:02:45 +0900282func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900283 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900284 if !android.InList(expected, result) {
285 t.Errorf("%q is not found in %v", expected, result)
286 }
287}
288
289func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900290 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900291 if android.InList(notExpected, result) {
292 t.Errorf("%q is found in %v", notExpected, result)
293 }
294}
295
Jooyung Hane1633032019-08-01 17:41:43 +0900296func ensureListEmpty(t *testing.T, result []string) {
297 t.Helper()
298 if len(result) > 0 {
299 t.Errorf("%q is expected to be empty", result)
300 }
301}
302
Jiyong Park25fc6a92018-11-18 18:02:45 +0900303// Minimal test
304func TestBasicApex(t *testing.T) {
Jiyong Parke26a63e2020-06-11 00:35:03 +0900305 ctx, config := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900306 apex_defaults {
307 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900308 manifest: ":myapex.manifest",
309 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900310 key: "myapex.key",
311 native_shared_libs: ["mylib"],
Alex Light3d673592019-01-18 14:37:31 -0800312 multilib: {
313 both: {
314 binaries: ["foo",],
315 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900316 },
Jiyong Park2cd081c2020-06-01 21:39:15 +0900317 java_libs: [
318 "myjar",
319 "myjar_dex",
320 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900321 }
322
Jiyong Park30ca9372019-02-07 16:27:23 +0900323 apex {
324 name: "myapex",
325 defaults: ["myapex-defaults"],
326 }
327
Jiyong Park25fc6a92018-11-18 18:02:45 +0900328 apex_key {
329 name: "myapex.key",
330 public_key: "testkey.avbpubkey",
331 private_key: "testkey.pem",
332 }
333
Jiyong Park809bb722019-02-13 21:33:49 +0900334 filegroup {
335 name: "myapex.manifest",
336 srcs: ["apex_manifest.json"],
337 }
338
339 filegroup {
340 name: "myapex.androidmanifest",
341 srcs: ["AndroidManifest.xml"],
342 }
343
Jiyong Park25fc6a92018-11-18 18:02:45 +0900344 cc_library {
345 name: "mylib",
346 srcs: ["mylib.cpp"],
347 shared_libs: ["mylib2"],
348 system_shared_libs: [],
349 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000350 // TODO: remove //apex_available:platform
351 apex_available: [
352 "//apex_available:platform",
353 "myapex",
354 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900355 }
356
Alex Light3d673592019-01-18 14:37:31 -0800357 cc_binary {
358 name: "foo",
359 srcs: ["mylib.cpp"],
360 compile_multilib: "both",
361 multilib: {
362 lib32: {
363 suffix: "32",
364 },
365 lib64: {
366 suffix: "64",
367 },
368 },
369 symlinks: ["foo_link_"],
370 symlink_preferred_arch: true,
371 system_shared_libs: [],
372 static_executable: true,
373 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000374 apex_available: [ "myapex" ],
Alex Light3d673592019-01-18 14:37:31 -0800375 }
376
Paul Duffin3766cb72020-04-07 15:25:44 +0100377 cc_library_shared {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900378 name: "mylib2",
379 srcs: ["mylib.cpp"],
380 system_shared_libs: [],
381 stl: "none",
Jiyong Park52818fc2019-03-18 12:01:38 +0900382 notice: "custom_notice",
Jiyong Park162e8442020-03-17 19:16:40 +0900383 static_libs: ["libstatic"],
384 // TODO: remove //apex_available:platform
385 apex_available: [
386 "//apex_available:platform",
387 "myapex",
388 ],
389 }
390
Paul Duffin3766cb72020-04-07 15:25:44 +0100391 cc_prebuilt_library_shared {
392 name: "mylib2",
393 srcs: ["prebuilt.so"],
394 // TODO: remove //apex_available:platform
395 apex_available: [
396 "//apex_available:platform",
397 "myapex",
398 ],
399 }
400
Jiyong Park162e8442020-03-17 19:16:40 +0900401 cc_library_static {
402 name: "libstatic",
403 srcs: ["mylib.cpp"],
404 system_shared_libs: [],
405 stl: "none",
406 notice: "custom_notice_for_static_lib",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000407 // TODO: remove //apex_available:platform
408 apex_available: [
409 "//apex_available:platform",
410 "myapex",
411 ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900412 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900413
414 java_library {
415 name: "myjar",
416 srcs: ["foo/bar/MyClass.java"],
Jiyong Parked50ca82020-05-28 23:46:55 +0900417 stem: "myjar_stem",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900418 sdk_version: "none",
419 system_modules: "none",
Jiyong Park7f7766d2019-07-25 22:02:35 +0900420 static_libs: ["myotherjar"],
Jiyong Park3ff16992019-12-27 14:11:47 +0900421 libs: ["mysharedjar"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000422 // TODO: remove //apex_available:platform
423 apex_available: [
424 "//apex_available:platform",
425 "myapex",
426 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900427 }
428
Jiyong Park2cd081c2020-06-01 21:39:15 +0900429 dex_import {
430 name: "myjar_dex",
431 jars: ["prebuilt.jar"],
432 apex_available: [
433 "//apex_available:platform",
434 "myapex",
435 ],
436 }
437
Jiyong Park7f7766d2019-07-25 22:02:35 +0900438 java_library {
439 name: "myotherjar",
440 srcs: ["foo/bar/MyClass.java"],
441 sdk_version: "none",
442 system_modules: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +0900443 // TODO: remove //apex_available:platform
444 apex_available: [
445 "//apex_available:platform",
446 "myapex",
447 ],
Jiyong Park7f7766d2019-07-25 22:02:35 +0900448 }
Jiyong Park3ff16992019-12-27 14:11:47 +0900449
450 java_library {
451 name: "mysharedjar",
452 srcs: ["foo/bar/MyClass.java"],
453 sdk_version: "none",
454 system_modules: "none",
Jiyong Park3ff16992019-12-27 14:11:47 +0900455 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900456 `)
457
Sundong Ahnabb64432019-10-22 13:58:29 +0900458 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900459
Jiyong Parke26a63e2020-06-11 00:35:03 +0900460 // Make sure that Android.mk is created
461 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
462 data := android.AndroidMkDataForTest(t, config, "", ab)
463 var builder strings.Builder
464 data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
465
466 androidMk := builder.String()
467 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
468 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
469
Jiyong Park42cca6c2019-04-01 11:15:50 +0900470 optFlags := apexRule.Args["opt_flags"]
471 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700472 // Ensure that the NOTICE output is being packaged as an asset.
Sundong Ahnabb64432019-10-22 13:58:29 +0900473 ensureContains(t, optFlags, "--assets_dir "+buildDir+"/.intermediates/myapex/android_common_myapex_image/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900474
Jiyong Park25fc6a92018-11-18 18:02:45 +0900475 copyCmds := apexRule.Args["copy_commands"]
476
477 // Ensure that main rule creates an output
478 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
479
480 // Ensure that apex variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -0800481 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900482 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_myapex")
Jiyong Park2cd081c2020-06-01 21:39:15 +0900483 ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_myapex")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900484
485 // Ensure that apex variant is created for the indirect dep
Colin Cross7113d202019-11-20 16:39:12 -0800486 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_myapex")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900487 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_myapex")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900488
489 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800490 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
491 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Parked50ca82020-05-28 23:46:55 +0900492 ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
Jiyong Park2cd081c2020-06-01 21:39:15 +0900493 ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900494 // .. but not for java libs
495 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Jiyong Park3ff16992019-12-27 14:11:47 +0900496 ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800497
Colin Cross7113d202019-11-20 16:39:12 -0800498 // Ensure that the platform variant ends with _shared or _common
499 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
500 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900501 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
502 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park3ff16992019-12-27 14:11:47 +0900503 ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
504
505 // Ensure that dynamic dependency to java libs are not included
506 ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
Alex Light3d673592019-01-18 14:37:31 -0800507
508 // Ensure that all symlinks are present.
509 found_foo_link_64 := false
510 found_foo := false
511 for _, cmd := range strings.Split(copyCmds, " && ") {
Jiyong Park7cd10e32020-01-14 09:22:18 +0900512 if strings.HasPrefix(cmd, "ln -sfn foo64") {
Alex Light3d673592019-01-18 14:37:31 -0800513 if strings.HasSuffix(cmd, "bin/foo") {
514 found_foo = true
515 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
516 found_foo_link_64 = true
517 }
518 }
519 }
520 good := found_foo && found_foo_link_64
521 if !good {
522 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
523 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900524
Sundong Ahnabb64432019-10-22 13:58:29 +0900525 mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700526 noticeInputs := mergeNoticesRule.Inputs.Strings()
Jiyong Park162e8442020-03-17 19:16:40 +0900527 if len(noticeInputs) != 3 {
528 t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs))
Jiyong Park52818fc2019-03-18 12:01:38 +0900529 }
530 ensureListContains(t, noticeInputs, "NOTICE")
531 ensureListContains(t, noticeInputs, "custom_notice")
Jiyong Park162e8442020-03-17 19:16:40 +0900532 ensureListContains(t, noticeInputs, "custom_notice_for_static_lib")
Jiyong Park83dc74b2020-01-14 18:38:44 +0900533
Artur Satayev5e7c32d2020-04-27 18:07:06 +0100534 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev388d39b2020-04-27 18:53:18 +0100535 ensureListContains(t, fullDepsInfo, "myjar(minSdkVersion:(no version)) <- myapex")
536 ensureListContains(t, fullDepsInfo, "mylib(minSdkVersion:(no version)) <- myapex")
537 ensureListContains(t, fullDepsInfo, "mylib2(minSdkVersion:(no version)) <- mylib")
538 ensureListContains(t, fullDepsInfo, "myotherjar(minSdkVersion:(no version)) <- myjar")
539 ensureListContains(t, fullDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
Artur Satayev5e7c32d2020-04-27 18:07:06 +0100540
541 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev388d39b2020-04-27 18:53:18 +0100542 ensureListContains(t, flatDepsInfo, " myjar(minSdkVersion:(no version))")
543 ensureListContains(t, flatDepsInfo, " mylib(minSdkVersion:(no version))")
544 ensureListContains(t, flatDepsInfo, " mylib2(minSdkVersion:(no version))")
545 ensureListContains(t, flatDepsInfo, " myotherjar(minSdkVersion:(no version))")
546 ensureListContains(t, flatDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external)")
Alex Light5098a612018-11-29 17:12:15 -0800547}
548
Jooyung Hanf21c7972019-12-16 22:32:06 +0900549func TestDefaults(t *testing.T) {
550 ctx, _ := testApex(t, `
551 apex_defaults {
552 name: "myapex-defaults",
553 key: "myapex.key",
554 prebuilts: ["myetc"],
555 native_shared_libs: ["mylib"],
556 java_libs: ["myjar"],
557 apps: ["AppFoo"],
558 }
559
560 prebuilt_etc {
561 name: "myetc",
562 src: "myprebuilt",
563 }
564
565 apex {
566 name: "myapex",
567 defaults: ["myapex-defaults"],
568 }
569
570 apex_key {
571 name: "myapex.key",
572 public_key: "testkey.avbpubkey",
573 private_key: "testkey.pem",
574 }
575
576 cc_library {
577 name: "mylib",
578 system_shared_libs: [],
579 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000580 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900581 }
582
583 java_library {
584 name: "myjar",
585 srcs: ["foo/bar/MyClass.java"],
586 sdk_version: "none",
587 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000588 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900589 }
590
591 android_app {
592 name: "AppFoo",
593 srcs: ["foo/bar/MyClass.java"],
594 sdk_version: "none",
595 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000596 apex_available: [ "myapex" ],
Jooyung Hanf21c7972019-12-16 22:32:06 +0900597 }
598 `)
Jooyung Hana57af4a2020-01-23 05:36:59 +0000599 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Hanf21c7972019-12-16 22:32:06 +0900600 "etc/myetc",
601 "javalib/myjar.jar",
602 "lib64/mylib.so",
603 "app/AppFoo/AppFoo.apk",
604 })
605}
606
Jooyung Han01a3ee22019-11-02 02:52:25 +0900607func TestApexManifest(t *testing.T) {
608 ctx, _ := testApex(t, `
609 apex {
610 name: "myapex",
611 key: "myapex.key",
612 }
613
614 apex_key {
615 name: "myapex.key",
616 public_key: "testkey.avbpubkey",
617 private_key: "testkey.pem",
618 }
619 `)
620
621 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han214bf372019-11-12 13:03:50 +0900622 args := module.Rule("apexRule").Args
623 if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
624 t.Error("manifest should be apex_manifest.pb, but " + manifest)
625 }
Jooyung Han01a3ee22019-11-02 02:52:25 +0900626}
627
Alex Light5098a612018-11-29 17:12:15 -0800628func TestBasicZipApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700629 ctx, _ := testApex(t, `
Alex Light5098a612018-11-29 17:12:15 -0800630 apex {
631 name: "myapex",
632 key: "myapex.key",
633 payload_type: "zip",
634 native_shared_libs: ["mylib"],
635 }
636
637 apex_key {
638 name: "myapex.key",
639 public_key: "testkey.avbpubkey",
640 private_key: "testkey.pem",
641 }
642
643 cc_library {
644 name: "mylib",
645 srcs: ["mylib.cpp"],
646 shared_libs: ["mylib2"],
647 system_shared_libs: [],
648 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000649 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800650 }
651
652 cc_library {
653 name: "mylib2",
654 srcs: ["mylib.cpp"],
655 system_shared_libs: [],
656 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000657 apex_available: [ "myapex" ],
Alex Light5098a612018-11-29 17:12:15 -0800658 }
659 `)
660
Sundong Ahnabb64432019-10-22 13:58:29 +0900661 zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
Alex Light5098a612018-11-29 17:12:15 -0800662 copyCmds := zipApexRule.Args["copy_commands"]
663
664 // Ensure that main rule creates an output
665 ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
666
667 // Ensure that APEX variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -0800668 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex")
Alex Light5098a612018-11-29 17:12:15 -0800669
670 // Ensure that APEX variant is created for the indirect dep
Colin Cross7113d202019-11-20 16:39:12 -0800671 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_myapex")
Alex Light5098a612018-11-29 17:12:15 -0800672
673 // Ensure that both direct and indirect deps are copied into apex
674 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
675 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900676}
677
678func TestApexWithStubs(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700679 ctx, _ := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900680 apex {
681 name: "myapex",
682 key: "myapex.key",
683 native_shared_libs: ["mylib", "mylib3"],
684 }
685
686 apex_key {
687 name: "myapex.key",
688 public_key: "testkey.avbpubkey",
689 private_key: "testkey.pem",
690 }
691
692 cc_library {
693 name: "mylib",
694 srcs: ["mylib.cpp"],
695 shared_libs: ["mylib2", "mylib3"],
696 system_shared_libs: [],
697 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000698 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900699 }
700
701 cc_library {
702 name: "mylib2",
703 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900704 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900705 system_shared_libs: [],
706 stl: "none",
707 stubs: {
708 versions: ["1", "2", "3"],
709 },
710 }
711
712 cc_library {
713 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900714 srcs: ["mylib.cpp"],
715 shared_libs: ["mylib4"],
716 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900717 stl: "none",
718 stubs: {
719 versions: ["10", "11", "12"],
720 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000721 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900722 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900723
724 cc_library {
725 name: "mylib4",
726 srcs: ["mylib.cpp"],
727 system_shared_libs: [],
728 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000729 apex_available: [ "myapex" ],
Jiyong Park28d395a2018-12-07 22:42:47 +0900730 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900731 `)
732
Sundong Ahnabb64432019-10-22 13:58:29 +0900733 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900734 copyCmds := apexRule.Args["copy_commands"]
735
736 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800737 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900738
739 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800740 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900741
742 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800743 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900744
Colin Cross7113d202019-11-20 16:39:12 -0800745 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_myapex").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900746
747 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900748 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_3/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900749 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Park3ff16992019-12-27 14:11:47 +0900750 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900751
752 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Colin Cross7113d202019-11-20 16:39:12 -0800753 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_myapex/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900754 // .. and not linking to the stubs variant of mylib3
Colin Cross7113d202019-11-20 16:39:12 -0800755 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12_myapex/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900756
757 // Ensure that stubs libs are built without -include flags
Jiyong Park0f80c182020-01-31 02:49:53 +0900758 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park64379952018-12-13 18:37:29 +0900759 ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +0900760
761 // Ensure that genstub is invoked with --apex
Jiyong Park3ff16992019-12-27 14:11:47 +0900762 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_3").Rule("genStubSrc").Args["flags"])
Jooyung Han671f1ce2019-12-17 12:47:13 +0900763
Jooyung Hana57af4a2020-01-23 05:36:59 +0000764 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han671f1ce2019-12-17 12:47:13 +0900765 "lib64/mylib.so",
766 "lib64/mylib3.so",
767 "lib64/mylib4.so",
768 })
Jiyong Park25fc6a92018-11-18 18:02:45 +0900769}
770
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900771func TestApexWithExplicitStubsDependency(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700772 ctx, _ := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900773 apex {
Jiyong Park83dc74b2020-01-14 18:38:44 +0900774 name: "myapex2",
775 key: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900776 native_shared_libs: ["mylib"],
777 }
778
779 apex_key {
Jiyong Park83dc74b2020-01-14 18:38:44 +0900780 name: "myapex2.key",
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900781 public_key: "testkey.avbpubkey",
782 private_key: "testkey.pem",
783 }
784
785 cc_library {
786 name: "mylib",
787 srcs: ["mylib.cpp"],
788 shared_libs: ["libfoo#10"],
Jiyong Park678c8812020-02-07 17:25:49 +0900789 static_libs: ["libbaz"],
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900790 system_shared_libs: [],
791 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000792 apex_available: [ "myapex2" ],
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900793 }
794
795 cc_library {
796 name: "libfoo",
797 srcs: ["mylib.cpp"],
798 shared_libs: ["libbar"],
799 system_shared_libs: [],
800 stl: "none",
801 stubs: {
802 versions: ["10", "20", "30"],
803 },
804 }
805
806 cc_library {
807 name: "libbar",
808 srcs: ["mylib.cpp"],
809 system_shared_libs: [],
810 stl: "none",
811 }
812
Jiyong Park678c8812020-02-07 17:25:49 +0900813 cc_library_static {
814 name: "libbaz",
815 srcs: ["mylib.cpp"],
816 system_shared_libs: [],
817 stl: "none",
818 apex_available: [ "myapex2" ],
819 }
820
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900821 `)
822
Jiyong Park83dc74b2020-01-14 18:38:44 +0900823 apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900824 copyCmds := apexRule.Args["copy_commands"]
825
826 // Ensure that direct non-stubs dep is always included
827 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
828
829 // Ensure that indirect stubs dep is not included
830 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
831
832 // Ensure that dependency of stubs is not included
833 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
834
Jiyong Park83dc74b2020-01-14 18:38:44 +0900835 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_myapex2").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900836
837 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +0900838 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900839 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Park3ff16992019-12-27 14:11:47 +0900840 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900841
Jiyong Park3ff16992019-12-27 14:11:47 +0900842 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900843
844 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
845 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
Jiyong Park83dc74b2020-01-14 18:38:44 +0900846
Artur Satayev5e7c32d2020-04-27 18:07:06 +0100847 fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
Artur Satayev388d39b2020-04-27 18:53:18 +0100848 ensureListContains(t, fullDepsInfo, "mylib(minSdkVersion:(no version)) <- myapex2")
849 ensureListContains(t, fullDepsInfo, "libbaz(minSdkVersion:(no version)) <- mylib")
850 ensureListContains(t, fullDepsInfo, "libfoo(minSdkVersion:(no version)) (external) <- mylib")
Jiyong Park678c8812020-02-07 17:25:49 +0900851
Artur Satayev5e7c32d2020-04-27 18:07:06 +0100852 flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
Artur Satayev388d39b2020-04-27 18:53:18 +0100853 ensureListContains(t, flatDepsInfo, " mylib(minSdkVersion:(no version))")
854 ensureListContains(t, flatDepsInfo, " libbaz(minSdkVersion:(no version))")
855 ensureListContains(t, flatDepsInfo, " libfoo(minSdkVersion:(no version)) (external)")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900856}
857
Jooyung Hand3639552019-08-09 12:57:43 +0900858func TestApexWithRuntimeLibsDependency(t *testing.T) {
859 /*
860 myapex
861 |
862 v (runtime_libs)
863 mylib ------+------> libfoo [provides stub]
864 |
865 `------> libbar
866 */
867 ctx, _ := testApex(t, `
868 apex {
869 name: "myapex",
870 key: "myapex.key",
871 native_shared_libs: ["mylib"],
872 }
873
874 apex_key {
875 name: "myapex.key",
876 public_key: "testkey.avbpubkey",
877 private_key: "testkey.pem",
878 }
879
880 cc_library {
881 name: "mylib",
882 srcs: ["mylib.cpp"],
883 runtime_libs: ["libfoo", "libbar"],
884 system_shared_libs: [],
885 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000886 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +0900887 }
888
889 cc_library {
890 name: "libfoo",
891 srcs: ["mylib.cpp"],
892 system_shared_libs: [],
893 stl: "none",
894 stubs: {
895 versions: ["10", "20", "30"],
896 },
897 }
898
899 cc_library {
900 name: "libbar",
901 srcs: ["mylib.cpp"],
902 system_shared_libs: [],
903 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +0000904 apex_available: [ "myapex" ],
Jooyung Hand3639552019-08-09 12:57:43 +0900905 }
906
907 `)
908
Sundong Ahnabb64432019-10-22 13:58:29 +0900909 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +0900910 copyCmds := apexRule.Args["copy_commands"]
911
912 // Ensure that direct non-stubs dep is always included
913 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
914
915 // Ensure that indirect stubs dep is not included
916 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
917
918 // Ensure that runtime_libs dep in included
919 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
920
Sundong Ahnabb64432019-10-22 13:58:29 +0900921 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +0900922 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
923 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +0900924
925}
926
Jooyung Han67a96cd2020-03-13 15:23:36 +0900927func TestApexDependsOnLLNDKTransitively(t *testing.T) {
928 testcases := []struct {
929 name string
930 minSdkVersion string
931 shouldLink string
932 shouldNotLink []string
933 }{
934 {
Jooyung Han74066602020-03-20 04:29:24 +0900935 name: "should link to the latest",
Jooyung Han67a96cd2020-03-13 15:23:36 +0900936 minSdkVersion: "current",
937 shouldLink: "30",
938 shouldNotLink: []string{"29"},
939 },
940 {
941 name: "should link to llndk#29",
942 minSdkVersion: "29",
943 shouldLink: "29",
944 shouldNotLink: []string{"30"},
945 },
946 }
947 for _, tc := range testcases {
948 t.Run(tc.name, func(t *testing.T) {
949 ctx, _ := testApex(t, `
950 apex {
951 name: "myapex",
952 key: "myapex.key",
953 use_vendor: true,
954 native_shared_libs: ["mylib"],
955 min_sdk_version: "`+tc.minSdkVersion+`",
956 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900957
Jooyung Han67a96cd2020-03-13 15:23:36 +0900958 apex_key {
959 name: "myapex.key",
960 public_key: "testkey.avbpubkey",
961 private_key: "testkey.pem",
962 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900963
Jooyung Han67a96cd2020-03-13 15:23:36 +0900964 cc_library {
965 name: "mylib",
966 srcs: ["mylib.cpp"],
967 vendor_available: true,
968 shared_libs: ["libbar"],
969 system_shared_libs: [],
970 stl: "none",
971 apex_available: [ "myapex" ],
972 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900973
Jooyung Han67a96cd2020-03-13 15:23:36 +0900974 cc_library {
975 name: "libbar",
976 srcs: ["mylib.cpp"],
977 system_shared_libs: [],
978 stl: "none",
979 stubs: { versions: ["29","30"] },
980 }
Jooyung Han9c80bae2019-08-20 17:30:57 +0900981
Jooyung Han67a96cd2020-03-13 15:23:36 +0900982 llndk_library {
983 name: "libbar",
984 symbol_file: "",
985 }
986 `, func(fs map[string][]byte, config android.Config) {
987 setUseVendorWhitelistForTest(config, []string{"myapex"})
988 }, withUnbundledBuild)
Jooyung Han9c80bae2019-08-20 17:30:57 +0900989
Jooyung Han67a96cd2020-03-13 15:23:36 +0900990 // Ensure that LLNDK dep is not included
991 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
992 "lib64/mylib.so",
993 })
Jooyung Han9c80bae2019-08-20 17:30:57 +0900994
Jooyung Han67a96cd2020-03-13 15:23:36 +0900995 // Ensure that LLNDK dep is required
996 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
997 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
998 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +0900999
Jooyung Han67a96cd2020-03-13 15:23:36 +09001000 mylibLdFlags := ctx.ModuleForTests("mylib", "android_vendor.VER_arm64_armv8-a_shared_myapex").Rule("ld").Args["libFlags"]
1001 ensureContains(t, mylibLdFlags, "libbar.llndk/android_vendor.VER_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
1002 for _, ver := range tc.shouldNotLink {
1003 ensureNotContains(t, mylibLdFlags, "libbar.llndk/android_vendor.VER_arm64_armv8-a_shared_"+ver+"/libbar.so")
1004 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001005
Jooyung Han67a96cd2020-03-13 15:23:36 +09001006 mylibCFlags := ctx.ModuleForTests("mylib", "android_vendor.VER_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
1007 ensureContains(t, mylibCFlags, "__LIBBAR_API__="+tc.shouldLink)
1008 })
1009 }
Jooyung Han9c80bae2019-08-20 17:30:57 +09001010}
1011
Jiyong Park25fc6a92018-11-18 18:02:45 +09001012func TestApexWithSystemLibsStubs(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001013 ctx, _ := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +09001014 apex {
1015 name: "myapex",
1016 key: "myapex.key",
1017 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
1018 }
1019
1020 apex_key {
1021 name: "myapex.key",
1022 public_key: "testkey.avbpubkey",
1023 private_key: "testkey.pem",
1024 }
1025
1026 cc_library {
1027 name: "mylib",
1028 srcs: ["mylib.cpp"],
1029 shared_libs: ["libdl#27"],
1030 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001031 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001032 }
1033
1034 cc_library_shared {
1035 name: "mylib_shared",
1036 srcs: ["mylib.cpp"],
1037 shared_libs: ["libdl#27"],
1038 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001039 apex_available: [ "myapex" ],
Jiyong Park25fc6a92018-11-18 18:02:45 +09001040 }
1041
1042 cc_library {
Jiyong Parkb0788572018-12-20 22:10:17 +09001043 name: "libBootstrap",
1044 srcs: ["mylib.cpp"],
1045 stl: "none",
1046 bootstrap: true,
1047 }
Jiyong Park25fc6a92018-11-18 18:02:45 +09001048 `)
1049
Sundong Ahnabb64432019-10-22 13:58:29 +09001050 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001051 copyCmds := apexRule.Args["copy_commands"]
1052
1053 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -08001054 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +09001055 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
1056 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001057
1058 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +09001059 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001060
Colin Cross7113d202019-11-20 16:39:12 -08001061 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_myapex").Rule("ld").Args["libFlags"]
1062 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
1063 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_myapex").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001064
1065 // For dependency to libc
1066 // Ensure that mylib is linking with the latest version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001067 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_29/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001068 // ... and not linking to the non-stub (impl) variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001069 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001070 // ... Cflags from stub is correctly exported to mylib
1071 ensureContains(t, mylibCFlags, "__LIBC_API__=29")
1072 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=29")
1073
1074 // For dependency to libm
1075 // Ensure that mylib is linking with the non-stub (impl) variant
Colin Cross7113d202019-11-20 16:39:12 -08001076 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_myapex/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001077 // ... and not linking to the stub variant
Jiyong Park3ff16992019-12-27 14:11:47 +09001078 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001079 // ... and is not compiling with the stub
1080 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
1081 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
1082
1083 // For dependency to libdl
1084 // Ensure that mylib is linking with the specified version of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001085 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001086 // ... and not linking to the other versions of stubs
Jiyong Park3ff16992019-12-27 14:11:47 +09001087 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
1088 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001089 // ... and not linking to the non-stub (impl) variant
Colin Cross7113d202019-11-20 16:39:12 -08001090 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_myapex/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001091 // ... Cflags from stub is correctly exported to mylib
1092 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
1093 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +09001094
1095 // Ensure that libBootstrap is depending on the platform variant of bionic libs
Colin Cross7113d202019-11-20 16:39:12 -08001096 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
1097 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
1098 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
1099 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +09001100}
Jiyong Park7c2ee712018-12-07 00:42:25 +09001101
Jooyung Han0c4e0162020-02-26 22:45:42 +09001102func TestApexUseStubsAccordingToMinSdkVersionInUnbundledBuild(t *testing.T) {
1103 // there are three links between liba --> libz
1104 // 1) myapex -> libx -> liba -> libz : this should be #2 link, but fallback to #1
1105 // 2) otherapex -> liby -> liba -> libz : this should be #3 link
1106 // 3) (platform) -> liba -> libz : this should be non-stub link
1107 ctx, _ := testApex(t, `
1108 apex {
1109 name: "myapex",
1110 key: "myapex.key",
1111 native_shared_libs: ["libx"],
1112 min_sdk_version: "2",
1113 }
1114
1115 apex {
1116 name: "otherapex",
1117 key: "myapex.key",
1118 native_shared_libs: ["liby"],
1119 min_sdk_version: "3",
1120 }
1121
1122 apex_key {
1123 name: "myapex.key",
1124 public_key: "testkey.avbpubkey",
1125 private_key: "testkey.pem",
1126 }
1127
1128 cc_library {
1129 name: "libx",
1130 shared_libs: ["liba"],
1131 system_shared_libs: [],
1132 stl: "none",
1133 apex_available: [ "myapex" ],
1134 }
1135
1136 cc_library {
1137 name: "liby",
1138 shared_libs: ["liba"],
1139 system_shared_libs: [],
1140 stl: "none",
1141 apex_available: [ "otherapex" ],
1142 }
1143
1144 cc_library {
1145 name: "liba",
1146 shared_libs: ["libz"],
1147 system_shared_libs: [],
1148 stl: "none",
1149 apex_available: [
1150 "//apex_available:anyapex",
1151 "//apex_available:platform",
1152 ],
1153 }
1154
1155 cc_library {
1156 name: "libz",
1157 system_shared_libs: [],
1158 stl: "none",
1159 stubs: {
1160 versions: ["1", "3"],
1161 },
1162 }
1163 `, withUnbundledBuild)
1164
1165 expectLink := func(from, from_variant, to, to_variant string) {
1166 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1167 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1168 }
1169 expectNoLink := func(from, from_variant, to, to_variant string) {
1170 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1171 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1172 }
1173 // platform liba is linked to non-stub version
1174 expectLink("liba", "shared", "libz", "shared")
1175 // liba in myapex is linked to #1
1176 expectLink("liba", "shared_myapex", "libz", "shared_1")
1177 expectNoLink("liba", "shared_myapex", "libz", "shared_3")
1178 expectNoLink("liba", "shared_myapex", "libz", "shared")
1179 // liba in otherapex is linked to #3
1180 expectLink("liba", "shared_otherapex", "libz", "shared_3")
1181 expectNoLink("liba", "shared_otherapex", "libz", "shared_1")
1182 expectNoLink("liba", "shared_otherapex", "libz", "shared")
1183}
1184
Jooyung Han29e91d22020-04-02 01:41:41 +09001185func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
1186 ctx, _ := testApex(t, `
1187 apex {
1188 name: "myapex",
1189 key: "myapex.key",
1190 native_shared_libs: ["libx"],
1191 min_sdk_version: "R",
1192 }
1193
1194 apex_key {
1195 name: "myapex.key",
1196 public_key: "testkey.avbpubkey",
1197 private_key: "testkey.pem",
1198 }
1199
1200 cc_library {
1201 name: "libx",
1202 shared_libs: ["libz"],
1203 system_shared_libs: [],
1204 stl: "none",
1205 apex_available: [ "myapex" ],
1206 }
1207
1208 cc_library {
1209 name: "libz",
1210 system_shared_libs: [],
1211 stl: "none",
1212 stubs: {
1213 versions: ["29", "R"],
1214 },
1215 }
1216 `, func(fs map[string][]byte, config android.Config) {
1217 config.TestProductVariables.Platform_version_active_codenames = []string{"R"}
1218 })
1219
1220 expectLink := func(from, from_variant, to, to_variant string) {
1221 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1222 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1223 }
1224 expectNoLink := func(from, from_variant, to, to_variant string) {
1225 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1226 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1227 }
1228 // 9000 is quite a magic number.
1229 // Finalized SDK codenames are mapped as P(28), Q(29), ...
1230 // And, codenames which are not finalized yet(active_codenames + future_codenames) are numbered from 9000, 9001, ...
1231 // to distinguish them from finalized and future_api(10000)
1232 // In this test, "R" is assumed not finalized yet( listed in Platform_version_active_codenames) and translated into 9000
1233 // (refer android/api_levels.go)
1234 expectLink("libx", "shared_myapex", "libz", "shared_9000")
1235 expectNoLink("libx", "shared_myapex", "libz", "shared_29")
1236 expectNoLink("libx", "shared_myapex", "libz", "shared")
1237}
1238
Jooyung Han0c4e0162020-02-26 22:45:42 +09001239func TestApexMinSdkVersionDefaultsToLatest(t *testing.T) {
1240 ctx, _ := testApex(t, `
1241 apex {
1242 name: "myapex",
1243 key: "myapex.key",
1244 native_shared_libs: ["libx"],
1245 }
1246
1247 apex_key {
1248 name: "myapex.key",
1249 public_key: "testkey.avbpubkey",
1250 private_key: "testkey.pem",
1251 }
1252
1253 cc_library {
1254 name: "libx",
1255 shared_libs: ["libz"],
1256 system_shared_libs: [],
1257 stl: "none",
1258 apex_available: [ "myapex" ],
1259 }
1260
1261 cc_library {
1262 name: "libz",
1263 system_shared_libs: [],
1264 stl: "none",
1265 stubs: {
1266 versions: ["1", "2"],
1267 },
1268 }
1269 `)
1270
1271 expectLink := func(from, from_variant, to, to_variant string) {
1272 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1273 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1274 }
1275 expectNoLink := func(from, from_variant, to, to_variant string) {
1276 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1277 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1278 }
1279 expectLink("libx", "shared_myapex", "libz", "shared_2")
1280 expectNoLink("libx", "shared_myapex", "libz", "shared_1")
1281 expectNoLink("libx", "shared_myapex", "libz", "shared")
1282}
1283
1284func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
1285 ctx, _ := testApex(t, `
1286 apex {
1287 name: "myapex",
1288 key: "myapex.key",
1289 native_shared_libs: ["libx"],
1290 }
1291
1292 apex_key {
1293 name: "myapex.key",
1294 public_key: "testkey.avbpubkey",
1295 private_key: "testkey.pem",
1296 }
1297
1298 cc_library {
1299 name: "libx",
1300 system_shared_libs: [],
1301 stl: "none",
1302 apex_available: [ "myapex" ],
1303 stubs: {
1304 versions: ["1", "2"],
1305 },
1306 }
1307
1308 cc_library {
1309 name: "libz",
1310 shared_libs: ["libx"],
1311 system_shared_libs: [],
1312 stl: "none",
1313 }
1314 `)
1315
1316 expectLink := func(from, from_variant, to, to_variant string) {
1317 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1318 ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1319 }
1320 expectNoLink := func(from, from_variant, to, to_variant string) {
1321 ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
1322 ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1323 }
1324 expectLink("libz", "shared", "libx", "shared_2")
1325 expectNoLink("libz", "shared", "libz", "shared_1")
1326 expectNoLink("libz", "shared", "libz", "shared")
1327}
1328
Jooyung Han74066602020-03-20 04:29:24 +09001329func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
Jooyung Han0c4e0162020-02-26 22:45:42 +09001330 ctx, _ := testApex(t, `
1331 apex {
1332 name: "myapex",
1333 key: "myapex.key",
1334 native_shared_libs: ["libx"],
1335 min_sdk_version: "29",
1336 }
1337
1338 apex_key {
1339 name: "myapex.key",
1340 public_key: "testkey.avbpubkey",
1341 private_key: "testkey.pem",
1342 }
1343
1344 cc_library {
1345 name: "libx",
1346 shared_libs: ["libbar"],
1347 apex_available: [ "myapex" ],
1348 }
1349
1350 cc_library {
1351 name: "libbar",
1352 stubs: {
1353 versions: ["29", "30"],
1354 },
1355 }
Jooyung Han74066602020-03-20 04:29:24 +09001356 `, func(fs map[string][]byte, config android.Config) {
1357 config.TestProductVariables.SanitizeDevice = []string{"hwaddress"}
1358 })
Jooyung Han0c4e0162020-02-26 22:45:42 +09001359 expectLink := func(from, from_variant, to, to_variant string) {
1360 ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
1361 libFlags := ld.Args["libFlags"]
1362 ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
1363 }
Jooyung Han74066602020-03-20 04:29:24 +09001364 expectLink("libx", "shared_hwasan_myapex", "libbar", "shared_30")
Jooyung Han0c4e0162020-02-26 22:45:42 +09001365}
1366
Jooyung Han74066602020-03-20 04:29:24 +09001367func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
Jooyung Han0c4e0162020-02-26 22:45:42 +09001368 ctx, _ := testApex(t, `
1369 apex {
1370 name: "myapex",
1371 key: "myapex.key",
1372 native_shared_libs: ["libx"],
1373 min_sdk_version: "29",
1374 }
1375
1376 apex_key {
1377 name: "myapex.key",
1378 public_key: "testkey.avbpubkey",
1379 private_key: "testkey.pem",
1380 }
1381
1382 cc_library {
1383 name: "libx",
1384 apex_available: [ "myapex" ],
1385 }
Jooyung Han74066602020-03-20 04:29:24 +09001386 `)
Jooyung Han0c4e0162020-02-26 22:45:42 +09001387
1388 // ensure apex variant of c++ is linked with static unwinder
1389 cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_myapex").Module().(*cc.Module)
1390 ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libgcc_stripped")
1391 // note that platform variant is not.
1392 cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
1393 ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libgcc_stripped")
Jooyung Han0c4e0162020-02-26 22:45:42 +09001394}
1395
1396func TestInvalidMinSdkVersion(t *testing.T) {
Jooyung Han74066602020-03-20 04:29:24 +09001397 testApexError(t, `"libz" .*: not found a version\(<=29\)`, `
Jooyung Han0c4e0162020-02-26 22:45:42 +09001398 apex {
1399 name: "myapex",
1400 key: "myapex.key",
1401 native_shared_libs: ["libx"],
1402 min_sdk_version: "29",
1403 }
1404
1405 apex_key {
1406 name: "myapex.key",
1407 public_key: "testkey.avbpubkey",
1408 private_key: "testkey.pem",
1409 }
1410
1411 cc_library {
1412 name: "libx",
1413 shared_libs: ["libz"],
1414 system_shared_libs: [],
1415 stl: "none",
1416 apex_available: [ "myapex" ],
1417 }
1418
1419 cc_library {
1420 name: "libz",
1421 system_shared_libs: [],
1422 stl: "none",
1423 stubs: {
1424 versions: ["30"],
1425 },
1426 }
Jooyung Han74066602020-03-20 04:29:24 +09001427 `)
Jooyung Han0c4e0162020-02-26 22:45:42 +09001428
Jooyung Han29e91d22020-04-02 01:41:41 +09001429 testApexError(t, `"myapex" .*: min_sdk_version: SDK version should be .*`, `
Jooyung Han0c4e0162020-02-26 22:45:42 +09001430 apex {
1431 name: "myapex",
1432 key: "myapex.key",
Jooyung Han29e91d22020-04-02 01:41:41 +09001433 min_sdk_version: "abc",
Jooyung Han0c4e0162020-02-26 22:45:42 +09001434 }
1435
1436 apex_key {
1437 name: "myapex.key",
1438 public_key: "testkey.avbpubkey",
1439 private_key: "testkey.pem",
1440 }
1441 `)
1442}
1443
Artur Satayev2eedf622020-04-15 17:29:42 +01001444func TestJavaStableSdkVersion(t *testing.T) {
1445 testCases := []struct {
1446 name string
1447 expectedError string
1448 bp string
1449 }{
1450 {
1451 name: "Non-updatable apex with non-stable dep",
1452 bp: `
1453 apex {
1454 name: "myapex",
1455 java_libs: ["myjar"],
1456 key: "myapex.key",
1457 }
1458 apex_key {
1459 name: "myapex.key",
1460 public_key: "testkey.avbpubkey",
1461 private_key: "testkey.pem",
1462 }
1463 java_library {
1464 name: "myjar",
1465 srcs: ["foo/bar/MyClass.java"],
1466 sdk_version: "core_platform",
1467 apex_available: ["myapex"],
1468 }
1469 `,
1470 },
1471 {
1472 name: "Updatable apex with stable dep",
1473 bp: `
1474 apex {
1475 name: "myapex",
1476 java_libs: ["myjar"],
1477 key: "myapex.key",
1478 updatable: true,
1479 min_sdk_version: "29",
1480 }
1481 apex_key {
1482 name: "myapex.key",
1483 public_key: "testkey.avbpubkey",
1484 private_key: "testkey.pem",
1485 }
1486 java_library {
1487 name: "myjar",
1488 srcs: ["foo/bar/MyClass.java"],
1489 sdk_version: "current",
1490 apex_available: ["myapex"],
1491 }
1492 `,
1493 },
1494 {
1495 name: "Updatable apex with non-stable dep",
1496 expectedError: "cannot depend on \"myjar\"",
1497 bp: `
1498 apex {
1499 name: "myapex",
1500 java_libs: ["myjar"],
1501 key: "myapex.key",
1502 updatable: true,
1503 }
1504 apex_key {
1505 name: "myapex.key",
1506 public_key: "testkey.avbpubkey",
1507 private_key: "testkey.pem",
1508 }
1509 java_library {
1510 name: "myjar",
1511 srcs: ["foo/bar/MyClass.java"],
1512 sdk_version: "core_platform",
1513 apex_available: ["myapex"],
1514 }
1515 `,
1516 },
1517 {
1518 name: "Updatable apex with non-stable transitive dep",
1519 expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against non-public Android API.",
1520 bp: `
1521 apex {
1522 name: "myapex",
1523 java_libs: ["myjar"],
1524 key: "myapex.key",
1525 updatable: true,
1526 }
1527 apex_key {
1528 name: "myapex.key",
1529 public_key: "testkey.avbpubkey",
1530 private_key: "testkey.pem",
1531 }
1532 java_library {
1533 name: "myjar",
1534 srcs: ["foo/bar/MyClass.java"],
1535 sdk_version: "current",
1536 apex_available: ["myapex"],
1537 static_libs: ["transitive-jar"],
1538 }
1539 java_library {
1540 name: "transitive-jar",
1541 srcs: ["foo/bar/MyClass.java"],
1542 sdk_version: "core_platform",
1543 apex_available: ["myapex"],
1544 }
1545 `,
1546 },
1547 }
1548
1549 for _, test := range testCases {
1550 t.Run(test.name, func(t *testing.T) {
1551 if test.expectedError == "" {
1552 testApex(t, test.bp)
1553 } else {
1554 testApexError(t, test.expectedError, test.bp)
1555 }
1556 })
1557 }
1558}
1559
Jiyong Park7c2ee712018-12-07 00:42:25 +09001560func TestFilesInSubDir(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001561 ctx, _ := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +09001562 apex {
1563 name: "myapex",
1564 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001565 native_shared_libs: ["mylib"],
1566 binaries: ["mybin"],
Jiyong Park7c2ee712018-12-07 00:42:25 +09001567 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001568 compile_multilib: "both",
Jiyong Park7c2ee712018-12-07 00:42:25 +09001569 }
1570
1571 apex_key {
1572 name: "myapex.key",
1573 public_key: "testkey.avbpubkey",
1574 private_key: "testkey.pem",
1575 }
1576
1577 prebuilt_etc {
1578 name: "myetc",
1579 src: "myprebuilt",
1580 sub_dir: "foo/bar",
1581 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001582
1583 cc_library {
1584 name: "mylib",
1585 srcs: ["mylib.cpp"],
1586 relative_install_path: "foo/bar",
1587 system_shared_libs: [],
1588 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001589 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001590 }
1591
1592 cc_binary {
1593 name: "mybin",
1594 srcs: ["mylib.cpp"],
1595 relative_install_path: "foo/bar",
1596 system_shared_libs: [],
1597 static_executable: true,
1598 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001599 apex_available: [ "myapex" ],
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001600 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09001601 `)
1602
Sundong Ahnabb64432019-10-22 13:58:29 +09001603 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
Jiyong Park7c2ee712018-12-07 00:42:25 +09001604 dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
1605
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001606 // Ensure that the subdirectories are all listed
Jiyong Park7c2ee712018-12-07 00:42:25 +09001607 ensureListContains(t, dirs, "etc")
1608 ensureListContains(t, dirs, "etc/foo")
1609 ensureListContains(t, dirs, "etc/foo/bar")
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001610 ensureListContains(t, dirs, "lib64")
1611 ensureListContains(t, dirs, "lib64/foo")
1612 ensureListContains(t, dirs, "lib64/foo/bar")
1613 ensureListContains(t, dirs, "lib")
1614 ensureListContains(t, dirs, "lib/foo")
1615 ensureListContains(t, dirs, "lib/foo/bar")
1616
Jiyong Parkbd13e442019-03-15 18:10:35 +09001617 ensureListContains(t, dirs, "bin")
1618 ensureListContains(t, dirs, "bin/foo")
1619 ensureListContains(t, dirs, "bin/foo/bar")
Jiyong Park7c2ee712018-12-07 00:42:25 +09001620}
Jiyong Parkda6eb592018-12-19 17:12:36 +09001621
1622func TestUseVendor(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001623 ctx, _ := testApex(t, `
Jiyong Parkda6eb592018-12-19 17:12:36 +09001624 apex {
1625 name: "myapex",
1626 key: "myapex.key",
1627 native_shared_libs: ["mylib"],
1628 use_vendor: true,
1629 }
1630
1631 apex_key {
1632 name: "myapex.key",
1633 public_key: "testkey.avbpubkey",
1634 private_key: "testkey.pem",
1635 }
1636
1637 cc_library {
1638 name: "mylib",
1639 srcs: ["mylib.cpp"],
1640 shared_libs: ["mylib2"],
1641 system_shared_libs: [],
1642 vendor_available: true,
1643 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001644 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09001645 }
1646
1647 cc_library {
1648 name: "mylib2",
1649 srcs: ["mylib.cpp"],
1650 system_shared_libs: [],
1651 vendor_available: true,
1652 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001653 apex_available: [ "myapex" ],
Jiyong Parkda6eb592018-12-19 17:12:36 +09001654 }
Jooyung Handc782442019-11-01 03:14:38 +09001655 `, func(fs map[string][]byte, config android.Config) {
1656 setUseVendorWhitelistForTest(config, []string{"myapex"})
1657 })
Jiyong Parkda6eb592018-12-19 17:12:36 +09001658
1659 inputsList := []string{}
Sundong Ahnabb64432019-10-22 13:58:29 +09001660 for _, i := range ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().BuildParamsForTests() {
Jiyong Parkda6eb592018-12-19 17:12:36 +09001661 for _, implicit := range i.Implicits {
1662 inputsList = append(inputsList, implicit.String())
1663 }
1664 }
1665 inputsString := strings.Join(inputsList, " ")
1666
1667 // ensure that the apex includes vendor variants of the direct and indirect deps
Colin Crossfb0c16e2019-11-20 17:12:35 -08001668 ensureContains(t, inputsString, "android_vendor.VER_arm64_armv8-a_shared_myapex/mylib.so")
1669 ensureContains(t, inputsString, "android_vendor.VER_arm64_armv8-a_shared_myapex/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09001670
1671 // ensure that the apex does not include core variants
Colin Cross7113d202019-11-20 16:39:12 -08001672 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_myapex/mylib.so")
1673 ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_myapex/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09001674}
Jiyong Park16e91a02018-12-20 18:18:08 +09001675
Jooyung Handc782442019-11-01 03:14:38 +09001676func TestUseVendorRestriction(t *testing.T) {
1677 testApexError(t, `module "myapex" .*: use_vendor: not allowed`, `
1678 apex {
1679 name: "myapex",
1680 key: "myapex.key",
1681 use_vendor: true,
1682 }
1683 apex_key {
1684 name: "myapex.key",
1685 public_key: "testkey.avbpubkey",
1686 private_key: "testkey.pem",
1687 }
1688 `, func(fs map[string][]byte, config android.Config) {
1689 setUseVendorWhitelistForTest(config, []string{""})
1690 })
1691 // no error with whitelist
1692 testApex(t, `
1693 apex {
1694 name: "myapex",
1695 key: "myapex.key",
1696 use_vendor: true,
1697 }
1698 apex_key {
1699 name: "myapex.key",
1700 public_key: "testkey.avbpubkey",
1701 private_key: "testkey.pem",
1702 }
1703 `, func(fs map[string][]byte, config android.Config) {
1704 setUseVendorWhitelistForTest(config, []string{"myapex"})
1705 })
1706}
1707
Jooyung Han5c998b92019-06-27 11:30:33 +09001708func TestUseVendorFailsIfNotVendorAvailable(t *testing.T) {
1709 testApexError(t, `dependency "mylib" of "myapex" missing variant:\n.*image:vendor`, `
1710 apex {
1711 name: "myapex",
1712 key: "myapex.key",
1713 native_shared_libs: ["mylib"],
1714 use_vendor: true,
1715 }
1716
1717 apex_key {
1718 name: "myapex.key",
1719 public_key: "testkey.avbpubkey",
1720 private_key: "testkey.pem",
1721 }
1722
1723 cc_library {
1724 name: "mylib",
1725 srcs: ["mylib.cpp"],
1726 system_shared_libs: [],
1727 stl: "none",
1728 }
1729 `)
1730}
1731
Jiyong Park16e91a02018-12-20 18:18:08 +09001732func TestStaticLinking(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001733 ctx, _ := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09001734 apex {
1735 name: "myapex",
1736 key: "myapex.key",
1737 native_shared_libs: ["mylib"],
1738 }
1739
1740 apex_key {
1741 name: "myapex.key",
1742 public_key: "testkey.avbpubkey",
1743 private_key: "testkey.pem",
1744 }
1745
1746 cc_library {
1747 name: "mylib",
1748 srcs: ["mylib.cpp"],
1749 system_shared_libs: [],
1750 stl: "none",
1751 stubs: {
1752 versions: ["1", "2", "3"],
1753 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001754 apex_available: [
1755 "//apex_available:platform",
1756 "myapex",
1757 ],
Jiyong Park16e91a02018-12-20 18:18:08 +09001758 }
1759
1760 cc_binary {
1761 name: "not_in_apex",
1762 srcs: ["mylib.cpp"],
1763 static_libs: ["mylib"],
1764 static_executable: true,
1765 system_shared_libs: [],
1766 stl: "none",
1767 }
Jiyong Park16e91a02018-12-20 18:18:08 +09001768 `)
1769
Colin Cross7113d202019-11-20 16:39:12 -08001770 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
Jiyong Park16e91a02018-12-20 18:18:08 +09001771
1772 // Ensure that not_in_apex is linking with the static variant of mylib
Colin Cross7113d202019-11-20 16:39:12 -08001773 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09001774}
Jiyong Park9335a262018-12-24 11:31:58 +09001775
1776func TestKeys(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001777 ctx, _ := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09001778 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001779 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09001780 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001781 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09001782 native_shared_libs: ["mylib"],
Jooyung Han54aca7b2019-11-20 02:26:02 +09001783 file_contexts: ":myapex-file_contexts",
Jiyong Park9335a262018-12-24 11:31:58 +09001784 }
1785
1786 cc_library {
1787 name: "mylib",
1788 srcs: ["mylib.cpp"],
1789 system_shared_libs: [],
1790 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001791 apex_available: [ "myapex_keytest" ],
Jiyong Park9335a262018-12-24 11:31:58 +09001792 }
1793
1794 apex_key {
1795 name: "myapex.key",
1796 public_key: "testkey.avbpubkey",
1797 private_key: "testkey.pem",
1798 }
1799
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001800 android_app_certificate {
1801 name: "myapex.certificate",
1802 certificate: "testkey",
1803 }
1804
1805 android_app_certificate {
1806 name: "myapex.certificate.override",
1807 certificate: "testkey.override",
1808 }
1809
Jiyong Park9335a262018-12-24 11:31:58 +09001810 `)
1811
1812 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09001813 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09001814
1815 if keys.public_key_file.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
1816 t.Errorf("public key %q is not %q", keys.public_key_file.String(),
1817 "vendor/foo/devkeys/testkey.avbpubkey")
1818 }
1819 if keys.private_key_file.String() != "vendor/foo/devkeys/testkey.pem" {
1820 t.Errorf("private key %q is not %q", keys.private_key_file.String(),
1821 "vendor/foo/devkeys/testkey.pem")
1822 }
1823
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001824 // check the APK certs. It should be overridden to myapex.certificate.override
Sundong Ahnabb64432019-10-22 13:58:29 +09001825 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001826 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09001827 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001828 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09001829 }
1830}
Jiyong Park58e364a2019-01-19 19:24:06 +09001831
Jooyung Hanf121a652019-12-17 14:30:11 +09001832func TestCertificate(t *testing.T) {
1833 t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
1834 ctx, _ := testApex(t, `
1835 apex {
1836 name: "myapex",
1837 key: "myapex.key",
1838 }
1839 apex_key {
1840 name: "myapex.key",
1841 public_key: "testkey.avbpubkey",
1842 private_key: "testkey.pem",
1843 }`)
1844 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
1845 expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
1846 if actual := rule.Args["certificates"]; actual != expected {
1847 t.Errorf("certificates should be %q, not %q", expected, actual)
1848 }
1849 })
1850 t.Run("override when unspecified", func(t *testing.T) {
1851 ctx, _ := testApex(t, `
1852 apex {
1853 name: "myapex_keytest",
1854 key: "myapex.key",
1855 file_contexts: ":myapex-file_contexts",
1856 }
1857 apex_key {
1858 name: "myapex.key",
1859 public_key: "testkey.avbpubkey",
1860 private_key: "testkey.pem",
1861 }
1862 android_app_certificate {
1863 name: "myapex.certificate.override",
1864 certificate: "testkey.override",
1865 }`)
1866 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
1867 expected := "testkey.override.x509.pem testkey.override.pk8"
1868 if actual := rule.Args["certificates"]; actual != expected {
1869 t.Errorf("certificates should be %q, not %q", expected, actual)
1870 }
1871 })
1872 t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
1873 ctx, _ := testApex(t, `
1874 apex {
1875 name: "myapex",
1876 key: "myapex.key",
1877 certificate: ":myapex.certificate",
1878 }
1879 apex_key {
1880 name: "myapex.key",
1881 public_key: "testkey.avbpubkey",
1882 private_key: "testkey.pem",
1883 }
1884 android_app_certificate {
1885 name: "myapex.certificate",
1886 certificate: "testkey",
1887 }`)
1888 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
1889 expected := "testkey.x509.pem testkey.pk8"
1890 if actual := rule.Args["certificates"]; actual != expected {
1891 t.Errorf("certificates should be %q, not %q", expected, actual)
1892 }
1893 })
1894 t.Run("override when specifiec as <:module>", func(t *testing.T) {
1895 ctx, _ := testApex(t, `
1896 apex {
1897 name: "myapex_keytest",
1898 key: "myapex.key",
1899 file_contexts: ":myapex-file_contexts",
1900 certificate: ":myapex.certificate",
1901 }
1902 apex_key {
1903 name: "myapex.key",
1904 public_key: "testkey.avbpubkey",
1905 private_key: "testkey.pem",
1906 }
1907 android_app_certificate {
1908 name: "myapex.certificate.override",
1909 certificate: "testkey.override",
1910 }`)
1911 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
1912 expected := "testkey.override.x509.pem testkey.override.pk8"
1913 if actual := rule.Args["certificates"]; actual != expected {
1914 t.Errorf("certificates should be %q, not %q", expected, actual)
1915 }
1916 })
1917 t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
1918 ctx, _ := testApex(t, `
1919 apex {
1920 name: "myapex",
1921 key: "myapex.key",
1922 certificate: "testkey",
1923 }
1924 apex_key {
1925 name: "myapex.key",
1926 public_key: "testkey.avbpubkey",
1927 private_key: "testkey.pem",
1928 }`)
1929 rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
1930 expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
1931 if actual := rule.Args["certificates"]; actual != expected {
1932 t.Errorf("certificates should be %q, not %q", expected, actual)
1933 }
1934 })
1935 t.Run("override when specified as <name>", func(t *testing.T) {
1936 ctx, _ := testApex(t, `
1937 apex {
1938 name: "myapex_keytest",
1939 key: "myapex.key",
1940 file_contexts: ":myapex-file_contexts",
1941 certificate: "testkey",
1942 }
1943 apex_key {
1944 name: "myapex.key",
1945 public_key: "testkey.avbpubkey",
1946 private_key: "testkey.pem",
1947 }
1948 android_app_certificate {
1949 name: "myapex.certificate.override",
1950 certificate: "testkey.override",
1951 }`)
1952 rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
1953 expected := "testkey.override.x509.pem testkey.override.pk8"
1954 if actual := rule.Args["certificates"]; actual != expected {
1955 t.Errorf("certificates should be %q, not %q", expected, actual)
1956 }
1957 })
1958}
1959
Jiyong Park58e364a2019-01-19 19:24:06 +09001960func TestMacro(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001961 ctx, _ := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09001962 apex {
1963 name: "myapex",
1964 key: "myapex.key",
Jooyung Han68e511e2020-03-02 17:44:33 +09001965 native_shared_libs: ["mylib", "mylib2"],
Jiyong Park58e364a2019-01-19 19:24:06 +09001966 }
1967
1968 apex {
1969 name: "otherapex",
1970 key: "myapex.key",
Jooyung Han68e511e2020-03-02 17:44:33 +09001971 native_shared_libs: ["mylib", "mylib2"],
Jooyung Han61c41542020-03-07 03:45:53 +09001972 min_sdk_version: "29",
Jiyong Park58e364a2019-01-19 19:24:06 +09001973 }
1974
1975 apex_key {
1976 name: "myapex.key",
1977 public_key: "testkey.avbpubkey",
1978 private_key: "testkey.pem",
1979 }
1980
1981 cc_library {
1982 name: "mylib",
1983 srcs: ["mylib.cpp"],
1984 system_shared_libs: [],
1985 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001986 apex_available: [
Anton Hanssoneec79eb2020-01-10 15:12:39 +00001987 "myapex",
1988 "otherapex",
1989 ],
Jooyung Hanc3e92632020-03-21 23:20:55 +09001990 recovery_available: true,
Jiyong Park58e364a2019-01-19 19:24:06 +09001991 }
Jooyung Han68e511e2020-03-02 17:44:33 +09001992 cc_library {
1993 name: "mylib2",
1994 srcs: ["mylib.cpp"],
1995 system_shared_libs: [],
1996 stl: "none",
1997 apex_available: [
1998 "myapex",
1999 "otherapex",
2000 ],
2001 use_apex_name_macro: true,
2002 }
Jiyong Park58e364a2019-01-19 19:24:06 +09002003 `)
2004
Jooyung Han68e511e2020-03-02 17:44:33 +09002005 // non-APEX variant does not have __ANDROID_APEX__ defined
Colin Cross7113d202019-11-20 16:39:12 -08002006 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09002007 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han74066602020-03-20 04:29:24 +09002008 ensureNotContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__")
Jooyung Han68e511e2020-03-02 17:44:33 +09002009
Jooyung Han61c41542020-03-07 03:45:53 +09002010 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Jooyung Han68e511e2020-03-02 17:44:33 +09002011 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
2012 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han61c41542020-03-07 03:45:53 +09002013 ensureContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__=10000")
Jooyung Han77988572019-10-18 16:26:16 +09002014 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
Jooyung Han68e511e2020-03-02 17:44:33 +09002015
Jooyung Han61c41542020-03-07 03:45:53 +09002016 // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
Jooyung Han68e511e2020-03-02 17:44:33 +09002017 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
2018 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han61c41542020-03-07 03:45:53 +09002019 ensureContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__=29")
Jooyung Han77988572019-10-18 16:26:16 +09002020 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09002021
Jooyung Han68e511e2020-03-02 17:44:33 +09002022 // When cc_library sets use_apex_name_macro: true
2023 // apex variants define additional macro to distinguish which apex variant it is built for
2024
2025 // non-APEX variant does not have __ANDROID_APEX__ defined
2026 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
2027 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
2028
2029 // APEX variant has __ANDROID_APEX__ defined
2030 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09002031 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09002032 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
2033 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09002034
Jooyung Han68e511e2020-03-02 17:44:33 +09002035 // APEX variant has __ANDROID_APEX__ defined
2036 mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09002037 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09002038 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
2039 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jooyung Hanc3e92632020-03-21 23:20:55 +09002040
2041 // recovery variant does not set __ANDROID_SDK_VERSION__
2042 mylibCFlags = ctx.ModuleForTests("mylib", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
2043 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
2044 ensureNotContains(t, mylibCFlags, "-D__ANDROID_SDK_VERSION__")
Jiyong Park58e364a2019-01-19 19:24:06 +09002045}
Jiyong Park7e636d02019-01-28 16:16:54 +09002046
2047func TestHeaderLibsDependency(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002048 ctx, _ := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09002049 apex {
2050 name: "myapex",
2051 key: "myapex.key",
2052 native_shared_libs: ["mylib"],
2053 }
2054
2055 apex_key {
2056 name: "myapex.key",
2057 public_key: "testkey.avbpubkey",
2058 private_key: "testkey.pem",
2059 }
2060
2061 cc_library_headers {
2062 name: "mylib_headers",
2063 export_include_dirs: ["my_include"],
2064 system_shared_libs: [],
2065 stl: "none",
Jiyong Park0f80c182020-01-31 02:49:53 +09002066 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09002067 }
2068
2069 cc_library {
2070 name: "mylib",
2071 srcs: ["mylib.cpp"],
2072 system_shared_libs: [],
2073 stl: "none",
2074 header_libs: ["mylib_headers"],
2075 export_header_lib_headers: ["mylib_headers"],
2076 stubs: {
2077 versions: ["1", "2", "3"],
2078 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002079 apex_available: [ "myapex" ],
Jiyong Park7e636d02019-01-28 16:16:54 +09002080 }
2081
2082 cc_library {
2083 name: "otherlib",
2084 srcs: ["mylib.cpp"],
2085 system_shared_libs: [],
2086 stl: "none",
2087 shared_libs: ["mylib"],
2088 }
2089 `)
2090
Colin Cross7113d202019-11-20 16:39:12 -08002091 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
Jiyong Park7e636d02019-01-28 16:16:54 +09002092
2093 // Ensure that the include path of the header lib is exported to 'otherlib'
2094 ensureContains(t, cFlags, "-Imy_include")
2095}
Alex Light9670d332019-01-29 18:07:33 -08002096
Jiyong Park7cd10e32020-01-14 09:22:18 +09002097type fileInApex struct {
2098 path string // path in apex
Jooyung Hana57af4a2020-01-23 05:36:59 +00002099 src string // src path
Jiyong Park7cd10e32020-01-14 09:22:18 +09002100 isLink bool
2101}
2102
Jooyung Hana57af4a2020-01-23 05:36:59 +00002103func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
Jooyung Han31c470b2019-10-18 16:26:59 +09002104 t.Helper()
Jooyung Hana57af4a2020-01-23 05:36:59 +00002105 apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
Jooyung Han31c470b2019-10-18 16:26:59 +09002106 copyCmds := apexRule.Args["copy_commands"]
2107 imageApexDir := "/image.apex/"
Jiyong Park7cd10e32020-01-14 09:22:18 +09002108 var ret []fileInApex
Jooyung Han31c470b2019-10-18 16:26:59 +09002109 for _, cmd := range strings.Split(copyCmds, "&&") {
2110 cmd = strings.TrimSpace(cmd)
2111 if cmd == "" {
2112 continue
2113 }
2114 terms := strings.Split(cmd, " ")
Jooyung Hana57af4a2020-01-23 05:36:59 +00002115 var dst, src string
Jiyong Park7cd10e32020-01-14 09:22:18 +09002116 var isLink bool
Jooyung Han31c470b2019-10-18 16:26:59 +09002117 switch terms[0] {
2118 case "mkdir":
2119 case "cp":
Jiyong Park7cd10e32020-01-14 09:22:18 +09002120 if len(terms) != 3 && len(terms) != 4 {
Jooyung Han31c470b2019-10-18 16:26:59 +09002121 t.Fatal("copyCmds contains invalid cp command", cmd)
2122 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09002123 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00002124 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09002125 isLink = false
2126 case "ln":
2127 if len(terms) != 3 && len(terms) != 4 {
2128 // ln LINK TARGET or ln -s LINK TARGET
2129 t.Fatal("copyCmds contains invalid ln command", cmd)
2130 }
2131 dst = terms[len(terms)-1]
Jooyung Hana57af4a2020-01-23 05:36:59 +00002132 src = terms[len(terms)-2]
Jiyong Park7cd10e32020-01-14 09:22:18 +09002133 isLink = true
2134 default:
2135 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
2136 }
2137 if dst != "" {
Jooyung Han31c470b2019-10-18 16:26:59 +09002138 index := strings.Index(dst, imageApexDir)
2139 if index == -1 {
2140 t.Fatal("copyCmds should copy a file to image.apex/", cmd)
2141 }
2142 dstFile := dst[index+len(imageApexDir):]
Jooyung Hana57af4a2020-01-23 05:36:59 +00002143 ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
Jooyung Han31c470b2019-10-18 16:26:59 +09002144 }
2145 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09002146 return ret
2147}
2148
Jooyung Hana57af4a2020-01-23 05:36:59 +00002149func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
2150 t.Helper()
Jiyong Park7cd10e32020-01-14 09:22:18 +09002151 var failed bool
2152 var surplus []string
2153 filesMatched := make(map[string]bool)
Jooyung Hana57af4a2020-01-23 05:36:59 +00002154 for _, file := range getFiles(t, ctx, moduleName, variant) {
Jooyung Han8d8906c2020-02-27 13:31:56 +09002155 mactchFound := false
Jiyong Park7cd10e32020-01-14 09:22:18 +09002156 for _, expected := range files {
2157 if matched, _ := path.Match(expected, file.path); matched {
2158 filesMatched[expected] = true
Jooyung Han8d8906c2020-02-27 13:31:56 +09002159 mactchFound = true
2160 break
Jiyong Park7cd10e32020-01-14 09:22:18 +09002161 }
2162 }
Jooyung Han8d8906c2020-02-27 13:31:56 +09002163 if !mactchFound {
2164 surplus = append(surplus, file.path)
2165 }
Jiyong Park7cd10e32020-01-14 09:22:18 +09002166 }
Jooyung Han31c470b2019-10-18 16:26:59 +09002167
Jooyung Han31c470b2019-10-18 16:26:59 +09002168 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09002169 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09002170 t.Log("surplus files", surplus)
2171 failed = true
2172 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09002173
2174 if len(files) > len(filesMatched) {
2175 var missing []string
2176 for _, expected := range files {
2177 if !filesMatched[expected] {
2178 missing = append(missing, expected)
2179 }
2180 }
2181 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09002182 t.Log("missing files", missing)
2183 failed = true
2184 }
2185 if failed {
2186 t.Fail()
2187 }
2188}
2189
Jooyung Han344d5432019-08-23 11:17:39 +09002190func TestVndkApexCurrent(t *testing.T) {
2191 ctx, _ := testApex(t, `
2192 apex_vndk {
2193 name: "myapex",
2194 key: "myapex.key",
Jooyung Han344d5432019-08-23 11:17:39 +09002195 }
2196
2197 apex_key {
2198 name: "myapex.key",
2199 public_key: "testkey.avbpubkey",
2200 private_key: "testkey.pem",
2201 }
2202
2203 cc_library {
2204 name: "libvndk",
2205 srcs: ["mylib.cpp"],
2206 vendor_available: true,
2207 vndk: {
2208 enabled: true,
2209 },
2210 system_shared_libs: [],
2211 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002212 apex_available: [ "myapex" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002213 }
2214
2215 cc_library {
2216 name: "libvndksp",
2217 srcs: ["mylib.cpp"],
2218 vendor_available: true,
2219 vndk: {
2220 enabled: true,
2221 support_system_process: true,
2222 },
2223 system_shared_libs: [],
2224 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002225 apex_available: [ "myapex" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002226 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09002227 `+vndkLibrariesTxtFiles("current"))
Jooyung Han344d5432019-08-23 11:17:39 +09002228
Jooyung Hana57af4a2020-01-23 05:36:59 +00002229 ensureExactContents(t, ctx, "myapex", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002230 "lib/libvndk.so",
2231 "lib/libvndksp.so",
Jooyung Han8d8906c2020-02-27 13:31:56 +09002232 "lib/libc++.so",
Jooyung Han31c470b2019-10-18 16:26:59 +09002233 "lib64/libvndk.so",
2234 "lib64/libvndksp.so",
Jooyung Han8d8906c2020-02-27 13:31:56 +09002235 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002236 "etc/llndk.libraries.VER.txt",
2237 "etc/vndkcore.libraries.VER.txt",
2238 "etc/vndksp.libraries.VER.txt",
2239 "etc/vndkprivate.libraries.VER.txt",
Jooyung Han31c470b2019-10-18 16:26:59 +09002240 })
Jooyung Han344d5432019-08-23 11:17:39 +09002241}
2242
2243func TestVndkApexWithPrebuilt(t *testing.T) {
2244 ctx, _ := testApex(t, `
2245 apex_vndk {
2246 name: "myapex",
2247 key: "myapex.key",
Jooyung Han344d5432019-08-23 11:17:39 +09002248 }
2249
2250 apex_key {
2251 name: "myapex.key",
2252 public_key: "testkey.avbpubkey",
2253 private_key: "testkey.pem",
2254 }
2255
2256 cc_prebuilt_library_shared {
Jooyung Han31c470b2019-10-18 16:26:59 +09002257 name: "libvndk",
2258 srcs: ["libvndk.so"],
Jooyung Han344d5432019-08-23 11:17:39 +09002259 vendor_available: true,
2260 vndk: {
2261 enabled: true,
2262 },
2263 system_shared_libs: [],
2264 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002265 apex_available: [ "myapex" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002266 }
Jooyung Han31c470b2019-10-18 16:26:59 +09002267
2268 cc_prebuilt_library_shared {
2269 name: "libvndk.arm",
2270 srcs: ["libvndk.arm.so"],
2271 vendor_available: true,
2272 vndk: {
2273 enabled: true,
2274 },
2275 enabled: false,
2276 arch: {
2277 arm: {
2278 enabled: true,
2279 },
2280 },
2281 system_shared_libs: [],
2282 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002283 apex_available: [ "myapex" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09002284 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09002285 `+vndkLibrariesTxtFiles("current"),
2286 withFiles(map[string][]byte{
2287 "libvndk.so": nil,
2288 "libvndk.arm.so": nil,
2289 }))
Jooyung Han344d5432019-08-23 11:17:39 +09002290
Jooyung Hana57af4a2020-01-23 05:36:59 +00002291 ensureExactContents(t, ctx, "myapex", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002292 "lib/libvndk.so",
2293 "lib/libvndk.arm.so",
2294 "lib64/libvndk.so",
Jooyung Han8d8906c2020-02-27 13:31:56 +09002295 "lib/libc++.so",
2296 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002297 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09002298 })
Jooyung Han344d5432019-08-23 11:17:39 +09002299}
2300
Jooyung Han39edb6c2019-11-06 16:53:07 +09002301func vndkLibrariesTxtFiles(vers ...string) (result string) {
2302 for _, v := range vers {
2303 if v == "current" {
Kiyoung Kime1aa8ea2019-12-30 11:12:55 +09002304 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate"} {
Jooyung Han39edb6c2019-11-06 16:53:07 +09002305 result += `
2306 vndk_libraries_txt {
2307 name: "` + txt + `.libraries.txt",
2308 }
2309 `
2310 }
2311 } else {
2312 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate"} {
2313 result += `
2314 prebuilt_etc {
2315 name: "` + txt + `.libraries.` + v + `.txt",
2316 src: "dummy.txt",
2317 }
2318 `
2319 }
2320 }
2321 }
2322 return
2323}
2324
Jooyung Han344d5432019-08-23 11:17:39 +09002325func TestVndkApexVersion(t *testing.T) {
2326 ctx, _ := testApex(t, `
2327 apex_vndk {
2328 name: "myapex_v27",
2329 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002330 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002331 vndk_version: "27",
2332 }
2333
2334 apex_key {
2335 name: "myapex.key",
2336 public_key: "testkey.avbpubkey",
2337 private_key: "testkey.pem",
2338 }
2339
Jooyung Han31c470b2019-10-18 16:26:59 +09002340 vndk_prebuilt_shared {
2341 name: "libvndk27",
2342 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09002343 vendor_available: true,
2344 vndk: {
2345 enabled: true,
2346 },
Jooyung Han31c470b2019-10-18 16:26:59 +09002347 target_arch: "arm64",
2348 arch: {
2349 arm: {
2350 srcs: ["libvndk27_arm.so"],
2351 },
2352 arm64: {
2353 srcs: ["libvndk27_arm64.so"],
2354 },
2355 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002356 apex_available: [ "myapex_v27" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002357 }
2358
2359 vndk_prebuilt_shared {
2360 name: "libvndk27",
2361 version: "27",
2362 vendor_available: true,
2363 vndk: {
2364 enabled: true,
2365 },
Jooyung Han31c470b2019-10-18 16:26:59 +09002366 target_arch: "x86_64",
2367 arch: {
2368 x86: {
2369 srcs: ["libvndk27_x86.so"],
2370 },
2371 x86_64: {
2372 srcs: ["libvndk27_x86_64.so"],
2373 },
2374 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09002375 }
2376 `+vndkLibrariesTxtFiles("27"),
2377 withFiles(map[string][]byte{
2378 "libvndk27_arm.so": nil,
2379 "libvndk27_arm64.so": nil,
2380 "libvndk27_x86.so": nil,
2381 "libvndk27_x86_64.so": nil,
2382 }))
Jooyung Han344d5432019-08-23 11:17:39 +09002383
Jooyung Hana57af4a2020-01-23 05:36:59 +00002384 ensureExactContents(t, ctx, "myapex_v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002385 "lib/libvndk27_arm.so",
2386 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002387 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09002388 })
Jooyung Han344d5432019-08-23 11:17:39 +09002389}
2390
2391func TestVndkApexErrorWithDuplicateVersion(t *testing.T) {
2392 testApexError(t, `module "myapex_v27.*" .*: vndk_version: 27 is already defined in "myapex_v27.*"`, `
2393 apex_vndk {
2394 name: "myapex_v27",
2395 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002396 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002397 vndk_version: "27",
2398 }
2399 apex_vndk {
2400 name: "myapex_v27_other",
2401 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002402 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002403 vndk_version: "27",
2404 }
2405
2406 apex_key {
2407 name: "myapex.key",
2408 public_key: "testkey.avbpubkey",
2409 private_key: "testkey.pem",
2410 }
2411
2412 cc_library {
2413 name: "libvndk",
2414 srcs: ["mylib.cpp"],
2415 vendor_available: true,
2416 vndk: {
2417 enabled: true,
2418 },
2419 system_shared_libs: [],
2420 stl: "none",
2421 }
2422
2423 vndk_prebuilt_shared {
2424 name: "libvndk",
2425 version: "27",
2426 vendor_available: true,
2427 vndk: {
2428 enabled: true,
2429 },
2430 srcs: ["libvndk.so"],
2431 }
2432 `, withFiles(map[string][]byte{
2433 "libvndk.so": nil,
2434 }))
2435}
2436
Jooyung Han90eee022019-10-01 20:02:42 +09002437func TestVndkApexNameRule(t *testing.T) {
2438 ctx, _ := testApex(t, `
2439 apex_vndk {
2440 name: "myapex",
2441 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002442 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09002443 }
2444 apex_vndk {
2445 name: "myapex_v28",
2446 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002447 file_contexts: ":myapex-file_contexts",
Jooyung Han90eee022019-10-01 20:02:42 +09002448 vndk_version: "28",
2449 }
2450 apex_key {
2451 name: "myapex.key",
2452 public_key: "testkey.avbpubkey",
2453 private_key: "testkey.pem",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002454 }`+vndkLibrariesTxtFiles("28", "current"))
Jooyung Han90eee022019-10-01 20:02:42 +09002455
2456 assertApexName := func(expected, moduleName string) {
Jooyung Hana57af4a2020-01-23 05:36:59 +00002457 bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
Jooyung Han90eee022019-10-01 20:02:42 +09002458 actual := proptools.String(bundle.properties.Apex_name)
2459 if !reflect.DeepEqual(actual, expected) {
2460 t.Errorf("Got '%v', expected '%v'", actual, expected)
2461 }
2462 }
2463
2464 assertApexName("com.android.vndk.vVER", "myapex")
2465 assertApexName("com.android.vndk.v28", "myapex_v28")
2466}
2467
Jooyung Han344d5432019-08-23 11:17:39 +09002468func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
2469 ctx, _ := testApex(t, `
2470 apex_vndk {
2471 name: "myapex",
2472 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002473 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002474 }
2475
2476 apex_key {
2477 name: "myapex.key",
2478 public_key: "testkey.avbpubkey",
2479 private_key: "testkey.pem",
2480 }
2481
2482 cc_library {
2483 name: "libvndk",
2484 srcs: ["mylib.cpp"],
2485 vendor_available: true,
2486 native_bridge_supported: true,
2487 host_supported: true,
2488 vndk: {
2489 enabled: true,
2490 },
2491 system_shared_libs: [],
2492 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002493 apex_available: [ "myapex" ],
Jooyung Han344d5432019-08-23 11:17:39 +09002494 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09002495 `+vndkLibrariesTxtFiles("current"),
2496 withTargets(map[android.OsType][]android.Target{
2497 android.Android: []android.Target{
2498 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
2499 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
2500 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}}, NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "arm64", NativeBridgeRelativePath: "x86_64"},
2501 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}}, NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "arm", NativeBridgeRelativePath: "x86"},
2502 },
2503 }))
Jooyung Han344d5432019-08-23 11:17:39 +09002504
Jooyung Hana57af4a2020-01-23 05:36:59 +00002505 ensureExactContents(t, ctx, "myapex", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002506 "lib/libvndk.so",
2507 "lib64/libvndk.so",
Jooyung Han8d8906c2020-02-27 13:31:56 +09002508 "lib/libc++.so",
2509 "lib64/libc++.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002510 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09002511 })
Jooyung Han344d5432019-08-23 11:17:39 +09002512}
2513
2514func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
2515 testApexError(t, `module "myapex" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
2516 apex_vndk {
2517 name: "myapex",
2518 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002519 file_contexts: ":myapex-file_contexts",
Jooyung Han344d5432019-08-23 11:17:39 +09002520 native_bridge_supported: true,
2521 }
2522
2523 apex_key {
2524 name: "myapex.key",
2525 public_key: "testkey.avbpubkey",
2526 private_key: "testkey.pem",
2527 }
2528
2529 cc_library {
2530 name: "libvndk",
2531 srcs: ["mylib.cpp"],
2532 vendor_available: true,
2533 native_bridge_supported: true,
2534 host_supported: true,
2535 vndk: {
2536 enabled: true,
2537 },
2538 system_shared_libs: [],
2539 stl: "none",
2540 }
2541 `)
2542}
2543
Jooyung Han31c470b2019-10-18 16:26:59 +09002544func TestVndkApexWithBinder32(t *testing.T) {
Jooyung Han39edb6c2019-11-06 16:53:07 +09002545 ctx, _ := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09002546 apex_vndk {
2547 name: "myapex_v27",
2548 key: "myapex.key",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002549 file_contexts: ":myapex-file_contexts",
Jooyung Han31c470b2019-10-18 16:26:59 +09002550 vndk_version: "27",
2551 }
2552
2553 apex_key {
2554 name: "myapex.key",
2555 public_key: "testkey.avbpubkey",
2556 private_key: "testkey.pem",
2557 }
2558
2559 vndk_prebuilt_shared {
2560 name: "libvndk27",
2561 version: "27",
2562 target_arch: "arm",
2563 vendor_available: true,
2564 vndk: {
2565 enabled: true,
2566 },
2567 arch: {
2568 arm: {
2569 srcs: ["libvndk27.so"],
2570 }
2571 },
2572 }
2573
2574 vndk_prebuilt_shared {
2575 name: "libvndk27",
2576 version: "27",
2577 target_arch: "arm",
2578 binder32bit: true,
2579 vendor_available: true,
2580 vndk: {
2581 enabled: true,
2582 },
2583 arch: {
2584 arm: {
2585 srcs: ["libvndk27binder32.so"],
2586 }
2587 },
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002588 apex_available: [ "myapex_v27" ],
Jooyung Han31c470b2019-10-18 16:26:59 +09002589 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09002590 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09002591 withFiles(map[string][]byte{
2592 "libvndk27.so": nil,
2593 "libvndk27binder32.so": nil,
2594 }),
2595 withBinder32bit,
2596 withTargets(map[android.OsType][]android.Target{
2597 android.Android: []android.Target{
2598 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
2599 },
2600 }),
2601 )
2602
Jooyung Hana57af4a2020-01-23 05:36:59 +00002603 ensureExactContents(t, ctx, "myapex_v27", "android_common_image", []string{
Jooyung Han31c470b2019-10-18 16:26:59 +09002604 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09002605 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09002606 })
2607}
2608
Jooyung Hane1633032019-08-01 17:41:43 +09002609func TestDependenciesInApexManifest(t *testing.T) {
2610 ctx, _ := testApex(t, `
2611 apex {
2612 name: "myapex_nodep",
2613 key: "myapex.key",
2614 native_shared_libs: ["lib_nodep"],
2615 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002616 file_contexts: ":myapex-file_contexts",
Jooyung Hane1633032019-08-01 17:41:43 +09002617 }
2618
2619 apex {
2620 name: "myapex_dep",
2621 key: "myapex.key",
2622 native_shared_libs: ["lib_dep"],
2623 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002624 file_contexts: ":myapex-file_contexts",
Jooyung Hane1633032019-08-01 17:41:43 +09002625 }
2626
2627 apex {
2628 name: "myapex_provider",
2629 key: "myapex.key",
2630 native_shared_libs: ["libfoo"],
2631 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002632 file_contexts: ":myapex-file_contexts",
Jooyung Hane1633032019-08-01 17:41:43 +09002633 }
2634
2635 apex {
2636 name: "myapex_selfcontained",
2637 key: "myapex.key",
2638 native_shared_libs: ["lib_dep", "libfoo"],
2639 compile_multilib: "both",
Jooyung Han54aca7b2019-11-20 02:26:02 +09002640 file_contexts: ":myapex-file_contexts",
Jooyung Hane1633032019-08-01 17:41:43 +09002641 }
2642
2643 apex_key {
2644 name: "myapex.key",
2645 public_key: "testkey.avbpubkey",
2646 private_key: "testkey.pem",
2647 }
2648
2649 cc_library {
2650 name: "lib_nodep",
2651 srcs: ["mylib.cpp"],
2652 system_shared_libs: [],
2653 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002654 apex_available: [ "myapex_nodep" ],
Jooyung Hane1633032019-08-01 17:41:43 +09002655 }
2656
2657 cc_library {
2658 name: "lib_dep",
2659 srcs: ["mylib.cpp"],
2660 shared_libs: ["libfoo"],
2661 system_shared_libs: [],
2662 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002663 apex_available: [
2664 "myapex_dep",
2665 "myapex_provider",
2666 "myapex_selfcontained",
2667 ],
Jooyung Hane1633032019-08-01 17:41:43 +09002668 }
2669
2670 cc_library {
2671 name: "libfoo",
2672 srcs: ["mytest.cpp"],
2673 stubs: {
2674 versions: ["1"],
2675 },
2676 system_shared_libs: [],
2677 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002678 apex_available: [
2679 "myapex_provider",
2680 "myapex_selfcontained",
2681 ],
Jooyung Hane1633032019-08-01 17:41:43 +09002682 }
2683 `)
2684
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002685 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09002686 var provideNativeLibs, requireNativeLibs []string
2687
Sundong Ahnabb64432019-10-22 13:58:29 +09002688 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002689 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
2690 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09002691 ensureListEmpty(t, provideNativeLibs)
2692 ensureListEmpty(t, requireNativeLibs)
2693
Sundong Ahnabb64432019-10-22 13:58:29 +09002694 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002695 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
2696 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09002697 ensureListEmpty(t, provideNativeLibs)
2698 ensureListContains(t, requireNativeLibs, "libfoo.so")
2699
Sundong Ahnabb64432019-10-22 13:58:29 +09002700 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002701 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
2702 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09002703 ensureListContains(t, provideNativeLibs, "libfoo.so")
2704 ensureListEmpty(t, requireNativeLibs)
2705
Sundong Ahnabb64432019-10-22 13:58:29 +09002706 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002707 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
2708 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09002709 ensureListContains(t, provideNativeLibs, "libfoo.so")
2710 ensureListEmpty(t, requireNativeLibs)
2711}
2712
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002713func TestApexName(t *testing.T) {
Jiyong Parkdb334862020-02-05 17:19:28 +09002714 ctx, config := testApex(t, `
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002715 apex {
2716 name: "myapex",
2717 key: "myapex.key",
2718 apex_name: "com.android.myapex",
Jiyong Parkdb334862020-02-05 17:19:28 +09002719 native_shared_libs: ["mylib"],
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002720 }
2721
2722 apex_key {
2723 name: "myapex.key",
2724 public_key: "testkey.avbpubkey",
2725 private_key: "testkey.pem",
2726 }
Jiyong Parkdb334862020-02-05 17:19:28 +09002727
2728 cc_library {
2729 name: "mylib",
2730 srcs: ["mylib.cpp"],
2731 system_shared_libs: [],
2732 stl: "none",
2733 apex_available: [
2734 "//apex_available:platform",
2735 "myapex",
2736 ],
2737 }
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002738 `)
2739
Sundong Ahnabb64432019-10-22 13:58:29 +09002740 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002741 apexManifestRule := module.Rule("apexManifestRule")
2742 ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
2743 apexRule := module.Rule("apexRule")
2744 ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
Jiyong Parkdb334862020-02-05 17:19:28 +09002745
2746 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
2747 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
2748 name := apexBundle.BaseModuleName()
2749 prefix := "TARGET_"
2750 var builder strings.Builder
2751 data.Custom(&builder, name, prefix, "", data)
2752 androidMk := builder.String()
2753 ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
2754 ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09002755}
2756
Alex Light0851b882019-02-07 13:20:53 -08002757func TestNonTestApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002758 ctx, _ := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08002759 apex {
2760 name: "myapex",
2761 key: "myapex.key",
2762 native_shared_libs: ["mylib_common"],
2763 }
2764
2765 apex_key {
2766 name: "myapex.key",
2767 public_key: "testkey.avbpubkey",
2768 private_key: "testkey.pem",
2769 }
2770
2771 cc_library {
2772 name: "mylib_common",
2773 srcs: ["mylib.cpp"],
2774 system_shared_libs: [],
2775 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002776 apex_available: [
2777 "//apex_available:platform",
2778 "myapex",
2779 ],
Alex Light0851b882019-02-07 13:20:53 -08002780 }
2781 `)
2782
Sundong Ahnabb64432019-10-22 13:58:29 +09002783 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08002784 apexRule := module.Rule("apexRule")
2785 copyCmds := apexRule.Args["copy_commands"]
2786
2787 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
2788 t.Log("Apex was a test apex!")
2789 t.Fail()
2790 }
2791 // Ensure that main rule creates an output
2792 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2793
2794 // Ensure that apex variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -08002795 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_myapex")
Alex Light0851b882019-02-07 13:20:53 -08002796
2797 // Ensure that both direct and indirect deps are copied into apex
2798 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
2799
Colin Cross7113d202019-11-20 16:39:12 -08002800 // Ensure that the platform variant ends with _shared
2801 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08002802
2803 if !android.InAnyApex("mylib_common") {
2804 t.Log("Found mylib_common not in any apex!")
2805 t.Fail()
2806 }
2807}
2808
2809func TestTestApex(t *testing.T) {
2810 if android.InAnyApex("mylib_common_test") {
2811 t.Fatal("mylib_common_test must not be used in any other tests since this checks that global state is not updated in an illegal way!")
2812 }
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002813 ctx, _ := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08002814 apex_test {
2815 name: "myapex",
2816 key: "myapex.key",
2817 native_shared_libs: ["mylib_common_test"],
2818 }
2819
2820 apex_key {
2821 name: "myapex.key",
2822 public_key: "testkey.avbpubkey",
2823 private_key: "testkey.pem",
2824 }
2825
2826 cc_library {
2827 name: "mylib_common_test",
2828 srcs: ["mylib.cpp"],
2829 system_shared_libs: [],
2830 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002831 // TODO: remove //apex_available:platform
2832 apex_available: [
2833 "//apex_available:platform",
2834 "myapex",
2835 ],
Alex Light0851b882019-02-07 13:20:53 -08002836 }
2837 `)
2838
Sundong Ahnabb64432019-10-22 13:58:29 +09002839 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08002840 apexRule := module.Rule("apexRule")
2841 copyCmds := apexRule.Args["copy_commands"]
2842
2843 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
2844 t.Log("Apex was not a test apex!")
2845 t.Fail()
2846 }
2847 // Ensure that main rule creates an output
2848 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2849
2850 // Ensure that apex variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -08002851 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_myapex")
Alex Light0851b882019-02-07 13:20:53 -08002852
2853 // Ensure that both direct and indirect deps are copied into apex
2854 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
2855
Colin Cross7113d202019-11-20 16:39:12 -08002856 // Ensure that the platform variant ends with _shared
2857 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
Alex Light0851b882019-02-07 13:20:53 -08002858}
2859
Alex Light9670d332019-01-29 18:07:33 -08002860func TestApexWithTarget(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002861 ctx, _ := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08002862 apex {
2863 name: "myapex",
2864 key: "myapex.key",
2865 multilib: {
2866 first: {
2867 native_shared_libs: ["mylib_common"],
2868 }
2869 },
2870 target: {
2871 android: {
2872 multilib: {
2873 first: {
2874 native_shared_libs: ["mylib"],
2875 }
2876 }
2877 },
2878 host: {
2879 multilib: {
2880 first: {
2881 native_shared_libs: ["mylib2"],
2882 }
2883 }
2884 }
2885 }
2886 }
2887
2888 apex_key {
2889 name: "myapex.key",
2890 public_key: "testkey.avbpubkey",
2891 private_key: "testkey.pem",
2892 }
2893
2894 cc_library {
2895 name: "mylib",
2896 srcs: ["mylib.cpp"],
2897 system_shared_libs: [],
2898 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002899 // TODO: remove //apex_available:platform
2900 apex_available: [
2901 "//apex_available:platform",
2902 "myapex",
2903 ],
Alex Light9670d332019-01-29 18:07:33 -08002904 }
2905
2906 cc_library {
2907 name: "mylib_common",
2908 srcs: ["mylib.cpp"],
2909 system_shared_libs: [],
2910 stl: "none",
2911 compile_multilib: "first",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00002912 // TODO: remove //apex_available:platform
2913 apex_available: [
2914 "//apex_available:platform",
2915 "myapex",
2916 ],
Alex Light9670d332019-01-29 18:07:33 -08002917 }
2918
2919 cc_library {
2920 name: "mylib2",
2921 srcs: ["mylib.cpp"],
2922 system_shared_libs: [],
2923 stl: "none",
2924 compile_multilib: "first",
2925 }
2926 `)
2927
Sundong Ahnabb64432019-10-22 13:58:29 +09002928 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08002929 copyCmds := apexRule.Args["copy_commands"]
2930
2931 // Ensure that main rule creates an output
2932 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2933
2934 // Ensure that apex variant is created for the direct dep
Colin Cross7113d202019-11-20 16:39:12 -08002935 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex")
2936 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_myapex")
2937 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_myapex")
Alex Light9670d332019-01-29 18:07:33 -08002938
2939 // Ensure that both direct and indirect deps are copied into apex
2940 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
2941 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
2942 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
2943
Colin Cross7113d202019-11-20 16:39:12 -08002944 // Ensure that the platform variant ends with _shared
2945 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
2946 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
2947 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
Alex Light9670d332019-01-29 18:07:33 -08002948}
Jiyong Park04480cf2019-02-06 00:16:29 +09002949
2950func TestApexWithShBinary(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002951 ctx, _ := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09002952 apex {
2953 name: "myapex",
2954 key: "myapex.key",
2955 binaries: ["myscript"],
2956 }
2957
2958 apex_key {
2959 name: "myapex.key",
2960 public_key: "testkey.avbpubkey",
2961 private_key: "testkey.pem",
2962 }
2963
2964 sh_binary {
2965 name: "myscript",
2966 src: "mylib.cpp",
2967 filename: "myscript.sh",
2968 sub_dir: "script",
2969 }
2970 `)
2971
Sundong Ahnabb64432019-10-22 13:58:29 +09002972 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09002973 copyCmds := apexRule.Args["copy_commands"]
2974
2975 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
2976}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002977
Jooyung Han91df2082019-11-20 01:49:42 +09002978func TestApexInVariousPartition(t *testing.T) {
2979 testcases := []struct {
2980 propName, parition, flattenedPartition string
2981 }{
2982 {"", "system", "system_ext"},
2983 {"product_specific: true", "product", "product"},
2984 {"soc_specific: true", "vendor", "vendor"},
2985 {"proprietary: true", "vendor", "vendor"},
2986 {"vendor: true", "vendor", "vendor"},
2987 {"system_ext_specific: true", "system_ext", "system_ext"},
2988 }
2989 for _, tc := range testcases {
2990 t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
2991 ctx, _ := testApex(t, `
2992 apex {
2993 name: "myapex",
2994 key: "myapex.key",
2995 `+tc.propName+`
2996 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002997
Jooyung Han91df2082019-11-20 01:49:42 +09002998 apex_key {
2999 name: "myapex.key",
3000 public_key: "testkey.avbpubkey",
3001 private_key: "testkey.pem",
3002 }
3003 `)
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003004
Jooyung Han91df2082019-11-20 01:49:42 +09003005 apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
3006 expected := buildDir + "/target/product/test_device/" + tc.parition + "/apex"
3007 actual := apex.installDir.String()
3008 if actual != expected {
3009 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
3010 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003011
Jooyung Han91df2082019-11-20 01:49:42 +09003012 flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
3013 expected = buildDir + "/target/product/test_device/" + tc.flattenedPartition + "/apex"
3014 actual = flattened.installDir.String()
3015 if actual != expected {
3016 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
3017 }
3018 })
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003019 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09003020}
Jiyong Park67882562019-03-21 01:11:21 +09003021
Jooyung Han54aca7b2019-11-20 02:26:02 +09003022func TestFileContexts(t *testing.T) {
3023 ctx, _ := testApex(t, `
3024 apex {
3025 name: "myapex",
3026 key: "myapex.key",
3027 }
3028
3029 apex_key {
3030 name: "myapex.key",
3031 public_key: "testkey.avbpubkey",
3032 private_key: "testkey.pem",
3033 }
3034 `)
3035 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
3036 apexRule := module.Rule("apexRule")
3037 actual := apexRule.Args["file_contexts"]
3038 expected := "system/sepolicy/apex/myapex-file_contexts"
3039 if actual != expected {
3040 t.Errorf("wrong file_contexts. expected %q. actual %q", expected, actual)
3041 }
3042
3043 testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
3044 apex {
3045 name: "myapex",
3046 key: "myapex.key",
3047 file_contexts: "my_own_file_contexts",
3048 }
3049
3050 apex_key {
3051 name: "myapex.key",
3052 public_key: "testkey.avbpubkey",
3053 private_key: "testkey.pem",
3054 }
3055 `, withFiles(map[string][]byte{
3056 "my_own_file_contexts": nil,
3057 }))
3058
3059 testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
3060 apex {
3061 name: "myapex",
3062 key: "myapex.key",
3063 product_specific: true,
3064 file_contexts: "product_specific_file_contexts",
3065 }
3066
3067 apex_key {
3068 name: "myapex.key",
3069 public_key: "testkey.avbpubkey",
3070 private_key: "testkey.pem",
3071 }
3072 `)
3073
3074 ctx, _ = testApex(t, `
3075 apex {
3076 name: "myapex",
3077 key: "myapex.key",
3078 product_specific: true,
3079 file_contexts: "product_specific_file_contexts",
3080 }
3081
3082 apex_key {
3083 name: "myapex.key",
3084 public_key: "testkey.avbpubkey",
3085 private_key: "testkey.pem",
3086 }
3087 `, withFiles(map[string][]byte{
3088 "product_specific_file_contexts": nil,
3089 }))
3090 module = ctx.ModuleForTests("myapex", "android_common_myapex_image")
3091 apexRule = module.Rule("apexRule")
3092 actual = apexRule.Args["file_contexts"]
3093 expected = "product_specific_file_contexts"
3094 if actual != expected {
3095 t.Errorf("wrong file_contexts. expected %q. actual %q", expected, actual)
3096 }
3097
3098 ctx, _ = testApex(t, `
3099 apex {
3100 name: "myapex",
3101 key: "myapex.key",
3102 product_specific: true,
3103 file_contexts: ":my-file-contexts",
3104 }
3105
3106 apex_key {
3107 name: "myapex.key",
3108 public_key: "testkey.avbpubkey",
3109 private_key: "testkey.pem",
3110 }
3111
3112 filegroup {
3113 name: "my-file-contexts",
3114 srcs: ["product_specific_file_contexts"],
3115 }
3116 `, withFiles(map[string][]byte{
3117 "product_specific_file_contexts": nil,
3118 }))
3119 module = ctx.ModuleForTests("myapex", "android_common_myapex_image")
3120 apexRule = module.Rule("apexRule")
3121 actual = apexRule.Args["file_contexts"]
3122 expected = "product_specific_file_contexts"
3123 if actual != expected {
3124 t.Errorf("wrong file_contexts. expected %q. actual %q", expected, actual)
3125 }
3126}
3127
Jiyong Park67882562019-03-21 01:11:21 +09003128func TestApexKeyFromOtherModule(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003129 ctx, _ := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09003130 apex_key {
3131 name: "myapex.key",
3132 public_key: ":my.avbpubkey",
3133 private_key: ":my.pem",
3134 product_specific: true,
3135 }
3136
3137 filegroup {
3138 name: "my.avbpubkey",
3139 srcs: ["testkey2.avbpubkey"],
3140 }
3141
3142 filegroup {
3143 name: "my.pem",
3144 srcs: ["testkey2.pem"],
3145 }
3146 `)
3147
3148 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
3149 expected_pubkey := "testkey2.avbpubkey"
3150 actual_pubkey := apex_key.public_key_file.String()
3151 if actual_pubkey != expected_pubkey {
3152 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
3153 }
3154 expected_privkey := "testkey2.pem"
3155 actual_privkey := apex_key.private_key_file.String()
3156 if actual_privkey != expected_privkey {
3157 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
3158 }
3159}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07003160
3161func TestPrebuilt(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003162 ctx, _ := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07003163 prebuilt_apex {
3164 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09003165 arch: {
3166 arm64: {
3167 src: "myapex-arm64.apex",
3168 },
3169 arm: {
3170 src: "myapex-arm.apex",
3171 },
3172 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07003173 }
3174 `)
3175
3176 prebuilt := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
3177
Jiyong Parkc95714e2019-03-29 14:23:10 +09003178 expectedInput := "myapex-arm64.apex"
3179 if prebuilt.inputApex.String() != expectedInput {
3180 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
3181 }
Jaewoong Jung939ebd52019-03-26 15:07:36 -07003182}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01003183
3184func TestPrebuiltFilenameOverride(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003185 ctx, _ := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01003186 prebuilt_apex {
3187 name: "myapex",
3188 src: "myapex-arm.apex",
3189 filename: "notmyapex.apex",
3190 }
3191 `)
3192
3193 p := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
3194
3195 expected := "notmyapex.apex"
3196 if p.installFilename != expected {
3197 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
3198 }
3199}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07003200
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003201func TestPrebuiltOverrides(t *testing.T) {
3202 ctx, config := testApex(t, `
3203 prebuilt_apex {
3204 name: "myapex.prebuilt",
3205 src: "myapex-arm.apex",
3206 overrides: [
3207 "myapex",
3208 ],
3209 }
3210 `)
3211
3212 p := ctx.ModuleForTests("myapex.prebuilt", "android_common").Module().(*Prebuilt)
3213
3214 expected := []string{"myapex"}
Jiyong Park0b0e1b92019-12-03 13:24:29 +09003215 actual := android.AndroidMkEntriesForTest(t, config, "", p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003216 if !reflect.DeepEqual(actual, expected) {
Jiyong Parkb0a012c2019-11-14 17:17:03 +09003217 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003218 }
3219}
3220
Roland Levillain630846d2019-06-26 12:48:34 +01003221func TestApexWithTests(t *testing.T) {
Roland Levillainf89cd092019-07-29 16:22:59 +01003222 ctx, config := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01003223 apex_test {
3224 name: "myapex",
3225 key: "myapex.key",
3226 tests: [
3227 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01003228 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01003229 ],
3230 }
3231
3232 apex_key {
3233 name: "myapex.key",
3234 public_key: "testkey.avbpubkey",
3235 private_key: "testkey.pem",
3236 }
3237
3238 cc_test {
3239 name: "mytest",
3240 gtest: false,
3241 srcs: ["mytest.cpp"],
3242 relative_install_path: "test",
3243 system_shared_libs: [],
3244 static_executable: true,
3245 stl: "none",
3246 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01003247
3248 cc_test {
3249 name: "mytests",
3250 gtest: false,
3251 srcs: [
3252 "mytest1.cpp",
3253 "mytest2.cpp",
3254 "mytest3.cpp",
3255 ],
3256 test_per_src: true,
3257 relative_install_path: "test",
3258 system_shared_libs: [],
3259 static_executable: true,
3260 stl: "none",
3261 }
Roland Levillain630846d2019-06-26 12:48:34 +01003262 `)
3263
Sundong Ahnabb64432019-10-22 13:58:29 +09003264 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01003265 copyCmds := apexRule.Args["copy_commands"]
3266
3267 // Ensure that test dep is copied into apex.
3268 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Roland Levillain9b5fde92019-06-28 15:41:19 +01003269
3270 // Ensure that test deps built with `test_per_src` are copied into apex.
3271 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
3272 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
3273 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01003274
3275 // Ensure the module is correctly translated.
Sundong Ahnabb64432019-10-22 13:58:29 +09003276 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Roland Levillainf89cd092019-07-29 16:22:59 +01003277 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
3278 name := apexBundle.BaseModuleName()
3279 prefix := "TARGET_"
3280 var builder strings.Builder
3281 data.Custom(&builder, name, prefix, "", data)
3282 androidMk := builder.String()
Jooyung Han31c470b2019-10-18 16:26:59 +09003283 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
3284 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
3285 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
3286 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
Jooyung Han214bf372019-11-12 13:03:50 +09003287 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
Jooyung Han31c470b2019-10-18 16:26:59 +09003288 ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01003289 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Roland Levillain630846d2019-06-26 12:48:34 +01003290}
3291
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09003292func TestInstallExtraFlattenedApexes(t *testing.T) {
3293 ctx, config := testApex(t, `
3294 apex {
3295 name: "myapex",
3296 key: "myapex.key",
3297 }
3298 apex_key {
3299 name: "myapex.key",
3300 public_key: "testkey.avbpubkey",
3301 private_key: "testkey.pem",
3302 }
3303 `, func(fs map[string][]byte, config android.Config) {
3304 config.TestProductVariables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
3305 })
3306 ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Jiyong Park83dc74b2020-01-14 18:38:44 +09003307 ensureListContains(t, ab.requiredDeps, "myapex.flattened")
Jooyung Han3ab2c3e2019-12-05 16:27:44 +09003308 mk := android.AndroidMkDataForTest(t, config, "", ab)
3309 var builder strings.Builder
3310 mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
3311 androidMk := builder.String()
3312 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
3313}
3314
Jooyung Han5c998b92019-06-27 11:30:33 +09003315func TestApexUsesOtherApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07003316 ctx, _ := testApex(t, `
Jooyung Han5c998b92019-06-27 11:30:33 +09003317 apex {
3318 name: "myapex",
3319 key: "myapex.key",
3320 native_shared_libs: ["mylib"],
3321 uses: ["commonapex"],
3322 }
3323
3324 apex {
3325 name: "commonapex",
3326 key: "myapex.key",
3327 native_shared_libs: ["libcommon"],
3328 provide_cpp_shared_libs: true,
3329 }
3330
3331 apex_key {
3332 name: "myapex.key",
3333 public_key: "testkey.avbpubkey",
3334 private_key: "testkey.pem",
3335 }
3336
3337 cc_library {
3338 name: "mylib",
3339 srcs: ["mylib.cpp"],
3340 shared_libs: ["libcommon"],
3341 system_shared_libs: [],
3342 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003343 apex_available: [ "myapex" ],
Jooyung Han5c998b92019-06-27 11:30:33 +09003344 }
3345
3346 cc_library {
3347 name: "libcommon",
3348 srcs: ["mylib_common.cpp"],
3349 system_shared_libs: [],
3350 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003351 // TODO: remove //apex_available:platform
3352 apex_available: [
3353 "//apex_available:platform",
3354 "commonapex",
3355 "myapex",
3356 ],
Jooyung Han5c998b92019-06-27 11:30:33 +09003357 }
3358 `)
3359
Sundong Ahnabb64432019-10-22 13:58:29 +09003360 module1 := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han5c998b92019-06-27 11:30:33 +09003361 apexRule1 := module1.Rule("apexRule")
3362 copyCmds1 := apexRule1.Args["copy_commands"]
3363
Sundong Ahnabb64432019-10-22 13:58:29 +09003364 module2 := ctx.ModuleForTests("commonapex", "android_common_commonapex_image")
Jooyung Han5c998b92019-06-27 11:30:33 +09003365 apexRule2 := module2.Rule("apexRule")
3366 copyCmds2 := apexRule2.Args["copy_commands"]
3367
Colin Cross7113d202019-11-20 16:39:12 -08003368 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_myapex")
3369 ensureListContains(t, ctx.ModuleVariantsForTests("libcommon"), "android_arm64_armv8-a_shared_commonapex")
Jooyung Han5c998b92019-06-27 11:30:33 +09003370 ensureContains(t, copyCmds1, "image.apex/lib64/mylib.so")
3371 ensureContains(t, copyCmds2, "image.apex/lib64/libcommon.so")
3372 ensureNotContains(t, copyCmds1, "image.apex/lib64/libcommon.so")
3373}
3374
3375func TestApexUsesFailsIfNotProvided(t *testing.T) {
3376 testApexError(t, `uses: "commonapex" does not provide native_shared_libs`, `
3377 apex {
3378 name: "myapex",
3379 key: "myapex.key",
3380 uses: ["commonapex"],
3381 }
3382
3383 apex {
3384 name: "commonapex",
3385 key: "myapex.key",
3386 }
3387
3388 apex_key {
3389 name: "myapex.key",
3390 public_key: "testkey.avbpubkey",
3391 private_key: "testkey.pem",
3392 }
3393 `)
3394 testApexError(t, `uses: "commonapex" is not a provider`, `
3395 apex {
3396 name: "myapex",
3397 key: "myapex.key",
3398 uses: ["commonapex"],
3399 }
3400
3401 cc_library {
3402 name: "commonapex",
3403 system_shared_libs: [],
3404 stl: "none",
3405 }
3406
3407 apex_key {
3408 name: "myapex.key",
3409 public_key: "testkey.avbpubkey",
3410 private_key: "testkey.pem",
3411 }
3412 `)
3413}
3414
3415func TestApexUsesFailsIfUseVenderMismatch(t *testing.T) {
3416 testApexError(t, `use_vendor: "commonapex" has different value of use_vendor`, `
3417 apex {
3418 name: "myapex",
3419 key: "myapex.key",
3420 use_vendor: true,
3421 uses: ["commonapex"],
3422 }
3423
3424 apex {
3425 name: "commonapex",
3426 key: "myapex.key",
3427 provide_cpp_shared_libs: true,
3428 }
3429
3430 apex_key {
3431 name: "myapex.key",
3432 public_key: "testkey.avbpubkey",
3433 private_key: "testkey.pem",
3434 }
Jooyung Handc782442019-11-01 03:14:38 +09003435 `, func(fs map[string][]byte, config android.Config) {
3436 setUseVendorWhitelistForTest(config, []string{"myapex"})
3437 })
Jooyung Han5c998b92019-06-27 11:30:33 +09003438}
3439
Jooyung Hand48f3c32019-08-23 11:18:57 +09003440func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
3441 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
3442 apex {
3443 name: "myapex",
3444 key: "myapex.key",
3445 native_shared_libs: ["libfoo"],
3446 }
3447
3448 apex_key {
3449 name: "myapex.key",
3450 public_key: "testkey.avbpubkey",
3451 private_key: "testkey.pem",
3452 }
3453
3454 cc_library {
3455 name: "libfoo",
3456 stl: "none",
3457 system_shared_libs: [],
3458 enabled: false,
Jooyung Hanb8fa86a2020-03-10 06:23:13 +09003459 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09003460 }
3461 `)
3462 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
3463 apex {
3464 name: "myapex",
3465 key: "myapex.key",
3466 java_libs: ["myjar"],
3467 }
3468
3469 apex_key {
3470 name: "myapex.key",
3471 public_key: "testkey.avbpubkey",
3472 private_key: "testkey.pem",
3473 }
3474
3475 java_library {
3476 name: "myjar",
3477 srcs: ["foo/bar/MyClass.java"],
3478 sdk_version: "none",
3479 system_modules: "none",
Jooyung Hand48f3c32019-08-23 11:18:57 +09003480 enabled: false,
Jooyung Hanb8fa86a2020-03-10 06:23:13 +09003481 apex_available: ["myapex"],
Jooyung Hand48f3c32019-08-23 11:18:57 +09003482 }
3483 `)
3484}
3485
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003486func TestApexWithApps(t *testing.T) {
3487 ctx, _ := testApex(t, `
3488 apex {
3489 name: "myapex",
3490 key: "myapex.key",
3491 apps: [
3492 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09003493 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003494 ],
3495 }
3496
3497 apex_key {
3498 name: "myapex.key",
3499 public_key: "testkey.avbpubkey",
3500 private_key: "testkey.pem",
3501 }
3502
3503 android_app {
3504 name: "AppFoo",
3505 srcs: ["foo/bar/MyClass.java"],
Colin Cross1c93c292020-02-15 10:38:00 -08003506 sdk_version: "current",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003507 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09003508 jni_libs: ["libjni"],
Colin Cross1c93c292020-02-15 10:38:00 -08003509 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003510 apex_available: [ "myapex" ],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003511 }
Jiyong Parkf7487312019-10-17 12:54:30 +09003512
3513 android_app {
3514 name: "AppFooPriv",
3515 srcs: ["foo/bar/MyClass.java"],
Colin Cross1c93c292020-02-15 10:38:00 -08003516 sdk_version: "current",
Jiyong Parkf7487312019-10-17 12:54:30 +09003517 system_modules: "none",
3518 privileged: true,
Colin Cross1c93c292020-02-15 10:38:00 -08003519 stl: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003520 apex_available: [ "myapex" ],
Jiyong Parkf7487312019-10-17 12:54:30 +09003521 }
Jiyong Park8be103b2019-11-08 15:53:48 +09003522
3523 cc_library_shared {
3524 name: "libjni",
3525 srcs: ["mylib.cpp"],
Jooyung Han65041792020-02-25 16:59:29 +09003526 shared_libs: ["libfoo"],
Jiyong Park8be103b2019-11-08 15:53:48 +09003527 stl: "none",
3528 system_shared_libs: [],
Jiyong Park0f80c182020-01-31 02:49:53 +09003529 apex_available: [ "myapex" ],
Jooyung Han65041792020-02-25 16:59:29 +09003530 sdk_version: "current",
3531 }
3532
3533 cc_library_shared {
3534 name: "libfoo",
3535 stl: "none",
3536 system_shared_libs: [],
3537 apex_available: [ "myapex" ],
3538 sdk_version: "current",
Jiyong Park8be103b2019-11-08 15:53:48 +09003539 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003540 `)
3541
Sundong Ahnabb64432019-10-22 13:58:29 +09003542 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003543 apexRule := module.Rule("apexRule")
3544 copyCmds := apexRule.Args["copy_commands"]
3545
3546 ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
Jiyong Parkf7487312019-10-17 12:54:30 +09003547 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
Jiyong Park52cd06f2019-11-11 10:14:32 +09003548
Jooyung Han65041792020-02-25 16:59:29 +09003549 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_myapex").Description("zip jni libs")
3550 // JNI libraries are uncompressed
Jiyong Park52cd06f2019-11-11 10:14:32 +09003551 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
Jooyung Han65041792020-02-25 16:59:29 +09003552 t.Errorf("jni libs are not uncompressed for AppFoo")
Jiyong Park52cd06f2019-11-11 10:14:32 +09003553 }
Jooyung Han65041792020-02-25 16:59:29 +09003554 // JNI libraries including transitive deps are
3555 for _, jni := range []string{"libjni", "libfoo"} {
Colin Cross01fd7cc2020-02-19 16:54:04 -08003556 jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_myapex").Module().(*cc.Module).OutputFile()
Jooyung Han65041792020-02-25 16:59:29 +09003557 // ... embedded inside APK (jnilibs.zip)
3558 ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
3559 // ... and not directly inside the APEX
3560 ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
3561 }
Dario Frenicde2a032019-10-27 00:29:22 +01003562}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003563
Dario Frenicde2a032019-10-27 00:29:22 +01003564func TestApexWithAppImports(t *testing.T) {
3565 ctx, _ := testApex(t, `
3566 apex {
3567 name: "myapex",
3568 key: "myapex.key",
3569 apps: [
3570 "AppFooPrebuilt",
3571 "AppFooPrivPrebuilt",
3572 ],
3573 }
3574
3575 apex_key {
3576 name: "myapex.key",
3577 public_key: "testkey.avbpubkey",
3578 private_key: "testkey.pem",
3579 }
3580
3581 android_app_import {
3582 name: "AppFooPrebuilt",
3583 apk: "PrebuiltAppFoo.apk",
3584 presigned: true,
3585 dex_preopt: {
3586 enabled: false,
3587 },
3588 }
3589
3590 android_app_import {
3591 name: "AppFooPrivPrebuilt",
3592 apk: "PrebuiltAppFooPriv.apk",
3593 privileged: true,
3594 presigned: true,
3595 dex_preopt: {
3596 enabled: false,
3597 },
Jooyung Han65cd0f02020-03-23 20:21:11 +09003598 filename: "AwesomePrebuiltAppFooPriv.apk",
Dario Frenicde2a032019-10-27 00:29:22 +01003599 }
3600 `)
3601
Sundong Ahnabb64432019-10-22 13:58:29 +09003602 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Dario Frenicde2a032019-10-27 00:29:22 +01003603 apexRule := module.Rule("apexRule")
3604 copyCmds := apexRule.Args["copy_commands"]
3605
3606 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
Jooyung Han65cd0f02020-03-23 20:21:11 +09003607 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk")
3608}
3609
3610func TestApexWithAppImportsPrefer(t *testing.T) {
3611 ctx, _ := testApex(t, `
3612 apex {
3613 name: "myapex",
3614 key: "myapex.key",
3615 apps: [
3616 "AppFoo",
3617 ],
3618 }
3619
3620 apex_key {
3621 name: "myapex.key",
3622 public_key: "testkey.avbpubkey",
3623 private_key: "testkey.pem",
3624 }
3625
3626 android_app {
3627 name: "AppFoo",
3628 srcs: ["foo/bar/MyClass.java"],
3629 sdk_version: "none",
3630 system_modules: "none",
3631 apex_available: [ "myapex" ],
3632 }
3633
3634 android_app_import {
3635 name: "AppFoo",
3636 apk: "AppFooPrebuilt.apk",
3637 filename: "AppFooPrebuilt.apk",
3638 presigned: true,
3639 prefer: true,
3640 }
3641 `, withFiles(map[string][]byte{
3642 "AppFooPrebuilt.apk": nil,
3643 }))
3644
3645 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
3646 "app/AppFoo/AppFooPrebuilt.apk",
3647 })
Sundong Ahne1f05aa2019-08-27 13:55:42 +09003648}
3649
Dario Freni6f3937c2019-12-20 22:58:03 +00003650func TestApexWithTestHelperApp(t *testing.T) {
3651 ctx, _ := testApex(t, `
3652 apex {
3653 name: "myapex",
3654 key: "myapex.key",
3655 apps: [
3656 "TesterHelpAppFoo",
3657 ],
3658 }
3659
3660 apex_key {
3661 name: "myapex.key",
3662 public_key: "testkey.avbpubkey",
3663 private_key: "testkey.pem",
3664 }
3665
3666 android_test_helper_app {
3667 name: "TesterHelpAppFoo",
3668 srcs: ["foo/bar/MyClass.java"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003669 apex_available: [ "myapex" ],
Dario Freni6f3937c2019-12-20 22:58:03 +00003670 }
3671
3672 `)
3673
3674 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
3675 apexRule := module.Rule("apexRule")
3676 copyCmds := apexRule.Args["copy_commands"]
3677
3678 ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk")
3679}
3680
Jooyung Han18020ea2019-11-13 10:50:48 +09003681func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
3682 // libfoo's apex_available comes from cc_defaults
Jooyung Hanb8fa86a2020-03-10 06:23:13 +09003683 testApexError(t, `requires "libfoo" that is not available for the APEX`, `
Jooyung Han18020ea2019-11-13 10:50:48 +09003684 apex {
3685 name: "myapex",
3686 key: "myapex.key",
3687 native_shared_libs: ["libfoo"],
3688 }
3689
3690 apex_key {
3691 name: "myapex.key",
3692 public_key: "testkey.avbpubkey",
3693 private_key: "testkey.pem",
3694 }
3695
3696 apex {
3697 name: "otherapex",
3698 key: "myapex.key",
3699 native_shared_libs: ["libfoo"],
3700 }
3701
3702 cc_defaults {
3703 name: "libfoo-defaults",
3704 apex_available: ["otherapex"],
3705 }
3706
3707 cc_library {
3708 name: "libfoo",
3709 defaults: ["libfoo-defaults"],
3710 stl: "none",
3711 system_shared_libs: [],
3712 }`)
3713}
3714
Paul Duffinde7464c2020-03-30 17:54:29 +01003715func TestApexAvailable_DirectDep(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09003716 // libfoo is not available to myapex, but only to otherapex
3717 testApexError(t, "requires \"libfoo\" that is not available for the APEX", `
3718 apex {
3719 name: "myapex",
3720 key: "myapex.key",
3721 native_shared_libs: ["libfoo"],
3722 }
3723
3724 apex_key {
3725 name: "myapex.key",
3726 public_key: "testkey.avbpubkey",
3727 private_key: "testkey.pem",
3728 }
3729
3730 apex {
3731 name: "otherapex",
3732 key: "otherapex.key",
3733 native_shared_libs: ["libfoo"],
3734 }
3735
3736 apex_key {
3737 name: "otherapex.key",
3738 public_key: "testkey.avbpubkey",
3739 private_key: "testkey.pem",
3740 }
3741
3742 cc_library {
3743 name: "libfoo",
3744 stl: "none",
3745 system_shared_libs: [],
3746 apex_available: ["otherapex"],
3747 }`)
Paul Duffinde7464c2020-03-30 17:54:29 +01003748}
Jiyong Park127b40b2019-09-30 16:04:35 +09003749
Paul Duffinde7464c2020-03-30 17:54:29 +01003750func TestApexAvailable_IndirectDep(t *testing.T) {
Jooyung Hanb8fa86a2020-03-10 06:23:13 +09003751 // libbbaz is an indirect dep
Paul Duffin868ecfd2020-03-30 17:58:21 +01003752 testApexError(t, `requires "libbaz" that is not available for the APEX. Dependency path:
Paul Duffinf0207962020-03-31 11:31:36 +01003753.*via tag apex\.dependencyTag.*"sharedLib".*
Paul Duffin868ecfd2020-03-30 17:58:21 +01003754.*-> libfoo.*link:shared.*
Paul Duffinb20ad0a2020-03-31 15:23:40 +01003755.*via tag cc\.DependencyTag.*"shared".*
Paul Duffin868ecfd2020-03-30 17:58:21 +01003756.*-> libbar.*link:shared.*
Paul Duffinb20ad0a2020-03-31 15:23:40 +01003757.*via tag cc\.DependencyTag.*"shared".*
3758.*-> libbaz.*link:shared.*`, `
Jiyong Park127b40b2019-09-30 16:04:35 +09003759 apex {
3760 name: "myapex",
3761 key: "myapex.key",
3762 native_shared_libs: ["libfoo"],
3763 }
3764
3765 apex_key {
3766 name: "myapex.key",
3767 public_key: "testkey.avbpubkey",
3768 private_key: "testkey.pem",
3769 }
3770
Jiyong Park127b40b2019-09-30 16:04:35 +09003771 cc_library {
3772 name: "libfoo",
3773 stl: "none",
3774 shared_libs: ["libbar"],
3775 system_shared_libs: [],
Jooyung Hanb8fa86a2020-03-10 06:23:13 +09003776 apex_available: ["myapex"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003777 }
3778
3779 cc_library {
3780 name: "libbar",
3781 stl: "none",
Jooyung Hanb8fa86a2020-03-10 06:23:13 +09003782 shared_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003783 system_shared_libs: [],
Jooyung Hanb8fa86a2020-03-10 06:23:13 +09003784 apex_available: ["myapex"],
3785 }
3786
3787 cc_library {
3788 name: "libbaz",
3789 stl: "none",
3790 system_shared_libs: [],
Jiyong Park127b40b2019-09-30 16:04:35 +09003791 }`)
Paul Duffinde7464c2020-03-30 17:54:29 +01003792}
Jiyong Park127b40b2019-09-30 16:04:35 +09003793
Paul Duffinde7464c2020-03-30 17:54:29 +01003794func TestApexAvailable_InvalidApexName(t *testing.T) {
Jiyong Park127b40b2019-09-30 16:04:35 +09003795 testApexError(t, "\"otherapex\" is not a valid module name", `
3796 apex {
3797 name: "myapex",
3798 key: "myapex.key",
3799 native_shared_libs: ["libfoo"],
3800 }
3801
3802 apex_key {
3803 name: "myapex.key",
3804 public_key: "testkey.avbpubkey",
3805 private_key: "testkey.pem",
3806 }
3807
3808 cc_library {
3809 name: "libfoo",
3810 stl: "none",
3811 system_shared_libs: [],
3812 apex_available: ["otherapex"],
3813 }`)
3814
Paul Duffinde7464c2020-03-30 17:54:29 +01003815 testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09003816 apex {
3817 name: "myapex",
3818 key: "myapex.key",
3819 native_shared_libs: ["libfoo", "libbar"],
3820 }
3821
3822 apex_key {
3823 name: "myapex.key",
3824 public_key: "testkey.avbpubkey",
3825 private_key: "testkey.pem",
3826 }
3827
3828 cc_library {
3829 name: "libfoo",
3830 stl: "none",
3831 system_shared_libs: [],
Jiyong Park9f14b9b2020-03-01 17:29:06 +09003832 runtime_libs: ["libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003833 apex_available: ["myapex"],
3834 }
3835
3836 cc_library {
3837 name: "libbar",
3838 stl: "none",
3839 system_shared_libs: [],
3840 apex_available: ["//apex_available:anyapex"],
Jiyong Park9f14b9b2020-03-01 17:29:06 +09003841 }
3842
3843 cc_library {
3844 name: "libbaz",
3845 stl: "none",
3846 system_shared_libs: [],
3847 stubs: {
3848 versions: ["10", "20", "30"],
3849 },
Jiyong Park127b40b2019-09-30 16:04:35 +09003850 }`)
Paul Duffinde7464c2020-03-30 17:54:29 +01003851}
Jiyong Park127b40b2019-09-30 16:04:35 +09003852
Jiyong Park6a9ddc32020-04-07 16:37:39 +09003853func TestApexAvailable_CheckForPlatform(t *testing.T) {
Paul Duffinde7464c2020-03-30 17:54:29 +01003854 ctx, _ := testApex(t, `
Jiyong Park127b40b2019-09-30 16:04:35 +09003855 apex {
3856 name: "myapex",
3857 key: "myapex.key",
Jiyong Park6a9ddc32020-04-07 16:37:39 +09003858 native_shared_libs: ["libbar", "libbaz"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003859 }
3860
3861 apex_key {
3862 name: "myapex.key",
3863 public_key: "testkey.avbpubkey",
3864 private_key: "testkey.pem",
3865 }
3866
3867 cc_library {
3868 name: "libfoo",
3869 stl: "none",
3870 system_shared_libs: [],
Jiyong Park6a9ddc32020-04-07 16:37:39 +09003871 shared_libs: ["libbar"],
Jiyong Park127b40b2019-09-30 16:04:35 +09003872 apex_available: ["//apex_available:platform"],
Jiyong Park6a9ddc32020-04-07 16:37:39 +09003873 }
3874
3875 cc_library {
3876 name: "libfoo2",
3877 stl: "none",
3878 system_shared_libs: [],
3879 shared_libs: ["libbaz"],
3880 apex_available: ["//apex_available:platform"],
3881 }
3882
3883 cc_library {
3884 name: "libbar",
3885 stl: "none",
3886 system_shared_libs: [],
3887 apex_available: ["myapex"],
3888 }
3889
3890 cc_library {
3891 name: "libbaz",
3892 stl: "none",
3893 system_shared_libs: [],
3894 apex_available: ["myapex"],
3895 stubs: {
3896 versions: ["1"],
3897 },
Jiyong Park127b40b2019-09-30 16:04:35 +09003898 }`)
3899
Jiyong Park6a9ddc32020-04-07 16:37:39 +09003900 // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
3901 // because it depends on libbar which isn't available to platform
3902 libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
3903 if libfoo.NotAvailableForPlatform() != true {
3904 t.Errorf("%q shouldn't be available to platform", libfoo.String())
3905 }
3906
3907 // libfoo2 however can be available to platform because it depends on libbaz which provides
3908 // stubs
3909 libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
3910 if libfoo2.NotAvailableForPlatform() == true {
3911 t.Errorf("%q should be available to platform", libfoo2.String())
3912 }
Paul Duffinde7464c2020-03-30 17:54:29 +01003913}
Jiyong Parka90ca002019-10-07 15:47:24 +09003914
Paul Duffinde7464c2020-03-30 17:54:29 +01003915func TestApexAvailable_CreatedForApex(t *testing.T) {
Jiyong Park6a9ddc32020-04-07 16:37:39 +09003916 ctx, _ := testApex(t, `
Jiyong Parka90ca002019-10-07 15:47:24 +09003917 apex {
3918 name: "myapex",
3919 key: "myapex.key",
3920 native_shared_libs: ["libfoo"],
3921 }
3922
3923 apex_key {
3924 name: "myapex.key",
3925 public_key: "testkey.avbpubkey",
3926 private_key: "testkey.pem",
3927 }
3928
3929 cc_library {
3930 name: "libfoo",
3931 stl: "none",
3932 system_shared_libs: [],
3933 apex_available: ["myapex"],
3934 static: {
3935 apex_available: ["//apex_available:platform"],
3936 },
3937 }`)
3938
Jiyong Park6a9ddc32020-04-07 16:37:39 +09003939 libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
3940 if libfooShared.NotAvailableForPlatform() != true {
3941 t.Errorf("%q shouldn't be available to platform", libfooShared.String())
3942 }
3943 libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
3944 if libfooStatic.NotAvailableForPlatform() != false {
3945 t.Errorf("%q should be available to platform", libfooStatic.String())
3946 }
Jiyong Park127b40b2019-09-30 16:04:35 +09003947}
3948
Jiyong Park5d790c32019-11-15 18:40:32 +09003949func TestOverrideApex(t *testing.T) {
Jaewoong Jung1670ca02019-11-22 14:50:42 -08003950 ctx, config := testApex(t, `
Jiyong Park5d790c32019-11-15 18:40:32 +09003951 apex {
3952 name: "myapex",
3953 key: "myapex.key",
3954 apps: ["app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08003955 overrides: ["oldapex"],
Jiyong Park5d790c32019-11-15 18:40:32 +09003956 }
3957
3958 override_apex {
3959 name: "override_myapex",
3960 base: "myapex",
3961 apps: ["override_app"],
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08003962 overrides: ["unknownapex"],
Baligh Uddin004d7172020-02-19 21:29:28 -08003963 logging_parent: "com.foo.bar",
Baligh Uddincb6aa122020-03-15 13:01:05 -07003964 package_name: "test.overridden.package",
Jiyong Park5d790c32019-11-15 18:40:32 +09003965 }
3966
3967 apex_key {
3968 name: "myapex.key",
3969 public_key: "testkey.avbpubkey",
3970 private_key: "testkey.pem",
3971 }
3972
3973 android_app {
3974 name: "app",
3975 srcs: ["foo/bar/MyClass.java"],
3976 package_name: "foo",
3977 sdk_version: "none",
3978 system_modules: "none",
Anton Hanssoneec79eb2020-01-10 15:12:39 +00003979 apex_available: [ "myapex" ],
Jiyong Park5d790c32019-11-15 18:40:32 +09003980 }
3981
3982 override_android_app {
3983 name: "override_app",
3984 base: "app",
3985 package_name: "bar",
3986 }
Jiyong Parka519c542020-03-03 11:45:41 +09003987 `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
Jiyong Park5d790c32019-11-15 18:40:32 +09003988
Jiyong Park317645e2019-12-05 13:20:58 +09003989 originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
3990 overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
3991 if originalVariant.GetOverriddenBy() != "" {
3992 t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
3993 }
3994 if overriddenVariant.GetOverriddenBy() != "override_myapex" {
3995 t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
3996 }
3997
Jiyong Park5d790c32019-11-15 18:40:32 +09003998 module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
3999 apexRule := module.Rule("apexRule")
4000 copyCmds := apexRule.Args["copy_commands"]
4001
4002 ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk")
Jooyung Han65cd0f02020-03-23 20:21:11 +09004003 ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004004
4005 apexBundle := module.Module().(*apexBundle)
4006 name := apexBundle.Name()
4007 if name != "override_myapex" {
4008 t.Errorf("name should be \"override_myapex\", but was %q", name)
4009 }
4010
Baligh Uddin004d7172020-02-19 21:29:28 -08004011 if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
4012 t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
4013 }
4014
Jiyong Parka519c542020-03-03 11:45:41 +09004015 optFlags := apexRule.Args["opt_flags"]
Baligh Uddincb6aa122020-03-15 13:01:05 -07004016 ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
Jiyong Parka519c542020-03-03 11:45:41 +09004017
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004018 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
4019 var builder strings.Builder
4020 data.Custom(&builder, name, "TARGET_", "", data)
4021 androidMk := builder.String()
Jiyong Parkf653b052019-11-18 15:39:01 +09004022 ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004023 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
4024 ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
Jaewoong Jung7abcf8e2019-12-19 17:32:06 -08004025 ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004026 ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
Jiyong Parkf653b052019-11-18 15:39:01 +09004027 ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
Jaewoong Jung1670ca02019-11-22 14:50:42 -08004028 ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
4029 ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
Jiyong Park5d790c32019-11-15 18:40:32 +09004030}
4031
Jooyung Han214bf372019-11-12 13:03:50 +09004032func TestLegacyAndroid10Support(t *testing.T) {
4033 ctx, _ := testApex(t, `
4034 apex {
4035 name: "myapex",
4036 key: "myapex.key",
Peter Collingbournedc4f9862020-02-12 17:13:25 -08004037 native_shared_libs: ["mylib"],
Jooyung Han23b0adf2020-03-12 18:37:20 +09004038 min_sdk_version: "29",
Jooyung Han214bf372019-11-12 13:03:50 +09004039 }
4040
4041 apex_key {
4042 name: "myapex.key",
4043 public_key: "testkey.avbpubkey",
4044 private_key: "testkey.pem",
4045 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08004046
4047 cc_library {
4048 name: "mylib",
4049 srcs: ["mylib.cpp"],
4050 stl: "libc++",
4051 system_shared_libs: [],
4052 apex_available: [ "myapex" ],
4053 }
Peter Collingbournedc4f9862020-02-12 17:13:25 -08004054 `, withUnbundledBuild)
Jooyung Han214bf372019-11-12 13:03:50 +09004055
4056 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4057 args := module.Rule("apexRule").Args
4058 ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
Dario Frenie3546902020-01-14 23:50:25 +00004059 ensureNotContains(t, args["opt_flags"], "--no_hashtree")
Peter Collingbournedc4f9862020-02-12 17:13:25 -08004060
4061 // The copies of the libraries in the apex should have one more dependency than
4062 // the ones outside the apex, namely the unwinder. Ideally we should check
4063 // the dependency names directly here but for some reason the names are blank in
4064 // this test.
4065 for _, lib := range []string{"libc++", "mylib"} {
4066 apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_myapex").Rule("ld").Implicits
4067 nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
4068 if len(apexImplicits) != len(nonApexImplicits)+1 {
4069 t.Errorf("%q missing unwinder dep", lib)
4070 }
4071 }
Jooyung Han214bf372019-11-12 13:03:50 +09004072}
4073
Paul Duffinbf19a972020-05-26 13:21:35 +01004074var filesForSdkLibrary = map[string][]byte{
4075 "api/current.txt": nil,
4076 "api/removed.txt": nil,
4077 "api/system-current.txt": nil,
4078 "api/system-removed.txt": nil,
4079 "api/test-current.txt": nil,
4080 "api/test-removed.txt": nil,
Paul Duffinf642a312020-06-12 17:46:39 +01004081
4082 // For java_sdk_library_import
4083 "a.jar": nil,
Paul Duffinbf19a972020-05-26 13:21:35 +01004084}
4085
Jooyung Han58f26ab2019-12-18 15:34:32 +09004086func TestJavaSDKLibrary(t *testing.T) {
4087 ctx, _ := testApex(t, `
4088 apex {
4089 name: "myapex",
4090 key: "myapex.key",
4091 java_libs: ["foo"],
4092 }
4093
4094 apex_key {
4095 name: "myapex.key",
4096 public_key: "testkey.avbpubkey",
4097 private_key: "testkey.pem",
4098 }
4099
4100 java_sdk_library {
4101 name: "foo",
4102 srcs: ["a.java"],
4103 api_packages: ["foo"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004104 apex_available: [ "myapex" ],
Jooyung Han58f26ab2019-12-18 15:34:32 +09004105 }
Paul Duffinbf19a972020-05-26 13:21:35 +01004106 `, withFiles(filesForSdkLibrary))
Jooyung Han58f26ab2019-12-18 15:34:32 +09004107
4108 // java_sdk_library installs both impl jar and permission XML
Jooyung Hana57af4a2020-01-23 05:36:59 +00004109 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
Jooyung Han58f26ab2019-12-18 15:34:32 +09004110 "javalib/foo.jar",
4111 "etc/permissions/foo.xml",
4112 })
4113 // Permission XML should point to the activated path of impl jar of java_sdk_library
Jiyong Parke3833882020-02-17 17:28:10 +09004114 sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
4115 ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`)
Jooyung Han58f26ab2019-12-18 15:34:32 +09004116}
4117
Paul Duffinbf19a972020-05-26 13:21:35 +01004118func TestJavaSDKLibrary_WithinApex(t *testing.T) {
4119 ctx, _ := testApex(t, `
4120 apex {
4121 name: "myapex",
4122 key: "myapex.key",
4123 java_libs: ["foo", "bar"],
4124 }
4125
4126 apex_key {
4127 name: "myapex.key",
4128 public_key: "testkey.avbpubkey",
4129 private_key: "testkey.pem",
4130 }
4131
4132 java_sdk_library {
4133 name: "foo",
4134 srcs: ["a.java"],
4135 api_packages: ["foo"],
4136 apex_available: ["myapex"],
4137 sdk_version: "none",
4138 system_modules: "none",
4139 }
4140
4141 java_library {
4142 name: "bar",
4143 srcs: ["a.java"],
4144 libs: ["foo"],
4145 apex_available: ["myapex"],
4146 sdk_version: "none",
4147 system_modules: "none",
4148 }
4149 `, withFiles(filesForSdkLibrary))
4150
4151 // java_sdk_library installs both impl jar and permission XML
4152 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
4153 "javalib/bar.jar",
4154 "javalib/foo.jar",
4155 "etc/permissions/foo.xml",
4156 })
4157
4158 // The bar library should depend on the implementation jar.
4159 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
4160 if expected, actual := `^-classpath /[^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
4161 t.Errorf("expected %q, found %#q", expected, actual)
4162 }
4163}
4164
4165func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
4166 ctx, _ := testApex(t, `
4167 apex {
4168 name: "myapex",
4169 key: "myapex.key",
4170 java_libs: ["foo"],
4171 }
4172
4173 apex_key {
4174 name: "myapex.key",
4175 public_key: "testkey.avbpubkey",
4176 private_key: "testkey.pem",
4177 }
4178
4179 java_sdk_library {
4180 name: "foo",
4181 srcs: ["a.java"],
4182 api_packages: ["foo"],
4183 apex_available: ["myapex"],
4184 sdk_version: "none",
4185 system_modules: "none",
4186 }
4187
4188 java_library {
4189 name: "bar",
4190 srcs: ["a.java"],
4191 libs: ["foo"],
4192 sdk_version: "none",
4193 system_modules: "none",
4194 }
4195 `, withFiles(filesForSdkLibrary))
4196
4197 // java_sdk_library installs both impl jar and permission XML
4198 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
4199 "javalib/foo.jar",
4200 "etc/permissions/foo.xml",
4201 })
4202
4203 // The bar library should depend on the stubs jar.
4204 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
4205 if expected, actual := `^-classpath /[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
4206 t.Errorf("expected %q, found %#q", expected, actual)
4207 }
4208}
4209
Paul Duffinf642a312020-06-12 17:46:39 +01004210func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
4211 ctx, _ := testApex(t, ``,
4212 withFiles(map[string][]byte{
4213 "apex/a.java": nil,
4214 "apex/apex_manifest.json": nil,
4215 "apex/Android.bp": []byte(`
4216 package {
4217 default_visibility: ["//visibility:private"],
4218 }
4219
4220 apex {
4221 name: "myapex",
4222 key: "myapex.key",
4223 java_libs: ["foo", "bar"],
4224 }
4225
4226 apex_key {
4227 name: "myapex.key",
4228 public_key: "testkey.avbpubkey",
4229 private_key: "testkey.pem",
4230 }
4231
4232 java_library {
4233 name: "bar",
4234 srcs: ["a.java"],
4235 libs: ["foo"],
4236 apex_available: ["myapex"],
4237 sdk_version: "none",
4238 system_modules: "none",
4239 }
4240`),
4241 "source/a.java": nil,
4242 "source/api/current.txt": nil,
4243 "source/api/removed.txt": nil,
4244 "source/Android.bp": []byte(`
4245 package {
4246 default_visibility: ["//visibility:private"],
4247 }
4248
4249 java_sdk_library {
4250 name: "foo",
4251 visibility: ["//apex"],
4252 srcs: ["a.java"],
4253 api_packages: ["foo"],
4254 apex_available: ["myapex"],
4255 sdk_version: "none",
4256 system_modules: "none",
4257 public: {
4258 enabled: true,
4259 },
4260 }
4261`),
4262 "prebuilt/a.jar": nil,
4263 "prebuilt/Android.bp": []byte(`
4264 package {
4265 default_visibility: ["//visibility:private"],
4266 }
4267
4268 java_sdk_library_import {
4269 name: "foo",
4270 visibility: ["//apex", "//source"],
4271 apex_available: ["myapex"],
4272 prefer: true,
4273 public: {
4274 jars: ["a.jar"],
4275 },
4276 }
4277`),
4278 }),
4279 )
4280
4281 // java_sdk_library installs both impl jar and permission XML
4282 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
4283 "javalib/bar.jar",
4284 "javalib/foo.jar",
4285 "etc/permissions/foo.xml",
4286 })
4287
4288 // The bar library should depend on the implementation jar.
4289 barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
4290 if expected, actual := `^-classpath /[^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
4291 t.Errorf("expected %q, found %#q", expected, actual)
4292 }
4293}
4294
4295func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
4296 testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
4297 apex {
4298 name: "myapex",
4299 key: "myapex.key",
4300 java_libs: ["foo"],
4301 }
4302
4303 apex_key {
4304 name: "myapex.key",
4305 public_key: "testkey.avbpubkey",
4306 private_key: "testkey.pem",
4307 }
4308
4309 java_sdk_library_import {
4310 name: "foo",
4311 apex_available: ["myapex"],
4312 prefer: true,
4313 public: {
4314 jars: ["a.jar"],
4315 },
4316 }
4317
4318 `, withFiles(filesForSdkLibrary))
4319}
4320
atrost6e126252020-01-27 17:01:16 +00004321func TestCompatConfig(t *testing.T) {
4322 ctx, _ := testApex(t, `
4323 apex {
4324 name: "myapex",
4325 key: "myapex.key",
4326 prebuilts: ["myjar-platform-compat-config"],
4327 java_libs: ["myjar"],
4328 }
4329
4330 apex_key {
4331 name: "myapex.key",
4332 public_key: "testkey.avbpubkey",
4333 private_key: "testkey.pem",
4334 }
4335
4336 platform_compat_config {
4337 name: "myjar-platform-compat-config",
4338 src: ":myjar",
4339 }
4340
4341 java_library {
4342 name: "myjar",
4343 srcs: ["foo/bar/MyClass.java"],
4344 sdk_version: "none",
4345 system_modules: "none",
atrost6e126252020-01-27 17:01:16 +00004346 apex_available: [ "myapex" ],
4347 }
4348 `)
4349 ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
4350 "etc/compatconfig/myjar-platform-compat-config.xml",
4351 "javalib/myjar.jar",
4352 })
4353}
4354
Jiyong Park479321d2019-12-16 11:47:12 +09004355func TestRejectNonInstallableJavaLibrary(t *testing.T) {
4356 testApexError(t, `"myjar" is not configured to be compiled into dex`, `
4357 apex {
4358 name: "myapex",
4359 key: "myapex.key",
4360 java_libs: ["myjar"],
4361 }
4362
4363 apex_key {
4364 name: "myapex.key",
4365 public_key: "testkey.avbpubkey",
4366 private_key: "testkey.pem",
4367 }
4368
4369 java_library {
4370 name: "myjar",
4371 srcs: ["foo/bar/MyClass.java"],
4372 sdk_version: "none",
4373 system_modules: "none",
Jiyong Park6b21c7d2020-02-11 09:16:01 +09004374 compile_dex: false,
Jooyung Hanb8fa86a2020-03-10 06:23:13 +09004375 apex_available: ["myapex"],
Jiyong Park479321d2019-12-16 11:47:12 +09004376 }
4377 `)
4378}
4379
Jiyong Park7afd1072019-12-30 16:56:33 +09004380func TestCarryRequiredModuleNames(t *testing.T) {
4381 ctx, config := testApex(t, `
4382 apex {
4383 name: "myapex",
4384 key: "myapex.key",
4385 native_shared_libs: ["mylib"],
4386 }
4387
4388 apex_key {
4389 name: "myapex.key",
4390 public_key: "testkey.avbpubkey",
4391 private_key: "testkey.pem",
4392 }
4393
4394 cc_library {
4395 name: "mylib",
4396 srcs: ["mylib.cpp"],
4397 system_shared_libs: [],
4398 stl: "none",
4399 required: ["a", "b"],
4400 host_required: ["c", "d"],
4401 target_required: ["e", "f"],
Anton Hanssoneec79eb2020-01-10 15:12:39 +00004402 apex_available: [ "myapex" ],
Jiyong Park7afd1072019-12-30 16:56:33 +09004403 }
4404 `)
4405
4406 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
4407 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
4408 name := apexBundle.BaseModuleName()
4409 prefix := "TARGET_"
4410 var builder strings.Builder
4411 data.Custom(&builder, name, prefix, "", data)
4412 androidMk := builder.String()
4413 ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
4414 ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
4415 ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
4416}
4417
Jiyong Park7cd10e32020-01-14 09:22:18 +09004418func TestSymlinksFromApexToSystem(t *testing.T) {
4419 bp := `
4420 apex {
4421 name: "myapex",
4422 key: "myapex.key",
4423 native_shared_libs: ["mylib"],
4424 java_libs: ["myjar"],
4425 }
4426
Jiyong Park9d677202020-02-19 16:29:35 +09004427 apex {
4428 name: "myapex.updatable",
4429 key: "myapex.key",
4430 native_shared_libs: ["mylib"],
4431 java_libs: ["myjar"],
4432 updatable: true,
Jooyung Hanced674e2020-04-27 12:10:30 +09004433 min_sdk_version: "current",
Jiyong Park9d677202020-02-19 16:29:35 +09004434 }
4435
Jiyong Park7cd10e32020-01-14 09:22:18 +09004436 apex_key {
4437 name: "myapex.key",
4438 public_key: "testkey.avbpubkey",
4439 private_key: "testkey.pem",
4440 }
4441
4442 cc_library {
4443 name: "mylib",
4444 srcs: ["mylib.cpp"],
4445 shared_libs: ["myotherlib"],
4446 system_shared_libs: [],
4447 stl: "none",
4448 apex_available: [
4449 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09004450 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09004451 "//apex_available:platform",
4452 ],
4453 }
4454
4455 cc_library {
4456 name: "myotherlib",
4457 srcs: ["mylib.cpp"],
4458 system_shared_libs: [],
4459 stl: "none",
4460 apex_available: [
4461 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09004462 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09004463 "//apex_available:platform",
4464 ],
4465 }
4466
4467 java_library {
4468 name: "myjar",
4469 srcs: ["foo/bar/MyClass.java"],
4470 sdk_version: "none",
4471 system_modules: "none",
4472 libs: ["myotherjar"],
Jiyong Park7cd10e32020-01-14 09:22:18 +09004473 apex_available: [
4474 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09004475 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09004476 "//apex_available:platform",
4477 ],
4478 }
4479
4480 java_library {
4481 name: "myotherjar",
4482 srcs: ["foo/bar/MyClass.java"],
4483 sdk_version: "none",
4484 system_modules: "none",
4485 apex_available: [
4486 "myapex",
Jiyong Park9d677202020-02-19 16:29:35 +09004487 "myapex.updatable",
Jiyong Park7cd10e32020-01-14 09:22:18 +09004488 "//apex_available:platform",
4489 ],
4490 }
4491 `
4492
4493 ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
4494 for _, f := range files {
4495 if f.path == file {
4496 if f.isLink {
4497 t.Errorf("%q is not a real file", file)
4498 }
4499 return
4500 }
4501 }
4502 t.Errorf("%q is not found", file)
4503 }
4504
4505 ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
4506 for _, f := range files {
4507 if f.path == file {
4508 if !f.isLink {
4509 t.Errorf("%q is not a symlink", file)
4510 }
4511 return
4512 }
4513 }
4514 t.Errorf("%q is not found", file)
4515 }
4516
Jiyong Park9d677202020-02-19 16:29:35 +09004517 // For unbundled build, symlink shouldn't exist regardless of whether an APEX
4518 // is updatable or not
Jiyong Park7cd10e32020-01-14 09:22:18 +09004519 ctx, _ := testApex(t, bp, withUnbundledBuild)
Jooyung Hana57af4a2020-01-23 05:36:59 +00004520 files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09004521 ensureRealfileExists(t, files, "javalib/myjar.jar")
4522 ensureRealfileExists(t, files, "lib64/mylib.so")
4523 ensureRealfileExists(t, files, "lib64/myotherlib.so")
4524
Jiyong Park9d677202020-02-19 16:29:35 +09004525 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
4526 ensureRealfileExists(t, files, "javalib/myjar.jar")
4527 ensureRealfileExists(t, files, "lib64/mylib.so")
4528 ensureRealfileExists(t, files, "lib64/myotherlib.so")
4529
4530 // For bundled build, symlink to the system for the non-updatable APEXes only
Jiyong Park7cd10e32020-01-14 09:22:18 +09004531 ctx, _ = testApex(t, bp)
Jooyung Hana57af4a2020-01-23 05:36:59 +00004532 files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
Jiyong Park7cd10e32020-01-14 09:22:18 +09004533 ensureRealfileExists(t, files, "javalib/myjar.jar")
4534 ensureRealfileExists(t, files, "lib64/mylib.so")
4535 ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
Jiyong Park9d677202020-02-19 16:29:35 +09004536
4537 files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
4538 ensureRealfileExists(t, files, "javalib/myjar.jar")
4539 ensureRealfileExists(t, files, "lib64/mylib.so")
4540 ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
Jiyong Park7cd10e32020-01-14 09:22:18 +09004541}
4542
Jooyung Han40b286c2020-04-17 13:43:10 +09004543func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
4544 ctx, _ := testApex(t, `
4545 apex {
4546 name: "myapex",
4547 key: "myapex.key",
4548 }
4549 apex_key {
4550 name: "myapex.key",
4551 public_key: "testkey.avbpubkey",
4552 private_key: "testkey.pem",
4553 }
4554 `, func(fs map[string][]byte, config android.Config) {
4555 delete(config.Targets, android.Android)
4556 config.AndroidCommonTarget = android.Target{}
4557 })
4558
4559 if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
4560 t.Errorf("Expected variants: %v, but got: %v", expected, got)
4561 }
4562}
4563
Jiyong Parkd93e1b12020-02-28 15:22:21 +09004564func TestAppBundle(t *testing.T) {
4565 ctx, _ := testApex(t, `
4566 apex {
4567 name: "myapex",
4568 key: "myapex.key",
4569 apps: ["AppFoo"],
4570 }
4571
4572 apex_key {
4573 name: "myapex.key",
4574 public_key: "testkey.avbpubkey",
4575 private_key: "testkey.pem",
4576 }
4577
4578 android_app {
4579 name: "AppFoo",
4580 srcs: ["foo/bar/MyClass.java"],
4581 sdk_version: "none",
4582 system_modules: "none",
4583 apex_available: [ "myapex" ],
4584 }
Jiyong Parkaf8998c2020-02-28 16:51:07 +09004585 `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
Jiyong Parkd93e1b12020-02-28 15:22:21 +09004586
4587 bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("Bundle Config")
4588 content := bundleConfigRule.Args["content"]
4589
4590 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
Jiyong Parkaf8998c2020-02-28 16:51:07 +09004591 ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`)
Jiyong Parkd93e1b12020-02-28 15:22:21 +09004592}
4593
Sasha Smundakc4f0ff12020-05-27 16:36:07 -07004594func TestAppSetBundle(t *testing.T) {
4595 ctx, _ := testApex(t, `
4596 apex {
4597 name: "myapex",
4598 key: "myapex.key",
4599 apps: ["AppSet"],
4600 }
4601
4602 apex_key {
4603 name: "myapex.key",
4604 public_key: "testkey.avbpubkey",
4605 private_key: "testkey.pem",
4606 }
4607
4608 android_app_set {
4609 name: "AppSet",
4610 set: "AppSet.apks",
4611 }`)
4612 mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
4613 bundleConfigRule := mod.Description("Bundle Config")
4614 content := bundleConfigRule.Args["content"]
4615 ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
4616 s := mod.Rule("apexRule").Args["copy_commands"]
4617 copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
4618 if len(copyCmds) != 3 {
4619 t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s)
4620 }
4621 ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$")
4622 ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$")
4623 ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$")
4624}
4625
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004626func testNoUpdatableJarsInBootImage(t *testing.T, errmsg, bp string, transformDexpreoptConfig func(*dexpreopt.GlobalConfig)) {
4627 t.Helper()
4628
4629 bp = bp + `
4630 filegroup {
4631 name: "some-updatable-apex-file_contexts",
4632 srcs: [
4633 "system/sepolicy/apex/some-updatable-apex-file_contexts",
4634 ],
4635 }
Ulya Trafimovichc0eb0b12020-04-22 18:05:58 +01004636
4637 filegroup {
4638 name: "some-non-updatable-apex-file_contexts",
4639 srcs: [
4640 "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
4641 ],
4642 }
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004643 `
4644 bp += cc.GatherRequiredDepsForTest(android.Android)
4645 bp += java.GatherRequiredDepsForTest()
4646 bp += dexpreopt.BpToolModulesForTest()
4647
4648 fs := map[string][]byte{
4649 "a.java": nil,
4650 "a.jar": nil,
4651 "build/make/target/product/security": nil,
4652 "apex_manifest.json": nil,
4653 "AndroidManifest.xml": nil,
4654 "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
Ulya Trafimovichc0eb0b12020-04-22 18:05:58 +01004655 "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004656 "system/sepolicy/apex/com.android.art.something-file_contexts": nil,
4657 "framework/aidl/a.aidl": nil,
4658 }
4659 cc.GatherRequiredFilesForTest(fs)
4660
4661 ctx := android.NewTestArchContext()
4662 ctx.RegisterModuleType("apex", BundleFactory)
4663 ctx.RegisterModuleType("apex_key", ApexKeyFactory)
4664 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Paul Duffineedf3f12020-04-29 18:27:14 +01004665 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004666 cc.RegisterRequiredBuildComponentsForTest(ctx)
4667 java.RegisterJavaBuildComponents(ctx)
4668 java.RegisterSystemModulesBuildComponents(ctx)
4669 java.RegisterAppBuildComponents(ctx)
4670 java.RegisterDexpreoptBootJarsComponents(ctx)
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004671 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
4672 ctx.PreDepsMutators(RegisterPreDepsMutators)
4673 ctx.PostDepsMutators(RegisterPostDepsMutators)
4674
4675 config := android.TestArchConfig(buildDir, nil, bp, fs)
4676 ctx.Register(config)
4677
4678 _ = dexpreopt.GlobalSoongConfigForTests(config)
4679 dexpreopt.RegisterToolModulesForTest(ctx)
4680 pathCtx := android.PathContextForTesting(config)
4681 dexpreoptConfig := dexpreopt.GlobalConfigForTests(pathCtx)
4682 transformDexpreoptConfig(dexpreoptConfig)
4683 dexpreopt.SetTestGlobalConfig(config, dexpreoptConfig)
4684
4685 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
4686 android.FailIfErrored(t, errs)
4687
4688 _, errs = ctx.PrepareBuildActions(config)
4689 if errmsg == "" {
4690 android.FailIfErrored(t, errs)
4691 } else if len(errs) > 0 {
4692 android.FailIfNoMatchingErrors(t, errmsg, errs)
4693 return
4694 } else {
4695 t.Fatalf("missing expected error %q (0 errors are returned)", errmsg)
4696 }
4697}
4698
Jooyung Hanced674e2020-04-27 12:10:30 +09004699func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
4700 testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
4701 apex {
4702 name: "myapex",
4703 key: "myapex.key",
4704 updatable: true,
4705 }
4706
4707 apex_key {
4708 name: "myapex.key",
4709 public_key: "testkey.avbpubkey",
4710 private_key: "testkey.pem",
4711 }
4712 `)
4713}
4714
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004715func TestNoUpdatableJarsInBootImage(t *testing.T) {
4716 bp := `
4717 java_library {
4718 name: "some-updatable-apex-lib",
4719 srcs: ["a.java"],
Artur Satayev2eedf622020-04-15 17:29:42 +01004720 sdk_version: "current",
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004721 apex_available: [
4722 "some-updatable-apex",
4723 ],
4724 }
4725
4726 java_library {
Ulya Trafimovichc0eb0b12020-04-22 18:05:58 +01004727 name: "some-non-updatable-apex-lib",
4728 srcs: ["a.java"],
4729 apex_available: [
4730 "some-non-updatable-apex",
4731 ],
4732 }
4733
4734 java_library {
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004735 name: "some-platform-lib",
4736 srcs: ["a.java"],
Artur Satayev2eedf622020-04-15 17:29:42 +01004737 sdk_version: "current",
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004738 installable: true,
4739 }
4740
4741 java_library {
4742 name: "some-art-lib",
4743 srcs: ["a.java"],
Artur Satayev2eedf622020-04-15 17:29:42 +01004744 sdk_version: "current",
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004745 apex_available: [
4746 "com.android.art.something",
4747 ],
4748 hostdex: true,
4749 }
4750
4751 apex {
4752 name: "some-updatable-apex",
4753 key: "some-updatable-apex.key",
4754 java_libs: ["some-updatable-apex-lib"],
Ulya Trafimovichc0eb0b12020-04-22 18:05:58 +01004755 updatable: true,
4756 min_sdk_version: "current",
4757 }
4758
4759 apex {
4760 name: "some-non-updatable-apex",
4761 key: "some-non-updatable-apex.key",
4762 java_libs: ["some-non-updatable-apex-lib"],
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004763 }
4764
4765 apex_key {
4766 name: "some-updatable-apex.key",
4767 }
4768
Ulya Trafimovichc0eb0b12020-04-22 18:05:58 +01004769 apex_key {
4770 name: "some-non-updatable-apex.key",
4771 }
4772
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004773 apex {
4774 name: "com.android.art.something",
4775 key: "com.android.art.something.key",
4776 java_libs: ["some-art-lib"],
Ulya Trafimovichc0eb0b12020-04-22 18:05:58 +01004777 updatable: true,
4778 min_sdk_version: "current",
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004779 }
4780
4781 apex_key {
4782 name: "com.android.art.something.key",
4783 }
4784 `
4785
4786 var error string
4787 var transform func(*dexpreopt.GlobalConfig)
4788
4789 // updatable jar from ART apex in the ART boot image => ok
4790 transform = func(config *dexpreopt.GlobalConfig) {
4791 config.ArtApexJars = []string{"some-art-lib"}
4792 }
4793 testNoUpdatableJarsInBootImage(t, "", bp, transform)
4794
4795 // updatable jar from ART apex in the framework boot image => error
4796 error = "module 'some-art-lib' from updatable apex 'com.android.art.something' is not allowed in the framework boot image"
4797 transform = func(config *dexpreopt.GlobalConfig) {
4798 config.BootJars = []string{"some-art-lib"}
4799 }
4800 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4801
4802 // updatable jar from some other apex in the ART boot image => error
4803 error = "module 'some-updatable-apex-lib' from updatable apex 'some-updatable-apex' is not allowed in the ART boot image"
4804 transform = func(config *dexpreopt.GlobalConfig) {
4805 config.ArtApexJars = []string{"some-updatable-apex-lib"}
4806 }
4807 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4808
Ulya Trafimovichc0eb0b12020-04-22 18:05:58 +01004809 // non-updatable jar from some other apex in the ART boot image => error
4810 error = "module 'some-non-updatable-apex-lib' is not allowed in the ART boot image"
4811 transform = func(config *dexpreopt.GlobalConfig) {
4812 config.ArtApexJars = []string{"some-non-updatable-apex-lib"}
4813 }
4814 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4815
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004816 // updatable jar from some other apex in the framework boot image => error
4817 error = "module 'some-updatable-apex-lib' from updatable apex 'some-updatable-apex' is not allowed in the framework boot image"
4818 transform = func(config *dexpreopt.GlobalConfig) {
4819 config.BootJars = []string{"some-updatable-apex-lib"}
4820 }
4821 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4822
Ulya Trafimovichc0eb0b12020-04-22 18:05:58 +01004823 // non-updatable jar from some other apex in the framework boot image => ok
4824 transform = func(config *dexpreopt.GlobalConfig) {
4825 config.BootJars = []string{"some-non-updatable-apex-lib"}
4826 }
4827 testNoUpdatableJarsInBootImage(t, "", bp, transform)
4828
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004829 // nonexistent jar in the ART boot image => error
4830 error = "failed to find a dex jar path for module 'nonexistent'"
4831 transform = func(config *dexpreopt.GlobalConfig) {
4832 config.ArtApexJars = []string{"nonexistent"}
4833 }
4834 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4835
4836 // nonexistent jar in the framework boot image => error
4837 error = "failed to find a dex jar path for module 'nonexistent'"
4838 transform = func(config *dexpreopt.GlobalConfig) {
4839 config.BootJars = []string{"nonexistent"}
4840 }
4841 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4842
4843 // platform jar in the ART boot image => error
Ulya Trafimovichc0eb0b12020-04-22 18:05:58 +01004844 error = "module 'some-platform-lib' is not allowed in the ART boot image"
Ulya Trafimovichcc21bba2020-01-13 15:18:16 +00004845 transform = func(config *dexpreopt.GlobalConfig) {
4846 config.ArtApexJars = []string{"some-platform-lib"}
4847 }
4848 testNoUpdatableJarsInBootImage(t, error, bp, transform)
4849
4850 // platform jar in the framework boot image => ok
4851 transform = func(config *dexpreopt.GlobalConfig) {
4852 config.BootJars = []string{"some-platform-lib"}
4853 }
4854 testNoUpdatableJarsInBootImage(t, "", bp, transform)
4855}
4856
Jiyong Parkf0d01b72020-04-13 16:19:48 +09004857func TestTestFor(t *testing.T) {
4858 ctx, _ := testApex(t, `
4859 apex {
4860 name: "myapex",
4861 key: "myapex.key",
4862 native_shared_libs: ["mylib", "myprivlib"],
4863 }
4864
4865 apex_key {
4866 name: "myapex.key",
4867 public_key: "testkey.avbpubkey",
4868 private_key: "testkey.pem",
4869 }
4870
4871 cc_library {
4872 name: "mylib",
4873 srcs: ["mylib.cpp"],
4874 system_shared_libs: [],
4875 stl: "none",
4876 stubs: {
4877 versions: ["1"],
4878 },
4879 apex_available: ["myapex"],
4880 }
4881
4882 cc_library {
4883 name: "myprivlib",
4884 srcs: ["mylib.cpp"],
4885 system_shared_libs: [],
4886 stl: "none",
4887 apex_available: ["myapex"],
4888 }
4889
4890
4891 cc_test {
4892 name: "mytest",
4893 gtest: false,
4894 srcs: ["mylib.cpp"],
4895 system_shared_libs: [],
4896 stl: "none",
4897 shared_libs: ["mylib", "myprivlib"],
4898 test_for: ["myapex"]
4899 }
4900 `)
4901
4902 // the test 'mytest' is a test for the apex, therefore is linked to the
4903 // actual implementation of mylib instead of its stub.
4904 ldFlags := ctx.ModuleForTests("mytest", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
4905 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_shared/mylib.so")
4906 ensureNotContains(t, ldFlags, "mylib/android_arm64_armv8-a_shared_1/mylib.so")
4907}
4908
Jaewoong Jung8cf307e2020-05-14 14:15:24 -07004909// TODO(jungjw): Move this to proptools
4910func intPtr(i int) *int {
4911 return &i
4912}
4913
4914func TestApexSet(t *testing.T) {
4915 ctx, config := testApex(t, `
4916 apex_set {
4917 name: "myapex",
4918 set: "myapex.apks",
4919 filename: "foo_v2.apex",
4920 overrides: ["foo"],
4921 }
4922 `, func(fs map[string][]byte, config android.Config) {
4923 config.TestProductVariables.Platform_sdk_version = intPtr(30)
Jaewoong Jung829b7132020-06-10 12:23:32 -07004924 config.Targets[android.Android] = []android.Target{
4925 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
4926 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
4927 }
Jaewoong Jung8cf307e2020-05-14 14:15:24 -07004928 })
4929
4930 m := ctx.ModuleForTests("myapex", "android_common")
4931
4932 // Check extract_apks tool parameters.
4933 extractedApex := m.Output(buildDir + "/.intermediates/myapex/android_common/foo_v2.apex")
4934 actual := extractedApex.Args["abis"]
4935 expected := "ARMEABI_V7A,ARM64_V8A"
4936 if actual != expected {
4937 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
4938 }
4939 actual = extractedApex.Args["sdk-version"]
4940 expected = "30"
4941 if actual != expected {
4942 t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
4943 }
4944
4945 a := m.Module().(*ApexSet)
4946 expectedOverrides := []string{"foo"}
4947 actualOverrides := android.AndroidMkEntriesForTest(t, config, "", a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
4948 if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
4949 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
4950 }
4951}
4952
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07004953func TestMain(m *testing.M) {
4954 run := func() int {
4955 setUp()
4956 defer tearDown()
4957
4958 return m.Run()
4959 }
4960
4961 os.Exit(run())
4962}