blob: 8b8629b9410da00e96bf3151776068720d688bf8 [file] [log] [blame]
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001// Copyright 2021 Google LLC
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15// Convert makefile containing device configuration to Starlark file
16// The conversion can handle the following constructs in a makefile:
Colin Crossd079e0b2022-08-16 10:27:33 -070017// - comments
18// - simple variable assignments
19// - $(call init-product,<file>)
20// - $(call inherit-product-if-exists
21// - if directives
Sasha Smundakb051c4e2020-11-05 20:45:07 -080022//
Colin Crossd079e0b2022-08-16 10:27:33 -070023// All other constructs are carried over to the output starlark file as comments.
Sasha Smundakb051c4e2020-11-05 20:45:07 -080024package mk2rbc
25
26import (
27 "bytes"
28 "fmt"
29 "io"
Sasha Smundak6609ba72021-07-22 18:32:56 -070030 "io/fs"
Sasha Smundakb051c4e2020-11-05 20:45:07 -080031 "io/ioutil"
32 "os"
33 "path/filepath"
34 "regexp"
Cole Faust62e05112022-04-05 17:56:11 -070035 "sort"
Sasha Smundakb051c4e2020-11-05 20:45:07 -080036 "strconv"
37 "strings"
38 "text/scanner"
39
40 mkparser "android/soong/androidmk/parser"
41)
42
43const (
Sasha Smundak6d852dd2021-09-27 20:34:39 -070044 annotationCommentPrefix = "RBC#"
45 baseUri = "//build/make/core:product_config.rbc"
Sasha Smundakb051c4e2020-11-05 20:45:07 -080046 // The name of the struct exported by the product_config.rbc
47 // that contains the functions and variables available to
48 // product configuration Starlark files.
49 baseName = "rblf"
50
Sasha Smundak65b547e2021-09-17 15:35:41 -070051 soongNsPrefix = "SOONG_CONFIG_"
52
Sasha Smundakb051c4e2020-11-05 20:45:07 -080053 // And here are the functions and variables:
Cole Fauste2a37982022-03-09 16:00:17 -080054 cfnGetCfg = baseName + ".cfg"
55 cfnMain = baseName + ".product_configuration"
56 cfnBoardMain = baseName + ".board_configuration"
57 cfnPrintVars = baseName + ".printvars"
58 cfnInherit = baseName + ".inherit"
59 cfnSetListDefault = baseName + ".setdefault"
Sasha Smundakb051c4e2020-11-05 20:45:07 -080060)
61
62const (
Cole Faust9ebf6e42021-12-13 14:08:34 -080063 soongConfigAppend = "soong_config_append"
64 soongConfigAssign = "soong_config_set"
Sasha Smundakb051c4e2020-11-05 20:45:07 -080065)
66
Cole Faust9ebf6e42021-12-13 14:08:34 -080067var knownFunctions = map[string]interface {
68 parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr
Sasha Smundakb051c4e2020-11-05 20:45:07 -080069}{
Cole Faust1cc08852022-02-28 11:12:08 -080070 "abspath": &simpleCallParser{name: baseName + ".abspath", returnType: starlarkTypeString},
71 "add-product-dex-preopt-module-config": &simpleCallParser{name: baseName + ".add_product_dex_preopt_module_config", returnType: starlarkTypeString, addHandle: true},
72 "add_soong_config_namespace": &simpleCallParser{name: baseName + ".soong_config_namespace", returnType: starlarkTypeVoid, addGlobals: true},
73 "add_soong_config_var_value": &simpleCallParser{name: baseName + ".soong_config_set", returnType: starlarkTypeVoid, addGlobals: true},
74 soongConfigAssign: &simpleCallParser{name: baseName + ".soong_config_set", returnType: starlarkTypeVoid, addGlobals: true},
75 soongConfigAppend: &simpleCallParser{name: baseName + ".soong_config_append", returnType: starlarkTypeVoid, addGlobals: true},
76 "soong_config_get": &simpleCallParser{name: baseName + ".soong_config_get", returnType: starlarkTypeString, addGlobals: true},
77 "add-to-product-copy-files-if-exists": &simpleCallParser{name: baseName + ".copy_if_exists", returnType: starlarkTypeList},
78 "addprefix": &simpleCallParser{name: baseName + ".addprefix", returnType: starlarkTypeList},
79 "addsuffix": &simpleCallParser{name: baseName + ".addsuffix", returnType: starlarkTypeList},
Cole Faustd2daabf2022-12-12 17:38:01 -080080 "and": &andOrParser{isAnd: true},
Cole Faust1cc08852022-02-28 11:12:08 -080081 "copy-files": &simpleCallParser{name: baseName + ".copy_files", returnType: starlarkTypeList},
Cole Faust0e2b2562022-04-01 11:46:50 -070082 "dir": &simpleCallParser{name: baseName + ".dir", returnType: starlarkTypeString},
Cole Faust1cc08852022-02-28 11:12:08 -080083 "dist-for-goals": &simpleCallParser{name: baseName + ".mkdist_for_goals", returnType: starlarkTypeVoid, addGlobals: true},
Cole Faust6c41b8a2022-04-13 13:53:48 -070084 "enforce-product-packages-exist": &simpleCallParser{name: baseName + ".enforce_product_packages_exist", returnType: starlarkTypeVoid, addHandle: true},
Cole Faust1cc08852022-02-28 11:12:08 -080085 "error": &makeControlFuncParser{name: baseName + ".mkerror"},
86 "findstring": &simpleCallParser{name: baseName + ".findstring", returnType: starlarkTypeInt},
87 "find-copy-subdir-files": &simpleCallParser{name: baseName + ".find_and_copy", returnType: starlarkTypeList},
88 "filter": &simpleCallParser{name: baseName + ".filter", returnType: starlarkTypeList},
89 "filter-out": &simpleCallParser{name: baseName + ".filter_out", returnType: starlarkTypeList},
Cole Faust5a13aaf2022-04-27 17:49:35 -070090 "firstword": &simpleCallParser{name: baseName + ".first_word", returnType: starlarkTypeString},
Cole Faustf035d402022-03-28 14:02:50 -070091 "foreach": &foreachCallParser{},
Cole Faust1cc08852022-02-28 11:12:08 -080092 "if": &ifCallParser{},
93 "info": &makeControlFuncParser{name: baseName + ".mkinfo"},
94 "is-board-platform": &simpleCallParser{name: baseName + ".board_platform_is", returnType: starlarkTypeBool, addGlobals: true},
95 "is-board-platform2": &simpleCallParser{name: baseName + ".board_platform_is", returnType: starlarkTypeBool, addGlobals: true},
96 "is-board-platform-in-list": &simpleCallParser{name: baseName + ".board_platform_in", returnType: starlarkTypeBool, addGlobals: true},
97 "is-board-platform-in-list2": &simpleCallParser{name: baseName + ".board_platform_in", returnType: starlarkTypeBool, addGlobals: true},
98 "is-product-in-list": &isProductInListCallParser{},
99 "is-vendor-board-platform": &isVendorBoardPlatformCallParser{},
100 "is-vendor-board-qcom": &isVendorBoardQcomCallParser{},
Cole Faust5a13aaf2022-04-27 17:49:35 -0700101 "lastword": &simpleCallParser{name: baseName + ".last_word", returnType: starlarkTypeString},
Cole Faust1cc08852022-02-28 11:12:08 -0800102 "notdir": &simpleCallParser{name: baseName + ".notdir", returnType: starlarkTypeString},
103 "math_max": &mathMaxOrMinCallParser{function: "max"},
104 "math_min": &mathMaxOrMinCallParser{function: "min"},
105 "math_gt_or_eq": &mathComparisonCallParser{op: ">="},
106 "math_gt": &mathComparisonCallParser{op: ">"},
107 "math_lt": &mathComparisonCallParser{op: "<"},
108 "my-dir": &myDirCallParser{},
Cole Faustd2daabf2022-12-12 17:38:01 -0800109 "or": &andOrParser{isAnd: false},
Cole Faust1cc08852022-02-28 11:12:08 -0800110 "patsubst": &substCallParser{fname: "patsubst"},
111 "product-copy-files-by-pattern": &simpleCallParser{name: baseName + ".product_copy_files_by_pattern", returnType: starlarkTypeList},
Cole Faustea9db582022-03-21 17:50:05 -0700112 "require-artifacts-in-path": &simpleCallParser{name: baseName + ".require_artifacts_in_path", returnType: starlarkTypeVoid, addHandle: true},
113 "require-artifacts-in-path-relaxed": &simpleCallParser{name: baseName + ".require_artifacts_in_path_relaxed", returnType: starlarkTypeVoid, addHandle: true},
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800114 // TODO(asmundak): remove it once all calls are removed from configuration makefiles. see b/183161002
Cole Faust9ebf6e42021-12-13 14:08:34 -0800115 "shell": &shellCallParser{},
Cole Faust95b95cb2022-04-05 16:37:39 -0700116 "sort": &simpleCallParser{name: baseName + ".mksort", returnType: starlarkTypeList},
Cole Faust1cc08852022-02-28 11:12:08 -0800117 "strip": &simpleCallParser{name: baseName + ".mkstrip", returnType: starlarkTypeString},
Cole Faust9ebf6e42021-12-13 14:08:34 -0800118 "subst": &substCallParser{fname: "subst"},
119 "warning": &makeControlFuncParser{name: baseName + ".mkwarning"},
120 "word": &wordCallParser{},
Cole Faust94c4a9a2022-04-22 17:43:52 -0700121 "words": &wordsCallParser{},
Cole Faust1cc08852022-02-28 11:12:08 -0800122 "wildcard": &simpleCallParser{name: baseName + ".expand_wildcard", returnType: starlarkTypeList},
Cole Faust9ebf6e42021-12-13 14:08:34 -0800123}
124
Cole Faustf035d402022-03-28 14:02:50 -0700125// The same as knownFunctions, but returns a []starlarkNode instead of a starlarkExpr
126var knownNodeFunctions = map[string]interface {
127 parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) []starlarkNode
128}{
129 "eval": &evalNodeParser{},
130 "if": &ifCallNodeParser{},
131 "inherit-product": &inheritProductCallParser{loadAlways: true},
132 "inherit-product-if-exists": &inheritProductCallParser{loadAlways: false},
133 "foreach": &foreachCallNodeParser{},
134}
135
Cole Faust1e275862022-04-26 14:28:04 -0700136// These look like variables, but are actually functions, and would give
137// undefined variable errors if we converted them as variables. Instead,
138// emit an error instead of converting them.
139var unsupportedFunctions = map[string]bool{
140 "local-generated-sources-dir": true,
141 "local-intermediates-dir": true,
142}
143
Cole Faust9ebf6e42021-12-13 14:08:34 -0800144// These are functions that we don't implement conversions for, but
145// we allow seeing their definitions in the product config files.
146var ignoredDefines = map[string]bool{
147 "find-word-in-list": true, // internal macro
148 "get-vendor-board-platforms": true, // internal macro, used by is-board-platform, etc.
149 "is-android-codename": true, // unused by product config
150 "is-android-codename-in-list": true, // unused by product config
151 "is-chipset-in-board-platform": true, // unused by product config
152 "is-chipset-prefix-in-board-platform": true, // unused by product config
153 "is-not-board-platform": true, // defined but never used
154 "is-platform-sdk-version-at-least": true, // unused by product config
155 "match-prefix": true, // internal macro
156 "match-word": true, // internal macro
157 "match-word-in-list": true, // internal macro
158 "tb-modules": true, // defined in hardware/amlogic/tb_modules/tb_detect.mk, unused
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800159}
160
Cole Faustb0d32ab2021-12-09 14:00:59 -0800161var identifierFullMatchRegex = regexp.MustCompile("^[a-zA-Z_][a-zA-Z0-9_]*$")
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800162
163// Conversion request parameters
164type Request struct {
Sasha Smundak422b6142021-11-11 18:31:59 -0800165 MkFile string // file to convert
166 Reader io.Reader // if set, read input from this stream instead
Sasha Smundak422b6142021-11-11 18:31:59 -0800167 OutputSuffix string // generated Starlark files suffix
168 OutputDir string // if set, root of the output hierarchy
169 ErrorLogger ErrorLogger
170 TracedVariables []string // trace assignment to these variables
171 TraceCalls bool
172 SourceFS fs.FS
173 MakefileFinder MakefileFinder
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800174}
175
Sasha Smundak7d934b92021-11-10 12:20:01 -0800176// ErrorLogger prints errors and gathers error statistics.
177// Its NewError function is called on every error encountered during the conversion.
178type ErrorLogger interface {
Sasha Smundak422b6142021-11-11 18:31:59 -0800179 NewError(el ErrorLocation, node mkparser.Node, text string, args ...interface{})
180}
181
182type ErrorLocation struct {
183 MkFile string
184 MkLine int
185}
186
187func (el ErrorLocation) String() string {
188 return fmt.Sprintf("%s:%d", el.MkFile, el.MkLine)
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800189}
190
191// Derives module name for a given file. It is base name
192// (file name without suffix), with some characters replaced to make it a Starlark identifier
193func moduleNameForFile(mkFile string) string {
194 base := strings.TrimSuffix(filepath.Base(mkFile), filepath.Ext(mkFile))
195 // TODO(asmundak): what else can be in the product file names?
Sasha Smundak6609ba72021-07-22 18:32:56 -0700196 return strings.NewReplacer("-", "_", ".", "_").Replace(base)
197
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800198}
199
200func cloneMakeString(mkString *mkparser.MakeString) *mkparser.MakeString {
201 r := &mkparser.MakeString{StringPos: mkString.StringPos}
202 r.Strings = append(r.Strings, mkString.Strings...)
203 r.Variables = append(r.Variables, mkString.Variables...)
204 return r
205}
206
207func isMakeControlFunc(s string) bool {
208 return s == "error" || s == "warning" || s == "info"
209}
210
Cole Faustf0632662022-04-07 13:59:24 -0700211// varAssignmentScope points to the last assignment for each variable
212// in the current block. It is used during the parsing to chain
213// the assignments to a variable together.
214type varAssignmentScope struct {
215 outer *varAssignmentScope
216 vars map[string]bool
217}
218
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800219// Starlark output generation context
220type generationContext struct {
Cole Faustf0632662022-04-07 13:59:24 -0700221 buf strings.Builder
222 starScript *StarlarkScript
223 indentLevel int
224 inAssignment bool
225 tracedCount int
226 varAssignments *varAssignmentScope
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800227}
228
229func NewGenerateContext(ss *StarlarkScript) *generationContext {
Cole Faustf0632662022-04-07 13:59:24 -0700230 return &generationContext{
231 starScript: ss,
232 varAssignments: &varAssignmentScope{
233 outer: nil,
234 vars: make(map[string]bool),
235 },
236 }
237}
238
239func (gctx *generationContext) pushVariableAssignments() {
240 va := &varAssignmentScope{
241 outer: gctx.varAssignments,
242 vars: make(map[string]bool),
243 }
244 gctx.varAssignments = va
245}
246
247func (gctx *generationContext) popVariableAssignments() {
248 gctx.varAssignments = gctx.varAssignments.outer
249}
250
251func (gctx *generationContext) hasBeenAssigned(v variable) bool {
252 for va := gctx.varAssignments; va != nil; va = va.outer {
253 if _, ok := va.vars[v.name()]; ok {
254 return true
255 }
256 }
257 return false
258}
259
260func (gctx *generationContext) setHasBeenAssigned(v variable) {
261 gctx.varAssignments.vars[v.name()] = true
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800262}
263
264// emit returns generated script
265func (gctx *generationContext) emit() string {
266 ss := gctx.starScript
267
268 // The emitted code has the following layout:
269 // <initial comments>
270 // preamble, i.e.,
271 // load statement for the runtime support
272 // load statement for each unique submodule pulled in by this one
273 // def init(g, handle):
274 // cfg = rblf.cfg(handle)
275 // <statements>
276 // <warning if conversion was not clean>
277
278 iNode := len(ss.nodes)
279 for i, node := range ss.nodes {
280 if _, ok := node.(*commentNode); !ok {
281 iNode = i
282 break
283 }
284 node.emit(gctx)
285 }
286
287 gctx.emitPreamble()
288
289 gctx.newLine()
290 // The arguments passed to the init function are the global dictionary
291 // ('g') and the product configuration dictionary ('cfg')
292 gctx.write("def init(g, handle):")
293 gctx.indentLevel++
294 if gctx.starScript.traceCalls {
295 gctx.newLine()
296 gctx.writef(`print(">%s")`, gctx.starScript.mkFile)
297 }
298 gctx.newLine()
299 gctx.writef("cfg = %s(handle)", cfnGetCfg)
300 for _, node := range ss.nodes[iNode:] {
301 node.emit(gctx)
302 }
303
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800304 if gctx.starScript.traceCalls {
305 gctx.newLine()
306 gctx.writef(`print("<%s")`, gctx.starScript.mkFile)
307 }
308 gctx.indentLevel--
309 gctx.write("\n")
310 return gctx.buf.String()
311}
312
313func (gctx *generationContext) emitPreamble() {
314 gctx.newLine()
315 gctx.writef("load(%q, %q)", baseUri, baseName)
316 // Emit exactly one load statement for each URI.
317 loadedSubConfigs := make(map[string]string)
Sasha Smundak6bc132a2022-01-10 17:02:16 -0800318 for _, mi := range gctx.starScript.inherited {
319 uri := mi.path
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800320 if m, ok := loadedSubConfigs[uri]; ok {
321 // No need to emit load statement, but fix module name.
Sasha Smundak6bc132a2022-01-10 17:02:16 -0800322 mi.moduleLocalName = m
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800323 continue
324 }
Sasha Smundak6bc132a2022-01-10 17:02:16 -0800325 if mi.optional || mi.missing {
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800326 uri += "|init"
327 }
328 gctx.newLine()
Sasha Smundak6bc132a2022-01-10 17:02:16 -0800329 gctx.writef("load(%q, %s = \"init\")", uri, mi.entryName())
330 loadedSubConfigs[uri] = mi.moduleLocalName
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800331 }
332 gctx.write("\n")
333}
334
335func (gctx *generationContext) emitPass() {
336 gctx.newLine()
337 gctx.write("pass")
338}
339
340func (gctx *generationContext) write(ss ...string) {
341 for _, s := range ss {
342 gctx.buf.WriteString(s)
343 }
344}
345
346func (gctx *generationContext) writef(format string, args ...interface{}) {
347 gctx.write(fmt.Sprintf(format, args...))
348}
349
350func (gctx *generationContext) newLine() {
351 if gctx.buf.Len() == 0 {
352 return
353 }
354 gctx.write("\n")
355 gctx.writef("%*s", 2*gctx.indentLevel, "")
356}
357
Sasha Smundak422b6142021-11-11 18:31:59 -0800358func (gctx *generationContext) emitConversionError(el ErrorLocation, message string) {
359 gctx.writef(`rblf.mk2rbc_error("%s", %q)`, el, message)
360}
361
Sasha Smundak6bc132a2022-01-10 17:02:16 -0800362func (gctx *generationContext) emitLoadCheck(im inheritedModule) {
363 if !im.needsLoadCheck() {
364 return
365 }
366 gctx.newLine()
367 gctx.writef("if not %s:", im.entryName())
368 gctx.indentLevel++
369 gctx.newLine()
370 gctx.write(`rblf.mkerror("`, gctx.starScript.mkFile, `", "Cannot find %s" % (`)
371 im.pathExpr().emit(gctx)
372 gctx.write("))")
373 gctx.indentLevel--
374}
375
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800376type knownVariable struct {
377 name string
378 class varClass
379 valueType starlarkType
380}
381
382type knownVariables map[string]knownVariable
383
384func (pcv knownVariables) NewVariable(name string, varClass varClass, valueType starlarkType) {
385 v, exists := pcv[name]
386 if !exists {
387 pcv[name] = knownVariable{name, varClass, valueType}
388 return
389 }
390 // Conflict resolution:
391 // * config class trumps everything
392 // * any type trumps unknown type
393 match := varClass == v.class
394 if !match {
395 if varClass == VarClassConfig {
396 v.class = VarClassConfig
397 match = true
398 } else if v.class == VarClassConfig {
399 match = true
400 }
401 }
402 if valueType != v.valueType {
403 if valueType != starlarkTypeUnknown {
404 if v.valueType == starlarkTypeUnknown {
405 v.valueType = valueType
406 } else {
407 match = false
408 }
409 }
410 }
411 if !match {
412 fmt.Fprintf(os.Stderr, "cannot redefine %s as %v/%v (already defined as %v/%v)\n",
413 name, varClass, valueType, v.class, v.valueType)
414 }
415}
416
417// All known product variables.
418var KnownVariables = make(knownVariables)
419
420func init() {
421 for _, kv := range []string{
422 // Kernel-related variables that we know are lists.
423 "BOARD_VENDOR_KERNEL_MODULES",
424 "BOARD_VENDOR_RAMDISK_KERNEL_MODULES",
425 "BOARD_VENDOR_RAMDISK_KERNEL_MODULES_LOAD",
426 "BOARD_RECOVERY_KERNEL_MODULES",
427 // Other variables we knwo are lists
428 "ART_APEX_JARS",
429 } {
430 KnownVariables.NewVariable(kv, VarClassSoong, starlarkTypeList)
431 }
432}
433
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800434// Information about the generated Starlark script.
435type StarlarkScript struct {
Sasha Smundak422b6142021-11-11 18:31:59 -0800436 mkFile string
437 moduleName string
438 mkPos scanner.Position
439 nodes []starlarkNode
440 inherited []*moduleInfo
441 hasErrors bool
Sasha Smundak422b6142021-11-11 18:31:59 -0800442 traceCalls bool // print enter/exit each init function
443 sourceFS fs.FS
444 makefileFinder MakefileFinder
445 nodeLocator func(pos mkparser.Pos) int
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800446}
447
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800448// parseContext holds the script we are generating and all the ephemeral data
449// needed during the parsing.
450type parseContext struct {
451 script *StarlarkScript
452 nodes []mkparser.Node // Makefile as parsed by mkparser
453 currentNodeIndex int // Node in it we are processing
454 ifNestLevel int
455 moduleNameCount map[string]int // count of imported modules with given basename
456 fatalError error
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800457 outputSuffix string
Sasha Smundak7d934b92021-11-10 12:20:01 -0800458 errorLogger ErrorLogger
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800459 tracedVariables map[string]bool // variables to be traced in the generated script
460 variables map[string]variable
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800461 outputDir string
Sasha Smundak6609ba72021-07-22 18:32:56 -0700462 dependentModules map[string]*moduleInfo
Sasha Smundak3deb9682021-07-26 18:42:25 -0700463 soongNamespaces map[string]map[string]bool
Sasha Smundak6d852dd2021-09-27 20:34:39 -0700464 includeTops []string
Cole Faustf92c9f22022-03-14 14:35:50 -0700465 typeHints map[string]starlarkType
466 atTopOfMakefile bool
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800467}
468
469func newParseContext(ss *StarlarkScript, nodes []mkparser.Node) *parseContext {
470 predefined := []struct{ name, value string }{
471 {"SRC_TARGET_DIR", filepath.Join("build", "make", "target")},
472 {"LOCAL_PATH", filepath.Dir(ss.mkFile)},
Cole Faust5a13aaf2022-04-27 17:49:35 -0700473 {"MAKEFILE_LIST", ss.mkFile},
Cole Faust9b6111a2022-02-02 15:38:33 -0800474 {"TOPDIR", ""}, // TOPDIR is just set to an empty string in cleanbuild.mk and core.mk
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800475 // TODO(asmundak): maybe read it from build/make/core/envsetup.mk?
476 {"TARGET_COPY_OUT_SYSTEM", "system"},
477 {"TARGET_COPY_OUT_SYSTEM_OTHER", "system_other"},
478 {"TARGET_COPY_OUT_DATA", "data"},
479 {"TARGET_COPY_OUT_ASAN", filepath.Join("data", "asan")},
480 {"TARGET_COPY_OUT_OEM", "oem"},
481 {"TARGET_COPY_OUT_RAMDISK", "ramdisk"},
482 {"TARGET_COPY_OUT_DEBUG_RAMDISK", "debug_ramdisk"},
483 {"TARGET_COPY_OUT_VENDOR_DEBUG_RAMDISK", "vendor_debug_ramdisk"},
484 {"TARGET_COPY_OUT_TEST_HARNESS_RAMDISK", "test_harness_ramdisk"},
485 {"TARGET_COPY_OUT_ROOT", "root"},
486 {"TARGET_COPY_OUT_RECOVERY", "recovery"},
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800487 {"TARGET_COPY_OUT_VENDOR_RAMDISK", "vendor_ramdisk"},
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800488 // TODO(asmundak): to process internal config files, we need the following variables:
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800489 // TARGET_VENDOR
490 // target_base_product
491 //
492
493 // the following utility variables are set in build/make/common/core.mk:
494 {"empty", ""},
495 {"space", " "},
496 {"comma", ","},
497 {"newline", "\n"},
498 {"pound", "#"},
499 {"backslash", "\\"},
500 }
501 ctx := &parseContext{
502 script: ss,
503 nodes: nodes,
504 currentNodeIndex: 0,
505 ifNestLevel: 0,
506 moduleNameCount: make(map[string]int),
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800507 variables: make(map[string]variable),
Sasha Smundak6609ba72021-07-22 18:32:56 -0700508 dependentModules: make(map[string]*moduleInfo),
Sasha Smundak3deb9682021-07-26 18:42:25 -0700509 soongNamespaces: make(map[string]map[string]bool),
Cole Faust6c934f62022-01-06 15:51:12 -0800510 includeTops: []string{},
Cole Faustf92c9f22022-03-14 14:35:50 -0700511 typeHints: make(map[string]starlarkType),
512 atTopOfMakefile: true,
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800513 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800514 for _, item := range predefined {
515 ctx.variables[item.name] = &predefinedVariable{
516 baseVariable: baseVariable{nam: item.name, typ: starlarkTypeString},
517 value: &stringLiteralExpr{item.value},
518 }
519 }
520
521 return ctx
522}
523
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800524func (ctx *parseContext) hasNodes() bool {
525 return ctx.currentNodeIndex < len(ctx.nodes)
526}
527
528func (ctx *parseContext) getNode() mkparser.Node {
529 if !ctx.hasNodes() {
530 return nil
531 }
532 node := ctx.nodes[ctx.currentNodeIndex]
533 ctx.currentNodeIndex++
534 return node
535}
536
537func (ctx *parseContext) backNode() {
538 if ctx.currentNodeIndex <= 0 {
539 panic("Cannot back off")
540 }
541 ctx.currentNodeIndex--
542}
543
Cole Faustdd569ae2022-01-31 15:48:29 -0800544func (ctx *parseContext) handleAssignment(a *mkparser.Assignment) []starlarkNode {
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800545 // Handle only simple variables
Cole Faust00afd4f2022-04-26 14:01:56 -0700546 if !a.Name.Const() || a.Target != nil {
Cole Faustdd569ae2022-01-31 15:48:29 -0800547 return []starlarkNode{ctx.newBadNode(a, "Only simple variables are handled")}
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800548 }
549 name := a.Name.Strings[0]
Sasha Smundakea3bc3a2021-11-10 13:06:42 -0800550 // The `override` directive
551 // override FOO :=
552 // is parsed as an assignment to a variable named `override FOO`.
553 // There are very few places where `override` is used, just flag it.
554 if strings.HasPrefix(name, "override ") {
Cole Faustdd569ae2022-01-31 15:48:29 -0800555 return []starlarkNode{ctx.newBadNode(a, "cannot handle override directive")}
Sasha Smundakea3bc3a2021-11-10 13:06:42 -0800556 }
Cole Faust5d5fcc32022-04-26 18:02:05 -0700557 if name == ".KATI_READONLY" {
558 // Skip assignments to .KATI_READONLY. If it was in the output file, it
559 // would be an error because it would be sorted before the definition of
560 // the variable it's trying to make readonly.
561 return []starlarkNode{}
562 }
Sasha Smundakea3bc3a2021-11-10 13:06:42 -0800563
Cole Faustc00184e2021-11-08 12:08:57 -0800564 // Soong configuration
Sasha Smundak3deb9682021-07-26 18:42:25 -0700565 if strings.HasPrefix(name, soongNsPrefix) {
Cole Faustdd569ae2022-01-31 15:48:29 -0800566 return ctx.handleSoongNsAssignment(strings.TrimPrefix(name, soongNsPrefix), a)
Sasha Smundak3deb9682021-07-26 18:42:25 -0700567 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800568 lhs := ctx.addVariable(name)
569 if lhs == nil {
Cole Faustdd569ae2022-01-31 15:48:29 -0800570 return []starlarkNode{ctx.newBadNode(a, "unknown variable %s", name)}
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800571 }
Cole Faust3c4fc992022-02-28 16:05:01 -0800572 _, isTraced := ctx.tracedVariables[lhs.name()]
Sasha Smundak422b6142021-11-11 18:31:59 -0800573 asgn := &assignmentNode{lhs: lhs, mkValue: a.Value, isTraced: isTraced, location: ctx.errorLocation(a)}
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800574 if lhs.valueType() == starlarkTypeUnknown {
575 // Try to divine variable type from the RHS
576 asgn.value = ctx.parseMakeString(a, a.Value)
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800577 inferred_type := asgn.value.typ()
578 if inferred_type != starlarkTypeUnknown {
Sasha Smundak9d011ab2021-07-09 16:00:57 -0700579 lhs.setValueType(inferred_type)
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800580 }
581 }
582 if lhs.valueType() == starlarkTypeList {
Cole Faustdd569ae2022-01-31 15:48:29 -0800583 xConcat, xBad := ctx.buildConcatExpr(a)
584 if xBad != nil {
Cole Faust1e275862022-04-26 14:28:04 -0700585 asgn.value = xBad
586 } else {
587 switch len(xConcat.items) {
588 case 0:
589 asgn.value = &listExpr{}
590 case 1:
591 asgn.value = xConcat.items[0]
592 default:
593 asgn.value = xConcat
594 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800595 }
596 } else {
597 asgn.value = ctx.parseMakeString(a, a.Value)
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800598 }
599
Cole Faust421a1922022-03-16 14:35:45 -0700600 if asgn.lhs.valueType() == starlarkTypeString &&
601 asgn.value.typ() != starlarkTypeUnknown &&
602 asgn.value.typ() != starlarkTypeString {
603 asgn.value = &toStringExpr{expr: asgn.value}
604 }
605
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800606 switch a.Type {
607 case "=", ":=":
608 asgn.flavor = asgnSet
609 case "+=":
Cole Fauste2a37982022-03-09 16:00:17 -0800610 asgn.flavor = asgnAppend
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800611 case "?=":
612 asgn.flavor = asgnMaybeSet
613 default:
614 panic(fmt.Errorf("unexpected assignment type %s", a.Type))
615 }
616
Cole Faustdd569ae2022-01-31 15:48:29 -0800617 return []starlarkNode{asgn}
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800618}
619
Cole Faustdd569ae2022-01-31 15:48:29 -0800620func (ctx *parseContext) handleSoongNsAssignment(name string, asgn *mkparser.Assignment) []starlarkNode {
Sasha Smundak3deb9682021-07-26 18:42:25 -0700621 val := ctx.parseMakeString(asgn, asgn.Value)
622 if xBad, ok := val.(*badExpr); ok {
Cole Faustdd569ae2022-01-31 15:48:29 -0800623 return []starlarkNode{&exprNode{expr: xBad}}
Sasha Smundak3deb9682021-07-26 18:42:25 -0700624 }
Sasha Smundak3deb9682021-07-26 18:42:25 -0700625
626 // Unfortunately, Soong namespaces can be set up by directly setting corresponding Make
627 // variables instead of via add_soong_config_namespace + add_soong_config_var_value.
628 // Try to divine the call from the assignment as follows:
629 if name == "NAMESPACES" {
630 // Upon seeng
631 // SOONG_CONFIG_NAMESPACES += foo
632 // remember that there is a namespace `foo` and act as we saw
633 // $(call add_soong_config_namespace,foo)
634 s, ok := maybeString(val)
635 if !ok {
Cole Faustdd569ae2022-01-31 15:48:29 -0800636 return []starlarkNode{ctx.newBadNode(asgn, "cannot handle variables in SOONG_CONFIG_NAMESPACES assignment, please use add_soong_config_namespace instead")}
Sasha Smundak3deb9682021-07-26 18:42:25 -0700637 }
Cole Faustdd569ae2022-01-31 15:48:29 -0800638 result := make([]starlarkNode, 0)
Sasha Smundak3deb9682021-07-26 18:42:25 -0700639 for _, ns := range strings.Fields(s) {
640 ctx.addSoongNamespace(ns)
Cole Faustdd569ae2022-01-31 15:48:29 -0800641 result = append(result, &exprNode{&callExpr{
Cole Faust9ebf6e42021-12-13 14:08:34 -0800642 name: baseName + ".soong_config_namespace",
643 args: []starlarkExpr{&globalsExpr{}, &stringLiteralExpr{ns}},
Sasha Smundak3deb9682021-07-26 18:42:25 -0700644 returnType: starlarkTypeVoid,
645 }})
646 }
Cole Faustdd569ae2022-01-31 15:48:29 -0800647 return result
Sasha Smundak3deb9682021-07-26 18:42:25 -0700648 } else {
649 // Upon seeing
650 // SOONG_CONFIG_x_y = v
651 // find a namespace called `x` and act as if we encountered
Cole Faustc00184e2021-11-08 12:08:57 -0800652 // $(call soong_config_set,x,y,v)
Sasha Smundak3deb9682021-07-26 18:42:25 -0700653 // or check that `x_y` is a namespace, and then add the RHS of this assignment as variables in
654 // it.
655 // Emit an error in the ambiguous situation (namespaces `foo_bar` with a variable `baz`
656 // and `foo` with a variable `bar_baz`.
657 namespaceName := ""
658 if ctx.hasSoongNamespace(name) {
659 namespaceName = name
660 }
661 var varName string
662 for pos, ch := range name {
663 if !(ch == '_' && ctx.hasSoongNamespace(name[0:pos])) {
664 continue
665 }
666 if namespaceName != "" {
Cole Faustdd569ae2022-01-31 15:48:29 -0800667 return []starlarkNode{ctx.newBadNode(asgn, "ambiguous soong namespace (may be either `%s` or `%s`)", namespaceName, name[0:pos])}
Sasha Smundak3deb9682021-07-26 18:42:25 -0700668 }
669 namespaceName = name[0:pos]
670 varName = name[pos+1:]
671 }
672 if namespaceName == "" {
Cole Faustdd569ae2022-01-31 15:48:29 -0800673 return []starlarkNode{ctx.newBadNode(asgn, "cannot figure out Soong namespace, please use add_soong_config_var_value macro instead")}
Sasha Smundak3deb9682021-07-26 18:42:25 -0700674 }
675 if varName == "" {
676 // Remember variables in this namespace
677 s, ok := maybeString(val)
678 if !ok {
Cole Faustdd569ae2022-01-31 15:48:29 -0800679 return []starlarkNode{ctx.newBadNode(asgn, "cannot handle variables in SOONG_CONFIG_ assignment, please use add_soong_config_var_value instead")}
Sasha Smundak3deb9682021-07-26 18:42:25 -0700680 }
681 ctx.updateSoongNamespace(asgn.Type != "+=", namespaceName, strings.Fields(s))
Cole Faustdd569ae2022-01-31 15:48:29 -0800682 return []starlarkNode{}
Sasha Smundak3deb9682021-07-26 18:42:25 -0700683 }
684
685 // Finally, handle assignment to a namespace variable
686 if !ctx.hasNamespaceVar(namespaceName, varName) {
Cole Faustdd569ae2022-01-31 15:48:29 -0800687 return []starlarkNode{ctx.newBadNode(asgn, "no %s variable in %s namespace, please use add_soong_config_var_value instead", varName, namespaceName)}
Sasha Smundak3deb9682021-07-26 18:42:25 -0700688 }
Cole Faust9ebf6e42021-12-13 14:08:34 -0800689 fname := baseName + "." + soongConfigAssign
Sasha Smundak65b547e2021-09-17 15:35:41 -0700690 if asgn.Type == "+=" {
Cole Faust9ebf6e42021-12-13 14:08:34 -0800691 fname = baseName + "." + soongConfigAppend
Sasha Smundak65b547e2021-09-17 15:35:41 -0700692 }
Cole Faustdd569ae2022-01-31 15:48:29 -0800693 return []starlarkNode{&exprNode{&callExpr{
Sasha Smundak65b547e2021-09-17 15:35:41 -0700694 name: fname,
Cole Faust9ebf6e42021-12-13 14:08:34 -0800695 args: []starlarkExpr{&globalsExpr{}, &stringLiteralExpr{namespaceName}, &stringLiteralExpr{varName}, val},
Sasha Smundak3deb9682021-07-26 18:42:25 -0700696 returnType: starlarkTypeVoid,
Cole Faustdd569ae2022-01-31 15:48:29 -0800697 }}}
Sasha Smundak3deb9682021-07-26 18:42:25 -0700698 }
699}
700
Cole Faustdd569ae2022-01-31 15:48:29 -0800701func (ctx *parseContext) buildConcatExpr(a *mkparser.Assignment) (*concatExpr, *badExpr) {
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800702 xConcat := &concatExpr{}
703 var xItemList *listExpr
704 addToItemList := func(x ...starlarkExpr) {
705 if xItemList == nil {
706 xItemList = &listExpr{[]starlarkExpr{}}
707 }
708 xItemList.items = append(xItemList.items, x...)
709 }
710 finishItemList := func() {
711 if xItemList != nil {
712 xConcat.items = append(xConcat.items, xItemList)
713 xItemList = nil
714 }
715 }
716
717 items := a.Value.Words()
718 for _, item := range items {
719 // A function call in RHS is supposed to return a list, all other item
720 // expressions return individual elements.
721 switch x := ctx.parseMakeString(a, item).(type) {
722 case *badExpr:
Cole Faustdd569ae2022-01-31 15:48:29 -0800723 return nil, x
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800724 case *stringLiteralExpr:
725 addToItemList(maybeConvertToStringList(x).(*listExpr).items...)
726 default:
727 switch x.typ() {
728 case starlarkTypeList:
729 finishItemList()
730 xConcat.items = append(xConcat.items, x)
731 case starlarkTypeString:
732 finishItemList()
733 xConcat.items = append(xConcat.items, &callExpr{
734 object: x,
735 name: "split",
736 args: nil,
737 returnType: starlarkTypeList,
738 })
739 default:
740 addToItemList(x)
741 }
742 }
743 }
744 if xItemList != nil {
745 xConcat.items = append(xConcat.items, xItemList)
746 }
Cole Faustdd569ae2022-01-31 15:48:29 -0800747 return xConcat, nil
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800748}
749
Sasha Smundak6609ba72021-07-22 18:32:56 -0700750func (ctx *parseContext) newDependentModule(path string, optional bool) *moduleInfo {
751 modulePath := ctx.loadedModulePath(path)
752 if mi, ok := ctx.dependentModules[modulePath]; ok {
Sasha Smundak868c5e32021-09-23 16:20:58 -0700753 mi.optional = mi.optional && optional
Sasha Smundak6609ba72021-07-22 18:32:56 -0700754 return mi
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800755 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800756 moduleName := moduleNameForFile(path)
757 moduleLocalName := "_" + moduleName
758 n, found := ctx.moduleNameCount[moduleName]
759 if found {
760 moduleLocalName += fmt.Sprintf("%d", n)
761 }
762 ctx.moduleNameCount[moduleName] = n + 1
Sasha Smundak6bc132a2022-01-10 17:02:16 -0800763 _, err := fs.Stat(ctx.script.sourceFS, path)
Sasha Smundak6609ba72021-07-22 18:32:56 -0700764 mi := &moduleInfo{
765 path: modulePath,
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800766 originalPath: path,
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800767 moduleLocalName: moduleLocalName,
Sasha Smundak6609ba72021-07-22 18:32:56 -0700768 optional: optional,
Sasha Smundak6bc132a2022-01-10 17:02:16 -0800769 missing: err != nil,
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800770 }
Sasha Smundak6609ba72021-07-22 18:32:56 -0700771 ctx.dependentModules[modulePath] = mi
772 ctx.script.inherited = append(ctx.script.inherited, mi)
773 return mi
774}
775
776func (ctx *parseContext) handleSubConfig(
Cole Faustdd569ae2022-01-31 15:48:29 -0800777 v mkparser.Node, pathExpr starlarkExpr, loadAlways bool, processModule func(inheritedModule) starlarkNode) []starlarkNode {
Sasha Smundak6609ba72021-07-22 18:32:56 -0700778
Cole Faust62e05112022-04-05 17:56:11 -0700779 // Allow seeing $(sort $(wildcard realPathExpr)) or $(wildcard realPathExpr)
780 // because those are functionally the same as not having the sort/wildcard calls.
781 if ce, ok := pathExpr.(*callExpr); ok && ce.name == "rblf.mksort" && len(ce.args) == 1 {
782 if ce2, ok2 := ce.args[0].(*callExpr); ok2 && ce2.name == "rblf.expand_wildcard" && len(ce2.args) == 1 {
783 pathExpr = ce2.args[0]
784 }
785 } else if ce2, ok2 := pathExpr.(*callExpr); ok2 && ce2.name == "rblf.expand_wildcard" && len(ce2.args) == 1 {
786 pathExpr = ce2.args[0]
787 }
788
Sasha Smundak6609ba72021-07-22 18:32:56 -0700789 // In a simple case, the name of a module to inherit/include is known statically.
790 if path, ok := maybeString(pathExpr); ok {
Sasha Smundak868c5e32021-09-23 16:20:58 -0700791 // Note that even if this directive loads a module unconditionally, a module may be
792 // absent without causing any harm if this directive is inside an if/else block.
793 moduleShouldExist := loadAlways && ctx.ifNestLevel == 0
Sasha Smundak6609ba72021-07-22 18:32:56 -0700794 if strings.Contains(path, "*") {
795 if paths, err := fs.Glob(ctx.script.sourceFS, path); err == nil {
Cole Faust62e05112022-04-05 17:56:11 -0700796 sort.Strings(paths)
Cole Faustdd569ae2022-01-31 15:48:29 -0800797 result := make([]starlarkNode, 0)
Sasha Smundak6609ba72021-07-22 18:32:56 -0700798 for _, p := range paths {
Sasha Smundak868c5e32021-09-23 16:20:58 -0700799 mi := ctx.newDependentModule(p, !moduleShouldExist)
Cole Faustdd569ae2022-01-31 15:48:29 -0800800 result = append(result, processModule(inheritedStaticModule{mi, loadAlways}))
Sasha Smundak6609ba72021-07-22 18:32:56 -0700801 }
Cole Faustdd569ae2022-01-31 15:48:29 -0800802 return result
Sasha Smundak6609ba72021-07-22 18:32:56 -0700803 } else {
Cole Faustdd569ae2022-01-31 15:48:29 -0800804 return []starlarkNode{ctx.newBadNode(v, "cannot glob wildcard argument")}
Sasha Smundak6609ba72021-07-22 18:32:56 -0700805 }
806 } else {
Sasha Smundak868c5e32021-09-23 16:20:58 -0700807 mi := ctx.newDependentModule(path, !moduleShouldExist)
Cole Faustdd569ae2022-01-31 15:48:29 -0800808 return []starlarkNode{processModule(inheritedStaticModule{mi, loadAlways})}
Sasha Smundak6609ba72021-07-22 18:32:56 -0700809 }
Sasha Smundak6609ba72021-07-22 18:32:56 -0700810 }
811
812 // If module path references variables (e.g., $(v1)/foo/$(v2)/device-config.mk), find all the paths in the
813 // source tree that may be a match and the corresponding variable values. For instance, if the source tree
814 // contains vendor1/foo/abc/dev.mk and vendor2/foo/def/dev.mk, the first one will be inherited when
815 // (v1, v2) == ('vendor1', 'abc'), and the second one when (v1, v2) == ('vendor2', 'def').
816 // We then emit the code that loads all of them, e.g.:
817 // load("//vendor1/foo/abc:dev.rbc", _dev1_init="init")
818 // load("//vendor2/foo/def/dev.rbc", _dev2_init="init")
819 // And then inherit it as follows:
820 // _e = {
821 // "vendor1/foo/abc/dev.mk": ("vendor1/foo/abc/dev", _dev1_init),
822 // "vendor2/foo/def/dev.mk": ("vendor2/foo/def/dev", _dev_init2) }.get("%s/foo/%s/dev.mk" % (v1, v2))
823 // if _e:
824 // rblf.inherit(handle, _e[0], _e[1])
825 //
826 var matchingPaths []string
Cole Faust9df1d732022-04-26 16:27:22 -0700827 var needsWarning = false
828 if interpolate, ok := pathExpr.(*interpolateExpr); ok {
829 pathPattern := []string{interpolate.chunks[0]}
830 for _, chunk := range interpolate.chunks[1:] {
831 if chunk != "" {
832 pathPattern = append(pathPattern, chunk)
833 }
834 }
Cole Faust74ac0272022-06-14 12:45:26 -0700835 if len(pathPattern) == 1 {
836 pathPattern = append(pathPattern, "")
Cole Faust9df1d732022-04-26 16:27:22 -0700837 }
Cole Faust74ac0272022-06-14 12:45:26 -0700838 matchingPaths = ctx.findMatchingPaths(pathPattern)
Cole Faust9df1d732022-04-26 16:27:22 -0700839 needsWarning = pathPattern[0] == "" && len(ctx.includeTops) == 0
840 } else if len(ctx.includeTops) > 0 {
Cole Faust74ac0272022-06-14 12:45:26 -0700841 matchingPaths = append(matchingPaths, ctx.findMatchingPaths([]string{"", ""})...)
Cole Faust9df1d732022-04-26 16:27:22 -0700842 } else {
Cole Faustdd569ae2022-01-31 15:48:29 -0800843 return []starlarkNode{ctx.newBadNode(v, "inherit-product/include argument is too complex")}
Sasha Smundak6609ba72021-07-22 18:32:56 -0700844 }
845
Sasha Smundak6609ba72021-07-22 18:32:56 -0700846 // Safeguard against $(call inherit-product,$(PRODUCT_PATH))
Sasha Smundak90be8c52021-08-03 11:06:10 -0700847 const maxMatchingFiles = 150
Sasha Smundak6609ba72021-07-22 18:32:56 -0700848 if len(matchingPaths) > maxMatchingFiles {
Cole Faustdd569ae2022-01-31 15:48:29 -0800849 return []starlarkNode{ctx.newBadNode(v, "there are >%d files matching the pattern, please rewrite it", maxMatchingFiles)}
Sasha Smundak6609ba72021-07-22 18:32:56 -0700850 }
Cole Faust93f8d392022-03-02 13:31:30 -0800851
Cole Faust9df1d732022-04-26 16:27:22 -0700852 res := inheritedDynamicModule{pathExpr, []*moduleInfo{}, loadAlways, ctx.errorLocation(v), needsWarning}
Cole Faust93f8d392022-03-02 13:31:30 -0800853 for _, p := range matchingPaths {
854 // A product configuration files discovered dynamically may attempt to inherit
855 // from another one which does not exist in this source tree. Prevent load errors
856 // by always loading the dynamic files as optional.
857 res.candidateModules = append(res.candidateModules, ctx.newDependentModule(p, true))
Sasha Smundak6609ba72021-07-22 18:32:56 -0700858 }
Cole Faust93f8d392022-03-02 13:31:30 -0800859 return []starlarkNode{processModule(res)}
Sasha Smundak6609ba72021-07-22 18:32:56 -0700860}
861
862func (ctx *parseContext) findMatchingPaths(pattern []string) []string {
Cole Faust9b6111a2022-02-02 15:38:33 -0800863 files := ctx.script.makefileFinder.Find(".")
Sasha Smundak6609ba72021-07-22 18:32:56 -0700864 if len(pattern) == 0 {
865 return files
866 }
867
868 // Create regular expression from the pattern
Cole Faust74ac0272022-06-14 12:45:26 -0700869 regexString := "^" + regexp.QuoteMeta(pattern[0])
Sasha Smundak6609ba72021-07-22 18:32:56 -0700870 for _, s := range pattern[1:] {
Cole Faust74ac0272022-06-14 12:45:26 -0700871 regexString += ".*" + regexp.QuoteMeta(s)
Sasha Smundak6609ba72021-07-22 18:32:56 -0700872 }
Cole Faust74ac0272022-06-14 12:45:26 -0700873 regexString += "$"
874 rex := regexp.MustCompile(regexString)
875
876 includeTopRegexString := ""
877 if len(ctx.includeTops) > 0 {
878 for i, top := range ctx.includeTops {
879 if i > 0 {
880 includeTopRegexString += "|"
881 }
882 includeTopRegexString += "^" + regexp.QuoteMeta(top)
883 }
884 } else {
885 includeTopRegexString = ".*"
886 }
887
888 includeTopRegex := regexp.MustCompile(includeTopRegexString)
Sasha Smundak6609ba72021-07-22 18:32:56 -0700889
890 // Now match
891 var res []string
892 for _, p := range files {
Cole Faust74ac0272022-06-14 12:45:26 -0700893 if rex.MatchString(p) && includeTopRegex.MatchString(p) {
Sasha Smundak6609ba72021-07-22 18:32:56 -0700894 res = append(res, p)
895 }
896 }
897 return res
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800898}
899
Cole Faustf035d402022-03-28 14:02:50 -0700900type inheritProductCallParser struct {
901 loadAlways bool
902}
903
904func (p *inheritProductCallParser) parse(ctx *parseContext, v mkparser.Node, args *mkparser.MakeString) []starlarkNode {
Cole Faust9ebf6e42021-12-13 14:08:34 -0800905 args.TrimLeftSpaces()
906 args.TrimRightSpaces()
907 pathExpr := ctx.parseMakeString(v, args)
908 if _, ok := pathExpr.(*badExpr); ok {
Cole Faustdd569ae2022-01-31 15:48:29 -0800909 return []starlarkNode{ctx.newBadNode(v, "Unable to parse argument to inherit")}
Cole Faust9ebf6e42021-12-13 14:08:34 -0800910 }
Cole Faustf035d402022-03-28 14:02:50 -0700911 return ctx.handleSubConfig(v, pathExpr, p.loadAlways, func(im inheritedModule) starlarkNode {
912 return &inheritNode{im, p.loadAlways}
Sasha Smundak6609ba72021-07-22 18:32:56 -0700913 })
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800914}
915
Cole Faust20052982022-04-22 14:43:55 -0700916func (ctx *parseContext) handleInclude(v *mkparser.Directive) []starlarkNode {
917 loadAlways := v.Name[0] != '-'
918 return ctx.handleSubConfig(v, ctx.parseMakeString(v, v.Args), loadAlways, func(im inheritedModule) starlarkNode {
Cole Faustdd569ae2022-01-31 15:48:29 -0800919 return &includeNode{im, loadAlways}
Sasha Smundak6609ba72021-07-22 18:32:56 -0700920 })
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800921}
922
Cole Faustdd569ae2022-01-31 15:48:29 -0800923func (ctx *parseContext) handleVariable(v *mkparser.Variable) []starlarkNode {
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800924 // Handle:
925 // $(call inherit-product,...)
926 // $(call inherit-product-if-exists,...)
927 // $(info xxx)
928 // $(warning xxx)
929 // $(error xxx)
Cole Faust9ebf6e42021-12-13 14:08:34 -0800930 // $(call other-custom-functions,...)
931
Cole Faustf035d402022-03-28 14:02:50 -0700932 if name, args, ok := ctx.maybeParseFunctionCall(v, v.Name); ok {
933 if kf, ok := knownNodeFunctions[name]; ok {
934 return kf.parse(ctx, v, args)
935 }
Cole Faust9ebf6e42021-12-13 14:08:34 -0800936 }
Cole Faustf035d402022-03-28 14:02:50 -0700937
Cole Faustdd569ae2022-01-31 15:48:29 -0800938 return []starlarkNode{&exprNode{expr: ctx.parseReference(v, v.Name)}}
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800939}
940
Cole Faustdd569ae2022-01-31 15:48:29 -0800941func (ctx *parseContext) maybeHandleDefine(directive *mkparser.Directive) starlarkNode {
Sasha Smundakf3e072a2021-07-14 12:50:28 -0700942 macro_name := strings.Fields(directive.Args.Strings[0])[0]
943 // Ignore the macros that we handle
Cole Faust9ebf6e42021-12-13 14:08:34 -0800944 _, ignored := ignoredDefines[macro_name]
945 _, known := knownFunctions[macro_name]
946 if !ignored && !known {
Cole Faustdd569ae2022-01-31 15:48:29 -0800947 return ctx.newBadNode(directive, "define is not supported: %s", macro_name)
Sasha Smundakf3e072a2021-07-14 12:50:28 -0700948 }
Cole Faustdd569ae2022-01-31 15:48:29 -0800949 return nil
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800950}
951
Cole Faustdd569ae2022-01-31 15:48:29 -0800952func (ctx *parseContext) handleIfBlock(ifDirective *mkparser.Directive) starlarkNode {
953 ssSwitch := &switchNode{
954 ssCases: []*switchCase{ctx.processBranch(ifDirective)},
955 }
956 for ctx.hasNodes() && ctx.fatalError == nil {
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800957 node := ctx.getNode()
958 switch x := node.(type) {
959 case *mkparser.Directive:
960 switch x.Name {
961 case "else", "elifdef", "elifndef", "elifeq", "elifneq":
Cole Faustdd569ae2022-01-31 15:48:29 -0800962 ssSwitch.ssCases = append(ssSwitch.ssCases, ctx.processBranch(x))
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800963 case "endif":
Cole Faustdd569ae2022-01-31 15:48:29 -0800964 return ssSwitch
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800965 default:
Cole Faustdd569ae2022-01-31 15:48:29 -0800966 return ctx.newBadNode(node, "unexpected directive %s", x.Name)
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800967 }
968 default:
Cole Faustdd569ae2022-01-31 15:48:29 -0800969 return ctx.newBadNode(ifDirective, "unexpected statement")
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800970 }
971 }
972 if ctx.fatalError == nil {
973 ctx.fatalError = fmt.Errorf("no matching endif for %s", ifDirective.Dump())
974 }
Cole Faustdd569ae2022-01-31 15:48:29 -0800975 return ctx.newBadNode(ifDirective, "no matching endif for %s", ifDirective.Dump())
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800976}
977
978// processBranch processes a single branch (if/elseif/else) until the next directive
979// on the same level.
Cole Faustdd569ae2022-01-31 15:48:29 -0800980func (ctx *parseContext) processBranch(check *mkparser.Directive) *switchCase {
981 block := &switchCase{gate: ctx.parseCondition(check)}
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800982 defer func() {
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800983 ctx.ifNestLevel--
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800984 }()
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800985 ctx.ifNestLevel++
986
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800987 for ctx.hasNodes() {
988 node := ctx.getNode()
Cole Faust591a1fe2021-11-08 15:37:57 -0800989 if d, ok := node.(*mkparser.Directive); ok {
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800990 switch d.Name {
991 case "else", "elifdef", "elifndef", "elifeq", "elifneq", "endif":
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800992 ctx.backNode()
Cole Faustdd569ae2022-01-31 15:48:29 -0800993 return block
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800994 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800995 }
Cole Faustdd569ae2022-01-31 15:48:29 -0800996 block.nodes = append(block.nodes, ctx.handleSimpleStatement(node)...)
Sasha Smundakb051c4e2020-11-05 20:45:07 -0800997 }
998 ctx.fatalError = fmt.Errorf("no matching endif for %s", check.Dump())
Cole Faustdd569ae2022-01-31 15:48:29 -0800999 return block
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001000}
1001
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001002func (ctx *parseContext) parseCondition(check *mkparser.Directive) starlarkNode {
1003 switch check.Name {
1004 case "ifdef", "ifndef", "elifdef", "elifndef":
Cole Faust71514c02022-01-27 17:21:41 -08001005 if !check.Args.Const() {
Cole Faustdd569ae2022-01-31 15:48:29 -08001006 return ctx.newBadNode(check, "ifdef variable ref too complex: %s", check.Args.Dump())
Cole Faust71514c02022-01-27 17:21:41 -08001007 }
Cole Faustf0632662022-04-07 13:59:24 -07001008 v := NewVariableRefExpr(ctx.addVariable(check.Args.Strings[0]))
Cole Faust71514c02022-01-27 17:21:41 -08001009 if strings.HasSuffix(check.Name, "ndef") {
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001010 v = &notExpr{v}
1011 }
1012 return &ifNode{
1013 isElif: strings.HasPrefix(check.Name, "elif"),
1014 expr: v,
1015 }
1016 case "ifeq", "ifneq", "elifeq", "elifneq":
1017 return &ifNode{
1018 isElif: strings.HasPrefix(check.Name, "elif"),
1019 expr: ctx.parseCompare(check),
1020 }
1021 case "else":
1022 return &elseNode{}
1023 default:
1024 panic(fmt.Errorf("%s: unknown directive: %s", ctx.script.mkFile, check.Dump()))
1025 }
1026}
1027
1028func (ctx *parseContext) newBadExpr(node mkparser.Node, text string, args ...interface{}) starlarkExpr {
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001029 if ctx.errorLogger != nil {
Sasha Smundak422b6142021-11-11 18:31:59 -08001030 ctx.errorLogger.NewError(ctx.errorLocation(node), node, text, args...)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001031 }
1032 ctx.script.hasErrors = true
Cole Faustdd569ae2022-01-31 15:48:29 -08001033 return &badExpr{errorLocation: ctx.errorLocation(node), message: fmt.Sprintf(text, args...)}
1034}
1035
1036// records that the given node failed to be converted and includes an explanatory message
1037func (ctx *parseContext) newBadNode(failedNode mkparser.Node, message string, args ...interface{}) starlarkNode {
1038 return &exprNode{ctx.newBadExpr(failedNode, message, args...)}
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001039}
1040
1041func (ctx *parseContext) parseCompare(cond *mkparser.Directive) starlarkExpr {
1042 // Strip outer parentheses
1043 mkArg := cloneMakeString(cond.Args)
1044 mkArg.Strings[0] = strings.TrimLeft(mkArg.Strings[0], "( ")
1045 n := len(mkArg.Strings)
1046 mkArg.Strings[n-1] = strings.TrimRight(mkArg.Strings[n-1], ") ")
1047 args := mkArg.Split(",")
1048 // TODO(asmundak): handle the case where the arguments are in quotes and space-separated
1049 if len(args) != 2 {
1050 return ctx.newBadExpr(cond, "ifeq/ifneq len(args) != 2 %s", cond.Dump())
1051 }
1052 args[0].TrimRightSpaces()
1053 args[1].TrimLeftSpaces()
1054
1055 isEq := !strings.HasSuffix(cond.Name, "neq")
Cole Faustf8320212021-11-10 15:05:07 -08001056 xLeft := ctx.parseMakeString(cond, args[0])
1057 xRight := ctx.parseMakeString(cond, args[1])
1058 if bad, ok := xLeft.(*badExpr); ok {
1059 return bad
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001060 }
Cole Faustf8320212021-11-10 15:05:07 -08001061 if bad, ok := xRight.(*badExpr); ok {
1062 return bad
1063 }
1064
1065 if expr, ok := ctx.parseCompareSpecialCases(cond, xLeft, xRight); ok {
1066 return expr
1067 }
1068
Cole Faust9ebf6e42021-12-13 14:08:34 -08001069 var stringOperand string
1070 var otherOperand starlarkExpr
1071 if s, ok := maybeString(xLeft); ok {
1072 stringOperand = s
1073 otherOperand = xRight
1074 } else if s, ok := maybeString(xRight); ok {
1075 stringOperand = s
1076 otherOperand = xLeft
1077 }
1078
Cole Faust9ebf6e42021-12-13 14:08:34 -08001079 // If we've identified one of the operands as being a string literal, check
1080 // for some special cases we can do to simplify the resulting expression.
1081 if otherOperand != nil {
1082 if stringOperand == "" {
1083 if isEq {
Cole Faustf035d402022-03-28 14:02:50 -07001084 return negateExpr(otherOperand)
Cole Faust9ebf6e42021-12-13 14:08:34 -08001085 } else {
1086 return otherOperand
1087 }
1088 }
1089 if stringOperand == "true" && otherOperand.typ() == starlarkTypeBool {
1090 if !isEq {
Cole Faustf035d402022-03-28 14:02:50 -07001091 return negateExpr(otherOperand)
Cole Faust9ebf6e42021-12-13 14:08:34 -08001092 } else {
1093 return otherOperand
1094 }
1095 }
Cole Fausta99afdf2022-04-26 12:06:49 -07001096 if otherOperand.typ() == starlarkTypeList {
1097 fields := strings.Fields(stringOperand)
1098 elements := make([]starlarkExpr, len(fields))
1099 for i, s := range fields {
1100 elements[i] = &stringLiteralExpr{literal: s}
1101 }
1102 return &eqExpr{
1103 left: otherOperand,
1104 right: &listExpr{elements},
1105 isEq: isEq,
1106 }
1107 }
Cole Faustb1103e22022-01-06 15:22:05 -08001108 if intOperand, err := strconv.Atoi(strings.TrimSpace(stringOperand)); err == nil && otherOperand.typ() == starlarkTypeInt {
1109 return &eqExpr{
1110 left: otherOperand,
1111 right: &intLiteralExpr{literal: intOperand},
1112 isEq: isEq,
1113 }
1114 }
Cole Faust9ebf6e42021-12-13 14:08:34 -08001115 }
1116
Cole Faustf8320212021-11-10 15:05:07 -08001117 return &eqExpr{left: xLeft, right: xRight, isEq: isEq}
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001118}
1119
Cole Faustf8320212021-11-10 15:05:07 -08001120// Given an if statement's directive and the left/right starlarkExprs,
1121// check if the starlarkExprs are one of a few hardcoded special cases
Cole Faust9932f752022-02-08 11:56:25 -08001122// that can be converted to a simpler equality expression than simply comparing
Cole Faustf8320212021-11-10 15:05:07 -08001123// the two.
1124func (ctx *parseContext) parseCompareSpecialCases(directive *mkparser.Directive, left starlarkExpr,
1125 right starlarkExpr) (starlarkExpr, bool) {
1126 isEq := !strings.HasSuffix(directive.Name, "neq")
1127
1128 // All the special cases require a call on one side and a
1129 // string literal/variable on the other. Turn the left/right variables into
1130 // call/value variables, and return false if that's not possible.
1131 var value starlarkExpr = nil
1132 call, ok := left.(*callExpr)
1133 if ok {
1134 switch right.(type) {
1135 case *stringLiteralExpr, *variableRefExpr:
1136 value = right
1137 }
1138 } else {
1139 call, _ = right.(*callExpr)
1140 switch left.(type) {
1141 case *stringLiteralExpr, *variableRefExpr:
1142 value = left
1143 }
1144 }
1145
1146 if call == nil || value == nil {
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001147 return nil, false
1148 }
Cole Faustf8320212021-11-10 15:05:07 -08001149
Cole Faustf8320212021-11-10 15:05:07 -08001150 switch call.name {
Cole Faust9932f752022-02-08 11:56:25 -08001151 case baseName + ".filter":
1152 return ctx.parseCompareFilterFuncResult(directive, call, value, isEq)
Cole Faust9ebf6e42021-12-13 14:08:34 -08001153 case baseName + ".findstring":
Cole Faustf8320212021-11-10 15:05:07 -08001154 return ctx.parseCheckFindstringFuncResult(directive, call, value, !isEq), true
Cole Faust9ebf6e42021-12-13 14:08:34 -08001155 case baseName + ".strip":
Cole Faustf8320212021-11-10 15:05:07 -08001156 return ctx.parseCompareStripFuncResult(directive, call, value, !isEq), true
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001157 }
Cole Faustf8320212021-11-10 15:05:07 -08001158 return nil, false
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001159}
1160
1161func (ctx *parseContext) parseCompareFilterFuncResult(cond *mkparser.Directive,
Cole Faust9932f752022-02-08 11:56:25 -08001162 filterFuncCall *callExpr, xValue starlarkExpr, negate bool) (starlarkExpr, bool) {
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001163 // We handle:
Sasha Smundak0554d762021-07-08 18:26:12 -07001164 // * ifeq/ifneq (,$(filter v1 v2 ..., EXPR) becomes if EXPR not in/in ["v1", "v2", ...]
1165 // * ifeq/ifneq (,$(filter EXPR, v1 v2 ...) becomes if EXPR not in/in ["v1", "v2", ...]
Cole Faust9932f752022-02-08 11:56:25 -08001166 if x, ok := xValue.(*stringLiteralExpr); !ok || x.literal != "" {
1167 return nil, false
1168 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001169 xPattern := filterFuncCall.args[0]
1170 xText := filterFuncCall.args[1]
1171 var xInList *stringLiteralExpr
Sasha Smundak0554d762021-07-08 18:26:12 -07001172 var expr starlarkExpr
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001173 var ok bool
Cole Faust9932f752022-02-08 11:56:25 -08001174 if xInList, ok = xPattern.(*stringLiteralExpr); ok && !strings.ContainsRune(xInList.literal, '%') && xText.typ() == starlarkTypeList {
1175 expr = xText
1176 } else if xInList, ok = xText.(*stringLiteralExpr); ok {
1177 expr = xPattern
1178 } else {
1179 return nil, false
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001180 }
Cole Faust9932f752022-02-08 11:56:25 -08001181 slExpr := newStringListExpr(strings.Fields(xInList.literal))
1182 // Generate simpler code for the common cases:
1183 if expr.typ() == starlarkTypeList {
1184 if len(slExpr.items) == 1 {
1185 // Checking that a string belongs to list
1186 return &inExpr{isNot: negate, list: expr, expr: slExpr.items[0]}, true
Sasha Smundak0554d762021-07-08 18:26:12 -07001187 } else {
Cole Faust9932f752022-02-08 11:56:25 -08001188 return nil, false
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001189 }
Cole Faust9932f752022-02-08 11:56:25 -08001190 } else if len(slExpr.items) == 1 {
1191 return &eqExpr{left: expr, right: slExpr.items[0], isEq: !negate}, true
1192 } else {
1193 return &inExpr{isNot: negate, list: newStringListExpr(strings.Fields(xInList.literal)), expr: expr}, true
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001194 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001195}
1196
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001197func (ctx *parseContext) parseCheckFindstringFuncResult(directive *mkparser.Directive,
1198 xCall *callExpr, xValue starlarkExpr, negate bool) starlarkExpr {
Sasha Smundak0554d762021-07-08 18:26:12 -07001199 if isEmptyString(xValue) {
1200 return &eqExpr{
1201 left: &callExpr{
1202 object: xCall.args[1],
1203 name: "find",
1204 args: []starlarkExpr{xCall.args[0]},
1205 returnType: starlarkTypeInt,
1206 },
1207 right: &intLiteralExpr{-1},
1208 isEq: !negate,
1209 }
Cole Faust0e9418c2021-12-13 16:33:25 -08001210 } else if s, ok := maybeString(xValue); ok {
1211 if s2, ok := maybeString(xCall.args[0]); ok && s == s2 {
1212 return &eqExpr{
1213 left: &callExpr{
1214 object: xCall.args[1],
1215 name: "find",
1216 args: []starlarkExpr{xCall.args[0]},
1217 returnType: starlarkTypeInt,
1218 },
1219 right: &intLiteralExpr{-1},
1220 isEq: negate,
1221 }
1222 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001223 }
Cole Faust0e9418c2021-12-13 16:33:25 -08001224 return ctx.newBadExpr(directive, "$(findstring) can only be compared to nothing or its first argument")
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001225}
1226
1227func (ctx *parseContext) parseCompareStripFuncResult(directive *mkparser.Directive,
1228 xCall *callExpr, xValue starlarkExpr, negate bool) starlarkExpr {
1229 if _, ok := xValue.(*stringLiteralExpr); !ok {
1230 return ctx.newBadExpr(directive, "strip result can be compared only to string: %s", xValue)
1231 }
1232 return &eqExpr{
1233 left: &callExpr{
1234 name: "strip",
1235 args: xCall.args,
1236 returnType: starlarkTypeString,
1237 },
1238 right: xValue, isEq: !negate}
1239}
1240
Cole Faustf035d402022-03-28 14:02:50 -07001241func (ctx *parseContext) maybeParseFunctionCall(node mkparser.Node, ref *mkparser.MakeString) (name string, args *mkparser.MakeString, ok bool) {
1242 ref.TrimLeftSpaces()
1243 ref.TrimRightSpaces()
1244
1245 words := ref.SplitN(" ", 2)
1246 if !words[0].Const() {
1247 return "", nil, false
1248 }
1249
1250 name = words[0].Dump()
1251 args = mkparser.SimpleMakeString("", words[0].Pos())
1252 if len(words) >= 2 {
1253 args = words[1]
1254 }
1255 args.TrimLeftSpaces()
1256 if name == "call" {
1257 words = args.SplitN(",", 2)
1258 if words[0].Empty() || !words[0].Const() {
1259 return "", nil, false
1260 }
1261 name = words[0].Dump()
1262 if len(words) < 2 {
Cole Faust6c41b8a2022-04-13 13:53:48 -07001263 args = mkparser.SimpleMakeString("", words[0].Pos())
Cole Faustf035d402022-03-28 14:02:50 -07001264 } else {
1265 args = words[1]
1266 }
1267 }
1268 ok = true
1269 return
1270}
1271
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001272// parses $(...), returning an expression
1273func (ctx *parseContext) parseReference(node mkparser.Node, ref *mkparser.MakeString) starlarkExpr {
1274 ref.TrimLeftSpaces()
1275 ref.TrimRightSpaces()
1276 refDump := ref.Dump()
1277
1278 // Handle only the case where the first (or only) word is constant
1279 words := ref.SplitN(" ", 2)
1280 if !words[0].Const() {
Cole Faust13238772022-04-28 14:29:57 -07001281 if len(words) == 1 {
1282 expr := ctx.parseMakeString(node, ref)
1283 return &callExpr{
1284 object: &identifierExpr{"cfg"},
1285 name: "get",
1286 args: []starlarkExpr{
1287 expr,
1288 &callExpr{
1289 object: &identifierExpr{"g"},
1290 name: "get",
1291 args: []starlarkExpr{
1292 expr,
1293 &stringLiteralExpr{literal: ""},
1294 },
1295 returnType: starlarkTypeUnknown,
1296 },
1297 },
1298 returnType: starlarkTypeUnknown,
1299 }
1300 } else {
1301 return ctx.newBadExpr(node, "reference is too complex: %s", refDump)
1302 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001303 }
1304
Cole Faust1e275862022-04-26 14:28:04 -07001305 if name, _, ok := ctx.maybeParseFunctionCall(node, ref); ok {
1306 if _, unsupported := unsupportedFunctions[name]; unsupported {
1307 return ctx.newBadExpr(node, "%s is not supported", refDump)
1308 }
1309 }
1310
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001311 // If it is a single word, it can be a simple variable
1312 // reference or a function call
Cole Faustf035d402022-03-28 14:02:50 -07001313 if len(words) == 1 && !isMakeControlFunc(refDump) && refDump != "shell" && refDump != "eval" {
Sasha Smundak65b547e2021-09-17 15:35:41 -07001314 if strings.HasPrefix(refDump, soongNsPrefix) {
1315 // TODO (asmundak): if we find many, maybe handle them.
Cole Faustc00184e2021-11-08 12:08:57 -08001316 return ctx.newBadExpr(node, "SOONG_CONFIG_ variables cannot be referenced, use soong_config_get instead: %s", refDump)
Sasha Smundak65b547e2021-09-17 15:35:41 -07001317 }
Cole Faustc36c9622021-12-07 15:20:45 -08001318 // Handle substitution references: https://www.gnu.org/software/make/manual/html_node/Substitution-Refs.html
1319 if strings.Contains(refDump, ":") {
1320 parts := strings.SplitN(refDump, ":", 2)
1321 substParts := strings.SplitN(parts[1], "=", 2)
1322 if len(substParts) < 2 || strings.Count(substParts[0], "%") > 1 {
1323 return ctx.newBadExpr(node, "Invalid substitution reference")
1324 }
1325 if !strings.Contains(substParts[0], "%") {
1326 if strings.Contains(substParts[1], "%") {
1327 return ctx.newBadExpr(node, "A substitution reference must have a %% in the \"before\" part of the substitution if it has one in the \"after\" part.")
1328 }
1329 substParts[0] = "%" + substParts[0]
1330 substParts[1] = "%" + substParts[1]
1331 }
1332 v := ctx.addVariable(parts[0])
1333 if v == nil {
1334 return ctx.newBadExpr(node, "unknown variable %s", refDump)
1335 }
1336 return &callExpr{
Cole Faust9ebf6e42021-12-13 14:08:34 -08001337 name: baseName + ".mkpatsubst",
1338 returnType: starlarkTypeString,
Cole Faustc36c9622021-12-07 15:20:45 -08001339 args: []starlarkExpr{
1340 &stringLiteralExpr{literal: substParts[0]},
1341 &stringLiteralExpr{literal: substParts[1]},
Cole Faustf0632662022-04-07 13:59:24 -07001342 NewVariableRefExpr(v),
Cole Faustc36c9622021-12-07 15:20:45 -08001343 },
1344 }
1345 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001346 if v := ctx.addVariable(refDump); v != nil {
Cole Faustf0632662022-04-07 13:59:24 -07001347 return NewVariableRefExpr(v)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001348 }
1349 return ctx.newBadExpr(node, "unknown variable %s", refDump)
1350 }
1351
Cole Faustf035d402022-03-28 14:02:50 -07001352 if name, args, ok := ctx.maybeParseFunctionCall(node, ref); ok {
1353 if kf, found := knownFunctions[name]; found {
1354 return kf.parse(ctx, node, args)
Sasha Smundak6609ba72021-07-22 18:32:56 -07001355 } else {
Cole Faustf035d402022-03-28 14:02:50 -07001356 return ctx.newBadExpr(node, "cannot handle invoking %s", name)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001357 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001358 }
Cole Faust1e275862022-04-26 14:28:04 -07001359 return ctx.newBadExpr(node, "cannot handle %s", refDump)
Cole Faust9ebf6e42021-12-13 14:08:34 -08001360}
1361
1362type simpleCallParser struct {
1363 name string
1364 returnType starlarkType
1365 addGlobals bool
Cole Faust1cc08852022-02-28 11:12:08 -08001366 addHandle bool
Cole Faust9ebf6e42021-12-13 14:08:34 -08001367}
1368
1369func (p *simpleCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1370 expr := &callExpr{name: p.name, returnType: p.returnType}
1371 if p.addGlobals {
1372 expr.args = append(expr.args, &globalsExpr{})
1373 }
Cole Faust1cc08852022-02-28 11:12:08 -08001374 if p.addHandle {
1375 expr.args = append(expr.args, &identifierExpr{name: "handle"})
1376 }
Cole Faust9ebf6e42021-12-13 14:08:34 -08001377 for _, arg := range args.Split(",") {
1378 arg.TrimLeftSpaces()
1379 arg.TrimRightSpaces()
1380 x := ctx.parseMakeString(node, arg)
1381 if xBad, ok := x.(*badExpr); ok {
1382 return xBad
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001383 }
Cole Faust9ebf6e42021-12-13 14:08:34 -08001384 expr.args = append(expr.args, x)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001385 }
1386 return expr
1387}
1388
Cole Faust9ebf6e42021-12-13 14:08:34 -08001389type makeControlFuncParser struct {
1390 name string
1391}
1392
1393func (p *makeControlFuncParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1394 // Make control functions need special treatment as everything
1395 // after the name is a single text argument
1396 x := ctx.parseMakeString(node, args)
1397 if xBad, ok := x.(*badExpr); ok {
1398 return xBad
1399 }
1400 return &callExpr{
1401 name: p.name,
1402 args: []starlarkExpr{
1403 &stringLiteralExpr{ctx.script.mkFile},
1404 x,
1405 },
1406 returnType: starlarkTypeUnknown,
1407 }
1408}
1409
1410type shellCallParser struct{}
1411
1412func (p *shellCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1413 // Shell functions need special treatment as everything
1414 // after the name is a single text argument
1415 x := ctx.parseMakeString(node, args)
1416 if xBad, ok := x.(*badExpr); ok {
1417 return xBad
1418 }
1419 return &callExpr{
1420 name: baseName + ".shell",
1421 args: []starlarkExpr{x},
1422 returnType: starlarkTypeUnknown,
1423 }
1424}
1425
1426type myDirCallParser struct{}
1427
1428func (p *myDirCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1429 if !args.Empty() {
1430 return ctx.newBadExpr(node, "my-dir function cannot have any arguments passed to it.")
1431 }
Cole Faustf5adedc2022-03-18 14:05:06 -07001432 return &stringLiteralExpr{literal: filepath.Dir(ctx.script.mkFile)}
Cole Faust9ebf6e42021-12-13 14:08:34 -08001433}
1434
Cole Faustd2daabf2022-12-12 17:38:01 -08001435type andOrParser struct {
1436 isAnd bool
1437}
1438
1439func (p *andOrParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1440 if args.Empty() {
1441 return ctx.newBadExpr(node, "and/or function must have at least 1 argument")
1442 }
1443 op := "or"
1444 if p.isAnd {
1445 op = "and"
1446 }
1447
1448 argsParsed := make([]starlarkExpr, 0)
1449
1450 for _, arg := range args.Split(",") {
1451 arg.TrimLeftSpaces()
1452 arg.TrimRightSpaces()
1453 x := ctx.parseMakeString(node, arg)
1454 if xBad, ok := x.(*badExpr); ok {
1455 return xBad
1456 }
1457 argsParsed = append(argsParsed, x)
1458 }
1459 typ := starlarkTypeUnknown
1460 for _, arg := range argsParsed {
1461 if typ != arg.typ() && arg.typ() != starlarkTypeUnknown && typ != starlarkTypeUnknown {
1462 return ctx.newBadExpr(node, "Expected all arguments to $(or) or $(and) to have the same type, found %q and %q", typ.String(), arg.typ().String())
1463 }
1464 if arg.typ() != starlarkTypeUnknown {
1465 typ = arg.typ()
1466 }
1467 }
1468 result := argsParsed[0]
1469 for _, arg := range argsParsed[1:] {
1470 result = &binaryOpExpr{
1471 left: result,
1472 right: arg,
1473 op: op,
1474 returnType: typ,
1475 }
1476 }
1477 return result
1478}
1479
Cole Faust9ebf6e42021-12-13 14:08:34 -08001480type isProductInListCallParser struct{}
1481
1482func (p *isProductInListCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1483 if args.Empty() {
1484 return ctx.newBadExpr(node, "is-product-in-list requires an argument")
1485 }
1486 return &inExpr{
Cole Faustf0632662022-04-07 13:59:24 -07001487 expr: NewVariableRefExpr(ctx.addVariable("TARGET_PRODUCT")),
Cole Faust9ebf6e42021-12-13 14:08:34 -08001488 list: maybeConvertToStringList(ctx.parseMakeString(node, args)),
1489 isNot: false,
1490 }
1491}
1492
1493type isVendorBoardPlatformCallParser struct{}
1494
1495func (p *isVendorBoardPlatformCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1496 if args.Empty() || !identifierFullMatchRegex.MatchString(args.Dump()) {
1497 return ctx.newBadExpr(node, "cannot handle non-constant argument to is-vendor-board-platform")
1498 }
1499 return &inExpr{
Cole Faustf0632662022-04-07 13:59:24 -07001500 expr: NewVariableRefExpr(ctx.addVariable("TARGET_BOARD_PLATFORM")),
1501 list: NewVariableRefExpr(ctx.addVariable(args.Dump() + "_BOARD_PLATFORMS")),
Cole Faust9ebf6e42021-12-13 14:08:34 -08001502 isNot: false,
1503 }
1504}
1505
1506type isVendorBoardQcomCallParser struct{}
1507
1508func (p *isVendorBoardQcomCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1509 if !args.Empty() {
1510 return ctx.newBadExpr(node, "is-vendor-board-qcom does not accept any arguments")
1511 }
1512 return &inExpr{
Cole Faustf0632662022-04-07 13:59:24 -07001513 expr: NewVariableRefExpr(ctx.addVariable("TARGET_BOARD_PLATFORM")),
1514 list: NewVariableRefExpr(ctx.addVariable("QCOM_BOARD_PLATFORMS")),
Cole Faust9ebf6e42021-12-13 14:08:34 -08001515 isNot: false,
1516 }
1517}
1518
1519type substCallParser struct {
1520 fname string
1521}
1522
1523func (p *substCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001524 words := args.Split(",")
1525 if len(words) != 3 {
Cole Faust9ebf6e42021-12-13 14:08:34 -08001526 return ctx.newBadExpr(node, "%s function should have 3 arguments", p.fname)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001527 }
Sasha Smundak35434ed2021-11-05 16:29:56 -07001528 from := ctx.parseMakeString(node, words[0])
1529 if xBad, ok := from.(*badExpr); ok {
1530 return xBad
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001531 }
Sasha Smundak35434ed2021-11-05 16:29:56 -07001532 to := ctx.parseMakeString(node, words[1])
1533 if xBad, ok := to.(*badExpr); ok {
1534 return xBad
1535 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001536 words[2].TrimLeftSpaces()
1537 words[2].TrimRightSpaces()
1538 obj := ctx.parseMakeString(node, words[2])
Sasha Smundak9d011ab2021-07-09 16:00:57 -07001539 typ := obj.typ()
Cole Faust9ebf6e42021-12-13 14:08:34 -08001540 if typ == starlarkTypeString && p.fname == "subst" {
Sasha Smundak94b41c72021-07-12 18:30:42 -07001541 // Optimization: if it's $(subst from, to, string), emit string.replace(from, to)
Sasha Smundak9d011ab2021-07-09 16:00:57 -07001542 return &callExpr{
1543 object: obj,
1544 name: "replace",
Sasha Smundak35434ed2021-11-05 16:29:56 -07001545 args: []starlarkExpr{from, to},
Sasha Smundak9d011ab2021-07-09 16:00:57 -07001546 returnType: typ,
1547 }
1548 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001549 return &callExpr{
Cole Faust9ebf6e42021-12-13 14:08:34 -08001550 name: baseName + ".mk" + p.fname,
Sasha Smundak35434ed2021-11-05 16:29:56 -07001551 args: []starlarkExpr{from, to, obj},
Sasha Smundak9d011ab2021-07-09 16:00:57 -07001552 returnType: obj.typ(),
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001553 }
1554}
1555
Cole Faust9ebf6e42021-12-13 14:08:34 -08001556type ifCallParser struct{}
1557
1558func (p *ifCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
Cole Faust4eadba72021-12-07 11:54:52 -08001559 words := args.Split(",")
1560 if len(words) != 2 && len(words) != 3 {
1561 return ctx.newBadExpr(node, "if function should have 2 or 3 arguments, found "+strconv.Itoa(len(words)))
1562 }
1563 condition := ctx.parseMakeString(node, words[0])
1564 ifTrue := ctx.parseMakeString(node, words[1])
1565 var ifFalse starlarkExpr
1566 if len(words) == 3 {
1567 ifFalse = ctx.parseMakeString(node, words[2])
1568 } else {
1569 switch ifTrue.typ() {
1570 case starlarkTypeList:
1571 ifFalse = &listExpr{items: []starlarkExpr{}}
1572 case starlarkTypeInt:
1573 ifFalse = &intLiteralExpr{literal: 0}
1574 case starlarkTypeBool:
1575 ifFalse = &boolLiteralExpr{literal: false}
1576 default:
1577 ifFalse = &stringLiteralExpr{literal: ""}
1578 }
1579 }
1580 return &ifExpr{
1581 condition,
1582 ifTrue,
1583 ifFalse,
1584 }
1585}
1586
Cole Faustf035d402022-03-28 14:02:50 -07001587type ifCallNodeParser struct{}
Cole Faust9ebf6e42021-12-13 14:08:34 -08001588
Cole Faustf035d402022-03-28 14:02:50 -07001589func (p *ifCallNodeParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) []starlarkNode {
1590 words := args.Split(",")
1591 if len(words) != 2 && len(words) != 3 {
1592 return []starlarkNode{ctx.newBadNode(node, "if function should have 2 or 3 arguments, found "+strconv.Itoa(len(words)))}
1593 }
1594
1595 ifn := &ifNode{expr: ctx.parseMakeString(node, words[0])}
1596 cases := []*switchCase{
1597 {
1598 gate: ifn,
1599 nodes: ctx.parseNodeMakeString(node, words[1]),
1600 },
1601 }
1602 if len(words) == 3 {
1603 cases = append(cases, &switchCase{
1604 gate: &elseNode{},
1605 nodes: ctx.parseNodeMakeString(node, words[2]),
1606 })
1607 }
1608 if len(cases) == 2 {
1609 if len(cases[1].nodes) == 0 {
1610 // Remove else branch if it has no contents
1611 cases = cases[:1]
1612 } else if len(cases[0].nodes) == 0 {
1613 // If the if branch has no contents but the else does,
1614 // move them to the if and negate its condition
1615 ifn.expr = negateExpr(ifn.expr)
1616 cases[0].nodes = cases[1].nodes
1617 cases = cases[:1]
1618 }
1619 }
1620
1621 return []starlarkNode{&switchNode{ssCases: cases}}
1622}
1623
1624type foreachCallParser struct{}
1625
1626func (p *foreachCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
Cole Faustb0d32ab2021-12-09 14:00:59 -08001627 words := args.Split(",")
1628 if len(words) != 3 {
1629 return ctx.newBadExpr(node, "foreach function should have 3 arguments, found "+strconv.Itoa(len(words)))
1630 }
1631 if !words[0].Const() || words[0].Empty() || !identifierFullMatchRegex.MatchString(words[0].Strings[0]) {
1632 return ctx.newBadExpr(node, "first argument to foreach function must be a simple string identifier")
1633 }
1634 loopVarName := words[0].Strings[0]
1635 list := ctx.parseMakeString(node, words[1])
1636 action := ctx.parseMakeString(node, words[2]).transform(func(expr starlarkExpr) starlarkExpr {
1637 if varRefExpr, ok := expr.(*variableRefExpr); ok && varRefExpr.ref.name() == loopVarName {
1638 return &identifierExpr{loopVarName}
1639 }
1640 return nil
1641 })
1642
1643 if list.typ() != starlarkTypeList {
1644 list = &callExpr{
Cole Faust9ebf6e42021-12-13 14:08:34 -08001645 name: baseName + ".words",
1646 returnType: starlarkTypeList,
Cole Faustb0d32ab2021-12-09 14:00:59 -08001647 args: []starlarkExpr{list},
1648 }
1649 }
1650
Cole Faust72374fc2022-05-05 11:45:04 -07001651 var result starlarkExpr = &foreachExpr{
Cole Faustb0d32ab2021-12-09 14:00:59 -08001652 varName: loopVarName,
1653 list: list,
1654 action: action,
1655 }
Cole Faust72374fc2022-05-05 11:45:04 -07001656
1657 if action.typ() == starlarkTypeList {
1658 result = &callExpr{
1659 name: baseName + ".flatten_2d_list",
1660 args: []starlarkExpr{result},
1661 returnType: starlarkTypeList,
1662 }
1663 }
1664
1665 return result
Cole Faustb0d32ab2021-12-09 14:00:59 -08001666}
1667
Cole Faustf035d402022-03-28 14:02:50 -07001668func transformNode(node starlarkNode, transformer func(expr starlarkExpr) starlarkExpr) {
1669 switch a := node.(type) {
1670 case *ifNode:
1671 a.expr = a.expr.transform(transformer)
1672 case *switchCase:
1673 transformNode(a.gate, transformer)
1674 for _, n := range a.nodes {
1675 transformNode(n, transformer)
1676 }
1677 case *switchNode:
1678 for _, n := range a.ssCases {
1679 transformNode(n, transformer)
1680 }
1681 case *exprNode:
1682 a.expr = a.expr.transform(transformer)
1683 case *assignmentNode:
1684 a.value = a.value.transform(transformer)
1685 case *foreachNode:
1686 a.list = a.list.transform(transformer)
1687 for _, n := range a.actions {
1688 transformNode(n, transformer)
1689 }
Cole Faust9df1d732022-04-26 16:27:22 -07001690 case *inheritNode:
1691 if b, ok := a.module.(inheritedDynamicModule); ok {
1692 b.path = b.path.transform(transformer)
1693 a.module = b
1694 }
1695 case *includeNode:
1696 if b, ok := a.module.(inheritedDynamicModule); ok {
1697 b.path = b.path.transform(transformer)
1698 a.module = b
1699 }
Cole Faustf035d402022-03-28 14:02:50 -07001700 }
1701}
1702
1703type foreachCallNodeParser struct{}
1704
1705func (p *foreachCallNodeParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) []starlarkNode {
1706 words := args.Split(",")
1707 if len(words) != 3 {
1708 return []starlarkNode{ctx.newBadNode(node, "foreach function should have 3 arguments, found "+strconv.Itoa(len(words)))}
1709 }
1710 if !words[0].Const() || words[0].Empty() || !identifierFullMatchRegex.MatchString(words[0].Strings[0]) {
1711 return []starlarkNode{ctx.newBadNode(node, "first argument to foreach function must be a simple string identifier")}
1712 }
1713
1714 loopVarName := words[0].Strings[0]
1715
1716 list := ctx.parseMakeString(node, words[1])
1717 if list.typ() != starlarkTypeList {
1718 list = &callExpr{
1719 name: baseName + ".words",
1720 returnType: starlarkTypeList,
1721 args: []starlarkExpr{list},
1722 }
1723 }
1724
1725 actions := ctx.parseNodeMakeString(node, words[2])
1726 // TODO(colefaust): Replace transforming code with something more elegant
1727 for _, action := range actions {
1728 transformNode(action, func(expr starlarkExpr) starlarkExpr {
1729 if varRefExpr, ok := expr.(*variableRefExpr); ok && varRefExpr.ref.name() == loopVarName {
1730 return &identifierExpr{loopVarName}
1731 }
1732 return nil
1733 })
1734 }
1735
1736 return []starlarkNode{&foreachNode{
1737 varName: loopVarName,
1738 list: list,
1739 actions: actions,
1740 }}
1741}
1742
Cole Faust9ebf6e42021-12-13 14:08:34 -08001743type wordCallParser struct{}
1744
1745func (p *wordCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001746 words := args.Split(",")
1747 if len(words) != 2 {
1748 return ctx.newBadExpr(node, "word function should have 2 arguments")
1749 }
Cole Faust94c4a9a2022-04-22 17:43:52 -07001750 var index = 0
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001751 if words[0].Const() {
Cole Faust94c4a9a2022-04-22 17:43:52 -07001752 if i, err := strconv.Atoi(strings.TrimSpace(words[0].Strings[0])); err == nil {
1753 index = i
1754 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001755 }
1756 if index < 1 {
1757 return ctx.newBadExpr(node, "word index should be constant positive integer")
1758 }
1759 words[1].TrimLeftSpaces()
1760 words[1].TrimRightSpaces()
1761 array := ctx.parseMakeString(node, words[1])
Cole Faust94c4a9a2022-04-22 17:43:52 -07001762 if bad, ok := array.(*badExpr); ok {
1763 return bad
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001764 }
1765 if array.typ() != starlarkTypeList {
Cole Faust94c4a9a2022-04-22 17:43:52 -07001766 array = &callExpr{
1767 name: baseName + ".words",
1768 args: []starlarkExpr{array},
1769 returnType: starlarkTypeList,
1770 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001771 }
Cole Faust94c4a9a2022-04-22 17:43:52 -07001772 return &indexExpr{array, &intLiteralExpr{index - 1}}
1773}
1774
1775type wordsCallParser struct{}
1776
1777func (p *wordsCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1778 args.TrimLeftSpaces()
1779 args.TrimRightSpaces()
1780 array := ctx.parseMakeString(node, args)
1781 if bad, ok := array.(*badExpr); ok {
1782 return bad
1783 }
1784 if array.typ() != starlarkTypeList {
1785 array = &callExpr{
1786 name: baseName + ".words",
1787 args: []starlarkExpr{array},
1788 returnType: starlarkTypeList,
1789 }
1790 }
1791 return &callExpr{
1792 name: "len",
1793 args: []starlarkExpr{array},
1794 returnType: starlarkTypeInt,
1795 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001796}
1797
Cole Faustb1103e22022-01-06 15:22:05 -08001798func parseIntegerArguments(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString, expectedArgs int) ([]starlarkExpr, error) {
1799 parsedArgs := make([]starlarkExpr, 0)
1800 for _, arg := range args.Split(",") {
1801 expr := ctx.parseMakeString(node, arg)
1802 if expr.typ() == starlarkTypeList {
1803 return nil, fmt.Errorf("argument to math argument has type list, which cannot be converted to int")
1804 }
1805 if s, ok := maybeString(expr); ok {
1806 intVal, err := strconv.Atoi(strings.TrimSpace(s))
1807 if err != nil {
1808 return nil, err
1809 }
1810 expr = &intLiteralExpr{literal: intVal}
1811 } else if expr.typ() != starlarkTypeInt {
1812 expr = &callExpr{
1813 name: "int",
1814 args: []starlarkExpr{expr},
1815 returnType: starlarkTypeInt,
1816 }
1817 }
1818 parsedArgs = append(parsedArgs, expr)
1819 }
1820 if len(parsedArgs) != expectedArgs {
1821 return nil, fmt.Errorf("function should have %d arguments", expectedArgs)
1822 }
1823 return parsedArgs, nil
1824}
1825
1826type mathComparisonCallParser struct {
1827 op string
1828}
1829
1830func (p *mathComparisonCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1831 parsedArgs, err := parseIntegerArguments(ctx, node, args, 2)
1832 if err != nil {
1833 return ctx.newBadExpr(node, err.Error())
1834 }
1835 return &binaryOpExpr{
1836 left: parsedArgs[0],
1837 right: parsedArgs[1],
1838 op: p.op,
1839 returnType: starlarkTypeBool,
1840 }
1841}
1842
1843type mathMaxOrMinCallParser struct {
1844 function string
1845}
1846
1847func (p *mathMaxOrMinCallParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) starlarkExpr {
1848 parsedArgs, err := parseIntegerArguments(ctx, node, args, 2)
1849 if err != nil {
1850 return ctx.newBadExpr(node, err.Error())
1851 }
1852 return &callExpr{
1853 object: nil,
1854 name: p.function,
1855 args: parsedArgs,
1856 returnType: starlarkTypeInt,
1857 }
1858}
1859
Cole Faustf035d402022-03-28 14:02:50 -07001860type evalNodeParser struct{}
1861
1862func (p *evalNodeParser) parse(ctx *parseContext, node mkparser.Node, args *mkparser.MakeString) []starlarkNode {
1863 parser := mkparser.NewParser("Eval expression", strings.NewReader(args.Dump()))
1864 nodes, errs := parser.Parse()
1865 if errs != nil {
1866 return []starlarkNode{ctx.newBadNode(node, "Unable to parse eval statement")}
1867 }
1868
1869 if len(nodes) == 0 {
1870 return []starlarkNode{}
1871 } else if len(nodes) == 1 {
1872 switch n := nodes[0].(type) {
1873 case *mkparser.Assignment:
1874 if n.Name.Const() {
1875 return ctx.handleAssignment(n)
1876 }
1877 case *mkparser.Comment:
1878 return []starlarkNode{&commentNode{strings.TrimSpace("#" + n.Comment)}}
Cole Faust20052982022-04-22 14:43:55 -07001879 case *mkparser.Directive:
1880 if n.Name == "include" || n.Name == "-include" {
1881 return ctx.handleInclude(n)
1882 }
1883 case *mkparser.Variable:
1884 // Technically inherit-product(-if-exists) don't need to be put inside
1885 // an eval, but some makefiles do it, presumably because they copy+pasted
1886 // from a $(eval include ...)
1887 if name, _, ok := ctx.maybeParseFunctionCall(n, n.Name); ok {
1888 if name == "inherit-product" || name == "inherit-product-if-exists" {
1889 return ctx.handleVariable(n)
1890 }
1891 }
Cole Faustf035d402022-03-28 14:02:50 -07001892 }
1893 }
1894
Cole Faust20052982022-04-22 14:43:55 -07001895 return []starlarkNode{ctx.newBadNode(node, "Eval expression too complex; only assignments, comments, includes, and inherit-products are supported")}
Cole Faustf035d402022-03-28 14:02:50 -07001896}
1897
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001898func (ctx *parseContext) parseMakeString(node mkparser.Node, mk *mkparser.MakeString) starlarkExpr {
1899 if mk.Const() {
1900 return &stringLiteralExpr{mk.Dump()}
1901 }
1902 if mkRef, ok := mk.SingleVariable(); ok {
1903 return ctx.parseReference(node, mkRef)
1904 }
1905 // If we reached here, it's neither string literal nor a simple variable,
1906 // we need a full-blown interpolation node that will generate
1907 // "a%b%c" % (X, Y) for a$(X)b$(Y)c
Cole Faustfc438682021-12-14 12:46:32 -08001908 parts := make([]starlarkExpr, len(mk.Variables)+len(mk.Strings))
1909 for i := 0; i < len(parts); i++ {
1910 if i%2 == 0 {
1911 parts[i] = &stringLiteralExpr{literal: mk.Strings[i/2]}
1912 } else {
1913 parts[i] = ctx.parseReference(node, mk.Variables[i/2].Name)
1914 if x, ok := parts[i].(*badExpr); ok {
1915 return x
1916 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001917 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001918 }
Cole Faustfc438682021-12-14 12:46:32 -08001919 return NewInterpolateExpr(parts)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001920}
1921
Cole Faustf035d402022-03-28 14:02:50 -07001922func (ctx *parseContext) parseNodeMakeString(node mkparser.Node, mk *mkparser.MakeString) []starlarkNode {
1923 // Discard any constant values in the make string, as they would be top level
1924 // string literals and do nothing.
1925 result := make([]starlarkNode, 0, len(mk.Variables))
1926 for i := range mk.Variables {
1927 result = append(result, ctx.handleVariable(&mk.Variables[i])...)
1928 }
1929 return result
1930}
1931
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001932// Handles the statements whose treatment is the same in all contexts: comment,
1933// assignment, variable (which is a macro call in reality) and all constructs that
1934// do not handle in any context ('define directive and any unrecognized stuff).
Cole Faustdd569ae2022-01-31 15:48:29 -08001935func (ctx *parseContext) handleSimpleStatement(node mkparser.Node) []starlarkNode {
1936 var result []starlarkNode
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001937 switch x := node.(type) {
1938 case *mkparser.Comment:
Cole Faustdd569ae2022-01-31 15:48:29 -08001939 if n, handled := ctx.maybeHandleAnnotation(x); handled && n != nil {
1940 result = []starlarkNode{n}
1941 } else if !handled {
1942 result = []starlarkNode{&commentNode{strings.TrimSpace("#" + x.Comment)}}
Cole Faust7940c6a2022-01-31 15:54:05 -08001943 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001944 case *mkparser.Assignment:
Cole Faustdd569ae2022-01-31 15:48:29 -08001945 result = ctx.handleAssignment(x)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001946 case *mkparser.Variable:
Cole Faustdd569ae2022-01-31 15:48:29 -08001947 result = ctx.handleVariable(x)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001948 case *mkparser.Directive:
1949 switch x.Name {
1950 case "define":
Cole Faustdd569ae2022-01-31 15:48:29 -08001951 if res := ctx.maybeHandleDefine(x); res != nil {
1952 result = []starlarkNode{res}
1953 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001954 case "include", "-include":
Cole Faust20052982022-04-22 14:43:55 -07001955 result = ctx.handleInclude(x)
Cole Faust591a1fe2021-11-08 15:37:57 -08001956 case "ifeq", "ifneq", "ifdef", "ifndef":
Cole Faustdd569ae2022-01-31 15:48:29 -08001957 result = []starlarkNode{ctx.handleIfBlock(x)}
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001958 default:
Cole Faustdd569ae2022-01-31 15:48:29 -08001959 result = []starlarkNode{ctx.newBadNode(x, "unexpected directive %s", x.Name)}
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001960 }
1961 default:
Cole Faustdd569ae2022-01-31 15:48:29 -08001962 result = []starlarkNode{ctx.newBadNode(x, "unsupported line %s", strings.ReplaceAll(x.Dump(), "\n", "\n#"))}
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001963 }
Cole Faust6c934f62022-01-06 15:51:12 -08001964
1965 // Clear the includeTops after each non-comment statement
1966 // so that include annotations placed on certain statements don't apply
1967 // globally for the rest of the makefile was well.
Cole Faustf92c9f22022-03-14 14:35:50 -07001968 if _, wasComment := node.(*mkparser.Comment); !wasComment {
1969 ctx.atTopOfMakefile = false
Cole Faust6c934f62022-01-06 15:51:12 -08001970 ctx.includeTops = []string{}
1971 }
Cole Faustdd569ae2022-01-31 15:48:29 -08001972
1973 if result == nil {
1974 result = []starlarkNode{}
1975 }
Cole Faustf035d402022-03-28 14:02:50 -07001976
Cole Faustdd569ae2022-01-31 15:48:29 -08001977 return result
Sasha Smundakb051c4e2020-11-05 20:45:07 -08001978}
1979
Cole Faustf92c9f22022-03-14 14:35:50 -07001980// The types allowed in a type_hint
1981var typeHintMap = map[string]starlarkType{
1982 "string": starlarkTypeString,
1983 "list": starlarkTypeList,
1984}
1985
Sasha Smundak6d852dd2021-09-27 20:34:39 -07001986// Processes annotation. An annotation is a comment that starts with #RBC# and provides
1987// a conversion hint -- say, where to look for the dynamically calculated inherit/include
Cole Faust7940c6a2022-01-31 15:54:05 -08001988// paths. Returns true if the comment was a successfully-handled annotation.
Cole Faustdd569ae2022-01-31 15:48:29 -08001989func (ctx *parseContext) maybeHandleAnnotation(cnode *mkparser.Comment) (starlarkNode, bool) {
Sasha Smundak6d852dd2021-09-27 20:34:39 -07001990 maybeTrim := func(s, prefix string) (string, bool) {
1991 if strings.HasPrefix(s, prefix) {
1992 return strings.TrimSpace(strings.TrimPrefix(s, prefix)), true
1993 }
1994 return s, false
1995 }
1996 annotation, ok := maybeTrim(cnode.Comment, annotationCommentPrefix)
1997 if !ok {
Cole Faustdd569ae2022-01-31 15:48:29 -08001998 return nil, false
Sasha Smundak6d852dd2021-09-27 20:34:39 -07001999 }
2000 if p, ok := maybeTrim(annotation, "include_top"); ok {
Cole Faustf7ed5342021-12-21 14:15:12 -08002001 // Don't allow duplicate include tops, because then we will generate
2002 // invalid starlark code. (duplicate keys in the _entry dictionary)
2003 for _, top := range ctx.includeTops {
2004 if top == p {
Cole Faustdd569ae2022-01-31 15:48:29 -08002005 return nil, true
Cole Faustf7ed5342021-12-21 14:15:12 -08002006 }
2007 }
Sasha Smundak6d852dd2021-09-27 20:34:39 -07002008 ctx.includeTops = append(ctx.includeTops, p)
Cole Faustdd569ae2022-01-31 15:48:29 -08002009 return nil, true
Cole Faustf92c9f22022-03-14 14:35:50 -07002010 } else if p, ok := maybeTrim(annotation, "type_hint"); ok {
2011 // Type hints must come at the beginning the file, to avoid confusion
2012 // if a type hint was specified later and thus only takes effect for half
2013 // of the file.
2014 if !ctx.atTopOfMakefile {
2015 return ctx.newBadNode(cnode, "type_hint annotations must come before the first Makefile statement"), true
2016 }
2017
2018 parts := strings.Fields(p)
2019 if len(parts) <= 1 {
2020 return ctx.newBadNode(cnode, "Invalid type_hint annotation: %s. Must be a variable type followed by a list of variables of that type", p), true
2021 }
2022
2023 var varType starlarkType
2024 if varType, ok = typeHintMap[parts[0]]; !ok {
2025 varType = starlarkTypeUnknown
2026 }
2027 if varType == starlarkTypeUnknown {
2028 return ctx.newBadNode(cnode, "Invalid type_hint annotation. Only list/string types are accepted, found %s", parts[0]), true
2029 }
2030
2031 for _, name := range parts[1:] {
2032 // Don't allow duplicate type hints
2033 if _, ok := ctx.typeHints[name]; ok {
2034 return ctx.newBadNode(cnode, "Duplicate type hint for variable %s", name), true
2035 }
2036 ctx.typeHints[name] = varType
2037 }
2038 return nil, true
Sasha Smundak6d852dd2021-09-27 20:34:39 -07002039 }
Cole Faustdd569ae2022-01-31 15:48:29 -08002040 return ctx.newBadNode(cnode, "unsupported annotation %s", cnode.Comment), true
Sasha Smundakb051c4e2020-11-05 20:45:07 -08002041}
2042
2043func (ctx *parseContext) loadedModulePath(path string) string {
2044 // During the transition to Roboleaf some of the product configuration files
2045 // will be converted and checked in while the others will be generated on the fly
2046 // and run. The runner (rbcrun application) accommodates this by allowing three
2047 // different ways to specify the loaded file location:
2048 // 1) load(":<file>",...) loads <file> from the same directory
2049 // 2) load("//path/relative/to/source/root:<file>", ...) loads <file> source tree
2050 // 3) load("/absolute/path/to/<file> absolute path
2051 // If the file being generated and the file it wants to load are in the same directory,
2052 // generate option 1.
2053 // Otherwise, if output directory is not specified, generate 2)
2054 // Finally, if output directory has been specified and the file being generated and
2055 // the file it wants to load from are in the different directories, generate 2) or 3):
2056 // * if the file being loaded exists in the source tree, generate 2)
2057 // * otherwise, generate 3)
2058 // Finally, figure out the loaded module path and name and create a node for it
2059 loadedModuleDir := filepath.Dir(path)
2060 base := filepath.Base(path)
2061 loadedModuleName := strings.TrimSuffix(base, filepath.Ext(base)) + ctx.outputSuffix
2062 if loadedModuleDir == filepath.Dir(ctx.script.mkFile) {
2063 return ":" + loadedModuleName
2064 }
2065 if ctx.outputDir == "" {
2066 return fmt.Sprintf("//%s:%s", loadedModuleDir, loadedModuleName)
2067 }
2068 if _, err := os.Stat(filepath.Join(loadedModuleDir, loadedModuleName)); err == nil {
2069 return fmt.Sprintf("//%s:%s", loadedModuleDir, loadedModuleName)
2070 }
2071 return filepath.Join(ctx.outputDir, loadedModuleDir, loadedModuleName)
2072}
2073
Sasha Smundak3deb9682021-07-26 18:42:25 -07002074func (ctx *parseContext) addSoongNamespace(ns string) {
2075 if _, ok := ctx.soongNamespaces[ns]; ok {
2076 return
2077 }
2078 ctx.soongNamespaces[ns] = make(map[string]bool)
2079}
2080
2081func (ctx *parseContext) hasSoongNamespace(name string) bool {
2082 _, ok := ctx.soongNamespaces[name]
2083 return ok
2084}
2085
2086func (ctx *parseContext) updateSoongNamespace(replace bool, namespaceName string, varNames []string) {
2087 ctx.addSoongNamespace(namespaceName)
2088 vars := ctx.soongNamespaces[namespaceName]
2089 if replace {
2090 vars = make(map[string]bool)
2091 ctx.soongNamespaces[namespaceName] = vars
2092 }
2093 for _, v := range varNames {
2094 vars[v] = true
2095 }
2096}
2097
2098func (ctx *parseContext) hasNamespaceVar(namespaceName string, varName string) bool {
2099 vars, ok := ctx.soongNamespaces[namespaceName]
2100 if ok {
2101 _, ok = vars[varName]
2102 }
2103 return ok
2104}
2105
Sasha Smundak422b6142021-11-11 18:31:59 -08002106func (ctx *parseContext) errorLocation(node mkparser.Node) ErrorLocation {
2107 return ErrorLocation{ctx.script.mkFile, ctx.script.nodeLocator(node.Pos())}
2108}
2109
Sasha Smundakb051c4e2020-11-05 20:45:07 -08002110func (ss *StarlarkScript) String() string {
2111 return NewGenerateContext(ss).emit()
2112}
2113
2114func (ss *StarlarkScript) SubConfigFiles() []string {
Sasha Smundak6609ba72021-07-22 18:32:56 -07002115
Sasha Smundakb051c4e2020-11-05 20:45:07 -08002116 var subs []string
2117 for _, src := range ss.inherited {
2118 subs = append(subs, src.originalPath)
2119 }
2120 return subs
2121}
2122
2123func (ss *StarlarkScript) HasErrors() bool {
2124 return ss.hasErrors
2125}
2126
2127// Convert reads and parses a makefile. If successful, parsed tree
2128// is returned and then can be passed to String() to get the generated
2129// Starlark file.
2130func Convert(req Request) (*StarlarkScript, error) {
2131 reader := req.Reader
2132 if reader == nil {
2133 mkContents, err := ioutil.ReadFile(req.MkFile)
2134 if err != nil {
2135 return nil, err
2136 }
2137 reader = bytes.NewBuffer(mkContents)
2138 }
2139 parser := mkparser.NewParser(req.MkFile, reader)
2140 nodes, errs := parser.Parse()
2141 if len(errs) > 0 {
2142 for _, e := range errs {
2143 fmt.Fprintln(os.Stderr, "ERROR:", e)
2144 }
2145 return nil, fmt.Errorf("bad makefile %s", req.MkFile)
2146 }
2147 starScript := &StarlarkScript{
Sasha Smundak422b6142021-11-11 18:31:59 -08002148 moduleName: moduleNameForFile(req.MkFile),
2149 mkFile: req.MkFile,
Sasha Smundak422b6142021-11-11 18:31:59 -08002150 traceCalls: req.TraceCalls,
2151 sourceFS: req.SourceFS,
2152 makefileFinder: req.MakefileFinder,
2153 nodeLocator: func(pos mkparser.Pos) int { return parser.Unpack(pos).Line },
Cole Faustdd569ae2022-01-31 15:48:29 -08002154 nodes: make([]starlarkNode, 0),
Sasha Smundakb051c4e2020-11-05 20:45:07 -08002155 }
2156 ctx := newParseContext(starScript, nodes)
2157 ctx.outputSuffix = req.OutputSuffix
2158 ctx.outputDir = req.OutputDir
2159 ctx.errorLogger = req.ErrorLogger
2160 if len(req.TracedVariables) > 0 {
2161 ctx.tracedVariables = make(map[string]bool)
2162 for _, v := range req.TracedVariables {
2163 ctx.tracedVariables[v] = true
2164 }
2165 }
Sasha Smundakb051c4e2020-11-05 20:45:07 -08002166 for ctx.hasNodes() && ctx.fatalError == nil {
Cole Faustdd569ae2022-01-31 15:48:29 -08002167 starScript.nodes = append(starScript.nodes, ctx.handleSimpleStatement(ctx.getNode())...)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08002168 }
2169 if ctx.fatalError != nil {
2170 return nil, ctx.fatalError
2171 }
2172 return starScript, nil
2173}
2174
Cole Faust864028a2021-12-01 13:43:17 -08002175func Launcher(mainModuleUri, inputVariablesUri, mainModuleName string) string {
Sasha Smundakb051c4e2020-11-05 20:45:07 -08002176 var buf bytes.Buffer
2177 fmt.Fprintf(&buf, "load(%q, %q)\n", baseUri, baseName)
Cole Faust864028a2021-12-01 13:43:17 -08002178 fmt.Fprintf(&buf, "load(%q, input_variables_init = \"init\")\n", inputVariablesUri)
Sasha Smundakd7d07ad2021-09-10 15:42:34 -07002179 fmt.Fprintf(&buf, "load(%q, \"init\")\n", mainModuleUri)
Cole Faust864028a2021-12-01 13:43:17 -08002180 fmt.Fprintf(&buf, "%s(%s(%q, init, input_variables_init))\n", cfnPrintVars, cfnMain, mainModuleName)
Sasha Smundakb051c4e2020-11-05 20:45:07 -08002181 return buf.String()
2182}
2183
Cole Faust6ed7cb42021-10-07 17:08:46 -07002184func BoardLauncher(mainModuleUri string, inputVariablesUri string) string {
2185 var buf bytes.Buffer
2186 fmt.Fprintf(&buf, "load(%q, %q)\n", baseUri, baseName)
2187 fmt.Fprintf(&buf, "load(%q, \"init\")\n", mainModuleUri)
2188 fmt.Fprintf(&buf, "load(%q, input_variables_init = \"init\")\n", inputVariablesUri)
Cole Fausta0604662022-02-28 11:53:58 -08002189 fmt.Fprintf(&buf, "%s(%s(init, input_variables_init))\n", cfnPrintVars, cfnBoardMain)
Cole Faust6ed7cb42021-10-07 17:08:46 -07002190 return buf.String()
2191}
2192
Sasha Smundakb051c4e2020-11-05 20:45:07 -08002193func MakePath2ModuleName(mkPath string) string {
2194 return strings.TrimSuffix(mkPath, filepath.Ext(mkPath))
2195}