blob: 85a891a469c1bb9730995ef844e5e05716bc6362 [file] [log] [blame]
Colin Crossb0cba6a2015-11-20 15:35:26 -08001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
Colin Crossb98c8b02016-07-29 13:44:28 -070015package config
Colin Cross3f40fa42015-01-30 17:27:36 -080016
17import (
18 "fmt"
19 "strings"
20
Colin Cross635c3b02016-05-18 15:37:25 -070021 "android/soong/android"
Colin Cross3f40fa42015-01-30 17:27:36 -080022)
23
24var (
Colin Crossc4bde762015-11-23 16:11:30 -080025 armToolchainCflags = []string{
26 "-mthumb-interwork",
Dan Willemsenc264c162016-05-18 22:52:25 -070027 "-msoft-float",
Colin Crossc4bde762015-11-23 16:11:30 -080028 }
29
Colin Cross3f40fa42015-01-30 17:27:36 -080030 armCflags = []string{
31 "-fno-exceptions", // from build/core/combo/select.mk
32 "-Wno-multichar", // from build/core/combo/select.mk
Colin Cross3f40fa42015-01-30 17:27:36 -080033 "-ffunction-sections",
34 "-fdata-sections",
35 "-funwind-tables",
Dan Willemsen7a0f8482016-01-12 16:22:40 -080036 "-fstack-protector-strong",
Colin Cross3f40fa42015-01-30 17:27:36 -080037 "-Wa,--noexecstack",
38 "-Werror=format-security",
39 "-D_FORTIFY_SOURCE=2",
40 "-fno-short-enums",
41 "-no-canonical-prefixes",
42 "-fno-canonical-system-headers",
Colin Cross3f40fa42015-01-30 17:27:36 -080043
44 "-fno-builtin-sin",
45 "-fno-strict-volatile-bitfields",
46
47 // TARGET_RELEASE_CFLAGS
48 "-DNDEBUG",
49 "-g",
50 "-Wstrict-aliasing=2",
51 "-fgcse-after-reload",
52 "-frerun-cse-after-loop",
53 "-frename-registers",
54 }
55
56 armCppflags = []string{
57 "-fvisibility-inlines-hidden",
58 }
59
60 armLdflags = []string{
61 "-Wl,-z,noexecstack",
62 "-Wl,-z,relro",
63 "-Wl,-z,now",
64 "-Wl,--build-id=md5",
65 "-Wl,--warn-shared-textrel",
66 "-Wl,--fatal-warnings",
Colin Cross13af54d2015-03-16 16:12:05 -070067 "-Wl,--icf=safe",
Colin Cross3f40fa42015-01-30 17:27:36 -080068 "-Wl,--hash-style=gnu",
Dan Willemsenc7e45972015-12-09 13:05:28 -080069 "-Wl,--no-undefined-version",
Colin Cross3f40fa42015-01-30 17:27:36 -080070 }
71
72 armArmCflags = []string{
73 "-O2",
74 "-fomit-frame-pointer",
75 "-fstrict-aliasing",
76 "-funswitch-loops",
77 }
78
79 armThumbCflags = []string{
80 "-mthumb",
81 "-Os",
82 "-fomit-frame-pointer",
83 "-fno-strict-aliasing",
84 }
85
86 armArchVariantCflags = map[string][]string{
87 "armv5te": []string{
88 "-march=armv5te",
89 "-mtune=xscale",
90 "-D__ARM_ARCH_5__",
91 "-D__ARM_ARCH_5T__",
92 "-D__ARM_ARCH_5E__",
93 "-D__ARM_ARCH_5TE__",
94 },
95 "armv7-a": []string{
96 "-march=armv7-a",
97 "-mfloat-abi=softfp",
98 "-mfpu=vfpv3-d16",
99 },
100 "armv7-a-neon": []string{
101 "-mfloat-abi=softfp",
102 "-mfpu=neon",
103 },
104 }
105
Colin Cross3f40fa42015-01-30 17:27:36 -0800106 armCpuVariantCflags = map[string][]string{
Dan Willemsen110a89d2016-01-14 15:17:19 -0800107 "": []string{
108 "-march=armv7-a",
109 },
Colin Cross3f40fa42015-01-30 17:27:36 -0800110 "cortex-a7": []string{
111 "-mcpu=cortex-a7",
Dan Willemsen8e1e3fb2016-03-29 15:47:08 -0700112 // Fake an ARM compiler flag as these processors support LPAE which GCC/clang
113 // don't advertise.
114 // TODO This is a hack and we need to add it for each processor that supports LPAE until some
115 // better solution comes around. See Bug 27340895
116 "-D__ARM_FEATURE_LPAE=1",
Colin Cross3f40fa42015-01-30 17:27:36 -0800117 },
118 "cortex-a8": []string{
119 "-mcpu=cortex-a8",
120 },
121 "cortex-a15": []string{
122 "-mcpu=cortex-a15",
123 // Fake an ARM compiler flag as these processors support LPAE which GCC/clang
124 // don't advertise.
Dan Willemsen8e1e3fb2016-03-29 15:47:08 -0700125 // TODO This is a hack and we need to add it for each processor that supports LPAE until some
126 // better solution comes around. See Bug 27340895
Colin Cross3f40fa42015-01-30 17:27:36 -0800127 "-D__ARM_FEATURE_LPAE=1",
128 },
Dan Willemsened89a7a2016-05-09 13:39:58 -0700129 "krait": []string{
130 "-mcpu=cortex-a15",
131 // Fake an ARM compiler flag as these processors support LPAE which GCC/clang
132 // don't advertise.
133 // TODO This is a hack and we need to add it for each processor that supports LPAE until some
134 // better solution comes around. See Bug 27340895
135 "-D__ARM_FEATURE_LPAE=1",
136 },
Colin Cross3f40fa42015-01-30 17:27:36 -0800137 }
138
Dan Willemsenf5a959c2015-07-13 13:28:18 -0700139 armClangCpuVariantCflags = copyVariantFlags(armCpuVariantCflags)
140 armClangArchVariantCflags = copyVariantFlags(armArchVariantCflags)
Colin Cross3f40fa42015-01-30 17:27:36 -0800141)
142
Dan Willemsen34fc3b12015-12-07 12:30:44 -0800143const (
144 armGccVersion = "4.9"
145)
146
Colin Cross3f40fa42015-01-30 17:27:36 -0800147func init() {
148 replaceFirst := func(slice []string, from, to string) {
149 if slice[0] != from {
150 panic(fmt.Errorf("Expected %q, found %q", from, to))
151 }
152
153 slice[0] = to
154 }
155
Dan Willemsened89a7a2016-05-09 13:39:58 -0700156 replaceFirst(armClangCpuVariantCflags["krait"], "-mcpu=cortex-a15", "-mcpu=krait")
157 armClangCpuVariantCflags["krait"] = append(armClangCpuVariantCflags["krait"], "-mfpu=neon-vfpv4")
Colin Cross3f40fa42015-01-30 17:27:36 -0800158
Dan Willemsen34fc3b12015-12-07 12:30:44 -0800159 pctx.StaticVariable("armGccVersion", armGccVersion)
Colin Cross3f40fa42015-01-30 17:27:36 -0800160
Colin Crossb98c8b02016-07-29 13:44:28 -0700161 pctx.SourcePathVariable("ArmGccRoot",
Dan Willemsen87b17d12015-07-14 00:39:06 -0700162 "prebuilts/gcc/${HostPrebuiltTag}/arm/arm-linux-androideabi-${armGccVersion}")
Colin Cross3f40fa42015-01-30 17:27:36 -0800163
Colin Crossb98c8b02016-07-29 13:44:28 -0700164 pctx.StaticVariable("ArmToolchainCflags", strings.Join(armToolchainCflags, " "))
165 pctx.StaticVariable("ArmCflags", strings.Join(armCflags, " "))
166 pctx.StaticVariable("ArmLdflags", strings.Join(armLdflags, " "))
167 pctx.StaticVariable("ArmCppflags", strings.Join(armCppflags, " "))
168 pctx.StaticVariable("ArmIncludeFlags", bionicHeaders("arm", "arm"))
Colin Cross3f40fa42015-01-30 17:27:36 -0800169
170 // Extended cflags
171
Tim Kilbourn1a9bf262015-03-18 12:28:32 -0700172 // ARM vs. Thumb instruction set flags
Colin Crossb98c8b02016-07-29 13:44:28 -0700173 pctx.StaticVariable("ArmArmCflags", strings.Join(armArmCflags, " "))
174 pctx.StaticVariable("ArmThumbCflags", strings.Join(armThumbCflags, " "))
Colin Cross3f40fa42015-01-30 17:27:36 -0800175
176 // Architecture variant cflags
Colin Crossb98c8b02016-07-29 13:44:28 -0700177 pctx.StaticVariable("ArmArmv5TECflags", strings.Join(armArchVariantCflags["armv5te"], " "))
178 pctx.StaticVariable("ArmArmv7ACflags", strings.Join(armArchVariantCflags["armv7-a"], " "))
179 pctx.StaticVariable("ArmArmv7ANeonCflags", strings.Join(armArchVariantCflags["armv7-a-neon"], " "))
Colin Cross3f40fa42015-01-30 17:27:36 -0800180
Colin Cross3f40fa42015-01-30 17:27:36 -0800181 // Cpu variant cflags
Colin Crossb98c8b02016-07-29 13:44:28 -0700182 pctx.StaticVariable("ArmGenericCflags", strings.Join(armCpuVariantCflags[""], " "))
183 pctx.StaticVariable("ArmCortexA7Cflags", strings.Join(armCpuVariantCflags["cortex-a7"], " "))
184 pctx.StaticVariable("ArmCortexA8Cflags", strings.Join(armCpuVariantCflags["cortex-a8"], " "))
185 pctx.StaticVariable("ArmCortexA15Cflags", strings.Join(armCpuVariantCflags["cortex-a15"], " "))
186 pctx.StaticVariable("ArmKraitCflags", strings.Join(armCpuVariantCflags["krait"], " "))
Colin Cross3f40fa42015-01-30 17:27:36 -0800187
188 // Clang cflags
Colin Crossb98c8b02016-07-29 13:44:28 -0700189 pctx.StaticVariable("ArmToolchainClangCflags", strings.Join(ClangFilterUnknownCflags(armToolchainCflags), " "))
190 pctx.StaticVariable("ArmClangCflags", strings.Join(ClangFilterUnknownCflags(armCflags), " "))
191 pctx.StaticVariable("ArmClangLdflags", strings.Join(ClangFilterUnknownCflags(armLdflags), " "))
192 pctx.StaticVariable("ArmClangCppflags", strings.Join(ClangFilterUnknownCflags(armCppflags), " "))
Colin Cross3f40fa42015-01-30 17:27:36 -0800193
Dan Willemsen6d11dd82015-11-03 14:27:00 -0800194 // Clang ARM vs. Thumb instruction set cflags
Colin Crossb98c8b02016-07-29 13:44:28 -0700195 pctx.StaticVariable("ArmClangArmCflags", strings.Join(ClangFilterUnknownCflags(armArmCflags), " "))
196 pctx.StaticVariable("ArmClangThumbCflags", strings.Join(ClangFilterUnknownCflags(armThumbCflags), " "))
Dan Willemsen6d11dd82015-11-03 14:27:00 -0800197
Dan Willemsen110a89d2016-01-14 15:17:19 -0800198 // Clang arch variant cflags
Colin Crossb98c8b02016-07-29 13:44:28 -0700199 pctx.StaticVariable("ArmClangArmv5TECflags",
Colin Cross3f40fa42015-01-30 17:27:36 -0800200 strings.Join(armClangArchVariantCflags["armv5te"], " "))
Colin Crossb98c8b02016-07-29 13:44:28 -0700201 pctx.StaticVariable("ArmClangArmv7ACflags",
Colin Cross3f40fa42015-01-30 17:27:36 -0800202 strings.Join(armClangArchVariantCflags["armv7-a"], " "))
Colin Crossb98c8b02016-07-29 13:44:28 -0700203 pctx.StaticVariable("ArmClangArmv7ANeonCflags",
Colin Cross3f40fa42015-01-30 17:27:36 -0800204 strings.Join(armClangArchVariantCflags["armv7-a-neon"], " "))
205
206 // Clang cpu variant cflags
Colin Crossb98c8b02016-07-29 13:44:28 -0700207 pctx.StaticVariable("ArmClangGenericCflags",
Dan Willemsen110a89d2016-01-14 15:17:19 -0800208 strings.Join(armClangCpuVariantCflags[""], " "))
Colin Crossb98c8b02016-07-29 13:44:28 -0700209 pctx.StaticVariable("ArmClangCortexA7Cflags",
Colin Cross3f40fa42015-01-30 17:27:36 -0800210 strings.Join(armClangCpuVariantCflags["cortex-a7"], " "))
Colin Crossb98c8b02016-07-29 13:44:28 -0700211 pctx.StaticVariable("ArmClangCortexA8Cflags",
Colin Cross3f40fa42015-01-30 17:27:36 -0800212 strings.Join(armClangCpuVariantCflags["cortex-a8"], " "))
Colin Crossb98c8b02016-07-29 13:44:28 -0700213 pctx.StaticVariable("ArmClangCortexA15Cflags",
Colin Cross3f40fa42015-01-30 17:27:36 -0800214 strings.Join(armClangCpuVariantCflags["cortex-a15"], " "))
Colin Crossb98c8b02016-07-29 13:44:28 -0700215 pctx.StaticVariable("ArmClangKraitCflags",
Colin Cross3f40fa42015-01-30 17:27:36 -0800216 strings.Join(armClangCpuVariantCflags["krait"], " "))
217}
218
219var (
220 armArchVariantCflagsVar = map[string]string{
Colin Crossb98c8b02016-07-29 13:44:28 -0700221 "armv5te": "${config.ArmArmv5TECflags}",
222 "armv7-a": "${config.ArmArmv7ACflags}",
223 "armv7-a-neon": "${config.ArmArmv7ANeonCflags}",
Colin Cross3f40fa42015-01-30 17:27:36 -0800224 }
225
Colin Cross3f40fa42015-01-30 17:27:36 -0800226 armCpuVariantCflagsVar = map[string]string{
Colin Crossb98c8b02016-07-29 13:44:28 -0700227 "": "${config.ArmGenericCflags}",
228 "cortex-a7": "${config.ArmCortexA7Cflags}",
229 "cortex-a8": "${config.ArmCortexA8Cflags}",
230 "cortex-a15": "${config.ArmCortexA15Cflags}",
231 "cortex-a53": "${config.ArmCortexA7Cflags}",
232 "cortex-a53.a57": "${config.ArmCortexA7Cflags}",
233 "krait": "${config.ArmKraitCflags}",
234 "denver": "${config.ArmCortexA15Cflags}",
Colin Cross3f40fa42015-01-30 17:27:36 -0800235 }
236
237 armClangArchVariantCflagsVar = map[string]string{
Colin Crossb98c8b02016-07-29 13:44:28 -0700238 "armv5te": "${config.ArmClangArmv5TECflags}",
239 "armv7-a": "${config.ArmClangArmv7ACflags}",
240 "armv7-a-neon": "${config.ArmClangArmv7ANeonCflags}",
Colin Cross3f40fa42015-01-30 17:27:36 -0800241 }
242
243 armClangCpuVariantCflagsVar = map[string]string{
Colin Crossb98c8b02016-07-29 13:44:28 -0700244 "": "${config.ArmClangGenericCflags}",
245 "cortex-a7": "${config.ArmClangCortexA7Cflags}",
246 "cortex-a8": "${config.ArmClangCortexA8Cflags}",
247 "cortex-a15": "${config.ArmClangCortexA15Cflags}",
248 "cortex-a53": "${config.ArmClangCortexA7Cflags}",
249 "cortex-a53.a57": "${config.ArmClangCortexA7Cflags}",
250 "krait": "${config.ArmClangKraitCflags}",
251 "denver": "${config.ArmClangCortexA15Cflags}",
Colin Cross3f40fa42015-01-30 17:27:36 -0800252 }
253)
254
255type toolchainArm struct {
256 toolchain32Bit
Colin Crossc4bde762015-11-23 16:11:30 -0800257 ldflags string
258 toolchainCflags, toolchainClangCflags string
Colin Cross3f40fa42015-01-30 17:27:36 -0800259}
260
Dan Albertbe961682015-03-18 23:38:50 -0700261func (t *toolchainArm) Name() string {
262 return "arm"
263}
264
Colin Cross3f40fa42015-01-30 17:27:36 -0800265func (t *toolchainArm) GccRoot() string {
Colin Crossb98c8b02016-07-29 13:44:28 -0700266 return "${config.ArmGccRoot}"
Colin Cross3f40fa42015-01-30 17:27:36 -0800267}
268
269func (t *toolchainArm) GccTriple() string {
Dan Albert84f431f2016-07-20 14:44:26 -0700270 return "arm-linux-androideabi"
Colin Cross3f40fa42015-01-30 17:27:36 -0800271}
272
Dan Albertbe961682015-03-18 23:38:50 -0700273func (t *toolchainArm) GccVersion() string {
Dan Willemsen34fc3b12015-12-07 12:30:44 -0800274 return armGccVersion
Dan Albertbe961682015-03-18 23:38:50 -0700275}
276
Colin Crossc4bde762015-11-23 16:11:30 -0800277func (t *toolchainArm) ToolchainCflags() string {
278 return t.toolchainCflags
279}
280
Colin Cross3f40fa42015-01-30 17:27:36 -0800281func (t *toolchainArm) Cflags() string {
Colin Crossb98c8b02016-07-29 13:44:28 -0700282 return "${config.ArmCflags}"
Colin Cross3f40fa42015-01-30 17:27:36 -0800283}
284
285func (t *toolchainArm) Cppflags() string {
Colin Crossb98c8b02016-07-29 13:44:28 -0700286 return "${config.ArmCppflags}"
Colin Cross3f40fa42015-01-30 17:27:36 -0800287}
288
289func (t *toolchainArm) Ldflags() string {
290 return t.ldflags
291}
292
293func (t *toolchainArm) IncludeFlags() string {
Colin Crossb98c8b02016-07-29 13:44:28 -0700294 return "${config.ArmIncludeFlags}"
Colin Cross3f40fa42015-01-30 17:27:36 -0800295}
296
Tim Kilbourn1a9bf262015-03-18 12:28:32 -0700297func (t *toolchainArm) InstructionSetFlags(isa string) (string, error) {
298 switch isa {
299 case "arm":
Colin Crossb98c8b02016-07-29 13:44:28 -0700300 return "${config.ArmArmCflags}", nil
Tim Kilbourn1a9bf262015-03-18 12:28:32 -0700301 case "thumb", "":
Colin Crossb98c8b02016-07-29 13:44:28 -0700302 return "${config.ArmThumbCflags}", nil
Tim Kilbourn1a9bf262015-03-18 12:28:32 -0700303 default:
304 return t.toolchainBase.InstructionSetFlags(isa)
305 }
306}
307
Colin Cross3f40fa42015-01-30 17:27:36 -0800308func (t *toolchainArm) ClangTriple() string {
Dan Albert84f431f2016-07-20 14:44:26 -0700309 return t.GccTriple()
Colin Cross3f40fa42015-01-30 17:27:36 -0800310}
311
Colin Crossc4bde762015-11-23 16:11:30 -0800312func (t *toolchainArm) ToolchainClangCflags() string {
313 return t.toolchainClangCflags
314}
315
Colin Cross3f40fa42015-01-30 17:27:36 -0800316func (t *toolchainArm) ClangCflags() string {
Colin Crossb98c8b02016-07-29 13:44:28 -0700317 return "${config.ArmClangCflags}"
Colin Cross3f40fa42015-01-30 17:27:36 -0800318}
319
320func (t *toolchainArm) ClangCppflags() string {
Colin Crossb98c8b02016-07-29 13:44:28 -0700321 return "${config.ArmClangCppflags}"
Colin Cross3f40fa42015-01-30 17:27:36 -0800322}
323
324func (t *toolchainArm) ClangLdflags() string {
325 return t.ldflags
326}
327
Dan Willemsen6d11dd82015-11-03 14:27:00 -0800328func (t *toolchainArm) ClangInstructionSetFlags(isa string) (string, error) {
329 switch isa {
330 case "arm":
Colin Crossb98c8b02016-07-29 13:44:28 -0700331 return "${config.ArmClangArmCflags}", nil
Dan Willemsen6d11dd82015-11-03 14:27:00 -0800332 case "thumb", "":
Colin Crossb98c8b02016-07-29 13:44:28 -0700333 return "${config.ArmClangThumbCflags}", nil
Dan Willemsen6d11dd82015-11-03 14:27:00 -0800334 default:
335 return t.toolchainBase.ClangInstructionSetFlags(isa)
336 }
337}
338
Evgenii Stepanovaf36db12016-08-15 14:18:24 -0700339func (toolchainArm) SanitizerRuntimeLibraryArch() string {
340 return "arm"
Colin Cross16b23492016-01-06 14:41:07 -0800341}
342
Colin Cross635c3b02016-05-18 15:37:25 -0700343func armToolchainFactory(arch android.Arch) Toolchain {
Colin Crossc1e814d2015-04-28 13:15:59 -0700344 var fixCortexA8 string
Dan Willemsen110a89d2016-01-14 15:17:19 -0800345 toolchainCflags := make([]string, 2, 3)
346 toolchainClangCflags := make([]string, 2, 3)
347
Colin Crossb98c8b02016-07-29 13:44:28 -0700348 toolchainCflags[0] = "${config.ArmToolchainCflags}"
Dan Willemsen110a89d2016-01-14 15:17:19 -0800349 toolchainCflags[1] = armArchVariantCflagsVar[arch.ArchVariant]
Colin Crossb98c8b02016-07-29 13:44:28 -0700350 toolchainClangCflags[0] = "${config.ArmToolchainClangCflags}"
Dan Willemsen110a89d2016-01-14 15:17:19 -0800351 toolchainClangCflags[1] = armClangArchVariantCflagsVar[arch.ArchVariant]
352
353 switch arch.ArchVariant {
354 case "armv7-a-neon":
355 switch arch.CpuVariant {
356 case "cortex-a8", "":
357 // Generic ARM might be a Cortex A8 -- better safe than sorry
358 fixCortexA8 = "-Wl,--fix-cortex-a8"
359 default:
360 fixCortexA8 = "-Wl,--no-fix-cortex-a8"
361 }
362
363 toolchainCflags = append(toolchainCflags,
364 variantOrDefault(armCpuVariantCflagsVar, arch.CpuVariant))
365 toolchainClangCflags = append(toolchainClangCflags,
366 variantOrDefault(armClangCpuVariantCflagsVar, arch.CpuVariant))
367 case "armv7-a":
Colin Crossc1e814d2015-04-28 13:15:59 -0700368 fixCortexA8 = "-Wl,--fix-cortex-a8"
Dan Willemsen110a89d2016-01-14 15:17:19 -0800369 case "armv5te":
370 // Nothing extra for armv5te
Colin Crossc1e814d2015-04-28 13:15:59 -0700371 default:
Dan Willemsen110a89d2016-01-14 15:17:19 -0800372 panic(fmt.Sprintf("Unknown ARM architecture version: %q", arch.ArchVariant))
Colin Crossc1e814d2015-04-28 13:15:59 -0700373 }
374
Colin Cross3f40fa42015-01-30 17:27:36 -0800375 return &toolchainArm{
Dan Willemsen110a89d2016-01-14 15:17:19 -0800376 toolchainCflags: strings.Join(toolchainCflags, " "),
Colin Cross3f40fa42015-01-30 17:27:36 -0800377 ldflags: strings.Join([]string{
Colin Crossb98c8b02016-07-29 13:44:28 -0700378 "${config.ArmLdflags}",
Colin Crossc1e814d2015-04-28 13:15:59 -0700379 fixCortexA8,
Colin Cross3f40fa42015-01-30 17:27:36 -0800380 }, " "),
Dan Willemsen110a89d2016-01-14 15:17:19 -0800381 toolchainClangCflags: strings.Join(toolchainClangCflags, " "),
Colin Cross3f40fa42015-01-30 17:27:36 -0800382 }
383}
384
385func init() {
Colin Crossa1ad8d12016-06-01 17:09:44 -0700386 registerToolchainFactory(android.Android, android.Arm, armToolchainFactory)
Colin Cross3f40fa42015-01-30 17:27:36 -0800387}