Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | f5a3eac | 2021-08-23 17:05:17 +0000 | [diff] [blame] | 1 | // Copyright 2021 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 15 | package bp2build |
| 16 | |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 0da7ce6 | 2021-08-23 17:04:20 +0000 | [diff] [blame] | 17 | /* |
| 18 | For shareable/common bp2build testing functionality and dumping ground for |
| 19 | specific-but-shared functionality among tests in package |
| 20 | */ |
| 21 | |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 22 | import ( |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 23 | "fmt" |
Chris Parsons | 5011e61 | 2023-09-13 23:33:20 +0000 | [diff] [blame] | 24 | "path/filepath" |
Chris Parsons | cd20903 | 2023-09-19 01:12:48 +0000 | [diff] [blame] | 25 | "regexp" |
Zi Wang | fba0a21 | 2023-03-07 16:48:19 -0800 | [diff] [blame] | 26 | "sort" |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 27 | "strings" |
Rupert Shuttleworth | 06559d0 | 2021-05-19 09:14:26 -0400 | [diff] [blame] | 28 | "testing" |
| 29 | |
Spandan Das | 5af0bd3 | 2022-09-28 20:43:08 +0000 | [diff] [blame] | 30 | "github.com/google/blueprint/proptools" |
| 31 | |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 32 | "android/soong/android" |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 33 | "android/soong/android/allowlists" |
Jingwen Chen | 7385067 | 2020-12-14 08:25:34 -0500 | [diff] [blame] | 34 | "android/soong/bazel" |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 35 | ) |
| 36 | |
Jingwen Chen | 91220d7 | 2021-03-24 02:18:33 -0400 | [diff] [blame] | 37 | var ( |
Rupert Shuttleworth | 06559d0 | 2021-05-19 09:14:26 -0400 | [diff] [blame] | 38 | buildDir string |
Jingwen Chen | 91220d7 | 2021-03-24 02:18:33 -0400 | [diff] [blame] | 39 | ) |
| 40 | |
Chris Parsons | cd20903 | 2023-09-19 01:12:48 +0000 | [diff] [blame] | 41 | var labelRegex = regexp.MustCompile(`^//([^: ]+):([^ ]+)$`) |
| 42 | var simpleModuleNameRegex = regexp.MustCompile(`^[^: /]+$`) |
| 43 | |
Jingwen Chen | 5146ac0 | 2021-09-02 11:44:42 +0000 | [diff] [blame] | 44 | func checkError(t *testing.T, errs []error, expectedErr error) bool { |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 45 | t.Helper() |
Jingwen Chen | 5146ac0 | 2021-09-02 11:44:42 +0000 | [diff] [blame] | 46 | |
Jingwen Chen | 5146ac0 | 2021-09-02 11:44:42 +0000 | [diff] [blame] | 47 | if len(errs) != 1 { |
Liz Kammer | 6eff323 | 2021-08-26 08:37:59 -0400 | [diff] [blame] | 48 | return false |
Jingwen Chen | 5146ac0 | 2021-09-02 11:44:42 +0000 | [diff] [blame] | 49 | } |
Liz Kammer | 5430953 | 2021-12-14 12:21:22 -0500 | [diff] [blame] | 50 | if strings.Contains(errs[0].Error(), expectedErr.Error()) { |
Jingwen Chen | 5146ac0 | 2021-09-02 11:44:42 +0000 | [diff] [blame] | 51 | return true |
| 52 | } |
| 53 | |
| 54 | return false |
| 55 | } |
| 56 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 57 | func errored(t *testing.T, tc Bp2buildTestCase, errs []error) bool { |
Jingwen Chen | 5146ac0 | 2021-09-02 11:44:42 +0000 | [diff] [blame] | 58 | t.Helper() |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 59 | if tc.ExpectedErr != nil { |
Jingwen Chen | 5146ac0 | 2021-09-02 11:44:42 +0000 | [diff] [blame] | 60 | // Rely on checkErrors, as this test case is expected to have an error. |
| 61 | return false |
| 62 | } |
| 63 | |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 64 | if len(errs) > 0 { |
| 65 | for _, err := range errs { |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 66 | t.Errorf("%s: %s", tc.Description, err) |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 67 | } |
| 68 | return true |
| 69 | } |
Jingwen Chen | 5146ac0 | 2021-09-02 11:44:42 +0000 | [diff] [blame] | 70 | |
| 71 | // All good, continue execution. |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 72 | return false |
| 73 | } |
| 74 | |
Trevor Radcliffe | 1b4b2d9 | 2022-09-01 18:57:01 +0000 | [diff] [blame] | 75 | func RunBp2BuildTestCaseSimple(t *testing.T, tc Bp2buildTestCase) { |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 76 | t.Helper() |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 77 | RunBp2BuildTestCase(t, func(ctx android.RegistrationContext) {}, tc) |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 78 | } |
| 79 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 80 | type Bp2buildTestCase struct { |
| 81 | Description string |
| 82 | ModuleTypeUnderTest string |
| 83 | ModuleTypeUnderTestFactory android.ModuleFactory |
Sam Delmerico | 5840afc | 2023-06-12 15:44:03 -0400 | [diff] [blame] | 84 | // Text to add to the toplevel, root Android.bp file. If Dir is not set, all |
| 85 | // ExpectedBazelTargets are assumed to be generated by this file. |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 86 | Blueprint string |
Sam Delmerico | 5840afc | 2023-06-12 15:44:03 -0400 | [diff] [blame] | 87 | // ExpectedBazelTargets compares the BazelTargets generated in `Dir` (if not empty). |
| 88 | // Otherwise, it checks the BazelTargets generated by `Blueprint` in the root directory. |
| 89 | ExpectedBazelTargets []string |
Chris Parsons | 5011e61 | 2023-09-13 23:33:20 +0000 | [diff] [blame] | 90 | // AlreadyExistingBuildContents, if non-empty, simulates an already-present source BUILD file |
| 91 | // in the directory under test. The BUILD file has the given contents. This BUILD file |
| 92 | // will also be treated as "BUILD file to keep" by the simulated bp2build environment. |
| 93 | AlreadyExistingBuildContents string |
Chris Parsons | cd20903 | 2023-09-19 01:12:48 +0000 | [diff] [blame] | 94 | |
| 95 | // StubbedBuildDefinitions, if non-empty, adds stub definitions to already-present source |
| 96 | // BUILD files for each bazel label given. The BUILD files with these stub definitions |
| 97 | // are added to the BUILD file given in AlreadyExistingBuildContents. |
| 98 | // Labels may be of the form //pkg/to:target_name (which would be defined in pkg/to/BUILD.bazel) |
| 99 | // or `target_name` (which would be defined in ./BUILD.bazel). |
Chris Parsons | 5011e61 | 2023-09-13 23:33:20 +0000 | [diff] [blame] | 100 | StubbedBuildDefinitions []string |
| 101 | |
| 102 | Filesystem map[string]string |
Sam Delmerico | 5840afc | 2023-06-12 15:44:03 -0400 | [diff] [blame] | 103 | // Dir sets the directory which will be compared against the targets in ExpectedBazelTargets. |
| 104 | // This should used in conjunction with the Filesystem property to check for targets |
| 105 | // generated from a directory that is not the root. |
| 106 | // If not set, all ExpectedBazelTargets are assumed to be generated by the text in the |
| 107 | // Blueprint property. |
| 108 | Dir string |
Trevor Radcliffe | 58ea451 | 2022-04-07 20:36:39 +0000 | [diff] [blame] | 109 | // An error with a string contained within the string of the expected error |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 110 | ExpectedErr error |
| 111 | UnconvertedDepsMode unconvertedDepsMode |
Jingwen Chen | 0eeaeb8 | 2022-09-21 10:27:42 +0000 | [diff] [blame] | 112 | |
| 113 | // For every directory listed here, the BUILD file for that directory will |
| 114 | // be merged with the generated BUILD file. This allows custom BUILD targets |
| 115 | // to be used in tests, or use BUILD files to draw package boundaries. |
| 116 | KeepBuildFileForDirs []string |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 117 | } |
| 118 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 119 | func RunBp2BuildTestCase(t *testing.T, registerModuleTypes func(ctx android.RegistrationContext), tc Bp2buildTestCase) { |
Liz Kammer | ffc17e4 | 2022-11-23 09:42:05 -0500 | [diff] [blame] | 120 | t.Helper() |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 121 | bp2buildSetup := android.GroupFixturePreparers( |
| 122 | android.FixtureRegisterWithContext(registerModuleTypes), |
| 123 | SetBp2BuildTestRunner, |
| 124 | ) |
Spandan Das | 5af0bd3 | 2022-09-28 20:43:08 +0000 | [diff] [blame] | 125 | runBp2BuildTestCaseWithSetup(t, bp2buildSetup, tc) |
| 126 | } |
| 127 | |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 128 | func runBp2BuildTestCaseWithSetup(t *testing.T, extraPreparer android.FixturePreparer, tc Bp2buildTestCase) { |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 129 | t.Helper() |
Chris Parsons | cd20903 | 2023-09-19 01:12:48 +0000 | [diff] [blame] | 130 | if tc.Filesystem == nil { |
| 131 | tc.Filesystem = map[string]string{} |
| 132 | } |
Chris Parsons | 5011e61 | 2023-09-13 23:33:20 +0000 | [diff] [blame] | 133 | checkDir := "." |
| 134 | if tc.Dir != "" { |
| 135 | checkDir = tc.Dir |
| 136 | } |
| 137 | keepExistingBuildDirs := tc.KeepBuildFileForDirs |
| 138 | buildFilesToParse := []string{} |
Chris Parsons | cd20903 | 2023-09-19 01:12:48 +0000 | [diff] [blame] | 139 | |
| 140 | if len(tc.StubbedBuildDefinitions) > 0 { |
| 141 | for _, buildDef := range tc.StubbedBuildDefinitions { |
| 142 | globalLabelMatch := labelRegex.FindStringSubmatch(buildDef) |
| 143 | var dir, targetName string |
| 144 | if len(globalLabelMatch) > 0 { |
| 145 | dir = globalLabelMatch[1] |
| 146 | targetName = globalLabelMatch[2] |
| 147 | } else { |
| 148 | if !simpleModuleNameRegex.MatchString(buildDef) { |
| 149 | t.Errorf("Stubbed build definition '%s' must be either a simple module name or of global target syntax (//foo/bar:baz).", buildDef) |
| 150 | return |
| 151 | } |
| 152 | dir = "." |
| 153 | targetName = buildDef |
| 154 | } |
| 155 | buildFilePath := filepath.Join(dir, "BUILD") |
| 156 | tc.Filesystem[buildFilePath] += |
| 157 | MakeBazelTarget( |
| 158 | "bp2build_test_stub", |
| 159 | targetName, |
| 160 | AttrNameToString{}) |
| 161 | keepExistingBuildDirs = append(keepExistingBuildDirs, dir) |
| 162 | buildFilesToParse = append(buildFilesToParse, buildFilePath) |
| 163 | } |
| 164 | } |
| 165 | if len(tc.AlreadyExistingBuildContents) > 0 { |
| 166 | buildFilePath := filepath.Join(checkDir, "BUILD") |
| 167 | tc.Filesystem[buildFilePath] += tc.AlreadyExistingBuildContents |
| 168 | keepExistingBuildDirs = append(keepExistingBuildDirs, checkDir) |
| 169 | buildFilesToParse = append(buildFilesToParse, buildFilePath) |
| 170 | } |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 171 | filesystem := make(map[string][]byte) |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 172 | for f, content := range tc.Filesystem { |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 173 | filesystem[f] = []byte(content) |
| 174 | } |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 175 | preparers := []android.FixturePreparer{ |
| 176 | extraPreparer, |
| 177 | android.FixtureMergeMockFs(filesystem), |
| 178 | android.FixtureWithRootAndroidBp(tc.Blueprint), |
| 179 | android.FixtureRegisterWithContext(func(ctx android.RegistrationContext) { |
| 180 | ctx.RegisterModuleType(tc.ModuleTypeUnderTest, tc.ModuleTypeUnderTestFactory) |
| 181 | }), |
Chris Parsons | 5011e61 | 2023-09-13 23:33:20 +0000 | [diff] [blame] | 182 | android.FixtureModifyContextWithMockFs(func(ctx *android.TestContext) { |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 183 | // A default configuration for tests to not have to specify bp2build_available on top level |
| 184 | // targets. |
| 185 | bp2buildConfig := android.NewBp2BuildAllowlist().SetDefaultConfig( |
| 186 | allowlists.Bp2BuildConfig{ |
| 187 | android.Bp2BuildTopLevel: allowlists.Bp2BuildDefaultTrueRecursively, |
| 188 | }, |
| 189 | ) |
Chris Parsons | 5011e61 | 2023-09-13 23:33:20 +0000 | [diff] [blame] | 190 | for _, f := range keepExistingBuildDirs { |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 191 | bp2buildConfig.SetKeepExistingBuildFile(map[string]bool{ |
| 192 | f: /*recursive=*/ false, |
| 193 | }) |
| 194 | } |
| 195 | ctx.RegisterBp2BuildConfig(bp2buildConfig) |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 196 | // This setting is added to bp2build invocations. It prevents bp2build |
| 197 | // from cloning modules to their original state after mutators run. This |
| 198 | // would lose some data intentionally set by these mutators. |
| 199 | ctx.SkipCloneModulesAfterMutators = true |
Chris Parsons | 5011e61 | 2023-09-13 23:33:20 +0000 | [diff] [blame] | 200 | err := ctx.RegisterExistingBazelTargets(".", buildFilesToParse) |
| 201 | if err != nil { |
| 202 | t.Errorf("error parsing build files in test setup: %s", err) |
| 203 | } |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 204 | }), |
| 205 | android.FixtureModifyEnv(func(env map[string]string) { |
| 206 | if tc.UnconvertedDepsMode == errorModulesUnconvertedDeps { |
| 207 | env["BP2BUILD_ERROR_UNCONVERTED"] = "true" |
| 208 | } |
| 209 | }), |
Jingwen Chen | 5146ac0 | 2021-09-02 11:44:42 +0000 | [diff] [blame] | 210 | } |
| 211 | |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 212 | preparer := android.GroupFixturePreparers(preparers...) |
| 213 | if tc.ExpectedErr != nil { |
| 214 | pattern := "\\Q" + tc.ExpectedErr.Error() + "\\E" |
| 215 | preparer = preparer.ExtendWithErrorHandler(android.FixtureExpectsOneErrorPattern(pattern)) |
| 216 | } |
| 217 | result := preparer.RunTestWithCustomResult(t).(*BazelTestResult) |
| 218 | if len(result.Errs) > 0 { |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 219 | return |
| 220 | } |
| 221 | |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 222 | expectedTargets := map[string][]string{ |
| 223 | checkDir: tc.ExpectedBazelTargets, |
Liz Kammer | 6eff323 | 2021-08-26 08:37:59 -0400 | [diff] [blame] | 224 | } |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 225 | |
| 226 | result.CompareAllBazelTargets(t, tc.Description, expectedTargets, true) |
| 227 | } |
| 228 | |
| 229 | // SetBp2BuildTestRunner customizes the test fixture mechanism to run tests in Bp2Build mode. |
Chris Parsons | 73f411b | 2023-06-20 21:46:57 +0000 | [diff] [blame] | 230 | var SetBp2BuildTestRunner = android.FixtureSetTestRunner(&bazelTestRunner{}) |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 231 | |
Chris Parsons | 73f411b | 2023-06-20 21:46:57 +0000 | [diff] [blame] | 232 | // bazelTestRunner customizes the test fixture mechanism to run tests of the bp2build build mode. |
| 233 | type bazelTestRunner struct{} |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 234 | |
| 235 | func (b *bazelTestRunner) FinalPreparer(result *android.TestResult) android.CustomTestResult { |
| 236 | ctx := result.TestContext |
Chris Parsons | 73f411b | 2023-06-20 21:46:57 +0000 | [diff] [blame] | 237 | ctx.RegisterForBazelConversion() |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 238 | |
| 239 | return &BazelTestResult{TestResult: result} |
| 240 | } |
| 241 | |
| 242 | func (b *bazelTestRunner) PostParseProcessor(result android.CustomTestResult) { |
| 243 | bazelResult := result.(*BazelTestResult) |
| 244 | ctx := bazelResult.TestContext |
| 245 | config := bazelResult.Config |
| 246 | _, errs := ctx.ResolveDependencies(config) |
| 247 | if bazelResult.CollateErrs(errs) { |
| 248 | return |
| 249 | } |
| 250 | |
Chris Parsons | 73f411b | 2023-06-20 21:46:57 +0000 | [diff] [blame] | 251 | codegenCtx := NewCodegenContext(config, ctx.Context, Bp2Build, "") |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 252 | res, errs := GenerateBazelTargets(codegenCtx, false) |
| 253 | if bazelResult.CollateErrs(errs) { |
| 254 | return |
| 255 | } |
| 256 | |
| 257 | // Store additional data for access by tests. |
| 258 | bazelResult.conversionResults = res |
| 259 | } |
| 260 | |
| 261 | // BazelTestResult is a wrapper around android.TestResult to provide type safe access to the bazel |
| 262 | // specific data stored by the bazelTestRunner. |
| 263 | type BazelTestResult struct { |
| 264 | *android.TestResult |
| 265 | |
| 266 | // The result returned by the GenerateBazelTargets function. |
| 267 | conversionResults |
| 268 | } |
| 269 | |
| 270 | // CompareAllBazelTargets compares the BazelTargets produced by the test for all the directories |
| 271 | // with the supplied set of expected targets. |
| 272 | // |
| 273 | // If ignoreUnexpected=false then this enforces an exact match where every BazelTarget produced must |
| 274 | // have a corresponding expected BazelTarget. |
| 275 | // |
| 276 | // If ignoreUnexpected=true then it will ignore directories for which there are no expected targets. |
| 277 | func (b BazelTestResult) CompareAllBazelTargets(t *testing.T, description string, expectedTargets map[string][]string, ignoreUnexpected bool) { |
Liz Kammer | 2b3f56e | 2023-03-23 11:51:49 -0400 | [diff] [blame] | 278 | t.Helper() |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 279 | actualTargets := b.buildFileToTargets |
| 280 | |
| 281 | // Generate the sorted set of directories to check. |
Cole Faust | 18994c7 | 2023-02-28 16:02:16 -0800 | [diff] [blame] | 282 | dirsToCheck := android.SortedKeys(expectedTargets) |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 283 | if !ignoreUnexpected { |
| 284 | // This needs to perform an exact match so add the directories in which targets were |
| 285 | // produced to the list of directories to check. |
Cole Faust | 18994c7 | 2023-02-28 16:02:16 -0800 | [diff] [blame] | 286 | dirsToCheck = append(dirsToCheck, android.SortedKeys(actualTargets)...) |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 287 | dirsToCheck = android.SortedUniqueStrings(dirsToCheck) |
| 288 | } |
| 289 | |
| 290 | for _, dir := range dirsToCheck { |
| 291 | expected := expectedTargets[dir] |
| 292 | actual := actualTargets[dir] |
| 293 | |
| 294 | if expected == nil { |
| 295 | if actual != nil { |
| 296 | t.Errorf("did not expect any bazel modules in %q but found %d", dir, len(actual)) |
| 297 | } |
| 298 | } else if actual == nil { |
| 299 | expectedCount := len(expected) |
| 300 | if expectedCount > 0 { |
| 301 | t.Errorf("expected %d bazel modules in %q but did not find any", expectedCount, dir) |
| 302 | } |
| 303 | } else { |
| 304 | b.CompareBazelTargets(t, description, expected, actual) |
| 305 | } |
| 306 | } |
| 307 | } |
| 308 | |
| 309 | func (b BazelTestResult) CompareBazelTargets(t *testing.T, description string, expectedContents []string, actualTargets BazelTargets) { |
Liz Kammer | 748d707 | 2023-01-25 12:07:43 -0500 | [diff] [blame] | 310 | t.Helper() |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 311 | if actualCount, expectedCount := len(actualTargets), len(expectedContents); actualCount != expectedCount { |
Sasha Smundak | 9d2f174 | 2022-08-04 13:28:38 -0700 | [diff] [blame] | 312 | t.Errorf("%s: Expected %d bazel target (%s), got %d (%s)", |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 313 | description, expectedCount, expectedContents, actualCount, actualTargets) |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 314 | } else { |
Zi Wang | fba0a21 | 2023-03-07 16:48:19 -0800 | [diff] [blame] | 315 | sort.SliceStable(actualTargets, func(i, j int) bool { |
| 316 | return actualTargets[i].name < actualTargets[j].name |
| 317 | }) |
| 318 | sort.SliceStable(expectedContents, func(i, j int) bool { |
| 319 | return getTargetName(expectedContents[i]) < getTargetName(expectedContents[j]) |
| 320 | }) |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 321 | for i, actualTarget := range actualTargets { |
| 322 | if w, g := expectedContents[i], actualTarget.content; w != g { |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 323 | t.Errorf( |
Paul Duffin | 4c0765a | 2022-10-29 17:48:00 +0100 | [diff] [blame] | 324 | "%s[%d]: Expected generated Bazel target to be `%s`, got `%s`", |
| 325 | description, i, w, g) |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 1c92aef | 2021-08-23 16:10:00 +0000 | [diff] [blame] | 326 | } |
| 327 | } |
| 328 | } |
| 329 | } |
| 330 | |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 331 | type nestedProps struct { |
Liz Kammer | 46fb7ab | 2021-12-01 10:09:34 -0500 | [diff] [blame] | 332 | Nested_prop *string |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 333 | } |
| 334 | |
Liz Kammer | 32a0339 | 2021-09-14 11:17:21 -0400 | [diff] [blame] | 335 | type EmbeddedProps struct { |
Liz Kammer | 46fb7ab | 2021-12-01 10:09:34 -0500 | [diff] [blame] | 336 | Embedded_prop *string |
Liz Kammer | 32a0339 | 2021-09-14 11:17:21 -0400 | [diff] [blame] | 337 | } |
| 338 | |
| 339 | type OtherEmbeddedProps struct { |
Liz Kammer | 46fb7ab | 2021-12-01 10:09:34 -0500 | [diff] [blame] | 340 | Other_embedded_prop *string |
Liz Kammer | 32a0339 | 2021-09-14 11:17:21 -0400 | [diff] [blame] | 341 | } |
| 342 | |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 343 | type customProps struct { |
Liz Kammer | 32a0339 | 2021-09-14 11:17:21 -0400 | [diff] [blame] | 344 | EmbeddedProps |
| 345 | *OtherEmbeddedProps |
| 346 | |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 347 | Bool_prop bool |
| 348 | Bool_ptr_prop *bool |
| 349 | // Ensure that properties tagged `blueprint:mutated` are omitted |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 3a019a6 | 2022-06-23 16:02:44 +0000 | [diff] [blame] | 350 | Int_prop int `blueprint:"mutated"` |
| 351 | Int64_ptr_prop *int64 |
| 352 | String_prop string |
| 353 | String_literal_prop *string `android:"arch_variant"` |
| 354 | String_ptr_prop *string |
| 355 | String_list_prop []string |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 356 | |
| 357 | Nested_props nestedProps |
| 358 | Nested_props_ptr *nestedProps |
Liz Kammer | 4562a3b | 2021-04-21 18:15:34 -0400 | [diff] [blame] | 359 | |
Liz Kammer | 32b77cf | 2021-08-04 15:17:02 -0400 | [diff] [blame] | 360 | Arch_paths []string `android:"path,arch_variant"` |
| 361 | Arch_paths_exclude []string `android:"path,arch_variant"` |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 362 | |
| 363 | // Prop used to indicate this conversion should be 1 module -> multiple targets |
| 364 | One_to_many_prop *bool |
Spandan Das | 5af0bd3 | 2022-09-28 20:43:08 +0000 | [diff] [blame] | 365 | |
| 366 | Api *string // File describing the APIs of this module |
Spandan Das | 6a448ec | 2023-04-19 17:36:12 +0000 | [diff] [blame] | 367 | |
| 368 | Test_config_setting *bool // Used to test generation of config_setting targets |
Spandan Das | 3131d67 | 2023-08-03 22:33:47 +0000 | [diff] [blame] | 369 | |
| 370 | Dir *string // Dir in which the Bazel Target will be created |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 371 | } |
| 372 | |
| 373 | type customModule struct { |
| 374 | android.ModuleBase |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 375 | android.BazelModuleBase |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 376 | |
| 377 | props customProps |
| 378 | } |
| 379 | |
| 380 | // OutputFiles is needed because some instances of this module use dist with a |
| 381 | // tag property which requires the module implements OutputFileProducer. |
| 382 | func (m *customModule) OutputFiles(tag string) (android.Paths, error) { |
| 383 | return android.PathsForTesting("path" + tag), nil |
| 384 | } |
| 385 | |
| 386 | func (m *customModule) GenerateAndroidBuildActions(ctx android.ModuleContext) { |
| 387 | // nothing for now. |
| 388 | } |
| 389 | |
| 390 | func customModuleFactoryBase() android.Module { |
| 391 | module := &customModule{} |
| 392 | module.AddProperties(&module.props) |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 393 | android.InitBazelModule(module) |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 394 | return module |
| 395 | } |
| 396 | |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 397 | func customModuleFactoryHostAndDevice() android.Module { |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 398 | m := customModuleFactoryBase() |
Liz Kammer | 4562a3b | 2021-04-21 18:15:34 -0400 | [diff] [blame] | 399 | android.InitAndroidArchModule(m, android.HostAndDeviceSupported, android.MultilibBoth) |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 400 | return m |
| 401 | } |
| 402 | |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 403 | func customModuleFactoryDeviceSupported() android.Module { |
| 404 | m := customModuleFactoryBase() |
| 405 | android.InitAndroidArchModule(m, android.DeviceSupported, android.MultilibBoth) |
| 406 | return m |
| 407 | } |
| 408 | |
| 409 | func customModuleFactoryHostSupported() android.Module { |
| 410 | m := customModuleFactoryBase() |
| 411 | android.InitAndroidArchModule(m, android.HostSupported, android.MultilibBoth) |
| 412 | return m |
| 413 | } |
| 414 | |
| 415 | func customModuleFactoryHostAndDeviceDefault() android.Module { |
| 416 | m := customModuleFactoryBase() |
| 417 | android.InitAndroidArchModule(m, android.HostAndDeviceDefault, android.MultilibBoth) |
| 418 | return m |
| 419 | } |
| 420 | |
| 421 | func customModuleFactoryNeitherHostNorDeviceSupported() android.Module { |
| 422 | m := customModuleFactoryBase() |
| 423 | android.InitAndroidArchModule(m, android.NeitherHostNorDeviceSupported, android.MultilibBoth) |
| 424 | return m |
| 425 | } |
| 426 | |
Liz Kammer | 2dd9ca4 | 2020-11-25 16:06:39 -0800 | [diff] [blame] | 427 | type testProps struct { |
| 428 | Test_prop struct { |
| 429 | Test_string_prop string |
| 430 | } |
| 431 | } |
| 432 | |
| 433 | type customTestModule struct { |
| 434 | android.ModuleBase |
| 435 | |
| 436 | props customProps |
| 437 | test_props testProps |
| 438 | } |
| 439 | |
| 440 | func (m *customTestModule) GenerateAndroidBuildActions(ctx android.ModuleContext) { |
| 441 | // nothing for now. |
| 442 | } |
| 443 | |
| 444 | func customTestModuleFactoryBase() android.Module { |
| 445 | m := &customTestModule{} |
| 446 | m.AddProperties(&m.props) |
| 447 | m.AddProperties(&m.test_props) |
| 448 | return m |
| 449 | } |
| 450 | |
| 451 | func customTestModuleFactory() android.Module { |
| 452 | m := customTestModuleFactoryBase() |
| 453 | android.InitAndroidModule(m) |
| 454 | return m |
| 455 | } |
| 456 | |
| 457 | type customDefaultsModule struct { |
| 458 | android.ModuleBase |
| 459 | android.DefaultsModuleBase |
| 460 | } |
| 461 | |
| 462 | func customDefaultsModuleFactoryBase() android.DefaultsModule { |
| 463 | module := &customDefaultsModule{} |
| 464 | module.AddProperties(&customProps{}) |
| 465 | return module |
| 466 | } |
| 467 | |
| 468 | func customDefaultsModuleFactoryBasic() android.Module { |
| 469 | return customDefaultsModuleFactoryBase() |
| 470 | } |
| 471 | |
| 472 | func customDefaultsModuleFactory() android.Module { |
| 473 | m := customDefaultsModuleFactoryBase() |
| 474 | android.InitDefaultsModule(m) |
| 475 | return m |
| 476 | } |
Jingwen Chen | 7385067 | 2020-12-14 08:25:34 -0500 | [diff] [blame] | 477 | |
Liz Kammer | 32a0339 | 2021-09-14 11:17:21 -0400 | [diff] [blame] | 478 | type EmbeddedAttr struct { |
Liz Kammer | 46fb7ab | 2021-12-01 10:09:34 -0500 | [diff] [blame] | 479 | Embedded_attr *string |
Liz Kammer | 32a0339 | 2021-09-14 11:17:21 -0400 | [diff] [blame] | 480 | } |
| 481 | |
| 482 | type OtherEmbeddedAttr struct { |
Liz Kammer | 46fb7ab | 2021-12-01 10:09:34 -0500 | [diff] [blame] | 483 | Other_embedded_attr *string |
Liz Kammer | 32a0339 | 2021-09-14 11:17:21 -0400 | [diff] [blame] | 484 | } |
| 485 | |
Jingwen Chen | 7385067 | 2020-12-14 08:25:34 -0500 | [diff] [blame] | 486 | type customBazelModuleAttributes struct { |
Liz Kammer | 32a0339 | 2021-09-14 11:17:21 -0400 | [diff] [blame] | 487 | EmbeddedAttr |
| 488 | *OtherEmbeddedAttr |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 3a019a6 | 2022-06-23 16:02:44 +0000 | [diff] [blame] | 489 | String_literal_prop bazel.StringAttribute |
| 490 | String_ptr_prop *string |
| 491 | String_list_prop []string |
| 492 | Arch_paths bazel.LabelListAttribute |
Spandan Das | 5af0bd3 | 2022-09-28 20:43:08 +0000 | [diff] [blame] | 493 | Api bazel.LabelAttribute |
Jingwen Chen | 7385067 | 2020-12-14 08:25:34 -0500 | [diff] [blame] | 494 | } |
| 495 | |
Spandan Das | 3131d67 | 2023-08-03 22:33:47 +0000 | [diff] [blame] | 496 | func (m *customModule) dir() *string { |
| 497 | return m.props.Dir |
| 498 | } |
| 499 | |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 500 | func (m *customModule) ConvertWithBp2build(ctx android.TopDownMutatorContext) { |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 501 | if p := m.props.One_to_many_prop; p != nil && *p { |
| 502 | customBp2buildOneToMany(ctx, m) |
| 503 | return |
| 504 | } |
Liz Kammer | 4562a3b | 2021-04-21 18:15:34 -0400 | [diff] [blame] | 505 | |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 3a019a6 | 2022-06-23 16:02:44 +0000 | [diff] [blame] | 506 | paths := bazel.LabelListAttribute{} |
| 507 | strAttr := bazel.StringAttribute{} |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 508 | for axis, configToProps := range m.GetArchVariantProperties(ctx, &customProps{}) { |
| 509 | for config, props := range configToProps { |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 3a019a6 | 2022-06-23 16:02:44 +0000 | [diff] [blame] | 510 | if custProps, ok := props.(*customProps); ok { |
| 511 | if custProps.Arch_paths != nil { |
| 512 | paths.SetSelectValue(axis, config, android.BazelLabelForModuleSrcExcludes(ctx, custProps.Arch_paths, custProps.Arch_paths_exclude)) |
| 513 | } |
| 514 | if custProps.String_literal_prop != nil { |
| 515 | strAttr.SetSelectValue(axis, config, custProps.String_literal_prop) |
| 516 | } |
Liz Kammer | 4562a3b | 2021-04-21 18:15:34 -0400 | [diff] [blame] | 517 | } |
| 518 | } |
Jingwen Chen | 7385067 | 2020-12-14 08:25:34 -0500 | [diff] [blame] | 519 | } |
Liz Kammer | 9e2a5a7 | 2023-09-19 08:41:14 -0400 | [diff] [blame^] | 520 | productVariableProps, errs := android.ProductVariableProperties(ctx, ctx.Module()) |
| 521 | for _, err := range errs { |
| 522 | ctx.ModuleErrorf("ProductVariableProperties error: %s", err) |
| 523 | } |
Liz Kammer | 9d2d410 | 2022-12-21 14:51:37 -0500 | [diff] [blame] | 524 | if props, ok := productVariableProps["String_literal_prop"]; ok { |
| 525 | for c, p := range props { |
| 526 | if val, ok := p.(*string); ok { |
| 527 | strAttr.SetSelectValue(c.ConfigurationAxis(), c.SelectKey(), val) |
| 528 | } |
| 529 | } |
| 530 | } |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 531 | |
| 532 | paths.ResolveExcludes() |
| 533 | |
| 534 | attrs := &customBazelModuleAttributes{ |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 3a019a6 | 2022-06-23 16:02:44 +0000 | [diff] [blame] | 535 | String_literal_prop: strAttr, |
| 536 | String_ptr_prop: m.props.String_ptr_prop, |
| 537 | String_list_prop: m.props.String_list_prop, |
| 538 | Arch_paths: paths, |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 539 | } |
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux | 3a019a6 | 2022-06-23 16:02:44 +0000 | [diff] [blame] | 540 | |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 541 | attrs.Embedded_attr = m.props.Embedded_prop |
| 542 | if m.props.OtherEmbeddedProps != nil { |
| 543 | attrs.OtherEmbeddedAttr = &OtherEmbeddedAttr{Other_embedded_attr: m.props.OtherEmbeddedProps.Other_embedded_prop} |
| 544 | } |
| 545 | |
| 546 | props := bazel.BazelTargetModuleProperties{ |
| 547 | Rule_class: "custom", |
| 548 | } |
| 549 | |
Spandan Das | 3131d67 | 2023-08-03 22:33:47 +0000 | [diff] [blame] | 550 | ctx.CreateBazelTargetModule(props, android.CommonAttributes{Name: m.Name(), Dir: m.dir()}, attrs) |
Spandan Das | 6a448ec | 2023-04-19 17:36:12 +0000 | [diff] [blame] | 551 | |
| 552 | if proptools.Bool(m.props.Test_config_setting) { |
| 553 | m.createConfigSetting(ctx) |
| 554 | } |
| 555 | |
| 556 | } |
| 557 | |
| 558 | func (m *customModule) createConfigSetting(ctx android.TopDownMutatorContext) { |
| 559 | csa := bazel.ConfigSettingAttributes{ |
| 560 | Flag_values: bazel.StringMapAttribute{ |
| 561 | "//build/bazel/rules/my_string_setting": m.Name(), |
| 562 | }, |
| 563 | } |
| 564 | ca := android.CommonAttributes{ |
| 565 | Name: m.Name() + "_config_setting", |
| 566 | } |
| 567 | ctx.CreateBazelConfigSetting( |
| 568 | csa, |
| 569 | ca, |
| 570 | ctx.ModuleDir(), |
| 571 | ) |
Jingwen Chen | 7385067 | 2020-12-14 08:25:34 -0500 | [diff] [blame] | 572 | } |
Jingwen Chen | 40067de | 2021-01-26 21:58:43 -0500 | [diff] [blame] | 573 | |
Spandan Das | 5af0bd3 | 2022-09-28 20:43:08 +0000 | [diff] [blame] | 574 | var _ android.ApiProvider = (*customModule)(nil) |
| 575 | |
| 576 | func (c *customModule) ConvertWithApiBp2build(ctx android.TopDownMutatorContext) { |
| 577 | props := bazel.BazelTargetModuleProperties{ |
| 578 | Rule_class: "custom_api_contribution", |
| 579 | } |
| 580 | apiAttribute := bazel.MakeLabelAttribute( |
| 581 | android.BazelLabelForModuleSrcSingle(ctx, proptools.String(c.props.Api)).Label, |
| 582 | ) |
| 583 | attrs := &customBazelModuleAttributes{ |
| 584 | Api: *apiAttribute, |
| 585 | } |
| 586 | ctx.CreateBazelTargetModule(props, |
| 587 | android.CommonAttributes{Name: c.Name()}, |
| 588 | attrs) |
| 589 | } |
| 590 | |
Jingwen Chen | 40067de | 2021-01-26 21:58:43 -0500 | [diff] [blame] | 591 | // A bp2build mutator that uses load statements and creates a 1:M mapping from |
| 592 | // module to target. |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 593 | func customBp2buildOneToMany(ctx android.TopDownMutatorContext, m *customModule) { |
Jingwen Chen | 77e8b7b | 2021-02-05 03:03:24 -0500 | [diff] [blame] | 594 | |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 595 | baseName := m.Name() |
| 596 | attrs := &customBazelModuleAttributes{} |
Jingwen Chen | 1fd1469 | 2021-02-05 03:01:50 -0500 | [diff] [blame] | 597 | |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 598 | myLibraryProps := bazel.BazelTargetModuleProperties{ |
| 599 | Rule_class: "my_library", |
| 600 | Bzl_load_location: "//build/bazel/rules:rules.bzl", |
Jingwen Chen | 40067de | 2021-01-26 21:58:43 -0500 | [diff] [blame] | 601 | } |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 602 | ctx.CreateBazelTargetModule(myLibraryProps, android.CommonAttributes{Name: baseName}, attrs) |
| 603 | |
| 604 | protoLibraryProps := bazel.BazelTargetModuleProperties{ |
| 605 | Rule_class: "proto_library", |
| 606 | Bzl_load_location: "//build/bazel/rules:proto.bzl", |
| 607 | } |
| 608 | ctx.CreateBazelTargetModule(protoLibraryProps, android.CommonAttributes{Name: baseName + "_proto_library_deps"}, attrs) |
| 609 | |
| 610 | myProtoLibraryProps := bazel.BazelTargetModuleProperties{ |
| 611 | Rule_class: "my_proto_library", |
| 612 | Bzl_load_location: "//build/bazel/rules:proto.bzl", |
| 613 | } |
| 614 | ctx.CreateBazelTargetModule(myProtoLibraryProps, android.CommonAttributes{Name: baseName + "_my_proto_library_deps"}, attrs) |
Jingwen Chen | 40067de | 2021-01-26 21:58:43 -0500 | [diff] [blame] | 615 | } |
Jingwen Chen | ba369ad | 2021-02-22 10:19:34 -0500 | [diff] [blame] | 616 | |
| 617 | // Helper method for tests to easily access the targets in a dir. |
Liz Kammer | 6eff323 | 2021-08-26 08:37:59 -0400 | [diff] [blame] | 618 | func generateBazelTargetsForDir(codegenCtx *CodegenContext, dir string) (BazelTargets, []error) { |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 619 | // TODO: Set generateFilegroups to true and/or remove the generateFilegroups argument completely |
Liz Kammer | 6eff323 | 2021-08-26 08:37:59 -0400 | [diff] [blame] | 620 | res, err := GenerateBazelTargets(codegenCtx, false) |
Alix | 94e2603 | 2022-08-16 20:37:33 +0000 | [diff] [blame] | 621 | if err != nil { |
| 622 | return BazelTargets{}, err |
| 623 | } |
Liz Kammer | 6eff323 | 2021-08-26 08:37:59 -0400 | [diff] [blame] | 624 | return res.buildFileToTargets[dir], err |
Jingwen Chen | ba369ad | 2021-02-22 10:19:34 -0500 | [diff] [blame] | 625 | } |
Liz Kammer | 32b77cf | 2021-08-04 15:17:02 -0400 | [diff] [blame] | 626 | |
| 627 | func registerCustomModuleForBp2buildConversion(ctx *android.TestContext) { |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 628 | ctx.RegisterModuleType("custom", customModuleFactoryHostAndDevice) |
Liz Kammer | 32b77cf | 2021-08-04 15:17:02 -0400 | [diff] [blame] | 629 | ctx.RegisterForBazelConversion() |
| 630 | } |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 631 | |
Chris Parsons | cd20903 | 2023-09-19 01:12:48 +0000 | [diff] [blame] | 632 | func simpleModule(typ, name string) string { |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 633 | return fmt.Sprintf(` |
| 634 | %s { |
| 635 | name: "%s", |
Liz Kammer | 7a210ac | 2021-09-22 15:52:58 -0400 | [diff] [blame] | 636 | }`, typ, name) |
| 637 | } |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 638 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 639 | type AttrNameToString map[string]string |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 640 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 641 | func (a AttrNameToString) clone() AttrNameToString { |
| 642 | newAttrs := make(AttrNameToString, len(a)) |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 643 | for k, v := range a { |
| 644 | newAttrs[k] = v |
| 645 | } |
| 646 | return newAttrs |
| 647 | } |
| 648 | |
| 649 | // makeBazelTargetNoRestrictions returns bazel target build file definition that can be host or |
| 650 | // device specific, or independent of host/device. |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 651 | func makeBazelTargetHostOrDevice(typ, name string, attrs AttrNameToString, hod android.HostOrDeviceSupported) string { |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 652 | if _, ok := attrs["target_compatible_with"]; !ok { |
| 653 | switch hod { |
| 654 | case android.HostSupported: |
| 655 | attrs["target_compatible_with"] = `select({ |
| 656 | "//build/bazel/platforms/os:android": ["@platforms//:incompatible"], |
| 657 | "//conditions:default": [], |
| 658 | })` |
| 659 | case android.DeviceSupported: |
| 660 | attrs["target_compatible_with"] = `["//build/bazel/platforms/os:android"]` |
| 661 | } |
| 662 | } |
| 663 | |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 664 | attrStrings := make([]string, 0, len(attrs)+1) |
Sasha Smundak | fb58949 | 2022-08-04 11:13:27 -0700 | [diff] [blame] | 665 | if name != "" { |
| 666 | attrStrings = append(attrStrings, fmt.Sprintf(` name = "%s",`, name)) |
| 667 | } |
Cole Faust | 18994c7 | 2023-02-28 16:02:16 -0800 | [diff] [blame] | 668 | for _, k := range android.SortedKeys(attrs) { |
Liz Kammer | 78cfdaa | 2021-11-08 12:56:31 -0500 | [diff] [blame] | 669 | attrStrings = append(attrStrings, fmt.Sprintf(" %s = %s,", k, attrs[k])) |
| 670 | } |
| 671 | return fmt.Sprintf(`%s( |
| 672 | %s |
| 673 | )`, typ, strings.Join(attrStrings, "\n")) |
| 674 | } |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 675 | |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 676 | // MakeBazelTargetNoRestrictions returns bazel target build file definition that does not add a |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 677 | // target_compatible_with. This is useful for module types like filegroup and genrule that arch not |
| 678 | // arch variant |
Sam Delmerico | 3177a6e | 2022-06-21 19:28:33 +0000 | [diff] [blame] | 679 | func MakeBazelTargetNoRestrictions(typ, name string, attrs AttrNameToString) string { |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 680 | return makeBazelTargetHostOrDevice(typ, name, attrs, android.HostAndDeviceDefault) |
| 681 | } |
| 682 | |
| 683 | // makeBazelTargetNoRestrictions returns bazel target build file definition that is device specific |
| 684 | // as this is the most common default in Soong. |
Alix | e06d75b | 2022-08-31 18:28:19 +0000 | [diff] [blame] | 685 | func MakeBazelTarget(typ, name string, attrs AttrNameToString) string { |
Liz Kammer | dfeb120 | 2022-05-13 17:20:20 -0400 | [diff] [blame] | 686 | return makeBazelTargetHostOrDevice(typ, name, attrs, android.DeviceSupported) |
| 687 | } |
Sasha Smundak | 9d2f174 | 2022-08-04 13:28:38 -0700 | [diff] [blame] | 688 | |
| 689 | type ExpectedRuleTarget struct { |
| 690 | Rule string |
| 691 | Name string |
| 692 | Attrs AttrNameToString |
| 693 | Hod android.HostOrDeviceSupported |
| 694 | } |
| 695 | |
| 696 | func (ebr ExpectedRuleTarget) String() string { |
| 697 | return makeBazelTargetHostOrDevice(ebr.Rule, ebr.Name, ebr.Attrs, ebr.Hod) |
| 698 | } |
Trevor Radcliffe | 087af54 | 2022-09-16 15:36:10 +0000 | [diff] [blame] | 699 | |
| 700 | func makeCcStubSuiteTargets(name string, attrs AttrNameToString) string { |
| 701 | if _, hasStubs := attrs["stubs_symbol_file"]; !hasStubs { |
| 702 | return "" |
| 703 | } |
| 704 | STUB_SUITE_ATTRS := map[string]string{ |
Spandan Das | 04f9f4c | 2023-09-13 23:59:05 +0000 | [diff] [blame] | 705 | "api_surface": "api_surface", |
Sam Delmerico | 5f90649 | 2023-03-15 18:06:18 -0400 | [diff] [blame] | 706 | "stubs_symbol_file": "symbol_file", |
| 707 | "stubs_versions": "versions", |
| 708 | "soname": "soname", |
| 709 | "source_library_label": "source_library_label", |
Trevor Radcliffe | 087af54 | 2022-09-16 15:36:10 +0000 | [diff] [blame] | 710 | } |
| 711 | |
| 712 | stubSuiteAttrs := AttrNameToString{} |
| 713 | for key, _ := range attrs { |
| 714 | if _, stubSuiteAttr := STUB_SUITE_ATTRS[key]; stubSuiteAttr { |
| 715 | stubSuiteAttrs[STUB_SUITE_ATTRS[key]] = attrs[key] |
Sam Delmerico | 5f90649 | 2023-03-15 18:06:18 -0400 | [diff] [blame] | 716 | } else { |
| 717 | panic(fmt.Sprintf("unused cc_stub_suite attr %q\n", key)) |
Trevor Radcliffe | 087af54 | 2022-09-16 15:36:10 +0000 | [diff] [blame] | 718 | } |
| 719 | } |
| 720 | return MakeBazelTarget("cc_stub_suite", name+"_stub_libs", stubSuiteAttrs) |
| 721 | } |
Alix | 341484b | 2022-10-31 19:08:18 +0000 | [diff] [blame] | 722 | |
| 723 | func MakeNeverlinkDuplicateTarget(moduleType string, name string) string { |
Liz Kammer | 0291440 | 2023-08-07 13:38:18 -0400 | [diff] [blame] | 724 | return MakeNeverlinkDuplicateTargetWithAttrs(moduleType, name, AttrNameToString{ |
| 725 | "sdk_version": `"current"`, // use as default |
| 726 | }) |
Romain Jobredeaux | 2eef2e1 | 2023-02-24 12:07:08 -0500 | [diff] [blame] | 727 | } |
| 728 | |
| 729 | func MakeNeverlinkDuplicateTargetWithAttrs(moduleType string, name string, extraAttrs AttrNameToString) string { |
| 730 | attrs := extraAttrs |
| 731 | attrs["neverlink"] = `True` |
| 732 | attrs["exports"] = `[":` + name + `"]` |
| 733 | return MakeBazelTarget(moduleType, name+"-neverlink", attrs) |
Alix | 341484b | 2022-10-31 19:08:18 +0000 | [diff] [blame] | 734 | } |
Zi Wang | fba0a21 | 2023-03-07 16:48:19 -0800 | [diff] [blame] | 735 | |
| 736 | func getTargetName(targetContent string) string { |
| 737 | data := strings.Split(targetContent, "name = \"") |
| 738 | if len(data) < 2 { |
| 739 | return "" |
| 740 | } else { |
| 741 | endIndex := strings.Index(data[1], "\"") |
| 742 | return data[1][:endIndex] |
| 743 | } |
| 744 | } |