Gitiles
Code Review Sign In
gerrit.omnirom.org / android_build_soong / 878a7f16326a9a638d19e306592adb5439f3169a / . / android / bazel.go
blob: c5e7dfd2499458ee62ee4590cb68025d97b0aa85 [file] [log] [blame]
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]1// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package android
16
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]17import (
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]18 "bufio"
19 "errors"
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]20 "fmt"
21 "io/ioutil"
22 "path/filepath"
23 "strings"
24
Liz Kammerbdc60992021-02-24 16:55:11 -0500[diff] [blame]25 "github.com/google/blueprint"
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]26 "github.com/google/blueprint/proptools"
27)
28
Jingwen Chen01812022021-11-19 14:29:43 +0000[diff] [blame]29type bazelModuleProperties struct {
30 // The label of the Bazel target replacing this Soong module. When run in conversion mode, this
31 // will import the handcrafted build target into the autogenerated file. Note: this may result in
32 // a conflict due to duplicate targets if bp2build_available is also set.
33 Label *string
34
35 // If true, bp2build will generate the converted Bazel target for this module. Note: this may
36 // cause a conflict due to the duplicate targets if label is also set.
37 //
38 // This is a bool pointer to support tristates: true, false, not set.
39 //
40 // To opt-in a module, set bazel_module: { bp2build_available: true }
41 // To opt-out a module, set bazel_module: { bp2build_available: false }
42 // To defer the default setting for the directory, do not set the value.
43 Bp2build_available *bool
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]44
45 // CanConvertToBazel is set via InitBazelModule to indicate that a module type can be converted to
46 // Bazel with Bp2build.
47 CanConvertToBazel bool `blueprint:"mutated"`
Jingwen Chen01812022021-11-19 14:29:43 +0000[diff] [blame]48}
49
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]50// Properties contains common module properties for Bazel migration purposes.
51type properties struct {
52 // In USE_BAZEL_ANALYSIS=1 mode, this represents the Bazel target replacing
53 // this Soong module.
Jingwen Chen01812022021-11-19 14:29:43 +0000[diff] [blame]54 Bazel_module bazelModuleProperties
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]55}
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]56
Jingwen Chen25825ca2021-11-15 12:28:43 +0000[diff] [blame]57// namespacedVariableProperties is a map from a string representing a Soong
Jingwen Chen84817de2021-11-17 10:57:35 +0000[diff] [blame]58// config variable namespace, like "android" or "vendor_name" to a slice of
59// pointer to a struct containing a single field called Soong_config_variables
60// whose value mirrors the structure in the Blueprint file.
61type namespacedVariableProperties map[string][]interface{}
Jingwen Chena47f28d2021-11-02 16:43:57 +0000[diff] [blame]62
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]63// BazelModuleBase contains the property structs with metadata for modules which can be converted to
64// Bazel.
65type BazelModuleBase struct {
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]66 bazelProperties properties
Jingwen Chena47f28d2021-11-02 16:43:57 +0000[diff] [blame]67
68 // namespacedVariableProperties is used for soong_config_module_type support
69 // in bp2build. Soong config modules allow users to set module properties
70 // based on custom product variables defined in Android.bp files. These
71 // variables are namespaced to prevent clobbering, especially when set from
72 // Makefiles.
73 namespacedVariableProperties namespacedVariableProperties
74
75 // baseModuleType is set when this module was created from a module type
76 // defined by a soong_config_module_type. Every soong_config_module_type
77 // "wraps" another module type, e.g. a soong_config_module_type can wrap a
78 // cc_defaults to a custom_cc_defaults, or cc_binary to a custom_cc_binary.
79 // This baseModuleType is set to the wrapped module type.
80 baseModuleType string
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]81}
82
83// Bazelable is specifies the interface for modules that can be converted to Bazel.
84type Bazelable interface {
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]85 bazelProps() *properties
86 HasHandcraftedLabel() bool
Liz Kammerbdc60992021-02-24 16:55:11 -0500[diff] [blame]87 HandcraftedLabel() string
88 GetBazelLabel(ctx BazelConversionPathContext, module blueprint.Module) string
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]89 ShouldConvertWithBp2build(ctx BazelConversionContext) bool
90 shouldConvertWithBp2build(ctx BazelConversionContext, module blueprint.Module) bool
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]91 GetBazelBuildFileContents(c Config, path, name string) (string, error)
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]92 ConvertWithBp2build(ctx TopDownMutatorContext)
Jingwen Chena47f28d2021-11-02 16:43:57 +0000[diff] [blame]93
Jingwen Chen84817de2021-11-17 10:57:35 +0000[diff] [blame]94 // namespacedVariableProps is a map from a soong config variable namespace
95 // (e.g. acme, android) to a map of interfaces{}, which are really
96 // reflect.Struct pointers, representing the value of the
97 // soong_config_variables property of a module. The struct pointer is the
98 // one with the single member called Soong_config_variables, which itself is
99 // a struct containing fields for each supported feature in that namespace.
100 //
101 // The reason for using an slice of interface{} is to support defaults
102 // propagation of the struct pointers.
Jingwen Chena47f28d2021-11-02 16:43:57 +0000[diff] [blame]103 namespacedVariableProps() namespacedVariableProperties
104 setNamespacedVariableProps(props namespacedVariableProperties)
105 BaseModuleType() string
Jingwen Chen84817de2021-11-17 10:57:35 +0000[diff] [blame]106 SetBaseModuleType(baseModuleType string)
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]107}
108
109// BazelModule is a lightweight wrapper interface around Module for Bazel-convertible modules.
110type BazelModule interface {
111 Module
112 Bazelable
113}
114
115// InitBazelModule is a wrapper function that decorates a BazelModule with Bazel-conversion
116// properties.
117func InitBazelModule(module BazelModule) {
118 module.AddProperties(module.bazelProps())
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]119 module.bazelProps().Bazel_module.CanConvertToBazel = true
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]120}
121
122// bazelProps returns the Bazel properties for the given BazelModuleBase.
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]123func (b *BazelModuleBase) bazelProps() *properties {
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]124 return &b.bazelProperties
125}
126
Jingwen Chena47f28d2021-11-02 16:43:57 +0000[diff] [blame]127func (b *BazelModuleBase) namespacedVariableProps() namespacedVariableProperties {
128 return b.namespacedVariableProperties
129}
130
131func (b *BazelModuleBase) setNamespacedVariableProps(props namespacedVariableProperties) {
132 b.namespacedVariableProperties = props
133}
134
135func (b *BazelModuleBase) BaseModuleType() string {
136 return b.baseModuleType
137}
138
139func (b *BazelModuleBase) SetBaseModuleType(baseModuleType string) {
140 b.baseModuleType = baseModuleType
141}
142
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]143// HasHandcraftedLabel returns whether this module has a handcrafted Bazel label.
144func (b *BazelModuleBase) HasHandcraftedLabel() bool {
145 return b.bazelProperties.Bazel_module.Label != nil
146}
147
148// HandcraftedLabel returns the handcrafted label for this module, or empty string if there is none
149func (b *BazelModuleBase) HandcraftedLabel() string {
150 return proptools.String(b.bazelProperties.Bazel_module.Label)
151}
152
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]153// GetBazelLabel returns the Bazel label for the given BazelModuleBase.
Liz Kammerbdc60992021-02-24 16:55:11 -0500[diff] [blame]154func (b *BazelModuleBase) GetBazelLabel(ctx BazelConversionPathContext, module blueprint.Module) string {
155 if b.HasHandcraftedLabel() {
156 return b.HandcraftedLabel()
157 }
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]158 if b.ShouldConvertWithBp2build(ctx) {
Liz Kammerbdc60992021-02-24 16:55:11 -0500[diff] [blame]159 return bp2buildModuleLabel(ctx, module)
160 }
161 return "" // no label for unconverted module
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]162}
163
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]164// Configuration to decide if modules in a directory should default to true/false for bp2build_available
165type Bp2BuildConfig map[string]BazelConversionConfigEntry
166type BazelConversionConfigEntry int
167
168const (
Jingwen Chen91220d72021-03-24 02:18:33 -0400[diff] [blame]169 // A sentinel value to be used as a key in Bp2BuildConfig for modules with
170 // no package path. This is also the module dir for top level Android.bp
171 // modules.
172 BP2BUILD_TOPLEVEL = "."
173
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]174 // iota + 1 ensures that the int value is not 0 when used in the Bp2buildAllowlist map,
175 // which can also mean that the key doesn't exist in a lookup.
176
177 // all modules in this package and subpackages default to bp2build_available: true.
178 // allows modules to opt-out.
179 Bp2BuildDefaultTrueRecursively BazelConversionConfigEntry = iota + 1
180
Jingwen Chen294e7742021-08-31 05:58:01 +0000[diff] [blame]181 // all modules in this package (not recursively) default to bp2build_available: true.
182 // allows modules to opt-out.
183 Bp2BuildDefaultTrue
184
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]185 // all modules in this package (not recursively) default to bp2build_available: false.
186 // allows modules to opt-in.
187 Bp2BuildDefaultFalse
188)
189
190var (
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400[diff] [blame]191 // Keep any existing BUILD files (and do not generate new BUILD files) for these directories
Jingwen Chenb643c7a2021-07-26 04:45:48 +0000[diff] [blame]192 // in the synthetic Bazel workspace.
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400[diff] [blame]193 bp2buildKeepExistingBuildFile = map[string]bool{
194 // This is actually build/bazel/build.BAZEL symlinked to ./BUILD
Jingwen Chenf59a8e12021-07-16 09:28:53 +0000[diff] [blame]195 ".":/*recursive = */ false,
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400[diff] [blame]196
Jingwen Chenb643c7a2021-07-26 04:45:48 +0000[diff] [blame]197 // build/bazel/examples/apex/... BUILD files should be generated, so
198 // build/bazel is not recursive. Instead list each subdirectory under
199 // build/bazel explicitly.
200 "build/bazel":/* recursive = */ false,
Jingwen Chen941f0ab2022-02-09 13:25:30 +0000[diff] [blame]201 "build/bazel/ci/dist":/* recursive = */ false,
Jingwen Chenb643c7a2021-07-26 04:45:48 +0000[diff] [blame]202 "build/bazel/examples/android_app":/* recursive = */ true,
Romain Jobredeaux5cc9c9d2021-08-26 15:07:48 +0000[diff] [blame]203 "build/bazel/examples/java":/* recursive = */ true,
Jingwen Chenb643c7a2021-07-26 04:45:48 +0000[diff] [blame]204 "build/bazel/bazel_skylib":/* recursive = */ true,
205 "build/bazel/rules":/* recursive = */ true,
206 "build/bazel/rules_cc":/* recursive = */ true,
Jingwen Chen294e7742021-08-31 05:58:01 +0000[diff] [blame]207 "build/bazel/scripts":/* recursive = */ true,
Jingwen Chenb643c7a2021-07-26 04:45:48 +0000[diff] [blame]208 "build/bazel/tests":/* recursive = */ true,
209 "build/bazel/platforms":/* recursive = */ true,
210 "build/bazel/product_variables":/* recursive = */ true,
Jingwen Chen5e49b822021-08-24 05:14:22 +0000[diff] [blame]211 "build/bazel_common_rules":/* recursive = */ true,
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]212 // build/make/tools/signapk BUILD file is generated, so build/make/tools is not recursive.
213 "build/make/tools":/* recursive = */ false,
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400[diff] [blame]214 "build/pesto":/* recursive = */ true,
215
216 // external/bazelbuild-rules_android/... is needed by mixed builds, otherwise mixed builds analysis fails
217 // e.g. ERROR: Analysis of target '@soong_injection//mixed_builds:buildroot' failed
218 "external/bazelbuild-rules_android":/* recursive = */ true,
Jingwen Chen91632252021-08-10 13:00:33 +0000[diff] [blame]219 "external/bazel-skylib":/* recursive = */ true,
Romain Jobredeaux9e09bba2021-09-08 18:09:02 +0000[diff] [blame]220 "external/guava":/* recursive = */ true,
Romain Jobredeaux9e09bba2021-09-08 18:09:02 +0000[diff] [blame]221 "external/jsr305":/* recursive = */ true,
222 "frameworks/ex/common":/* recursive = */ true,
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400[diff] [blame]223
Romain Jobredeauxf1b0ac82021-08-12 14:39:00 +0000[diff] [blame]224 "packages/apps/Music":/* recursive = */ true,
Romain Jobredeaux9e09bba2021-09-08 18:09:02 +0000[diff] [blame]225 "packages/apps/QuickSearchBox":/* recursive = */ true,
Romain Jobredeauxa2c08142021-09-22 14:43:43 -0400[diff] [blame]226 "packages/apps/WallpaperPicker":/* recursive = */ false,
227
Chris Parsons494eef32021-11-09 10:29:52 -0500[diff] [blame]228 "prebuilts/gcc":/* recursive = */ true,
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000[diff] [blame]229 "prebuilts/build-tools":/* recursive = */ false,
Romain Jobredeauxa2c08142021-09-22 14:43:43 -0400[diff] [blame]230 "prebuilts/sdk":/* recursive = */ false,
231 "prebuilts/sdk/current/extras/app-toolkit":/* recursive = */ false,
232 "prebuilts/sdk/current/support":/* recursive = */ false,
233 "prebuilts/sdk/tools":/* recursive = */ false,
234 "prebuilts/r8":/* recursive = */ false,
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400[diff] [blame]235 }
236
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]237 // Configure modules in these directories to enable bp2build_available: true or false by default.
238 bp2buildDefaultConfig = Bp2BuildConfig{
Liz Kammer35ca77e2021-12-22 15:31:40 -0500[diff] [blame]239 "art/libartpalette": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400[diff] [blame]240 "art/libdexfile": Bp2BuildDefaultTrueRecursively,
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500[diff] [blame]241 "art/runtime": Bp2BuildDefaultTrueRecursively,
242 "art/tools": Bp2BuildDefaultTrue,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400[diff] [blame]243 "bionic": Bp2BuildDefaultTrueRecursively,
244 "bootable/recovery/tools/recovery_l10n": Bp2BuildDefaultTrue,
Jingwen Chen0a9d09f2021-11-24 07:00:11 +0000[diff] [blame]245 "build/bazel/examples/soong_config_variables": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]246 "build/bazel/examples/apex/minimal": Bp2BuildDefaultTrueRecursively,
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]247 "build/make/tools/signapk": Bp2BuildDefaultTrue,
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]248 "build/soong": Bp2BuildDefaultTrue,
Rupert Shuttleworth2ac9c482021-11-10 10:37:05 -0500[diff] [blame]249 "build/soong/cc/libbuildversion": Bp2BuildDefaultTrue, // Skip tests subdir
Jingwen Chen89e21882021-11-30 11:16:06 +0000[diff] [blame]250 "build/soong/cc/ndkstubgen": Bp2BuildDefaultTrue,
251 "build/soong/cc/symbolfile": Bp2BuildDefaultTrue,
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500[diff] [blame]252 "build/soong/linkerconfig": Bp2BuildDefaultTrueRecursively,
Liz Kammer5c313582021-12-03 15:23:26 -0500[diff] [blame]253 "build/soong/scripts": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]254 "cts/common/device-side/nativetesthelper/jni": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400[diff] [blame]255 "development/apps/DevelopmentSettings": Bp2BuildDefaultTrue,
256 "development/apps/Fallback": Bp2BuildDefaultTrue,
257 "development/apps/WidgetPreview": Bp2BuildDefaultTrue,
258 "development/samples/BasicGLSurfaceView": Bp2BuildDefaultTrue,
259 "development/samples/BluetoothChat": Bp2BuildDefaultTrue,
260 "development/samples/BrokenKeyDerivation": Bp2BuildDefaultTrue,
261 "development/samples/Compass": Bp2BuildDefaultTrue,
262 "development/samples/ContactManager": Bp2BuildDefaultTrue,
263 "development/samples/FixedGridLayout": Bp2BuildDefaultTrue,
264 "development/samples/HelloEffects": Bp2BuildDefaultTrue,
265 "development/samples/Home": Bp2BuildDefaultTrue,
266 "development/samples/HoneycombGallery": Bp2BuildDefaultTrue,
267 "development/samples/JetBoy": Bp2BuildDefaultTrue,
268 "development/samples/KeyChainDemo": Bp2BuildDefaultTrue,
269 "development/samples/LceDemo": Bp2BuildDefaultTrue,
270 "development/samples/LunarLander": Bp2BuildDefaultTrue,
271 "development/samples/MultiResolution": Bp2BuildDefaultTrue,
272 "development/samples/MultiWindow": Bp2BuildDefaultTrue,
273 "development/samples/NotePad": Bp2BuildDefaultTrue,
274 "development/samples/Obb": Bp2BuildDefaultTrue,
275 "development/samples/RSSReader": Bp2BuildDefaultTrue,
276 "development/samples/ReceiveShareDemo": Bp2BuildDefaultTrue,
277 "development/samples/SearchableDictionary": Bp2BuildDefaultTrue,
278 "development/samples/SipDemo": Bp2BuildDefaultTrue,
279 "development/samples/SkeletonApp": Bp2BuildDefaultTrue,
280 "development/samples/Snake": Bp2BuildDefaultTrue,
281 "development/samples/SpellChecker/": Bp2BuildDefaultTrueRecursively,
282 "development/samples/ThemedNavBarKeyboard": Bp2BuildDefaultTrue,
283 "development/samples/ToyVpn": Bp2BuildDefaultTrue,
284 "development/samples/TtsEngine": Bp2BuildDefaultTrue,
285 "development/samples/USB/AdbTest": Bp2BuildDefaultTrue,
286 "development/samples/USB/MissileLauncher": Bp2BuildDefaultTrue,
287 "development/samples/VoiceRecognitionService": Bp2BuildDefaultTrue,
288 "development/samples/VoicemailProviderDemo": Bp2BuildDefaultTrue,
Romain Jobredeaux355851b2022-01-13 17:07:01 +0000[diff] [blame]289 "development/samples/WiFiDirectDemo": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]290 "development/sdk": Bp2BuildDefaultTrueRecursively,
291 "external/arm-optimized-routines": Bp2BuildDefaultTrueRecursively,
Sam Delmerico4c7069f2022-02-03 17:50:03 +0000[diff] [blame]292 "external/auto/common": Bp2BuildDefaultTrueRecursively,
293 "external/auto/service": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]294 "external/boringssl": Bp2BuildDefaultTrueRecursively,
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]295 "external/bouncycastle": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]296 "external/brotli": Bp2BuildDefaultTrue,
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]297 "external/conscrypt": Bp2BuildDefaultTrue,
Sam Delmericofde9fb52022-01-28 20:53:38 +0000[diff] [blame]298 "external/error_prone": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]299 "external/fmtlib": Bp2BuildDefaultTrueRecursively,
Chris Parsonsb97a8172021-10-04 12:48:29 -0400[diff] [blame]300 "external/google-benchmark": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]301 "external/googletest": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]302 "external/gwp_asan": Bp2BuildDefaultTrueRecursively,
Liz Kammer35ca77e2021-12-22 15:31:40 -0500[diff] [blame]303 "external/icu": Bp2BuildDefaultTrueRecursively,
304 "external/icu/android_icu4j": Bp2BuildDefaultFalse, // java rules incomplete
305 "external/icu/icu4j": Bp2BuildDefaultFalse, // java rules incomplete
Sam Delmerico4c7069f2022-02-03 17:50:03 +0000[diff] [blame]306 "external/javapoet": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]307 "external/jemalloc_new": Bp2BuildDefaultTrueRecursively,
Chris Parsonsb97a8172021-10-04 12:48:29 -0400[diff] [blame]308 "external/jsoncpp": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]309 "external/libcap": Bp2BuildDefaultTrueRecursively,
310 "external/libcxx": Bp2BuildDefaultTrueRecursively,
311 "external/libcxxabi": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]312 "external/libevent": Bp2BuildDefaultTrueRecursively,
Liz Kammerb5b478d2021-12-15 13:00:21 -0500[diff] [blame]313 "external/libpng": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]314 "external/lz4/lib": Bp2BuildDefaultTrue,
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]315 "external/lzma/C": Bp2BuildDefaultTrueRecursively,
Liz Kammer2fc34892021-10-11 12:56:48 -0400[diff] [blame]316 "external/mdnsresponder": Bp2BuildDefaultTrueRecursively,
317 "external/minijail": Bp2BuildDefaultTrueRecursively,
318 "external/pcre": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]319 "external/protobuf": Bp2BuildDefaultTrueRecursively,
320 "external/python/six": Bp2BuildDefaultTrueRecursively,
321 "external/scudo": Bp2BuildDefaultTrueRecursively,
Liz Kammer2fc34892021-10-11 12:56:48 -0400[diff] [blame]322 "external/selinux/libselinux": Bp2BuildDefaultTrueRecursively,
Liz Kammerb5b478d2021-12-15 13:00:21 -0500[diff] [blame]323 "external/selinux/libsepol": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]324 "external/zlib": Bp2BuildDefaultTrueRecursively,
Liz Kammer2fc34892021-10-11 12:56:48 -0400[diff] [blame]325 "external/zstd": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400[diff] [blame]326 "frameworks/base/media/tests/MediaDump": Bp2BuildDefaultTrue,
327 "frameworks/base/startop/apps/test": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]328 "frameworks/native/libs/adbd_auth": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400[diff] [blame]329 "frameworks/native/opengl/tests/gl2_cameraeye": Bp2BuildDefaultTrue,
330 "frameworks/native/opengl/tests/gl2_java": Bp2BuildDefaultTrue,
331 "frameworks/native/opengl/tests/testLatency": Bp2BuildDefaultTrue,
332 "frameworks/native/opengl/tests/testPauseResume": Bp2BuildDefaultTrue,
333 "frameworks/native/opengl/tests/testViewport": Bp2BuildDefaultTrue,
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]334 "frameworks/proto_logging/stats/stats_log_api_gen": Bp2BuildDefaultTrueRecursively,
335 "libnativehelper": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400[diff] [blame]336 "packages/apps/DevCamera": Bp2BuildDefaultTrue,
337 "packages/apps/HTMLViewer": Bp2BuildDefaultTrue,
338 "packages/apps/Protips": Bp2BuildDefaultTrue,
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500[diff] [blame]339 "packages/modules/StatsD/lib/libstatssocket": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]340 "packages/modules/adb": Bp2BuildDefaultTrue,
Jingwen Chend109bd92021-12-14 07:50:18 +0000[diff] [blame]341 "packages/modules/adb/apex": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]342 "packages/modules/adb/crypto": Bp2BuildDefaultTrueRecursively,
343 "packages/modules/adb/libs": Bp2BuildDefaultTrueRecursively,
344 "packages/modules/adb/pairing_auth": Bp2BuildDefaultTrueRecursively,
345 "packages/modules/adb/pairing_connection": Bp2BuildDefaultTrueRecursively,
346 "packages/modules/adb/proto": Bp2BuildDefaultTrueRecursively,
347 "packages/modules/adb/tls": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400[diff] [blame]348 "packages/providers/MediaProvider/tools/dialogs": Bp2BuildDefaultTrue,
349 "packages/screensavers/Basic": Bp2BuildDefaultTrue,
350 "packages/services/Car/tests/SampleRearViewCamera": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]351 "prebuilts/clang/host/linux-x86": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux428a3662022-01-28 11:12:52 -0500[diff] [blame]352 "prebuilts/tools/common/m2": Bp2BuildDefaultTrue,
Jingwen Chend43d4a42021-11-23 12:40:11 +0000[diff] [blame]353 "system/apex": Bp2BuildDefaultFalse, // TODO(b/207466993): flaky failures
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500[diff] [blame]354 "system/apex/proto": Bp2BuildDefaultTrueRecursively,
355 "system/apex/libs": Bp2BuildDefaultTrueRecursively,
Liz Kammeraabfb5d2021-12-08 15:25:06 -0500[diff] [blame]356 "system/core/debuggerd": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]357 "system/core/diagnose_usb": Bp2BuildDefaultTrueRecursively,
358 "system/core/libasyncio": Bp2BuildDefaultTrue,
359 "system/core/libcrypto_utils": Bp2BuildDefaultTrueRecursively,
360 "system/core/libcutils": Bp2BuildDefaultTrueRecursively,
Liz Kammer2fc34892021-10-11 12:56:48 -0400[diff] [blame]361 "system/core/libpackagelistparser": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]362 "system/core/libprocessgroup": Bp2BuildDefaultTrue,
Chris Parsonsb97a8172021-10-04 12:48:29 -0400[diff] [blame]363 "system/core/libprocessgroup/cgrouprc": Bp2BuildDefaultTrue,
364 "system/core/libprocessgroup/cgrouprc_format": Bp2BuildDefaultTrue,
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]365 "system/core/libsystem": Bp2BuildDefaultTrueRecursively,
366 "system/core/libutils": Bp2BuildDefaultTrueRecursively,
367 "system/core/libvndksupport": Bp2BuildDefaultTrueRecursively,
Lukacs T. Berki497f17d2021-04-26 12:15:57 +0200[diff] [blame]368 "system/core/property_service/libpropertyinfoparser": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]369 "system/libbase": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]370 "system/libprocinfo": Bp2BuildDefaultTrue,
Chris Parsonsc39f6332021-10-01 18:00:31 -0400[diff] [blame]371 "system/libziparchive": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]372 "system/logging/liblog": Bp2BuildDefaultTrueRecursively,
373 "system/sepolicy/apex": Bp2BuildDefaultTrueRecursively,
374 "system/timezone/apex": Bp2BuildDefaultTrueRecursively,
375 "system/timezone/output_data": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]376 "system/unwinding/libbacktrace": Bp2BuildDefaultTrueRecursively,
377 "system/unwinding/libunwindstack": Bp2BuildDefaultTrueRecursively,
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]378 "tools/apksig": Bp2BuildDefaultTrue,
379 "tools/platform-compat/java/android/compat": Bp2BuildDefaultTrueRecursively,
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]380 }
Jingwen Chen5d72cba2021-03-25 09:28:38 +0000[diff] [blame]381
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400[diff] [blame]382 // Per-module denylist to always opt modules out of both bp2build and mixed builds.
Rupert Shuttleworth4f43fe92021-03-30 14:13:16 +0000[diff] [blame]383 bp2buildModuleDoNotConvertList = []string{
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500[diff] [blame]384 "libnativehelper_compat_libc", // Broken compile: implicit declaration of function 'strerror_r' is invalid in C99
385
386 "libart", // depends on unconverted modules: art_operator_srcs, libodrstatslog, libelffile, art_cmdlineparser_headers, cpp-define-generator-definitions, libcpu_features, libdexfile, libartpalette, libbacktrace, libnativebridge, libnativeloader, libsigchain, libunwindstack, libartbase, libprofile, cpp-define-generator-asm-support, apex-info-list-tinyxml, libtinyxml2, libnativeloader-headers, libstatssocket, heapprofd_client_api
387 "libart-runtime-gtest", // depends on unconverted modules: libgtest_isolated, libart-compiler, libdexfile, libprofile, libartbase, libbacktrace, libartbase-art-gtest
388 "libart_headers", // depends on unconverted modules: art_libartbase_headers
389 "libartd", // depends on unconverted modules: apex-info-list-tinyxml, libtinyxml2, libnativeloader-headers, libstatssocket, heapprofd_client_api, art_operator_srcs, libodrstatslog, libelffiled, art_cmdlineparser_headers, cpp-define-generator-definitions, libcpu_features, libdexfiled, libartpalette, libbacktrace, libnativebridge, libnativeloader, libsigchain, libunwindstack, libartbased, libprofiled, cpp-define-generator-asm-support
390 "libartd-runtime-gtest", // depends on unconverted modules: libgtest_isolated, libartd-compiler, libdexfiled, libprofiled, libartbased, libbacktrace, libartbased-art-gtest
391 "libstatslog_art", // depends on unconverted modules: statslog_art.cpp, statslog_art.h
392 "statslog_art.h", "statslog_art.cpp", // depends on unconverted modules: stats-log-api-gen
393
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]394 "libandroid_runtime_lazy", // depends on unconverted modules: libbinder_headers
395 "libcmd", // depends on unconverted modules: libbinder
396
Chris Parsons58852a02021-12-09 18:10:18 -0500[diff] [blame]397 "libdexfile_support_static", // Depends on unconverted module: libdexfile_external_headers
398 "libunwindstack_local", "libunwindstack_utils", "libc_malloc_debug", "libfdtrack", // Depends on unconverted module: libunwindstack
399
400 "libdexfile_support", // TODO(b/210546943): Enabled based on product variables.
401 "libdexfile_external_headers", // TODO(b/210546943): Enabled based on product variables.
402
403 "libunwindstack", // Depends on unconverted module libdexfile_support.
404 "libnativehelper_compat_libc++", // Broken compile: implicit declaration of function 'strerror_r' is invalid in C99
405
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]406 "chkcon", "sefcontext_compile", // depends on unconverted modules: libsepol
407
408 "libsepol", // TODO(b/207408632): Unsupported case of .l sources in cc library rules
409
Liz Kammer5c313582021-12-03 15:23:26 -0500[diff] [blame]410 "gen-kotlin-build-file.py", // module has same name as source
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]411
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]412 "libactivitymanager_aidl", // TODO(b/207426160): Depends on activity_manager_procstate_aidl, which is an aidl filegroup.
413
Liz Kammer5c313582021-12-03 15:23:26 -0500[diff] [blame]414 "libnativehelper_lazy_mts_jni", "libnativehelper_mts_jni", // depends on unconverted modules: libgmock_ndk
415 "libnativetesthelper_jni", "libgmock_main_ndk", "libgmock_ndk", // depends on unconverted module: libgtest_ndk_c++
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]416
417 "statslog-framework-java-gen", "statslog.cpp", "statslog.h", "statslog.rs", "statslog_header.rs", // depends on unconverted modules: stats-log-api-gen
418
419 "stats-log-api-gen", // depends on unconverted modules: libstats_proto_host, libprotobuf-cpp-full
420
421 "libstatslog", // depends on unconverted modules: statslog.cpp, statslog.h, ...
422
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]423 "cmd", // depends on unconverted module packagemanager_aidl-cpp, of unsupported type aidl_interface
424 "servicedispatcher", // depends on unconverted module android.debug_aidl, of unsupported type aidl_interface
425 "libutilscallstack", // depends on unconverted module libbacktrace
426 "libbacktrace", // depends on unconverted module libunwindstack
427 "libdebuggerd_handler", // depends on unconverted module libdebuggerd_handler_core
428 "libdebuggerd_handler_core", "libdebuggerd_handler_fallback", // depends on unconverted module libdebuggerd
Liz Kammeraabfb5d2021-12-08 15:25:06 -0500[diff] [blame]429 "unwind_for_offline", // depends on unconverted module libunwindstack_utils
430 "libdebuggerd", // depends on unconverted modules libdexfile_support, libunwindstack, gwp_asan_crash_handler, libtombstone_proto, libprotobuf-cpp-lite
431 "libdexfile_static", // depends on libartpalette, libartbase, libdexfile, which are of unsupported type: art_cc_library.
432
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500[diff] [blame]433 "static_crasher", // depends on unconverted modules: libdebuggerd_handler
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]434
Liz Kammer5c313582021-12-03 15:23:26 -0500[diff] [blame]435 "pbtombstone", "crash_dump", // depends on libdebuggerd, libunwindstack
Rupert Shuttleworth47aa5842021-04-30 04:04:15 -0400[diff] [blame]436
Chris Parsonsc39f6332021-10-01 18:00:31 -0400[diff] [blame]437 "libbase_ndk", // http://b/186826477, fails to link libctscamera2_jni for device (required for CtsCameraTestCases)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000[diff] [blame]438
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]439 "libprotobuf-internal-protos", // b/210751803, we don't handle path property for filegroups
440 "libprotobuf-internal-python-srcs", // b/210751803, we don't handle path property for filegroups
441 "libprotobuf-java-full", // b/210751803, we don't handle path property for filegroups
Sam Delmericofde9fb52022-01-28 20:53:38 +0000[diff] [blame]442 "host-libprotobuf-java-full", // b/210751803, we don't handle path property for filegroups
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]443 "libprotobuf-java-util-full", // b/210751803, we don't handle path property for filegroups
Sam Delmericofde9fb52022-01-28 20:53:38 +0000[diff] [blame]444
445 "conscrypt", // b/210751803, we don't handle path property for filegroups
446 "conscrypt-for-host", // b/210751803, we don't handle path property for filegroups
447
448 "host-libprotobuf-java-lite", // b/217236083, java_library cannot have deps without srcs
449 "host-libprotobuf-java-micro", // b/217236083, java_library cannot have deps without srcs
450 "host-libprotobuf-java-nano", // b/217236083, java_library cannot have deps without srcs
451 "error_prone_core", // b/217236083, java_library cannot have deps without srcs
452 "bouncycastle-host", // b/217236083, java_library cannot have deps without srcs
453
454 "apex_manifest_proto_java", // b/215230097, we don't handle .proto files in java_library srcs attribute
Liz Kammer0f3b7d22021-09-28 13:48:21 -0400[diff] [blame]455
Jingwen Chenf6b4cd42022-02-08 03:23:10 +0000[diff] [blame]456 "libc_musl_sysroot_bionic_arch_headers", // b/218405924, depends on soong_zip
457 "libc_musl_sysroot_bionic_headers", // b/218405924, depends on soong_zip and generates duplicate srcs
458
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500[diff] [blame]459 // python protos
460 "libprotobuf-python", // contains .proto sources
461 "conv_linker_config", // depends on linker_config_proto, a python lib with proto sources
462 "apex_build_info_proto", "apex_manifest_proto", // a python lib with proto sources
463 "linker_config_proto", // contains .proto sources
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400[diff] [blame]464
Chris Parsonsb97a8172021-10-04 12:48:29 -0400[diff] [blame]465 "brotli-fuzzer-corpus", // b/202015218: outputs are in location incompatible with bazel genrule handling.
Jingwen Chen294e7742021-08-31 05:58:01 +0000[diff] [blame]466
Jingwen Chendf27b7a2021-10-18 06:33:16 +0000[diff] [blame]467 // b/203369847: multiple genrules in the same package creating the same file
468 // //development/sdk/...
469 "platform_tools_properties",
470 "build_tools_source_properties",
471
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -0400[diff] [blame]472 // APEX support
Liz Kammer5c313582021-12-03 15:23:26 -0500[diff] [blame]473 "com.android.runtime", // depends on unconverted modules: bionic-linker-config, linkerconfig
Chris Parsonsa37e1952021-09-28 16:47:36 -0400[diff] [blame]474
Chris Parsonsc39f6332021-10-01 18:00:31 -0400[diff] [blame]475 "libgtest_ndk_c++", // b/201816222: Requires sdk_version support.
476 "libgtest_main_ndk_c++", // b/201816222: Requires sdk_version support.
Liz Kammer2b8004b2021-10-04 13:55:44 -0400[diff] [blame]477
Liz Kammer1263d9b2021-12-10 14:28:20 -0500[diff] [blame]478 "abb", // depends on unconverted modules: libcmd, libbinder
479 "adb", // depends on unconverted modules: AdbWinApi, libadb_host, libandroidfw, libapp_processes_protos_full, libfastdeploy_host, libopenscreen-discovery, libopenscreen-platform-impl, libusb, bin2c_fastdeployagent, AdbWinUsbApi
Liz Kammer3d3b35c2022-01-11 16:02:50 +0000[diff] [blame]480 "libadb_host", // depends on unconverted modules: libopenscreen-discovery, libopenscreen-platform-impl, libusb, AdbWinApi
481 "libfastdeploy_host", // depends on unconverted modules: libandroidfw, libusb, AdbWinApi
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]482 "linker", // depends on unconverted modules: libdebuggerd_handler_fallback
Liz Kammer2b8004b2021-10-04 13:55:44 -0400[diff] [blame]483 "linker_reloc_bench_main", // depends on unconverted modules: liblinker_reloc_bench_*
Chris Parsons8a498162021-11-18 17:19:12 -0500[diff] [blame]484 "versioner", // depends on unconverted modules: libclang_cxx_host, libLLVM_host, of unsupported type llvm_host_prebuilt_library_shared
Liz Kammer2b8004b2021-10-04 13:55:44 -0400[diff] [blame]485
486 "linkerconfig", // http://b/202876379 has arch-variant static_executable
487 "mdnsd", // http://b/202876379 has arch-variant static_executable
488
Chris Parsons58852a02021-12-09 18:10:18 -0500[diff] [blame]489 "CarHTMLViewer", // depends on unconverted modules android.car-stubs, car-ui-lib
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]490
491 "libdexfile", // depends on unconverted modules: dexfile_operator_srcs, libartbase, libartpalette,
492 "libdexfiled", // depends on unconverted modules: dexfile_operator_srcs, libartbased, libartpalette
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500[diff] [blame]493
494 // go deps:
Liz Kammer35ca77e2021-12-22 15:31:40 -0500[diff] [blame]495 "apex-protos", // depends on soong_zip, a go binary
496 "generated_android_icu4j_src_files", "generated_android_icu4j_test_files", "icu4c_test_data", // depends on unconverted modules: soong_zip
Liz Kammer878a7f12022-03-01 08:35:51 -0500[diff] [blame^]497 "host_bionic_linker_asm", // depends on extract_linker, a go binary.
498 "host_bionic_linker_script", // depends on extract_linker, a go binary.
499 "robolectric-sqlite4java-native", // depends on soong_zip, a go binary
500 "robolectric_tzdata", // depends on soong_zip, a go binary
501 "libc_musl_sysroot_libc++_headers", "libc_musl_sysroot_libc++abi_headers", // depends on soong_zip, zip2zip
Liz Kammer35ca77e2021-12-22 15:31:40 -0500[diff] [blame]502
503 "android_icu4j_srcgen_binary", // Bazel build error: deps not allowed without srcs; move to runtime_deps
504 "core-icu4j-for-host", // Bazel build error: deps not allowed without srcs; move to runtime_deps
Sam Delmericocd1b80f2022-01-11 21:55:46 +0000[diff] [blame]505
506 // java deps
Liz Kammer35ca77e2021-12-22 15:31:40 -0500[diff] [blame]507 "android_icu4j_srcgen", // depends on unconverted modules: currysrc
Liz Kammera20b7a72022-02-04 12:59:36 -0500[diff] [blame]508 "bin2c_fastdeployagent", // depends on deployagent, a java binary
Liz Kammer35ca77e2021-12-22 15:31:40 -0500[diff] [blame]509 "currysrc", // depends on unconverted modules: currysrc_org.eclipse, guavalib, jopt-simple-4.9
Liz Kammer35ca77e2021-12-22 15:31:40 -0500[diff] [blame]510 "robolectric-sqlite4java-0.282", // depends on unconverted modules: robolectric-sqlite4java-import, robolectric-sqlite4java-native
Liz Kammera20b7a72022-02-04 12:59:36 -0500[diff] [blame]511 "timezone-host", // depends on unconverted modules: art.module.api.annotations
Liz Kammer35ca77e2021-12-22 15:31:40 -0500[diff] [blame]512 "truth-host-prebuilt", // depends on unconverted modules: truth-prebuilt
Liz Kammera20b7a72022-02-04 12:59:36 -0500[diff] [blame]513 "truth-prebuilt", // depends on unconverted modules: asm-7.0, guava
Liz Kammer35ca77e2021-12-22 15:31:40 -0500[diff] [blame]514
515 "generated_android_icu4j_resources", // depends on unconverted modules: android_icu4j_srcgen_binary, soong_zip
516 "generated_android_icu4j_test_resources", // depends on unconverted modules: android_icu4j_srcgen_binary, soong_zip
Liz Kammera20b7a72022-02-04 12:59:36 -0500[diff] [blame]517
518 "art-script", // depends on unconverted modules: dalvikvm, dex2oat
519 "dex2oat-script", // depends on unconverted modules: dex2oat
Jingwen Cheneb2a3fd2022-02-16 12:59:50 +0000[diff] [blame]520
521 "error_prone_checkerframework_dataflow_nullaway", // TODO(b/219908977): "Error in fail: deps not allowed without srcs; move to runtime_deps?"
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400[diff] [blame]522 }
Rupert Shuttleworthc143cc52021-04-13 13:08:04 -0400[diff] [blame]523
Jingwen Chen179856a2021-05-03 09:15:48 +0000[diff] [blame]524 // Per-module denylist of cc_library modules to only generate the static
525 // variant if their shared variant isn't ready or buildable by Bazel.
Chris Parsons58852a02021-12-09 18:10:18 -0500[diff] [blame]526 bp2buildCcLibraryStaticOnlyList = []string{}
Jingwen Chen179856a2021-05-03 09:15:48 +0000[diff] [blame]527
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400[diff] [blame]528 // Per-module denylist to opt modules out of mixed builds. Such modules will
529 // still be generated via bp2build.
Chris Parsons2c788392021-08-10 11:58:07 -0400[diff] [blame]530 mixedBuildsDisabledList = []string{
Liz Kammer5c313582021-12-03 15:23:26 -0500[diff] [blame]531 "art_libdexfile_dex_instruction_list_header", // breaks libart_mterp.armng, header not found
532
Wei Li455ba832021-11-04 22:58:12 +0000[diff] [blame]533 "libbrotli", // http://b/198585397, ld.lld: error: bionic/libc/arch-arm64/generic/bionic/memmove.S:95:(.text+0x10): relocation R_AARCH64_CONDBR19 out of range: -1404176 is not in [-1048576, 1048575]; references __memcpy
534 "minijail_constants_json", // http://b/200899432, bazel-built cc_genrule does not work in mixed build when it is a dependency of another soong module.
Liz Kammerc3192992021-11-16 17:01:11 -0500[diff] [blame]535
Jingwen Chend4808592021-11-26 05:39:07 +0000[diff] [blame]536 "cap_names.h", // TODO(b/204913827) runfiles need to be handled in mixed builds
537 "libcap", // TODO(b/204913827) runfiles need to be handled in mixed builds
538 "libprotobuf-cpp-full", "libprotobuf-cpp-lite", // Unsupported product&vendor suffix. b/204811222 and b/204810610.
Liz Kammer12615db2021-09-28 09:19:17 -0400[diff] [blame]539
540 // Depends on libprotobuf-cpp-*
Liz Kammereb2d6d12021-12-06 14:56:25 -0500[diff] [blame]541 "libadb_pairing_connection",
Liz Kammer12615db2021-09-28 09:19:17 -0400[diff] [blame]542 "libadb_pairing_connection_static",
543 "libadb_pairing_server", "libadb_pairing_server_static",
Yu Liu7f3605f2022-02-08 14:15:12 -0800[diff] [blame]544
545 // TODO(b/204811222) support suffix in cc_binary
546 "acvp_modulewrapper",
547 "android.hardware.media.c2@1.0-service-v4l2",
548 "app_process",
549 "bar_test",
550 "bench_cxa_atexit",
551 "bench_noop",
552 "bench_noop_nostl",
553 "bench_noop_static",
554 "boringssl_self_test",
555 "boringssl_self_test_vendor",
556 "bssl",
557 "cavp",
558 "crash_dump",
559 "crasher",
560 "libcxx_test_template",
561 "linker",
562 "memory_replay",
563 "native_bridge_guest_linker",
564 "native_bridge_stub_library_defaults",
565 "noop",
566 "simpleperf_ndk",
567 "toybox-static",
568 "zlib_bench",
Chris Parsons2c788392021-08-10 11:58:07 -0400[diff] [blame]569 }
Rupert Shuttleworth4f43fe92021-03-30 14:13:16 +0000[diff] [blame]570
571 // Used for quicker lookups
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400[diff] [blame]572 bp2buildModuleDoNotConvert = map[string]bool{}
Jingwen Chen179856a2021-05-03 09:15:48 +0000[diff] [blame]573 bp2buildCcLibraryStaticOnly = map[string]bool{}
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400[diff] [blame]574 mixedBuildsDisabled = map[string]bool{}
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]575)
576
Rupert Shuttleworth4f43fe92021-03-30 14:13:16 +0000[diff] [blame]577func init() {
578 for _, moduleName := range bp2buildModuleDoNotConvertList {
579 bp2buildModuleDoNotConvert[moduleName] = true
580 }
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400[diff] [blame]581
Jingwen Chen179856a2021-05-03 09:15:48 +0000[diff] [blame]582 for _, moduleName := range bp2buildCcLibraryStaticOnlyList {
583 bp2buildCcLibraryStaticOnly[moduleName] = true
584 }
585
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400[diff] [blame]586 for _, moduleName := range mixedBuildsDisabledList {
587 mixedBuildsDisabled[moduleName] = true
588 }
589}
590
Chris Parsons953b3562021-09-20 15:14:39 -0400[diff] [blame]591func GenerateCcLibraryStaticOnly(moduleName string) bool {
592 return bp2buildCcLibraryStaticOnly[moduleName]
Jingwen Chen179856a2021-05-03 09:15:48 +0000[diff] [blame]593}
594
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400[diff] [blame]595func ShouldKeepExistingBuildFileForDir(dir string) bool {
596 if _, ok := bp2buildKeepExistingBuildFile[dir]; ok {
597 // Exact dir match
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400[diff] [blame]598 return true
599 }
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400[diff] [blame]600 // Check if subtree match
601 for prefix, recursive := range bp2buildKeepExistingBuildFile {
602 if recursive {
603 if strings.HasPrefix(dir, prefix+"/") {
604 return true
605 }
606 }
607 }
608 // Default
609 return false
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400[diff] [blame]610}
611
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400[diff] [blame]612// MixedBuildsEnabled checks that a module is ready to be replaced by a
613// converted or handcrafted Bazel target.
Chris Parsons494eef32021-11-09 10:29:52 -0500[diff] [blame]614func (b *BazelModuleBase) MixedBuildsEnabled(ctx ModuleContext) bool {
615 if ctx.Os() == Windows {
616 // Windows toolchains are not currently supported.
617 return false
618 }
Chris Parsons58852a02021-12-09 18:10:18 -0500[diff] [blame]619 if !ctx.Module().Enabled() {
620 return false
621 }
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400[diff] [blame]622 if !ctx.Config().BazelContext.BazelEnabled() {
623 return false
624 }
Liz Kammer6eff3232021-08-26 08:37:59 -0400[diff] [blame]625 if !convertedToBazel(ctx, ctx.Module()) {
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400[diff] [blame]626 return false
627 }
Liz Kammer6eff3232021-08-26 08:37:59 -0400[diff] [blame]628
Chris Parsons953b3562021-09-20 15:14:39 -0400[diff] [blame]629 if GenerateCcLibraryStaticOnly(ctx.Module().Name()) {
Jingwen Chen179856a2021-05-03 09:15:48 +0000[diff] [blame]630 // Don't use partially-converted cc_library targets in mixed builds,
631 // since mixed builds would generally rely on both static and shared
632 // variants of a cc_library.
633 return false
634 }
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400[diff] [blame]635 return !mixedBuildsDisabled[ctx.Module().Name()]
Rupert Shuttleworth4f43fe92021-03-30 14:13:16 +0000[diff] [blame]636}
637
Liz Kammer6eff3232021-08-26 08:37:59 -0400[diff] [blame]638// ConvertedToBazel returns whether this module has been converted (with bp2build or manually) to Bazel.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000[diff] [blame]639func convertedToBazel(ctx BazelConversionContext, module blueprint.Module) bool {
Liz Kammer6eff3232021-08-26 08:37:59 -0400[diff] [blame]640 b, ok := module.(Bazelable)
641 if !ok {
642 return false
643 }
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]644 return b.shouldConvertWithBp2build(ctx, module) || b.HasHandcraftedLabel()
Liz Kammer6eff3232021-08-26 08:37:59 -0400[diff] [blame]645}
646
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]647// ShouldConvertWithBp2build returns whether the given BazelModuleBase should be converted with bp2build.
648func (b *BazelModuleBase) ShouldConvertWithBp2build(ctx BazelConversionContext) bool {
649 return b.shouldConvertWithBp2build(ctx, ctx.Module())
Liz Kammer6eff3232021-08-26 08:37:59 -0400[diff] [blame]650}
651
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]652func (b *BazelModuleBase) shouldConvertWithBp2build(ctx BazelConversionContext, module blueprint.Module) bool {
Liz Kammer6eff3232021-08-26 08:37:59 -0400[diff] [blame]653 if bp2buildModuleDoNotConvert[module.Name()] {
Jingwen Chen5d72cba2021-03-25 09:28:38 +0000[diff] [blame]654 return false
655 }
656
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]657 if !b.bazelProps().Bazel_module.CanConvertToBazel {
658 return false
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]659 }
660
Liz Kammer6eff3232021-08-26 08:37:59 -0400[diff] [blame]661 packagePath := ctx.OtherModuleDir(module)
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]662 config := ctx.Config().bp2buildPackageConfig
663
664 // This is a tristate value: true, false, or unset.
665 propValue := b.bazelProperties.Bazel_module.Bp2build_available
666 if bp2buildDefaultTrueRecursively(packagePath, config) {
667 // Allow modules to explicitly opt-out.
668 return proptools.BoolDefault(propValue, true)
669 }
670
671 // Allow modules to explicitly opt-in.
672 return proptools.BoolDefault(propValue, false)
673}
674
675// bp2buildDefaultTrueRecursively checks that the package contains a prefix from the
676// set of package prefixes where all modules must be converted. That is, if the
677// package is x/y/z, and the list contains either x, x/y, or x/y/z, this function will
678// return true.
679//
680// However, if the package is x/y, and it matches a Bp2BuildDefaultFalse "x/y" entry
681// exactly, this module will return false early.
682//
683// This function will also return false if the package doesn't match anything in
684// the config.
685func bp2buildDefaultTrueRecursively(packagePath string, config Bp2BuildConfig) bool {
686 ret := false
687
Jingwen Chen294e7742021-08-31 05:58:01 +0000[diff] [blame]688 // Check if the package path has an exact match in the config.
689 if config[packagePath] == Bp2BuildDefaultTrue || config[packagePath] == Bp2BuildDefaultTrueRecursively {
Jingwen Chen91220d72021-03-24 02:18:33 -0400[diff] [blame]690 return true
Jingwen Chen294e7742021-08-31 05:58:01 +0000[diff] [blame]691 } else if config[packagePath] == Bp2BuildDefaultFalse {
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]692 return false
693 }
694
Jingwen Chen91220d72021-03-24 02:18:33 -0400[diff] [blame]695 // If not, check for the config recursively.
Jingwen Chen12b4c272021-03-10 02:05:59 -0500[diff] [blame]696 packagePrefix := ""
697 // e.g. for x/y/z, iterate over x, x/y, then x/y/z, taking the final value from the allowlist.
698 for _, part := range strings.Split(packagePath, "/") {
699 packagePrefix += part
700 if config[packagePrefix] == Bp2BuildDefaultTrueRecursively {
701 // package contains this prefix and this prefix should convert all modules
702 return true
703 }
704 // Continue to the next part of the package dir.
705 packagePrefix += "/"
706 }
707
708 return ret
Liz Kammerea6666f2021-02-17 10:17:28 -0500[diff] [blame]709}
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]710
711// GetBazelBuildFileContents returns the file contents of a hand-crafted BUILD file if available or
712// an error if there are errors reading the file.
713// TODO(b/181575318): currently we append the whole BUILD file, let's change that to do
714// something more targeted based on the rule type and target.
715func (b *BazelModuleBase) GetBazelBuildFileContents(c Config, path, name string) (string, error) {
Liz Kammerbdc60992021-02-24 16:55:11 -0500[diff] [blame]716 if !strings.Contains(b.HandcraftedLabel(), path) {
717 return "", fmt.Errorf("%q not found in bazel_module.label %q", path, b.HandcraftedLabel())
Liz Kammerba3ea162021-02-17 13:22:03 -0500[diff] [blame]718 }
719 name = filepath.Join(path, name)
720 f, err := c.fs.Open(name)
721 if err != nil {
722 return "", err
723 }
724 defer f.Close()
725
726 data, err := ioutil.ReadAll(f)
727 if err != nil {
728 return "", err
729 }
730 return string(data[:]), nil
731}
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400[diff] [blame]732
733func registerBp2buildConversionMutator(ctx RegisterMutatorsContext) {
734 ctx.TopDown("bp2build_conversion", convertWithBp2build).Parallel()
735}
736
737func convertWithBp2build(ctx TopDownMutatorContext) {
738 bModule, ok := ctx.Module().(Bazelable)
739 if !ok || !bModule.shouldConvertWithBp2build(ctx, ctx.Module()) {
740 return
741 }
742
743 bModule.ConvertWithBp2build(ctx)
744}
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]745
746// GetMainClassInManifest scans the manifest file specified in filepath and returns
747// the value of attribute Main-Class in the manifest file if it exists, or returns error.
748// WARNING: this is for bp2build converters of java_* modules only.
749func GetMainClassInManifest(c Config, filepath string) (string, error) {
750 file, err := c.fs.Open(filepath)
751 if err != nil {
752 return "", err
753 }
Liz Kammer0fe123d2022-02-07 10:17:35 -0500[diff] [blame]754 defer file.Close()
Wei Libafb6d62021-12-10 03:14:59 -0800[diff] [blame]755 scanner := bufio.NewScanner(file)
756 for scanner.Scan() {
757 line := scanner.Text()
758 if strings.HasPrefix(line, "Main-Class:") {
759 return strings.TrimSpace(line[len("Main-Class:"):]), nil
760 }
761 }
762
763 return "", errors.New("Main-Class is not found.")
764}