blob: af614ff79cca62aa84be616ffa82c064516d4b02 [file] [log] [blame]
Liz Kammerea6666f2021-02-17 10:17:28 -05001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package android
16
Liz Kammerba3ea162021-02-17 13:22:03 -050017import (
18 "fmt"
19 "io/ioutil"
20 "path/filepath"
21 "strings"
22
Liz Kammerbdc60992021-02-24 16:55:11 -050023 "github.com/google/blueprint"
Liz Kammerba3ea162021-02-17 13:22:03 -050024 "github.com/google/blueprint/proptools"
25)
26
Jingwen Chen01812022021-11-19 14:29:43 +000027type bazelModuleProperties struct {
28 // The label of the Bazel target replacing this Soong module. When run in conversion mode, this
29 // will import the handcrafted build target into the autogenerated file. Note: this may result in
30 // a conflict due to duplicate targets if bp2build_available is also set.
31 Label *string
32
33 // If true, bp2build will generate the converted Bazel target for this module. Note: this may
34 // cause a conflict due to the duplicate targets if label is also set.
35 //
36 // This is a bool pointer to support tristates: true, false, not set.
37 //
38 // To opt-in a module, set bazel_module: { bp2build_available: true }
39 // To opt-out a module, set bazel_module: { bp2build_available: false }
40 // To defer the default setting for the directory, do not set the value.
41 Bp2build_available *bool
42}
43
Liz Kammerba3ea162021-02-17 13:22:03 -050044// Properties contains common module properties for Bazel migration purposes.
45type properties struct {
46 // In USE_BAZEL_ANALYSIS=1 mode, this represents the Bazel target replacing
47 // this Soong module.
Jingwen Chen01812022021-11-19 14:29:43 +000048 Bazel_module bazelModuleProperties
Liz Kammerba3ea162021-02-17 13:22:03 -050049}
Liz Kammerea6666f2021-02-17 10:17:28 -050050
Jingwen Chen25825ca2021-11-15 12:28:43 +000051// namespacedVariableProperties is a map from a string representing a Soong
Jingwen Chen84817de2021-11-17 10:57:35 +000052// config variable namespace, like "android" or "vendor_name" to a slice of
53// pointer to a struct containing a single field called Soong_config_variables
54// whose value mirrors the structure in the Blueprint file.
55type namespacedVariableProperties map[string][]interface{}
Jingwen Chena47f28d2021-11-02 16:43:57 +000056
Liz Kammerea6666f2021-02-17 10:17:28 -050057// BazelModuleBase contains the property structs with metadata for modules which can be converted to
58// Bazel.
59type BazelModuleBase struct {
Liz Kammerba3ea162021-02-17 13:22:03 -050060 bazelProperties properties
Jingwen Chena47f28d2021-11-02 16:43:57 +000061
62 // namespacedVariableProperties is used for soong_config_module_type support
63 // in bp2build. Soong config modules allow users to set module properties
64 // based on custom product variables defined in Android.bp files. These
65 // variables are namespaced to prevent clobbering, especially when set from
66 // Makefiles.
67 namespacedVariableProperties namespacedVariableProperties
68
69 // baseModuleType is set when this module was created from a module type
70 // defined by a soong_config_module_type. Every soong_config_module_type
71 // "wraps" another module type, e.g. a soong_config_module_type can wrap a
72 // cc_defaults to a custom_cc_defaults, or cc_binary to a custom_cc_binary.
73 // This baseModuleType is set to the wrapped module type.
74 baseModuleType string
Liz Kammerea6666f2021-02-17 10:17:28 -050075}
76
77// Bazelable is specifies the interface for modules that can be converted to Bazel.
78type Bazelable interface {
Liz Kammerba3ea162021-02-17 13:22:03 -050079 bazelProps() *properties
80 HasHandcraftedLabel() bool
Liz Kammerbdc60992021-02-24 16:55:11 -050081 HandcraftedLabel() string
82 GetBazelLabel(ctx BazelConversionPathContext, module blueprint.Module) string
Jingwen Chen55bc8202021-11-02 06:40:51 +000083 ConvertWithBp2build(ctx BazelConversionContext) bool
84 convertWithBp2build(ctx BazelConversionContext, module blueprint.Module) bool
Liz Kammerba3ea162021-02-17 13:22:03 -050085 GetBazelBuildFileContents(c Config, path, name string) (string, error)
Jingwen Chena47f28d2021-11-02 16:43:57 +000086
Jingwen Chen84817de2021-11-17 10:57:35 +000087 // namespacedVariableProps is a map from a soong config variable namespace
88 // (e.g. acme, android) to a map of interfaces{}, which are really
89 // reflect.Struct pointers, representing the value of the
90 // soong_config_variables property of a module. The struct pointer is the
91 // one with the single member called Soong_config_variables, which itself is
92 // a struct containing fields for each supported feature in that namespace.
93 //
94 // The reason for using an slice of interface{} is to support defaults
95 // propagation of the struct pointers.
Jingwen Chena47f28d2021-11-02 16:43:57 +000096 namespacedVariableProps() namespacedVariableProperties
97 setNamespacedVariableProps(props namespacedVariableProperties)
98 BaseModuleType() string
Jingwen Chen84817de2021-11-17 10:57:35 +000099 SetBaseModuleType(baseModuleType string)
Liz Kammerea6666f2021-02-17 10:17:28 -0500100}
101
102// BazelModule is a lightweight wrapper interface around Module for Bazel-convertible modules.
103type BazelModule interface {
104 Module
105 Bazelable
106}
107
108// InitBazelModule is a wrapper function that decorates a BazelModule with Bazel-conversion
109// properties.
110func InitBazelModule(module BazelModule) {
111 module.AddProperties(module.bazelProps())
112}
113
114// bazelProps returns the Bazel properties for the given BazelModuleBase.
Liz Kammerba3ea162021-02-17 13:22:03 -0500115func (b *BazelModuleBase) bazelProps() *properties {
Liz Kammerea6666f2021-02-17 10:17:28 -0500116 return &b.bazelProperties
117}
118
Jingwen Chena47f28d2021-11-02 16:43:57 +0000119func (b *BazelModuleBase) namespacedVariableProps() namespacedVariableProperties {
120 return b.namespacedVariableProperties
121}
122
123func (b *BazelModuleBase) setNamespacedVariableProps(props namespacedVariableProperties) {
124 b.namespacedVariableProperties = props
125}
126
127func (b *BazelModuleBase) BaseModuleType() string {
128 return b.baseModuleType
129}
130
131func (b *BazelModuleBase) SetBaseModuleType(baseModuleType string) {
132 b.baseModuleType = baseModuleType
133}
134
Liz Kammerba3ea162021-02-17 13:22:03 -0500135// HasHandcraftedLabel returns whether this module has a handcrafted Bazel label.
136func (b *BazelModuleBase) HasHandcraftedLabel() bool {
137 return b.bazelProperties.Bazel_module.Label != nil
138}
139
140// HandcraftedLabel returns the handcrafted label for this module, or empty string if there is none
141func (b *BazelModuleBase) HandcraftedLabel() string {
142 return proptools.String(b.bazelProperties.Bazel_module.Label)
143}
144
Liz Kammerea6666f2021-02-17 10:17:28 -0500145// GetBazelLabel returns the Bazel label for the given BazelModuleBase.
Liz Kammerbdc60992021-02-24 16:55:11 -0500146func (b *BazelModuleBase) GetBazelLabel(ctx BazelConversionPathContext, module blueprint.Module) string {
147 if b.HasHandcraftedLabel() {
148 return b.HandcraftedLabel()
149 }
Jingwen Chen12b4c272021-03-10 02:05:59 -0500150 if b.ConvertWithBp2build(ctx) {
Liz Kammerbdc60992021-02-24 16:55:11 -0500151 return bp2buildModuleLabel(ctx, module)
152 }
153 return "" // no label for unconverted module
Liz Kammerea6666f2021-02-17 10:17:28 -0500154}
155
Jingwen Chen12b4c272021-03-10 02:05:59 -0500156// Configuration to decide if modules in a directory should default to true/false for bp2build_available
157type Bp2BuildConfig map[string]BazelConversionConfigEntry
158type BazelConversionConfigEntry int
159
160const (
Jingwen Chen91220d72021-03-24 02:18:33 -0400161 // A sentinel value to be used as a key in Bp2BuildConfig for modules with
162 // no package path. This is also the module dir for top level Android.bp
163 // modules.
164 BP2BUILD_TOPLEVEL = "."
165
Jingwen Chen12b4c272021-03-10 02:05:59 -0500166 // iota + 1 ensures that the int value is not 0 when used in the Bp2buildAllowlist map,
167 // which can also mean that the key doesn't exist in a lookup.
168
169 // all modules in this package and subpackages default to bp2build_available: true.
170 // allows modules to opt-out.
171 Bp2BuildDefaultTrueRecursively BazelConversionConfigEntry = iota + 1
172
Jingwen Chen294e7742021-08-31 05:58:01 +0000173 // all modules in this package (not recursively) default to bp2build_available: true.
174 // allows modules to opt-out.
175 Bp2BuildDefaultTrue
176
Jingwen Chen12b4c272021-03-10 02:05:59 -0500177 // all modules in this package (not recursively) default to bp2build_available: false.
178 // allows modules to opt-in.
179 Bp2BuildDefaultFalse
180)
181
182var (
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400183 // Keep any existing BUILD files (and do not generate new BUILD files) for these directories
Jingwen Chenb643c7a2021-07-26 04:45:48 +0000184 // in the synthetic Bazel workspace.
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400185 bp2buildKeepExistingBuildFile = map[string]bool{
186 // This is actually build/bazel/build.BAZEL symlinked to ./BUILD
Jingwen Chenf59a8e12021-07-16 09:28:53 +0000187 ".":/*recursive = */ false,
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400188
Jingwen Chenb643c7a2021-07-26 04:45:48 +0000189 // build/bazel/examples/apex/... BUILD files should be generated, so
190 // build/bazel is not recursive. Instead list each subdirectory under
191 // build/bazel explicitly.
192 "build/bazel":/* recursive = */ false,
193 "build/bazel/examples/android_app":/* recursive = */ true,
Romain Jobredeaux5cc9c9d2021-08-26 15:07:48 +0000194 "build/bazel/examples/java":/* recursive = */ true,
Jingwen Chenb643c7a2021-07-26 04:45:48 +0000195 "build/bazel/bazel_skylib":/* recursive = */ true,
196 "build/bazel/rules":/* recursive = */ true,
197 "build/bazel/rules_cc":/* recursive = */ true,
Jingwen Chen294e7742021-08-31 05:58:01 +0000198 "build/bazel/scripts":/* recursive = */ true,
Jingwen Chenb643c7a2021-07-26 04:45:48 +0000199 "build/bazel/tests":/* recursive = */ true,
200 "build/bazel/platforms":/* recursive = */ true,
201 "build/bazel/product_variables":/* recursive = */ true,
Jingwen Chen5e49b822021-08-24 05:14:22 +0000202 "build/bazel_common_rules":/* recursive = */ true,
Romain Jobredeaux9e09bba2021-09-08 18:09:02 +0000203 "build/make/tools":/* recursive = */ true,
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400204 "build/pesto":/* recursive = */ true,
205
206 // external/bazelbuild-rules_android/... is needed by mixed builds, otherwise mixed builds analysis fails
207 // e.g. ERROR: Analysis of target '@soong_injection//mixed_builds:buildroot' failed
208 "external/bazelbuild-rules_android":/* recursive = */ true,
Jingwen Chen91632252021-08-10 13:00:33 +0000209 "external/bazel-skylib":/* recursive = */ true,
Romain Jobredeaux9e09bba2021-09-08 18:09:02 +0000210 "external/guava":/* recursive = */ true,
211 "external/error_prone":/* recursive = */ true,
212 "external/jsr305":/* recursive = */ true,
213 "frameworks/ex/common":/* recursive = */ true,
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400214
Romain Jobredeauxf1b0ac82021-08-12 14:39:00 +0000215 "packages/apps/Music":/* recursive = */ true,
Romain Jobredeaux9e09bba2021-09-08 18:09:02 +0000216 "packages/apps/QuickSearchBox":/* recursive = */ true,
Romain Jobredeauxa2c08142021-09-22 14:43:43 -0400217 "packages/apps/WallpaperPicker":/* recursive = */ false,
218
Chris Parsons494eef32021-11-09 10:29:52 -0500219 "prebuilts/gcc":/* recursive = */ true,
Romain Jobredeauxa2c08142021-09-22 14:43:43 -0400220 "prebuilts/sdk":/* recursive = */ false,
221 "prebuilts/sdk/current/extras/app-toolkit":/* recursive = */ false,
222 "prebuilts/sdk/current/support":/* recursive = */ false,
223 "prebuilts/sdk/tools":/* recursive = */ false,
224 "prebuilts/r8":/* recursive = */ false,
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400225 }
226
Jingwen Chen12b4c272021-03-10 02:05:59 -0500227 // Configure modules in these directories to enable bp2build_available: true or false by default.
228 bp2buildDefaultConfig = Bp2BuildConfig{
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400229 "art/libdexfile": Bp2BuildDefaultTrueRecursively,
230 "bionic": Bp2BuildDefaultTrueRecursively,
231 "bootable/recovery/tools/recovery_l10n": Bp2BuildDefaultTrue,
Jingwen Chen0a9d09f2021-11-24 07:00:11 +0000232 "build/bazel/examples/soong_config_variables": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400233 "build/bazel/examples/apex/minimal": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500234 "build/soong": Bp2BuildDefaultTrue,
Rupert Shuttleworth2ac9c482021-11-10 10:37:05 -0500235 "build/soong/cc/libbuildversion": Bp2BuildDefaultTrue, // Skip tests subdir
Chris Parsons8a498162021-11-18 17:19:12 -0500236 "cts/common/device-side/nativetesthelper/jni": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400237 "development/apps/DevelopmentSettings": Bp2BuildDefaultTrue,
238 "development/apps/Fallback": Bp2BuildDefaultTrue,
239 "development/apps/WidgetPreview": Bp2BuildDefaultTrue,
240 "development/samples/BasicGLSurfaceView": Bp2BuildDefaultTrue,
241 "development/samples/BluetoothChat": Bp2BuildDefaultTrue,
242 "development/samples/BrokenKeyDerivation": Bp2BuildDefaultTrue,
243 "development/samples/Compass": Bp2BuildDefaultTrue,
244 "development/samples/ContactManager": Bp2BuildDefaultTrue,
245 "development/samples/FixedGridLayout": Bp2BuildDefaultTrue,
246 "development/samples/HelloEffects": Bp2BuildDefaultTrue,
247 "development/samples/Home": Bp2BuildDefaultTrue,
248 "development/samples/HoneycombGallery": Bp2BuildDefaultTrue,
249 "development/samples/JetBoy": Bp2BuildDefaultTrue,
250 "development/samples/KeyChainDemo": Bp2BuildDefaultTrue,
251 "development/samples/LceDemo": Bp2BuildDefaultTrue,
252 "development/samples/LunarLander": Bp2BuildDefaultTrue,
253 "development/samples/MultiResolution": Bp2BuildDefaultTrue,
254 "development/samples/MultiWindow": Bp2BuildDefaultTrue,
255 "development/samples/NotePad": Bp2BuildDefaultTrue,
256 "development/samples/Obb": Bp2BuildDefaultTrue,
257 "development/samples/RSSReader": Bp2BuildDefaultTrue,
258 "development/samples/ReceiveShareDemo": Bp2BuildDefaultTrue,
259 "development/samples/SearchableDictionary": Bp2BuildDefaultTrue,
260 "development/samples/SipDemo": Bp2BuildDefaultTrue,
261 "development/samples/SkeletonApp": Bp2BuildDefaultTrue,
262 "development/samples/Snake": Bp2BuildDefaultTrue,
263 "development/samples/SpellChecker/": Bp2BuildDefaultTrueRecursively,
264 "development/samples/ThemedNavBarKeyboard": Bp2BuildDefaultTrue,
265 "development/samples/ToyVpn": Bp2BuildDefaultTrue,
266 "development/samples/TtsEngine": Bp2BuildDefaultTrue,
267 "development/samples/USB/AdbTest": Bp2BuildDefaultTrue,
268 "development/samples/USB/MissileLauncher": Bp2BuildDefaultTrue,
269 "development/samples/VoiceRecognitionService": Bp2BuildDefaultTrue,
270 "development/samples/VoicemailProviderDemo": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400271 "development/sdk": Bp2BuildDefaultTrueRecursively,
272 "external/arm-optimized-routines": Bp2BuildDefaultTrueRecursively,
273 "external/boringssl": Bp2BuildDefaultTrueRecursively,
274 "external/brotli": Bp2BuildDefaultTrue,
275 "external/fmtlib": Bp2BuildDefaultTrueRecursively,
Chris Parsonsb97a8172021-10-04 12:48:29 -0400276 "external/google-benchmark": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500277 "external/googletest": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400278 "external/gwp_asan": Bp2BuildDefaultTrueRecursively,
279 "external/jemalloc_new": Bp2BuildDefaultTrueRecursively,
Chris Parsonsb97a8172021-10-04 12:48:29 -0400280 "external/jsoncpp": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400281 "external/libcap": Bp2BuildDefaultTrueRecursively,
282 "external/libcxx": Bp2BuildDefaultTrueRecursively,
283 "external/libcxxabi": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500284 "external/libevent": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400285 "external/lz4/lib": Bp2BuildDefaultTrue,
Chris Parsons8a498162021-11-18 17:19:12 -0500286 "external/lzma/C": Bp2BuildDefaultTrueRecursively,
Liz Kammer2fc34892021-10-11 12:56:48 -0400287 "external/mdnsresponder": Bp2BuildDefaultTrueRecursively,
288 "external/minijail": Bp2BuildDefaultTrueRecursively,
289 "external/pcre": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400290 "external/protobuf": Bp2BuildDefaultTrueRecursively,
291 "external/python/six": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500292 "external/selinux/libsepol": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400293 "external/scudo": Bp2BuildDefaultTrueRecursively,
Liz Kammer2fc34892021-10-11 12:56:48 -0400294 "external/selinux/libselinux": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400295 "external/zlib": Bp2BuildDefaultTrueRecursively,
Liz Kammer2fc34892021-10-11 12:56:48 -0400296 "external/zstd": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400297 "frameworks/base/media/tests/MediaDump": Bp2BuildDefaultTrue,
298 "frameworks/base/startop/apps/test": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400299 "frameworks/native/libs/adbd_auth": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400300 "frameworks/native/opengl/tests/gl2_cameraeye": Bp2BuildDefaultTrue,
301 "frameworks/native/opengl/tests/gl2_java": Bp2BuildDefaultTrue,
302 "frameworks/native/opengl/tests/testLatency": Bp2BuildDefaultTrue,
303 "frameworks/native/opengl/tests/testPauseResume": Bp2BuildDefaultTrue,
304 "frameworks/native/opengl/tests/testViewport": Bp2BuildDefaultTrue,
Chris Parsons8a498162021-11-18 17:19:12 -0500305 "frameworks/proto_logging/stats/stats_log_api_gen": Bp2BuildDefaultTrueRecursively,
306 "libnativehelper": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400307 "packages/apps/DevCamera": Bp2BuildDefaultTrue,
308 "packages/apps/HTMLViewer": Bp2BuildDefaultTrue,
309 "packages/apps/Protips": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400310 "packages/modules/adb": Bp2BuildDefaultTrue,
311 "packages/modules/adb/crypto": Bp2BuildDefaultTrueRecursively,
312 "packages/modules/adb/libs": Bp2BuildDefaultTrueRecursively,
313 "packages/modules/adb/pairing_auth": Bp2BuildDefaultTrueRecursively,
314 "packages/modules/adb/pairing_connection": Bp2BuildDefaultTrueRecursively,
315 "packages/modules/adb/proto": Bp2BuildDefaultTrueRecursively,
316 "packages/modules/adb/tls": Bp2BuildDefaultTrueRecursively,
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400317 "packages/providers/MediaProvider/tools/dialogs": Bp2BuildDefaultTrue,
318 "packages/screensavers/Basic": Bp2BuildDefaultTrue,
319 "packages/services/Car/tests/SampleRearViewCamera": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400320 "prebuilts/clang/host/linux-x86": Bp2BuildDefaultTrueRecursively,
Jingwen Chend43d4a42021-11-23 12:40:11 +0000321 "system/apex": Bp2BuildDefaultFalse, // TODO(b/207466993): flaky failures
Chris Parsons8a498162021-11-18 17:19:12 -0500322 "system/core/debuggerd": Bp2BuildDefaultTrue,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400323 "system/core/diagnose_usb": Bp2BuildDefaultTrueRecursively,
324 "system/core/libasyncio": Bp2BuildDefaultTrue,
325 "system/core/libcrypto_utils": Bp2BuildDefaultTrueRecursively,
326 "system/core/libcutils": Bp2BuildDefaultTrueRecursively,
Liz Kammer2fc34892021-10-11 12:56:48 -0400327 "system/core/libpackagelistparser": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400328 "system/core/libprocessgroup": Bp2BuildDefaultTrue,
Chris Parsonsb97a8172021-10-04 12:48:29 -0400329 "system/core/libprocessgroup/cgrouprc": Bp2BuildDefaultTrue,
330 "system/core/libprocessgroup/cgrouprc_format": Bp2BuildDefaultTrue,
Chris Parsons8a498162021-11-18 17:19:12 -0500331 "system/core/libsystem": Bp2BuildDefaultTrueRecursively,
332 "system/core/libutils": Bp2BuildDefaultTrueRecursively,
333 "system/core/libvndksupport": Bp2BuildDefaultTrueRecursively,
Lukacs T. Berki497f17d2021-04-26 12:15:57 +0200334 "system/core/property_service/libpropertyinfoparser": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400335 "system/libbase": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500336 "system/libprocinfo": Bp2BuildDefaultTrue,
Chris Parsonsc39f6332021-10-01 18:00:31 -0400337 "system/libziparchive": Bp2BuildDefaultTrueRecursively,
Chris Parsonsa37e1952021-09-28 16:47:36 -0400338 "system/logging/liblog": Bp2BuildDefaultTrueRecursively,
339 "system/sepolicy/apex": Bp2BuildDefaultTrueRecursively,
340 "system/timezone/apex": Bp2BuildDefaultTrueRecursively,
341 "system/timezone/output_data": Bp2BuildDefaultTrueRecursively,
Chris Parsons8a498162021-11-18 17:19:12 -0500342 "system/unwinding/libbacktrace": Bp2BuildDefaultTrueRecursively,
343 "system/unwinding/libunwindstack": Bp2BuildDefaultTrueRecursively,
Jingwen Chen12b4c272021-03-10 02:05:59 -0500344 }
Jingwen Chen5d72cba2021-03-25 09:28:38 +0000345
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400346 // Per-module denylist to always opt modules out of both bp2build and mixed builds.
Rupert Shuttleworth4f43fe92021-03-30 14:13:16 +0000347 bp2buildModuleDoNotConvertList = []string{
Chris Parsons8a498162021-11-18 17:19:12 -0500348 "libnativehelper_compat_libc++", // Broken compile: implicit declaration of function 'strerror_r' is invalid in C99
349 "art_libdexfile_dex_instruction_list_header", // breaks libart_mterp.armng, header not found
350
351 "libandroid_runtime_lazy", // depends on unconverted modules: libbinder_headers
352 "libcmd", // depends on unconverted modules: libbinder
353
354 "chkcon", "sefcontext_compile", // depends on unconverted modules: libsepol
355
356 "libsepol", // TODO(b/207408632): Unsupported case of .l sources in cc library rules
357
358 "get_clang_version_test", // depends on unconverted module: get_clang_version
359
360 "libbinder", // TODO(b/188503688): Disabled for some archs,
361 "libactivitymanager_aidl", // TODO(b/207426160): Depends on activity_manager_procstate_aidl, which is an aidl filegroup.
362
363 "libnativehelper_lazy_mts_jni", // depends on unconverted modules: libgmock_ndk
364 "libnativehelper_mts_jni", // depends on unconverted modules: libgmock_ndk
365 "libnativetesthelper_jni", // depends on unconverted modules: libgtest_ndk_c++
366
367 "statslog-framework-java-gen", "statslog.cpp", "statslog.h", "statslog.rs", "statslog_header.rs", // depends on unconverted modules: stats-log-api-gen
368
369 "stats-log-api-gen", // depends on unconverted modules: libstats_proto_host, libprotobuf-cpp-full
370
371 "libstatslog", // depends on unconverted modules: statslog.cpp, statslog.h, ...
372
373 "libgmock_main_ndk", "libgmock_ndk", // depends on unconverted module: libgtest_ndk_c++
374
375 "cmd", // depends on unconverted module packagemanager_aidl-cpp, of unsupported type aidl_interface
376 "servicedispatcher", // depends on unconverted module android.debug_aidl, of unsupported type aidl_interface
377 "libutilscallstack", // depends on unconverted module libbacktrace
378 "libbacktrace", // depends on unconverted module libunwindstack
379 "libdebuggerd_handler", // depends on unconverted module libdebuggerd_handler_core
380 "libdebuggerd_handler_core", "libdebuggerd_handler_fallback", // depends on unconverted module libdebuggerd
381 "unwind_for_offline", // depends on unconverted module libunwindstack_utils
382 "libdebuggerd", // depends on unconverted modules libdexfile_support, libunwindstack, gwp_asan_crash_handler, libtombstone_proto, libprotobuf-cpp-lite
383 "libdexfile_static", // depends on libartpalette, libartbase, libdexfile, which are of unsupported type: art_cc_library.
384 "host_bionic_linker_asm", // depends on extract_linker, a go binary.
385 "host_bionic_linker_script", // depends on extract_linker, a go binary.
386
387 "pbtombstone", // depends on libprotobuf-cpp-lite, libtombstone_proto
388 "crash_dump", // depends on unconverted module libprotobuf-cpp-lite
Chris Parsons494eef32021-11-09 10:29:52 -0500389 "libprotobuf-cpp-full", "libprotobuf-cpp-lite", // Unsupported product&vendor suffix. b/204811222 and b/204810610.
390
Chris Parsons8a498162021-11-18 17:19:12 -0500391 "libunwindstack_local", "libunwindstack_utils", // depends on unconverted module libunwindstack
392 "libunwindstack", // depends on libdexfile_support, of unsupported module type art_cc_library_static
393 "libc_malloc_debug", // depends on unconverted module libunwindstack
Rupert Shuttleworth47aa5842021-04-30 04:04:15 -0400394
Chris Parsonsc39f6332021-10-01 18:00:31 -0400395 "libbase_ndk", // http://b/186826477, fails to link libctscamera2_jni for device (required for CtsCameraTestCases)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000396
Chris Parsons8a498162021-11-18 17:19:12 -0500397 "lib_linker_config_proto_lite", // contains .proto sources
398
Liz Kammer0f3b7d22021-09-28 13:48:21 -0400399 "libprotobuf-python", // contains .proto sources
400 "libprotobuf-internal-protos", // we don't handle path property for fileegroups
401 "libprotobuf-internal-python-srcs", // we don't handle path property for fileegroups
402
Chris Parsonsa37e1952021-09-28 16:47:36 -0400403 "libseccomp_policy", // b/201094425: depends on func_to_syscall_nrs, which depends on py_binary, which is unsupported in mixed builds.
Chris Parsons8a498162021-11-18 17:19:12 -0500404 "libfdtrack", // depends on unconverted module libunwindstack
Lukacs T. Berkib5ac5af2021-04-27 11:02:11 +0200405
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400406 "gwp_asan_crash_handler", // cc_library, ld.lld: error: undefined symbol: memset
407
Chris Parsonsb97a8172021-10-04 12:48:29 -0400408 "brotli-fuzzer-corpus", // b/202015218: outputs are in location incompatible with bazel genrule handling.
Jingwen Chen294e7742021-08-31 05:58:01 +0000409
Jingwen Chendf27b7a2021-10-18 06:33:16 +0000410 // b/203369847: multiple genrules in the same package creating the same file
411 // //development/sdk/...
412 "platform_tools_properties",
413 "build_tools_source_properties",
414
Jingwen Chen790324e2021-04-30 08:20:01 +0000415 // Tests. Handle later.
416 "libbionic_tests_headers_posix", // http://b/186024507, cc_library_static, sched.h, time.h not found
417 "libjemalloc5_integrationtest",
418 "libjemalloc5_stresstestlib",
419 "libjemalloc5_unittest",
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -0400420
421 // APEX support
Chris Parsonsb97a8172021-10-04 12:48:29 -0400422 "com.android.runtime", // http://b/194746715, apex, depends on 'libc_malloc_debug'
Chris Parsonsa37e1952021-09-28 16:47:36 -0400423
424 "libadb_crypto", // Depends on libadb_protos
425 "libadb_crypto_static", // Depends on libadb_protos_static
426 "libadb_pairing_connection", // Depends on libadb_protos
427 "libadb_pairing_connection_static", // Depends on libadb_protos_static
428 "libadb_pairing_server", // Depends on libadb_protos
429 "libadb_pairing_server_static", // Depends on libadb_protos_static
430 "libadbd", // Depends on libadbd_core
431 "libadbd_core", // Depends on libadb_protos
432 "libadbd_services", // Depends on libadb_protos
433
434 "libadb_protos_static", // b/200601772: Requires cc_library proto support
435 "libadb_protos", // b/200601772: Requires cc_library proto support
436 "libapp_processes_protos_lite", // b/200601772: Requires cc_library proto support
Chris Parsonsc39f6332021-10-01 18:00:31 -0400437
438 "libgtest_ndk_c++", // b/201816222: Requires sdk_version support.
439 "libgtest_main_ndk_c++", // b/201816222: Requires sdk_version support.
Liz Kammer2b8004b2021-10-04 13:55:44 -0400440
Chris Parsons8a498162021-11-18 17:19:12 -0500441 "abb", // depends on unconverted modules: libadbd_core, libadbd_services,
442 "adb", // depends on unconverted modules: bin2c_fastdeployagent, libadb_crypto, libadb_host, libadb_pairing_connection, libadb_protos, libandroidfw, libapp_processes_protos_full, libfastdeploy_host, libopenscreen-discovery, libopenscreen-platform-impl, libusb, libzstd, AdbWinApi
443 "adbd", // depends on unconverted modules: libadb_crypto, libadb_pairing_connection, libadb_protos, libadbd, libadbd_core, libapp_processes_protos_lite, libzstd, libadbd_services, libcap, libminijail
444 "linker", // depends on unconverted modules: libdebuggerd_handler_fallback
Liz Kammer2b8004b2021-10-04 13:55:44 -0400445 "linker_reloc_bench_main", // depends on unconverted modules: liblinker_reloc_bench_*
Chris Parsons8a498162021-11-18 17:19:12 -0500446 "versioner", // depends on unconverted modules: libclang_cxx_host, libLLVM_host, of unsupported type llvm_host_prebuilt_library_shared
Liz Kammer2b8004b2021-10-04 13:55:44 -0400447
448 "linkerconfig", // http://b/202876379 has arch-variant static_executable
449 "mdnsd", // http://b/202876379 has arch-variant static_executable
450
451 "acvp_modulewrapper", // disabled for android x86/x86_64
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400452 "CarHTMLViewer", // depends on unconverted modules android.car-stubs, car-ui-lib
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400453 }
Rupert Shuttleworthc143cc52021-04-13 13:08:04 -0400454
Jingwen Chen179856a2021-05-03 09:15:48 +0000455 // Per-module denylist of cc_library modules to only generate the static
456 // variant if their shared variant isn't ready or buildable by Bazel.
457 bp2buildCcLibraryStaticOnlyList = []string{
Jingwen Chen53542922021-05-18 09:01:49 +0000458 "libjemalloc5", // http://b/188503688, cc_library, `target: { android: { enabled: false } }` for android targets.
Jingwen Chen179856a2021-05-03 09:15:48 +0000459 }
460
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400461 // Per-module denylist to opt modules out of mixed builds. Such modules will
462 // still be generated via bp2build.
Chris Parsons2c788392021-08-10 11:58:07 -0400463 mixedBuildsDisabledList = []string{
Wei Li455ba832021-11-04 22:58:12 +0000464 "libbrotli", // http://b/198585397, ld.lld: error: bionic/libc/arch-arm64/generic/bionic/memmove.S:95:(.text+0x10): relocation R_AARCH64_CONDBR19 out of range: -1404176 is not in [-1048576, 1048575]; references __memcpy
465 "minijail_constants_json", // http://b/200899432, bazel-built cc_genrule does not work in mixed build when it is a dependency of another soong module.
Liz Kammerc3192992021-11-16 17:01:11 -0500466
Jingwen Chend4808592021-11-26 05:39:07 +0000467 "cap_names.h", // TODO(b/204913827) runfiles need to be handled in mixed builds
468 "libcap", // TODO(b/204913827) runfiles need to be handled in mixed builds
469 "libprotobuf-cpp-full", "libprotobuf-cpp-lite", // Unsupported product&vendor suffix. b/204811222 and b/204810610.
Chris Parsons2c788392021-08-10 11:58:07 -0400470 }
Rupert Shuttleworth4f43fe92021-03-30 14:13:16 +0000471
472 // Used for quicker lookups
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400473 bp2buildModuleDoNotConvert = map[string]bool{}
Jingwen Chen179856a2021-05-03 09:15:48 +0000474 bp2buildCcLibraryStaticOnly = map[string]bool{}
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400475 mixedBuildsDisabled = map[string]bool{}
Jingwen Chen12b4c272021-03-10 02:05:59 -0500476)
477
Rupert Shuttleworth4f43fe92021-03-30 14:13:16 +0000478func init() {
479 for _, moduleName := range bp2buildModuleDoNotConvertList {
480 bp2buildModuleDoNotConvert[moduleName] = true
481 }
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400482
Jingwen Chen179856a2021-05-03 09:15:48 +0000483 for _, moduleName := range bp2buildCcLibraryStaticOnlyList {
484 bp2buildCcLibraryStaticOnly[moduleName] = true
485 }
486
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400487 for _, moduleName := range mixedBuildsDisabledList {
488 mixedBuildsDisabled[moduleName] = true
489 }
490}
491
Chris Parsons953b3562021-09-20 15:14:39 -0400492func GenerateCcLibraryStaticOnly(moduleName string) bool {
493 return bp2buildCcLibraryStaticOnly[moduleName]
Jingwen Chen179856a2021-05-03 09:15:48 +0000494}
495
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400496func ShouldKeepExistingBuildFileForDir(dir string) bool {
497 if _, ok := bp2buildKeepExistingBuildFile[dir]; ok {
498 // Exact dir match
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400499 return true
500 }
Rupert Shuttleworth00960792021-05-12 21:20:13 -0400501 // Check if subtree match
502 for prefix, recursive := range bp2buildKeepExistingBuildFile {
503 if recursive {
504 if strings.HasPrefix(dir, prefix+"/") {
505 return true
506 }
507 }
508 }
509 // Default
510 return false
Rupert Shuttleworth2a4fc3e2021-04-21 07:10:09 -0400511}
512
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400513// MixedBuildsEnabled checks that a module is ready to be replaced by a
514// converted or handcrafted Bazel target.
Chris Parsons494eef32021-11-09 10:29:52 -0500515func (b *BazelModuleBase) MixedBuildsEnabled(ctx ModuleContext) bool {
516 if ctx.Os() == Windows {
517 // Windows toolchains are not currently supported.
518 return false
519 }
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400520 if !ctx.Config().BazelContext.BazelEnabled() {
521 return false
522 }
Liz Kammer6eff3232021-08-26 08:37:59 -0400523 if !convertedToBazel(ctx, ctx.Module()) {
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400524 return false
525 }
Liz Kammer6eff3232021-08-26 08:37:59 -0400526
Chris Parsons953b3562021-09-20 15:14:39 -0400527 if GenerateCcLibraryStaticOnly(ctx.Module().Name()) {
Jingwen Chen179856a2021-05-03 09:15:48 +0000528 // Don't use partially-converted cc_library targets in mixed builds,
529 // since mixed builds would generally rely on both static and shared
530 // variants of a cc_library.
531 return false
532 }
Chris Parsonsbab4d7e2021-04-15 17:27:08 -0400533 return !mixedBuildsDisabled[ctx.Module().Name()]
Rupert Shuttleworth4f43fe92021-03-30 14:13:16 +0000534}
535
Liz Kammer6eff3232021-08-26 08:37:59 -0400536// ConvertedToBazel returns whether this module has been converted (with bp2build or manually) to Bazel.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000537func convertedToBazel(ctx BazelConversionContext, module blueprint.Module) bool {
Liz Kammer6eff3232021-08-26 08:37:59 -0400538 b, ok := module.(Bazelable)
539 if !ok {
540 return false
541 }
542 return b.convertWithBp2build(ctx, module) || b.HasHandcraftedLabel()
543}
544
Liz Kammerea6666f2021-02-17 10:17:28 -0500545// ConvertWithBp2build returns whether the given BazelModuleBase should be converted with bp2build.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000546func (b *BazelModuleBase) ConvertWithBp2build(ctx BazelConversionContext) bool {
Liz Kammer6eff3232021-08-26 08:37:59 -0400547 return b.convertWithBp2build(ctx, ctx.Module())
548}
549
Jingwen Chen55bc8202021-11-02 06:40:51 +0000550func (b *BazelModuleBase) convertWithBp2build(ctx BazelConversionContext, module blueprint.Module) bool {
Liz Kammer6eff3232021-08-26 08:37:59 -0400551 if bp2buildModuleDoNotConvert[module.Name()] {
Jingwen Chen5d72cba2021-03-25 09:28:38 +0000552 return false
553 }
554
Jingwen Chen12b4c272021-03-10 02:05:59 -0500555 // Ensure that the module type of this module has a bp2build converter. This
556 // prevents mixed builds from using auto-converted modules just by matching
557 // the package dir; it also has to have a bp2build mutator as well.
Liz Kammer6eff3232021-08-26 08:37:59 -0400558 if ctx.Config().bp2buildModuleTypeConfig[ctx.OtherModuleType(module)] == false {
Jingwen Chena47f28d2021-11-02 16:43:57 +0000559 if b, ok := module.(Bazelable); ok && b.BaseModuleType() != "" {
560 // For modules with custom types from soong_config_module_types,
561 // check that their _base module type_ has a bp2build mutator.
562 if ctx.Config().bp2buildModuleTypeConfig[b.BaseModuleType()] == false {
563 return false
564 }
565 } else {
566 return false
567 }
Jingwen Chen12b4c272021-03-10 02:05:59 -0500568 }
569
Liz Kammer6eff3232021-08-26 08:37:59 -0400570 packagePath := ctx.OtherModuleDir(module)
Jingwen Chen12b4c272021-03-10 02:05:59 -0500571 config := ctx.Config().bp2buildPackageConfig
572
573 // This is a tristate value: true, false, or unset.
574 propValue := b.bazelProperties.Bazel_module.Bp2build_available
575 if bp2buildDefaultTrueRecursively(packagePath, config) {
576 // Allow modules to explicitly opt-out.
577 return proptools.BoolDefault(propValue, true)
578 }
579
580 // Allow modules to explicitly opt-in.
581 return proptools.BoolDefault(propValue, false)
582}
583
584// bp2buildDefaultTrueRecursively checks that the package contains a prefix from the
585// set of package prefixes where all modules must be converted. That is, if the
586// package is x/y/z, and the list contains either x, x/y, or x/y/z, this function will
587// return true.
588//
589// However, if the package is x/y, and it matches a Bp2BuildDefaultFalse "x/y" entry
590// exactly, this module will return false early.
591//
592// This function will also return false if the package doesn't match anything in
593// the config.
594func bp2buildDefaultTrueRecursively(packagePath string, config Bp2BuildConfig) bool {
595 ret := false
596
Jingwen Chen294e7742021-08-31 05:58:01 +0000597 // Check if the package path has an exact match in the config.
598 if config[packagePath] == Bp2BuildDefaultTrue || config[packagePath] == Bp2BuildDefaultTrueRecursively {
Jingwen Chen91220d72021-03-24 02:18:33 -0400599 return true
Jingwen Chen294e7742021-08-31 05:58:01 +0000600 } else if config[packagePath] == Bp2BuildDefaultFalse {
Jingwen Chen12b4c272021-03-10 02:05:59 -0500601 return false
602 }
603
Jingwen Chen91220d72021-03-24 02:18:33 -0400604 // If not, check for the config recursively.
Jingwen Chen12b4c272021-03-10 02:05:59 -0500605 packagePrefix := ""
606 // e.g. for x/y/z, iterate over x, x/y, then x/y/z, taking the final value from the allowlist.
607 for _, part := range strings.Split(packagePath, "/") {
608 packagePrefix += part
609 if config[packagePrefix] == Bp2BuildDefaultTrueRecursively {
610 // package contains this prefix and this prefix should convert all modules
611 return true
612 }
613 // Continue to the next part of the package dir.
614 packagePrefix += "/"
615 }
616
617 return ret
Liz Kammerea6666f2021-02-17 10:17:28 -0500618}
Liz Kammerba3ea162021-02-17 13:22:03 -0500619
620// GetBazelBuildFileContents returns the file contents of a hand-crafted BUILD file if available or
621// an error if there are errors reading the file.
622// TODO(b/181575318): currently we append the whole BUILD file, let's change that to do
623// something more targeted based on the rule type and target.
624func (b *BazelModuleBase) GetBazelBuildFileContents(c Config, path, name string) (string, error) {
Liz Kammerbdc60992021-02-24 16:55:11 -0500625 if !strings.Contains(b.HandcraftedLabel(), path) {
626 return "", fmt.Errorf("%q not found in bazel_module.label %q", path, b.HandcraftedLabel())
Liz Kammerba3ea162021-02-17 13:22:03 -0500627 }
628 name = filepath.Join(path, name)
629 f, err := c.fs.Open(name)
630 if err != nil {
631 return "", err
632 }
633 defer f.Close()
634
635 data, err := ioutil.ReadAll(f)
636 if err != nil {
637 return "", err
638 }
639 return string(data[:]), nil
640}