Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1 | // Copyright 2016 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package cc |
| 16 | |
| 17 | import ( |
| 18 | "fmt" |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 19 | "io" |
Jeff Gaston | 7276539 | 2017-11-28 16:37:53 -0800 | [diff] [blame] | 20 | "sort" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 21 | "strings" |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 22 | "sync" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 23 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 24 | "github.com/google/blueprint" |
| 25 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 26 | "android/soong/android" |
Evgenii Stepanov | af36db1 | 2016-08-15 14:18:24 -0700 | [diff] [blame] | 27 | "android/soong/cc/config" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 28 | ) |
| 29 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 30 | var ( |
| 31 | // Any C flags added by sanitizer which libTooling tools may not |
| 32 | // understand also need to be added to ClangLibToolingUnknownCflags in |
| 33 | // cc/config/clang.go |
Vishwath Mohan | f3918d3 | 2017-02-14 07:59:33 -0800 | [diff] [blame] | 34 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 35 | asanCflags = []string{"-fno-omit-frame-pointer"} |
| 36 | asanLdflags = []string{"-Wl,-u,__asan_preinit"} |
| 37 | asanLibs = []string{"libasan"} |
| 38 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 39 | cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso", |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 40 | "-fsanitize-blacklist=external/compiler-rt/lib/cfi/cfi_blacklist.txt"} |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 41 | cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi", |
Pirama Arumuga Nainar | bdb17f0 | 2017-08-28 21:50:17 -0700 | [diff] [blame] | 42 | "-Wl,-plugin-opt,O1"} |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 43 | cfiExportsMapPath = "build/soong/cc/config/cfi_exports.map" |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 44 | cfiStaticLibsMutex sync.Mutex |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 45 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 46 | intOverflowCflags = []string{"-fsanitize-blacklist=build/soong/cc/config/integer_overflow_blacklist.txt"} |
| 47 | minimalRuntimeFlags = []string{"-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer", "-fno-sanitize-recover=integer"} |
Dan Willemsen | cbceaab | 2016-10-13 16:44:07 -0700 | [diff] [blame] | 48 | ) |
| 49 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 50 | type sanitizerType int |
| 51 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 52 | func boolPtr(v bool) *bool { |
| 53 | if v { |
| 54 | return &v |
| 55 | } else { |
| 56 | return nil |
| 57 | } |
| 58 | } |
| 59 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 60 | const ( |
| 61 | asan sanitizerType = iota + 1 |
| 62 | tsan |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 63 | intOverflow |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 64 | cfi |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 65 | ) |
| 66 | |
| 67 | func (t sanitizerType) String() string { |
| 68 | switch t { |
| 69 | case asan: |
| 70 | return "asan" |
| 71 | case tsan: |
| 72 | return "tsan" |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 73 | case intOverflow: |
| 74 | return "intOverflow" |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 75 | case cfi: |
| 76 | return "cfi" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 77 | default: |
| 78 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 79 | } |
| 80 | } |
| 81 | |
| 82 | type SanitizeProperties struct { |
| 83 | // enable AddressSanitizer, ThreadSanitizer, or UndefinedBehaviorSanitizer |
| 84 | Sanitize struct { |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 85 | Never *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 86 | |
| 87 | // main sanitizers |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 88 | Address *bool `android:"arch_variant"` |
| 89 | Thread *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 90 | |
| 91 | // local sanitizers |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 92 | Undefined *bool `android:"arch_variant"` |
| 93 | All_undefined *bool `android:"arch_variant"` |
| 94 | Misc_undefined []string `android:"arch_variant"` |
| 95 | Coverage *bool `android:"arch_variant"` |
| 96 | Safestack *bool `android:"arch_variant"` |
| 97 | Cfi *bool `android:"arch_variant"` |
| 98 | Integer_overflow *bool `android:"arch_variant"` |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 99 | Scudo *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 100 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 101 | // Sanitizers to run in the diagnostic mode (as opposed to the release mode). |
| 102 | // Replaces abort() on error with a human-readable error message. |
| 103 | // Address and Thread sanitizers always run in diagnostic mode. |
| 104 | Diag struct { |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 105 | Undefined *bool `android:"arch_variant"` |
| 106 | Cfi *bool `android:"arch_variant"` |
| 107 | Integer_overflow *bool `android:"arch_variant"` |
| 108 | Misc_undefined []string `android:"arch_variant"` |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 109 | } |
| 110 | |
| 111 | // value to pass to -fsanitize-recover= |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 112 | Recover []string |
| 113 | |
| 114 | // value to pass to -fsanitize-blacklist |
| 115 | Blacklist *string |
| 116 | } `android:"arch_variant"` |
| 117 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 118 | SanitizerEnabled bool `blueprint:"mutated"` |
| 119 | SanitizeDep bool `blueprint:"mutated"` |
| 120 | MinimalRuntimeDep bool `blueprint:"mutated"` |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 121 | UbsanRuntimeDep bool `blueprint:"mutated"` |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 122 | InSanitizerDir bool `blueprint:"mutated"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 123 | } |
| 124 | |
| 125 | type sanitize struct { |
| 126 | Properties SanitizeProperties |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 127 | |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 128 | runtimeLibrary string |
| 129 | androidMkRuntimeLibrary string |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 130 | } |
| 131 | |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 132 | func init() { |
| 133 | android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider) |
| 134 | } |
| 135 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 136 | func (sanitize *sanitize) props() []interface{} { |
| 137 | return []interface{}{&sanitize.Properties} |
| 138 | } |
| 139 | |
| 140 | func (sanitize *sanitize) begin(ctx BaseModuleContext) { |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 141 | s := &sanitize.Properties.Sanitize |
| 142 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 143 | // Don't apply sanitizers to NDK code. |
Jeff Gaston | af3cc2d | 2017-09-27 17:01:44 -0700 | [diff] [blame] | 144 | if ctx.useSdk() { |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 145 | s.Never = BoolPtr(true) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 146 | } |
| 147 | |
| 148 | // Never always wins. |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 149 | if Bool(s.Never) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 150 | return |
| 151 | } |
| 152 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 153 | var globalSanitizers []string |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 154 | var globalSanitizersDiag []string |
| 155 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 156 | if ctx.clang() { |
| 157 | if ctx.Host() { |
Pirama Arumuga Nainar | 83d716c | 2018-06-26 14:01:40 -0700 | [diff] [blame^] | 158 | if !ctx.Windows() { |
| 159 | globalSanitizers = ctx.Config().SanitizeHost() |
| 160 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 161 | } else { |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 162 | arches := ctx.Config().SanitizeDeviceArch() |
Colin Cross | 23ae82a | 2016-11-02 14:34:39 -0700 | [diff] [blame] | 163 | if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) { |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 164 | globalSanitizers = ctx.Config().SanitizeDevice() |
| 165 | globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag() |
Colin Cross | 23ae82a | 2016-11-02 14:34:39 -0700 | [diff] [blame] | 166 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 167 | } |
| 168 | } |
| 169 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 170 | if len(globalSanitizers) > 0 { |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 171 | var found bool |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 172 | if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil { |
| 173 | s.All_undefined = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 174 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 175 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 176 | if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil { |
| 177 | s.Undefined = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 178 | } |
| 179 | |
Evgenii Stepanov | 774cb81 | 2016-12-28 15:52:54 -0800 | [diff] [blame] | 180 | if found, globalSanitizers = removeFromList("address", globalSanitizers); found { |
| 181 | if s.Address == nil { |
| 182 | s.Address = boolPtr(true) |
| 183 | } else if *s.Address == false { |
| 184 | // Coverage w/o address is an error. If globalSanitizers includes both, and the module |
| 185 | // disables address, then disable coverage as well. |
| 186 | _, globalSanitizers = removeFromList("coverage", globalSanitizers) |
| 187 | } |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 188 | } |
| 189 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 190 | if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil { |
| 191 | s.Thread = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 192 | } |
| 193 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 194 | if found, globalSanitizers = removeFromList("coverage", globalSanitizers); found && s.Coverage == nil { |
| 195 | s.Coverage = boolPtr(true) |
| 196 | } |
| 197 | |
| 198 | if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil { |
| 199 | s.Safestack = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 200 | } |
| 201 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 202 | if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil { |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 203 | if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) { |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 204 | s.Cfi = boolPtr(true) |
| 205 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 206 | } |
| 207 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 208 | // Global integer_overflow builds do not support static libraries. |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 209 | if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil { |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 210 | if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() { |
Ivan Lozano | 5f59553 | 2017-07-13 14:46:05 -0700 | [diff] [blame] | 211 | s.Integer_overflow = boolPtr(true) |
| 212 | } |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 213 | } |
| 214 | |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 215 | if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil { |
| 216 | s.Scudo = boolPtr(true) |
| 217 | } |
| 218 | |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 219 | if len(globalSanitizers) > 0 { |
| 220 | ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0]) |
| 221 | } |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 222 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 223 | // Global integer_overflow builds do not support static library diagnostics. |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 224 | if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found && |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 225 | s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() { |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 226 | s.Diag.Integer_overflow = boolPtr(true) |
| 227 | } |
| 228 | |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 229 | if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found && |
| 230 | s.Diag.Cfi == nil && Bool(s.Cfi) { |
| 231 | s.Diag.Cfi = boolPtr(true) |
| 232 | } |
| 233 | |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 234 | if len(globalSanitizersDiag) > 0 { |
| 235 | ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0]) |
| 236 | } |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 237 | } |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 238 | |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 239 | // Enable CFI for all components in the include paths |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 240 | if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) { |
Vishwath Mohan | 3af8ee0 | 2018-03-30 02:55:23 +0000 | [diff] [blame] | 241 | s.Cfi = boolPtr(true) |
| 242 | if inList("cfi", ctx.Config().SanitizeDeviceDiag()) { |
| 243 | s.Diag.Cfi = boolPtr(true) |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 244 | } |
| 245 | } |
| 246 | |
Evgenii Stepanov | a83fdac | 2017-01-31 18:37:30 -0800 | [diff] [blame] | 247 | // CFI needs gold linker, and mips toolchain does not have one. |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 248 | if !ctx.Config().EnableCFI() || ctx.Arch().ArchType == android.Mips || ctx.Arch().ArchType == android.Mips64 { |
Vishwath Mohan | 1b017a7 | 2017-01-19 13:54:55 -0800 | [diff] [blame] | 249 | s.Cfi = nil |
| 250 | s.Diag.Cfi = nil |
| 251 | } |
| 252 | |
Vishwath Mohan | 6d67e6e | 2017-02-07 20:31:41 -0800 | [diff] [blame] | 253 | // Also disable CFI for arm32 until b/35157333 is fixed. |
| 254 | if ctx.Arch().ArchType == android.Arm { |
| 255 | s.Cfi = nil |
| 256 | s.Diag.Cfi = nil |
| 257 | } |
| 258 | |
Vishwath Mohan | 8f4fdd8 | 2017-04-20 07:42:52 -0700 | [diff] [blame] | 259 | // Also disable CFI if ASAN is enabled. |
| 260 | if Bool(s.Address) { |
| 261 | s.Cfi = nil |
| 262 | s.Diag.Cfi = nil |
| 263 | } |
| 264 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 265 | // Disable sanitizers that depend on the UBSan runtime for host builds. |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 266 | if ctx.Host() { |
| 267 | s.Cfi = nil |
| 268 | s.Diag.Cfi = nil |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 269 | s.Misc_undefined = nil |
| 270 | s.Undefined = nil |
| 271 | s.All_undefined = nil |
| 272 | s.Integer_overflow = nil |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 273 | } |
| 274 | |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 275 | if ctx.staticBinary() { |
| 276 | s.Address = nil |
Colin Cross | 91169fe | 2016-08-11 15:54:20 -0700 | [diff] [blame] | 277 | s.Coverage = nil |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 278 | s.Thread = nil |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 279 | } |
| 280 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 281 | if Bool(s.All_undefined) { |
| 282 | s.Undefined = nil |
| 283 | } |
| 284 | |
Evgenii Stepanov | 0a8a0d0 | 2016-05-12 13:54:53 -0700 | [diff] [blame] | 285 | if !ctx.toolchain().Is64Bit() { |
| 286 | // TSAN and SafeStack are not supported on 32-bit architectures |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 287 | s.Thread = nil |
| 288 | s.Safestack = nil |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 289 | // TODO(ccross): error for compile_multilib = "32"? |
| 290 | } |
| 291 | |
Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 292 | if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) || |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 293 | Bool(s.Coverage) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 || |
| 294 | Bool(s.Scudo)) { |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 295 | sanitize.Properties.SanitizerEnabled = true |
| 296 | } |
| 297 | |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 298 | // Disable Scudo if ASan or TSan is enabled. |
| 299 | if Bool(s.Address) || Bool(s.Thread) { |
| 300 | s.Scudo = nil |
| 301 | } |
| 302 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 303 | if Bool(s.Coverage) { |
| 304 | if !Bool(s.Address) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 305 | ctx.ModuleErrorf(`Use of "coverage" also requires "address"`) |
| 306 | } |
| 307 | } |
| 308 | } |
| 309 | |
| 310 | func (sanitize *sanitize) deps(ctx BaseModuleContext, deps Deps) Deps { |
| 311 | if !sanitize.Properties.SanitizerEnabled { // || c.static() { |
| 312 | return deps |
| 313 | } |
| 314 | |
| 315 | if ctx.Device() { |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 316 | if Bool(sanitize.Properties.Sanitize.Address) { |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 317 | deps.StaticLibs = append(deps.StaticLibs, asanLibs...) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 318 | } |
| 319 | } |
| 320 | |
| 321 | return deps |
| 322 | } |
| 323 | |
| 324 | func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags { |
Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 325 | minimalRuntimeLib := config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(ctx.toolchain()) + ".a" |
| 326 | minimalRuntimePath := "${config.ClangAsanLibDir}/" + minimalRuntimeLib |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 327 | |
| 328 | if ctx.Device() && sanitize.Properties.MinimalRuntimeDep { |
| 329 | flags.LdFlags = append(flags.LdFlags, minimalRuntimePath) |
Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 330 | flags.LdFlags = append(flags.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 331 | } |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 332 | if !sanitize.Properties.SanitizerEnabled && !sanitize.Properties.UbsanRuntimeDep { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 333 | return flags |
| 334 | } |
| 335 | |
| 336 | if !ctx.clang() { |
| 337 | ctx.ModuleErrorf("Use of sanitizers requires clang") |
| 338 | } |
| 339 | |
| 340 | var sanitizers []string |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 341 | var diagSanitizers []string |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 342 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 343 | if Bool(sanitize.Properties.Sanitize.All_undefined) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 344 | sanitizers = append(sanitizers, "undefined") |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 345 | } else { |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 346 | if Bool(sanitize.Properties.Sanitize.Undefined) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 347 | sanitizers = append(sanitizers, |
| 348 | "bool", |
| 349 | "integer-divide-by-zero", |
| 350 | "return", |
| 351 | "returns-nonnull-attribute", |
| 352 | "shift-exponent", |
| 353 | "unreachable", |
| 354 | "vla-bound", |
| 355 | // TODO(danalbert): The following checks currently have compiler performance issues. |
| 356 | //"alignment", |
| 357 | //"bounds", |
| 358 | //"enum", |
| 359 | //"float-cast-overflow", |
| 360 | //"float-divide-by-zero", |
| 361 | //"nonnull-attribute", |
| 362 | //"null", |
| 363 | //"shift-base", |
| 364 | //"signed-integer-overflow", |
| 365 | // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on. |
| 366 | // https://llvm.org/PR19302 |
| 367 | // http://reviews.llvm.org/D6974 |
| 368 | // "object-size", |
| 369 | ) |
| 370 | } |
| 371 | sanitizers = append(sanitizers, sanitize.Properties.Sanitize.Misc_undefined...) |
| 372 | } |
| 373 | |
Ivan Lozano | 651275b | 2017-06-13 10:24:34 -0700 | [diff] [blame] | 374 | if Bool(sanitize.Properties.Sanitize.Diag.Undefined) { |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 375 | diagSanitizers = append(diagSanitizers, "undefined") |
| 376 | } |
| 377 | |
Ivan Lozano | 651275b | 2017-06-13 10:24:34 -0700 | [diff] [blame] | 378 | diagSanitizers = append(diagSanitizers, sanitize.Properties.Sanitize.Diag.Misc_undefined...) |
| 379 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 380 | if Bool(sanitize.Properties.Sanitize.Address) { |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 381 | if ctx.Arch().ArchType == android.Arm { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 382 | // Frame pointer based unwinder in ASan requires ARM frame setup. |
| 383 | // TODO: put in flags? |
| 384 | flags.RequiredInstructionSet = "arm" |
| 385 | } |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 386 | flags.CFlags = append(flags.CFlags, asanCflags...) |
| 387 | flags.LdFlags = append(flags.LdFlags, asanLdflags...) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 388 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 389 | if ctx.Host() { |
| 390 | // -nodefaultlibs (provided with libc++) prevents the driver from linking |
| 391 | // libraries needed with -fsanitize=address. http://b/18650275 (WAI) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 392 | flags.LdFlags = append(flags.LdFlags, "-Wl,--no-as-needed") |
| 393 | } else { |
| 394 | flags.CFlags = append(flags.CFlags, "-mllvm", "-asan-globals=0") |
| 395 | flags.DynamicLinker = "/system/bin/linker_asan" |
| 396 | if flags.Toolchain.Is64Bit() { |
| 397 | flags.DynamicLinker += "64" |
| 398 | } |
| 399 | } |
| 400 | sanitizers = append(sanitizers, "address") |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 401 | diagSanitizers = append(diagSanitizers, "address") |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 402 | } |
| 403 | |
Yabin Cui | 6be405e | 2017-10-19 15:52:11 -0700 | [diff] [blame] | 404 | if Bool(sanitize.Properties.Sanitize.Thread) { |
| 405 | sanitizers = append(sanitizers, "thread") |
| 406 | } |
| 407 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 408 | if Bool(sanitize.Properties.Sanitize.Coverage) { |
Zach Riggle | 06bbd89 | 2017-08-21 17:12:32 -0400 | [diff] [blame] | 409 | flags.CFlags = append(flags.CFlags, "-fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp") |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 410 | } |
| 411 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 412 | if Bool(sanitize.Properties.Sanitize.Safestack) { |
Evgenii Stepanov | 0a8a0d0 | 2016-05-12 13:54:53 -0700 | [diff] [blame] | 413 | sanitizers = append(sanitizers, "safe-stack") |
| 414 | } |
| 415 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 416 | if Bool(sanitize.Properties.Sanitize.Cfi) { |
Evgenii Stepanov | 7ebf9fa | 2017-01-20 14:13:06 -0800 | [diff] [blame] | 417 | if ctx.Arch().ArchType == android.Arm { |
| 418 | // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up |
| 419 | // to do this on a function basis, so force Thumb on the entire module. |
| 420 | flags.RequiredInstructionSet = "thumb" |
| 421 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 422 | sanitizers = append(sanitizers, "cfi") |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 423 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 424 | flags.CFlags = append(flags.CFlags, cfiCflags...) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 425 | // Only append the default visibility flag if -fvisibility has not already been set |
| 426 | // to hidden. |
| 427 | if !inList("-fvisibility=hidden", flags.CFlags) { |
| 428 | flags.CFlags = append(flags.CFlags, "-fvisibility=default") |
| 429 | } |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 430 | flags.LdFlags = append(flags.LdFlags, cfiLdflags...) |
Zhizhou Yang | 51be632 | 2018-02-08 18:32:11 -0800 | [diff] [blame] | 431 | flags.ArGoldPlugin = true |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 432 | if Bool(sanitize.Properties.Sanitize.Diag.Cfi) { |
| 433 | diagSanitizers = append(diagSanitizers, "cfi") |
| 434 | } |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 435 | |
| 436 | if ctx.staticBinary() { |
| 437 | _, flags.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.CFlags) |
| 438 | _, flags.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.LdFlags) |
| 439 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 440 | } |
| 441 | |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 442 | if Bool(sanitize.Properties.Sanitize.Integer_overflow) { |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 443 | sanitizers = append(sanitizers, "unsigned-integer-overflow") |
| 444 | sanitizers = append(sanitizers, "signed-integer-overflow") |
| 445 | flags.CFlags = append(flags.CFlags, intOverflowCflags...) |
| 446 | if Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) { |
| 447 | diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow") |
| 448 | diagSanitizers = append(diagSanitizers, "signed-integer-overflow") |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 449 | } |
| 450 | } |
| 451 | |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 452 | if Bool(sanitize.Properties.Sanitize.Scudo) { |
| 453 | sanitizers = append(sanitizers, "scudo") |
| 454 | } |
| 455 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 456 | if len(sanitizers) > 0 { |
| 457 | sanitizeArg := "-fsanitize=" + strings.Join(sanitizers, ",") |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 458 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 459 | flags.CFlags = append(flags.CFlags, sanitizeArg) |
| 460 | if ctx.Host() { |
| 461 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-recover=all") |
| 462 | flags.LdFlags = append(flags.LdFlags, sanitizeArg) |
Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 463 | // Host sanitizers only link symbols in the final executable, so |
| 464 | // there will always be undefined symbols in intermediate libraries. |
| 465 | _, flags.LdFlags = removeFromList("-Wl,--no-undefined", flags.LdFlags) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 466 | } else { |
Colin Cross | 263abbd | 2016-07-15 13:10:48 -0700 | [diff] [blame] | 467 | flags.CFlags = append(flags.CFlags, "-fsanitize-trap=all", "-ftrap-function=abort") |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 468 | |
| 469 | if enableMinimalRuntime(sanitize) { |
| 470 | flags.CFlags = append(flags.CFlags, strings.Join(minimalRuntimeFlags, " ")) |
| 471 | flags.libFlags = append([]string{minimalRuntimePath}, flags.libFlags...) |
Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 472 | flags.LdFlags = append(flags.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 473 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 474 | } |
| 475 | } |
| 476 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 477 | if len(diagSanitizers) > 0 { |
Ivan Lozano | b7d0f52 | 2018-01-20 01:44:38 +0000 | [diff] [blame] | 478 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-trap="+strings.Join(diagSanitizers, ",")) |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 479 | } |
| 480 | // FIXME: enable RTTI if diag + (cfi or vptr) |
| 481 | |
Andreas Gampe | 9707116 | 2017-05-08 13:15:23 -0700 | [diff] [blame] | 482 | if sanitize.Properties.Sanitize.Recover != nil { |
| 483 | flags.CFlags = append(flags.CFlags, "-fsanitize-recover="+ |
| 484 | strings.Join(sanitize.Properties.Sanitize.Recover, ",")) |
| 485 | } |
| 486 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 487 | // Link a runtime library if needed. |
| 488 | runtimeLibrary := "" |
| 489 | if Bool(sanitize.Properties.Sanitize.Address) { |
| 490 | runtimeLibrary = config.AddressSanitizerRuntimeLibrary(ctx.toolchain()) |
Yabin Cui | 6be405e | 2017-10-19 15:52:11 -0700 | [diff] [blame] | 491 | } else if Bool(sanitize.Properties.Sanitize.Thread) { |
| 492 | runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(ctx.toolchain()) |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 493 | } else if Bool(sanitize.Properties.Sanitize.Scudo) { |
| 494 | runtimeLibrary = config.ScudoRuntimeLibrary(ctx.toolchain()) |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 495 | } else if len(diagSanitizers) > 0 || sanitize.Properties.UbsanRuntimeDep { |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 496 | runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(ctx.toolchain()) |
| 497 | } |
| 498 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 499 | if runtimeLibrary != "" { |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 500 | runtimeLibraryPath := "${config.ClangAsanLibDir}/" + runtimeLibrary |
| 501 | if !ctx.static() { |
| 502 | runtimeLibraryPath = runtimeLibraryPath + ctx.toolchain().ShlibSuffix() |
| 503 | } else { |
| 504 | runtimeLibraryPath = runtimeLibraryPath + ".a" |
| 505 | } |
| 506 | |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 507 | // ASan runtime library must be the first in the link order. |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 508 | flags.libFlags = append([]string{runtimeLibraryPath}, flags.libFlags...) |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 509 | sanitize.runtimeLibrary = runtimeLibrary |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 510 | |
| 511 | // When linking against VNDK, use the vendor variant of the runtime lib |
| 512 | sanitize.androidMkRuntimeLibrary = sanitize.runtimeLibrary |
Jeff Gaston | af3cc2d | 2017-09-27 17:01:44 -0700 | [diff] [blame] | 513 | if ctx.useVndk() { |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 514 | sanitize.androidMkRuntimeLibrary = sanitize.runtimeLibrary + vendorSuffix |
| 515 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 516 | } |
| 517 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 518 | blacklist := android.OptionalPathForModuleSrc(ctx, sanitize.Properties.Sanitize.Blacklist) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 519 | if blacklist.Valid() { |
| 520 | flags.CFlags = append(flags.CFlags, "-fsanitize-blacklist="+blacklist.String()) |
| 521 | flags.CFlagsDeps = append(flags.CFlagsDeps, blacklist.Path()) |
| 522 | } |
| 523 | |
| 524 | return flags |
| 525 | } |
| 526 | |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 527 | func (sanitize *sanitize) AndroidMk(ctx AndroidMkContext, ret *android.AndroidMkData) { |
Colin Cross | 27a4b05 | 2017-08-10 16:32:23 -0700 | [diff] [blame] | 528 | ret.Extra = append(ret.Extra, func(w io.Writer, outputFile android.Path) { |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 529 | if sanitize.androidMkRuntimeLibrary != "" { |
| 530 | fmt.Fprintln(w, "LOCAL_SHARED_LIBRARIES += "+sanitize.androidMkRuntimeLibrary) |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 531 | } |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 532 | }) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 533 | |
| 534 | // Add a suffix for CFI-enabled static libraries to allow surfacing both to make without a |
| 535 | // name conflict. |
| 536 | if ret.Class == "STATIC_LIBRARIES" && Bool(sanitize.Properties.Sanitize.Cfi) { |
| 537 | ret.SubName += ".cfi" |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 538 | } |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 539 | } |
| 540 | |
Vishwath Mohan | 1dd8839 | 2017-03-29 22:00:18 -0700 | [diff] [blame] | 541 | func (sanitize *sanitize) inSanitizerDir() bool { |
| 542 | return sanitize.Properties.InSanitizerDir |
Colin Cross | 30d5f51 | 2016-05-03 18:02:42 -0700 | [diff] [blame] | 543 | } |
| 544 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 545 | func (sanitize *sanitize) getSanitizerBoolPtr(t sanitizerType) *bool { |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 546 | switch t { |
| 547 | case asan: |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 548 | return sanitize.Properties.Sanitize.Address |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 549 | case tsan: |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 550 | return sanitize.Properties.Sanitize.Thread |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 551 | case intOverflow: |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 552 | return sanitize.Properties.Sanitize.Integer_overflow |
| 553 | case cfi: |
| 554 | return sanitize.Properties.Sanitize.Cfi |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 555 | default: |
| 556 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 557 | } |
| 558 | } |
| 559 | |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 560 | func (sanitize *sanitize) isUnsanitizedVariant() bool { |
| 561 | return !sanitize.isSanitizerEnabled(asan) && |
| 562 | !sanitize.isSanitizerEnabled(tsan) && |
| 563 | !sanitize.isSanitizerEnabled(cfi) |
| 564 | } |
| 565 | |
Jayant Chowdhary | b7e08ca | 2018-05-10 15:29:24 -0700 | [diff] [blame] | 566 | func (sanitize *sanitize) isVariantOnProductionDevice() bool { |
| 567 | return !sanitize.isSanitizerEnabled(asan) && |
| 568 | !sanitize.isSanitizerEnabled(tsan) |
| 569 | } |
| 570 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 571 | func (sanitize *sanitize) SetSanitizer(t sanitizerType, b bool) { |
| 572 | switch t { |
| 573 | case asan: |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 574 | sanitize.Properties.Sanitize.Address = boolPtr(b) |
Colin Cross | 91169fe | 2016-08-11 15:54:20 -0700 | [diff] [blame] | 575 | if !b { |
| 576 | sanitize.Properties.Sanitize.Coverage = nil |
| 577 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 578 | case tsan: |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 579 | sanitize.Properties.Sanitize.Thread = boolPtr(b) |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 580 | case intOverflow: |
| 581 | sanitize.Properties.Sanitize.Integer_overflow = boolPtr(b) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 582 | case cfi: |
| 583 | sanitize.Properties.Sanitize.Cfi = boolPtr(b) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 584 | default: |
| 585 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 586 | } |
| 587 | if b { |
| 588 | sanitize.Properties.SanitizerEnabled = true |
| 589 | } |
| 590 | } |
| 591 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 592 | // Check if the sanitizer is explicitly disabled (as opposed to nil by |
| 593 | // virtue of not being set). |
| 594 | func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t sanitizerType) bool { |
| 595 | if sanitize == nil { |
| 596 | return false |
| 597 | } |
| 598 | |
| 599 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) |
| 600 | return sanitizerVal != nil && *sanitizerVal == false |
| 601 | } |
| 602 | |
| 603 | // There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled) |
| 604 | // because enabling a sanitizer either directly (via the blueprint) or |
| 605 | // indirectly (via a mutator) sets the bool ptr to true, and you can't |
| 606 | // distinguish between the cases. It isn't needed though - both cases can be |
| 607 | // treated identically. |
| 608 | func (sanitize *sanitize) isSanitizerEnabled(t sanitizerType) bool { |
| 609 | if sanitize == nil { |
| 610 | return false |
| 611 | } |
| 612 | |
| 613 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) |
| 614 | return sanitizerVal != nil && *sanitizerVal == true |
| 615 | } |
| 616 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 617 | func isSanitizableDependencyTag(tag blueprint.DependencyTag) bool { |
| 618 | t, ok := tag.(dependencyTag) |
| 619 | return ok && t.library || t == reuseObjTag |
| 620 | } |
| 621 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 622 | // Propagate asan requirements down from binaries |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 623 | func sanitizerDepsMutator(t sanitizerType) func(android.TopDownMutatorContext) { |
| 624 | return func(mctx android.TopDownMutatorContext) { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 625 | if c, ok := mctx.Module().(*Module); ok && c.sanitize.isSanitizerEnabled(t) { |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 626 | mctx.WalkDeps(func(child, parent android.Module) bool { |
| 627 | if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) { |
| 628 | return false |
| 629 | } |
| 630 | if d, ok := child.(*Module); ok && d.sanitize != nil && |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 631 | !Bool(d.sanitize.Properties.Sanitize.Never) && |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 632 | !d.sanitize.isSanitizerExplicitlyDisabled(t) { |
| 633 | if (t == cfi && d.static()) || t != cfi { |
| 634 | d.sanitize.Properties.SanitizeDep = true |
| 635 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 636 | } |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 637 | return true |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 638 | }) |
| 639 | } |
| 640 | } |
| 641 | } |
| 642 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 643 | // Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies. |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 644 | func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) { |
| 645 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { |
| 646 | mctx.WalkDeps(func(child, parent android.Module) bool { |
| 647 | if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) { |
| 648 | return false |
| 649 | } |
| 650 | if d, ok := child.(*Module); ok && d.static() && d.sanitize != nil { |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 651 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 652 | if enableMinimalRuntime(d.sanitize) { |
| 653 | // If a static dependency is built with the minimal runtime, |
| 654 | // make sure we include the ubsan minimal runtime. |
| 655 | c.sanitize.Properties.MinimalRuntimeDep = true |
| 656 | } else if Bool(d.sanitize.Properties.Sanitize.Diag.Integer_overflow) || |
| 657 | len(d.sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0 { |
| 658 | // If a static dependency runs with full ubsan diagnostics, |
| 659 | // make sure we include the ubsan runtime. |
| 660 | c.sanitize.Properties.UbsanRuntimeDep = true |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 661 | } |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 662 | } |
| 663 | return true |
| 664 | }) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 665 | } |
| 666 | } |
| 667 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 668 | // Create sanitized variants for modules that need them |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 669 | func sanitizerMutator(t sanitizerType) func(android.BottomUpMutatorContext) { |
| 670 | return func(mctx android.BottomUpMutatorContext) { |
Vishwath Mohan | e615345 | 2017-08-11 00:52:44 +0000 | [diff] [blame] | 671 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 672 | if c.isDependencyRoot() && c.sanitize.isSanitizerEnabled(t) { |
Colin Cross | 30d5f51 | 2016-05-03 18:02:42 -0700 | [diff] [blame] | 673 | modules := mctx.CreateVariations(t.String()) |
| 674 | modules[0].(*Module).sanitize.SetSanitizer(t, true) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 675 | } else if c.sanitize.isSanitizerEnabled(t) || c.sanitize.Properties.SanitizeDep { |
| 676 | // Save original sanitizer status before we assign values to variant |
| 677 | // 0 as that overwrites the original. |
| 678 | isSanitizerEnabled := c.sanitize.isSanitizerEnabled(t) |
| 679 | |
Colin Cross | b0f2895 | 2016-09-19 16:46:53 -0700 | [diff] [blame] | 680 | modules := mctx.CreateVariations("", t.String()) |
| 681 | modules[0].(*Module).sanitize.SetSanitizer(t, false) |
| 682 | modules[1].(*Module).sanitize.SetSanitizer(t, true) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 683 | |
Colin Cross | b0f2895 | 2016-09-19 16:46:53 -0700 | [diff] [blame] | 684 | modules[0].(*Module).sanitize.Properties.SanitizeDep = false |
| 685 | modules[1].(*Module).sanitize.Properties.SanitizeDep = false |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 686 | |
| 687 | // We don't need both variants active for anything but CFI-enabled |
| 688 | // target static libraries, so suppress the appropriate variant in |
| 689 | // all other cases. |
| 690 | if t == cfi { |
| 691 | if c.static() { |
| 692 | if !mctx.Device() { |
| 693 | if isSanitizerEnabled { |
| 694 | modules[0].(*Module).Properties.PreventInstall = true |
| 695 | modules[0].(*Module).Properties.HideFromMake = true |
| 696 | } else { |
| 697 | modules[1].(*Module).Properties.PreventInstall = true |
| 698 | modules[1].(*Module).Properties.HideFromMake = true |
| 699 | } |
| 700 | } else { |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 701 | cfiStaticLibs := cfiStaticLibs(mctx.Config()) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 702 | |
| 703 | cfiStaticLibsMutex.Lock() |
| 704 | *cfiStaticLibs = append(*cfiStaticLibs, c.Name()) |
| 705 | cfiStaticLibsMutex.Unlock() |
| 706 | } |
| 707 | } else { |
| 708 | modules[0].(*Module).Properties.PreventInstall = true |
| 709 | modules[0].(*Module).Properties.HideFromMake = true |
| 710 | } |
| 711 | } else if t == asan { |
| 712 | if mctx.Device() { |
| 713 | // CFI and ASAN are currently mutually exclusive so disable |
| 714 | // CFI if this is an ASAN variant. |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 715 | modules[1].(*Module).sanitize.Properties.InSanitizerDir = true |
| 716 | modules[1].(*Module).sanitize.SetSanitizer(cfi, false) |
| 717 | } |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 718 | if isSanitizerEnabled { |
| 719 | modules[0].(*Module).Properties.PreventInstall = true |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 720 | modules[0].(*Module).Properties.HideFromMake = true |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 721 | } else { |
| 722 | modules[1].(*Module).Properties.PreventInstall = true |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 723 | modules[1].(*Module).Properties.HideFromMake = true |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 724 | } |
| 725 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 726 | } |
| 727 | c.sanitize.Properties.SanitizeDep = false |
| 728 | } |
| 729 | } |
| 730 | } |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 731 | |
| 732 | func cfiStaticLibs(config android.Config) *[]string { |
| 733 | return config.Once("cfiStaticLibs", func() interface{} { |
| 734 | return &[]string{} |
| 735 | }).(*[]string) |
| 736 | } |
| 737 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 738 | func enableMinimalRuntime(sanitize *sanitize) bool { |
| 739 | if !Bool(sanitize.Properties.Sanitize.Address) && |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 740 | !Bool(sanitize.Properties.Sanitize.Scudo) && |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 741 | (Bool(sanitize.Properties.Sanitize.Integer_overflow) || |
| 742 | len(sanitize.Properties.Sanitize.Misc_undefined) > 0) && |
| 743 | !(Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) || |
| 744 | Bool(sanitize.Properties.Sanitize.Diag.Cfi) || |
| 745 | len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0) { |
| 746 | return true |
| 747 | } |
| 748 | return false |
| 749 | } |
| 750 | |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 751 | func cfiMakeVarsProvider(ctx android.MakeVarsContext) { |
| 752 | cfiStaticLibs := cfiStaticLibs(ctx.Config()) |
Jeff Gaston | 7276539 | 2017-11-28 16:37:53 -0800 | [diff] [blame] | 753 | sort.Strings(*cfiStaticLibs) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 754 | ctx.Strict("SOONG_CFI_STATIC_LIBRARIES", strings.Join(*cfiStaticLibs, " ")) |
| 755 | } |