blob: 66e7ffb951e5102ae9493d6055d2db3819e784d6 [file] [log] [blame]
Jiyong Park25fc6a92018-11-18 18:02:45 +09001// Copyright 2018 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
Jiyong Park25fc6a92018-11-18 18:02:45 +090018 "io/ioutil"
19 "os"
Jooyung Han39edb6c2019-11-06 16:53:07 +090020 "path"
Jaewoong Jung22f7d182019-07-16 18:25:41 -070021 "reflect"
Jooyung Han31c470b2019-10-18 16:26:59 +090022 "sort"
Jiyong Park25fc6a92018-11-18 18:02:45 +090023 "strings"
24 "testing"
Jiyong Parkda6eb592018-12-19 17:12:36 +090025
26 "github.com/google/blueprint/proptools"
27
28 "android/soong/android"
29 "android/soong/cc"
Jiyong Parkb2742fd2019-02-11 11:38:15 +090030 "android/soong/java"
Jiyong Park25fc6a92018-11-18 18:02:45 +090031)
32
Jaewoong Jung14f5ff62019-06-18 13:09:13 -070033var buildDir string
34
Jooyung Hand3639552019-08-09 12:57:43 +090035// names returns name list from white space separated string
36func names(s string) (ns []string) {
37 for _, n := range strings.Split(s, " ") {
38 if len(n) > 0 {
39 ns = append(ns, n)
40 }
41 }
42 return
43}
44
Jooyung Han344d5432019-08-23 11:17:39 +090045func testApexError(t *testing.T, pattern, bp string, handlers ...testCustomizer) {
46 t.Helper()
47 ctx, config := testApexContext(t, bp, handlers...)
Jooyung Han5c998b92019-06-27 11:30:33 +090048 _, errs := ctx.ParseFileList(".", []string{"Android.bp"})
49 if len(errs) > 0 {
50 android.FailIfNoMatchingErrors(t, pattern, errs)
51 return
52 }
53 _, errs = ctx.PrepareBuildActions(config)
54 if len(errs) > 0 {
55 android.FailIfNoMatchingErrors(t, pattern, errs)
56 return
57 }
58
59 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
60}
61
Jooyung Han344d5432019-08-23 11:17:39 +090062func testApex(t *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) {
63 t.Helper()
64 ctx, config := testApexContext(t, bp, handlers...)
Jooyung Han5c998b92019-06-27 11:30:33 +090065 _, errs := ctx.ParseFileList(".", []string{"Android.bp"})
66 android.FailIfErrored(t, errs)
67 _, errs = ctx.PrepareBuildActions(config)
68 android.FailIfErrored(t, errs)
Jaewoong Jung22f7d182019-07-16 18:25:41 -070069 return ctx, config
Jooyung Han5c998b92019-06-27 11:30:33 +090070}
71
Jooyung Han344d5432019-08-23 11:17:39 +090072type testCustomizer func(fs map[string][]byte, config android.Config)
73
74func withFiles(files map[string][]byte) testCustomizer {
75 return func(fs map[string][]byte, config android.Config) {
76 for k, v := range files {
77 fs[k] = v
78 }
79 }
80}
81
82func withTargets(targets map[android.OsType][]android.Target) testCustomizer {
83 return func(fs map[string][]byte, config android.Config) {
84 for k, v := range targets {
85 config.Targets[k] = v
86 }
87 }
88}
89
Jooyung Han31c470b2019-10-18 16:26:59 +090090func withBinder32bit(fs map[string][]byte, config android.Config) {
91 config.TestProductVariables.Binder32bit = proptools.BoolPtr(true)
92}
93
Jooyung Han344d5432019-08-23 11:17:39 +090094func testApexContext(t *testing.T, bp string, handlers ...testCustomizer) (*android.TestContext, android.Config) {
Jaewoong Jungc1001ec2019-06-25 11:20:53 -070095 config := android.TestArchConfig(buildDir, nil)
96 config.TestProductVariables.DeviceVndkVersion = proptools.StringPtr("current")
97 config.TestProductVariables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
98 config.TestProductVariables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
99 config.TestProductVariables.Platform_sdk_codename = proptools.StringPtr("Q")
100 config.TestProductVariables.Platform_sdk_final = proptools.BoolPtr(false)
Jooyung Han344d5432019-08-23 11:17:39 +0900101 config.TestProductVariables.Platform_vndk_version = proptools.StringPtr("VER")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900102
103 ctx := android.NewTestArchContext()
Jiyong Parkd1063c12019-07-17 20:08:41 +0900104 ctx.RegisterModuleType("apex", android.ModuleFactoryAdaptor(BundleFactory))
Alex Light0851b882019-02-07 13:20:53 -0800105 ctx.RegisterModuleType("apex_test", android.ModuleFactoryAdaptor(testApexBundleFactory))
Jooyung Han344d5432019-08-23 11:17:39 +0900106 ctx.RegisterModuleType("apex_vndk", android.ModuleFactoryAdaptor(vndkApexBundleFactory))
Jiyong Parkd1063c12019-07-17 20:08:41 +0900107 ctx.RegisterModuleType("apex_key", android.ModuleFactoryAdaptor(ApexKeyFactory))
Jiyong Park30ca9372019-02-07 16:27:23 +0900108 ctx.RegisterModuleType("apex_defaults", android.ModuleFactoryAdaptor(defaultsFactory))
Jaewoong Jung939ebd52019-03-26 15:07:36 -0700109 ctx.RegisterModuleType("prebuilt_apex", android.ModuleFactoryAdaptor(PrebuiltFactory))
Jiyong Park25fc6a92018-11-18 18:02:45 +0900110
111 ctx.RegisterModuleType("cc_library", android.ModuleFactoryAdaptor(cc.LibraryFactory))
112 ctx.RegisterModuleType("cc_library_shared", android.ModuleFactoryAdaptor(cc.LibrarySharedFactory))
Jiyong Park7e636d02019-01-28 16:16:54 +0900113 ctx.RegisterModuleType("cc_library_headers", android.ModuleFactoryAdaptor(cc.LibraryHeaderFactory))
Jooyung Han344d5432019-08-23 11:17:39 +0900114 ctx.RegisterModuleType("cc_prebuilt_library_shared", android.ModuleFactoryAdaptor(cc.PrebuiltSharedLibraryFactory))
115 ctx.RegisterModuleType("cc_prebuilt_library_static", android.ModuleFactoryAdaptor(cc.PrebuiltStaticLibraryFactory))
Jiyong Park16e91a02018-12-20 18:18:08 +0900116 ctx.RegisterModuleType("cc_binary", android.ModuleFactoryAdaptor(cc.BinaryFactory))
Jiyong Park25fc6a92018-11-18 18:02:45 +0900117 ctx.RegisterModuleType("cc_object", android.ModuleFactoryAdaptor(cc.ObjectFactory))
Jooyung Han18020ea2019-11-13 10:50:48 +0900118 ctx.RegisterModuleType("cc_defaults", android.ModuleFactoryAdaptor(func() android.Module {
119 return cc.DefaultsFactory()
120 }))
Roland Levillain630846d2019-06-26 12:48:34 +0100121 ctx.RegisterModuleType("cc_test", android.ModuleFactoryAdaptor(cc.TestFactory))
Jiyong Parkda6eb592018-12-19 17:12:36 +0900122 ctx.RegisterModuleType("llndk_library", android.ModuleFactoryAdaptor(cc.LlndkLibraryFactory))
Jooyung Han344d5432019-08-23 11:17:39 +0900123 ctx.RegisterModuleType("vndk_prebuilt_shared", android.ModuleFactoryAdaptor(cc.VndkPrebuiltSharedFactory))
Jooyung Han39edb6c2019-11-06 16:53:07 +0900124 ctx.RegisterModuleType("vndk_libraries_txt", android.ModuleFactoryAdaptor(cc.VndkLibrariesTxtFactory))
Jiyong Park25fc6a92018-11-18 18:02:45 +0900125 ctx.RegisterModuleType("toolchain_library", android.ModuleFactoryAdaptor(cc.ToolchainLibraryFactory))
Jiyong Park7c2ee712018-12-07 00:42:25 +0900126 ctx.RegisterModuleType("prebuilt_etc", android.ModuleFactoryAdaptor(android.PrebuiltEtcFactory))
Jiyong Park04480cf2019-02-06 00:16:29 +0900127 ctx.RegisterModuleType("sh_binary", android.ModuleFactoryAdaptor(android.ShBinaryFactory))
Jiyong Parkb2742fd2019-02-11 11:38:15 +0900128 ctx.RegisterModuleType("android_app_certificate", android.ModuleFactoryAdaptor(java.AndroidAppCertificateFactory))
Jiyong Park809bb722019-02-13 21:33:49 +0900129 ctx.RegisterModuleType("filegroup", android.ModuleFactoryAdaptor(android.FileGroupFactory))
Jiyong Park7f7766d2019-07-25 22:02:35 +0900130 ctx.RegisterModuleType("java_library", android.ModuleFactoryAdaptor(java.LibraryFactory))
Jiyong Park9e6c2422019-08-09 20:39:45 +0900131 ctx.RegisterModuleType("java_import", android.ModuleFactoryAdaptor(java.ImportFactory))
Dario Frenicde2a032019-10-27 00:29:22 +0100132 ctx.RegisterModuleType("java_system_modules", android.ModuleFactoryAdaptor(java.SystemModulesFactory))
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900133 ctx.RegisterModuleType("android_app", android.ModuleFactoryAdaptor(java.AndroidAppFactory))
Dario Frenicde2a032019-10-27 00:29:22 +0100134 ctx.RegisterModuleType("android_app_import", android.ModuleFactoryAdaptor(java.AndroidAppImportFactory))
Jiyong Park7f7766d2019-07-25 22:02:35 +0900135
Jooyung Han344d5432019-08-23 11:17:39 +0900136 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Jaewoong Jung939ebd52019-03-26 15:07:36 -0700137 ctx.PreArchMutators(func(ctx android.RegisterMutatorsContext) {
138 ctx.BottomUp("prebuilts", android.PrebuiltMutator).Parallel()
139 })
Jiyong Park25fc6a92018-11-18 18:02:45 +0900140 ctx.PreDepsMutators(func(ctx android.RegisterMutatorsContext) {
Colin Cross7228ecd2019-11-18 16:00:16 -0800141 ctx.BottomUp("image", android.ImageMutator).Parallel()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900142 ctx.BottomUp("link", cc.LinkageMutator).Parallel()
Jiyong Parkda6eb592018-12-19 17:12:36 +0900143 ctx.BottomUp("vndk", cc.VndkMutator).Parallel()
Roland Levillain9b5fde92019-06-28 15:41:19 +0100144 ctx.BottomUp("test_per_src", cc.TestPerSrcMutator).Parallel()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900145 ctx.BottomUp("version", cc.VersionMutator).Parallel()
146 ctx.BottomUp("begin", cc.BeginMutator).Parallel()
Jooyung Han344d5432019-08-23 11:17:39 +0900147 })
Jooyung Han31c470b2019-10-18 16:26:59 +0900148 ctx.PreDepsMutators(RegisterPreDepsMutators)
149 ctx.PostDepsMutators(RegisterPostDepsMutators)
Jooyung Han344d5432019-08-23 11:17:39 +0900150 ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) {
Jooyung Han344d5432019-08-23 11:17:39 +0900151 ctx.TopDown("prebuilt_select", android.PrebuiltSelectModuleMutator).Parallel()
152 ctx.BottomUp("prebuilt_postdeps", android.PrebuiltPostDepsMutator).Parallel()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900153 })
154
155 ctx.Register()
156
157 bp = bp + `
158 toolchain_library {
159 name: "libcompiler_rt-extras",
160 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900161 vendor_available: true,
162 recovery_available: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900163 }
164
165 toolchain_library {
166 name: "libatomic",
167 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900168 vendor_available: true,
169 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900170 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900171 }
172
173 toolchain_library {
174 name: "libgcc",
175 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900176 vendor_available: true,
177 recovery_available: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900178 }
179
180 toolchain_library {
Yi Kongacee27c2019-03-29 20:05:14 -0700181 name: "libgcc_stripped",
182 src: "",
183 vendor_available: true,
184 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900185 native_bridge_supported: true,
Yi Kongacee27c2019-03-29 20:05:14 -0700186 }
187
188 toolchain_library {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900189 name: "libclang_rt.builtins-aarch64-android",
190 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900191 vendor_available: true,
192 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900193 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900194 }
195
196 toolchain_library {
197 name: "libclang_rt.builtins-arm-android",
198 src: "",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900199 vendor_available: true,
200 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900201 native_bridge_supported: true,
202 }
203
204 toolchain_library {
205 name: "libclang_rt.builtins-x86_64-android",
206 src: "",
207 vendor_available: true,
208 recovery_available: true,
209 native_bridge_supported: true,
210 }
211
212 toolchain_library {
213 name: "libclang_rt.builtins-i686-android",
214 src: "",
215 vendor_available: true,
216 recovery_available: true,
217 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900218 }
219
220 cc_object {
221 name: "crtbegin_so",
222 stl: "none",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900223 vendor_available: true,
224 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900225 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900226 }
227
228 cc_object {
229 name: "crtend_so",
230 stl: "none",
Jiyong Parkda6eb592018-12-19 17:12:36 +0900231 vendor_available: true,
232 recovery_available: true,
Jooyung Han344d5432019-08-23 11:17:39 +0900233 native_bridge_supported: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900234 }
235
Alex Light3d673592019-01-18 14:37:31 -0800236 cc_object {
237 name: "crtbegin_static",
238 stl: "none",
239 }
240
241 cc_object {
242 name: "crtend_android",
243 stl: "none",
244 }
245
Jiyong Parkda6eb592018-12-19 17:12:36 +0900246 llndk_library {
247 name: "libc",
248 symbol_file: "",
Jooyung Han344d5432019-08-23 11:17:39 +0900249 native_bridge_supported: true,
Jiyong Parkda6eb592018-12-19 17:12:36 +0900250 }
251
252 llndk_library {
253 name: "libm",
254 symbol_file: "",
Jooyung Han344d5432019-08-23 11:17:39 +0900255 native_bridge_supported: true,
Jiyong Parkda6eb592018-12-19 17:12:36 +0900256 }
257
258 llndk_library {
259 name: "libdl",
260 symbol_file: "",
Jooyung Han344d5432019-08-23 11:17:39 +0900261 native_bridge_supported: true,
Jiyong Parkda6eb592018-12-19 17:12:36 +0900262 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900263 `
Dario Frenicde2a032019-10-27 00:29:22 +0100264 bp = bp + java.GatherRequiredDepsForTest()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900265
Jooyung Han344d5432019-08-23 11:17:39 +0900266 fs := map[string][]byte{
Dario Frenicde2a032019-10-27 00:29:22 +0100267 "Android.bp": []byte(bp),
268 "a.java": nil,
269 "PrebuiltAppFoo.apk": nil,
270 "PrebuiltAppFooPriv.apk": nil,
271 "build/make/target/product/security": nil,
272 "apex_manifest.json": nil,
273 "AndroidManifest.xml": nil,
274 "system/sepolicy/apex/myapex-file_contexts": nil,
Jiyong Parkb2742fd2019-02-11 11:38:15 +0900275 "system/sepolicy/apex/myapex_keytest-file_contexts": nil,
276 "system/sepolicy/apex/otherapex-file_contexts": nil,
Jooyung Han5c998b92019-06-27 11:30:33 +0900277 "system/sepolicy/apex/commonapex-file_contexts": nil,
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900278 "mylib.cpp": nil,
279 "mylib_common.cpp": nil,
280 "mytest.cpp": nil,
281 "mytest1.cpp": nil,
282 "mytest2.cpp": nil,
283 "mytest3.cpp": nil,
284 "myprebuilt": nil,
285 "my_include": nil,
286 "foo/bar/MyClass.java": nil,
287 "prebuilt.jar": nil,
288 "vendor/foo/devkeys/test.x509.pem": nil,
289 "vendor/foo/devkeys/test.pk8": nil,
290 "testkey.x509.pem": nil,
291 "testkey.pk8": nil,
292 "testkey.override.x509.pem": nil,
293 "testkey.override.pk8": nil,
294 "vendor/foo/devkeys/testkey.avbpubkey": nil,
295 "vendor/foo/devkeys/testkey.pem": nil,
296 "NOTICE": nil,
297 "custom_notice": nil,
298 "testkey2.avbpubkey": nil,
299 "testkey2.pem": nil,
300 "myapex-arm64.apex": nil,
301 "myapex-arm.apex": nil,
302 "frameworks/base/api/current.txt": nil,
Dario Frenicde2a032019-10-27 00:29:22 +0100303 "framework/aidl/a.aidl": nil,
Sundong Ahne1f05aa2019-08-27 13:55:42 +0900304 "build/make/core/proguard.flags": nil,
305 "build/make/core/proguard_basic_keeps.flags": nil,
Jooyung Han39edb6c2019-11-06 16:53:07 +0900306 "dummy.txt": nil,
Jooyung Han344d5432019-08-23 11:17:39 +0900307 }
308
309 for _, handler := range handlers {
310 handler(fs, config)
311 }
312
313 ctx.MockFileSystem(fs)
Jiyong Park25fc6a92018-11-18 18:02:45 +0900314
Jooyung Han5c998b92019-06-27 11:30:33 +0900315 return ctx, config
Jiyong Park25fc6a92018-11-18 18:02:45 +0900316}
317
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700318func setUp() {
319 var err error
320 buildDir, err = ioutil.TempDir("", "soong_apex_test")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900321 if err != nil {
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700322 panic(err)
Jiyong Park25fc6a92018-11-18 18:02:45 +0900323 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900324}
325
Jaewoong Jungc1001ec2019-06-25 11:20:53 -0700326func tearDown() {
Jiyong Park25fc6a92018-11-18 18:02:45 +0900327 os.RemoveAll(buildDir)
328}
329
330// ensure that 'result' contains 'expected'
331func ensureContains(t *testing.T, result string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900332 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900333 if !strings.Contains(result, expected) {
334 t.Errorf("%q is not found in %q", expected, result)
335 }
336}
337
338// ensures that 'result' does not contain 'notExpected'
339func ensureNotContains(t *testing.T, result string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900340 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900341 if strings.Contains(result, notExpected) {
342 t.Errorf("%q is found in %q", notExpected, result)
343 }
344}
345
346func ensureListContains(t *testing.T, result []string, expected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900347 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900348 if !android.InList(expected, result) {
349 t.Errorf("%q is not found in %v", expected, result)
350 }
351}
352
353func ensureListNotContains(t *testing.T, result []string, notExpected string) {
Jooyung Han5c998b92019-06-27 11:30:33 +0900354 t.Helper()
Jiyong Park25fc6a92018-11-18 18:02:45 +0900355 if android.InList(notExpected, result) {
356 t.Errorf("%q is found in %v", notExpected, result)
357 }
358}
359
Jooyung Hane1633032019-08-01 17:41:43 +0900360func ensureListEmpty(t *testing.T, result []string) {
361 t.Helper()
362 if len(result) > 0 {
363 t.Errorf("%q is expected to be empty", result)
364 }
365}
366
Jiyong Park25fc6a92018-11-18 18:02:45 +0900367// Minimal test
368func TestBasicApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700369 ctx, _ := testApex(t, `
Jiyong Park30ca9372019-02-07 16:27:23 +0900370 apex_defaults {
371 name: "myapex-defaults",
Jiyong Park809bb722019-02-13 21:33:49 +0900372 manifest: ":myapex.manifest",
373 androidManifest: ":myapex.androidmanifest",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900374 key: "myapex.key",
375 native_shared_libs: ["mylib"],
Alex Light3d673592019-01-18 14:37:31 -0800376 multilib: {
377 both: {
378 binaries: ["foo",],
379 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900380 },
Jiyong Park9e6c2422019-08-09 20:39:45 +0900381 java_libs: ["myjar", "myprebuiltjar"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900382 }
383
Jiyong Park30ca9372019-02-07 16:27:23 +0900384 apex {
385 name: "myapex",
386 defaults: ["myapex-defaults"],
387 }
388
Jiyong Park25fc6a92018-11-18 18:02:45 +0900389 apex_key {
390 name: "myapex.key",
391 public_key: "testkey.avbpubkey",
392 private_key: "testkey.pem",
393 }
394
Jiyong Park809bb722019-02-13 21:33:49 +0900395 filegroup {
396 name: "myapex.manifest",
397 srcs: ["apex_manifest.json"],
398 }
399
400 filegroup {
401 name: "myapex.androidmanifest",
402 srcs: ["AndroidManifest.xml"],
403 }
404
Jiyong Park25fc6a92018-11-18 18:02:45 +0900405 cc_library {
406 name: "mylib",
407 srcs: ["mylib.cpp"],
408 shared_libs: ["mylib2"],
409 system_shared_libs: [],
410 stl: "none",
411 }
412
Alex Light3d673592019-01-18 14:37:31 -0800413 cc_binary {
414 name: "foo",
415 srcs: ["mylib.cpp"],
416 compile_multilib: "both",
417 multilib: {
418 lib32: {
419 suffix: "32",
420 },
421 lib64: {
422 suffix: "64",
423 },
424 },
425 symlinks: ["foo_link_"],
426 symlink_preferred_arch: true,
427 system_shared_libs: [],
428 static_executable: true,
429 stl: "none",
430 }
431
Jiyong Park25fc6a92018-11-18 18:02:45 +0900432 cc_library {
433 name: "mylib2",
434 srcs: ["mylib.cpp"],
435 system_shared_libs: [],
436 stl: "none",
Jiyong Park52818fc2019-03-18 12:01:38 +0900437 notice: "custom_notice",
Jiyong Park25fc6a92018-11-18 18:02:45 +0900438 }
Jiyong Park7f7766d2019-07-25 22:02:35 +0900439
440 java_library {
441 name: "myjar",
442 srcs: ["foo/bar/MyClass.java"],
443 sdk_version: "none",
444 system_modules: "none",
445 compile_dex: true,
446 static_libs: ["myotherjar"],
447 }
448
449 java_library {
450 name: "myotherjar",
451 srcs: ["foo/bar/MyClass.java"],
452 sdk_version: "none",
453 system_modules: "none",
454 compile_dex: true,
455 }
Jiyong Park9e6c2422019-08-09 20:39:45 +0900456
457 java_import {
458 name: "myprebuiltjar",
459 jars: ["prebuilt.jar"],
460 installable: true,
461 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900462 `)
463
Sundong Ahnabb64432019-10-22 13:58:29 +0900464 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900465
466 optFlags := apexRule.Args["opt_flags"]
467 ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700468 // Ensure that the NOTICE output is being packaged as an asset.
Sundong Ahnabb64432019-10-22 13:58:29 +0900469 ensureContains(t, optFlags, "--assets_dir "+buildDir+"/.intermediates/myapex/android_common_myapex_image/NOTICE")
Jiyong Park42cca6c2019-04-01 11:15:50 +0900470
Jiyong Park25fc6a92018-11-18 18:02:45 +0900471 copyCmds := apexRule.Args["copy_commands"]
472
473 // Ensure that main rule creates an output
474 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
475
476 // Ensure that apex variant is created for the direct dep
Jiyong Parkda6eb592018-12-19 17:12:36 +0900477 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared_myapex")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900478 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_myapex")
Jiyong Park9e6c2422019-08-09 20:39:45 +0900479 ensureListContains(t, ctx.ModuleVariantsForTests("myprebuiltjar"), "android_common_myapex")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900480
481 // Ensure that apex variant is created for the indirect dep
Jiyong Parkda6eb592018-12-19 17:12:36 +0900482 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared_myapex")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900483 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_myapex")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900484
485 // Ensure that both direct and indirect deps are copied into apex
Alex Light5098a612018-11-29 17:12:15 -0800486 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
487 ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900488 ensureContains(t, copyCmds, "image.apex/javalib/myjar.jar")
Jiyong Park9e6c2422019-08-09 20:39:45 +0900489 ensureContains(t, copyCmds, "image.apex/javalib/myprebuiltjar.jar")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900490 // .. but not for java libs
491 ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
Logan Chien3aeedc92018-12-26 15:32:21 +0800492
Jiyong Park7f7766d2019-07-25 22:02:35 +0900493 // Ensure that the platform variant ends with _core_shared or _common
Logan Chien3aeedc92018-12-26 15:32:21 +0800494 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared")
495 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared")
Jiyong Park7f7766d2019-07-25 22:02:35 +0900496 ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
497 ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
Jiyong Park9e6c2422019-08-09 20:39:45 +0900498 ensureListContains(t, ctx.ModuleVariantsForTests("myprebuiltjar"), "android_common")
Alex Light3d673592019-01-18 14:37:31 -0800499
500 // Ensure that all symlinks are present.
501 found_foo_link_64 := false
502 found_foo := false
503 for _, cmd := range strings.Split(copyCmds, " && ") {
504 if strings.HasPrefix(cmd, "ln -s foo64") {
505 if strings.HasSuffix(cmd, "bin/foo") {
506 found_foo = true
507 } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
508 found_foo_link_64 = true
509 }
510 }
511 }
512 good := found_foo && found_foo_link_64
513 if !good {
514 t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
515 }
Jiyong Park52818fc2019-03-18 12:01:38 +0900516
Sundong Ahnabb64432019-10-22 13:58:29 +0900517 mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
Jaewoong Jung5b425e22019-06-17 17:40:56 -0700518 noticeInputs := mergeNoticesRule.Inputs.Strings()
Jaewoong Jung14f5ff62019-06-18 13:09:13 -0700519 if len(noticeInputs) != 2 {
520 t.Errorf("number of input notice files: expected = 2, actual = %q", len(noticeInputs))
Jiyong Park52818fc2019-03-18 12:01:38 +0900521 }
522 ensureListContains(t, noticeInputs, "NOTICE")
523 ensureListContains(t, noticeInputs, "custom_notice")
Alex Light5098a612018-11-29 17:12:15 -0800524}
525
Jooyung Han01a3ee22019-11-02 02:52:25 +0900526func TestApexManifest(t *testing.T) {
527 ctx, _ := testApex(t, `
528 apex {
529 name: "myapex",
530 key: "myapex.key",
531 }
532
533 apex_key {
534 name: "myapex.key",
535 public_key: "testkey.avbpubkey",
536 private_key: "testkey.pem",
537 }
538 `)
539
540 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
541 module.Output("apex_manifest.pb")
542 module.Output("apex_manifest.json")
543 module.Output("apex_manifest_full.json")
544}
545
Alex Light5098a612018-11-29 17:12:15 -0800546func TestBasicZipApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700547 ctx, _ := testApex(t, `
Alex Light5098a612018-11-29 17:12:15 -0800548 apex {
549 name: "myapex",
550 key: "myapex.key",
551 payload_type: "zip",
552 native_shared_libs: ["mylib"],
553 }
554
555 apex_key {
556 name: "myapex.key",
557 public_key: "testkey.avbpubkey",
558 private_key: "testkey.pem",
559 }
560
561 cc_library {
562 name: "mylib",
563 srcs: ["mylib.cpp"],
564 shared_libs: ["mylib2"],
565 system_shared_libs: [],
566 stl: "none",
567 }
568
569 cc_library {
570 name: "mylib2",
571 srcs: ["mylib.cpp"],
572 system_shared_libs: [],
573 stl: "none",
574 }
575 `)
576
Sundong Ahnabb64432019-10-22 13:58:29 +0900577 zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
Alex Light5098a612018-11-29 17:12:15 -0800578 copyCmds := zipApexRule.Args["copy_commands"]
579
580 // Ensure that main rule creates an output
581 ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
582
583 // Ensure that APEX variant is created for the direct dep
Jiyong Parkda6eb592018-12-19 17:12:36 +0900584 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared_myapex")
Alex Light5098a612018-11-29 17:12:15 -0800585
586 // Ensure that APEX variant is created for the indirect dep
Jiyong Parkda6eb592018-12-19 17:12:36 +0900587 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared_myapex")
Alex Light5098a612018-11-29 17:12:15 -0800588
589 // Ensure that both direct and indirect deps are copied into apex
590 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
591 ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900592}
593
594func TestApexWithStubs(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700595 ctx, _ := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900596 apex {
597 name: "myapex",
598 key: "myapex.key",
599 native_shared_libs: ["mylib", "mylib3"],
600 }
601
602 apex_key {
603 name: "myapex.key",
604 public_key: "testkey.avbpubkey",
605 private_key: "testkey.pem",
606 }
607
608 cc_library {
609 name: "mylib",
610 srcs: ["mylib.cpp"],
611 shared_libs: ["mylib2", "mylib3"],
612 system_shared_libs: [],
613 stl: "none",
614 }
615
616 cc_library {
617 name: "mylib2",
618 srcs: ["mylib.cpp"],
Jiyong Park64379952018-12-13 18:37:29 +0900619 cflags: ["-include mylib.h"],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900620 system_shared_libs: [],
621 stl: "none",
622 stubs: {
623 versions: ["1", "2", "3"],
624 },
625 }
626
627 cc_library {
628 name: "mylib3",
Jiyong Park28d395a2018-12-07 22:42:47 +0900629 srcs: ["mylib.cpp"],
630 shared_libs: ["mylib4"],
631 system_shared_libs: [],
Jiyong Park25fc6a92018-11-18 18:02:45 +0900632 stl: "none",
633 stubs: {
634 versions: ["10", "11", "12"],
635 },
636 }
Jiyong Park28d395a2018-12-07 22:42:47 +0900637
638 cc_library {
639 name: "mylib4",
640 srcs: ["mylib.cpp"],
641 system_shared_libs: [],
642 stl: "none",
643 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900644 `)
645
Sundong Ahnabb64432019-10-22 13:58:29 +0900646 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900647 copyCmds := apexRule.Args["copy_commands"]
648
649 // Ensure that direct non-stubs dep is always included
Alex Light5098a612018-11-29 17:12:15 -0800650 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900651
652 // Ensure that indirect stubs dep is not included
Alex Light5098a612018-11-29 17:12:15 -0800653 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900654
655 // Ensure that direct stubs dep is included
Alex Light5098a612018-11-29 17:12:15 -0800656 ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900657
Jiyong Parkda6eb592018-12-19 17:12:36 +0900658 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_shared_myapex").Rule("ld").Args["libFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900659
660 // Ensure that mylib is linking with the latest version of stubs for mylib2
Jiyong Parkda6eb592018-12-19 17:12:36 +0900661 ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_core_shared_3_myapex/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900662 // ... and not linking to the non-stub (impl) variant of mylib2
Jiyong Parkda6eb592018-12-19 17:12:36 +0900663 ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_core_shared_myapex/mylib2.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900664
665 // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
Jiyong Parkda6eb592018-12-19 17:12:36 +0900666 ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_core_shared_myapex/mylib3.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900667 // .. and not linking to the stubs variant of mylib3
Jiyong Parkda6eb592018-12-19 17:12:36 +0900668 ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_core_shared_12_myapex/mylib3.so")
Jiyong Park64379952018-12-13 18:37:29 +0900669
670 // Ensure that stubs libs are built without -include flags
Jiyong Parkda6eb592018-12-19 17:12:36 +0900671 mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_core_static_myapex").Rule("cc").Args["cFlags"]
Jiyong Park64379952018-12-13 18:37:29 +0900672 ensureNotContains(t, mylib2Cflags, "-include ")
Jiyong Park3fd0baf2018-12-07 16:25:39 +0900673
674 // Ensure that genstub is invoked with --apex
Jiyong Parkda6eb592018-12-19 17:12:36 +0900675 ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_core_static_3_myapex").Rule("genStubSrc").Args["flags"])
Jiyong Park25fc6a92018-11-18 18:02:45 +0900676}
677
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900678func TestApexWithExplicitStubsDependency(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700679 ctx, _ := testApex(t, `
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900680 apex {
681 name: "myapex",
682 key: "myapex.key",
683 native_shared_libs: ["mylib"],
684 }
685
686 apex_key {
687 name: "myapex.key",
688 public_key: "testkey.avbpubkey",
689 private_key: "testkey.pem",
690 }
691
692 cc_library {
693 name: "mylib",
694 srcs: ["mylib.cpp"],
695 shared_libs: ["libfoo#10"],
696 system_shared_libs: [],
697 stl: "none",
698 }
699
700 cc_library {
701 name: "libfoo",
702 srcs: ["mylib.cpp"],
703 shared_libs: ["libbar"],
704 system_shared_libs: [],
705 stl: "none",
706 stubs: {
707 versions: ["10", "20", "30"],
708 },
709 }
710
711 cc_library {
712 name: "libbar",
713 srcs: ["mylib.cpp"],
714 system_shared_libs: [],
715 stl: "none",
716 }
717
718 `)
719
Sundong Ahnabb64432019-10-22 13:58:29 +0900720 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900721 copyCmds := apexRule.Args["copy_commands"]
722
723 // Ensure that direct non-stubs dep is always included
724 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
725
726 // Ensure that indirect stubs dep is not included
727 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
728
729 // Ensure that dependency of stubs is not included
730 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
731
Jiyong Parkda6eb592018-12-19 17:12:36 +0900732 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_shared_myapex").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900733
734 // Ensure that mylib is linking with version 10 of libfoo
Jiyong Parkda6eb592018-12-19 17:12:36 +0900735 ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_core_shared_10_myapex/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900736 // ... and not linking to the non-stub (impl) variant of libfoo
Jiyong Parkda6eb592018-12-19 17:12:36 +0900737 ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_core_shared_myapex/libfoo.so")
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900738
Jiyong Parkda6eb592018-12-19 17:12:36 +0900739 libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_core_shared_10_myapex").Rule("ld").Args["libFlags"]
Jiyong Park0ddfcd12018-12-11 01:35:25 +0900740
741 // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
742 ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
743}
744
Jooyung Hand3639552019-08-09 12:57:43 +0900745func TestApexWithRuntimeLibsDependency(t *testing.T) {
746 /*
747 myapex
748 |
749 v (runtime_libs)
750 mylib ------+------> libfoo [provides stub]
751 |
752 `------> libbar
753 */
754 ctx, _ := testApex(t, `
755 apex {
756 name: "myapex",
757 key: "myapex.key",
758 native_shared_libs: ["mylib"],
759 }
760
761 apex_key {
762 name: "myapex.key",
763 public_key: "testkey.avbpubkey",
764 private_key: "testkey.pem",
765 }
766
767 cc_library {
768 name: "mylib",
769 srcs: ["mylib.cpp"],
770 runtime_libs: ["libfoo", "libbar"],
771 system_shared_libs: [],
772 stl: "none",
773 }
774
775 cc_library {
776 name: "libfoo",
777 srcs: ["mylib.cpp"],
778 system_shared_libs: [],
779 stl: "none",
780 stubs: {
781 versions: ["10", "20", "30"],
782 },
783 }
784
785 cc_library {
786 name: "libbar",
787 srcs: ["mylib.cpp"],
788 system_shared_libs: [],
789 stl: "none",
790 }
791
792 `)
793
Sundong Ahnabb64432019-10-22 13:58:29 +0900794 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Hand3639552019-08-09 12:57:43 +0900795 copyCmds := apexRule.Args["copy_commands"]
796
797 // Ensure that direct non-stubs dep is always included
798 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
799
800 // Ensure that indirect stubs dep is not included
801 ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
802
803 // Ensure that runtime_libs dep in included
804 ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
805
Sundong Ahnabb64432019-10-22 13:58:29 +0900806 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +0900807 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
808 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
Jooyung Hand3639552019-08-09 12:57:43 +0900809
810}
811
Jooyung Han9c80bae2019-08-20 17:30:57 +0900812func TestApexDependencyToLLNDK(t *testing.T) {
813 ctx, _ := testApex(t, `
814 apex {
815 name: "myapex",
816 key: "myapex.key",
817 use_vendor: true,
818 native_shared_libs: ["mylib"],
819 }
820
821 apex_key {
822 name: "myapex.key",
823 public_key: "testkey.avbpubkey",
824 private_key: "testkey.pem",
825 }
826
827 cc_library {
828 name: "mylib",
829 srcs: ["mylib.cpp"],
830 vendor_available: true,
831 shared_libs: ["libbar"],
832 system_shared_libs: [],
833 stl: "none",
834 }
835
836 cc_library {
837 name: "libbar",
838 srcs: ["mylib.cpp"],
839 system_shared_libs: [],
840 stl: "none",
841 }
842
843 llndk_library {
844 name: "libbar",
845 symbol_file: "",
846 }
Jooyung Handc782442019-11-01 03:14:38 +0900847 `, func(fs map[string][]byte, config android.Config) {
848 setUseVendorWhitelistForTest(config, []string{"myapex"})
849 })
Jooyung Han9c80bae2019-08-20 17:30:57 +0900850
Sundong Ahnabb64432019-10-22 13:58:29 +0900851 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jooyung Han9c80bae2019-08-20 17:30:57 +0900852 copyCmds := apexRule.Args["copy_commands"]
853
854 // Ensure that LLNDK dep is not included
855 ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
856
Sundong Ahnabb64432019-10-22 13:58:29 +0900857 apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +0900858 ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
Jooyung Han9c80bae2019-08-20 17:30:57 +0900859
860 // Ensure that LLNDK dep is required
Jooyung Hand15aa1f2019-09-27 00:38:03 +0900861 ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
Jooyung Han9c80bae2019-08-20 17:30:57 +0900862
863}
864
Jiyong Park25fc6a92018-11-18 18:02:45 +0900865func TestApexWithSystemLibsStubs(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700866 ctx, _ := testApex(t, `
Jiyong Park25fc6a92018-11-18 18:02:45 +0900867 apex {
868 name: "myapex",
869 key: "myapex.key",
870 native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
871 }
872
873 apex_key {
874 name: "myapex.key",
875 public_key: "testkey.avbpubkey",
876 private_key: "testkey.pem",
877 }
878
879 cc_library {
880 name: "mylib",
881 srcs: ["mylib.cpp"],
882 shared_libs: ["libdl#27"],
883 stl: "none",
884 }
885
886 cc_library_shared {
887 name: "mylib_shared",
888 srcs: ["mylib.cpp"],
889 shared_libs: ["libdl#27"],
890 stl: "none",
891 }
892
893 cc_library {
894 name: "libc",
Yi Konge7fe9912019-06-02 00:53:50 -0700895 no_libcrt: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900896 nocrt: true,
897 system_shared_libs: [],
898 stl: "none",
899 stubs: {
900 versions: ["27", "28", "29"],
901 },
902 }
903
904 cc_library {
905 name: "libm",
Yi Konge7fe9912019-06-02 00:53:50 -0700906 no_libcrt: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900907 nocrt: true,
908 system_shared_libs: [],
909 stl: "none",
910 stubs: {
911 versions: ["27", "28", "29"],
912 },
913 }
914
915 cc_library {
916 name: "libdl",
Yi Konge7fe9912019-06-02 00:53:50 -0700917 no_libcrt: true,
Jiyong Park25fc6a92018-11-18 18:02:45 +0900918 nocrt: true,
919 system_shared_libs: [],
920 stl: "none",
921 stubs: {
922 versions: ["27", "28", "29"],
923 },
924 }
Jiyong Parkb0788572018-12-20 22:10:17 +0900925
926 cc_library {
927 name: "libBootstrap",
928 srcs: ["mylib.cpp"],
929 stl: "none",
930 bootstrap: true,
931 }
Jiyong Park25fc6a92018-11-18 18:02:45 +0900932 `)
933
Sundong Ahnabb64432019-10-22 13:58:29 +0900934 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900935 copyCmds := apexRule.Args["copy_commands"]
936
937 // Ensure that mylib, libm, libdl are included.
Alex Light5098a612018-11-29 17:12:15 -0800938 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
Jiyong Parkb0788572018-12-20 22:10:17 +0900939 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
940 ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900941
942 // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
Jiyong Parkb0788572018-12-20 22:10:17 +0900943 ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900944
Jiyong Parkda6eb592018-12-19 17:12:36 +0900945 mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_shared_myapex").Rule("ld").Args["libFlags"]
946 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_static_myapex").Rule("cc").Args["cFlags"]
947 mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_core_shared_myapex").Rule("cc").Args["cFlags"]
Jiyong Park25fc6a92018-11-18 18:02:45 +0900948
949 // For dependency to libc
950 // Ensure that mylib is linking with the latest version of stubs
Jiyong Parkda6eb592018-12-19 17:12:36 +0900951 ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_core_shared_29_myapex/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900952 // ... and not linking to the non-stub (impl) variant
Jiyong Parkda6eb592018-12-19 17:12:36 +0900953 ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_core_shared_myapex/libc.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900954 // ... Cflags from stub is correctly exported to mylib
955 ensureContains(t, mylibCFlags, "__LIBC_API__=29")
956 ensureContains(t, mylibSharedCFlags, "__LIBC_API__=29")
957
958 // For dependency to libm
959 // Ensure that mylib is linking with the non-stub (impl) variant
Jiyong Parkda6eb592018-12-19 17:12:36 +0900960 ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_core_shared_myapex/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900961 // ... and not linking to the stub variant
Jiyong Parkda6eb592018-12-19 17:12:36 +0900962 ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_core_shared_29_myapex/libm.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900963 // ... and is not compiling with the stub
964 ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
965 ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
966
967 // For dependency to libdl
968 // Ensure that mylib is linking with the specified version of stubs
Jiyong Parkda6eb592018-12-19 17:12:36 +0900969 ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_core_shared_27_myapex/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900970 // ... and not linking to the other versions of stubs
Jiyong Parkda6eb592018-12-19 17:12:36 +0900971 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_core_shared_28_myapex/libdl.so")
972 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_core_shared_29_myapex/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900973 // ... and not linking to the non-stub (impl) variant
Jiyong Parkda6eb592018-12-19 17:12:36 +0900974 ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_core_shared_myapex/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900975 // ... Cflags from stub is correctly exported to mylib
976 ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
977 ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
Jiyong Parkb0788572018-12-20 22:10:17 +0900978
979 // Ensure that libBootstrap is depending on the platform variant of bionic libs
980 libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_core_shared").Rule("ld").Args["libFlags"]
981 ensureContains(t, libFlags, "libc/android_arm64_armv8-a_core_shared/libc.so")
982 ensureContains(t, libFlags, "libm/android_arm64_armv8-a_core_shared/libm.so")
983 ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_core_shared/libdl.so")
Jiyong Park25fc6a92018-11-18 18:02:45 +0900984}
Jiyong Park7c2ee712018-12-07 00:42:25 +0900985
986func TestFilesInSubDir(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -0700987 ctx, _ := testApex(t, `
Jiyong Park7c2ee712018-12-07 00:42:25 +0900988 apex {
989 name: "myapex",
990 key: "myapex.key",
Jiyong Parkb7c24df2019-02-01 12:03:59 +0900991 native_shared_libs: ["mylib"],
992 binaries: ["mybin"],
Jiyong Park7c2ee712018-12-07 00:42:25 +0900993 prebuilts: ["myetc"],
Jiyong Parkb7c24df2019-02-01 12:03:59 +0900994 compile_multilib: "both",
Jiyong Park7c2ee712018-12-07 00:42:25 +0900995 }
996
997 apex_key {
998 name: "myapex.key",
999 public_key: "testkey.avbpubkey",
1000 private_key: "testkey.pem",
1001 }
1002
1003 prebuilt_etc {
1004 name: "myetc",
1005 src: "myprebuilt",
1006 sub_dir: "foo/bar",
1007 }
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001008
1009 cc_library {
1010 name: "mylib",
1011 srcs: ["mylib.cpp"],
1012 relative_install_path: "foo/bar",
1013 system_shared_libs: [],
1014 stl: "none",
1015 }
1016
1017 cc_binary {
1018 name: "mybin",
1019 srcs: ["mylib.cpp"],
1020 relative_install_path: "foo/bar",
1021 system_shared_libs: [],
1022 static_executable: true,
1023 stl: "none",
1024 }
Jiyong Park7c2ee712018-12-07 00:42:25 +09001025 `)
1026
Sundong Ahnabb64432019-10-22 13:58:29 +09001027 generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
Jiyong Park7c2ee712018-12-07 00:42:25 +09001028 dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
1029
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001030 // Ensure that the subdirectories are all listed
Jiyong Park7c2ee712018-12-07 00:42:25 +09001031 ensureListContains(t, dirs, "etc")
1032 ensureListContains(t, dirs, "etc/foo")
1033 ensureListContains(t, dirs, "etc/foo/bar")
Jiyong Parkb7c24df2019-02-01 12:03:59 +09001034 ensureListContains(t, dirs, "lib64")
1035 ensureListContains(t, dirs, "lib64/foo")
1036 ensureListContains(t, dirs, "lib64/foo/bar")
1037 ensureListContains(t, dirs, "lib")
1038 ensureListContains(t, dirs, "lib/foo")
1039 ensureListContains(t, dirs, "lib/foo/bar")
1040
Jiyong Parkbd13e442019-03-15 18:10:35 +09001041 ensureListContains(t, dirs, "bin")
1042 ensureListContains(t, dirs, "bin/foo")
1043 ensureListContains(t, dirs, "bin/foo/bar")
Jiyong Park7c2ee712018-12-07 00:42:25 +09001044}
Jiyong Parkda6eb592018-12-19 17:12:36 +09001045
1046func TestUseVendor(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001047 ctx, _ := testApex(t, `
Jiyong Parkda6eb592018-12-19 17:12:36 +09001048 apex {
1049 name: "myapex",
1050 key: "myapex.key",
1051 native_shared_libs: ["mylib"],
1052 use_vendor: true,
1053 }
1054
1055 apex_key {
1056 name: "myapex.key",
1057 public_key: "testkey.avbpubkey",
1058 private_key: "testkey.pem",
1059 }
1060
1061 cc_library {
1062 name: "mylib",
1063 srcs: ["mylib.cpp"],
1064 shared_libs: ["mylib2"],
1065 system_shared_libs: [],
1066 vendor_available: true,
1067 stl: "none",
1068 }
1069
1070 cc_library {
1071 name: "mylib2",
1072 srcs: ["mylib.cpp"],
1073 system_shared_libs: [],
1074 vendor_available: true,
1075 stl: "none",
1076 }
Jooyung Handc782442019-11-01 03:14:38 +09001077 `, func(fs map[string][]byte, config android.Config) {
1078 setUseVendorWhitelistForTest(config, []string{"myapex"})
1079 })
Jiyong Parkda6eb592018-12-19 17:12:36 +09001080
1081 inputsList := []string{}
Sundong Ahnabb64432019-10-22 13:58:29 +09001082 for _, i := range ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().BuildParamsForTests() {
Jiyong Parkda6eb592018-12-19 17:12:36 +09001083 for _, implicit := range i.Implicits {
1084 inputsList = append(inputsList, implicit.String())
1085 }
1086 }
1087 inputsString := strings.Join(inputsList, " ")
1088
1089 // ensure that the apex includes vendor variants of the direct and indirect deps
Inseob Kim64c43952019-08-26 16:52:35 +09001090 ensureContains(t, inputsString, "android_arm64_armv8-a_vendor.VER_shared_myapex/mylib.so")
1091 ensureContains(t, inputsString, "android_arm64_armv8-a_vendor.VER_shared_myapex/mylib2.so")
Jiyong Parkda6eb592018-12-19 17:12:36 +09001092
1093 // ensure that the apex does not include core variants
1094 ensureNotContains(t, inputsString, "android_arm64_armv8-a_core_shared_myapex/mylib.so")
1095 ensureNotContains(t, inputsString, "android_arm64_armv8-a_core_shared_myapex/mylib2.so")
1096}
Jiyong Park16e91a02018-12-20 18:18:08 +09001097
Jooyung Handc782442019-11-01 03:14:38 +09001098func TestUseVendorRestriction(t *testing.T) {
1099 testApexError(t, `module "myapex" .*: use_vendor: not allowed`, `
1100 apex {
1101 name: "myapex",
1102 key: "myapex.key",
1103 use_vendor: true,
1104 }
1105 apex_key {
1106 name: "myapex.key",
1107 public_key: "testkey.avbpubkey",
1108 private_key: "testkey.pem",
1109 }
1110 `, func(fs map[string][]byte, config android.Config) {
1111 setUseVendorWhitelistForTest(config, []string{""})
1112 })
1113 // no error with whitelist
1114 testApex(t, `
1115 apex {
1116 name: "myapex",
1117 key: "myapex.key",
1118 use_vendor: true,
1119 }
1120 apex_key {
1121 name: "myapex.key",
1122 public_key: "testkey.avbpubkey",
1123 private_key: "testkey.pem",
1124 }
1125 `, func(fs map[string][]byte, config android.Config) {
1126 setUseVendorWhitelistForTest(config, []string{"myapex"})
1127 })
1128}
1129
Jooyung Han5c998b92019-06-27 11:30:33 +09001130func TestUseVendorFailsIfNotVendorAvailable(t *testing.T) {
1131 testApexError(t, `dependency "mylib" of "myapex" missing variant:\n.*image:vendor`, `
1132 apex {
1133 name: "myapex",
1134 key: "myapex.key",
1135 native_shared_libs: ["mylib"],
1136 use_vendor: true,
1137 }
1138
1139 apex_key {
1140 name: "myapex.key",
1141 public_key: "testkey.avbpubkey",
1142 private_key: "testkey.pem",
1143 }
1144
1145 cc_library {
1146 name: "mylib",
1147 srcs: ["mylib.cpp"],
1148 system_shared_libs: [],
1149 stl: "none",
1150 }
1151 `)
1152}
1153
Jiyong Park16e91a02018-12-20 18:18:08 +09001154func TestStaticLinking(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001155 ctx, _ := testApex(t, `
Jiyong Park16e91a02018-12-20 18:18:08 +09001156 apex {
1157 name: "myapex",
1158 key: "myapex.key",
1159 native_shared_libs: ["mylib"],
1160 }
1161
1162 apex_key {
1163 name: "myapex.key",
1164 public_key: "testkey.avbpubkey",
1165 private_key: "testkey.pem",
1166 }
1167
1168 cc_library {
1169 name: "mylib",
1170 srcs: ["mylib.cpp"],
1171 system_shared_libs: [],
1172 stl: "none",
1173 stubs: {
1174 versions: ["1", "2", "3"],
1175 },
1176 }
1177
1178 cc_binary {
1179 name: "not_in_apex",
1180 srcs: ["mylib.cpp"],
1181 static_libs: ["mylib"],
1182 static_executable: true,
1183 system_shared_libs: [],
1184 stl: "none",
1185 }
Jiyong Park16e91a02018-12-20 18:18:08 +09001186 `)
1187
1188 ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a_core").Rule("ld").Args["libFlags"]
1189
1190 // Ensure that not_in_apex is linking with the static variant of mylib
Logan Chien3aeedc92018-12-26 15:32:21 +08001191 ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_core_static/mylib.a")
Jiyong Park16e91a02018-12-20 18:18:08 +09001192}
Jiyong Park9335a262018-12-24 11:31:58 +09001193
1194func TestKeys(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001195 ctx, _ := testApex(t, `
Jiyong Park9335a262018-12-24 11:31:58 +09001196 apex {
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001197 name: "myapex_keytest",
Jiyong Park9335a262018-12-24 11:31:58 +09001198 key: "myapex.key",
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001199 certificate: ":myapex.certificate",
Jiyong Park9335a262018-12-24 11:31:58 +09001200 native_shared_libs: ["mylib"],
1201 }
1202
1203 cc_library {
1204 name: "mylib",
1205 srcs: ["mylib.cpp"],
1206 system_shared_libs: [],
1207 stl: "none",
1208 }
1209
1210 apex_key {
1211 name: "myapex.key",
1212 public_key: "testkey.avbpubkey",
1213 private_key: "testkey.pem",
1214 }
1215
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001216 android_app_certificate {
1217 name: "myapex.certificate",
1218 certificate: "testkey",
1219 }
1220
1221 android_app_certificate {
1222 name: "myapex.certificate.override",
1223 certificate: "testkey.override",
1224 }
1225
Jiyong Park9335a262018-12-24 11:31:58 +09001226 `)
1227
1228 // check the APEX keys
Jiyong Parkd1e293d2019-03-15 02:13:21 +09001229 keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
Jiyong Park9335a262018-12-24 11:31:58 +09001230
1231 if keys.public_key_file.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
1232 t.Errorf("public key %q is not %q", keys.public_key_file.String(),
1233 "vendor/foo/devkeys/testkey.avbpubkey")
1234 }
1235 if keys.private_key_file.String() != "vendor/foo/devkeys/testkey.pem" {
1236 t.Errorf("private key %q is not %q", keys.private_key_file.String(),
1237 "vendor/foo/devkeys/testkey.pem")
1238 }
1239
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001240 // check the APK certs. It should be overridden to myapex.certificate.override
Sundong Ahnabb64432019-10-22 13:58:29 +09001241 certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001242 if certs != "testkey.override.x509.pem testkey.override.pk8" {
Jiyong Park9335a262018-12-24 11:31:58 +09001243 t.Errorf("cert and private key %q are not %q", certs,
Jiyong Parkb2742fd2019-02-11 11:38:15 +09001244 "testkey.override.509.pem testkey.override.pk8")
Jiyong Park9335a262018-12-24 11:31:58 +09001245 }
1246}
Jiyong Park58e364a2019-01-19 19:24:06 +09001247
1248func TestMacro(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001249 ctx, _ := testApex(t, `
Jiyong Park58e364a2019-01-19 19:24:06 +09001250 apex {
1251 name: "myapex",
1252 key: "myapex.key",
1253 native_shared_libs: ["mylib"],
1254 }
1255
1256 apex {
1257 name: "otherapex",
1258 key: "myapex.key",
1259 native_shared_libs: ["mylib"],
1260 }
1261
1262 apex_key {
1263 name: "myapex.key",
1264 public_key: "testkey.avbpubkey",
1265 private_key: "testkey.pem",
1266 }
1267
1268 cc_library {
1269 name: "mylib",
1270 srcs: ["mylib.cpp"],
1271 system_shared_libs: [],
1272 stl: "none",
1273 }
1274 `)
1275
Jooyung Han6b8459b2019-10-30 08:29:25 +09001276 // non-APEX variant does not have __ANDROID_APEX(_NAME)__ defined
Jiyong Park58e364a2019-01-19 19:24:06 +09001277 mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_static").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09001278 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09001279 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
1280 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09001281
Jooyung Han6b8459b2019-10-30 08:29:25 +09001282 // APEX variant has __ANDROID_APEX(_NAME)__ defined
Jiyong Park58e364a2019-01-19 19:24:06 +09001283 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_static_myapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09001284 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09001285 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
1286 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09001287
Jooyung Han6b8459b2019-10-30 08:29:25 +09001288 // APEX variant has __ANDROID_APEX(_NAME)__ defined
Jiyong Park58e364a2019-01-19 19:24:06 +09001289 mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_core_static_otherapex").Rule("cc").Args["cFlags"]
Jooyung Han6b8459b2019-10-30 08:29:25 +09001290 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
Jooyung Han77988572019-10-18 16:26:16 +09001291 ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
1292 ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
Jiyong Park58e364a2019-01-19 19:24:06 +09001293}
Jiyong Park7e636d02019-01-28 16:16:54 +09001294
1295func TestHeaderLibsDependency(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001296 ctx, _ := testApex(t, `
Jiyong Park7e636d02019-01-28 16:16:54 +09001297 apex {
1298 name: "myapex",
1299 key: "myapex.key",
1300 native_shared_libs: ["mylib"],
1301 }
1302
1303 apex_key {
1304 name: "myapex.key",
1305 public_key: "testkey.avbpubkey",
1306 private_key: "testkey.pem",
1307 }
1308
1309 cc_library_headers {
1310 name: "mylib_headers",
1311 export_include_dirs: ["my_include"],
1312 system_shared_libs: [],
1313 stl: "none",
1314 }
1315
1316 cc_library {
1317 name: "mylib",
1318 srcs: ["mylib.cpp"],
1319 system_shared_libs: [],
1320 stl: "none",
1321 header_libs: ["mylib_headers"],
1322 export_header_lib_headers: ["mylib_headers"],
1323 stubs: {
1324 versions: ["1", "2", "3"],
1325 },
1326 }
1327
1328 cc_library {
1329 name: "otherlib",
1330 srcs: ["mylib.cpp"],
1331 system_shared_libs: [],
1332 stl: "none",
1333 shared_libs: ["mylib"],
1334 }
1335 `)
1336
1337 cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_core_static").Rule("cc").Args["cFlags"]
1338
1339 // Ensure that the include path of the header lib is exported to 'otherlib'
1340 ensureContains(t, cFlags, "-Imy_include")
1341}
Alex Light9670d332019-01-29 18:07:33 -08001342
Jooyung Han31c470b2019-10-18 16:26:59 +09001343func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName string, files []string) {
1344 t.Helper()
Sundong Ahnabb64432019-10-22 13:58:29 +09001345 apexRule := ctx.ModuleForTests(moduleName, "android_common_"+moduleName+"_image").Rule("apexRule")
Jooyung Han31c470b2019-10-18 16:26:59 +09001346 copyCmds := apexRule.Args["copy_commands"]
1347 imageApexDir := "/image.apex/"
Jooyung Han39edb6c2019-11-06 16:53:07 +09001348 var failed bool
1349 var surplus []string
1350 filesMatched := make(map[string]bool)
1351 addContent := func(content string) {
1352 for _, expected := range files {
1353 if matched, _ := path.Match(expected, content); matched {
1354 filesMatched[expected] = true
1355 return
1356 }
1357 }
1358 surplus = append(surplus, content)
1359 }
Jooyung Han31c470b2019-10-18 16:26:59 +09001360 for _, cmd := range strings.Split(copyCmds, "&&") {
1361 cmd = strings.TrimSpace(cmd)
1362 if cmd == "" {
1363 continue
1364 }
1365 terms := strings.Split(cmd, " ")
1366 switch terms[0] {
1367 case "mkdir":
1368 case "cp":
1369 if len(terms) != 3 {
1370 t.Fatal("copyCmds contains invalid cp command", cmd)
1371 }
1372 dst := terms[2]
1373 index := strings.Index(dst, imageApexDir)
1374 if index == -1 {
1375 t.Fatal("copyCmds should copy a file to image.apex/", cmd)
1376 }
1377 dstFile := dst[index+len(imageApexDir):]
Jooyung Han39edb6c2019-11-06 16:53:07 +09001378 addContent(dstFile)
Jooyung Han31c470b2019-10-18 16:26:59 +09001379 default:
1380 t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
1381 }
1382 }
Jooyung Han31c470b2019-10-18 16:26:59 +09001383
Jooyung Han31c470b2019-10-18 16:26:59 +09001384 if len(surplus) > 0 {
Jooyung Han39edb6c2019-11-06 16:53:07 +09001385 sort.Strings(surplus)
Jooyung Han31c470b2019-10-18 16:26:59 +09001386 t.Log("surplus files", surplus)
1387 failed = true
1388 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001389
1390 if len(files) > len(filesMatched) {
1391 var missing []string
1392 for _, expected := range files {
1393 if !filesMatched[expected] {
1394 missing = append(missing, expected)
1395 }
1396 }
1397 sort.Strings(missing)
Jooyung Han31c470b2019-10-18 16:26:59 +09001398 t.Log("missing files", missing)
1399 failed = true
1400 }
1401 if failed {
1402 t.Fail()
1403 }
1404}
1405
Jooyung Han344d5432019-08-23 11:17:39 +09001406func TestVndkApexCurrent(t *testing.T) {
1407 ctx, _ := testApex(t, `
1408 apex_vndk {
1409 name: "myapex",
1410 key: "myapex.key",
1411 file_contexts: "myapex",
1412 }
1413
1414 apex_key {
1415 name: "myapex.key",
1416 public_key: "testkey.avbpubkey",
1417 private_key: "testkey.pem",
1418 }
1419
1420 cc_library {
1421 name: "libvndk",
1422 srcs: ["mylib.cpp"],
1423 vendor_available: true,
1424 vndk: {
1425 enabled: true,
1426 },
1427 system_shared_libs: [],
1428 stl: "none",
1429 }
1430
1431 cc_library {
1432 name: "libvndksp",
1433 srcs: ["mylib.cpp"],
1434 vendor_available: true,
1435 vndk: {
1436 enabled: true,
1437 support_system_process: true,
1438 },
1439 system_shared_libs: [],
1440 stl: "none",
1441 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001442 `+vndkLibrariesTxtFiles("current"))
Jooyung Han344d5432019-08-23 11:17:39 +09001443
Jooyung Han31c470b2019-10-18 16:26:59 +09001444 ensureExactContents(t, ctx, "myapex", []string{
1445 "lib/libvndk.so",
1446 "lib/libvndksp.so",
1447 "lib64/libvndk.so",
1448 "lib64/libvndksp.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001449 "etc/llndk.libraries.VER.txt",
1450 "etc/vndkcore.libraries.VER.txt",
1451 "etc/vndksp.libraries.VER.txt",
1452 "etc/vndkprivate.libraries.VER.txt",
1453 "etc/vndkcorevariant.libraries.VER.txt",
Jooyung Han31c470b2019-10-18 16:26:59 +09001454 })
Jooyung Han344d5432019-08-23 11:17:39 +09001455}
1456
1457func TestVndkApexWithPrebuilt(t *testing.T) {
1458 ctx, _ := testApex(t, `
1459 apex_vndk {
1460 name: "myapex",
1461 key: "myapex.key",
1462 file_contexts: "myapex",
1463 }
1464
1465 apex_key {
1466 name: "myapex.key",
1467 public_key: "testkey.avbpubkey",
1468 private_key: "testkey.pem",
1469 }
1470
1471 cc_prebuilt_library_shared {
Jooyung Han31c470b2019-10-18 16:26:59 +09001472 name: "libvndk",
1473 srcs: ["libvndk.so"],
Jooyung Han344d5432019-08-23 11:17:39 +09001474 vendor_available: true,
1475 vndk: {
1476 enabled: true,
1477 },
1478 system_shared_libs: [],
1479 stl: "none",
1480 }
Jooyung Han31c470b2019-10-18 16:26:59 +09001481
1482 cc_prebuilt_library_shared {
1483 name: "libvndk.arm",
1484 srcs: ["libvndk.arm.so"],
1485 vendor_available: true,
1486 vndk: {
1487 enabled: true,
1488 },
1489 enabled: false,
1490 arch: {
1491 arm: {
1492 enabled: true,
1493 },
1494 },
1495 system_shared_libs: [],
1496 stl: "none",
1497 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001498 `+vndkLibrariesTxtFiles("current"),
1499 withFiles(map[string][]byte{
1500 "libvndk.so": nil,
1501 "libvndk.arm.so": nil,
1502 }))
Jooyung Han344d5432019-08-23 11:17:39 +09001503
Jooyung Han31c470b2019-10-18 16:26:59 +09001504 ensureExactContents(t, ctx, "myapex", []string{
1505 "lib/libvndk.so",
1506 "lib/libvndk.arm.so",
1507 "lib64/libvndk.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001508 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09001509 })
Jooyung Han344d5432019-08-23 11:17:39 +09001510}
1511
Jooyung Han39edb6c2019-11-06 16:53:07 +09001512func vndkLibrariesTxtFiles(vers ...string) (result string) {
1513 for _, v := range vers {
1514 if v == "current" {
1515 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkcorevariant"} {
1516 result += `
1517 vndk_libraries_txt {
1518 name: "` + txt + `.libraries.txt",
1519 }
1520 `
1521 }
1522 } else {
1523 for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate"} {
1524 result += `
1525 prebuilt_etc {
1526 name: "` + txt + `.libraries.` + v + `.txt",
1527 src: "dummy.txt",
1528 }
1529 `
1530 }
1531 }
1532 }
1533 return
1534}
1535
Jooyung Han344d5432019-08-23 11:17:39 +09001536func TestVndkApexVersion(t *testing.T) {
1537 ctx, _ := testApex(t, `
1538 apex_vndk {
1539 name: "myapex_v27",
1540 key: "myapex.key",
1541 file_contexts: "myapex",
1542 vndk_version: "27",
1543 }
1544
1545 apex_key {
1546 name: "myapex.key",
1547 public_key: "testkey.avbpubkey",
1548 private_key: "testkey.pem",
1549 }
1550
Jooyung Han31c470b2019-10-18 16:26:59 +09001551 vndk_prebuilt_shared {
1552 name: "libvndk27",
1553 version: "27",
Jooyung Han344d5432019-08-23 11:17:39 +09001554 vendor_available: true,
1555 vndk: {
1556 enabled: true,
1557 },
Jooyung Han31c470b2019-10-18 16:26:59 +09001558 target_arch: "arm64",
1559 arch: {
1560 arm: {
1561 srcs: ["libvndk27_arm.so"],
1562 },
1563 arm64: {
1564 srcs: ["libvndk27_arm64.so"],
1565 },
1566 },
Jooyung Han344d5432019-08-23 11:17:39 +09001567 }
1568
1569 vndk_prebuilt_shared {
1570 name: "libvndk27",
1571 version: "27",
1572 vendor_available: true,
1573 vndk: {
1574 enabled: true,
1575 },
Jooyung Han31c470b2019-10-18 16:26:59 +09001576 target_arch: "x86_64",
1577 arch: {
1578 x86: {
1579 srcs: ["libvndk27_x86.so"],
1580 },
1581 x86_64: {
1582 srcs: ["libvndk27_x86_64.so"],
1583 },
1584 },
Jooyung Han39edb6c2019-11-06 16:53:07 +09001585 }
1586 `+vndkLibrariesTxtFiles("27"),
1587 withFiles(map[string][]byte{
1588 "libvndk27_arm.so": nil,
1589 "libvndk27_arm64.so": nil,
1590 "libvndk27_x86.so": nil,
1591 "libvndk27_x86_64.so": nil,
1592 }))
Jooyung Han344d5432019-08-23 11:17:39 +09001593
Jooyung Han31c470b2019-10-18 16:26:59 +09001594 ensureExactContents(t, ctx, "myapex_v27", []string{
1595 "lib/libvndk27_arm.so",
1596 "lib64/libvndk27_arm64.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001597 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09001598 })
Jooyung Han344d5432019-08-23 11:17:39 +09001599}
1600
1601func TestVndkApexErrorWithDuplicateVersion(t *testing.T) {
1602 testApexError(t, `module "myapex_v27.*" .*: vndk_version: 27 is already defined in "myapex_v27.*"`, `
1603 apex_vndk {
1604 name: "myapex_v27",
1605 key: "myapex.key",
1606 file_contexts: "myapex",
1607 vndk_version: "27",
1608 }
1609 apex_vndk {
1610 name: "myapex_v27_other",
1611 key: "myapex.key",
1612 file_contexts: "myapex",
1613 vndk_version: "27",
1614 }
1615
1616 apex_key {
1617 name: "myapex.key",
1618 public_key: "testkey.avbpubkey",
1619 private_key: "testkey.pem",
1620 }
1621
1622 cc_library {
1623 name: "libvndk",
1624 srcs: ["mylib.cpp"],
1625 vendor_available: true,
1626 vndk: {
1627 enabled: true,
1628 },
1629 system_shared_libs: [],
1630 stl: "none",
1631 }
1632
1633 vndk_prebuilt_shared {
1634 name: "libvndk",
1635 version: "27",
1636 vendor_available: true,
1637 vndk: {
1638 enabled: true,
1639 },
1640 srcs: ["libvndk.so"],
1641 }
1642 `, withFiles(map[string][]byte{
1643 "libvndk.so": nil,
1644 }))
1645}
1646
Jooyung Han90eee022019-10-01 20:02:42 +09001647func TestVndkApexNameRule(t *testing.T) {
1648 ctx, _ := testApex(t, `
1649 apex_vndk {
1650 name: "myapex",
1651 key: "myapex.key",
1652 file_contexts: "myapex",
1653 }
1654 apex_vndk {
1655 name: "myapex_v28",
1656 key: "myapex.key",
1657 file_contexts: "myapex",
1658 vndk_version: "28",
1659 }
1660 apex_key {
1661 name: "myapex.key",
1662 public_key: "testkey.avbpubkey",
1663 private_key: "testkey.pem",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001664 }`+vndkLibrariesTxtFiles("28", "current"))
Jooyung Han90eee022019-10-01 20:02:42 +09001665
1666 assertApexName := func(expected, moduleName string) {
Sundong Ahnabb64432019-10-22 13:58:29 +09001667 bundle := ctx.ModuleForTests(moduleName, "android_common_"+moduleName+"_image").Module().(*apexBundle)
Jooyung Han90eee022019-10-01 20:02:42 +09001668 actual := proptools.String(bundle.properties.Apex_name)
1669 if !reflect.DeepEqual(actual, expected) {
1670 t.Errorf("Got '%v', expected '%v'", actual, expected)
1671 }
1672 }
1673
1674 assertApexName("com.android.vndk.vVER", "myapex")
1675 assertApexName("com.android.vndk.v28", "myapex_v28")
1676}
1677
Jooyung Han344d5432019-08-23 11:17:39 +09001678func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
1679 ctx, _ := testApex(t, `
1680 apex_vndk {
1681 name: "myapex",
1682 key: "myapex.key",
1683 file_contexts: "myapex",
1684 }
1685
1686 apex_key {
1687 name: "myapex.key",
1688 public_key: "testkey.avbpubkey",
1689 private_key: "testkey.pem",
1690 }
1691
1692 cc_library {
1693 name: "libvndk",
1694 srcs: ["mylib.cpp"],
1695 vendor_available: true,
1696 native_bridge_supported: true,
1697 host_supported: true,
1698 vndk: {
1699 enabled: true,
1700 },
1701 system_shared_libs: [],
1702 stl: "none",
1703 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001704 `+vndkLibrariesTxtFiles("current"),
1705 withTargets(map[android.OsType][]android.Target{
1706 android.Android: []android.Target{
1707 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
1708 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
1709 {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}}, NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "arm64", NativeBridgeRelativePath: "x86_64"},
1710 {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}}, NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "arm", NativeBridgeRelativePath: "x86"},
1711 },
1712 }))
Jooyung Han344d5432019-08-23 11:17:39 +09001713
Jooyung Han31c470b2019-10-18 16:26:59 +09001714 ensureExactContents(t, ctx, "myapex", []string{
1715 "lib/libvndk.so",
1716 "lib64/libvndk.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001717 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09001718 })
Jooyung Han344d5432019-08-23 11:17:39 +09001719}
1720
1721func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
1722 testApexError(t, `module "myapex" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
1723 apex_vndk {
1724 name: "myapex",
1725 key: "myapex.key",
1726 file_contexts: "myapex",
1727 native_bridge_supported: true,
1728 }
1729
1730 apex_key {
1731 name: "myapex.key",
1732 public_key: "testkey.avbpubkey",
1733 private_key: "testkey.pem",
1734 }
1735
1736 cc_library {
1737 name: "libvndk",
1738 srcs: ["mylib.cpp"],
1739 vendor_available: true,
1740 native_bridge_supported: true,
1741 host_supported: true,
1742 vndk: {
1743 enabled: true,
1744 },
1745 system_shared_libs: [],
1746 stl: "none",
1747 }
1748 `)
1749}
1750
Jooyung Han31c470b2019-10-18 16:26:59 +09001751func TestVndkApexWithBinder32(t *testing.T) {
Jooyung Han39edb6c2019-11-06 16:53:07 +09001752 ctx, _ := testApex(t, `
Jooyung Han31c470b2019-10-18 16:26:59 +09001753 apex_vndk {
1754 name: "myapex_v27",
1755 key: "myapex.key",
1756 file_contexts: "myapex",
1757 vndk_version: "27",
1758 }
1759
1760 apex_key {
1761 name: "myapex.key",
1762 public_key: "testkey.avbpubkey",
1763 private_key: "testkey.pem",
1764 }
1765
1766 vndk_prebuilt_shared {
1767 name: "libvndk27",
1768 version: "27",
1769 target_arch: "arm",
1770 vendor_available: true,
1771 vndk: {
1772 enabled: true,
1773 },
1774 arch: {
1775 arm: {
1776 srcs: ["libvndk27.so"],
1777 }
1778 },
1779 }
1780
1781 vndk_prebuilt_shared {
1782 name: "libvndk27",
1783 version: "27",
1784 target_arch: "arm",
1785 binder32bit: true,
1786 vendor_available: true,
1787 vndk: {
1788 enabled: true,
1789 },
1790 arch: {
1791 arm: {
1792 srcs: ["libvndk27binder32.so"],
1793 }
1794 },
1795 }
Jooyung Han39edb6c2019-11-06 16:53:07 +09001796 `+vndkLibrariesTxtFiles("27"),
Jooyung Han31c470b2019-10-18 16:26:59 +09001797 withFiles(map[string][]byte{
1798 "libvndk27.so": nil,
1799 "libvndk27binder32.so": nil,
1800 }),
1801 withBinder32bit,
1802 withTargets(map[android.OsType][]android.Target{
1803 android.Android: []android.Target{
1804 {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}, NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
1805 },
1806 }),
1807 )
1808
1809 ensureExactContents(t, ctx, "myapex_v27", []string{
1810 "lib/libvndk27binder32.so",
Jooyung Han39edb6c2019-11-06 16:53:07 +09001811 "etc/*",
Jooyung Han31c470b2019-10-18 16:26:59 +09001812 })
1813}
1814
Jooyung Hane1633032019-08-01 17:41:43 +09001815func TestDependenciesInApexManifest(t *testing.T) {
1816 ctx, _ := testApex(t, `
1817 apex {
1818 name: "myapex_nodep",
1819 key: "myapex.key",
1820 native_shared_libs: ["lib_nodep"],
1821 compile_multilib: "both",
1822 file_contexts: "myapex",
1823 }
1824
1825 apex {
1826 name: "myapex_dep",
1827 key: "myapex.key",
1828 native_shared_libs: ["lib_dep"],
1829 compile_multilib: "both",
1830 file_contexts: "myapex",
1831 }
1832
1833 apex {
1834 name: "myapex_provider",
1835 key: "myapex.key",
1836 native_shared_libs: ["libfoo"],
1837 compile_multilib: "both",
1838 file_contexts: "myapex",
1839 }
1840
1841 apex {
1842 name: "myapex_selfcontained",
1843 key: "myapex.key",
1844 native_shared_libs: ["lib_dep", "libfoo"],
1845 compile_multilib: "both",
1846 file_contexts: "myapex",
1847 }
1848
1849 apex_key {
1850 name: "myapex.key",
1851 public_key: "testkey.avbpubkey",
1852 private_key: "testkey.pem",
1853 }
1854
1855 cc_library {
1856 name: "lib_nodep",
1857 srcs: ["mylib.cpp"],
1858 system_shared_libs: [],
1859 stl: "none",
1860 }
1861
1862 cc_library {
1863 name: "lib_dep",
1864 srcs: ["mylib.cpp"],
1865 shared_libs: ["libfoo"],
1866 system_shared_libs: [],
1867 stl: "none",
1868 }
1869
1870 cc_library {
1871 name: "libfoo",
1872 srcs: ["mytest.cpp"],
1873 stubs: {
1874 versions: ["1"],
1875 },
1876 system_shared_libs: [],
1877 stl: "none",
1878 }
1879 `)
1880
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001881 var apexManifestRule android.TestingBuildParams
Jooyung Hane1633032019-08-01 17:41:43 +09001882 var provideNativeLibs, requireNativeLibs []string
1883
Sundong Ahnabb64432019-10-22 13:58:29 +09001884 apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001885 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
1886 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09001887 ensureListEmpty(t, provideNativeLibs)
1888 ensureListEmpty(t, requireNativeLibs)
1889
Sundong Ahnabb64432019-10-22 13:58:29 +09001890 apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001891 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
1892 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09001893 ensureListEmpty(t, provideNativeLibs)
1894 ensureListContains(t, requireNativeLibs, "libfoo.so")
1895
Sundong Ahnabb64432019-10-22 13:58:29 +09001896 apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001897 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
1898 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09001899 ensureListContains(t, provideNativeLibs, "libfoo.so")
1900 ensureListEmpty(t, requireNativeLibs)
1901
Sundong Ahnabb64432019-10-22 13:58:29 +09001902 apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001903 provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
1904 requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
Jooyung Hane1633032019-08-01 17:41:43 +09001905 ensureListContains(t, provideNativeLibs, "libfoo.so")
1906 ensureListEmpty(t, requireNativeLibs)
1907}
1908
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001909func TestApexName(t *testing.T) {
1910 ctx, _ := testApex(t, `
1911 apex {
1912 name: "myapex",
1913 key: "myapex.key",
1914 apex_name: "com.android.myapex",
1915 }
1916
1917 apex_key {
1918 name: "myapex.key",
1919 public_key: "testkey.avbpubkey",
1920 private_key: "testkey.pem",
1921 }
1922 `)
1923
Sundong Ahnabb64432019-10-22 13:58:29 +09001924 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Hand15aa1f2019-09-27 00:38:03 +09001925 apexManifestRule := module.Rule("apexManifestRule")
1926 ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
1927 apexRule := module.Rule("apexRule")
1928 ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
1929}
1930
Alex Light0851b882019-02-07 13:20:53 -08001931func TestNonTestApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001932 ctx, _ := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08001933 apex {
1934 name: "myapex",
1935 key: "myapex.key",
1936 native_shared_libs: ["mylib_common"],
1937 }
1938
1939 apex_key {
1940 name: "myapex.key",
1941 public_key: "testkey.avbpubkey",
1942 private_key: "testkey.pem",
1943 }
1944
1945 cc_library {
1946 name: "mylib_common",
1947 srcs: ["mylib.cpp"],
1948 system_shared_libs: [],
1949 stl: "none",
1950 }
1951 `)
1952
Sundong Ahnabb64432019-10-22 13:58:29 +09001953 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08001954 apexRule := module.Rule("apexRule")
1955 copyCmds := apexRule.Args["copy_commands"]
1956
1957 if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
1958 t.Log("Apex was a test apex!")
1959 t.Fail()
1960 }
1961 // Ensure that main rule creates an output
1962 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
1963
1964 // Ensure that apex variant is created for the direct dep
1965 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_core_shared_myapex")
1966
1967 // Ensure that both direct and indirect deps are copied into apex
1968 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
1969
1970 // Ensure that the platform variant ends with _core_shared
1971 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_core_shared")
1972
1973 if !android.InAnyApex("mylib_common") {
1974 t.Log("Found mylib_common not in any apex!")
1975 t.Fail()
1976 }
1977}
1978
1979func TestTestApex(t *testing.T) {
1980 if android.InAnyApex("mylib_common_test") {
1981 t.Fatal("mylib_common_test must not be used in any other tests since this checks that global state is not updated in an illegal way!")
1982 }
Jaewoong Jung22f7d182019-07-16 18:25:41 -07001983 ctx, _ := testApex(t, `
Alex Light0851b882019-02-07 13:20:53 -08001984 apex_test {
1985 name: "myapex",
1986 key: "myapex.key",
1987 native_shared_libs: ["mylib_common_test"],
1988 }
1989
1990 apex_key {
1991 name: "myapex.key",
1992 public_key: "testkey.avbpubkey",
1993 private_key: "testkey.pem",
1994 }
1995
1996 cc_library {
1997 name: "mylib_common_test",
1998 srcs: ["mylib.cpp"],
1999 system_shared_libs: [],
2000 stl: "none",
2001 }
2002 `)
2003
Sundong Ahnabb64432019-10-22 13:58:29 +09002004 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Alex Light0851b882019-02-07 13:20:53 -08002005 apexRule := module.Rule("apexRule")
2006 copyCmds := apexRule.Args["copy_commands"]
2007
2008 if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
2009 t.Log("Apex was not a test apex!")
2010 t.Fail()
2011 }
2012 // Ensure that main rule creates an output
2013 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2014
2015 // Ensure that apex variant is created for the direct dep
2016 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_core_shared_myapex")
2017
2018 // Ensure that both direct and indirect deps are copied into apex
2019 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
2020
2021 // Ensure that the platform variant ends with _core_shared
2022 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_core_shared")
2023
2024 if android.InAnyApex("mylib_common_test") {
2025 t.Log("Found mylib_common_test in some apex!")
2026 t.Fail()
2027 }
2028}
2029
Alex Light9670d332019-01-29 18:07:33 -08002030func TestApexWithTarget(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002031 ctx, _ := testApex(t, `
Alex Light9670d332019-01-29 18:07:33 -08002032 apex {
2033 name: "myapex",
2034 key: "myapex.key",
2035 multilib: {
2036 first: {
2037 native_shared_libs: ["mylib_common"],
2038 }
2039 },
2040 target: {
2041 android: {
2042 multilib: {
2043 first: {
2044 native_shared_libs: ["mylib"],
2045 }
2046 }
2047 },
2048 host: {
2049 multilib: {
2050 first: {
2051 native_shared_libs: ["mylib2"],
2052 }
2053 }
2054 }
2055 }
2056 }
2057
2058 apex_key {
2059 name: "myapex.key",
2060 public_key: "testkey.avbpubkey",
2061 private_key: "testkey.pem",
2062 }
2063
2064 cc_library {
2065 name: "mylib",
2066 srcs: ["mylib.cpp"],
2067 system_shared_libs: [],
2068 stl: "none",
2069 }
2070
2071 cc_library {
2072 name: "mylib_common",
2073 srcs: ["mylib.cpp"],
2074 system_shared_libs: [],
2075 stl: "none",
2076 compile_multilib: "first",
2077 }
2078
2079 cc_library {
2080 name: "mylib2",
2081 srcs: ["mylib.cpp"],
2082 system_shared_libs: [],
2083 stl: "none",
2084 compile_multilib: "first",
2085 }
2086 `)
2087
Sundong Ahnabb64432019-10-22 13:58:29 +09002088 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Alex Light9670d332019-01-29 18:07:33 -08002089 copyCmds := apexRule.Args["copy_commands"]
2090
2091 // Ensure that main rule creates an output
2092 ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
2093
2094 // Ensure that apex variant is created for the direct dep
2095 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared_myapex")
2096 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_core_shared_myapex")
2097 ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared_myapex")
2098
2099 // Ensure that both direct and indirect deps are copied into apex
2100 ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
2101 ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
2102 ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
2103
2104 // Ensure that the platform variant ends with _core_shared
2105 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared")
2106 ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_core_shared")
2107 ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_core_shared")
2108}
Jiyong Park04480cf2019-02-06 00:16:29 +09002109
2110func TestApexWithShBinary(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002111 ctx, _ := testApex(t, `
Jiyong Park04480cf2019-02-06 00:16:29 +09002112 apex {
2113 name: "myapex",
2114 key: "myapex.key",
2115 binaries: ["myscript"],
2116 }
2117
2118 apex_key {
2119 name: "myapex.key",
2120 public_key: "testkey.avbpubkey",
2121 private_key: "testkey.pem",
2122 }
2123
2124 sh_binary {
2125 name: "myscript",
2126 src: "mylib.cpp",
2127 filename: "myscript.sh",
2128 sub_dir: "script",
2129 }
2130 `)
2131
Sundong Ahnabb64432019-10-22 13:58:29 +09002132 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Jiyong Park04480cf2019-02-06 00:16:29 +09002133 copyCmds := apexRule.Args["copy_commands"]
2134
2135 ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
2136}
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002137
2138func TestApexInProductPartition(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002139 ctx, _ := testApex(t, `
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002140 apex {
2141 name: "myapex",
2142 key: "myapex.key",
2143 native_shared_libs: ["mylib"],
2144 product_specific: true,
2145 }
2146
2147 apex_key {
2148 name: "myapex.key",
2149 public_key: "testkey.avbpubkey",
2150 private_key: "testkey.pem",
2151 product_specific: true,
2152 }
2153
2154 cc_library {
2155 name: "mylib",
2156 srcs: ["mylib.cpp"],
2157 system_shared_libs: [],
2158 stl: "none",
2159 }
2160 `)
2161
Sundong Ahnabb64432019-10-22 13:58:29 +09002162 apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Colin Crossff6c33d2019-10-02 16:01:35 -07002163 expected := buildDir + "/target/product/test_device/product/apex"
2164 actual := apex.installDir.String()
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002165 if actual != expected {
2166 t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
2167 }
Jiyong Parkd1e293d2019-03-15 02:13:21 +09002168}
Jiyong Park67882562019-03-21 01:11:21 +09002169
2170func TestApexKeyFromOtherModule(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002171 ctx, _ := testApex(t, `
Jiyong Park67882562019-03-21 01:11:21 +09002172 apex_key {
2173 name: "myapex.key",
2174 public_key: ":my.avbpubkey",
2175 private_key: ":my.pem",
2176 product_specific: true,
2177 }
2178
2179 filegroup {
2180 name: "my.avbpubkey",
2181 srcs: ["testkey2.avbpubkey"],
2182 }
2183
2184 filegroup {
2185 name: "my.pem",
2186 srcs: ["testkey2.pem"],
2187 }
2188 `)
2189
2190 apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
2191 expected_pubkey := "testkey2.avbpubkey"
2192 actual_pubkey := apex_key.public_key_file.String()
2193 if actual_pubkey != expected_pubkey {
2194 t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
2195 }
2196 expected_privkey := "testkey2.pem"
2197 actual_privkey := apex_key.private_key_file.String()
2198 if actual_privkey != expected_privkey {
2199 t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
2200 }
2201}
Jaewoong Jung939ebd52019-03-26 15:07:36 -07002202
2203func TestPrebuilt(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002204 ctx, _ := testApex(t, `
Jaewoong Jung939ebd52019-03-26 15:07:36 -07002205 prebuilt_apex {
2206 name: "myapex",
Jiyong Parkc95714e2019-03-29 14:23:10 +09002207 arch: {
2208 arm64: {
2209 src: "myapex-arm64.apex",
2210 },
2211 arm: {
2212 src: "myapex-arm.apex",
2213 },
2214 },
Jaewoong Jung939ebd52019-03-26 15:07:36 -07002215 }
2216 `)
2217
2218 prebuilt := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
2219
Jiyong Parkc95714e2019-03-29 14:23:10 +09002220 expectedInput := "myapex-arm64.apex"
2221 if prebuilt.inputApex.String() != expectedInput {
2222 t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
2223 }
Jaewoong Jung939ebd52019-03-26 15:07:36 -07002224}
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01002225
2226func TestPrebuiltFilenameOverride(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002227 ctx, _ := testApex(t, `
Nikita Ioffe7a41ebd2019-04-04 18:09:48 +01002228 prebuilt_apex {
2229 name: "myapex",
2230 src: "myapex-arm.apex",
2231 filename: "notmyapex.apex",
2232 }
2233 `)
2234
2235 p := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
2236
2237 expected := "notmyapex.apex"
2238 if p.installFilename != expected {
2239 t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
2240 }
2241}
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07002242
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002243func TestPrebuiltOverrides(t *testing.T) {
2244 ctx, config := testApex(t, `
2245 prebuilt_apex {
2246 name: "myapex.prebuilt",
2247 src: "myapex-arm.apex",
2248 overrides: [
2249 "myapex",
2250 ],
2251 }
2252 `)
2253
2254 p := ctx.ModuleForTests("myapex.prebuilt", "android_common").Module().(*Prebuilt)
2255
2256 expected := []string{"myapex"}
Jiyong Parkb0a012c2019-11-14 17:17:03 +09002257 actual := android.AndroidMkEntriesForTest(t, config, "", p).EntryMap["LOCAL_OVERRIDES_MODULES"]
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002258 if !reflect.DeepEqual(actual, expected) {
Jiyong Parkb0a012c2019-11-14 17:17:03 +09002259 t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002260 }
2261}
2262
Roland Levillain630846d2019-06-26 12:48:34 +01002263func TestApexWithTests(t *testing.T) {
Roland Levillainf89cd092019-07-29 16:22:59 +01002264 ctx, config := testApex(t, `
Roland Levillain630846d2019-06-26 12:48:34 +01002265 apex_test {
2266 name: "myapex",
2267 key: "myapex.key",
2268 tests: [
2269 "mytest",
Roland Levillain9b5fde92019-06-28 15:41:19 +01002270 "mytests",
Roland Levillain630846d2019-06-26 12:48:34 +01002271 ],
2272 }
2273
2274 apex_key {
2275 name: "myapex.key",
2276 public_key: "testkey.avbpubkey",
2277 private_key: "testkey.pem",
2278 }
2279
2280 cc_test {
2281 name: "mytest",
2282 gtest: false,
2283 srcs: ["mytest.cpp"],
2284 relative_install_path: "test",
2285 system_shared_libs: [],
2286 static_executable: true,
2287 stl: "none",
2288 }
Roland Levillain9b5fde92019-06-28 15:41:19 +01002289
2290 cc_test {
2291 name: "mytests",
2292 gtest: false,
2293 srcs: [
2294 "mytest1.cpp",
2295 "mytest2.cpp",
2296 "mytest3.cpp",
2297 ],
2298 test_per_src: true,
2299 relative_install_path: "test",
2300 system_shared_libs: [],
2301 static_executable: true,
2302 stl: "none",
2303 }
Roland Levillain630846d2019-06-26 12:48:34 +01002304 `)
2305
Sundong Ahnabb64432019-10-22 13:58:29 +09002306 apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
Roland Levillain630846d2019-06-26 12:48:34 +01002307 copyCmds := apexRule.Args["copy_commands"]
2308
2309 // Ensure that test dep is copied into apex.
2310 ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
Roland Levillain9b5fde92019-06-28 15:41:19 +01002311
2312 // Ensure that test deps built with `test_per_src` are copied into apex.
2313 ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
2314 ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
2315 ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
Roland Levillainf89cd092019-07-29 16:22:59 +01002316
2317 // Ensure the module is correctly translated.
Sundong Ahnabb64432019-10-22 13:58:29 +09002318 apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
Roland Levillainf89cd092019-07-29 16:22:59 +01002319 data := android.AndroidMkDataForTest(t, config, "", apexBundle)
2320 name := apexBundle.BaseModuleName()
2321 prefix := "TARGET_"
2322 var builder strings.Builder
2323 data.Custom(&builder, name, prefix, "", data)
2324 androidMk := builder.String()
Jooyung Han31c470b2019-10-18 16:26:59 +09002325 ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
2326 ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
2327 ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
2328 ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
2329 ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.json.myapex\n")
2330 ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
Roland Levillainf89cd092019-07-29 16:22:59 +01002331 ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
Roland Levillain630846d2019-06-26 12:48:34 +01002332}
2333
Jooyung Han5c998b92019-06-27 11:30:33 +09002334func TestApexUsesOtherApex(t *testing.T) {
Jaewoong Jung22f7d182019-07-16 18:25:41 -07002335 ctx, _ := testApex(t, `
Jooyung Han5c998b92019-06-27 11:30:33 +09002336 apex {
2337 name: "myapex",
2338 key: "myapex.key",
2339 native_shared_libs: ["mylib"],
2340 uses: ["commonapex"],
2341 }
2342
2343 apex {
2344 name: "commonapex",
2345 key: "myapex.key",
2346 native_shared_libs: ["libcommon"],
2347 provide_cpp_shared_libs: true,
2348 }
2349
2350 apex_key {
2351 name: "myapex.key",
2352 public_key: "testkey.avbpubkey",
2353 private_key: "testkey.pem",
2354 }
2355
2356 cc_library {
2357 name: "mylib",
2358 srcs: ["mylib.cpp"],
2359 shared_libs: ["libcommon"],
2360 system_shared_libs: [],
2361 stl: "none",
2362 }
2363
2364 cc_library {
2365 name: "libcommon",
2366 srcs: ["mylib_common.cpp"],
2367 system_shared_libs: [],
2368 stl: "none",
2369 }
2370 `)
2371
Sundong Ahnabb64432019-10-22 13:58:29 +09002372 module1 := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Jooyung Han5c998b92019-06-27 11:30:33 +09002373 apexRule1 := module1.Rule("apexRule")
2374 copyCmds1 := apexRule1.Args["copy_commands"]
2375
Sundong Ahnabb64432019-10-22 13:58:29 +09002376 module2 := ctx.ModuleForTests("commonapex", "android_common_commonapex_image")
Jooyung Han5c998b92019-06-27 11:30:33 +09002377 apexRule2 := module2.Rule("apexRule")
2378 copyCmds2 := apexRule2.Args["copy_commands"]
2379
2380 ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_core_shared_myapex")
2381 ensureListContains(t, ctx.ModuleVariantsForTests("libcommon"), "android_arm64_armv8-a_core_shared_commonapex")
2382 ensureContains(t, copyCmds1, "image.apex/lib64/mylib.so")
2383 ensureContains(t, copyCmds2, "image.apex/lib64/libcommon.so")
2384 ensureNotContains(t, copyCmds1, "image.apex/lib64/libcommon.so")
2385}
2386
2387func TestApexUsesFailsIfNotProvided(t *testing.T) {
2388 testApexError(t, `uses: "commonapex" does not provide native_shared_libs`, `
2389 apex {
2390 name: "myapex",
2391 key: "myapex.key",
2392 uses: ["commonapex"],
2393 }
2394
2395 apex {
2396 name: "commonapex",
2397 key: "myapex.key",
2398 }
2399
2400 apex_key {
2401 name: "myapex.key",
2402 public_key: "testkey.avbpubkey",
2403 private_key: "testkey.pem",
2404 }
2405 `)
2406 testApexError(t, `uses: "commonapex" is not a provider`, `
2407 apex {
2408 name: "myapex",
2409 key: "myapex.key",
2410 uses: ["commonapex"],
2411 }
2412
2413 cc_library {
2414 name: "commonapex",
2415 system_shared_libs: [],
2416 stl: "none",
2417 }
2418
2419 apex_key {
2420 name: "myapex.key",
2421 public_key: "testkey.avbpubkey",
2422 private_key: "testkey.pem",
2423 }
2424 `)
2425}
2426
2427func TestApexUsesFailsIfUseVenderMismatch(t *testing.T) {
2428 testApexError(t, `use_vendor: "commonapex" has different value of use_vendor`, `
2429 apex {
2430 name: "myapex",
2431 key: "myapex.key",
2432 use_vendor: true,
2433 uses: ["commonapex"],
2434 }
2435
2436 apex {
2437 name: "commonapex",
2438 key: "myapex.key",
2439 provide_cpp_shared_libs: true,
2440 }
2441
2442 apex_key {
2443 name: "myapex.key",
2444 public_key: "testkey.avbpubkey",
2445 private_key: "testkey.pem",
2446 }
Jooyung Handc782442019-11-01 03:14:38 +09002447 `, func(fs map[string][]byte, config android.Config) {
2448 setUseVendorWhitelistForTest(config, []string{"myapex"})
2449 })
Jooyung Han5c998b92019-06-27 11:30:33 +09002450}
2451
Jooyung Hand48f3c32019-08-23 11:18:57 +09002452func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
2453 testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
2454 apex {
2455 name: "myapex",
2456 key: "myapex.key",
2457 native_shared_libs: ["libfoo"],
2458 }
2459
2460 apex_key {
2461 name: "myapex.key",
2462 public_key: "testkey.avbpubkey",
2463 private_key: "testkey.pem",
2464 }
2465
2466 cc_library {
2467 name: "libfoo",
2468 stl: "none",
2469 system_shared_libs: [],
2470 enabled: false,
2471 }
2472 `)
2473 testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
2474 apex {
2475 name: "myapex",
2476 key: "myapex.key",
2477 java_libs: ["myjar"],
2478 }
2479
2480 apex_key {
2481 name: "myapex.key",
2482 public_key: "testkey.avbpubkey",
2483 private_key: "testkey.pem",
2484 }
2485
2486 java_library {
2487 name: "myjar",
2488 srcs: ["foo/bar/MyClass.java"],
2489 sdk_version: "none",
2490 system_modules: "none",
2491 compile_dex: true,
2492 enabled: false,
2493 }
2494 `)
2495}
2496
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002497func TestApexWithApps(t *testing.T) {
2498 ctx, _ := testApex(t, `
2499 apex {
2500 name: "myapex",
2501 key: "myapex.key",
2502 apps: [
2503 "AppFoo",
Jiyong Parkf7487312019-10-17 12:54:30 +09002504 "AppFooPriv",
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002505 ],
2506 }
2507
2508 apex_key {
2509 name: "myapex.key",
2510 public_key: "testkey.avbpubkey",
2511 private_key: "testkey.pem",
2512 }
2513
2514 android_app {
2515 name: "AppFoo",
2516 srcs: ["foo/bar/MyClass.java"],
2517 sdk_version: "none",
2518 system_modules: "none",
Jiyong Park8be103b2019-11-08 15:53:48 +09002519 jni_libs: ["libjni"],
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002520 }
Jiyong Parkf7487312019-10-17 12:54:30 +09002521
2522 android_app {
2523 name: "AppFooPriv",
2524 srcs: ["foo/bar/MyClass.java"],
2525 sdk_version: "none",
2526 system_modules: "none",
2527 privileged: true,
2528 }
Jiyong Park8be103b2019-11-08 15:53:48 +09002529
2530 cc_library_shared {
2531 name: "libjni",
2532 srcs: ["mylib.cpp"],
2533 stl: "none",
2534 system_shared_libs: [],
2535 }
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002536 `)
2537
Sundong Ahnabb64432019-10-22 13:58:29 +09002538 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002539 apexRule := module.Rule("apexRule")
2540 copyCmds := apexRule.Args["copy_commands"]
2541
2542 ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
Jiyong Parkf7487312019-10-17 12:54:30 +09002543 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
Jiyong Park52cd06f2019-11-11 10:14:32 +09002544
2545 // JNI libraries are embedded inside APK
2546 appZipRule := ctx.ModuleForTests("AppFoo", "android_common_myapex").Rule("zip")
2547 libjniOutput := ctx.ModuleForTests("libjni", "android_arm64_armv8-a_core_shared_myapex").Module().(*cc.Module).OutputFile()
2548 ensureListContains(t, appZipRule.Implicits.Strings(), libjniOutput.String())
2549 // ... uncompressed
2550 if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
2551 t.Errorf("jni lib is not uncompressed for AppFoo")
2552 }
2553 // ... and not directly inside the APEX
2554 ensureNotContains(t, copyCmds, "image.apex/lib64/libjni.so")
Dario Frenicde2a032019-10-27 00:29:22 +01002555}
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002556
Dario Frenicde2a032019-10-27 00:29:22 +01002557func TestApexWithAppImports(t *testing.T) {
2558 ctx, _ := testApex(t, `
2559 apex {
2560 name: "myapex",
2561 key: "myapex.key",
2562 apps: [
2563 "AppFooPrebuilt",
2564 "AppFooPrivPrebuilt",
2565 ],
2566 }
2567
2568 apex_key {
2569 name: "myapex.key",
2570 public_key: "testkey.avbpubkey",
2571 private_key: "testkey.pem",
2572 }
2573
2574 android_app_import {
2575 name: "AppFooPrebuilt",
2576 apk: "PrebuiltAppFoo.apk",
2577 presigned: true,
2578 dex_preopt: {
2579 enabled: false,
2580 },
2581 }
2582
2583 android_app_import {
2584 name: "AppFooPrivPrebuilt",
2585 apk: "PrebuiltAppFooPriv.apk",
2586 privileged: true,
2587 presigned: true,
2588 dex_preopt: {
2589 enabled: false,
2590 },
2591 }
2592 `)
2593
Sundong Ahnabb64432019-10-22 13:58:29 +09002594 module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
Dario Frenicde2a032019-10-27 00:29:22 +01002595 apexRule := module.Rule("apexRule")
2596 copyCmds := apexRule.Args["copy_commands"]
2597
2598 ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
2599 ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AppFooPrivPrebuilt.apk")
Sundong Ahne1f05aa2019-08-27 13:55:42 +09002600}
2601
Jooyung Han18020ea2019-11-13 10:50:48 +09002602func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
2603 // libfoo's apex_available comes from cc_defaults
2604 testApexError(t, `"myapex" .*: requires "libfoo" that is not available for the APEX`, `
2605 apex {
2606 name: "myapex",
2607 key: "myapex.key",
2608 native_shared_libs: ["libfoo"],
2609 }
2610
2611 apex_key {
2612 name: "myapex.key",
2613 public_key: "testkey.avbpubkey",
2614 private_key: "testkey.pem",
2615 }
2616
2617 apex {
2618 name: "otherapex",
2619 key: "myapex.key",
2620 native_shared_libs: ["libfoo"],
2621 }
2622
2623 cc_defaults {
2624 name: "libfoo-defaults",
2625 apex_available: ["otherapex"],
2626 }
2627
2628 cc_library {
2629 name: "libfoo",
2630 defaults: ["libfoo-defaults"],
2631 stl: "none",
2632 system_shared_libs: [],
2633 }`)
2634}
2635
Jiyong Park127b40b2019-09-30 16:04:35 +09002636func TestApexAvailable(t *testing.T) {
2637 // libfoo is not available to myapex, but only to otherapex
2638 testApexError(t, "requires \"libfoo\" that is not available for the APEX", `
2639 apex {
2640 name: "myapex",
2641 key: "myapex.key",
2642 native_shared_libs: ["libfoo"],
2643 }
2644
2645 apex_key {
2646 name: "myapex.key",
2647 public_key: "testkey.avbpubkey",
2648 private_key: "testkey.pem",
2649 }
2650
2651 apex {
2652 name: "otherapex",
2653 key: "otherapex.key",
2654 native_shared_libs: ["libfoo"],
2655 }
2656
2657 apex_key {
2658 name: "otherapex.key",
2659 public_key: "testkey.avbpubkey",
2660 private_key: "testkey.pem",
2661 }
2662
2663 cc_library {
2664 name: "libfoo",
2665 stl: "none",
2666 system_shared_libs: [],
2667 apex_available: ["otherapex"],
2668 }`)
2669
2670 // libbar is an indirect dep
2671 testApexError(t, "requires \"libbar\" that is not available for the APEX", `
2672 apex {
2673 name: "myapex",
2674 key: "myapex.key",
2675 native_shared_libs: ["libfoo"],
2676 }
2677
2678 apex_key {
2679 name: "myapex.key",
2680 public_key: "testkey.avbpubkey",
2681 private_key: "testkey.pem",
2682 }
2683
2684 apex {
2685 name: "otherapex",
2686 key: "otherapex.key",
2687 native_shared_libs: ["libfoo"],
2688 }
2689
2690 apex_key {
2691 name: "otherapex.key",
2692 public_key: "testkey.avbpubkey",
2693 private_key: "testkey.pem",
2694 }
2695
2696 cc_library {
2697 name: "libfoo",
2698 stl: "none",
2699 shared_libs: ["libbar"],
2700 system_shared_libs: [],
2701 apex_available: ["myapex", "otherapex"],
2702 }
2703
2704 cc_library {
2705 name: "libbar",
2706 stl: "none",
2707 system_shared_libs: [],
2708 apex_available: ["otherapex"],
2709 }`)
2710
2711 testApexError(t, "\"otherapex\" is not a valid module name", `
2712 apex {
2713 name: "myapex",
2714 key: "myapex.key",
2715 native_shared_libs: ["libfoo"],
2716 }
2717
2718 apex_key {
2719 name: "myapex.key",
2720 public_key: "testkey.avbpubkey",
2721 private_key: "testkey.pem",
2722 }
2723
2724 cc_library {
2725 name: "libfoo",
2726 stl: "none",
2727 system_shared_libs: [],
2728 apex_available: ["otherapex"],
2729 }`)
2730
2731 ctx, _ := testApex(t, `
2732 apex {
2733 name: "myapex",
2734 key: "myapex.key",
2735 native_shared_libs: ["libfoo", "libbar"],
2736 }
2737
2738 apex_key {
2739 name: "myapex.key",
2740 public_key: "testkey.avbpubkey",
2741 private_key: "testkey.pem",
2742 }
2743
2744 cc_library {
2745 name: "libfoo",
2746 stl: "none",
2747 system_shared_libs: [],
2748 apex_available: ["myapex"],
2749 }
2750
2751 cc_library {
2752 name: "libbar",
2753 stl: "none",
2754 system_shared_libs: [],
2755 apex_available: ["//apex_available:anyapex"],
2756 }`)
2757
2758 // check that libfoo and libbar are created only for myapex, but not for the platform
2759 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared_myapex")
2760 ensureListNotContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared")
2761 ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_core_shared_myapex")
2762 ensureListNotContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_core_shared")
2763
2764 ctx, _ = testApex(t, `
2765 apex {
2766 name: "myapex",
2767 key: "myapex.key",
2768 }
2769
2770 apex_key {
2771 name: "myapex.key",
2772 public_key: "testkey.avbpubkey",
2773 private_key: "testkey.pem",
2774 }
2775
2776 cc_library {
2777 name: "libfoo",
2778 stl: "none",
2779 system_shared_libs: [],
2780 apex_available: ["//apex_available:platform"],
2781 }`)
2782
2783 // check that libfoo is created only for the platform
2784 ensureListNotContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared_myapex")
2785 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared")
Jiyong Parka90ca002019-10-07 15:47:24 +09002786
2787 ctx, _ = testApex(t, `
2788 apex {
2789 name: "myapex",
2790 key: "myapex.key",
2791 native_shared_libs: ["libfoo"],
2792 }
2793
2794 apex_key {
2795 name: "myapex.key",
2796 public_key: "testkey.avbpubkey",
2797 private_key: "testkey.pem",
2798 }
2799
2800 cc_library {
2801 name: "libfoo",
2802 stl: "none",
2803 system_shared_libs: [],
2804 apex_available: ["myapex"],
2805 static: {
2806 apex_available: ["//apex_available:platform"],
2807 },
2808 }`)
2809
2810 // shared variant of libfoo is only available to myapex
2811 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared_myapex")
2812 ensureListNotContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_shared")
2813 // but the static variant is available to both myapex and the platform
2814 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_static_myapex")
2815 ensureListContains(t, ctx.ModuleVariantsForTests("libfoo"), "android_arm64_armv8-a_core_static")
Jiyong Park127b40b2019-09-30 16:04:35 +09002816}
2817
Jaewoong Jungc1001ec2019-06-25 11:20:53 -07002818func TestMain(m *testing.M) {
2819 run := func() int {
2820 setUp()
2821 defer tearDown()
2822
2823 return m.Run()
2824 }
2825
2826 os.Exit(run())
2827}