blob: d85ce4bb9efc3c09824021090f31f9e1bf4d2dd2 [file] [log] [blame]
Liz Kammer620dea62021-04-14 17:36:10 -04001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package android
16
17import (
Liz Kammer620dea62021-04-14 17:36:10 -040018 "fmt"
19 "path/filepath"
20 "strings"
21
Chris Parsons953b3562021-09-20 15:14:39 -040022 "android/soong/bazel"
23
Liz Kammer620dea62021-04-14 17:36:10 -040024 "github.com/google/blueprint"
25 "github.com/google/blueprint/pathtools"
26)
27
28// bazel_paths contains methods to:
29// * resolve Soong path and module references into bazel.LabelList
30// * resolve Bazel path references into Soong-compatible paths
31//
32// There is often a similar method for Bazel as there is for Soong path handling and should be used
33// in similar circumstances
34//
Usta Shresthadb46a9b2022-07-11 11:29:56 -040035// Bazel Soong
36// ==============================================================
37// BazelLabelForModuleSrc PathForModuleSrc
38// BazelLabelForModuleSrcExcludes PathForModuleSrcExcludes
39// BazelLabelForModuleDeps n/a
40// tbd PathForSource
41// tbd ExistentPathsForSources
42// PathForBazelOut PathForModuleOut
Liz Kammer620dea62021-04-14 17:36:10 -040043//
44// Use cases:
45// * Module contains a property (often tagged `android:"path"`) that expects paths *relative to the
46// module directory*:
47// * BazelLabelForModuleSrcExcludes, if the module also contains an excludes_<propname> property
48// * BazelLabelForModuleSrc, otherwise
49// * Converting references to other modules to Bazel Labels:
50// BazelLabelForModuleDeps
51// * Converting a path obtained from bazel_handler cquery results:
52// PathForBazelOut
53//
54// NOTE: all Soong globs are expanded within Soong rather than being converted to a Bazel glob
55// syntax. This occurs because Soong does not have a concept of crossing package boundaries,
56// so the glob as computed by Soong may contain paths that cross package-boundaries. These
57// would be unknowingly omitted if the glob were handled by Bazel. By expanding globs within
58// Soong, we support identification and detection (within Bazel) use of paths that cross
59// package boundaries.
60//
61// Path resolution:
62// * filepath/globs: resolves as itself or is converted to an absolute Bazel label (e.g.
63// //path/to/dir:<filepath>) if path exists in a separate package or subpackage.
64// * references to other modules (using the ":name{.tag}" syntax). These resolve as a Bazel label
65// for a target. If the Bazel target is in the local module directory, it will be returned
66// relative to the current package (e.g. ":<target>"). Otherwise, it will be returned as an
67// absolute Bazel label (e.g. "//path/to/dir:<target>"). If the reference to another module
68// cannot be resolved,the function will panic. This is often due to the dependency not being added
69// via an AddDependency* method.
70
Usta Shresthadb46a9b2022-07-11 11:29:56 -040071// BazelConversionContext is a minimal context interface to check if a module should be converted by bp2build,
Jingwen Chen55bc8202021-11-02 06:40:51 +000072// with functions containing information to match against allowlists and denylists.
73// If a module is deemed to be convertible by bp2build, then it should rely on a
74// BazelConversionPathContext for more functions for dep/path features.
75type BazelConversionContext interface {
76 Config() Config
Liz Kammer620dea62021-04-14 17:36:10 -040077
Liz Kammer620dea62021-04-14 17:36:10 -040078 Module() Module
Liz Kammer6eff3232021-08-26 08:37:59 -040079 OtherModuleType(m blueprint.Module) string
Liz Kammer620dea62021-04-14 17:36:10 -040080 OtherModuleName(m blueprint.Module) string
81 OtherModuleDir(m blueprint.Module) string
Sam Delmerico24c56032022-03-28 19:53:03 +000082 ModuleErrorf(format string, args ...interface{})
Jingwen Chen55bc8202021-11-02 06:40:51 +000083}
84
85// A subset of the ModuleContext methods which are sufficient to resolve references to paths/deps in
86// order to form a Bazel-compatible label for conversion.
87type BazelConversionPathContext interface {
88 EarlyModulePathContext
89 BazelConversionContext
90
Liz Kammerc86e0942023-08-11 16:15:12 -040091 ModuleName() string
92 ModuleType() string
Jingwen Chen55bc8202021-11-02 06:40:51 +000093 ModuleErrorf(fmt string, args ...interface{})
94 PropertyErrorf(property, fmt string, args ...interface{})
95 GetDirectDep(name string) (blueprint.Module, blueprint.DependencyTag)
96 ModuleFromName(name string) (blueprint.Module, bool)
Liz Kammer6eff3232021-08-26 08:37:59 -040097 AddUnconvertedBp2buildDep(string)
Liz Kammerdaa09ef2021-12-15 15:35:38 -050098 AddMissingBp2buildDep(dep string)
Liz Kammer620dea62021-04-14 17:36:10 -040099}
100
101// BazelLabelForModuleDeps expects a list of reference to other modules, ("<module>"
102// or ":<module>") and returns a Bazel-compatible label which corresponds to dependencies on the
103// module within the given ctx.
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000104func BazelLabelForModuleDeps(ctx Bp2buildMutatorContext, modules []string) bazel.LabelList {
105 return BazelLabelForModuleDepsWithFn(ctx, modules, BazelModuleLabel, true)
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400106}
107
108// BazelLabelForModuleWholeDepsExcludes expects two lists: modules (containing modules to include in
109// the list), and excludes (modules to exclude from the list). Both of these should contain
110// references to other modules, ("<module>" or ":<module>"). It returns a Bazel-compatible label
111// list which corresponds to dependencies on the module within the given ctx, and the excluded
112// dependencies. Prebuilt dependencies will be appended with _alwayslink so they can be handled as
113// whole static libraries.
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000114func BazelLabelForModuleDepsExcludes(ctx Bp2buildMutatorContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -0400115 return BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, BazelModuleLabel)
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400116}
117
Chris Parsons953b3562021-09-20 15:14:39 -0400118// BazelLabelForModuleDepsWithFn expects a list of reference to other modules, ("<module>"
119// or ":<module>") and applies moduleToLabelFn to determine and return a Bazel-compatible label
120// which corresponds to dependencies on the module within the given ctx.
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000121func BazelLabelForModuleDepsWithFn(ctx Bp2buildMutatorContext, modules []string,
122 moduleToLabelFn func(BazelConversionPathContext, blueprint.Module) string,
123 markAsDeps bool) bazel.LabelList {
Liz Kammer620dea62021-04-14 17:36:10 -0400124 var labels bazel.LabelList
Chris Parsons51f8c392021-08-03 21:01:05 -0400125 // In some cases, a nil string list is different than an explicitly empty list.
126 if len(modules) == 0 && modules != nil {
127 labels.Includes = []bazel.Label{}
128 return labels
129 }
Cole Faust5c84c622023-08-01 11:07:02 -0700130 modules = FirstUniqueStrings(modules)
Liz Kammer620dea62021-04-14 17:36:10 -0400131 for _, module := range modules {
132 bpText := module
133 if m := SrcIsModule(module); m == "" {
134 module = ":" + module
135 }
136 if m, t := SrcIsModuleWithTag(module); m != "" {
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000137 l := getOtherModuleLabel(ctx, m, t, moduleToLabelFn, markAsDeps)
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500138 if l != nil {
139 l.OriginalModuleName = bpText
140 labels.Includes = append(labels.Includes, *l)
141 }
Liz Kammer620dea62021-04-14 17:36:10 -0400142 } else {
143 ctx.ModuleErrorf("%q, is not a module reference", module)
144 }
145 }
146 return labels
147}
148
Chris Parsons953b3562021-09-20 15:14:39 -0400149// BazelLabelForModuleDepsExcludesWithFn expects two lists: modules (containing modules to include in the
150// list), and excludes (modules to exclude from the list). Both of these should contain references
151// to other modules, ("<module>" or ":<module>"). It applies moduleToLabelFn to determine and return a
152// Bazel-compatible label list which corresponds to dependencies on the module within the given ctx, and
153// the excluded dependencies.
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000154func BazelLabelForModuleDepsExcludesWithFn(ctx Bp2buildMutatorContext, modules, excludes []string,
Jingwen Chen55bc8202021-11-02 06:40:51 +0000155 moduleToLabelFn func(BazelConversionPathContext, blueprint.Module) string) bazel.LabelList {
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000156 moduleLabels := BazelLabelForModuleDepsWithFn(ctx, RemoveListFromList(modules, excludes), moduleToLabelFn, true)
Liz Kammer47535c52021-06-02 16:02:22 -0400157 if len(excludes) == 0 {
158 return moduleLabels
159 }
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000160 excludeLabels := BazelLabelForModuleDepsWithFn(ctx, excludes, moduleToLabelFn, false)
Liz Kammer47535c52021-06-02 16:02:22 -0400161 return bazel.LabelList{
162 Includes: moduleLabels.Includes,
163 Excludes: excludeLabels.Includes,
164 }
165}
166
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000167func BazelLabelForModuleSrcSingle(ctx Bp2buildMutatorContext, path string) bazel.Label {
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500168 if srcs := BazelLabelForModuleSrcExcludes(ctx, []string{path}, []string(nil)).Includes; len(srcs) > 0 {
169 return srcs[0]
170 }
171 return bazel.Label{}
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200172}
173
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000174func BazelLabelForModuleDepSingle(ctx Bp2buildMutatorContext, path string) bazel.Label {
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500175 if srcs := BazelLabelForModuleDepsExcludes(ctx, []string{path}, []string(nil)).Includes; len(srcs) > 0 {
176 return srcs[0]
177 }
178 return bazel.Label{}
Rupert Shuttleworth6e4950a2021-07-27 01:34:59 -0400179}
180
Liz Kammer620dea62021-04-14 17:36:10 -0400181// BazelLabelForModuleSrc expects a list of path (relative to local module directory) and module
182// references (":<module>") and returns a bazel.LabelList{} containing the resolved references in
183// paths, relative to the local module, or Bazel-labels (absolute if in a different package or
184// relative if within the same package).
185// Properties must have been annotated with struct tag `android:"path"` so that dependencies modules
Spandan Das950091c2023-07-19 22:26:37 +0000186// will have already been handled by the pathdeps mutator.
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000187func BazelLabelForModuleSrc(ctx Bp2buildMutatorContext, paths []string) bazel.LabelList {
Liz Kammer620dea62021-04-14 17:36:10 -0400188 return BazelLabelForModuleSrcExcludes(ctx, paths, []string(nil))
189}
190
191// BazelLabelForModuleSrc expects lists of path and excludes (relative to local module directory)
192// and module references (":<module>") and returns a bazel.LabelList{} containing the resolved
193// references in paths, minus those in excludes, relative to the local module, or Bazel-labels
194// (absolute if in a different package or relative if within the same package).
195// Properties must have been annotated with struct tag `android:"path"` so that dependencies modules
Spandan Das950091c2023-07-19 22:26:37 +0000196// will have already been handled by the pathdeps mutator.
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000197func BazelLabelForModuleSrcExcludes(ctx Bp2buildMutatorContext, paths, excludes []string) bazel.LabelList {
198 excludeLabels := expandSrcsForBazel(ctx, excludes, []string(nil), false)
Liz Kammer620dea62021-04-14 17:36:10 -0400199 excluded := make([]string, 0, len(excludeLabels.Includes))
200 for _, e := range excludeLabels.Includes {
201 excluded = append(excluded, e.Label)
202 }
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000203 labels := expandSrcsForBazel(ctx, paths, excluded, true)
Liz Kammer620dea62021-04-14 17:36:10 -0400204 labels.Excludes = excludeLabels.Includes
Spandan Das0a8a2752023-06-21 01:50:33 +0000205 labels = TransformSubpackagePaths(ctx.Config(), ctx.ModuleDir(), labels)
Liz Kammer620dea62021-04-14 17:36:10 -0400206 return labels
207}
208
Spandan Das03010662023-08-15 22:06:41 +0000209func BazelLabelForSrcPatternExcludes(ctx BazelConversionPathContext, dir, pattern string, excludes []string) bazel.LabelList {
210 topRelPaths, err := ctx.GlobWithDeps(filepath.Join(dir, pattern), excludes)
211 if err != nil {
212 ctx.ModuleErrorf("Could not search dir: %s for pattern %s due to %v\n", dir, pattern, err)
213 }
214 // An intermediate list of labels relative to `dir` that assumes that there no subpacakges beneath `dir`
215 dirRelLabels := []bazel.Label{}
216 for _, topRelPath := range topRelPaths {
217 dirRelPath := Rel(ctx, dir, topRelPath)
218 dirRelLabels = append(dirRelLabels, bazel.Label{Label: "./" + dirRelPath})
219 }
220 // Return the package boudary resolved labels
221 return TransformSubpackagePaths(ctx.Config(), dir, bazel.MakeLabelList(dirRelLabels))
222}
223
Jingwen Chen0eeaeb82022-09-21 10:27:42 +0000224// Returns true if a prefix + components[:i] is a package boundary.
225//
226// A package boundary is determined by a BUILD file in the directory. This can happen in 2 cases:
227//
Usta Shresthad5580312022-09-23 16:46:38 -0400228// 1. An Android.bp exists, which bp2build will always convert to a sibling BUILD file.
229// 2. An Android.bp doesn't exist, but a checked-in BUILD/BUILD.bazel file exists, and that file
230// is allowlisted by the bp2build configuration to be merged into the symlink forest workspace.
Jingwen Chen0eeaeb82022-09-21 10:27:42 +0000231func isPackageBoundary(config Config, prefix string, components []string, componentIndex int) bool {
232 prefix = filepath.Join(prefix, filepath.Join(components[:componentIndex+1]...))
233 if exists, _, _ := config.fs.Exists(filepath.Join(prefix, "Android.bp")); exists {
Liz Kammer620dea62021-04-14 17:36:10 -0400234 return true
Jingwen Chen0eeaeb82022-09-21 10:27:42 +0000235 } else if config.Bp2buildPackageConfig.ShouldKeepExistingBuildFileForDir(prefix) {
236 if exists, _, _ := config.fs.Exists(filepath.Join(prefix, "BUILD")); exists {
237 return true
238 } else if exists, _, _ := config.fs.Exists(filepath.Join(prefix, "BUILD.bazel")); exists {
239 return true
240 }
Liz Kammer620dea62021-04-14 17:36:10 -0400241 }
Jingwen Chen0eeaeb82022-09-21 10:27:42 +0000242
243 return false
Liz Kammer620dea62021-04-14 17:36:10 -0400244}
245
246// Transform a path (if necessary) to acknowledge package boundaries
247//
248// e.g. something like
Colin Crossd079e0b2022-08-16 10:27:33 -0700249//
250// async_safe/include/async_safe/CHECK.h
251//
Liz Kammer620dea62021-04-14 17:36:10 -0400252// might become
Colin Crossd079e0b2022-08-16 10:27:33 -0700253//
254// //bionic/libc/async_safe:include/async_safe/CHECK.h
255//
Liz Kammer620dea62021-04-14 17:36:10 -0400256// if the "async_safe" directory is actually a package and not just a directory.
257//
258// In particular, paths that extend into packages are transformed into absolute labels beginning with //.
Spandan Das0a8a2752023-06-21 01:50:33 +0000259func transformSubpackagePath(cfg Config, dir string, path bazel.Label) bazel.Label {
Liz Kammer620dea62021-04-14 17:36:10 -0400260 var newPath bazel.Label
261
Jingwen Chen38e62642021-04-19 05:00:15 +0000262 // Don't transform OriginalModuleName
263 newPath.OriginalModuleName = path.OriginalModuleName
Liz Kammer1e753242023-06-02 19:03:06 -0400264 // if it wasn't a module, store the original path. We may need the original path to replace
265 // references if it is actually in another package
266 if path.OriginalModuleName == "" {
267 newPath.OriginalModuleName = path.Label
268 }
Liz Kammer620dea62021-04-14 17:36:10 -0400269
270 if strings.HasPrefix(path.Label, "//") {
271 // Assume absolute labels are already correct (e.g. //path/to/some/package:foo.h)
272 newPath.Label = path.Label
273 return newPath
274 }
Usta Shresthad5580312022-09-23 16:46:38 -0400275 if strings.HasPrefix(path.Label, "./") {
276 // Drop "./" for consistent handling of paths.
277 // Specifically, to not let "." be considered a package boundary.
278 // Say `inputPath` is `x/Android.bp` and that file has some module
279 // with `srcs=["y/a.c", "z/b.c"]`.
280 // And say the directory tree is:
281 // x
282 // ├── Android.bp
283 // ├── y
284 // │ ├── a.c
285 // │ └── Android.bp
286 // └── z
287 // └── b.c
288 // Then bazel equivalent labels in srcs should be:
289 // //x/y:a.c, x/z/b.c
290 // The above should still be the case if `x/Android.bp` had
291 // srcs=["./y/a.c", "./z/b.c"]
292 // However, if we didn't strip "./", we'd get
293 // //x/./y:a.c, //x/.:z/b.c
294 path.Label = strings.TrimPrefix(path.Label, "./")
295 }
Liz Kammer620dea62021-04-14 17:36:10 -0400296 pathComponents := strings.Split(path.Label, "/")
Usta Shresthad5580312022-09-23 16:46:38 -0400297 newLabel := ""
Jingwen Chen0eeaeb82022-09-21 10:27:42 +0000298 foundPackageBoundary := false
Liz Kammer620dea62021-04-14 17:36:10 -0400299 // Check the deepest subdirectory first and work upwards
300 for i := len(pathComponents) - 1; i >= 0; i-- {
301 pathComponent := pathComponents[i]
302 var sep string
Spandan Das0a8a2752023-06-21 01:50:33 +0000303 if !foundPackageBoundary && isPackageBoundary(cfg, dir, pathComponents, i) {
Liz Kammer620dea62021-04-14 17:36:10 -0400304 sep = ":"
Jingwen Chen0eeaeb82022-09-21 10:27:42 +0000305 foundPackageBoundary = true
Liz Kammer620dea62021-04-14 17:36:10 -0400306 } else {
307 sep = "/"
308 }
309 if newLabel == "" {
310 newLabel = pathComponent
311 } else {
312 newLabel = pathComponent + sep + newLabel
313 }
314 }
Jingwen Chen0eeaeb82022-09-21 10:27:42 +0000315 if foundPackageBoundary {
Liz Kammer620dea62021-04-14 17:36:10 -0400316 // Ensure paths end up looking like //bionic/... instead of //./bionic/...
Spandan Das0a8a2752023-06-21 01:50:33 +0000317 moduleDir := dir
Liz Kammer620dea62021-04-14 17:36:10 -0400318 if strings.HasPrefix(moduleDir, ".") {
319 moduleDir = moduleDir[1:]
320 }
321 // Make the path into an absolute label (e.g. //bionic/libc/foo:bar.h instead of just foo:bar.h)
322 if moduleDir == "" {
323 newLabel = "//" + newLabel
324 } else {
325 newLabel = "//" + moduleDir + "/" + newLabel
326 }
327 }
328 newPath.Label = newLabel
329
330 return newPath
331}
332
333// Transform paths to acknowledge package boundaries
334// See transformSubpackagePath() for more information
Spandan Das0a8a2752023-06-21 01:50:33 +0000335func TransformSubpackagePaths(cfg Config, dir string, paths bazel.LabelList) bazel.LabelList {
Liz Kammer620dea62021-04-14 17:36:10 -0400336 var newPaths bazel.LabelList
337 for _, include := range paths.Includes {
Spandan Das0a8a2752023-06-21 01:50:33 +0000338 newPaths.Includes = append(newPaths.Includes, transformSubpackagePath(cfg, dir, include))
Liz Kammer620dea62021-04-14 17:36:10 -0400339 }
340 for _, exclude := range paths.Excludes {
Spandan Das0a8a2752023-06-21 01:50:33 +0000341 newPaths.Excludes = append(newPaths.Excludes, transformSubpackagePath(cfg, dir, exclude))
Liz Kammer620dea62021-04-14 17:36:10 -0400342 }
343 return newPaths
344}
345
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400346// Converts root-relative Paths to a list of bazel.Label relative to the module in ctx.
347func RootToModuleRelativePaths(ctx BazelConversionPathContext, paths Paths) []bazel.Label {
348 var newPaths []bazel.Label
349 for _, path := range PathsWithModuleSrcSubDir(ctx, paths, "") {
350 s := path.Rel()
351 newPaths = append(newPaths, bazel.Label{Label: s})
352 }
353 return newPaths
354}
355
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000356var Bp2buildDepTag bp2buildDepTag
357
358type bp2buildDepTag struct {
359 blueprint.BaseDependencyTag
360}
361
Liz Kammer620dea62021-04-14 17:36:10 -0400362// expandSrcsForBazel returns bazel.LabelList with paths rooted from the module's local source
363// directory and Bazel target labels, excluding those included in the excludes argument (which
364// should already be expanded to resolve references to Soong-modules). Valid elements of paths
365// include:
Colin Crossd079e0b2022-08-16 10:27:33 -0700366// - filepath, relative to local module directory, resolves as a filepath relative to the local
367// source directory
368// - glob, relative to the local module directory, resolves as filepath(s), relative to the local
369// module directory. Because Soong does not have a concept of crossing package boundaries, the
370// glob as computed by Soong may contain paths that cross package-boundaries that would be
371// unknowingly omitted if the glob were handled by Bazel. To allow identification and detect
372// (within Bazel) use of paths that cross package boundaries, we expand globs within Soong rather
373// than converting Soong glob syntax to Bazel glob syntax. **Invalid for excludes.**
374// - other modules using the ":name{.tag}" syntax. These modules must implement SourceFileProducer
375// or OutputFileProducer. These resolve as a Bazel label for a target. If the Bazel target is in
376// the local module directory, it will be returned relative to the current package (e.g.
377// ":<target>"). Otherwise, it will be returned as an absolute Bazel label (e.g.
378// "//path/to/dir:<target>"). If the reference to another module cannot be resolved,the function
379// will panic.
380//
Liz Kammer620dea62021-04-14 17:36:10 -0400381// Properties passed as the paths or excludes argument must have been annotated with struct tag
382// `android:"path"` so that dependencies on other modules will have already been handled by the
Spandan Das950091c2023-07-19 22:26:37 +0000383// pathdeps mutator.
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000384func expandSrcsForBazel(ctx Bp2buildMutatorContext, paths, expandedExcludes []string, markAsDeps bool) bazel.LabelList {
Liz Kammer620dea62021-04-14 17:36:10 -0400385 if paths == nil {
386 return bazel.LabelList{}
387 }
388 labels := bazel.LabelList{
389 Includes: []bazel.Label{},
390 }
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000391
392 // expandedExcludes contain module-dir relative paths, but root-relative paths
393 // are needed for GlobFiles later.
394 var rootRelativeExpandedExcludes []string
395 for _, e := range expandedExcludes {
396 rootRelativeExpandedExcludes = append(rootRelativeExpandedExcludes, filepath.Join(ctx.ModuleDir(), e))
397 }
398
Liz Kammer620dea62021-04-14 17:36:10 -0400399 for _, p := range paths {
400 if m, tag := SrcIsModuleWithTag(p); m != "" {
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000401 l := getOtherModuleLabel(ctx, m, tag, BazelModuleLabel, markAsDeps)
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500402 if l != nil && !InList(l.Label, expandedExcludes) {
Spandan Dasf62e80a2023-08-17 22:35:04 +0000403 if strings.HasPrefix(m, "//") {
404 // this is a module in a soong namespace
405 // It appears as //<namespace>:<module_name> in srcs, and not ://<namespace>:<module_name>
406 l.OriginalModuleName = m
407 } else {
408 l.OriginalModuleName = fmt.Sprintf(":%s", m)
409 }
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500410 labels.Includes = append(labels.Includes, *l)
Liz Kammer620dea62021-04-14 17:36:10 -0400411 }
412 } else {
413 var expandedPaths []bazel.Label
414 if pathtools.IsGlob(p) {
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000415 // e.g. turn "math/*.c" in
416 // external/arm-optimized-routines to external/arm-optimized-routines/math/*.c
417 rootRelativeGlobPath := pathForModuleSrc(ctx, p).String()
Romain Jobredeaux1282c422021-10-29 10:52:59 -0400418 expandedPaths = RootToModuleRelativePaths(ctx, GlobFiles(ctx, rootRelativeGlobPath, rootRelativeExpandedExcludes))
Liz Kammer620dea62021-04-14 17:36:10 -0400419 } else {
420 if !InList(p, expandedExcludes) {
421 expandedPaths = append(expandedPaths, bazel.Label{Label: p})
422 }
423 }
424 labels.Includes = append(labels.Includes, expandedPaths...)
425 }
426 }
427 return labels
428}
429
430// getOtherModuleLabel returns a bazel.Label for the given dependency/tag combination for the
431// module. The label will be relative to the current directory if appropriate. The dependency must
432// already be resolved by either deps mutator or path deps mutator.
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000433func getOtherModuleLabel(ctx Bp2buildMutatorContext, dep, tag string,
434 labelFromModule func(BazelConversionPathContext, blueprint.Module) string,
435 markAsDep bool) *bazel.Label {
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400436 m, _ := ctx.ModuleFromName(dep)
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500437 // The module was not found in an Android.bp file, this is often due to:
438 // * a limited manifest
439 // * a required module not being converted from Android.mk
Liz Kammer620dea62021-04-14 17:36:10 -0400440 if m == nil {
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500441 ctx.AddMissingBp2buildDep(dep)
442 return &bazel.Label{
443 Label: ":" + dep + "__BP2BUILD__MISSING__DEP",
444 }
Liz Kammer620dea62021-04-14 17:36:10 -0400445 }
Chris Parsons5f1b3c72023-09-28 20:41:03 +0000446 if markAsDep {
447 // Don't count dependencies of "libc". This is a hack to circumvent the
448 // fact that, in a variantless build graph, "libc" has a dependency on itself.
449 if ctx.ModuleName() != "libc" {
450 ctx.AddDependency(ctx.Module(), Bp2buildDepTag, dep)
451 }
452 }
Liz Kammer6eff3232021-08-26 08:37:59 -0400453 if !convertedToBazel(ctx, m) {
454 ctx.AddUnconvertedBp2buildDep(dep)
455 }
Chris Parsons953b3562021-09-20 15:14:39 -0400456 label := BazelModuleLabel(ctx, ctx.Module())
457 otherLabel := labelFromModule(ctx, m)
458
459 // TODO(b/165114590): Convert tag (":name{.tag}") to corresponding Bazel implicit output targets.
Romain Jobredeaux9c06ef32023-08-21 18:05:29 -0400460 if tag != "" && m.Name() == "framework-res" {
461 otherLabel += tag
462 }
Chris Parsons953b3562021-09-20 15:14:39 -0400463
Liz Kammer620dea62021-04-14 17:36:10 -0400464 if samePackage(label, otherLabel) {
465 otherLabel = bazelShortLabel(otherLabel)
466 }
467
Liz Kammerdaa09ef2021-12-15 15:35:38 -0500468 return &bazel.Label{
Liz Kammer620dea62021-04-14 17:36:10 -0400469 Label: otherLabel,
470 }
471}
472
Jingwen Chen55bc8202021-11-02 06:40:51 +0000473func BazelModuleLabel(ctx BazelConversionPathContext, module blueprint.Module) string {
Liz Kammer620dea62021-04-14 17:36:10 -0400474 // TODO(b/165114590): Convert tag (":name{.tag}") to corresponding Bazel implicit output targets.
Spandan Das64852422023-08-02 21:58:41 +0000475 if !convertedToBazel(ctx, module) || isGoModule(module) {
Liz Kammer620dea62021-04-14 17:36:10 -0400476 return bp2buildModuleLabel(ctx, module)
477 }
Liz Kammer6eff3232021-08-26 08:37:59 -0400478 b, _ := module.(Bazelable)
Liz Kammer620dea62021-04-14 17:36:10 -0400479 return b.GetBazelLabel(ctx, module)
480}
481
482func bazelShortLabel(label string) string {
483 i := strings.Index(label, ":")
Jingwen Chen80b6b642021-11-02 06:23:07 +0000484 if i == -1 {
485 panic(fmt.Errorf("Could not find the ':' character in '%s', expected a fully qualified label.", label))
486 }
Liz Kammer620dea62021-04-14 17:36:10 -0400487 return label[i:]
488}
489
490func bazelPackage(label string) string {
491 i := strings.Index(label, ":")
Jingwen Chen80b6b642021-11-02 06:23:07 +0000492 if i == -1 {
493 panic(fmt.Errorf("Could not find the ':' character in '%s', expected a fully qualified label.", label))
494 }
Liz Kammer620dea62021-04-14 17:36:10 -0400495 return label[0:i]
496}
497
498func samePackage(label1, label2 string) bool {
499 return bazelPackage(label1) == bazelPackage(label2)
500}
501
Jingwen Chen55bc8202021-11-02 06:40:51 +0000502func bp2buildModuleLabel(ctx BazelConversionContext, module blueprint.Module) string {
Liz Kammerc86e0942023-08-11 16:15:12 -0400503 moduleName := moduleNameWithPossibleOverride(ctx, module, ctx.OtherModuleName(module))
504 moduleDir := moduleDirWithPossibleOverride(ctx, module, ctx.OtherModuleDir(module))
Jingwen Chen889f2f22022-12-16 08:16:01 +0000505 if moduleDir == Bp2BuildTopLevel {
506 moduleDir = ""
507 }
Liz Kammere1b39a52023-09-18 14:32:18 -0400508 if a, ok := module.(Module); ok && IsModulePrebuilt(a) {
509 moduleName = RemoveOptionalPrebuiltPrefix(moduleName)
510 }
Liz Kammer620dea62021-04-14 17:36:10 -0400511 return fmt.Sprintf("//%s:%s", moduleDir, moduleName)
512}
513
514// BazelOutPath is a Bazel output path compatible to be used for mixed builds within Soong/Ninja.
515type BazelOutPath struct {
516 OutputPath
517}
518
Liz Kammer0f3b7d22021-09-28 13:48:21 -0400519// ensure BazelOutPath implements Path
Liz Kammer620dea62021-04-14 17:36:10 -0400520var _ Path = BazelOutPath{}
Liz Kammer0f3b7d22021-09-28 13:48:21 -0400521
522// ensure BazelOutPath implements genPathProvider
523var _ genPathProvider = BazelOutPath{}
524
525// ensure BazelOutPath implements objPathProvider
Liz Kammer620dea62021-04-14 17:36:10 -0400526var _ objPathProvider = BazelOutPath{}
527
Liz Kammer0f3b7d22021-09-28 13:48:21 -0400528func (p BazelOutPath) genPathWithExt(ctx ModuleOutPathContext, subdir, ext string) ModuleGenPath {
529 return PathForModuleGen(ctx, subdir, pathtools.ReplaceExtension(p.path, ext))
530}
531
Liz Kammer620dea62021-04-14 17:36:10 -0400532func (p BazelOutPath) objPathWithExt(ctx ModuleOutPathContext, subdir, ext string) ModuleObjPath {
533 return PathForModuleObj(ctx, subdir, pathtools.ReplaceExtension(p.path, ext))
534}
535
Cole Faust9a06d252022-06-03 16:00:11 -0700536// PathForBazelOutRelative returns a BazelOutPath representing the path under an output directory dedicated to
537// bazel-owned outputs. Calling .Rel() on the result will give the input path as relative to the given
538// relativeRoot.
539func PathForBazelOutRelative(ctx PathContext, relativeRoot string, path string) BazelOutPath {
540 validatedPath, err := validatePath(filepath.Join("execroot", "__main__", path))
Liz Kammer620dea62021-04-14 17:36:10 -0400541 if err != nil {
542 reportPathError(ctx, err)
543 }
Cole Faust0abd4b42023-01-10 10:49:18 -0800544 var relativeRootPath string
545 if pathComponents := strings.SplitN(path, "/", 4); len(pathComponents) >= 3 &&
Cole Faust9a06d252022-06-03 16:00:11 -0700546 pathComponents[0] == "bazel-out" && pathComponents[2] == "bin" {
547 // If the path starts with something like: bazel-out/linux_x86_64-fastbuild-ST-b4ef1c4402f9/bin/
548 // make it relative to that folder. bazel-out/volatile-status.txt is an example
549 // of something that starts with bazel-out but is not relative to the bin folder
550 relativeRootPath = filepath.Join("execroot", "__main__", pathComponents[0], pathComponents[1], pathComponents[2], relativeRoot)
Cole Faust0abd4b42023-01-10 10:49:18 -0800551 } else {
552 relativeRootPath = filepath.Join("execroot", "__main__", relativeRoot)
Cole Faust9a06d252022-06-03 16:00:11 -0700553 }
Liz Kammer620dea62021-04-14 17:36:10 -0400554
Cole Faust9a06d252022-06-03 16:00:11 -0700555 var relPath string
556 if relPath, err = filepath.Rel(relativeRootPath, validatedPath); err != nil || strings.HasPrefix(relPath, "../") {
557 // We failed to make this path relative to execroot/__main__, fall back to a non-relative path
558 // One case where this happens is when path is ../bazel_tools/something
559 relativeRootPath = ""
560 relPath = validatedPath
561 }
562
563 outputPath := OutputPath{
564 basePath{"", ""},
Lukacs T. Berki9f6c24a2021-08-26 15:07:24 +0200565 ctx.Config().soongOutDir,
Cole Faust9a06d252022-06-03 16:00:11 -0700566 ctx.Config().BazelContext.OutputBase(),
567 }
Liz Kammer620dea62021-04-14 17:36:10 -0400568
569 return BazelOutPath{
Cole Faust9a06d252022-06-03 16:00:11 -0700570 // .withRel() appends its argument onto the current path, and only the most
571 // recently appended part is returned by outputPath.rel().
572 // So outputPath.rel() will return relPath.
573 OutputPath: outputPath.withRel(relativeRootPath).withRel(relPath),
Liz Kammer620dea62021-04-14 17:36:10 -0400574 }
575}
Liz Kammerb6a55bf2021-04-12 15:42:51 -0400576
Cole Faust9a06d252022-06-03 16:00:11 -0700577// PathForBazelOut returns a BazelOutPath representing the path under an output directory dedicated to
578// bazel-owned outputs.
579func PathForBazelOut(ctx PathContext, path string) BazelOutPath {
580 return PathForBazelOutRelative(ctx, "", path)
581}
582
Liz Kammerb6a55bf2021-04-12 15:42:51 -0400583// PathsForBazelOut returns a list of paths representing the paths under an output directory
584// dedicated to Bazel-owned outputs.
585func PathsForBazelOut(ctx PathContext, paths []string) Paths {
586 outs := make(Paths, 0, len(paths))
587 for _, p := range paths {
588 outs = append(outs, PathForBazelOut(ctx, p))
589 }
590 return outs
591}
Jingwen Chen6817bbb2022-10-14 09:56:07 +0000592
593// BazelStringOrLabelFromProp splits a Soong module property that can be
594// either a string literal, path (with android:path tag) or a module reference
595// into separate bazel string or label attributes. Bazel treats string and label
596// attributes as distinct types, so this function categorizes a string property
597// into either one of them.
598//
599// e.g. apex.private_key = "foo.pem" can either refer to:
600//
601// 1. "foo.pem" in the current directory -> file target
602// 2. "foo.pem" module -> rule target
603// 3. "foo.pem" file in a different directory, prefixed by a product variable handled
604// in a bazel macro. -> string literal
605//
606// For the first two cases, they are defined using the label attribute. For the third case,
607// it's defined with the string attribute.
608func BazelStringOrLabelFromProp(
Chris Parsons637458d2023-09-19 20:09:00 +0000609 ctx Bp2buildMutatorContext,
Jingwen Chen6817bbb2022-10-14 09:56:07 +0000610 propToDistinguish *string) (bazel.LabelAttribute, bazel.StringAttribute) {
611
612 var labelAttr bazel.LabelAttribute
613 var strAttr bazel.StringAttribute
614
615 if propToDistinguish == nil {
616 // nil pointer
617 return labelAttr, strAttr
618 }
619
620 prop := String(propToDistinguish)
621 if SrcIsModule(prop) != "" {
622 // If it's a module (SrcIsModule will return the module name), set the
623 // resolved label to the label attribute.
624 labelAttr.SetValue(BazelLabelForModuleDepSingle(ctx, prop))
625 } else {
626 // Not a module name. This could be a string literal or a file target in
627 // the current dir. Check if the path exists:
628 path := ExistentPathForSource(ctx, ctx.ModuleDir(), prop)
629
630 if path.Valid() && parentDir(path.String()) == ctx.ModuleDir() {
631 // If it exists and the path is relative to the current dir, resolve the bazel label
632 // for the _file target_ and set it to the label attribute.
633 //
634 // Resolution is necessary because this could be a file in a subpackage.
635 labelAttr.SetValue(BazelLabelForModuleSrcSingle(ctx, prop))
636 } else {
637 // Otherwise, treat it as a string literal and assign to the string attribute.
638 strAttr.Value = propToDistinguish
639 }
640 }
641
642 return labelAttr, strAttr
643}