blob: 26cacdba811875cc70c0348677cd6c7ad46d80a3 [file] [log] [blame]
Liz Kammer620dea62021-04-14 17:36:10 -04001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package android
16
17import (
18 "android/soong/bazel"
19 "fmt"
20 "path/filepath"
21 "strings"
22
23 "github.com/google/blueprint"
24 "github.com/google/blueprint/pathtools"
25)
26
27// bazel_paths contains methods to:
28// * resolve Soong path and module references into bazel.LabelList
29// * resolve Bazel path references into Soong-compatible paths
30//
31// There is often a similar method for Bazel as there is for Soong path handling and should be used
32// in similar circumstances
33//
34// Bazel Soong
35//
36// BazelLabelForModuleSrc PathForModuleSrc
37// BazelLabelForModuleSrcExcludes PathForModuleSrcExcludes
38// BazelLabelForModuleDeps n/a
39// tbd PathForSource
40// tbd ExistentPathsForSources
41// PathForBazelOut PathForModuleOut
42//
43// Use cases:
44// * Module contains a property (often tagged `android:"path"`) that expects paths *relative to the
45// module directory*:
46// * BazelLabelForModuleSrcExcludes, if the module also contains an excludes_<propname> property
47// * BazelLabelForModuleSrc, otherwise
48// * Converting references to other modules to Bazel Labels:
49// BazelLabelForModuleDeps
50// * Converting a path obtained from bazel_handler cquery results:
51// PathForBazelOut
52//
53// NOTE: all Soong globs are expanded within Soong rather than being converted to a Bazel glob
54// syntax. This occurs because Soong does not have a concept of crossing package boundaries,
55// so the glob as computed by Soong may contain paths that cross package-boundaries. These
56// would be unknowingly omitted if the glob were handled by Bazel. By expanding globs within
57// Soong, we support identification and detection (within Bazel) use of paths that cross
58// package boundaries.
59//
60// Path resolution:
61// * filepath/globs: resolves as itself or is converted to an absolute Bazel label (e.g.
62// //path/to/dir:<filepath>) if path exists in a separate package or subpackage.
63// * references to other modules (using the ":name{.tag}" syntax). These resolve as a Bazel label
64// for a target. If the Bazel target is in the local module directory, it will be returned
65// relative to the current package (e.g. ":<target>"). Otherwise, it will be returned as an
66// absolute Bazel label (e.g. "//path/to/dir:<target>"). If the reference to another module
67// cannot be resolved,the function will panic. This is often due to the dependency not being added
68// via an AddDependency* method.
69
70// A subset of the ModuleContext methods which are sufficient to resolve references to paths/deps in
71// order to form a Bazel-compatible label for conversion.
72type BazelConversionPathContext interface {
73 EarlyModulePathContext
74
75 GetDirectDep(name string) (blueprint.Module, blueprint.DependencyTag)
Chris Parsons5a34ffb2021-07-21 14:34:58 -040076 ModuleFromName(name string) (blueprint.Module, bool)
Liz Kammer620dea62021-04-14 17:36:10 -040077 Module() Module
78 ModuleType() string
79 OtherModuleName(m blueprint.Module) string
80 OtherModuleDir(m blueprint.Module) string
81}
82
83// BazelLabelForModuleDeps expects a list of reference to other modules, ("<module>"
84// or ":<module>") and returns a Bazel-compatible label which corresponds to dependencies on the
85// module within the given ctx.
86func BazelLabelForModuleDeps(ctx BazelConversionPathContext, modules []string) bazel.LabelList {
Liz Kammer2d7bbe32021-06-10 18:20:06 -040087 return bazelLabelForModuleDeps(ctx, modules, false)
88}
89
90// BazelLabelForModuleWholeDeps expects a list of references to other modules, ("<module>"
91// or ":<module>") and returns a Bazel-compatible label which corresponds to dependencies on the
92// module within the given ctx, where prebuilt dependencies will be appended with _alwayslink so
93// they can be handled as whole static libraries.
94func BazelLabelForModuleWholeDeps(ctx BazelConversionPathContext, modules []string) bazel.LabelList {
95 return bazelLabelForModuleDeps(ctx, modules, true)
96}
97
98// BazelLabelForModuleDepsExcludes expects two lists: modules (containing modules to include in the
99// list), and excludes (modules to exclude from the list). Both of these should contain references
100// to other modules, ("<module>" or ":<module>"). It returns a Bazel-compatible label list which
101// corresponds to dependencies on the module within the given ctx, and the excluded dependencies.
102func BazelLabelForModuleDepsExcludes(ctx BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
103 return bazelLabelForModuleDepsExcludes(ctx, modules, excludes, false)
104}
105
106// BazelLabelForModuleWholeDepsExcludes expects two lists: modules (containing modules to include in
107// the list), and excludes (modules to exclude from the list). Both of these should contain
108// references to other modules, ("<module>" or ":<module>"). It returns a Bazel-compatible label
109// list which corresponds to dependencies on the module within the given ctx, and the excluded
110// dependencies. Prebuilt dependencies will be appended with _alwayslink so they can be handled as
111// whole static libraries.
112func BazelLabelForModuleWholeDepsExcludes(ctx BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
113 return bazelLabelForModuleDepsExcludes(ctx, modules, excludes, true)
114}
115
116func bazelLabelForModuleDeps(ctx BazelConversionPathContext, modules []string, isWholeLibs bool) bazel.LabelList {
Liz Kammer620dea62021-04-14 17:36:10 -0400117 var labels bazel.LabelList
118 for _, module := range modules {
119 bpText := module
120 if m := SrcIsModule(module); m == "" {
121 module = ":" + module
122 }
123 if m, t := SrcIsModuleWithTag(module); m != "" {
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400124 l := getOtherModuleLabel(ctx, m, t, isWholeLibs)
Jingwen Chen38e62642021-04-19 05:00:15 +0000125 l.OriginalModuleName = bpText
Liz Kammer620dea62021-04-14 17:36:10 -0400126 labels.Includes = append(labels.Includes, l)
127 } else {
128 ctx.ModuleErrorf("%q, is not a module reference", module)
129 }
130 }
131 return labels
132}
133
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400134func bazelLabelForModuleDepsExcludes(ctx BazelConversionPathContext, modules, excludes []string, isWholeLibs bool) bazel.LabelList {
135 moduleLabels := bazelLabelForModuleDeps(ctx, RemoveListFromList(modules, excludes), isWholeLibs)
Liz Kammer47535c52021-06-02 16:02:22 -0400136 if len(excludes) == 0 {
137 return moduleLabels
138 }
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400139 excludeLabels := bazelLabelForModuleDeps(ctx, excludes, isWholeLibs)
Liz Kammer47535c52021-06-02 16:02:22 -0400140 return bazel.LabelList{
141 Includes: moduleLabels.Includes,
142 Excludes: excludeLabels.Includes,
143 }
144}
145
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200146func BazelLabelForModuleSrcSingle(ctx BazelConversionPathContext, path string) bazel.Label {
147 return BazelLabelForModuleSrcExcludes(ctx, []string{path}, []string(nil)).Includes[0]
148}
149
Liz Kammer620dea62021-04-14 17:36:10 -0400150// BazelLabelForModuleSrc expects a list of path (relative to local module directory) and module
151// references (":<module>") and returns a bazel.LabelList{} containing the resolved references in
152// paths, relative to the local module, or Bazel-labels (absolute if in a different package or
153// relative if within the same package).
154// Properties must have been annotated with struct tag `android:"path"` so that dependencies modules
155// will have already been handled by the path_deps mutator.
156func BazelLabelForModuleSrc(ctx BazelConversionPathContext, paths []string) bazel.LabelList {
157 return BazelLabelForModuleSrcExcludes(ctx, paths, []string(nil))
158}
159
160// BazelLabelForModuleSrc expects lists of path and excludes (relative to local module directory)
161// and module references (":<module>") and returns a bazel.LabelList{} containing the resolved
162// references in paths, minus those in excludes, relative to the local module, or Bazel-labels
163// (absolute if in a different package or relative if within the same package).
164// Properties must have been annotated with struct tag `android:"path"` so that dependencies modules
165// will have already been handled by the path_deps mutator.
166func BazelLabelForModuleSrcExcludes(ctx BazelConversionPathContext, paths, excludes []string) bazel.LabelList {
167 excludeLabels := expandSrcsForBazel(ctx, excludes, []string(nil))
168 excluded := make([]string, 0, len(excludeLabels.Includes))
169 for _, e := range excludeLabels.Includes {
170 excluded = append(excluded, e.Label)
171 }
172 labels := expandSrcsForBazel(ctx, paths, excluded)
173 labels.Excludes = excludeLabels.Includes
174 labels = transformSubpackagePaths(ctx, labels)
175 return labels
176}
177
178// Returns true if a prefix + components[:i] + /Android.bp exists
179// TODO(b/185358476) Could check for BUILD file instead of checking for Android.bp file, or ensure BUILD is always generated?
180func directoryHasBlueprint(fs pathtools.FileSystem, prefix string, components []string, componentIndex int) bool {
181 blueprintPath := prefix
182 if blueprintPath != "" {
183 blueprintPath = blueprintPath + "/"
184 }
185 blueprintPath = blueprintPath + strings.Join(components[:componentIndex+1], "/")
186 blueprintPath = blueprintPath + "/Android.bp"
187 if exists, _, _ := fs.Exists(blueprintPath); exists {
188 return true
189 } else {
190 return false
191 }
192}
193
194// Transform a path (if necessary) to acknowledge package boundaries
195//
196// e.g. something like
197// async_safe/include/async_safe/CHECK.h
198// might become
199// //bionic/libc/async_safe:include/async_safe/CHECK.h
200// if the "async_safe" directory is actually a package and not just a directory.
201//
202// In particular, paths that extend into packages are transformed into absolute labels beginning with //.
203func transformSubpackagePath(ctx BazelConversionPathContext, path bazel.Label) bazel.Label {
204 var newPath bazel.Label
205
Jingwen Chen38e62642021-04-19 05:00:15 +0000206 // Don't transform OriginalModuleName
207 newPath.OriginalModuleName = path.OriginalModuleName
Liz Kammer620dea62021-04-14 17:36:10 -0400208
209 if strings.HasPrefix(path.Label, "//") {
210 // Assume absolute labels are already correct (e.g. //path/to/some/package:foo.h)
211 newPath.Label = path.Label
212 return newPath
213 }
214
215 newLabel := ""
216 pathComponents := strings.Split(path.Label, "/")
217 foundBlueprint := false
218 // Check the deepest subdirectory first and work upwards
219 for i := len(pathComponents) - 1; i >= 0; i-- {
220 pathComponent := pathComponents[i]
221 var sep string
222 if !foundBlueprint && directoryHasBlueprint(ctx.Config().fs, ctx.ModuleDir(), pathComponents, i) {
223 sep = ":"
224 foundBlueprint = true
225 } else {
226 sep = "/"
227 }
228 if newLabel == "" {
229 newLabel = pathComponent
230 } else {
231 newLabel = pathComponent + sep + newLabel
232 }
233 }
234 if foundBlueprint {
235 // Ensure paths end up looking like //bionic/... instead of //./bionic/...
236 moduleDir := ctx.ModuleDir()
237 if strings.HasPrefix(moduleDir, ".") {
238 moduleDir = moduleDir[1:]
239 }
240 // Make the path into an absolute label (e.g. //bionic/libc/foo:bar.h instead of just foo:bar.h)
241 if moduleDir == "" {
242 newLabel = "//" + newLabel
243 } else {
244 newLabel = "//" + moduleDir + "/" + newLabel
245 }
246 }
247 newPath.Label = newLabel
248
249 return newPath
250}
251
252// Transform paths to acknowledge package boundaries
253// See transformSubpackagePath() for more information
254func transformSubpackagePaths(ctx BazelConversionPathContext, paths bazel.LabelList) bazel.LabelList {
255 var newPaths bazel.LabelList
256 for _, include := range paths.Includes {
257 newPaths.Includes = append(newPaths.Includes, transformSubpackagePath(ctx, include))
258 }
259 for _, exclude := range paths.Excludes {
260 newPaths.Excludes = append(newPaths.Excludes, transformSubpackagePath(ctx, exclude))
261 }
262 return newPaths
263}
264
265// expandSrcsForBazel returns bazel.LabelList with paths rooted from the module's local source
266// directory and Bazel target labels, excluding those included in the excludes argument (which
267// should already be expanded to resolve references to Soong-modules). Valid elements of paths
268// include:
269// * filepath, relative to local module directory, resolves as a filepath relative to the local
270// source directory
271// * glob, relative to the local module directory, resolves as filepath(s), relative to the local
272// module directory. Because Soong does not have a concept of crossing package boundaries, the
273// glob as computed by Soong may contain paths that cross package-boundaries that would be
274// unknowingly omitted if the glob were handled by Bazel. To allow identification and detect
275// (within Bazel) use of paths that cross package boundaries, we expand globs within Soong rather
276// than converting Soong glob syntax to Bazel glob syntax. **Invalid for excludes.**
277// * other modules using the ":name{.tag}" syntax. These modules must implement SourceFileProducer
278// or OutputFileProducer. These resolve as a Bazel label for a target. If the Bazel target is in
279// the local module directory, it will be returned relative to the current package (e.g.
280// ":<target>"). Otherwise, it will be returned as an absolute Bazel label (e.g.
281// "//path/to/dir:<target>"). If the reference to another module cannot be resolved,the function
282// will panic.
283// Properties passed as the paths or excludes argument must have been annotated with struct tag
284// `android:"path"` so that dependencies on other modules will have already been handled by the
285// path_deps mutator.
286func expandSrcsForBazel(ctx BazelConversionPathContext, paths, expandedExcludes []string) bazel.LabelList {
287 if paths == nil {
288 return bazel.LabelList{}
289 }
290 labels := bazel.LabelList{
291 Includes: []bazel.Label{},
292 }
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000293
294 // expandedExcludes contain module-dir relative paths, but root-relative paths
295 // are needed for GlobFiles later.
296 var rootRelativeExpandedExcludes []string
297 for _, e := range expandedExcludes {
298 rootRelativeExpandedExcludes = append(rootRelativeExpandedExcludes, filepath.Join(ctx.ModuleDir(), e))
299 }
300
Liz Kammer620dea62021-04-14 17:36:10 -0400301 for _, p := range paths {
302 if m, tag := SrcIsModuleWithTag(p); m != "" {
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400303 l := getOtherModuleLabel(ctx, m, tag, false)
Liz Kammer620dea62021-04-14 17:36:10 -0400304 if !InList(l.Label, expandedExcludes) {
Jingwen Chen38e62642021-04-19 05:00:15 +0000305 l.OriginalModuleName = fmt.Sprintf(":%s", m)
Liz Kammer620dea62021-04-14 17:36:10 -0400306 labels.Includes = append(labels.Includes, l)
307 }
308 } else {
309 var expandedPaths []bazel.Label
310 if pathtools.IsGlob(p) {
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000311 // e.g. turn "math/*.c" in
312 // external/arm-optimized-routines to external/arm-optimized-routines/math/*.c
313 rootRelativeGlobPath := pathForModuleSrc(ctx, p).String()
314 globbedPaths := GlobFiles(ctx, rootRelativeGlobPath, rootRelativeExpandedExcludes)
Liz Kammer620dea62021-04-14 17:36:10 -0400315 globbedPaths = PathsWithModuleSrcSubDir(ctx, globbedPaths, "")
316 for _, path := range globbedPaths {
317 s := path.Rel()
318 expandedPaths = append(expandedPaths, bazel.Label{Label: s})
319 }
320 } else {
321 if !InList(p, expandedExcludes) {
322 expandedPaths = append(expandedPaths, bazel.Label{Label: p})
323 }
324 }
325 labels.Includes = append(labels.Includes, expandedPaths...)
326 }
327 }
328 return labels
329}
330
331// getOtherModuleLabel returns a bazel.Label for the given dependency/tag combination for the
332// module. The label will be relative to the current directory if appropriate. The dependency must
333// already be resolved by either deps mutator or path deps mutator.
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400334func getOtherModuleLabel(ctx BazelConversionPathContext, dep, tag string, isWholeLibs bool) bazel.Label {
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400335 m, _ := ctx.ModuleFromName(dep)
Liz Kammer620dea62021-04-14 17:36:10 -0400336 if m == nil {
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400337 panic(fmt.Errorf("No module named %q found, but was a direct dep of %q", dep, ctx.Module().Name()))
Liz Kammer620dea62021-04-14 17:36:10 -0400338 }
339 otherLabel := bazelModuleLabel(ctx, m, tag)
340 label := bazelModuleLabel(ctx, ctx.Module(), "")
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400341 if isWholeLibs {
342 if m, ok := m.(Module); ok && IsModulePrebuilt(m) {
343 otherLabel += "_alwayslink"
344 }
345 }
Liz Kammer620dea62021-04-14 17:36:10 -0400346 if samePackage(label, otherLabel) {
347 otherLabel = bazelShortLabel(otherLabel)
348 }
349
350 return bazel.Label{
351 Label: otherLabel,
352 }
353}
354
355func bazelModuleLabel(ctx BazelConversionPathContext, module blueprint.Module, tag string) string {
356 // TODO(b/165114590): Convert tag (":name{.tag}") to corresponding Bazel implicit output targets.
357 b, ok := module.(Bazelable)
358 // TODO(b/181155349): perhaps return an error here if the module can't be/isn't being converted
359 if !ok || !b.ConvertedToBazel(ctx) {
360 return bp2buildModuleLabel(ctx, module)
361 }
362 return b.GetBazelLabel(ctx, module)
363}
364
365func bazelShortLabel(label string) string {
366 i := strings.Index(label, ":")
367 return label[i:]
368}
369
370func bazelPackage(label string) string {
371 i := strings.Index(label, ":")
372 return label[0:i]
373}
374
375func samePackage(label1, label2 string) bool {
376 return bazelPackage(label1) == bazelPackage(label2)
377}
378
379func bp2buildModuleLabel(ctx BazelConversionPathContext, module blueprint.Module) string {
380 moduleName := ctx.OtherModuleName(module)
381 moduleDir := ctx.OtherModuleDir(module)
382 return fmt.Sprintf("//%s:%s", moduleDir, moduleName)
383}
384
385// BazelOutPath is a Bazel output path compatible to be used for mixed builds within Soong/Ninja.
386type BazelOutPath struct {
387 OutputPath
388}
389
390var _ Path = BazelOutPath{}
391var _ objPathProvider = BazelOutPath{}
392
393func (p BazelOutPath) objPathWithExt(ctx ModuleOutPathContext, subdir, ext string) ModuleObjPath {
394 return PathForModuleObj(ctx, subdir, pathtools.ReplaceExtension(p.path, ext))
395}
396
397// PathForBazelOut returns a Path representing the paths... under an output directory dedicated to
398// bazel-owned outputs.
399func PathForBazelOut(ctx PathContext, paths ...string) BazelOutPath {
400 execRootPathComponents := append([]string{"execroot", "__main__"}, paths...)
401 execRootPath := filepath.Join(execRootPathComponents...)
402 validatedExecRootPath, err := validatePath(execRootPath)
403 if err != nil {
404 reportPathError(ctx, err)
405 }
406
407 outputPath := OutputPath{basePath{"", ""},
408 ctx.Config().buildDir,
409 ctx.Config().BazelContext.OutputBase()}
410
411 return BazelOutPath{
412 OutputPath: outputPath.withRel(validatedExecRootPath),
413 }
414}
Liz Kammerb6a55bf2021-04-12 15:42:51 -0400415
416// PathsForBazelOut returns a list of paths representing the paths under an output directory
417// dedicated to Bazel-owned outputs.
418func PathsForBazelOut(ctx PathContext, paths []string) Paths {
419 outs := make(Paths, 0, len(paths))
420 for _, p := range paths {
421 outs = append(outs, PathForBazelOut(ctx, p))
422 }
423 return outs
424}