blob: 2154ec943ae720c761027a9c5aa8adfc4098cbcb [file] [log] [blame]
Colin Cross2207f872021-03-24 12:39:08 -07001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
18 "fmt"
19 "strings"
20
21 "github.com/google/blueprint/proptools"
22
23 "android/soong/android"
24 "android/soong/java/config"
25 "android/soong/remoteexec"
26)
27
28func init() {
29 RegisterStubsBuildComponents(android.InitRegistrationContext)
30}
31
32func RegisterStubsBuildComponents(ctx android.RegistrationContext) {
33 ctx.RegisterModuleType("stubs_defaults", StubsDefaultsFactory)
34
35 ctx.RegisterModuleType("droidstubs", DroidstubsFactory)
36 ctx.RegisterModuleType("droidstubs_host", DroidstubsHostFactory)
37
38 ctx.RegisterModuleType("prebuilt_stubs_sources", PrebuiltStubsSourcesFactory)
39}
40
41//
42// Droidstubs
43//
44type Droidstubs struct {
45 Javadoc
46 android.SdkBase
47
48 properties DroidstubsProperties
49 apiFile android.WritablePath
50 apiXmlFile android.WritablePath
51 lastReleasedApiXmlFile android.WritablePath
52 privateApiFile android.WritablePath
53 removedApiFile android.WritablePath
Colin Cross2207f872021-03-24 12:39:08 -070054 nullabilityWarningsFile android.WritablePath
55
56 checkCurrentApiTimestamp android.WritablePath
57 updateCurrentApiTimestamp android.WritablePath
58 checkLastReleasedApiTimestamp android.WritablePath
59 apiLintTimestamp android.WritablePath
60 apiLintReport android.WritablePath
61
62 checkNullabilityWarningsTimestamp android.WritablePath
63
64 annotationsZip android.WritablePath
65 apiVersionsXml android.WritablePath
66
67 apiFilePath android.Path
68 removedApiFilePath android.Path
69
70 metadataZip android.WritablePath
71 metadataDir android.WritablePath
72}
73
74type DroidstubsProperties struct {
75 // The generated public API filename by Metalava, defaults to <module>_api.txt
76 Api_filename *string
77
78 // the generated removed API filename by Metalava, defaults to <module>_removed.txt
79 Removed_api_filename *string
80
Colin Cross2207f872021-03-24 12:39:08 -070081 Check_api struct {
82 Last_released ApiToCheck
83
84 Current ApiToCheck
85
86 Api_lint struct {
87 Enabled *bool
88
89 // If set, performs api_lint on any new APIs not found in the given signature file
90 New_since *string `android:"path"`
91
92 // If not blank, path to the baseline txt file for approved API lint violations.
93 Baseline_file *string `android:"path"`
94 }
95 }
96
97 // user can specify the version of previous released API file in order to do compatibility check.
98 Previous_api *string `android:"path"`
99
100 // is set to true, Metalava will allow framework SDK to contain annotations.
101 Annotations_enabled *bool
102
103 // a list of top-level directories containing files to merge qualifier annotations (i.e. those intended to be included in the stubs written) from.
104 Merge_annotations_dirs []string
105
106 // a list of top-level directories containing Java stub files to merge show/hide annotations from.
107 Merge_inclusion_annotations_dirs []string
108
109 // a file containing a list of classes to do nullability validation for.
110 Validate_nullability_from_list *string
111
112 // a file containing expected warnings produced by validation of nullability annotations.
113 Check_nullability_warnings *string
114
115 // if set to true, allow Metalava to generate doc_stubs source files. Defaults to false.
116 Create_doc_stubs *bool
117
118 // if set to true, cause Metalava to output Javadoc comments in the stubs source files. Defaults to false.
119 // Has no effect if create_doc_stubs: true.
120 Output_javadoc_comments *bool
121
122 // if set to false then do not write out stubs. Defaults to true.
123 //
124 // TODO(b/146727827): Remove capability when we do not need to generate stubs and API separately.
125 Generate_stubs *bool
126
127 // if set to true, provides a hint to the build system that this rule uses a lot of memory,
128 // whicih can be used for scheduling purposes
129 High_mem *bool
130
131 // is set to true, Metalava will allow framework SDK to contain API levels annotations.
132 Api_levels_annotations_enabled *bool
133
134 // the dirs which Metalava extracts API levels annotations from.
135 Api_levels_annotations_dirs []string
136
137 // the filename which Metalava extracts API levels annotations from. Defaults to android.jar.
138 Api_levels_jar_filename *string
139
140 // if set to true, collect the values used by the Dev tools and
141 // write them in files packaged with the SDK. Defaults to false.
142 Write_sdk_values *bool
143}
144
Anton Hansson52609322021-05-05 10:36:05 +0100145// Used by xsd_config
146type ApiFilePath interface {
147 ApiFilePath() android.Path
148}
149
150type ApiStubsSrcProvider interface {
151 StubsSrcJar() android.Path
152}
153
154// Provider of information about API stubs, used by java_sdk_library.
155type ApiStubsProvider interface {
156 ApiFilePath
157 RemovedApiFilePath() android.Path
158
159 ApiStubsSrcProvider
160}
161
Colin Cross2207f872021-03-24 12:39:08 -0700162// droidstubs passes sources files through Metalava to generate stub .java files that only contain the API to be
163// documented, filtering out hidden classes and methods. The resulting .java files are intended to be passed to
164// a droiddoc module to generate documentation.
165func DroidstubsFactory() android.Module {
166 module := &Droidstubs{}
167
168 module.AddProperties(&module.properties,
169 &module.Javadoc.properties)
170
171 InitDroiddocModule(module, android.HostAndDeviceSupported)
172 android.InitSdkAwareModule(module)
173 return module
174}
175
176// droidstubs_host passes sources files through Metalava to generate stub .java files that only contain the API
177// to be documented, filtering out hidden classes and methods. The resulting .java files are intended to be
178// passed to a droiddoc_host module to generate documentation. Use a droidstubs_host instead of a droidstubs
179// module when symbols needed by the source files are provided by java_library_host modules.
180func DroidstubsHostFactory() android.Module {
181 module := &Droidstubs{}
182
183 module.AddProperties(&module.properties,
184 &module.Javadoc.properties)
185
186 InitDroiddocModule(module, android.HostSupported)
187 return module
188}
189
190func (d *Droidstubs) OutputFiles(tag string) (android.Paths, error) {
191 switch tag {
192 case "":
193 return android.Paths{d.stubsSrcJar}, nil
194 case ".docs.zip":
195 return android.Paths{d.docZip}, nil
196 case ".api.txt", android.DefaultDistTag:
197 // This is the default dist path for dist properties that have no tag property.
198 return android.Paths{d.apiFilePath}, nil
199 case ".removed-api.txt":
200 return android.Paths{d.removedApiFilePath}, nil
201 case ".annotations.zip":
202 return android.Paths{d.annotationsZip}, nil
203 case ".api_versions.xml":
204 return android.Paths{d.apiVersionsXml}, nil
205 default:
206 return nil, fmt.Errorf("unsupported module reference tag %q", tag)
207 }
208}
209
210func (d *Droidstubs) ApiFilePath() android.Path {
211 return d.apiFilePath
212}
213
214func (d *Droidstubs) RemovedApiFilePath() android.Path {
215 return d.removedApiFilePath
216}
217
218func (d *Droidstubs) StubsSrcJar() android.Path {
219 return d.stubsSrcJar
220}
221
222var metalavaMergeAnnotationsDirTag = dependencyTag{name: "metalava-merge-annotations-dir"}
223var metalavaMergeInclusionAnnotationsDirTag = dependencyTag{name: "metalava-merge-inclusion-annotations-dir"}
224var metalavaAPILevelsAnnotationsDirTag = dependencyTag{name: "metalava-api-levels-annotations-dir"}
225
226func (d *Droidstubs) DepsMutator(ctx android.BottomUpMutatorContext) {
227 d.Javadoc.addDeps(ctx)
228
229 if len(d.properties.Merge_annotations_dirs) != 0 {
230 for _, mergeAnnotationsDir := range d.properties.Merge_annotations_dirs {
231 ctx.AddDependency(ctx.Module(), metalavaMergeAnnotationsDirTag, mergeAnnotationsDir)
232 }
233 }
234
235 if len(d.properties.Merge_inclusion_annotations_dirs) != 0 {
236 for _, mergeInclusionAnnotationsDir := range d.properties.Merge_inclusion_annotations_dirs {
237 ctx.AddDependency(ctx.Module(), metalavaMergeInclusionAnnotationsDirTag, mergeInclusionAnnotationsDir)
238 }
239 }
240
241 if len(d.properties.Api_levels_annotations_dirs) != 0 {
242 for _, apiLevelsAnnotationsDir := range d.properties.Api_levels_annotations_dirs {
243 ctx.AddDependency(ctx.Module(), metalavaAPILevelsAnnotationsDirTag, apiLevelsAnnotationsDir)
244 }
245 }
246}
247
248func (d *Droidstubs) stubsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsDir android.OptionalPath) {
249 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
250 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") ||
251 String(d.properties.Api_filename) != "" {
252 filename := proptools.StringDefault(d.properties.Api_filename, ctx.ModuleName()+"_api.txt")
Colin Crosscb77f752021-03-24 12:04:44 -0700253 d.apiFile = android.PathForModuleOut(ctx, "metalava", filename)
Colin Cross2207f872021-03-24 12:39:08 -0700254 cmd.FlagWithOutput("--api ", d.apiFile)
255 d.apiFilePath = d.apiFile
256 } else if sourceApiFile := proptools.String(d.properties.Check_api.Current.Api_file); sourceApiFile != "" {
257 // If check api is disabled then make the source file available for export.
258 d.apiFilePath = android.PathForModuleSrc(ctx, sourceApiFile)
259 }
260
261 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
262 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") ||
263 String(d.properties.Removed_api_filename) != "" {
264 filename := proptools.StringDefault(d.properties.Removed_api_filename, ctx.ModuleName()+"_removed.txt")
Colin Crosscb77f752021-03-24 12:04:44 -0700265 d.removedApiFile = android.PathForModuleOut(ctx, "metalava", filename)
Colin Cross2207f872021-03-24 12:39:08 -0700266 cmd.FlagWithOutput("--removed-api ", d.removedApiFile)
267 d.removedApiFilePath = d.removedApiFile
268 } else if sourceRemovedApiFile := proptools.String(d.properties.Check_api.Current.Removed_api_file); sourceRemovedApiFile != "" {
269 // If check api is disabled then make the source removed api file available for export.
270 d.removedApiFilePath = android.PathForModuleSrc(ctx, sourceRemovedApiFile)
271 }
272
Colin Cross2207f872021-03-24 12:39:08 -0700273 if Bool(d.properties.Write_sdk_values) {
Colin Crosscb77f752021-03-24 12:04:44 -0700274 d.metadataDir = android.PathForModuleOut(ctx, "metalava", "metadata")
Colin Cross2207f872021-03-24 12:39:08 -0700275 cmd.FlagWithArg("--sdk-values ", d.metadataDir.String())
276 }
277
278 if stubsDir.Valid() {
279 if Bool(d.properties.Create_doc_stubs) {
280 cmd.FlagWithArg("--doc-stubs ", stubsDir.String())
281 } else {
282 cmd.FlagWithArg("--stubs ", stubsDir.String())
283 if !Bool(d.properties.Output_javadoc_comments) {
284 cmd.Flag("--exclude-documentation-from-stubs")
285 }
286 }
287 }
288}
289
290func (d *Droidstubs) annotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
291 if Bool(d.properties.Annotations_enabled) {
292 cmd.Flag("--include-annotations")
293
Andrei Onea4985e512021-04-29 16:29:34 +0100294 cmd.FlagWithArg("--exclude-annotation ", "androidx.annotation.RequiresApi")
295
Colin Cross2207f872021-03-24 12:39:08 -0700296 validatingNullability :=
Colin Crossbc139922021-03-25 18:33:16 -0700297 strings.Contains(String(d.Javadoc.properties.Args), "--validate-nullability-from-merged-stubs") ||
Colin Cross2207f872021-03-24 12:39:08 -0700298 String(d.properties.Validate_nullability_from_list) != ""
299
300 migratingNullability := String(d.properties.Previous_api) != ""
301 if migratingNullability {
302 previousApi := android.PathForModuleSrc(ctx, String(d.properties.Previous_api))
303 cmd.FlagWithInput("--migrate-nullness ", previousApi)
304 }
305
306 if s := String(d.properties.Validate_nullability_from_list); s != "" {
307 cmd.FlagWithInput("--validate-nullability-from-list ", android.PathForModuleSrc(ctx, s))
308 }
309
310 if validatingNullability {
Colin Crosscb77f752021-03-24 12:04:44 -0700311 d.nullabilityWarningsFile = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"_nullability_warnings.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700312 cmd.FlagWithOutput("--nullability-warnings-txt ", d.nullabilityWarningsFile)
313 }
314
Colin Crosscb77f752021-03-24 12:04:44 -0700315 d.annotationsZip = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"_annotations.zip")
Colin Cross2207f872021-03-24 12:39:08 -0700316 cmd.FlagWithOutput("--extract-annotations ", d.annotationsZip)
317
318 if len(d.properties.Merge_annotations_dirs) != 0 {
319 d.mergeAnnoDirFlags(ctx, cmd)
320 }
321
322 // TODO(tnorbye): find owners to fix these warnings when annotation was enabled.
323 cmd.FlagWithArg("--hide ", "HiddenTypedefConstant").
324 FlagWithArg("--hide ", "SuperfluousPrefix").
325 FlagWithArg("--hide ", "AnnotationExtraction")
326 }
327}
328
329func (d *Droidstubs) mergeAnnoDirFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
330 ctx.VisitDirectDepsWithTag(metalavaMergeAnnotationsDirTag, func(m android.Module) {
331 if t, ok := m.(*ExportedDroiddocDir); ok {
332 cmd.FlagWithArg("--merge-qualifier-annotations ", t.dir.String()).Implicits(t.deps)
333 } else {
334 ctx.PropertyErrorf("merge_annotations_dirs",
335 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
336 }
337 })
338}
339
340func (d *Droidstubs) inclusionAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
341 ctx.VisitDirectDepsWithTag(metalavaMergeInclusionAnnotationsDirTag, func(m android.Module) {
342 if t, ok := m.(*ExportedDroiddocDir); ok {
343 cmd.FlagWithArg("--merge-inclusion-annotations ", t.dir.String()).Implicits(t.deps)
344 } else {
345 ctx.PropertyErrorf("merge_inclusion_annotations_dirs",
346 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
347 }
348 })
349}
350
351func (d *Droidstubs) apiLevelsAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
352 if !Bool(d.properties.Api_levels_annotations_enabled) {
353 return
354 }
355
Colin Crosscb77f752021-03-24 12:04:44 -0700356 d.apiVersionsXml = android.PathForModuleOut(ctx, "metalava", "api-versions.xml")
Colin Cross2207f872021-03-24 12:39:08 -0700357
358 if len(d.properties.Api_levels_annotations_dirs) == 0 {
359 ctx.PropertyErrorf("api_levels_annotations_dirs",
360 "has to be non-empty if api levels annotations was enabled!")
361 }
362
363 cmd.FlagWithOutput("--generate-api-levels ", d.apiVersionsXml)
364 cmd.FlagWithInput("--apply-api-levels ", d.apiVersionsXml)
365 cmd.FlagWithArg("--current-version ", ctx.Config().PlatformSdkVersion().String())
366 cmd.FlagWithArg("--current-codename ", ctx.Config().PlatformSdkCodename())
367
368 filename := proptools.StringDefault(d.properties.Api_levels_jar_filename, "android.jar")
369
370 ctx.VisitDirectDepsWithTag(metalavaAPILevelsAnnotationsDirTag, func(m android.Module) {
371 if t, ok := m.(*ExportedDroiddocDir); ok {
372 for _, dep := range t.deps {
Colin Cross5f6ffc72021-03-29 21:54:45 -0700373 if dep.Base() == filename {
374 cmd.Implicit(dep)
375 }
376 if filename != "android.jar" && dep.Base() == "android.jar" {
377 // Metalava implicitly searches these patterns:
378 // prebuilts/tools/common/api-versions/android-%/android.jar
379 // prebuilts/sdk/%/public/android.jar
380 // Add android.jar files from the api_levels_annotations_dirs directories to try
381 // to satisfy these patterns. If Metalava can't find a match for an API level
382 // between 1 and 28 in at least one pattern it will fail.
Colin Cross2207f872021-03-24 12:39:08 -0700383 cmd.Implicit(dep)
384 }
385 }
386 cmd.FlagWithArg("--android-jar-pattern ", t.dir.String()+"/%/public/"+filename)
387 } else {
388 ctx.PropertyErrorf("api_levels_annotations_dirs",
389 "module %q is not a metalava api-levels-annotations dir", ctx.OtherModuleName(m))
390 }
391 })
392}
393
394func metalavaCmd(ctx android.ModuleContext, rule *android.RuleBuilder, javaVersion javaVersion, srcs android.Paths,
395 srcJarList android.Path, bootclasspath, classpath classpath, sourcepaths android.Paths,
Colin Cross8095c292021-03-30 16:40:48 -0700396 homeDir android.WritablePath) *android.RuleBuilderCommand {
Colin Cross2207f872021-03-24 12:39:08 -0700397 rule.Command().Text("rm -rf").Flag(homeDir.String())
398 rule.Command().Text("mkdir -p").Flag(homeDir.String())
399
400 cmd := rule.Command()
401 cmd.FlagWithArg("ANDROID_PREFS_ROOT=", homeDir.String())
402
403 if ctx.Config().UseRBE() && ctx.Config().IsEnvTrue("RBE_METALAVA") {
404 rule.Remoteable(android.RemoteRuleSupports{RBE: true})
Colin Cross8095c292021-03-30 16:40:48 -0700405 execStrategy := ctx.Config().GetenvWithDefault("RBE_METALAVA_EXEC_STRATEGY", remoteexec.LocalExecStrategy)
406 labels := map[string]string{"type": "tool", "name": "metalava"}
407 // TODO: metalava pool rejects these jobs
408 pool := ctx.Config().GetenvWithDefault("RBE_METALAVA_POOL", "java16")
409 rule.Rewrapper(&remoteexec.REParams{
410 Labels: labels,
411 ExecStrategy: execStrategy,
412 ToolchainInputs: []string{config.JavaCmd(ctx).String()},
413 Platform: map[string]string{remoteexec.PoolKey: pool},
414 })
Colin Cross2207f872021-03-24 12:39:08 -0700415 }
416
Colin Cross6aa5c402021-03-24 12:28:50 -0700417 cmd.BuiltTool("metalava").ImplicitTool(ctx.Config().HostJavaToolPath(ctx, "metalava.jar")).
Colin Cross2207f872021-03-24 12:39:08 -0700418 Flag(config.JavacVmFlags).
419 Flag("-J--add-opens=java.base/java.util=ALL-UNNAMED").
420 FlagWithArg("-encoding ", "UTF-8").
421 FlagWithArg("-source ", javaVersion.String()).
422 FlagWithRspFileInputList("@", android.PathForModuleOut(ctx, "metalava.rsp"), srcs).
423 FlagWithInput("@", srcJarList)
424
Colin Cross2207f872021-03-24 12:39:08 -0700425 if len(bootclasspath) > 0 {
426 cmd.FlagWithInputList("-bootclasspath ", bootclasspath.Paths(), ":")
427 }
428
429 if len(classpath) > 0 {
430 cmd.FlagWithInputList("-classpath ", classpath.Paths(), ":")
431 }
432
433 if len(sourcepaths) > 0 {
434 cmd.FlagWithList("-sourcepath ", sourcepaths.Strings(), ":")
435 } else {
436 cmd.FlagWithArg("-sourcepath ", `""`)
437 }
438
439 cmd.Flag("--no-banner").
440 Flag("--color").
441 Flag("--quiet").
442 Flag("--format=v2").
443 FlagWithArg("--repeat-errors-max ", "10").
444 FlagWithArg("--hide ", "UnresolvedImport")
445
446 return cmd
447}
448
449func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) {
450 deps := d.Javadoc.collectDeps(ctx)
451
Jiyong Parkf1691d22021-03-29 20:11:58 +0900452 javaVersion := getJavaVersion(ctx, String(d.Javadoc.properties.Java_version), android.SdkContext(d))
Colin Cross2207f872021-03-24 12:39:08 -0700453
454 // Create rule for metalava
455
Colin Crosscb77f752021-03-24 12:04:44 -0700456 srcJarDir := android.PathForModuleOut(ctx, "metalava", "srcjars")
Colin Cross2207f872021-03-24 12:39:08 -0700457
458 rule := android.NewRuleBuilder(pctx, ctx)
459
Colin Cross8095c292021-03-30 16:40:48 -0700460 rule.Sbox(android.PathForModuleOut(ctx, "metalava"),
461 android.PathForModuleOut(ctx, "metalava.sbox.textproto")).
462 SandboxInputs()
Colin Cross6aa5c402021-03-24 12:28:50 -0700463
Colin Cross2207f872021-03-24 12:39:08 -0700464 if BoolDefault(d.properties.High_mem, false) {
465 // This metalava run uses lots of memory, restrict the number of metalava jobs that can run in parallel.
466 rule.HighMem()
467 }
468
469 generateStubs := BoolDefault(d.properties.Generate_stubs, true)
470 var stubsDir android.OptionalPath
471 if generateStubs {
Colin Crosscb77f752021-03-24 12:04:44 -0700472 d.Javadoc.stubsSrcJar = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"-"+"stubs.srcjar")
473 stubsDir = android.OptionalPathForPath(android.PathForModuleOut(ctx, "metalava", "stubsDir"))
Colin Cross2207f872021-03-24 12:39:08 -0700474 rule.Command().Text("rm -rf").Text(stubsDir.String())
475 rule.Command().Text("mkdir -p").Text(stubsDir.String())
476 }
477
478 srcJarList := zipSyncCmd(ctx, rule, srcJarDir, d.Javadoc.srcJars)
479
Colin Crosscb77f752021-03-24 12:04:44 -0700480 homeDir := android.PathForModuleOut(ctx, "metalava", "home")
Colin Cross2207f872021-03-24 12:39:08 -0700481 cmd := metalavaCmd(ctx, rule, javaVersion, d.Javadoc.srcFiles, srcJarList,
Colin Cross8095c292021-03-30 16:40:48 -0700482 deps.bootClasspath, deps.classpath, d.Javadoc.sourcepaths, homeDir)
Colin Cross2207f872021-03-24 12:39:08 -0700483 cmd.Implicits(d.Javadoc.implicits)
484
485 d.stubsFlags(ctx, cmd, stubsDir)
486
487 d.annotationsFlags(ctx, cmd)
488 d.inclusionAnnotationsFlags(ctx, cmd)
489 d.apiLevelsAnnotationsFlags(ctx, cmd)
490
Colin Crossbc139922021-03-25 18:33:16 -0700491 d.expandArgs(ctx, cmd)
Colin Cross2207f872021-03-24 12:39:08 -0700492
Colin Cross2207f872021-03-24 12:39:08 -0700493 for _, o := range d.Javadoc.properties.Out {
494 cmd.ImplicitOutput(android.PathForModuleGen(ctx, o))
495 }
496
497 // Add options for the other optional tasks: API-lint and check-released.
498 // We generate separate timestamp files for them.
499
500 doApiLint := false
501 doCheckReleased := false
502
503 // Add API lint options.
504
505 if BoolDefault(d.properties.Check_api.Api_lint.Enabled, false) {
506 doApiLint = true
507
508 newSince := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.New_since)
509 if newSince.Valid() {
510 cmd.FlagWithInput("--api-lint ", newSince.Path())
511 } else {
512 cmd.Flag("--api-lint")
513 }
Colin Crosscb77f752021-03-24 12:04:44 -0700514 d.apiLintReport = android.PathForModuleOut(ctx, "metalava", "api_lint_report.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700515 cmd.FlagWithOutput("--report-even-if-suppressed ", d.apiLintReport) // TODO: Change to ":api-lint"
516
Colin Cross0d532412021-03-25 09:38:45 -0700517 // TODO(b/154317059): Clean up this allowlist by baselining and/or checking in last-released.
Colin Cross2207f872021-03-24 12:39:08 -0700518 if d.Name() != "android.car-system-stubs-docs" &&
519 d.Name() != "android.car-stubs-docs" {
520 cmd.Flag("--lints-as-errors")
521 cmd.Flag("--warnings-as-errors") // Most lints are actually warnings.
522 }
523
524 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.Baseline_file)
Colin Crosscb77f752021-03-24 12:04:44 -0700525 updatedBaselineOutput := android.PathForModuleOut(ctx, "metalava", "api_lint_baseline.txt")
526 d.apiLintTimestamp = android.PathForModuleOut(ctx, "metalava", "api_lint.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700527
528 // Note this string includes a special shell quote $' ... ', which decodes the "\n"s.
Colin Cross2207f872021-03-24 12:39:08 -0700529 //
530 // TODO: metalava also has a slightly different message hardcoded. Should we unify this
531 // message and metalava's one?
532 msg := `$'` + // Enclose with $' ... '
533 `************************************************************\n` +
534 `Your API changes are triggering API Lint warnings or errors.\n` +
535 `To make these errors go away, fix the code according to the\n` +
536 `error and/or warning messages above.\n` +
537 `\n` +
538 `If it is not possible to do so, there are workarounds:\n` +
539 `\n` +
540 `1. You can suppress the errors with @SuppressLint("<id>")\n`
541
542 if baselineFile.Valid() {
543 cmd.FlagWithInput("--baseline:api-lint ", baselineFile.Path())
544 cmd.FlagWithOutput("--update-baseline:api-lint ", updatedBaselineOutput)
545
546 msg += fmt.Sprintf(``+
547 `2. You can update the baseline by executing the following\n`+
548 ` command:\n`+
Colin Cross63eeda02021-04-15 19:01:57 -0700549 ` (cd $ANDROID_BUILD_TOP && cp \\\n`+
550 ` "%s" \\\n`+
551 ` "%s")\n`+
Colin Cross2207f872021-03-24 12:39:08 -0700552 ` To submit the revised baseline.txt to the main Android\n`+
553 ` repository, you will need approval.\n`, updatedBaselineOutput, baselineFile.Path())
554 } else {
555 msg += fmt.Sprintf(``+
556 `2. You can add a baseline file of existing lint failures\n`+
557 ` to the build rule of %s.\n`, d.Name())
558 }
559 // Note the message ends with a ' (single quote), to close the $' ... ' .
560 msg += `************************************************************\n'`
561
562 cmd.FlagWithArg("--error-message:api-lint ", msg)
563 }
564
565 // Add "check released" options. (Detect incompatible API changes from the last public release)
566
567 if apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") {
568 doCheckReleased = true
569
570 if len(d.Javadoc.properties.Out) > 0 {
571 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
572 }
573
574 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Last_released.Api_file))
575 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Last_released.Removed_api_file))
576 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Last_released.Baseline_file)
Colin Crosscb77f752021-03-24 12:04:44 -0700577 updatedBaselineOutput := android.PathForModuleOut(ctx, "metalava", "last_released_baseline.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700578
Colin Crosscb77f752021-03-24 12:04:44 -0700579 d.checkLastReleasedApiTimestamp = android.PathForModuleOut(ctx, "metalava", "check_last_released_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700580
581 cmd.FlagWithInput("--check-compatibility:api:released ", apiFile)
582 cmd.FlagWithInput("--check-compatibility:removed:released ", removedApiFile)
583
584 if baselineFile.Valid() {
585 cmd.FlagWithInput("--baseline:compatibility:released ", baselineFile.Path())
586 cmd.FlagWithOutput("--update-baseline:compatibility:released ", updatedBaselineOutput)
587 }
588
589 // Note this string includes quote ($' ... '), which decodes the "\n"s.
590 msg := `$'\n******************************\n` +
591 `You have tried to change the API from what has been previously released in\n` +
592 `an SDK. Please fix the errors listed above.\n` +
593 `******************************\n'`
594
595 cmd.FlagWithArg("--error-message:compatibility:released ", msg)
596 }
597
Colin Cross2207f872021-03-24 12:39:08 -0700598 if generateStubs {
599 rule.Command().
600 BuiltTool("soong_zip").
601 Flag("-write_if_changed").
602 Flag("-jar").
603 FlagWithOutput("-o ", d.Javadoc.stubsSrcJar).
604 FlagWithArg("-C ", stubsDir.String()).
605 FlagWithArg("-D ", stubsDir.String())
606 }
607
608 if Bool(d.properties.Write_sdk_values) {
Colin Crosscb77f752021-03-24 12:04:44 -0700609 d.metadataZip = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"-metadata.zip")
Colin Cross2207f872021-03-24 12:39:08 -0700610 rule.Command().
611 BuiltTool("soong_zip").
612 Flag("-write_if_changed").
613 Flag("-d").
614 FlagWithOutput("-o ", d.metadataZip).
615 FlagWithArg("-C ", d.metadataDir.String()).
616 FlagWithArg("-D ", d.metadataDir.String())
617 }
618
619 // TODO: We don't really need two separate API files, but this is a reminiscence of how
620 // we used to run metalava separately for API lint and the "last_released" check. Unify them.
621 if doApiLint {
622 rule.Command().Text("touch").Output(d.apiLintTimestamp)
623 }
624 if doCheckReleased {
625 rule.Command().Text("touch").Output(d.checkLastReleasedApiTimestamp)
626 }
627
Colin Cross6aa5c402021-03-24 12:28:50 -0700628 // TODO(b/183630617): rewrapper doesn't support restat rules
Colin Cross8095c292021-03-30 16:40:48 -0700629 // rule.Restat()
Colin Cross2207f872021-03-24 12:39:08 -0700630
631 zipSyncCleanupCmd(rule, srcJarDir)
632
633 rule.Build("metalava", "metalava merged")
634
635 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") {
636
637 if len(d.Javadoc.properties.Out) > 0 {
638 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
639 }
640
641 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Api_file))
642 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Removed_api_file))
643 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Current.Baseline_file)
644
645 if baselineFile.Valid() {
646 ctx.PropertyErrorf("baseline_file", "current API check can't have a baseline file. (module %s)", ctx.ModuleName())
647 }
648
Colin Crosscb77f752021-03-24 12:04:44 -0700649 d.checkCurrentApiTimestamp = android.PathForModuleOut(ctx, "metalava", "check_current_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700650
651 rule := android.NewRuleBuilder(pctx, ctx)
652
653 // Diff command line.
654 // -F matches the closest "opening" line, such as "package android {"
655 // and " public class Intent {".
656 diff := `diff -u -F '{ *$'`
657
658 rule.Command().Text("( true")
659 rule.Command().
660 Text(diff).
661 Input(apiFile).Input(d.apiFile)
662
663 rule.Command().
664 Text(diff).
665 Input(removedApiFile).Input(d.removedApiFile)
666
667 msg := fmt.Sprintf(`\n******************************\n`+
668 `You have tried to change the API from what has been previously approved.\n\n`+
669 `To make these errors go away, you have two choices:\n`+
670 ` 1. You can add '@hide' javadoc comments (and remove @SystemApi/@TestApi/etc)\n`+
671 ` to the new methods, etc. shown in the above diff.\n\n`+
672 ` 2. You can update current.txt and/or removed.txt by executing the following command:\n`+
673 ` m %s-update-current-api\n\n`+
674 ` To submit the revised current.txt to the main Android repository,\n`+
675 ` you will need approval.\n`+
676 `******************************\n`, ctx.ModuleName())
677
678 rule.Command().
679 Text("touch").Output(d.checkCurrentApiTimestamp).
680 Text(") || (").
681 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
682 Text("; exit 38").
683 Text(")")
684
685 rule.Build("metalavaCurrentApiCheck", "check current API")
686
Colin Crosscb77f752021-03-24 12:04:44 -0700687 d.updateCurrentApiTimestamp = android.PathForModuleOut(ctx, "metalava", "update_current_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700688
689 // update API rule
690 rule = android.NewRuleBuilder(pctx, ctx)
691
692 rule.Command().Text("( true")
693
694 rule.Command().
695 Text("cp").Flag("-f").
696 Input(d.apiFile).Flag(apiFile.String())
697
698 rule.Command().
699 Text("cp").Flag("-f").
700 Input(d.removedApiFile).Flag(removedApiFile.String())
701
702 msg = "failed to update public API"
703
704 rule.Command().
705 Text("touch").Output(d.updateCurrentApiTimestamp).
706 Text(") || (").
707 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
708 Text("; exit 38").
709 Text(")")
710
711 rule.Build("metalavaCurrentApiUpdate", "update current API")
712 }
713
714 if String(d.properties.Check_nullability_warnings) != "" {
715 if d.nullabilityWarningsFile == nil {
716 ctx.PropertyErrorf("check_nullability_warnings",
717 "Cannot specify check_nullability_warnings unless validating nullability")
718 }
719
720 checkNullabilityWarnings := android.PathForModuleSrc(ctx, String(d.properties.Check_nullability_warnings))
721
Colin Crosscb77f752021-03-24 12:04:44 -0700722 d.checkNullabilityWarningsTimestamp = android.PathForModuleOut(ctx, "metalava", "check_nullability_warnings.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700723
724 msg := fmt.Sprintf(`\n******************************\n`+
725 `The warnings encountered during nullability annotation validation did\n`+
726 `not match the checked in file of expected warnings. The diffs are shown\n`+
727 `above. You have two options:\n`+
728 ` 1. Resolve the differences by editing the nullability annotations.\n`+
729 ` 2. Update the file of expected warnings by running:\n`+
730 ` cp %s %s\n`+
731 ` and submitting the updated file as part of your change.`,
732 d.nullabilityWarningsFile, checkNullabilityWarnings)
733
734 rule := android.NewRuleBuilder(pctx, ctx)
735
736 rule.Command().
737 Text("(").
738 Text("diff").Input(checkNullabilityWarnings).Input(d.nullabilityWarningsFile).
739 Text("&&").
740 Text("touch").Output(d.checkNullabilityWarningsTimestamp).
741 Text(") || (").
742 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
743 Text("; exit 38").
744 Text(")")
745
746 rule.Build("nullabilityWarningsCheck", "nullability warnings check")
747 }
748}
749
750func StubsDefaultsFactory() android.Module {
751 module := &DocDefaults{}
752
753 module.AddProperties(
754 &JavadocProperties{},
755 &DroidstubsProperties{},
756 )
757
758 android.InitDefaultsModule(module)
759
760 return module
761}
762
763var _ android.PrebuiltInterface = (*PrebuiltStubsSources)(nil)
764
765type PrebuiltStubsSourcesProperties struct {
766 Srcs []string `android:"path"`
767}
768
769type PrebuiltStubsSources struct {
770 android.ModuleBase
771 android.DefaultableModuleBase
772 prebuilt android.Prebuilt
773 android.SdkBase
774
775 properties PrebuiltStubsSourcesProperties
776
777 stubsSrcJar android.ModuleOutPath
778}
779
780func (p *PrebuiltStubsSources) OutputFiles(tag string) (android.Paths, error) {
781 switch tag {
782 case "":
783 return android.Paths{p.stubsSrcJar}, nil
784 default:
785 return nil, fmt.Errorf("unsupported module reference tag %q", tag)
786 }
787}
788
789func (d *PrebuiltStubsSources) StubsSrcJar() android.Path {
790 return d.stubsSrcJar
791}
792
793func (p *PrebuiltStubsSources) GenerateAndroidBuildActions(ctx android.ModuleContext) {
794 p.stubsSrcJar = android.PathForModuleOut(ctx, ctx.ModuleName()+"-"+"stubs.srcjar")
795
796 if len(p.properties.Srcs) != 1 {
797 ctx.PropertyErrorf("srcs", "must only specify one directory path, contains %d paths", len(p.properties.Srcs))
798 return
799 }
800
801 localSrcDir := p.properties.Srcs[0]
802 // Although PathForModuleSrc can return nil if either the path doesn't exist or
803 // the path components are invalid it won't in this case because no components
804 // are specified and the module directory must exist in order to get this far.
805 srcDir := android.PathForModuleSrc(ctx).(android.SourcePath).Join(ctx, localSrcDir)
806
807 // Glob the contents of the directory just in case the directory does not exist.
808 srcGlob := localSrcDir + "/**/*"
809 srcPaths := android.PathsForModuleSrc(ctx, []string{srcGlob})
810
811 rule := android.NewRuleBuilder(pctx, ctx)
812 rule.Command().
813 BuiltTool("soong_zip").
814 Flag("-write_if_changed").
815 Flag("-jar").
816 FlagWithOutput("-o ", p.stubsSrcJar).
817 FlagWithArg("-C ", srcDir.String()).
818 FlagWithRspFileInputList("-r ", p.stubsSrcJar.ReplaceExtension(ctx, "rsp"), srcPaths)
819
820 rule.Restat()
821
822 rule.Build("zip src", "Create srcjar from prebuilt source")
823}
824
825func (p *PrebuiltStubsSources) Prebuilt() *android.Prebuilt {
826 return &p.prebuilt
827}
828
829func (p *PrebuiltStubsSources) Name() string {
830 return p.prebuilt.Name(p.ModuleBase.Name())
831}
832
833// prebuilt_stubs_sources imports a set of java source files as if they were
834// generated by droidstubs.
835//
836// By default, a prebuilt_stubs_sources has a single variant that expects a
837// set of `.java` files generated by droidstubs.
838//
839// Specifying `host_supported: true` will produce two variants, one for use as a dependency of device modules and one
840// for host modules.
841//
842// Intended only for use by sdk snapshots.
843func PrebuiltStubsSourcesFactory() android.Module {
844 module := &PrebuiltStubsSources{}
845
846 module.AddProperties(&module.properties)
847
848 android.InitPrebuiltModule(module, &module.properties.Srcs)
849 android.InitSdkAwareModule(module)
850 InitDroiddocModule(module, android.HostAndDeviceSupported)
851 return module
852}