Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 1 | // Copyright (c) 2014 The Chromium OS Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 5 | #include <algorithm> |
| 6 | #include <string> |
Alex Deymo | 94c0616 | 2014-03-21 20:34:46 -0700 | [diff] [blame] | 7 | #include <utility> |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 8 | #include <vector> |
| 9 | |
| 10 | #include <base/bind.h> |
Alex Deymo | 680d022 | 2014-04-24 21:00:08 -0700 | [diff] [blame] | 11 | #include <base/memory/scoped_ptr.h> |
Gilad Arnold | f62a4b8 | 2014-05-01 07:41:07 -0700 | [diff] [blame] | 12 | #include <base/time/time.h> |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 13 | #include <gmock/gmock.h> |
Alex Deymo | 1f01291 | 2014-04-24 19:08:04 -0700 | [diff] [blame] | 14 | #include <gtest/gtest.h> |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 15 | |
Alex Deymo | 41a75a7 | 2014-04-15 15:36:22 -0700 | [diff] [blame] | 16 | #include "update_engine/fake_clock.h" |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 17 | #include "update_engine/test_utils.h" |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 18 | #include "update_engine/update_manager/default_policy.h" |
| 19 | #include "update_engine/update_manager/fake_state.h" |
| 20 | #include "update_engine/update_manager/mock_policy.h" |
| 21 | #include "update_engine/update_manager/umtest_utils.h" |
| 22 | #include "update_engine/update_manager/update_manager.h" |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 23 | |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 24 | using base::Bind; |
| 25 | using base::Callback; |
Gilad Arnold | f62a4b8 | 2014-05-01 07:41:07 -0700 | [diff] [blame] | 26 | using base::Time; |
| 27 | using base::TimeDelta; |
Gilad Arnold | b3b0544 | 2014-05-30 14:25:05 -0700 | [diff] [blame] | 28 | using chromeos_update_engine::ErrorCode; |
Alex Deymo | 41a75a7 | 2014-04-15 15:36:22 -0700 | [diff] [blame] | 29 | using chromeos_update_engine::FakeClock; |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 30 | using std::pair; |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 31 | using std::string; |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 32 | using std::vector; |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 33 | using testing::Return; |
| 34 | using testing::StrictMock; |
Gilad Arnold | 5ef9c48 | 2014-03-03 13:51:02 -0800 | [diff] [blame] | 35 | using testing::_; |
| 36 | |
Gilad Arnold | f62a4b8 | 2014-05-01 07:41:07 -0700 | [diff] [blame] | 37 | namespace { |
| 38 | |
| 39 | // Generates a fixed timestamp for use in faking the current time. |
| 40 | Time FixedTime() { |
| 41 | Time::Exploded now_exp; |
| 42 | now_exp.year = 2014; |
| 43 | now_exp.month = 3; |
| 44 | now_exp.day_of_week = 2; |
| 45 | now_exp.day_of_month = 18; |
| 46 | now_exp.hour = 8; |
| 47 | now_exp.minute = 5; |
| 48 | now_exp.second = 33; |
| 49 | now_exp.millisecond = 675; |
| 50 | return Time::FromLocalExploded(now_exp); |
| 51 | } |
| 52 | |
| 53 | } // namespace |
| 54 | |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 55 | namespace chromeos_update_manager { |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 56 | |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 57 | class UmUpdateManagerTest : public ::testing::Test { |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 58 | protected: |
| 59 | virtual void SetUp() { |
Alex Deymo | 42c30c3 | 2014-04-24 18:41:18 -0700 | [diff] [blame] | 60 | fake_state_ = new FakeState(); |
Gilad Arnold | b227199 | 2014-06-19 12:35:24 -0700 | [diff] [blame] | 61 | umut_.reset(new UpdateManager(&fake_clock_, TimeDelta::FromSeconds(5), |
| 62 | fake_state_)); |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 63 | } |
| 64 | |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 65 | FakeState* fake_state_; // Owned by the umut_. |
Alex Deymo | 41a75a7 | 2014-04-15 15:36:22 -0700 | [diff] [blame] | 66 | FakeClock fake_clock_; |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 67 | scoped_ptr<UpdateManager> umut_; |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 68 | }; |
| 69 | |
| 70 | // The FailingPolicy implements a single method and make it always fail. This |
| 71 | // class extends the DefaultPolicy class to allow extensions of the Policy |
| 72 | // class without extending nor changing this test. |
| 73 | class FailingPolicy : public DefaultPolicy { |
Alex Deymo | 2de23f5 | 2014-02-26 14:30:13 -0800 | [diff] [blame] | 74 | virtual EvalStatus UpdateCheckAllowed(EvaluationContext* ec, State* state, |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 75 | string* error, |
Alex Deymo | 0d11c60 | 2014-04-23 20:12:20 -0700 | [diff] [blame] | 76 | UpdateCheckParams* result) const { |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 77 | *error = "FailingPolicy failed."; |
Alex Deymo | e636c3c | 2014-03-11 19:02:08 -0700 | [diff] [blame] | 78 | return EvalStatus::kFailed; |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 79 | } |
| 80 | }; |
| 81 | |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 82 | // The LazyPolicy always returns EvalStatus::kAskMeAgainLater. |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 83 | class LazyPolicy : public DefaultPolicy { |
Alex Deymo | 2de23f5 | 2014-02-26 14:30:13 -0800 | [diff] [blame] | 84 | virtual EvalStatus UpdateCheckAllowed(EvaluationContext* ec, State* state, |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 85 | string* error, |
Alex Deymo | 0d11c60 | 2014-04-23 20:12:20 -0700 | [diff] [blame] | 86 | UpdateCheckParams* result) const { |
Alex Deymo | e636c3c | 2014-03-11 19:02:08 -0700 | [diff] [blame] | 87 | return EvalStatus::kAskMeAgainLater; |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 88 | } |
| 89 | }; |
| 90 | |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 91 | // AccumulateCallsCallback() adds to the passed |acc| accumulator vector pairs |
| 92 | // of EvalStatus and T instances. This allows to create a callback that keeps |
| 93 | // track of when it is called and the arguments passed to it, to be used with |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 94 | // the UpdateManager::AsyncPolicyRequest(). |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 95 | template<typename T> |
| 96 | static void AccumulateCallsCallback(vector<pair<EvalStatus, T>>* acc, |
| 97 | EvalStatus status, const T& result) { |
| 98 | acc->push_back(std::make_pair(status, result)); |
| 99 | } |
| 100 | |
Alex Deymo | 0d11c60 | 2014-04-23 20:12:20 -0700 | [diff] [blame] | 101 | // Tests that policy requests are completed successfully. It is important that |
| 102 | // this tests cover all policy requests as defined in Policy. |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 103 | TEST_F(UmUpdateManagerTest, PolicyRequestCallUpdateCheckAllowed) { |
Alex Deymo | 0d11c60 | 2014-04-23 20:12:20 -0700 | [diff] [blame] | 104 | UpdateCheckParams result; |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 105 | EXPECT_EQ(EvalStatus::kSucceeded, umut_->PolicyRequest( |
Alex Deymo | 0d11c60 | 2014-04-23 20:12:20 -0700 | [diff] [blame] | 106 | &Policy::UpdateCheckAllowed, &result)); |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 107 | } |
| 108 | |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 109 | TEST_F(UmUpdateManagerTest, PolicyRequestCallUpdateCanStart) { |
Gilad Arnold | f62a4b8 | 2014-05-01 07:41:07 -0700 | [diff] [blame] | 110 | const UpdateState update_state = { |
Gilad Arnold | b3b0544 | 2014-05-30 14:25:05 -0700 | [diff] [blame] | 111 | FixedTime(), 1, |
| 112 | vector<string>(1, "http://fake/url/"), 10, 0, 0, vector<ErrorCode>(), |
| 113 | TimeDelta::FromSeconds(15), TimeDelta::FromSeconds(60), |
Gilad Arnold | f62a4b8 | 2014-05-01 07:41:07 -0700 | [diff] [blame] | 114 | 4, 2, 8 |
| 115 | }; |
Gilad Arnold | 42f253b | 2014-06-25 12:39:17 -0700 | [diff] [blame^] | 116 | UpdateDownloadParams result; |
Gilad Arnold | f62a4b8 | 2014-05-01 07:41:07 -0700 | [diff] [blame] | 117 | EXPECT_EQ(EvalStatus::kSucceeded, |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 118 | umut_->PolicyRequest(&Policy::UpdateCanStart, &result, true, |
Gilad Arnold | f62a4b8 | 2014-05-01 07:41:07 -0700 | [diff] [blame] | 119 | update_state)); |
| 120 | } |
| 121 | |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 122 | TEST_F(UmUpdateManagerTest, PolicyRequestCallsDefaultOnError) { |
| 123 | umut_->set_policy(new FailingPolicy()); |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 124 | |
| 125 | // Tests that the DefaultPolicy instance is called when the method fails, |
| 126 | // which will set this as true. |
Alex Deymo | 0d11c60 | 2014-04-23 20:12:20 -0700 | [diff] [blame] | 127 | UpdateCheckParams result; |
| 128 | result.updates_enabled = false; |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 129 | EvalStatus status = umut_->PolicyRequest( |
Alex Deymo | 680d022 | 2014-04-24 21:00:08 -0700 | [diff] [blame] | 130 | &Policy::UpdateCheckAllowed, &result); |
Gilad Arnold | af2f6ae | 2014-04-28 14:14:52 -0700 | [diff] [blame] | 131 | EXPECT_EQ(EvalStatus::kSucceeded, status); |
Alex Deymo | 0d11c60 | 2014-04-23 20:12:20 -0700 | [diff] [blame] | 132 | EXPECT_TRUE(result.updates_enabled); |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 133 | } |
| 134 | |
Gilad Arnold | 897b5e5 | 2014-05-21 09:37:18 -0700 | [diff] [blame] | 135 | // This test only applies to debug builds where DCHECK is enabled. |
| 136 | #if DCHECK_IS_ON |
| 137 | TEST_F(UmUpdateManagerTest, PolicyRequestDoesntBlockDeathTest) { |
| 138 | // The update manager should die (DCHECK) if a policy called synchronously |
| 139 | // returns a kAskMeAgainLater value. |
Alex Deymo | 0d11c60 | 2014-04-23 20:12:20 -0700 | [diff] [blame] | 140 | UpdateCheckParams result; |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 141 | umut_->set_policy(new LazyPolicy()); |
Gilad Arnold | 897b5e5 | 2014-05-21 09:37:18 -0700 | [diff] [blame] | 142 | EXPECT_DEATH(umut_->PolicyRequest(&Policy::UpdateCheckAllowed, &result), ""); |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 143 | } |
Gilad Arnold | 897b5e5 | 2014-05-21 09:37:18 -0700 | [diff] [blame] | 144 | #endif // DCHECK_IS_ON |
Alex Deymo | c705cc8 | 2014-02-19 11:15:00 -0800 | [diff] [blame] | 145 | |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 146 | TEST_F(UmUpdateManagerTest, AsyncPolicyRequestDelaysEvaluation) { |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 147 | // To avoid differences in code execution order between an AsyncPolicyRequest |
| 148 | // call on a policy that returns AskMeAgainLater the first time and one that |
| 149 | // succeeds the first time, we ensure that the passed callback is called from |
| 150 | // the main loop in both cases even when we could evaluate it right now. |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 151 | umut_->set_policy(new FailingPolicy()); |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 152 | |
Alex Deymo | 0d11c60 | 2014-04-23 20:12:20 -0700 | [diff] [blame] | 153 | vector<pair<EvalStatus, UpdateCheckParams>> calls; |
| 154 | Callback<void(EvalStatus, const UpdateCheckParams& result)> callback = |
| 155 | Bind(AccumulateCallsCallback<UpdateCheckParams>, &calls); |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 156 | |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 157 | umut_->AsyncPolicyRequest(callback, &Policy::UpdateCheckAllowed); |
Alex Deymo | 7b948f0 | 2014-03-10 17:01:10 -0700 | [diff] [blame] | 158 | // The callback should wait until we run the main loop for it to be executed. |
| 159 | EXPECT_EQ(0, calls.size()); |
| 160 | chromeos_update_engine::RunGMainLoopMaxIterations(100); |
| 161 | EXPECT_EQ(1, calls.size()); |
| 162 | } |
| 163 | |
Alex Deymo | 63784a5 | 2014-05-28 10:46:14 -0700 | [diff] [blame] | 164 | } // namespace chromeos_update_manager |