Alex Deymo | aea4c1c | 2015-08-19 20:24:43 -0700 | [diff] [blame] | 1 | // |
| 2 | // Copyright (C) 2012 The Android Open Source Project |
| 3 | // |
| 4 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | // you may not use this file except in compliance with the License. |
| 6 | // You may obtain a copy of the License at |
| 7 | // |
| 8 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | // |
| 10 | // Unless required by applicable law or agreed to in writing, software |
| 11 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | // See the License for the specific language governing permissions and |
| 14 | // limitations under the License. |
| 15 | // |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 16 | |
Alex Deymo | 39910dc | 2015-11-09 17:04:30 -0800 | [diff] [blame] | 17 | #include "update_engine/common/subprocess.h" |
Darin Petkov | a0b9e77 | 2011-10-06 05:05:56 -0700 | [diff] [blame] | 18 | |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 19 | #include <fcntl.h> |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 20 | #include <stdlib.h> |
| 21 | #include <string.h> |
Kenneth Waters | a7fcafa | 2010-09-21 10:27:03 -0700 | [diff] [blame] | 22 | #include <unistd.h> |
Darin Petkov | a0b9e77 | 2011-10-06 05:05:56 -0700 | [diff] [blame] | 23 | |
Kelvin Zhang | 866d470 | 2023-10-24 12:37:35 -0700 | [diff] [blame] | 24 | #include <chrono> |
Ben Chan | 02f7c1d | 2014-10-18 15:18:02 -0700 | [diff] [blame] | 25 | #include <memory> |
Darin Petkov | a0b9e77 | 2011-10-06 05:05:56 -0700 | [diff] [blame] | 26 | #include <string> |
Amin Hassani | a885954 | 2018-03-07 16:24:43 -0800 | [diff] [blame] | 27 | #include <utility> |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 28 | #include <vector> |
Darin Petkov | a0b9e77 | 2011-10-06 05:05:56 -0700 | [diff] [blame] | 29 | |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 30 | #include <base/bind.h> |
Darin Petkov | a0b9e77 | 2011-10-06 05:05:56 -0700 | [diff] [blame] | 31 | #include <base/logging.h> |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 32 | #include <base/posix/eintr_wrapper.h> |
Kelvin Zhang | b9a9aa2 | 2024-10-15 10:38:35 -0700 | [diff] [blame] | 33 | #include <android-base/stringprintf.h> |
Alex Vakulenko | 3f39d5c | 2015-10-13 09:27:13 -0700 | [diff] [blame] | 34 | #include <brillo/secure_blob.h> |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 35 | |
Alex Deymo | 0d29854 | 2016-03-30 18:31:49 -0700 | [diff] [blame] | 36 | #include "update_engine/common/utils.h" |
| 37 | |
Alex Vakulenko | 3f39d5c | 2015-10-13 09:27:13 -0700 | [diff] [blame] | 38 | using brillo::MessageLoop; |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 39 | using std::string; |
Ben Chan | 02f7c1d | 2014-10-18 15:18:02 -0700 | [diff] [blame] | 40 | using std::unique_ptr; |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 41 | using std::vector; |
| 42 | |
| 43 | namespace chromeos_update_engine { |
| 44 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 45 | namespace { |
Darin Petkov | 6f03a3b | 2010-11-10 14:27:14 -0800 | [diff] [blame] | 46 | |
Alex Deymo | 109c28d | 2016-04-05 23:00:52 +0000 | [diff] [blame] | 47 | bool SetupChild(const std::map<string, string>& env, uint32_t flags) { |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 48 | // Setup the environment variables. |
| 49 | clearenv(); |
Kelvin Zhang | 866d470 | 2023-10-24 12:37:35 -0700 | [diff] [blame] | 50 | if (setpgid(0, 0) != 0) { |
| 51 | PLOG(ERROR) << "Failed to setpgid on subprocess " << getpid(); |
| 52 | return false; |
| 53 | } |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 54 | for (const auto& key_value : env) { |
| 55 | setenv(key_value.first.c_str(), key_value.second.c_str(), 0); |
| 56 | } |
Darin Petkov | 6f03a3b | 2010-11-10 14:27:14 -0800 | [diff] [blame] | 57 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 58 | if ((flags & Subprocess::kRedirectStderrToStdout) != 0) { |
| 59 | if (HANDLE_EINTR(dup2(STDOUT_FILENO, STDERR_FILENO)) != STDERR_FILENO) |
| 60 | return false; |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 61 | } |
Andrew de los Reyes | c1d5c93 | 2011-04-20 17:15:47 -0700 | [diff] [blame] | 62 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 63 | int fd = HANDLE_EINTR(open("/dev/null", O_RDONLY)); |
| 64 | if (fd < 0) |
| 65 | return false; |
| 66 | if (HANDLE_EINTR(dup2(fd, STDIN_FILENO)) != STDIN_FILENO) |
| 67 | return false; |
| 68 | IGNORE_EINTR(close(fd)); |
| 69 | |
| 70 | return true; |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 71 | } |
| 72 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 73 | // Helper function to launch a process with the given Subprocess::Flags. |
| 74 | // This function only sets up and starts the process according to the |flags|. |
| 75 | // The caller is responsible for watching the termination of the subprocess. |
| 76 | // Return whether the process was successfully launched and fills in the |proc| |
| 77 | // Process. |
| 78 | bool LaunchProcess(const vector<string>& cmd, |
| 79 | uint32_t flags, |
Alex Deymo | e384bb2 | 2016-03-29 17:23:33 -0700 | [diff] [blame] | 80 | const vector<int>& output_pipes, |
Alex Vakulenko | 3f39d5c | 2015-10-13 09:27:13 -0700 | [diff] [blame] | 81 | brillo::Process* proc) { |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 82 | for (const string& arg : cmd) |
| 83 | proc->AddArg(arg); |
| 84 | proc->SetSearchPath((flags & Subprocess::kSearchPath) != 0); |
| 85 | |
| 86 | // Create an environment for the child process with just the required PATHs. |
| 87 | std::map<string, string> env; |
| 88 | for (const char* key : {"LD_LIBRARY_PATH", "PATH"}) { |
| 89 | const char* value = getenv(key); |
| 90 | if (value) |
| 91 | env.emplace(key, value); |
| 92 | } |
| 93 | |
Alex Deymo | e384bb2 | 2016-03-29 17:23:33 -0700 | [diff] [blame] | 94 | for (const int fd : output_pipes) { |
| 95 | proc->RedirectUsingPipe(fd, false); |
| 96 | } |
| 97 | proc->SetCloseUnusedFileDescriptors(true); |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 98 | proc->RedirectUsingPipe(STDOUT_FILENO, false); |
Alex Deymo | 109c28d | 2016-04-05 23:00:52 +0000 | [diff] [blame] | 99 | proc->SetPreExecCallback(base::Bind(&SetupChild, env, flags)); |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 100 | |
Kelvin Zhang | 0c18424 | 2024-10-25 11:19:27 -0700 | [diff] [blame^] | 101 | LOG(INFO) << "Running \"" << android::base::Join(cmd, " ") << "\""; |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 102 | return proc->Start(); |
| 103 | } |
| 104 | |
| 105 | } // namespace |
| 106 | |
Alex Deymo | b7ca096 | 2014-10-01 17:58:07 -0700 | [diff] [blame] | 107 | void Subprocess::Init( |
Amin Hassani | b268959 | 2019-01-13 17:04:28 -0800 | [diff] [blame] | 108 | brillo::AsynchronousSignalHandlerInterface* async_signal_handler) { |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 109 | if (subprocess_singleton_ == this) |
| 110 | return; |
| 111 | CHECK(subprocess_singleton_ == nullptr); |
| 112 | subprocess_singleton_ = this; |
| 113 | |
Alex Deymo | b7ca096 | 2014-10-01 17:58:07 -0700 | [diff] [blame] | 114 | process_reaper_.Register(async_signal_handler); |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 115 | } |
| 116 | |
| 117 | Subprocess::~Subprocess() { |
| 118 | if (subprocess_singleton_ == this) |
| 119 | subprocess_singleton_ = nullptr; |
Kenneth Waters | a7fcafa | 2010-09-21 10:27:03 -0700 | [diff] [blame] | 120 | } |
| 121 | |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 122 | void Subprocess::OnStdoutReady(SubprocessRecord* record) { |
Darin Petkov | 6f03a3b | 2010-11-10 14:27:14 -0800 | [diff] [blame] | 123 | char buf[1024]; |
Alex Deymo | 0d29854 | 2016-03-30 18:31:49 -0700 | [diff] [blame] | 124 | size_t bytes_read; |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 125 | do { |
Alex Deymo | 0d29854 | 2016-03-30 18:31:49 -0700 | [diff] [blame] | 126 | bytes_read = 0; |
| 127 | bool eof; |
| 128 | bool ok = utils::ReadAll( |
Kokoa Matsuda | 91aa217 | 2024-10-16 16:01:04 +0900 | [diff] [blame] | 129 | record->stdout_fd, buf, std::size(buf), &bytes_read, &eof); |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 130 | record->stdout_str.append(buf, bytes_read); |
Alex Deymo | 0d29854 | 2016-03-30 18:31:49 -0700 | [diff] [blame] | 131 | if (!ok || eof) { |
| 132 | // There was either an error or an EOF condition, so we are done watching |
| 133 | // the file descriptor. |
Hidehiko Abe | 493fecb | 2019-07-10 23:30:50 +0900 | [diff] [blame] | 134 | record->stdout_controller.reset(); |
Alex Deymo | 0d29854 | 2016-03-30 18:31:49 -0700 | [diff] [blame] | 135 | return; |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 136 | } |
Alex Deymo | 0d29854 | 2016-03-30 18:31:49 -0700 | [diff] [blame] | 137 | } while (bytes_read); |
Darin Petkov | 6f03a3b | 2010-11-10 14:27:14 -0800 | [diff] [blame] | 138 | } |
| 139 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 140 | void Subprocess::ChildExitedCallback(const siginfo_t& info) { |
| 141 | auto pid_record = subprocess_records_.find(info.si_pid); |
| 142 | if (pid_record == subprocess_records_.end()) |
| 143 | return; |
| 144 | SubprocessRecord* record = pid_record->second.get(); |
| 145 | |
| 146 | // Make sure we read any remaining process output and then close the pipe. |
| 147 | OnStdoutReady(record); |
| 148 | |
Hidehiko Abe | 493fecb | 2019-07-10 23:30:50 +0900 | [diff] [blame] | 149 | record->stdout_controller.reset(); |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 150 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 151 | // Don't print any log if the subprocess exited with exit code 0. |
| 152 | if (info.si_code != CLD_EXITED) { |
Kelvin Zhang | 866d470 | 2023-10-24 12:37:35 -0700 | [diff] [blame] | 153 | LOG(INFO) << "Subprocess " << info.si_pid << " terminated with si_code " |
| 154 | << info.si_code; |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 155 | } else if (info.si_status != 0) { |
Kelvin Zhang | 866d470 | 2023-10-24 12:37:35 -0700 | [diff] [blame] | 156 | LOG(INFO) << "Subprocess " << info.si_pid |
| 157 | << " exited with si_status: " << info.si_status; |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 158 | } |
Andrew de los Reyes | 3270f74 | 2010-07-15 22:28:14 -0700 | [diff] [blame] | 159 | |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 160 | if (!record->stdout_str.empty()) { |
| 161 | LOG(INFO) << "Subprocess output:\n" << record->stdout_str; |
Andrew de los Reyes | 3270f74 | 2010-07-15 22:28:14 -0700 | [diff] [blame] | 162 | } |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 163 | if (!record->callback.is_null()) { |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 164 | record->callback.Run(info.si_status, record->stdout_str); |
Andrew de los Reyes | 3270f74 | 2010-07-15 22:28:14 -0700 | [diff] [blame] | 165 | } |
Alex Deymo | e384bb2 | 2016-03-29 17:23:33 -0700 | [diff] [blame] | 166 | // Release and close all the pipes after calling the callback so our |
| 167 | // redirected pipes are still alive. Releasing the process first makes |
| 168 | // Reset(0) not attempt to kill the process, which is already a zombie at this |
| 169 | // point. |
| 170 | record->proc.Release(); |
| 171 | record->proc.Reset(0); |
| 172 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 173 | subprocess_records_.erase(pid_record); |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 174 | } |
| 175 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 176 | pid_t Subprocess::Exec(const vector<string>& cmd, |
| 177 | const ExecCallback& callback) { |
Alex Deymo | 109c28d | 2016-04-05 23:00:52 +0000 | [diff] [blame] | 178 | return ExecFlags(cmd, kRedirectStderrToStdout, {}, callback); |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 179 | } |
Andrew de los Reyes | 08c4e27 | 2010-04-15 14:02:17 -0700 | [diff] [blame] | 180 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 181 | pid_t Subprocess::ExecFlags(const vector<string>& cmd, |
| 182 | uint32_t flags, |
Alex Deymo | e384bb2 | 2016-03-29 17:23:33 -0700 | [diff] [blame] | 183 | const vector<int>& output_pipes, |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 184 | const ExecCallback& callback) { |
| 185 | unique_ptr<SubprocessRecord> record(new SubprocessRecord(callback)); |
| 186 | |
Alex Deymo | 109c28d | 2016-04-05 23:00:52 +0000 | [diff] [blame] | 187 | if (!LaunchProcess(cmd, flags, output_pipes, &record->proc)) { |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 188 | LOG(ERROR) << "Failed to launch subprocess"; |
Chris Masone | c6c57a5 | 2010-09-23 13:06:14 -0700 | [diff] [blame] | 189 | return 0; |
| 190 | } |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 191 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 192 | pid_t pid = record->proc.pid(); |
Amin Hassani | b268959 | 2019-01-13 17:04:28 -0800 | [diff] [blame] | 193 | CHECK(process_reaper_.WatchForChild( |
| 194 | FROM_HERE, |
| 195 | pid, |
| 196 | base::Bind(&Subprocess::ChildExitedCallback, base::Unretained(this)))); |
Darin Petkov | 6f03a3b | 2010-11-10 14:27:14 -0800 | [diff] [blame] | 197 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 198 | record->stdout_fd = record->proc.GetPipe(STDOUT_FILENO); |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 199 | // Capture the subprocess output. Make our end of the pipe non-blocking. |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 200 | int fd_flags = fcntl(record->stdout_fd, F_GETFL, 0) | O_NONBLOCK; |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 201 | if (HANDLE_EINTR(fcntl(record->stdout_fd, F_SETFL, fd_flags)) < 0) { |
| 202 | LOG(ERROR) << "Unable to set non-blocking I/O mode on fd " |
| 203 | << record->stdout_fd << "."; |
| 204 | } |
| 205 | |
Hidehiko Abe | 493fecb | 2019-07-10 23:30:50 +0900 | [diff] [blame] | 206 | record->stdout_controller = base::FileDescriptorWatcher::WatchReadable( |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 207 | record->stdout_fd, |
Hidehiko Abe | 493fecb | 2019-07-10 23:30:50 +0900 | [diff] [blame] | 208 | base::BindRepeating(&Subprocess::OnStdoutReady, record.get())); |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 209 | |
Alex Vakulenko | ce8c8ee | 2016-04-08 08:59:26 -0700 | [diff] [blame] | 210 | subprocess_records_[pid] = std::move(record); |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 211 | return pid; |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 212 | } |
| 213 | |
Kelvin Zhang | 866d470 | 2023-10-24 12:37:35 -0700 | [diff] [blame] | 214 | bool WaitForProcessGroup(pid_t pid, std::chrono::milliseconds timeout) { |
| 215 | using std::chrono::system_clock; |
| 216 | auto start = system_clock::now(); |
| 217 | do { |
| 218 | pid_t w = waitpid(-pid, nullptr, WNOHANG); |
| 219 | if (w < 0) { |
| 220 | // When all of the child process with this process group ID exits, waitpid |
| 221 | // will return ECHILD. Until that point, keep callilng waitpid() as there |
| 222 | // might be multiple child processes with the same process group id. |
| 223 | if (errno == ECHILD) { |
| 224 | LOG(INFO) << "All processes with process group id " << pid << " exited"; |
| 225 | return true; |
| 226 | } |
| 227 | PLOG(ERROR) << "Waitpid returned " << w; |
| 228 | return false; |
| 229 | } |
| 230 | usleep(100); |
| 231 | } while ((system_clock::now() - start) <= timeout); |
| 232 | LOG(INFO) << "process group " << pid << " did not exit in " << timeout.count() |
| 233 | << " milliseconds"; |
| 234 | return false; |
| 235 | } |
| 236 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 237 | void Subprocess::KillExec(pid_t pid) { |
Kelvin Zhang | 866d470 | 2023-10-24 12:37:35 -0700 | [diff] [blame] | 238 | using namespace std::chrono_literals; |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 239 | auto pid_record = subprocess_records_.find(pid); |
| 240 | if (pid_record == subprocess_records_.end()) |
Alex Deymo | 29b8153 | 2015-07-09 11:51:49 -0700 | [diff] [blame] | 241 | return; |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 242 | pid_record->second->callback.Reset(); |
Sen Jiang | 1d3b863 | 2016-05-13 12:32:10 -0700 | [diff] [blame] | 243 | // We don't care about output/return code, so we use SIGKILL here to ensure it |
| 244 | // will be killed, SIGTERM might lead to leaked subprocess. |
Kelvin Zhang | 1e92631 | 2023-09-27 18:10:25 -0700 | [diff] [blame] | 245 | CHECK_EQ(pid_record->second->proc.pid(), pid); |
Kelvin Zhang | 866d470 | 2023-10-24 12:37:35 -0700 | [diff] [blame] | 246 | if (kill(-pid, SIGKILL) != 0) { |
| 247 | PLOG(WARNING) << "Failed to kill subprocess group " << pid; |
Alex Deymo | d15c546 | 2016-03-09 18:11:12 -0800 | [diff] [blame] | 248 | } |
Kelvin Zhang | 866d470 | 2023-10-24 12:37:35 -0700 | [diff] [blame] | 249 | WaitForProcessGroup(pid, 5000ms); |
Alex Deymo | d15c546 | 2016-03-09 18:11:12 -0800 | [diff] [blame] | 250 | // Release the pid now so we don't try to kill it if Subprocess is destroyed |
| 251 | // before the corresponding ChildExitedCallback() is called. |
| 252 | pid_record->second->proc.Release(); |
Kelvin Zhang | 1e92631 | 2023-09-27 18:10:25 -0700 | [diff] [blame] | 253 | if (subprocess_records_.count(pid)) { |
| 254 | siginfo_t info; |
| 255 | info.si_code = CLD_KILLED; |
| 256 | info.si_status = SIGKILL; |
| 257 | info.si_pid = pid; |
| 258 | ChildExitedCallback(info); |
| 259 | } |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 260 | } |
| 261 | |
Alex Deymo | e384bb2 | 2016-03-29 17:23:33 -0700 | [diff] [blame] | 262 | int Subprocess::GetPipeFd(pid_t pid, int fd) const { |
| 263 | auto pid_record = subprocess_records_.find(pid); |
| 264 | if (pid_record == subprocess_records_.end()) |
| 265 | return -1; |
| 266 | return pid_record->second->proc.GetPipe(fd); |
| 267 | } |
| 268 | |
Alex Deymo | f329b93 | 2014-10-30 01:37:48 -0700 | [diff] [blame] | 269 | bool Subprocess::SynchronousExec(const vector<string>& cmd, |
Darin Petkov | 85d02b7 | 2011-05-17 13:25:51 -0700 | [diff] [blame] | 270 | int* return_code, |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 271 | string* stdout_str, |
| 272 | string* stderr_str) { |
Amin Hassani | 3a4caa1 | 2019-11-06 11:12:28 -0800 | [diff] [blame] | 273 | // The default for |SynchronousExec| is to use |kSearchPath| since the code |
| 274 | // relies on that. |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 275 | return SynchronousExecFlags( |
| 276 | cmd, kSearchPath, return_code, stdout_str, stderr_str); |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 277 | } |
| 278 | |
| 279 | bool Subprocess::SynchronousExecFlags(const vector<string>& cmd, |
| 280 | uint32_t flags, |
| 281 | int* return_code, |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 282 | string* stdout_str, |
| 283 | string* stderr_str) { |
Alex Vakulenko | 3f39d5c | 2015-10-13 09:27:13 -0700 | [diff] [blame] | 284 | brillo::ProcessImpl proc; |
Amin Hassani | 3a4caa1 | 2019-11-06 11:12:28 -0800 | [diff] [blame] | 285 | if (!LaunchProcess(cmd, flags, {STDERR_FILENO}, &proc)) { |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 286 | LOG(ERROR) << "Failed to launch subprocess"; |
| 287 | return false; |
| 288 | } |
| 289 | |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 290 | if (stdout_str) { |
| 291 | stdout_str->clear(); |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 292 | } |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 293 | if (stderr_str) { |
| 294 | stderr_str->clear(); |
Amin Hassani | 3a4caa1 | 2019-11-06 11:12:28 -0800 | [diff] [blame] | 295 | } |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 296 | |
Amin Hassani | 3a4caa1 | 2019-11-06 11:12:28 -0800 | [diff] [blame] | 297 | // Read from both stdout and stderr individually. |
| 298 | int stdout_fd = proc.GetPipe(STDOUT_FILENO); |
| 299 | int stderr_fd = proc.GetPipe(STDERR_FILENO); |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 300 | vector<char> buffer(32 * 1024); |
Amin Hassani | 3a4caa1 | 2019-11-06 11:12:28 -0800 | [diff] [blame] | 301 | bool stdout_closed = false, stderr_closed = false; |
| 302 | while (!stdout_closed || !stderr_closed) { |
| 303 | if (!stdout_closed) { |
| 304 | int rc = HANDLE_EINTR(read(stdout_fd, buffer.data(), buffer.size())); |
| 305 | if (rc <= 0) { |
| 306 | stdout_closed = true; |
| 307 | if (rc < 0) |
| 308 | PLOG(ERROR) << "Reading from child's stdout"; |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 309 | } else if (stdout_str != nullptr) { |
| 310 | stdout_str->append(buffer.data(), rc); |
Amin Hassani | 3a4caa1 | 2019-11-06 11:12:28 -0800 | [diff] [blame] | 311 | } |
| 312 | } |
| 313 | |
| 314 | if (!stderr_closed) { |
| 315 | int rc = HANDLE_EINTR(read(stderr_fd, buffer.data(), buffer.size())); |
| 316 | if (rc <= 0) { |
| 317 | stderr_closed = true; |
| 318 | if (rc < 0) |
| 319 | PLOG(ERROR) << "Reading from child's stderr"; |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 320 | } else if (stderr_str != nullptr) { |
| 321 | stderr_str->append(buffer.data(), rc); |
Amin Hassani | 3a4caa1 | 2019-11-06 11:12:28 -0800 | [diff] [blame] | 322 | } |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 323 | } |
| 324 | } |
Amin Hassani | 3a4caa1 | 2019-11-06 11:12:28 -0800 | [diff] [blame] | 325 | |
Alex Deymo | 461b259 | 2015-07-24 20:10:52 -0700 | [diff] [blame] | 326 | // At this point, the subprocess already closed the output, so we only need to |
| 327 | // wait for it to finish. |
| 328 | int proc_return_code = proc.Wait(); |
| 329 | if (return_code) |
| 330 | *return_code = proc_return_code; |
Alex Vakulenko | 3f39d5c | 2015-10-13 09:27:13 -0700 | [diff] [blame] | 331 | return proc_return_code != brillo::Process::kErrorExitStatus; |
Darin Petkov | 85d02b7 | 2011-05-17 13:25:51 -0700 | [diff] [blame] | 332 | } |
| 333 | |
Amin Hassani | a885954 | 2018-03-07 16:24:43 -0800 | [diff] [blame] | 334 | void Subprocess::FlushBufferedLogsAtExit() { |
| 335 | if (!subprocess_records_.empty()) { |
| 336 | LOG(INFO) << "We are exiting, but there are still in flight subprocesses!"; |
| 337 | for (auto& pid_record : subprocess_records_) { |
| 338 | SubprocessRecord* record = pid_record.second.get(); |
| 339 | // Make sure we read any remaining process output. |
| 340 | OnStdoutReady(record); |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 341 | if (!record->stdout_str.empty()) { |
Amin Hassani | a885954 | 2018-03-07 16:24:43 -0800 | [diff] [blame] | 342 | LOG(INFO) << "Subprocess(" << pid_record.first << ") output:\n" |
Colin Cross | d76a8ac | 2021-12-21 13:08:20 -0800 | [diff] [blame] | 343 | << record->stdout_str; |
Amin Hassani | a885954 | 2018-03-07 16:24:43 -0800 | [diff] [blame] | 344 | } |
| 345 | } |
| 346 | } |
| 347 | } |
| 348 | |
Alex Vakulenko | 88b591f | 2014-08-28 16:48:57 -0700 | [diff] [blame] | 349 | Subprocess* Subprocess::subprocess_singleton_ = nullptr; |
adlr@google.com | 3defe6a | 2009-12-04 20:57:17 +0000 | [diff] [blame] | 350 | |
| 351 | } // namespace chromeos_update_engine |