Alex Klyubin | f5446eb | 2017-03-23 14:27:32 -0700 | [diff] [blame] | 1 | typeattribute incidentd coredomain; |
Yi Jin | bc24ba7 | 2018-01-22 14:00:46 -0800 | [diff] [blame] | 2 | typeattribute incidentd mlstrustedsubject; |
Alex Klyubin | f5446eb | 2017-03-23 14:27:32 -0700 | [diff] [blame] | 3 | |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 4 | init_daemon_domain(incidentd) |
Nick Kralevich | 5e37271 | 2018-09-27 10:21:37 -0700 | [diff] [blame] | 5 | type incidentd_exec, system_file_type, exec_type, file_type; |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 6 | binder_use(incidentd) |
| 7 | wakelock_use(incidentd) |
| 8 | |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 9 | # Allow incidentd to scan through /proc/pid for all processes |
| 10 | r_dir_file(incidentd, domain) |
| 11 | |
Yi Jin | bc24ba7 | 2018-01-22 14:00:46 -0800 | [diff] [blame] | 12 | # Allow incidentd to kill incident_helper when timeout |
| 13 | allow incidentd incident_helper:process sigkill; |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 14 | |
| 15 | # Allow executing files on system, such as: |
| 16 | # /system/bin/toolbox |
| 17 | # /system/bin/logcat |
| 18 | # /system/bin/dumpsys |
| 19 | allow incidentd system_file:file execute_no_trans; |
| 20 | allow incidentd toolbox_exec:file rx_file_perms; |
| 21 | |
Yi Jin | 880de35 | 2018-06-26 14:17:04 -0700 | [diff] [blame] | 22 | # section id 1002, allow reading kernel version /proc/version |
| 23 | allow incidentd proc_version:file r_file_perms; |
| 24 | |
Yi Jin | bc24ba7 | 2018-01-22 14:00:46 -0800 | [diff] [blame] | 25 | # section id 2001, allow reading /proc/pagetypeinfo |
| 26 | allow incidentd proc_pagetypeinfo:file r_file_perms; |
| 27 | |
| 28 | # section id 2002, allow reading /d/wakeup_sources |
| 29 | allow incidentd debugfs_wakeup_sources:file r_file_perms; |
| 30 | |
| 31 | # section id 2003, allow executing top |
| 32 | allow incidentd proc_meminfo:file { open read }; |
| 33 | |
| 34 | # section id 2004, allow reading /sys/devices/system/cpu/cpufreq/all_time_in_state |
| 35 | allow incidentd sysfs_devices_system_cpu:file r_file_perms; |
| 36 | |
Kweku Adams | 06ac7db | 2018-03-06 17:42:35 -0800 | [diff] [blame] | 37 | # section id 2005, allow reading ps dump in full |
| 38 | allow incidentd domain:process getattr; |
| 39 | |
Yi Jin | bc24ba7 | 2018-01-22 14:00:46 -0800 | [diff] [blame] | 40 | # section id 2006, allow reading /sys/class/power_supply/bms/battery_type |
| 41 | allow incidentd sysfs_batteryinfo:dir { search }; |
| 42 | allow incidentd sysfs_batteryinfo:file r_file_perms; |
| 43 | |
Yi Jin | 76238cd | 2018-03-30 10:14:08 -0700 | [diff] [blame] | 44 | # section id 2007, allow reading LAST_KMSG /sys/fs/pstore/console-ramoops |
| 45 | userdebug_or_eng(`allow incidentd pstorefs:dir search'); |
| 46 | userdebug_or_eng(`allow incidentd pstorefs:file r_file_perms'); |
| 47 | |
Bookatz | d2f3d18 | 2018-11-05 15:01:39 -0800 | [diff] [blame] | 48 | # section id 3023, allow obtaining stats report |
| 49 | allow incidentd stats_service:service_manager find; |
| 50 | binder_call(incidentd, statsd) |
| 51 | |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 52 | # Create and write into /data/misc/incidents |
| 53 | allow incidentd incident_data_file:dir rw_dir_perms; |
| 54 | allow incidentd incident_data_file:file create_file_perms; |
| 55 | |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 56 | # Enable incidentd to get stack traces. |
| 57 | binder_use(incidentd) |
| 58 | hwbinder_use(incidentd) |
| 59 | allow incidentd hwservicemanager:hwservice_manager { list }; |
| 60 | get_prop(incidentd, hwservicemanager_prop) |
| 61 | allow incidentd hidl_manager_hwservice:hwservice_manager { find }; |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 62 | |
Kweku Adams | 06ac7db | 2018-03-06 17:42:35 -0800 | [diff] [blame] | 63 | # Read files in /proc |
| 64 | allow incidentd { |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 65 | proc_cmdline |
| 66 | proc_pipe_conf |
Kweku Adams | 06ac7db | 2018-03-06 17:42:35 -0800 | [diff] [blame] | 67 | proc_stat |
| 68 | }:file r_file_perms; |
| 69 | |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 70 | # Signal java processes to dump their stack and get the results |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 71 | allow incidentd { appdomain ephemeral_app system_server }:process signal; |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 72 | |
| 73 | # Signal native processes to dump their stack. |
| 74 | # This list comes from native_processes_to_dump in incidentd/utils.c |
| 75 | allow incidentd { |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 76 | # This list comes from native_processes_to_dump in dumputils/dump_utils.cpp |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 77 | audioserver |
| 78 | cameraserver |
| 79 | drmserver |
| 80 | inputflinger |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 81 | mediadrmserver |
| 82 | mediaextractor |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 83 | mediametrics |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 84 | mediaserver |
| 85 | sdcardd |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 86 | statsd |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 87 | surfaceflinger |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 88 | |
| 89 | # This list comes from hal_interfaces_to_dump in dumputils/dump_utils.cpp |
| 90 | hal_audio_server |
| 91 | hal_bluetooth_server |
| 92 | hal_camera_server |
Chia-I Wu | 7c5e18c | 2018-08-09 15:56:09 -0700 | [diff] [blame] | 93 | hal_graphics_allocator_server |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 94 | hal_graphics_composer_server |
Yifan Hong | 0d53ef2 | 2018-11-27 17:35:31 -0800 | [diff] [blame] | 95 | hal_health_server |
Steven Moreland | 7baf725 | 2018-05-25 16:23:37 -0700 | [diff] [blame] | 96 | hal_omx_server |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 97 | hal_sensors_server |
| 98 | hal_vr_server |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 99 | }:process signal; |
| 100 | |
| 101 | # Allow incidentd to make binder calls to any binder service |
Yi Jin | bc24ba7 | 2018-01-22 14:00:46 -0800 | [diff] [blame] | 102 | binder_call(incidentd, system_server) |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 103 | binder_call(incidentd, appdomain) |
| 104 | |
| 105 | # Reading /proc/PID/maps of other processes |
Kweku Adams | 985db6d | 2018-03-12 16:21:40 -0700 | [diff] [blame] | 106 | userdebug_or_eng(`allow incidentd self:global_capability_class_set { sys_ptrace }'); |
| 107 | # incidentd has capability sys_ptrace, but should only use that capability for |
| 108 | # accessing sensitive /proc/PID files, never for using ptrace attach. |
| 109 | neverallow incidentd *:process ptrace; |
| 110 | |
| 111 | allow incidentd self:global_capability_class_set { |
| 112 | # Send signals to processes |
| 113 | kill |
| 114 | }; |
| 115 | |
| 116 | # Connect to tombstoned to intercept dumps. |
| 117 | unix_socket_connect(incidentd, tombstoned_intercept, tombstoned) |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 118 | |
| 119 | # Run a shell. |
| 120 | allow incidentd shell_exec:file rx_file_perms; |
| 121 | |
| 122 | # logd access - work to be done is a PII safe log (possibly an event log?) |
Yi Jin | bc24ba7 | 2018-01-22 14:00:46 -0800 | [diff] [blame] | 123 | userdebug_or_eng(`read_logd(incidentd)') |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 124 | # TODO control_logd(incidentd) |
| 125 | |
| 126 | # Allow incidentd to find these standard groups of services. |
| 127 | # Others can be whitelisted individually. |
| 128 | allow incidentd { |
| 129 | system_server_service |
| 130 | app_api_service |
| 131 | system_api_service |
| 132 | }:service_manager find; |
| 133 | |
| 134 | # Only incidentd can publish the binder service |
| 135 | add_service(incidentd, incident_service) |
| 136 | |
Mike Ma | de3a3e4 | 2018-12-03 10:35:40 -0800 | [diff] [blame] | 137 | # Allow pipes only from dumpstate and incident |
| 138 | allow incidentd { dumpstate incident }:fd use; |
| 139 | allow incidentd { dumpstate incident }:fifo_file write; |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 140 | |
| 141 | # Allow incident to call back to incident with status updates. |
| 142 | binder_call(incidentd, incident) |
| 143 | |
| 144 | ### |
| 145 | ### neverallow rules |
| 146 | ### |
| 147 | |
Mike Ma | de3a3e4 | 2018-12-03 10:35:40 -0800 | [diff] [blame] | 148 | # only dumpstate, system_server, system_app and incident command can find the incident service |
yro | cf38ca5 | 2018-01-22 13:56:41 -0800 | [diff] [blame] | 149 | neverallow { |
| 150 | domain |
Mike Ma | de3a3e4 | 2018-12-03 10:35:40 -0800 | [diff] [blame] | 151 | -dumpstate |
yro | cf38ca5 | 2018-01-22 13:56:41 -0800 | [diff] [blame] | 152 | -incident |
| 153 | -incidentd |
Joe Onorato | 9cc5c09 | 2019-03-16 15:45:45 -0700 | [diff] [blame^] | 154 | -priv_app |
yro | cf38ca5 | 2018-01-22 13:56:41 -0800 | [diff] [blame] | 155 | -statsd |
| 156 | -system_app |
| 157 | -system_server |
| 158 | } incident_service:service_manager find; |
Joe Onorato | 41f93db | 2016-11-20 23:23:04 -0800 | [diff] [blame] | 159 | |
| 160 | # only incidentd and the other root services in limited circumstances |
| 161 | # can get to the files in /data/misc/incidents |
| 162 | # |
| 163 | # write, execute, append are forbidden almost everywhere |
| 164 | neverallow { domain -incidentd -init -vold } incident_data_file:file { |
| 165 | w_file_perms |
| 166 | x_file_perms |
| 167 | create |
| 168 | rename |
| 169 | setattr |
| 170 | unlink |
| 171 | append |
| 172 | }; |
| 173 | # read is also allowed by system_server, for when the file is handed to dropbox |
| 174 | neverallow { domain -incidentd -init -vold -system_server } incident_data_file:file r_file_perms; |
| 175 | # limited access to the directory itself |
| 176 | neverallow { domain -incidentd -init -vold } incident_data_file:dir create_dir_perms; |
| 177 | |