Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2012-2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 16 | // for manual checking of stale entries during ChattyLogBuffer::erase() |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 17 | //#define DEBUG_CHECK_FOR_STALE_ENTRIES |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 18 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 19 | #include "ChattyLogBuffer.h" |
| 20 | |
Mark Salyzyn | 671e343 | 2014-05-06 07:34:59 -0700 | [diff] [blame] | 21 | #include <ctype.h> |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 22 | #include <endian.h> |
Mark Salyzyn | 202e153 | 2015-02-09 08:21:05 -0800 | [diff] [blame] | 23 | #include <errno.h> |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 24 | #include <stdio.h> |
| 25 | #include <string.h> |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 26 | #include <sys/cdefs.h> |
Mark Salyzyn | 57a0af9 | 2014-05-09 17:44:18 -0700 | [diff] [blame] | 27 | #include <sys/user.h> |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 28 | #include <time.h> |
| 29 | #include <unistd.h> |
| 30 | |
Tom Cherry | b398a7c | 2020-05-20 12:09:22 -0700 | [diff] [blame^] | 31 | #include <limits> |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 32 | #include <unordered_map> |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 33 | #include <utility> |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 34 | |
Mark Salyzyn | f10e273 | 2016-09-27 13:08:23 -0700 | [diff] [blame] | 35 | #include <private/android_logger.h> |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 36 | |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 37 | #include "LogUtils.h" |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 38 | |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 39 | #ifndef __predict_false |
| 40 | #define __predict_false(exp) __builtin_expect((exp) != 0, 0) |
| 41 | #endif |
| 42 | |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 43 | // Default |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 44 | #define log_buffer_size(id) mMaxSize[id] |
Mark Salyzyn | 671e343 | 2014-05-06 07:34:59 -0700 | [diff] [blame] | 45 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 46 | void ChattyLogBuffer::Init() { |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 47 | log_id_for_each(i) { |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 48 | if (SetSize(i, __android_logger_get_buffer_size(i))) { |
| 49 | SetSize(i, LOG_BUFFER_MIN_SIZE); |
Mark Salyzyn | 57a0af9 | 2014-05-09 17:44:18 -0700 | [diff] [blame] | 50 | } |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 51 | } |
Tom Cherry | e170d1a | 2020-05-01 16:45:25 -0700 | [diff] [blame] | 52 | // Release any sleeping reader threads to dump their current content. |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 53 | auto reader_threads_lock = std::lock_guard{reader_list_->reader_threads_lock()}; |
| 54 | for (const auto& reader_thread : reader_list_->reader_threads()) { |
| 55 | reader_thread->triggerReader_Locked(); |
Mark Salyzyn | b6bee33 | 2015-09-08 08:56:32 -0700 | [diff] [blame] | 56 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 57 | } |
| 58 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 59 | ChattyLogBuffer::ChattyLogBuffer(LogReaderList* reader_list, LogTags* tags, PruneList* prune, |
| 60 | LogStatistics* stats) |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 61 | : reader_list_(reader_list), tags_(tags), prune_(prune), stats_(stats) { |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 62 | pthread_rwlock_init(&mLogElementsLock, nullptr); |
Mark Salyzyn | 11e55cb | 2015-03-10 16:45:17 -0700 | [diff] [blame] | 63 | |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 64 | log_id_for_each(i) { |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 65 | lastLoggedElements[i] = nullptr; |
| 66 | droppedElements[i] = nullptr; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 67 | } |
| 68 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 69 | Init(); |
Mark Salyzyn | 11e55cb | 2015-03-10 16:45:17 -0700 | [diff] [blame] | 70 | } |
| 71 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 72 | ChattyLogBuffer::~ChattyLogBuffer() { |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 73 | log_id_for_each(i) { |
| 74 | delete lastLoggedElements[i]; |
| 75 | delete droppedElements[i]; |
| 76 | } |
| 77 | } |
| 78 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 79 | LogBufferElementCollection::iterator ChattyLogBuffer::GetOldest(log_id_t log_id) { |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 80 | auto it = mLogElements.begin(); |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 81 | if (oldest_[log_id]) { |
| 82 | it = *oldest_[log_id]; |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 83 | } |
| 84 | while (it != mLogElements.end() && (*it)->getLogId() != log_id) { |
| 85 | it++; |
| 86 | } |
| 87 | if (it != mLogElements.end()) { |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 88 | oldest_[log_id] = it; |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 89 | } |
| 90 | return it; |
| 91 | } |
| 92 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 93 | enum match_type { DIFFERENT, SAME, SAME_LIBLOG }; |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 94 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 95 | static enum match_type identical(LogBufferElement* elem, LogBufferElement* last) { |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 96 | // is it mostly identical? |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 97 | // if (!elem) return DIFFERENT; |
Mark Salyzyn | 0484b3b | 2016-08-11 08:02:06 -0700 | [diff] [blame] | 98 | ssize_t lenl = elem->getMsgLen(); |
| 99 | if (lenl <= 0) return DIFFERENT; // value if this represents a chatty elem |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 100 | // if (!last) return DIFFERENT; |
Mark Salyzyn | 0484b3b | 2016-08-11 08:02:06 -0700 | [diff] [blame] | 101 | ssize_t lenr = last->getMsgLen(); |
| 102 | if (lenr <= 0) return DIFFERENT; // value if this represents a chatty elem |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 103 | // if (elem->getLogId() != last->getLogId()) return DIFFERENT; |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 104 | if (elem->getUid() != last->getUid()) return DIFFERENT; |
| 105 | if (elem->getPid() != last->getPid()) return DIFFERENT; |
| 106 | if (elem->getTid() != last->getTid()) return DIFFERENT; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 107 | |
| 108 | // last is more than a minute old, stop squashing identical messages |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 109 | if (elem->getRealTime().nsec() > (last->getRealTime().nsec() + 60 * NS_PER_SEC)) |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 110 | return DIFFERENT; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 111 | |
| 112 | // Identical message |
| 113 | const char* msgl = elem->getMsg(); |
| 114 | const char* msgr = last->getMsg(); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 115 | if (lenl == lenr) { |
| 116 | if (!fastcmp<memcmp>(msgl, msgr, lenl)) return SAME; |
| 117 | // liblog tagged messages (content gets summed) |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 118 | if (elem->getLogId() == LOG_ID_EVENTS && lenl == sizeof(android_log_event_int_t) && |
| 119 | !fastcmp<memcmp>(msgl, msgr, sizeof(android_log_event_int_t) - sizeof(int32_t)) && |
| 120 | elem->getTag() == LIBLOG_LOG_TAG) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 121 | return SAME_LIBLOG; |
Mark Salyzyn | 1598fe0 | 2017-03-13 15:41:59 -0700 | [diff] [blame] | 122 | } |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 123 | } |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 124 | |
| 125 | // audit message (except sequence number) identical? |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 126 | if (last->isBinary() && lenl > static_cast<ssize_t>(sizeof(android_log_event_string_t)) && |
| 127 | lenr > static_cast<ssize_t>(sizeof(android_log_event_string_t))) { |
| 128 | if (fastcmp<memcmp>(msgl, msgr, sizeof(android_log_event_string_t) - sizeof(int32_t))) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 129 | return DIFFERENT; |
Mark Salyzyn | 1598fe0 | 2017-03-13 15:41:59 -0700 | [diff] [blame] | 130 | } |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 131 | msgl += sizeof(android_log_event_string_t); |
| 132 | lenl -= sizeof(android_log_event_string_t); |
| 133 | msgr += sizeof(android_log_event_string_t); |
| 134 | lenr -= sizeof(android_log_event_string_t); |
| 135 | } |
Mark Salyzyn | 0484b3b | 2016-08-11 08:02:06 -0700 | [diff] [blame] | 136 | static const char avc[] = "): avc: "; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 137 | const char* avcl = android::strnstr(msgl, lenl, avc); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 138 | if (!avcl) return DIFFERENT; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 139 | lenl -= avcl - msgl; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 140 | const char* avcr = android::strnstr(msgr, lenr, avc); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 141 | if (!avcr) return DIFFERENT; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 142 | lenr -= avcr - msgr; |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 143 | if (lenl != lenr) return DIFFERENT; |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 144 | if (fastcmp<memcmp>(avcl + strlen(avc), avcr + strlen(avc), lenl - strlen(avc))) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 145 | return DIFFERENT; |
Mark Salyzyn | 1598fe0 | 2017-03-13 15:41:59 -0700 | [diff] [blame] | 146 | } |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 147 | return SAME; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 148 | } |
| 149 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 150 | int ChattyLogBuffer::Log(log_id_t log_id, log_time realtime, uid_t uid, pid_t pid, pid_t tid, |
| 151 | const char* msg, uint16_t len) { |
Yi Kong | 141ccee | 2018-03-01 17:48:53 -0500 | [diff] [blame] | 152 | if (log_id >= LOG_ID_MAX) { |
Mark Salyzyn | 202e153 | 2015-02-09 08:21:05 -0800 | [diff] [blame] | 153 | return -EINVAL; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 154 | } |
Mark Salyzyn | e59c469 | 2014-10-02 13:07:05 -0700 | [diff] [blame] | 155 | |
Mark Salyzyn | 206ed8e | 2017-05-18 10:06:00 -0700 | [diff] [blame] | 156 | // Slip the time by 1 nsec if the incoming lands on xxxxxx000 ns. |
| 157 | // This prevents any chance that an outside source can request an |
| 158 | // exact entry with time specified in ms or us precision. |
| 159 | if ((realtime.tv_nsec % 1000) == 0) ++realtime.tv_nsec; |
| 160 | |
Tom Cherry | 2ac86de | 2020-02-20 13:21:51 -0800 | [diff] [blame] | 161 | LogBufferElement* elem = new LogBufferElement(log_id, realtime, uid, pid, tid, msg, len); |
| 162 | |
| 163 | // b/137093665: don't coalesce security messages. |
| 164 | if (log_id == LOG_ID_SECURITY) { |
| 165 | wrlock(); |
| 166 | log(elem); |
| 167 | unlock(); |
| 168 | |
| 169 | return len; |
| 170 | } |
| 171 | |
| 172 | int prio = ANDROID_LOG_INFO; |
| 173 | const char* tag = nullptr; |
| 174 | size_t tag_len = 0; |
| 175 | if (log_id == LOG_ID_EVENTS || log_id == LOG_ID_STATS) { |
Tom Cherry | 1a12ae3 | 2020-05-01 16:13:18 -0700 | [diff] [blame] | 176 | tag = tags_->tagToName(elem->getTag()); |
Tom Cherry | 2ac86de | 2020-02-20 13:21:51 -0800 | [diff] [blame] | 177 | if (tag) { |
| 178 | tag_len = strlen(tag); |
Mark Salyzyn | 083b037 | 2015-12-04 10:59:45 -0800 | [diff] [blame] | 179 | } |
Tom Cherry | 2ac86de | 2020-02-20 13:21:51 -0800 | [diff] [blame] | 180 | } else { |
| 181 | prio = *msg; |
| 182 | tag = msg + 1; |
| 183 | tag_len = strnlen(tag, len - 1); |
| 184 | } |
| 185 | if (!__android_log_is_loggable_len(prio, tag, tag_len, ANDROID_LOG_VERBOSE)) { |
| 186 | // Log traffic received to total |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 187 | stats_->AddTotal(elem); |
Tom Cherry | 2ac86de | 2020-02-20 13:21:51 -0800 | [diff] [blame] | 188 | delete elem; |
| 189 | return -EACCES; |
Mark Salyzyn | e59c469 | 2014-10-02 13:07:05 -0700 | [diff] [blame] | 190 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 191 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 192 | wrlock(); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 193 | LogBufferElement* currentLast = lastLoggedElements[log_id]; |
| 194 | if (currentLast) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 195 | LogBufferElement* dropped = droppedElements[log_id]; |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 196 | uint16_t count = dropped ? dropped->getDropped() : 0; |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 197 | // |
| 198 | // State Init |
| 199 | // incoming: |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 200 | // dropped = nullptr |
| 201 | // currentLast = nullptr; |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 202 | // elem = incoming message |
| 203 | // outgoing: |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 204 | // dropped = nullptr -> State 0 |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 205 | // currentLast = copy of elem |
| 206 | // log elem |
| 207 | // State 0 |
| 208 | // incoming: |
| 209 | // count = 0 |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 210 | // dropped = nullptr |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 211 | // currentLast = copy of last message |
| 212 | // elem = incoming message |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 213 | // outgoing: if match != DIFFERENT |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 214 | // dropped = copy of first identical message -> State 1 |
| 215 | // currentLast = reference to elem |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 216 | // break: if match == DIFFERENT |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 217 | // dropped = nullptr -> State 0 |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 218 | // delete copy of last message (incoming currentLast) |
| 219 | // currentLast = copy of elem |
| 220 | // log elem |
| 221 | // State 1 |
| 222 | // incoming: |
| 223 | // count = 0 |
| 224 | // dropped = copy of first identical message |
| 225 | // currentLast = reference to last held-back incoming |
| 226 | // message |
| 227 | // elem = incoming message |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 228 | // outgoing: if match == SAME |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 229 | // delete copy of first identical message (dropped) |
| 230 | // dropped = reference to last held-back incoming |
| 231 | // message set to chatty count of 1 -> State 2 |
| 232 | // currentLast = reference to elem |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 233 | // outgoing: if match == SAME_LIBLOG |
| 234 | // dropped = copy of first identical message -> State 1 |
| 235 | // take sum of currentLast and elem |
| 236 | // if sum overflows: |
| 237 | // log currentLast |
| 238 | // currentLast = reference to elem |
| 239 | // else |
| 240 | // delete currentLast |
| 241 | // currentLast = reference to elem, sum liblog. |
| 242 | // break: if match == DIFFERENT |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 243 | // delete dropped |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 244 | // dropped = nullptr -> State 0 |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 245 | // log reference to last held-back (currentLast) |
| 246 | // currentLast = copy of elem |
| 247 | // log elem |
| 248 | // State 2 |
| 249 | // incoming: |
| 250 | // count = chatty count |
| 251 | // dropped = chatty message holding count |
| 252 | // currentLast = reference to last held-back incoming |
| 253 | // message. |
| 254 | // dropped = chatty message holding count |
| 255 | // elem = incoming message |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 256 | // outgoing: if match != DIFFERENT |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 257 | // delete chatty message holding count |
| 258 | // dropped = reference to last held-back incoming |
| 259 | // message, set to chatty count + 1 |
| 260 | // currentLast = reference to elem |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 261 | // break: if match == DIFFERENT |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 262 | // log dropped (chatty message) |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 263 | // dropped = nullptr -> State 0 |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 264 | // log reference to last held-back (currentLast) |
| 265 | // currentLast = copy of elem |
| 266 | // log elem |
| 267 | // |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 268 | enum match_type match = identical(elem, currentLast); |
| 269 | if (match != DIFFERENT) { |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 270 | if (dropped) { |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 271 | // Sum up liblog tag messages? |
| 272 | if ((count == 0) /* at Pass 1 */ && (match == SAME_LIBLOG)) { |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 273 | android_log_event_int_t* event = reinterpret_cast<android_log_event_int_t*>( |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 274 | const_cast<char*>(currentLast->getMsg())); |
| 275 | // |
| 276 | // To unit test, differentiate with something like: |
| 277 | // event->header.tag = htole32(CHATTY_LOG_TAG); |
| 278 | // here, then instead of delete currentLast below, |
| 279 | // log(currentLast) to see the incremental sums form. |
| 280 | // |
| 281 | uint32_t swab = event->payload.data; |
| 282 | unsigned long long total = htole32(swab); |
| 283 | event = reinterpret_cast<android_log_event_int_t*>( |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 284 | const_cast<char*>(elem->getMsg())); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 285 | swab = event->payload.data; |
| 286 | |
| 287 | lastLoggedElements[LOG_ID_EVENTS] = elem; |
| 288 | total += htole32(swab); |
| 289 | // check for overflow |
Tom Cherry | b398a7c | 2020-05-20 12:09:22 -0700 | [diff] [blame^] | 290 | if (total >= std::numeric_limits<int32_t>::max()) { |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 291 | log(currentLast); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 292 | unlock(); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 293 | return len; |
| 294 | } |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 295 | stats_->AddTotal(currentLast); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 296 | delete currentLast; |
| 297 | swab = total; |
| 298 | event->payload.data = htole32(swab); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 299 | unlock(); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 300 | return len; |
| 301 | } |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 302 | if (count == USHRT_MAX) { |
| 303 | log(dropped); |
| 304 | count = 1; |
| 305 | } else { |
| 306 | delete dropped; |
| 307 | ++count; |
| 308 | } |
| 309 | } |
| 310 | if (count) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 311 | stats_->AddTotal(currentLast); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 312 | currentLast->setDropped(count); |
| 313 | } |
| 314 | droppedElements[log_id] = currentLast; |
| 315 | lastLoggedElements[log_id] = elem; |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 316 | unlock(); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 317 | return len; |
| 318 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 319 | if (dropped) { // State 1 or 2 |
| 320 | if (count) { // State 2 |
| 321 | log(dropped); // report chatty |
| 322 | } else { // State 1 |
| 323 | delete dropped; |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 324 | } |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 325 | droppedElements[log_id] = nullptr; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 326 | log(currentLast); // report last message in the series |
| 327 | } else { // State 0 |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 328 | delete currentLast; |
| 329 | } |
| 330 | } |
| 331 | lastLoggedElements[log_id] = new LogBufferElement(*elem); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 332 | |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 333 | log(elem); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 334 | unlock(); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 335 | |
| 336 | return len; |
| 337 | } |
| 338 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 339 | // assumes ChattyLogBuffer::wrlock() held, owns elem, look after garbage collection |
| 340 | void ChattyLogBuffer::log(LogBufferElement* elem) { |
Tom Cherry | 65abf39 | 2019-08-21 13:17:12 -0700 | [diff] [blame] | 341 | mLogElements.push_back(elem); |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 342 | stats_->Add(elem); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 343 | maybePrune(elem->getLogId()); |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 344 | reader_list_->NotifyNewLog(1 << elem->getLogId()); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 345 | } |
| 346 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 347 | // ChattyLogBuffer::wrlock() must be held when this function is called. |
| 348 | void ChattyLogBuffer::maybePrune(log_id_t id) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 349 | unsigned long prune_rows; |
| 350 | if (stats_->ShouldPrune(id, log_buffer_size(id), &prune_rows)) { |
| 351 | prune(id, prune_rows); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 352 | } |
| 353 | } |
| 354 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 355 | LogBufferElementCollection::iterator ChattyLogBuffer::erase(LogBufferElementCollection::iterator it, |
| 356 | bool coalesce) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 357 | LogBufferElement* element = *it; |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 358 | log_id_t id = element->getLogId(); |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 359 | |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 360 | // Remove iterator references in the various lists that will become stale |
| 361 | // after the element is erased from the main logging list. |
| 362 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 363 | { // start of scope for found iterator |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 364 | int key = (id == LOG_ID_EVENTS || id == LOG_ID_SECURITY) ? element->getTag() |
| 365 | : element->getUid(); |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 366 | LogBufferIteratorMap::iterator found = mLastWorst[id].find(key); |
| 367 | if ((found != mLastWorst[id].end()) && (it == found->second)) { |
| 368 | mLastWorst[id].erase(found); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 369 | } |
Mark Salyzyn | c892ea3 | 2015-08-19 17:06:11 -0700 | [diff] [blame] | 370 | } |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 371 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 372 | { // start of scope for pid found iterator |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 373 | // element->getUid() may not be AID_SYSTEM for next-best-watermark. |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 374 | // will not assume id != LOG_ID_EVENTS or LOG_ID_SECURITY for KISS and |
| 375 | // long term code stability, find() check should be fast for those ids. |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 376 | LogBufferPidIteratorMap::iterator found = mLastWorstPidOfSystem[id].find(element->getPid()); |
| 377 | if (found != mLastWorstPidOfSystem[id].end() && it == found->second) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 378 | mLastWorstPidOfSystem[id].erase(found); |
| 379 | } |
| 380 | } |
| 381 | |
Mark Salyzyn | 7fd6c5c | 2016-01-19 16:04:41 -0800 | [diff] [blame] | 382 | bool setLast[LOG_ID_MAX]; |
| 383 | bool doSetLast = false; |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 384 | log_id_for_each(i) { doSetLast |= setLast[i] = oldest_[i] && it == *oldest_[i]; } |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 385 | #ifdef DEBUG_CHECK_FOR_STALE_ENTRIES |
| 386 | LogBufferElementCollection::iterator bad = it; |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 387 | int key = |
| 388 | (id == LOG_ID_EVENTS || id == LOG_ID_SECURITY) ? element->getTag() : element->getUid(); |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 389 | #endif |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 390 | it = mLogElements.erase(it); |
Mark Salyzyn | 7fd6c5c | 2016-01-19 16:04:41 -0800 | [diff] [blame] | 391 | if (doSetLast) { |
| 392 | log_id_for_each(i) { |
| 393 | if (setLast[i]) { |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 394 | if (__predict_false(it == mLogElements.end())) { |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 395 | oldest_[i] = std::nullopt; |
Mark Salyzyn | 7fd6c5c | 2016-01-19 16:04:41 -0800 | [diff] [blame] | 396 | } else { |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 397 | oldest_[i] = it; // Store the next iterator even if it does not correspond to |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 398 | // the same log_id, as a starting point for GetOldest(). |
Mark Salyzyn | 7fd6c5c | 2016-01-19 16:04:41 -0800 | [diff] [blame] | 399 | } |
| 400 | } |
Mark Salyzyn | 507eb9f | 2016-01-11 10:58:09 -0800 | [diff] [blame] | 401 | } |
| 402 | } |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 403 | #ifdef DEBUG_CHECK_FOR_STALE_ENTRIES |
| 404 | log_id_for_each(i) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 405 | for (auto b : mLastWorst[i]) { |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 406 | if (bad == b.second) { |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 407 | android::prdebug("stale mLastWorst[%d] key=%d mykey=%d\n", i, b.first, key); |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 408 | } |
| 409 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 410 | for (auto b : mLastWorstPidOfSystem[i]) { |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 411 | if (bad == b.second) { |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 412 | android::prdebug("stale mLastWorstPidOfSystem[%d] pid=%d\n", i, b.first); |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 413 | } |
| 414 | } |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 415 | } |
| 416 | #endif |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 417 | if (coalesce) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 418 | stats_->Erase(element); |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 419 | } else { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 420 | stats_->Subtract(element); |
Mark Salyzyn | 831aa29 | 2015-09-03 16:08:50 -0700 | [diff] [blame] | 421 | } |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 422 | delete element; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 423 | |
| 424 | return it; |
| 425 | } |
| 426 | |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 427 | // Define a temporary mechanism to report the last LogBufferElement pointer |
| 428 | // for the specified uid, pid and tid. Used below to help merge-sort when |
| 429 | // pruning for worst UID. |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 430 | class LogBufferElementLast { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 431 | typedef std::unordered_map<uint64_t, LogBufferElement*> LogBufferElementMap; |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 432 | LogBufferElementMap map; |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 433 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 434 | public: |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 435 | bool coalesce(LogBufferElement* element, uint16_t dropped) { |
Tom Cherry | a515197 | 2020-05-15 11:39:58 -0700 | [diff] [blame] | 436 | uint64_t key = LogBufferElementKey(element->getUid(), element->getPid(), element->getTid()); |
| 437 | LogBufferElementMap::iterator it = map.find(key); |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 438 | if (it != map.end()) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 439 | LogBufferElement* found = it->second; |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 440 | uint16_t moreDropped = found->getDropped(); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 441 | if ((dropped + moreDropped) > USHRT_MAX) { |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 442 | map.erase(it); |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 443 | } else { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 444 | found->setDropped(dropped + moreDropped); |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 445 | return true; |
| 446 | } |
| 447 | } |
| 448 | return false; |
| 449 | } |
| 450 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 451 | void add(LogBufferElement* element) { |
Tom Cherry | a515197 | 2020-05-15 11:39:58 -0700 | [diff] [blame] | 452 | uint64_t key = LogBufferElementKey(element->getUid(), element->getPid(), element->getTid()); |
| 453 | map[key] = element; |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 454 | } |
| 455 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 456 | void clear() { map.clear(); } |
Mark Salyzyn | e06a6e0 | 2015-04-20 14:08:56 -0700 | [diff] [blame] | 457 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 458 | void clear(LogBufferElement* element) { |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 459 | uint64_t current = element->getRealTime().nsec() - (EXPIRE_RATELIMIT * NS_PER_SEC); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 460 | for (LogBufferElementMap::iterator it = map.begin(); it != map.end();) { |
| 461 | LogBufferElement* mapElement = it->second; |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 462 | if (mapElement->getDropped() >= EXPIRE_THRESHOLD && |
| 463 | current > mapElement->getRealTime().nsec()) { |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 464 | it = map.erase(it); |
| 465 | } else { |
| 466 | ++it; |
Mark Salyzyn | e06a6e0 | 2015-04-20 14:08:56 -0700 | [diff] [blame] | 467 | } |
| 468 | } |
| 469 | } |
Tom Cherry | a515197 | 2020-05-15 11:39:58 -0700 | [diff] [blame] | 470 | |
| 471 | private: |
| 472 | uint64_t LogBufferElementKey(uid_t uid, pid_t pid, pid_t tid) { |
| 473 | return uint64_t(uid) << 32 | uint64_t(pid) << 16 | uint64_t(tid); |
| 474 | } |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 475 | }; |
| 476 | |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 477 | // If the selected reader is blocking our pruning progress, decide on |
| 478 | // what kind of mitigation is necessary to unblock the situation. |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 479 | void ChattyLogBuffer::kickMe(LogReaderThread* me, log_id_t id, unsigned long pruneRows) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 480 | if (stats_->Sizes(id) > (2 * log_buffer_size(id))) { // +100% |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 481 | // A misbehaving or slow reader has its connection |
| 482 | // dropped if we hit too much memory pressure. |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 483 | android::prdebug("Kicking blocked reader, %s, from ChattyLogBuffer::kickMe()\n", |
| 484 | me->name().c_str()); |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 485 | me->release_Locked(); |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 486 | } else if (me->deadline().time_since_epoch().count() != 0) { |
| 487 | // Allow a blocked WRAP deadline reader to trigger and start reporting the log data. |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 488 | me->triggerReader_Locked(); |
| 489 | } else { |
| 490 | // tell slow reader to skip entries to catch up |
Tom Cherry | 21f16a0 | 2019-11-15 17:37:03 -0800 | [diff] [blame] | 491 | android::prdebug( |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 492 | "Skipping %lu entries from slow reader, %s, from ChattyLogBuffer::kickMe()\n", |
| 493 | pruneRows, me->name().c_str()); |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 494 | me->triggerSkip_Locked(id, pruneRows); |
| 495 | } |
| 496 | } |
| 497 | |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 498 | // prune "pruneRows" of type "id" from the buffer. |
| 499 | // |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 500 | // This garbage collection task is used to expire log entries. It is called to |
| 501 | // remove all logs (clear), all UID logs (unprivileged clear), or every |
| 502 | // 256 or 10% of the total logs (whichever is less) to prune the logs. |
| 503 | // |
| 504 | // First there is a prep phase where we discover the reader region lock that |
| 505 | // acts as a backstop to any pruning activity to stop there and go no further. |
| 506 | // |
| 507 | // There are three major pruning loops that follow. All expire from the oldest |
| 508 | // entries. Since there are multiple log buffers, the Android logging facility |
| 509 | // will appear to drop entries 'in the middle' when looking at multiple log |
| 510 | // sources and buffers. This effect is slightly more prominent when we prune |
| 511 | // the worst offender by logging source. Thus the logs slowly loose content |
| 512 | // and value as you move back in time. This is preferred since chatty sources |
| 513 | // invariably move the logs value down faster as less chatty sources would be |
| 514 | // expired in the noise. |
| 515 | // |
| 516 | // The first loop performs blacklisting and worst offender pruning. Falling |
| 517 | // through when there are no notable worst offenders and have not hit the |
| 518 | // region lock preventing further worst offender pruning. This loop also looks |
| 519 | // after managing the chatty log entries and merging to help provide |
| 520 | // statistical basis for blame. The chatty entries are not a notification of |
| 521 | // how much logs you may have, but instead represent how much logs you would |
| 522 | // have had in a virtual log buffer that is extended to cover all the in-memory |
| 523 | // logs without loss. They last much longer than the represented pruned logs |
| 524 | // since they get multiplied by the gains in the non-chatty log sources. |
| 525 | // |
| 526 | // The second loop get complicated because an algorithm of watermarks and |
| 527 | // history is maintained to reduce the order and keep processing time |
| 528 | // down to a minimum at scale. These algorithms can be costly in the face |
| 529 | // of larger log buffers, or severly limited processing time granted to a |
| 530 | // background task at lowest priority. |
| 531 | // |
| 532 | // This second loop does straight-up expiration from the end of the logs |
| 533 | // (again, remember for the specified log buffer id) but does some whitelist |
| 534 | // preservation. Thus whitelist is a Hail Mary low priority, blacklists and |
| 535 | // spam filtration all take priority. This second loop also checks if a region |
| 536 | // lock is causing us to buffer too much in the logs to help the reader(s), |
| 537 | // and will tell the slowest reader thread to skip log entries, and if |
| 538 | // persistent and hits a further threshold, kill the reader thread. |
| 539 | // |
| 540 | // The third thread is optional, and only gets hit if there was a whitelist |
| 541 | // and more needs to be pruned against the backstop of the region lock. |
| 542 | // |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 543 | // ChattyLogBuffer::wrlock() must be held when this function is called. |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 544 | // |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 545 | bool ChattyLogBuffer::prune(log_id_t id, unsigned long pruneRows, uid_t caller_uid) { |
Tom Cherry | 6ec71e9 | 2020-05-04 12:53:36 -0700 | [diff] [blame] | 546 | LogReaderThread* oldest = nullptr; |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 547 | bool busy = false; |
Mark Salyzyn | 2b25c66 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 548 | bool clearAll = pruneRows == ULONG_MAX; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 549 | |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 550 | auto reader_threads_lock = std::lock_guard{reader_list_->reader_threads_lock()}; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 551 | |
| 552 | // Region locked? |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 553 | for (const auto& reader_thread : reader_list_->reader_threads()) { |
| 554 | if (!reader_thread->IsWatching(id)) { |
| 555 | continue; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 556 | } |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 557 | if (!oldest || oldest->start() > reader_thread->start() || |
| 558 | (oldest->start() == reader_thread->start() && |
| 559 | reader_thread->deadline().time_since_epoch().count() != 0)) { |
| 560 | oldest = reader_thread.get(); |
| 561 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 562 | } |
| 563 | |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 564 | LogBufferElementCollection::iterator it; |
| 565 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 566 | if (__predict_false(caller_uid != AID_ROOT)) { // unlikely |
Mark Salyzyn | 43a5f31 | 2016-09-01 15:48:36 -0700 | [diff] [blame] | 567 | // Only here if clear all request from non system source, so chatty |
| 568 | // filter logistics is not required. |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 569 | it = GetOldest(id); |
Mark Salyzyn | 507eb9f | 2016-01-11 10:58:09 -0800 | [diff] [blame] | 570 | while (it != mLogElements.end()) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 571 | LogBufferElement* element = *it; |
Mark Salyzyn | 1a240b4 | 2014-06-12 11:16:16 -0700 | [diff] [blame] | 572 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 573 | if (element->getLogId() != id || element->getUid() != caller_uid) { |
Mark Salyzyn | 2b25c66 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 574 | ++it; |
| 575 | continue; |
| 576 | } |
| 577 | |
Tom Cherry | cef47bb | 2020-05-04 17:10:16 -0700 | [diff] [blame] | 578 | if (oldest && oldest->start() <= element->getSequence()) { |
Tom Cherry | 5e26655 | 2020-04-08 10:47:26 -0700 | [diff] [blame] | 579 | busy = true; |
| 580 | kickMe(oldest, id, pruneRows); |
Mark Salyzyn | 1a240b4 | 2014-06-12 11:16:16 -0700 | [diff] [blame] | 581 | break; |
| 582 | } |
| 583 | |
Mark Salyzyn | 2b25c66 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 584 | it = erase(it); |
Mark Salyzyn | 43a5f31 | 2016-09-01 15:48:36 -0700 | [diff] [blame] | 585 | if (--pruneRows == 0) { |
| 586 | break; |
| 587 | } |
Mark Salyzyn | 1a240b4 | 2014-06-12 11:16:16 -0700 | [diff] [blame] | 588 | } |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 589 | return busy; |
Mark Salyzyn | 1a240b4 | 2014-06-12 11:16:16 -0700 | [diff] [blame] | 590 | } |
| 591 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 592 | // prune by worst offenders; by blacklist, UID, and by PID of system UID |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 593 | bool hasBlacklist = (id != LOG_ID_SECURITY) && prune_->naughty(); |
Mark Salyzyn | 2b25c66 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 594 | while (!clearAll && (pruneRows > 0)) { |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 595 | // recalculate the worst offender on every batched pass |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 596 | int worst = -1; // not valid for getUid() or getKey() |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 597 | size_t worst_sizes = 0; |
| 598 | size_t second_worst_sizes = 0; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 599 | pid_t worstPid = 0; // POSIX guarantees PID != 0 |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 600 | |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 601 | if (worstUidEnabledForLogid(id) && prune_->worstUidEnabled()) { |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 602 | // Calculate threshold as 12.5% of available storage |
| 603 | size_t threshold = log_buffer_size(id) / 8; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 604 | |
Tom Cherry | b6b78e9 | 2020-05-07 09:13:12 -0700 | [diff] [blame] | 605 | if (id == LOG_ID_EVENTS || id == LOG_ID_SECURITY) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 606 | stats_->WorstTwoTags(threshold, &worst, &worst_sizes, &second_worst_sizes); |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 607 | // per-pid filter for AID_SYSTEM sources is too complex |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 608 | } else { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 609 | stats_->WorstTwoUids(id, threshold, &worst, &worst_sizes, &second_worst_sizes); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 610 | |
Tom Cherry | b6b78e9 | 2020-05-07 09:13:12 -0700 | [diff] [blame] | 611 | if (worst == AID_SYSTEM && prune_->worstPidOfSystemEnabled()) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 612 | stats_->WorstTwoSystemPids(id, worst_sizes, &worstPid, &second_worst_sizes); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 613 | } |
| 614 | } |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 615 | } |
| 616 | |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 617 | // skip if we have neither worst nor naughty filters |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 618 | if ((worst == -1) && !hasBlacklist) { |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 619 | break; |
| 620 | } |
| 621 | |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 622 | bool kick = false; |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 623 | bool leading = true; // true if starting from the oldest log entry, false if starting from |
| 624 | // a specific chatty entry. |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 625 | // Perform at least one mandatory garbage collection cycle in following |
| 626 | // - clear leading chatty tags |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 627 | // - coalesce chatty tags |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 628 | // - check age-out of preserved logs |
| 629 | bool gc = pruneRows <= 1; |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 630 | if (!gc && (worst != -1)) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 631 | { // begin scope for worst found iterator |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 632 | LogBufferIteratorMap::iterator found = mLastWorst[id].find(worst); |
| 633 | if (found != mLastWorst[id].end() && found->second != mLogElements.end()) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 634 | leading = false; |
| 635 | it = found->second; |
| 636 | } |
| 637 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 638 | if (worstPid) { // begin scope for pid worst found iterator |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 639 | // FYI: worstPid only set if !LOG_ID_EVENTS and |
| 640 | // !LOG_ID_SECURITY, not going to make that assumption ... |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 641 | LogBufferPidIteratorMap::iterator found = mLastWorstPidOfSystem[id].find(worstPid); |
| 642 | if (found != mLastWorstPidOfSystem[id].end() && |
| 643 | found->second != mLogElements.end()) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 644 | leading = false; |
| 645 | it = found->second; |
| 646 | } |
Mark Salyzyn | c892ea3 | 2015-08-19 17:06:11 -0700 | [diff] [blame] | 647 | } |
| 648 | } |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 649 | if (leading) { |
| 650 | it = GetOldest(id); |
| 651 | } |
Tom Cherry | bd80e56 | 2020-05-18 08:58:50 -0700 | [diff] [blame] | 652 | static const log_time too_old{EXPIRE_HOUR_THRESHOLD * 60 * 60, 0}; |
Mark Salyzyn | ccfe844 | 2015-08-24 13:43:27 -0700 | [diff] [blame] | 653 | LogBufferElementCollection::iterator lastt; |
| 654 | lastt = mLogElements.end(); |
| 655 | --lastt; |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 656 | LogBufferElementLast last; |
Mark Salyzyn | c892ea3 | 2015-08-19 17:06:11 -0700 | [diff] [blame] | 657 | while (it != mLogElements.end()) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 658 | LogBufferElement* element = *it; |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 659 | |
Tom Cherry | cef47bb | 2020-05-04 17:10:16 -0700 | [diff] [blame] | 660 | if (oldest && oldest->start() <= element->getSequence()) { |
Tom Cherry | 5e26655 | 2020-04-08 10:47:26 -0700 | [diff] [blame] | 661 | busy = true; |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 662 | // Do not let chatty eliding trigger any reader mitigation |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 663 | break; |
| 664 | } |
| 665 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 666 | if (element->getLogId() != id) { |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 667 | ++it; |
| 668 | continue; |
| 669 | } |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 670 | // below this point element->getLogId() == id |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 671 | |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 672 | uint16_t dropped = element->getDropped(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 673 | |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 674 | // remove any leading drops |
| 675 | if (leading && dropped) { |
| 676 | it = erase(it); |
| 677 | continue; |
| 678 | } |
| 679 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 680 | if (dropped && last.coalesce(element, dropped)) { |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 681 | it = erase(it, true); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 682 | continue; |
| 683 | } |
| 684 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 685 | int key = (id == LOG_ID_EVENTS || id == LOG_ID_SECURITY) ? element->getTag() |
| 686 | : element->getUid(); |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 687 | |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 688 | if (hasBlacklist && prune_->naughty(element)) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 689 | last.clear(element); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 690 | it = erase(it); |
| 691 | if (dropped) { |
| 692 | continue; |
| 693 | } |
| 694 | |
| 695 | pruneRows--; |
| 696 | if (pruneRows == 0) { |
| 697 | break; |
| 698 | } |
| 699 | |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 700 | if (key == worst) { |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 701 | kick = true; |
| 702 | if (worst_sizes < second_worst_sizes) { |
| 703 | break; |
| 704 | } |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 705 | worst_sizes -= element->getMsgLen(); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 706 | } |
| 707 | continue; |
| 708 | } |
| 709 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 710 | if ((element->getRealTime() < ((*lastt)->getRealTime() - too_old)) || |
| 711 | (element->getRealTime() > (*lastt)->getRealTime())) { |
Mark Salyzyn | ccfe844 | 2015-08-24 13:43:27 -0700 | [diff] [blame] | 712 | break; |
| 713 | } |
| 714 | |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 715 | if (dropped) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 716 | last.add(element); |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 717 | if (worstPid && ((!gc && element->getPid() == worstPid) || |
| 718 | mLastWorstPidOfSystem[id].find(element->getPid()) == |
| 719 | mLastWorstPidOfSystem[id].end())) { |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 720 | // element->getUid() may not be AID_SYSTEM, next best |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 721 | // watermark if current one empty. id is not LOG_ID_EVENTS |
| 722 | // or LOG_ID_SECURITY because of worstPid check. |
Mark Salyzyn | 1eefca2 | 2016-09-01 07:28:44 -0700 | [diff] [blame] | 723 | mLastWorstPidOfSystem[id][element->getPid()] = it; |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 724 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 725 | if ((!gc && !worstPid && (key == worst)) || |
| 726 | (mLastWorst[id].find(key) == mLastWorst[id].end())) { |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 727 | mLastWorst[id][key] = it; |
Mark Salyzyn | 49afe0d | 2015-08-24 13:43:27 -0700 | [diff] [blame] | 728 | } |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 729 | ++it; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 730 | continue; |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 731 | } |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 732 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 733 | if (key != worst || (worstPid && element->getPid() != worstPid)) { |
Mark Salyzyn | 5921276 | 2015-06-01 09:41:19 -0700 | [diff] [blame] | 734 | leading = false; |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 735 | last.clear(element); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 736 | ++it; |
| 737 | continue; |
| 738 | } |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 739 | // key == worst below here |
| 740 | // If worstPid set, then element->getPid() == worstPid below here |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 741 | |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 742 | pruneRows--; |
| 743 | if (pruneRows == 0) { |
| 744 | break; |
| 745 | } |
| 746 | |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 747 | kick = true; |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 748 | |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 749 | uint16_t len = element->getMsgLen(); |
Mark Salyzyn | 5392aac | 2015-05-22 10:03:31 -0700 | [diff] [blame] | 750 | |
| 751 | // do not create any leading drops |
| 752 | if (leading) { |
| 753 | it = erase(it); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 754 | } else { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 755 | stats_->Drop(element); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 756 | element->setDropped(1); |
| 757 | if (last.coalesce(element, 1)) { |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 758 | it = erase(it, true); |
Mark Salyzyn | 5392aac | 2015-05-22 10:03:31 -0700 | [diff] [blame] | 759 | } else { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 760 | last.add(element); |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 761 | if (worstPid && (!gc || mLastWorstPidOfSystem[id].find(worstPid) == |
| 762 | mLastWorstPidOfSystem[id].end())) { |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 763 | // element->getUid() may not be AID_SYSTEM, next best |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 764 | // watermark if current one empty. id is not |
| 765 | // LOG_ID_EVENTS or LOG_ID_SECURITY because of worstPid. |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 766 | mLastWorstPidOfSystem[id][worstPid] = it; |
| 767 | } |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 768 | if ((!gc && !worstPid) || mLastWorst[id].find(worst) == mLastWorst[id].end()) { |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 769 | mLastWorst[id][worst] = it; |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 770 | } |
Mark Salyzyn | 5392aac | 2015-05-22 10:03:31 -0700 | [diff] [blame] | 771 | ++it; |
| 772 | } |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 773 | } |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 774 | if (worst_sizes < second_worst_sizes) { |
| 775 | break; |
| 776 | } |
| 777 | worst_sizes -= len; |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 778 | } |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 779 | last.clear(); |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 780 | |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 781 | if (!kick || !prune_->worstUidEnabled()) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 782 | break; // the following loop will ask bad clients to skip/drop |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 783 | } |
| 784 | } |
| 785 | |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 786 | bool whitelist = false; |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 787 | bool hasWhitelist = (id != LOG_ID_SECURITY) && prune_->nice() && !clearAll; |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 788 | it = GetOldest(id); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 789 | while ((pruneRows > 0) && (it != mLogElements.end())) { |
| 790 | LogBufferElement* element = *it; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 791 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 792 | if (element->getLogId() != id) { |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 793 | it++; |
| 794 | continue; |
| 795 | } |
| 796 | |
Tom Cherry | cef47bb | 2020-05-04 17:10:16 -0700 | [diff] [blame] | 797 | if (oldest && oldest->start() <= element->getSequence()) { |
Tom Cherry | 5e26655 | 2020-04-08 10:47:26 -0700 | [diff] [blame] | 798 | busy = true; |
| 799 | if (!whitelist) kickMe(oldest, id, pruneRows); |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 800 | break; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 801 | } |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 802 | |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 803 | if (hasWhitelist && !element->getDropped() && prune_->nice(element)) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 804 | // WhiteListed |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 805 | whitelist = true; |
| 806 | it++; |
| 807 | continue; |
| 808 | } |
| 809 | |
| 810 | it = erase(it); |
| 811 | pruneRows--; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 812 | } |
| 813 | |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 814 | // Do not save the whitelist if we are reader range limited |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 815 | if (whitelist && (pruneRows > 0)) { |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 816 | it = GetOldest(id); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 817 | while ((it != mLogElements.end()) && (pruneRows > 0)) { |
| 818 | LogBufferElement* element = *it; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 819 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 820 | if (element->getLogId() != id) { |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 821 | ++it; |
| 822 | continue; |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 823 | } |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 824 | |
Tom Cherry | cef47bb | 2020-05-04 17:10:16 -0700 | [diff] [blame] | 825 | if (oldest && oldest->start() <= element->getSequence()) { |
Tom Cherry | 5e26655 | 2020-04-08 10:47:26 -0700 | [diff] [blame] | 826 | busy = true; |
| 827 | kickMe(oldest, id, pruneRows); |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 828 | break; |
| 829 | } |
| 830 | |
| 831 | it = erase(it); |
| 832 | pruneRows--; |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 833 | } |
| 834 | } |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 835 | |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 836 | return (pruneRows > 0) && busy; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 837 | } |
| 838 | |
| 839 | // clear all rows of type "id" from the buffer. |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 840 | bool ChattyLogBuffer::Clear(log_id_t id, uid_t uid) { |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 841 | bool busy = true; |
| 842 | // If it takes more than 4 tries (seconds) to clear, then kill reader(s) |
| 843 | for (int retry = 4;;) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 844 | if (retry == 1) { // last pass |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 845 | // Check if it is still busy after the sleep, we say prune |
| 846 | // one entry, not another clear run, so we are looking for |
| 847 | // the quick side effect of the return value to tell us if |
| 848 | // we have a _blocked_ reader. |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 849 | wrlock(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 850 | busy = prune(id, 1, uid); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 851 | unlock(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 852 | // It is still busy, blocked reader(s), lets kill them all! |
| 853 | // otherwise, lets be a good citizen and preserve the slow |
| 854 | // readers and let the clear run (below) deal with determining |
| 855 | // if we are still blocked and return an error code to caller. |
| 856 | if (busy) { |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 857 | auto reader_threads_lock = std::lock_guard{reader_list_->reader_threads_lock()}; |
| 858 | for (const auto& reader_thread : reader_list_->reader_threads()) { |
| 859 | if (reader_thread->IsWatching(id)) { |
Tom Cherry | 21f16a0 | 2019-11-15 17:37:03 -0800 | [diff] [blame] | 860 | android::prdebug( |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 861 | "Kicking blocked reader, %s, from ChattyLogBuffer::clear()\n", |
| 862 | reader_thread->name().c_str()); |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 863 | reader_thread->release_Locked(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 864 | } |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 865 | } |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 866 | } |
| 867 | } |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 868 | wrlock(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 869 | busy = prune(id, ULONG_MAX, uid); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 870 | unlock(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 871 | if (!busy || !--retry) { |
| 872 | break; |
| 873 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 874 | sleep(1); // Let reader(s) catch up after notification |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 875 | } |
| 876 | return busy; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 877 | } |
| 878 | |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 879 | // set the total space allocated to "id" |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 880 | int ChattyLogBuffer::SetSize(log_id_t id, unsigned long size) { |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 881 | // Reasonable limits ... |
Mark Salyzyn | f10e273 | 2016-09-27 13:08:23 -0700 | [diff] [blame] | 882 | if (!__android_logger_valid_buffer_size(size)) { |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 883 | return -1; |
| 884 | } |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 885 | wrlock(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 886 | log_buffer_size(id) = size; |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 887 | unlock(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 888 | return 0; |
| 889 | } |
| 890 | |
| 891 | // get the total space allocated to "id" |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 892 | unsigned long ChattyLogBuffer::GetSize(log_id_t id) { |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 893 | rdlock(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 894 | size_t retval = log_buffer_size(id); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 895 | unlock(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 896 | return retval; |
| 897 | } |
| 898 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 899 | uint64_t ChattyLogBuffer::FlushTo( |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 900 | LogWriter* writer, uint64_t start, pid_t* lastTid, |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 901 | const std::function<FlushToResult(const LogBufferElement* element)>& filter) { |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 902 | LogBufferElementCollection::iterator it; |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 903 | uid_t uid = writer->uid(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 904 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 905 | rdlock(); |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 906 | |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 907 | if (start <= 1) { |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 908 | // client wants to start from the beginning |
| 909 | it = mLogElements.begin(); |
| 910 | } else { |
| 911 | // Client wants to start from some specified time. Chances are |
| 912 | // we are better off starting from the end of the time sorted list. |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 913 | for (it = mLogElements.end(); it != mLogElements.begin(); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 914 | /* do nothing */) { |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 915 | --it; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 916 | LogBufferElement* element = *it; |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 917 | if (element->getSequence() <= start) { |
| 918 | it++; |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 919 | break; |
| 920 | } |
| 921 | } |
| 922 | } |
| 923 | |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 924 | uint64_t curr = start; |
Mark Salyzyn | b5b8796 | 2017-01-23 14:20:31 -0800 | [diff] [blame] | 925 | |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 926 | for (; it != mLogElements.end(); ++it) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 927 | LogBufferElement* element = *it; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 928 | |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 929 | if (!writer->privileged() && element->getUid() != uid) { |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 930 | continue; |
| 931 | } |
| 932 | |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 933 | if (!writer->can_read_security_logs() && element->getLogId() == LOG_ID_SECURITY) { |
Mark Salyzyn | 8fa8896 | 2016-01-26 14:32:35 -0800 | [diff] [blame] | 934 | continue; |
| 935 | } |
| 936 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 937 | // NB: calling out to another object with wrlock() held (safe) |
Mark Salyzyn | f7c0f75 | 2015-03-03 13:39:37 -0800 | [diff] [blame] | 938 | if (filter) { |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 939 | FlushToResult ret = filter(element); |
| 940 | if (ret == FlushToResult::kSkip) { |
Mark Salyzyn | f7c0f75 | 2015-03-03 13:39:37 -0800 | [diff] [blame] | 941 | continue; |
| 942 | } |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 943 | if (ret == FlushToResult::kStop) { |
Mark Salyzyn | f7c0f75 | 2015-03-03 13:39:37 -0800 | [diff] [blame] | 944 | break; |
| 945 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 946 | } |
| 947 | |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 948 | bool sameTid = false; |
| 949 | if (lastTid) { |
| 950 | sameTid = lastTid[element->getLogId()] == element->getTid(); |
| 951 | // Dropped (chatty) immediately following a valid log from the |
| 952 | // same source in the same log buffer indicates we have a |
| 953 | // multiple identical squash. chatty that differs source |
| 954 | // is due to spam filter. chatty to chatty of different |
| 955 | // source is also due to spam filter. |
| 956 | lastTid[element->getLogId()] = |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 957 | (element->getDropped() && !sameTid) ? 0 : element->getTid(); |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 958 | } |
Mark Salyzyn | b5b8796 | 2017-01-23 14:20:31 -0800 | [diff] [blame] | 959 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 960 | unlock(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 961 | |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 962 | curr = element->getSequence(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 963 | // range locking in LastLogTimes looks after us |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 964 | if (!element->FlushTo(writer, stats_, sameTid)) { |
| 965 | return FLUSH_ERROR; |
Mark Salyzyn | eb45db2 | 2017-05-17 19:55:12 +0000 | [diff] [blame] | 966 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 967 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 968 | rdlock(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 969 | } |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 970 | unlock(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 971 | |
Mark Salyzyn | 206ed8e | 2017-05-18 10:06:00 -0700 | [diff] [blame] | 972 | return curr; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 973 | } |