Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2012-2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 16 | // for manual checking of stale entries during ChattyLogBuffer::erase() |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 17 | //#define DEBUG_CHECK_FOR_STALE_ENTRIES |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 18 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 19 | #include "ChattyLogBuffer.h" |
| 20 | |
Mark Salyzyn | 671e343 | 2014-05-06 07:34:59 -0700 | [diff] [blame] | 21 | #include <ctype.h> |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 22 | #include <endian.h> |
Mark Salyzyn | 202e153 | 2015-02-09 08:21:05 -0800 | [diff] [blame] | 23 | #include <errno.h> |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 24 | #include <stdio.h> |
| 25 | #include <string.h> |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 26 | #include <sys/cdefs.h> |
Mark Salyzyn | 57a0af9 | 2014-05-09 17:44:18 -0700 | [diff] [blame] | 27 | #include <sys/user.h> |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 28 | #include <time.h> |
| 29 | #include <unistd.h> |
| 30 | |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 31 | #include <unordered_map> |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 32 | #include <utility> |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 33 | |
Mark Salyzyn | f10e273 | 2016-09-27 13:08:23 -0700 | [diff] [blame] | 34 | #include <private/android_logger.h> |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 35 | |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 36 | #include "LogUtils.h" |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 37 | |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 38 | #ifndef __predict_false |
| 39 | #define __predict_false(exp) __builtin_expect((exp) != 0, 0) |
| 40 | #endif |
| 41 | |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 42 | // Default |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 43 | #define log_buffer_size(id) mMaxSize[id] |
Mark Salyzyn | 671e343 | 2014-05-06 07:34:59 -0700 | [diff] [blame] | 44 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 45 | void ChattyLogBuffer::Init() { |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 46 | log_id_for_each(i) { |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 47 | if (SetSize(i, __android_logger_get_buffer_size(i))) { |
| 48 | SetSize(i, LOG_BUFFER_MIN_SIZE); |
Mark Salyzyn | 57a0af9 | 2014-05-09 17:44:18 -0700 | [diff] [blame] | 49 | } |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 50 | } |
Tom Cherry | e170d1a | 2020-05-01 16:45:25 -0700 | [diff] [blame] | 51 | // Release any sleeping reader threads to dump their current content. |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 52 | auto reader_threads_lock = std::lock_guard{reader_list_->reader_threads_lock()}; |
| 53 | for (const auto& reader_thread : reader_list_->reader_threads()) { |
| 54 | reader_thread->triggerReader_Locked(); |
Mark Salyzyn | b6bee33 | 2015-09-08 08:56:32 -0700 | [diff] [blame] | 55 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 56 | } |
| 57 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 58 | ChattyLogBuffer::ChattyLogBuffer(LogReaderList* reader_list, LogTags* tags, PruneList* prune, |
| 59 | LogStatistics* stats) |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 60 | : reader_list_(reader_list), tags_(tags), prune_(prune), stats_(stats) { |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 61 | pthread_rwlock_init(&mLogElementsLock, nullptr); |
Mark Salyzyn | 11e55cb | 2015-03-10 16:45:17 -0700 | [diff] [blame] | 62 | |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 63 | log_id_for_each(i) { |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 64 | lastLoggedElements[i] = nullptr; |
| 65 | droppedElements[i] = nullptr; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 66 | } |
| 67 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 68 | Init(); |
Mark Salyzyn | 11e55cb | 2015-03-10 16:45:17 -0700 | [diff] [blame] | 69 | } |
| 70 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 71 | ChattyLogBuffer::~ChattyLogBuffer() { |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 72 | log_id_for_each(i) { |
| 73 | delete lastLoggedElements[i]; |
| 74 | delete droppedElements[i]; |
| 75 | } |
| 76 | } |
| 77 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 78 | LogBufferElementCollection::iterator ChattyLogBuffer::GetOldest(log_id_t log_id) { |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 79 | auto it = mLogElements.begin(); |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 80 | if (oldest_[log_id]) { |
| 81 | it = *oldest_[log_id]; |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 82 | } |
| 83 | while (it != mLogElements.end() && (*it)->getLogId() != log_id) { |
| 84 | it++; |
| 85 | } |
| 86 | if (it != mLogElements.end()) { |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 87 | oldest_[log_id] = it; |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 88 | } |
| 89 | return it; |
| 90 | } |
| 91 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 92 | enum match_type { DIFFERENT, SAME, SAME_LIBLOG }; |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 93 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 94 | static enum match_type identical(LogBufferElement* elem, LogBufferElement* last) { |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 95 | // is it mostly identical? |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 96 | // if (!elem) return DIFFERENT; |
Mark Salyzyn | 0484b3b | 2016-08-11 08:02:06 -0700 | [diff] [blame] | 97 | ssize_t lenl = elem->getMsgLen(); |
| 98 | if (lenl <= 0) return DIFFERENT; // value if this represents a chatty elem |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 99 | // if (!last) return DIFFERENT; |
Mark Salyzyn | 0484b3b | 2016-08-11 08:02:06 -0700 | [diff] [blame] | 100 | ssize_t lenr = last->getMsgLen(); |
| 101 | if (lenr <= 0) return DIFFERENT; // value if this represents a chatty elem |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 102 | // if (elem->getLogId() != last->getLogId()) return DIFFERENT; |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 103 | if (elem->getUid() != last->getUid()) return DIFFERENT; |
| 104 | if (elem->getPid() != last->getPid()) return DIFFERENT; |
| 105 | if (elem->getTid() != last->getTid()) return DIFFERENT; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 106 | |
| 107 | // last is more than a minute old, stop squashing identical messages |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 108 | if (elem->getRealTime().nsec() > (last->getRealTime().nsec() + 60 * NS_PER_SEC)) |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 109 | return DIFFERENT; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 110 | |
| 111 | // Identical message |
| 112 | const char* msgl = elem->getMsg(); |
| 113 | const char* msgr = last->getMsg(); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 114 | if (lenl == lenr) { |
| 115 | if (!fastcmp<memcmp>(msgl, msgr, lenl)) return SAME; |
| 116 | // liblog tagged messages (content gets summed) |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 117 | if (elem->getLogId() == LOG_ID_EVENTS && lenl == sizeof(android_log_event_int_t) && |
| 118 | !fastcmp<memcmp>(msgl, msgr, sizeof(android_log_event_int_t) - sizeof(int32_t)) && |
| 119 | elem->getTag() == LIBLOG_LOG_TAG) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 120 | return SAME_LIBLOG; |
Mark Salyzyn | 1598fe0 | 2017-03-13 15:41:59 -0700 | [diff] [blame] | 121 | } |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 122 | } |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 123 | |
| 124 | // audit message (except sequence number) identical? |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 125 | if (last->isBinary() && lenl > static_cast<ssize_t>(sizeof(android_log_event_string_t)) && |
| 126 | lenr > static_cast<ssize_t>(sizeof(android_log_event_string_t))) { |
| 127 | if (fastcmp<memcmp>(msgl, msgr, sizeof(android_log_event_string_t) - sizeof(int32_t))) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 128 | return DIFFERENT; |
Mark Salyzyn | 1598fe0 | 2017-03-13 15:41:59 -0700 | [diff] [blame] | 129 | } |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 130 | msgl += sizeof(android_log_event_string_t); |
| 131 | lenl -= sizeof(android_log_event_string_t); |
| 132 | msgr += sizeof(android_log_event_string_t); |
| 133 | lenr -= sizeof(android_log_event_string_t); |
| 134 | } |
Mark Salyzyn | 0484b3b | 2016-08-11 08:02:06 -0700 | [diff] [blame] | 135 | static const char avc[] = "): avc: "; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 136 | const char* avcl = android::strnstr(msgl, lenl, avc); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 137 | if (!avcl) return DIFFERENT; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 138 | lenl -= avcl - msgl; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 139 | const char* avcr = android::strnstr(msgr, lenr, avc); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 140 | if (!avcr) return DIFFERENT; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 141 | lenr -= avcr - msgr; |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 142 | if (lenl != lenr) return DIFFERENT; |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 143 | if (fastcmp<memcmp>(avcl + strlen(avc), avcr + strlen(avc), lenl - strlen(avc))) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 144 | return DIFFERENT; |
Mark Salyzyn | 1598fe0 | 2017-03-13 15:41:59 -0700 | [diff] [blame] | 145 | } |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 146 | return SAME; |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 147 | } |
| 148 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 149 | int ChattyLogBuffer::Log(log_id_t log_id, log_time realtime, uid_t uid, pid_t pid, pid_t tid, |
| 150 | const char* msg, uint16_t len) { |
Yi Kong | 141ccee | 2018-03-01 17:48:53 -0500 | [diff] [blame] | 151 | if (log_id >= LOG_ID_MAX) { |
Mark Salyzyn | 202e153 | 2015-02-09 08:21:05 -0800 | [diff] [blame] | 152 | return -EINVAL; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 153 | } |
Mark Salyzyn | e59c469 | 2014-10-02 13:07:05 -0700 | [diff] [blame] | 154 | |
Mark Salyzyn | 206ed8e | 2017-05-18 10:06:00 -0700 | [diff] [blame] | 155 | // Slip the time by 1 nsec if the incoming lands on xxxxxx000 ns. |
| 156 | // This prevents any chance that an outside source can request an |
| 157 | // exact entry with time specified in ms or us precision. |
| 158 | if ((realtime.tv_nsec % 1000) == 0) ++realtime.tv_nsec; |
| 159 | |
Tom Cherry | 2ac86de | 2020-02-20 13:21:51 -0800 | [diff] [blame] | 160 | LogBufferElement* elem = new LogBufferElement(log_id, realtime, uid, pid, tid, msg, len); |
| 161 | |
| 162 | // b/137093665: don't coalesce security messages. |
| 163 | if (log_id == LOG_ID_SECURITY) { |
| 164 | wrlock(); |
| 165 | log(elem); |
| 166 | unlock(); |
| 167 | |
| 168 | return len; |
| 169 | } |
| 170 | |
| 171 | int prio = ANDROID_LOG_INFO; |
| 172 | const char* tag = nullptr; |
| 173 | size_t tag_len = 0; |
| 174 | if (log_id == LOG_ID_EVENTS || log_id == LOG_ID_STATS) { |
Tom Cherry | 1a12ae3 | 2020-05-01 16:13:18 -0700 | [diff] [blame] | 175 | tag = tags_->tagToName(elem->getTag()); |
Tom Cherry | 2ac86de | 2020-02-20 13:21:51 -0800 | [diff] [blame] | 176 | if (tag) { |
| 177 | tag_len = strlen(tag); |
Mark Salyzyn | 083b037 | 2015-12-04 10:59:45 -0800 | [diff] [blame] | 178 | } |
Tom Cherry | 2ac86de | 2020-02-20 13:21:51 -0800 | [diff] [blame] | 179 | } else { |
| 180 | prio = *msg; |
| 181 | tag = msg + 1; |
| 182 | tag_len = strnlen(tag, len - 1); |
| 183 | } |
| 184 | if (!__android_log_is_loggable_len(prio, tag, tag_len, ANDROID_LOG_VERBOSE)) { |
| 185 | // Log traffic received to total |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 186 | stats_->AddTotal(elem); |
Tom Cherry | 2ac86de | 2020-02-20 13:21:51 -0800 | [diff] [blame] | 187 | delete elem; |
| 188 | return -EACCES; |
Mark Salyzyn | e59c469 | 2014-10-02 13:07:05 -0700 | [diff] [blame] | 189 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 190 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 191 | wrlock(); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 192 | LogBufferElement* currentLast = lastLoggedElements[log_id]; |
| 193 | if (currentLast) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 194 | LogBufferElement* dropped = droppedElements[log_id]; |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 195 | uint16_t count = dropped ? dropped->getDropped() : 0; |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 196 | // |
| 197 | // State Init |
| 198 | // incoming: |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 199 | // dropped = nullptr |
| 200 | // currentLast = nullptr; |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 201 | // elem = incoming message |
| 202 | // outgoing: |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 203 | // dropped = nullptr -> State 0 |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 204 | // currentLast = copy of elem |
| 205 | // log elem |
| 206 | // State 0 |
| 207 | // incoming: |
| 208 | // count = 0 |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 209 | // dropped = nullptr |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 210 | // currentLast = copy of last message |
| 211 | // elem = incoming message |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 212 | // outgoing: if match != DIFFERENT |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 213 | // dropped = copy of first identical message -> State 1 |
| 214 | // currentLast = reference to elem |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 215 | // break: if match == DIFFERENT |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 216 | // dropped = nullptr -> State 0 |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 217 | // delete copy of last message (incoming currentLast) |
| 218 | // currentLast = copy of elem |
| 219 | // log elem |
| 220 | // State 1 |
| 221 | // incoming: |
| 222 | // count = 0 |
| 223 | // dropped = copy of first identical message |
| 224 | // currentLast = reference to last held-back incoming |
| 225 | // message |
| 226 | // elem = incoming message |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 227 | // outgoing: if match == SAME |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 228 | // delete copy of first identical message (dropped) |
| 229 | // dropped = reference to last held-back incoming |
| 230 | // message set to chatty count of 1 -> State 2 |
| 231 | // currentLast = reference to elem |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 232 | // outgoing: if match == SAME_LIBLOG |
| 233 | // dropped = copy of first identical message -> State 1 |
| 234 | // take sum of currentLast and elem |
| 235 | // if sum overflows: |
| 236 | // log currentLast |
| 237 | // currentLast = reference to elem |
| 238 | // else |
| 239 | // delete currentLast |
| 240 | // currentLast = reference to elem, sum liblog. |
| 241 | // break: if match == DIFFERENT |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 242 | // delete dropped |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 243 | // dropped = nullptr -> State 0 |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 244 | // log reference to last held-back (currentLast) |
| 245 | // currentLast = copy of elem |
| 246 | // log elem |
| 247 | // State 2 |
| 248 | // incoming: |
| 249 | // count = chatty count |
| 250 | // dropped = chatty message holding count |
| 251 | // currentLast = reference to last held-back incoming |
| 252 | // message. |
| 253 | // dropped = chatty message holding count |
| 254 | // elem = incoming message |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 255 | // outgoing: if match != DIFFERENT |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 256 | // delete chatty message holding count |
| 257 | // dropped = reference to last held-back incoming |
| 258 | // message, set to chatty count + 1 |
| 259 | // currentLast = reference to elem |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 260 | // break: if match == DIFFERENT |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 261 | // log dropped (chatty message) |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 262 | // dropped = nullptr -> State 0 |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 263 | // log reference to last held-back (currentLast) |
| 264 | // currentLast = copy of elem |
| 265 | // log elem |
| 266 | // |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 267 | enum match_type match = identical(elem, currentLast); |
| 268 | if (match != DIFFERENT) { |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 269 | if (dropped) { |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 270 | // Sum up liblog tag messages? |
| 271 | if ((count == 0) /* at Pass 1 */ && (match == SAME_LIBLOG)) { |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 272 | android_log_event_int_t* event = reinterpret_cast<android_log_event_int_t*>( |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 273 | const_cast<char*>(currentLast->getMsg())); |
| 274 | // |
| 275 | // To unit test, differentiate with something like: |
| 276 | // event->header.tag = htole32(CHATTY_LOG_TAG); |
| 277 | // here, then instead of delete currentLast below, |
| 278 | // log(currentLast) to see the incremental sums form. |
| 279 | // |
| 280 | uint32_t swab = event->payload.data; |
| 281 | unsigned long long total = htole32(swab); |
| 282 | event = reinterpret_cast<android_log_event_int_t*>( |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 283 | const_cast<char*>(elem->getMsg())); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 284 | swab = event->payload.data; |
| 285 | |
| 286 | lastLoggedElements[LOG_ID_EVENTS] = elem; |
| 287 | total += htole32(swab); |
| 288 | // check for overflow |
| 289 | if (total >= UINT32_MAX) { |
| 290 | log(currentLast); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 291 | unlock(); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 292 | return len; |
| 293 | } |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 294 | stats_->AddTotal(currentLast); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 295 | delete currentLast; |
| 296 | swab = total; |
| 297 | event->payload.data = htole32(swab); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 298 | unlock(); |
Mark Salyzyn | 1dfb4de | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 299 | return len; |
| 300 | } |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 301 | if (count == USHRT_MAX) { |
| 302 | log(dropped); |
| 303 | count = 1; |
| 304 | } else { |
| 305 | delete dropped; |
| 306 | ++count; |
| 307 | } |
| 308 | } |
| 309 | if (count) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 310 | stats_->AddTotal(currentLast); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 311 | currentLast->setDropped(count); |
| 312 | } |
| 313 | droppedElements[log_id] = currentLast; |
| 314 | lastLoggedElements[log_id] = elem; |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 315 | unlock(); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 316 | return len; |
| 317 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 318 | if (dropped) { // State 1 or 2 |
| 319 | if (count) { // State 2 |
| 320 | log(dropped); // report chatty |
| 321 | } else { // State 1 |
| 322 | delete dropped; |
Mark Salyzyn | 8f83a35 | 2016-12-16 16:09:15 -0800 | [diff] [blame] | 323 | } |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 324 | droppedElements[log_id] = nullptr; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 325 | log(currentLast); // report last message in the series |
| 326 | } else { // State 0 |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 327 | delete currentLast; |
| 328 | } |
| 329 | } |
| 330 | lastLoggedElements[log_id] = new LogBufferElement(*elem); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 331 | |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 332 | log(elem); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 333 | unlock(); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 334 | |
| 335 | return len; |
| 336 | } |
| 337 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 338 | // assumes ChattyLogBuffer::wrlock() held, owns elem, look after garbage collection |
| 339 | void ChattyLogBuffer::log(LogBufferElement* elem) { |
Tom Cherry | 65abf39 | 2019-08-21 13:17:12 -0700 | [diff] [blame] | 340 | mLogElements.push_back(elem); |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 341 | stats_->Add(elem); |
Mark Salyzyn | a2c0222 | 2016-12-13 10:31:29 -0800 | [diff] [blame] | 342 | maybePrune(elem->getLogId()); |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 343 | reader_list_->NotifyNewLog(1 << elem->getLogId()); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 344 | } |
| 345 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 346 | // ChattyLogBuffer::wrlock() must be held when this function is called. |
| 347 | void ChattyLogBuffer::maybePrune(log_id_t id) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 348 | unsigned long prune_rows; |
| 349 | if (stats_->ShouldPrune(id, log_buffer_size(id), &prune_rows)) { |
| 350 | prune(id, prune_rows); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 351 | } |
| 352 | } |
| 353 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 354 | LogBufferElementCollection::iterator ChattyLogBuffer::erase(LogBufferElementCollection::iterator it, |
| 355 | bool coalesce) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 356 | LogBufferElement* element = *it; |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 357 | log_id_t id = element->getLogId(); |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 358 | |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 359 | // Remove iterator references in the various lists that will become stale |
| 360 | // after the element is erased from the main logging list. |
| 361 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 362 | { // start of scope for found iterator |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 363 | int key = (id == LOG_ID_EVENTS || id == LOG_ID_SECURITY) ? element->getTag() |
| 364 | : element->getUid(); |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 365 | LogBufferIteratorMap::iterator found = mLastWorst[id].find(key); |
| 366 | if ((found != mLastWorst[id].end()) && (it == found->second)) { |
| 367 | mLastWorst[id].erase(found); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 368 | } |
Mark Salyzyn | c892ea3 | 2015-08-19 17:06:11 -0700 | [diff] [blame] | 369 | } |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 370 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 371 | { // start of scope for pid found iterator |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 372 | // element->getUid() may not be AID_SYSTEM for next-best-watermark. |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 373 | // will not assume id != LOG_ID_EVENTS or LOG_ID_SECURITY for KISS and |
| 374 | // long term code stability, find() check should be fast for those ids. |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 375 | LogBufferPidIteratorMap::iterator found = mLastWorstPidOfSystem[id].find(element->getPid()); |
| 376 | if (found != mLastWorstPidOfSystem[id].end() && it == found->second) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 377 | mLastWorstPidOfSystem[id].erase(found); |
| 378 | } |
| 379 | } |
| 380 | |
Mark Salyzyn | 7fd6c5c | 2016-01-19 16:04:41 -0800 | [diff] [blame] | 381 | bool setLast[LOG_ID_MAX]; |
| 382 | bool doSetLast = false; |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 383 | log_id_for_each(i) { doSetLast |= setLast[i] = oldest_[i] && it == *oldest_[i]; } |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 384 | #ifdef DEBUG_CHECK_FOR_STALE_ENTRIES |
| 385 | LogBufferElementCollection::iterator bad = it; |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 386 | int key = |
| 387 | (id == LOG_ID_EVENTS || id == LOG_ID_SECURITY) ? element->getTag() : element->getUid(); |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 388 | #endif |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 389 | it = mLogElements.erase(it); |
Mark Salyzyn | 7fd6c5c | 2016-01-19 16:04:41 -0800 | [diff] [blame] | 390 | if (doSetLast) { |
| 391 | log_id_for_each(i) { |
| 392 | if (setLast[i]) { |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 393 | if (__predict_false(it == mLogElements.end())) { |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 394 | oldest_[i] = std::nullopt; |
Mark Salyzyn | 7fd6c5c | 2016-01-19 16:04:41 -0800 | [diff] [blame] | 395 | } else { |
Tom Cherry | 20118ee | 2020-05-04 10:17:42 -0700 | [diff] [blame] | 396 | oldest_[i] = it; // Store the next iterator even if it does not correspond to |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 397 | // the same log_id, as a starting point for GetOldest(). |
Mark Salyzyn | 7fd6c5c | 2016-01-19 16:04:41 -0800 | [diff] [blame] | 398 | } |
| 399 | } |
Mark Salyzyn | 507eb9f | 2016-01-11 10:58:09 -0800 | [diff] [blame] | 400 | } |
| 401 | } |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 402 | #ifdef DEBUG_CHECK_FOR_STALE_ENTRIES |
| 403 | log_id_for_each(i) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 404 | for (auto b : mLastWorst[i]) { |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 405 | if (bad == b.second) { |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 406 | android::prdebug("stale mLastWorst[%d] key=%d mykey=%d\n", i, b.first, key); |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 407 | } |
| 408 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 409 | for (auto b : mLastWorstPidOfSystem[i]) { |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 410 | if (bad == b.second) { |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 411 | android::prdebug("stale mLastWorstPidOfSystem[%d] pid=%d\n", i, b.first); |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 412 | } |
| 413 | } |
Mark Salyzyn | 60636fa | 2016-10-24 16:22:17 -0700 | [diff] [blame] | 414 | } |
| 415 | #endif |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 416 | if (coalesce) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 417 | stats_->Erase(element); |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 418 | } else { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 419 | stats_->Subtract(element); |
Mark Salyzyn | 831aa29 | 2015-09-03 16:08:50 -0700 | [diff] [blame] | 420 | } |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 421 | delete element; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 422 | |
| 423 | return it; |
| 424 | } |
| 425 | |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 426 | // Define a temporary mechanism to report the last LogBufferElement pointer |
| 427 | // for the specified uid, pid and tid. Used below to help merge-sort when |
| 428 | // pruning for worst UID. |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 429 | class LogBufferElementLast { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 430 | typedef std::unordered_map<uint64_t, LogBufferElement*> LogBufferElementMap; |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 431 | LogBufferElementMap map; |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 432 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 433 | public: |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 434 | bool coalesce(LogBufferElement* element, uint16_t dropped) { |
Tom Cherry | a515197 | 2020-05-15 11:39:58 -0700 | [diff] [blame] | 435 | uint64_t key = LogBufferElementKey(element->getUid(), element->getPid(), element->getTid()); |
| 436 | LogBufferElementMap::iterator it = map.find(key); |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 437 | if (it != map.end()) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 438 | LogBufferElement* found = it->second; |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 439 | uint16_t moreDropped = found->getDropped(); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 440 | if ((dropped + moreDropped) > USHRT_MAX) { |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 441 | map.erase(it); |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 442 | } else { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 443 | found->setDropped(dropped + moreDropped); |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 444 | return true; |
| 445 | } |
| 446 | } |
| 447 | return false; |
| 448 | } |
| 449 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 450 | void add(LogBufferElement* element) { |
Tom Cherry | a515197 | 2020-05-15 11:39:58 -0700 | [diff] [blame] | 451 | uint64_t key = LogBufferElementKey(element->getUid(), element->getPid(), element->getTid()); |
| 452 | map[key] = element; |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 453 | } |
| 454 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 455 | void clear() { map.clear(); } |
Mark Salyzyn | e06a6e0 | 2015-04-20 14:08:56 -0700 | [diff] [blame] | 456 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 457 | void clear(LogBufferElement* element) { |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 458 | uint64_t current = element->getRealTime().nsec() - (EXPIRE_RATELIMIT * NS_PER_SEC); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 459 | for (LogBufferElementMap::iterator it = map.begin(); it != map.end();) { |
| 460 | LogBufferElement* mapElement = it->second; |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 461 | if (mapElement->getDropped() >= EXPIRE_THRESHOLD && |
| 462 | current > mapElement->getRealTime().nsec()) { |
Mark Salyzyn | 511338d | 2015-05-19 09:12:30 -0700 | [diff] [blame] | 463 | it = map.erase(it); |
| 464 | } else { |
| 465 | ++it; |
Mark Salyzyn | e06a6e0 | 2015-04-20 14:08:56 -0700 | [diff] [blame] | 466 | } |
| 467 | } |
| 468 | } |
Tom Cherry | a515197 | 2020-05-15 11:39:58 -0700 | [diff] [blame] | 469 | |
| 470 | private: |
| 471 | uint64_t LogBufferElementKey(uid_t uid, pid_t pid, pid_t tid) { |
| 472 | return uint64_t(uid) << 32 | uint64_t(pid) << 16 | uint64_t(tid); |
| 473 | } |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 474 | }; |
| 475 | |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 476 | // If the selected reader is blocking our pruning progress, decide on |
| 477 | // what kind of mitigation is necessary to unblock the situation. |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 478 | void ChattyLogBuffer::kickMe(LogReaderThread* me, log_id_t id, unsigned long pruneRows) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 479 | if (stats_->Sizes(id) > (2 * log_buffer_size(id))) { // +100% |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 480 | // A misbehaving or slow reader has its connection |
| 481 | // dropped if we hit too much memory pressure. |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 482 | android::prdebug("Kicking blocked reader, %s, from ChattyLogBuffer::kickMe()\n", |
| 483 | me->name().c_str()); |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 484 | me->release_Locked(); |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 485 | } else if (me->deadline().time_since_epoch().count() != 0) { |
| 486 | // Allow a blocked WRAP deadline reader to trigger and start reporting the log data. |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 487 | me->triggerReader_Locked(); |
| 488 | } else { |
| 489 | // tell slow reader to skip entries to catch up |
Tom Cherry | 21f16a0 | 2019-11-15 17:37:03 -0800 | [diff] [blame] | 490 | android::prdebug( |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 491 | "Skipping %lu entries from slow reader, %s, from ChattyLogBuffer::kickMe()\n", |
| 492 | pruneRows, me->name().c_str()); |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 493 | me->triggerSkip_Locked(id, pruneRows); |
| 494 | } |
| 495 | } |
| 496 | |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 497 | // prune "pruneRows" of type "id" from the buffer. |
| 498 | // |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 499 | // This garbage collection task is used to expire log entries. It is called to |
| 500 | // remove all logs (clear), all UID logs (unprivileged clear), or every |
| 501 | // 256 or 10% of the total logs (whichever is less) to prune the logs. |
| 502 | // |
| 503 | // First there is a prep phase where we discover the reader region lock that |
| 504 | // acts as a backstop to any pruning activity to stop there and go no further. |
| 505 | // |
| 506 | // There are three major pruning loops that follow. All expire from the oldest |
| 507 | // entries. Since there are multiple log buffers, the Android logging facility |
| 508 | // will appear to drop entries 'in the middle' when looking at multiple log |
| 509 | // sources and buffers. This effect is slightly more prominent when we prune |
| 510 | // the worst offender by logging source. Thus the logs slowly loose content |
| 511 | // and value as you move back in time. This is preferred since chatty sources |
| 512 | // invariably move the logs value down faster as less chatty sources would be |
| 513 | // expired in the noise. |
| 514 | // |
| 515 | // The first loop performs blacklisting and worst offender pruning. Falling |
| 516 | // through when there are no notable worst offenders and have not hit the |
| 517 | // region lock preventing further worst offender pruning. This loop also looks |
| 518 | // after managing the chatty log entries and merging to help provide |
| 519 | // statistical basis for blame. The chatty entries are not a notification of |
| 520 | // how much logs you may have, but instead represent how much logs you would |
| 521 | // have had in a virtual log buffer that is extended to cover all the in-memory |
| 522 | // logs without loss. They last much longer than the represented pruned logs |
| 523 | // since they get multiplied by the gains in the non-chatty log sources. |
| 524 | // |
| 525 | // The second loop get complicated because an algorithm of watermarks and |
| 526 | // history is maintained to reduce the order and keep processing time |
| 527 | // down to a minimum at scale. These algorithms can be costly in the face |
| 528 | // of larger log buffers, or severly limited processing time granted to a |
| 529 | // background task at lowest priority. |
| 530 | // |
| 531 | // This second loop does straight-up expiration from the end of the logs |
| 532 | // (again, remember for the specified log buffer id) but does some whitelist |
| 533 | // preservation. Thus whitelist is a Hail Mary low priority, blacklists and |
| 534 | // spam filtration all take priority. This second loop also checks if a region |
| 535 | // lock is causing us to buffer too much in the logs to help the reader(s), |
| 536 | // and will tell the slowest reader thread to skip log entries, and if |
| 537 | // persistent and hits a further threshold, kill the reader thread. |
| 538 | // |
| 539 | // The third thread is optional, and only gets hit if there was a whitelist |
| 540 | // and more needs to be pruned against the backstop of the region lock. |
| 541 | // |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 542 | // ChattyLogBuffer::wrlock() must be held when this function is called. |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 543 | // |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 544 | bool ChattyLogBuffer::prune(log_id_t id, unsigned long pruneRows, uid_t caller_uid) { |
Tom Cherry | 6ec71e9 | 2020-05-04 12:53:36 -0700 | [diff] [blame] | 545 | LogReaderThread* oldest = nullptr; |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 546 | bool busy = false; |
Mark Salyzyn | 2b25c66 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 547 | bool clearAll = pruneRows == ULONG_MAX; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 548 | |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 549 | auto reader_threads_lock = std::lock_guard{reader_list_->reader_threads_lock()}; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 550 | |
| 551 | // Region locked? |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 552 | for (const auto& reader_thread : reader_list_->reader_threads()) { |
| 553 | if (!reader_thread->IsWatching(id)) { |
| 554 | continue; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 555 | } |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 556 | if (!oldest || oldest->start() > reader_thread->start() || |
| 557 | (oldest->start() == reader_thread->start() && |
| 558 | reader_thread->deadline().time_since_epoch().count() != 0)) { |
| 559 | oldest = reader_thread.get(); |
| 560 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 561 | } |
| 562 | |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 563 | LogBufferElementCollection::iterator it; |
| 564 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 565 | if (__predict_false(caller_uid != AID_ROOT)) { // unlikely |
Mark Salyzyn | 43a5f31 | 2016-09-01 15:48:36 -0700 | [diff] [blame] | 566 | // Only here if clear all request from non system source, so chatty |
| 567 | // filter logistics is not required. |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 568 | it = GetOldest(id); |
Mark Salyzyn | 507eb9f | 2016-01-11 10:58:09 -0800 | [diff] [blame] | 569 | while (it != mLogElements.end()) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 570 | LogBufferElement* element = *it; |
Mark Salyzyn | 1a240b4 | 2014-06-12 11:16:16 -0700 | [diff] [blame] | 571 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 572 | if (element->getLogId() != id || element->getUid() != caller_uid) { |
Mark Salyzyn | 2b25c66 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 573 | ++it; |
| 574 | continue; |
| 575 | } |
| 576 | |
Tom Cherry | cef47bb | 2020-05-04 17:10:16 -0700 | [diff] [blame] | 577 | if (oldest && oldest->start() <= element->getSequence()) { |
Tom Cherry | 5e26655 | 2020-04-08 10:47:26 -0700 | [diff] [blame] | 578 | busy = true; |
| 579 | kickMe(oldest, id, pruneRows); |
Mark Salyzyn | 1a240b4 | 2014-06-12 11:16:16 -0700 | [diff] [blame] | 580 | break; |
| 581 | } |
| 582 | |
Mark Salyzyn | 2b25c66 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 583 | it = erase(it); |
Mark Salyzyn | 43a5f31 | 2016-09-01 15:48:36 -0700 | [diff] [blame] | 584 | if (--pruneRows == 0) { |
| 585 | break; |
| 586 | } |
Mark Salyzyn | 1a240b4 | 2014-06-12 11:16:16 -0700 | [diff] [blame] | 587 | } |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 588 | return busy; |
Mark Salyzyn | 1a240b4 | 2014-06-12 11:16:16 -0700 | [diff] [blame] | 589 | } |
| 590 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 591 | // prune by worst offenders; by blacklist, UID, and by PID of system UID |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 592 | bool hasBlacklist = (id != LOG_ID_SECURITY) && prune_->naughty(); |
Mark Salyzyn | 2b25c66 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 593 | while (!clearAll && (pruneRows > 0)) { |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 594 | // recalculate the worst offender on every batched pass |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 595 | int worst = -1; // not valid for getUid() or getKey() |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 596 | size_t worst_sizes = 0; |
| 597 | size_t second_worst_sizes = 0; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 598 | pid_t worstPid = 0; // POSIX guarantees PID != 0 |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 599 | |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 600 | if (worstUidEnabledForLogid(id) && prune_->worstUidEnabled()) { |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 601 | // Calculate threshold as 12.5% of available storage |
| 602 | size_t threshold = log_buffer_size(id) / 8; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 603 | |
Tom Cherry | b6b78e9 | 2020-05-07 09:13:12 -0700 | [diff] [blame] | 604 | if (id == LOG_ID_EVENTS || id == LOG_ID_SECURITY) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 605 | stats_->WorstTwoTags(threshold, &worst, &worst_sizes, &second_worst_sizes); |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 606 | // per-pid filter for AID_SYSTEM sources is too complex |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 607 | } else { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 608 | stats_->WorstTwoUids(id, threshold, &worst, &worst_sizes, &second_worst_sizes); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 609 | |
Tom Cherry | b6b78e9 | 2020-05-07 09:13:12 -0700 | [diff] [blame] | 610 | if (worst == AID_SYSTEM && prune_->worstPidOfSystemEnabled()) { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 611 | stats_->WorstTwoSystemPids(id, worst_sizes, &worstPid, &second_worst_sizes); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 612 | } |
| 613 | } |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 614 | } |
| 615 | |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 616 | // skip if we have neither worst nor naughty filters |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 617 | if ((worst == -1) && !hasBlacklist) { |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 618 | break; |
| 619 | } |
| 620 | |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 621 | bool kick = false; |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 622 | bool leading = true; // true if starting from the oldest log entry, false if starting from |
| 623 | // a specific chatty entry. |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 624 | // Perform at least one mandatory garbage collection cycle in following |
| 625 | // - clear leading chatty tags |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 626 | // - coalesce chatty tags |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 627 | // - check age-out of preserved logs |
| 628 | bool gc = pruneRows <= 1; |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 629 | if (!gc && (worst != -1)) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 630 | { // begin scope for worst found iterator |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 631 | LogBufferIteratorMap::iterator found = mLastWorst[id].find(worst); |
| 632 | if (found != mLastWorst[id].end() && found->second != mLogElements.end()) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 633 | leading = false; |
| 634 | it = found->second; |
| 635 | } |
| 636 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 637 | if (worstPid) { // begin scope for pid worst found iterator |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 638 | // FYI: worstPid only set if !LOG_ID_EVENTS and |
| 639 | // !LOG_ID_SECURITY, not going to make that assumption ... |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 640 | LogBufferPidIteratorMap::iterator found = mLastWorstPidOfSystem[id].find(worstPid); |
| 641 | if (found != mLastWorstPidOfSystem[id].end() && |
| 642 | found->second != mLogElements.end()) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 643 | leading = false; |
| 644 | it = found->second; |
| 645 | } |
Mark Salyzyn | c892ea3 | 2015-08-19 17:06:11 -0700 | [diff] [blame] | 646 | } |
| 647 | } |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 648 | if (leading) { |
| 649 | it = GetOldest(id); |
| 650 | } |
Tom Cherry | bd80e56 | 2020-05-18 08:58:50 -0700 | [diff] [blame] | 651 | static const log_time too_old{EXPIRE_HOUR_THRESHOLD * 60 * 60, 0}; |
Mark Salyzyn | ccfe844 | 2015-08-24 13:43:27 -0700 | [diff] [blame] | 652 | LogBufferElementCollection::iterator lastt; |
| 653 | lastt = mLogElements.end(); |
| 654 | --lastt; |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 655 | LogBufferElementLast last; |
Mark Salyzyn | c892ea3 | 2015-08-19 17:06:11 -0700 | [diff] [blame] | 656 | while (it != mLogElements.end()) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 657 | LogBufferElement* element = *it; |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 658 | |
Tom Cherry | cef47bb | 2020-05-04 17:10:16 -0700 | [diff] [blame] | 659 | if (oldest && oldest->start() <= element->getSequence()) { |
Tom Cherry | 5e26655 | 2020-04-08 10:47:26 -0700 | [diff] [blame] | 660 | busy = true; |
Mark Salyzyn | 0878a7c | 2017-05-11 13:28:33 -0700 | [diff] [blame] | 661 | // Do not let chatty eliding trigger any reader mitigation |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 662 | break; |
| 663 | } |
| 664 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 665 | if (element->getLogId() != id) { |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 666 | ++it; |
| 667 | continue; |
| 668 | } |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 669 | // below this point element->getLogId() == id |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 670 | |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 671 | uint16_t dropped = element->getDropped(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 672 | |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 673 | // remove any leading drops |
| 674 | if (leading && dropped) { |
| 675 | it = erase(it); |
| 676 | continue; |
| 677 | } |
| 678 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 679 | if (dropped && last.coalesce(element, dropped)) { |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 680 | it = erase(it, true); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 681 | continue; |
| 682 | } |
| 683 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 684 | int key = (id == LOG_ID_EVENTS || id == LOG_ID_SECURITY) ? element->getTag() |
| 685 | : element->getUid(); |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 686 | |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 687 | if (hasBlacklist && prune_->naughty(element)) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 688 | last.clear(element); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 689 | it = erase(it); |
| 690 | if (dropped) { |
| 691 | continue; |
| 692 | } |
| 693 | |
| 694 | pruneRows--; |
| 695 | if (pruneRows == 0) { |
| 696 | break; |
| 697 | } |
| 698 | |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 699 | if (key == worst) { |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 700 | kick = true; |
| 701 | if (worst_sizes < second_worst_sizes) { |
| 702 | break; |
| 703 | } |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 704 | worst_sizes -= element->getMsgLen(); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 705 | } |
| 706 | continue; |
| 707 | } |
| 708 | |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 709 | if ((element->getRealTime() < ((*lastt)->getRealTime() - too_old)) || |
| 710 | (element->getRealTime() > (*lastt)->getRealTime())) { |
Mark Salyzyn | ccfe844 | 2015-08-24 13:43:27 -0700 | [diff] [blame] | 711 | break; |
| 712 | } |
| 713 | |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 714 | if (dropped) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 715 | last.add(element); |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 716 | if (worstPid && ((!gc && element->getPid() == worstPid) || |
| 717 | mLastWorstPidOfSystem[id].find(element->getPid()) == |
| 718 | mLastWorstPidOfSystem[id].end())) { |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 719 | // element->getUid() may not be AID_SYSTEM, next best |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 720 | // watermark if current one empty. id is not LOG_ID_EVENTS |
| 721 | // or LOG_ID_SECURITY because of worstPid check. |
Mark Salyzyn | 1eefca2 | 2016-09-01 07:28:44 -0700 | [diff] [blame] | 722 | mLastWorstPidOfSystem[id][element->getPid()] = it; |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 723 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 724 | if ((!gc && !worstPid && (key == worst)) || |
| 725 | (mLastWorst[id].find(key) == mLastWorst[id].end())) { |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 726 | mLastWorst[id][key] = it; |
Mark Salyzyn | 49afe0d | 2015-08-24 13:43:27 -0700 | [diff] [blame] | 727 | } |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 728 | ++it; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 729 | continue; |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 730 | } |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 731 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 732 | if (key != worst || (worstPid && element->getPid() != worstPid)) { |
Mark Salyzyn | 5921276 | 2015-06-01 09:41:19 -0700 | [diff] [blame] | 733 | leading = false; |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 734 | last.clear(element); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 735 | ++it; |
| 736 | continue; |
| 737 | } |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 738 | // key == worst below here |
| 739 | // If worstPid set, then element->getPid() == worstPid below here |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 740 | |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 741 | pruneRows--; |
| 742 | if (pruneRows == 0) { |
| 743 | break; |
| 744 | } |
| 745 | |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 746 | kick = true; |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 747 | |
Chih-Hung Hsieh | 08d470b | 2018-08-13 14:22:56 -0700 | [diff] [blame] | 748 | uint16_t len = element->getMsgLen(); |
Mark Salyzyn | 5392aac | 2015-05-22 10:03:31 -0700 | [diff] [blame] | 749 | |
| 750 | // do not create any leading drops |
| 751 | if (leading) { |
| 752 | it = erase(it); |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 753 | } else { |
Tom Cherry | 64e9016 | 2020-05-07 14:44:43 -0700 | [diff] [blame] | 754 | stats_->Drop(element); |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 755 | element->setDropped(1); |
| 756 | if (last.coalesce(element, 1)) { |
Mark Salyzyn | aaad42f | 2015-09-30 07:40:09 -0700 | [diff] [blame] | 757 | it = erase(it, true); |
Mark Salyzyn | 5392aac | 2015-05-22 10:03:31 -0700 | [diff] [blame] | 758 | } else { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 759 | last.add(element); |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 760 | if (worstPid && (!gc || mLastWorstPidOfSystem[id].find(worstPid) == |
| 761 | mLastWorstPidOfSystem[id].end())) { |
Mark Salyzyn | fa07f9d | 2016-10-21 09:46:42 -0700 | [diff] [blame] | 762 | // element->getUid() may not be AID_SYSTEM, next best |
Mark Salyzyn | 8fcfd85 | 2016-10-24 08:20:26 -0700 | [diff] [blame] | 763 | // watermark if current one empty. id is not |
| 764 | // LOG_ID_EVENTS or LOG_ID_SECURITY because of worstPid. |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 765 | mLastWorstPidOfSystem[id][worstPid] = it; |
| 766 | } |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 767 | if ((!gc && !worstPid) || mLastWorst[id].find(worst) == mLastWorst[id].end()) { |
Mark Salyzyn | 6a06694 | 2016-07-14 15:34:30 -0700 | [diff] [blame] | 768 | mLastWorst[id][worst] = it; |
Mark Salyzyn | 5bb2972 | 2015-09-08 09:12:51 -0700 | [diff] [blame] | 769 | } |
Mark Salyzyn | 5392aac | 2015-05-22 10:03:31 -0700 | [diff] [blame] | 770 | ++it; |
| 771 | } |
Mark Salyzyn | ab0dcf6 | 2015-03-16 12:04:09 -0700 | [diff] [blame] | 772 | } |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 773 | if (worst_sizes < second_worst_sizes) { |
| 774 | break; |
| 775 | } |
| 776 | worst_sizes -= len; |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 777 | } |
Mark Salyzyn | 2c9d909 | 2015-04-17 15:38:04 -0700 | [diff] [blame] | 778 | last.clear(); |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 779 | |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 780 | if (!kick || !prune_->worstUidEnabled()) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 781 | break; // the following loop will ask bad clients to skip/drop |
Mark Salyzyn | 64d6fe9 | 2014-02-06 18:11:13 -0800 | [diff] [blame] | 782 | } |
| 783 | } |
| 784 | |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 785 | bool whitelist = false; |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 786 | bool hasWhitelist = (id != LOG_ID_SECURITY) && prune_->nice() && !clearAll; |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 787 | it = GetOldest(id); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 788 | while ((pruneRows > 0) && (it != mLogElements.end())) { |
| 789 | LogBufferElement* element = *it; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 790 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 791 | if (element->getLogId() != id) { |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 792 | it++; |
| 793 | continue; |
| 794 | } |
| 795 | |
Tom Cherry | cef47bb | 2020-05-04 17:10:16 -0700 | [diff] [blame] | 796 | if (oldest && oldest->start() <= element->getSequence()) { |
Tom Cherry | 5e26655 | 2020-04-08 10:47:26 -0700 | [diff] [blame] | 797 | busy = true; |
| 798 | if (!whitelist) kickMe(oldest, id, pruneRows); |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 799 | break; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 800 | } |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 801 | |
Tom Cherry | 5a3db39 | 2020-05-01 17:03:20 -0700 | [diff] [blame] | 802 | if (hasWhitelist && !element->getDropped() && prune_->nice(element)) { |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 803 | // WhiteListed |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 804 | whitelist = true; |
| 805 | it++; |
| 806 | continue; |
| 807 | } |
| 808 | |
| 809 | it = erase(it); |
| 810 | pruneRows--; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 811 | } |
| 812 | |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 813 | // Do not save the whitelist if we are reader range limited |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 814 | if (whitelist && (pruneRows > 0)) { |
Tom Cherry | 385c2c9 | 2020-04-29 17:58:18 -0700 | [diff] [blame] | 815 | it = GetOldest(id); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 816 | while ((it != mLogElements.end()) && (pruneRows > 0)) { |
| 817 | LogBufferElement* element = *it; |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 818 | |
Mark Salyzyn | bec3c3d | 2015-08-28 08:02:59 -0700 | [diff] [blame] | 819 | if (element->getLogId() != id) { |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 820 | ++it; |
| 821 | continue; |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 822 | } |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 823 | |
Tom Cherry | cef47bb | 2020-05-04 17:10:16 -0700 | [diff] [blame] | 824 | if (oldest && oldest->start() <= element->getSequence()) { |
Tom Cherry | 5e26655 | 2020-04-08 10:47:26 -0700 | [diff] [blame] | 825 | busy = true; |
| 826 | kickMe(oldest, id, pruneRows); |
Mark Salyzyn | 97c1c2b | 2015-03-10 13:51:35 -0700 | [diff] [blame] | 827 | break; |
| 828 | } |
| 829 | |
| 830 | it = erase(it); |
| 831 | pruneRows--; |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 832 | } |
| 833 | } |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 834 | |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 835 | return (pruneRows > 0) && busy; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 836 | } |
| 837 | |
| 838 | // clear all rows of type "id" from the buffer. |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 839 | bool ChattyLogBuffer::Clear(log_id_t id, uid_t uid) { |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 840 | bool busy = true; |
| 841 | // If it takes more than 4 tries (seconds) to clear, then kill reader(s) |
| 842 | for (int retry = 4;;) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 843 | if (retry == 1) { // last pass |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 844 | // Check if it is still busy after the sleep, we say prune |
| 845 | // one entry, not another clear run, so we are looking for |
| 846 | // the quick side effect of the return value to tell us if |
| 847 | // we have a _blocked_ reader. |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 848 | wrlock(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 849 | busy = prune(id, 1, uid); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 850 | unlock(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 851 | // It is still busy, blocked reader(s), lets kill them all! |
| 852 | // otherwise, lets be a good citizen and preserve the slow |
| 853 | // readers and let the clear run (below) deal with determining |
| 854 | // if we are still blocked and return an error code to caller. |
| 855 | if (busy) { |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 856 | auto reader_threads_lock = std::lock_guard{reader_list_->reader_threads_lock()}; |
| 857 | for (const auto& reader_thread : reader_list_->reader_threads()) { |
| 858 | if (reader_thread->IsWatching(id)) { |
Tom Cherry | 21f16a0 | 2019-11-15 17:37:03 -0800 | [diff] [blame] | 859 | android::prdebug( |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 860 | "Kicking blocked reader, %s, from ChattyLogBuffer::clear()\n", |
| 861 | reader_thread->name().c_str()); |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 862 | reader_thread->release_Locked(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 863 | } |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 864 | } |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 865 | } |
| 866 | } |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 867 | wrlock(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 868 | busy = prune(id, ULONG_MAX, uid); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 869 | unlock(); |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 870 | if (!busy || !--retry) { |
| 871 | break; |
| 872 | } |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 873 | sleep(1); // Let reader(s) catch up after notification |
Mark Salyzyn | c5dc970 | 2015-09-16 15:34:00 -0700 | [diff] [blame] | 874 | } |
| 875 | return busy; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 876 | } |
| 877 | |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 878 | // set the total space allocated to "id" |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 879 | int ChattyLogBuffer::SetSize(log_id_t id, unsigned long size) { |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 880 | // Reasonable limits ... |
Mark Salyzyn | f10e273 | 2016-09-27 13:08:23 -0700 | [diff] [blame] | 881 | if (!__android_logger_valid_buffer_size(size)) { |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 882 | return -1; |
| 883 | } |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 884 | wrlock(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 885 | log_buffer_size(id) = size; |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 886 | unlock(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 887 | return 0; |
| 888 | } |
| 889 | |
| 890 | // get the total space allocated to "id" |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 891 | unsigned long ChattyLogBuffer::GetSize(log_id_t id) { |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 892 | rdlock(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 893 | size_t retval = log_buffer_size(id); |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 894 | unlock(); |
Mark Salyzyn | dfa7a07 | 2014-02-11 12:29:31 -0800 | [diff] [blame] | 895 | return retval; |
| 896 | } |
| 897 | |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 898 | uint64_t ChattyLogBuffer::FlushTo( |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 899 | LogWriter* writer, uint64_t start, pid_t* lastTid, |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 900 | const std::function<FlushToResult(const LogBufferElement* element)>& filter) { |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 901 | LogBufferElementCollection::iterator it; |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 902 | uid_t uid = writer->uid(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 903 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 904 | rdlock(); |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 905 | |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 906 | if (start <= 1) { |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 907 | // client wants to start from the beginning |
| 908 | it = mLogElements.begin(); |
| 909 | } else { |
| 910 | // Client wants to start from some specified time. Chances are |
| 911 | // we are better off starting from the end of the time sorted list. |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 912 | for (it = mLogElements.end(); it != mLogElements.begin(); |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 913 | /* do nothing */) { |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 914 | --it; |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 915 | LogBufferElement* element = *it; |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 916 | if (element->getSequence() <= start) { |
| 917 | it++; |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 918 | break; |
| 919 | } |
| 920 | } |
| 921 | } |
| 922 | |
Tom Cherry | 10d086e | 2019-08-21 14:16:34 -0700 | [diff] [blame] | 923 | uint64_t curr = start; |
Mark Salyzyn | b5b8796 | 2017-01-23 14:20:31 -0800 | [diff] [blame] | 924 | |
Dragoslav Mitrinovic | 8e8e8db | 2015-01-15 09:29:43 -0600 | [diff] [blame] | 925 | for (; it != mLogElements.end(); ++it) { |
Mark Salyzyn | 501c373 | 2017-03-10 14:31:54 -0800 | [diff] [blame] | 926 | LogBufferElement* element = *it; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 927 | |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 928 | if (!writer->privileged() && element->getUid() != uid) { |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 929 | continue; |
| 930 | } |
| 931 | |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 932 | if (!writer->can_read_security_logs() && element->getLogId() == LOG_ID_SECURITY) { |
Mark Salyzyn | 8fa8896 | 2016-01-26 14:32:35 -0800 | [diff] [blame] | 933 | continue; |
| 934 | } |
| 935 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 936 | // NB: calling out to another object with wrlock() held (safe) |
Mark Salyzyn | f7c0f75 | 2015-03-03 13:39:37 -0800 | [diff] [blame] | 937 | if (filter) { |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 938 | FlushToResult ret = filter(element); |
| 939 | if (ret == FlushToResult::kSkip) { |
Mark Salyzyn | f7c0f75 | 2015-03-03 13:39:37 -0800 | [diff] [blame] | 940 | continue; |
| 941 | } |
Tom Cherry | 68630a0 | 2020-05-11 16:29:29 -0700 | [diff] [blame] | 942 | if (ret == FlushToResult::kStop) { |
Mark Salyzyn | f7c0f75 | 2015-03-03 13:39:37 -0800 | [diff] [blame] | 943 | break; |
| 944 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 945 | } |
| 946 | |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 947 | bool sameTid = false; |
| 948 | if (lastTid) { |
| 949 | sameTid = lastTid[element->getLogId()] == element->getTid(); |
| 950 | // Dropped (chatty) immediately following a valid log from the |
| 951 | // same source in the same log buffer indicates we have a |
| 952 | // multiple identical squash. chatty that differs source |
| 953 | // is due to spam filter. chatty to chatty of different |
| 954 | // source is also due to spam filter. |
| 955 | lastTid[element->getLogId()] = |
Tom Cherry | d5b3838 | 2020-05-12 13:16:41 -0700 | [diff] [blame] | 956 | (element->getDropped() && !sameTid) ? 0 : element->getTid(); |
Mark Salyzyn | ae2abf1 | 2017-03-31 10:48:39 -0700 | [diff] [blame] | 957 | } |
Mark Salyzyn | b5b8796 | 2017-01-23 14:20:31 -0800 | [diff] [blame] | 958 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 959 | unlock(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 960 | |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 961 | curr = element->getSequence(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 962 | // range locking in LastLogTimes looks after us |
Tom Cherry | 283c9a1 | 2020-05-14 19:25:05 -0700 | [diff] [blame] | 963 | if (!element->FlushTo(writer, stats_, sameTid)) { |
| 964 | return FLUSH_ERROR; |
Mark Salyzyn | eb45db2 | 2017-05-17 19:55:12 +0000 | [diff] [blame] | 965 | } |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 966 | |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 967 | rdlock(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 968 | } |
Mark Salyzyn | 3c501b5 | 2017-04-18 14:09:45 -0700 | [diff] [blame] | 969 | unlock(); |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 970 | |
Mark Salyzyn | 206ed8e | 2017-05-18 10:06:00 -0700 | [diff] [blame] | 971 | return curr; |
Mark Salyzyn | 0175b07 | 2014-02-26 09:50:16 -0800 | [diff] [blame] | 972 | } |