blob: ca42999c763f2e70beab000de8f14e84f0020ec3 [file] [log] [blame]
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001// Copyright 2021, The Android Open Source Project
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
Andrew Walbranf6bf6862021-05-21 12:41:13 +000015//! Implementation of the AIDL interface of the VirtualizationService.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +000016
David Brazdil1f530702022-10-03 12:18:10 +010017use crate::{get_calling_pid, get_calling_uid};
David Brazdil49f96f52022-12-16 21:29:13 +000018use crate::atom::{
David Brazdil49f96f52022-12-16 21:29:13 +000019 write_vm_booted_stats, write_vm_creation_stats};
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +000020use crate::composite::make_composite_image;
David Brazdil8cf8f482022-11-23 14:21:26 +000021use crate::crosvm::{CrosvmConfig, DiskFile, PayloadState, VmContext, VmInstance, VmState};
Shikha Panwar22e70452022-10-10 18:32:55 +000022use crate::payload::{add_microdroid_payload_images, add_microdroid_system_images};
Seungjae Yoofd9a0622022-10-14 10:01:29 +090023use crate::selinux::{getfilecon, SeContext};
Jiyong Park753553b2021-07-12 21:21:09 +090024use android_os_permissions_aidl::aidl::android::os::IPermissionController;
David Brazdil49f96f52022-12-16 21:29:13 +000025use android_system_virtualizationcommon::aidl::android::system::virtualizationcommon::{
Andrew Walbranc92d35f2022-01-12 12:45:19 +000026 DeathReason::DeathReason,
David Brazdil49f96f52022-12-16 21:29:13 +000027 ErrorCode::ErrorCode,
28};
29use android_system_virtualizationservice::aidl::android::system::virtualizationservice::{
Andrew Walbran6b650662021-09-07 13:13:23 +000030 DiskImage::DiskImage,
Alan Stokes0cc59ee2021-09-24 11:20:34 +010031 IVirtualMachine::{BnVirtualMachine, IVirtualMachine},
Andrew Walbran6b650662021-09-07 13:13:23 +000032 IVirtualMachineCallback::IVirtualMachineCallback,
33 IVirtualizationService::IVirtualizationService,
Keir Frasercdd4b112022-11-24 14:02:25 +000034 MemoryTrimLevel::MemoryTrimLevel,
Jiyong Park029977d2021-11-24 21:56:49 +090035 Partition::Partition,
Andrew Walbran6b650662021-09-07 13:13:23 +000036 PartitionType::PartitionType,
Inseob Kim0168b462022-12-27 14:54:35 +090037 VirtualMachineAppConfig::{DebugLevel::DebugLevel, Payload::Payload, VirtualMachineAppConfig},
Jooyung Han21e9b922021-06-26 04:14:16 +090038 VirtualMachineConfig::VirtualMachineConfig,
Andrew Walbran6b650662021-09-07 13:13:23 +000039 VirtualMachineDebugInfo::VirtualMachineDebugInfo,
Alan Stokes0d1ef782022-09-27 13:46:35 +010040 VirtualMachinePayloadConfig::VirtualMachinePayloadConfig,
Jooyung Han21e9b922021-06-26 04:14:16 +090041 VirtualMachineRawConfig::VirtualMachineRawConfig,
Andrew Walbran6b650662021-09-07 13:13:23 +000042 VirtualMachineState::VirtualMachineState,
Jooyung Han21e9b922021-06-26 04:14:16 +090043};
David Brazdilafc9a9e2023-01-12 16:08:10 +000044use android_system_virtualizationservice_internal::aidl::android::system::virtualizationservice_internal::IVirtualizationServiceInternal::IVirtualizationServiceInternal;
Seungjae Yoodd91f0f2022-11-09 15:25:21 +090045use android_system_virtualmachineservice::aidl::android::system::virtualmachineservice::IVirtualMachineService::{
David Brazdilafc9a9e2023-01-12 16:08:10 +000046 BnVirtualMachineService, IVirtualMachineService,
Seungjae Yoofd9a0622022-10-14 10:01:29 +090047};
David Brazdilafc9a9e2023-01-12 16:08:10 +000048use anyhow::{bail, Context, Result};
Seungjae Yoofd9a0622022-10-14 10:01:29 +090049use apkverify::{HashAlgorithm, V4Signature};
Alan Stokes0e82b502022-08-08 14:44:48 +010050use binder::{
David Brazdilafc9a9e2023-01-12 16:08:10 +000051 self, wait_for_interface, BinderFeatures, ExceptionCode, Interface, ParcelFileDescriptor,
52 Status, StatusCode, Strong,
Andrew Walbrana89fc132021-03-17 17:08:36 +000053};
Andrew Walbrandfc953d2021-06-10 13:59:56 +000054use disk::QcowFile;
David Brazdil49f96f52022-12-16 21:29:13 +000055use lazy_static::lazy_static;
Seungjae Yoo0a8c84c2022-07-11 08:19:15 +000056use log::{debug, error, info, warn};
Seungjae Yoofd9a0622022-10-14 10:01:29 +090057use microdroid_payload_config::{OsConfig, Task, TaskType, VmPayloadConfig};
Inseob Kim0168b462022-12-27 14:54:35 +090058use nix::unistd::pipe;
David Brazdil73988ea2022-11-11 15:10:32 +000059use rpcbinder::RpcServer;
Jiyong Parkdcf17412022-02-08 15:07:23 +090060use semver::VersionReq;
Andrew Walbrandff3b942021-06-09 15:20:36 +000061use std::convert::TryInto;
Shikha Panward8e35422021-10-11 13:51:27 +000062use std::ffi::CStr;
David Brazdilafc9a9e2023-01-12 16:08:10 +000063use std::fs::{read_dir, remove_file, File, OpenOptions};
64use std::io::{BufRead, BufReader, Error, ErrorKind, Write};
Andrew Walbranb15cd6e2021-07-05 16:38:07 +000065use std::num::NonZeroU32;
Andrew Walbrand3a84182021-09-07 14:48:52 +000066use std::os::unix::io::{FromRawFd, IntoRawFd};
David Brazdilafc9a9e2023-01-12 16:08:10 +000067use std::os::unix::raw::pid_t;
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +000068use std::path::{Path, PathBuf};
Andrew Walbran320b5602021-03-04 16:11:12 +000069use std::sync::{Arc, Mutex, Weak};
Andrew Walbrancc0db522021-07-12 17:03:42 +000070use vmconfig::VmConfig;
David Brazdilafc9a9e2023-01-12 16:08:10 +000071use vsock::VsockStream;
Jooyung Han35edb8f2021-07-01 16:17:16 +090072use zip::ZipArchive;
Andrew Walbrand6dce6f2021-03-05 16:39:08 +000073
David Brazdil41d1a872022-10-05 14:44:19 +010074/// The unique ID of a VM used (together with a port number) for vsock communication.
75pub type Cid = u32;
76
David Brazdil4b4c5102022-12-19 22:56:20 +000077pub const BINDER_SERVICE_IDENTIFIER: &str = "android.system.virtualizationservice";
78
Jooyung Han95884632021-07-06 22:27:54 +090079/// The size of zero.img.
80/// Gaps in composite disk images are filled with a shared zero.img.
81const ZERO_FILLER_SIZE: u64 = 4096;
82
Jiyong Park9dd389e2021-08-23 20:42:59 +090083/// Magic string for the instance image
84const ANDROID_VM_INSTANCE_MAGIC: &str = "Android-VM-instance";
85
86/// Version of the instance image format
87const ANDROID_VM_INSTANCE_VERSION: u16 = 1;
88
Alan Stokes0d1ef782022-09-27 13:46:35 +010089const MICRODROID_OS_NAME: &str = "microdroid";
90
Shikha Panwar9fd198f2022-11-18 17:43:43 +000091const UNFORMATTED_STORAGE_MAGIC: &str = "UNFORMATTED-STORAGE";
92
David Brazdil49f96f52022-12-16 21:29:13 +000093lazy_static! {
David Brazdil4b4c5102022-12-19 22:56:20 +000094 pub static ref GLOBAL_SERVICE: Strong<dyn IVirtualizationServiceInternal> =
95 wait_for_interface(BINDER_SERVICE_IDENTIFIER)
96 .expect("Could not connect to VirtualizationServiceInternal");
David Brazdil49f96f52022-12-16 21:29:13 +000097}
98
Nikita Ioffef1ce9872022-12-09 13:31:59 +000099fn create_or_update_idsig_file(
100 input_fd: &ParcelFileDescriptor,
101 idsig_fd: &ParcelFileDescriptor,
102) -> Result<()> {
103 let mut input = clone_file(input_fd)?;
104 let metadata = input.metadata().context("failed to get input metadata")?;
105 if !metadata.is_file() {
106 bail!("input is not a regular file");
107 }
108 let mut sig = V4Signature::create(&mut input, 4096, &[], HashAlgorithm::SHA256)
109 .context("failed to create idsig")?;
110
111 let mut output = clone_file(idsig_fd)?;
Nikita Ioffec09b0492022-12-14 20:18:33 +0000112 output.set_len(0).context("failed to set_len on the idsig output")?;
113 sig.write_into(&mut output).context("failed to write idsig")?;
Nikita Ioffef1ce9872022-12-09 13:31:59 +0000114 Ok(())
115}
116
David Brazdil4b4c5102022-12-19 22:56:20 +0000117pub fn remove_temporary_files(path: &PathBuf) -> Result<()> {
118 for dir_entry in read_dir(path)? {
119 remove_file(dir_entry?.path())?;
120 }
121 Ok(())
David Brazdil528e0472022-10-10 15:06:02 +0100122}
123
David Brazdil528e0472022-10-10 15:06:02 +0100124/// Implementation of `IVirtualizationService`, the entry point of the AIDL service.
David Brazdil49f96f52022-12-16 21:29:13 +0000125#[derive(Debug, Default)]
Andrew Walbranf6bf6862021-05-21 12:41:13 +0000126pub struct VirtualizationService {
Jiyong Park8611a6c2021-07-09 18:17:44 +0900127 state: Arc<Mutex<State>>,
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000128}
129
Shikha Panward8e35422021-10-11 13:51:27 +0000130impl Interface for VirtualizationService {
131 fn dump(&self, mut file: &File, _args: &[&CStr]) -> Result<(), StatusCode> {
132 check_permission("android.permission.DUMP").or(Err(StatusCode::PERMISSION_DENIED))?;
133 let state = &mut *self.state.lock().unwrap();
134 let vms = state.vms();
135 writeln!(file, "Running {0} VMs:", vms.len()).or(Err(StatusCode::UNKNOWN_ERROR))?;
136 for vm in vms {
137 writeln!(file, "VM CID: {}", vm.cid).or(Err(StatusCode::UNKNOWN_ERROR))?;
138 writeln!(file, "\tState: {:?}", vm.vm_state.lock().unwrap())
139 .or(Err(StatusCode::UNKNOWN_ERROR))?;
140 writeln!(file, "\tPayload state {:?}", vm.payload_state())
141 .or(Err(StatusCode::UNKNOWN_ERROR))?;
142 writeln!(file, "\tProtected: {}", vm.protected).or(Err(StatusCode::UNKNOWN_ERROR))?;
143 writeln!(file, "\ttemporary_directory: {}", vm.temporary_directory.to_string_lossy())
144 .or(Err(StatusCode::UNKNOWN_ERROR))?;
145 writeln!(file, "\trequester_uid: {}", vm.requester_uid)
146 .or(Err(StatusCode::UNKNOWN_ERROR))?;
Shikha Panward8e35422021-10-11 13:51:27 +0000147 writeln!(file, "\trequester_debug_pid: {}", vm.requester_debug_pid)
148 .or(Err(StatusCode::UNKNOWN_ERROR))?;
149 }
150 Ok(())
151 }
152}
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000153
Andrew Walbranf6bf6862021-05-21 12:41:13 +0000154impl IVirtualizationService for VirtualizationService {
Andrew Walbranf8d94112021-09-07 11:45:36 +0000155 /// Creates (but does not start) a new VM with the given configuration, assigning it the next
156 /// available CID.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000157 ///
158 /// Returns a binder `IVirtualMachine` object referring to it, as a handle for the client.
Andrew Walbranf8d94112021-09-07 11:45:36 +0000159 fn createVm(
Andrew Walbrana89fc132021-03-17 17:08:36 +0000160 &self,
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000161 config: &VirtualMachineConfig,
Jiyong Parkb8182bb2021-10-26 22:53:08 +0900162 console_fd: Option<&ParcelFileDescriptor>,
Andrew Walbrana89fc132021-03-17 17:08:36 +0000163 log_fd: Option<&ParcelFileDescriptor>,
164 ) -> binder::Result<Strong<dyn IVirtualMachine>> {
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000165 let mut is_protected = false;
166 let ret = self.create_vm_internal(config, console_fd, log_fd, &mut is_protected);
Seungjae Yoo0a8c84c2022-07-11 08:19:15 +0000167 write_vm_creation_stats(config, is_protected, &ret);
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000168 ret
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000169 }
Andrew Walbran320b5602021-03-04 16:11:12 +0000170
Andrew Walbrandff3b942021-06-09 15:20:36 +0000171 /// Initialise an empty partition image of the given size to be used as a writable partition.
172 fn initializeWritablePartition(
173 &self,
174 image_fd: &ParcelFileDescriptor,
175 size: i64,
Jiyong Park9dd389e2021-08-23 20:42:59 +0900176 partition_type: PartitionType,
Andrew Walbrandff3b942021-06-09 15:20:36 +0000177 ) -> binder::Result<()> {
Jiyong Park753553b2021-07-12 21:21:09 +0900178 check_manage_access()?;
Andrew Walbrandfc953d2021-06-10 13:59:56 +0000179 let size = size.try_into().map_err(|e| {
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000180 Status::new_exception_str(
Andrew Walbran806f1542021-06-10 14:07:12 +0000181 ExceptionCode::ILLEGAL_ARGUMENT,
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100182 Some(format!("Invalid size {}: {:?}", size, e)),
Andrew Walbran806f1542021-06-10 14:07:12 +0000183 )
Andrew Walbrandff3b942021-06-09 15:20:36 +0000184 })?;
Andrew Walbrandfc953d2021-06-10 13:59:56 +0000185 let image = clone_file(image_fd)?;
Jooyung Han1edd5b92021-10-28 10:58:05 +0900186 // initialize the file. Any data in the file will be erased.
187 image.set_len(0).map_err(|e| {
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000188 Status::new_service_specific_error_str(
189 -1,
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100190 Some(format!("Failed to reset a file: {:?}", e)),
Jooyung Han1edd5b92021-10-28 10:58:05 +0900191 )
192 })?;
Jiyong Park9dd389e2021-08-23 20:42:59 +0900193 let mut part = QcowFile::new(image, size).map_err(|e| {
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000194 Status::new_service_specific_error_str(
195 -1,
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100196 Some(format!("Failed to create QCOW2 image: {:?}", e)),
Andrew Walbran806f1542021-06-10 14:07:12 +0000197 )
Andrew Walbrandfc953d2021-06-10 13:59:56 +0000198 })?;
Andrew Walbrandff3b942021-06-09 15:20:36 +0000199
Jiyong Park9dd389e2021-08-23 20:42:59 +0900200 match partition_type {
201 PartitionType::RAW => Ok(()),
202 PartitionType::ANDROID_VM_INSTANCE => format_as_android_vm_instance(&mut part),
Shikha Panwar9fd198f2022-11-18 17:43:43 +0000203 PartitionType::ENCRYPTEDSTORE => format_as_encryptedstore(&mut part),
Jiyong Park9dd389e2021-08-23 20:42:59 +0900204 _ => Err(Error::new(
205 ErrorKind::Unsupported,
206 format!("Unsupported partition type {:?}", partition_type),
207 )),
208 }
209 .map_err(|e| {
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000210 Status::new_service_specific_error_str(
211 -1,
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100212 Some(format!("Failed to initialize partition as {:?}: {:?}", partition_type, e)),
Jiyong Park9dd389e2021-08-23 20:42:59 +0900213 )
214 })?;
215
Andrew Walbrandff3b942021-06-09 15:20:36 +0000216 Ok(())
217 }
218
Jiyong Park0a248432021-08-20 23:32:39 +0900219 /// Creates or update the idsig file by digesting the input APK file.
220 fn createOrUpdateIdsigFile(
221 &self,
222 input_fd: &ParcelFileDescriptor,
223 idsig_fd: &ParcelFileDescriptor,
224 ) -> binder::Result<()> {
225 // TODO(b/193504400): do this only when (1) idsig_fd is empty or (2) the APK digest in
226 // idsig_fd is different from APK digest in input_fd
227
Jiyong Parkc3ca24f2022-06-28 10:45:15 +0900228 check_manage_access()?;
229
Nikita Ioffef1ce9872022-12-09 13:31:59 +0000230 create_or_update_idsig_file(input_fd, idsig_fd)
231 .map_err(|e| Status::new_service_specific_error_str(-1, Some(format!("{:?}", e))))?;
Jiyong Park0a248432021-08-20 23:32:39 +0900232 Ok(())
233 }
234
Andrew Walbran320b5602021-03-04 16:11:12 +0000235 /// Get a list of all currently running VMs. This method is only intended for debug purposes,
236 /// and as such is only permitted from the shell user.
237 fn debugListVms(&self) -> binder::Result<Vec<VirtualMachineDebugInfo>> {
David Brazdil209074a2023-01-12 16:44:51 +0000238 // Delegate to the global service, including checking the debug permission.
David Brazdild4f51a52023-01-11 14:09:27 +0000239 GLOBAL_SERVICE.debugListVms()
Andrew Walbran320b5602021-03-04 16:11:12 +0000240 }
241}
242
Jiyong Park8611a6c2021-07-09 18:17:44 +0900243impl VirtualizationService {
244 pub fn init() -> VirtualizationService {
David Brazdil49f96f52022-12-16 21:29:13 +0000245 VirtualizationService::default()
Jiyong Park8611a6c2021-07-09 18:17:44 +0900246 }
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000247
David Brazdil209074a2023-01-12 16:44:51 +0000248 fn create_vm_context(
249 &self,
250 requester_debug_pid: pid_t,
251 ) -> binder::Result<(VmContext, Cid, PathBuf)> {
David Brazdil8cf8f482022-11-23 14:21:26 +0000252 const NUM_ATTEMPTS: usize = 5;
253
254 for _ in 0..NUM_ATTEMPTS {
Charisee96113f32023-01-26 09:00:42 +0000255 let vm_context = GLOBAL_SERVICE.allocateGlobalVmContext(requester_debug_pid)?;
David Brazdild4f51a52023-01-11 14:09:27 +0000256 let cid = vm_context.getCid()? as Cid;
257 let temp_dir: PathBuf = vm_context.getTemporaryDirectory()?.into();
David Brazdil8cf8f482022-11-23 14:21:26 +0000258 let service = VirtualMachineService::new_binder(self.state.clone(), cid).as_binder();
259
260 // Start VM service listening for connections from the new CID on port=CID.
David Brazdil8cf8f482022-11-23 14:21:26 +0000261 let port = cid;
David Brazdil3238da42022-11-18 10:04:51 +0000262 match RpcServer::new_vsock(service, cid, port) {
David Brazdil8cf8f482022-11-23 14:21:26 +0000263 Ok(vm_server) => {
264 vm_server.start();
David Brazdild4f51a52023-01-11 14:09:27 +0000265 return Ok((VmContext::new(vm_context, vm_server), cid, temp_dir));
David Brazdil8cf8f482022-11-23 14:21:26 +0000266 }
267 Err(err) => {
268 warn!("Could not start RpcServer on port {}: {}", port, err);
269 }
270 }
271 }
David Brazdil209074a2023-01-12 16:44:51 +0000272 Err(Status::new_service_specific_error_str(
273 -1,
274 Some("Too many attempts to create VM context failed."),
275 ))
David Brazdil8cf8f482022-11-23 14:21:26 +0000276 }
277
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000278 fn create_vm_internal(
279 &self,
280 config: &VirtualMachineConfig,
281 console_fd: Option<&ParcelFileDescriptor>,
282 log_fd: Option<&ParcelFileDescriptor>,
283 is_protected: &mut bool,
284 ) -> binder::Result<Strong<dyn IVirtualMachine>> {
David Brazdil209074a2023-01-12 16:44:51 +0000285 let requester_uid = get_calling_uid();
286 let requester_debug_pid = get_calling_pid();
287
288 // Allocating VM context checks the MANAGE_VIRTUAL_MACHINE permission.
289 let (vm_context, cid, temporary_directory) = self.create_vm_context(requester_debug_pid)?;
Inseob Kim1119d702022-05-02 18:01:58 +0900290
Alan Stokes7bc146c2022-10-20 17:10:32 +0100291 let is_custom = match config {
292 VirtualMachineConfig::RawConfig(_) => true,
293 VirtualMachineConfig::AppConfig(config) => {
294 // Some features are reserved for platform apps only, even when using
295 // VirtualMachineAppConfig:
296 // - controlling CPUs;
297 // - specifying a config file in the APK.
298 !config.taskProfiles.is_empty() || matches!(config.payload, Payload::ConfigPath(_))
Inseob Kim1119d702022-05-02 18:01:58 +0900299 }
Alan Stokes7bc146c2022-10-20 17:10:32 +0100300 };
301 if is_custom {
302 check_use_custom_virtual_machine()?;
Inseob Kim1119d702022-05-02 18:01:58 +0900303 }
304
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000305 let state = &mut *self.state.lock().unwrap();
Inseob Kim0168b462022-12-27 14:54:35 +0900306 let console_fd =
307 clone_or_prepare_logger_fd(config, console_fd, format!("Console({})", cid))?;
308 let log_fd = clone_or_prepare_logger_fd(config, log_fd, format!("Log({})", cid))?;
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000309
310 // Counter to generate unique IDs for temporary image files.
311 let mut next_temporary_image_id = 0;
312 // Files which are referred to from composite images. These must be mapped to the crosvm
313 // child process, and not closed before it is started.
314 let mut indirect_files = vec![];
315
Alan Stokes7bc146c2022-10-20 17:10:32 +0100316 let (is_app_config, config) = match config {
317 VirtualMachineConfig::RawConfig(config) => (false, BorrowedOrOwned::Borrowed(config)),
318 VirtualMachineConfig::AppConfig(config) => {
319 let config = load_app_config(config, &temporary_directory).map_err(|e| {
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000320 *is_protected = config.protectedVm;
Alan Stokes0d1ef782022-09-27 13:46:35 +0100321 let message = format!("Failed to load app config: {:?}", e);
322 error!("{}", message);
323 Status::new_service_specific_error_str(-1, Some(message))
Alan Stokes7bc146c2022-10-20 17:10:32 +0100324 })?;
325 (true, BorrowedOrOwned::Owned(config))
326 }
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000327 };
328 let config = config.as_ref();
329 *is_protected = config.protectedVm;
330
331 // Check if partition images are labeled incorrectly. This is to prevent random images
332 // which are not protected by the Android Verified Boot (e.g. bits downloaded by apps) from
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100333 // being loaded in a pVM. This applies to everything in the raw config, and everything but
334 // the non-executable, generated partitions in the app config.
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000335 config
336 .disks
337 .iter()
338 .flat_map(|disk| disk.partitions.iter())
339 .filter(|partition| {
340 if is_app_config {
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100341 !is_safe_app_partition(&partition.label)
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000342 } else {
343 true // all partitions are checked
344 }
345 })
346 .try_for_each(check_label_for_partition)
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100347 .map_err(|e| Status::new_service_specific_error_str(-1, Some(format!("{:?}", e))))?;
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000348
Alan Stokes185fe112023-01-10 16:20:55 +0000349 let kernel = maybe_clone_file(&config.kernel)?;
350 let initrd = maybe_clone_file(&config.initrd)?;
351
352 // In a protected VM, we require custom kernels to come from a trusted source (b/237054515).
353 if config.protectedVm {
354 check_label_for_kernel_files(&kernel, &initrd).map_err(|e| {
355 Status::new_service_specific_error_str(-1, Some(format!("{:?}", e)))
356 })?;
357 }
358
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000359 let zero_filler_path = temporary_directory.join("zero.img");
360 write_zero_filler(&zero_filler_path).map_err(|e| {
Alan Stokes70ccf162022-07-08 11:05:03 +0100361 error!("Failed to make composite image: {:?}", e);
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000362 Status::new_service_specific_error_str(
363 -1,
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100364 Some(format!("Failed to make composite image: {:?}", e)),
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000365 )
366 })?;
367
368 // Assemble disk images if needed.
369 let disks = config
370 .disks
371 .iter()
372 .map(|disk| {
373 assemble_disk_image(
374 disk,
375 &zero_filler_path,
376 &temporary_directory,
377 &mut next_temporary_image_id,
378 &mut indirect_files,
379 )
380 })
381 .collect::<Result<Vec<DiskFile>, _>>()?;
382
Jiyong Parke558ab12022-07-07 20:18:55 +0900383 // Creating this ramdump file unconditionally is not harmful as ramdump will be created
384 // only when the VM is configured as such. `ramdump_write` is sent to crosvm and will
Jiyong Park4afe2012022-07-08 05:38:49 +0900385 // be the backing store for the /dev/hvc1 where VM will emit ramdump to. `ramdump_read`
Jiyong Parke558ab12022-07-07 20:18:55 +0900386 // will be sent back to the client (i.e. the VM owner) for readout.
387 let ramdump_path = temporary_directory.join("ramdump");
388 let ramdump = prepare_ramdump_file(&ramdump_path).map_err(|e| {
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100389 error!("Failed to prepare ramdump file: {:?}", e);
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000390 Status::new_service_specific_error_str(
391 -1,
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100392 Some(format!("Failed to prepare ramdump file: {:?}", e)),
Jiyong Parke558ab12022-07-07 20:18:55 +0900393 )
394 })?;
395
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000396 // Actually start the VM.
397 let crosvm_config = CrosvmConfig {
398 cid,
Seungjae Yoo62085c02022-08-12 04:44:52 +0000399 name: config.name.clone(),
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000400 bootloader: maybe_clone_file(&config.bootloader)?,
Alan Stokes185fe112023-01-10 16:20:55 +0000401 kernel,
402 initrd,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000403 disks,
404 params: config.params.to_owned(),
405 protected: *is_protected,
406 memory_mib: config.memoryMib.try_into().ok().and_then(NonZeroU32::new),
407 cpus: config.numCpus.try_into().ok().and_then(NonZeroU32::new),
Jiyong Parkdfe16d62022-04-20 17:32:12 +0900408 task_profiles: config.taskProfiles.clone(),
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000409 console_fd,
410 log_fd,
Jiyong Parke558ab12022-07-07 20:18:55 +0900411 ramdump: Some(ramdump),
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000412 indirect_files,
413 platform_version: parse_platform_version_req(&config.platformVersion)?,
Jiyong Parke6ed0f92022-06-22 00:13:00 +0900414 detect_hangup: is_app_config,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000415 };
416 let instance = Arc::new(
David Brazdil528e0472022-10-10 15:06:02 +0100417 VmInstance::new(
418 crosvm_config,
419 temporary_directory,
420 requester_uid,
421 requester_debug_pid,
422 vm_context,
423 )
424 .map_err(|e| {
425 error!("Failed to create VM with config {:?}: {:?}", config, e);
426 Status::new_service_specific_error_str(
427 -1,
428 Some(format!("Failed to create VM: {:?}", e)),
429 )
430 })?,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000431 );
432 state.add_vm(Arc::downgrade(&instance));
433 Ok(VirtualMachine::create(instance))
434 }
Jiyong Park8611a6c2021-07-09 18:17:44 +0900435}
436
Andrew Walbranfbb39d22021-07-28 17:01:25 +0000437fn write_zero_filler(zero_filler_path: &Path) -> Result<()> {
Jooyung Han95884632021-07-06 22:27:54 +0900438 let file = OpenOptions::new()
439 .create_new(true)
440 .read(true)
441 .write(true)
442 .open(zero_filler_path)
443 .with_context(|| "Failed to create zero.img")?;
444 file.set_len(ZERO_FILLER_SIZE)?;
Andrew Walbranfbb39d22021-07-28 17:01:25 +0000445 Ok(())
Jooyung Han95884632021-07-06 22:27:54 +0900446}
447
Jiyong Park9dd389e2021-08-23 20:42:59 +0900448fn format_as_android_vm_instance(part: &mut dyn Write) -> std::io::Result<()> {
449 part.write_all(ANDROID_VM_INSTANCE_MAGIC.as_bytes())?;
450 part.write_all(&ANDROID_VM_INSTANCE_VERSION.to_le_bytes())?;
451 part.flush()
452}
453
Shikha Panwar9fd198f2022-11-18 17:43:43 +0000454fn format_as_encryptedstore(part: &mut dyn Write) -> std::io::Result<()> {
455 part.write_all(UNFORMATTED_STORAGE_MAGIC.as_bytes())?;
456 part.flush()
457}
458
Jiyong Parke558ab12022-07-07 20:18:55 +0900459fn prepare_ramdump_file(ramdump_path: &Path) -> Result<File> {
Chris Wailes9b866f02022-11-16 15:17:16 -0800460 File::create(ramdump_path).context(format!("Failed to create ramdump file {:?}", &ramdump_path))
Jiyong Parke558ab12022-07-07 20:18:55 +0900461}
462
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000463/// Given the configuration for a disk image, assembles the `DiskFile` to pass to crosvm.
464///
465/// This may involve assembling a composite disk from a set of partition images.
466fn assemble_disk_image(
467 disk: &DiskImage,
Jooyung Han95884632021-07-06 22:27:54 +0900468 zero_filler_path: &Path,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000469 temporary_directory: &Path,
470 next_temporary_image_id: &mut u64,
471 indirect_files: &mut Vec<File>,
Andrew Walbran806f1542021-06-10 14:07:12 +0000472) -> Result<DiskFile, Status> {
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000473 let image = if !disk.partitions.is_empty() {
474 if disk.image.is_some() {
475 warn!("DiskImage {:?} contains both image and partitions.", disk);
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000476 return Err(Status::new_exception_str(
Andrew Walbran806f1542021-06-10 14:07:12 +0000477 ExceptionCode::ILLEGAL_ARGUMENT,
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000478 Some("DiskImage contains both image and partitions."),
Andrew Walbran806f1542021-06-10 14:07:12 +0000479 ));
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000480 }
481
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000482 let composite_image_filenames =
483 make_composite_image_filenames(temporary_directory, next_temporary_image_id);
484 let (image, partition_files) = make_composite_image(
485 &disk.partitions,
Jooyung Han95884632021-07-06 22:27:54 +0900486 zero_filler_path,
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000487 &composite_image_filenames.composite,
488 &composite_image_filenames.header,
489 &composite_image_filenames.footer,
490 )
491 .map_err(|e| {
Alan Stokes70ccf162022-07-08 11:05:03 +0100492 error!("Failed to make composite image with config {:?}: {:?}", disk, e);
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000493 Status::new_service_specific_error_str(
494 -1,
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100495 Some(format!("Failed to make composite image: {:?}", e)),
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000496 )
497 })?;
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000498
499 // Pass the file descriptors for the various partition files to crosvm when it
500 // is run.
501 indirect_files.extend(partition_files);
502
503 image
504 } else if let Some(image) = &disk.image {
505 clone_file(image)?
506 } else {
507 warn!("DiskImage {:?} didn't contain image or partitions.", disk);
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000508 return Err(Status::new_exception_str(
Andrew Walbran806f1542021-06-10 14:07:12 +0000509 ExceptionCode::ILLEGAL_ARGUMENT,
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000510 Some("DiskImage didn't contain image or partitions."),
Andrew Walbran806f1542021-06-10 14:07:12 +0000511 ));
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000512 };
513
514 Ok(DiskFile { image, writable: disk.writable })
515}
516
Jooyung Han21e9b922021-06-26 04:14:16 +0900517fn load_app_config(
518 config: &VirtualMachineAppConfig,
519 temporary_directory: &Path,
Jooyung Hanadfb76c2021-06-28 17:29:30 +0900520) -> Result<VirtualMachineRawConfig> {
Andrew Walbrancc0db522021-07-12 17:03:42 +0000521 let apk_file = clone_file(config.apk.as_ref().unwrap())?;
522 let idsig_file = clone_file(config.idsig.as_ref().unwrap())?;
Jiyong Park8d081812021-07-23 17:45:04 +0900523 let instance_file = clone_file(config.instanceImage.as_ref().unwrap())?;
Jooyung Han21e9b922021-06-26 04:14:16 +0900524
Shikha Panwar22e70452022-10-10 18:32:55 +0000525 let storage_image = if let Some(file) = config.encryptedStorageImage.as_ref() {
526 Some(clone_file(file)?)
527 } else {
528 None
529 };
530
Alan Stokes0d1ef782022-09-27 13:46:35 +0100531 let vm_payload_config = match &config.payload {
532 Payload::ConfigPath(config_path) => {
533 load_vm_payload_config_from_file(&apk_file, config_path.as_str())
534 .with_context(|| format!("Couldn't read config from {}", config_path))?
535 }
Alan Stokes8f12f2b2023-01-09 09:19:20 +0000536 Payload::PayloadConfig(payload_config) => create_vm_payload_config(payload_config)?,
Alan Stokes0d1ef782022-09-27 13:46:35 +0100537 };
Jooyung Han21e9b922021-06-26 04:14:16 +0900538
Alan Stokes0d1ef782022-09-27 13:46:35 +0100539 // For now, the only supported OS is Microdroid
540 let os_name = vm_payload_config.os.name.as_str();
541 if os_name != MICRODROID_OS_NAME {
Andrew Walbrancc0db522021-07-12 17:03:42 +0000542 bail!("Unknown OS \"{}\"", os_name);
Jooyung Han35edb8f2021-07-01 16:17:16 +0900543 }
Andrew Walbrancc0db522021-07-12 17:03:42 +0000544
545 // It is safe to construct a filename based on the os_name because we've already checked that it
546 // is one of the allowed values.
Jooyung Han21e9b922021-06-26 04:14:16 +0900547 let vm_config_path = PathBuf::from(format!("/apex/com.android.virt/etc/{}.json", os_name));
548 let vm_config_file = File::open(vm_config_path)?;
Andrew Walbrancc0db522021-07-12 17:03:42 +0000549 let mut vm_config = VmConfig::load(&vm_config_file)?.to_parcelable()?;
Jooyung Han21e9b922021-06-26 04:14:16 +0900550
Andrew Walbrancc045902021-07-27 16:06:17 +0000551 if config.memoryMib > 0 {
552 vm_config.memoryMib = config.memoryMib;
Andrew Walbran45bcb0c2021-07-14 15:02:06 +0000553 }
554
Seungjae Yoo62085c02022-08-12 04:44:52 +0000555 vm_config.name = config.name.clone();
Andrew Walbran3994f002022-01-27 17:33:45 +0000556 vm_config.protectedVm = config.protectedVm;
Jiyong Park032615f2022-01-10 13:55:34 +0900557 vm_config.numCpus = config.numCpus;
Jiyong Parkdfe16d62022-04-20 17:32:12 +0900558 vm_config.taskProfiles = config.taskProfiles.clone();
Jiyong Park032615f2022-01-10 13:55:34 +0900559
Shikha Panwar22e70452022-10-10 18:32:55 +0000560 // Microdroid takes additional init ramdisk & (optionally) storage image
561 add_microdroid_system_images(config, instance_file, storage_image, &mut vm_config)?;
562
563 // Include Microdroid payload disk (contains apks, idsigs) in vm config
564 add_microdroid_payload_images(
Alan Stokes0d1ef782022-09-27 13:46:35 +0100565 config,
566 temporary_directory,
567 apk_file,
568 idsig_file,
Alan Stokes0d1ef782022-09-27 13:46:35 +0100569 &vm_payload_config,
570 &mut vm_config,
571 )?;
Jooyung Han21e9b922021-06-26 04:14:16 +0900572
Andrew Walbrancc0db522021-07-12 17:03:42 +0000573 Ok(vm_config)
Jooyung Han21e9b922021-06-26 04:14:16 +0900574}
575
Alan Stokes0d1ef782022-09-27 13:46:35 +0100576fn load_vm_payload_config_from_file(apk_file: &File, config_path: &str) -> Result<VmPayloadConfig> {
577 let mut apk_zip = ZipArchive::new(apk_file)?;
578 let config_file = apk_zip.by_name(config_path)?;
579 Ok(serde_json::from_reader(config_file)?)
580}
581
Alan Stokes8f12f2b2023-01-09 09:19:20 +0000582fn create_vm_payload_config(
583 payload_config: &VirtualMachinePayloadConfig,
584) -> Result<VmPayloadConfig> {
Alan Stokes0d1ef782022-09-27 13:46:35 +0100585 // There isn't an actual config file. Construct a synthetic VmPayloadConfig from the explicit
586 // parameters we've been given. Microdroid will do something equivalent inside the VM using the
587 // payload config that we send it via the metadata file.
Alan Stokes8f12f2b2023-01-09 09:19:20 +0000588
589 let payload_binary_name = &payload_config.payloadBinaryName;
590 if payload_binary_name.contains('/') {
591 bail!("Payload binary name must not specify a path: {payload_binary_name}");
592 }
593
594 let task = Task { type_: TaskType::MicrodroidLauncher, command: payload_binary_name.clone() };
595 Ok(VmPayloadConfig {
Alan Stokes0d1ef782022-09-27 13:46:35 +0100596 os: OsConfig { name: MICRODROID_OS_NAME.to_owned() },
597 task: Some(task),
598 apexes: vec![],
599 extra_apks: vec![],
600 prefer_staged: false,
Alan Stokes1f417c92022-09-29 15:13:28 +0100601 export_tombstones: false,
Alan Stokes0d1ef782022-09-27 13:46:35 +0100602 enable_authfs: false,
Alan Stokes8f12f2b2023-01-09 09:19:20 +0000603 })
Alan Stokes0d1ef782022-09-27 13:46:35 +0100604}
605
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000606/// Generates a unique filename to use for a composite disk image.
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000607fn make_composite_image_filenames(
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000608 temporary_directory: &Path,
609 next_temporary_image_id: &mut u64,
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000610) -> CompositeImageFilenames {
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000611 let id = *next_temporary_image_id;
612 *next_temporary_image_id += 1;
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000613 CompositeImageFilenames {
614 composite: temporary_directory.join(format!("composite-{}.img", id)),
615 header: temporary_directory.join(format!("composite-{}-header.img", id)),
616 footer: temporary_directory.join(format!("composite-{}-footer.img", id)),
617 }
618}
619
620/// Filenames for a composite disk image, including header and footer partitions.
621#[derive(Clone, Debug, Eq, PartialEq)]
622struct CompositeImageFilenames {
623 /// The composite disk image itself.
624 composite: PathBuf,
625 /// The header partition image.
626 header: PathBuf,
627 /// The footer partition image.
628 footer: PathBuf,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000629}
630
Jiyong Park753553b2021-07-12 21:21:09 +0900631/// Checks whether the caller has a specific permission
632fn check_permission(perm: &str) -> binder::Result<()> {
David Brazdil1f530702022-10-03 12:18:10 +0100633 let calling_pid = get_calling_pid();
634 let calling_uid = get_calling_uid();
Jiyong Park753553b2021-07-12 21:21:09 +0900635 // Root can do anything
636 if calling_uid == 0 {
637 return Ok(());
638 }
639 let perm_svc: Strong<dyn IPermissionController::IPermissionController> =
640 binder::get_interface("permission")?;
641 if perm_svc.checkPermission(perm, calling_pid, calling_uid as i32)? {
Andrew Walbran806f1542021-06-10 14:07:12 +0000642 Ok(())
643 } else {
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000644 Err(Status::new_exception_str(
Jiyong Park753553b2021-07-12 21:21:09 +0900645 ExceptionCode::SECURITY,
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000646 Some(format!("does not have the {} permission", perm)),
Jiyong Park753553b2021-07-12 21:21:09 +0900647 ))
Andrew Walbran806f1542021-06-10 14:07:12 +0000648 }
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000649}
650
Jiyong Park753553b2021-07-12 21:21:09 +0900651/// Check whether the caller of the current Binder method is allowed to manage VMs
652fn check_manage_access() -> binder::Result<()> {
653 check_permission("android.permission.MANAGE_VIRTUAL_MACHINE")
654}
655
Inseob Kim1119d702022-05-02 18:01:58 +0900656/// Check whether the caller of the current Binder method is allowed to create custom VMs
657fn check_use_custom_virtual_machine() -> binder::Result<()> {
658 check_permission("android.permission.USE_CUSTOM_VIRTUAL_MACHINE")
659}
660
Alan Stokes185fe112023-01-10 16:20:55 +0000661/// Return whether a partition is exempt from selinux label checks, because we know that it does
662/// not contain code and is likely to be generated in an app-writable directory.
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100663fn is_safe_app_partition(label: &str) -> bool {
Shikha Panwara2ff8c52022-11-30 19:25:46 +0000664 // See add_microdroid_system_images & add_microdroid_payload_images in payload.rs.
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100665 label == "vm-instance"
Shikha Panwara2ff8c52022-11-30 19:25:46 +0000666 || label == "encryptedstore"
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100667 || label == "microdroid-apk-idsig"
668 || label == "payload-metadata"
669 || label.starts_with("extra-idsig-")
670}
671
Alan Stokes185fe112023-01-10 16:20:55 +0000672/// Check that a file SELinux label is acceptable.
673///
674/// We only want to allow code in a VM to be sourced from places that apps, and the
675/// system, do not have write access to.
676///
677/// Note that sepolicy must also grant read access for these types to both virtualization
678/// service and crosvm.
679///
680/// App private data files are deliberately excluded, to avoid arbitrary payloads being run on
681/// user devices (W^X).
682fn check_label_is_allowed(context: &SeContext) -> Result<()> {
683 match context.selinux_type()? {
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100684 | "system_file" // immutable dm-verity protected partition
685 | "apk_data_file" // APKs of an installed app
Shikha Panwara2ff8c52022-11-30 19:25:46 +0000686 | "staging_data_file" // updated/staged APEX images
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100687 | "shell_data_file" // test files created via adb shell
688 => Ok(()),
Alan Stokes185fe112023-01-10 16:20:55 +0000689 _ => bail!("Label {} is not allowed", context),
Jiyong Park029977d2021-11-24 21:56:49 +0900690 }
691}
692
Alan Stokes185fe112023-01-10 16:20:55 +0000693fn check_label_for_partition(partition: &Partition) -> Result<()> {
694 let file = partition.image.as_ref().unwrap().as_ref();
695 check_label_is_allowed(&getfilecon(file)?)
696 .with_context(|| format!("Partition {} invalid", &partition.label))
697}
698
699fn check_label_for_kernel_files(kernel: &Option<File>, initrd: &Option<File>) -> Result<()> {
700 if let Some(f) = kernel {
701 check_label_for_file(f, "kernel")?;
702 }
703 if let Some(f) = initrd {
704 check_label_for_file(f, "initrd")?;
705 }
706 Ok(())
707}
708fn check_label_for_file(file: &File, name: &str) -> Result<()> {
709 check_label_is_allowed(&getfilecon(file)?).with_context(|| format!("{} file invalid", name))
710}
711
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000712/// Implementation of the AIDL `IVirtualMachine` interface. Used as a handle to a VM.
713#[derive(Debug)]
714struct VirtualMachine {
715 instance: Arc<VmInstance>,
716}
717
718impl VirtualMachine {
719 fn create(instance: Arc<VmInstance>) -> Strong<dyn IVirtualMachine> {
David Brazdil4b4c5102022-12-19 22:56:20 +0000720 BnVirtualMachine::new_binder(VirtualMachine { instance }, BinderFeatures::default())
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000721 }
722}
723
724impl Interface for VirtualMachine {}
725
726impl IVirtualMachine for VirtualMachine {
727 fn getCid(&self) -> binder::Result<i32> {
Jiyong Park753553b2021-07-12 21:21:09 +0900728 // Don't check permission. The owner of the VM might have passed this binder object to
729 // others.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000730 Ok(self.instance.cid as i32)
731 }
Andrew Walbrandae07162021-03-12 17:05:20 +0000732
Andrew Walbran6b650662021-09-07 13:13:23 +0000733 fn getState(&self) -> binder::Result<VirtualMachineState> {
Jiyong Park753553b2021-07-12 21:21:09 +0900734 // Don't check permission. The owner of the VM might have passed this binder object to
735 // others.
Andrew Walbran6b650662021-09-07 13:13:23 +0000736 Ok(get_state(&self.instance))
Andrew Walbrandae07162021-03-12 17:05:20 +0000737 }
738
739 fn registerCallback(
740 &self,
741 callback: &Strong<dyn IVirtualMachineCallback>,
742 ) -> binder::Result<()> {
Jiyong Park753553b2021-07-12 21:21:09 +0900743 // Don't check permission. The owner of the VM might have passed this binder object to
744 // others.
745 //
Andrew Walbrandae07162021-03-12 17:05:20 +0000746 // TODO: Should this give an error if the VM is already dead?
747 self.instance.callbacks.add(callback.clone());
748 Ok(())
749 }
Andrew Walbrancbe8b082021-08-06 15:42:11 +0000750
Andrew Walbranf8d94112021-09-07 11:45:36 +0000751 fn start(&self) -> binder::Result<()> {
752 self.instance.start().map_err(|e| {
753 error!("Error starting VM with CID {}: {:?}", self.instance.cid, e);
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000754 Status::new_service_specific_error_str(-1, Some(e.to_string()))
Andrew Walbranf8d94112021-09-07 11:45:36 +0000755 })
756 }
757
Inseob Kima446f802022-07-11 19:46:37 +0900758 fn stop(&self) -> binder::Result<()> {
759 self.instance.kill().map_err(|e| {
760 error!("Error stopping VM with CID {}: {:?}", self.instance.cid, e);
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000761 Status::new_service_specific_error_str(-1, Some(e.to_string()))
Inseob Kima446f802022-07-11 19:46:37 +0900762 })
763 }
764
Keir Frasercdd4b112022-11-24 14:02:25 +0000765 fn onTrimMemory(&self, level: MemoryTrimLevel) -> binder::Result<()> {
766 self.instance.trim_memory(level).map_err(|e| {
767 error!("Error trimming VM with CID {}: {:?}", self.instance.cid, e);
768 Status::new_service_specific_error_str(-1, Some(e.to_string()))
769 })
770 }
771
Andrew Walbrancbe8b082021-08-06 15:42:11 +0000772 fn connectVsock(&self, port: i32) -> binder::Result<ParcelFileDescriptor> {
Andrew Walbranf8d94112021-09-07 11:45:36 +0000773 if !matches!(&*self.instance.vm_state.lock().unwrap(), VmState::Running { .. }) {
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000774 return Err(Status::new_service_specific_error_str(-1, Some("VM is not running")));
Andrew Walbrancbe8b082021-08-06 15:42:11 +0000775 }
Alan Stokes10c47672022-12-13 17:17:08 +0000776 let port = port as u32;
777 if port < 1024 {
778 return Err(Status::new_service_specific_error_str(
779 -1,
780 Some(format!("Can't connect to privileged port {port}")),
781 ));
782 }
783 let stream = VsockStream::connect_with_cid_port(self.instance.cid, port).map_err(|e| {
784 Status::new_service_specific_error_str(-1, Some(format!("Failed to connect: {:?}", e)))
785 })?;
Andrew Walbrancbe8b082021-08-06 15:42:11 +0000786 Ok(vsock_stream_to_pfd(stream))
787 }
Andrew Walbrandae07162021-03-12 17:05:20 +0000788}
789
790impl Drop for VirtualMachine {
791 fn drop(&mut self) {
792 debug!("Dropping {:?}", self);
Inseob Kima446f802022-07-11 19:46:37 +0900793 if let Err(e) = self.instance.kill() {
794 debug!("Error stopping dropped VM with CID {}: {:?}", self.instance.cid, e);
795 }
Andrew Walbrandae07162021-03-12 17:05:20 +0000796 }
797}
798
799/// A set of Binders to be called back in response to various events on the VM, such as when it
800/// dies.
801#[derive(Debug, Default)]
802pub struct VirtualMachineCallbacks(Mutex<Vec<Strong<dyn IVirtualMachineCallback>>>);
803
804impl VirtualMachineCallbacks {
Jiyong Park8611a6c2021-07-09 18:17:44 +0900805 /// Call all registered callbacks to notify that the payload has started.
David Brazdil451cc962022-10-14 14:08:12 +0100806 pub fn notify_payload_started(&self, cid: Cid) {
Jiyong Park8611a6c2021-07-09 18:17:44 +0900807 let callbacks = &*self.0.lock().unwrap();
Jiyong Park8611a6c2021-07-09 18:17:44 +0900808 for callback in callbacks {
David Brazdil451cc962022-10-14 14:08:12 +0100809 if let Err(e) = callback.onPayloadStarted(cid as i32) {
Alan Stokes70ccf162022-07-08 11:05:03 +0100810 error!("Error notifying payload start event from VM CID {}: {:?}", cid, e);
Jiyong Park8611a6c2021-07-09 18:17:44 +0900811 }
812 }
813 }
814
Inseob Kim14cb8692021-08-31 21:50:39 +0900815 /// Call all registered callbacks to notify that the payload is ready to serve.
816 pub fn notify_payload_ready(&self, cid: Cid) {
817 let callbacks = &*self.0.lock().unwrap();
818 for callback in callbacks {
819 if let Err(e) = callback.onPayloadReady(cid as i32) {
Alan Stokes70ccf162022-07-08 11:05:03 +0100820 error!("Error notifying payload ready event from VM CID {}: {:?}", cid, e);
Inseob Kim14cb8692021-08-31 21:50:39 +0900821 }
822 }
823 }
824
Inseob Kim2444af92021-08-31 01:22:50 +0900825 /// Call all registered callbacks to notify that the payload has finished.
826 pub fn notify_payload_finished(&self, cid: Cid, exit_code: i32) {
827 let callbacks = &*self.0.lock().unwrap();
828 for callback in callbacks {
829 if let Err(e) = callback.onPayloadFinished(cid as i32, exit_code) {
Alan Stokes70ccf162022-07-08 11:05:03 +0100830 error!("Error notifying payload finish event from VM CID {}: {:?}", cid, e);
Inseob Kim2444af92021-08-31 01:22:50 +0900831 }
832 }
833 }
834
Jooyung Handd0a1732021-11-23 15:26:20 +0900835 /// Call all registered callbacks to say that the VM encountered an error.
Alan Stokes2bead0d2022-09-05 16:58:34 +0100836 pub fn notify_error(&self, cid: Cid, error_code: ErrorCode, message: &str) {
Jooyung Handd0a1732021-11-23 15:26:20 +0900837 let callbacks = &*self.0.lock().unwrap();
838 for callback in callbacks {
839 if let Err(e) = callback.onError(cid as i32, error_code, message) {
Alan Stokes70ccf162022-07-08 11:05:03 +0100840 error!("Error notifying error event from VM CID {}: {:?}", cid, e);
Jooyung Handd0a1732021-11-23 15:26:20 +0900841 }
842 }
843 }
844
Andrew Walbrandae07162021-03-12 17:05:20 +0000845 /// Call all registered callbacks to say that the VM has died.
Andrew Walbranc92d35f2022-01-12 12:45:19 +0000846 pub fn callback_on_died(&self, cid: Cid, reason: DeathReason) {
Andrew Walbrandae07162021-03-12 17:05:20 +0000847 let callbacks = &*self.0.lock().unwrap();
848 for callback in callbacks {
Andrew Walbranc92d35f2022-01-12 12:45:19 +0000849 if let Err(e) = callback.onDied(cid as i32, reason) {
Alan Stokes70ccf162022-07-08 11:05:03 +0100850 error!("Error notifying exit of VM CID {}: {:?}", cid, e);
Andrew Walbrandae07162021-03-12 17:05:20 +0000851 }
852 }
853 }
854
855 /// Add a new callback to the set.
856 fn add(&self, callback: Strong<dyn IVirtualMachineCallback>) {
857 self.0.lock().unwrap().push(callback);
858 }
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000859}
860
Andrew Walbranf6bf6862021-05-21 12:41:13 +0000861/// The mutable state of the VirtualizationService. There should only be one instance of this
862/// struct.
Chris Wailes641fc4a2021-12-01 15:03:21 -0800863#[derive(Debug, Default)]
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000864struct State {
Andrew Walbran320b5602021-03-04 16:11:12 +0000865 /// The VMs which have been started. When VMs are started a weak reference is added to this list
866 /// while a strong reference is returned to the caller over Binder. Once all copies of the
867 /// Binder client are dropped the weak reference here will become invalid, and will be removed
868 /// from the list opportunistically the next time `add_vm` is called.
869 vms: Vec<Weak<VmInstance>>,
870}
871
872impl State {
Andrew Walbrandae07162021-03-12 17:05:20 +0000873 /// Get a list of VMs which still have Binder references to them.
Andrew Walbran320b5602021-03-04 16:11:12 +0000874 fn vms(&self) -> Vec<Arc<VmInstance>> {
875 // Attempt to upgrade the weak pointers to strong pointers.
876 self.vms.iter().filter_map(Weak::upgrade).collect()
877 }
878
879 /// Add a new VM to the list.
880 fn add_vm(&mut self, vm: Weak<VmInstance>) {
881 // Garbage collect any entries from the stored list which no longer exist.
882 self.vms.retain(|vm| vm.strong_count() > 0);
883
884 // Actually add the new VM.
885 self.vms.push(vm);
886 }
David Brazdil3c2ddef2021-03-18 13:09:57 +0000887
Jiyong Park8611a6c2021-07-09 18:17:44 +0900888 /// Get a VM that corresponds to the given cid
889 fn get_vm(&self, cid: Cid) -> Option<Arc<VmInstance>> {
890 self.vms().into_iter().find(|vm| vm.cid == cid)
891 }
Jiyong Parkd50a0242021-09-16 21:00:14 +0900892}
893
Andrew Walbran6b650662021-09-07 13:13:23 +0000894/// Gets the `VirtualMachineState` of the given `VmInstance`.
895fn get_state(instance: &VmInstance) -> VirtualMachineState {
Andrew Walbranf8d94112021-09-07 11:45:36 +0000896 match &*instance.vm_state.lock().unwrap() {
897 VmState::NotStarted { .. } => VirtualMachineState::NOT_STARTED,
898 VmState::Running { .. } => match instance.payload_state() {
Andrew Walbran6b650662021-09-07 13:13:23 +0000899 PayloadState::Starting => VirtualMachineState::STARTING,
900 PayloadState::Started => VirtualMachineState::STARTED,
901 PayloadState::Ready => VirtualMachineState::READY,
902 PayloadState::Finished => VirtualMachineState::FINISHED,
Jiyong Parka4eebde2022-07-12 18:01:12 +0900903 PayloadState::Hangup => VirtualMachineState::DEAD,
Andrew Walbranf8d94112021-09-07 11:45:36 +0000904 },
905 VmState::Dead => VirtualMachineState::DEAD,
906 VmState::Failed => VirtualMachineState::DEAD,
Andrew Walbran6b650662021-09-07 13:13:23 +0000907 }
908}
909
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000910/// Converts a `&ParcelFileDescriptor` to a `File` by cloning the file.
Seungjae Yoo0a8c84c2022-07-11 08:19:15 +0000911pub fn clone_file(file: &ParcelFileDescriptor) -> Result<File, Status> {
Andrew Walbran806f1542021-06-10 14:07:12 +0000912 file.as_ref().try_clone().map_err(|e| {
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000913 Status::new_exception_str(
Andrew Walbran806f1542021-06-10 14:07:12 +0000914 ExceptionCode::BAD_PARCELABLE,
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100915 Some(format!("Failed to clone File from ParcelFileDescriptor: {:?}", e)),
Andrew Walbran806f1542021-06-10 14:07:12 +0000916 )
917 })
918}
919
Andrew Walbrand3a84182021-09-07 14:48:52 +0000920/// Converts an `&Option<ParcelFileDescriptor>` to an `Option<File>` by cloning the file.
921fn maybe_clone_file(file: &Option<ParcelFileDescriptor>) -> Result<Option<File>, Status> {
922 file.as_ref().map(clone_file).transpose()
923}
924
Andrew Walbrancbe8b082021-08-06 15:42:11 +0000925/// Converts a `VsockStream` to a `ParcelFileDescriptor`.
926fn vsock_stream_to_pfd(stream: VsockStream) -> ParcelFileDescriptor {
927 // SAFETY: ownership is transferred from stream to f
928 let f = unsafe { File::from_raw_fd(stream.into_raw_fd()) };
929 ParcelFileDescriptor::new(f)
930}
931
Jiyong Parkdcf17412022-02-08 15:07:23 +0900932/// Parses the platform version requirement string.
933fn parse_platform_version_req(s: &str) -> Result<VersionReq, Status> {
934 VersionReq::parse(s).map_err(|e| {
Andrew Walbrandcf9d582022-08-03 11:25:24 +0000935 Status::new_exception_str(
Jiyong Parkdcf17412022-02-08 15:07:23 +0900936 ExceptionCode::BAD_PARCELABLE,
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100937 Some(format!("Invalid platform version requirement {}: {:?}", s, e)),
Jiyong Parkdcf17412022-02-08 15:07:23 +0900938 )
939 })
940}
941
Inseob Kim0168b462022-12-27 14:54:35 +0900942fn is_debuggable(config: &VirtualMachineConfig) -> bool {
943 match config {
944 VirtualMachineConfig::AppConfig(config) => config.debugLevel != DebugLevel::NONE,
945 _ => false,
946 }
947}
948
949fn clone_or_prepare_logger_fd(
950 config: &VirtualMachineConfig,
951 fd: Option<&ParcelFileDescriptor>,
952 tag: String,
953) -> Result<Option<File>, Status> {
954 if let Some(fd) = fd {
955 return Ok(Some(clone_file(fd)?));
956 }
957
958 if !is_debuggable(config) {
959 return Ok(None);
960 }
961
962 let (raw_read_fd, raw_write_fd) = pipe().map_err(|e| {
963 Status::new_service_specific_error_str(-1, Some(format!("Failed to create pipe: {:?}", e)))
964 })?;
965
966 // SAFETY: We are the sole owners of these fds as they were just created.
967 let mut reader = BufReader::new(unsafe { File::from_raw_fd(raw_read_fd) });
968 let write_fd = unsafe { File::from_raw_fd(raw_write_fd) };
969
970 std::thread::spawn(move || loop {
971 let mut buf = vec![];
972 match reader.read_until(b'\n', &mut buf) {
973 Ok(0) => {
974 // EOF
975 return;
976 }
977 Ok(size) => {
978 if buf[size - 1] == b'\n' {
979 buf.pop();
980 }
981 info!("{}: {}", &tag, &String::from_utf8_lossy(&buf));
982 }
983 Err(e) => {
984 error!("Could not read console pipe: {:?}", e);
985 return;
986 }
987 };
988 });
989
990 Ok(Some(write_fd))
991}
992
Jooyung Han35edb8f2021-07-01 16:17:16 +0900993/// Simple utility for referencing Borrowed or Owned. Similar to std::borrow::Cow, but
994/// it doesn't require that T implements Clone.
995enum BorrowedOrOwned<'a, T> {
996 Borrowed(&'a T),
997 Owned(T),
998}
999
1000impl<'a, T> AsRef<T> for BorrowedOrOwned<'a, T> {
1001 fn as_ref(&self) -> &T {
1002 match self {
1003 Self::Borrowed(b) => b,
Chris Wailes68c39f82021-07-27 16:03:44 -07001004 Self::Owned(o) => o,
Jooyung Han35edb8f2021-07-01 16:17:16 +09001005 }
1006 }
1007}
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001008
1009/// Implementation of `IVirtualMachineService`, the entry point of the AIDL service.
1010#[derive(Debug, Default)]
1011struct VirtualMachineService {
1012 state: Arc<Mutex<State>>,
Inseob Kimc7d28c72021-10-25 14:28:10 +00001013 cid: Cid,
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001014}
1015
1016impl Interface for VirtualMachineService {}
1017
1018impl IVirtualMachineService for VirtualMachineService {
Inseob Kimc7d28c72021-10-25 14:28:10 +00001019 fn notifyPayloadStarted(&self) -> binder::Result<()> {
1020 let cid = self.cid;
Inseob Kim7f61fe72021-08-20 20:50:47 +09001021 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01001022 info!("VM with CID {} started payload", cid);
Andrew Walbrandcf9d582022-08-03 11:25:24 +00001023 vm.update_payload_state(PayloadState::Started).map_err(|e| {
1024 Status::new_exception_str(ExceptionCode::ILLEGAL_STATE, Some(e.to_string()))
1025 })?;
David Brazdil451cc962022-10-14 14:08:12 +01001026 vm.callbacks.notify_payload_started(cid);
Seungjae Yoo62085c02022-08-12 04:44:52 +00001027
Seungjae Yoo6d265d92022-11-15 10:51:33 +09001028 let vm_start_timestamp = vm.vm_metric.lock().unwrap().start_timestamp;
1029 write_vm_booted_stats(vm.requester_uid as i32, &vm.name, vm_start_timestamp);
Inseob Kim7f61fe72021-08-20 20:50:47 +09001030 Ok(())
1031 } else {
Jooyung Handd0a1732021-11-23 15:26:20 +09001032 error!("notifyPayloadStarted is called from an unknown CID {}", cid);
Andrew Walbrandcf9d582022-08-03 11:25:24 +00001033 Err(Status::new_service_specific_error_str(
1034 -1,
1035 Some(format!("cannot find a VM with CID {}", cid)),
Inseob Kim7f61fe72021-08-20 20:50:47 +09001036 ))
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001037 }
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001038 }
Inseob Kim2444af92021-08-31 01:22:50 +09001039
Inseob Kimc7d28c72021-10-25 14:28:10 +00001040 fn notifyPayloadReady(&self) -> binder::Result<()> {
1041 let cid = self.cid;
Inseob Kim14cb8692021-08-31 21:50:39 +09001042 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01001043 info!("VM with CID {} reported payload is ready", cid);
Andrew Walbrandcf9d582022-08-03 11:25:24 +00001044 vm.update_payload_state(PayloadState::Ready).map_err(|e| {
1045 Status::new_exception_str(ExceptionCode::ILLEGAL_STATE, Some(e.to_string()))
1046 })?;
Inseob Kim14cb8692021-08-31 21:50:39 +09001047 vm.callbacks.notify_payload_ready(cid);
1048 Ok(())
1049 } else {
Jooyung Handd0a1732021-11-23 15:26:20 +09001050 error!("notifyPayloadReady is called from an unknown CID {}", cid);
Andrew Walbrandcf9d582022-08-03 11:25:24 +00001051 Err(Status::new_service_specific_error_str(
1052 -1,
1053 Some(format!("cannot find a VM with CID {}", cid)),
Inseob Kim14cb8692021-08-31 21:50:39 +09001054 ))
1055 }
1056 }
1057
Inseob Kimc7d28c72021-10-25 14:28:10 +00001058 fn notifyPayloadFinished(&self, exit_code: i32) -> binder::Result<()> {
1059 let cid = self.cid;
Inseob Kim2444af92021-08-31 01:22:50 +09001060 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01001061 info!("VM with CID {} finished payload", cid);
Andrew Walbrandcf9d582022-08-03 11:25:24 +00001062 vm.update_payload_state(PayloadState::Finished).map_err(|e| {
1063 Status::new_exception_str(ExceptionCode::ILLEGAL_STATE, Some(e.to_string()))
1064 })?;
Inseob Kim2444af92021-08-31 01:22:50 +09001065 vm.callbacks.notify_payload_finished(cid, exit_code);
1066 Ok(())
1067 } else {
Jooyung Handd0a1732021-11-23 15:26:20 +09001068 error!("notifyPayloadFinished is called from an unknown CID {}", cid);
Andrew Walbrandcf9d582022-08-03 11:25:24 +00001069 Err(Status::new_service_specific_error_str(
1070 -1,
1071 Some(format!("cannot find a VM with CID {}", cid)),
Jooyung Handd0a1732021-11-23 15:26:20 +09001072 ))
1073 }
1074 }
1075
Alan Stokes2bead0d2022-09-05 16:58:34 +01001076 fn notifyError(&self, error_code: ErrorCode, message: &str) -> binder::Result<()> {
Jooyung Handd0a1732021-11-23 15:26:20 +09001077 let cid = self.cid;
1078 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01001079 info!("VM with CID {} encountered an error", cid);
Andrew Walbrandcf9d582022-08-03 11:25:24 +00001080 vm.update_payload_state(PayloadState::Finished).map_err(|e| {
1081 Status::new_exception_str(ExceptionCode::ILLEGAL_STATE, Some(e.to_string()))
1082 })?;
Jooyung Handd0a1732021-11-23 15:26:20 +09001083 vm.callbacks.notify_error(cid, error_code, message);
1084 Ok(())
1085 } else {
Seungjae Yooec8c1602022-06-20 05:28:00 +00001086 error!("notifyError is called from an unknown CID {}", cid);
Andrew Walbrandcf9d582022-08-03 11:25:24 +00001087 Err(Status::new_service_specific_error_str(
1088 -1,
1089 Some(format!("cannot find a VM with CID {}", cid)),
Inseob Kim2444af92021-08-31 01:22:50 +09001090 ))
1091 }
1092 }
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001093}
1094
1095impl VirtualMachineService {
Inseob Kimc7d28c72021-10-25 14:28:10 +00001096 fn new_binder(state: Arc<Mutex<State>>, cid: Cid) -> Strong<dyn IVirtualMachineService> {
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001097 BnVirtualMachineService::new_binder(
Inseob Kimc7d28c72021-10-25 14:28:10 +00001098 VirtualMachineService { state, cid },
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001099 BinderFeatures::default(),
1100 )
1101 }
1102}
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001103
1104#[cfg(test)]
1105mod tests {
1106 use super::*;
1107
1108 #[test]
1109 fn test_is_allowed_label_for_partition() -> Result<()> {
1110 let expected_results = vec![
1111 ("u:object_r:system_file:s0", true),
1112 ("u:object_r:apk_data_file:s0", true),
1113 ("u:object_r:app_data_file:s0", false),
1114 ("u:object_r:app_data_file:s0:c512,c768", false),
1115 ("u:object_r:privapp_data_file:s0:c512,c768", false),
1116 ("invalid", false),
1117 ("user:role:apk_data_file:severity:categories", true),
1118 ("user:role:apk_data_file:severity:categories:extraneous", false),
1119 ];
1120
1121 for (label, expected_valid) in expected_results {
1122 let context = SeContext::new(label)?;
1123 let result = check_label_is_allowed(&context);
1124 if expected_valid {
1125 assert!(result.is_ok(), "Expected label {} to be allowed, got {:?}", label, result);
1126 } else if result.is_ok() {
1127 bail!("Expected label {} to be disallowed", label);
1128 }
1129 }
1130 Ok(())
1131 }
Nikita Ioffef1ce9872022-12-09 13:31:59 +00001132
1133 #[test]
1134 fn test_create_or_update_idsig_file_empty_apk() -> Result<()> {
1135 let apk = tempfile::tempfile().unwrap();
1136 let idsig = tempfile::tempfile().unwrap();
1137
1138 let ret = create_or_update_idsig_file(
1139 &ParcelFileDescriptor::new(apk),
1140 &ParcelFileDescriptor::new(idsig),
1141 );
1142 assert!(ret.is_err(), "should fail");
1143 Ok(())
1144 }
1145
1146 #[test]
1147 fn test_create_or_update_idsig_dir_instead_of_file_for_apk() -> Result<()> {
1148 let tmp_dir = tempfile::TempDir::new().unwrap();
1149 let apk = File::open(tmp_dir.path()).unwrap();
1150 let idsig = tempfile::tempfile().unwrap();
1151
1152 let ret = create_or_update_idsig_file(
1153 &ParcelFileDescriptor::new(apk),
1154 &ParcelFileDescriptor::new(idsig),
1155 );
1156 assert!(ret.is_err(), "should fail");
1157 Ok(())
1158 }
1159
1160 /// Verifies that create_or_update_idsig_file won't oom if a fd that corresponds to a directory
1161 /// on ext4 filesystem is passed.
1162 /// On ext4 lseek on a directory fd will return (off_t)-1 (see:
1163 /// https://bugzilla.kernel.org/show_bug.cgi?id=200043), which will result in
1164 /// create_or_update_idsig_file ooming while attempting to allocate petabytes of memory.
1165 #[test]
1166 fn test_create_or_update_idsig_does_not_crash_dir_on_ext4() -> Result<()> {
1167 // APEXes are backed by the ext4.
1168 let apk = File::open("/apex/com.android.virt/").unwrap();
1169 let idsig = tempfile::tempfile().unwrap();
1170
1171 let ret = create_or_update_idsig_file(
1172 &ParcelFileDescriptor::new(apk),
1173 &ParcelFileDescriptor::new(idsig),
1174 );
1175 assert!(ret.is_err(), "should fail");
1176 Ok(())
1177 }
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001178}