Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2021 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 17 | use anyhow::{anyhow, bail, Context, Result}; |
Victor Hsieh | 616f822 | 2022-01-14 13:06:32 -0800 | [diff] [blame] | 18 | use log::{debug, info, warn}; |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 19 | use minijail::{self, Minijail}; |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 20 | use regex::Regex; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 21 | use std::collections::HashMap; |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 22 | use std::env; |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 23 | use std::ffi::OsString; |
Victor Hsieh | 616f822 | 2022-01-14 13:06:32 -0800 | [diff] [blame] | 24 | use std::fs::read_dir; |
Alan Stokes | 35bac3c | 2021-12-16 14:37:24 +0000 | [diff] [blame] | 25 | use std::path::{self, Path, PathBuf}; |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 26 | use std::process::Command; |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 27 | |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 28 | use crate::artifact_signer::ArtifactSigner; |
Alan Stokes | 223a746 | 2022-01-20 14:12:24 +0000 | [diff] [blame] | 29 | use crate::signing_key::Signer; |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 30 | use authfs_aidl_interface::aidl::com::android::virt::fs::{ |
Victor Hsieh | 015bcb5 | 2021-11-17 17:28:01 -0800 | [diff] [blame] | 31 | AuthFsConfig::{ |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 32 | AuthFsConfig, InputDirFdAnnotation::InputDirFdAnnotation, |
Victor Hsieh | 616f822 | 2022-01-14 13:06:32 -0800 | [diff] [blame] | 33 | OutputDirFdAnnotation::OutputDirFdAnnotation, |
Victor Hsieh | 015bcb5 | 2021-11-17 17:28:01 -0800 | [diff] [blame] | 34 | }, |
Victor Hsieh | 015bcb5 | 2021-11-17 17:28:01 -0800 | [diff] [blame] | 35 | IAuthFsService::IAuthFsService, |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 36 | }; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 37 | use authfs_aidl_interface::binder::Strong; |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 38 | use compos_common::odrefresh::ExitCode; |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 39 | |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 40 | const FD_SERVER_PORT: i32 = 3264; // TODO: support dynamic port |
| 41 | |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 42 | pub struct OdrefreshContext<'a> { |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 43 | system_dir_fd: i32, |
| 44 | output_dir_fd: i32, |
Alan Stokes | 9646db9 | 2021-12-14 13:22:33 +0000 | [diff] [blame] | 45 | staging_dir_fd: i32, |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 46 | target_dir_name: &'a str, |
| 47 | zygote_arch: &'a str, |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 48 | system_server_compiler_filter: &'a str, |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 49 | } |
| 50 | |
| 51 | impl<'a> OdrefreshContext<'a> { |
| 52 | pub fn new( |
| 53 | system_dir_fd: i32, |
| 54 | output_dir_fd: i32, |
| 55 | staging_dir_fd: i32, |
| 56 | target_dir_name: &'a str, |
| 57 | zygote_arch: &'a str, |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 58 | system_server_compiler_filter: &'a str, |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 59 | ) -> Result<Self> { |
| 60 | if system_dir_fd < 0 || output_dir_fd < 0 || staging_dir_fd < 0 { |
| 61 | bail!("The remote FDs are expected to be non-negative"); |
| 62 | } |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 63 | if !matches!(zygote_arch, "zygote64" | "zygote64_32") { |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 64 | bail!("Invalid zygote arch"); |
| 65 | } |
Alan Stokes | 35bac3c | 2021-12-16 14:37:24 +0000 | [diff] [blame] | 66 | // Disallow any sort of path traversal |
| 67 | if target_dir_name.contains(path::MAIN_SEPARATOR) { |
| 68 | bail!("Invalid target directory {}", target_dir_name); |
| 69 | } |
| 70 | |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 71 | // We're not validating/allowlisting the compiler filter, and just assume the compiler will |
| 72 | // reject an invalid string. We need to accept "verify" filter anyway, and potential |
| 73 | // performance degration by the attacker is not currently in scope. This also allows ART to |
| 74 | // specify new compiler filter and configure through system property without change to |
| 75 | // CompOS. |
| 76 | |
| 77 | Ok(Self { |
| 78 | system_dir_fd, |
| 79 | output_dir_fd, |
| 80 | staging_dir_fd, |
| 81 | target_dir_name, |
| 82 | zygote_arch, |
| 83 | system_server_compiler_filter, |
| 84 | }) |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 85 | } |
| 86 | } |
| 87 | |
| 88 | pub fn odrefresh( |
| 89 | odrefresh_path: &Path, |
| 90 | context: OdrefreshContext, |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 91 | authfs_service: Strong<dyn IAuthFsService>, |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 92 | signer: Signer, |
| 93 | ) -> Result<ExitCode> { |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 94 | // Mount authfs (via authfs_service). The authfs instance unmounts once the `authfs` variable |
| 95 | // is out of scope. |
| 96 | let authfs_config = AuthFsConfig { |
| 97 | port: FD_SERVER_PORT, |
| 98 | inputDirFdAnnotations: vec![InputDirFdAnnotation { |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 99 | fd: context.system_dir_fd, |
Victor Hsieh | 9978257 | 2022-01-05 15:38:33 -0800 | [diff] [blame] | 100 | // 0 is the index of extra_apks in vm_config_extra_apk.json |
| 101 | manifestPath: "/mnt/extra-apk/0/assets/build_manifest.pb".to_string(), |
| 102 | prefix: "system/".to_string(), |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 103 | }], |
Alan Stokes | 9646db9 | 2021-12-14 13:22:33 +0000 | [diff] [blame] | 104 | outputDirFdAnnotations: vec![ |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 105 | OutputDirFdAnnotation { fd: context.output_dir_fd }, |
| 106 | OutputDirFdAnnotation { fd: context.staging_dir_fd }, |
Alan Stokes | 9646db9 | 2021-12-14 13:22:33 +0000 | [diff] [blame] | 107 | ], |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 108 | ..Default::default() |
| 109 | }; |
| 110 | let authfs = authfs_service.mount(&authfs_config)?; |
| 111 | let mountpoint = PathBuf::from(authfs.getMountPoint()?); |
| 112 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 113 | // Make a copy of our environment as the basis of the one we will give odrefresh |
| 114 | let mut odrefresh_vars = EnvMap::from_current_env(); |
| 115 | |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 116 | let mut android_root = mountpoint.clone(); |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 117 | android_root.push(context.system_dir_fd.to_string()); |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 118 | android_root.push("system"); |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 119 | odrefresh_vars.set("ANDROID_ROOT", path_to_str(&android_root)?); |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 120 | debug!("ANDROID_ROOT={:?}", &android_root); |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 121 | |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 122 | let art_apex_data = mountpoint.join(context.output_dir_fd.to_string()); |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 123 | odrefresh_vars.set("ART_APEX_DATA", path_to_str(&art_apex_data)?); |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 124 | debug!("ART_APEX_DATA={:?}", &art_apex_data); |
Victor Hsieh | 64df53d | 2021-11-30 17:09:51 -0800 | [diff] [blame] | 125 | |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 126 | let staging_dir = mountpoint.join(context.staging_dir_fd.to_string()); |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 127 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 128 | set_classpaths(&mut odrefresh_vars, &android_root)?; |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 129 | |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 130 | let mut args = vec![ |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 131 | "odrefresh".to_string(), |
Alan Stokes | 48c1d2b | 2022-01-10 15:54:04 +0000 | [diff] [blame] | 132 | "--compilation-os-mode".to_string(), |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 133 | format!("--zygote-arch={}", context.zygote_arch), |
| 134 | format!("--dalvik-cache={}", context.target_dir_name), |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 135 | format!("--staging-dir={}", staging_dir.display()), |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 136 | "--no-refresh".to_string(), |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 137 | ]; |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 138 | |
| 139 | if !context.system_server_compiler_filter.is_empty() { |
| 140 | args.push(format!( |
| 141 | "--system-server-compiler-filter={}", |
| 142 | context.system_server_compiler_filter |
| 143 | )); |
| 144 | } |
Alan Stokes | 48c1d2b | 2022-01-10 15:54:04 +0000 | [diff] [blame] | 145 | |
| 146 | args.push("--compile".to_string()); |
Victor Hsieh | 9bfbc5f | 2021-12-16 11:45:10 -0800 | [diff] [blame] | 147 | |
Alan Stokes | 9646db9 | 2021-12-14 13:22:33 +0000 | [diff] [blame] | 148 | debug!("Running odrefresh with args: {:?}", &args); |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 149 | let jail = spawn_jailed_task(odrefresh_path, &args, &odrefresh_vars.into_env()) |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 150 | .context("Spawn odrefresh")?; |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 151 | let exit_code = match jail.wait() { |
| 152 | Ok(_) => Result::<u8>::Ok(0), |
| 153 | Err(minijail::Error::ReturnCode(exit_code)) => Ok(exit_code), |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 154 | Err(e) => { |
| 155 | bail!("Unexpected minijail error: {}", e) |
| 156 | } |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 157 | }?; |
| 158 | |
Alan Stokes | 126fd51 | 2021-12-16 15:00:01 +0000 | [diff] [blame] | 159 | let exit_code = ExitCode::from_i32(exit_code.into())?; |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 160 | info!("odrefresh exited with {:?}", exit_code); |
| 161 | |
| 162 | if exit_code == ExitCode::CompilationSuccess { |
| 163 | // authfs only shows us the files we created, so it's ok to just sign everything under |
| 164 | // the target directory. |
| 165 | let target_dir = art_apex_data.join(context.target_dir_name); |
| 166 | let mut artifact_signer = ArtifactSigner::new(&target_dir); |
| 167 | add_artifacts(&target_dir, &mut artifact_signer)?; |
| 168 | |
| 169 | artifact_signer.write_info_and_signature(signer, &target_dir.join("compos.info"))?; |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 170 | } |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 171 | |
| 172 | Ok(exit_code) |
| 173 | } |
| 174 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 175 | fn path_to_str(path: &Path) -> Result<&str> { |
| 176 | path.to_str().ok_or_else(|| anyhow!("Bad path {:?}", path)) |
| 177 | } |
| 178 | |
| 179 | fn set_classpaths(odrefresh_vars: &mut EnvMap, android_root: &Path) -> Result<()> { |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 180 | let export_lines = run_derive_classpath(android_root)?; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 181 | load_classpath_vars(odrefresh_vars, &export_lines) |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 182 | } |
| 183 | |
| 184 | fn run_derive_classpath(android_root: &Path) -> Result<String> { |
| 185 | let classpaths_root = android_root.join("etc/classpaths"); |
| 186 | |
| 187 | let mut bootclasspath_arg = OsString::new(); |
| 188 | bootclasspath_arg.push("--bootclasspath-fragment="); |
| 189 | bootclasspath_arg.push(classpaths_root.join("bootclasspath.pb")); |
| 190 | |
| 191 | let mut systemserverclasspath_arg = OsString::new(); |
| 192 | systemserverclasspath_arg.push("--systemserverclasspath-fragment="); |
| 193 | systemserverclasspath_arg.push(classpaths_root.join("systemserverclasspath.pb")); |
| 194 | |
| 195 | let result = Command::new("/apex/com.android.sdkext/bin/derive_classpath") |
| 196 | .arg(bootclasspath_arg) |
| 197 | .arg(systemserverclasspath_arg) |
| 198 | .arg("/proc/self/fd/1") |
| 199 | .output() |
| 200 | .context("Failed to run derive_classpath")?; |
| 201 | |
| 202 | if !result.status.success() { |
| 203 | bail!("derive_classpath returned {}", result.status); |
| 204 | } |
| 205 | |
| 206 | String::from_utf8(result.stdout).context("Converting derive_classpath output") |
| 207 | } |
| 208 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 209 | fn load_classpath_vars(odrefresh_vars: &mut EnvMap, export_lines: &str) -> Result<()> { |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 210 | // Each line should be in the format "export <var name> <value>" |
| 211 | let pattern = Regex::new(r"^export ([^ ]+) ([^ ]+)$").context("Failed to construct Regex")?; |
| 212 | for line in export_lines.lines() { |
| 213 | if let Some(captures) = pattern.captures(line) { |
| 214 | let name = &captures[1]; |
| 215 | let value = &captures[2]; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 216 | odrefresh_vars.set(name, value); |
Alan Stokes | 9247251 | 2022-01-04 11:48:38 +0000 | [diff] [blame] | 217 | } else { |
| 218 | warn!("Malformed line from derive_classpath: {}", line); |
| 219 | } |
| 220 | } |
| 221 | |
| 222 | Ok(()) |
| 223 | } |
| 224 | |
Alan Stokes | 46a1dff | 2021-12-14 10:56:05 +0000 | [diff] [blame] | 225 | fn add_artifacts(target_dir: &Path, artifact_signer: &mut ArtifactSigner) -> Result<()> { |
| 226 | for entry in |
| 227 | read_dir(&target_dir).with_context(|| format!("Traversing {}", target_dir.display()))? |
| 228 | { |
| 229 | let entry = entry?; |
| 230 | let file_type = entry.file_type()?; |
| 231 | if file_type.is_dir() { |
| 232 | add_artifacts(&entry.path(), artifact_signer)?; |
| 233 | } else if file_type.is_file() { |
| 234 | artifact_signer.add_artifact(&entry.path())?; |
| 235 | } else { |
| 236 | // authfs shouldn't create anything else, but just in case |
| 237 | bail!("Unexpected file type in artifacts: {:?}", entry); |
| 238 | } |
| 239 | } |
| 240 | Ok(()) |
Victor Hsieh | f996869 | 2021-11-18 11:34:39 -0800 | [diff] [blame] | 241 | } |
| 242 | |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 243 | fn spawn_jailed_task(executable: &Path, args: &[String], env_vars: &[String]) -> Result<Minijail> { |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 244 | // TODO(b/185175567): Run in a more restricted sandbox. |
| 245 | let jail = Minijail::new()?; |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 246 | let keep_fds = []; |
| 247 | let command = minijail::Command::new_for_path(executable, &keep_fds, args, Some(env_vars))?; |
| 248 | let _pid = jail.run_command(command)?; |
Victor Hsieh | 51789de | 2021-08-06 16:50:49 -0700 | [diff] [blame] | 249 | Ok(jail) |
| 250 | } |
Alan Stokes | fadcef2 | 2022-01-24 17:00:59 +0000 | [diff] [blame] | 251 | |
| 252 | struct EnvMap(HashMap<String, String>); |
| 253 | |
| 254 | impl EnvMap { |
| 255 | fn from_current_env() -> Self { |
| 256 | Self(env::vars().collect()) |
| 257 | } |
| 258 | |
| 259 | fn set(&mut self, key: &str, value: &str) { |
| 260 | self.0.insert(key.to_owned(), value.to_owned()); |
| 261 | } |
| 262 | |
| 263 | fn into_env(self) -> Vec<String> { |
| 264 | // execve() expects an array of "k=v" strings, rather than a list of (k, v) pairs. |
| 265 | self.0.into_iter().map(|(k, v)| k + "=" + &v).collect() |
| 266 | } |
| 267 | } |