Jooyung Han | 12a0b70 | 2021-08-05 23:20:31 +0900 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2021 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Alice Wang | 3c01662 | 2022-09-19 09:08:27 +0000 | [diff] [blame^] | 17 | use apkverify::{get_public_key_der, testing::assert_contains, verify}; |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 18 | use std::{fs, matches, path::Path}; |
Jooyung Han | d839785 | 2021-08-10 16:29:36 +0900 | [diff] [blame] | 19 | |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 20 | const KEY_NAMES_DSA: &[&str] = &["1024", "2048", "3072"]; |
| 21 | const KEY_NAMES_ECDSA: &[&str] = &["p256", "p384", "p521"]; |
| 22 | const KEY_NAMES_RSA: &[&str] = &["1024", "2048", "3072", "4096", "8192", "16384"]; |
Jooyung Han | cee6de6 | 2021-08-11 15:52:07 +0900 | [diff] [blame] | 23 | |
| 24 | #[test] |
| 25 | fn test_verify_truncated_cd() { |
| 26 | use zip::result::ZipError; |
| 27 | let res = verify("tests/data/v2-only-truncated-cd.apk"); |
Alice Wang | 9288935 | 2022-09-16 10:42:52 +0000 | [diff] [blame] | 28 | // TODO(b/190343842): consider making a helper for err assertion |
Jooyung Han | cee6de6 | 2021-08-11 15:52:07 +0900 | [diff] [blame] | 29 | assert!(matches!( |
Andrew Walbran | 117cd5e | 2021-08-13 11:42:13 +0000 | [diff] [blame] | 30 | res.unwrap_err().root_cause().downcast_ref::<ZipError>().unwrap(), |
Jooyung Han | cee6de6 | 2021-08-11 15:52:07 +0900 | [diff] [blame] | 31 | ZipError::InvalidArchive(_), |
| 32 | )); |
| 33 | } |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 34 | |
| 35 | #[test] |
| 36 | fn test_verify_v3() { |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 37 | validate_apk_public_key("tests/data/test.apex"); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 38 | } |
| 39 | |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 40 | #[test] |
| 41 | fn test_verify_v3_dsa_sha256() { |
| 42 | for key_name in KEY_NAMES_DSA.iter() { |
| 43 | let res = verify(format!("tests/data/v3-only-with-dsa-sha256-{}.apk", key_name)); |
| 44 | assert!(res.is_err()); |
Alice Wang | a66b5c0 | 2022-09-16 07:25:17 +0000 | [diff] [blame] | 45 | assert_contains(&res.unwrap_err().to_string(), "not implemented"); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 46 | } |
| 47 | } |
| 48 | |
| 49 | #[test] |
| 50 | fn test_verify_v3_ecdsa_sha256() { |
| 51 | for key_name in KEY_NAMES_ECDSA.iter() { |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 52 | validate_apk_public_key(format!("tests/data/v3-only-with-ecdsa-sha256-{}.apk", key_name)); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 53 | } |
| 54 | } |
| 55 | |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 56 | #[test] |
| 57 | fn test_verify_v3_ecdsa_sha512() { |
| 58 | for key_name in KEY_NAMES_ECDSA.iter() { |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 59 | validate_apk_public_key(format!("tests/data/v3-only-with-ecdsa-sha512-{}.apk", key_name)); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 60 | } |
| 61 | } |
| 62 | |
| 63 | #[test] |
| 64 | fn test_verify_v3_rsa_sha256() { |
| 65 | for key_name in KEY_NAMES_RSA.iter() { |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 66 | validate_apk_public_key(format!( |
| 67 | "tests/data/v3-only-with-rsa-pkcs1-sha256-{}.apk", |
| 68 | key_name |
| 69 | )); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 70 | } |
| 71 | } |
| 72 | |
| 73 | #[test] |
| 74 | fn test_verify_v3_rsa_sha512() { |
| 75 | for key_name in KEY_NAMES_RSA.iter() { |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 76 | validate_apk_public_key(format!( |
| 77 | "tests/data/v3-only-with-rsa-pkcs1-sha512-{}.apk", |
| 78 | key_name |
| 79 | )); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 80 | } |
| 81 | } |
| 82 | |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 83 | #[test] |
| 84 | fn test_verify_v3_sig_does_not_verify() { |
| 85 | let path_list = [ |
| 86 | "tests/data/v3-only-with-dsa-sha256-2048-sig-does-not-verify.apk", |
| 87 | "tests/data/v3-only-with-ecdsa-sha512-p521-sig-does-not-verify.apk", |
| 88 | "tests/data/v3-only-with-rsa-pkcs1-sha256-3072-sig-does-not-verify.apk", |
| 89 | ]; |
| 90 | for path in path_list.iter() { |
| 91 | let res = verify(path); |
| 92 | assert!(res.is_err()); |
| 93 | let error_msg = &res.unwrap_err().to_string(); |
| 94 | assert!( |
Alice Wang | a66b5c0 | 2022-09-16 07:25:17 +0000 | [diff] [blame] | 95 | error_msg.contains("Signature is invalid") || error_msg.contains("not implemented") |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 96 | ); |
| 97 | } |
| 98 | } |
| 99 | |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 100 | #[test] |
| 101 | fn test_verify_v3_digest_mismatch() { |
| 102 | let path_list = [ |
| 103 | "tests/data/v3-only-with-dsa-sha256-3072-digest-mismatch.apk", |
| 104 | "tests/data/v3-only-with-rsa-pkcs1-sha512-8192-digest-mismatch.apk", |
| 105 | ]; |
| 106 | for path in path_list.iter() { |
| 107 | let res = verify(path); |
| 108 | assert!(res.is_err()); |
| 109 | let error_msg = &res.unwrap_err().to_string(); |
Alice Wang | a66b5c0 | 2022-09-16 07:25:17 +0000 | [diff] [blame] | 110 | assert!(error_msg.contains("Digest mismatch") || error_msg.contains("not implemented")); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 111 | } |
| 112 | } |
| 113 | |
| 114 | #[test] |
| 115 | fn test_verify_v3_wrong_apk_sig_block_magic() { |
| 116 | let res = verify("tests/data/v3-only-with-ecdsa-sha512-p384-wrong-apk-sig-block-magic.apk"); |
| 117 | assert!(res.is_err()); |
| 118 | assert_contains(&res.unwrap_err().to_string(), "No APK Signing Block"); |
| 119 | } |
| 120 | |
| 121 | #[test] |
| 122 | fn test_verify_v3_apk_sig_block_size_mismatch() { |
| 123 | let res = |
| 124 | verify("tests/data/v3-only-with-rsa-pkcs1-sha512-4096-apk-sig-block-size-mismatch.apk"); |
| 125 | assert!(res.is_err()); |
| 126 | assert_contains( |
| 127 | &res.unwrap_err().to_string(), |
| 128 | "APK Signing Block sizes in header and footer do not match", |
| 129 | ); |
| 130 | } |
| 131 | |
| 132 | #[test] |
| 133 | fn test_verify_v3_cert_and_public_key_mismatch() { |
| 134 | let res = verify("tests/data/v3-only-cert-and-public-key-mismatch.apk"); |
| 135 | assert!(res.is_err()); |
| 136 | assert_contains(&res.unwrap_err().to_string(), "Public key mismatch"); |
| 137 | } |
| 138 | |
| 139 | #[test] |
| 140 | fn test_verify_v3_empty() { |
| 141 | let res = verify("tests/data/v3-only-empty.apk"); |
| 142 | assert!(res.is_err()); |
| 143 | assert_contains(&res.unwrap_err().to_string(), "APK too small for APK Signing Block"); |
| 144 | } |
| 145 | |
| 146 | #[test] |
| 147 | fn test_verify_v3_no_certs_in_sig() { |
| 148 | let res = verify("tests/data/v3-only-no-certs-in-sig.apk"); |
| 149 | assert!(res.is_err()); |
| 150 | assert_contains(&res.unwrap_err().to_string(), "No certificates listed"); |
| 151 | } |
| 152 | |
| 153 | #[test] |
| 154 | fn test_verify_v3_no_supported_sig_algs() { |
| 155 | let res = verify("tests/data/v3-only-no-supported-sig-algs.apk"); |
| 156 | assert!(res.is_err()); |
| 157 | assert_contains(&res.unwrap_err().to_string(), "No supported signatures found"); |
| 158 | } |
| 159 | |
| 160 | #[test] |
| 161 | fn test_verify_v3_signatures_and_digests_block_mismatch() { |
| 162 | let res = verify("tests/data/v3-only-signatures-and-digests-block-mismatch.apk"); |
| 163 | assert!(res.is_err()); |
| 164 | assert_contains( |
| 165 | &res.unwrap_err().to_string(), |
| 166 | "Signature algorithms don't match between digests and signatures records", |
| 167 | ); |
| 168 | } |
| 169 | |
| 170 | #[test] |
| 171 | fn test_verify_v3_unknown_additional_attr() { |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 172 | validate_apk_public_key("tests/data/v3-only-unknown-additional-attr.apk"); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 173 | } |
| 174 | |
| 175 | #[test] |
| 176 | fn test_verify_v3_unknown_pair_in_apk_sig_block() { |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 177 | validate_apk_public_key("tests/data/v3-only-unknown-pair-in-apk-sig-block.apk"); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 178 | } |
| 179 | |
| 180 | #[test] |
| 181 | fn test_verify_v3_ignorable_unsupported_sig_algs() { |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 182 | validate_apk_public_key("tests/data/v3-only-with-ignorable-unsupported-sig-algs.apk"); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 183 | } |
| 184 | |
| 185 | #[test] |
| 186 | fn test_verify_v3_stamp() { |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 187 | validate_apk_public_key("tests/data/v3-only-with-stamp.apk"); |
| 188 | } |
| 189 | |
| 190 | fn validate_apk_public_key<P: AsRef<Path>>(apk_path: P) { |
| 191 | // Validates public key from verification == expected public key. |
| 192 | let public_key_from_verification = verify(apk_path.as_ref()); |
| 193 | let public_key_from_verification = |
| 194 | public_key_from_verification.expect("Error in verification result"); |
| 195 | |
| 196 | let expected_public_key_path = format!("{}.der", apk_path.as_ref().to_str().unwrap()); |
| 197 | assert!( |
| 198 | fs::metadata(&expected_public_key_path).is_ok(), |
| 199 | "File does not exist. You can re-create it with:\n$ echo -en {} > {}\n", |
| 200 | public_key_from_verification.iter().map(|b| format!("\\\\x{:02x}", b)).collect::<String>(), |
| 201 | expected_public_key_path |
| 202 | ); |
| 203 | let expected_public_key = fs::read(&expected_public_key_path).unwrap(); |
| 204 | assert_eq!( |
| 205 | expected_public_key, |
| 206 | public_key_from_verification.as_ref(), |
| 207 | "{}", |
| 208 | expected_public_key_path |
| 209 | ); |
| 210 | |
Alice Wang | 3c01662 | 2022-09-19 09:08:27 +0000 | [diff] [blame^] | 211 | // Validates public key extracted directly from apk |
Alice Wang | 67d3c00 | 2022-09-16 10:08:25 +0000 | [diff] [blame] | 212 | // (without verification) == expected public key. |
Alice Wang | 3c01662 | 2022-09-19 09:08:27 +0000 | [diff] [blame^] | 213 | let public_key_from_apk = get_public_key_der(apk_path.as_ref()); |
| 214 | let public_key_from_apk = |
| 215 | public_key_from_apk.expect("Error when extracting public key from apk"); |
| 216 | assert_eq!(expected_public_key, public_key_from_apk.as_ref(), "{}", expected_public_key_path); |
Seungjae Yoo | 91e250a | 2022-06-07 02:21:56 +0000 | [diff] [blame] | 217 | } |