blob: 6ae3bbd67f22255572a1531164a350f180eb5648 [file] [log] [blame]
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001// Copyright 2021, The Android Open Source Project
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
Andrew Walbranf6bf6862021-05-21 12:41:13 +000015//! Implementation of the AIDL interface of the VirtualizationService.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +000016
David Brazdil1f530702022-10-03 12:18:10 +010017use crate::{get_calling_pid, get_calling_uid};
David Brazdil49f96f52022-12-16 21:29:13 +000018use crate::atom::{
David Brazdil49f96f52022-12-16 21:29:13 +000019 write_vm_booted_stats, write_vm_creation_stats};
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +000020use crate::composite::make_composite_image;
Inseob Kim7307a892023-09-14 13:37:58 +090021use crate::crosvm::{CrosvmConfig, DiskFile, PayloadState, VfioDevice, VmContext, VmInstance, VmState};
Jaewan Kim61f86142023-03-28 15:12:52 +090022use crate::debug_config::DebugConfig;
Nikita Ioffe5dfddf22023-06-29 16:11:26 +010023use crate::payload::{add_microdroid_payload_images, add_microdroid_system_images, add_microdroid_vendor_image};
Seungjae Yoofd9a0622022-10-14 10:01:29 +090024use crate::selinux::{getfilecon, SeContext};
Jiyong Park753553b2021-07-12 21:21:09 +090025use android_os_permissions_aidl::aidl::android::os::IPermissionController;
David Brazdil49f96f52022-12-16 21:29:13 +000026use android_system_virtualizationcommon::aidl::android::system::virtualizationcommon::{
Alice Wang4e3015d2023-10-10 09:35:37 +000027 Certificate::Certificate,
Andrew Walbranc92d35f2022-01-12 12:45:19 +000028 DeathReason::DeathReason,
David Brazdil49f96f52022-12-16 21:29:13 +000029 ErrorCode::ErrorCode,
30};
31use android_system_virtualizationservice::aidl::android::system::virtualizationservice::{
Inseob Kim53d0b212023-07-20 16:58:37 +090032 AssignableDevice::AssignableDevice,
David Brazdil7d1e5ec2023-02-06 17:56:29 +000033 CpuTopology::CpuTopology,
Andrew Walbran6b650662021-09-07 13:13:23 +000034 DiskImage::DiskImage,
Alan Stokes0cc59ee2021-09-24 11:20:34 +010035 IVirtualMachine::{BnVirtualMachine, IVirtualMachine},
Andrew Walbran6b650662021-09-07 13:13:23 +000036 IVirtualMachineCallback::IVirtualMachineCallback,
37 IVirtualizationService::IVirtualizationService,
Alan Stokes27f3ef02023-09-29 15:09:35 +010038 IVirtualizationService::FEATURE_MULTI_TENANT,
Nikita Ioffe631717e2023-09-05 13:38:07 +010039 IVirtualizationService::FEATURE_VENDOR_MODULES,
Alan Stokes7f27c0d2023-09-07 16:22:58 +010040 IVirtualizationService::FEATURE_DICE_CHANGES,
Keir Frasercdd4b112022-11-24 14:02:25 +000041 MemoryTrimLevel::MemoryTrimLevel,
Jiyong Park029977d2021-11-24 21:56:49 +090042 Partition::Partition,
Andrew Walbran6b650662021-09-07 13:13:23 +000043 PartitionType::PartitionType,
Inseob Kim0168b462022-12-27 14:54:35 +090044 VirtualMachineAppConfig::{DebugLevel::DebugLevel, Payload::Payload, VirtualMachineAppConfig},
Jooyung Han21e9b922021-06-26 04:14:16 +090045 VirtualMachineConfig::VirtualMachineConfig,
Andrew Walbran6b650662021-09-07 13:13:23 +000046 VirtualMachineDebugInfo::VirtualMachineDebugInfo,
Alan Stokes0d1ef782022-09-27 13:46:35 +010047 VirtualMachinePayloadConfig::VirtualMachinePayloadConfig,
Jooyung Han21e9b922021-06-26 04:14:16 +090048 VirtualMachineRawConfig::VirtualMachineRawConfig,
Andrew Walbran6b650662021-09-07 13:13:23 +000049 VirtualMachineState::VirtualMachineState,
Jooyung Han21e9b922021-06-26 04:14:16 +090050};
David Brazdilafc9a9e2023-01-12 16:08:10 +000051use android_system_virtualizationservice_internal::aidl::android::system::virtualizationservice_internal::IVirtualizationServiceInternal::IVirtualizationServiceInternal;
Seungjae Yoodd91f0f2022-11-09 15:25:21 +090052use android_system_virtualmachineservice::aidl::android::system::virtualmachineservice::IVirtualMachineService::{
David Brazdilafc9a9e2023-01-12 16:08:10 +000053 BnVirtualMachineService, IVirtualMachineService,
Seungjae Yoofd9a0622022-10-14 10:01:29 +090054};
Alan Stokes25f69362023-03-06 16:51:54 +000055use anyhow::{anyhow, bail, Context, Result};
Seungjae Yoofd9a0622022-10-14 10:01:29 +090056use apkverify::{HashAlgorithm, V4Signature};
Jiyong Parkd7bd2f22023-08-10 20:41:19 +090057use avflog::LogResult;
Alan Stokes0e82b502022-08-08 14:44:48 +010058use binder::{
David Brazdilafc9a9e2023-01-12 16:08:10 +000059 self, wait_for_interface, BinderFeatures, ExceptionCode, Interface, ParcelFileDescriptor,
60 Status, StatusCode, Strong,
Jiyong Park2227eaa2023-08-04 11:59:18 +090061 IntoBinderResult,
Andrew Walbrana89fc132021-03-17 17:08:36 +000062};
David Brazdilf50c7a62023-04-19 14:22:42 +000063use disk::QcowFile;
David Brazdil49f96f52022-12-16 21:29:13 +000064use lazy_static::lazy_static;
Seungjae Yooec3bc522023-11-09 10:14:30 +090065use libfdt::Fdt;
Seungjae Yoo0a8c84c2022-07-11 08:19:15 +000066use log::{debug, error, info, warn};
Seungjae Yoofd9a0622022-10-14 10:01:29 +090067use microdroid_payload_config::{OsConfig, Task, TaskType, VmPayloadConfig};
Inseob Kim0168b462022-12-27 14:54:35 +090068use nix::unistd::pipe;
David Brazdil73988ea2022-11-11 15:10:32 +000069use rpcbinder::RpcServer;
Alan Stokes25f69362023-03-06 16:51:54 +000070use rustutils::system_properties;
Jiyong Parkdcf17412022-02-08 15:07:23 +090071use semver::VersionReq;
Inseob Kim6ef80972023-07-20 17:23:36 +090072use std::collections::HashSet;
Andrew Walbrandff3b942021-06-09 15:20:36 +000073use std::convert::TryInto;
Seungjae Yooec3bc522023-11-09 10:14:30 +090074use std::ffi::{CStr, CString};
Inseob Kim6ef80972023-07-20 17:23:36 +090075use std::fs::{canonicalize, read_dir, remove_file, File, OpenOptions};
David Brazdilf50c7a62023-04-19 14:22:42 +000076use std::io::{BufRead, BufReader, Error, ErrorKind, Write};
Nikita Ioffe5776f082023-02-10 21:38:26 +000077use std::num::{NonZeroU16, NonZeroU32};
Andrew Walbrand3a84182021-09-07 14:48:52 +000078use std::os::unix::io::{FromRawFd, IntoRawFd};
David Brazdilafc9a9e2023-01-12 16:08:10 +000079use std::os::unix::raw::pid_t;
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +000080use std::path::{Path, PathBuf};
Andrew Walbran320b5602021-03-04 16:11:12 +000081use std::sync::{Arc, Mutex, Weak};
Seungjae Yooec3bc522023-11-09 10:14:30 +090082use vbmeta::VbMetaImage;
Andrew Walbrancc0db522021-07-12 17:03:42 +000083use vmconfig::VmConfig;
David Brazdilafc9a9e2023-01-12 16:08:10 +000084use vsock::VsockStream;
Jooyung Han35edb8f2021-07-01 16:17:16 +090085use zip::ZipArchive;
Andrew Walbrand6dce6f2021-03-05 16:39:08 +000086
David Brazdil41d1a872022-10-05 14:44:19 +010087/// The unique ID of a VM used (together with a port number) for vsock communication.
88pub type Cid = u32;
89
David Brazdil4b4c5102022-12-19 22:56:20 +000090pub const BINDER_SERVICE_IDENTIFIER: &str = "android.system.virtualizationservice";
91
Jooyung Han95884632021-07-06 22:27:54 +090092/// The size of zero.img.
93/// Gaps in composite disk images are filled with a shared zero.img.
94const ZERO_FILLER_SIZE: u64 = 4096;
95
David Brazdilf50c7a62023-04-19 14:22:42 +000096/// Magic string for the instance image
97const ANDROID_VM_INSTANCE_MAGIC: &str = "Android-VM-instance";
98
99/// Version of the instance image format
100const ANDROID_VM_INSTANCE_VERSION: u16 = 1;
101
Alan Stokes0d1ef782022-09-27 13:46:35 +0100102const MICRODROID_OS_NAME: &str = "microdroid";
103
Inseob Kim172f9eb2023-11-06 17:02:08 +0900104const MICRODROID_GKI_OS_NAME: &str = "microdroid_gki";
105
David Brazdilf50c7a62023-04-19 14:22:42 +0000106const UNFORMATTED_STORAGE_MAGIC: &str = "UNFORMATTED-STORAGE";
107
Seungjae Yooec3bc522023-11-09 10:14:30 +0900108/// Roughly estimated sufficient size for storing vendor public key into DTBO.
109const EMPTY_VENDOR_DT_OVERLAY_BUF_SIZE: usize = 10000;
110
David Brazdilf50c7a62023-04-19 14:22:42 +0000111/// crosvm requires all partitions to be a multiple of 4KiB.
112const PARTITION_GRANULARITY_BYTES: u64 = 4096;
113
David Brazdil49f96f52022-12-16 21:29:13 +0000114lazy_static! {
David Brazdil4b4c5102022-12-19 22:56:20 +0000115 pub static ref GLOBAL_SERVICE: Strong<dyn IVirtualizationServiceInternal> =
116 wait_for_interface(BINDER_SERVICE_IDENTIFIER)
117 .expect("Could not connect to VirtualizationServiceInternal");
David Brazdil49f96f52022-12-16 21:29:13 +0000118}
119
Nikita Ioffef1ce9872022-12-09 13:31:59 +0000120fn create_or_update_idsig_file(
121 input_fd: &ParcelFileDescriptor,
122 idsig_fd: &ParcelFileDescriptor,
123) -> Result<()> {
124 let mut input = clone_file(input_fd)?;
125 let metadata = input.metadata().context("failed to get input metadata")?;
126 if !metadata.is_file() {
127 bail!("input is not a regular file");
128 }
Alan Stokes25f69362023-03-06 16:51:54 +0000129 let mut sig =
130 V4Signature::create(&mut input, get_current_sdk()?, 4096, &[], HashAlgorithm::SHA256)
131 .context("failed to create idsig")?;
Nikita Ioffef1ce9872022-12-09 13:31:59 +0000132
133 let mut output = clone_file(idsig_fd)?;
Jiyong Park8d192952023-06-26 14:29:51 +0900134
135 // Optimization. We don't have to update idsig file whenever a VM is started. Don't update it,
136 // if the idsig file already has the same APK digest.
137 if output.metadata()?.len() > 0 {
138 if let Ok(out_sig) = V4Signature::from_idsig(&mut output) {
139 if out_sig.signing_info.apk_digest == sig.signing_info.apk_digest {
140 debug!("idsig {:?} is up-to-date with apk {:?}.", output, input);
141 return Ok(());
142 }
143 }
144 // if we fail to read v4signature from output, that's fine. User can pass a random file.
145 // We will anyway overwrite the file to the v4signature generated from input_fd.
146 }
147
Nikita Ioffec09b0492022-12-14 20:18:33 +0000148 output.set_len(0).context("failed to set_len on the idsig output")?;
149 sig.write_into(&mut output).context("failed to write idsig")?;
Nikita Ioffef1ce9872022-12-09 13:31:59 +0000150 Ok(())
151}
152
Alan Stokes25f69362023-03-06 16:51:54 +0000153fn get_current_sdk() -> Result<u32> {
154 let current_sdk = system_properties::read("ro.build.version.sdk")?;
155 let current_sdk = current_sdk.ok_or_else(|| anyhow!("SDK version missing"))?;
156 current_sdk.parse().context("Malformed SDK version")
157}
158
David Brazdil4b4c5102022-12-19 22:56:20 +0000159pub fn remove_temporary_files(path: &PathBuf) -> Result<()> {
160 for dir_entry in read_dir(path)? {
161 remove_file(dir_entry?.path())?;
162 }
163 Ok(())
David Brazdil528e0472022-10-10 15:06:02 +0100164}
165
David Brazdil528e0472022-10-10 15:06:02 +0100166/// Implementation of `IVirtualizationService`, the entry point of the AIDL service.
David Brazdil49f96f52022-12-16 21:29:13 +0000167#[derive(Debug, Default)]
Andrew Walbranf6bf6862021-05-21 12:41:13 +0000168pub struct VirtualizationService {
Jiyong Park8611a6c2021-07-09 18:17:44 +0900169 state: Arc<Mutex<State>>,
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000170}
171
Shikha Panward8e35422021-10-11 13:51:27 +0000172impl Interface for VirtualizationService {
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000173 fn dump(&self, writer: &mut dyn Write, _args: &[&CStr]) -> Result<(), StatusCode> {
Shikha Panward8e35422021-10-11 13:51:27 +0000174 check_permission("android.permission.DUMP").or(Err(StatusCode::PERMISSION_DENIED))?;
175 let state = &mut *self.state.lock().unwrap();
176 let vms = state.vms();
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000177 writeln!(writer, "Running {0} VMs:", vms.len()).or(Err(StatusCode::UNKNOWN_ERROR))?;
Shikha Panward8e35422021-10-11 13:51:27 +0000178 for vm in vms {
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000179 writeln!(writer, "VM CID: {}", vm.cid).or(Err(StatusCode::UNKNOWN_ERROR))?;
180 writeln!(writer, "\tState: {:?}", vm.vm_state.lock().unwrap())
Shikha Panward8e35422021-10-11 13:51:27 +0000181 .or(Err(StatusCode::UNKNOWN_ERROR))?;
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000182 writeln!(writer, "\tPayload state {:?}", vm.payload_state())
Shikha Panward8e35422021-10-11 13:51:27 +0000183 .or(Err(StatusCode::UNKNOWN_ERROR))?;
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000184 writeln!(writer, "\tProtected: {}", vm.protected).or(Err(StatusCode::UNKNOWN_ERROR))?;
185 writeln!(writer, "\ttemporary_directory: {}", vm.temporary_directory.to_string_lossy())
Shikha Panward8e35422021-10-11 13:51:27 +0000186 .or(Err(StatusCode::UNKNOWN_ERROR))?;
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000187 writeln!(writer, "\trequester_uid: {}", vm.requester_uid)
Shikha Panward8e35422021-10-11 13:51:27 +0000188 .or(Err(StatusCode::UNKNOWN_ERROR))?;
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000189 writeln!(writer, "\trequester_debug_pid: {}", vm.requester_debug_pid)
Shikha Panward8e35422021-10-11 13:51:27 +0000190 .or(Err(StatusCode::UNKNOWN_ERROR))?;
191 }
192 Ok(())
193 }
194}
Andrew Walbranf6bf6862021-05-21 12:41:13 +0000195impl IVirtualizationService for VirtualizationService {
Andrew Walbranf8d94112021-09-07 11:45:36 +0000196 /// Creates (but does not start) a new VM with the given configuration, assigning it the next
197 /// available CID.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000198 ///
199 /// Returns a binder `IVirtualMachine` object referring to it, as a handle for the client.
Andrew Walbranf8d94112021-09-07 11:45:36 +0000200 fn createVm(
Andrew Walbrana89fc132021-03-17 17:08:36 +0000201 &self,
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000202 config: &VirtualMachineConfig,
Jiyong Parke6fb1672023-06-26 16:45:55 +0900203 console_out_fd: Option<&ParcelFileDescriptor>,
204 console_in_fd: Option<&ParcelFileDescriptor>,
Andrew Walbrana89fc132021-03-17 17:08:36 +0000205 log_fd: Option<&ParcelFileDescriptor>,
206 ) -> binder::Result<Strong<dyn IVirtualMachine>> {
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000207 let mut is_protected = false;
Jiyong Parke6fb1672023-06-26 16:45:55 +0900208 let ret = self.create_vm_internal(
209 config,
210 console_out_fd,
211 console_in_fd,
212 log_fd,
213 &mut is_protected,
214 );
Seungjae Yoo0a8c84c2022-07-11 08:19:15 +0000215 write_vm_creation_stats(config, is_protected, &ret);
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000216 ret
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000217 }
Andrew Walbran320b5602021-03-04 16:11:12 +0000218
Andrew Walbrandff3b942021-06-09 15:20:36 +0000219 /// Initialise an empty partition image of the given size to be used as a writable partition.
220 fn initializeWritablePartition(
221 &self,
222 image_fd: &ParcelFileDescriptor,
Alan Stokesff0005f2023-01-30 09:53:00 +0000223 size_bytes: i64,
Jiyong Park9dd389e2021-08-23 20:42:59 +0900224 partition_type: PartitionType,
Andrew Walbrandff3b942021-06-09 15:20:36 +0000225 ) -> binder::Result<()> {
Jiyong Park753553b2021-07-12 21:21:09 +0900226 check_manage_access()?;
Jiyong Park2227eaa2023-08-04 11:59:18 +0900227 let size_bytes = size_bytes
228 .try_into()
229 .with_context(|| format!("Invalid size: {}", size_bytes))
230 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT)?;
David Brazdilf50c7a62023-04-19 14:22:42 +0000231 let size_bytes = round_up(size_bytes, PARTITION_GRANULARITY_BYTES);
232 let image = clone_file(image_fd)?;
233 // initialize the file. Any data in the file will be erased.
Jiyong Park2227eaa2023-08-04 11:59:18 +0900234 image.set_len(0).context("Failed to reset a file").or_service_specific_exception(-1)?;
235 let mut part = QcowFile::new(image, size_bytes)
236 .context("Failed to create QCOW2 image")
237 .or_service_specific_exception(-1)?;
David Brazdilf50c7a62023-04-19 14:22:42 +0000238
239 match partition_type {
240 PartitionType::RAW => Ok(()),
241 PartitionType::ANDROID_VM_INSTANCE => format_as_android_vm_instance(&mut part),
242 PartitionType::ENCRYPTEDSTORE => format_as_encryptedstore(&mut part),
243 _ => Err(Error::new(
244 ErrorKind::Unsupported,
245 format!("Unsupported partition type {:?}", partition_type),
246 )),
247 }
Jiyong Park2227eaa2023-08-04 11:59:18 +0900248 .with_context(|| format!("Failed to initialize partition as {:?}", partition_type))
249 .or_service_specific_exception(-1)?;
David Brazdilf50c7a62023-04-19 14:22:42 +0000250
251 Ok(())
Andrew Walbrandff3b942021-06-09 15:20:36 +0000252 }
253
Jiyong Park0a248432021-08-20 23:32:39 +0900254 /// Creates or update the idsig file by digesting the input APK file.
255 fn createOrUpdateIdsigFile(
256 &self,
257 input_fd: &ParcelFileDescriptor,
258 idsig_fd: &ParcelFileDescriptor,
259 ) -> binder::Result<()> {
Jiyong Parkc3ca24f2022-06-28 10:45:15 +0900260 check_manage_access()?;
261
Jiyong Park2227eaa2023-08-04 11:59:18 +0900262 create_or_update_idsig_file(input_fd, idsig_fd).or_service_specific_exception(-1)?;
Jiyong Park0a248432021-08-20 23:32:39 +0900263 Ok(())
264 }
265
Andrew Walbran320b5602021-03-04 16:11:12 +0000266 /// Get a list of all currently running VMs. This method is only intended for debug purposes,
267 /// and as such is only permitted from the shell user.
268 fn debugListVms(&self) -> binder::Result<Vec<VirtualMachineDebugInfo>> {
David Brazdil209074a2023-01-12 16:44:51 +0000269 // Delegate to the global service, including checking the debug permission.
David Brazdild4f51a52023-01-11 14:09:27 +0000270 GLOBAL_SERVICE.debugListVms()
Andrew Walbran320b5602021-03-04 16:11:12 +0000271 }
Inseob Kim53d0b212023-07-20 16:58:37 +0900272
273 /// Get a list of assignable device types.
274 fn getAssignableDevices(&self) -> binder::Result<Vec<AssignableDevice>> {
275 // Delegate to the global service, including checking the permission.
276 GLOBAL_SERVICE.getAssignableDevices()
277 }
Nikita Ioffef7c742a2023-09-04 16:57:59 +0100278
279 /// Returns whether given feature is enabled
280 fn isFeatureEnabled(&self, feature: &str) -> binder::Result<bool> {
281 check_manage_access()?;
282
283 // This approach is quite cumbersome, but will do the work for the short term.
284 // TODO(b/298012279): make this scalable.
285 match feature {
Alan Stokes7f27c0d2023-09-07 16:22:58 +0100286 FEATURE_DICE_CHANGES => Ok(cfg!(dice_changes)),
Alan Stokes27f3ef02023-09-29 15:09:35 +0100287 FEATURE_MULTI_TENANT => Ok(cfg!(multi_tenant)),
Nikita Ioffe631717e2023-09-05 13:38:07 +0100288 FEATURE_VENDOR_MODULES => Ok(cfg!(vendor_modules)),
Nikita Ioffef7c742a2023-09-04 16:57:59 +0100289 _ => {
Alan Stokes7f27c0d2023-09-07 16:22:58 +0100290 warn!("unknown feature {feature}");
Nikita Ioffef7c742a2023-09-04 16:57:59 +0100291 Ok(false)
292 }
293 }
294 }
Andrew Walbran320b5602021-03-04 16:11:12 +0000295}
296
Jiyong Park8611a6c2021-07-09 18:17:44 +0900297impl VirtualizationService {
298 pub fn init() -> VirtualizationService {
David Brazdil49f96f52022-12-16 21:29:13 +0000299 VirtualizationService::default()
Jiyong Park8611a6c2021-07-09 18:17:44 +0900300 }
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000301
David Brazdil209074a2023-01-12 16:44:51 +0000302 fn create_vm_context(
303 &self,
304 requester_debug_pid: pid_t,
305 ) -> binder::Result<(VmContext, Cid, PathBuf)> {
David Brazdil8cf8f482022-11-23 14:21:26 +0000306 const NUM_ATTEMPTS: usize = 5;
307
308 for _ in 0..NUM_ATTEMPTS {
Charisee96113f32023-01-26 09:00:42 +0000309 let vm_context = GLOBAL_SERVICE.allocateGlobalVmContext(requester_debug_pid)?;
David Brazdild4f51a52023-01-11 14:09:27 +0000310 let cid = vm_context.getCid()? as Cid;
311 let temp_dir: PathBuf = vm_context.getTemporaryDirectory()?.into();
David Brazdil8cf8f482022-11-23 14:21:26 +0000312 let service = VirtualMachineService::new_binder(self.state.clone(), cid).as_binder();
313
314 // Start VM service listening for connections from the new CID on port=CID.
David Brazdil8cf8f482022-11-23 14:21:26 +0000315 let port = cid;
David Brazdil3238da42022-11-18 10:04:51 +0000316 match RpcServer::new_vsock(service, cid, port) {
David Brazdil8cf8f482022-11-23 14:21:26 +0000317 Ok(vm_server) => {
318 vm_server.start();
David Brazdild4f51a52023-01-11 14:09:27 +0000319 return Ok((VmContext::new(vm_context, vm_server), cid, temp_dir));
David Brazdil8cf8f482022-11-23 14:21:26 +0000320 }
321 Err(err) => {
322 warn!("Could not start RpcServer on port {}: {}", port, err);
323 }
324 }
325 }
Jiyong Park2227eaa2023-08-04 11:59:18 +0900326 Err(anyhow!("Too many attempts to create VM context failed"))
327 .or_service_specific_exception(-1)
David Brazdil8cf8f482022-11-23 14:21:26 +0000328 }
329
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000330 fn create_vm_internal(
331 &self,
332 config: &VirtualMachineConfig,
Jiyong Parke6fb1672023-06-26 16:45:55 +0900333 console_out_fd: Option<&ParcelFileDescriptor>,
334 console_in_fd: Option<&ParcelFileDescriptor>,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000335 log_fd: Option<&ParcelFileDescriptor>,
336 is_protected: &mut bool,
337 ) -> binder::Result<Strong<dyn IVirtualMachine>> {
David Brazdil209074a2023-01-12 16:44:51 +0000338 let requester_uid = get_calling_uid();
339 let requester_debug_pid = get_calling_pid();
340
Nikita Ioffe631717e2023-09-05 13:38:07 +0100341 check_config_features(config)?;
342
David Brazdil209074a2023-01-12 16:44:51 +0000343 // Allocating VM context checks the MANAGE_VIRTUAL_MACHINE permission.
344 let (vm_context, cid, temporary_directory) = self.create_vm_context(requester_debug_pid)?;
Inseob Kim1119d702022-05-02 18:01:58 +0900345
Alan Stokes7bc146c2022-10-20 17:10:32 +0100346 let is_custom = match config {
347 VirtualMachineConfig::RawConfig(_) => true,
348 VirtualMachineConfig::AppConfig(config) => {
349 // Some features are reserved for platform apps only, even when using
Nikita Ioffea0eb5ee2023-06-26 18:18:21 +0100350 // VirtualMachineAppConfig. Almost all of these features are grouped in the
351 // CustomConfig struct:
Alan Stokes7bc146c2022-10-20 17:10:32 +0100352 // - controlling CPUs;
Nikita Ioffea0eb5ee2023-06-26 18:18:21 +0100353 // - specifying a config file in the APK; (this one is not part of CustomConfig)
Nikita Ioffe26c35ed2023-06-05 17:49:08 +0100354 // - gdbPort is set, meaning that crosvm will start a gdb server;
Inseob Kim6ef80972023-07-20 17:23:36 +0900355 // - using anything other than the default kernel;
356 // - specifying devices to be assigned.
Nikita Ioffea0eb5ee2023-06-26 18:18:21 +0100357 config.customConfig.is_some() || matches!(config.payload, Payload::ConfigPath(_))
Inseob Kim1119d702022-05-02 18:01:58 +0900358 }
Alan Stokes7bc146c2022-10-20 17:10:32 +0100359 };
360 if is_custom {
361 check_use_custom_virtual_machine()?;
Inseob Kim1119d702022-05-02 18:01:58 +0900362 }
363
Nikita Ioffe5776f082023-02-10 21:38:26 +0000364 let gdb_port = extract_gdb_port(config);
365
366 // Additional permission checks if caller request gdb.
367 if gdb_port.is_some() {
368 check_gdb_allowed(config)?;
369 }
370
Seungjae Yooec3bc522023-11-09 10:14:30 +0900371 let vendor_public_key = extract_vendor_public_key(config)
372 .context("Failed to extract vendor public key")
373 .or_service_specific_exception(-1)?;
374 let dtbo_vendor = if let Some(vendor_public_key) = vendor_public_key {
375 let dtbo_for_vendor_image = temporary_directory.join("dtbo_vendor");
376 create_dtbo_for_vendor_image(&vendor_public_key, &dtbo_for_vendor_image)
377 .context("Failed to write vendor_public_key")
378 .or_service_specific_exception(-1)?;
379 let file = File::open(dtbo_for_vendor_image)
380 .context("Failed to open dtbo_vendor")
381 .or_service_specific_exception(-1)?;
382 Some(file)
383 } else {
384 None
385 };
386
Jaewan Kim61f86142023-03-28 15:12:52 +0900387 let debug_level = match config {
388 VirtualMachineConfig::AppConfig(config) => config.debugLevel,
389 _ => DebugLevel::NONE,
390 };
391 let debug_config = DebugConfig::new(debug_level);
392
393 let ramdump = if debug_config.is_ramdump_needed() {
Jiyong Parked180932023-02-24 19:55:41 +0900394 Some(prepare_ramdump_file(&temporary_directory)?)
395 } else {
396 None
397 };
398
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000399 let state = &mut *self.state.lock().unwrap();
Jiyong Parke6fb1672023-06-26 16:45:55 +0900400 let console_out_fd =
401 clone_or_prepare_logger_fd(&debug_config, console_out_fd, format!("Console({})", cid))?;
402 let console_in_fd = console_in_fd.map(clone_file).transpose()?;
Jaewan Kim61f86142023-03-28 15:12:52 +0900403 let log_fd = clone_or_prepare_logger_fd(&debug_config, log_fd, format!("Log({})", cid))?;
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000404
405 // Counter to generate unique IDs for temporary image files.
406 let mut next_temporary_image_id = 0;
407 // Files which are referred to from composite images. These must be mapped to the crosvm
408 // child process, and not closed before it is started.
409 let mut indirect_files = vec![];
410
Alan Stokes7bc146c2022-10-20 17:10:32 +0100411 let (is_app_config, config) = match config {
412 VirtualMachineConfig::RawConfig(config) => (false, BorrowedOrOwned::Borrowed(config)),
413 VirtualMachineConfig::AppConfig(config) => {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900414 let config = load_app_config(config, &debug_config, &temporary_directory)
415 .or_service_specific_exception_with(-1, |e| {
Jaewan Kim61f86142023-03-28 15:12:52 +0900416 *is_protected = config.protectedVm;
417 let message = format!("Failed to load app config: {:?}", e);
418 error!("{}", message);
Jiyong Park2227eaa2023-08-04 11:59:18 +0900419 message
Jaewan Kim61f86142023-03-28 15:12:52 +0900420 })?;
Alan Stokes7bc146c2022-10-20 17:10:32 +0100421 (true, BorrowedOrOwned::Owned(config))
422 }
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000423 };
424 let config = config.as_ref();
425 *is_protected = config.protectedVm;
426
427 // Check if partition images are labeled incorrectly. This is to prevent random images
428 // which are not protected by the Android Verified Boot (e.g. bits downloaded by apps) from
Alan Stokes3e5eec12023-09-07 12:10:00 +0100429 // being loaded in a pVM. This applies to everything but the instance image in the raw
430 // config, and everything but the non-executable, generated partitions in the app
431 // config.
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000432 config
433 .disks
434 .iter()
435 .flat_map(|disk| disk.partitions.iter())
436 .filter(|partition| {
437 if is_app_config {
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100438 !is_safe_app_partition(&partition.label)
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000439 } else {
Alice Wangc206b9b2023-08-28 14:13:51 +0000440 !is_safe_raw_partition(&partition.label)
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000441 }
442 })
443 .try_for_each(check_label_for_partition)
Jiyong Park2227eaa2023-08-04 11:59:18 +0900444 .or_service_specific_exception(-1)?;
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000445
Alan Stokes185fe112023-01-10 16:20:55 +0000446 let kernel = maybe_clone_file(&config.kernel)?;
447 let initrd = maybe_clone_file(&config.initrd)?;
448
449 // In a protected VM, we require custom kernels to come from a trusted source (b/237054515).
450 if config.protectedVm {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900451 check_label_for_kernel_files(&kernel, &initrd).or_service_specific_exception(-1)?;
Alan Stokes185fe112023-01-10 16:20:55 +0000452 }
453
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000454 let zero_filler_path = temporary_directory.join("zero.img");
Jiyong Park2227eaa2023-08-04 11:59:18 +0900455 write_zero_filler(&zero_filler_path)
456 .context("Failed to make composite image")
457 .with_log()
458 .or_service_specific_exception(-1)?;
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000459
460 // Assemble disk images if needed.
461 let disks = config
462 .disks
463 .iter()
464 .map(|disk| {
465 assemble_disk_image(
466 disk,
467 &zero_filler_path,
468 &temporary_directory,
469 &mut next_temporary_image_id,
470 &mut indirect_files,
471 )
472 })
473 .collect::<Result<Vec<DiskFile>, _>>()?;
474
David Brazdil7d1e5ec2023-02-06 17:56:29 +0000475 let (cpus, host_cpu_topology) = match config.cpuTopology {
476 CpuTopology::MATCH_HOST => (None, true),
477 CpuTopology::ONE_CPU => (NonZeroU32::new(1), false),
478 val => {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900479 return Err(anyhow!("Failed to parse CPU topology value {:?}", val))
480 .with_log()
481 .or_service_specific_exception(-1);
David Brazdil7d1e5ec2023-02-06 17:56:29 +0000482 }
483 };
484
Inseob Kim7307a892023-09-14 13:37:58 +0900485 let vfio_devices = if !config.devices.is_empty() {
Inseob Kim6ef80972023-07-20 17:23:36 +0900486 let mut set = HashSet::new();
487 for device in config.devices.iter() {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900488 let path = canonicalize(device)
489 .with_context(|| format!("can't canonicalize {device}"))
490 .or_service_specific_exception(-1)?;
Inseob Kim6ef80972023-07-20 17:23:36 +0900491 if !set.insert(path) {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900492 return Err(anyhow!("duplicated device {device}"))
493 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT);
Inseob Kim6ef80972023-07-20 17:23:36 +0900494 }
495 }
Inseob Kim7307a892023-09-14 13:37:58 +0900496 GLOBAL_SERVICE
497 .bindDevicesToVfioDriver(&config.devices)?
498 .into_iter()
499 .map(|x| VfioDevice {
500 sysfs_path: PathBuf::from(&x.sysfsPath),
Jaewan Kim35e818d2023-10-18 05:36:38 +0000501 dtbo_label: x.dtboLabel,
Inseob Kim7307a892023-09-14 13:37:58 +0900502 })
503 .collect::<Vec<_>>()
504 } else {
505 vec![]
506 };
Inseob Kim6ef80972023-07-20 17:23:36 +0900507
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000508 // Actually start the VM.
509 let crosvm_config = CrosvmConfig {
510 cid,
Seungjae Yoo62085c02022-08-12 04:44:52 +0000511 name: config.name.clone(),
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000512 bootloader: maybe_clone_file(&config.bootloader)?,
Alan Stokes185fe112023-01-10 16:20:55 +0000513 kernel,
514 initrd,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000515 disks,
516 params: config.params.to_owned(),
517 protected: *is_protected,
Jaewan Kim61f86142023-03-28 15:12:52 +0900518 debug_config,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000519 memory_mib: config.memoryMib.try_into().ok().and_then(NonZeroU32::new),
David Brazdil7d1e5ec2023-02-06 17:56:29 +0000520 cpus,
521 host_cpu_topology,
Jiyong Parkdfe16d62022-04-20 17:32:12 +0900522 task_profiles: config.taskProfiles.clone(),
Jiyong Parke6fb1672023-06-26 16:45:55 +0900523 console_out_fd,
524 console_in_fd,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000525 log_fd,
Jiyong Parked180932023-02-24 19:55:41 +0900526 ramdump,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000527 indirect_files,
528 platform_version: parse_platform_version_req(&config.platformVersion)?,
Jiyong Parke6ed0f92022-06-22 00:13:00 +0900529 detect_hangup: is_app_config,
Nikita Ioffe5776f082023-02-10 21:38:26 +0000530 gdb_port,
Inseob Kim7307a892023-09-14 13:37:58 +0900531 vfio_devices,
Seungjae Yooec3bc522023-11-09 10:14:30 +0900532 dtbo_vendor,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000533 };
534 let instance = Arc::new(
David Brazdil528e0472022-10-10 15:06:02 +0100535 VmInstance::new(
536 crosvm_config,
537 temporary_directory,
538 requester_uid,
539 requester_debug_pid,
540 vm_context,
541 )
Jiyong Park2227eaa2023-08-04 11:59:18 +0900542 .with_context(|| format!("Failed to create VM with config {:?}", config))
543 .with_log()
544 .or_service_specific_exception(-1)?,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000545 );
546 state.add_vm(Arc::downgrade(&instance));
547 Ok(VirtualMachine::create(instance))
548 }
Jiyong Park8611a6c2021-07-09 18:17:44 +0900549}
550
Seungjae Yooec3bc522023-11-09 10:14:30 +0900551fn extract_vendor_public_key(config: &VirtualMachineConfig) -> Result<Option<Vec<u8>>> {
552 let VirtualMachineConfig::AppConfig(config) = config else {
553 return Ok(None);
554 };
555 let Some(custom_config) = &config.customConfig else {
556 return Ok(None);
557 };
558 let Some(file) = custom_config.vendorImage.as_ref() else {
559 return Ok(None);
560 };
561
562 let file = clone_file(file)?;
563 let size = file.metadata().context("Failed to get metadata from microdroid-vendor.img")?.len();
564 let vbmeta = VbMetaImage::verify_reader_region(&file, 0, size)
565 .context("Failed to get vbmeta from microdroid-vendor.img")?;
566 let vendor_public_key = vbmeta
567 .public_key()
568 .ok_or(anyhow!("No public key is extracted from microdroid-vendor.img"))?
569 .to_vec();
570
571 Ok(Some(vendor_public_key))
572}
573
574fn create_dtbo_for_vendor_image(vendor_public_key: &[u8], dtbo: &PathBuf) -> Result<()> {
575 if dtbo.exists() {
576 return Err(anyhow!("DTBO file already exists"));
577 }
578
579 let mut buf = vec![0; EMPTY_VENDOR_DT_OVERLAY_BUF_SIZE];
580 let fdt = Fdt::create_empty_tree(buf.as_mut_slice())
581 .map_err(|e| anyhow!("Failed to create FDT: {:?}", e))?;
582 let mut root = fdt.root_mut().map_err(|e| anyhow!("Failed to get root node: {:?}", e))?;
583
584 let fragment_node_name = CString::new("fragment@0")?;
585 let mut fragment_node = root
586 .add_subnode(fragment_node_name.as_c_str())
587 .map_err(|e| anyhow!("Failed to create fragment node: {:?}", e))?;
588 let target_path_prop_name = CString::new("target-path")?;
589 let target_path = CString::new("/")?;
590 fragment_node
591 .setprop(target_path_prop_name.as_c_str(), target_path.to_bytes_with_nul())
592 .map_err(|e| anyhow!("Failed to set target-path: {:?}", e))?;
593 let overlay_node_name = CString::new("__overlay__")?;
594 let mut overlay_node = fragment_node
595 .add_subnode(overlay_node_name.as_c_str())
596 .map_err(|e| anyhow!("Failed to create overlay node: {:?}", e))?;
597
598 let avf_node_name = CString::new("avf")?;
599 let mut avf_node = overlay_node
600 .add_subnode(avf_node_name.as_c_str())
601 .map_err(|e| anyhow!("Failed to create avf node: {:?}", e))?;
602 let vendor_public_key_name = CString::new("vendor_public_key")?;
603 avf_node
604 .setprop(vendor_public_key_name.as_c_str(), vendor_public_key)
605 .map_err(|e| anyhow!("Failed to set avf/vendor_public_key: {:?}", e))?;
606
607 fdt.pack().map_err(|e| anyhow!("Failed to pack fdt: {:?}", e))?;
608 let mut file = File::create(dtbo)?;
609 file.write_all(fdt.as_slice())?;
610 Ok(file.flush()?)
611}
612
Andrew Walbranfbb39d22021-07-28 17:01:25 +0000613fn write_zero_filler(zero_filler_path: &Path) -> Result<()> {
Jooyung Han95884632021-07-06 22:27:54 +0900614 let file = OpenOptions::new()
615 .create_new(true)
616 .read(true)
617 .write(true)
618 .open(zero_filler_path)
619 .with_context(|| "Failed to create zero.img")?;
620 file.set_len(ZERO_FILLER_SIZE)?;
Andrew Walbranfbb39d22021-07-28 17:01:25 +0000621 Ok(())
Jooyung Han95884632021-07-06 22:27:54 +0900622}
623
David Brazdilf50c7a62023-04-19 14:22:42 +0000624fn format_as_android_vm_instance(part: &mut dyn Write) -> std::io::Result<()> {
625 part.write_all(ANDROID_VM_INSTANCE_MAGIC.as_bytes())?;
626 part.write_all(&ANDROID_VM_INSTANCE_VERSION.to_le_bytes())?;
627 part.flush()
628}
629
630fn format_as_encryptedstore(part: &mut dyn Write) -> std::io::Result<()> {
631 part.write_all(UNFORMATTED_STORAGE_MAGIC.as_bytes())?;
632 part.flush()
633}
634
635fn round_up(input: u64, granularity: u64) -> u64 {
636 if granularity == 0 {
637 return input;
638 }
639 // If the input is absurdly large we round down instead of up; it's going to fail anyway.
640 let result = input.checked_add(granularity - 1).unwrap_or(input);
641 (result / granularity) * granularity
642}
643
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000644/// Given the configuration for a disk image, assembles the `DiskFile` to pass to crosvm.
645///
646/// This may involve assembling a composite disk from a set of partition images.
647fn assemble_disk_image(
648 disk: &DiskImage,
Jooyung Han95884632021-07-06 22:27:54 +0900649 zero_filler_path: &Path,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000650 temporary_directory: &Path,
651 next_temporary_image_id: &mut u64,
652 indirect_files: &mut Vec<File>,
Andrew Walbran806f1542021-06-10 14:07:12 +0000653) -> Result<DiskFile, Status> {
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000654 let image = if !disk.partitions.is_empty() {
655 if disk.image.is_some() {
656 warn!("DiskImage {:?} contains both image and partitions.", disk);
Jiyong Park2227eaa2023-08-04 11:59:18 +0900657 return Err(anyhow!("DiskImage contains both image and partitions"))
658 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT);
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000659 }
660
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000661 let composite_image_filenames =
662 make_composite_image_filenames(temporary_directory, next_temporary_image_id);
663 let (image, partition_files) = make_composite_image(
664 &disk.partitions,
Jooyung Han95884632021-07-06 22:27:54 +0900665 zero_filler_path,
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000666 &composite_image_filenames.composite,
667 &composite_image_filenames.header,
668 &composite_image_filenames.footer,
669 )
Jiyong Park2227eaa2023-08-04 11:59:18 +0900670 .with_context(|| format!("Failed to make composite disk image with config {:?}", disk))
671 .with_log()
672 .or_service_specific_exception(-1)?;
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000673
674 // Pass the file descriptors for the various partition files to crosvm when it
675 // is run.
676 indirect_files.extend(partition_files);
677
678 image
679 } else if let Some(image) = &disk.image {
680 clone_file(image)?
681 } else {
682 warn!("DiskImage {:?} didn't contain image or partitions.", disk);
Jiyong Park2227eaa2023-08-04 11:59:18 +0900683 return Err(anyhow!("DiskImage didn't contain image or partitions."))
684 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT);
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000685 };
686
687 Ok(DiskFile { image, writable: disk.writable })
688}
689
Nikita Ioffeaa6858c2023-07-04 01:37:41 +0100690fn append_kernel_param(param: &str, vm_config: &mut VirtualMachineRawConfig) {
691 if let Some(ref mut params) = vm_config.params {
692 params.push(' ');
693 params.push_str(param)
694 } else {
695 vm_config.params = Some(param.to_owned())
696 }
697}
698
Inseob Kim172f9eb2023-11-06 17:02:08 +0900699fn is_valid_os(os_name: &str) -> bool {
700 if os_name == MICRODROID_OS_NAME {
701 return true;
702 }
703 if cfg!(vendor_modules) && os_name == MICRODROID_GKI_OS_NAME {
704 return true;
705 }
706 false
707}
708
Jooyung Han21e9b922021-06-26 04:14:16 +0900709fn load_app_config(
710 config: &VirtualMachineAppConfig,
Jaewan Kim61f86142023-03-28 15:12:52 +0900711 debug_config: &DebugConfig,
Jooyung Han21e9b922021-06-26 04:14:16 +0900712 temporary_directory: &Path,
Jooyung Hanadfb76c2021-06-28 17:29:30 +0900713) -> Result<VirtualMachineRawConfig> {
Andrew Walbrancc0db522021-07-12 17:03:42 +0000714 let apk_file = clone_file(config.apk.as_ref().unwrap())?;
715 let idsig_file = clone_file(config.idsig.as_ref().unwrap())?;
Jiyong Park8d081812021-07-23 17:45:04 +0900716 let instance_file = clone_file(config.instanceImage.as_ref().unwrap())?;
Jooyung Han21e9b922021-06-26 04:14:16 +0900717
Shikha Panwar22e70452022-10-10 18:32:55 +0000718 let storage_image = if let Some(file) = config.encryptedStorageImage.as_ref() {
719 Some(clone_file(file)?)
720 } else {
721 None
722 };
723
Alan Stokes0d1ef782022-09-27 13:46:35 +0100724 let vm_payload_config = match &config.payload {
725 Payload::ConfigPath(config_path) => {
726 load_vm_payload_config_from_file(&apk_file, config_path.as_str())
727 .with_context(|| format!("Couldn't read config from {}", config_path))?
728 }
Alan Stokes8f12f2b2023-01-09 09:19:20 +0000729 Payload::PayloadConfig(payload_config) => create_vm_payload_config(payload_config)?,
Alan Stokes0d1ef782022-09-27 13:46:35 +0100730 };
Jooyung Han21e9b922021-06-26 04:14:16 +0900731
Inseob Kim172f9eb2023-11-06 17:02:08 +0900732 // For now, the only supported OS is Microdroid and Microdroid GKI
Alan Stokes0d1ef782022-09-27 13:46:35 +0100733 let os_name = vm_payload_config.os.name.as_str();
Inseob Kim172f9eb2023-11-06 17:02:08 +0900734 if !is_valid_os(os_name) {
Andrew Walbrancc0db522021-07-12 17:03:42 +0000735 bail!("Unknown OS \"{}\"", os_name);
Jooyung Han35edb8f2021-07-01 16:17:16 +0900736 }
Andrew Walbrancc0db522021-07-12 17:03:42 +0000737
738 // It is safe to construct a filename based on the os_name because we've already checked that it
739 // is one of the allowed values.
Jooyung Han21e9b922021-06-26 04:14:16 +0900740 let vm_config_path = PathBuf::from(format!("/apex/com.android.virt/etc/{}.json", os_name));
741 let vm_config_file = File::open(vm_config_path)?;
Andrew Walbrancc0db522021-07-12 17:03:42 +0000742 let mut vm_config = VmConfig::load(&vm_config_file)?.to_parcelable()?;
Jooyung Han21e9b922021-06-26 04:14:16 +0900743
Nikita Ioffea0eb5ee2023-06-26 18:18:21 +0100744 if let Some(custom_config) = &config.customConfig {
745 if let Some(file) = custom_config.customKernelImage.as_ref() {
746 vm_config.kernel = Some(ParcelFileDescriptor::new(clone_file(file)?))
747 }
748 vm_config.taskProfiles = custom_config.taskProfiles.clone();
749 vm_config.gdbPort = custom_config.gdbPort;
Nikita Ioffe5dfddf22023-06-29 16:11:26 +0100750
751 if let Some(file) = custom_config.vendorImage.as_ref() {
Nikita Ioffeaa6858c2023-07-04 01:37:41 +0100752 add_microdroid_vendor_image(clone_file(file)?, &mut vm_config);
753 append_kernel_param("androidboot.microdroid.mount_vendor=1", &mut vm_config)
Nikita Ioffe5dfddf22023-06-29 16:11:26 +0100754 }
Inseob Kim6ef80972023-07-20 17:23:36 +0900755
756 vm_config.devices = custom_config.devices.clone();
Nikita Ioffe26c35ed2023-06-05 17:49:08 +0100757 }
758
Andrew Walbrancc045902021-07-27 16:06:17 +0000759 if config.memoryMib > 0 {
760 vm_config.memoryMib = config.memoryMib;
Andrew Walbran45bcb0c2021-07-14 15:02:06 +0000761 }
762
Seungjae Yoo62085c02022-08-12 04:44:52 +0000763 vm_config.name = config.name.clone();
Andrew Walbran3994f002022-01-27 17:33:45 +0000764 vm_config.protectedVm = config.protectedVm;
David Brazdil7d1e5ec2023-02-06 17:56:29 +0000765 vm_config.cpuTopology = config.cpuTopology;
Jiyong Park032615f2022-01-10 13:55:34 +0900766
Shikha Panwar22e70452022-10-10 18:32:55 +0000767 // Microdroid takes additional init ramdisk & (optionally) storage image
Inseob Kim172f9eb2023-11-06 17:02:08 +0900768 add_microdroid_system_images(config, instance_file, storage_image, os_name, &mut vm_config)?;
Shikha Panwar22e70452022-10-10 18:32:55 +0000769
770 // Include Microdroid payload disk (contains apks, idsigs) in vm config
771 add_microdroid_payload_images(
Alan Stokes0d1ef782022-09-27 13:46:35 +0100772 config,
Jaewan Kim61f86142023-03-28 15:12:52 +0900773 debug_config,
Alan Stokes0d1ef782022-09-27 13:46:35 +0100774 temporary_directory,
775 apk_file,
776 idsig_file,
Alan Stokes0d1ef782022-09-27 13:46:35 +0100777 &vm_payload_config,
778 &mut vm_config,
779 )?;
Jooyung Han21e9b922021-06-26 04:14:16 +0900780
Andrew Walbrancc0db522021-07-12 17:03:42 +0000781 Ok(vm_config)
Jooyung Han21e9b922021-06-26 04:14:16 +0900782}
783
Alan Stokes0d1ef782022-09-27 13:46:35 +0100784fn load_vm_payload_config_from_file(apk_file: &File, config_path: &str) -> Result<VmPayloadConfig> {
785 let mut apk_zip = ZipArchive::new(apk_file)?;
786 let config_file = apk_zip.by_name(config_path)?;
787 Ok(serde_json::from_reader(config_file)?)
788}
789
Alan Stokes8f12f2b2023-01-09 09:19:20 +0000790fn create_vm_payload_config(
791 payload_config: &VirtualMachinePayloadConfig,
792) -> Result<VmPayloadConfig> {
Alan Stokes0d1ef782022-09-27 13:46:35 +0100793 // There isn't an actual config file. Construct a synthetic VmPayloadConfig from the explicit
794 // parameters we've been given. Microdroid will do something equivalent inside the VM using the
795 // payload config that we send it via the metadata file.
Alan Stokes8f12f2b2023-01-09 09:19:20 +0000796
797 let payload_binary_name = &payload_config.payloadBinaryName;
798 if payload_binary_name.contains('/') {
799 bail!("Payload binary name must not specify a path: {payload_binary_name}");
800 }
801
802 let task = Task { type_: TaskType::MicrodroidLauncher, command: payload_binary_name.clone() };
Inseob Kim172f9eb2023-11-06 17:02:08 +0900803 let name = payload_config.osName.clone();
Alan Stokes8f12f2b2023-01-09 09:19:20 +0000804 Ok(VmPayloadConfig {
Inseob Kim172f9eb2023-11-06 17:02:08 +0900805 os: OsConfig { name },
Alan Stokes0d1ef782022-09-27 13:46:35 +0100806 task: Some(task),
807 apexes: vec![],
808 extra_apks: vec![],
809 prefer_staged: false,
Inseob Kimab1037d2023-02-08 17:03:31 +0900810 export_tombstones: None,
Alan Stokes0d1ef782022-09-27 13:46:35 +0100811 enable_authfs: false,
Alan Stokes8f12f2b2023-01-09 09:19:20 +0000812 })
Alan Stokes0d1ef782022-09-27 13:46:35 +0100813}
814
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000815/// Generates a unique filename to use for a composite disk image.
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000816fn make_composite_image_filenames(
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000817 temporary_directory: &Path,
818 next_temporary_image_id: &mut u64,
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000819) -> CompositeImageFilenames {
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000820 let id = *next_temporary_image_id;
821 *next_temporary_image_id += 1;
Andrew Walbran3eca16c2021-06-14 11:15:14 +0000822 CompositeImageFilenames {
823 composite: temporary_directory.join(format!("composite-{}.img", id)),
824 header: temporary_directory.join(format!("composite-{}-header.img", id)),
825 footer: temporary_directory.join(format!("composite-{}-footer.img", id)),
826 }
827}
828
829/// Filenames for a composite disk image, including header and footer partitions.
830#[derive(Clone, Debug, Eq, PartialEq)]
831struct CompositeImageFilenames {
832 /// The composite disk image itself.
833 composite: PathBuf,
834 /// The header partition image.
835 header: PathBuf,
836 /// The footer partition image.
837 footer: PathBuf,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +0000838}
839
Jiyong Park753553b2021-07-12 21:21:09 +0900840/// Checks whether the caller has a specific permission
841fn check_permission(perm: &str) -> binder::Result<()> {
David Brazdil1f530702022-10-03 12:18:10 +0100842 let calling_pid = get_calling_pid();
843 let calling_uid = get_calling_uid();
Jiyong Park753553b2021-07-12 21:21:09 +0900844 // Root can do anything
845 if calling_uid == 0 {
846 return Ok(());
847 }
848 let perm_svc: Strong<dyn IPermissionController::IPermissionController> =
849 binder::get_interface("permission")?;
850 if perm_svc.checkPermission(perm, calling_pid, calling_uid as i32)? {
Andrew Walbran806f1542021-06-10 14:07:12 +0000851 Ok(())
852 } else {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900853 Err(anyhow!("does not have the {} permission", perm))
854 .or_binder_exception(ExceptionCode::SECURITY)
Andrew Walbran806f1542021-06-10 14:07:12 +0000855 }
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000856}
857
Jiyong Park753553b2021-07-12 21:21:09 +0900858/// Check whether the caller of the current Binder method is allowed to manage VMs
859fn check_manage_access() -> binder::Result<()> {
860 check_permission("android.permission.MANAGE_VIRTUAL_MACHINE")
861}
862
Inseob Kim1119d702022-05-02 18:01:58 +0900863/// Check whether the caller of the current Binder method is allowed to create custom VMs
864fn check_use_custom_virtual_machine() -> binder::Result<()> {
865 check_permission("android.permission.USE_CUSTOM_VIRTUAL_MACHINE")
866}
867
Alan Stokes185fe112023-01-10 16:20:55 +0000868/// Return whether a partition is exempt from selinux label checks, because we know that it does
869/// not contain code and is likely to be generated in an app-writable directory.
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100870fn is_safe_app_partition(label: &str) -> bool {
Shikha Panwara2ff8c52022-11-30 19:25:46 +0000871 // See add_microdroid_system_images & add_microdroid_payload_images in payload.rs.
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100872 label == "vm-instance"
Shikha Panwara2ff8c52022-11-30 19:25:46 +0000873 || label == "encryptedstore"
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100874 || label == "microdroid-apk-idsig"
875 || label == "payload-metadata"
876 || label.starts_with("extra-idsig-")
877}
878
Alice Wangc206b9b2023-08-28 14:13:51 +0000879/// Returns whether a partition with the given label is safe for a raw config VM.
880fn is_safe_raw_partition(label: &str) -> bool {
881 label == "vm-instance"
882}
883
Alan Stokes185fe112023-01-10 16:20:55 +0000884/// Check that a file SELinux label is acceptable.
885///
886/// We only want to allow code in a VM to be sourced from places that apps, and the
Seungjae Yoo2b74c442023-11-15 18:05:07 +0900887/// system or vendor, do not have write access to.
Alan Stokes185fe112023-01-10 16:20:55 +0000888///
889/// Note that sepolicy must also grant read access for these types to both virtualization
890/// service and crosvm.
891///
892/// App private data files are deliberately excluded, to avoid arbitrary payloads being run on
893/// user devices (W^X).
894fn check_label_is_allowed(context: &SeContext) -> Result<()> {
895 match context.selinux_type()? {
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100896 | "apk_data_file" // APKs of an installed app
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100897 | "shell_data_file" // test files created via adb shell
Alan Stokesfe4bb0c2023-03-20 14:15:36 +0000898 | "staging_data_file" // updated/staged APEX images
899 | "system_file" // immutable dm-verity protected partition
900 | "virtualizationservice_data_file" // files created by VS / VirtMgr
Seungjae Yoo2b74c442023-11-15 18:05:07 +0900901 | "vendor_microdroid_file" // immutable dm-verity protected partition (/vendor/etc/avf/microdroid/.*)
Alan Stokes53cc5ca2022-08-30 14:28:19 +0100902 => Ok(()),
Alan Stokes185fe112023-01-10 16:20:55 +0000903 _ => bail!("Label {} is not allowed", context),
Jiyong Park029977d2021-11-24 21:56:49 +0900904 }
905}
906
Alan Stokes185fe112023-01-10 16:20:55 +0000907fn check_label_for_partition(partition: &Partition) -> Result<()> {
908 let file = partition.image.as_ref().unwrap().as_ref();
909 check_label_is_allowed(&getfilecon(file)?)
910 .with_context(|| format!("Partition {} invalid", &partition.label))
911}
912
913fn check_label_for_kernel_files(kernel: &Option<File>, initrd: &Option<File>) -> Result<()> {
914 if let Some(f) = kernel {
915 check_label_for_file(f, "kernel")?;
916 }
917 if let Some(f) = initrd {
918 check_label_for_file(f, "initrd")?;
919 }
920 Ok(())
921}
922fn check_label_for_file(file: &File, name: &str) -> Result<()> {
923 check_label_is_allowed(&getfilecon(file)?).with_context(|| format!("{} file invalid", name))
924}
925
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000926/// Implementation of the AIDL `IVirtualMachine` interface. Used as a handle to a VM.
927#[derive(Debug)]
928struct VirtualMachine {
929 instance: Arc<VmInstance>,
930}
931
932impl VirtualMachine {
933 fn create(instance: Arc<VmInstance>) -> Strong<dyn IVirtualMachine> {
David Brazdil4b4c5102022-12-19 22:56:20 +0000934 BnVirtualMachine::new_binder(VirtualMachine { instance }, BinderFeatures::default())
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000935 }
936}
937
938impl Interface for VirtualMachine {}
939
940impl IVirtualMachine for VirtualMachine {
941 fn getCid(&self) -> binder::Result<i32> {
Jiyong Park753553b2021-07-12 21:21:09 +0900942 // Don't check permission. The owner of the VM might have passed this binder object to
943 // others.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000944 Ok(self.instance.cid as i32)
945 }
Andrew Walbrandae07162021-03-12 17:05:20 +0000946
Andrew Walbran6b650662021-09-07 13:13:23 +0000947 fn getState(&self) -> binder::Result<VirtualMachineState> {
Jiyong Park753553b2021-07-12 21:21:09 +0900948 // Don't check permission. The owner of the VM might have passed this binder object to
949 // others.
Andrew Walbran6b650662021-09-07 13:13:23 +0000950 Ok(get_state(&self.instance))
Andrew Walbrandae07162021-03-12 17:05:20 +0000951 }
952
953 fn registerCallback(
954 &self,
955 callback: &Strong<dyn IVirtualMachineCallback>,
956 ) -> binder::Result<()> {
Jiyong Park753553b2021-07-12 21:21:09 +0900957 // Don't check permission. The owner of the VM might have passed this binder object to
958 // others.
959 //
Andrew Walbrandae07162021-03-12 17:05:20 +0000960 // TODO: Should this give an error if the VM is already dead?
961 self.instance.callbacks.add(callback.clone());
962 Ok(())
963 }
Andrew Walbrancbe8b082021-08-06 15:42:11 +0000964
Andrew Walbranf8d94112021-09-07 11:45:36 +0000965 fn start(&self) -> binder::Result<()> {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900966 self.instance
967 .start()
968 .with_context(|| format!("Error starting VM with CID {}", self.instance.cid))
969 .with_log()
970 .or_service_specific_exception(-1)
Andrew Walbranf8d94112021-09-07 11:45:36 +0000971 }
972
Inseob Kima446f802022-07-11 19:46:37 +0900973 fn stop(&self) -> binder::Result<()> {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900974 self.instance
975 .kill()
976 .with_context(|| format!("Error stopping VM with CID {}", self.instance.cid))
977 .with_log()
978 .or_service_specific_exception(-1)
Inseob Kima446f802022-07-11 19:46:37 +0900979 }
980
Keir Frasercdd4b112022-11-24 14:02:25 +0000981 fn onTrimMemory(&self, level: MemoryTrimLevel) -> binder::Result<()> {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900982 self.instance
983 .trim_memory(level)
984 .with_context(|| format!("Error trimming VM with CID {}", self.instance.cid))
985 .with_log()
986 .or_service_specific_exception(-1)
Keir Frasercdd4b112022-11-24 14:02:25 +0000987 }
988
Andrew Walbrancbe8b082021-08-06 15:42:11 +0000989 fn connectVsock(&self, port: i32) -> binder::Result<ParcelFileDescriptor> {
Andrew Walbranf8d94112021-09-07 11:45:36 +0000990 if !matches!(&*self.instance.vm_state.lock().unwrap(), VmState::Running { .. }) {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900991 return Err(anyhow!("VM is not running")).or_service_specific_exception(-1);
Andrew Walbrancbe8b082021-08-06 15:42:11 +0000992 }
Alan Stokes10c47672022-12-13 17:17:08 +0000993 let port = port as u32;
994 if port < 1024 {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900995 return Err(anyhow!("Can't connect to privileged port {port}"))
996 .or_service_specific_exception(-1);
Alan Stokes10c47672022-12-13 17:17:08 +0000997 }
Jiyong Park2227eaa2023-08-04 11:59:18 +0900998 let stream = VsockStream::connect_with_cid_port(self.instance.cid, port)
999 .context("Failed to connect")
1000 .or_service_specific_exception(-1)?;
Andrew Walbrancbe8b082021-08-06 15:42:11 +00001001 Ok(vsock_stream_to_pfd(stream))
1002 }
Andrew Walbrandae07162021-03-12 17:05:20 +00001003}
1004
1005impl Drop for VirtualMachine {
1006 fn drop(&mut self) {
1007 debug!("Dropping {:?}", self);
Inseob Kima446f802022-07-11 19:46:37 +09001008 if let Err(e) = self.instance.kill() {
1009 debug!("Error stopping dropped VM with CID {}: {:?}", self.instance.cid, e);
1010 }
Andrew Walbrandae07162021-03-12 17:05:20 +00001011 }
1012}
1013
1014/// A set of Binders to be called back in response to various events on the VM, such as when it
1015/// dies.
1016#[derive(Debug, Default)]
1017pub struct VirtualMachineCallbacks(Mutex<Vec<Strong<dyn IVirtualMachineCallback>>>);
1018
1019impl VirtualMachineCallbacks {
Jiyong Park8611a6c2021-07-09 18:17:44 +09001020 /// Call all registered callbacks to notify that the payload has started.
David Brazdil451cc962022-10-14 14:08:12 +01001021 pub fn notify_payload_started(&self, cid: Cid) {
Jiyong Park8611a6c2021-07-09 18:17:44 +09001022 let callbacks = &*self.0.lock().unwrap();
Jiyong Park8611a6c2021-07-09 18:17:44 +09001023 for callback in callbacks {
David Brazdil451cc962022-10-14 14:08:12 +01001024 if let Err(e) = callback.onPayloadStarted(cid as i32) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001025 error!("Error notifying payload start event from VM CID {}: {:?}", cid, e);
Jiyong Park8611a6c2021-07-09 18:17:44 +09001026 }
1027 }
1028 }
1029
Inseob Kim14cb8692021-08-31 21:50:39 +09001030 /// Call all registered callbacks to notify that the payload is ready to serve.
1031 pub fn notify_payload_ready(&self, cid: Cid) {
1032 let callbacks = &*self.0.lock().unwrap();
1033 for callback in callbacks {
1034 if let Err(e) = callback.onPayloadReady(cid as i32) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001035 error!("Error notifying payload ready event from VM CID {}: {:?}", cid, e);
Inseob Kim14cb8692021-08-31 21:50:39 +09001036 }
1037 }
1038 }
1039
Inseob Kim2444af92021-08-31 01:22:50 +09001040 /// Call all registered callbacks to notify that the payload has finished.
1041 pub fn notify_payload_finished(&self, cid: Cid, exit_code: i32) {
1042 let callbacks = &*self.0.lock().unwrap();
1043 for callback in callbacks {
1044 if let Err(e) = callback.onPayloadFinished(cid as i32, exit_code) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001045 error!("Error notifying payload finish event from VM CID {}: {:?}", cid, e);
Inseob Kim2444af92021-08-31 01:22:50 +09001046 }
1047 }
1048 }
1049
Jooyung Handd0a1732021-11-23 15:26:20 +09001050 /// Call all registered callbacks to say that the VM encountered an error.
Alan Stokes2bead0d2022-09-05 16:58:34 +01001051 pub fn notify_error(&self, cid: Cid, error_code: ErrorCode, message: &str) {
Jooyung Handd0a1732021-11-23 15:26:20 +09001052 let callbacks = &*self.0.lock().unwrap();
1053 for callback in callbacks {
1054 if let Err(e) = callback.onError(cid as i32, error_code, message) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001055 error!("Error notifying error event from VM CID {}: {:?}", cid, e);
Jooyung Handd0a1732021-11-23 15:26:20 +09001056 }
1057 }
1058 }
1059
Andrew Walbrandae07162021-03-12 17:05:20 +00001060 /// Call all registered callbacks to say that the VM has died.
Andrew Walbranc92d35f2022-01-12 12:45:19 +00001061 pub fn callback_on_died(&self, cid: Cid, reason: DeathReason) {
Andrew Walbrandae07162021-03-12 17:05:20 +00001062 let callbacks = &*self.0.lock().unwrap();
1063 for callback in callbacks {
Andrew Walbranc92d35f2022-01-12 12:45:19 +00001064 if let Err(e) = callback.onDied(cid as i32, reason) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001065 error!("Error notifying exit of VM CID {}: {:?}", cid, e);
Andrew Walbrandae07162021-03-12 17:05:20 +00001066 }
1067 }
1068 }
1069
1070 /// Add a new callback to the set.
1071 fn add(&self, callback: Strong<dyn IVirtualMachineCallback>) {
1072 self.0.lock().unwrap().push(callback);
1073 }
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001074}
1075
Andrew Walbranf6bf6862021-05-21 12:41:13 +00001076/// The mutable state of the VirtualizationService. There should only be one instance of this
1077/// struct.
Chris Wailes641fc4a2021-12-01 15:03:21 -08001078#[derive(Debug, Default)]
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001079struct State {
Alan Stokes3e5eec12023-09-07 12:10:00 +01001080 /// The VMs which have been started. When VMs are started a weak reference is added to this
1081 /// list while a strong reference is returned to the caller over Binder. Once all copies of
1082 /// the Binder client are dropped the weak reference here will become invalid, and will be
1083 /// removed from the list opportunistically the next time `add_vm` is called.
Andrew Walbran320b5602021-03-04 16:11:12 +00001084 vms: Vec<Weak<VmInstance>>,
1085}
1086
1087impl State {
Andrew Walbrandae07162021-03-12 17:05:20 +00001088 /// Get a list of VMs which still have Binder references to them.
Andrew Walbran320b5602021-03-04 16:11:12 +00001089 fn vms(&self) -> Vec<Arc<VmInstance>> {
1090 // Attempt to upgrade the weak pointers to strong pointers.
1091 self.vms.iter().filter_map(Weak::upgrade).collect()
1092 }
1093
1094 /// Add a new VM to the list.
1095 fn add_vm(&mut self, vm: Weak<VmInstance>) {
1096 // Garbage collect any entries from the stored list which no longer exist.
1097 self.vms.retain(|vm| vm.strong_count() > 0);
1098
1099 // Actually add the new VM.
1100 self.vms.push(vm);
1101 }
David Brazdil3c2ddef2021-03-18 13:09:57 +00001102
Jiyong Park8611a6c2021-07-09 18:17:44 +09001103 /// Get a VM that corresponds to the given cid
1104 fn get_vm(&self, cid: Cid) -> Option<Arc<VmInstance>> {
1105 self.vms().into_iter().find(|vm| vm.cid == cid)
1106 }
Jiyong Parkd50a0242021-09-16 21:00:14 +09001107}
1108
Andrew Walbran6b650662021-09-07 13:13:23 +00001109/// Gets the `VirtualMachineState` of the given `VmInstance`.
1110fn get_state(instance: &VmInstance) -> VirtualMachineState {
Andrew Walbranf8d94112021-09-07 11:45:36 +00001111 match &*instance.vm_state.lock().unwrap() {
1112 VmState::NotStarted { .. } => VirtualMachineState::NOT_STARTED,
1113 VmState::Running { .. } => match instance.payload_state() {
Andrew Walbran6b650662021-09-07 13:13:23 +00001114 PayloadState::Starting => VirtualMachineState::STARTING,
1115 PayloadState::Started => VirtualMachineState::STARTED,
1116 PayloadState::Ready => VirtualMachineState::READY,
1117 PayloadState::Finished => VirtualMachineState::FINISHED,
Jiyong Parka4eebde2022-07-12 18:01:12 +09001118 PayloadState::Hangup => VirtualMachineState::DEAD,
Andrew Walbranf8d94112021-09-07 11:45:36 +00001119 },
1120 VmState::Dead => VirtualMachineState::DEAD,
1121 VmState::Failed => VirtualMachineState::DEAD,
Andrew Walbran6b650662021-09-07 13:13:23 +00001122 }
1123}
1124
David Brazdilf50c7a62023-04-19 14:22:42 +00001125/// Converts a `&ParcelFileDescriptor` to a `File` by cloning the file.
Jiyong Park2227eaa2023-08-04 11:59:18 +09001126pub fn clone_file(file: &ParcelFileDescriptor) -> binder::Result<File> {
1127 file.as_ref()
1128 .try_clone()
1129 .context("Failed to clone File from ParcelFileDescriptor")
1130 .or_binder_exception(ExceptionCode::BAD_PARCELABLE)
Andrei Homescu11333c62023-11-09 04:26:39 +00001131 .map(File::from)
David Brazdilf50c7a62023-04-19 14:22:42 +00001132}
1133
Andrew Walbrand3a84182021-09-07 14:48:52 +00001134/// Converts an `&Option<ParcelFileDescriptor>` to an `Option<File>` by cloning the file.
Jiyong Park2227eaa2023-08-04 11:59:18 +09001135fn maybe_clone_file(file: &Option<ParcelFileDescriptor>) -> binder::Result<Option<File>> {
Andrew Walbrand3a84182021-09-07 14:48:52 +00001136 file.as_ref().map(clone_file).transpose()
1137}
1138
Andrew Walbrancbe8b082021-08-06 15:42:11 +00001139/// Converts a `VsockStream` to a `ParcelFileDescriptor`.
1140fn vsock_stream_to_pfd(stream: VsockStream) -> ParcelFileDescriptor {
1141 // SAFETY: ownership is transferred from stream to f
1142 let f = unsafe { File::from_raw_fd(stream.into_raw_fd()) };
1143 ParcelFileDescriptor::new(f)
1144}
1145
Jiyong Parkdcf17412022-02-08 15:07:23 +09001146/// Parses the platform version requirement string.
Jiyong Park2227eaa2023-08-04 11:59:18 +09001147fn parse_platform_version_req(s: &str) -> binder::Result<VersionReq> {
1148 VersionReq::parse(s)
1149 .with_context(|| format!("Invalid platform version requirement {}", s))
1150 .or_binder_exception(ExceptionCode::BAD_PARCELABLE)
Jiyong Parkdcf17412022-02-08 15:07:23 +09001151}
1152
Jiyong Parked180932023-02-24 19:55:41 +09001153/// Create the empty ramdump file
1154fn prepare_ramdump_file(temporary_directory: &Path) -> binder::Result<File> {
1155 // `ramdump_write` is sent to crosvm and will be the backing store for the /dev/hvc1 where
1156 // VM will emit ramdump to. `ramdump_read` will be sent back to the client (i.e. the VM
1157 // owner) for readout.
1158 let ramdump_path = temporary_directory.join("ramdump");
Jiyong Park2227eaa2023-08-04 11:59:18 +09001159 let ramdump = File::create(ramdump_path)
1160 .context("Failed to prepare ramdump file")
1161 .with_log()
1162 .or_service_specific_exception(-1)?;
Jiyong Parked180932023-02-24 19:55:41 +09001163 Ok(ramdump)
1164}
1165
Nikita Ioffe5776f082023-02-10 21:38:26 +00001166fn is_protected(config: &VirtualMachineConfig) -> bool {
1167 match config {
1168 VirtualMachineConfig::RawConfig(config) => config.protectedVm,
1169 VirtualMachineConfig::AppConfig(config) => config.protectedVm,
1170 }
1171}
1172
1173fn check_gdb_allowed(config: &VirtualMachineConfig) -> binder::Result<()> {
1174 if is_protected(config) {
Jiyong Park2227eaa2023-08-04 11:59:18 +09001175 return Err(anyhow!("Can't use gdb with protected VMs"))
1176 .or_binder_exception(ExceptionCode::SECURITY);
Nikita Ioffe5776f082023-02-10 21:38:26 +00001177 }
1178
1179 match config {
1180 VirtualMachineConfig::RawConfig(_) => Ok(()),
1181 VirtualMachineConfig::AppConfig(config) => {
1182 if config.debugLevel != DebugLevel::FULL {
Jiyong Park2227eaa2023-08-04 11:59:18 +09001183 Err(anyhow!("Can't use gdb with non-debuggable VMs"))
1184 .or_binder_exception(ExceptionCode::SECURITY)
Nikita Ioffe5776f082023-02-10 21:38:26 +00001185 } else {
1186 Ok(())
1187 }
1188 }
1189 }
1190}
1191
1192fn extract_gdb_port(config: &VirtualMachineConfig) -> Option<NonZeroU16> {
1193 match config {
1194 VirtualMachineConfig::RawConfig(config) => NonZeroU16::new(config.gdbPort as u16),
Nikita Ioffea0eb5ee2023-06-26 18:18:21 +01001195 VirtualMachineConfig::AppConfig(config) => {
1196 NonZeroU16::new(config.customConfig.as_ref().map(|c| c.gdbPort).unwrap_or(0) as u16)
1197 }
Nikita Ioffe5776f082023-02-10 21:38:26 +00001198 }
1199}
1200
Nikita Ioffe631717e2023-09-05 13:38:07 +01001201fn check_no_vendor_modules(config: &VirtualMachineConfig) -> binder::Result<()> {
1202 let VirtualMachineConfig::AppConfig(config) = config else { return Ok(()) };
1203 if let Some(custom_config) = &config.customConfig {
1204 if custom_config.vendorImage.is_some() || custom_config.customKernelImage.is_some() {
1205 return Err(anyhow!("vendor modules feature is disabled"))
1206 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION);
1207 }
1208 }
1209 Ok(())
1210}
1211
Nikita Ioffe94a8a182023-11-16 16:37:48 +00001212fn check_no_devices(config: &VirtualMachineConfig) -> binder::Result<()> {
1213 let VirtualMachineConfig::AppConfig(config) = config else { return Ok(()) };
1214 if let Some(custom_config) = &config.customConfig {
1215 if !custom_config.devices.is_empty() {
1216 return Err(anyhow!("device assignment feature is disabled"))
1217 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION);
1218 }
1219 }
1220 Ok(())
1221}
1222
Nikita Ioffe631717e2023-09-05 13:38:07 +01001223fn check_config_features(config: &VirtualMachineConfig) -> binder::Result<()> {
1224 if !cfg!(vendor_modules) {
1225 check_no_vendor_modules(config)?;
1226 }
Nikita Ioffe94a8a182023-11-16 16:37:48 +00001227 if !cfg!(device_assignment) {
1228 check_no_devices(config)?;
1229 }
Nikita Ioffe631717e2023-09-05 13:38:07 +01001230 Ok(())
1231}
1232
Inseob Kim0168b462022-12-27 14:54:35 +09001233fn clone_or_prepare_logger_fd(
Jaewan Kim61f86142023-03-28 15:12:52 +09001234 debug_config: &DebugConfig,
Inseob Kim0168b462022-12-27 14:54:35 +09001235 fd: Option<&ParcelFileDescriptor>,
1236 tag: String,
1237) -> Result<Option<File>, Status> {
1238 if let Some(fd) = fd {
1239 return Ok(Some(clone_file(fd)?));
1240 }
1241
Jaewan Kim61f86142023-03-28 15:12:52 +09001242 if !debug_config.should_prepare_console_output() {
Jaewan Kim66f062e2023-02-25 01:07:43 +09001243 return Ok(None);
1244 };
Inseob Kim0168b462022-12-27 14:54:35 +09001245
Jiyong Park2227eaa2023-08-04 11:59:18 +09001246 let (raw_read_fd, raw_write_fd) =
1247 pipe().context("Failed to create pipe").or_service_specific_exception(-1)?;
Inseob Kim0168b462022-12-27 14:54:35 +09001248
Andrew Walbranb58d1b42023-07-07 13:54:49 +01001249 // SAFETY: We are the sole owner of this FD as we just created it, and it is valid and open.
Inseob Kim0168b462022-12-27 14:54:35 +09001250 let mut reader = BufReader::new(unsafe { File::from_raw_fd(raw_read_fd) });
Andrew Walbranb58d1b42023-07-07 13:54:49 +01001251 // SAFETY: We are the sole owner of this FD as we just created it, and it is valid and open.
Inseob Kim0168b462022-12-27 14:54:35 +09001252 let write_fd = unsafe { File::from_raw_fd(raw_write_fd) };
1253
1254 std::thread::spawn(move || loop {
1255 let mut buf = vec![];
1256 match reader.read_until(b'\n', &mut buf) {
1257 Ok(0) => {
1258 // EOF
1259 return;
1260 }
1261 Ok(size) => {
1262 if buf[size - 1] == b'\n' {
1263 buf.pop();
1264 }
1265 info!("{}: {}", &tag, &String::from_utf8_lossy(&buf));
1266 }
1267 Err(e) => {
1268 error!("Could not read console pipe: {:?}", e);
1269 return;
1270 }
1271 };
1272 });
1273
1274 Ok(Some(write_fd))
1275}
1276
Jooyung Han35edb8f2021-07-01 16:17:16 +09001277/// Simple utility for referencing Borrowed or Owned. Similar to std::borrow::Cow, but
1278/// it doesn't require that T implements Clone.
1279enum BorrowedOrOwned<'a, T> {
1280 Borrowed(&'a T),
1281 Owned(T),
1282}
1283
1284impl<'a, T> AsRef<T> for BorrowedOrOwned<'a, T> {
1285 fn as_ref(&self) -> &T {
1286 match self {
1287 Self::Borrowed(b) => b,
Chris Wailes68c39f82021-07-27 16:03:44 -07001288 Self::Owned(o) => o,
Jooyung Han35edb8f2021-07-01 16:17:16 +09001289 }
1290 }
1291}
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001292
1293/// Implementation of `IVirtualMachineService`, the entry point of the AIDL service.
1294#[derive(Debug, Default)]
1295struct VirtualMachineService {
1296 state: Arc<Mutex<State>>,
Inseob Kimc7d28c72021-10-25 14:28:10 +00001297 cid: Cid,
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001298}
1299
1300impl Interface for VirtualMachineService {}
1301
1302impl IVirtualMachineService for VirtualMachineService {
Inseob Kimc7d28c72021-10-25 14:28:10 +00001303 fn notifyPayloadStarted(&self) -> binder::Result<()> {
1304 let cid = self.cid;
Inseob Kim7f61fe72021-08-20 20:50:47 +09001305 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01001306 info!("VM with CID {} started payload", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001307 vm.update_payload_state(PayloadState::Started)
1308 .or_binder_exception(ExceptionCode::ILLEGAL_STATE)?;
David Brazdil451cc962022-10-14 14:08:12 +01001309 vm.callbacks.notify_payload_started(cid);
Seungjae Yoo62085c02022-08-12 04:44:52 +00001310
Seungjae Yoo6d265d92022-11-15 10:51:33 +09001311 let vm_start_timestamp = vm.vm_metric.lock().unwrap().start_timestamp;
1312 write_vm_booted_stats(vm.requester_uid as i32, &vm.name, vm_start_timestamp);
Inseob Kim7f61fe72021-08-20 20:50:47 +09001313 Ok(())
1314 } else {
Jooyung Handd0a1732021-11-23 15:26:20 +09001315 error!("notifyPayloadStarted is called from an unknown CID {}", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001316 Err(anyhow!("cannot find a VM with CID {}", cid)).or_service_specific_exception(-1)
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001317 }
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001318 }
Inseob Kim2444af92021-08-31 01:22:50 +09001319
Inseob Kimc7d28c72021-10-25 14:28:10 +00001320 fn notifyPayloadReady(&self) -> binder::Result<()> {
1321 let cid = self.cid;
Inseob Kim14cb8692021-08-31 21:50:39 +09001322 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01001323 info!("VM with CID {} reported payload is ready", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001324 vm.update_payload_state(PayloadState::Ready)
1325 .or_binder_exception(ExceptionCode::ILLEGAL_STATE)?;
Inseob Kim14cb8692021-08-31 21:50:39 +09001326 vm.callbacks.notify_payload_ready(cid);
1327 Ok(())
1328 } else {
Jooyung Handd0a1732021-11-23 15:26:20 +09001329 error!("notifyPayloadReady is called from an unknown CID {}", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001330 Err(anyhow!("cannot find a VM with CID {}", cid)).or_service_specific_exception(-1)
Inseob Kim14cb8692021-08-31 21:50:39 +09001331 }
1332 }
1333
Inseob Kimc7d28c72021-10-25 14:28:10 +00001334 fn notifyPayloadFinished(&self, exit_code: i32) -> binder::Result<()> {
1335 let cid = self.cid;
Inseob Kim2444af92021-08-31 01:22:50 +09001336 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01001337 info!("VM with CID {} finished payload", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001338 vm.update_payload_state(PayloadState::Finished)
1339 .or_binder_exception(ExceptionCode::ILLEGAL_STATE)?;
Inseob Kim2444af92021-08-31 01:22:50 +09001340 vm.callbacks.notify_payload_finished(cid, exit_code);
1341 Ok(())
1342 } else {
Jooyung Handd0a1732021-11-23 15:26:20 +09001343 error!("notifyPayloadFinished is called from an unknown CID {}", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001344 Err(anyhow!("cannot find a VM with CID {}", cid)).or_service_specific_exception(-1)
Jooyung Handd0a1732021-11-23 15:26:20 +09001345 }
1346 }
1347
Alan Stokes2bead0d2022-09-05 16:58:34 +01001348 fn notifyError(&self, error_code: ErrorCode, message: &str) -> binder::Result<()> {
Jooyung Handd0a1732021-11-23 15:26:20 +09001349 let cid = self.cid;
1350 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01001351 info!("VM with CID {} encountered an error", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001352 vm.update_payload_state(PayloadState::Finished)
1353 .or_binder_exception(ExceptionCode::ILLEGAL_STATE)?;
Jooyung Handd0a1732021-11-23 15:26:20 +09001354 vm.callbacks.notify_error(cid, error_code, message);
1355 Ok(())
1356 } else {
Seungjae Yooec8c1602022-06-20 05:28:00 +00001357 error!("notifyError is called from an unknown CID {}", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001358 Err(anyhow!("cannot find a VM with CID {}", cid)).or_service_specific_exception(-1)
Inseob Kim2444af92021-08-31 01:22:50 +09001359 }
1360 }
Alice Wangc2fec932023-02-23 16:24:02 +00001361
Alice Wang4e3015d2023-10-10 09:35:37 +00001362 fn requestAttestation(&self, csr: &[u8]) -> binder::Result<Vec<Certificate>> {
Alice Wangbff017f2023-11-09 14:43:28 +00001363 GLOBAL_SERVICE.requestAttestation(csr, get_calling_uid() as i32)
Alice Wangc2fec932023-02-23 16:24:02 +00001364 }
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001365}
1366
1367impl VirtualMachineService {
Inseob Kimc7d28c72021-10-25 14:28:10 +00001368 fn new_binder(state: Arc<Mutex<State>>, cid: Cid) -> Strong<dyn IVirtualMachineService> {
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001369 BnVirtualMachineService::new_binder(
Inseob Kimc7d28c72021-10-25 14:28:10 +00001370 VirtualMachineService { state, cid },
Inseob Kim1b95f2e2021-08-19 13:17:40 +09001371 BinderFeatures::default(),
1372 )
1373 }
1374}
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001375
1376#[cfg(test)]
1377mod tests {
1378 use super::*;
1379
1380 #[test]
1381 fn test_is_allowed_label_for_partition() -> Result<()> {
1382 let expected_results = vec![
1383 ("u:object_r:system_file:s0", true),
1384 ("u:object_r:apk_data_file:s0", true),
1385 ("u:object_r:app_data_file:s0", false),
1386 ("u:object_r:app_data_file:s0:c512,c768", false),
1387 ("u:object_r:privapp_data_file:s0:c512,c768", false),
1388 ("invalid", false),
1389 ("user:role:apk_data_file:severity:categories", true),
1390 ("user:role:apk_data_file:severity:categories:extraneous", false),
1391 ];
1392
1393 for (label, expected_valid) in expected_results {
1394 let context = SeContext::new(label)?;
1395 let result = check_label_is_allowed(&context);
1396 if expected_valid {
1397 assert!(result.is_ok(), "Expected label {} to be allowed, got {:?}", label, result);
1398 } else if result.is_ok() {
1399 bail!("Expected label {} to be disallowed", label);
1400 }
1401 }
1402 Ok(())
1403 }
Nikita Ioffef1ce9872022-12-09 13:31:59 +00001404
1405 #[test]
1406 fn test_create_or_update_idsig_file_empty_apk() -> Result<()> {
1407 let apk = tempfile::tempfile().unwrap();
1408 let idsig = tempfile::tempfile().unwrap();
1409
1410 let ret = create_or_update_idsig_file(
1411 &ParcelFileDescriptor::new(apk),
1412 &ParcelFileDescriptor::new(idsig),
1413 );
1414 assert!(ret.is_err(), "should fail");
1415 Ok(())
1416 }
1417
1418 #[test]
1419 fn test_create_or_update_idsig_dir_instead_of_file_for_apk() -> Result<()> {
1420 let tmp_dir = tempfile::TempDir::new().unwrap();
1421 let apk = File::open(tmp_dir.path()).unwrap();
1422 let idsig = tempfile::tempfile().unwrap();
1423
1424 let ret = create_or_update_idsig_file(
1425 &ParcelFileDescriptor::new(apk),
1426 &ParcelFileDescriptor::new(idsig),
1427 );
1428 assert!(ret.is_err(), "should fail");
1429 Ok(())
1430 }
1431
1432 /// Verifies that create_or_update_idsig_file won't oom if a fd that corresponds to a directory
1433 /// on ext4 filesystem is passed.
1434 /// On ext4 lseek on a directory fd will return (off_t)-1 (see:
1435 /// https://bugzilla.kernel.org/show_bug.cgi?id=200043), which will result in
1436 /// create_or_update_idsig_file ooming while attempting to allocate petabytes of memory.
1437 #[test]
1438 fn test_create_or_update_idsig_does_not_crash_dir_on_ext4() -> Result<()> {
1439 // APEXes are backed by the ext4.
1440 let apk = File::open("/apex/com.android.virt/").unwrap();
1441 let idsig = tempfile::tempfile().unwrap();
1442
1443 let ret = create_or_update_idsig_file(
1444 &ParcelFileDescriptor::new(apk),
1445 &ParcelFileDescriptor::new(idsig),
1446 );
1447 assert!(ret.is_err(), "should fail");
1448 Ok(())
1449 }
Jiyong Park8d192952023-06-26 14:29:51 +09001450
1451 #[test]
1452 fn test_create_or_update_idsig_does_not_update_if_already_valid() -> Result<()> {
1453 use std::io::Seek;
1454
1455 // Pick any APK
1456 let mut apk = File::open("/system/priv-app/Shell/Shell.apk").unwrap();
1457 let mut idsig = tempfile::tempfile().unwrap();
1458
1459 create_or_update_idsig_file(
1460 &ParcelFileDescriptor::new(apk.try_clone()?),
1461 &ParcelFileDescriptor::new(idsig.try_clone()?),
1462 )?;
1463 let modified_orig = idsig.metadata()?.modified()?;
1464 apk.rewind()?;
1465 idsig.rewind()?;
1466
1467 // Call the function again
1468 create_or_update_idsig_file(
1469 &ParcelFileDescriptor::new(apk.try_clone()?),
1470 &ParcelFileDescriptor::new(idsig.try_clone()?),
1471 )?;
1472 let modified_new = idsig.metadata()?.modified()?;
1473 assert!(modified_orig == modified_new, "idsig file was updated unnecessarily");
1474 Ok(())
1475 }
Nikita Ioffeaa6858c2023-07-04 01:37:41 +01001476
1477 #[test]
1478 fn test_append_kernel_param_first_param() {
1479 let mut vm_config = VirtualMachineRawConfig { ..Default::default() };
1480 append_kernel_param("foo=1", &mut vm_config);
1481 assert_eq!(vm_config.params, Some("foo=1".to_owned()))
1482 }
1483
1484 #[test]
1485 fn test_append_kernel_param() {
1486 let mut vm_config =
1487 VirtualMachineRawConfig { params: Some("foo=5".to_owned()), ..Default::default() };
1488 append_kernel_param("bar=42", &mut vm_config);
1489 assert_eq!(vm_config.params, Some("foo=5 bar=42".to_owned()))
1490 }
Seungjae Yooec3bc522023-11-09 10:14:30 +09001491
1492 #[test]
1493 fn test_create_dtbo_for_vendor_image() -> Result<()> {
1494 let vendor_public_key = String::from("foo");
1495 let vendor_public_key = vendor_public_key.as_bytes();
1496
1497 let tmp_dir = tempfile::TempDir::new()?;
1498 let dtbo_path = tmp_dir.path().to_path_buf().join("bar");
1499
1500 create_dtbo_for_vendor_image(vendor_public_key, &dtbo_path)?;
1501
1502 let data = std::fs::read(dtbo_path)?;
1503 let fdt = Fdt::from_slice(&data).unwrap();
1504
1505 let fragment_node_path = CString::new("/fragment@0")?;
1506 let fragment_node = fdt.node(fragment_node_path.as_c_str()).unwrap();
1507 let Some(fragment_node) = fragment_node else {
1508 bail!("fragment_node shouldn't be None.");
1509 };
1510 let target_path_prop_name = CString::new("target-path")?;
1511 let target_path_from_dtbo =
1512 fragment_node.getprop(target_path_prop_name.as_c_str()).unwrap();
1513 let target_path_expected = CString::new("/")?;
1514 assert_eq!(target_path_from_dtbo, Some(target_path_expected.to_bytes_with_nul()));
1515
1516 let avf_node_path = CString::new("/fragment@0/__overlay__/avf")?;
1517 let avf_node = fdt.node(avf_node_path.as_c_str()).unwrap();
1518 let Some(avf_node) = avf_node else {
1519 bail!("avf_node shouldn't be None.");
1520 };
1521 let vendor_public_key_name = CString::new("vendor_public_key")?;
1522 let key_from_dtbo = avf_node.getprop(vendor_public_key_name.as_c_str()).unwrap();
1523 assert_eq!(key_from_dtbo, Some(vendor_public_key));
1524
1525 tmp_dir.close()?;
1526 Ok(())
1527 }
1528
1529 #[test]
1530 fn test_create_dtbo_for_vendor_image_throws_error_if_already_exists() -> Result<()> {
1531 let vendor_public_key = String::from("foo");
1532 let vendor_public_key = vendor_public_key.as_bytes();
1533
1534 let tmp_dir = tempfile::TempDir::new()?;
1535 let dtbo_path = tmp_dir.path().to_path_buf().join("bar");
1536
1537 create_dtbo_for_vendor_image(vendor_public_key, &dtbo_path)?;
1538
1539 let ret_second_trial = create_dtbo_for_vendor_image(vendor_public_key, &dtbo_path);
1540 assert!(ret_second_trial.is_err(), "should fail");
1541
1542 tmp_dir.close()?;
1543 Ok(())
1544 }
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001545}