blob: eefaa65f6267240f933ebc6d9a3c8ca86b4de443 [file] [log] [blame]
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001// Copyright 2021, The Android Open Source Project
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
Andrew Walbranf6bf6862021-05-21 12:41:13 +000015//! Implementation of the AIDL interface of the VirtualizationService.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +000016
Seungjae Yoo13af0b62024-05-20 14:15:13 +090017use crate::{get_calling_pid, get_calling_uid, get_this_pid};
Alan Stokesfda70842023-12-20 17:50:14 +000018use crate::atom::{write_vm_booted_stats, write_vm_creation_stats};
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +000019use crate::composite::make_composite_image;
Akilesh Kailash05515dc2024-10-22 21:42:52 -070020use crate::crosvm::{AudioConfig, CrosvmConfig, DiskFile, SharedPathConfig, DisplayConfig, GpuConfig, InputDeviceOption, PayloadState, UsbConfig, VmContext, VmInstance, VmState};
Jaewan Kimabd328b2024-12-10 15:59:33 +090021use crate::debug_config::{DebugConfig, DebugPolicy};
Shikha Panwar55e10ec2024-02-13 12:53:49 +000022use crate::dt_overlay::{create_device_tree_overlay, VM_DT_OVERLAY_MAX_SIZE, VM_DT_OVERLAY_PATH};
Inseob Kimf79c5722024-12-16 17:29:57 +090023use crate::payload::{ApexInfoList, add_microdroid_payload_images, add_microdroid_system_images, add_microdroid_vendor_image};
Nikita Ioffe13748d22024-10-23 15:10:39 +000024use crate::selinux::{check_tee_service_permission, getfilecon, getprevcon, SeContext};
Jiyong Park753553b2021-07-12 21:21:09 +090025use android_os_permissions_aidl::aidl::android::os::IPermissionController;
David Brazdil49f96f52022-12-16 21:29:13 +000026use android_system_virtualizationcommon::aidl::android::system::virtualizationcommon::{
Alice Wang4e3015d2023-10-10 09:35:37 +000027 Certificate::Certificate,
Andrew Walbranc92d35f2022-01-12 12:45:19 +000028 DeathReason::DeathReason,
David Brazdil49f96f52022-12-16 21:29:13 +000029 ErrorCode::ErrorCode,
30};
31use android_system_virtualizationservice::aidl::android::system::virtualizationservice::{
Jaewan Kimf43372b2024-12-13 18:33:58 +090032 AssignedDevices::AssignedDevices,
Inseob Kim53d0b212023-07-20 16:58:37 +090033 AssignableDevice::AssignableDevice,
Andrew Walbran6b650662021-09-07 13:13:23 +000034 DiskImage::DiskImage,
Akilesh Kailash05515dc2024-10-22 21:42:52 -070035 SharedPath::SharedPath,
Jeongik Chac181be72024-03-27 00:18:30 +090036 InputDevice::InputDevice,
Devin Moore407df8f2024-08-27 19:39:16 +000037 IVirtualMachine::{self, BnVirtualMachine},
Andrew Walbran6b650662021-09-07 13:13:23 +000038 IVirtualMachineCallback::IVirtualMachineCallback,
39 IVirtualizationService::IVirtualizationService,
Jiyong Park029977d2021-11-24 21:56:49 +090040 Partition::Partition,
Andrew Walbran6b650662021-09-07 13:13:23 +000041 PartitionType::PartitionType,
Inseob Kim0168b462022-12-27 14:54:35 +090042 VirtualMachineAppConfig::{DebugLevel::DebugLevel, Payload::Payload, VirtualMachineAppConfig},
Jooyung Han21e9b922021-06-26 04:14:16 +090043 VirtualMachineConfig::VirtualMachineConfig,
Andrew Walbran6b650662021-09-07 13:13:23 +000044 VirtualMachineDebugInfo::VirtualMachineDebugInfo,
Alan Stokes0d1ef782022-09-27 13:46:35 +010045 VirtualMachinePayloadConfig::VirtualMachinePayloadConfig,
Jooyung Han21e9b922021-06-26 04:14:16 +090046 VirtualMachineRawConfig::VirtualMachineRawConfig,
Andrew Walbran6b650662021-09-07 13:13:23 +000047 VirtualMachineState::VirtualMachineState,
Jooyung Han21e9b922021-06-26 04:14:16 +090048};
Inseob Kimecde8c02024-09-03 13:11:08 +090049use android_system_virtualizationservice_internal::aidl::android::system::virtualizationservice_internal::IGlobalVmContext::IGlobalVmContext;
David Brazdilafc9a9e2023-01-12 16:08:10 +000050use android_system_virtualizationservice_internal::aidl::android::system::virtualizationservice_internal::IVirtualizationServiceInternal::IVirtualizationServiceInternal;
Seungjae Yoodd91f0f2022-11-09 15:25:21 +090051use android_system_virtualmachineservice::aidl::android::system::virtualmachineservice::IVirtualMachineService::{
David Brazdilafc9a9e2023-01-12 16:08:10 +000052 BnVirtualMachineService, IVirtualMachineService,
Seungjae Yoofd9a0622022-10-14 10:01:29 +090053};
Shikha Panware45e9422024-02-28 21:18:10 +000054use android_hardware_security_secretkeeper::aidl::android::hardware::security::secretkeeper::ISecretkeeper::{BnSecretkeeper, ISecretkeeper};
Shikha Panwar5d6a6752023-12-14 22:08:26 +000055use android_hardware_security_secretkeeper::aidl::android::hardware::security::secretkeeper::SecretId::SecretId;
Matt Gilbrideb57abcc2024-10-12 15:26:45 +000056use android_hardware_security_secretkeeper::aidl::android::hardware::security::secretkeeper::PublicKey::PublicKey;
Shikha Panwar5d6a6752023-12-14 22:08:26 +000057use android_hardware_security_authgraph::aidl::android::hardware::security::authgraph::{
58 Arc::Arc as AuthgraphArc, IAuthGraphKeyExchange::IAuthGraphKeyExchange,
59 IAuthGraphKeyExchange::BnAuthGraphKeyExchange, Identity::Identity, KeInitResult::KeInitResult,
60 Key::Key, PubKey::PubKey, SessionIdSignature::SessionIdSignature, SessionInfo::SessionInfo,
61 SessionInitiationInfo::SessionInitiationInfo,
62};
Inseob Kim7e1877b2024-11-07 17:28:56 +090063use anyhow::{anyhow, bail, ensure, Context, Result};
Seungjae Yoofd9a0622022-10-14 10:01:29 +090064use apkverify::{HashAlgorithm, V4Signature};
Jiyong Parkd7bd2f22023-08-10 20:41:19 +090065use avflog::LogResult;
Alan Stokes0e82b502022-08-08 14:44:48 +010066use binder::{
Devin Moore407df8f2024-08-27 19:39:16 +000067 self, wait_for_interface, Accessor, BinderFeatures, ConnectionInfo, ExceptionCode, Interface, ParcelFileDescriptor,
68 SpIBinder, Status, StatusCode, Strong, IntoBinderResult,
Andrew Walbrana89fc132021-03-17 17:08:36 +000069};
Inseob Kim46257382024-01-03 15:41:22 +090070use glob::glob;
Devin Moorec8800a12024-10-17 17:56:18 +000071use libc::{AF_VSOCK, sa_family_t, sockaddr_vm};
Seungjae Yoo0a8c84c2022-07-11 08:19:15 +000072use log::{debug, error, info, warn};
Nikita Ioffe901083f2025-01-20 01:54:28 +000073use microdroid_payload_config::{ApexConfig, ApkConfig, Task, TaskType, VmPayloadConfig};
Inseob Kim0168b462022-12-27 14:54:35 +090074use nix::unistd::pipe;
David Brazdil73988ea2022-11-11 15:10:32 +000075use rpcbinder::RpcServer;
Alan Stokes25f69362023-03-06 16:51:54 +000076use rustutils::system_properties;
Jiyong Parkdcf17412022-02-08 15:07:23 +090077use semver::VersionReq;
Inseob Kimecde8c02024-09-03 13:11:08 +090078use serde::Deserialize;
Inseob Kim7e1877b2024-11-07 17:28:56 +090079use std::collections::{HashSet, HashMap};
Andrew Walbrandff3b942021-06-09 15:20:36 +000080use std::convert::TryInto;
Shikha Panwar55e10ec2024-02-13 12:53:49 +000081use std::fs;
Jaewan Kim39952072024-01-19 17:04:53 +090082use std::ffi::CStr;
Inseob Kimecde8c02024-09-03 13:11:08 +090083use std::fs::{canonicalize, create_dir_all, read_dir, remove_dir_all, remove_file, File, OpenOptions};
Shikha Panwar9ae2e622024-01-30 12:22:30 +000084use std::io::{BufRead, BufReader, Error, ErrorKind, Seek, SeekFrom, Write};
Inseob Kim46257382024-01-03 15:41:22 +090085use std::iter;
Nikita Ioffe5776f082023-02-10 21:38:26 +000086use std::num::{NonZeroU16, NonZeroU32};
Inseob Kimecde8c02024-09-03 13:11:08 +090087use std::ops::Range;
Jiyong Parkaf63d1c2024-09-04 16:15:42 +090088use std::os::unix::io::{AsRawFd, FromRawFd, IntoRawFd};
David Brazdilafc9a9e2023-01-12 16:08:10 +000089use std::os::unix::raw::pid_t;
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +000090use std::path::{Path, PathBuf};
Andrew Walbran9c03a3a2024-09-03 12:12:59 +010091use std::sync::{Arc, Mutex, Weak, LazyLock};
Seungjae Yoo14e60182024-02-21 13:28:31 +090092use vbmeta::VbMetaImage;
Pierre-Clément Tosid3bbe1d2024-04-15 18:03:51 +010093use vmconfig::{VmConfig, get_debug_level};
Devin Moorec8800a12024-10-17 17:56:18 +000094use vsock::VsockStream;
Jooyung Han35edb8f2021-07-01 16:17:16 +090095use zip::ZipArchive;
Andrew Walbrand6dce6f2021-03-05 16:39:08 +000096
David Brazdil41d1a872022-10-05 14:44:19 +010097/// The unique ID of a VM used (together with a port number) for vsock communication.
98pub type Cid = u32;
99
David Brazdil4b4c5102022-12-19 22:56:20 +0000100pub const BINDER_SERVICE_IDENTIFIER: &str = "android.system.virtualizationservice";
101
Devin Moore407df8f2024-08-27 19:39:16 +0000102/// Vsock privileged ports are below this number.
103const VSOCK_PRIV_PORT_MAX: u32 = 1024;
104
Jooyung Han95884632021-07-06 22:27:54 +0900105/// The size of zero.img.
106/// Gaps in composite disk images are filled with a shared zero.img.
107const ZERO_FILLER_SIZE: u64 = 4096;
108
David Brazdilf50c7a62023-04-19 14:22:42 +0000109/// Magic string for the instance image
110const ANDROID_VM_INSTANCE_MAGIC: &str = "Android-VM-instance";
111
112/// Version of the instance image format
113const ANDROID_VM_INSTANCE_VERSION: u16 = 1;
114
Alan Stokes0d1ef782022-09-27 13:46:35 +0100115const MICRODROID_OS_NAME: &str = "microdroid";
116
Shikha Panwar5d6a6752023-12-14 22:08:26 +0000117const SECRETKEEPER_IDENTIFIER: &str =
Shikha Panwarbe5dee72024-02-21 19:06:20 +0000118 "android.hardware.security.secretkeeper.ISecretkeeper/default";
Shikha Panwar5d6a6752023-12-14 22:08:26 +0000119
David Brazdilf50c7a62023-04-19 14:22:42 +0000120const UNFORMATTED_STORAGE_MAGIC: &str = "UNFORMATTED-STORAGE";
121
122/// crosvm requires all partitions to be a multiple of 4KiB.
123const PARTITION_GRANULARITY_BYTES: u64 = 4096;
124
Shikha Panwar55e10ec2024-02-13 12:53:49 +0000125const VM_REFERENCE_DT_ON_HOST_PATH: &str = "/proc/device-tree/avf/reference";
126
Andrew Walbran9c03a3a2024-09-03 12:12:59 +0100127pub static GLOBAL_SERVICE: LazyLock<Strong<dyn IVirtualizationServiceInternal>> =
128 LazyLock::new(|| {
Inseob Kimecde8c02024-09-03 13:11:08 +0900129 if cfg!(early) {
130 panic!("Early virtmgr must not connect to VirtualizatinoServiceInternal")
131 } else {
132 wait_for_interface(BINDER_SERVICE_IDENTIFIER)
133 .expect("Could not connect to VirtualizationServiceInternal")
134 }
Andrew Walbran9c03a3a2024-09-03 12:12:59 +0100135 });
136static SUPPORTED_OS_NAMES: LazyLock<HashSet<String>> =
137 LazyLock::new(|| get_supported_os_names().expect("Failed to get list of supported os names"));
David Brazdil49f96f52022-12-16 21:29:13 +0000138
Inseob Kime3e932d2024-12-16 20:06:57 +0900139static CALLING_EXE_PATH: LazyLock<Option<PathBuf>> = LazyLock::new(|| {
140 let calling_exe_link = format!("/proc/{}/exe", get_calling_pid());
141 match fs::read_link(&calling_exe_link) {
142 Ok(calling_exe_path) => Some(calling_exe_path),
143 Err(e) => {
144 // virtmgr forked from apps fails to read /proc probably due to hidepid=2. As we
145 // discourage vendor apps, regarding such cases as system is safer.
146 // TODO(b/383969737): determine if this is okay. Or find a way how to track origins of
147 // apps.
148 warn!("can't read_link '{calling_exe_link}': {e:?}; regarding as system");
149 None
150 }
151 }
152});
153
Nikita Ioffef1ce9872022-12-09 13:31:59 +0000154fn create_or_update_idsig_file(
155 input_fd: &ParcelFileDescriptor,
156 idsig_fd: &ParcelFileDescriptor,
157) -> Result<()> {
158 let mut input = clone_file(input_fd)?;
159 let metadata = input.metadata().context("failed to get input metadata")?;
160 if !metadata.is_file() {
161 bail!("input is not a regular file");
162 }
Alan Stokes25f69362023-03-06 16:51:54 +0000163 let mut sig =
164 V4Signature::create(&mut input, get_current_sdk()?, 4096, &[], HashAlgorithm::SHA256)
165 .context("failed to create idsig")?;
Nikita Ioffef1ce9872022-12-09 13:31:59 +0000166
167 let mut output = clone_file(idsig_fd)?;
Jiyong Park8d192952023-06-26 14:29:51 +0900168
169 // Optimization. We don't have to update idsig file whenever a VM is started. Don't update it,
170 // if the idsig file already has the same APK digest.
171 if output.metadata()?.len() > 0 {
172 if let Ok(out_sig) = V4Signature::from_idsig(&mut output) {
173 if out_sig.signing_info.apk_digest == sig.signing_info.apk_digest {
174 debug!("idsig {:?} is up-to-date with apk {:?}.", output, input);
175 return Ok(());
176 }
177 }
178 // if we fail to read v4signature from output, that's fine. User can pass a random file.
179 // We will anyway overwrite the file to the v4signature generated from input_fd.
180 }
181
Shikha Panwar9ae2e622024-01-30 12:22:30 +0000182 output
183 .seek(SeekFrom::Start(0))
184 .context("failed to move cursor to start on the idsig output")?;
Nikita Ioffec09b0492022-12-14 20:18:33 +0000185 output.set_len(0).context("failed to set_len on the idsig output")?;
186 sig.write_into(&mut output).context("failed to write idsig")?;
Nikita Ioffef1ce9872022-12-09 13:31:59 +0000187 Ok(())
188}
189
Alan Stokes25f69362023-03-06 16:51:54 +0000190fn get_current_sdk() -> Result<u32> {
191 let current_sdk = system_properties::read("ro.build.version.sdk")?;
192 let current_sdk = current_sdk.ok_or_else(|| anyhow!("SDK version missing"))?;
193 current_sdk.parse().context("Malformed SDK version")
194}
195
David Brazdil4b4c5102022-12-19 22:56:20 +0000196pub fn remove_temporary_files(path: &PathBuf) -> Result<()> {
197 for dir_entry in read_dir(path)? {
198 remove_file(dir_entry?.path())?;
199 }
200 Ok(())
David Brazdil528e0472022-10-10 15:06:02 +0100201}
202
David Brazdil528e0472022-10-10 15:06:02 +0100203/// Implementation of `IVirtualizationService`, the entry point of the AIDL service.
David Brazdil49f96f52022-12-16 21:29:13 +0000204#[derive(Debug, Default)]
Andrew Walbranf6bf6862021-05-21 12:41:13 +0000205pub struct VirtualizationService {
Jiyong Park8611a6c2021-07-09 18:17:44 +0900206 state: Arc<Mutex<State>>,
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000207}
208
Shikha Panward8e35422021-10-11 13:51:27 +0000209impl Interface for VirtualizationService {
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000210 fn dump(&self, writer: &mut dyn Write, _args: &[&CStr]) -> Result<(), StatusCode> {
Shikha Panward8e35422021-10-11 13:51:27 +0000211 check_permission("android.permission.DUMP").or(Err(StatusCode::PERMISSION_DENIED))?;
212 let state = &mut *self.state.lock().unwrap();
213 let vms = state.vms();
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000214 writeln!(writer, "Running {0} VMs:", vms.len()).or(Err(StatusCode::UNKNOWN_ERROR))?;
Shikha Panward8e35422021-10-11 13:51:27 +0000215 for vm in vms {
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000216 writeln!(writer, "VM CID: {}", vm.cid).or(Err(StatusCode::UNKNOWN_ERROR))?;
217 writeln!(writer, "\tState: {:?}", vm.vm_state.lock().unwrap())
Shikha Panward8e35422021-10-11 13:51:27 +0000218 .or(Err(StatusCode::UNKNOWN_ERROR))?;
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000219 writeln!(writer, "\tPayload state {:?}", vm.payload_state())
Shikha Panward8e35422021-10-11 13:51:27 +0000220 .or(Err(StatusCode::UNKNOWN_ERROR))?;
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000221 writeln!(writer, "\tProtected: {}", vm.protected).or(Err(StatusCode::UNKNOWN_ERROR))?;
222 writeln!(writer, "\ttemporary_directory: {}", vm.temporary_directory.to_string_lossy())
Shikha Panward8e35422021-10-11 13:51:27 +0000223 .or(Err(StatusCode::UNKNOWN_ERROR))?;
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000224 writeln!(writer, "\trequester_uid: {}", vm.requester_uid)
Shikha Panward8e35422021-10-11 13:51:27 +0000225 .or(Err(StatusCode::UNKNOWN_ERROR))?;
Andrei Homescu0cf8e222023-11-09 04:27:55 +0000226 writeln!(writer, "\trequester_debug_pid: {}", vm.requester_debug_pid)
Shikha Panward8e35422021-10-11 13:51:27 +0000227 .or(Err(StatusCode::UNKNOWN_ERROR))?;
228 }
229 Ok(())
230 }
231}
Andrew Walbranf6bf6862021-05-21 12:41:13 +0000232impl IVirtualizationService for VirtualizationService {
Andrew Walbranf8d94112021-09-07 11:45:36 +0000233 /// Creates (but does not start) a new VM with the given configuration, assigning it the next
234 /// available CID.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000235 ///
236 /// Returns a binder `IVirtualMachine` object referring to it, as a handle for the client.
Andrew Walbranf8d94112021-09-07 11:45:36 +0000237 fn createVm(
Andrew Walbrana89fc132021-03-17 17:08:36 +0000238 &self,
Andrew Walbran3a5a9212021-05-04 17:09:08 +0000239 config: &VirtualMachineConfig,
Jiyong Parke6fb1672023-06-26 16:45:55 +0900240 console_out_fd: Option<&ParcelFileDescriptor>,
241 console_in_fd: Option<&ParcelFileDescriptor>,
Andrew Walbrana89fc132021-03-17 17:08:36 +0000242 log_fd: Option<&ParcelFileDescriptor>,
Elie Kheirallah5c807a22024-09-23 20:40:42 +0000243 dump_dt_fd: Option<&ParcelFileDescriptor>,
Devin Moore407df8f2024-08-27 19:39:16 +0000244 ) -> binder::Result<Strong<dyn IVirtualMachine::IVirtualMachine>> {
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000245 let mut is_protected = false;
Jiyong Parke6fb1672023-06-26 16:45:55 +0900246 let ret = self.create_vm_internal(
247 config,
248 console_out_fd,
249 console_in_fd,
250 log_fd,
251 &mut is_protected,
Elie Kheirallah5c807a22024-09-23 20:40:42 +0000252 dump_dt_fd,
Jiyong Parke6fb1672023-06-26 16:45:55 +0900253 );
Seungjae Yoo0a8c84c2022-07-11 08:19:15 +0000254 write_vm_creation_stats(config, is_protected, &ret);
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000255 ret
Andrew Walbrand6dce6f2021-03-05 16:39:08 +0000256 }
Andrew Walbran320b5602021-03-04 16:11:12 +0000257
Shikha Panwar61a74b52024-02-16 13:17:01 +0000258 /// Allocate a new instance_id to the VM
259 fn allocateInstanceId(&self) -> binder::Result<[u8; 64]> {
Shikha Panwarbd5eba92024-03-27 20:23:31 +0000260 check_manage_access()?;
Shikha Panwar61a74b52024-02-16 13:17:01 +0000261 GLOBAL_SERVICE.allocateInstanceId()
262 }
263
Andrew Walbrandff3b942021-06-09 15:20:36 +0000264 /// Initialise an empty partition image of the given size to be used as a writable partition.
265 fn initializeWritablePartition(
266 &self,
267 image_fd: &ParcelFileDescriptor,
Alan Stokesff0005f2023-01-30 09:53:00 +0000268 size_bytes: i64,
Jiyong Park9dd389e2021-08-23 20:42:59 +0900269 partition_type: PartitionType,
Andrew Walbrandff3b942021-06-09 15:20:36 +0000270 ) -> binder::Result<()> {
Jiyong Park753553b2021-07-12 21:21:09 +0900271 check_manage_access()?;
Jiyong Park2227eaa2023-08-04 11:59:18 +0900272 let size_bytes = size_bytes
273 .try_into()
274 .with_context(|| format!("Invalid size: {}", size_bytes))
275 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT)?;
David Brazdilf50c7a62023-04-19 14:22:42 +0000276 let size_bytes = round_up(size_bytes, PARTITION_GRANULARITY_BYTES);
Shikha Panwar9ae2e622024-01-30 12:22:30 +0000277 let mut image = clone_file(image_fd)?;
David Brazdilf50c7a62023-04-19 14:22:42 +0000278 // initialize the file. Any data in the file will be erased.
Shikha Panwar9ae2e622024-01-30 12:22:30 +0000279 image
280 .seek(SeekFrom::Start(0))
281 .context("failed to move cursor to start")
282 .or_service_specific_exception(-1)?;
Jiyong Park2227eaa2023-08-04 11:59:18 +0900283 image.set_len(0).context("Failed to reset a file").or_service_specific_exception(-1)?;
Frederick Mayle0d310572024-05-02 12:34:58 -0700284 // Set the file length. In most filesystems, this will not allocate any physical disk
285 // space, it will only change the logical size.
286 image
287 .set_len(size_bytes)
288 .context("Failed to extend file")
Jiyong Park2227eaa2023-08-04 11:59:18 +0900289 .or_service_specific_exception(-1)?;
David Brazdilf50c7a62023-04-19 14:22:42 +0000290
291 match partition_type {
292 PartitionType::RAW => Ok(()),
Frederick Mayle0d310572024-05-02 12:34:58 -0700293 PartitionType::ANDROID_VM_INSTANCE => format_as_android_vm_instance(&mut image),
294 PartitionType::ENCRYPTEDSTORE => format_as_encryptedstore(&mut image),
David Brazdilf50c7a62023-04-19 14:22:42 +0000295 _ => Err(Error::new(
296 ErrorKind::Unsupported,
297 format!("Unsupported partition type {:?}", partition_type),
298 )),
299 }
Jiyong Park2227eaa2023-08-04 11:59:18 +0900300 .with_context(|| format!("Failed to initialize partition as {:?}", partition_type))
301 .or_service_specific_exception(-1)?;
David Brazdilf50c7a62023-04-19 14:22:42 +0000302
303 Ok(())
Andrew Walbrandff3b942021-06-09 15:20:36 +0000304 }
305
Shraddha Basantwania9a9c4f2025-02-25 09:51:48 -0800306 fn setEncryptedStorageSize(
307 &self,
308 image_fd: &ParcelFileDescriptor,
309 size: i64,
310 ) -> binder::Result<()> {
311 check_manage_access()?;
312
313 let size = size
314 .try_into()
315 .with_context(|| format!("Invalid size: {}", size))
316 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT)?;
317 let size = round_up(size, PARTITION_GRANULARITY_BYTES);
318
319 let image = clone_file(image_fd)?;
320 let image_size = image.metadata().unwrap().len();
321
322 if image_size > size {
323 return Err(Status::new_exception_str(
324 ExceptionCode::ILLEGAL_ARGUMENT,
325 Some("Can't shrink encrypted storage"),
326 ));
327 }
328 // Reset the file length. In most filesystems, this will not allocate any physical disk
329 // space, it will only change the logical size.
330 image.set_len(size).context("Failed to extend file").or_service_specific_exception(-1)?;
331 Ok(())
332 }
333
Jiyong Park0a248432021-08-20 23:32:39 +0900334 /// Creates or update the idsig file by digesting the input APK file.
335 fn createOrUpdateIdsigFile(
336 &self,
337 input_fd: &ParcelFileDescriptor,
338 idsig_fd: &ParcelFileDescriptor,
339 ) -> binder::Result<()> {
Jiyong Parkc3ca24f2022-06-28 10:45:15 +0900340 check_manage_access()?;
341
Jiyong Park2227eaa2023-08-04 11:59:18 +0900342 create_or_update_idsig_file(input_fd, idsig_fd).or_service_specific_exception(-1)?;
Jiyong Park0a248432021-08-20 23:32:39 +0900343 Ok(())
344 }
345
Andrew Walbran320b5602021-03-04 16:11:12 +0000346 /// Get a list of all currently running VMs. This method is only intended for debug purposes,
347 /// and as such is only permitted from the shell user.
348 fn debugListVms(&self) -> binder::Result<Vec<VirtualMachineDebugInfo>> {
David Brazdil209074a2023-01-12 16:44:51 +0000349 // Delegate to the global service, including checking the debug permission.
David Brazdild4f51a52023-01-11 14:09:27 +0000350 GLOBAL_SERVICE.debugListVms()
Andrew Walbran320b5602021-03-04 16:11:12 +0000351 }
Inseob Kim53d0b212023-07-20 16:58:37 +0900352
353 /// Get a list of assignable device types.
354 fn getAssignableDevices(&self) -> binder::Result<Vec<AssignableDevice>> {
355 // Delegate to the global service, including checking the permission.
356 GLOBAL_SERVICE.getAssignableDevices()
357 }
Nikita Ioffef7c742a2023-09-04 16:57:59 +0100358
Inseob Kim46257382024-01-03 15:41:22 +0900359 /// Get a list of supported OSes.
360 fn getSupportedOSList(&self) -> binder::Result<Vec<String>> {
361 Ok(Vec::from_iter(SUPPORTED_OS_NAMES.iter().cloned()))
362 }
363
Jaewan Kimabd328b2024-12-10 15:59:33 +0900364 /// Get printable debug policy for testing and debugging
365 fn getDebugPolicy(&self) -> binder::Result<String> {
366 let debug_policy = DebugPolicy::from_host();
367 Ok(format!("{debug_policy:?}"))
368 }
369
Nikita Ioffef7c742a2023-09-04 16:57:59 +0100370 /// Returns whether given feature is enabled
371 fn isFeatureEnabled(&self, feature: &str) -> binder::Result<bool> {
372 check_manage_access()?;
Shikha Panwar6d306412024-02-17 21:37:49 +0000373 Ok(avf_features::is_feature_enabled(feature))
Nikita Ioffef7c742a2023-09-04 16:57:59 +0100374 }
Alice Wange64dd182024-01-17 15:57:55 +0000375
376 fn enableTestAttestation(&self) -> binder::Result<()> {
377 GLOBAL_SERVICE.enableTestAttestation()
378 }
Alice Wang0362f7f2024-03-21 08:16:26 +0000379
380 fn isRemoteAttestationSupported(&self) -> binder::Result<bool> {
381 check_manage_access()?;
382 GLOBAL_SERVICE.isRemoteAttestationSupported()
383 }
Shikha Panwar7aef66d2024-03-13 00:28:41 +0000384
385 fn isUpdatableVmSupported(&self) -> binder::Result<bool> {
386 // The response is specific to Microdroid. Updatable VMs are only possible if device
387 // supports Secretkeeper. Guest OS needs to use Secretkeeper based secrets. Microdroid does
388 // this, however other guest OSes may do things differently.
389 check_manage_access()?;
390 Ok(is_secretkeeper_supported())
391 }
Shikha Panwarbd5eba92024-03-27 20:23:31 +0000392
Shikha Panwar07d701c2024-03-28 14:43:52 +0000393 fn removeVmInstance(&self, instance_id: &[u8; 64]) -> binder::Result<()> {
394 check_manage_access()?;
395 GLOBAL_SERVICE.removeVmInstance(instance_id)
396 }
397
Shikha Panwarbd5eba92024-03-27 20:23:31 +0000398 fn claimVmInstance(&self, instance_id: &[u8; 64]) -> binder::Result<()> {
399 check_manage_access()?;
400 GLOBAL_SERVICE.claimVmInstance(instance_id)
401 }
Andrew Walbran320b5602021-03-04 16:11:12 +0000402}
403
Inseob Kimecde8c02024-09-03 13:11:08 +0900404/// Implementation of the AIDL `IGlobalVmContext` interface for early VMs.
405#[derive(Debug, Default)]
406struct EarlyVmContext {
407 /// The unique CID assigned to the VM for vsock communication.
408 cid: Cid,
409 /// Temporary directory for this VM instance.
410 temp_dir: PathBuf,
411}
412
413impl EarlyVmContext {
414 fn new(cid: Cid, temp_dir: PathBuf) -> Result<Self> {
415 // Remove the entire directory before creating a VM. Early VMs use predefined CIDs and AVF
416 // should trust clients, e.g. they won't run two VMs at the same time
417 let _ = remove_dir_all(&temp_dir);
418 create_dir_all(&temp_dir).context(format!("can't create '{}'", temp_dir.display()))?;
419
420 Ok(Self { cid, temp_dir })
421 }
422}
423
424impl Interface for EarlyVmContext {}
425
426impl Drop for EarlyVmContext {
427 fn drop(&mut self) {
428 if let Err(e) = remove_dir_all(&self.temp_dir) {
429 error!("Cannot remove {} upon dropping: {e}", self.temp_dir.display());
430 }
431 }
432}
433
434impl IGlobalVmContext for EarlyVmContext {
435 fn getCid(&self) -> binder::Result<i32> {
436 Ok(self.cid as i32)
437 }
438
439 fn getTemporaryDirectory(&self) -> binder::Result<String> {
440 Ok(self.temp_dir.to_string_lossy().to_string())
441 }
442
443 fn setHostConsoleName(&self, _pathname: &str) -> binder::Result<()> {
444 Err(Status::new_exception_str(
445 ExceptionCode::UNSUPPORTED_OPERATION,
446 Some("Early VM doesn't support setting host console name"),
447 ))
448 }
449}
450
Frederick Mayle3a46b272025-02-10 21:55:49 -0800451#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
452enum CallingPartition {
453 Odm,
454 Product,
455 System,
456 SystemExt,
457 Vendor,
458 Unknown,
459}
460
461impl CallingPartition {
462 fn as_str(&self) -> &'static str {
463 match self {
464 CallingPartition::Odm => "odm",
465 CallingPartition::Product => "product",
466 CallingPartition::System => "system",
467 CallingPartition::SystemExt => "system_ext",
468 CallingPartition::Vendor => "vendor",
469 CallingPartition::Unknown => "[unknown]",
470 }
471 }
472}
473
474impl std::fmt::Display for CallingPartition {
475 fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
476 write!(f, "{}", self.as_str())
477 }
478}
479
480fn find_partition(path: Option<&Path>) -> binder::Result<CallingPartition> {
Frederick Maylecc9862f2025-02-10 20:42:59 -0800481 let Some(path) = path else {
Frederick Mayle3a46b272025-02-10 21:55:49 -0800482 return Ok(CallingPartition::System);
Inseob Kime3e932d2024-12-16 20:06:57 +0900483 };
Armelle Laine1a25d982025-01-31 06:39:54 +0000484 if path.starts_with("/system/system_ext/") {
Frederick Mayle3a46b272025-02-10 21:55:49 -0800485 return Ok(CallingPartition::SystemExt);
Armelle Laine1a25d982025-01-31 06:39:54 +0000486 }
Frederick Mayle3a46b272025-02-10 21:55:49 -0800487 if path.starts_with("/system/product/") {
488 return Ok(CallingPartition::Product);
489 }
Frederick Mayle2192baf2025-02-26 11:27:22 -0800490 if path.starts_with("/data/nativetest/vendor/")
491 || path.starts_with("/data/nativetest64/vendor/")
492 {
493 return Ok(CallingPartition::Vendor);
494 }
495
Frederick Mayle3a46b272025-02-10 21:55:49 -0800496 let partition = {
497 let mut components = path.components();
498 let Some(std::path::Component::Normal(partition)) = components.nth(1) else {
499 return Err(anyhow!("Can't find partition in '{}'", path.display()))
Frederick Maylecc9862f2025-02-10 20:42:59 -0800500 .or_service_specific_exception(-1);
501 };
Frederick Maylecc9862f2025-02-10 20:42:59 -0800502
Frederick Mayle3a46b272025-02-10 21:55:49 -0800503 // If path is under /apex, find a partition of the preinstalled .apex path
504 if partition == "apex" {
505 let Some(std::path::Component::Normal(apex_name)) = components.next() else {
506 return Err(anyhow!("Can't find apex name for '{}'", path.display()))
507 .or_service_specific_exception(-1);
508 };
509 let apex_info_list = ApexInfoList::load()
510 .context("Failed to get apex info list")
511 .or_service_specific_exception(-1)?;
512 apex_info_list
513 .list
514 .iter()
515 .find(|apex_info| apex_info.name.as_str() == apex_name)
516 .map(|apex_info| apex_info.partition.to_lowercase())
517 .ok_or(anyhow!("Can't find apex info for {apex_name:?}"))
518 .or_service_specific_exception(-1)?
519 } else {
520 partition.to_string_lossy().into_owned()
521 }
522 };
523 Ok(match partition.as_str() {
524 "odm" => CallingPartition::Odm,
525 "product" => CallingPartition::Product,
526 "system" => CallingPartition::System,
527 "system_ext" => CallingPartition::SystemExt,
528 "vendor" => CallingPartition::Vendor,
529 _ => {
530 warn!("unknown partition for '{}'", path.display());
531 CallingPartition::Unknown
532 }
533 })
Inseob Kimecde8c02024-09-03 13:11:08 +0900534}
535
Jiyong Park8611a6c2021-07-09 18:17:44 +0900536impl VirtualizationService {
537 pub fn init() -> VirtualizationService {
David Brazdil49f96f52022-12-16 21:29:13 +0000538 VirtualizationService::default()
Jiyong Park8611a6c2021-07-09 18:17:44 +0900539 }
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000540
Inseob Kimecde8c02024-09-03 13:11:08 +0900541 fn create_early_vm_context(
542 &self,
543 config: &VirtualMachineConfig,
Inseob Kime3e932d2024-12-16 20:06:57 +0900544 calling_exe_path: Option<&Path>,
Frederick Mayle50c2b6a2025-02-11 18:26:04 -0800545 calling_partition: CallingPartition,
Inseob Kimecde8c02024-09-03 13:11:08 +0900546 ) -> binder::Result<(VmContext, Cid, PathBuf)> {
Inseob Kimecde8c02024-09-03 13:11:08 +0900547 let name = match config {
548 VirtualMachineConfig::RawConfig(config) => &config.name,
549 VirtualMachineConfig::AppConfig(config) => &config.name,
550 };
Frederick Mayle3a46b272025-02-10 21:55:49 -0800551 let early_vm = find_early_vm_for_partition(calling_partition, name)
Inseob Kime3e932d2024-12-16 20:06:57 +0900552 .or_service_specific_exception(-1)?;
553 let calling_exe_path = match calling_exe_path {
554 Some(path) => path,
555 None => {
556 return Err(anyhow!("Can't verify the path of PID {}", get_calling_pid()))
557 .or_service_specific_exception(-1)
558 }
559 };
Alice Wang78dd87a2025-02-13 08:56:07 +0000560 early_vm.check_exe_paths_match(calling_exe_path)?;
Inseob Kimecde8c02024-09-03 13:11:08 +0900561
562 let cid = early_vm.cid as Cid;
563 let temp_dir = PathBuf::from(format!("/mnt/vm/early/{cid}"));
564
565 let context = EarlyVmContext::new(cid, temp_dir.clone())
566 .context(format!("Can't create early vm contexts for {cid}"))
567 .or_service_specific_exception(-1)?;
Inseob Kimecde8c02024-09-03 13:11:08 +0900568
Jiyong Park690c1ca2024-11-28 18:06:50 +0900569 if requires_vm_service(config) {
570 // Start VM service listening for connections from the new CID on port=CID.
571 let service = VirtualMachineService::new_binder(self.state.clone(), cid).as_binder();
572 let port = cid;
573 let (vm_server, _) = RpcServer::new_vsock(service, cid, port)
574 .context(format!("Could not start RpcServer on port {port}"))
575 .or_service_specific_exception(-1)?;
576 vm_server.start();
577 Ok((VmContext::new(Strong::new(Box::new(context)), Some(vm_server)), cid, temp_dir))
578 } else {
579 Ok((VmContext::new(Strong::new(Box::new(context)), None), cid, temp_dir))
580 }
Inseob Kimecde8c02024-09-03 13:11:08 +0900581 }
582
David Brazdil209074a2023-01-12 16:44:51 +0000583 fn create_vm_context(
584 &self,
585 requester_debug_pid: pid_t,
Jiyong Park690c1ca2024-11-28 18:06:50 +0900586 config: &VirtualMachineConfig,
David Brazdil209074a2023-01-12 16:44:51 +0000587 ) -> binder::Result<(VmContext, Cid, PathBuf)> {
David Brazdil8cf8f482022-11-23 14:21:26 +0000588 const NUM_ATTEMPTS: usize = 5;
589
590 for _ in 0..NUM_ATTEMPTS {
Charisee96113f32023-01-26 09:00:42 +0000591 let vm_context = GLOBAL_SERVICE.allocateGlobalVmContext(requester_debug_pid)?;
David Brazdild4f51a52023-01-11 14:09:27 +0000592 let cid = vm_context.getCid()? as Cid;
593 let temp_dir: PathBuf = vm_context.getTemporaryDirectory()?.into();
Jiyong Park690c1ca2024-11-28 18:06:50 +0900594
595 // We don't need to start the VM service for custom VMs.
596 if !requires_vm_service(config) {
597 return Ok((VmContext::new(vm_context, None), cid, temp_dir));
598 }
599
David Brazdil8cf8f482022-11-23 14:21:26 +0000600 let service = VirtualMachineService::new_binder(self.state.clone(), cid).as_binder();
601
602 // Start VM service listening for connections from the new CID on port=CID.
David Brazdil8cf8f482022-11-23 14:21:26 +0000603 let port = cid;
David Brazdil3238da42022-11-18 10:04:51 +0000604 match RpcServer::new_vsock(service, cid, port) {
Devin Moore068e6742024-10-28 18:16:25 +0000605 Ok((vm_server, _)) => {
David Brazdil8cf8f482022-11-23 14:21:26 +0000606 vm_server.start();
Jiyong Park690c1ca2024-11-28 18:06:50 +0900607 return Ok((VmContext::new(vm_context, Some(vm_server)), cid, temp_dir));
David Brazdil8cf8f482022-11-23 14:21:26 +0000608 }
609 Err(err) => {
610 warn!("Could not start RpcServer on port {}: {}", port, err);
611 }
612 }
613 }
Jiyong Park2227eaa2023-08-04 11:59:18 +0900614 Err(anyhow!("Too many attempts to create VM context failed"))
615 .or_service_specific_exception(-1)
David Brazdil8cf8f482022-11-23 14:21:26 +0000616 }
617
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000618 fn create_vm_internal(
619 &self,
620 config: &VirtualMachineConfig,
Jiyong Parke6fb1672023-06-26 16:45:55 +0900621 console_out_fd: Option<&ParcelFileDescriptor>,
622 console_in_fd: Option<&ParcelFileDescriptor>,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000623 log_fd: Option<&ParcelFileDescriptor>,
624 is_protected: &mut bool,
Elie Kheirallah5c807a22024-09-23 20:40:42 +0000625 dump_dt_fd: Option<&ParcelFileDescriptor>,
Devin Moore407df8f2024-08-27 19:39:16 +0000626 ) -> binder::Result<Strong<dyn IVirtualMachine::IVirtualMachine>> {
David Brazdil209074a2023-01-12 16:44:51 +0000627 let requester_uid = get_calling_uid();
628 let requester_debug_pid = get_calling_pid();
629
Frederick Mayle50c2b6a2025-02-11 18:26:04 -0800630 let calling_partition = find_partition(CALLING_EXE_PATH.as_deref())?;
631
Nikita Ioffe631717e2023-09-05 13:38:07 +0100632 check_config_features(config)?;
633
Inseob Kimecde8c02024-09-03 13:11:08 +0900634 if cfg!(early) {
635 check_config_allowed_for_early_vms(config)?;
636 }
637
Nikita Ioffeb1416122024-10-22 12:18:49 +0000638 let caller_secontext = getprevcon().or_service_specific_exception(-1)?;
639 info!("callers secontext: {}", caller_secontext);
640
David Brazdil209074a2023-01-12 16:44:51 +0000641 // Allocating VM context checks the MANAGE_VIRTUAL_MACHINE permission.
Inseob Kimecde8c02024-09-03 13:11:08 +0900642 let (vm_context, cid, temporary_directory) = if cfg!(early) {
Frederick Mayle50c2b6a2025-02-11 18:26:04 -0800643 self.create_early_vm_context(config, CALLING_EXE_PATH.as_deref(), calling_partition)?
Inseob Kimecde8c02024-09-03 13:11:08 +0900644 } else {
Jiyong Park690c1ca2024-11-28 18:06:50 +0900645 self.create_vm_context(requester_debug_pid, config)?
Inseob Kimecde8c02024-09-03 13:11:08 +0900646 };
Inseob Kim1119d702022-05-02 18:01:58 +0900647
Alan Stokesfda70842023-12-20 17:50:14 +0000648 if is_custom_config(config) {
Alan Stokes7bc146c2022-10-20 17:10:32 +0100649 check_use_custom_virtual_machine()?;
Inseob Kim1119d702022-05-02 18:01:58 +0900650 }
651
Nikita Ioffe5776f082023-02-10 21:38:26 +0000652 let gdb_port = extract_gdb_port(config);
653
654 // Additional permission checks if caller request gdb.
655 if gdb_port.is_some() {
656 check_gdb_allowed(config)?;
657 }
658
Frederick Mayle196ca2b2024-12-18 15:27:43 -0800659 let instance_id = extract_instance_id(config);
Jaewan Kimf43372b2024-12-13 18:33:58 +0900660 let mut device_tree_overlays = vec![];
Frederick Mayle196ca2b2024-12-18 15:27:43 -0800661 if let Some(dt_overlay) =
662 maybe_create_reference_dt_overlay(config, &instance_id, &temporary_directory)?
663 {
Jaewan Kimf43372b2024-12-13 18:33:58 +0900664 device_tree_overlays.push(dt_overlay);
665 }
666 if let Some(dtbo) = get_dtbo(config) {
667 let dtbo = File::from(
668 dtbo.as_ref()
669 .try_clone()
670 .context("Failed to create VM DTBO from ParcelFileDescriptor")
671 .or_binder_exception(ExceptionCode::BAD_PARCELABLE)?,
672 );
673 device_tree_overlays.push(dtbo);
674 }
Seungjae Yooec3bc522023-11-09 10:14:30 +0900675
Jaewan Kimf3143242024-03-15 06:56:31 +0000676 let debug_config = DebugConfig::new(config);
Nikita Ioffe2cb75cf2024-06-04 16:43:56 +0000677 let ramdump = if !uses_gki_kernel(config) && debug_config.is_ramdump_needed() {
Jiyong Parked180932023-02-24 19:55:41 +0900678 Some(prepare_ramdump_file(&temporary_directory)?)
679 } else {
680 None
681 };
682
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000683 let state = &mut *self.state.lock().unwrap();
Jiyong Parke6fb1672023-06-26 16:45:55 +0900684 let console_out_fd =
Pierre-Clément Tosifc523c52024-08-20 10:34:06 +0100685 clone_or_prepare_logger_fd(console_out_fd, format!("Console({})", cid))?;
Jiyong Parke6fb1672023-06-26 16:45:55 +0900686 let console_in_fd = console_in_fd.map(clone_file).transpose()?;
Pierre-Clément Tosifc523c52024-08-20 10:34:06 +0100687 let log_fd = clone_or_prepare_logger_fd(log_fd, format!("Log({})", cid))?;
Pierre-Clément Tosi9515d0f2024-04-15 15:58:07 +0100688 let dump_dt_fd = if let Some(fd) = dump_dt_fd {
689 Some(clone_file(fd)?)
690 } else if debug_config.dump_device_tree {
691 Some(prepare_dump_dt_file(&temporary_directory)?)
692 } else {
693 None
694 };
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000695
696 // Counter to generate unique IDs for temporary image files.
697 let mut next_temporary_image_id = 0;
698 // Files which are referred to from composite images. These must be mapped to the crosvm
699 // child process, and not closed before it is started.
700 let mut indirect_files = vec![];
701
Alan Stokes7bc146c2022-10-20 17:10:32 +0100702 let (is_app_config, config) = match config {
703 VirtualMachineConfig::RawConfig(config) => (false, BorrowedOrOwned::Borrowed(config)),
704 VirtualMachineConfig::AppConfig(config) => {
Jiyong Park2227eaa2023-08-04 11:59:18 +0900705 let config = load_app_config(config, &debug_config, &temporary_directory)
706 .or_service_specific_exception_with(-1, |e| {
Jaewan Kim61f86142023-03-28 15:12:52 +0900707 *is_protected = config.protectedVm;
708 let message = format!("Failed to load app config: {:?}", e);
709 error!("{}", message);
Jiyong Park2227eaa2023-08-04 11:59:18 +0900710 message
Jaewan Kim61f86142023-03-28 15:12:52 +0900711 })?;
Alan Stokes7bc146c2022-10-20 17:10:32 +0100712 (true, BorrowedOrOwned::Owned(config))
713 }
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000714 };
715 let config = config.as_ref();
716 *is_protected = config.protectedVm;
717
Nikita Ioffe9951e4b2024-11-14 17:30:50 +0000718 if !config.teeServices.is_empty() {
719 check_tee_service_permission(&caller_secontext, &config.teeServices)
720 .with_log()
721 .or_binder_exception(ExceptionCode::SECURITY)?;
722 }
Nikita Ioffe13748d22024-10-23 15:10:39 +0000723
Jiyong Park3051ffe2024-11-26 14:41:58 +0900724 let kernel = maybe_clone_file(&config.kernel)?;
725 let initrd = maybe_clone_file(&config.initrd)?;
726
727 if config.protectedVm {
728 // Fail fast with a meaningful error message in case device doesn't support pVMs.
729 check_protected_vm_is_supported()?;
730
731 // In a protected VM, we require custom kernels to come from a trusted source
732 // (b/237054515).
Frederick Mayle50c2b6a2025-02-11 18:26:04 -0800733 check_label_for_kernel_files(&kernel, &initrd, calling_partition)
734 .or_service_specific_exception(-1)?;
Jiyong Park3051ffe2024-11-26 14:41:58 +0900735
736 // Check if partition images are labeled incorrectly. This is to prevent random images
737 // which are not protected by the Android Verified Boot (e.g. bits downloaded by apps)
738 // from being loaded in a pVM. This applies to everything but the instance image in the
739 // raw config, and everything but the non-executable, generated partitions in the app
740 // config.
741 config
742 .disks
743 .iter()
Frederick Mayle9539fb52025-02-13 13:08:15 -0800744 .flat_map(|disk| disk.image.as_ref())
745 .try_for_each(|image| check_label_for_file(image, "disk image", calling_partition))
746 .or_service_specific_exception(-1)?;
747 config
748 .disks
749 .iter()
Jiyong Park3051ffe2024-11-26 14:41:58 +0900750 .flat_map(|disk| disk.partitions.iter())
751 .filter(|partition| {
752 if is_app_config {
753 !is_safe_app_partition(&partition.label)
754 } else {
755 !is_safe_raw_partition(&partition.label)
756 }
757 })
Frederick Mayle50c2b6a2025-02-11 18:26:04 -0800758 .try_for_each(|partition| check_label_for_partition(partition, calling_partition))
Jiyong Park3051ffe2024-11-26 14:41:58 +0900759 .or_service_specific_exception(-1)?;
760 }
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000761
Inseob Kimff48a7c2024-02-26 22:07:21 +0900762 // Check if files for payloads and bases are NOT coming from /vendor and /odm, as they may
763 // have unstable interfaces.
764 // TODO(b/316431494): remove once Treble interfaces are stabilized.
Frederick Mayle50c2b6a2025-02-11 18:26:04 -0800765 check_partitions_for_files(config, calling_partition).or_service_specific_exception(-1)?;
Inseob Kimff48a7c2024-02-26 22:07:21 +0900766
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000767 let zero_filler_path = temporary_directory.join("zero.img");
Jiyong Park2227eaa2023-08-04 11:59:18 +0900768 write_zero_filler(&zero_filler_path)
769 .context("Failed to make composite image")
770 .with_log()
771 .or_service_specific_exception(-1)?;
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000772
773 // Assemble disk images if needed.
774 let disks = config
775 .disks
776 .iter()
777 .map(|disk| {
778 assemble_disk_image(
779 disk,
780 &zero_filler_path,
781 &temporary_directory,
782 &mut next_temporary_image_id,
783 &mut indirect_files,
784 )
785 })
786 .collect::<Result<Vec<DiskFile>, _>>()?;
787
Akilesh Kailash05515dc2024-10-22 21:42:52 -0700788 let shared_paths = assemble_shared_paths(&config.sharedPaths, &temporary_directory)?;
789
Jaewan Kimf43372b2024-12-13 18:33:58 +0900790 let (vfio_devices, dtbo) = match &config.devices {
791 AssignedDevices::Devices(devices) if !devices.is_empty() => {
792 let mut set = HashSet::new();
793 for device in devices.iter() {
794 let path = canonicalize(device)
795 .with_context(|| format!("can't canonicalize {device}"))
796 .or_service_specific_exception(-1)?;
797 if !set.insert(path) {
798 return Err(anyhow!("duplicated device {device}"))
799 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT);
800 }
Inseob Kim6ef80972023-07-20 17:23:36 +0900801 }
Jaewan Kimf43372b2024-12-13 18:33:58 +0900802 let devices = GLOBAL_SERVICE.bindDevicesToVfioDriver(devices)?;
803 let dtbo_file = File::from(
804 GLOBAL_SERVICE
805 .getDtboFile()?
806 .as_ref()
807 .try_clone()
808 .context("Failed to create VM DTBO from ParcelFileDescriptor")
809 .or_binder_exception(ExceptionCode::BAD_PARCELABLE)?,
810 );
811 (devices, Some(dtbo_file))
Inseob Kim6ef80972023-07-20 17:23:36 +0900812 }
Jaewan Kimf43372b2024-12-13 18:33:58 +0900813 _ => (vec![], None),
Inseob Kim7307a892023-09-14 13:37:58 +0900814 };
Jeongik Cha798401c2024-04-11 21:54:49 +0900815 let display_config = if cfg!(paravirtualized_devices) {
816 config
817 .displayConfig
818 .as_ref()
819 .map(DisplayConfig::new)
820 .transpose()
821 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT)?
822 } else {
823 None
824 };
Jason Macnakea7b0fa2024-05-08 17:02:44 -0700825 let gpu_config = if cfg!(paravirtualized_devices) {
826 config
827 .gpuConfig
828 .as_ref()
829 .map(GpuConfig::new)
830 .transpose()
831 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT)?
832 } else {
833 None
834 };
Jeongik Cha1df1c032024-04-03 16:03:12 +0900835
Jeongik Chac181be72024-03-27 00:18:30 +0900836 let input_device_options = if cfg!(paravirtualized_devices) {
837 config
838 .inputDevices
839 .iter()
840 .map(to_input_device_option_from)
841 .collect::<Result<Vec<InputDeviceOption>, _>>()
842 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT)?
843 } else {
844 vec![]
845 };
846
Seungjae Yoo13af0b62024-05-20 14:15:13 +0900847 // Create TAP network interface if the VM supports network.
Seungjae Yoo986d7a42024-05-28 14:06:58 +0900848 let tap = if cfg!(network) && config.networkSupported {
Seungjae Yoo13af0b62024-05-20 14:15:13 +0900849 if *is_protected {
850 return Err(anyhow!("Network feature is not supported for pVM yet"))
851 .with_log()
852 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION)?;
853 }
Seungjae Yoo986d7a42024-05-28 14:06:58 +0900854 Some(File::from(
855 GLOBAL_SERVICE
856 .createTapInterface(&get_this_pid().to_string())?
857 .as_ref()
858 .try_clone()
859 .context("Failed to get TAP interface from ParcelFileDescriptor")
860 .or_binder_exception(ExceptionCode::BAD_PARCELABLE)?,
861 ))
Seungjae Yoo13af0b62024-05-20 14:15:13 +0900862 } else {
863 None
864 };
Mu-Le Leeb2d5a312024-06-05 10:52:47 +0800865
866 let audio_config = if cfg!(paravirtualized_devices) {
867 config.audioConfig.as_ref().map(AudioConfig::new)
868 } else {
869 None
870 };
Seungjae Yoo13af0b62024-05-20 14:15:13 +0900871
Elie Kheirallah29d72912024-08-07 20:17:26 +0000872 let usb_config = config
873 .usbConfig
874 .as_ref()
875 .map(UsbConfig::new)
876 .unwrap_or(Ok(UsbConfig { controller: false }))
877 .or_binder_exception(ExceptionCode::BAD_PARCELABLE)?;
878
Pierre-Clément Tosi3d70d462025-01-07 16:03:24 +0000879 let detect_hangup = is_app_config && gdb_port.is_none();
880
Frederick Mayle31cc5b22024-12-19 14:42:43 -0800881 let custom_memory_backing_files = config
882 .customMemoryBackingFiles
883 .iter()
884 .map(|memory_backing_file| {
885 Ok((
886 clone_file(
887 memory_backing_file
888 .file
889 .as_ref()
890 .context("missing CustomMemoryBackingFile FD")
891 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT)?,
892 )?
893 .into(),
894 memory_backing_file.rangeStart as u64,
895 memory_backing_file.size as u64,
896 ))
897 })
898 .collect::<binder::Result<_>>()?;
899
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000900 // Actually start the VM.
901 let crosvm_config = CrosvmConfig {
902 cid,
Seungjae Yoo62085c02022-08-12 04:44:52 +0000903 name: config.name.clone(),
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000904 bootloader: maybe_clone_file(&config.bootloader)?,
Alan Stokes185fe112023-01-10 16:20:55 +0000905 kernel,
906 initrd,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000907 disks,
Akilesh Kailash05515dc2024-10-22 21:42:52 -0700908 shared_paths,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000909 params: config.params.to_owned(),
910 protected: *is_protected,
Jaewan Kim61f86142023-03-28 15:12:52 +0900911 debug_config,
Frederick Mayle68d06e72024-07-12 17:18:11 -0700912 memory_mib: config
913 .memoryMib
914 .try_into()
915 .ok()
916 .and_then(NonZeroU32::new)
917 .unwrap_or(NonZeroU32::new(256).unwrap()),
Frederick Mayle384f5b52024-12-06 16:23:23 -0800918 swiotlb_mib: config.swiotlbMib.try_into().ok().and_then(NonZeroU32::new),
Elie Kheirallahb4b2f242025-01-23 03:38:07 +0000919 cpus: config.cpuOptions.clone(),
Jiyong Parke6fb1672023-06-26 16:45:55 +0900920 console_out_fd,
921 console_in_fd,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000922 log_fd,
Jiyong Parked180932023-02-24 19:55:41 +0900923 ramdump,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000924 indirect_files,
925 platform_version: parse_platform_version_req(&config.platformVersion)?,
Pierre-Clément Tosi3d70d462025-01-07 16:03:24 +0000926 detect_hangup,
Nikita Ioffe5776f082023-02-10 21:38:26 +0000927 gdb_port,
Inseob Kim7307a892023-09-14 13:37:58 +0900928 vfio_devices,
David Brazdil2dfefd12023-11-17 14:07:36 +0000929 dtbo,
Jaewan Kimf43372b2024-12-13 18:33:58 +0900930 device_tree_overlays,
Jeongik Cha1df1c032024-04-03 16:03:12 +0900931 display_config,
Jeongik Chac181be72024-03-27 00:18:30 +0900932 input_device_options,
Vincent Donnefort538a2c62024-03-20 16:01:10 +0000933 hugepages: config.hugePages,
Seungjae Yoo986d7a42024-05-28 14:06:58 +0900934 tap,
Yi-Yo Chiang8dd32552024-05-22 19:38:16 +0800935 console_input_device: config.consoleInputDevice.clone(),
David Dai23cff712024-06-13 19:23:45 +0000936 boost_uclamp: config.boostUclamp,
Jason Macnakea7b0fa2024-05-08 17:02:44 -0700937 gpu_config,
Mu-Le Leeb2d5a312024-06-05 10:52:47 +0800938 audio_config,
Frederick Maylecc4e2d72024-12-06 16:54:40 -0800939 balloon: config.balloon,
Elie Kheirallah29d72912024-08-07 20:17:26 +0000940 usb_config,
Elie Kheirallah5c807a22024-09-23 20:40:42 +0000941 dump_dt_fd,
Frederick Mayle196ca2b2024-12-18 15:27:43 -0800942 enable_hypervisor_specific_auth_method: config.enableHypervisorSpecificAuthMethod,
943 instance_id,
Frederick Mayle31cc5b22024-12-19 14:42:43 -0800944 custom_memory_backing_files,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000945 };
946 let instance = Arc::new(
David Brazdil528e0472022-10-10 15:06:02 +0100947 VmInstance::new(
948 crosvm_config,
949 temporary_directory,
950 requester_uid,
951 requester_debug_pid,
952 vm_context,
953 )
Jiyong Park2227eaa2023-08-04 11:59:18 +0900954 .with_context(|| format!("Failed to create VM with config {:?}", config))
955 .with_log()
956 .or_service_specific_exception(-1)?,
Shikha Panwar061aa2c2022-04-05 12:52:56 +0000957 );
958 state.add_vm(Arc::downgrade(&instance));
959 Ok(VirtualMachine::create(instance))
960 }
Jiyong Park8611a6c2021-07-09 18:17:44 +0900961}
962
Alan Stokesfda70842023-12-20 17:50:14 +0000963/// Returns whether a VM config represents a "custom" virtual machine, which requires the
964/// USE_CUSTOM_VIRTUAL_MACHINE.
965fn is_custom_config(config: &VirtualMachineConfig) -> bool {
966 match config {
967 // Any raw (non-Microdroid) VM is considered custom.
968 VirtualMachineConfig::RawConfig(_) => true,
969 VirtualMachineConfig::AppConfig(config) => {
970 // Some features are reserved for platform apps only, even when using
971 // VirtualMachineAppConfig. Almost all of these features are grouped in the
972 // CustomConfig struct:
973 // - controlling CPUs;
974 // - gdbPort is set, meaning that crosvm will start a gdb server;
975 // - using anything other than the default kernel;
976 // - specifying devices to be assigned.
977 if config.customConfig.is_some() {
978 true
979 } else {
980 // Additional custom features not included in CustomConfig:
981 // - specifying a config file;
Alan Stokes736f6822024-02-16 16:08:00 +0000982 // - specifying extra APKs;
983 // - specifying an OS other than Microdroid.
Inseob Kim89b24592024-02-23 18:59:43 +0900984 (match &config.payload {
Alan Stokesfda70842023-12-20 17:50:14 +0000985 Payload::ConfigPath(_) => true,
Inseob Kim89b24592024-02-23 18:59:43 +0900986 Payload::PayloadConfig(payload_config) => !payload_config.extraApks.is_empty(),
987 }) || config.osName != MICRODROID_OS_NAME
Alan Stokesfda70842023-12-20 17:50:14 +0000988 }
989 }
990 }
991}
992
Jiyong Park690c1ca2024-11-28 18:06:50 +0900993/// Returns whether a VM config requires VirtualMachineService running on the host. Only Microdroid
994/// VM (i.e. AppConfig) requires it. However, a few Microdroid tests use RawConfig for Microdroid
995/// VM. To handle the exceptional case, we use name as a second criteria; if the name is
996/// "microdroid" we run VirtualMachineService
997fn requires_vm_service(config: &VirtualMachineConfig) -> bool {
998 match config {
999 VirtualMachineConfig::AppConfig(_) => true,
1000 VirtualMachineConfig::RawConfig(config) => config.name == "microdroid",
1001 }
1002}
1003
Seungjae Yoo14e60182024-02-21 13:28:31 +09001004fn extract_vendor_hashtree_digest(config: &VirtualMachineConfig) -> Result<Option<Vec<u8>>> {
1005 let VirtualMachineConfig::AppConfig(config) = config else {
1006 return Ok(None);
1007 };
1008 let Some(custom_config) = &config.customConfig else {
1009 return Ok(None);
1010 };
1011 let Some(file) = custom_config.vendorImage.as_ref() else {
1012 return Ok(None);
1013 };
1014
1015 let file = clone_file(file)?;
1016 let size =
1017 file.metadata().context("Failed to get metadata from microdroid vendor image")?.len();
1018 let vbmeta = VbMetaImage::verify_reader_region(&file, 0, size)
1019 .context("Failed to get vbmeta from microdroid-vendor.img")?;
1020
1021 for descriptor in vbmeta.descriptors()?.iter() {
1022 if let vbmeta::Descriptor::Hashtree(_) = descriptor {
1023 let root_digest = hex::encode(descriptor.to_hashtree()?.root_digest());
1024 return Ok(Some(root_digest.as_bytes().to_vec()));
1025 }
1026 }
1027 Err(anyhow!("No hashtree digest is extracted from microdroid vendor image"))
1028}
1029
Jaewan Kimf43372b2024-12-13 18:33:58 +09001030fn maybe_create_reference_dt_overlay(
Nikita Ioffeb2c6f3a2024-06-06 12:51:53 +00001031 config: &VirtualMachineConfig,
Frederick Mayle196ca2b2024-12-18 15:27:43 -08001032 instance_id: &[u8; 64],
Nikita Ioffeb2c6f3a2024-06-06 12:51:53 +00001033 temporary_directory: &Path,
1034) -> binder::Result<Option<File>> {
1035 // Currently, VirtMgr adds the host copy of reference DT & untrusted properties
1036 // (e.g. instance-id)
1037 let host_ref_dt = Path::new(VM_REFERENCE_DT_ON_HOST_PATH);
1038 let host_ref_dt = if host_ref_dt.exists()
1039 && read_dir(host_ref_dt).or_service_specific_exception(-1)?.next().is_some()
1040 {
1041 Some(host_ref_dt)
1042 } else {
1043 warn!("VM reference DT doesn't exist in host DT");
1044 None
1045 };
1046
1047 let vendor_hashtree_digest = extract_vendor_hashtree_digest(config)
1048 .context("Failed to extract vendor hashtree digest")
1049 .or_service_specific_exception(-1)?;
1050
Matt Gilbrideaade4272024-12-05 13:52:42 +00001051 let mut trusted_props = if let Some(ref vendor_hashtree_digest) = vendor_hashtree_digest {
Nikita Ioffeb2c6f3a2024-06-06 12:51:53 +00001052 info!(
1053 "Passing vendor hashtree digest to pvmfw. This will be rejected if it doesn't \
1054 match the trusted digest in the pvmfw config, causing the VM to fail to start."
1055 );
Alan Stokesf46a17c2025-01-05 15:50:18 +00001056 vec![(c"vendor_hashtree_descriptor_root_digest", vendor_hashtree_digest.as_slice())]
Nikita Ioffeb2c6f3a2024-06-06 12:51:53 +00001057 } else {
Matt Gilbrideaade4272024-12-05 13:52:42 +00001058 vec![]
Nikita Ioffeb2c6f3a2024-06-06 12:51:53 +00001059 };
1060
Matt Gilbrideaade4272024-12-05 13:52:42 +00001061 let key_material;
Nikita Ioffeb2c6f3a2024-06-06 12:51:53 +00001062 let mut untrusted_props = Vec::with_capacity(2);
1063 if cfg!(llpvm_changes) {
Alan Stokesf46a17c2025-01-05 15:50:18 +00001064 untrusted_props.push((c"instance-id", &instance_id[..]));
Nikita Ioffeb2c6f3a2024-06-06 12:51:53 +00001065 let want_updatable = extract_want_updatable(config);
1066 if want_updatable && is_secretkeeper_supported() {
1067 // Let guest know that it can defer rollback protection to Secretkeeper by setting
1068 // an empty property in untrusted node in DT. This enables Updatable VMs.
Alan Stokesf46a17c2025-01-05 15:50:18 +00001069 untrusted_props.push((c"defer-rollback-protection", &[]));
Matt Gilbrideaade4272024-12-05 13:52:42 +00001070 let sk: Strong<dyn ISecretkeeper> =
1071 binder::wait_for_interface(SECRETKEEPER_IDENTIFIER)?;
1072 if sk.getInterfaceVersion()? >= 2 {
1073 let PublicKey { keyMaterial } = sk.getSecretkeeperIdentity()?;
1074 key_material = keyMaterial;
Alan Stokesf46a17c2025-01-05 15:50:18 +00001075 trusted_props.push((c"secretkeeper_public_key", key_material.as_slice()));
Matt Gilbrideaade4272024-12-05 13:52:42 +00001076 }
Nikita Ioffeb2c6f3a2024-06-06 12:51:53 +00001077 }
1078 }
1079
1080 let device_tree_overlay = if host_ref_dt.is_some()
1081 || !untrusted_props.is_empty()
1082 || !trusted_props.is_empty()
1083 {
1084 let dt_output = temporary_directory.join(VM_DT_OVERLAY_PATH);
1085 let mut data = [0_u8; VM_DT_OVERLAY_MAX_SIZE];
1086 let fdt =
1087 create_device_tree_overlay(&mut data, host_ref_dt, &untrusted_props, &trusted_props)
1088 .map_err(|e| anyhow!("Failed to create DT overlay, {e:?}"))
1089 .or_service_specific_exception(-1)?;
1090 fs::write(&dt_output, fdt.as_slice()).or_service_specific_exception(-1)?;
1091 Some(File::open(dt_output).or_service_specific_exception(-1)?)
1092 } else {
1093 None
1094 };
1095 Ok(device_tree_overlay)
1096}
1097
Jaewan Kimf43372b2024-12-13 18:33:58 +09001098fn get_dtbo(config: &VirtualMachineConfig) -> Option<&ParcelFileDescriptor> {
1099 let VirtualMachineConfig::RawConfig(config) = config else {
1100 return None;
1101 };
1102 match &config.devices {
1103 AssignedDevices::Dtbo(dtbo) => dtbo.as_ref(),
1104 _ => None,
1105 }
1106}
1107
Andrew Walbranfbb39d22021-07-28 17:01:25 +00001108fn write_zero_filler(zero_filler_path: &Path) -> Result<()> {
Jooyung Han95884632021-07-06 22:27:54 +09001109 let file = OpenOptions::new()
1110 .create_new(true)
1111 .read(true)
1112 .write(true)
1113 .open(zero_filler_path)
1114 .with_context(|| "Failed to create zero.img")?;
1115 file.set_len(ZERO_FILLER_SIZE)?;
Andrew Walbranfbb39d22021-07-28 17:01:25 +00001116 Ok(())
Jooyung Han95884632021-07-06 22:27:54 +09001117}
1118
David Brazdilf50c7a62023-04-19 14:22:42 +00001119fn format_as_android_vm_instance(part: &mut dyn Write) -> std::io::Result<()> {
1120 part.write_all(ANDROID_VM_INSTANCE_MAGIC.as_bytes())?;
1121 part.write_all(&ANDROID_VM_INSTANCE_VERSION.to_le_bytes())?;
1122 part.flush()
1123}
1124
1125fn format_as_encryptedstore(part: &mut dyn Write) -> std::io::Result<()> {
1126 part.write_all(UNFORMATTED_STORAGE_MAGIC.as_bytes())?;
1127 part.flush()
1128}
1129
1130fn round_up(input: u64, granularity: u64) -> u64 {
1131 if granularity == 0 {
1132 return input;
1133 }
1134 // If the input is absurdly large we round down instead of up; it's going to fail anyway.
1135 let result = input.checked_add(granularity - 1).unwrap_or(input);
1136 (result / granularity) * granularity
1137}
1138
Jeongik Chac181be72024-03-27 00:18:30 +09001139fn to_input_device_option_from(input_device: &InputDevice) -> Result<InputDeviceOption> {
1140 Ok(match input_device {
1141 InputDevice::SingleTouch(single_touch) => InputDeviceOption::SingleTouch {
1142 file: clone_file(single_touch.pfd.as_ref().ok_or(anyhow!("pfd should have value"))?)?,
1143 height: u32::try_from(single_touch.height)?,
1144 width: u32::try_from(single_touch.width)?,
1145 name: if !single_touch.name.is_empty() {
1146 Some(single_touch.name.clone())
1147 } else {
1148 None
1149 },
1150 },
1151 InputDevice::EvDev(evdev) => InputDeviceOption::EvDev(clone_file(
1152 evdev.pfd.as_ref().ok_or(anyhow!("pfd should have value"))?,
1153 )?),
Jeongik Cha985b6402024-04-15 18:13:00 +09001154 InputDevice::Keyboard(keyboard) => InputDeviceOption::Keyboard(clone_file(
1155 keyboard.pfd.as_ref().ok_or(anyhow!("pfd should have value"))?,
1156 )?),
Jeongik Cha343894e2024-05-17 20:39:31 +09001157 InputDevice::Mouse(mouse) => InputDeviceOption::Mouse(clone_file(
1158 mouse.pfd.as_ref().ok_or(anyhow!("pfd should have value"))?,
1159 )?),
Jiyong Park6c1b9f02024-07-05 16:21:10 +09001160 InputDevice::Switches(switches) => InputDeviceOption::Switches(clone_file(
1161 switches.pfd.as_ref().ok_or(anyhow!("pfd should have value"))?,
1162 )?),
Jeongik Cha112a2682024-07-09 12:28:45 +09001163 InputDevice::Trackpad(trackpad) => InputDeviceOption::MultiTouchTrackpad {
1164 file: clone_file(trackpad.pfd.as_ref().ok_or(anyhow!("pfd should have value"))?)?,
1165 height: u32::try_from(trackpad.height)?,
1166 width: u32::try_from(trackpad.width)?,
1167 name: if !trackpad.name.is_empty() { Some(trackpad.name.clone()) } else { None },
1168 },
Jeongik Cha10494912024-07-16 11:19:50 +09001169 InputDevice::MultiTouch(multi_touch) => InputDeviceOption::MultiTouch {
1170 file: clone_file(multi_touch.pfd.as_ref().ok_or(anyhow!("pfd should have value"))?)?,
1171 height: u32::try_from(multi_touch.height)?,
1172 width: u32::try_from(multi_touch.width)?,
1173 name: if !multi_touch.name.is_empty() { Some(multi_touch.name.clone()) } else { None },
1174 },
Jeongik Chac181be72024-03-27 00:18:30 +09001175 })
1176}
Akilesh Kailash05515dc2024-10-22 21:42:52 -07001177
1178fn assemble_shared_paths(
1179 shared_paths: &[SharedPath],
1180 temporary_directory: &Path,
1181) -> Result<Vec<SharedPathConfig>, Status> {
1182 if shared_paths.is_empty() {
1183 return Ok(Vec::new()); // Return an empty vector if shared_paths is empty
1184 }
1185
1186 shared_paths
1187 .iter()
1188 .map(|path| {
1189 Ok(SharedPathConfig {
1190 path: path.sharedPath.clone(),
1191 host_uid: path.hostUid,
1192 host_gid: path.hostGid,
1193 guest_uid: path.guestUid,
1194 guest_gid: path.guestGid,
1195 mask: path.mask,
1196 tag: path.tag.clone(),
Akilesh Kailashc9aa0682024-11-25 10:27:24 -08001197 socket_path: temporary_directory
1198 .join(&path.socketPath)
1199 .to_string_lossy()
1200 .to_string(),
1201 socket_fd: maybe_clone_file(&path.socketFd)?,
1202 app_domain: path.appDomain,
Akilesh Kailash05515dc2024-10-22 21:42:52 -07001203 })
1204 })
1205 .collect()
1206}
1207
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001208/// Given the configuration for a disk image, assembles the `DiskFile` to pass to crosvm.
1209///
1210/// This may involve assembling a composite disk from a set of partition images.
1211fn assemble_disk_image(
1212 disk: &DiskImage,
Jooyung Han95884632021-07-06 22:27:54 +09001213 zero_filler_path: &Path,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001214 temporary_directory: &Path,
1215 next_temporary_image_id: &mut u64,
1216 indirect_files: &mut Vec<File>,
Andrew Walbran806f1542021-06-10 14:07:12 +00001217) -> Result<DiskFile, Status> {
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001218 let image = if !disk.partitions.is_empty() {
1219 if disk.image.is_some() {
1220 warn!("DiskImage {:?} contains both image and partitions.", disk);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001221 return Err(anyhow!("DiskImage contains both image and partitions"))
1222 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT);
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001223 }
1224
Andrew Walbran3eca16c2021-06-14 11:15:14 +00001225 let composite_image_filenames =
1226 make_composite_image_filenames(temporary_directory, next_temporary_image_id);
1227 let (image, partition_files) = make_composite_image(
1228 &disk.partitions,
Jooyung Han95884632021-07-06 22:27:54 +09001229 zero_filler_path,
Andrew Walbran3eca16c2021-06-14 11:15:14 +00001230 &composite_image_filenames.composite,
1231 &composite_image_filenames.header,
1232 &composite_image_filenames.footer,
1233 )
Jiyong Park2227eaa2023-08-04 11:59:18 +09001234 .with_context(|| format!("Failed to make composite disk image with config {:?}", disk))
1235 .with_log()
1236 .or_service_specific_exception(-1)?;
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001237
1238 // Pass the file descriptors for the various partition files to crosvm when it
1239 // is run.
1240 indirect_files.extend(partition_files);
1241
1242 image
1243 } else if let Some(image) = &disk.image {
1244 clone_file(image)?
1245 } else {
1246 warn!("DiskImage {:?} didn't contain image or partitions.", disk);
Jiyong Park2227eaa2023-08-04 11:59:18 +09001247 return Err(anyhow!("DiskImage didn't contain image or partitions."))
1248 .or_binder_exception(ExceptionCode::ILLEGAL_ARGUMENT);
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001249 };
1250
1251 Ok(DiskFile { image, writable: disk.writable })
1252}
1253
Nikita Ioffeaa6858c2023-07-04 01:37:41 +01001254fn append_kernel_param(param: &str, vm_config: &mut VirtualMachineRawConfig) {
1255 if let Some(ref mut params) = vm_config.params {
1256 params.push(' ');
1257 params.push_str(param)
1258 } else {
1259 vm_config.params = Some(param.to_owned())
1260 }
1261}
1262
Inseob Kim46257382024-01-03 15:41:22 +09001263fn extract_os_name_from_config_path(config: &Path) -> Option<String> {
1264 if config.extension()?.to_str()? != "json" {
1265 return None;
Inseob Kim172f9eb2023-11-06 17:02:08 +09001266 }
Inseob Kim46257382024-01-03 15:41:22 +09001267
1268 Some(config.with_extension("").file_name()?.to_str()?.to_owned())
1269}
1270
1271fn extract_os_names_from_configs(config_glob_pattern: &str) -> Result<HashSet<String>> {
1272 let configs = glob(config_glob_pattern)?.collect::<Result<Vec<_>, _>>()?;
1273 let os_names =
1274 configs.iter().filter_map(|x| extract_os_name_from_config_path(x)).collect::<HashSet<_>>();
1275
1276 Ok(os_names)
1277}
1278
1279fn get_supported_os_names() -> Result<HashSet<String>> {
1280 if !cfg!(vendor_modules) {
1281 return Ok(iter::once(MICRODROID_OS_NAME.to_owned()).collect());
1282 }
1283
1284 extract_os_names_from_configs("/apex/com.android.virt/etc/microdroid*.json")
1285}
1286
1287fn is_valid_os(os_name: &str) -> bool {
1288 SUPPORTED_OS_NAMES.contains(os_name)
Inseob Kim172f9eb2023-11-06 17:02:08 +09001289}
1290
Nikita Ioffe2cb75cf2024-06-04 16:43:56 +00001291fn uses_gki_kernel(config: &VirtualMachineConfig) -> bool {
1292 if !cfg!(vendor_modules) {
1293 return false;
1294 }
1295 match config {
1296 VirtualMachineConfig::RawConfig(_) => false,
1297 VirtualMachineConfig::AppConfig(config) => config.osName.starts_with("microdroid_gki-"),
1298 }
1299}
1300
Jooyung Han21e9b922021-06-26 04:14:16 +09001301fn load_app_config(
1302 config: &VirtualMachineAppConfig,
Jaewan Kim61f86142023-03-28 15:12:52 +09001303 debug_config: &DebugConfig,
Jooyung Han21e9b922021-06-26 04:14:16 +09001304 temporary_directory: &Path,
Jooyung Hanadfb76c2021-06-28 17:29:30 +09001305) -> Result<VirtualMachineRawConfig> {
Andrew Walbrancc0db522021-07-12 17:03:42 +00001306 let apk_file = clone_file(config.apk.as_ref().unwrap())?;
1307 let idsig_file = clone_file(config.idsig.as_ref().unwrap())?;
Jiyong Park8d081812021-07-23 17:45:04 +09001308 let instance_file = clone_file(config.instanceImage.as_ref().unwrap())?;
Jooyung Han21e9b922021-06-26 04:14:16 +09001309
Shikha Panwar22e70452022-10-10 18:32:55 +00001310 let storage_image = if let Some(file) = config.encryptedStorageImage.as_ref() {
1311 Some(clone_file(file)?)
1312 } else {
1313 None
1314 };
1315
Alan Stokesfda70842023-12-20 17:50:14 +00001316 let vm_payload_config;
1317 let extra_apk_files: Vec<_>;
1318 match &config.payload {
Alan Stokes0d1ef782022-09-27 13:46:35 +01001319 Payload::ConfigPath(config_path) => {
Alan Stokesfda70842023-12-20 17:50:14 +00001320 vm_payload_config =
1321 load_vm_payload_config_from_file(&apk_file, config_path.as_str())
1322 .with_context(|| format!("Couldn't read config from {}", config_path))?;
1323 extra_apk_files = vm_payload_config
1324 .extra_apks
1325 .iter()
1326 .enumerate()
1327 .map(|(i, apk)| {
1328 File::open(PathBuf::from(&apk.path))
1329 .with_context(|| format!("Failed to open extra apk #{i} {}", apk.path))
1330 })
1331 .collect::<Result<_>>()?;
Alan Stokes0d1ef782022-09-27 13:46:35 +01001332 }
Alan Stokesfda70842023-12-20 17:50:14 +00001333 Payload::PayloadConfig(payload_config) => {
1334 vm_payload_config = create_vm_payload_config(payload_config)?;
1335 extra_apk_files =
1336 payload_config.extraApks.iter().map(clone_file).collect::<binder::Result<_>>()?;
1337 }
Alan Stokes0d1ef782022-09-27 13:46:35 +01001338 };
Jooyung Han21e9b922021-06-26 04:14:16 +09001339
Inseob Kim89b24592024-02-23 18:59:43 +09001340 let payload_config_os = vm_payload_config.os.name.as_str();
1341 if !payload_config_os.is_empty() && payload_config_os != "microdroid" {
1342 bail!("'os' in payload config is deprecated");
1343 }
1344
Inseob Kim172f9eb2023-11-06 17:02:08 +09001345 // For now, the only supported OS is Microdroid and Microdroid GKI
Inseob Kim89b24592024-02-23 18:59:43 +09001346 let os_name = config.osName.as_str();
Inseob Kim172f9eb2023-11-06 17:02:08 +09001347 if !is_valid_os(os_name) {
Andrew Walbrancc0db522021-07-12 17:03:42 +00001348 bail!("Unknown OS \"{}\"", os_name);
Jooyung Han35edb8f2021-07-01 16:17:16 +09001349 }
Andrew Walbrancc0db522021-07-12 17:03:42 +00001350
1351 // It is safe to construct a filename based on the os_name because we've already checked that it
1352 // is one of the allowed values.
Jooyung Han21e9b922021-06-26 04:14:16 +09001353 let vm_config_path = PathBuf::from(format!("/apex/com.android.virt/etc/{}.json", os_name));
1354 let vm_config_file = File::open(vm_config_path)?;
Andrew Walbrancc0db522021-07-12 17:03:42 +00001355 let mut vm_config = VmConfig::load(&vm_config_file)?.to_parcelable()?;
Jooyung Han21e9b922021-06-26 04:14:16 +09001356
Nikita Ioffea0eb5ee2023-06-26 18:18:21 +01001357 if let Some(custom_config) = &config.customConfig {
1358 if let Some(file) = custom_config.customKernelImage.as_ref() {
1359 vm_config.kernel = Some(ParcelFileDescriptor::new(clone_file(file)?))
1360 }
Nikita Ioffea0eb5ee2023-06-26 18:18:21 +01001361 vm_config.gdbPort = custom_config.gdbPort;
Nikita Ioffe5dfddf22023-06-29 16:11:26 +01001362
1363 if let Some(file) = custom_config.vendorImage.as_ref() {
Nikita Ioffeaa6858c2023-07-04 01:37:41 +01001364 add_microdroid_vendor_image(clone_file(file)?, &mut vm_config);
Pechetty Sravani (xWF)faabfbd2024-09-24 15:27:48 +00001365 append_kernel_param("androidboot.microdroid.mount_vendor=1", &mut vm_config)
Nikita Ioffe5dfddf22023-06-29 16:11:26 +01001366 }
Inseob Kim6ef80972023-07-20 17:23:36 +09001367
Jaewan Kimf43372b2024-12-13 18:33:58 +09001368 vm_config.devices = AssignedDevices::Devices(custom_config.devices.clone());
Seungjae Yoo13af0b62024-05-20 14:15:13 +09001369 vm_config.networkSupported = custom_config.networkSupported;
Nikita Ioffeb4268b32024-09-03 10:23:14 +00001370
1371 for param in custom_config.extraKernelCmdlineParams.iter() {
1372 append_kernel_param(param, &mut vm_config);
1373 }
Nikita Ioffe99548382024-10-21 15:54:46 +00001374
1375 vm_config.teeServices.clone_from(&custom_config.teeServices);
Nikita Ioffe26c35ed2023-06-05 17:49:08 +01001376 }
1377
Andrew Walbrancc045902021-07-27 16:06:17 +00001378 if config.memoryMib > 0 {
1379 vm_config.memoryMib = config.memoryMib;
Andrew Walbran45bcb0c2021-07-14 15:02:06 +00001380 }
1381
Chris Wailes6177c662024-05-09 14:37:44 -07001382 vm_config.name.clone_from(&config.name);
Andrew Walbran3994f002022-01-27 17:33:45 +00001383 vm_config.protectedVm = config.protectedVm;
Elie Kheirallahb4b2f242025-01-23 03:38:07 +00001384 vm_config.cpuOptions = config.cpuOptions.clone();
Vincent Donnefort538a2c62024-03-20 16:01:10 +00001385 vm_config.hugePages = config.hugePages || vm_payload_config.hugepages;
David Dai23cff712024-06-13 19:23:45 +00001386 vm_config.boostUclamp = config.boostUclamp;
Jiyong Park032615f2022-01-10 13:55:34 +09001387
Shikha Panwar22e70452022-10-10 18:32:55 +00001388 // Microdroid takes additional init ramdisk & (optionally) storage image
Inseob Kim172f9eb2023-11-06 17:02:08 +09001389 add_microdroid_system_images(config, instance_file, storage_image, os_name, &mut vm_config)?;
Shikha Panwar22e70452022-10-10 18:32:55 +00001390
1391 // Include Microdroid payload disk (contains apks, idsigs) in vm config
1392 add_microdroid_payload_images(
Alan Stokes0d1ef782022-09-27 13:46:35 +01001393 config,
Jaewan Kim61f86142023-03-28 15:12:52 +09001394 debug_config,
Alan Stokes0d1ef782022-09-27 13:46:35 +01001395 temporary_directory,
1396 apk_file,
1397 idsig_file,
Alan Stokesfda70842023-12-20 17:50:14 +00001398 extra_apk_files,
Alan Stokes0d1ef782022-09-27 13:46:35 +01001399 &vm_payload_config,
1400 &mut vm_config,
1401 )?;
Jooyung Han21e9b922021-06-26 04:14:16 +09001402
Andrew Walbrancc0db522021-07-12 17:03:42 +00001403 Ok(vm_config)
Jooyung Han21e9b922021-06-26 04:14:16 +09001404}
1405
Frederick Mayle3a46b272025-02-10 21:55:49 -08001406fn check_partition_for_file(
1407 fd: &ParcelFileDescriptor,
1408 calling_partition: CallingPartition,
1409) -> Result<()> {
Inseob Kimff48a7c2024-02-26 22:07:21 +09001410 let path = format!("/proc/self/fd/{}", fd.as_raw_fd());
1411 let link = fs::read_link(&path).context(format!("can't read_link {path}"))?;
1412
1413 // microdroid vendor image is OK
1414 if cfg!(vendor_modules) && link == Path::new("/vendor/etc/avf/microdroid/microdroid_vendor.img")
1415 {
1416 return Ok(());
1417 }
1418
Inseob Kime3e932d2024-12-16 20:06:57 +09001419 let is_fd_vendor = link.starts_with("/vendor") || link.starts_with("/odm");
Frederick Mayle3a46b272025-02-10 21:55:49 -08001420 let is_caller_vendor =
1421 calling_partition == CallingPartition::Vendor || calling_partition == CallingPartition::Odm;
Inseob Kime3e932d2024-12-16 20:06:57 +09001422
1423 if is_fd_vendor != is_caller_vendor {
1424 bail!("{} can't be used for VM client in {calling_partition}", link.display());
Inseob Kimff48a7c2024-02-26 22:07:21 +09001425 }
1426
1427 Ok(())
1428}
1429
Inseob Kime3e932d2024-12-16 20:06:57 +09001430fn check_partitions_for_files(
1431 config: &VirtualMachineRawConfig,
Frederick Mayle3a46b272025-02-10 21:55:49 -08001432 calling_partition: CallingPartition,
Inseob Kime3e932d2024-12-16 20:06:57 +09001433) -> Result<()> {
Inseob Kimff48a7c2024-02-26 22:07:21 +09001434 config
1435 .disks
1436 .iter()
1437 .flat_map(|disk| disk.partitions.iter())
1438 .filter_map(|partition| partition.image.as_ref())
Inseob Kime3e932d2024-12-16 20:06:57 +09001439 .try_for_each(|fd| check_partition_for_file(fd, calling_partition))?;
Inseob Kimff48a7c2024-02-26 22:07:21 +09001440
Inseob Kime3e932d2024-12-16 20:06:57 +09001441 config
1442 .disks
1443 .iter()
1444 .filter_map(|disk| disk.image.as_ref())
1445 .try_for_each(|fd| check_partition_for_file(fd, calling_partition))?;
1446
1447 config.kernel.as_ref().map_or(Ok(()), |fd| check_partition_for_file(fd, calling_partition))?;
1448 config.initrd.as_ref().map_or(Ok(()), |fd| check_partition_for_file(fd, calling_partition))?;
1449 config
1450 .bootloader
1451 .as_ref()
1452 .map_or(Ok(()), |fd| check_partition_for_file(fd, calling_partition))?;
Inseob Kimff48a7c2024-02-26 22:07:21 +09001453
1454 Ok(())
1455}
1456
Alan Stokes0d1ef782022-09-27 13:46:35 +01001457fn load_vm_payload_config_from_file(apk_file: &File, config_path: &str) -> Result<VmPayloadConfig> {
1458 let mut apk_zip = ZipArchive::new(apk_file)?;
1459 let config_file = apk_zip.by_name(config_path)?;
1460 Ok(serde_json::from_reader(config_file)?)
1461}
1462
Alan Stokes8f12f2b2023-01-09 09:19:20 +00001463fn create_vm_payload_config(
1464 payload_config: &VirtualMachinePayloadConfig,
1465) -> Result<VmPayloadConfig> {
Alan Stokes0d1ef782022-09-27 13:46:35 +01001466 // There isn't an actual config file. Construct a synthetic VmPayloadConfig from the explicit
1467 // parameters we've been given. Microdroid will do something equivalent inside the VM using the
1468 // payload config that we send it via the metadata file.
Alan Stokes8f12f2b2023-01-09 09:19:20 +00001469
1470 let payload_binary_name = &payload_config.payloadBinaryName;
1471 if payload_binary_name.contains('/') {
1472 bail!("Payload binary name must not specify a path: {payload_binary_name}");
1473 }
1474
1475 let task = Task { type_: TaskType::MicrodroidLauncher, command: payload_binary_name.clone() };
Alan Stokesfda70842023-12-20 17:50:14 +00001476
1477 // The VM only cares about how many there are, these names are actually ignored.
1478 let extra_apk_count = payload_config.extraApks.len();
1479 let extra_apks =
1480 (0..extra_apk_count).map(|i| ApkConfig { path: format!("extra-apk-{i}") }).collect();
1481
Nikita Ioffe901083f2025-01-20 01:54:28 +00001482 if check_use_relaxed_microdroid_rollback_protection().is_ok() {
1483 // The only payload delivered via Mainline module in this release requires
1484 // com.android.i18n apex. However, we are past all the reasonable deadlines to add new
1485 // APIs, so we use the fact that the payload is granted
1486 // USE_RELAXED_MICRODROID_ROLLBACK_PROTECTION permission as a signal that we should include
1487 // com.android.i18n APEX.
1488 // TODO: remove this after we provide a stable @SystemApi to load additional APEXes to
1489 // Microdroid pVMs.
1490 let apexes = vec![ApexConfig { name: String::from("com.android.i18n") }];
1491 Ok(VmPayloadConfig { task: Some(task), apexes, extra_apks, ..Default::default() })
1492 } else {
1493 Ok(VmPayloadConfig { task: Some(task), extra_apks, ..Default::default() })
1494 }
Alan Stokes0d1ef782022-09-27 13:46:35 +01001495}
1496
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001497/// Generates a unique filename to use for a composite disk image.
Andrew Walbran3eca16c2021-06-14 11:15:14 +00001498fn make_composite_image_filenames(
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001499 temporary_directory: &Path,
1500 next_temporary_image_id: &mut u64,
Andrew Walbran3eca16c2021-06-14 11:15:14 +00001501) -> CompositeImageFilenames {
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001502 let id = *next_temporary_image_id;
1503 *next_temporary_image_id += 1;
Andrew Walbran3eca16c2021-06-14 11:15:14 +00001504 CompositeImageFilenames {
1505 composite: temporary_directory.join(format!("composite-{}.img", id)),
1506 header: temporary_directory.join(format!("composite-{}-header.img", id)),
1507 footer: temporary_directory.join(format!("composite-{}-footer.img", id)),
1508 }
1509}
1510
1511/// Filenames for a composite disk image, including header and footer partitions.
1512#[derive(Clone, Debug, Eq, PartialEq)]
1513struct CompositeImageFilenames {
1514 /// The composite disk image itself.
1515 composite: PathBuf,
1516 /// The header partition image.
1517 header: PathBuf,
1518 /// The footer partition image.
1519 footer: PathBuf,
Andrew Walbranf5fbb7d2021-05-12 17:15:48 +00001520}
1521
Jiyong Park753553b2021-07-12 21:21:09 +09001522/// Checks whether the caller has a specific permission
1523fn check_permission(perm: &str) -> binder::Result<()> {
Inseob Kimecde8c02024-09-03 13:11:08 +09001524 if cfg!(early) {
1525 // Skip permission check for early VMs, in favor of SELinux
1526 return Ok(());
1527 }
David Brazdil1f530702022-10-03 12:18:10 +01001528 let calling_pid = get_calling_pid();
1529 let calling_uid = get_calling_uid();
Jiyong Park753553b2021-07-12 21:21:09 +09001530 // Root can do anything
1531 if calling_uid == 0 {
1532 return Ok(());
1533 }
1534 let perm_svc: Strong<dyn IPermissionController::IPermissionController> =
Frederick Mayleb2a02872024-05-08 13:35:12 -07001535 binder::wait_for_interface("permission")?;
Jiyong Park753553b2021-07-12 21:21:09 +09001536 if perm_svc.checkPermission(perm, calling_pid, calling_uid as i32)? {
Andrew Walbran806f1542021-06-10 14:07:12 +00001537 Ok(())
1538 } else {
Jiyong Park2227eaa2023-08-04 11:59:18 +09001539 Err(anyhow!("does not have the {} permission", perm))
1540 .or_binder_exception(ExceptionCode::SECURITY)
Andrew Walbran806f1542021-06-10 14:07:12 +00001541 }
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001542}
1543
Jiyong Park753553b2021-07-12 21:21:09 +09001544/// Check whether the caller of the current Binder method is allowed to manage VMs
1545fn check_manage_access() -> binder::Result<()> {
1546 check_permission("android.permission.MANAGE_VIRTUAL_MACHINE")
1547}
1548
Inseob Kim1119d702022-05-02 18:01:58 +09001549/// Check whether the caller of the current Binder method is allowed to create custom VMs
1550fn check_use_custom_virtual_machine() -> binder::Result<()> {
1551 check_permission("android.permission.USE_CUSTOM_VIRTUAL_MACHINE")
1552}
1553
Nikita Ioffe901083f2025-01-20 01:54:28 +00001554/// Check whether the caller of the current binder method is allowed to use relaxed microdroid
1555/// rollback protection schema.
1556fn check_use_relaxed_microdroid_rollback_protection() -> binder::Result<()> {
1557 check_permission("android.permission.USE_RELAXED_MICRODROID_ROLLBACK_PROTECTION")
1558}
1559
Alan Stokes185fe112023-01-10 16:20:55 +00001560/// Return whether a partition is exempt from selinux label checks, because we know that it does
1561/// not contain code and is likely to be generated in an app-writable directory.
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001562fn is_safe_app_partition(label: &str) -> bool {
Shikha Panwara2ff8c52022-11-30 19:25:46 +00001563 // See add_microdroid_system_images & add_microdroid_payload_images in payload.rs.
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001564 label == "vm-instance"
Shikha Panwara2ff8c52022-11-30 19:25:46 +00001565 || label == "encryptedstore"
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001566 || label == "microdroid-apk-idsig"
1567 || label == "payload-metadata"
1568 || label.starts_with("extra-idsig-")
1569}
1570
Alice Wangc206b9b2023-08-28 14:13:51 +00001571/// Returns whether a partition with the given label is safe for a raw config VM.
1572fn is_safe_raw_partition(label: &str) -> bool {
1573 label == "vm-instance"
1574}
1575
Alan Stokes185fe112023-01-10 16:20:55 +00001576/// Check that a file SELinux label is acceptable.
1577///
1578/// We only want to allow code in a VM to be sourced from places that apps, and the
Seungjae Yoo2b74c442023-11-15 18:05:07 +09001579/// system or vendor, do not have write access to.
Alan Stokes185fe112023-01-10 16:20:55 +00001580///
1581/// Note that sepolicy must also grant read access for these types to both virtualization
1582/// service and crosvm.
1583///
1584/// App private data files are deliberately excluded, to avoid arbitrary payloads being run on
1585/// user devices (W^X).
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08001586fn check_label_is_allowed(context: &SeContext, calling_partition: CallingPartition) -> Result<()> {
Alan Stokes185fe112023-01-10 16:20:55 +00001587 match context.selinux_type()? {
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001588 | "apk_data_file" // APKs of an installed app
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001589 | "shell_data_file" // test files created via adb shell
Alan Stokesfe4bb0c2023-03-20 14:15:36 +00001590 | "staging_data_file" // updated/staged APEX images
1591 | "system_file" // immutable dm-verity protected partition
1592 | "virtualizationservice_data_file" // files created by VS / VirtMgr
Seungjae Yoo2b74c442023-11-15 18:05:07 +09001593 | "vendor_microdroid_file" // immutable dm-verity protected partition (/vendor/etc/avf/microdroid/.*)
Alan Stokes53cc5ca2022-08-30 14:28:19 +01001594 => Ok(()),
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08001595 // It is difficult to require specific label types for vendor initiated VM's files, so we
1596 // allow anything with a vendor prefix.
1597 t if calling_partition == CallingPartition::Vendor && t.starts_with("vendor_") => Ok(()),
Alan Stokes185fe112023-01-10 16:20:55 +00001598 _ => bail!("Label {} is not allowed", context),
Jiyong Park029977d2021-11-24 21:56:49 +09001599 }
1600}
1601
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08001602fn check_label_for_partition(
1603 partition: &Partition,
1604 calling_partition: CallingPartition,
1605) -> Result<()> {
Alan Stokes185fe112023-01-10 16:20:55 +00001606 let file = partition.image.as_ref().unwrap().as_ref();
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08001607 check_label_is_allowed(&getfilecon(file)?, calling_partition)
Alan Stokes185fe112023-01-10 16:20:55 +00001608 .with_context(|| format!("Partition {} invalid", &partition.label))
1609}
1610
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08001611fn check_label_for_kernel_files(
1612 kernel: &Option<File>,
1613 initrd: &Option<File>,
1614 calling_partition: CallingPartition,
1615) -> Result<()> {
Alan Stokes185fe112023-01-10 16:20:55 +00001616 if let Some(f) = kernel {
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08001617 check_label_for_file(f, "kernel", calling_partition)?;
Alan Stokes185fe112023-01-10 16:20:55 +00001618 }
1619 if let Some(f) = initrd {
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08001620 check_label_for_file(f, "initrd", calling_partition)?;
Alan Stokes185fe112023-01-10 16:20:55 +00001621 }
1622 Ok(())
1623}
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08001624fn check_label_for_file(
Frederick Mayle9539fb52025-02-13 13:08:15 -08001625 file: &impl AsRawFd,
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08001626 name: &str,
1627 calling_partition: CallingPartition,
1628) -> Result<()> {
1629 check_label_is_allowed(&getfilecon(file)?, calling_partition)
1630 .with_context(|| format!("{} file invalid", name))
Alan Stokes185fe112023-01-10 16:20:55 +00001631}
1632
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001633/// Implementation of the AIDL `IVirtualMachine` interface. Used as a handle to a VM.
1634#[derive(Debug)]
1635struct VirtualMachine {
1636 instance: Arc<VmInstance>,
1637}
1638
1639impl VirtualMachine {
Devin Moore407df8f2024-08-27 19:39:16 +00001640 fn create(instance: Arc<VmInstance>) -> Strong<dyn IVirtualMachine::IVirtualMachine> {
David Brazdil4b4c5102022-12-19 22:56:20 +00001641 BnVirtualMachine::new_binder(VirtualMachine { instance }, BinderFeatures::default())
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001642 }
1643}
1644
1645impl Interface for VirtualMachine {}
1646
Devin Moore407df8f2024-08-27 19:39:16 +00001647impl IVirtualMachine::IVirtualMachine for VirtualMachine {
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001648 fn getCid(&self) -> binder::Result<i32> {
Jiyong Park753553b2021-07-12 21:21:09 +09001649 // Don't check permission. The owner of the VM might have passed this binder object to
1650 // others.
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001651 Ok(self.instance.cid as i32)
1652 }
Andrew Walbrandae07162021-03-12 17:05:20 +00001653
Andrew Walbran6b650662021-09-07 13:13:23 +00001654 fn getState(&self) -> binder::Result<VirtualMachineState> {
Jiyong Park753553b2021-07-12 21:21:09 +09001655 // Don't check permission. The owner of the VM might have passed this binder object to
1656 // others.
Andrew Walbran6b650662021-09-07 13:13:23 +00001657 Ok(get_state(&self.instance))
Andrew Walbrandae07162021-03-12 17:05:20 +00001658 }
1659
1660 fn registerCallback(
1661 &self,
1662 callback: &Strong<dyn IVirtualMachineCallback>,
1663 ) -> binder::Result<()> {
Jiyong Park753553b2021-07-12 21:21:09 +09001664 // Don't check permission. The owner of the VM might have passed this binder object to
1665 // others.
Jaewan Kim27ac1832025-02-03 23:42:08 +09001666
1667 // Only register callback if it may be notified.
1668 // This also ensures no cyclic reference between callback and VmInstance after VM is died.
1669 let vm_state = self.instance.vm_state.lock().unwrap();
1670 if matches!(*vm_state, VmState::Dead) {
1671 warn!("Ignoring registerCallback() after VM is died");
1672 } else {
1673 self.instance.callbacks.add(callback.clone());
1674 }
1675 drop(vm_state);
1676
Andrew Walbrandae07162021-03-12 17:05:20 +00001677 Ok(())
1678 }
Andrew Walbrancbe8b082021-08-06 15:42:11 +00001679
Andrew Walbranf8d94112021-09-07 11:45:36 +00001680 fn start(&self) -> binder::Result<()> {
Jiyong Park2227eaa2023-08-04 11:59:18 +09001681 self.instance
1682 .start()
1683 .with_context(|| format!("Error starting VM with CID {}", self.instance.cid))
1684 .with_log()
1685 .or_service_specific_exception(-1)
Andrew Walbranf8d94112021-09-07 11:45:36 +00001686 }
1687
Inseob Kima446f802022-07-11 19:46:37 +09001688 fn stop(&self) -> binder::Result<()> {
Jiyong Park2227eaa2023-08-04 11:59:18 +09001689 self.instance
1690 .kill()
1691 .with_context(|| format!("Error stopping VM with CID {}", self.instance.cid))
1692 .with_log()
1693 .or_service_specific_exception(-1)
Inseob Kima446f802022-07-11 19:46:37 +09001694 }
1695
Keir Fraser48221ba2024-07-12 14:05:02 +00001696 fn getMemoryBalloon(&self) -> binder::Result<i64> {
1697 let balloon = self
1698 .instance
1699 .get_memory_balloon()
1700 .with_context(|| format!("Error getting balloon for VM with CID {}", self.instance.cid))
1701 .with_log()
1702 .or_service_specific_exception(-1)?;
1703 Ok(balloon.try_into().unwrap())
1704 }
1705
1706 fn setMemoryBalloon(&self, num_bytes: i64) -> binder::Result<()> {
Jiyong Park2227eaa2023-08-04 11:59:18 +09001707 self.instance
Keir Fraser48221ba2024-07-12 14:05:02 +00001708 .set_memory_balloon(num_bytes.try_into().unwrap())
1709 .with_context(|| format!("Error setting balloon for VM with CID {}", self.instance.cid))
Jiyong Park2227eaa2023-08-04 11:59:18 +09001710 .with_log()
1711 .or_service_specific_exception(-1)
Keir Frasercdd4b112022-11-24 14:02:25 +00001712 }
1713
Andrew Walbrancbe8b082021-08-06 15:42:11 +00001714 fn connectVsock(&self, port: i32) -> binder::Result<ParcelFileDescriptor> {
Andrew Walbranf8d94112021-09-07 11:45:36 +00001715 if !matches!(&*self.instance.vm_state.lock().unwrap(), VmState::Running { .. }) {
Devin Moore407df8f2024-08-27 19:39:16 +00001716 return Err(Status::new_service_specific_error_str(
1717 IVirtualMachine::ERROR_UNEXPECTED,
1718 Some("Virtual Machine is not running"),
1719 ));
Andrew Walbrancbe8b082021-08-06 15:42:11 +00001720 }
Alan Stokes10c47672022-12-13 17:17:08 +00001721 let port = port as u32;
Devin Moore407df8f2024-08-27 19:39:16 +00001722 if port < VSOCK_PRIV_PORT_MAX {
1723 return Err(Status::new_service_specific_error_str(
1724 IVirtualMachine::ERROR_UNEXPECTED,
1725 Some("Can't connect to privileged port {port}"),
1726 ));
Alan Stokes10c47672022-12-13 17:17:08 +00001727 }
Jiyong Park2227eaa2023-08-04 11:59:18 +09001728 let stream = VsockStream::connect_with_cid_port(self.instance.cid, port)
1729 .context("Failed to connect")
Devin Moore407df8f2024-08-27 19:39:16 +00001730 .or_service_specific_exception(IVirtualMachine::ERROR_UNEXPECTED)?;
Jiyong Parkaf63d1c2024-09-04 16:15:42 +09001731 Ok(vsock_stream_to_pfd(stream))
Andrew Walbrancbe8b082021-08-06 15:42:11 +00001732 }
Yi-Yo Chiang2fbf0da2024-06-14 22:56:56 +08001733
Devin Moore407df8f2024-08-27 19:39:16 +00001734 fn createAccessorBinder(&self, name: &str, port: i32) -> binder::Result<SpIBinder> {
1735 if !matches!(&*self.instance.vm_state.lock().unwrap(), VmState::Running { .. }) {
1736 return Err(Status::new_service_specific_error_str(
1737 IVirtualMachine::ERROR_UNEXPECTED,
1738 Some("Virtual Machine is not running"),
1739 ));
1740 }
1741 let port = port as u32;
1742 if port < VSOCK_PRIV_PORT_MAX {
1743 return Err(Status::new_service_specific_error_str(
1744 IVirtualMachine::ERROR_UNEXPECTED,
1745 Some("Can't connect to privileged port {port}"),
1746 ));
1747 }
1748 let cid = self.instance.cid;
Devin Moorec8800a12024-10-17 17:56:18 +00001749 let addr = sockaddr_vm {
1750 svm_family: AF_VSOCK as sa_family_t,
1751 svm_reserved1: 0,
1752 svm_port: port,
1753 svm_cid: cid,
1754 svm_zero: [0u8; 4],
1755 };
1756 let get_connection_info = move |_instance: &str| Some(ConnectionInfo::Vsock(addr));
Devin Moore407df8f2024-08-27 19:39:16 +00001757 let accessor = Accessor::new(name, get_connection_info);
1758 accessor
1759 .as_binder()
1760 .context("The newly created Accessor should always have a binder")
1761 .or_service_specific_exception(IVirtualMachine::ERROR_UNEXPECTED)
1762 }
1763
Yi-Yo Chiang2fbf0da2024-06-14 22:56:56 +08001764 fn setHostConsoleName(&self, ptsname: &str) -> binder::Result<()> {
1765 self.instance.vm_context.global_context.setHostConsoleName(ptsname)
1766 }
Jiyong Park23b67392024-07-04 13:51:42 +09001767
1768 fn suspend(&self) -> binder::Result<()> {
1769 self.instance
1770 .suspend()
1771 .with_context(|| format!("Error suspending VM with CID {}", self.instance.cid))
1772 .with_log()
1773 .or_service_specific_exception(-1)
1774 }
1775
1776 fn resume(&self) -> binder::Result<()> {
1777 self.instance
1778 .resume()
1779 .with_context(|| format!("Error resuming VM with CID {}", self.instance.cid))
1780 .with_log()
1781 .or_service_specific_exception(-1)
1782 }
Andrew Walbrandae07162021-03-12 17:05:20 +00001783}
1784
1785impl Drop for VirtualMachine {
1786 fn drop(&mut self) {
1787 debug!("Dropping {:?}", self);
Inseob Kima446f802022-07-11 19:46:37 +09001788 if let Err(e) = self.instance.kill() {
1789 debug!("Error stopping dropped VM with CID {}: {:?}", self.instance.cid, e);
1790 }
Andrew Walbrandae07162021-03-12 17:05:20 +00001791 }
1792}
1793
1794/// A set of Binders to be called back in response to various events on the VM, such as when it
1795/// dies.
1796#[derive(Debug, Default)]
1797pub struct VirtualMachineCallbacks(Mutex<Vec<Strong<dyn IVirtualMachineCallback>>>);
1798
1799impl VirtualMachineCallbacks {
Jiyong Park8611a6c2021-07-09 18:17:44 +09001800 /// Call all registered callbacks to notify that the payload has started.
David Brazdil451cc962022-10-14 14:08:12 +01001801 pub fn notify_payload_started(&self, cid: Cid) {
Jiyong Park8611a6c2021-07-09 18:17:44 +09001802 let callbacks = &*self.0.lock().unwrap();
Jiyong Park8611a6c2021-07-09 18:17:44 +09001803 for callback in callbacks {
David Brazdil451cc962022-10-14 14:08:12 +01001804 if let Err(e) = callback.onPayloadStarted(cid as i32) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001805 error!("Error notifying payload start event from VM CID {}: {:?}", cid, e);
Jiyong Park8611a6c2021-07-09 18:17:44 +09001806 }
1807 }
1808 }
1809
Inseob Kim14cb8692021-08-31 21:50:39 +09001810 /// Call all registered callbacks to notify that the payload is ready to serve.
1811 pub fn notify_payload_ready(&self, cid: Cid) {
1812 let callbacks = &*self.0.lock().unwrap();
1813 for callback in callbacks {
1814 if let Err(e) = callback.onPayloadReady(cid as i32) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001815 error!("Error notifying payload ready event from VM CID {}: {:?}", cid, e);
Inseob Kim14cb8692021-08-31 21:50:39 +09001816 }
1817 }
1818 }
1819
Inseob Kim2444af92021-08-31 01:22:50 +09001820 /// Call all registered callbacks to notify that the payload has finished.
1821 pub fn notify_payload_finished(&self, cid: Cid, exit_code: i32) {
1822 let callbacks = &*self.0.lock().unwrap();
1823 for callback in callbacks {
1824 if let Err(e) = callback.onPayloadFinished(cid as i32, exit_code) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001825 error!("Error notifying payload finish event from VM CID {}: {:?}", cid, e);
Inseob Kim2444af92021-08-31 01:22:50 +09001826 }
1827 }
1828 }
1829
Jooyung Handd0a1732021-11-23 15:26:20 +09001830 /// Call all registered callbacks to say that the VM encountered an error.
Alan Stokes2bead0d2022-09-05 16:58:34 +01001831 pub fn notify_error(&self, cid: Cid, error_code: ErrorCode, message: &str) {
Jooyung Handd0a1732021-11-23 15:26:20 +09001832 let callbacks = &*self.0.lock().unwrap();
1833 for callback in callbacks {
1834 if let Err(e) = callback.onError(cid as i32, error_code, message) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001835 error!("Error notifying error event from VM CID {}: {:?}", cid, e);
Jooyung Handd0a1732021-11-23 15:26:20 +09001836 }
1837 }
1838 }
1839
Andrew Walbrandae07162021-03-12 17:05:20 +00001840 /// Call all registered callbacks to say that the VM has died.
Andrew Walbranc92d35f2022-01-12 12:45:19 +00001841 pub fn callback_on_died(&self, cid: Cid, reason: DeathReason) {
Jaewan Kim27ac1832025-02-03 23:42:08 +09001842 let mut callbacks = self.0.lock().unwrap();
1843 for callback in &*callbacks {
Andrew Walbranc92d35f2022-01-12 12:45:19 +00001844 if let Err(e) = callback.onDied(cid as i32, reason) {
Alan Stokes70ccf162022-07-08 11:05:03 +01001845 error!("Error notifying exit of VM CID {}: {:?}", cid, e);
Andrew Walbrandae07162021-03-12 17:05:20 +00001846 }
1847 }
Jaewan Kim27ac1832025-02-03 23:42:08 +09001848
1849 // Nothing to notify afterward because VM cannot be restarted.
1850 // Explicitly clear callbacks to prevent potential cyclic references
1851 // between callback and VmInstance.
1852 (*callbacks).clear();
Andrew Walbrandae07162021-03-12 17:05:20 +00001853 }
1854
1855 /// Add a new callback to the set.
1856 fn add(&self, callback: Strong<dyn IVirtualMachineCallback>) {
1857 self.0.lock().unwrap().push(callback);
1858 }
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001859}
1860
Andrew Walbranf6bf6862021-05-21 12:41:13 +00001861/// The mutable state of the VirtualizationService. There should only be one instance of this
1862/// struct.
Chris Wailes641fc4a2021-12-01 15:03:21 -08001863#[derive(Debug, Default)]
Andrew Walbrand6dce6f2021-03-05 16:39:08 +00001864struct State {
Alan Stokes3e5eec12023-09-07 12:10:00 +01001865 /// The VMs which have been started. When VMs are started a weak reference is added to this
1866 /// list while a strong reference is returned to the caller over Binder. Once all copies of
1867 /// the Binder client are dropped the weak reference here will become invalid, and will be
1868 /// removed from the list opportunistically the next time `add_vm` is called.
Andrew Walbran320b5602021-03-04 16:11:12 +00001869 vms: Vec<Weak<VmInstance>>,
1870}
1871
1872impl State {
Andrew Walbrandae07162021-03-12 17:05:20 +00001873 /// Get a list of VMs which still have Binder references to them.
Andrew Walbran320b5602021-03-04 16:11:12 +00001874 fn vms(&self) -> Vec<Arc<VmInstance>> {
1875 // Attempt to upgrade the weak pointers to strong pointers.
1876 self.vms.iter().filter_map(Weak::upgrade).collect()
1877 }
1878
1879 /// Add a new VM to the list.
1880 fn add_vm(&mut self, vm: Weak<VmInstance>) {
1881 // Garbage collect any entries from the stored list which no longer exist.
1882 self.vms.retain(|vm| vm.strong_count() > 0);
1883
1884 // Actually add the new VM.
1885 self.vms.push(vm);
1886 }
David Brazdil3c2ddef2021-03-18 13:09:57 +00001887
Jiyong Park8611a6c2021-07-09 18:17:44 +09001888 /// Get a VM that corresponds to the given cid
1889 fn get_vm(&self, cid: Cid) -> Option<Arc<VmInstance>> {
1890 self.vms().into_iter().find(|vm| vm.cid == cid)
1891 }
Jiyong Parkd50a0242021-09-16 21:00:14 +09001892}
1893
Andrew Walbran6b650662021-09-07 13:13:23 +00001894/// Gets the `VirtualMachineState` of the given `VmInstance`.
1895fn get_state(instance: &VmInstance) -> VirtualMachineState {
Andrew Walbranf8d94112021-09-07 11:45:36 +00001896 match &*instance.vm_state.lock().unwrap() {
1897 VmState::NotStarted { .. } => VirtualMachineState::NOT_STARTED,
1898 VmState::Running { .. } => match instance.payload_state() {
Andrew Walbran6b650662021-09-07 13:13:23 +00001899 PayloadState::Starting => VirtualMachineState::STARTING,
1900 PayloadState::Started => VirtualMachineState::STARTED,
1901 PayloadState::Ready => VirtualMachineState::READY,
1902 PayloadState::Finished => VirtualMachineState::FINISHED,
Jiyong Parka4eebde2022-07-12 18:01:12 +09001903 PayloadState::Hangup => VirtualMachineState::DEAD,
Andrew Walbranf8d94112021-09-07 11:45:36 +00001904 },
1905 VmState::Dead => VirtualMachineState::DEAD,
1906 VmState::Failed => VirtualMachineState::DEAD,
Andrew Walbran6b650662021-09-07 13:13:23 +00001907 }
1908}
1909
David Brazdilf50c7a62023-04-19 14:22:42 +00001910/// Converts a `&ParcelFileDescriptor` to a `File` by cloning the file.
Jiyong Park2227eaa2023-08-04 11:59:18 +09001911pub fn clone_file(file: &ParcelFileDescriptor) -> binder::Result<File> {
1912 file.as_ref()
1913 .try_clone()
1914 .context("Failed to clone File from ParcelFileDescriptor")
1915 .or_binder_exception(ExceptionCode::BAD_PARCELABLE)
Andrei Homescu11333c62023-11-09 04:26:39 +00001916 .map(File::from)
David Brazdilf50c7a62023-04-19 14:22:42 +00001917}
1918
Andrew Walbrand3a84182021-09-07 14:48:52 +00001919/// Converts an `&Option<ParcelFileDescriptor>` to an `Option<File>` by cloning the file.
Jiyong Park2227eaa2023-08-04 11:59:18 +09001920fn maybe_clone_file(file: &Option<ParcelFileDescriptor>) -> binder::Result<Option<File>> {
Andrew Walbrand3a84182021-09-07 14:48:52 +00001921 file.as_ref().map(clone_file).transpose()
1922}
1923
Andrew Walbrancbe8b082021-08-06 15:42:11 +00001924/// Converts a `VsockStream` to a `ParcelFileDescriptor`.
Jiyong Parkaf63d1c2024-09-04 16:15:42 +09001925fn vsock_stream_to_pfd(stream: VsockStream) -> ParcelFileDescriptor {
1926 // SAFETY: ownership is transferred from stream to f
1927 let f = unsafe { File::from_raw_fd(stream.into_raw_fd()) };
1928 ParcelFileDescriptor::new(f)
Andrew Walbrancbe8b082021-08-06 15:42:11 +00001929}
1930
Jiyong Parkdcf17412022-02-08 15:07:23 +09001931/// Parses the platform version requirement string.
Jiyong Park2227eaa2023-08-04 11:59:18 +09001932fn parse_platform_version_req(s: &str) -> binder::Result<VersionReq> {
1933 VersionReq::parse(s)
1934 .with_context(|| format!("Invalid platform version requirement {}", s))
1935 .or_binder_exception(ExceptionCode::BAD_PARCELABLE)
Jiyong Parkdcf17412022-02-08 15:07:23 +09001936}
1937
Jiyong Parked180932023-02-24 19:55:41 +09001938/// Create the empty ramdump file
1939fn prepare_ramdump_file(temporary_directory: &Path) -> binder::Result<File> {
1940 // `ramdump_write` is sent to crosvm and will be the backing store for the /dev/hvc1 where
1941 // VM will emit ramdump to. `ramdump_read` will be sent back to the client (i.e. the VM
1942 // owner) for readout.
1943 let ramdump_path = temporary_directory.join("ramdump");
Jiyong Park2227eaa2023-08-04 11:59:18 +09001944 let ramdump = File::create(ramdump_path)
1945 .context("Failed to prepare ramdump file")
1946 .with_log()
1947 .or_service_specific_exception(-1)?;
Jiyong Parked180932023-02-24 19:55:41 +09001948 Ok(ramdump)
1949}
1950
Pierre-Clément Tosi9515d0f2024-04-15 15:58:07 +01001951/// Create the empty device tree dump file
1952fn prepare_dump_dt_file(temporary_directory: &Path) -> binder::Result<File> {
1953 let path = temporary_directory.join("device_tree.dtb");
1954 let file = File::create(path)
1955 .context("Failed to prepare device tree dump file")
1956 .with_log()
1957 .or_service_specific_exception(-1)?;
1958 Ok(file)
1959}
1960
Nikita Ioffe5776f082023-02-10 21:38:26 +00001961fn is_protected(config: &VirtualMachineConfig) -> bool {
1962 match config {
1963 VirtualMachineConfig::RawConfig(config) => config.protectedVm,
1964 VirtualMachineConfig::AppConfig(config) => config.protectedVm,
1965 }
1966}
1967
1968fn check_gdb_allowed(config: &VirtualMachineConfig) -> binder::Result<()> {
1969 if is_protected(config) {
Jiyong Park2227eaa2023-08-04 11:59:18 +09001970 return Err(anyhow!("Can't use gdb with protected VMs"))
1971 .or_binder_exception(ExceptionCode::SECURITY);
Nikita Ioffe5776f082023-02-10 21:38:26 +00001972 }
1973
Pierre-Clément Tosid3bbe1d2024-04-15 18:03:51 +01001974 if get_debug_level(config) == Some(DebugLevel::NONE) {
1975 return Err(anyhow!("Can't use gdb with non-debuggable VMs"))
1976 .or_binder_exception(ExceptionCode::SECURITY);
Nikita Ioffe5776f082023-02-10 21:38:26 +00001977 }
Pierre-Clément Tosid3bbe1d2024-04-15 18:03:51 +01001978
1979 Ok(())
Nikita Ioffe5776f082023-02-10 21:38:26 +00001980}
1981
Shikha Panwar61a74b52024-02-16 13:17:01 +00001982fn extract_instance_id(config: &VirtualMachineConfig) -> [u8; 64] {
1983 match config {
1984 VirtualMachineConfig::RawConfig(config) => config.instanceId,
1985 VirtualMachineConfig::AppConfig(config) => config.instanceId,
1986 }
1987}
1988
Alan Stokesc96b35e2024-05-03 13:21:20 +01001989fn extract_want_updatable(config: &VirtualMachineConfig) -> bool {
1990 match config {
1991 VirtualMachineConfig::RawConfig(_) => true,
1992 VirtualMachineConfig::AppConfig(config) => {
1993 let Some(custom) = &config.customConfig else { return true };
1994 custom.wantUpdatable
1995 }
1996 }
1997}
1998
Nikita Ioffe5776f082023-02-10 21:38:26 +00001999fn extract_gdb_port(config: &VirtualMachineConfig) -> Option<NonZeroU16> {
2000 match config {
2001 VirtualMachineConfig::RawConfig(config) => NonZeroU16::new(config.gdbPort as u16),
Nikita Ioffea0eb5ee2023-06-26 18:18:21 +01002002 VirtualMachineConfig::AppConfig(config) => {
2003 NonZeroU16::new(config.customConfig.as_ref().map(|c| c.gdbPort).unwrap_or(0) as u16)
2004 }
Nikita Ioffe5776f082023-02-10 21:38:26 +00002005 }
2006}
2007
Nikita Ioffe631717e2023-09-05 13:38:07 +01002008fn check_no_vendor_modules(config: &VirtualMachineConfig) -> binder::Result<()> {
2009 let VirtualMachineConfig::AppConfig(config) = config else { return Ok(()) };
2010 if let Some(custom_config) = &config.customConfig {
2011 if custom_config.vendorImage.is_some() || custom_config.customKernelImage.is_some() {
2012 return Err(anyhow!("vendor modules feature is disabled"))
2013 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION);
2014 }
2015 }
2016 Ok(())
2017}
2018
Nikita Ioffe94a8a182023-11-16 16:37:48 +00002019fn check_no_devices(config: &VirtualMachineConfig) -> binder::Result<()> {
2020 let VirtualMachineConfig::AppConfig(config) = config else { return Ok(()) };
2021 if let Some(custom_config) = &config.customConfig {
2022 if !custom_config.devices.is_empty() {
2023 return Err(anyhow!("device assignment feature is disabled"))
2024 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION);
2025 }
2026 }
2027 Ok(())
2028}
2029
Alan Stokesfda70842023-12-20 17:50:14 +00002030fn check_no_extra_apks(config: &VirtualMachineConfig) -> binder::Result<()> {
2031 let VirtualMachineConfig::AppConfig(config) = config else { return Ok(()) };
2032 let Payload::PayloadConfig(payload_config) = &config.payload else { return Ok(()) };
2033 if !payload_config.extraApks.is_empty() {
2034 return Err(anyhow!("multi-tenant feature is disabled"))
2035 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION);
2036 }
2037 Ok(())
2038}
2039
Nikita Ioffeb4268b32024-09-03 10:23:14 +00002040fn check_no_extra_kernel_cmdline_params(config: &VirtualMachineConfig) -> binder::Result<()> {
2041 let VirtualMachineConfig::AppConfig(config) = config else { return Ok(()) };
2042 if let Some(custom_config) = &config.customConfig {
2043 if !custom_config.extraKernelCmdlineParams.is_empty() {
2044 return Err(anyhow!("debuggable_vms_improvements feature is disabled"))
2045 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION);
2046 }
2047 }
2048 Ok(())
2049}
2050
Nikita Ioffe99548382024-10-21 15:54:46 +00002051fn check_no_tee_services(config: &VirtualMachineConfig) -> binder::Result<()> {
2052 match config {
2053 VirtualMachineConfig::RawConfig(config) => {
2054 if !config.teeServices.is_empty() {
2055 return Err(anyhow!("tee_services_allowlist feature is disabled"))
2056 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION);
2057 }
2058 }
2059 VirtualMachineConfig::AppConfig(config) => {
2060 if let Some(custom_config) = &config.customConfig {
2061 if !custom_config.teeServices.is_empty() {
2062 return Err(anyhow!("tee_services_allowlist feature is disabled"))
2063 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION);
2064 }
2065 }
2066 }
2067 };
2068 Ok(())
2069}
2070
Nikita Ioffef934e812024-07-05 15:44:41 +00002071fn check_protected_vm_is_supported() -> binder::Result<()> {
2072 let is_pvm_supported =
2073 hypervisor_props::is_protected_vm_supported().or_service_specific_exception(-1)?;
2074 if is_pvm_supported {
2075 Ok(())
2076 } else {
2077 Err(anyhow!("pVM is not supported"))
2078 .or_binder_exception(ExceptionCode::UNSUPPORTED_OPERATION)
2079 }
2080}
2081
Nikita Ioffe631717e2023-09-05 13:38:07 +01002082fn check_config_features(config: &VirtualMachineConfig) -> binder::Result<()> {
2083 if !cfg!(vendor_modules) {
2084 check_no_vendor_modules(config)?;
2085 }
Nikita Ioffe94a8a182023-11-16 16:37:48 +00002086 if !cfg!(device_assignment) {
2087 check_no_devices(config)?;
2088 }
Alan Stokesfda70842023-12-20 17:50:14 +00002089 if !cfg!(multi_tenant) {
2090 check_no_extra_apks(config)?;
2091 }
Nikita Ioffeb4268b32024-09-03 10:23:14 +00002092 if !cfg!(debuggable_vms_improvements) {
2093 check_no_extra_kernel_cmdline_params(config)?;
2094 }
Nikita Ioffe99548382024-10-21 15:54:46 +00002095 if !cfg!(tee_services_allowlist) {
2096 check_no_tee_services(config)?;
2097 }
Nikita Ioffe631717e2023-09-05 13:38:07 +01002098 Ok(())
2099}
2100
Inseob Kimecde8c02024-09-03 13:11:08 +09002101fn check_config_allowed_for_early_vms(config: &VirtualMachineConfig) -> binder::Result<()> {
2102 check_no_vendor_modules(config)?;
2103 check_no_devices(config)?;
2104
2105 Ok(())
2106}
2107
Inseob Kim0168b462022-12-27 14:54:35 +09002108fn clone_or_prepare_logger_fd(
Inseob Kim0168b462022-12-27 14:54:35 +09002109 fd: Option<&ParcelFileDescriptor>,
2110 tag: String,
2111) -> Result<Option<File>, Status> {
2112 if let Some(fd) = fd {
2113 return Ok(Some(clone_file(fd)?));
2114 }
2115
Frederick Maylefbbcfcd2024-04-08 16:31:54 -07002116 let (read_fd, write_fd) =
Jiyong Park2227eaa2023-08-04 11:59:18 +09002117 pipe().context("Failed to create pipe").or_service_specific_exception(-1)?;
Inseob Kim0168b462022-12-27 14:54:35 +09002118
Frederick Maylefbbcfcd2024-04-08 16:31:54 -07002119 let mut reader = BufReader::new(File::from(read_fd));
2120 let write_fd = File::from(write_fd);
Inseob Kim0168b462022-12-27 14:54:35 +09002121
Frederick Mayle26e41af2025-02-05 18:30:29 -08002122 let mut buf = vec![];
Inseob Kim0168b462022-12-27 14:54:35 +09002123 std::thread::spawn(move || loop {
Frederick Mayle26e41af2025-02-05 18:30:29 -08002124 buf.clear();
2125 buf.shrink_to(1024);
Inseob Kim0168b462022-12-27 14:54:35 +09002126 match reader.read_until(b'\n', &mut buf) {
2127 Ok(0) => {
2128 // EOF
2129 return;
2130 }
Frederick Mayle690ec2c2025-02-05 18:31:33 -08002131 Ok(_size) => {
2132 if buf.last() == Some(&b'\n') {
Inseob Kim0168b462022-12-27 14:54:35 +09002133 buf.pop();
Frederick Mayle690ec2c2025-02-05 18:31:33 -08002134 // Logs sent via TTY usually end lines with "\r\n".
2135 if buf.last() == Some(&b'\r') {
2136 buf.pop();
2137 }
Inseob Kim0168b462022-12-27 14:54:35 +09002138 }
2139 info!("{}: {}", &tag, &String::from_utf8_lossy(&buf));
2140 }
2141 Err(e) => {
2142 error!("Could not read console pipe: {:?}", e);
2143 return;
2144 }
2145 };
2146 });
2147
2148 Ok(Some(write_fd))
2149}
2150
Jooyung Han35edb8f2021-07-01 16:17:16 +09002151/// Simple utility for referencing Borrowed or Owned. Similar to std::borrow::Cow, but
2152/// it doesn't require that T implements Clone.
2153enum BorrowedOrOwned<'a, T> {
2154 Borrowed(&'a T),
2155 Owned(T),
2156}
2157
Chris Wailes73a1eb72025-01-15 11:56:43 -08002158impl<T> AsRef<T> for BorrowedOrOwned<'_, T> {
Jooyung Han35edb8f2021-07-01 16:17:16 +09002159 fn as_ref(&self) -> &T {
2160 match self {
2161 Self::Borrowed(b) => b,
Chris Wailes68c39f82021-07-27 16:03:44 -07002162 Self::Owned(o) => o,
Jooyung Han35edb8f2021-07-01 16:17:16 +09002163 }
2164 }
2165}
Inseob Kim1b95f2e2021-08-19 13:17:40 +09002166
2167/// Implementation of `IVirtualMachineService`, the entry point of the AIDL service.
2168#[derive(Debug, Default)]
2169struct VirtualMachineService {
2170 state: Arc<Mutex<State>>,
Inseob Kimc7d28c72021-10-25 14:28:10 +00002171 cid: Cid,
Inseob Kim1b95f2e2021-08-19 13:17:40 +09002172}
2173
2174impl Interface for VirtualMachineService {}
2175
2176impl IVirtualMachineService for VirtualMachineService {
Inseob Kimc7d28c72021-10-25 14:28:10 +00002177 fn notifyPayloadStarted(&self) -> binder::Result<()> {
2178 let cid = self.cid;
Inseob Kim7f61fe72021-08-20 20:50:47 +09002179 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01002180 info!("VM with CID {} started payload", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09002181 vm.update_payload_state(PayloadState::Started)
2182 .or_binder_exception(ExceptionCode::ILLEGAL_STATE)?;
David Brazdil451cc962022-10-14 14:08:12 +01002183 vm.callbacks.notify_payload_started(cid);
Seungjae Yoo62085c02022-08-12 04:44:52 +00002184
Seungjae Yoo6d265d92022-11-15 10:51:33 +09002185 let vm_start_timestamp = vm.vm_metric.lock().unwrap().start_timestamp;
2186 write_vm_booted_stats(vm.requester_uid as i32, &vm.name, vm_start_timestamp);
Inseob Kim7f61fe72021-08-20 20:50:47 +09002187 Ok(())
2188 } else {
Jooyung Handd0a1732021-11-23 15:26:20 +09002189 error!("notifyPayloadStarted is called from an unknown CID {}", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09002190 Err(anyhow!("cannot find a VM with CID {}", cid)).or_service_specific_exception(-1)
Inseob Kim1b95f2e2021-08-19 13:17:40 +09002191 }
Inseob Kim1b95f2e2021-08-19 13:17:40 +09002192 }
Inseob Kim2444af92021-08-31 01:22:50 +09002193
Inseob Kimc7d28c72021-10-25 14:28:10 +00002194 fn notifyPayloadReady(&self) -> binder::Result<()> {
2195 let cid = self.cid;
Inseob Kim14cb8692021-08-31 21:50:39 +09002196 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01002197 info!("VM with CID {} reported payload is ready", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09002198 vm.update_payload_state(PayloadState::Ready)
2199 .or_binder_exception(ExceptionCode::ILLEGAL_STATE)?;
Inseob Kim14cb8692021-08-31 21:50:39 +09002200 vm.callbacks.notify_payload_ready(cid);
2201 Ok(())
2202 } else {
Jooyung Handd0a1732021-11-23 15:26:20 +09002203 error!("notifyPayloadReady is called from an unknown CID {}", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09002204 Err(anyhow!("cannot find a VM with CID {}", cid)).or_service_specific_exception(-1)
Inseob Kim14cb8692021-08-31 21:50:39 +09002205 }
2206 }
2207
Inseob Kimc7d28c72021-10-25 14:28:10 +00002208 fn notifyPayloadFinished(&self, exit_code: i32) -> binder::Result<()> {
2209 let cid = self.cid;
Inseob Kim2444af92021-08-31 01:22:50 +09002210 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01002211 info!("VM with CID {} finished payload", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09002212 vm.update_payload_state(PayloadState::Finished)
2213 .or_binder_exception(ExceptionCode::ILLEGAL_STATE)?;
Inseob Kim2444af92021-08-31 01:22:50 +09002214 vm.callbacks.notify_payload_finished(cid, exit_code);
2215 Ok(())
2216 } else {
Jooyung Handd0a1732021-11-23 15:26:20 +09002217 error!("notifyPayloadFinished is called from an unknown CID {}", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09002218 Err(anyhow!("cannot find a VM with CID {}", cid)).or_service_specific_exception(-1)
Jooyung Handd0a1732021-11-23 15:26:20 +09002219 }
2220 }
2221
Alan Stokes2bead0d2022-09-05 16:58:34 +01002222 fn notifyError(&self, error_code: ErrorCode, message: &str) -> binder::Result<()> {
Jooyung Handd0a1732021-11-23 15:26:20 +09002223 let cid = self.cid;
2224 if let Some(vm) = self.state.lock().unwrap().get_vm(cid) {
David Brazdil415097c2022-10-21 14:17:05 +01002225 info!("VM with CID {} encountered an error", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09002226 vm.update_payload_state(PayloadState::Finished)
2227 .or_binder_exception(ExceptionCode::ILLEGAL_STATE)?;
Jooyung Handd0a1732021-11-23 15:26:20 +09002228 vm.callbacks.notify_error(cid, error_code, message);
2229 Ok(())
2230 } else {
Seungjae Yooec8c1602022-06-20 05:28:00 +00002231 error!("notifyError is called from an unknown CID {}", cid);
Jiyong Park2227eaa2023-08-04 11:59:18 +09002232 Err(anyhow!("cannot find a VM with CID {}", cid)).or_service_specific_exception(-1)
Inseob Kim2444af92021-08-31 01:22:50 +09002233 }
2234 }
Alice Wangc2fec932023-02-23 16:24:02 +00002235
Shikha Panware45e9422024-02-28 21:18:10 +00002236 fn getSecretkeeper(&self) -> binder::Result<Strong<dyn ISecretkeeper>> {
2237 if !is_secretkeeper_supported() {
2238 return Err(StatusCode::NAME_NOT_FOUND)?;
2239 }
2240 let sk = binder::wait_for_interface(SECRETKEEPER_IDENTIFIER)?;
2241 Ok(BnSecretkeeper::new_binder(SecretkeeperProxy(sk), BinderFeatures::default()))
Shikha Panwar5d6a6752023-12-14 22:08:26 +00002242 }
2243
Alice Wange64dd182024-01-17 15:57:55 +00002244 fn requestAttestation(&self, csr: &[u8], test_mode: bool) -> binder::Result<Vec<Certificate>> {
2245 GLOBAL_SERVICE.requestAttestation(csr, get_calling_uid() as i32, test_mode)
Alice Wangc2fec932023-02-23 16:24:02 +00002246 }
Shikha Panwareeae6402025-02-06 19:05:31 +00002247
2248 fn claimSecretkeeperEntry(&self, id: &[u8; 64]) -> binder::Result<()> {
2249 GLOBAL_SERVICE.claimSecretkeeperEntry(id)
2250 }
Inseob Kim1b95f2e2021-08-19 13:17:40 +09002251}
2252
Shikha Panwar8707f0f2024-02-28 20:40:42 +00002253fn is_secretkeeper_supported() -> bool {
Shikha Panwar81d13d32024-03-10 19:39:23 +00002254 binder::is_declared(SECRETKEEPER_IDENTIFIER)
2255 .expect("Could not check for declared Secretkeeper interface")
Shikha Panwar8187ca22024-01-04 08:33:08 +00002256}
2257
Inseob Kim1b95f2e2021-08-19 13:17:40 +09002258impl VirtualMachineService {
Inseob Kimc7d28c72021-10-25 14:28:10 +00002259 fn new_binder(state: Arc<Mutex<State>>, cid: Cid) -> Strong<dyn IVirtualMachineService> {
Inseob Kim1b95f2e2021-08-19 13:17:40 +09002260 BnVirtualMachineService::new_binder(
Inseob Kimc7d28c72021-10-25 14:28:10 +00002261 VirtualMachineService { state, cid },
Inseob Kim1b95f2e2021-08-19 13:17:40 +09002262 BinderFeatures::default(),
2263 )
2264 }
2265}
Alan Stokes53cc5ca2022-08-30 14:28:19 +01002266
Stephen Hines4c1e2fc2024-02-09 16:34:47 -08002267struct SecretkeeperProxy(Strong<dyn ISecretkeeper>);
2268
2269impl Interface for SecretkeeperProxy {}
2270
2271impl ISecretkeeper for SecretkeeperProxy {
2272 fn processSecretManagementRequest(&self, req: &[u8]) -> binder::Result<Vec<u8>> {
2273 // Pass the request to the channel, and read the response.
2274 self.0.processSecretManagementRequest(req)
2275 }
2276
2277 fn getAuthGraphKe(&self) -> binder::Result<Strong<dyn IAuthGraphKeyExchange>> {
2278 let ag = AuthGraphKeyExchangeProxy(self.0.getAuthGraphKe()?);
2279 Ok(BnAuthGraphKeyExchange::new_binder(ag, BinderFeatures::default()))
2280 }
2281
2282 fn deleteIds(&self, ids: &[SecretId]) -> binder::Result<()> {
2283 self.0.deleteIds(ids)
2284 }
2285
2286 fn deleteAll(&self) -> binder::Result<()> {
2287 self.0.deleteAll()
2288 }
Matt Gilbrideb57abcc2024-10-12 15:26:45 +00002289
2290 fn getSecretkeeperIdentity(&self) -> binder::Result<PublicKey> {
2291 // SecretkeeperProxy is really a RPC binder service for PVM (It is called by
2292 // MicrodroidManager). PVMs do not & must not (for security reason) rely on
2293 // getSecretKeeperIdentity, so we throw an exception if someone attempts to
2294 // use this API from the proxy.
2295 Err(ExceptionCode::SECURITY.into())
2296 }
Stephen Hines4c1e2fc2024-02-09 16:34:47 -08002297}
2298
2299struct AuthGraphKeyExchangeProxy(Strong<dyn IAuthGraphKeyExchange>);
2300
2301impl Interface for AuthGraphKeyExchangeProxy {}
2302
2303impl IAuthGraphKeyExchange for AuthGraphKeyExchangeProxy {
2304 fn create(&self) -> binder::Result<SessionInitiationInfo> {
2305 self.0.create()
2306 }
2307
2308 fn init(
2309 &self,
2310 peer_pub_key: &PubKey,
2311 peer_id: &Identity,
2312 peer_nonce: &[u8],
2313 peer_version: i32,
2314 ) -> binder::Result<KeInitResult> {
2315 self.0.init(peer_pub_key, peer_id, peer_nonce, peer_version)
2316 }
2317
2318 fn finish(
2319 &self,
2320 peer_pub_key: &PubKey,
2321 peer_id: &Identity,
2322 peer_signature: &SessionIdSignature,
2323 peer_nonce: &[u8],
2324 peer_version: i32,
2325 own_key: &Key,
2326 ) -> binder::Result<SessionInfo> {
2327 self.0.finish(peer_pub_key, peer_id, peer_signature, peer_nonce, peer_version, own_key)
2328 }
2329
2330 fn authenticationComplete(
2331 &self,
2332 peer_signature: &SessionIdSignature,
2333 shared_keys: &[AuthgraphArc; 2],
2334 ) -> binder::Result<[AuthgraphArc; 2]> {
2335 self.0.authenticationComplete(peer_signature, shared_keys)
2336 }
2337}
2338
Inseob Kimecde8c02024-09-03 13:11:08 +09002339// KEEP IN SYNC WITH early_vms.xsd
Inseob Kim7e1877b2024-11-07 17:28:56 +09002340#[derive(Clone, Debug, Deserialize, PartialEq)]
Inseob Kimecde8c02024-09-03 13:11:08 +09002341struct EarlyVm {
Inseob Kimecde8c02024-09-03 13:11:08 +09002342 name: String,
Inseob Kimecde8c02024-09-03 13:11:08 +09002343 cid: i32,
Inseob Kimecde8c02024-09-03 13:11:08 +09002344 path: String,
2345}
2346
2347#[derive(Debug, Default, Deserialize)]
2348struct EarlyVms {
Inseob Kimecde8c02024-09-03 13:11:08 +09002349 early_vm: Vec<EarlyVm>,
2350}
2351
Alice Wang78dd87a2025-02-13 08:56:07 +00002352impl EarlyVm {
2353 /// Verifies that the provided executable path matches the expected path stored in the XML
2354 /// configuration.
2355 /// If the provided path starts with `/system`, it will be stripped before comparison.
2356 fn check_exe_paths_match<P: AsRef<Path>>(&self, calling_exe_path: P) -> binder::Result<()> {
2357 let actual_path = calling_exe_path.as_ref();
2358 if Path::new(&self.path)
2359 == Path::new("/").join(actual_path.strip_prefix("/system").unwrap_or(actual_path))
2360 {
2361 return Ok(());
2362 }
2363 Err(Status::new_service_specific_error_str(
2364 -1,
2365 Some(format!(
2366 "Early VM '{}' executable paths do not match. Expected: {}. Found: {:?}.",
2367 self.name,
2368 self.path,
2369 actual_path.display()
2370 )),
2371 ))
2372 }
2373}
2374
Frederick Mayle3a46b272025-02-10 21:55:49 -08002375static EARLY_VMS_CACHE: LazyLock<Mutex<HashMap<CallingPartition, Vec<EarlyVm>>>> =
Inseob Kim7e1877b2024-11-07 17:28:56 +09002376 LazyLock::new(|| Mutex::new(HashMap::new()));
2377
Frederick Mayle3a46b272025-02-10 21:55:49 -08002378fn range_for_partition(partition: CallingPartition) -> Range<Cid> {
Inseob Kimecde8c02024-09-03 13:11:08 +09002379 match partition {
Frederick Mayle3a46b272025-02-10 21:55:49 -08002380 CallingPartition::System => 100..200,
2381 CallingPartition::SystemExt | CallingPartition::Product => 200..300,
2382 CallingPartition::Vendor | CallingPartition::Odm => 300..400,
2383 CallingPartition::Unknown => 0..0,
Inseob Kimecde8c02024-09-03 13:11:08 +09002384 }
2385}
2386
Inseob Kim7e1877b2024-11-07 17:28:56 +09002387fn get_early_vms_in_path(xml_path: &Path) -> Result<Vec<EarlyVm>> {
Inseob Kimecde8c02024-09-03 13:11:08 +09002388 if !xml_path.exists() {
2389 bail!("{} doesn't exist", xml_path.display());
2390 }
2391
2392 let xml =
2393 fs::read(xml_path).with_context(|| format!("Failed to read {}", xml_path.display()))?;
2394 let xml = String::from_utf8(xml)
2395 .with_context(|| format!("{} is not a valid UTF-8 file", xml_path.display()))?;
2396 let early_vms: EarlyVms = serde_xml_rs::from_str(&xml)
2397 .with_context(|| format!("Can't parse {}", xml_path.display()))?;
2398
Inseob Kim7e1877b2024-11-07 17:28:56 +09002399 Ok(early_vms.early_vm)
2400}
Inseob Kimecde8c02024-09-03 13:11:08 +09002401
Inseob Kim7e1877b2024-11-07 17:28:56 +09002402fn validate_cid_range(early_vms: &[EarlyVm], cid_range: &Range<Cid>) -> Result<()> {
2403 for early_vm in early_vms {
2404 let cid = early_vm
2405 .cid
2406 .try_into()
2407 .with_context(|| format!("VM '{}' uses Invalid CID {}", early_vm.name, early_vm.cid))?;
2408
2409 ensure!(
2410 cid_range.contains(&cid),
2411 "VM '{}' uses CID {cid} which is out of range. Available CIDs: {cid_range:?}",
2412 early_vm.name
2413 );
2414 }
2415 Ok(())
2416}
2417
Frederick Mayle3a46b272025-02-10 21:55:49 -08002418fn get_early_vms_in_partition(partition: CallingPartition) -> Result<Vec<EarlyVm>> {
Inseob Kim7e1877b2024-11-07 17:28:56 +09002419 let mut cache = EARLY_VMS_CACHE.lock().unwrap();
2420
Frederick Mayle3a46b272025-02-10 21:55:49 -08002421 if let Some(result) = cache.get(&partition) {
Inseob Kim7e1877b2024-11-07 17:28:56 +09002422 return Ok(result.clone());
2423 }
2424
2425 let pattern = format!("/{partition}/etc/avf/early_vms*.xml");
2426 let mut early_vms = Vec::new();
2427 for entry in glob::glob(&pattern).with_context(|| format!("Failed to glob {}", &pattern))? {
2428 match entry {
2429 Ok(path) => early_vms.extend(get_early_vms_in_path(&path)?),
2430 Err(e) => error!("Error while globbing (but continuing) {}: {}", &pattern, e),
2431 }
2432 }
2433
Frederick Mayle3a46b272025-02-10 21:55:49 -08002434 validate_cid_range(&early_vms, &range_for_partition(partition))
Inseob Kim7e1877b2024-11-07 17:28:56 +09002435 .with_context(|| format!("CID validation for {partition} failed"))?;
2436
Frederick Mayle3a46b272025-02-10 21:55:49 -08002437 cache.insert(partition, early_vms.clone());
Inseob Kim7e1877b2024-11-07 17:28:56 +09002438
2439 Ok(early_vms)
2440}
2441
2442fn find_early_vm<'a>(early_vms: &'a [EarlyVm], name: &str) -> Result<&'a EarlyVm> {
2443 let mut found_vm: Option<&EarlyVm> = None;
2444
2445 for early_vm in early_vms {
Inseob Kimecde8c02024-09-03 13:11:08 +09002446 if early_vm.name != name {
2447 continue;
2448 }
2449
Inseob Kimecde8c02024-09-03 13:11:08 +09002450 if found_vm.is_some() {
Inseob Kim7e1877b2024-11-07 17:28:56 +09002451 bail!("Multiple VMs named '{name}' are found");
Inseob Kimecde8c02024-09-03 13:11:08 +09002452 }
2453
2454 found_vm = Some(early_vm);
2455 }
2456
Inseob Kim7e1877b2024-11-07 17:28:56 +09002457 found_vm.ok_or_else(|| anyhow!("Can't find a VM named '{name}'"))
Inseob Kimecde8c02024-09-03 13:11:08 +09002458}
2459
Frederick Mayle3a46b272025-02-10 21:55:49 -08002460fn find_early_vm_for_partition(partition: CallingPartition, name: &str) -> Result<EarlyVm> {
Inseob Kim7e1877b2024-11-07 17:28:56 +09002461 let early_vms = get_early_vms_in_partition(partition)
2462 .with_context(|| format!("Failed to get early VMs from {partition}"))?;
2463
2464 Ok(find_early_vm(&early_vms, name)
2465 .with_context(|| format!("Failed to find early VM '{name}' in {partition}"))?
2466 .clone())
Inseob Kimecde8c02024-09-03 13:11:08 +09002467}
2468
Alan Stokes53cc5ca2022-08-30 14:28:19 +01002469#[cfg(test)]
2470mod tests {
2471 use super::*;
2472
2473 #[test]
2474 fn test_is_allowed_label_for_partition() -> Result<()> {
2475 let expected_results = vec![
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08002476 (CallingPartition::System, "u:object_r:system_file:s0", true),
2477 (CallingPartition::System, "u:object_r:apk_data_file:s0", true),
2478 (CallingPartition::System, "u:object_r:app_data_file:s0", false),
2479 (CallingPartition::System, "u:object_r:app_data_file:s0:c512,c768", false),
2480 (CallingPartition::System, "u:object_r:privapp_data_file:s0:c512,c768", false),
2481 (CallingPartition::System, "invalid", false),
2482 (CallingPartition::System, "user:role:apk_data_file:severity:categories", true),
2483 (
2484 CallingPartition::System,
2485 "user:role:apk_data_file:severity:categories:extraneous",
2486 false,
2487 ),
2488 (CallingPartition::System, "u:object_r:vendor_unknowable:s0", false),
2489 (CallingPartition::Vendor, "u:object_r:vendor_unknowable:s0", true),
Alan Stokes53cc5ca2022-08-30 14:28:19 +01002490 ];
2491
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08002492 for (calling_partition, label, expected_valid) in expected_results {
Alan Stokes53cc5ca2022-08-30 14:28:19 +01002493 let context = SeContext::new(label)?;
Frederick Mayle50c2b6a2025-02-11 18:26:04 -08002494 let result = check_label_is_allowed(&context, calling_partition);
2495 if expected_valid != result.is_ok() {
2496 bail!(
2497 "Expected label {label} to be {} for {calling_partition} partition",
2498 if expected_valid { "allowed" } else { "disallowed" }
2499 );
Alan Stokes53cc5ca2022-08-30 14:28:19 +01002500 }
2501 }
2502 Ok(())
2503 }
Nikita Ioffef1ce9872022-12-09 13:31:59 +00002504
2505 #[test]
2506 fn test_create_or_update_idsig_file_empty_apk() -> Result<()> {
2507 let apk = tempfile::tempfile().unwrap();
2508 let idsig = tempfile::tempfile().unwrap();
2509
2510 let ret = create_or_update_idsig_file(
2511 &ParcelFileDescriptor::new(apk),
2512 &ParcelFileDescriptor::new(idsig),
2513 );
2514 assert!(ret.is_err(), "should fail");
2515 Ok(())
2516 }
2517
2518 #[test]
2519 fn test_create_or_update_idsig_dir_instead_of_file_for_apk() -> Result<()> {
2520 let tmp_dir = tempfile::TempDir::new().unwrap();
2521 let apk = File::open(tmp_dir.path()).unwrap();
2522 let idsig = tempfile::tempfile().unwrap();
2523
2524 let ret = create_or_update_idsig_file(
2525 &ParcelFileDescriptor::new(apk),
2526 &ParcelFileDescriptor::new(idsig),
2527 );
2528 assert!(ret.is_err(), "should fail");
2529 Ok(())
2530 }
2531
2532 /// Verifies that create_or_update_idsig_file won't oom if a fd that corresponds to a directory
2533 /// on ext4 filesystem is passed.
2534 /// On ext4 lseek on a directory fd will return (off_t)-1 (see:
2535 /// https://bugzilla.kernel.org/show_bug.cgi?id=200043), which will result in
2536 /// create_or_update_idsig_file ooming while attempting to allocate petabytes of memory.
2537 #[test]
2538 fn test_create_or_update_idsig_does_not_crash_dir_on_ext4() -> Result<()> {
2539 // APEXes are backed by the ext4.
2540 let apk = File::open("/apex/com.android.virt/").unwrap();
2541 let idsig = tempfile::tempfile().unwrap();
2542
2543 let ret = create_or_update_idsig_file(
2544 &ParcelFileDescriptor::new(apk),
2545 &ParcelFileDescriptor::new(idsig),
2546 );
2547 assert!(ret.is_err(), "should fail");
2548 Ok(())
2549 }
Jiyong Park8d192952023-06-26 14:29:51 +09002550
2551 #[test]
2552 fn test_create_or_update_idsig_does_not_update_if_already_valid() -> Result<()> {
2553 use std::io::Seek;
2554
2555 // Pick any APK
2556 let mut apk = File::open("/system/priv-app/Shell/Shell.apk").unwrap();
2557 let mut idsig = tempfile::tempfile().unwrap();
2558
2559 create_or_update_idsig_file(
2560 &ParcelFileDescriptor::new(apk.try_clone()?),
2561 &ParcelFileDescriptor::new(idsig.try_clone()?),
2562 )?;
2563 let modified_orig = idsig.metadata()?.modified()?;
2564 apk.rewind()?;
2565 idsig.rewind()?;
2566
2567 // Call the function again
2568 create_or_update_idsig_file(
2569 &ParcelFileDescriptor::new(apk.try_clone()?),
2570 &ParcelFileDescriptor::new(idsig.try_clone()?),
2571 )?;
2572 let modified_new = idsig.metadata()?.modified()?;
2573 assert!(modified_orig == modified_new, "idsig file was updated unnecessarily");
2574 Ok(())
2575 }
Nikita Ioffeaa6858c2023-07-04 01:37:41 +01002576
2577 #[test]
Shikha Panwar9ae2e622024-01-30 12:22:30 +00002578 fn test_create_or_update_idsig_on_non_empty_file() -> Result<()> {
2579 use std::io::Read;
2580
2581 // Pick any APK
2582 let mut apk = File::open("/system/priv-app/Shell/Shell.apk").unwrap();
2583 let idsig_empty = tempfile::tempfile().unwrap();
2584 let mut idsig_invalid = tempfile::tempfile().unwrap();
2585 idsig_invalid.write_all(b"Oops")?;
2586
2587 // Create new idsig
2588 create_or_update_idsig_file(
2589 &ParcelFileDescriptor::new(apk.try_clone()?),
2590 &ParcelFileDescriptor::new(idsig_empty.try_clone()?),
2591 )?;
2592 apk.rewind()?;
2593
2594 // Update idsig_invalid
2595 create_or_update_idsig_file(
2596 &ParcelFileDescriptor::new(apk.try_clone()?),
2597 &ParcelFileDescriptor::new(idsig_invalid.try_clone()?),
2598 )?;
2599
2600 // Ensure the 2 idsig files have same size!
2601 assert!(
2602 idsig_empty.metadata()?.len() == idsig_invalid.metadata()?.len(),
2603 "idsig files differ in size"
2604 );
2605 // Ensure the 2 idsig files have same content!
2606 for (b1, b2) in idsig_empty.bytes().zip(idsig_invalid.bytes()) {
2607 assert!(b1.unwrap() == b2.unwrap(), "idsig files differ")
2608 }
2609 Ok(())
2610 }
2611 #[test]
Nikita Ioffeaa6858c2023-07-04 01:37:41 +01002612 fn test_append_kernel_param_first_param() {
2613 let mut vm_config = VirtualMachineRawConfig { ..Default::default() };
2614 append_kernel_param("foo=1", &mut vm_config);
2615 assert_eq!(vm_config.params, Some("foo=1".to_owned()))
2616 }
2617
2618 #[test]
2619 fn test_append_kernel_param() {
2620 let mut vm_config =
2621 VirtualMachineRawConfig { params: Some("foo=5".to_owned()), ..Default::default() };
2622 append_kernel_param("bar=42", &mut vm_config);
2623 assert_eq!(vm_config.params, Some("foo=5 bar=42".to_owned()))
2624 }
Seungjae Yooec3bc522023-11-09 10:14:30 +09002625
Inseob Kim46257382024-01-03 15:41:22 +09002626 fn test_extract_os_name_from_config_path(
2627 path: &Path,
2628 expected_result: Option<&str>,
2629 ) -> Result<()> {
2630 let result = extract_os_name_from_config_path(path);
2631 if result.as_deref() != expected_result {
2632 bail!("Expected {:?} but was {:?}", expected_result, &result)
2633 }
2634 Ok(())
2635 }
2636
2637 #[test]
2638 fn test_extract_os_name_from_microdroid_config() -> Result<()> {
2639 test_extract_os_name_from_config_path(
2640 Path::new("/apex/com.android.virt/etc/microdroid.json"),
2641 Some("microdroid"),
2642 )
2643 }
2644
2645 #[test]
Nikita Ioffef49350e2024-11-01 16:11:48 +00002646 fn test_extract_os_name_from_microdroid_16k_config() -> Result<()> {
2647 test_extract_os_name_from_config_path(
2648 Path::new("/apex/com.android.virt/etc/microdroid_16k.json"),
2649 Some("microdroid_16k"),
2650 )
2651 }
2652
2653 #[test]
Inseob Kim46257382024-01-03 15:41:22 +09002654 fn test_extract_os_name_from_microdroid_gki_config() -> Result<()> {
2655 test_extract_os_name_from_config_path(
2656 Path::new("/apex/com.android.virt/etc/microdroid_gki-android14-6.1.json"),
2657 Some("microdroid_gki-android14-6.1"),
2658 )
2659 }
2660
2661 #[test]
2662 fn test_extract_os_name_from_invalid_path() -> Result<()> {
2663 test_extract_os_name_from_config_path(
2664 Path::new("/apex/com.android.virt/etc/microdroid.img"),
2665 None,
2666 )
2667 }
2668
2669 #[test]
2670 fn test_extract_os_name_from_configs() -> Result<()> {
2671 let tmp_dir = tempfile::TempDir::new()?;
2672 let tmp_dir_path = tmp_dir.path().to_owned();
2673
2674 let mut os_names: HashSet<String> = HashSet::new();
2675 os_names.insert("microdroid".to_owned());
2676 os_names.insert("microdroid_gki-android14-6.1".to_owned());
2677 os_names.insert("microdroid_gki-android15-6.1".to_owned());
2678
2679 // config files
2680 for os_name in &os_names {
2681 std::fs::write(tmp_dir_path.join(os_name.to_owned() + ".json"), b"")?;
2682 }
2683
2684 // fake files not related to configs
2685 std::fs::write(tmp_dir_path.join("microdroid_super.img"), b"")?;
2686 std::fs::write(tmp_dir_path.join("microdroid_foobar.apk"), b"")?;
2687
2688 let glob_pattern = match tmp_dir_path.join("microdroid*.json").to_str() {
2689 Some(s) => s.to_owned(),
2690 None => bail!("tmp_dir_path {:?} is not UTF-8", tmp_dir_path),
2691 };
2692
2693 let result = extract_os_names_from_configs(&glob_pattern)?;
2694 if result != os_names {
2695 bail!("Expected {:?} but was {:?}", os_names, result);
2696 }
2697 Ok(())
2698 }
Inseob Kimecde8c02024-09-03 13:11:08 +09002699
2700 #[test]
2701 fn test_find_early_vms_from_xml() -> Result<()> {
2702 let tmp_dir = tempfile::TempDir::new()?;
2703 let tmp_dir_path = tmp_dir.path().to_owned();
2704 let xml_path = tmp_dir_path.join("early_vms.xml");
2705
2706 std::fs::write(
2707 &xml_path,
2708 br#"<?xml version="1.0" encoding="utf-8"?>
2709 <early_vms>
2710 <early_vm>
2711 <name>vm_demo_native_early</name>
2712 <cid>123</cid>
2713 <path>/system/bin/vm_demo_native_early</path>
2714 </early_vm>
2715 <early_vm>
Inseob Kim7e1877b2024-11-07 17:28:56 +09002716 <name>vm_demo_native_early_2</name>
2717 <cid>456</cid>
2718 <path>/system/bin/vm_demo_native_early_2</path>
2719 </early_vm>
2720 </early_vms>
2721 "#,
2722 )?;
2723
2724 let cid_range = 100..1000;
2725
2726 let early_vms = get_early_vms_in_path(&xml_path)?;
2727 validate_cid_range(&early_vms, &cid_range)?;
2728
2729 let test_cases = [
2730 (
2731 "vm_demo_native_early",
2732 EarlyVm {
2733 name: "vm_demo_native_early".to_owned(),
2734 cid: 123,
2735 path: "/system/bin/vm_demo_native_early".to_owned(),
2736 },
2737 ),
2738 (
2739 "vm_demo_native_early_2",
2740 EarlyVm {
2741 name: "vm_demo_native_early_2".to_owned(),
2742 cid: 456,
2743 path: "/system/bin/vm_demo_native_early_2".to_owned(),
2744 },
2745 ),
2746 ];
2747
2748 for (name, expected) in test_cases {
2749 let result = find_early_vm(&early_vms, name)?;
2750 assert_eq!(result, &expected);
2751 }
2752
2753 Ok(())
2754 }
2755
2756 #[test]
2757 fn test_invalid_cid_validation() -> Result<()> {
2758 let tmp_dir = tempfile::TempDir::new()?;
2759 let xml_path = tmp_dir.path().join("early_vms.xml");
2760
2761 let cid_range = 100..1000;
2762
2763 for cid in [-1, 999999] {
2764 std::fs::write(
2765 &xml_path,
2766 format!(
2767 r#"<?xml version="1.0" encoding="utf-8"?>
2768 <early_vms>
2769 <early_vm>
2770 <name>vm_demo_invalid_cid</name>
2771 <cid>{cid}</cid>
2772 <path>/system/bin/vm_demo_invalid_cid</path>
2773 </early_vm>
2774 </early_vms>
2775 "#
2776 ),
2777 )?;
2778
2779 let early_vms = get_early_vms_in_path(&xml_path)?;
2780 assert!(validate_cid_range(&early_vms, &cid_range).is_err(), "should fail");
2781 }
2782
2783 Ok(())
2784 }
2785
2786 #[test]
Armelle Laine1a25d982025-01-31 06:39:54 +00002787 fn test_symlink_to_system_ext_supported() -> Result<()> {
2788 let link_path = Path::new("/system/system_ext/file");
2789 let partition = find_partition(Some(link_path)).unwrap();
Frederick Mayle3a46b272025-02-10 21:55:49 -08002790 assert_eq!(CallingPartition::SystemExt, partition);
Armelle Laine1a25d982025-01-31 06:39:54 +00002791 Ok(())
2792 }
2793
2794 #[test]
2795 fn test_symlink_to_product_supported() -> Result<()> {
2796 let link_path = Path::new("/system/product/file");
2797 let partition = find_partition(Some(link_path)).unwrap();
Frederick Mayle3a46b272025-02-10 21:55:49 -08002798 assert_eq!(CallingPartition::Product, partition);
Armelle Laine1a25d982025-01-31 06:39:54 +00002799 Ok(())
2800 }
2801
2802 #[test]
Frederick Mayle2192baf2025-02-26 11:27:22 -08002803 fn test_vendor_in_data() {
2804 assert_eq!(
2805 CallingPartition::Vendor,
2806 find_partition(Some(Path::new("/data/nativetest64/vendor/file"))).unwrap()
2807 );
2808 }
2809
2810 #[test]
Alice Wang78dd87a2025-02-13 08:56:07 +00002811 fn early_vm_exe_paths_match_succeeds_with_same_paths() {
2812 let early_vm = EarlyVm {
2813 name: "vm_demo_native_early".to_owned(),
2814 cid: 123,
2815 path: "/system_ext/bin/vm_demo_native_early".to_owned(),
2816 };
2817 let calling_exe_path = "/system_ext/bin/vm_demo_native_early";
2818 assert!(early_vm.check_exe_paths_match(calling_exe_path).is_ok())
2819 }
2820
2821 #[test]
2822 fn early_vm_exe_paths_match_succeeds_with_calling_exe_path_from_system() {
2823 let early_vm = EarlyVm {
2824 name: "vm_demo_native_early".to_owned(),
2825 cid: 123,
2826 path: "/system_ext/bin/vm_demo_native_early".to_owned(),
2827 };
2828 let calling_exe_path = "/system/system_ext/bin/vm_demo_native_early";
2829 assert!(early_vm.check_exe_paths_match(calling_exe_path).is_ok())
2830 }
2831
2832 #[test]
2833 fn early_vm_exe_paths_match_fails_with_unmatched_paths() {
2834 let early_vm = EarlyVm {
2835 name: "vm_demo_native_early".to_owned(),
2836 cid: 123,
2837 path: "/system_ext/bin/vm_demo_native_early".to_owned(),
2838 };
2839 let calling_exe_path = "/system/etc/system_ext/bin/vm_demo_native_early";
2840 assert!(early_vm.check_exe_paths_match(calling_exe_path).is_err())
2841 }
2842
2843 #[test]
Inseob Kim7e1877b2024-11-07 17:28:56 +09002844 fn test_duplicated_early_vms() -> Result<()> {
2845 let tmp_dir = tempfile::TempDir::new()?;
2846 let tmp_dir_path = tmp_dir.path().to_owned();
2847 let xml_path = tmp_dir_path.join("early_vms.xml");
2848
2849 std::fs::write(
2850 &xml_path,
2851 br#"<?xml version="1.0" encoding="utf-8"?>
2852 <early_vms>
2853 <early_vm>
Inseob Kimecde8c02024-09-03 13:11:08 +09002854 <name>vm_demo_duplicated_name</name>
2855 <cid>456</cid>
2856 <path>/system/bin/vm_demo_duplicated_name_1</path>
2857 </early_vm>
2858 <early_vm>
2859 <name>vm_demo_duplicated_name</name>
2860 <cid>789</cid>
2861 <path>/system/bin/vm_demo_duplicated_name_2</path>
2862 </early_vm>
Inseob Kimecde8c02024-09-03 13:11:08 +09002863 </early_vms>
2864 "#,
2865 )?;
2866
2867 let cid_range = 100..1000;
2868
Inseob Kim7e1877b2024-11-07 17:28:56 +09002869 let early_vms = get_early_vms_in_path(&xml_path)?;
2870 validate_cid_range(&early_vms, &cid_range)?;
Inseob Kimecde8c02024-09-03 13:11:08 +09002871
Inseob Kim7e1877b2024-11-07 17:28:56 +09002872 assert!(find_early_vm(&early_vms, "vm_demo_duplicated_name").is_err(), "should fail");
Inseob Kimecde8c02024-09-03 13:11:08 +09002873
2874 Ok(())
2875 }
Alan Stokes53cc5ca2022-08-30 14:28:19 +01002876}