blob: 0e2f25bf10b5c37d601ba7aae20212d263d52a7f [file] [log] [blame]
Motomu Utsumiceb2a752022-10-04 18:38:04 +09001// Baseline format: 1.0
2AcronymName: org.chromium.net.CronetEngine#createURLStreamHandlerFactory():
3 Acronyms should not be capitalized in method names: was `createURLStreamHandlerFactory`, should this be `createUrlStreamHandlerFactory`?
4
5
6AndroidUri: org.chromium.net.CronetEngine#createURLStreamHandlerFactory():
7 Use android.net.Uri instead of java.net.URL (method org.chromium.net.CronetEngine.createURLStreamHandlerFactory())
8AndroidUri: org.chromium.net.CronetEngine#openConnection(java.net.URL):
9 Use android.net.Uri instead of java.net.URL (method org.chromium.net.CronetEngine.openConnection(java.net.URL))
10AndroidUri: org.chromium.net.CronetEngine#openConnection(java.net.URL) parameter #0:
11 Use android.net.Uri instead of java.net.URL (parameter url in org.chromium.net.CronetEngine.openConnection(java.net.URL url))
12
13
14BuilderSetStyle: org.chromium.net.CronetEngine.Builder#enableBrotli(boolean):
15 Builder methods names should use setFoo() / addFoo() / clearFoo() style: method org.chromium.net.CronetEngine.Builder.enableBrotli(boolean)
16BuilderSetStyle: org.chromium.net.CronetEngine.Builder#enableHttp2(boolean):
17 Builder methods names should use setFoo() / addFoo() / clearFoo() style: method org.chromium.net.CronetEngine.Builder.enableHttp2(boolean)
18BuilderSetStyle: org.chromium.net.CronetEngine.Builder#enableHttpCache(int, long):
19 Builder methods names should use setFoo() / addFoo() / clearFoo() style: method org.chromium.net.CronetEngine.Builder.enableHttpCache(int,long)
20BuilderSetStyle: org.chromium.net.CronetEngine.Builder#enablePublicKeyPinningBypassForLocalTrustAnchors(boolean):
21 Builder methods names should use setFoo() / addFoo() / clearFoo() style: method org.chromium.net.CronetEngine.Builder.enablePublicKeyPinningBypassForLocalTrustAnchors(boolean)
22BuilderSetStyle: org.chromium.net.CronetEngine.Builder#enableQuic(boolean):
23 Builder methods names should use setFoo() / addFoo() / clearFoo() style: method org.chromium.net.CronetEngine.Builder.enableQuic(boolean)
24BuilderSetStyle: org.chromium.net.UrlRequest.Builder#allowDirectExecutor():
25 Builder methods names should use setFoo() / addFoo() / clearFoo() style: method org.chromium.net.UrlRequest.Builder.allowDirectExecutor()
26BuilderSetStyle: org.chromium.net.UrlRequest.Builder#disableCache():
27 Builder methods names should use setFoo() / addFoo() / clearFoo() style: method org.chromium.net.UrlRequest.Builder.disableCache()
28
29
30ExecutorRegistration: org.chromium.net.UrlRequest#getStatus(org.chromium.net.UrlRequest.StatusListener):
31 Registration methods should have overload that accepts delivery Executor: `getStatus`
32
33
34GenericException: org.chromium.net.UrlRequest.Callback#onReadCompleted(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, java.nio.ByteBuffer):
35 Methods must not throw generic exceptions (`java.lang.Exception`)
36GenericException: org.chromium.net.UrlRequest.Callback#onRedirectReceived(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, String):
37 Methods must not throw generic exceptions (`java.lang.Exception`)
38GenericException: org.chromium.net.UrlRequest.Callback#onResponseStarted(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo):
39 Methods must not throw generic exceptions (`java.lang.Exception`)
40
41
42GetterOnBuilder: org.chromium.net.CronetEngine.Builder#getDefaultUserAgent():
43 Getter should be on the built object, not the builder: method org.chromium.net.CronetEngine.Builder.getDefaultUserAgent()
44
45
46ListenerInterface: org.chromium.net.UrlRequest.StatusListener:
47 Listeners should be an interface, or otherwise renamed Callback: StatusListener
48
49
50ListenerLast: org.chromium.net.CronetEngine#newUrlRequestBuilder(String, org.chromium.net.UrlRequest.Callback, java.util.concurrent.Executor) parameter #2:
51 Listeners should always be at end of argument list (method `newUrlRequestBuilder`)
52
53
54MissingGetterMatchingBuilder: org.chromium.net.CronetEngine.Builder#addPublicKeyPins(String, java.util.Set<byte[]>, boolean, java.util.Date):
55 org.chromium.net.CronetEngine does not declare a `getPublicKeyPinss()` method matching method org.chromium.net.CronetEngine.Builder.addPublicKeyPins(String,java.util.Set<byte[]>,boolean,java.util.Date)
56MissingGetterMatchingBuilder: org.chromium.net.CronetEngine.Builder#addQuicHint(String, int, int):
57 org.chromium.net.CronetEngine does not declare a `getQuicHints()` method matching method org.chromium.net.CronetEngine.Builder.addQuicHint(String,int,int)
58MissingGetterMatchingBuilder: org.chromium.net.CronetEngine.Builder#setLibraryLoader(org.chromium.net.CronetEngine.Builder.LibraryLoader):
59 org.chromium.net.CronetEngine does not declare a `getLibraryLoader()` method matching method org.chromium.net.CronetEngine.Builder.setLibraryLoader(org.chromium.net.CronetEngine.Builder.LibraryLoader)
60MissingGetterMatchingBuilder: org.chromium.net.CronetEngine.Builder#setStoragePath(String):
61 org.chromium.net.CronetEngine does not declare a `getStoragePath()` method matching method org.chromium.net.CronetEngine.Builder.setStoragePath(String)
62MissingGetterMatchingBuilder: org.chromium.net.CronetEngine.Builder#setUserAgent(String):
63 org.chromium.net.CronetEngine does not declare a `getUserAgent()` method matching method org.chromium.net.CronetEngine.Builder.setUserAgent(String)
64MissingGetterMatchingBuilder: org.chromium.net.UrlRequest.Builder#addHeader(String, String):
65 org.chromium.net.UrlRequest does not declare a `getHeaders()` method matching method org.chromium.net.UrlRequest.Builder.addHeader(String,String)
66MissingGetterMatchingBuilder: org.chromium.net.UrlRequest.Builder#setHttpMethod(String):
67 org.chromium.net.UrlRequest does not declare a `getHttpMethod()` method matching method org.chromium.net.UrlRequest.Builder.setHttpMethod(String)
68MissingGetterMatchingBuilder: org.chromium.net.UrlRequest.Builder#setPriority(int):
69 org.chromium.net.UrlRequest does not declare a `getPriority()` method matching method org.chromium.net.UrlRequest.Builder.setPriority(int)
70MissingGetterMatchingBuilder: org.chromium.net.UrlRequest.Builder#setUploadDataProvider(org.chromium.net.UploadDataProvider, java.util.concurrent.Executor):
71 org.chromium.net.UrlRequest does not declare a `getUploadDataProvider()` method matching method org.chromium.net.UrlRequest.Builder.setUploadDataProvider(org.chromium.net.UploadDataProvider,java.util.concurrent.Executor)
72
73
74MissingNullability: org.chromium.net.CallbackException#CallbackException(String, Throwable) parameter #0:
75 Missing nullability on parameter `message` in method `CallbackException`
76MissingNullability: org.chromium.net.CallbackException#CallbackException(String, Throwable) parameter #1:
77 Missing nullability on parameter `cause` in method `CallbackException`
78MissingNullability: org.chromium.net.CronetEngine#createURLStreamHandlerFactory():
79 Missing nullability on method `createURLStreamHandlerFactory` return
80MissingNullability: org.chromium.net.CronetEngine#getGlobalMetricsDeltas():
81 Missing nullability on method `getGlobalMetricsDeltas` return
82MissingNullability: org.chromium.net.CronetEngine#getVersionString():
83 Missing nullability on method `getVersionString` return
84MissingNullability: org.chromium.net.CronetEngine#newUrlRequestBuilder(String, org.chromium.net.UrlRequest.Callback, java.util.concurrent.Executor):
85 Missing nullability on method `newUrlRequestBuilder` return
86MissingNullability: org.chromium.net.CronetEngine#newUrlRequestBuilder(String, org.chromium.net.UrlRequest.Callback, java.util.concurrent.Executor) parameter #0:
87 Missing nullability on parameter `url` in method `newUrlRequestBuilder`
88MissingNullability: org.chromium.net.CronetEngine#newUrlRequestBuilder(String, org.chromium.net.UrlRequest.Callback, java.util.concurrent.Executor) parameter #1:
89 Missing nullability on parameter `callback` in method `newUrlRequestBuilder`
90MissingNullability: org.chromium.net.CronetEngine#newUrlRequestBuilder(String, org.chromium.net.UrlRequest.Callback, java.util.concurrent.Executor) parameter #2:
91 Missing nullability on parameter `executor` in method `newUrlRequestBuilder`
92MissingNullability: org.chromium.net.CronetEngine#openConnection(java.net.URL):
93 Missing nullability on method `openConnection` return
94MissingNullability: org.chromium.net.CronetEngine#openConnection(java.net.URL) parameter #0:
95 Missing nullability on parameter `url` in method `openConnection`
96MissingNullability: org.chromium.net.CronetEngine#startNetLogToFile(String, boolean) parameter #0:
97 Missing nullability on parameter `fileName` in method `startNetLogToFile`
98MissingNullability: org.chromium.net.CronetEngine.Builder#Builder(android.content.Context) parameter #0:
99 Missing nullability on parameter `context` in method `Builder`
100MissingNullability: org.chromium.net.CronetEngine.Builder#addPublicKeyPins(String, java.util.Set<byte[]>, boolean, java.util.Date):
101 Missing nullability on method `addPublicKeyPins` return
102MissingNullability: org.chromium.net.CronetEngine.Builder#addPublicKeyPins(String, java.util.Set<byte[]>, boolean, java.util.Date) parameter #0:
103 Missing nullability on parameter `hostName` in method `addPublicKeyPins`
104MissingNullability: org.chromium.net.CronetEngine.Builder#addPublicKeyPins(String, java.util.Set<byte[]>, boolean, java.util.Date) parameter #1:
105 Missing nullability on parameter `pinsSha256` in method `addPublicKeyPins`
106MissingNullability: org.chromium.net.CronetEngine.Builder#addPublicKeyPins(String, java.util.Set<byte[]>, boolean, java.util.Date) parameter #3:
107 Missing nullability on parameter `expirationDate` in method `addPublicKeyPins`
108MissingNullability: org.chromium.net.CronetEngine.Builder#addQuicHint(String, int, int):
109 Missing nullability on method `addQuicHint` return
110MissingNullability: org.chromium.net.CronetEngine.Builder#addQuicHint(String, int, int) parameter #0:
111 Missing nullability on parameter `host` in method `addQuicHint`
112MissingNullability: org.chromium.net.CronetEngine.Builder#build():
113 Missing nullability on method `build` return
114MissingNullability: org.chromium.net.CronetEngine.Builder#enableBrotli(boolean):
115 Missing nullability on method `enableBrotli` return
116MissingNullability: org.chromium.net.CronetEngine.Builder#enableHttp2(boolean):
117 Missing nullability on method `enableHttp2` return
118MissingNullability: org.chromium.net.CronetEngine.Builder#enableHttpCache(int, long):
119 Missing nullability on method `enableHttpCache` return
120MissingNullability: org.chromium.net.CronetEngine.Builder#enablePublicKeyPinningBypassForLocalTrustAnchors(boolean):
121 Missing nullability on method `enablePublicKeyPinningBypassForLocalTrustAnchors` return
122MissingNullability: org.chromium.net.CronetEngine.Builder#enableQuic(boolean):
123 Missing nullability on method `enableQuic` return
124MissingNullability: org.chromium.net.CronetEngine.Builder#getDefaultUserAgent():
125 Missing nullability on method `getDefaultUserAgent` return
126MissingNullability: org.chromium.net.CronetEngine.Builder#setLibraryLoader(org.chromium.net.CronetEngine.Builder.LibraryLoader):
127 Missing nullability on method `setLibraryLoader` return
128MissingNullability: org.chromium.net.CronetEngine.Builder#setLibraryLoader(org.chromium.net.CronetEngine.Builder.LibraryLoader) parameter #0:
129 Missing nullability on parameter `loader` in method `setLibraryLoader`
130MissingNullability: org.chromium.net.CronetEngine.Builder#setStoragePath(String):
131 Missing nullability on method `setStoragePath` return
132MissingNullability: org.chromium.net.CronetEngine.Builder#setStoragePath(String) parameter #0:
133 Missing nullability on parameter `value` in method `setStoragePath`
134MissingNullability: org.chromium.net.CronetEngine.Builder#setUserAgent(String):
135 Missing nullability on method `setUserAgent` return
136MissingNullability: org.chromium.net.CronetEngine.Builder#setUserAgent(String) parameter #0:
137 Missing nullability on parameter `userAgent` in method `setUserAgent`
138MissingNullability: org.chromium.net.CronetEngine.Builder.LibraryLoader#loadLibrary(String) parameter #0:
139 Missing nullability on parameter `libName` in method `loadLibrary`
140MissingNullability: org.chromium.net.CronetException#CronetException(String, Throwable) parameter #0:
141 Missing nullability on parameter `message` in method `CronetException`
142MissingNullability: org.chromium.net.CronetException#CronetException(String, Throwable) parameter #1:
143 Missing nullability on parameter `cause` in method `CronetException`
144MissingNullability: org.chromium.net.NetworkException#NetworkException(String, Throwable) parameter #0:
145 Missing nullability on parameter `message` in method `NetworkException`
146MissingNullability: org.chromium.net.NetworkException#NetworkException(String, Throwable) parameter #1:
147 Missing nullability on parameter `cause` in method `NetworkException`
148MissingNullability: org.chromium.net.QuicException#QuicException(String, Throwable) parameter #0:
149 Missing nullability on parameter `message` in method `QuicException`
150MissingNullability: org.chromium.net.QuicException#QuicException(String, Throwable) parameter #1:
151 Missing nullability on parameter `cause` in method `QuicException`
152MissingNullability: org.chromium.net.UploadDataProvider#read(org.chromium.net.UploadDataSink, java.nio.ByteBuffer) parameter #0:
153 Missing nullability on parameter `uploadDataSink` in method `read`
154MissingNullability: org.chromium.net.UploadDataProvider#read(org.chromium.net.UploadDataSink, java.nio.ByteBuffer) parameter #1:
155 Missing nullability on parameter `byteBuffer` in method `read`
156MissingNullability: org.chromium.net.UploadDataProvider#rewind(org.chromium.net.UploadDataSink) parameter #0:
157 Missing nullability on parameter `uploadDataSink` in method `rewind`
158MissingNullability: org.chromium.net.UploadDataProviders#create(android.os.ParcelFileDescriptor):
159 Missing nullability on method `create` return
160MissingNullability: org.chromium.net.UploadDataProviders#create(android.os.ParcelFileDescriptor) parameter #0:
161 Missing nullability on parameter `fd` in method `create`
162MissingNullability: org.chromium.net.UploadDataProviders#create(byte[]):
163 Missing nullability on method `create` return
164MissingNullability: org.chromium.net.UploadDataProviders#create(byte[]) parameter #0:
165 Missing nullability on parameter `data` in method `create`
166MissingNullability: org.chromium.net.UploadDataProviders#create(byte[], int, int):
167 Missing nullability on method `create` return
168MissingNullability: org.chromium.net.UploadDataProviders#create(byte[], int, int) parameter #0:
169 Missing nullability on parameter `data` in method `create`
170MissingNullability: org.chromium.net.UploadDataProviders#create(java.io.File):
171 Missing nullability on method `create` return
172MissingNullability: org.chromium.net.UploadDataProviders#create(java.io.File) parameter #0:
173 Missing nullability on parameter `file` in method `create`
174MissingNullability: org.chromium.net.UploadDataProviders#create(java.nio.ByteBuffer):
175 Missing nullability on method `create` return
176MissingNullability: org.chromium.net.UploadDataProviders#create(java.nio.ByteBuffer) parameter #0:
177 Missing nullability on parameter `buffer` in method `create`
178MissingNullability: org.chromium.net.UploadDataSink#onReadError(Exception) parameter #0:
179 Missing nullability on parameter `exception` in method `onReadError`
180MissingNullability: org.chromium.net.UploadDataSink#onRewindError(Exception) parameter #0:
181 Missing nullability on parameter `exception` in method `onRewindError`
182MissingNullability: org.chromium.net.UrlRequest#getStatus(org.chromium.net.UrlRequest.StatusListener) parameter #0:
183 Missing nullability on parameter `listener` in method `getStatus`
184MissingNullability: org.chromium.net.UrlRequest#read(java.nio.ByteBuffer) parameter #0:
185 Missing nullability on parameter `buffer` in method `read`
186MissingNullability: org.chromium.net.UrlRequest.Builder#addHeader(String, String):
187 Missing nullability on method `addHeader` return
188MissingNullability: org.chromium.net.UrlRequest.Builder#addHeader(String, String) parameter #0:
189 Missing nullability on parameter `header` in method `addHeader`
190MissingNullability: org.chromium.net.UrlRequest.Builder#addHeader(String, String) parameter #1:
191 Missing nullability on parameter `value` in method `addHeader`
192MissingNullability: org.chromium.net.UrlRequest.Builder#allowDirectExecutor():
193 Missing nullability on method `allowDirectExecutor` return
194MissingNullability: org.chromium.net.UrlRequest.Builder#build():
195 Missing nullability on method `build` return
196MissingNullability: org.chromium.net.UrlRequest.Builder#disableCache():
197 Missing nullability on method `disableCache` return
198MissingNullability: org.chromium.net.UrlRequest.Builder#setHttpMethod(String):
199 Missing nullability on method `setHttpMethod` return
200MissingNullability: org.chromium.net.UrlRequest.Builder#setHttpMethod(String) parameter #0:
201 Missing nullability on parameter `method` in method `setHttpMethod`
202MissingNullability: org.chromium.net.UrlRequest.Builder#setPriority(int):
203 Missing nullability on method `setPriority` return
204MissingNullability: org.chromium.net.UrlRequest.Builder#setUploadDataProvider(org.chromium.net.UploadDataProvider, java.util.concurrent.Executor):
205 Missing nullability on method `setUploadDataProvider` return
206MissingNullability: org.chromium.net.UrlRequest.Builder#setUploadDataProvider(org.chromium.net.UploadDataProvider, java.util.concurrent.Executor) parameter #0:
207 Missing nullability on parameter `uploadDataProvider` in method `setUploadDataProvider`
208MissingNullability: org.chromium.net.UrlRequest.Builder#setUploadDataProvider(org.chromium.net.UploadDataProvider, java.util.concurrent.Executor) parameter #1:
209 Missing nullability on parameter `executor` in method `setUploadDataProvider`
210MissingNullability: org.chromium.net.UrlRequest.Callback#onCanceled(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo) parameter #0:
211 Missing nullability on parameter `request` in method `onCanceled`
212MissingNullability: org.chromium.net.UrlRequest.Callback#onCanceled(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo) parameter #1:
213 Missing nullability on parameter `info` in method `onCanceled`
214MissingNullability: org.chromium.net.UrlRequest.Callback#onFailed(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, org.chromium.net.CronetException) parameter #0:
215 Missing nullability on parameter `request` in method `onFailed`
216MissingNullability: org.chromium.net.UrlRequest.Callback#onFailed(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, org.chromium.net.CronetException) parameter #1:
217 Missing nullability on parameter `info` in method `onFailed`
218MissingNullability: org.chromium.net.UrlRequest.Callback#onFailed(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, org.chromium.net.CronetException) parameter #2:
219 Missing nullability on parameter `error` in method `onFailed`
220MissingNullability: org.chromium.net.UrlRequest.Callback#onReadCompleted(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, java.nio.ByteBuffer) parameter #0:
221 Missing nullability on parameter `request` in method `onReadCompleted`
222MissingNullability: org.chromium.net.UrlRequest.Callback#onReadCompleted(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, java.nio.ByteBuffer) parameter #1:
223 Missing nullability on parameter `info` in method `onReadCompleted`
224MissingNullability: org.chromium.net.UrlRequest.Callback#onReadCompleted(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, java.nio.ByteBuffer) parameter #2:
225 Missing nullability on parameter `byteBuffer` in method `onReadCompleted`
226MissingNullability: org.chromium.net.UrlRequest.Callback#onRedirectReceived(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, String) parameter #0:
227 Missing nullability on parameter `request` in method `onRedirectReceived`
228MissingNullability: org.chromium.net.UrlRequest.Callback#onRedirectReceived(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, String) parameter #1:
229 Missing nullability on parameter `info` in method `onRedirectReceived`
230MissingNullability: org.chromium.net.UrlRequest.Callback#onRedirectReceived(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo, String) parameter #2:
231 Missing nullability on parameter `newLocationUrl` in method `onRedirectReceived`
232MissingNullability: org.chromium.net.UrlRequest.Callback#onResponseStarted(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo) parameter #0:
233 Missing nullability on parameter `request` in method `onResponseStarted`
234MissingNullability: org.chromium.net.UrlRequest.Callback#onResponseStarted(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo) parameter #1:
235 Missing nullability on parameter `info` in method `onResponseStarted`
236MissingNullability: org.chromium.net.UrlRequest.Callback#onSucceeded(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo) parameter #0:
237 Missing nullability on parameter `request` in method `onSucceeded`
238MissingNullability: org.chromium.net.UrlRequest.Callback#onSucceeded(org.chromium.net.UrlRequest, org.chromium.net.UrlResponseInfo) parameter #1:
239 Missing nullability on parameter `info` in method `onSucceeded`
240MissingNullability: org.chromium.net.UrlResponseInfo#getAllHeaders():
241 Missing nullability on method `getAllHeaders` return
242MissingNullability: org.chromium.net.UrlResponseInfo#getAllHeadersAsList():
243 Missing nullability on method `getAllHeadersAsList` return
244MissingNullability: org.chromium.net.UrlResponseInfo#getHttpStatusText():
245 Missing nullability on method `getHttpStatusText` return
246MissingNullability: org.chromium.net.UrlResponseInfo#getNegotiatedProtocol():
247 Missing nullability on method `getNegotiatedProtocol` return
248MissingNullability: org.chromium.net.UrlResponseInfo#getProxyServer():
249 Missing nullability on method `getProxyServer` return
250MissingNullability: org.chromium.net.UrlResponseInfo#getUrl():
251 Missing nullability on method `getUrl` return
252MissingNullability: org.chromium.net.UrlResponseInfo#getUrlChain():
253 Missing nullability on method `getUrlChain` return
254
255
256NotCloseable: org.chromium.net.CronetEngine:
257 Classes that release resources (shutdown()) should implement AutoClosable and CloseGuard: class org.chromium.net.CronetEngine
258
259
260StaticFinalBuilder: org.chromium.net.CronetEngine.Builder:
261 Builder must be final: org.chromium.net.CronetEngine.Builder
262StaticFinalBuilder: org.chromium.net.UrlRequest.Builder:
263 Builder must be final: org.chromium.net.UrlRequest.Builder