Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 1 | /* |
Kevin Rocard | 96d2cd9 | 2018-11-14 16:22:07 -0800 | [diff] [blame] | 2 | * Copyright (C) 2018 The Android Open Source Project |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Mikhail Naganov | 0dbf398 | 2021-01-08 17:48:22 -0800 | [diff] [blame] | 17 | #include <vector> |
| 18 | |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 19 | #define LOG_TAG "AudioEffectHidlHalTest" |
| 20 | #include <android-base/logging.h> |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 21 | #if MAJOR_VERSION <= 6 |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 22 | #include <system/audio.h> |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 23 | #endif |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 24 | |
Kevin Rocard | 96d2cd9 | 2018-11-14 16:22:07 -0800 | [diff] [blame] | 25 | #include PATH(android/hardware/audio/effect/FILE_VERSION/IEffect.h) |
| 26 | #include PATH(android/hardware/audio/effect/FILE_VERSION/IEffectsFactory.h) |
| 27 | #include PATH(android/hardware/audio/effect/FILE_VERSION/IEqualizerEffect.h) |
| 28 | #include PATH(android/hardware/audio/effect/FILE_VERSION/ILoudnessEnhancerEffect.h) |
| 29 | #include PATH(android/hardware/audio/effect/FILE_VERSION/types.h) |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 30 | #include <android/hidl/allocator/1.0/IAllocator.h> |
| 31 | #include <android/hidl/memory/1.0/IMemory.h> |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 32 | #if MAJOR_VERSION >= 7 |
Hayden Gomes | 4e7d69e | 2020-11-06 15:15:26 -0800 | [diff] [blame] | 33 | #include <android_audio_policy_configuration_V7_0-enums.h> |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 34 | #endif |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 35 | |
Kevin Rocard | f5305b3 | 2018-11-13 10:41:53 -0800 | [diff] [blame] | 36 | #include <common/all-versions/VersionUtils.h> |
| 37 | |
Mikhail Naganov | 978a0f9 | 2022-08-05 00:24:27 +0000 | [diff] [blame] | 38 | #include <cutils/properties.h> |
Mikhail Naganov | 315ce41 | 2019-10-23 16:46:54 -0700 | [diff] [blame] | 39 | #include <gtest/gtest.h> |
| 40 | #include <hidl/GtestPrinter.h> |
| 41 | #include <hidl/ServiceManagement.h> |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 42 | |
Mikhail Naganov | 00a44c0 | 2018-12-14 14:31:45 -0800 | [diff] [blame] | 43 | using ::android::sp; |
| 44 | using ::android::hardware::hidl_handle; |
| 45 | using ::android::hardware::hidl_memory; |
| 46 | using ::android::hardware::hidl_string; |
| 47 | using ::android::hardware::hidl_vec; |
| 48 | using ::android::hardware::MQDescriptorSync; |
| 49 | using ::android::hardware::Return; |
| 50 | using ::android::hardware::Void; |
| 51 | using ::android::hardware::audio::common::utils::mkEnumBitfield; |
| 52 | using ::android::hidl::allocator::V1_0::IAllocator; |
| 53 | using ::android::hidl::memory::V1_0::IMemory; |
Mikhail Naganov | 40fde0b | 2022-01-18 23:54:27 +0000 | [diff] [blame] | 54 | using namespace ::android::hardware::audio::common::COMMON_TYPES_CPP_VERSION; |
Mikhail Naganov | 00a44c0 | 2018-12-14 14:31:45 -0800 | [diff] [blame] | 55 | using namespace ::android::hardware::audio::effect::CPP_VERSION; |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 56 | #if MAJOR_VERSION >= 7 |
| 57 | // Make an alias for enumerations generated from the APM config XSD. |
| 58 | namespace xsd { |
Hayden Gomes | 4e7d69e | 2020-11-06 15:15:26 -0800 | [diff] [blame] | 59 | using namespace ::android::audio::policy::configuration::CPP_VERSION; |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 60 | } |
| 61 | #endif |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 62 | |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 63 | #ifndef ARRAY_SIZE |
| 64 | #define ARRAY_SIZE(a) (sizeof(a) / sizeof(*(a))) |
| 65 | #endif |
| 66 | |
Mikhail Naganov | 315ce41 | 2019-10-23 16:46:54 -0700 | [diff] [blame] | 67 | class AudioEffectsFactoryHidlTest : public ::testing::TestWithParam<std::string> { |
| 68 | public: |
| 69 | void SetUp() override { |
| 70 | effectsFactory = IEffectsFactory::getService(GetParam()); |
| 71 | ASSERT_NE(effectsFactory, nullptr); |
| 72 | } |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 73 | void TearDown() override { effectsFactory.clear(); } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 74 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 75 | protected: |
| 76 | static void description(const std::string& description) { |
| 77 | RecordProperty("description", description); |
| 78 | } |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 79 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 80 | sp<IEffectsFactory> effectsFactory; |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 81 | }; |
| 82 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 83 | TEST_P(AudioEffectsFactoryHidlTest, EnumerateEffects) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 84 | description("Verify that EnumerateEffects returns at least one effect"); |
| 85 | Result retval = Result::NOT_INITIALIZED; |
| 86 | size_t effectCount = 0; |
| 87 | Return<void> ret = |
| 88 | effectsFactory->getAllDescriptors([&](Result r, const hidl_vec<EffectDescriptor>& result) { |
| 89 | retval = r; |
| 90 | effectCount = result.size(); |
| 91 | }); |
| 92 | EXPECT_TRUE(ret.isOk()); |
| 93 | EXPECT_EQ(Result::OK, retval); |
| 94 | EXPECT_GT(effectCount, 0u); |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 95 | } |
| 96 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 97 | TEST_P(AudioEffectsFactoryHidlTest, CreateEffect) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 98 | description("Verify that an effect can be created via CreateEffect"); |
| 99 | bool gotEffect = false; |
| 100 | Uuid effectUuid; |
| 101 | Return<void> ret = |
| 102 | effectsFactory->getAllDescriptors([&](Result r, const hidl_vec<EffectDescriptor>& result) { |
| 103 | if (r == Result::OK && result.size() > 0) { |
| 104 | gotEffect = true; |
| 105 | effectUuid = result[0].uuid; |
| 106 | } |
| 107 | }); |
| 108 | ASSERT_TRUE(ret.isOk()); |
| 109 | ASSERT_TRUE(gotEffect); |
| 110 | Result retval = Result::NOT_INITIALIZED; |
| 111 | sp<IEffect> effect; |
| 112 | ret = effectsFactory->createEffect( |
Eric Laurent | d33e693 | 2019-11-13 13:47:50 -0800 | [diff] [blame] | 113 | effectUuid, 1 /*session*/, 1 /*ioHandle*/, |
| 114 | #if MAJOR_VERSION >= 6 |
| 115 | 0 /*device*/, |
| 116 | #endif |
| 117 | [&](Result r, const sp<IEffect>& result, uint64_t /*effectId*/) { |
| 118 | retval = r; |
| 119 | if (r == Result::OK) { |
| 120 | effect = result; |
| 121 | } |
| 122 | }); |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 123 | EXPECT_TRUE(ret.isOk()); |
| 124 | EXPECT_EQ(Result::OK, retval); |
| 125 | EXPECT_NE(nullptr, effect.get()); |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 126 | } |
| 127 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 128 | TEST_P(AudioEffectsFactoryHidlTest, GetDescriptor) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 129 | description( |
| 130 | "Verify that effects factory can provide an effect descriptor via " |
| 131 | "GetDescriptor"); |
| 132 | hidl_vec<EffectDescriptor> allDescriptors; |
| 133 | Return<void> ret = |
| 134 | effectsFactory->getAllDescriptors([&](Result r, const hidl_vec<EffectDescriptor>& result) { |
| 135 | if (r == Result::OK) { |
| 136 | allDescriptors = result; |
| 137 | } |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 138 | }); |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 139 | ASSERT_TRUE(ret.isOk()); |
| 140 | ASSERT_GT(allDescriptors.size(), 0u); |
| 141 | for (size_t i = 0; i < allDescriptors.size(); ++i) { |
| 142 | ret = effectsFactory->getDescriptor(allDescriptors[i].uuid, |
| 143 | [&](Result r, const EffectDescriptor& result) { |
| 144 | EXPECT_EQ(r, Result::OK); |
| 145 | EXPECT_EQ(result, allDescriptors[i]); |
| 146 | }); |
| 147 | } |
| 148 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 149 | } |
| 150 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 151 | TEST_P(AudioEffectsFactoryHidlTest, DebugDumpInvalidArgument) { |
Mikhail Naganov | 3e6fe75 | 2017-04-24 10:44:08 -0700 | [diff] [blame] | 152 | description("Verify that debugDump doesn't crash on invalid arguments"); |
Kevin Rocard | 96d2cd9 | 2018-11-14 16:22:07 -0800 | [diff] [blame] | 153 | #if MAJOR_VERSION == 2 |
Mikhail Naganov | 3e6fe75 | 2017-04-24 10:44:08 -0700 | [diff] [blame] | 154 | Return<void> ret = effectsFactory->debugDump(hidl_handle()); |
Kevin Rocard | 20614ba | 2018-11-10 07:20:17 -0800 | [diff] [blame] | 155 | #elif MAJOR_VERSION >= 4 |
Kevin Rocard | 96d2cd9 | 2018-11-14 16:22:07 -0800 | [diff] [blame] | 156 | Return<void> ret = effectsFactory->debug(hidl_handle(), {}); |
| 157 | #endif |
Mikhail Naganov | 3e6fe75 | 2017-04-24 10:44:08 -0700 | [diff] [blame] | 158 | ASSERT_TRUE(ret.isOk()); |
| 159 | } |
| 160 | |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 161 | // Equalizer effect is required by CDD, but only the type is fixed. |
| 162 | // This is the same UUID as AudioEffect.EFFECT_TYPE_EQUALIZER in Java. |
| 163 | static const Uuid EQUALIZER_EFFECT_TYPE = { |
| 164 | 0x0bed4300, 0xddd6, 0x11db, 0x8f34, |
| 165 | std::array<uint8_t, 6>{{0x00, 0x02, 0xa5, 0xd5, 0xc5, 0x1b}}}; |
| 166 | // Loudness Enhancer effect is required by CDD, but only the type is fixed. |
| 167 | // This is the same UUID as AudioEffect.EFFECT_TYPE_LOUDNESS_ENHANCER in Java. |
| 168 | static const Uuid LOUDNESS_ENHANCER_EFFECT_TYPE = { |
| 169 | 0xfe3199be, 0xaed0, 0x413f, 0x87bb, |
| 170 | std::array<uint8_t, 6>{{0x11, 0x26, 0x0e, 0xb6, 0x3c, 0xf1}}}; |
| 171 | |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 172 | enum { PARAM_FACTORY_NAME, PARAM_EFFECT_UUID }; |
| 173 | using EffectParameter = std::tuple<std::string, Uuid>; |
| 174 | |
| 175 | static inline std::string EffectParameterToString( |
| 176 | const ::testing::TestParamInfo<EffectParameter>& info) { |
| 177 | return ::android::hardware::PrintInstanceNameToString(::testing::TestParamInfo<std::string>{ |
| 178 | std::get<PARAM_FACTORY_NAME>(info.param), info.index}); |
| 179 | } |
| 180 | |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 181 | // The main test class for Audio Effect HIDL HAL. |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 182 | class AudioEffectHidlTest : public ::testing::TestWithParam<EffectParameter> { |
Mikhail Naganov | 315ce41 | 2019-10-23 16:46:54 -0700 | [diff] [blame] | 183 | public: |
| 184 | void SetUp() override { |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 185 | effectsFactory = IEffectsFactory::getService(std::get<PARAM_FACTORY_NAME>(GetParam())); |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 186 | ASSERT_NE(nullptr, effectsFactory.get()); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 187 | |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 188 | ASSERT_NO_FATAL_FAILURE(findAndCreateEffect(getEffectType())); |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 189 | ASSERT_NE(nullptr, effect.get()); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 190 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 191 | Return<Result> ret = effect->init(); |
| 192 | ASSERT_TRUE(ret.isOk()); |
| 193 | ASSERT_EQ(Result::OK, ret); |
| 194 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 195 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 196 | void TearDown() override { |
| 197 | effect.clear(); |
| 198 | effectsFactory.clear(); |
| 199 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 200 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 201 | protected: |
| 202 | static void description(const std::string& description) { |
| 203 | RecordProperty("description", description); |
| 204 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 205 | |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 206 | Uuid getEffectType() const { return std::get<PARAM_EFFECT_UUID>(GetParam()); } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 207 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 208 | void findAndCreateEffect(const Uuid& type); |
| 209 | void findEffectInstance(const Uuid& type, Uuid* uuid); |
| 210 | void getChannelCount(uint32_t* channelCount); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 211 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 212 | sp<IEffectsFactory> effectsFactory; |
| 213 | sp<IEffect> effect; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 214 | }; |
| 215 | |
| 216 | void AudioEffectHidlTest::findAndCreateEffect(const Uuid& type) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 217 | Uuid effectUuid; |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 218 | ASSERT_NO_FATAL_FAILURE(findEffectInstance(type, &effectUuid)); |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 219 | Return<void> ret = effectsFactory->createEffect( |
Eric Laurent | d33e693 | 2019-11-13 13:47:50 -0800 | [diff] [blame] | 220 | effectUuid, 1 /*session*/, 1 /*ioHandle*/, |
| 221 | #if MAJOR_VERSION >= 6 |
| 222 | 0 /*device*/, |
| 223 | #endif |
| 224 | [&](Result r, const sp<IEffect>& result, uint64_t /*effectId*/) { |
| 225 | if (r == Result::OK) { |
| 226 | effect = result; |
| 227 | } |
| 228 | }); |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 229 | ASSERT_TRUE(ret.isOk()); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 230 | } |
| 231 | |
| 232 | void AudioEffectHidlTest::findEffectInstance(const Uuid& type, Uuid* uuid) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 233 | bool effectFound = false; |
| 234 | Return<void> ret = |
| 235 | effectsFactory->getAllDescriptors([&](Result r, const hidl_vec<EffectDescriptor>& result) { |
| 236 | if (r == Result::OK) { |
| 237 | for (const auto& desc : result) { |
| 238 | if (desc.type == type) { |
| 239 | effectFound = true; |
| 240 | *uuid = desc.uuid; |
| 241 | break; |
| 242 | } |
| 243 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 244 | } |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 245 | }); |
| 246 | ASSERT_TRUE(ret.isOk()); |
| 247 | ASSERT_TRUE(effectFound); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 248 | } |
| 249 | |
| 250 | void AudioEffectHidlTest::getChannelCount(uint32_t* channelCount) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 251 | Result retval; |
| 252 | EffectConfig currentConfig; |
| 253 | Return<void> ret = effect->getConfig([&](Result r, const EffectConfig& conf) { |
| 254 | retval = r; |
| 255 | if (r == Result::OK) { |
| 256 | currentConfig = conf; |
| 257 | } |
| 258 | }); |
| 259 | ASSERT_TRUE(ret.isOk()); |
| 260 | ASSERT_EQ(Result::OK, retval); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 261 | #if MAJOR_VERSION <= 6 |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 262 | ASSERT_TRUE(audio_channel_mask_is_valid( |
| 263 | static_cast<audio_channel_mask_t>(currentConfig.outputCfg.channels))); |
| 264 | *channelCount = audio_channel_count_from_out_mask( |
| 265 | static_cast<audio_channel_mask_t>(currentConfig.outputCfg.channels)); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 266 | #else |
Mikhail Naganov | ff61198 | 2021-01-27 02:16:53 +0000 | [diff] [blame] | 267 | ASSERT_EQ(AudioConfigBaseOptional::ChannelMask::hidl_discriminator::value, |
| 268 | currentConfig.outputCfg.base.channelMask.getDiscriminator()); |
Hayden Gomes | 4e7d69e | 2020-11-06 15:15:26 -0800 | [diff] [blame] | 269 | *channelCount = android::audio::policy::configuration::V7_0::getChannelCount( |
Mikhail Naganov | ff61198 | 2021-01-27 02:16:53 +0000 | [diff] [blame] | 270 | currentConfig.outputCfg.base.channelMask.value()); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 271 | ASSERT_NE(*channelCount, 0); |
| 272 | #endif |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 273 | } |
| 274 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 275 | TEST_P(AudioEffectHidlTest, Close) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 276 | description("Verify that an effect can be closed"); |
| 277 | Return<Result> ret = effect->close(); |
| 278 | EXPECT_TRUE(ret.isOk()); |
| 279 | EXPECT_EQ(Result::OK, ret); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 280 | } |
| 281 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 282 | TEST_P(AudioEffectHidlTest, GetDescriptor) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 283 | description("Verify that an effect can return its own descriptor via GetDescriptor"); |
| 284 | Result retval = Result::NOT_INITIALIZED; |
| 285 | Uuid actualType; |
| 286 | Return<void> ret = effect->getDescriptor([&](Result r, const EffectDescriptor& desc) { |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 287 | retval = r; |
| 288 | if (r == Result::OK) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 289 | actualType = desc.type; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 290 | } |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 291 | }); |
| 292 | EXPECT_TRUE(ret.isOk()); |
| 293 | EXPECT_EQ(Result::OK, retval); |
| 294 | EXPECT_EQ(getEffectType(), actualType); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 295 | } |
| 296 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 297 | TEST_P(AudioEffectHidlTest, GetSetConfig) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 298 | description( |
| 299 | "Verify that it is possible to manipulate effect config via Get / " |
| 300 | "SetConfig"); |
| 301 | Result retval = Result::NOT_INITIALIZED; |
| 302 | EffectConfig currentConfig; |
| 303 | Return<void> ret = effect->getConfig([&](Result r, const EffectConfig& conf) { |
| 304 | retval = r; |
| 305 | if (r == Result::OK) { |
| 306 | currentConfig = conf; |
| 307 | } |
| 308 | }); |
| 309 | EXPECT_TRUE(ret.isOk()); |
| 310 | EXPECT_EQ(Result::OK, retval); |
| 311 | Return<Result> ret2 = effect->setConfig(currentConfig, nullptr, nullptr); |
| 312 | EXPECT_TRUE(ret2.isOk()); |
| 313 | EXPECT_EQ(Result::OK, ret2); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 314 | } |
| 315 | |
Mikhail Naganov | 0dbf398 | 2021-01-08 17:48:22 -0800 | [diff] [blame] | 316 | #if MAJOR_VERSION >= 7 |
| 317 | std::vector<EffectBufferConfig> generateInvalidConfigs(const EffectBufferConfig& src) { |
| 318 | std::vector<EffectBufferConfig> result; |
| 319 | EffectBufferConfig invalidFormat = src; |
Mikhail Naganov | ff61198 | 2021-01-27 02:16:53 +0000 | [diff] [blame] | 320 | invalidFormat.base.format.value("random_string"); |
Mikhail Naganov | 0dbf398 | 2021-01-08 17:48:22 -0800 | [diff] [blame] | 321 | result.push_back(std::move(invalidFormat)); |
| 322 | EffectBufferConfig invalidChannelMask = src; |
Mikhail Naganov | ff61198 | 2021-01-27 02:16:53 +0000 | [diff] [blame] | 323 | invalidChannelMask.base.channelMask.value("random_string"); |
Mikhail Naganov | 0dbf398 | 2021-01-08 17:48:22 -0800 | [diff] [blame] | 324 | result.push_back(std::move(invalidChannelMask)); |
| 325 | return result; |
| 326 | } |
| 327 | |
| 328 | TEST_P(AudioEffectHidlTest, SetConfigInvalidArguments) { |
| 329 | description("Verify that invalid arguments are rejected by SetConfig"); |
| 330 | Result retval = Result::NOT_INITIALIZED; |
| 331 | EffectConfig currentConfig; |
| 332 | Return<void> ret = effect->getConfig([&](Result r, const EffectConfig& conf) { |
| 333 | retval = r; |
| 334 | if (r == Result::OK) { |
| 335 | currentConfig = conf; |
| 336 | } |
| 337 | }); |
| 338 | EXPECT_TRUE(ret.isOk()); |
| 339 | EXPECT_EQ(Result::OK, retval); |
| 340 | for (const auto& invalidInputCfg : generateInvalidConfigs(currentConfig.inputCfg)) { |
| 341 | EffectConfig invalidConfig = currentConfig; |
| 342 | invalidConfig.inputCfg = invalidInputCfg; |
| 343 | Return<Result> ret = effect->setConfig(invalidConfig, nullptr, nullptr); |
| 344 | EXPECT_TRUE(ret.isOk()); |
| 345 | EXPECT_EQ(Result::INVALID_ARGUMENTS, ret); |
| 346 | } |
| 347 | for (const auto& invalidOutputCfg : generateInvalidConfigs(currentConfig.outputCfg)) { |
| 348 | EffectConfig invalidConfig = currentConfig; |
| 349 | invalidConfig.outputCfg = invalidOutputCfg; |
| 350 | Return<Result> ret = effect->setConfig(invalidConfig, nullptr, nullptr); |
| 351 | EXPECT_TRUE(ret.isOk()); |
| 352 | EXPECT_EQ(Result::INVALID_ARGUMENTS, ret); |
| 353 | } |
| 354 | } |
| 355 | #endif |
| 356 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 357 | TEST_P(AudioEffectHidlTest, GetConfigReverse) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 358 | description("Verify that GetConfigReverse does not crash"); |
| 359 | Return<void> ret = effect->getConfigReverse([&](Result, const EffectConfig&) {}); |
| 360 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 361 | } |
| 362 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 363 | TEST_P(AudioEffectHidlTest, GetSupportedAuxChannelsConfigs) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 364 | description("Verify that GetSupportedAuxChannelsConfigs does not crash"); |
| 365 | Return<void> ret = effect->getSupportedAuxChannelsConfigs( |
| 366 | 0, [&](Result, const hidl_vec<EffectAuxChannelsConfig>&) {}); |
| 367 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 368 | } |
| 369 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 370 | TEST_P(AudioEffectHidlTest, GetAuxChannelsConfig) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 371 | description("Verify that GetAuxChannelsConfig does not crash"); |
| 372 | Return<void> ret = effect->getAuxChannelsConfig([&](Result, const EffectAuxChannelsConfig&) {}); |
| 373 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 374 | } |
| 375 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 376 | TEST_P(AudioEffectHidlTest, SetAuxChannelsConfig) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 377 | description("Verify that SetAuxChannelsConfig does not crash"); |
| 378 | Return<Result> ret = effect->setAuxChannelsConfig(EffectAuxChannelsConfig()); |
| 379 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 380 | } |
| 381 | |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 382 | // Not generated automatically because AudioBuffer contains |
| 383 | // instances of hidl_memory which can't be compared properly |
| 384 | // in general case due to presence of handles. |
| 385 | // |
| 386 | // However, in this particular case, handles must not present |
| 387 | // thus comparison is possible. |
| 388 | // |
| 389 | // operator== must be defined in the same namespace as the structures. |
| 390 | namespace android { |
| 391 | namespace hardware { |
| 392 | namespace audio { |
| 393 | namespace effect { |
Kevin Rocard | 96d2cd9 | 2018-11-14 16:22:07 -0800 | [diff] [blame] | 394 | namespace CPP_VERSION { |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 395 | inline bool operator==(const AudioBuffer& lhs, const AudioBuffer& rhs) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 396 | return lhs.id == rhs.id && lhs.frameCount == rhs.frameCount && lhs.data.handle() == nullptr && |
| 397 | rhs.data.handle() == nullptr; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 398 | } |
| 399 | |
Mikhail Naganov | ff61198 | 2021-01-27 02:16:53 +0000 | [diff] [blame] | 400 | #if MAJOR_VERSION <= 6 |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 401 | inline bool operator==(const EffectBufferConfig& lhs, const EffectBufferConfig& rhs) { |
Mikhail Naganov | f363ed4 | 2020-12-10 18:47:51 -0800 | [diff] [blame] | 402 | return lhs.buffer == rhs.buffer && |
Mikhail Naganov | f363ed4 | 2020-12-10 18:47:51 -0800 | [diff] [blame] | 403 | lhs.samplingRateHz == rhs.samplingRateHz && lhs.channels == rhs.channels && |
| 404 | lhs.format == rhs.format && |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 405 | lhs.accessMode == rhs.accessMode && lhs.mask == rhs.mask; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 406 | } |
Mikhail Naganov | ff61198 | 2021-01-27 02:16:53 +0000 | [diff] [blame] | 407 | #else |
| 408 | inline bool operator==(const EffectBufferConfig& lhs, const EffectBufferConfig& rhs) { |
| 409 | return lhs.buffer.getDiscriminator() == rhs.buffer.getDiscriminator() && |
| 410 | (lhs.buffer.getDiscriminator() == |
| 411 | EffectBufferConfig::OptionalBuffer::hidl_discriminator::unspecified || |
| 412 | lhs.buffer.buf() == rhs.buffer.buf()) && |
| 413 | lhs.base == rhs.base && lhs.accessMode == rhs.accessMode; |
| 414 | } |
| 415 | #endif // MAJOR_VERSION <= 6 |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 416 | |
| 417 | inline bool operator==(const EffectConfig& lhs, const EffectConfig& rhs) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 418 | return lhs.inputCfg == rhs.inputCfg && lhs.outputCfg == rhs.outputCfg; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 419 | } |
Kevin Rocard | 96d2cd9 | 2018-11-14 16:22:07 -0800 | [diff] [blame] | 420 | } // namespace CPP_VERSION |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 421 | } // namespace effect |
| 422 | } // namespace audio |
| 423 | } // namespace hardware |
| 424 | } // namespace android |
| 425 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 426 | TEST_P(AudioEffectHidlTest, Reset) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 427 | description("Verify that Reset preserves effect configuration"); |
| 428 | Result retval = Result::NOT_INITIALIZED; |
| 429 | EffectConfig originalConfig; |
| 430 | Return<void> ret = effect->getConfig([&](Result r, const EffectConfig& conf) { |
| 431 | retval = r; |
| 432 | if (r == Result::OK) { |
| 433 | originalConfig = conf; |
| 434 | } |
| 435 | }); |
| 436 | ASSERT_TRUE(ret.isOk()); |
| 437 | ASSERT_EQ(Result::OK, retval); |
| 438 | Return<Result> ret2 = effect->reset(); |
| 439 | EXPECT_TRUE(ret2.isOk()); |
| 440 | EXPECT_EQ(Result::OK, ret2); |
| 441 | EffectConfig configAfterReset; |
| 442 | ret = effect->getConfig([&](Result r, const EffectConfig& conf) { |
| 443 | retval = r; |
| 444 | if (r == Result::OK) { |
| 445 | configAfterReset = conf; |
| 446 | } |
| 447 | }); |
| 448 | EXPECT_EQ(originalConfig, configAfterReset); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 449 | } |
| 450 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 451 | TEST_P(AudioEffectHidlTest, DisableEnableDisable) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 452 | description("Verify Disable -> Enable -> Disable sequence for an effect"); |
| 453 | Return<Result> ret = effect->disable(); |
| 454 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 455 | // Note: some legacy effects may return -EINVAL (INVALID_ARGUMENTS), |
| 456 | // more canonical is to return -ENOSYS (NOT_SUPPORTED) |
| 457 | EXPECT_TRUE(ret == Result::NOT_SUPPORTED || ret == Result::INVALID_ARGUMENTS); |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 458 | ret = effect->enable(); |
| 459 | EXPECT_TRUE(ret.isOk()); |
| 460 | EXPECT_EQ(Result::OK, ret); |
| 461 | ret = effect->disable(); |
| 462 | EXPECT_TRUE(ret.isOk()); |
| 463 | EXPECT_EQ(Result::OK, ret); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 464 | } |
| 465 | |
Mikhail Naganov | 0dbf398 | 2021-01-08 17:48:22 -0800 | [diff] [blame] | 466 | #if MAJOR_VERSION >= 7 |
| 467 | TEST_P(AudioEffectHidlTest, SetDeviceInvalidDeviceAddress) { |
| 468 | description("Verify that invalid device address is rejected by SetDevice"); |
| 469 | DeviceAddress device{.deviceType = "random_string"}; |
| 470 | Return<Result> ret = effect->setDevice(device); |
| 471 | EXPECT_TRUE(ret.isOk()); |
| 472 | EXPECT_EQ(Result::INVALID_ARGUMENTS, ret); |
| 473 | } |
| 474 | #endif |
| 475 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 476 | TEST_P(AudioEffectHidlTest, SetDevice) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 477 | description("Verify that SetDevice works for an output chain effect"); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 478 | #if MAJOR_VERSION <= 6 |
Kevin Rocard | f5305b3 | 2018-11-13 10:41:53 -0800 | [diff] [blame] | 479 | Return<Result> ret = effect->setDevice(mkEnumBitfield(AudioDevice::OUT_SPEAKER)); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 480 | #else |
| 481 | DeviceAddress device{.deviceType = toString(xsd::AudioDevice::AUDIO_DEVICE_OUT_SPEAKER)}; |
| 482 | Return<Result> ret = effect->setDevice(device); |
| 483 | #endif |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 484 | EXPECT_TRUE(ret.isOk()); |
| 485 | EXPECT_EQ(Result::OK, ret); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 486 | } |
| 487 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 488 | TEST_P(AudioEffectHidlTest, SetAndGetVolume) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 489 | description("Verify that SetAndGetVolume method works for an effect"); |
| 490 | uint32_t channelCount; |
| 491 | getChannelCount(&channelCount); |
| 492 | hidl_vec<uint32_t> volumes; |
| 493 | volumes.resize(channelCount); |
| 494 | for (uint32_t i = 0; i < channelCount; ++i) { |
| 495 | volumes[i] = 0; |
| 496 | } |
| 497 | Result retval = Result::NOT_INITIALIZED; |
| 498 | Return<void> ret = |
| 499 | effect->setAndGetVolume(volumes, [&](Result r, const hidl_vec<uint32_t>&) { retval = r; }); |
| 500 | EXPECT_TRUE(ret.isOk()); |
| 501 | EXPECT_EQ(Result::OK, retval); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 502 | } |
| 503 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 504 | TEST_P(AudioEffectHidlTest, VolumeChangeNotification) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 505 | description("Verify that effect accepts VolumeChangeNotification"); |
| 506 | uint32_t channelCount; |
| 507 | getChannelCount(&channelCount); |
| 508 | hidl_vec<uint32_t> volumes; |
| 509 | volumes.resize(channelCount); |
| 510 | for (uint32_t i = 0; i < channelCount; ++i) { |
| 511 | volumes[i] = 0; |
| 512 | } |
| 513 | Return<Result> ret = effect->volumeChangeNotification(volumes); |
| 514 | EXPECT_TRUE(ret.isOk()); |
| 515 | EXPECT_EQ(Result::OK, ret); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 516 | } |
| 517 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 518 | TEST_P(AudioEffectHidlTest, SetAudioMode) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 519 | description("Verify that SetAudioMode works for an effect"); |
| 520 | Return<Result> ret = effect->setAudioMode(AudioMode::NORMAL); |
| 521 | EXPECT_TRUE(ret.isOk()); |
| 522 | EXPECT_EQ(Result::OK, ret); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 523 | } |
| 524 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 525 | TEST_P(AudioEffectHidlTest, SetConfigReverse) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 526 | description("Verify that SetConfigReverse does not crash"); |
| 527 | Return<Result> ret = effect->setConfigReverse(EffectConfig(), nullptr, nullptr); |
| 528 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 529 | } |
| 530 | |
Mikhail Naganov | 0dbf398 | 2021-01-08 17:48:22 -0800 | [diff] [blame] | 531 | #if MAJOR_VERSION >= 7 |
| 532 | TEST_P(AudioEffectHidlTest, SetInputDeviceInvalidDeviceAddress) { |
| 533 | description("Verify that invalid device address is rejected by SetInputDevice"); |
| 534 | DeviceAddress device{.deviceType = "random_string"}; |
| 535 | Return<Result> ret = effect->setInputDevice(device); |
| 536 | EXPECT_TRUE(ret.isOk()); |
| 537 | EXPECT_TRUE(ret == Result::INVALID_ARGUMENTS || ret == Result::NOT_SUPPORTED) |
| 538 | << ::testing::PrintToString(ret); |
| 539 | } |
| 540 | #endif |
| 541 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 542 | TEST_P(AudioEffectHidlTest, SetInputDevice) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 543 | description("Verify that SetInputDevice does not crash"); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 544 | #if MAJOR_VERSION <= 6 |
Kevin Rocard | f5305b3 | 2018-11-13 10:41:53 -0800 | [diff] [blame] | 545 | Return<Result> ret = effect->setInputDevice(mkEnumBitfield(AudioDevice::IN_BUILTIN_MIC)); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 546 | #else |
| 547 | DeviceAddress device{.deviceType = toString(xsd::AudioDevice::AUDIO_DEVICE_IN_BUILTIN_MIC)}; |
| 548 | Return<Result> ret = effect->setInputDevice(device); |
| 549 | #endif |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 550 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 551 | } |
| 552 | |
Mikhail Naganov | 0dbf398 | 2021-01-08 17:48:22 -0800 | [diff] [blame] | 553 | #if MAJOR_VERSION >= 7 |
| 554 | TEST_P(AudioEffectHidlTest, SetInvalidAudioSource) { |
| 555 | description("Verify that an invalid audio source is rejected by SetAudioSource"); |
| 556 | Return<Result> ret = effect->setAudioSource("random_string"); |
| 557 | ASSERT_TRUE(ret.isOk()); |
| 558 | EXPECT_TRUE(ret == Result::INVALID_ARGUMENTS || ret == Result::NOT_SUPPORTED) |
| 559 | << ::testing::PrintToString(ret); |
| 560 | } |
| 561 | #endif |
| 562 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 563 | TEST_P(AudioEffectHidlTest, SetAudioSource) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 564 | description("Verify that SetAudioSource does not crash"); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 565 | #if MAJOR_VERSION <= 6 |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 566 | Return<Result> ret = effect->setAudioSource(AudioSource::MIC); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 567 | #else |
| 568 | Return<Result> ret = effect->setAudioSource(toString(xsd::AudioSource::AUDIO_SOURCE_MIC)); |
| 569 | #endif |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 570 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 571 | } |
| 572 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 573 | TEST_P(AudioEffectHidlTest, Offload) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 574 | description("Verify that calling Offload method does not crash"); |
Mikhail Naganov | d72a7c2 | 2020-08-14 00:16:09 +0000 | [diff] [blame] | 575 | Return<Result> ret = effect->offload(EffectOffloadParameter{}); |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 576 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 577 | } |
| 578 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 579 | TEST_P(AudioEffectHidlTest, PrepareForProcessing) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 580 | description("Verify that PrepareForProcessing method works for an effect"); |
| 581 | Result retval = Result::NOT_INITIALIZED; |
| 582 | Return<void> ret = effect->prepareForProcessing( |
| 583 | [&](Result r, const MQDescriptorSync<Result>&) { retval = r; }); |
| 584 | EXPECT_TRUE(ret.isOk()); |
| 585 | EXPECT_EQ(Result::OK, retval); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 586 | } |
| 587 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 588 | TEST_P(AudioEffectHidlTest, SetProcessBuffers) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 589 | description("Verify that SetProcessBuffers works for an effect"); |
| 590 | sp<IAllocator> ashmem = IAllocator::getService("ashmem"); |
| 591 | ASSERT_NE(nullptr, ashmem.get()); |
| 592 | bool success = false; |
| 593 | AudioBuffer buffer; |
| 594 | Return<void> ret = ashmem->allocate(1024, [&](bool s, const hidl_memory& memory) { |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 595 | success = s; |
| 596 | if (s) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 597 | buffer.data = memory; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 598 | } |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 599 | }); |
| 600 | ASSERT_TRUE(ret.isOk()); |
| 601 | ASSERT_TRUE(success); |
| 602 | Return<Result> ret2 = effect->setProcessBuffers(buffer, buffer); |
| 603 | EXPECT_TRUE(ret2.isOk()); |
| 604 | EXPECT_EQ(Result::OK, ret2); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 605 | } |
| 606 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 607 | TEST_P(AudioEffectHidlTest, Command) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 608 | description("Verify that Command does not crash"); |
| 609 | Return<void> ret = |
| 610 | effect->command(0, hidl_vec<uint8_t>(), 0, [&](int32_t, const hidl_vec<uint8_t>&) {}); |
| 611 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 612 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 613 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 614 | TEST_P(AudioEffectHidlTest, SetParameter) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 615 | description("Verify that SetParameter does not crash"); |
| 616 | Return<Result> ret = effect->setParameter(hidl_vec<uint8_t>(), hidl_vec<uint8_t>()); |
| 617 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 618 | } |
| 619 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 620 | TEST_P(AudioEffectHidlTest, GetParameter) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 621 | description("Verify that GetParameter does not crash"); |
| 622 | Return<void> ret = |
| 623 | effect->getParameter(hidl_vec<uint8_t>(), 0, [&](Result, const hidl_vec<uint8_t>&) {}); |
| 624 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 625 | } |
| 626 | |
Mikhail Naganov | 4f11034 | 2022-07-07 20:37:42 +0000 | [diff] [blame] | 627 | TEST_P(AudioEffectHidlTest, GetParameterInvalidMaxReplySize) { |
| 628 | description("Verify that GetParameter caps the maximum reply size"); |
Mikhail Naganov | 978a0f9 | 2022-08-05 00:24:27 +0000 | [diff] [blame] | 629 | const bool isNewDeviceLaunchingOnTPlus = property_get_int32("ro.vendor.api_level", 0) >= 33; |
| 630 | if (!isNewDeviceLaunchingOnTPlus) { |
| 631 | GTEST_SKIP() << "The test only applies to devices launching on T or later"; |
| 632 | } |
Mikhail Naganov | 4f11034 | 2022-07-07 20:37:42 +0000 | [diff] [blame] | 633 | // Use a non-empty parameter to avoid being rejected by any earlier checks. |
| 634 | hidl_vec<uint8_t> parameter; |
| 635 | parameter.resize(16); |
| 636 | // Use very large size to ensure that the service does not crash. Since parameters |
| 637 | // are specific to each effect, and some effects may not have parameters at all, |
| 638 | // simply checking the return value would not reveal an issue of using an uncapped value. |
| 639 | const uint32_t veryLargeReplySize = std::numeric_limits<uint32_t>::max() - 100; |
| 640 | Result retval = Result::OK; |
| 641 | Return<void> ret = |
| 642 | effect->getParameter(parameter, veryLargeReplySize, |
| 643 | [&](Result r, const hidl_vec<uint8_t>&) { retval = r; }); |
| 644 | EXPECT_TRUE(ret.isOk()); |
| 645 | EXPECT_EQ(Result::INVALID_ARGUMENTS, retval); |
| 646 | } |
| 647 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 648 | TEST_P(AudioEffectHidlTest, GetSupportedConfigsForFeature) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 649 | description("Verify that GetSupportedConfigsForFeature does not crash"); |
| 650 | Return<void> ret = effect->getSupportedConfigsForFeature( |
| 651 | 0, 0, 0, [&](Result, uint32_t, const hidl_vec<uint8_t>&) {}); |
| 652 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 653 | } |
| 654 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 655 | TEST_P(AudioEffectHidlTest, GetCurrentConfigForFeature) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 656 | description("Verify that GetCurrentConfigForFeature does not crash"); |
| 657 | Return<void> ret = |
| 658 | effect->getCurrentConfigForFeature(0, 0, [&](Result, const hidl_vec<uint8_t>&) {}); |
| 659 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 660 | } |
| 661 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 662 | TEST_P(AudioEffectHidlTest, SetCurrentConfigForFeature) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 663 | description("Verify that SetCurrentConfigForFeature does not crash"); |
| 664 | Return<Result> ret = effect->setCurrentConfigForFeature(0, hidl_vec<uint8_t>()); |
| 665 | EXPECT_TRUE(ret.isOk()); |
Mikhail Naganov | 05fa0d0 | 2017-03-24 17:06:25 -0700 | [diff] [blame] | 666 | } |
| 667 | |
Mikhail Naganov | 8e3480e | 2022-09-01 00:31:43 +0000 | [diff] [blame^] | 668 | TEST_P(AudioEffectHidlTest, GetSupportedConfigsForFeatureInvalidConfigSize) { |
| 669 | description("Verify that GetSupportedConfigsForFeature caps the maximum config size"); |
| 670 | const bool isNewDeviceLaunchingOnTPlus = property_get_int32("ro.vendor.api_level", 0) >= 33; |
| 671 | if (!isNewDeviceLaunchingOnTPlus) { |
| 672 | GTEST_SKIP() << "The test only applies to devices launching on T or later"; |
| 673 | } |
| 674 | // Use very large size to ensure that the service does not crash. |
| 675 | const uint32_t veryLargeConfigSize = std::numeric_limits<uint32_t>::max() - 100; |
| 676 | Result retval = Result::OK; |
| 677 | Return<void> ret = effect->getSupportedConfigsForFeature( |
| 678 | 0, 1, veryLargeConfigSize, |
| 679 | [&](Result r, uint32_t, const hidl_vec<uint8_t>&) { retval = r; }); |
| 680 | EXPECT_TRUE(ret.isOk()); |
| 681 | EXPECT_EQ(Result::INVALID_ARGUMENTS, retval); |
| 682 | } |
| 683 | |
| 684 | TEST_P(AudioEffectHidlTest, GetCurrentConfigForFeatureInvalidConfigSize) { |
| 685 | description("Verify that GetCurrentConfigForFeature caps the maximum config size"); |
| 686 | const bool isNewDeviceLaunchingOnTPlus = property_get_int32("ro.vendor.api_level", 0) >= 33; |
| 687 | if (!isNewDeviceLaunchingOnTPlus) { |
| 688 | GTEST_SKIP() << "The test only applies to devices launching on T or later"; |
| 689 | } |
| 690 | // Use very large size to ensure that the service does not crash. |
| 691 | const uint32_t veryLargeConfigSize = std::numeric_limits<uint32_t>::max() - 100; |
| 692 | Result retval = Result::OK; |
| 693 | Return<void> ret = effect->getCurrentConfigForFeature( |
| 694 | 0, veryLargeConfigSize, [&](Result r, const hidl_vec<uint8_t>&) { retval = r; }); |
| 695 | EXPECT_TRUE(ret.isOk()); |
| 696 | EXPECT_EQ(Result::INVALID_ARGUMENTS, retval); |
| 697 | } |
| 698 | |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 699 | // The main test class for Equalizer Audio Effect HIDL HAL. |
| 700 | class EqualizerAudioEffectHidlTest : public AudioEffectHidlTest { |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 701 | public: |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 702 | void SetUp() override { |
| 703 | AudioEffectHidlTest::SetUp(); |
| 704 | equalizer = IEqualizerEffect::castFrom(effect); |
| 705 | ASSERT_NE(nullptr, equalizer.get()); |
| 706 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 707 | |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 708 | void TearDown() override { |
| 709 | equalizer.clear(); |
| 710 | AudioEffectHidlTest::TearDown(); |
| 711 | } |
| 712 | |
| 713 | protected: |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 714 | void getNumBands(uint16_t* numBands); |
| 715 | void getLevelRange(int16_t* minLevel, int16_t* maxLevel); |
| 716 | void getBandFrequencyRange(uint16_t band, uint32_t* minFreq, uint32_t* centerFreq, |
| 717 | uint32_t* maxFreq); |
| 718 | void getPresetCount(size_t* count); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 719 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 720 | sp<IEqualizerEffect> equalizer; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 721 | }; |
| 722 | |
| 723 | void EqualizerAudioEffectHidlTest::getNumBands(uint16_t* numBands) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 724 | Result retval = Result::NOT_INITIALIZED; |
| 725 | Return<void> ret = equalizer->getNumBands([&](Result r, uint16_t b) { |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 726 | retval = r; |
| 727 | if (retval == Result::OK) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 728 | *numBands = b; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 729 | } |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 730 | }); |
| 731 | ASSERT_TRUE(ret.isOk()); |
| 732 | ASSERT_EQ(Result::OK, retval); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 733 | } |
| 734 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 735 | void EqualizerAudioEffectHidlTest::getLevelRange(int16_t* minLevel, int16_t* maxLevel) { |
| 736 | Result retval = Result::NOT_INITIALIZED; |
| 737 | Return<void> ret = equalizer->getLevelRange([&](Result r, int16_t min, int16_t max) { |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 738 | retval = r; |
| 739 | if (retval == Result::OK) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 740 | *minLevel = min; |
| 741 | *maxLevel = max; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 742 | } |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 743 | }); |
| 744 | ASSERT_TRUE(ret.isOk()); |
| 745 | ASSERT_EQ(Result::OK, retval); |
| 746 | } |
| 747 | |
| 748 | void EqualizerAudioEffectHidlTest::getBandFrequencyRange(uint16_t band, uint32_t* minFreq, |
| 749 | uint32_t* centerFreq, uint32_t* maxFreq) { |
| 750 | Result retval = Result::NOT_INITIALIZED; |
| 751 | Return<void> ret = |
| 752 | equalizer->getBandFrequencyRange(band, [&](Result r, uint32_t min, uint32_t max) { |
| 753 | retval = r; |
| 754 | if (retval == Result::OK) { |
| 755 | *minFreq = min; |
| 756 | *maxFreq = max; |
| 757 | } |
| 758 | }); |
| 759 | ASSERT_TRUE(ret.isOk()); |
| 760 | ASSERT_EQ(Result::OK, retval); |
| 761 | ret = equalizer->getBandCenterFrequency(band, [&](Result r, uint32_t center) { |
| 762 | retval = r; |
| 763 | if (retval == Result::OK) { |
| 764 | *centerFreq = center; |
| 765 | } |
| 766 | }); |
| 767 | ASSERT_TRUE(ret.isOk()); |
| 768 | ASSERT_EQ(Result::OK, retval); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 769 | } |
| 770 | |
| 771 | void EqualizerAudioEffectHidlTest::getPresetCount(size_t* count) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 772 | Result retval = Result::NOT_INITIALIZED; |
| 773 | Return<void> ret = equalizer->getPresetNames([&](Result r, const hidl_vec<hidl_string>& names) { |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 774 | retval = r; |
| 775 | if (retval == Result::OK) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 776 | *count = names.size(); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 777 | } |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 778 | }); |
| 779 | ASSERT_TRUE(ret.isOk()); |
| 780 | ASSERT_EQ(Result::OK, retval); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 781 | } |
| 782 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 783 | TEST_P(EqualizerAudioEffectHidlTest, GetNumBands) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 784 | description("Verify that Equalizer effect reports at least one band"); |
| 785 | uint16_t numBands = 0; |
| 786 | getNumBands(&numBands); |
| 787 | EXPECT_GT(numBands, 0); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 788 | } |
| 789 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 790 | TEST_P(EqualizerAudioEffectHidlTest, GetLevelRange) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 791 | description("Verify that Equalizer effect reports adequate band level range"); |
| 792 | int16_t minLevel = 0x7fff, maxLevel = 0; |
| 793 | getLevelRange(&minLevel, &maxLevel); |
| 794 | EXPECT_GT(maxLevel, minLevel); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 795 | } |
| 796 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 797 | TEST_P(EqualizerAudioEffectHidlTest, GetSetBandLevel) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 798 | description("Verify that manipulating band levels works for Equalizer effect"); |
| 799 | uint16_t numBands = 0; |
| 800 | getNumBands(&numBands); |
| 801 | ASSERT_GT(numBands, 0); |
| 802 | int16_t levels[3]{0x7fff, 0, 0}; |
| 803 | getLevelRange(&levels[0], &levels[2]); |
| 804 | ASSERT_GT(levels[2], levels[0]); |
| 805 | levels[1] = (levels[2] + levels[0]) / 2; |
| 806 | for (uint16_t i = 0; i < numBands; ++i) { |
| 807 | for (size_t j = 0; j < ARRAY_SIZE(levels); ++j) { |
| 808 | Return<Result> ret = equalizer->setBandLevel(i, levels[j]); |
| 809 | EXPECT_TRUE(ret.isOk()); |
| 810 | EXPECT_EQ(Result::OK, ret); |
| 811 | Result retval = Result::NOT_INITIALIZED; |
| 812 | int16_t actualLevel; |
| 813 | Return<void> ret2 = equalizer->getBandLevel(i, [&](Result r, int16_t l) { |
| 814 | retval = r; |
| 815 | if (retval == Result::OK) { |
| 816 | actualLevel = l; |
| 817 | } |
| 818 | }); |
| 819 | EXPECT_TRUE(ret2.isOk()); |
| 820 | EXPECT_EQ(Result::OK, retval); |
| 821 | EXPECT_EQ(levels[j], actualLevel); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 822 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 823 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 824 | } |
| 825 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 826 | TEST_P(EqualizerAudioEffectHidlTest, GetBandCenterFrequencyAndRange) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 827 | description("Verify that Equalizer effect reports adequate band frequency range"); |
| 828 | uint16_t numBands = 0; |
| 829 | getNumBands(&numBands); |
| 830 | ASSERT_GT(numBands, 0); |
| 831 | for (uint16_t i = 0; i < numBands; ++i) { |
| 832 | uint32_t minFreq = 0xffffffff, centerFreq = 0xffffffff, maxFreq = 0xffffffff; |
| 833 | getBandFrequencyRange(i, &minFreq, ¢erFreq, &maxFreq); |
| 834 | // Note: NXP legacy implementation reports "1" as upper bound for last band, |
| 835 | // so this check fails. |
| 836 | EXPECT_GE(maxFreq, centerFreq); |
| 837 | EXPECT_GE(centerFreq, minFreq); |
| 838 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 839 | } |
| 840 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 841 | TEST_P(EqualizerAudioEffectHidlTest, GetBandForFrequency) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 842 | description("Verify that Equalizer effect supports GetBandForFrequency correctly"); |
| 843 | uint16_t numBands = 0; |
| 844 | getNumBands(&numBands); |
| 845 | ASSERT_GT(numBands, 0); |
| 846 | for (uint16_t i = 0; i < numBands; ++i) { |
| 847 | uint32_t freqs[3]{0, 0, 0}; |
| 848 | getBandFrequencyRange(i, &freqs[0], &freqs[1], &freqs[2]); |
| 849 | // NXP legacy implementation reports "1" as upper bound for last band, some |
| 850 | // of the checks fail. |
| 851 | for (size_t j = 0; j < ARRAY_SIZE(freqs); ++j) { |
| 852 | if (j == 0) { |
| 853 | freqs[j]++; |
| 854 | } // Min frequency is an open interval. |
| 855 | Result retval = Result::NOT_INITIALIZED; |
| 856 | uint16_t actualBand = numBands + 1; |
| 857 | Return<void> ret = equalizer->getBandForFrequency(freqs[j], [&](Result r, uint16_t b) { |
| 858 | retval = r; |
| 859 | if (retval == Result::OK) { |
| 860 | actualBand = b; |
| 861 | } |
| 862 | }); |
| 863 | EXPECT_TRUE(ret.isOk()); |
| 864 | EXPECT_EQ(Result::OK, retval); |
| 865 | EXPECT_EQ(i, actualBand) << "Frequency: " << freqs[j]; |
| 866 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 867 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 868 | } |
| 869 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 870 | TEST_P(EqualizerAudioEffectHidlTest, GetPresetNames) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 871 | description("Verify that Equalizer effect reports at least one preset"); |
| 872 | size_t presetCount; |
| 873 | getPresetCount(&presetCount); |
| 874 | EXPECT_GT(presetCount, 0u); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 875 | } |
| 876 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 877 | TEST_P(EqualizerAudioEffectHidlTest, GetSetCurrentPreset) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 878 | description("Verify that manipulating the current preset for Equalizer effect"); |
| 879 | size_t presetCount; |
| 880 | getPresetCount(&presetCount); |
| 881 | ASSERT_GT(presetCount, 0u); |
| 882 | for (uint16_t i = 0; i < presetCount; ++i) { |
| 883 | Return<Result> ret = equalizer->setCurrentPreset(i); |
| 884 | EXPECT_TRUE(ret.isOk()); |
| 885 | EXPECT_EQ(Result::OK, ret); |
| 886 | Result retval = Result::NOT_INITIALIZED; |
| 887 | uint16_t actualPreset = 0xffff; |
| 888 | Return<void> ret2 = equalizer->getCurrentPreset([&](Result r, uint16_t p) { |
| 889 | retval = r; |
| 890 | if (retval == Result::OK) { |
| 891 | actualPreset = p; |
| 892 | } |
| 893 | }); |
| 894 | EXPECT_TRUE(ret2.isOk()); |
| 895 | EXPECT_EQ(Result::OK, retval); |
| 896 | EXPECT_EQ(i, actualPreset); |
| 897 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 898 | } |
| 899 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 900 | TEST_P(EqualizerAudioEffectHidlTest, GetSetAllProperties) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 901 | description( |
| 902 | "Verify that setting band levels and presets works via Get / " |
| 903 | "SetAllProperties for Equalizer effect"); |
Kevin Rocard | 96d2cd9 | 2018-11-14 16:22:07 -0800 | [diff] [blame] | 904 | using AllProperties = |
Mikhail Naganov | 00a44c0 | 2018-12-14 14:31:45 -0800 | [diff] [blame] | 905 | ::android::hardware::audio::effect::CPP_VERSION::IEqualizerEffect::AllProperties; |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 906 | uint16_t numBands = 0; |
| 907 | getNumBands(&numBands); |
| 908 | ASSERT_GT(numBands, 0); |
| 909 | AllProperties props; |
| 910 | props.bandLevels.resize(numBands); |
| 911 | for (size_t i = 0; i < numBands; ++i) { |
| 912 | props.bandLevels[i] = 0; |
| 913 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 914 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 915 | AllProperties actualProps; |
| 916 | Result retval = Result::NOT_INITIALIZED; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 917 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 918 | // Verify setting of the band levels via properties. |
| 919 | props.curPreset = -1; |
| 920 | Return<Result> ret = equalizer->setAllProperties(props); |
| 921 | EXPECT_TRUE(ret.isOk()); |
| 922 | EXPECT_EQ(Result::OK, ret); |
| 923 | Return<void> ret2 = equalizer->getAllProperties([&](Result r, AllProperties p) { |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 924 | retval = r; |
| 925 | if (retval == Result::OK) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 926 | actualProps = p; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 927 | } |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 928 | }); |
| 929 | EXPECT_TRUE(ret2.isOk()); |
| 930 | EXPECT_EQ(Result::OK, retval); |
| 931 | EXPECT_EQ(props.bandLevels, actualProps.bandLevels); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 932 | |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 933 | // Verify setting of the current preset via properties. |
| 934 | props.curPreset = 0; // Assuming there is at least one preset. |
| 935 | ret = equalizer->setAllProperties(props); |
| 936 | EXPECT_TRUE(ret.isOk()); |
| 937 | EXPECT_EQ(Result::OK, ret); |
| 938 | ret2 = equalizer->getAllProperties([&](Result r, AllProperties p) { |
| 939 | retval = r; |
| 940 | if (retval == Result::OK) { |
| 941 | actualProps = p; |
| 942 | } |
| 943 | }); |
| 944 | EXPECT_TRUE(ret2.isOk()); |
| 945 | EXPECT_EQ(Result::OK, retval); |
| 946 | EXPECT_EQ(props.curPreset, actualProps.curPreset); |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 947 | } |
| 948 | |
| 949 | // The main test class for Equalizer Audio Effect HIDL HAL. |
| 950 | class LoudnessEnhancerAudioEffectHidlTest : public AudioEffectHidlTest { |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 951 | public: |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 952 | void SetUp() override { |
| 953 | AudioEffectHidlTest::SetUp(); |
| 954 | enhancer = ILoudnessEnhancerEffect::castFrom(effect); |
| 955 | ASSERT_NE(nullptr, enhancer.get()); |
| 956 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 957 | |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 958 | void TearDown() override { |
| 959 | enhancer.clear(); |
| 960 | AudioEffectHidlTest::TearDown(); |
| 961 | } |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 962 | |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 963 | protected: |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 964 | sp<ILoudnessEnhancerEffect> enhancer; |
Mikhail Naganov | 9f28904 | 2017-02-23 08:39:36 -0800 | [diff] [blame] | 965 | }; |
| 966 | |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 967 | TEST_P(LoudnessEnhancerAudioEffectHidlTest, GetSetTargetGain) { |
Kevin Rocard | 55b1061 | 2018-11-12 12:33:16 -0800 | [diff] [blame] | 968 | description( |
| 969 | "Verify that manipulating the target gain works for Loudness Enhancer " |
| 970 | "effect"); |
| 971 | const int32_t gain = 100; |
| 972 | Return<Result> ret = enhancer->setTargetGain(gain); |
| 973 | EXPECT_TRUE(ret.isOk()); |
| 974 | EXPECT_EQ(Result::OK, ret); |
| 975 | int32_t actualGain = 0; |
| 976 | Result retval; |
| 977 | Return<void> ret2 = enhancer->getTargetGain([&](Result r, int32_t g) { |
| 978 | retval = r; |
| 979 | if (retval == Result::OK) { |
| 980 | actualGain = g; |
| 981 | } |
| 982 | }); |
| 983 | EXPECT_TRUE(ret2.isOk()); |
| 984 | EXPECT_EQ(Result::OK, retval); |
| 985 | EXPECT_EQ(gain, actualGain); |
Mikhail Naganov | bf39317 | 2016-11-11 16:24:50 -0800 | [diff] [blame] | 986 | } |
Zhuoyao Zhang | 7dc6ce8 | 2018-02-08 12:44:27 -0800 | [diff] [blame] | 987 | |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 988 | INSTANTIATE_TEST_SUITE_P(EffectsFactory, AudioEffectsFactoryHidlTest, |
| 989 | ::testing::ValuesIn(::android::hardware::getAllHalInstanceNames( |
| 990 | IEffectsFactory::descriptor)), |
| 991 | ::android::hardware::PrintInstanceNameToString); |
Mikhail Naganov | 315ce41 | 2019-10-23 16:46:54 -0700 | [diff] [blame] | 992 | INSTANTIATE_TEST_SUITE_P( |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 993 | Equalizer_IEffect, AudioEffectHidlTest, |
| 994 | ::testing::Combine(::testing::ValuesIn(::android::hardware::getAllHalInstanceNames( |
| 995 | IEffectsFactory::descriptor)), |
| 996 | ::testing::Values(EQUALIZER_EFFECT_TYPE)), |
| 997 | EffectParameterToString); |
Mikhail Naganov | 315ce41 | 2019-10-23 16:46:54 -0700 | [diff] [blame] | 998 | INSTANTIATE_TEST_SUITE_P( |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 999 | LoudnessEnhancer_IEffect, AudioEffectHidlTest, |
| 1000 | ::testing::Combine(::testing::ValuesIn(::android::hardware::getAllHalInstanceNames( |
| 1001 | IEffectsFactory::descriptor)), |
| 1002 | ::testing::Values(LOUDNESS_ENHANCER_EFFECT_TYPE)), |
| 1003 | EffectParameterToString); |
nelsonli | 3c12e58 | 2019-12-12 13:53:49 +0800 | [diff] [blame] | 1004 | INSTANTIATE_TEST_SUITE_P( |
Mikhail Naganov | 315ce41 | 2019-10-23 16:46:54 -0700 | [diff] [blame] | 1005 | Equalizer, EqualizerAudioEffectHidlTest, |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 1006 | ::testing::Combine(::testing::ValuesIn(::android::hardware::getAllHalInstanceNames( |
| 1007 | IEffectsFactory::descriptor)), |
| 1008 | ::testing::Values(EQUALIZER_EFFECT_TYPE)), |
| 1009 | EffectParameterToString); |
Mikhail Naganov | 315ce41 | 2019-10-23 16:46:54 -0700 | [diff] [blame] | 1010 | INSTANTIATE_TEST_SUITE_P( |
| 1011 | LoudnessEnhancer, LoudnessEnhancerAudioEffectHidlTest, |
Mikhail Naganov | 892d147 | 2020-03-19 10:44:06 -0700 | [diff] [blame] | 1012 | ::testing::Combine(::testing::ValuesIn(::android::hardware::getAllHalInstanceNames( |
| 1013 | IEffectsFactory::descriptor)), |
| 1014 | ::testing::Values(LOUDNESS_ENHANCER_EFFECT_TYPE)), |
| 1015 | EffectParameterToString); |
Mikhail Naganov | b9743d4 | 2020-07-21 10:57:03 -0700 | [diff] [blame] | 1016 | // When the VTS test runs on a device lacking the corresponding HAL version the parameter |
| 1017 | // list is empty, this isn't a problem. |
| 1018 | GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(AudioEffectsFactoryHidlTest); |
| 1019 | GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(AudioEffectHidlTest); |
| 1020 | GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(EqualizerAudioEffectHidlTest); |
| 1021 | GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(LoudnessEnhancerAudioEffectHidlTest); |