Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2020 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Marin Shalamanov | bed7fd3 | 2020-12-21 20:02:20 +0100 | [diff] [blame] | 17 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 18 | #include "gmock/gmock-spec-builders.h" |
| 19 | #include "mock/MockTimeStats.h" |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 20 | #undef LOG_TAG |
| 21 | #define LOG_TAG "LibSurfaceFlingerUnittests" |
| 22 | |
| 23 | #include <FrameTimeline/FrameTimeline.h> |
| 24 | #include <gtest/gtest.h> |
| 25 | #include <log/log.h> |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 26 | #include <perfetto/trace/trace.pb.h> |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 27 | #include <cinttypes> |
| 28 | |
| 29 | using namespace std::chrono_literals; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 30 | using testing::_; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 31 | using testing::AtLeast; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 32 | using testing::Contains; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 33 | using FrameTimelineEvent = perfetto::protos::FrameTimelineEvent; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 34 | using ProtoExpectedDisplayFrameStart = |
| 35 | perfetto::protos::FrameTimelineEvent_ExpectedDisplayFrameStart; |
| 36 | using ProtoExpectedSurfaceFrameStart = |
| 37 | perfetto::protos::FrameTimelineEvent_ExpectedSurfaceFrameStart; |
| 38 | using ProtoActualDisplayFrameStart = perfetto::protos::FrameTimelineEvent_ActualDisplayFrameStart; |
| 39 | using ProtoActualSurfaceFrameStart = perfetto::protos::FrameTimelineEvent_ActualSurfaceFrameStart; |
| 40 | using ProtoFrameEnd = perfetto::protos::FrameTimelineEvent_FrameEnd; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 41 | using ProtoPresentType = perfetto::protos::FrameTimelineEvent_PresentType; |
| 42 | using ProtoJankType = perfetto::protos::FrameTimelineEvent_JankType; |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 43 | using ProtoPredictionType = perfetto::protos::FrameTimelineEvent_PredictionType; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 44 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 45 | namespace android::frametimeline { |
| 46 | |
| 47 | class FrameTimelineTest : public testing::Test { |
| 48 | public: |
| 49 | FrameTimelineTest() { |
| 50 | const ::testing::TestInfo* const test_info = |
| 51 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 52 | ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 53 | } |
| 54 | |
| 55 | ~FrameTimelineTest() { |
| 56 | const ::testing::TestInfo* const test_info = |
| 57 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 58 | ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 59 | } |
| 60 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 61 | static void SetUpTestSuite() { |
| 62 | // Need to initialize tracing in process for testing, and only once per test suite. |
| 63 | perfetto::TracingInitArgs args; |
| 64 | args.backends = perfetto::kInProcessBackend; |
| 65 | perfetto::Tracing::Initialize(args); |
| 66 | } |
| 67 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 68 | void SetUp() override { |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 69 | mTimeStats = std::make_shared<mock::TimeStats>(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 70 | mFrameTimeline = std::make_unique<impl::FrameTimeline>(mTimeStats, kSurfaceFlingerPid, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 71 | kTestThresholds, kHwcDuration); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 72 | mFrameTimeline->registerDataSource(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 73 | mTokenManager = &mFrameTimeline->mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 74 | mTraceCookieCounter = &mFrameTimeline->mTraceCookieCounter; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 75 | maxDisplayFrames = &mFrameTimeline->mMaxDisplayFrames; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 76 | maxTokenRetentionTime = mTokenManager->kMaxRetentionTime; |
| 77 | } |
| 78 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 79 | // Each tracing session can be used for a single block of Start -> Stop. |
| 80 | static std::unique_ptr<perfetto::TracingSession> getTracingSessionForTest() { |
| 81 | perfetto::TraceConfig cfg; |
| 82 | cfg.set_duration_ms(500); |
| 83 | cfg.add_buffers()->set_size_kb(1024); |
| 84 | auto* ds_cfg = cfg.add_data_sources()->mutable_config(); |
| 85 | ds_cfg->set_name(impl::FrameTimeline::kFrameTimelineDataSource); |
| 86 | |
| 87 | auto tracingSession = perfetto::Tracing::NewTrace(perfetto::kInProcessBackend); |
| 88 | tracingSession->Setup(cfg); |
| 89 | return tracingSession; |
| 90 | } |
| 91 | |
| 92 | std::vector<perfetto::protos::TracePacket> readFrameTimelinePacketsBlocking( |
| 93 | perfetto::TracingSession* tracingSession) { |
| 94 | std::vector<char> raw_trace = tracingSession->ReadTraceBlocking(); |
| 95 | perfetto::protos::Trace trace; |
| 96 | EXPECT_TRUE(trace.ParseFromArray(raw_trace.data(), int(raw_trace.size()))); |
| 97 | |
| 98 | std::vector<perfetto::protos::TracePacket> packets; |
| 99 | for (const auto& packet : trace.packet()) { |
| 100 | if (!packet.has_frame_timeline_event()) { |
| 101 | continue; |
| 102 | } |
| 103 | packets.emplace_back(packet); |
| 104 | } |
| 105 | return packets; |
| 106 | } |
| 107 | |
| 108 | void addEmptyDisplayFrame() { |
| 109 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 110 | // Trigger a flushPresentFence by calling setSfPresent for the next frame |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 111 | mFrameTimeline->setSfPresent(2500, presentFence1); |
| 112 | } |
| 113 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 114 | void flushTokens(nsecs_t flushTime) { |
| 115 | std::lock_guard<std::mutex> lock(mTokenManager->mMutex); |
| 116 | mTokenManager->flushTokens(flushTime); |
| 117 | } |
| 118 | |
| 119 | SurfaceFrame& getSurfaceFrame(size_t displayFrameIdx, size_t surfaceFrameIdx) { |
| 120 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 121 | return *(mFrameTimeline->mDisplayFrames[displayFrameIdx] |
| 122 | ->getSurfaceFrames()[surfaceFrameIdx]); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 123 | } |
| 124 | |
| 125 | std::shared_ptr<impl::FrameTimeline::DisplayFrame> getDisplayFrame(size_t idx) { |
| 126 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 127 | return mFrameTimeline->mDisplayFrames[idx]; |
| 128 | } |
| 129 | |
| 130 | static bool compareTimelineItems(const TimelineItem& a, const TimelineItem& b) { |
| 131 | return a.startTime == b.startTime && a.endTime == b.endTime && |
| 132 | a.presentTime == b.presentTime; |
| 133 | } |
| 134 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 135 | const std::map<int64_t, TokenManagerPrediction>& getPredictions() const { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 136 | return mTokenManager->mPredictions; |
| 137 | } |
| 138 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 139 | uint32_t getNumberOfDisplayFrames() const { |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 140 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 141 | return static_cast<uint32_t>(mFrameTimeline->mDisplayFrames.size()); |
| 142 | } |
| 143 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 144 | int64_t snoopCurrentTraceCookie() const { return mTraceCookieCounter->mTraceCookie; } |
| 145 | |
| 146 | void flushTrace() { |
| 147 | using FrameTimelineDataSource = impl::FrameTimeline::FrameTimelineDataSource; |
| 148 | FrameTimelineDataSource::Trace( |
| 149 | [&](FrameTimelineDataSource::TraceContext ctx) { ctx.Flush(); }); |
| 150 | } |
| 151 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 152 | std::shared_ptr<mock::TimeStats> mTimeStats; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 153 | std::unique_ptr<impl::FrameTimeline> mFrameTimeline; |
| 154 | impl::TokenManager* mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 155 | TraceCookieCounter* mTraceCookieCounter; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 156 | FenceToFenceTimeMap fenceFactory; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 157 | uint32_t* maxDisplayFrames; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 158 | nsecs_t maxTokenRetentionTime; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 159 | static constexpr pid_t kSurfaceFlingerPid = 666; |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 160 | static constexpr nsecs_t kPresentThreshold = std::chrono::nanoseconds(2ns).count(); |
| 161 | static constexpr nsecs_t kDeadlineThreshold = std::chrono::nanoseconds(2ns).count(); |
| 162 | static constexpr nsecs_t kStartThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 163 | static constexpr JankClassificationThresholds kTestThresholds{kPresentThreshold, |
| 164 | kDeadlineThreshold, |
| 165 | kStartThreshold}; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 166 | static constexpr nsecs_t kHwcDuration = std::chrono::nanoseconds(3ns).count(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 167 | }; |
| 168 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 169 | static const std::string sLayerNameOne = "layer1"; |
| 170 | static const std::string sLayerNameTwo = "layer2"; |
| 171 | static constexpr const uid_t sUidOne = 0; |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 172 | static constexpr pid_t sPidOne = 10; |
| 173 | static constexpr pid_t sPidTwo = 20; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 174 | static constexpr int32_t sInputEventId = 5; |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 175 | static constexpr int32_t sLayerIdOne = 1; |
| 176 | static constexpr int32_t sLayerIdTwo = 2; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 177 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 178 | TEST_F(FrameTimelineTest, tokenManagerRemovesStalePredictions) { |
| 179 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 180 | EXPECT_EQ(getPredictions().size(), 1u); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 181 | flushTokens(systemTime() + maxTokenRetentionTime); |
| 182 | int64_t token2 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 183 | std::optional<TimelineItem> predictions = mTokenManager->getPredictionsForToken(token1); |
| 184 | |
| 185 | // token1 should have expired |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 186 | EXPECT_EQ(getPredictions().size(), 1u); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 187 | EXPECT_EQ(predictions.has_value(), false); |
| 188 | |
| 189 | predictions = mTokenManager->getPredictionsForToken(token2); |
| 190 | EXPECT_EQ(compareTimelineItems(*predictions, TimelineItem(10, 20, 30)), true); |
| 191 | } |
| 192 | |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 193 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_getOwnerPidReturnsCorrectPid) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 194 | auto surfaceFrame1 = |
| 195 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 196 | sLayerNameOne, sLayerNameOne, |
| 197 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 198 | auto surfaceFrame2 = |
| 199 | mFrameTimeline->createSurfaceFrameForToken({}, sPidTwo, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 200 | sLayerNameOne, sLayerNameOne, |
| 201 | /*isBuffer*/ true); |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 202 | EXPECT_EQ(surfaceFrame1->getOwnerPid(), sPidOne); |
| 203 | EXPECT_EQ(surfaceFrame2->getOwnerPid(), sPidTwo); |
| 204 | } |
| 205 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 206 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_noToken) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 207 | auto surfaceFrame = |
| 208 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 209 | sLayerNameOne, sLayerNameOne, |
| 210 | /*isBuffer*/ true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 211 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::None); |
| 212 | } |
| 213 | |
| 214 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_expiredToken) { |
| 215 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
| 216 | flushTokens(systemTime() + maxTokenRetentionTime); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 217 | auto surfaceFrame = |
| 218 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 219 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 220 | /*isBuffer*/ true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 221 | |
| 222 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Expired); |
| 223 | } |
| 224 | |
| 225 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validToken) { |
| 226 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 227 | auto surfaceFrame = |
| 228 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 229 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 230 | /*isBuffer*/ true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 231 | |
| 232 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Valid); |
| 233 | EXPECT_EQ(compareTimelineItems(surfaceFrame->getPredictions(), TimelineItem(10, 20, 30)), true); |
| 234 | } |
| 235 | |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 236 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validInputEventId) { |
| 237 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 238 | constexpr int32_t inputEventId = 1; |
| 239 | auto surfaceFrame = |
| 240 | mFrameTimeline->createSurfaceFrameForToken({token1, inputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 241 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 242 | /*isBuffer*/ true); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 243 | |
| 244 | EXPECT_EQ(inputEventId, surfaceFrame->getInputEventId()); |
| 245 | } |
| 246 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 247 | TEST_F(FrameTimelineTest, presentFenceSignaled_droppedFramesNotUpdated) { |
| 248 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 249 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 250 | auto surfaceFrame1 = |
| 251 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 252 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 253 | /*isBuffer*/ true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 254 | |
| 255 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 256 | mFrameTimeline->setSfWakeUp(token1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 257 | surfaceFrame1->setDropTime(12); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 258 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 259 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 260 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 261 | presentFence1->signalForTest(30); |
| 262 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 263 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 264 | |
| 265 | auto& droppedSurfaceFrame = getSurfaceFrame(0, 0); |
| 266 | EXPECT_EQ(droppedSurfaceFrame.getPresentState(), SurfaceFrame::PresentState::Dropped); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 267 | EXPECT_EQ(0u, droppedSurfaceFrame.getActuals().endTime); |
| 268 | EXPECT_EQ(12u, droppedSurfaceFrame.getDropTime()); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 269 | EXPECT_EQ(droppedSurfaceFrame.getActuals().presentTime, 0); |
| 270 | } |
| 271 | |
| 272 | TEST_F(FrameTimelineTest, presentFenceSignaled_presentedFramesUpdated) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 273 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 274 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 275 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 276 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 277 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 278 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 279 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 280 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 281 | sLayerNameOne, /*isBuffer*/ true); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 282 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 283 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 284 | sUidOne, sLayerIdTwo, sLayerNameTwo, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 285 | sLayerNameTwo, /*isBuffer*/ true); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 286 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 287 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 288 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 289 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 290 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 291 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 292 | auto displayFrame = getDisplayFrame(0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 293 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 294 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 295 | presentFence1->signalForTest(42); |
| 296 | |
| 297 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 298 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 299 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 0); |
| 300 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 301 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 302 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 303 | |
| 304 | // Fences have flushed, so the present timestamps should be updated |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 305 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 306 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 42); |
| 307 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 308 | EXPECT_NE(surfaceFrame1->getJankType(), std::nullopt); |
| 309 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 310 | } |
| 311 | |
| 312 | TEST_F(FrameTimelineTest, displayFramesSlidingWindowMovesAfterLimit) { |
| 313 | // Insert kMaxDisplayFrames' count of DisplayFrames to fill the deque |
| 314 | int frameTimeFactor = 0; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 315 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 316 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)) |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 317 | .Times(static_cast<int32_t>(*maxDisplayFrames)); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 318 | for (size_t i = 0; i < *maxDisplayFrames; i++) { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 319 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 320 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 321 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 322 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 323 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 324 | auto surfaceFrame = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 325 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 326 | sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 327 | sLayerNameOne, sLayerNameOne, |
| 328 | /*isBuffer*/ true); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 329 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 330 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 331 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 332 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 333 | presentFence->signalForTest(32 + frameTimeFactor); |
| 334 | frameTimeFactor += 30; |
| 335 | } |
| 336 | auto displayFrame0 = getDisplayFrame(0); |
| 337 | |
| 338 | // The 0th Display Frame should have actuals 22, 27, 32 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 339 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(22, 27, 32)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 340 | |
| 341 | // Add one more display frame |
| 342 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 343 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 344 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 345 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 346 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 347 | auto surfaceFrame = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 348 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 349 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 350 | sLayerNameOne, /*isBuffer*/ true); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 351 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 352 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 353 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 354 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 355 | presentFence->signalForTest(32 + frameTimeFactor); |
| 356 | displayFrame0 = getDisplayFrame(0); |
| 357 | |
| 358 | // The window should have slided by 1 now and the previous 0th display frame |
| 359 | // should have been removed from the deque |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 360 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(52, 57, 62)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 361 | } |
| 362 | |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 363 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceAfterQueue) { |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 364 | auto surfaceFrame = |
| 365 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 366 | "acquireFenceAfterQueue", |
| 367 | "acquireFenceAfterQueue", /*isBuffer*/ true); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 368 | surfaceFrame->setActualQueueTime(123); |
| 369 | surfaceFrame->setAcquireFenceTime(456); |
| 370 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 371 | } |
| 372 | |
| 373 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceBeforeQueue) { |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 374 | auto surfaceFrame = |
| 375 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 376 | "acquireFenceAfterQueue", |
| 377 | "acquireFenceAfterQueue", /*isBuffer*/ true); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 378 | surfaceFrame->setActualQueueTime(456); |
| 379 | surfaceFrame->setAcquireFenceTime(123); |
| 380 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 381 | } |
| 382 | |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 383 | TEST_F(FrameTimelineTest, setMaxDisplayFramesSetsSizeProperly) { |
| 384 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 385 | presentFence->signalForTest(2); |
| 386 | |
| 387 | // Size shouldn't exceed maxDisplayFrames - 64 |
| 388 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 389 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 390 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 391 | sLayerNameOne, sLayerNameOne, |
| 392 | /*isBuffer*/ true); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 393 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 394 | mFrameTimeline->setSfWakeUp(sfToken, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 395 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 396 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 397 | mFrameTimeline->setSfPresent(27, presentFence); |
| 398 | } |
| 399 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 400 | |
| 401 | // Increase the size to 256 |
| 402 | mFrameTimeline->setMaxDisplayFrames(256); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 403 | EXPECT_EQ(*maxDisplayFrames, 256u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 404 | |
| 405 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 406 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 407 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 408 | sLayerNameOne, sLayerNameOne, |
| 409 | /*isBuffer*/ true); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 410 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 411 | mFrameTimeline->setSfWakeUp(sfToken, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 412 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 413 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 414 | mFrameTimeline->setSfPresent(27, presentFence); |
| 415 | } |
| 416 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 417 | |
| 418 | // Shrink the size to 128 |
| 419 | mFrameTimeline->setMaxDisplayFrames(128); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 420 | EXPECT_EQ(*maxDisplayFrames, 128u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 421 | |
| 422 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 423 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 424 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 425 | sLayerNameOne, sLayerNameOne, |
| 426 | /*isBuffer*/ true); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 427 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 428 | mFrameTimeline->setSfWakeUp(sfToken, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 429 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 430 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 431 | mFrameTimeline->setSfPresent(27, presentFence); |
| 432 | } |
| 433 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 434 | } |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 435 | |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 436 | TEST_F(FrameTimelineTest, presentFenceSignaled_invalidSignalTime) { |
| 437 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 438 | |
| 439 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 440 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 441 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 442 | |
| 443 | auto surfaceFrame1 = |
| 444 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 445 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 446 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 447 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 448 | surfaceFrame1->setAcquireFenceTime(20); |
| 449 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 450 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 451 | |
| 452 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 453 | presentFence1->signalForTest(-1); |
| 454 | addEmptyDisplayFrame(); |
| 455 | |
| 456 | auto displayFrame0 = getDisplayFrame(0); |
| 457 | EXPECT_EQ(displayFrame0->getActuals().presentTime, -1); |
| 458 | EXPECT_EQ(displayFrame0->getJankType(), JankType::Unknown); |
| 459 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, -1); |
| 460 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown); |
| 461 | } |
| 462 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 463 | // Tests related to TimeStats |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 464 | TEST_F(FrameTimelineTest, presentFenceSignaled_doesNotReportForInvalidTokens) { |
| 465 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 466 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(0); |
| 467 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 468 | int64_t surfaceFrameToken1 = -1; |
| 469 | int64_t sfToken1 = -1; |
| 470 | |
| 471 | auto surfaceFrame1 = |
| 472 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 473 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 474 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 475 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 476 | surfaceFrame1->setAcquireFenceTime(20); |
| 477 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 478 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 479 | presentFence1->signalForTest(70); |
| 480 | |
| 481 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 482 | } |
| 483 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 484 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfCpu) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 485 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 486 | // Deadline delta is 2ms because, sf's adjusted deadline is 60 - composerTime(3) = 57ms. |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 487 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 488 | incrementJankyFrames( |
| 489 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 490 | sLayerNameOne, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 491 | JankType::SurfaceFlingerCpuDeadlineMissed, 2, 10, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 492 | 0})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 493 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 494 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 495 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 496 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 497 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 498 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 499 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 500 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 501 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 502 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 503 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 504 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 505 | presentFence1->signalForTest(70); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 506 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 507 | mFrameTimeline->setSfPresent(59, presentFence1); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 508 | } |
| 509 | |
| 510 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsDisplayMiss) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 511 | Fps refreshRate = Fps::fromPeriodNsecs(30); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 512 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 513 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 514 | sLayerNameOne, JankType::DisplayHAL, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 515 | -1, 0, 0})); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 516 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 517 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 518 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 519 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 520 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 521 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 522 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 523 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 524 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 525 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 526 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 527 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 528 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 529 | presentFence1->signalForTest(90); |
| 530 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 531 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::DisplayHAL); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 532 | } |
| 533 | |
| 534 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMiss) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 535 | Fps refreshRate = Fps(11.0); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 536 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 537 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 538 | sLayerNameOne, |
| 539 | JankType::AppDeadlineMissed, -1, 0, |
| 540 | 25})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 541 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 542 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 543 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 544 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 545 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 546 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 547 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 548 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 549 | surfaceFrame1->setAcquireFenceTime(45); |
| 550 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 551 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 552 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 553 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 554 | presentFence1->signalForTest(90); |
| 555 | mFrameTimeline->setSfPresent(86, presentFence1); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 556 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 557 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 558 | } |
| 559 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 560 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfScheduling) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 561 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 562 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 563 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 564 | sLayerNameOne, |
| 565 | JankType::SurfaceFlingerScheduling, |
| 566 | -1, 0, -10})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 567 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 568 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({40, 60, 92}); |
| 569 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 570 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 571 | auto surfaceFrame1 = |
| 572 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 573 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 574 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 575 | surfaceFrame1->setAcquireFenceTime(50); |
| 576 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 577 | |
| 578 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 579 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 580 | presentFence1->signalForTest(60); |
| 581 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 582 | |
| 583 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
| 584 | } |
| 585 | |
| 586 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfPredictionError) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 587 | Fps refreshRate = Fps::fromPeriodNsecs(16); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 588 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 589 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 590 | sLayerNameOne, |
| 591 | JankType::PredictionError, -1, 5, |
| 592 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 593 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 594 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 60}); |
| 595 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 596 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 597 | auto surfaceFrame1 = |
| 598 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 599 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 600 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 601 | surfaceFrame1->setAcquireFenceTime(40); |
| 602 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 603 | |
| 604 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 605 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 606 | presentFence1->signalForTest(65); |
| 607 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 608 | |
| 609 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::PredictionError); |
| 610 | } |
| 611 | |
| 612 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppBufferStuffing) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 613 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 614 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 615 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 616 | sLayerNameOne, |
| 617 | JankType::BufferStuffing, -1, 0, |
| 618 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 619 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 620 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 58}); |
| 621 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 622 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 623 | auto surfaceFrame1 = |
| 624 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 625 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 626 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 627 | surfaceFrame1->setAcquireFenceTime(40); |
| 628 | mFrameTimeline->setSfWakeUp(sfToken1, 82, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 629 | |
| 630 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 631 | /*previousLatchTime*/ 56); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 632 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 633 | presentFence1->signalForTest(90); |
| 634 | mFrameTimeline->setSfPresent(86, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 635 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 636 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::BufferStuffing); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 637 | } |
| 638 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 639 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMissWithRenderRate) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 640 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 641 | Fps renderRate = Fps::fromPeriodNsecs(30); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 642 | EXPECT_CALL(*mTimeStats, |
| 643 | incrementJankyFrames( |
| 644 | TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, sLayerNameOne, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 645 | JankType::AppDeadlineMissed, -1, 0, 25})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 646 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 647 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 648 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 649 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 650 | auto surfaceFrame1 = |
| 651 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 652 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 653 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 654 | surfaceFrame1->setAcquireFenceTime(45); |
| 655 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 656 | |
| 657 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 658 | surfaceFrame1->setRenderRate(renderRate); |
| 659 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 660 | presentFence1->signalForTest(90); |
| 661 | mFrameTimeline->setSfPresent(86, presentFence1); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 662 | |
| 663 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
| 664 | } |
| 665 | |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 666 | TEST_F(FrameTimelineTest, presentFenceSignaled_displayFramePredictionExpiredPresentsSurfaceFrame) { |
| 667 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 668 | Fps renderRate = Fps::fromPeriodNsecs(30); |
| 669 | |
| 670 | EXPECT_CALL(*mTimeStats, |
| 671 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, |
| 672 | sLayerNameOne, JankType::Unknown, |
| 673 | -1, -1, 25})); |
| 674 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 675 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 676 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 677 | |
| 678 | auto surfaceFrame1 = |
| 679 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 680 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 681 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 682 | surfaceFrame1->setAcquireFenceTime(45); |
| 683 | // Trigger a prediction expiry |
| 684 | flushTokens(systemTime() + maxTokenRetentionTime); |
| 685 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 686 | |
| 687 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 688 | surfaceFrame1->setRenderRate(renderRate); |
| 689 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 690 | presentFence1->signalForTest(90); |
| 691 | mFrameTimeline->setSfPresent(86, presentFence1); |
| 692 | |
| 693 | auto displayFrame = getDisplayFrame(0); |
| 694 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown); |
| 695 | EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::UnknownStart); |
| 696 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
| 697 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 698 | |
| 699 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 90); |
| 700 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown); |
| 701 | } |
| 702 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 703 | /* |
| 704 | * Tracing Tests |
| 705 | * |
| 706 | * Trace packets are flushed all the way only when the next packet is traced. |
| 707 | * For example: trace<Display/Surface>Frame() will create a TracePacket but not flush it. Only when |
| 708 | * another TracePacket is created, the previous one is guaranteed to be flushed. The following tests |
| 709 | * will have additional empty frames created for this reason. |
| 710 | */ |
| 711 | TEST_F(FrameTimelineTest, tracing_noPacketsSentWithoutTraceStart) { |
| 712 | auto tracingSession = getTracingSessionForTest(); |
| 713 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 714 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 715 | auto surfaceFrame1 = |
| 716 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 717 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 718 | /*isBuffer*/ true); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 719 | |
| 720 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 721 | mFrameTimeline->setSfWakeUp(token1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 722 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 723 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 724 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 725 | presentFence1->signalForTest(30); |
| 726 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 727 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 728 | |
| 729 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 730 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 731 | } |
| 732 | |
| 733 | TEST_F(FrameTimelineTest, tracing_sanityTest) { |
| 734 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 735 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 736 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 737 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 738 | |
| 739 | tracingSession->StartBlocking(); |
| 740 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 741 | int64_t token2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 742 | auto surfaceFrame1 = |
| 743 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 744 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 745 | /*isBuffer*/ true); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 746 | |
| 747 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 748 | mFrameTimeline->setSfWakeUp(token2, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 749 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 750 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 751 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 752 | presentFence1->signalForTest(30); |
| 753 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 754 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 755 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 756 | tracingSession->StopBlocking(); |
| 757 | |
| 758 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 759 | // Display Frame 1 has 8 packets - 4 from DisplayFrame and 4 from SurfaceFrame. |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 760 | EXPECT_EQ(packets.size(), 8u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 761 | } |
| 762 | |
| 763 | TEST_F(FrameTimelineTest, traceDisplayFrame_invalidTokenDoesNotEmitTracePacket) { |
| 764 | auto tracingSession = getTracingSessionForTest(); |
| 765 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 766 | |
| 767 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 768 | |
| 769 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 770 | mFrameTimeline->setSfWakeUp(-1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 771 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 772 | presentFence1->signalForTest(30); |
| 773 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 774 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 775 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 776 | tracingSession->StopBlocking(); |
| 777 | |
| 778 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 779 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 780 | } |
| 781 | |
| 782 | TEST_F(FrameTimelineTest, traceSurfaceFrame_invalidTokenDoesNotEmitTracePacket) { |
| 783 | auto tracingSession = getTracingSessionForTest(); |
| 784 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 785 | |
| 786 | tracingSession->StartBlocking(); |
| 787 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 788 | auto surfaceFrame1 = |
| 789 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 790 | sLayerNameOne, sLayerNameOne, |
| 791 | /*isBuffer*/ true); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 792 | |
| 793 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 794 | mFrameTimeline->setSfWakeUp(token1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 795 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 796 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 797 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 798 | presentFence1->signalForTest(30); |
| 799 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 800 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 801 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 802 | tracingSession->StopBlocking(); |
| 803 | |
| 804 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 805 | // Display Frame 1 has 4 packets (SurfaceFrame shouldn't be traced since it has an invalid |
| 806 | // token). |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 807 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 808 | } |
| 809 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 810 | ProtoExpectedDisplayFrameStart createProtoExpectedDisplayFrameStart(int64_t cookie, int64_t token, |
| 811 | pid_t pid) { |
| 812 | ProtoExpectedDisplayFrameStart proto; |
| 813 | proto.set_cookie(cookie); |
| 814 | proto.set_token(token); |
| 815 | proto.set_pid(pid); |
| 816 | return proto; |
| 817 | } |
| 818 | |
| 819 | ProtoActualDisplayFrameStart createProtoActualDisplayFrameStart( |
| 820 | int64_t cookie, int64_t token, pid_t pid, ProtoPresentType presentType, bool onTimeFinish, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 821 | bool gpuComposition, ProtoJankType jankType, ProtoPredictionType predictionType) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 822 | ProtoActualDisplayFrameStart proto; |
| 823 | proto.set_cookie(cookie); |
| 824 | proto.set_token(token); |
| 825 | proto.set_pid(pid); |
| 826 | proto.set_present_type(presentType); |
| 827 | proto.set_on_time_finish(onTimeFinish); |
| 828 | proto.set_gpu_composition(gpuComposition); |
| 829 | proto.set_jank_type(jankType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 830 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 831 | return proto; |
| 832 | } |
| 833 | |
| 834 | ProtoExpectedSurfaceFrameStart createProtoExpectedSurfaceFrameStart(int64_t cookie, int64_t token, |
| 835 | int64_t displayFrameToken, |
| 836 | pid_t pid, |
| 837 | std::string layerName) { |
| 838 | ProtoExpectedSurfaceFrameStart proto; |
| 839 | proto.set_cookie(cookie); |
| 840 | proto.set_token(token); |
| 841 | proto.set_display_frame_token(displayFrameToken); |
| 842 | proto.set_pid(pid); |
| 843 | proto.set_layer_name(layerName); |
| 844 | return proto; |
| 845 | } |
| 846 | |
| 847 | ProtoActualSurfaceFrameStart createProtoActualSurfaceFrameStart( |
| 848 | int64_t cookie, int64_t token, int64_t displayFrameToken, pid_t pid, std::string layerName, |
| 849 | ProtoPresentType presentType, bool onTimeFinish, bool gpuComposition, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 850 | ProtoJankType jankType, ProtoPredictionType predictionType) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 851 | ProtoActualSurfaceFrameStart proto; |
| 852 | proto.set_cookie(cookie); |
| 853 | proto.set_token(token); |
| 854 | proto.set_display_frame_token(displayFrameToken); |
| 855 | proto.set_pid(pid); |
| 856 | proto.set_layer_name(layerName); |
| 857 | proto.set_present_type(presentType); |
| 858 | proto.set_on_time_finish(onTimeFinish); |
| 859 | proto.set_gpu_composition(gpuComposition); |
| 860 | proto.set_jank_type(jankType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 861 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 862 | return proto; |
| 863 | } |
| 864 | |
| 865 | ProtoFrameEnd createProtoFrameEnd(int64_t cookie) { |
| 866 | ProtoFrameEnd proto; |
| 867 | proto.set_cookie(cookie); |
| 868 | return proto; |
| 869 | } |
| 870 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 871 | void validateTraceEvent(const ProtoExpectedDisplayFrameStart& received, |
| 872 | const ProtoExpectedDisplayFrameStart& source) { |
| 873 | ASSERT_TRUE(received.has_cookie()); |
| 874 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 875 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 876 | ASSERT_TRUE(received.has_token()); |
| 877 | EXPECT_EQ(received.token(), source.token()); |
| 878 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 879 | ASSERT_TRUE(received.has_pid()); |
| 880 | EXPECT_EQ(received.pid(), source.pid()); |
| 881 | } |
| 882 | |
| 883 | void validateTraceEvent(const ProtoActualDisplayFrameStart& received, |
| 884 | const ProtoActualDisplayFrameStart& source) { |
| 885 | ASSERT_TRUE(received.has_cookie()); |
| 886 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 887 | |
| 888 | ASSERT_TRUE(received.has_token()); |
| 889 | EXPECT_EQ(received.token(), source.token()); |
| 890 | |
| 891 | ASSERT_TRUE(received.has_pid()); |
| 892 | EXPECT_EQ(received.pid(), source.pid()); |
| 893 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 894 | ASSERT_TRUE(received.has_present_type()); |
| 895 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 896 | ASSERT_TRUE(received.has_on_time_finish()); |
| 897 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 898 | ASSERT_TRUE(received.has_gpu_composition()); |
| 899 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 900 | ASSERT_TRUE(received.has_jank_type()); |
| 901 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 902 | ASSERT_TRUE(received.has_prediction_type()); |
| 903 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 904 | } |
| 905 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 906 | void validateTraceEvent(const ProtoExpectedSurfaceFrameStart& received, |
| 907 | const ProtoExpectedSurfaceFrameStart& source) { |
| 908 | ASSERT_TRUE(received.has_cookie()); |
| 909 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 910 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 911 | ASSERT_TRUE(received.has_token()); |
| 912 | EXPECT_EQ(received.token(), source.token()); |
| 913 | |
| 914 | ASSERT_TRUE(received.has_display_frame_token()); |
| 915 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 916 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 917 | ASSERT_TRUE(received.has_pid()); |
| 918 | EXPECT_EQ(received.pid(), source.pid()); |
| 919 | |
| 920 | ASSERT_TRUE(received.has_layer_name()); |
| 921 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 922 | } |
| 923 | |
| 924 | void validateTraceEvent(const ProtoActualSurfaceFrameStart& received, |
| 925 | const ProtoActualSurfaceFrameStart& source) { |
| 926 | ASSERT_TRUE(received.has_cookie()); |
| 927 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 928 | |
| 929 | ASSERT_TRUE(received.has_token()); |
| 930 | EXPECT_EQ(received.token(), source.token()); |
| 931 | |
| 932 | ASSERT_TRUE(received.has_display_frame_token()); |
| 933 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 934 | |
| 935 | ASSERT_TRUE(received.has_pid()); |
| 936 | EXPECT_EQ(received.pid(), source.pid()); |
| 937 | |
| 938 | ASSERT_TRUE(received.has_layer_name()); |
| 939 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 940 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 941 | ASSERT_TRUE(received.has_present_type()); |
| 942 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 943 | ASSERT_TRUE(received.has_on_time_finish()); |
| 944 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 945 | ASSERT_TRUE(received.has_gpu_composition()); |
| 946 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 947 | ASSERT_TRUE(received.has_jank_type()); |
| 948 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 949 | ASSERT_TRUE(received.has_prediction_type()); |
| 950 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 951 | } |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 952 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 953 | void validateTraceEvent(const ProtoFrameEnd& received, const ProtoFrameEnd& source) { |
| 954 | ASSERT_TRUE(received.has_cookie()); |
| 955 | EXPECT_EQ(received.cookie(), source.cookie()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 956 | } |
| 957 | |
| 958 | TEST_F(FrameTimelineTest, traceDisplayFrame_emitsValidTracePacket) { |
| 959 | auto tracingSession = getTracingSessionForTest(); |
| 960 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 961 | |
| 962 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 963 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 30, 30}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 964 | |
| 965 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 966 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 967 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 968 | presentFence1->signalForTest(31); |
| 969 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 970 | int64_t traceCookie = snoopCurrentTraceCookie(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 971 | auto protoExpectedDisplayFrameStart = |
| 972 | createProtoExpectedDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 973 | kSurfaceFlingerPid); |
| 974 | auto protoExpectedDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 975 | auto protoActualDisplayFrameStart = |
| 976 | createProtoActualDisplayFrameStart(traceCookie + 2, displayFrameToken1, |
| 977 | kSurfaceFlingerPid, |
| 978 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 979 | FrameTimelineEvent::JANK_NONE, |
| 980 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 981 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 982 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 983 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 984 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 985 | tracingSession->StopBlocking(); |
| 986 | |
| 987 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 988 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 989 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 990 | // Packet - 0 : ExpectedDisplayFrameStart |
| 991 | const auto& packet0 = packets[0]; |
| 992 | ASSERT_TRUE(packet0.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 993 | EXPECT_EQ(packet0.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 994 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 995 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 996 | const auto& event0 = packet0.frame_timeline_event(); |
| 997 | ASSERT_TRUE(event0.has_expected_display_frame_start()); |
| 998 | const auto& expectedDisplayFrameStart = event0.expected_display_frame_start(); |
| 999 | validateTraceEvent(expectedDisplayFrameStart, protoExpectedDisplayFrameStart); |
| 1000 | |
| 1001 | // Packet - 1 : FrameEnd (ExpectedDisplayFrame) |
| 1002 | const auto& packet1 = packets[1]; |
| 1003 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1004 | EXPECT_EQ(packet1.timestamp(), 30u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1005 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1006 | |
| 1007 | const auto& event1 = packet1.frame_timeline_event(); |
| 1008 | ASSERT_TRUE(event1.has_frame_end()); |
| 1009 | const auto& expectedDisplayFrameEnd = event1.frame_end(); |
| 1010 | validateTraceEvent(expectedDisplayFrameEnd, protoExpectedDisplayFrameEnd); |
| 1011 | |
| 1012 | // Packet - 2 : ActualDisplayFrameStart |
| 1013 | const auto& packet2 = packets[2]; |
| 1014 | ASSERT_TRUE(packet2.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1015 | EXPECT_EQ(packet2.timestamp(), 20u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1016 | ASSERT_TRUE(packet2.has_frame_timeline_event()); |
| 1017 | |
| 1018 | const auto& event2 = packet2.frame_timeline_event(); |
| 1019 | ASSERT_TRUE(event2.has_actual_display_frame_start()); |
| 1020 | const auto& actualDisplayFrameStart = event2.actual_display_frame_start(); |
| 1021 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1022 | |
| 1023 | // Packet - 3 : FrameEnd (ActualDisplayFrame) |
| 1024 | const auto& packet3 = packets[3]; |
| 1025 | ASSERT_TRUE(packet3.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1026 | EXPECT_EQ(packet3.timestamp(), 31u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1027 | ASSERT_TRUE(packet3.has_frame_timeline_event()); |
| 1028 | |
| 1029 | const auto& event3 = packet3.frame_timeline_event(); |
| 1030 | ASSERT_TRUE(event3.has_frame_end()); |
| 1031 | const auto& actualDisplayFrameEnd = event3.frame_end(); |
| 1032 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1033 | } |
| 1034 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1035 | TEST_F(FrameTimelineTest, traceDisplayFrame_predictionExpiredDoesNotTraceExpectedTimeline) { |
| 1036 | auto tracingSession = getTracingSessionForTest(); |
| 1037 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1038 | |
| 1039 | tracingSession->StartBlocking(); |
| 1040 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 25, 30}); |
| 1041 | // Flush the token so that it would expire |
| 1042 | flushTokens(systemTime() + maxTokenRetentionTime); |
| 1043 | |
| 1044 | // Set up the display frame |
| 1045 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, Fps::fromPeriodNsecs(11)); |
| 1046 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1047 | presentFence1->signalForTest(31); |
| 1048 | |
| 1049 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1050 | |
| 1051 | auto protoActualDisplayFrameStart = |
| 1052 | createProtoActualDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1053 | kSurfaceFlingerPid, |
| 1054 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1055 | false, FrameTimelineEvent::JANK_UNKNOWN, |
| 1056 | FrameTimelineEvent::PREDICTION_EXPIRED); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1057 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1058 | |
| 1059 | addEmptyDisplayFrame(); |
| 1060 | flushTrace(); |
| 1061 | tracingSession->StopBlocking(); |
| 1062 | |
| 1063 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1064 | // Only actual timeline packets should be in the trace |
| 1065 | EXPECT_EQ(packets.size(), 2u); |
| 1066 | |
| 1067 | // Packet - 0 : ActualDisplayFrameStart |
| 1068 | const auto& packet0 = packets[0]; |
| 1069 | ASSERT_TRUE(packet0.has_timestamp()); |
| 1070 | EXPECT_EQ(packet0.timestamp(), 20u); |
| 1071 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
| 1072 | |
| 1073 | const auto& event0 = packet0.frame_timeline_event(); |
| 1074 | ASSERT_TRUE(event0.has_actual_display_frame_start()); |
| 1075 | const auto& actualDisplayFrameStart = event0.actual_display_frame_start(); |
| 1076 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1077 | |
| 1078 | // Packet - 1 : FrameEnd (ActualDisplayFrame) |
| 1079 | const auto& packet1 = packets[1]; |
| 1080 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1081 | EXPECT_EQ(packet1.timestamp(), 31u); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1082 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1083 | |
| 1084 | const auto& event1 = packet1.frame_timeline_event(); |
| 1085 | ASSERT_TRUE(event1.has_frame_end()); |
| 1086 | const auto& actualDisplayFrameEnd = event1.frame_end(); |
| 1087 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
| 1088 | } |
| 1089 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1090 | TEST_F(FrameTimelineTest, traceSurfaceFrame_emitsValidTracePacket) { |
| 1091 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1092 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1093 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1094 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1095 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1096 | |
| 1097 | tracingSession->StartBlocking(); |
| 1098 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 25, 40}); |
| 1099 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({30, 35, 40}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1100 | |
| 1101 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1102 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1103 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1104 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1105 | auto surfaceFrame2 = |
| 1106 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1107 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1108 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1109 | surfaceFrame1->setActualQueueTime(10); |
| 1110 | surfaceFrame1->setDropTime(15); |
| 1111 | |
| 1112 | surfaceFrame2->setActualQueueTime(15); |
| 1113 | surfaceFrame2->setAcquireFenceTime(20); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1114 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1115 | // First 2 cookies will be used by the DisplayFrame |
| 1116 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1117 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1118 | auto protoDroppedSurfaceFrameExpectedStart = |
| 1119 | createProtoExpectedSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1120 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1121 | auto protoDroppedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 1); |
| 1122 | auto protoDroppedSurfaceFrameActualStart = |
| 1123 | createProtoActualSurfaceFrameStart(traceCookie + 2, surfaceFrameToken, |
| 1124 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1125 | FrameTimelineEvent::PRESENT_DROPPED, false, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1126 | FrameTimelineEvent::JANK_NONE, |
| 1127 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1128 | auto protoDroppedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1129 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1130 | auto protoPresentedSurfaceFrameExpectedStart = |
| 1131 | createProtoExpectedSurfaceFrameStart(traceCookie + 3, surfaceFrameToken, |
| 1132 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1133 | auto protoPresentedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 3); |
| 1134 | auto protoPresentedSurfaceFrameActualStart = |
| 1135 | createProtoActualSurfaceFrameStart(traceCookie + 4, surfaceFrameToken, |
| 1136 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1137 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1138 | FrameTimelineEvent::JANK_NONE, |
| 1139 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1140 | auto protoPresentedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 4); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1141 | |
| 1142 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1143 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1144 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1145 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1146 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1147 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1148 | mFrameTimeline->setSfPresent(26, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1149 | presentFence1->signalForTest(40); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1150 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1151 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1152 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1153 | tracingSession->StopBlocking(); |
| 1154 | |
| 1155 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1156 | // 4 DisplayFrame + 4 DroppedSurfaceFrame + 4 PresentedSurfaceFrame |
| 1157 | EXPECT_EQ(packets.size(), 12u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1158 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1159 | // Packet - 4 : ExpectedSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1160 | const auto& packet4 = packets[4]; |
| 1161 | ASSERT_TRUE(packet4.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1162 | EXPECT_EQ(packet4.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1163 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1164 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1165 | const auto& event4 = packet4.frame_timeline_event(); |
| 1166 | ASSERT_TRUE(event4.has_expected_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1167 | const auto& expectedSurfaceFrameStart1 = event4.expected_surface_frame_start(); |
| 1168 | validateTraceEvent(expectedSurfaceFrameStart1, protoDroppedSurfaceFrameExpectedStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1169 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1170 | // Packet - 5 : FrameEnd (ExpectedSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1171 | const auto& packet5 = packets[5]; |
| 1172 | ASSERT_TRUE(packet5.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1173 | EXPECT_EQ(packet5.timestamp(), 25u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1174 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1175 | |
| 1176 | const auto& event5 = packet5.frame_timeline_event(); |
| 1177 | ASSERT_TRUE(event5.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1178 | const auto& expectedSurfaceFrameEnd1 = event5.frame_end(); |
| 1179 | validateTraceEvent(expectedSurfaceFrameEnd1, protoDroppedSurfaceFrameExpectedEnd); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1180 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1181 | // Packet - 6 : ActualSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1182 | const auto& packet6 = packets[6]; |
| 1183 | ASSERT_TRUE(packet6.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1184 | EXPECT_EQ(packet6.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1185 | ASSERT_TRUE(packet6.has_frame_timeline_event()); |
| 1186 | |
| 1187 | const auto& event6 = packet6.frame_timeline_event(); |
| 1188 | ASSERT_TRUE(event6.has_actual_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1189 | const auto& actualSurfaceFrameStart1 = event6.actual_surface_frame_start(); |
| 1190 | validateTraceEvent(actualSurfaceFrameStart1, protoDroppedSurfaceFrameActualStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1191 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1192 | // Packet - 7 : FrameEnd (ActualSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1193 | const auto& packet7 = packets[7]; |
| 1194 | ASSERT_TRUE(packet7.has_timestamp()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1195 | EXPECT_EQ(packet7.timestamp(), 15u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1196 | ASSERT_TRUE(packet7.has_frame_timeline_event()); |
| 1197 | |
| 1198 | const auto& event7 = packet7.frame_timeline_event(); |
| 1199 | ASSERT_TRUE(event7.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1200 | const auto& actualSurfaceFrameEnd1 = event7.frame_end(); |
| 1201 | validateTraceEvent(actualSurfaceFrameEnd1, protoDroppedSurfaceFrameActualEnd); |
| 1202 | |
| 1203 | // Packet - 8 : ExpectedSurfaceFrameStart2 |
| 1204 | const auto& packet8 = packets[8]; |
| 1205 | ASSERT_TRUE(packet8.has_timestamp()); |
| 1206 | EXPECT_EQ(packet8.timestamp(), 10u); |
| 1207 | ASSERT_TRUE(packet8.has_frame_timeline_event()); |
| 1208 | |
| 1209 | const auto& event8 = packet8.frame_timeline_event(); |
| 1210 | ASSERT_TRUE(event8.has_expected_surface_frame_start()); |
| 1211 | const auto& expectedSurfaceFrameStart2 = event8.expected_surface_frame_start(); |
| 1212 | validateTraceEvent(expectedSurfaceFrameStart2, protoPresentedSurfaceFrameExpectedStart); |
| 1213 | |
| 1214 | // Packet - 9 : FrameEnd (ExpectedSurfaceFrame2) |
| 1215 | const auto& packet9 = packets[9]; |
| 1216 | ASSERT_TRUE(packet9.has_timestamp()); |
| 1217 | EXPECT_EQ(packet9.timestamp(), 25u); |
| 1218 | ASSERT_TRUE(packet9.has_frame_timeline_event()); |
| 1219 | |
| 1220 | const auto& event9 = packet9.frame_timeline_event(); |
| 1221 | ASSERT_TRUE(event9.has_frame_end()); |
| 1222 | const auto& expectedSurfaceFrameEnd2 = event9.frame_end(); |
| 1223 | validateTraceEvent(expectedSurfaceFrameEnd2, protoPresentedSurfaceFrameExpectedEnd); |
| 1224 | |
| 1225 | // Packet - 10 : ActualSurfaceFrameStart2 |
| 1226 | const auto& packet10 = packets[10]; |
| 1227 | ASSERT_TRUE(packet10.has_timestamp()); |
| 1228 | EXPECT_EQ(packet10.timestamp(), 10u); |
| 1229 | ASSERT_TRUE(packet10.has_frame_timeline_event()); |
| 1230 | |
| 1231 | const auto& event10 = packet10.frame_timeline_event(); |
| 1232 | ASSERT_TRUE(event10.has_actual_surface_frame_start()); |
| 1233 | const auto& actualSurfaceFrameStart2 = event10.actual_surface_frame_start(); |
| 1234 | validateTraceEvent(actualSurfaceFrameStart2, protoPresentedSurfaceFrameActualStart); |
| 1235 | |
| 1236 | // Packet - 11 : FrameEnd (ActualSurfaceFrame2) |
| 1237 | const auto& packet11 = packets[11]; |
| 1238 | ASSERT_TRUE(packet11.has_timestamp()); |
| 1239 | EXPECT_EQ(packet11.timestamp(), 20u); |
| 1240 | ASSERT_TRUE(packet11.has_frame_timeline_event()); |
| 1241 | |
| 1242 | const auto& event11 = packet11.frame_timeline_event(); |
| 1243 | ASSERT_TRUE(event11.has_frame_end()); |
| 1244 | const auto& actualSurfaceFrameEnd2 = event11.frame_end(); |
| 1245 | validateTraceEvent(actualSurfaceFrameEnd2, protoPresentedSurfaceFrameActualEnd); |
| 1246 | } |
| 1247 | |
| 1248 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredDoesNotTraceExpectedTimeline) { |
| 1249 | auto tracingSession = getTracingSessionForTest(); |
| 1250 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1251 | |
| 1252 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1253 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1254 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1255 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1256 | int64_t surfaceFrameToken = |
| 1257 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1258 | |
| 1259 | // Flush the token so that it would expire |
| 1260 | flushTokens(systemTime() + maxTokenRetentionTime); |
| 1261 | auto surfaceFrame1 = |
| 1262 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, /*inputEventId*/ 0}, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1263 | sPidOne, sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1264 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1265 | surfaceFrame1->setActualQueueTime(appEndTime); |
| 1266 | surfaceFrame1->setAcquireFenceTime(appEndTime); |
| 1267 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1268 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(20ms).count(); |
| 1269 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1270 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1271 | int64_t displayFrameToken = |
| 1272 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1273 | |
| 1274 | // First 2 cookies will be used by the DisplayFrame |
| 1275 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1276 | |
| 1277 | auto protoActualSurfaceFrameStart = |
| 1278 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1279 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1280 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1281 | false, FrameTimelineEvent::JANK_UNKNOWN, |
| 1282 | FrameTimelineEvent::PREDICTION_EXPIRED); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1283 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1284 | |
| 1285 | // Set up the display frame |
| 1286 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, Fps::fromPeriodNsecs(11)); |
| 1287 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1288 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1289 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1290 | presentFence1->signalForTest(sfPresentTime); |
| 1291 | |
| 1292 | addEmptyDisplayFrame(); |
| 1293 | flushTrace(); |
| 1294 | tracingSession->StopBlocking(); |
| 1295 | |
| 1296 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1297 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1298 | ASSERT_EQ(packets.size(), 6u); |
| 1299 | |
| 1300 | // Packet - 4 : ActualSurfaceFrameStart |
| 1301 | const auto& packet4 = packets[4]; |
| 1302 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1303 | EXPECT_EQ(packet4.timestamp(), |
| 1304 | static_cast<uint64_t>(appEndTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1305 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1306 | |
| 1307 | const auto& event4 = packet4.frame_timeline_event(); |
| 1308 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1309 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1310 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1311 | |
| 1312 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1313 | const auto& packet5 = packets[5]; |
| 1314 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1315 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(appEndTime)); |
| 1316 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1317 | |
| 1318 | const auto& event5 = packet5.frame_timeline_event(); |
| 1319 | ASSERT_TRUE(event5.has_frame_end()); |
| 1320 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1321 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1322 | } |
| 1323 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1324 | // Tests for Jank classification |
| 1325 | TEST_F(FrameTimelineTest, jankClassification_presentOnTimeDoesNotClassify) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1326 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1327 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1328 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1329 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1330 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 30}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1331 | auto surfaceFrame = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1332 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1333 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1334 | sLayerNameOne, /*isBuffer*/ true); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1335 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1336 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1337 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 1338 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1339 | auto displayFrame = getDisplayFrame(0); |
| 1340 | auto& presentedSurfaceFrame = getSurfaceFrame(0, 0); |
| 1341 | presentFence1->signalForTest(29); |
| 1342 | |
| 1343 | // Fences haven't been flushed yet, so it should be 0 |
| 1344 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1345 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 0); |
| 1346 | |
| 1347 | addEmptyDisplayFrame(); |
| 1348 | displayFrame = getDisplayFrame(0); |
| 1349 | |
| 1350 | // Fences have flushed, so the present timestamps should be updated |
| 1351 | EXPECT_EQ(displayFrame->getActuals().presentTime, 29); |
| 1352 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 29); |
| 1353 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1354 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1355 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
| 1356 | } |
| 1357 | |
| 1358 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1359 | Fps vsyncRate = Fps::fromPeriodNsecs(11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1360 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1361 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1362 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1363 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1364 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1365 | auto displayFrame = getDisplayFrame(0); |
| 1366 | presentFence1->signalForTest(30); |
| 1367 | |
| 1368 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1369 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1370 | |
| 1371 | // Trigger a flush by finalizing the next DisplayFrame |
| 1372 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1373 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1374 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1375 | displayFrame = getDisplayFrame(0); |
| 1376 | |
| 1377 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1378 | EXPECT_EQ(displayFrame->getActuals().presentTime, 30); |
| 1379 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1380 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1381 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1382 | |
| 1383 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1384 | auto displayFrame2 = getDisplayFrame(1); |
| 1385 | presentFence2->signalForTest(65); |
| 1386 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1387 | addEmptyDisplayFrame(); |
| 1388 | displayFrame2 = getDisplayFrame(1); |
| 1389 | |
| 1390 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1391 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1392 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1393 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1394 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1395 | } |
| 1396 | |
| 1397 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1398 | Fps vsyncRate = Fps::fromPeriodNsecs(11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1399 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1400 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1401 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1402 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1403 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1404 | auto displayFrame = getDisplayFrame(0); |
| 1405 | presentFence1->signalForTest(50); |
| 1406 | |
| 1407 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1408 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1409 | |
| 1410 | // Trigger a flush by finalizing the next DisplayFrame |
| 1411 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1412 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1413 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1414 | displayFrame = getDisplayFrame(0); |
| 1415 | |
| 1416 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1417 | EXPECT_EQ(displayFrame->getActuals().presentTime, 50); |
| 1418 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1419 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1420 | EXPECT_EQ(displayFrame->getJankType(), JankType::DisplayHAL); |
| 1421 | |
| 1422 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1423 | auto displayFrame2 = getDisplayFrame(1); |
| 1424 | presentFence2->signalForTest(75); |
| 1425 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1426 | |
| 1427 | addEmptyDisplayFrame(); |
| 1428 | displayFrame2 = getDisplayFrame(1); |
| 1429 | |
| 1430 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1431 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 75); |
| 1432 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1433 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1434 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1435 | } |
| 1436 | |
| 1437 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishEarlyPresent) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1438 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1439 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({12, 18, 40}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1440 | mFrameTimeline->setSfWakeUp(sfToken1, 12, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1441 | |
| 1442 | mFrameTimeline->setSfPresent(22, presentFence1); |
| 1443 | auto displayFrame = getDisplayFrame(0); |
| 1444 | presentFence1->signalForTest(28); |
| 1445 | |
| 1446 | // Fences haven't been flushed yet, so it should be 0 |
| 1447 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1448 | |
| 1449 | addEmptyDisplayFrame(); |
| 1450 | displayFrame = getDisplayFrame(0); |
| 1451 | |
| 1452 | // Fences have flushed, so the present timestamps should be updated |
| 1453 | EXPECT_EQ(displayFrame->getActuals().presentTime, 28); |
| 1454 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1455 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1456 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1457 | } |
| 1458 | |
| 1459 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1460 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1461 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1462 | mFrameTimeline->setSfWakeUp(sfToken1, 12, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1463 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 1464 | auto displayFrame = getDisplayFrame(0); |
| 1465 | presentFence1->signalForTest(52); |
| 1466 | |
| 1467 | // Fences haven't been flushed yet, so it should be 0 |
| 1468 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1469 | |
| 1470 | addEmptyDisplayFrame(); |
| 1471 | displayFrame = getDisplayFrame(0); |
| 1472 | |
| 1473 | // Fences have flushed, so the present timestamps should be updated |
| 1474 | EXPECT_EQ(displayFrame->getActuals().presentTime, 52); |
| 1475 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1476 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1477 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
| 1478 | } |
| 1479 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1480 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateStartLateFinishLatePresent) { |
| 1481 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1482 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 1483 | mFrameTimeline->setSfWakeUp(sfToken1, 26, Fps::fromPeriodNsecs(11)); |
| 1484 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 1485 | auto displayFrame = getDisplayFrame(0); |
| 1486 | presentFence1->signalForTest(52); |
| 1487 | |
| 1488 | // Fences haven't been flushed yet, so it should be 0 |
| 1489 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1490 | |
| 1491 | addEmptyDisplayFrame(); |
| 1492 | displayFrame = getDisplayFrame(0); |
| 1493 | |
| 1494 | // Fences have flushed, so the present timestamps should be updated |
| 1495 | EXPECT_EQ(displayFrame->getActuals().presentTime, 52); |
| 1496 | EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::LateStart); |
| 1497 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1498 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1499 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1500 | } |
| 1501 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1502 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1503 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1504 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1505 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1506 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1507 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1508 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1509 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1510 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1511 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1512 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1513 | surfaceFrame1->setAcquireFenceTime(16); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1514 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1515 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1516 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1517 | mFrameTimeline->setSfPresent(27, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1518 | auto displayFrame1 = getDisplayFrame(0); |
| 1519 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1520 | presentFence1->signalForTest(30); |
| 1521 | |
| 1522 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1523 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1524 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1525 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1526 | |
| 1527 | // Trigger a flush by finalizing the next DisplayFrame |
| 1528 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1529 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1530 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1531 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1532 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1533 | surfaceFrame2->setAcquireFenceTime(36); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1534 | mFrameTimeline->setSfWakeUp(sfToken2, 52, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1535 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1536 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1537 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1538 | auto displayFrame2 = getDisplayFrame(1); |
| 1539 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1540 | |
| 1541 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1542 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 30); |
| 1543 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1544 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1545 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1546 | |
| 1547 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1548 | EXPECT_EQ(actuals1.presentTime, 30); |
| 1549 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1550 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1551 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::SurfaceFlingerScheduling); |
| 1552 | |
| 1553 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1554 | presentFence2->signalForTest(65); |
| 1555 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1556 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1557 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1558 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1559 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 1560 | |
| 1561 | EXPECT_CALL(*mTimeStats, |
| 1562 | incrementJankyFrames( |
| 1563 | TimeStats::JankyFramesInfo{Fps::fromPeriodNsecs(11), std::nullopt, sUidOne, |
| 1564 | sLayerNameOne, JankType::PredictionError, 0, 5, |
| 1565 | 0})); |
| 1566 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1567 | addEmptyDisplayFrame(); |
| 1568 | |
| 1569 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1570 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1571 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1572 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1573 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1574 | |
| 1575 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1576 | EXPECT_EQ(actuals2.presentTime, 65); |
| 1577 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1578 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1579 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
| 1580 | } |
| 1581 | |
| 1582 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1583 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1584 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1585 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1586 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1587 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1588 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1589 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1590 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1591 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1592 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1593 | surfaceFrame1->setAcquireFenceTime(16); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1594 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1595 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1596 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1597 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1598 | auto displayFrame1 = getDisplayFrame(0); |
| 1599 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1600 | presentFence1->signalForTest(50); |
| 1601 | |
| 1602 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1603 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1604 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1605 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1606 | |
| 1607 | // Trigger a flush by finalizing the next DisplayFrame |
| 1608 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1609 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1610 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1611 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1612 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1613 | surfaceFrame2->setAcquireFenceTime(36); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1614 | mFrameTimeline->setSfWakeUp(sfToken2, 52, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1615 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1616 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1617 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1618 | auto displayFrame2 = getDisplayFrame(1); |
| 1619 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1620 | |
| 1621 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1622 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 1623 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1624 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1625 | EXPECT_EQ(displayFrame1->getJankType(), JankType::DisplayHAL); |
| 1626 | |
| 1627 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1628 | EXPECT_EQ(actuals1.presentTime, 50); |
| 1629 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1630 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1631 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::DisplayHAL); |
| 1632 | |
| 1633 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1634 | presentFence2->signalForTest(86); |
| 1635 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1636 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1637 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1638 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1639 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 1640 | |
| 1641 | EXPECT_CALL(*mTimeStats, |
| 1642 | incrementJankyFrames( |
| 1643 | TimeStats::JankyFramesInfo{Fps::fromPeriodNsecs(11), std::nullopt, sUidOne, |
| 1644 | sLayerNameOne, JankType::PredictionError, 0, 5, |
| 1645 | 0})); |
| 1646 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1647 | addEmptyDisplayFrame(); |
| 1648 | |
| 1649 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1650 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 86); |
| 1651 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1652 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1653 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1654 | |
| 1655 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1656 | EXPECT_EQ(actuals2.presentTime, 86); |
| 1657 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1658 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1659 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
| 1660 | } |
| 1661 | |
| 1662 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1663 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1664 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1665 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1666 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1667 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 26, 60}); |
| 1668 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1669 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1670 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1671 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1672 | surfaceFrame1->setAcquireFenceTime(40); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1673 | mFrameTimeline->setSfWakeUp(sfToken1, 42, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1674 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1675 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1676 | mFrameTimeline->setSfPresent(46, presentFence1); |
| 1677 | auto displayFrame1 = getDisplayFrame(0); |
| 1678 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1679 | presentFence1->signalForTest(50); |
| 1680 | |
| 1681 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1682 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1683 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1684 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1685 | |
| 1686 | addEmptyDisplayFrame(); |
| 1687 | |
| 1688 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1689 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 1690 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1691 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1692 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1693 | |
| 1694 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1695 | EXPECT_EQ(actuals1.presentTime, 50); |
| 1696 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1697 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1698 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::Unknown); |
| 1699 | } |
| 1700 | |
| 1701 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishLatePresent) { |
| 1702 | // First frame - DisplayFrame is not janky. This should classify the SurfaceFrame as |
| 1703 | // AppDeadlineMissed. Second frame - DisplayFrame is janky. This should propagate DisplayFrame's |
| 1704 | // jank to the SurfaceFrame. |
| 1705 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1706 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1707 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1708 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({32, 40, 40}); |
| 1709 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1710 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 1711 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 50}); |
| 1712 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1713 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1714 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1715 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1716 | surfaceFrame1->setAcquireFenceTime(26); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1717 | mFrameTimeline->setSfWakeUp(sfToken1, 32, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1718 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1719 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1720 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 1721 | auto displayFrame1 = getDisplayFrame(0); |
| 1722 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1723 | presentFence1->signalForTest(40); |
| 1724 | |
| 1725 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1726 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1727 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1728 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1729 | |
| 1730 | // Trigger a flush by finalizing the next DisplayFrame |
| 1731 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1732 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1733 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1734 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1735 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1736 | surfaceFrame2->setAcquireFenceTime(40); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1737 | mFrameTimeline->setSfWakeUp(sfToken2, 43, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1738 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1739 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1740 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1741 | auto displayFrame2 = getDisplayFrame(1); |
| 1742 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1743 | |
| 1744 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1745 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 40); |
| 1746 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1747 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1748 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1749 | |
| 1750 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1751 | EXPECT_EQ(actuals1.presentTime, 40); |
| 1752 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1753 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1754 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 1755 | |
| 1756 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1757 | presentFence2->signalForTest(60); |
| 1758 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1759 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1760 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1761 | |
| 1762 | addEmptyDisplayFrame(); |
| 1763 | |
| 1764 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1765 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 60); |
| 1766 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1767 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1768 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
| 1769 | |
| 1770 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1771 | EXPECT_EQ(actuals2.presentTime, 60); |
| 1772 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1773 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1774 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
| 1775 | } |
| 1776 | |
| 1777 | TEST_F(FrameTimelineTest, jankClassification_multiJankBufferStuffingAndAppDeadlineMissed) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1778 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1779 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1780 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1781 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 1782 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 1783 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1784 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 1785 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1786 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1787 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1788 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1789 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1790 | surfaceFrame1->setAcquireFenceTime(50); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1791 | mFrameTimeline->setSfWakeUp(sfToken1, 52, Fps::fromPeriodNsecs(30)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1792 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1793 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1794 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 1795 | auto displayFrame1 = getDisplayFrame(0); |
| 1796 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1797 | presentFence1->signalForTest(60); |
| 1798 | |
| 1799 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1800 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1801 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1802 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1803 | |
| 1804 | // Trigger a flush by finalizing the next DisplayFrame |
| 1805 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1806 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1807 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1808 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1809 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1810 | surfaceFrame2->setAcquireFenceTime(84); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1811 | mFrameTimeline->setSfWakeUp(sfToken2, 112, Fps::fromPeriodNsecs(30)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1812 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 1813 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1814 | mFrameTimeline->setSfPresent(116, presentFence2); |
| 1815 | auto displayFrame2 = getDisplayFrame(1); |
| 1816 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1817 | presentFence2->signalForTest(120); |
| 1818 | |
| 1819 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1820 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 1821 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1822 | EXPECT_EQ(actuals1.endTime, 50); |
| 1823 | EXPECT_EQ(actuals1.presentTime, 60); |
| 1824 | |
| 1825 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1826 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1827 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1828 | |
| 1829 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1830 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1831 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 1832 | |
| 1833 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1834 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1835 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1836 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1837 | |
| 1838 | addEmptyDisplayFrame(); |
| 1839 | |
| 1840 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1841 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 1842 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1843 | EXPECT_EQ(actuals2.presentTime, 120); |
| 1844 | |
| 1845 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1846 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1847 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
| 1848 | |
| 1849 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1850 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1851 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 1852 | JankType::AppDeadlineMissed | JankType::BufferStuffing); |
| 1853 | } |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1854 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1855 | TEST_F(FrameTimelineTest, jankClassification_appDeadlineAdjustedForBufferStuffing) { |
| 1856 | // Layer specific increment |
| 1857 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
| 1858 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1859 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 1860 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 1861 | |
| 1862 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 1863 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 1864 | auto surfaceFrame1 = |
| 1865 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 1866 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1867 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1868 | surfaceFrame1->setAcquireFenceTime(50); |
| 1869 | mFrameTimeline->setSfWakeUp(sfToken1, 52, Fps::fromPeriodNsecs(30)); |
| 1870 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1871 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1872 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 1873 | auto displayFrame1 = getDisplayFrame(0); |
| 1874 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1875 | presentFence1->signalForTest(60); |
| 1876 | |
| 1877 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1878 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1879 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1880 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1881 | |
| 1882 | // Trigger a flush by finalizing the next DisplayFrame |
| 1883 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1884 | auto surfaceFrame2 = |
| 1885 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
| 1886 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1887 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1888 | surfaceFrame2->setAcquireFenceTime(80); |
| 1889 | mFrameTimeline->setSfWakeUp(sfToken2, 82, Fps::fromPeriodNsecs(30)); |
| 1890 | // Setting previous latch time to 54, adjusted deadline will be 54 + vsyncTime(30) = 84 |
| 1891 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 1892 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1893 | mFrameTimeline->setSfPresent(86, presentFence2); |
| 1894 | auto displayFrame2 = getDisplayFrame(1); |
| 1895 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1896 | presentFence2->signalForTest(90); |
| 1897 | |
| 1898 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1899 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 1900 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1901 | EXPECT_EQ(actuals1.endTime, 50); |
| 1902 | EXPECT_EQ(actuals1.presentTime, 60); |
| 1903 | |
| 1904 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1905 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1906 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1907 | |
| 1908 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1909 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1910 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 1911 | |
| 1912 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1913 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1914 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1915 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1916 | |
| 1917 | addEmptyDisplayFrame(); |
| 1918 | |
| 1919 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1920 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 1921 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1922 | EXPECT_EQ(actuals2.presentTime, 90); |
| 1923 | |
| 1924 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1925 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1926 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
| 1927 | |
| 1928 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1929 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1930 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::BufferStuffing); |
| 1931 | } |
| 1932 | |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1933 | TEST_F(FrameTimelineTest, computeFps_noLayerIds_returnsZero) { |
| 1934 | EXPECT_EQ(mFrameTimeline->computeFps({}), 0.0f); |
| 1935 | } |
| 1936 | |
| 1937 | TEST_F(FrameTimelineTest, computeFps_singleDisplayFrame_returnsZero) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1938 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1939 | |
| 1940 | auto surfaceFrame1 = |
| 1941 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1942 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 1943 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1944 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1945 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1946 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1947 | presentFence1->signalForTest(oneHundredMs); |
| 1948 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 1949 | |
| 1950 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 1951 | } |
| 1952 | |
| 1953 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_oneLayer) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1954 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 1955 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1956 | auto surfaceFrame1 = |
| 1957 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1958 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 1959 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1960 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1961 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1962 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1963 | presentFence1->signalForTest(oneHundredMs); |
| 1964 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 1965 | |
| 1966 | auto surfaceFrame2 = |
| 1967 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1968 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 1969 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1970 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1971 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1972 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1973 | presentFence2->signalForTest(twoHundredMs); |
| 1974 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 1975 | |
| 1976 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 10.0); |
| 1977 | } |
| 1978 | |
| 1979 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_twoLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1980 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 1981 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1982 | auto surfaceFrame1 = |
| 1983 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1984 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 1985 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1986 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1987 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1988 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1989 | presentFence1->signalForTest(oneHundredMs); |
| 1990 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 1991 | |
| 1992 | auto surfaceFrame2 = |
| 1993 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1994 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
| 1995 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1996 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1997 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1998 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1999 | presentFence2->signalForTest(twoHundredMs); |
| 2000 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2001 | |
| 2002 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne, sLayerIdTwo}), 10.0f); |
| 2003 | } |
| 2004 | |
| 2005 | TEST_F(FrameTimelineTest, computeFps_filtersOutLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2006 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2007 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2008 | auto surfaceFrame1 = |
| 2009 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2010 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2011 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2012 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2013 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2014 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2015 | presentFence1->signalForTest(oneHundredMs); |
| 2016 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2017 | |
| 2018 | auto surfaceFrame2 = |
| 2019 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2020 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
| 2021 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2022 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2023 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2024 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2025 | presentFence2->signalForTest(twoHundredMs); |
| 2026 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2027 | |
| 2028 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2029 | } |
| 2030 | |
| 2031 | TEST_F(FrameTimelineTest, computeFps_averagesOverMultipleFrames) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2032 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2033 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
| 2034 | const auto threeHundredMs = std::chrono::nanoseconds(300ms).count(); |
| 2035 | const auto fiveHundredMs = std::chrono::nanoseconds(500ms).count(); |
| 2036 | const auto sixHundredMs = std::chrono::nanoseconds(600ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2037 | auto surfaceFrame1 = |
| 2038 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2039 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2040 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2041 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2042 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2043 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2044 | presentFence1->signalForTest(oneHundredMs); |
| 2045 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2046 | |
| 2047 | auto surfaceFrame2 = |
| 2048 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2049 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2050 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2051 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2052 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2053 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2054 | presentFence2->signalForTest(twoHundredMs); |
| 2055 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2056 | |
| 2057 | auto surfaceFrame3 = |
| 2058 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2059 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
| 2060 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2061 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2062 | surfaceFrame3->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2063 | mFrameTimeline->addSurfaceFrame(surfaceFrame3); |
| 2064 | presentFence3->signalForTest(threeHundredMs); |
| 2065 | mFrameTimeline->setSfPresent(threeHundredMs, presentFence3); |
| 2066 | |
| 2067 | auto surfaceFrame4 = |
| 2068 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2069 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2070 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2071 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2072 | surfaceFrame4->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2073 | mFrameTimeline->addSurfaceFrame(surfaceFrame4); |
| 2074 | presentFence4->signalForTest(fiveHundredMs); |
| 2075 | mFrameTimeline->setSfPresent(fiveHundredMs, presentFence4); |
| 2076 | |
| 2077 | auto surfaceFrame5 = |
| 2078 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2079 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2080 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2081 | auto presentFence5 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2082 | // Dropped frames will be excluded from fps computation |
| 2083 | surfaceFrame5->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 2084 | mFrameTimeline->addSurfaceFrame(surfaceFrame5); |
| 2085 | presentFence5->signalForTest(sixHundredMs); |
| 2086 | mFrameTimeline->setSfPresent(sixHundredMs, presentFence5); |
| 2087 | |
| 2088 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 5.0f); |
| 2089 | } |
| 2090 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 2091 | } // namespace android::frametimeline |