Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2020 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Marin Shalamanov | bed7fd3 | 2020-12-21 20:02:20 +0100 | [diff] [blame] | 17 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 18 | #include "gmock/gmock-spec-builders.h" |
| 19 | #include "mock/MockTimeStats.h" |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 20 | #undef LOG_TAG |
| 21 | #define LOG_TAG "LibSurfaceFlingerUnittests" |
| 22 | |
| 23 | #include <FrameTimeline/FrameTimeline.h> |
| 24 | #include <gtest/gtest.h> |
| 25 | #include <log/log.h> |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 26 | #include <perfetto/trace/trace.pb.h> |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 27 | #include <cinttypes> |
| 28 | |
| 29 | using namespace std::chrono_literals; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 30 | using testing::_; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 31 | using testing::AtLeast; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 32 | using testing::Contains; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 33 | using FrameTimelineEvent = perfetto::protos::FrameTimelineEvent; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 34 | using ProtoExpectedDisplayFrameStart = |
| 35 | perfetto::protos::FrameTimelineEvent_ExpectedDisplayFrameStart; |
| 36 | using ProtoExpectedSurfaceFrameStart = |
| 37 | perfetto::protos::FrameTimelineEvent_ExpectedSurfaceFrameStart; |
| 38 | using ProtoActualDisplayFrameStart = perfetto::protos::FrameTimelineEvent_ActualDisplayFrameStart; |
| 39 | using ProtoActualSurfaceFrameStart = perfetto::protos::FrameTimelineEvent_ActualSurfaceFrameStart; |
| 40 | using ProtoFrameEnd = perfetto::protos::FrameTimelineEvent_FrameEnd; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 41 | using ProtoPresentType = perfetto::protos::FrameTimelineEvent_PresentType; |
| 42 | using ProtoJankType = perfetto::protos::FrameTimelineEvent_JankType; |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 43 | using ProtoPredictionType = perfetto::protos::FrameTimelineEvent_PredictionType; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 44 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 45 | namespace android::frametimeline { |
| 46 | |
| 47 | class FrameTimelineTest : public testing::Test { |
| 48 | public: |
| 49 | FrameTimelineTest() { |
| 50 | const ::testing::TestInfo* const test_info = |
| 51 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 52 | ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 53 | } |
| 54 | |
| 55 | ~FrameTimelineTest() { |
| 56 | const ::testing::TestInfo* const test_info = |
| 57 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 58 | ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 59 | } |
| 60 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 61 | static void SetUpTestSuite() { |
| 62 | // Need to initialize tracing in process for testing, and only once per test suite. |
| 63 | perfetto::TracingInitArgs args; |
| 64 | args.backends = perfetto::kInProcessBackend; |
| 65 | perfetto::Tracing::Initialize(args); |
| 66 | } |
| 67 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 68 | void SetUp() override { |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 69 | mTimeStats = std::make_shared<mock::TimeStats>(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 70 | mFrameTimeline = std::make_unique<impl::FrameTimeline>(mTimeStats, kSurfaceFlingerPid, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 71 | kTestThresholds); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 72 | mFrameTimeline->registerDataSource(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 73 | mTokenManager = &mFrameTimeline->mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 74 | mTraceCookieCounter = &mFrameTimeline->mTraceCookieCounter; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 75 | maxDisplayFrames = &mFrameTimeline->mMaxDisplayFrames; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 76 | maxTokenRetentionTime = mTokenManager->kMaxRetentionTime; |
| 77 | } |
| 78 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 79 | // Each tracing session can be used for a single block of Start -> Stop. |
| 80 | static std::unique_ptr<perfetto::TracingSession> getTracingSessionForTest() { |
| 81 | perfetto::TraceConfig cfg; |
| 82 | cfg.set_duration_ms(500); |
| 83 | cfg.add_buffers()->set_size_kb(1024); |
| 84 | auto* ds_cfg = cfg.add_data_sources()->mutable_config(); |
| 85 | ds_cfg->set_name(impl::FrameTimeline::kFrameTimelineDataSource); |
| 86 | |
| 87 | auto tracingSession = perfetto::Tracing::NewTrace(perfetto::kInProcessBackend); |
| 88 | tracingSession->Setup(cfg); |
| 89 | return tracingSession; |
| 90 | } |
| 91 | |
| 92 | std::vector<perfetto::protos::TracePacket> readFrameTimelinePacketsBlocking( |
| 93 | perfetto::TracingSession* tracingSession) { |
| 94 | std::vector<char> raw_trace = tracingSession->ReadTraceBlocking(); |
| 95 | perfetto::protos::Trace trace; |
| 96 | EXPECT_TRUE(trace.ParseFromArray(raw_trace.data(), int(raw_trace.size()))); |
| 97 | |
| 98 | std::vector<perfetto::protos::TracePacket> packets; |
| 99 | for (const auto& packet : trace.packet()) { |
| 100 | if (!packet.has_frame_timeline_event()) { |
| 101 | continue; |
| 102 | } |
| 103 | packets.emplace_back(packet); |
| 104 | } |
| 105 | return packets; |
| 106 | } |
| 107 | |
| 108 | void addEmptyDisplayFrame() { |
| 109 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 110 | // Trigger a flushPresentFence by calling setSfPresent for the next frame |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 111 | mFrameTimeline->setSfPresent(2500, presentFence1); |
| 112 | } |
| 113 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 114 | void flushTokens(nsecs_t flushTime) { |
| 115 | std::lock_guard<std::mutex> lock(mTokenManager->mMutex); |
| 116 | mTokenManager->flushTokens(flushTime); |
| 117 | } |
| 118 | |
| 119 | SurfaceFrame& getSurfaceFrame(size_t displayFrameIdx, size_t surfaceFrameIdx) { |
| 120 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 121 | return *(mFrameTimeline->mDisplayFrames[displayFrameIdx] |
| 122 | ->getSurfaceFrames()[surfaceFrameIdx]); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 123 | } |
| 124 | |
| 125 | std::shared_ptr<impl::FrameTimeline::DisplayFrame> getDisplayFrame(size_t idx) { |
| 126 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 127 | return mFrameTimeline->mDisplayFrames[idx]; |
| 128 | } |
| 129 | |
| 130 | static bool compareTimelineItems(const TimelineItem& a, const TimelineItem& b) { |
| 131 | return a.startTime == b.startTime && a.endTime == b.endTime && |
| 132 | a.presentTime == b.presentTime; |
| 133 | } |
| 134 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 135 | const std::map<int64_t, TokenManagerPrediction>& getPredictions() const { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 136 | return mTokenManager->mPredictions; |
| 137 | } |
| 138 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 139 | uint32_t getNumberOfDisplayFrames() const { |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 140 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 141 | return static_cast<uint32_t>(mFrameTimeline->mDisplayFrames.size()); |
| 142 | } |
| 143 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 144 | int64_t snoopCurrentTraceCookie() const { return mTraceCookieCounter->mTraceCookie; } |
| 145 | |
| 146 | void flushTrace() { |
| 147 | using FrameTimelineDataSource = impl::FrameTimeline::FrameTimelineDataSource; |
| 148 | FrameTimelineDataSource::Trace( |
| 149 | [&](FrameTimelineDataSource::TraceContext ctx) { ctx.Flush(); }); |
| 150 | } |
| 151 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 152 | std::shared_ptr<mock::TimeStats> mTimeStats; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 153 | std::unique_ptr<impl::FrameTimeline> mFrameTimeline; |
| 154 | impl::TokenManager* mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 155 | TraceCookieCounter* mTraceCookieCounter; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 156 | FenceToFenceTimeMap fenceFactory; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 157 | uint32_t* maxDisplayFrames; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 158 | nsecs_t maxTokenRetentionTime; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 159 | static constexpr pid_t kSurfaceFlingerPid = 666; |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 160 | static constexpr nsecs_t kPresentThreshold = std::chrono::nanoseconds(2ns).count(); |
| 161 | static constexpr nsecs_t kDeadlineThreshold = std::chrono::nanoseconds(2ns).count(); |
| 162 | static constexpr nsecs_t kStartThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 163 | static constexpr JankClassificationThresholds kTestThresholds{kPresentThreshold, |
| 164 | kDeadlineThreshold, |
| 165 | kStartThreshold}; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 166 | }; |
| 167 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 168 | static const std::string sLayerNameOne = "layer1"; |
| 169 | static const std::string sLayerNameTwo = "layer2"; |
| 170 | static constexpr const uid_t sUidOne = 0; |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 171 | static constexpr pid_t sPidOne = 10; |
| 172 | static constexpr pid_t sPidTwo = 20; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 173 | static constexpr int32_t sInputEventId = 5; |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 174 | static constexpr int32_t sLayerIdOne = 1; |
| 175 | static constexpr int32_t sLayerIdTwo = 2; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 176 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 177 | TEST_F(FrameTimelineTest, tokenManagerRemovesStalePredictions) { |
| 178 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 179 | EXPECT_EQ(getPredictions().size(), 1u); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 180 | flushTokens(systemTime() + maxTokenRetentionTime); |
| 181 | int64_t token2 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 182 | std::optional<TimelineItem> predictions = mTokenManager->getPredictionsForToken(token1); |
| 183 | |
| 184 | // token1 should have expired |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 185 | EXPECT_EQ(getPredictions().size(), 1u); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 186 | EXPECT_EQ(predictions.has_value(), false); |
| 187 | |
| 188 | predictions = mTokenManager->getPredictionsForToken(token2); |
| 189 | EXPECT_EQ(compareTimelineItems(*predictions, TimelineItem(10, 20, 30)), true); |
| 190 | } |
| 191 | |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 192 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_getOwnerPidReturnsCorrectPid) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 193 | auto surfaceFrame1 = |
| 194 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 195 | sLayerNameOne, sLayerNameOne, |
| 196 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 197 | auto surfaceFrame2 = |
| 198 | mFrameTimeline->createSurfaceFrameForToken({}, sPidTwo, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 199 | sLayerNameOne, sLayerNameOne, |
| 200 | /*isBuffer*/ true); |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 201 | EXPECT_EQ(surfaceFrame1->getOwnerPid(), sPidOne); |
| 202 | EXPECT_EQ(surfaceFrame2->getOwnerPid(), sPidTwo); |
| 203 | } |
| 204 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 205 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_noToken) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 206 | auto surfaceFrame = |
| 207 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 208 | sLayerNameOne, sLayerNameOne, |
| 209 | /*isBuffer*/ true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 210 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::None); |
| 211 | } |
| 212 | |
| 213 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_expiredToken) { |
| 214 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
| 215 | flushTokens(systemTime() + maxTokenRetentionTime); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 216 | auto surfaceFrame = |
| 217 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 218 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 219 | /*isBuffer*/ true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 220 | |
| 221 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Expired); |
| 222 | } |
| 223 | |
| 224 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validToken) { |
| 225 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 226 | auto surfaceFrame = |
| 227 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 228 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 229 | /*isBuffer*/ true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 230 | |
| 231 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Valid); |
| 232 | EXPECT_EQ(compareTimelineItems(surfaceFrame->getPredictions(), TimelineItem(10, 20, 30)), true); |
| 233 | } |
| 234 | |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 235 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validInputEventId) { |
| 236 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 237 | constexpr int32_t inputEventId = 1; |
| 238 | auto surfaceFrame = |
| 239 | mFrameTimeline->createSurfaceFrameForToken({token1, inputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 240 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 241 | /*isBuffer*/ true); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 242 | |
| 243 | EXPECT_EQ(inputEventId, surfaceFrame->getInputEventId()); |
| 244 | } |
| 245 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 246 | TEST_F(FrameTimelineTest, presentFenceSignaled_droppedFramesNotUpdated) { |
| 247 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 248 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 249 | auto surfaceFrame1 = |
| 250 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 251 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 252 | /*isBuffer*/ true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 253 | |
| 254 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 255 | mFrameTimeline->setSfWakeUp(token1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 256 | surfaceFrame1->setDropTime(12); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 257 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 258 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 259 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 260 | presentFence1->signalForTest(30); |
| 261 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 262 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 263 | |
| 264 | auto& droppedSurfaceFrame = getSurfaceFrame(0, 0); |
| 265 | EXPECT_EQ(droppedSurfaceFrame.getPresentState(), SurfaceFrame::PresentState::Dropped); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 266 | EXPECT_EQ(0u, droppedSurfaceFrame.getActuals().endTime); |
| 267 | EXPECT_EQ(12u, droppedSurfaceFrame.getDropTime()); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 268 | EXPECT_EQ(droppedSurfaceFrame.getActuals().presentTime, 0); |
| 269 | } |
| 270 | |
| 271 | TEST_F(FrameTimelineTest, presentFenceSignaled_presentedFramesUpdated) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 272 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 273 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 274 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 275 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 276 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 277 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 278 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 279 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 280 | sLayerNameOne, /*isBuffer*/ true); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 281 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 282 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 283 | sUidOne, sLayerIdTwo, sLayerNameTwo, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 284 | sLayerNameTwo, /*isBuffer*/ true); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 285 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 286 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 287 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 288 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 289 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 290 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 291 | auto displayFrame = getDisplayFrame(0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 292 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 293 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 294 | presentFence1->signalForTest(42); |
| 295 | |
| 296 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 297 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 298 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 0); |
| 299 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 300 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 301 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 302 | |
| 303 | // Fences have flushed, so the present timestamps should be updated |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 304 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 305 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 42); |
| 306 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 307 | EXPECT_NE(surfaceFrame1->getJankType(), std::nullopt); |
| 308 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 309 | } |
| 310 | |
| 311 | TEST_F(FrameTimelineTest, displayFramesSlidingWindowMovesAfterLimit) { |
| 312 | // Insert kMaxDisplayFrames' count of DisplayFrames to fill the deque |
| 313 | int frameTimeFactor = 0; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 314 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 315 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)) |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 316 | .Times(static_cast<int32_t>(*maxDisplayFrames)); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 317 | for (size_t i = 0; i < *maxDisplayFrames; i++) { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 318 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 319 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 320 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 321 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 322 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 323 | auto surfaceFrame = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 324 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 325 | sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 326 | sLayerNameOne, sLayerNameOne, |
| 327 | /*isBuffer*/ true); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 328 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 329 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 330 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 331 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 332 | presentFence->signalForTest(32 + frameTimeFactor); |
| 333 | frameTimeFactor += 30; |
| 334 | } |
| 335 | auto displayFrame0 = getDisplayFrame(0); |
| 336 | |
| 337 | // The 0th Display Frame should have actuals 22, 27, 32 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 338 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(22, 27, 32)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 339 | |
| 340 | // Add one more display frame |
| 341 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 342 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 343 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 344 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 345 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 346 | auto surfaceFrame = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 347 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 348 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 349 | sLayerNameOne, /*isBuffer*/ true); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 350 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 351 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 352 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 353 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 354 | presentFence->signalForTest(32 + frameTimeFactor); |
| 355 | displayFrame0 = getDisplayFrame(0); |
| 356 | |
| 357 | // The window should have slided by 1 now and the previous 0th display frame |
| 358 | // should have been removed from the deque |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 359 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(52, 57, 62)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 360 | } |
| 361 | |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 362 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceAfterQueue) { |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 363 | auto surfaceFrame = |
| 364 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 365 | "acquireFenceAfterQueue", |
| 366 | "acquireFenceAfterQueue", /*isBuffer*/ true); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 367 | surfaceFrame->setActualQueueTime(123); |
| 368 | surfaceFrame->setAcquireFenceTime(456); |
| 369 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 370 | } |
| 371 | |
| 372 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceBeforeQueue) { |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 373 | auto surfaceFrame = |
| 374 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 375 | "acquireFenceAfterQueue", |
| 376 | "acquireFenceAfterQueue", /*isBuffer*/ true); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 377 | surfaceFrame->setActualQueueTime(456); |
| 378 | surfaceFrame->setAcquireFenceTime(123); |
| 379 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 380 | } |
| 381 | |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 382 | TEST_F(FrameTimelineTest, setMaxDisplayFramesSetsSizeProperly) { |
| 383 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 384 | presentFence->signalForTest(2); |
| 385 | |
| 386 | // Size shouldn't exceed maxDisplayFrames - 64 |
| 387 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 388 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 389 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 390 | sLayerNameOne, sLayerNameOne, |
| 391 | /*isBuffer*/ true); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 392 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 393 | mFrameTimeline->setSfWakeUp(sfToken, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 394 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 395 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 396 | mFrameTimeline->setSfPresent(27, presentFence); |
| 397 | } |
| 398 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 399 | |
| 400 | // Increase the size to 256 |
| 401 | mFrameTimeline->setMaxDisplayFrames(256); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 402 | EXPECT_EQ(*maxDisplayFrames, 256u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 403 | |
| 404 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 405 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 406 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 407 | sLayerNameOne, sLayerNameOne, |
| 408 | /*isBuffer*/ true); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 409 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 410 | mFrameTimeline->setSfWakeUp(sfToken, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 411 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 412 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 413 | mFrameTimeline->setSfPresent(27, presentFence); |
| 414 | } |
| 415 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 416 | |
| 417 | // Shrink the size to 128 |
| 418 | mFrameTimeline->setMaxDisplayFrames(128); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 419 | EXPECT_EQ(*maxDisplayFrames, 128u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 420 | |
| 421 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 422 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 423 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 424 | sLayerNameOne, sLayerNameOne, |
| 425 | /*isBuffer*/ true); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 426 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 427 | mFrameTimeline->setSfWakeUp(sfToken, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 428 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 429 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 430 | mFrameTimeline->setSfPresent(27, presentFence); |
| 431 | } |
| 432 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 433 | } |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 434 | |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 435 | TEST_F(FrameTimelineTest, presentFenceSignaled_invalidSignalTime) { |
| 436 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 437 | |
| 438 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 439 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 440 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 441 | |
| 442 | auto surfaceFrame1 = |
| 443 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 444 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 445 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 446 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 447 | surfaceFrame1->setAcquireFenceTime(20); |
| 448 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 449 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 450 | |
| 451 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 452 | presentFence1->signalForTest(-1); |
| 453 | addEmptyDisplayFrame(); |
| 454 | |
| 455 | auto displayFrame0 = getDisplayFrame(0); |
| 456 | EXPECT_EQ(displayFrame0->getActuals().presentTime, -1); |
| 457 | EXPECT_EQ(displayFrame0->getJankType(), JankType::Unknown); |
| 458 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, -1); |
| 459 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown); |
| 460 | } |
| 461 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 462 | // Tests related to TimeStats |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 463 | TEST_F(FrameTimelineTest, presentFenceSignaled_doesNotReportForInvalidTokens) { |
| 464 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 465 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(0); |
| 466 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 467 | int64_t surfaceFrameToken1 = -1; |
| 468 | int64_t sfToken1 = -1; |
| 469 | |
| 470 | auto surfaceFrame1 = |
| 471 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 472 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 473 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 474 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 475 | surfaceFrame1->setAcquireFenceTime(20); |
| 476 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 477 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 478 | presentFence1->signalForTest(70); |
| 479 | |
| 480 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 481 | } |
| 482 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 483 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfCpu) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 484 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 485 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 486 | incrementJankyFrames( |
| 487 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 488 | sLayerNameOne, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 489 | JankType::SurfaceFlingerCpuDeadlineMissed, 2, 10, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 490 | 0})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 491 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 492 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 493 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 494 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 495 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 496 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 497 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 498 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 499 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 500 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 501 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 502 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 503 | presentFence1->signalForTest(70); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 504 | |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 505 | mFrameTimeline->setSfPresent(62, presentFence1); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 506 | } |
| 507 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 508 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfGpu) { |
| 509 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 510 | EXPECT_CALL(*mTimeStats, |
| 511 | incrementJankyFrames( |
| 512 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 513 | sLayerNameOne, |
| 514 | JankType::SurfaceFlingerGpuDeadlineMissed, 4, 10, |
| 515 | 0})); |
| 516 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 517 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 518 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 519 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 520 | |
| 521 | auto surfaceFrame1 = |
| 522 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 523 | sUidOne, sLayerIdOne, sLayerNameOne, |
| 524 | sLayerNameOne, /*isBuffer*/ true); |
| 525 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 526 | surfaceFrame1->setAcquireFenceTime(20); |
| 527 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 528 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 529 | gpuFence1->signalForTest(64); |
| 530 | presentFence1->signalForTest(70); |
| 531 | |
| 532 | mFrameTimeline->setSfPresent(59, presentFence1, gpuFence1); |
| 533 | } |
| 534 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 535 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsDisplayMiss) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 536 | Fps refreshRate = Fps::fromPeriodNsecs(30); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 537 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 538 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 539 | sLayerNameOne, JankType::DisplayHAL, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 540 | -4, 0, 0})); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 541 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 542 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 543 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 544 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 545 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 546 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 547 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 548 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 549 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 550 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 551 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 552 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 553 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 554 | presentFence1->signalForTest(90); |
| 555 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 556 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::DisplayHAL); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 557 | } |
| 558 | |
| 559 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMiss) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 560 | Fps refreshRate = Fps(11.0); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 561 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 562 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 563 | sLayerNameOne, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 564 | JankType::AppDeadlineMissed, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 565 | 25})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 566 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 567 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 568 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 569 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 570 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 571 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 572 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 573 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 574 | surfaceFrame1->setAcquireFenceTime(45); |
| 575 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 576 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 577 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 578 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 579 | presentFence1->signalForTest(90); |
| 580 | mFrameTimeline->setSfPresent(86, presentFence1); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 581 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 582 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 583 | } |
| 584 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 585 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfScheduling) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 586 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 587 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 588 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 589 | sLayerNameOne, |
| 590 | JankType::SurfaceFlingerScheduling, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 591 | -4, 0, -10})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 592 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 593 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({40, 60, 92}); |
| 594 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 595 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 596 | auto surfaceFrame1 = |
| 597 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 598 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 599 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 600 | surfaceFrame1->setAcquireFenceTime(50); |
| 601 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 602 | |
| 603 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 604 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 605 | presentFence1->signalForTest(60); |
| 606 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 607 | |
| 608 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
| 609 | } |
| 610 | |
| 611 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfPredictionError) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 612 | Fps refreshRate = Fps::fromPeriodNsecs(16); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 613 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 614 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 615 | sLayerNameOne, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 616 | JankType::PredictionError, -4, 5, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 617 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 618 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 619 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 60}); |
| 620 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 621 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 622 | auto surfaceFrame1 = |
| 623 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 624 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 625 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 626 | surfaceFrame1->setAcquireFenceTime(40); |
| 627 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 628 | |
| 629 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 630 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 631 | presentFence1->signalForTest(65); |
| 632 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 633 | |
| 634 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::PredictionError); |
| 635 | } |
| 636 | |
| 637 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppBufferStuffing) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 638 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 639 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 640 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
| 641 | sLayerNameOne, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 642 | JankType::BufferStuffing, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 643 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 644 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 645 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 58}); |
| 646 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 647 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 648 | auto surfaceFrame1 = |
| 649 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 650 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 651 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 652 | surfaceFrame1->setAcquireFenceTime(40); |
| 653 | mFrameTimeline->setSfWakeUp(sfToken1, 82, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 654 | |
| 655 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 656 | /*previousLatchTime*/ 56); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 657 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 658 | presentFence1->signalForTest(90); |
| 659 | mFrameTimeline->setSfPresent(86, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 660 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 661 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::BufferStuffing); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 662 | } |
| 663 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 664 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMissWithRenderRate) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 665 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 666 | Fps renderRate = Fps::fromPeriodNsecs(30); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 667 | EXPECT_CALL(*mTimeStats, |
| 668 | incrementJankyFrames( |
| 669 | TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, sLayerNameOne, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 670 | JankType::AppDeadlineMissed, -4, 0, 25})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 671 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 672 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 673 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 674 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 675 | auto surfaceFrame1 = |
| 676 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 677 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 678 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 679 | surfaceFrame1->setAcquireFenceTime(45); |
| 680 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 681 | |
| 682 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 683 | surfaceFrame1->setRenderRate(renderRate); |
| 684 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 685 | presentFence1->signalForTest(90); |
| 686 | mFrameTimeline->setSfPresent(86, presentFence1); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 687 | |
| 688 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
| 689 | } |
| 690 | |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 691 | TEST_F(FrameTimelineTest, presentFenceSignaled_displayFramePredictionExpiredPresentsSurfaceFrame) { |
| 692 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 693 | Fps renderRate = Fps::fromPeriodNsecs(30); |
| 694 | |
| 695 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 696 | incrementJankyFrames( |
| 697 | TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, sLayerNameOne, |
| 698 | JankType::Unknown | JankType::AppDeadlineMissed, |
Adithya Srinivasan | de27245 | 2021-04-10 00:21:00 +0000 | [diff] [blame] | 699 | 0, 0, 25})); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 700 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 701 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 702 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 703 | |
| 704 | auto surfaceFrame1 = |
| 705 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 706 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 707 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 708 | surfaceFrame1->setAcquireFenceTime(45); |
| 709 | // Trigger a prediction expiry |
| 710 | flushTokens(systemTime() + maxTokenRetentionTime); |
| 711 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 712 | |
| 713 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 714 | surfaceFrame1->setRenderRate(renderRate); |
| 715 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 716 | presentFence1->signalForTest(90); |
| 717 | mFrameTimeline->setSfPresent(86, presentFence1); |
| 718 | |
| 719 | auto displayFrame = getDisplayFrame(0); |
| 720 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown); |
| 721 | EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::UnknownStart); |
| 722 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
| 723 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 724 | |
| 725 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 726 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown | JankType::AppDeadlineMissed); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 727 | } |
| 728 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 729 | /* |
| 730 | * Tracing Tests |
| 731 | * |
| 732 | * Trace packets are flushed all the way only when the next packet is traced. |
| 733 | * For example: trace<Display/Surface>Frame() will create a TracePacket but not flush it. Only when |
| 734 | * another TracePacket is created, the previous one is guaranteed to be flushed. The following tests |
| 735 | * will have additional empty frames created for this reason. |
| 736 | */ |
| 737 | TEST_F(FrameTimelineTest, tracing_noPacketsSentWithoutTraceStart) { |
| 738 | auto tracingSession = getTracingSessionForTest(); |
| 739 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 740 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 741 | auto surfaceFrame1 = |
| 742 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 743 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 744 | /*isBuffer*/ true); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 745 | |
| 746 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 747 | mFrameTimeline->setSfWakeUp(token1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 748 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 749 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 750 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 751 | presentFence1->signalForTest(30); |
| 752 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 753 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 754 | |
| 755 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 756 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 757 | } |
| 758 | |
| 759 | TEST_F(FrameTimelineTest, tracing_sanityTest) { |
| 760 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 761 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 762 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 763 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 764 | |
| 765 | tracingSession->StartBlocking(); |
| 766 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 767 | int64_t token2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 768 | auto surfaceFrame1 = |
| 769 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 770 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 771 | /*isBuffer*/ true); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 772 | |
| 773 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 774 | mFrameTimeline->setSfWakeUp(token2, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 775 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 776 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 777 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 778 | presentFence1->signalForTest(30); |
| 779 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 780 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 781 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 782 | tracingSession->StopBlocking(); |
| 783 | |
| 784 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 785 | // Display Frame 1 has 8 packets - 4 from DisplayFrame and 4 from SurfaceFrame. |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 786 | EXPECT_EQ(packets.size(), 8u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 787 | } |
| 788 | |
| 789 | TEST_F(FrameTimelineTest, traceDisplayFrame_invalidTokenDoesNotEmitTracePacket) { |
| 790 | auto tracingSession = getTracingSessionForTest(); |
| 791 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 792 | |
| 793 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 794 | |
| 795 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 796 | mFrameTimeline->setSfWakeUp(-1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 797 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 798 | presentFence1->signalForTest(30); |
| 799 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 800 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 801 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 802 | tracingSession->StopBlocking(); |
| 803 | |
| 804 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 805 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 806 | } |
| 807 | |
| 808 | TEST_F(FrameTimelineTest, traceSurfaceFrame_invalidTokenDoesNotEmitTracePacket) { |
| 809 | auto tracingSession = getTracingSessionForTest(); |
| 810 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 811 | |
| 812 | tracingSession->StartBlocking(); |
| 813 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 814 | auto surfaceFrame1 = |
| 815 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 816 | sLayerNameOne, sLayerNameOne, |
| 817 | /*isBuffer*/ true); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 818 | |
| 819 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 820 | mFrameTimeline->setSfWakeUp(token1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 821 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 822 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 823 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 824 | presentFence1->signalForTest(30); |
| 825 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 826 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 827 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 828 | tracingSession->StopBlocking(); |
| 829 | |
| 830 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 831 | // Display Frame 1 has 4 packets (SurfaceFrame shouldn't be traced since it has an invalid |
| 832 | // token). |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 833 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 834 | } |
| 835 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 836 | ProtoExpectedDisplayFrameStart createProtoExpectedDisplayFrameStart(int64_t cookie, int64_t token, |
| 837 | pid_t pid) { |
| 838 | ProtoExpectedDisplayFrameStart proto; |
| 839 | proto.set_cookie(cookie); |
| 840 | proto.set_token(token); |
| 841 | proto.set_pid(pid); |
| 842 | return proto; |
| 843 | } |
| 844 | |
| 845 | ProtoActualDisplayFrameStart createProtoActualDisplayFrameStart( |
| 846 | int64_t cookie, int64_t token, pid_t pid, ProtoPresentType presentType, bool onTimeFinish, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 847 | bool gpuComposition, ProtoJankType jankType, ProtoPredictionType predictionType) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 848 | ProtoActualDisplayFrameStart proto; |
| 849 | proto.set_cookie(cookie); |
| 850 | proto.set_token(token); |
| 851 | proto.set_pid(pid); |
| 852 | proto.set_present_type(presentType); |
| 853 | proto.set_on_time_finish(onTimeFinish); |
| 854 | proto.set_gpu_composition(gpuComposition); |
| 855 | proto.set_jank_type(jankType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 856 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 857 | return proto; |
| 858 | } |
| 859 | |
| 860 | ProtoExpectedSurfaceFrameStart createProtoExpectedSurfaceFrameStart(int64_t cookie, int64_t token, |
| 861 | int64_t displayFrameToken, |
| 862 | pid_t pid, |
| 863 | std::string layerName) { |
| 864 | ProtoExpectedSurfaceFrameStart proto; |
| 865 | proto.set_cookie(cookie); |
| 866 | proto.set_token(token); |
| 867 | proto.set_display_frame_token(displayFrameToken); |
| 868 | proto.set_pid(pid); |
| 869 | proto.set_layer_name(layerName); |
| 870 | return proto; |
| 871 | } |
| 872 | |
| 873 | ProtoActualSurfaceFrameStart createProtoActualSurfaceFrameStart( |
| 874 | int64_t cookie, int64_t token, int64_t displayFrameToken, pid_t pid, std::string layerName, |
| 875 | ProtoPresentType presentType, bool onTimeFinish, bool gpuComposition, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 876 | ProtoJankType jankType, ProtoPredictionType predictionType) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 877 | ProtoActualSurfaceFrameStart proto; |
| 878 | proto.set_cookie(cookie); |
| 879 | proto.set_token(token); |
| 880 | proto.set_display_frame_token(displayFrameToken); |
| 881 | proto.set_pid(pid); |
| 882 | proto.set_layer_name(layerName); |
| 883 | proto.set_present_type(presentType); |
| 884 | proto.set_on_time_finish(onTimeFinish); |
| 885 | proto.set_gpu_composition(gpuComposition); |
| 886 | proto.set_jank_type(jankType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 887 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 888 | return proto; |
| 889 | } |
| 890 | |
| 891 | ProtoFrameEnd createProtoFrameEnd(int64_t cookie) { |
| 892 | ProtoFrameEnd proto; |
| 893 | proto.set_cookie(cookie); |
| 894 | return proto; |
| 895 | } |
| 896 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 897 | void validateTraceEvent(const ProtoExpectedDisplayFrameStart& received, |
| 898 | const ProtoExpectedDisplayFrameStart& source) { |
| 899 | ASSERT_TRUE(received.has_cookie()); |
| 900 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 901 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 902 | ASSERT_TRUE(received.has_token()); |
| 903 | EXPECT_EQ(received.token(), source.token()); |
| 904 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 905 | ASSERT_TRUE(received.has_pid()); |
| 906 | EXPECT_EQ(received.pid(), source.pid()); |
| 907 | } |
| 908 | |
| 909 | void validateTraceEvent(const ProtoActualDisplayFrameStart& received, |
| 910 | const ProtoActualDisplayFrameStart& source) { |
| 911 | ASSERT_TRUE(received.has_cookie()); |
| 912 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 913 | |
| 914 | ASSERT_TRUE(received.has_token()); |
| 915 | EXPECT_EQ(received.token(), source.token()); |
| 916 | |
| 917 | ASSERT_TRUE(received.has_pid()); |
| 918 | EXPECT_EQ(received.pid(), source.pid()); |
| 919 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 920 | ASSERT_TRUE(received.has_present_type()); |
| 921 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 922 | ASSERT_TRUE(received.has_on_time_finish()); |
| 923 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 924 | ASSERT_TRUE(received.has_gpu_composition()); |
| 925 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 926 | ASSERT_TRUE(received.has_jank_type()); |
| 927 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 928 | ASSERT_TRUE(received.has_prediction_type()); |
| 929 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 930 | } |
| 931 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 932 | void validateTraceEvent(const ProtoExpectedSurfaceFrameStart& received, |
| 933 | const ProtoExpectedSurfaceFrameStart& source) { |
| 934 | ASSERT_TRUE(received.has_cookie()); |
| 935 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 936 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 937 | ASSERT_TRUE(received.has_token()); |
| 938 | EXPECT_EQ(received.token(), source.token()); |
| 939 | |
| 940 | ASSERT_TRUE(received.has_display_frame_token()); |
| 941 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 942 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 943 | ASSERT_TRUE(received.has_pid()); |
| 944 | EXPECT_EQ(received.pid(), source.pid()); |
| 945 | |
| 946 | ASSERT_TRUE(received.has_layer_name()); |
| 947 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 948 | } |
| 949 | |
| 950 | void validateTraceEvent(const ProtoActualSurfaceFrameStart& received, |
| 951 | const ProtoActualSurfaceFrameStart& source) { |
| 952 | ASSERT_TRUE(received.has_cookie()); |
| 953 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 954 | |
| 955 | ASSERT_TRUE(received.has_token()); |
| 956 | EXPECT_EQ(received.token(), source.token()); |
| 957 | |
| 958 | ASSERT_TRUE(received.has_display_frame_token()); |
| 959 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 960 | |
| 961 | ASSERT_TRUE(received.has_pid()); |
| 962 | EXPECT_EQ(received.pid(), source.pid()); |
| 963 | |
| 964 | ASSERT_TRUE(received.has_layer_name()); |
| 965 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 966 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 967 | ASSERT_TRUE(received.has_present_type()); |
| 968 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 969 | ASSERT_TRUE(received.has_on_time_finish()); |
| 970 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 971 | ASSERT_TRUE(received.has_gpu_composition()); |
| 972 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 973 | ASSERT_TRUE(received.has_jank_type()); |
| 974 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 975 | ASSERT_TRUE(received.has_prediction_type()); |
| 976 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 977 | } |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 978 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 979 | void validateTraceEvent(const ProtoFrameEnd& received, const ProtoFrameEnd& source) { |
| 980 | ASSERT_TRUE(received.has_cookie()); |
| 981 | EXPECT_EQ(received.cookie(), source.cookie()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 982 | } |
| 983 | |
| 984 | TEST_F(FrameTimelineTest, traceDisplayFrame_emitsValidTracePacket) { |
| 985 | auto tracingSession = getTracingSessionForTest(); |
| 986 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 987 | |
| 988 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 989 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 30, 30}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 990 | |
| 991 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 992 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 993 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 994 | presentFence1->signalForTest(31); |
| 995 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 996 | int64_t traceCookie = snoopCurrentTraceCookie(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 997 | auto protoExpectedDisplayFrameStart = |
| 998 | createProtoExpectedDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 999 | kSurfaceFlingerPid); |
| 1000 | auto protoExpectedDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1001 | auto protoActualDisplayFrameStart = |
| 1002 | createProtoActualDisplayFrameStart(traceCookie + 2, displayFrameToken1, |
| 1003 | kSurfaceFlingerPid, |
| 1004 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1005 | FrameTimelineEvent::JANK_NONE, |
| 1006 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1007 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1008 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1009 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1010 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1011 | tracingSession->StopBlocking(); |
| 1012 | |
| 1013 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1014 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1015 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1016 | // Packet - 0 : ExpectedDisplayFrameStart |
| 1017 | const auto& packet0 = packets[0]; |
| 1018 | ASSERT_TRUE(packet0.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1019 | EXPECT_EQ(packet0.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1020 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1021 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1022 | const auto& event0 = packet0.frame_timeline_event(); |
| 1023 | ASSERT_TRUE(event0.has_expected_display_frame_start()); |
| 1024 | const auto& expectedDisplayFrameStart = event0.expected_display_frame_start(); |
| 1025 | validateTraceEvent(expectedDisplayFrameStart, protoExpectedDisplayFrameStart); |
| 1026 | |
| 1027 | // Packet - 1 : FrameEnd (ExpectedDisplayFrame) |
| 1028 | const auto& packet1 = packets[1]; |
| 1029 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1030 | EXPECT_EQ(packet1.timestamp(), 30u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1031 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1032 | |
| 1033 | const auto& event1 = packet1.frame_timeline_event(); |
| 1034 | ASSERT_TRUE(event1.has_frame_end()); |
| 1035 | const auto& expectedDisplayFrameEnd = event1.frame_end(); |
| 1036 | validateTraceEvent(expectedDisplayFrameEnd, protoExpectedDisplayFrameEnd); |
| 1037 | |
| 1038 | // Packet - 2 : ActualDisplayFrameStart |
| 1039 | const auto& packet2 = packets[2]; |
| 1040 | ASSERT_TRUE(packet2.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1041 | EXPECT_EQ(packet2.timestamp(), 20u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1042 | ASSERT_TRUE(packet2.has_frame_timeline_event()); |
| 1043 | |
| 1044 | const auto& event2 = packet2.frame_timeline_event(); |
| 1045 | ASSERT_TRUE(event2.has_actual_display_frame_start()); |
| 1046 | const auto& actualDisplayFrameStart = event2.actual_display_frame_start(); |
| 1047 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1048 | |
| 1049 | // Packet - 3 : FrameEnd (ActualDisplayFrame) |
| 1050 | const auto& packet3 = packets[3]; |
| 1051 | ASSERT_TRUE(packet3.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1052 | EXPECT_EQ(packet3.timestamp(), 31u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1053 | ASSERT_TRUE(packet3.has_frame_timeline_event()); |
| 1054 | |
| 1055 | const auto& event3 = packet3.frame_timeline_event(); |
| 1056 | ASSERT_TRUE(event3.has_frame_end()); |
| 1057 | const auto& actualDisplayFrameEnd = event3.frame_end(); |
| 1058 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1059 | } |
| 1060 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1061 | TEST_F(FrameTimelineTest, traceDisplayFrame_predictionExpiredDoesNotTraceExpectedTimeline) { |
| 1062 | auto tracingSession = getTracingSessionForTest(); |
| 1063 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1064 | |
| 1065 | tracingSession->StartBlocking(); |
| 1066 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 25, 30}); |
| 1067 | // Flush the token so that it would expire |
| 1068 | flushTokens(systemTime() + maxTokenRetentionTime); |
| 1069 | |
| 1070 | // Set up the display frame |
| 1071 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, Fps::fromPeriodNsecs(11)); |
| 1072 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1073 | presentFence1->signalForTest(31); |
| 1074 | |
| 1075 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1076 | |
| 1077 | auto protoActualDisplayFrameStart = |
| 1078 | createProtoActualDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1079 | kSurfaceFlingerPid, |
| 1080 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1081 | false, FrameTimelineEvent::JANK_UNKNOWN, |
| 1082 | FrameTimelineEvent::PREDICTION_EXPIRED); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1083 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1084 | |
| 1085 | addEmptyDisplayFrame(); |
| 1086 | flushTrace(); |
| 1087 | tracingSession->StopBlocking(); |
| 1088 | |
| 1089 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1090 | // Only actual timeline packets should be in the trace |
| 1091 | EXPECT_EQ(packets.size(), 2u); |
| 1092 | |
| 1093 | // Packet - 0 : ActualDisplayFrameStart |
| 1094 | const auto& packet0 = packets[0]; |
| 1095 | ASSERT_TRUE(packet0.has_timestamp()); |
| 1096 | EXPECT_EQ(packet0.timestamp(), 20u); |
| 1097 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
| 1098 | |
| 1099 | const auto& event0 = packet0.frame_timeline_event(); |
| 1100 | ASSERT_TRUE(event0.has_actual_display_frame_start()); |
| 1101 | const auto& actualDisplayFrameStart = event0.actual_display_frame_start(); |
| 1102 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1103 | |
| 1104 | // Packet - 1 : FrameEnd (ActualDisplayFrame) |
| 1105 | const auto& packet1 = packets[1]; |
| 1106 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1107 | EXPECT_EQ(packet1.timestamp(), 31u); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1108 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1109 | |
| 1110 | const auto& event1 = packet1.frame_timeline_event(); |
| 1111 | ASSERT_TRUE(event1.has_frame_end()); |
| 1112 | const auto& actualDisplayFrameEnd = event1.frame_end(); |
| 1113 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
| 1114 | } |
| 1115 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1116 | TEST_F(FrameTimelineTest, traceSurfaceFrame_emitsValidTracePacket) { |
| 1117 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1118 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1119 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1120 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1121 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1122 | |
| 1123 | tracingSession->StartBlocking(); |
| 1124 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 25, 40}); |
| 1125 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({30, 35, 40}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1126 | |
| 1127 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1128 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1129 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1130 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1131 | auto surfaceFrame2 = |
| 1132 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1133 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1134 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1135 | surfaceFrame1->setActualQueueTime(10); |
| 1136 | surfaceFrame1->setDropTime(15); |
| 1137 | |
| 1138 | surfaceFrame2->setActualQueueTime(15); |
| 1139 | surfaceFrame2->setAcquireFenceTime(20); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1140 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1141 | // First 2 cookies will be used by the DisplayFrame |
| 1142 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1143 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1144 | auto protoDroppedSurfaceFrameExpectedStart = |
| 1145 | createProtoExpectedSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1146 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1147 | auto protoDroppedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 1); |
| 1148 | auto protoDroppedSurfaceFrameActualStart = |
| 1149 | createProtoActualSurfaceFrameStart(traceCookie + 2, surfaceFrameToken, |
| 1150 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1151 | FrameTimelineEvent::PRESENT_DROPPED, false, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1152 | FrameTimelineEvent::JANK_NONE, |
| 1153 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1154 | auto protoDroppedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1155 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1156 | auto protoPresentedSurfaceFrameExpectedStart = |
| 1157 | createProtoExpectedSurfaceFrameStart(traceCookie + 3, surfaceFrameToken, |
| 1158 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1159 | auto protoPresentedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 3); |
| 1160 | auto protoPresentedSurfaceFrameActualStart = |
| 1161 | createProtoActualSurfaceFrameStart(traceCookie + 4, surfaceFrameToken, |
| 1162 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1163 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1164 | FrameTimelineEvent::JANK_NONE, |
| 1165 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1166 | auto protoPresentedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 4); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1167 | |
| 1168 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1169 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1170 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1171 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1172 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1173 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1174 | mFrameTimeline->setSfPresent(26, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1175 | presentFence1->signalForTest(40); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1176 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1177 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1178 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1179 | tracingSession->StopBlocking(); |
| 1180 | |
| 1181 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1182 | // 4 DisplayFrame + 4 DroppedSurfaceFrame + 4 PresentedSurfaceFrame |
| 1183 | EXPECT_EQ(packets.size(), 12u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1184 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1185 | // Packet - 4 : ExpectedSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1186 | const auto& packet4 = packets[4]; |
| 1187 | ASSERT_TRUE(packet4.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1188 | EXPECT_EQ(packet4.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1189 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1190 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1191 | const auto& event4 = packet4.frame_timeline_event(); |
| 1192 | ASSERT_TRUE(event4.has_expected_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1193 | const auto& expectedSurfaceFrameStart1 = event4.expected_surface_frame_start(); |
| 1194 | validateTraceEvent(expectedSurfaceFrameStart1, protoDroppedSurfaceFrameExpectedStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1195 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1196 | // Packet - 5 : FrameEnd (ExpectedSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1197 | const auto& packet5 = packets[5]; |
| 1198 | ASSERT_TRUE(packet5.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1199 | EXPECT_EQ(packet5.timestamp(), 25u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1200 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1201 | |
| 1202 | const auto& event5 = packet5.frame_timeline_event(); |
| 1203 | ASSERT_TRUE(event5.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1204 | const auto& expectedSurfaceFrameEnd1 = event5.frame_end(); |
| 1205 | validateTraceEvent(expectedSurfaceFrameEnd1, protoDroppedSurfaceFrameExpectedEnd); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1206 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1207 | // Packet - 6 : ActualSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1208 | const auto& packet6 = packets[6]; |
| 1209 | ASSERT_TRUE(packet6.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1210 | EXPECT_EQ(packet6.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1211 | ASSERT_TRUE(packet6.has_frame_timeline_event()); |
| 1212 | |
| 1213 | const auto& event6 = packet6.frame_timeline_event(); |
| 1214 | ASSERT_TRUE(event6.has_actual_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1215 | const auto& actualSurfaceFrameStart1 = event6.actual_surface_frame_start(); |
| 1216 | validateTraceEvent(actualSurfaceFrameStart1, protoDroppedSurfaceFrameActualStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1217 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1218 | // Packet - 7 : FrameEnd (ActualSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1219 | const auto& packet7 = packets[7]; |
| 1220 | ASSERT_TRUE(packet7.has_timestamp()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1221 | EXPECT_EQ(packet7.timestamp(), 15u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1222 | ASSERT_TRUE(packet7.has_frame_timeline_event()); |
| 1223 | |
| 1224 | const auto& event7 = packet7.frame_timeline_event(); |
| 1225 | ASSERT_TRUE(event7.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1226 | const auto& actualSurfaceFrameEnd1 = event7.frame_end(); |
| 1227 | validateTraceEvent(actualSurfaceFrameEnd1, protoDroppedSurfaceFrameActualEnd); |
| 1228 | |
| 1229 | // Packet - 8 : ExpectedSurfaceFrameStart2 |
| 1230 | const auto& packet8 = packets[8]; |
| 1231 | ASSERT_TRUE(packet8.has_timestamp()); |
| 1232 | EXPECT_EQ(packet8.timestamp(), 10u); |
| 1233 | ASSERT_TRUE(packet8.has_frame_timeline_event()); |
| 1234 | |
| 1235 | const auto& event8 = packet8.frame_timeline_event(); |
| 1236 | ASSERT_TRUE(event8.has_expected_surface_frame_start()); |
| 1237 | const auto& expectedSurfaceFrameStart2 = event8.expected_surface_frame_start(); |
| 1238 | validateTraceEvent(expectedSurfaceFrameStart2, protoPresentedSurfaceFrameExpectedStart); |
| 1239 | |
| 1240 | // Packet - 9 : FrameEnd (ExpectedSurfaceFrame2) |
| 1241 | const auto& packet9 = packets[9]; |
| 1242 | ASSERT_TRUE(packet9.has_timestamp()); |
| 1243 | EXPECT_EQ(packet9.timestamp(), 25u); |
| 1244 | ASSERT_TRUE(packet9.has_frame_timeline_event()); |
| 1245 | |
| 1246 | const auto& event9 = packet9.frame_timeline_event(); |
| 1247 | ASSERT_TRUE(event9.has_frame_end()); |
| 1248 | const auto& expectedSurfaceFrameEnd2 = event9.frame_end(); |
| 1249 | validateTraceEvent(expectedSurfaceFrameEnd2, protoPresentedSurfaceFrameExpectedEnd); |
| 1250 | |
| 1251 | // Packet - 10 : ActualSurfaceFrameStart2 |
| 1252 | const auto& packet10 = packets[10]; |
| 1253 | ASSERT_TRUE(packet10.has_timestamp()); |
| 1254 | EXPECT_EQ(packet10.timestamp(), 10u); |
| 1255 | ASSERT_TRUE(packet10.has_frame_timeline_event()); |
| 1256 | |
| 1257 | const auto& event10 = packet10.frame_timeline_event(); |
| 1258 | ASSERT_TRUE(event10.has_actual_surface_frame_start()); |
| 1259 | const auto& actualSurfaceFrameStart2 = event10.actual_surface_frame_start(); |
| 1260 | validateTraceEvent(actualSurfaceFrameStart2, protoPresentedSurfaceFrameActualStart); |
| 1261 | |
| 1262 | // Packet - 11 : FrameEnd (ActualSurfaceFrame2) |
| 1263 | const auto& packet11 = packets[11]; |
| 1264 | ASSERT_TRUE(packet11.has_timestamp()); |
| 1265 | EXPECT_EQ(packet11.timestamp(), 20u); |
| 1266 | ASSERT_TRUE(packet11.has_frame_timeline_event()); |
| 1267 | |
| 1268 | const auto& event11 = packet11.frame_timeline_event(); |
| 1269 | ASSERT_TRUE(event11.has_frame_end()); |
| 1270 | const auto& actualSurfaceFrameEnd2 = event11.frame_end(); |
| 1271 | validateTraceEvent(actualSurfaceFrameEnd2, protoPresentedSurfaceFrameActualEnd); |
| 1272 | } |
| 1273 | |
| 1274 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredDoesNotTraceExpectedTimeline) { |
| 1275 | auto tracingSession = getTracingSessionForTest(); |
| 1276 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1277 | |
| 1278 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1279 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1280 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1281 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1282 | int64_t surfaceFrameToken = |
| 1283 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1284 | |
| 1285 | // Flush the token so that it would expire |
| 1286 | flushTokens(systemTime() + maxTokenRetentionTime); |
| 1287 | auto surfaceFrame1 = |
| 1288 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, /*inputEventId*/ 0}, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1289 | sPidOne, sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1290 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1291 | surfaceFrame1->setActualQueueTime(appEndTime); |
| 1292 | surfaceFrame1->setAcquireFenceTime(appEndTime); |
| 1293 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1294 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(20ms).count(); |
| 1295 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1296 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1297 | int64_t displayFrameToken = |
| 1298 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1299 | |
| 1300 | // First 2 cookies will be used by the DisplayFrame |
| 1301 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1302 | |
| 1303 | auto protoActualSurfaceFrameStart = |
| 1304 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1305 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1306 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1307 | false, FrameTimelineEvent::JANK_UNKNOWN, |
| 1308 | FrameTimelineEvent::PREDICTION_EXPIRED); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1309 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1310 | |
| 1311 | // Set up the display frame |
| 1312 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, Fps::fromPeriodNsecs(11)); |
| 1313 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1314 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1315 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1316 | presentFence1->signalForTest(sfPresentTime); |
| 1317 | |
| 1318 | addEmptyDisplayFrame(); |
| 1319 | flushTrace(); |
| 1320 | tracingSession->StopBlocking(); |
| 1321 | |
| 1322 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1323 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1324 | ASSERT_EQ(packets.size(), 6u); |
| 1325 | |
| 1326 | // Packet - 4 : ActualSurfaceFrameStart |
| 1327 | const auto& packet4 = packets[4]; |
| 1328 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1329 | EXPECT_EQ(packet4.timestamp(), |
| 1330 | static_cast<uint64_t>(appEndTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1331 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1332 | |
| 1333 | const auto& event4 = packet4.frame_timeline_event(); |
| 1334 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1335 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1336 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1337 | |
| 1338 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1339 | const auto& packet5 = packets[5]; |
| 1340 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1341 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(appEndTime)); |
| 1342 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1343 | |
| 1344 | const auto& event5 = packet5.frame_timeline_event(); |
| 1345 | ASSERT_TRUE(event5.has_frame_end()); |
| 1346 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1347 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1348 | } |
| 1349 | |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1350 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredDroppedFramesTracedProperly) { |
| 1351 | auto tracingSession = getTracingSessionForTest(); |
| 1352 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1353 | |
| 1354 | tracingSession->StartBlocking(); |
| 1355 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1356 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1357 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1358 | int64_t surfaceFrameToken = |
| 1359 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1360 | |
| 1361 | // Flush the token so that it would expire |
| 1362 | flushTokens(systemTime() + maxTokenRetentionTime); |
| 1363 | auto surfaceFrame1 = |
| 1364 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, /*inputEventId*/ 0}, |
| 1365 | sPidOne, sUidOne, sLayerIdOne, sLayerNameOne, |
| 1366 | sLayerNameOne, /*isBuffer*/ true); |
| 1367 | |
| 1368 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(22ms).count(); |
| 1369 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1370 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1371 | int64_t displayFrameToken = |
| 1372 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1373 | |
| 1374 | // First 2 cookies will be used by the DisplayFrame |
| 1375 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1376 | |
| 1377 | auto protoActualSurfaceFrameStart = |
| 1378 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1379 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1380 | FrameTimelineEvent::PRESENT_DROPPED, false, false, |
| 1381 | FrameTimelineEvent::JANK_NONE, |
| 1382 | FrameTimelineEvent::PREDICTION_EXPIRED); |
| 1383 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1384 | |
| 1385 | // Set up the display frame |
| 1386 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, Fps::fromPeriodNsecs(11)); |
| 1387 | surfaceFrame1->setDropTime(sfStartTime); |
| 1388 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1389 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1390 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1391 | presentFence1->signalForTest(sfPresentTime); |
| 1392 | |
| 1393 | addEmptyDisplayFrame(); |
| 1394 | flushTrace(); |
| 1395 | tracingSession->StopBlocking(); |
| 1396 | |
| 1397 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1398 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1399 | ASSERT_EQ(packets.size(), 6u); |
| 1400 | |
| 1401 | // Packet - 4 : ActualSurfaceFrameStart |
| 1402 | const auto& packet4 = packets[4]; |
| 1403 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1404 | EXPECT_EQ(packet4.timestamp(), |
| 1405 | static_cast<uint64_t>(sfStartTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1406 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1407 | |
| 1408 | const auto& event4 = packet4.frame_timeline_event(); |
| 1409 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1410 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1411 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1412 | |
| 1413 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1414 | const auto& packet5 = packets[5]; |
| 1415 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1416 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(sfStartTime)); |
| 1417 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1418 | |
| 1419 | const auto& event5 = packet5.frame_timeline_event(); |
| 1420 | ASSERT_TRUE(event5.has_frame_end()); |
| 1421 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
| 1422 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
| 1423 | } |
| 1424 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1425 | // Tests for Jank classification |
| 1426 | TEST_F(FrameTimelineTest, jankClassification_presentOnTimeDoesNotClassify) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1427 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1428 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1429 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1430 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1431 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 30}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1432 | auto surfaceFrame = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1433 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1434 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1435 | sLayerNameOne, /*isBuffer*/ true); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1436 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1437 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1438 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 1439 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1440 | auto displayFrame = getDisplayFrame(0); |
| 1441 | auto& presentedSurfaceFrame = getSurfaceFrame(0, 0); |
| 1442 | presentFence1->signalForTest(29); |
| 1443 | |
| 1444 | // Fences haven't been flushed yet, so it should be 0 |
| 1445 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1446 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 0); |
| 1447 | |
| 1448 | addEmptyDisplayFrame(); |
| 1449 | displayFrame = getDisplayFrame(0); |
| 1450 | |
| 1451 | // Fences have flushed, so the present timestamps should be updated |
| 1452 | EXPECT_EQ(displayFrame->getActuals().presentTime, 29); |
| 1453 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 29); |
| 1454 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1455 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1456 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
| 1457 | } |
| 1458 | |
| 1459 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1460 | Fps vsyncRate = Fps::fromPeriodNsecs(11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1461 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1462 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1463 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1464 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1465 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1466 | auto displayFrame = getDisplayFrame(0); |
| 1467 | presentFence1->signalForTest(30); |
| 1468 | |
| 1469 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1470 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1471 | |
| 1472 | // Trigger a flush by finalizing the next DisplayFrame |
| 1473 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1474 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1475 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1476 | displayFrame = getDisplayFrame(0); |
| 1477 | |
| 1478 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1479 | EXPECT_EQ(displayFrame->getActuals().presentTime, 30); |
| 1480 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1481 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1482 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1483 | |
| 1484 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1485 | auto displayFrame2 = getDisplayFrame(1); |
| 1486 | presentFence2->signalForTest(65); |
| 1487 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1488 | addEmptyDisplayFrame(); |
| 1489 | displayFrame2 = getDisplayFrame(1); |
| 1490 | |
| 1491 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1492 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1493 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1494 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1495 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1496 | } |
| 1497 | |
| 1498 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1499 | Fps vsyncRate = Fps::fromPeriodNsecs(11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1500 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1501 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1502 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1503 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1504 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1505 | auto displayFrame = getDisplayFrame(0); |
| 1506 | presentFence1->signalForTest(50); |
| 1507 | |
| 1508 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1509 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1510 | |
| 1511 | // Trigger a flush by finalizing the next DisplayFrame |
| 1512 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1513 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1514 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1515 | displayFrame = getDisplayFrame(0); |
| 1516 | |
| 1517 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1518 | EXPECT_EQ(displayFrame->getActuals().presentTime, 50); |
| 1519 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1520 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1521 | EXPECT_EQ(displayFrame->getJankType(), JankType::DisplayHAL); |
| 1522 | |
| 1523 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1524 | auto displayFrame2 = getDisplayFrame(1); |
| 1525 | presentFence2->signalForTest(75); |
| 1526 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1527 | |
| 1528 | addEmptyDisplayFrame(); |
| 1529 | displayFrame2 = getDisplayFrame(1); |
| 1530 | |
| 1531 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1532 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 75); |
| 1533 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1534 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1535 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1536 | } |
| 1537 | |
| 1538 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishEarlyPresent) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1539 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1540 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({12, 18, 40}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1541 | mFrameTimeline->setSfWakeUp(sfToken1, 12, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1542 | |
| 1543 | mFrameTimeline->setSfPresent(22, presentFence1); |
| 1544 | auto displayFrame = getDisplayFrame(0); |
| 1545 | presentFence1->signalForTest(28); |
| 1546 | |
| 1547 | // Fences haven't been flushed yet, so it should be 0 |
| 1548 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1549 | |
| 1550 | addEmptyDisplayFrame(); |
| 1551 | displayFrame = getDisplayFrame(0); |
| 1552 | |
| 1553 | // Fences have flushed, so the present timestamps should be updated |
| 1554 | EXPECT_EQ(displayFrame->getActuals().presentTime, 28); |
| 1555 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1556 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1557 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1558 | } |
| 1559 | |
| 1560 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent) { |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1561 | /* |
| 1562 | * Case 1 - cpu time > vsync period but combined time > deadline > deadline -> cpudeadlinemissed |
| 1563 | * Case 2 - cpu time < vsync period but combined time > deadline -> gpudeadlinemissed |
| 1564 | */ |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1565 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1566 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1567 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1568 | auto gpuFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1569 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1570 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 1571 | // case 1 - cpu time = 33 - 12 = 21, vsync period = 11 |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1572 | mFrameTimeline->setSfWakeUp(sfToken1, 12, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1573 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 1574 | auto displayFrame0 = getDisplayFrame(0); |
| 1575 | gpuFence1->signalForTest(36); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1576 | presentFence1->signalForTest(52); |
| 1577 | |
| 1578 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1579 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 0); |
| 1580 | |
| 1581 | // case 2 - cpu time = 56 - 52 = 4, vsync period = 11 |
| 1582 | mFrameTimeline->setSfWakeUp(sfToken2, 52, Fps::fromPeriodNsecs(11)); |
| 1583 | mFrameTimeline->setSfPresent(56, presentFence2, gpuFence2); |
| 1584 | auto displayFrame1 = getDisplayFrame(1); |
| 1585 | gpuFence2->signalForTest(66); |
| 1586 | presentFence2->signalForTest(71); |
| 1587 | |
| 1588 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1589 | // Fences have flushed for first displayFrame, so the present timestamps should be updated |
| 1590 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 52); |
| 1591 | EXPECT_EQ(displayFrame0->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1592 | EXPECT_EQ(displayFrame0->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1593 | EXPECT_EQ(displayFrame0->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1594 | |
| 1595 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1596 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1597 | // Fences have flushed for second displayFrame, so the present timestamps should be updated |
| 1598 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 71); |
| 1599 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1600 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1601 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1602 | } |
| 1603 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1604 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateStartLateFinishLatePresent) { |
| 1605 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1606 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 1607 | mFrameTimeline->setSfWakeUp(sfToken1, 26, Fps::fromPeriodNsecs(11)); |
| 1608 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 1609 | auto displayFrame = getDisplayFrame(0); |
| 1610 | presentFence1->signalForTest(52); |
| 1611 | |
| 1612 | // Fences haven't been flushed yet, so it should be 0 |
| 1613 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1614 | |
| 1615 | addEmptyDisplayFrame(); |
| 1616 | displayFrame = getDisplayFrame(0); |
| 1617 | |
| 1618 | // Fences have flushed, so the present timestamps should be updated |
| 1619 | EXPECT_EQ(displayFrame->getActuals().presentTime, 52); |
| 1620 | EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::LateStart); |
| 1621 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1622 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1623 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1624 | } |
| 1625 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1626 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1627 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1628 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1629 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1630 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1631 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1632 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1633 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1634 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1635 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1636 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1637 | surfaceFrame1->setAcquireFenceTime(16); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1638 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1639 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1640 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1641 | mFrameTimeline->setSfPresent(27, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1642 | auto displayFrame1 = getDisplayFrame(0); |
| 1643 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1644 | presentFence1->signalForTest(30); |
| 1645 | |
| 1646 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1647 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1648 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1649 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1650 | |
| 1651 | // Trigger a flush by finalizing the next DisplayFrame |
| 1652 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1653 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1654 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1655 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1656 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1657 | surfaceFrame2->setAcquireFenceTime(36); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1658 | mFrameTimeline->setSfWakeUp(sfToken2, 52, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1659 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1660 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1661 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1662 | auto displayFrame2 = getDisplayFrame(1); |
| 1663 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1664 | |
| 1665 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1666 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 30); |
| 1667 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1668 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1669 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1670 | |
| 1671 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1672 | EXPECT_EQ(actuals1.presentTime, 30); |
| 1673 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1674 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1675 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::SurfaceFlingerScheduling); |
| 1676 | |
| 1677 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1678 | presentFence2->signalForTest(65); |
| 1679 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1680 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1681 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1682 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1683 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 1684 | |
| 1685 | EXPECT_CALL(*mTimeStats, |
| 1686 | incrementJankyFrames( |
| 1687 | TimeStats::JankyFramesInfo{Fps::fromPeriodNsecs(11), std::nullopt, sUidOne, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 1688 | sLayerNameOne, JankType::PredictionError, -3, 5, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1689 | 0})); |
| 1690 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1691 | addEmptyDisplayFrame(); |
| 1692 | |
| 1693 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1694 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1695 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1696 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1697 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1698 | |
| 1699 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1700 | EXPECT_EQ(actuals2.presentTime, 65); |
| 1701 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1702 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1703 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
| 1704 | } |
| 1705 | |
| 1706 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1707 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1708 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1709 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1710 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1711 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1712 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1713 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1714 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1715 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1716 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1717 | surfaceFrame1->setAcquireFenceTime(16); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1718 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1719 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1720 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1721 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1722 | auto displayFrame1 = getDisplayFrame(0); |
| 1723 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1724 | presentFence1->signalForTest(50); |
| 1725 | |
| 1726 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1727 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1728 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1729 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1730 | |
| 1731 | // Trigger a flush by finalizing the next DisplayFrame |
| 1732 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1733 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1734 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1735 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1736 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1737 | surfaceFrame2->setAcquireFenceTime(36); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1738 | mFrameTimeline->setSfWakeUp(sfToken2, 52, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1739 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1740 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1741 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1742 | auto displayFrame2 = getDisplayFrame(1); |
| 1743 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1744 | |
| 1745 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1746 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 1747 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1748 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1749 | EXPECT_EQ(displayFrame1->getJankType(), JankType::DisplayHAL); |
| 1750 | |
| 1751 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1752 | EXPECT_EQ(actuals1.presentTime, 50); |
| 1753 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1754 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1755 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::DisplayHAL); |
| 1756 | |
| 1757 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1758 | presentFence2->signalForTest(86); |
| 1759 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1760 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1761 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1762 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1763 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 1764 | |
| 1765 | EXPECT_CALL(*mTimeStats, |
| 1766 | incrementJankyFrames( |
| 1767 | TimeStats::JankyFramesInfo{Fps::fromPeriodNsecs(11), std::nullopt, sUidOne, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 1768 | sLayerNameOne, JankType::PredictionError, -3, 5, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1769 | 0})); |
| 1770 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1771 | addEmptyDisplayFrame(); |
| 1772 | |
| 1773 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1774 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 86); |
| 1775 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1776 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1777 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1778 | |
| 1779 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1780 | EXPECT_EQ(actuals2.presentTime, 86); |
| 1781 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1782 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1783 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
| 1784 | } |
| 1785 | |
| 1786 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1787 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1788 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1789 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1790 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1791 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 26, 60}); |
| 1792 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1793 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1794 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1795 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1796 | surfaceFrame1->setAcquireFenceTime(40); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1797 | mFrameTimeline->setSfWakeUp(sfToken1, 42, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1798 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1799 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1800 | mFrameTimeline->setSfPresent(46, presentFence1); |
| 1801 | auto displayFrame1 = getDisplayFrame(0); |
| 1802 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1803 | presentFence1->signalForTest(50); |
| 1804 | |
| 1805 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1806 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1807 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1808 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1809 | |
| 1810 | addEmptyDisplayFrame(); |
| 1811 | |
| 1812 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1813 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 1814 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1815 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1816 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1817 | |
| 1818 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1819 | EXPECT_EQ(actuals1.presentTime, 50); |
| 1820 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1821 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1822 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::Unknown); |
| 1823 | } |
| 1824 | |
| 1825 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishLatePresent) { |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 1826 | // First frame - DisplayFrame is not janky. This should classify the SurfaceFrame as only |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1827 | // AppDeadlineMissed. Second frame - DisplayFrame is janky. This should propagate DisplayFrame's |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 1828 | // jank to the SurfaceFrame along with AppDeadlineMissed. |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1829 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1830 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1831 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1832 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({32, 40, 40}); |
| 1833 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1834 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 1835 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 50}); |
| 1836 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1837 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1838 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1839 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1840 | surfaceFrame1->setAcquireFenceTime(26); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1841 | mFrameTimeline->setSfWakeUp(sfToken1, 32, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1842 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1843 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1844 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 1845 | auto displayFrame1 = getDisplayFrame(0); |
| 1846 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1847 | presentFence1->signalForTest(40); |
| 1848 | |
| 1849 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1850 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1851 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1852 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1853 | |
| 1854 | // Trigger a flush by finalizing the next DisplayFrame |
| 1855 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1856 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1857 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1858 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1859 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1860 | surfaceFrame2->setAcquireFenceTime(40); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1861 | mFrameTimeline->setSfWakeUp(sfToken2, 43, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1862 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1863 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1864 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1865 | auto displayFrame2 = getDisplayFrame(1); |
| 1866 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1867 | |
| 1868 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1869 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 40); |
| 1870 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1871 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1872 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1873 | |
| 1874 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1875 | EXPECT_EQ(actuals1.presentTime, 40); |
| 1876 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1877 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1878 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 1879 | |
| 1880 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1881 | presentFence2->signalForTest(60); |
| 1882 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1883 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1884 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1885 | |
| 1886 | addEmptyDisplayFrame(); |
| 1887 | |
| 1888 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1889 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 60); |
| 1890 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1891 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1892 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
| 1893 | |
| 1894 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1895 | EXPECT_EQ(actuals2.presentTime, 60); |
| 1896 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1897 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 1898 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 1899 | JankType::SurfaceFlingerCpuDeadlineMissed | JankType::AppDeadlineMissed); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1900 | } |
| 1901 | |
| 1902 | TEST_F(FrameTimelineTest, jankClassification_multiJankBufferStuffingAndAppDeadlineMissed) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1903 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1904 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1905 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1906 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 1907 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 1908 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1909 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 1910 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1911 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1912 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1913 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1914 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1915 | surfaceFrame1->setAcquireFenceTime(50); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1916 | mFrameTimeline->setSfWakeUp(sfToken1, 52, Fps::fromPeriodNsecs(30)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1917 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1918 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1919 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 1920 | auto displayFrame1 = getDisplayFrame(0); |
| 1921 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1922 | presentFence1->signalForTest(60); |
| 1923 | |
| 1924 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1925 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1926 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1927 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1928 | |
| 1929 | // Trigger a flush by finalizing the next DisplayFrame |
| 1930 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1931 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1932 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1933 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1934 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1935 | surfaceFrame2->setAcquireFenceTime(84); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1936 | mFrameTimeline->setSfWakeUp(sfToken2, 112, Fps::fromPeriodNsecs(30)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1937 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 1938 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1939 | mFrameTimeline->setSfPresent(116, presentFence2); |
| 1940 | auto displayFrame2 = getDisplayFrame(1); |
| 1941 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1942 | presentFence2->signalForTest(120); |
| 1943 | |
| 1944 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1945 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 1946 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1947 | EXPECT_EQ(actuals1.endTime, 50); |
| 1948 | EXPECT_EQ(actuals1.presentTime, 60); |
| 1949 | |
| 1950 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1951 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1952 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1953 | |
| 1954 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1955 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1956 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 1957 | |
| 1958 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1959 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1960 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1961 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1962 | |
| 1963 | addEmptyDisplayFrame(); |
| 1964 | |
| 1965 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1966 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 1967 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1968 | EXPECT_EQ(actuals2.presentTime, 120); |
| 1969 | |
| 1970 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1971 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1972 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
| 1973 | |
| 1974 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1975 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1976 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 1977 | JankType::AppDeadlineMissed | JankType::BufferStuffing); |
| 1978 | } |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1979 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1980 | TEST_F(FrameTimelineTest, jankClassification_appDeadlineAdjustedForBufferStuffing) { |
| 1981 | // Layer specific increment |
| 1982 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
| 1983 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1984 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 1985 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 1986 | |
| 1987 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 1988 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 1989 | auto surfaceFrame1 = |
| 1990 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 1991 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1992 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1993 | surfaceFrame1->setAcquireFenceTime(50); |
| 1994 | mFrameTimeline->setSfWakeUp(sfToken1, 52, Fps::fromPeriodNsecs(30)); |
| 1995 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1996 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1997 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 1998 | auto displayFrame1 = getDisplayFrame(0); |
| 1999 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2000 | presentFence1->signalForTest(60); |
| 2001 | |
| 2002 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2003 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2004 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2005 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2006 | |
| 2007 | // Trigger a flush by finalizing the next DisplayFrame |
| 2008 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2009 | auto surfaceFrame2 = |
| 2010 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
| 2011 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2012 | sLayerNameOne, /*isBuffer*/ true); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2013 | surfaceFrame2->setAcquireFenceTime(80); |
| 2014 | mFrameTimeline->setSfWakeUp(sfToken2, 82, Fps::fromPeriodNsecs(30)); |
| 2015 | // Setting previous latch time to 54, adjusted deadline will be 54 + vsyncTime(30) = 84 |
| 2016 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2017 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2018 | mFrameTimeline->setSfPresent(86, presentFence2); |
| 2019 | auto displayFrame2 = getDisplayFrame(1); |
| 2020 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2021 | presentFence2->signalForTest(90); |
| 2022 | |
| 2023 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2024 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2025 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2026 | EXPECT_EQ(actuals1.endTime, 50); |
| 2027 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2028 | |
| 2029 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2030 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2031 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 2032 | |
| 2033 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2034 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2035 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 2036 | |
| 2037 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2038 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2039 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2040 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2041 | |
| 2042 | addEmptyDisplayFrame(); |
| 2043 | |
| 2044 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2045 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2046 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2047 | EXPECT_EQ(actuals2.presentTime, 90); |
| 2048 | |
| 2049 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2050 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2051 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
| 2052 | |
| 2053 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2054 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2055 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::BufferStuffing); |
| 2056 | } |
| 2057 | |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2058 | TEST_F(FrameTimelineTest, computeFps_noLayerIds_returnsZero) { |
| 2059 | EXPECT_EQ(mFrameTimeline->computeFps({}), 0.0f); |
| 2060 | } |
| 2061 | |
| 2062 | TEST_F(FrameTimelineTest, computeFps_singleDisplayFrame_returnsZero) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2063 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2064 | |
| 2065 | auto surfaceFrame1 = |
| 2066 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2067 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2068 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2069 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2070 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2071 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2072 | presentFence1->signalForTest(oneHundredMs); |
| 2073 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2074 | |
| 2075 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2076 | } |
| 2077 | |
| 2078 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_oneLayer) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2079 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2080 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2081 | auto surfaceFrame1 = |
| 2082 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2083 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2084 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2085 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2086 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2087 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2088 | presentFence1->signalForTest(oneHundredMs); |
| 2089 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2090 | |
| 2091 | auto surfaceFrame2 = |
| 2092 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2093 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2094 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2095 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2096 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2097 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2098 | presentFence2->signalForTest(twoHundredMs); |
| 2099 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2100 | |
| 2101 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 10.0); |
| 2102 | } |
| 2103 | |
| 2104 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_twoLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2105 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2106 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2107 | auto surfaceFrame1 = |
| 2108 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2109 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2110 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2111 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2112 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2113 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2114 | presentFence1->signalForTest(oneHundredMs); |
| 2115 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2116 | |
| 2117 | auto surfaceFrame2 = |
| 2118 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2119 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
| 2120 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2121 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2122 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2123 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2124 | presentFence2->signalForTest(twoHundredMs); |
| 2125 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2126 | |
| 2127 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne, sLayerIdTwo}), 10.0f); |
| 2128 | } |
| 2129 | |
| 2130 | TEST_F(FrameTimelineTest, computeFps_filtersOutLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2131 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2132 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2133 | auto surfaceFrame1 = |
| 2134 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2135 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2136 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2137 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2138 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2139 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2140 | presentFence1->signalForTest(oneHundredMs); |
| 2141 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2142 | |
| 2143 | auto surfaceFrame2 = |
| 2144 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2145 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
| 2146 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2147 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2148 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2149 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2150 | presentFence2->signalForTest(twoHundredMs); |
| 2151 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2152 | |
| 2153 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2154 | } |
| 2155 | |
| 2156 | TEST_F(FrameTimelineTest, computeFps_averagesOverMultipleFrames) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2157 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2158 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
| 2159 | const auto threeHundredMs = std::chrono::nanoseconds(300ms).count(); |
| 2160 | const auto fiveHundredMs = std::chrono::nanoseconds(500ms).count(); |
| 2161 | const auto sixHundredMs = std::chrono::nanoseconds(600ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2162 | auto surfaceFrame1 = |
| 2163 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2164 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2165 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2166 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2167 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2168 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2169 | presentFence1->signalForTest(oneHundredMs); |
| 2170 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2171 | |
| 2172 | auto surfaceFrame2 = |
| 2173 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2174 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2175 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2176 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2177 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2178 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2179 | presentFence2->signalForTest(twoHundredMs); |
| 2180 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2181 | |
| 2182 | auto surfaceFrame3 = |
| 2183 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2184 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
| 2185 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2186 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2187 | surfaceFrame3->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2188 | mFrameTimeline->addSurfaceFrame(surfaceFrame3); |
| 2189 | presentFence3->signalForTest(threeHundredMs); |
| 2190 | mFrameTimeline->setSfPresent(threeHundredMs, presentFence3); |
| 2191 | |
| 2192 | auto surfaceFrame4 = |
| 2193 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2194 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2195 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2196 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2197 | surfaceFrame4->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2198 | mFrameTimeline->addSurfaceFrame(surfaceFrame4); |
| 2199 | presentFence4->signalForTest(fiveHundredMs); |
| 2200 | mFrameTimeline->setSfPresent(fiveHundredMs, presentFence4); |
| 2201 | |
| 2202 | auto surfaceFrame5 = |
| 2203 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2204 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
| 2205 | /*isBuffer*/ true); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2206 | auto presentFence5 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2207 | // Dropped frames will be excluded from fps computation |
| 2208 | surfaceFrame5->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 2209 | mFrameTimeline->addSurfaceFrame(surfaceFrame5); |
| 2210 | presentFence5->signalForTest(sixHundredMs); |
| 2211 | mFrameTimeline->setSfPresent(sixHundredMs, presentFence5); |
| 2212 | |
| 2213 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 5.0f); |
| 2214 | } |
| 2215 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 2216 | } // namespace android::frametimeline |