Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2020 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Marin Shalamanov | bed7fd3 | 2020-12-21 20:02:20 +0100 | [diff] [blame] | 17 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 18 | #include "gmock/gmock-spec-builders.h" |
| 19 | #include "mock/MockTimeStats.h" |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 20 | #undef LOG_TAG |
| 21 | #define LOG_TAG "LibSurfaceFlingerUnittests" |
| 22 | |
| 23 | #include <FrameTimeline/FrameTimeline.h> |
| 24 | #include <gtest/gtest.h> |
| 25 | #include <log/log.h> |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 26 | #include <perfetto/trace/trace.pb.h> |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 27 | #include <cinttypes> |
| 28 | |
| 29 | using namespace std::chrono_literals; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 30 | using testing::_; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 31 | using testing::AtLeast; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 32 | using testing::Contains; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 33 | using FrameTimelineEvent = perfetto::protos::FrameTimelineEvent; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 34 | using ProtoExpectedDisplayFrameStart = |
| 35 | perfetto::protos::FrameTimelineEvent_ExpectedDisplayFrameStart; |
| 36 | using ProtoExpectedSurfaceFrameStart = |
| 37 | perfetto::protos::FrameTimelineEvent_ExpectedSurfaceFrameStart; |
| 38 | using ProtoActualDisplayFrameStart = perfetto::protos::FrameTimelineEvent_ActualDisplayFrameStart; |
| 39 | using ProtoActualSurfaceFrameStart = perfetto::protos::FrameTimelineEvent_ActualSurfaceFrameStart; |
| 40 | using ProtoFrameEnd = perfetto::protos::FrameTimelineEvent_FrameEnd; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 41 | using ProtoPresentType = perfetto::protos::FrameTimelineEvent_PresentType; |
| 42 | using ProtoJankType = perfetto::protos::FrameTimelineEvent_JankType; |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 43 | using ProtoPredictionType = perfetto::protos::FrameTimelineEvent_PredictionType; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 44 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 45 | namespace android::frametimeline { |
| 46 | |
| 47 | class FrameTimelineTest : public testing::Test { |
| 48 | public: |
| 49 | FrameTimelineTest() { |
| 50 | const ::testing::TestInfo* const test_info = |
| 51 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 52 | ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 53 | } |
| 54 | |
| 55 | ~FrameTimelineTest() { |
| 56 | const ::testing::TestInfo* const test_info = |
| 57 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 58 | ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 59 | } |
| 60 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 61 | static void SetUpTestSuite() { |
| 62 | // Need to initialize tracing in process for testing, and only once per test suite. |
| 63 | perfetto::TracingInitArgs args; |
| 64 | args.backends = perfetto::kInProcessBackend; |
| 65 | perfetto::Tracing::Initialize(args); |
| 66 | } |
| 67 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 68 | void SetUp() override { |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 69 | constexpr bool kUseBootTimeClock = true; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 70 | mTimeStats = std::make_shared<mock::TimeStats>(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 71 | mFrameTimeline = std::make_unique<impl::FrameTimeline>(mTimeStats, kSurfaceFlingerPid, |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 72 | kTestThresholds, !kUseBootTimeClock); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 73 | mFrameTimeline->registerDataSource(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 74 | mTokenManager = &mFrameTimeline->mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 75 | mTraceCookieCounter = &mFrameTimeline->mTraceCookieCounter; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 76 | maxDisplayFrames = &mFrameTimeline->mMaxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 77 | maxTokens = mTokenManager->kMaxTokens; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 78 | } |
| 79 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 80 | // Each tracing session can be used for a single block of Start -> Stop. |
| 81 | static std::unique_ptr<perfetto::TracingSession> getTracingSessionForTest() { |
| 82 | perfetto::TraceConfig cfg; |
| 83 | cfg.set_duration_ms(500); |
| 84 | cfg.add_buffers()->set_size_kb(1024); |
| 85 | auto* ds_cfg = cfg.add_data_sources()->mutable_config(); |
| 86 | ds_cfg->set_name(impl::FrameTimeline::kFrameTimelineDataSource); |
| 87 | |
| 88 | auto tracingSession = perfetto::Tracing::NewTrace(perfetto::kInProcessBackend); |
| 89 | tracingSession->Setup(cfg); |
| 90 | return tracingSession; |
| 91 | } |
| 92 | |
| 93 | std::vector<perfetto::protos::TracePacket> readFrameTimelinePacketsBlocking( |
| 94 | perfetto::TracingSession* tracingSession) { |
| 95 | std::vector<char> raw_trace = tracingSession->ReadTraceBlocking(); |
| 96 | perfetto::protos::Trace trace; |
| 97 | EXPECT_TRUE(trace.ParseFromArray(raw_trace.data(), int(raw_trace.size()))); |
| 98 | |
| 99 | std::vector<perfetto::protos::TracePacket> packets; |
| 100 | for (const auto& packet : trace.packet()) { |
| 101 | if (!packet.has_frame_timeline_event()) { |
| 102 | continue; |
| 103 | } |
| 104 | packets.emplace_back(packet); |
| 105 | } |
| 106 | return packets; |
| 107 | } |
| 108 | |
| 109 | void addEmptyDisplayFrame() { |
| 110 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 111 | // Trigger a flushPresentFence by calling setSfPresent for the next frame |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 112 | mFrameTimeline->setSfPresent(2500, presentFence1); |
| 113 | } |
| 114 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 115 | void flushTokens() { |
| 116 | for (size_t i = 0; i < maxTokens; i++) { |
| 117 | mTokenManager->generateTokenForPredictions({}); |
| 118 | } |
| 119 | EXPECT_EQ(getPredictions().size(), maxTokens); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 120 | } |
| 121 | |
| 122 | SurfaceFrame& getSurfaceFrame(size_t displayFrameIdx, size_t surfaceFrameIdx) { |
| 123 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 124 | return *(mFrameTimeline->mDisplayFrames[displayFrameIdx] |
| 125 | ->getSurfaceFrames()[surfaceFrameIdx]); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 126 | } |
| 127 | |
| 128 | std::shared_ptr<impl::FrameTimeline::DisplayFrame> getDisplayFrame(size_t idx) { |
| 129 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 130 | return mFrameTimeline->mDisplayFrames[idx]; |
| 131 | } |
| 132 | |
| 133 | static bool compareTimelineItems(const TimelineItem& a, const TimelineItem& b) { |
| 134 | return a.startTime == b.startTime && a.endTime == b.endTime && |
| 135 | a.presentTime == b.presentTime; |
| 136 | } |
| 137 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 138 | const std::map<int64_t, TimelineItem>& getPredictions() const { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 139 | return mTokenManager->mPredictions; |
| 140 | } |
| 141 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 142 | uint32_t getNumberOfDisplayFrames() const { |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 143 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 144 | return static_cast<uint32_t>(mFrameTimeline->mDisplayFrames.size()); |
| 145 | } |
| 146 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 147 | int64_t snoopCurrentTraceCookie() const { return mTraceCookieCounter->mTraceCookie; } |
| 148 | |
| 149 | void flushTrace() { |
| 150 | using FrameTimelineDataSource = impl::FrameTimeline::FrameTimelineDataSource; |
| 151 | FrameTimelineDataSource::Trace( |
| 152 | [&](FrameTimelineDataSource::TraceContext ctx) { ctx.Flush(); }); |
| 153 | } |
| 154 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 155 | std::shared_ptr<mock::TimeStats> mTimeStats; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 156 | std::unique_ptr<impl::FrameTimeline> mFrameTimeline; |
| 157 | impl::TokenManager* mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 158 | TraceCookieCounter* mTraceCookieCounter; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 159 | FenceToFenceTimeMap fenceFactory; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 160 | uint32_t* maxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 161 | size_t maxTokens; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 162 | static constexpr pid_t kSurfaceFlingerPid = 666; |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 163 | static constexpr nsecs_t kPresentThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 54996e2 | 2021-06-25 22:26:45 +0000 | [diff] [blame] | 164 | static constexpr nsecs_t kDeadlineThreshold = std::chrono::nanoseconds(0ns).count(); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 165 | static constexpr nsecs_t kStartThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 166 | static constexpr JankClassificationThresholds kTestThresholds{kPresentThreshold, |
| 167 | kDeadlineThreshold, |
| 168 | kStartThreshold}; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 169 | }; |
| 170 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 171 | static const std::string sLayerNameOne = "layer1"; |
| 172 | static const std::string sLayerNameTwo = "layer2"; |
Dominik Laskowski | f5d0ea5 | 2021-09-26 17:27:01 -0700 | [diff] [blame] | 173 | |
| 174 | constexpr const uid_t sUidOne = 0; |
| 175 | constexpr pid_t sPidOne = 10; |
| 176 | constexpr pid_t sPidTwo = 20; |
| 177 | constexpr int32_t sInputEventId = 5; |
| 178 | constexpr int32_t sLayerIdOne = 1; |
| 179 | constexpr int32_t sLayerIdTwo = 2; |
| 180 | constexpr GameMode sGameMode = GameMode::Unsupported; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 181 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 182 | TEST_F(FrameTimelineTest, tokenManagerRemovesStalePredictions) { |
| 183 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 184 | EXPECT_EQ(getPredictions().size(), 1u); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 185 | flushTokens(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 186 | int64_t token2 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 187 | std::optional<TimelineItem> predictions = mTokenManager->getPredictionsForToken(token1); |
| 188 | |
| 189 | // token1 should have expired |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 190 | EXPECT_EQ(predictions.has_value(), false); |
| 191 | |
| 192 | predictions = mTokenManager->getPredictionsForToken(token2); |
| 193 | EXPECT_EQ(compareTimelineItems(*predictions, TimelineItem(10, 20, 30)), true); |
| 194 | } |
| 195 | |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 196 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_getOwnerPidReturnsCorrectPid) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 197 | auto surfaceFrame1 = |
| 198 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 199 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 200 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 201 | auto surfaceFrame2 = |
| 202 | mFrameTimeline->createSurfaceFrameForToken({}, sPidTwo, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 203 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 204 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 205 | EXPECT_EQ(surfaceFrame1->getOwnerPid(), sPidOne); |
| 206 | EXPECT_EQ(surfaceFrame2->getOwnerPid(), sPidTwo); |
| 207 | } |
| 208 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 209 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_noToken) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 210 | auto surfaceFrame = |
| 211 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 212 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 213 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 214 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::None); |
| 215 | } |
| 216 | |
| 217 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_expiredToken) { |
| 218 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 219 | flushTokens(); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 220 | auto surfaceFrame = |
| 221 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 222 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 223 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 224 | |
| 225 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Expired); |
| 226 | } |
| 227 | |
| 228 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validToken) { |
| 229 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 230 | auto surfaceFrame = |
| 231 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 232 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 233 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 234 | |
| 235 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Valid); |
| 236 | EXPECT_EQ(compareTimelineItems(surfaceFrame->getPredictions(), TimelineItem(10, 20, 30)), true); |
| 237 | } |
| 238 | |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 239 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validInputEventId) { |
| 240 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 241 | constexpr int32_t inputEventId = 1; |
| 242 | auto surfaceFrame = |
| 243 | mFrameTimeline->createSurfaceFrameForToken({token1, inputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 244 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 245 | /*isBuffer*/ true, sGameMode); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 246 | |
| 247 | EXPECT_EQ(inputEventId, surfaceFrame->getInputEventId()); |
| 248 | } |
| 249 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 250 | TEST_F(FrameTimelineTest, presentFenceSignaled_droppedFramesNotUpdated) { |
| 251 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 252 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 253 | auto surfaceFrame1 = |
| 254 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 255 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 256 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 257 | |
| 258 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 259 | mFrameTimeline->setSfWakeUp(token1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 260 | surfaceFrame1->setDropTime(12); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 261 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 262 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 263 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 264 | presentFence1->signalForTest(30); |
| 265 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 266 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 267 | |
| 268 | auto& droppedSurfaceFrame = getSurfaceFrame(0, 0); |
| 269 | EXPECT_EQ(droppedSurfaceFrame.getPresentState(), SurfaceFrame::PresentState::Dropped); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 270 | EXPECT_EQ(0u, droppedSurfaceFrame.getActuals().endTime); |
| 271 | EXPECT_EQ(12u, droppedSurfaceFrame.getDropTime()); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 272 | EXPECT_EQ(droppedSurfaceFrame.getActuals().presentTime, 0); |
| 273 | } |
| 274 | |
| 275 | TEST_F(FrameTimelineTest, presentFenceSignaled_presentedFramesUpdated) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 276 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 277 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 278 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 279 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 280 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 281 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 282 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 283 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 284 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 285 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 286 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 287 | sUidOne, sLayerIdTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 288 | sLayerNameTwo, /*isBuffer*/ true, sGameMode); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 289 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 290 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 291 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 292 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 293 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 294 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 295 | auto displayFrame = getDisplayFrame(0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 296 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 297 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 298 | presentFence1->signalForTest(42); |
| 299 | |
| 300 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 301 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 302 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 0); |
| 303 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 304 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 305 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 306 | |
| 307 | // Fences have flushed, so the present timestamps should be updated |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 308 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 309 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 42); |
| 310 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 311 | EXPECT_NE(surfaceFrame1->getJankType(), std::nullopt); |
| 312 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 313 | } |
| 314 | |
| 315 | TEST_F(FrameTimelineTest, displayFramesSlidingWindowMovesAfterLimit) { |
| 316 | // Insert kMaxDisplayFrames' count of DisplayFrames to fill the deque |
| 317 | int frameTimeFactor = 0; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 318 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 319 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)) |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 320 | .Times(static_cast<int32_t>(*maxDisplayFrames)); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 321 | for (size_t i = 0; i < *maxDisplayFrames; i++) { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 322 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 323 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 324 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 325 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 326 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 327 | auto surfaceFrame = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 328 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 329 | sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 330 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 331 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 332 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 333 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 334 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 335 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 336 | presentFence->signalForTest(32 + frameTimeFactor); |
| 337 | frameTimeFactor += 30; |
| 338 | } |
| 339 | auto displayFrame0 = getDisplayFrame(0); |
| 340 | |
| 341 | // The 0th Display Frame should have actuals 22, 27, 32 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 342 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(22, 27, 32)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 343 | |
| 344 | // Add one more display frame |
| 345 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 346 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 347 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 348 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 349 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 350 | auto surfaceFrame = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 351 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 352 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 353 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 354 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 355 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 356 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 357 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 358 | presentFence->signalForTest(32 + frameTimeFactor); |
| 359 | displayFrame0 = getDisplayFrame(0); |
| 360 | |
| 361 | // The window should have slided by 1 now and the previous 0th display frame |
| 362 | // should have been removed from the deque |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 363 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(52, 57, 62)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 364 | } |
| 365 | |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 366 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceAfterQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 367 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 368 | "acquireFenceAfterQueue", |
| 369 | "acquireFenceAfterQueue", |
| 370 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 371 | surfaceFrame->setActualQueueTime(123); |
| 372 | surfaceFrame->setAcquireFenceTime(456); |
| 373 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 374 | } |
| 375 | |
| 376 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceBeforeQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 377 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 378 | "acquireFenceAfterQueue", |
| 379 | "acquireFenceAfterQueue", |
| 380 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 381 | surfaceFrame->setActualQueueTime(456); |
| 382 | surfaceFrame->setAcquireFenceTime(123); |
| 383 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 384 | } |
| 385 | |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 386 | TEST_F(FrameTimelineTest, setMaxDisplayFramesSetsSizeProperly) { |
| 387 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 388 | presentFence->signalForTest(2); |
| 389 | |
| 390 | // Size shouldn't exceed maxDisplayFrames - 64 |
| 391 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 392 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 393 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 394 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 395 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 396 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 397 | mFrameTimeline->setSfWakeUp(sfToken, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 398 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 399 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 400 | mFrameTimeline->setSfPresent(27, presentFence); |
| 401 | } |
| 402 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 403 | |
| 404 | // Increase the size to 256 |
| 405 | mFrameTimeline->setMaxDisplayFrames(256); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 406 | EXPECT_EQ(*maxDisplayFrames, 256u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 407 | |
| 408 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 409 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 410 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 411 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 412 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 413 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 414 | mFrameTimeline->setSfWakeUp(sfToken, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 415 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 416 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 417 | mFrameTimeline->setSfPresent(27, presentFence); |
| 418 | } |
| 419 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 420 | |
| 421 | // Shrink the size to 128 |
| 422 | mFrameTimeline->setMaxDisplayFrames(128); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 423 | EXPECT_EQ(*maxDisplayFrames, 128u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 424 | |
| 425 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 426 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 427 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 428 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 429 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 430 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 431 | mFrameTimeline->setSfWakeUp(sfToken, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 432 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 433 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 434 | mFrameTimeline->setSfPresent(27, presentFence); |
| 435 | } |
| 436 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 437 | } |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 438 | |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 439 | TEST_F(FrameTimelineTest, presentFenceSignaled_invalidSignalTime) { |
| 440 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 441 | |
| 442 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 443 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 444 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 445 | |
| 446 | auto surfaceFrame1 = |
| 447 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 448 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 449 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 450 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 451 | surfaceFrame1->setAcquireFenceTime(20); |
| 452 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 453 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 454 | |
| 455 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 456 | presentFence1->signalForTest(-1); |
| 457 | addEmptyDisplayFrame(); |
| 458 | |
| 459 | auto displayFrame0 = getDisplayFrame(0); |
| 460 | EXPECT_EQ(displayFrame0->getActuals().presentTime, -1); |
| 461 | EXPECT_EQ(displayFrame0->getJankType(), JankType::Unknown); |
| 462 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, -1); |
| 463 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown); |
| 464 | } |
| 465 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 466 | // Tests related to TimeStats |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 467 | TEST_F(FrameTimelineTest, presentFenceSignaled_doesNotReportForInvalidTokens) { |
| 468 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 469 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(0); |
| 470 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 471 | int64_t surfaceFrameToken1 = -1; |
| 472 | int64_t sfToken1 = -1; |
| 473 | |
| 474 | auto surfaceFrame1 = |
| 475 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 476 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 477 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 478 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 479 | surfaceFrame1->setAcquireFenceTime(20); |
| 480 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 481 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 482 | presentFence1->signalForTest(70); |
| 483 | |
| 484 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 485 | } |
| 486 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 487 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfCpu) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 488 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 489 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 490 | incrementJankyFrames( |
| 491 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 492 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 493 | JankType::SurfaceFlingerCpuDeadlineMissed, 2, 10, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 494 | 0})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 495 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 496 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 497 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 498 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 499 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 500 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 501 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 502 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 503 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 504 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 505 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 506 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 507 | presentFence1->signalForTest(70); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 508 | |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 509 | mFrameTimeline->setSfPresent(62, presentFence1); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 510 | } |
| 511 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 512 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfGpu) { |
| 513 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 514 | EXPECT_CALL(*mTimeStats, |
| 515 | incrementJankyFrames( |
| 516 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 517 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 518 | JankType::SurfaceFlingerGpuDeadlineMissed, 4, 10, |
| 519 | 0})); |
| 520 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 521 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 522 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 523 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 524 | |
| 525 | auto surfaceFrame1 = |
| 526 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 527 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 528 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 529 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 530 | surfaceFrame1->setAcquireFenceTime(20); |
| 531 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 532 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 533 | gpuFence1->signalForTest(64); |
| 534 | presentFence1->signalForTest(70); |
| 535 | |
| 536 | mFrameTimeline->setSfPresent(59, presentFence1, gpuFence1); |
| 537 | } |
| 538 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 539 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsDisplayMiss) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 540 | Fps refreshRate = Fps::fromPeriodNsecs(30); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 541 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 542 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 543 | sLayerNameOne, sGameMode, |
| 544 | JankType::DisplayHAL, -4, 0, 0})); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 545 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 546 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 547 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 548 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 549 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 550 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 551 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 552 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 553 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 554 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 555 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 556 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 557 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 558 | presentFence1->signalForTest(90); |
| 559 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 560 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::DisplayHAL); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 561 | } |
| 562 | |
| 563 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMiss) { |
Dominik Laskowski | 6eab42d | 2021-09-13 14:34:13 -0700 | [diff] [blame] | 564 | Fps refreshRate = 11_Hz; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 565 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 566 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 567 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 568 | JankType::AppDeadlineMissed, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 569 | 25})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 570 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 571 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 572 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 573 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 574 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 575 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 576 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 577 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 578 | surfaceFrame1->setAcquireFenceTime(45); |
| 579 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 580 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 581 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 582 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 583 | presentFence1->signalForTest(90); |
| 584 | mFrameTimeline->setSfPresent(86, presentFence1); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 585 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 586 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 587 | } |
| 588 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 589 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfScheduling) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 590 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 591 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 592 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 593 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 594 | JankType::SurfaceFlingerScheduling, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 595 | -4, 0, -10})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 596 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 597 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({40, 60, 92}); |
| 598 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 599 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 600 | auto surfaceFrame1 = |
| 601 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 602 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 603 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 604 | surfaceFrame1->setAcquireFenceTime(50); |
| 605 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 606 | |
| 607 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 608 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 609 | presentFence1->signalForTest(60); |
| 610 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 611 | |
| 612 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
| 613 | } |
| 614 | |
| 615 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfPredictionError) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 616 | Fps refreshRate = Fps::fromPeriodNsecs(16); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 617 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 618 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 619 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 620 | JankType::PredictionError, -4, 5, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 621 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 622 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 623 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 60}); |
| 624 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 625 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 626 | auto surfaceFrame1 = |
| 627 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 628 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 629 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 630 | surfaceFrame1->setAcquireFenceTime(40); |
| 631 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 632 | |
| 633 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 634 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 635 | presentFence1->signalForTest(65); |
| 636 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 637 | |
| 638 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::PredictionError); |
| 639 | } |
| 640 | |
| 641 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppBufferStuffing) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 642 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 643 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 644 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 645 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 646 | JankType::BufferStuffing, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 647 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 648 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 649 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 58}); |
| 650 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 651 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 652 | auto surfaceFrame1 = |
| 653 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 654 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 655 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 656 | surfaceFrame1->setAcquireFenceTime(40); |
| 657 | mFrameTimeline->setSfWakeUp(sfToken1, 82, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 658 | |
| 659 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 660 | /*previousLatchTime*/ 56); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 661 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 662 | presentFence1->signalForTest(90); |
| 663 | mFrameTimeline->setSfPresent(86, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 664 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 665 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::BufferStuffing); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 666 | } |
| 667 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 668 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMissWithRenderRate) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 669 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 670 | Fps renderRate = Fps::fromPeriodNsecs(30); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 671 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 672 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, |
| 673 | sLayerNameOne, sGameMode, |
| 674 | JankType::AppDeadlineMissed, -4, 0, |
| 675 | 25})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 676 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 677 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 678 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 679 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 680 | auto surfaceFrame1 = |
| 681 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 682 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 683 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 684 | surfaceFrame1->setAcquireFenceTime(45); |
| 685 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 686 | |
| 687 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 688 | surfaceFrame1->setRenderRate(renderRate); |
| 689 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 690 | presentFence1->signalForTest(90); |
| 691 | mFrameTimeline->setSfPresent(86, presentFence1); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 692 | |
| 693 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
| 694 | } |
| 695 | |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 696 | TEST_F(FrameTimelineTest, presentFenceSignaled_displayFramePredictionExpiredPresentsSurfaceFrame) { |
| 697 | Fps refreshRate = Fps::fromPeriodNsecs(11); |
| 698 | Fps renderRate = Fps::fromPeriodNsecs(30); |
| 699 | |
| 700 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 701 | incrementJankyFrames( |
| 702 | TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 703 | sGameMode, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 704 | JankType::Unknown | JankType::AppDeadlineMissed, |
Adithya Srinivasan | de27245 | 2021-04-10 00:21:00 +0000 | [diff] [blame] | 705 | 0, 0, 25})); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 706 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 707 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 708 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 709 | |
| 710 | auto surfaceFrame1 = |
| 711 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 712 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 713 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 714 | surfaceFrame1->setAcquireFenceTime(45); |
| 715 | // Trigger a prediction expiry |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 716 | flushTokens(); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 717 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate); |
| 718 | |
| 719 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 720 | surfaceFrame1->setRenderRate(renderRate); |
| 721 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 722 | presentFence1->signalForTest(90); |
| 723 | mFrameTimeline->setSfPresent(86, presentFence1); |
| 724 | |
| 725 | auto displayFrame = getDisplayFrame(0); |
| 726 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown); |
| 727 | EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::UnknownStart); |
| 728 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
| 729 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 730 | |
| 731 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 732 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown | JankType::AppDeadlineMissed); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 733 | } |
| 734 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 735 | /* |
| 736 | * Tracing Tests |
| 737 | * |
| 738 | * Trace packets are flushed all the way only when the next packet is traced. |
| 739 | * For example: trace<Display/Surface>Frame() will create a TracePacket but not flush it. Only when |
| 740 | * another TracePacket is created, the previous one is guaranteed to be flushed. The following tests |
| 741 | * will have additional empty frames created for this reason. |
| 742 | */ |
| 743 | TEST_F(FrameTimelineTest, tracing_noPacketsSentWithoutTraceStart) { |
| 744 | auto tracingSession = getTracingSessionForTest(); |
| 745 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 746 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 747 | auto surfaceFrame1 = |
| 748 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 749 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 750 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 751 | |
| 752 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 753 | mFrameTimeline->setSfWakeUp(token1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 754 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 755 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 756 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 757 | presentFence1->signalForTest(30); |
| 758 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 759 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 760 | |
| 761 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 762 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 763 | } |
| 764 | |
| 765 | TEST_F(FrameTimelineTest, tracing_sanityTest) { |
| 766 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 767 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 768 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 769 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 770 | |
| 771 | tracingSession->StartBlocking(); |
| 772 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 773 | int64_t token2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 774 | auto surfaceFrame1 = |
| 775 | mFrameTimeline->createSurfaceFrameForToken({token1, sInputEventId}, sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 776 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 777 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 778 | |
| 779 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 780 | mFrameTimeline->setSfWakeUp(token2, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 781 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 782 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 783 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 784 | presentFence1->signalForTest(30); |
| 785 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 786 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 787 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 788 | tracingSession->StopBlocking(); |
| 789 | |
| 790 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 791 | // Display Frame 1 has 8 packets - 4 from DisplayFrame and 4 from SurfaceFrame. |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 792 | EXPECT_EQ(packets.size(), 8u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 793 | } |
| 794 | |
| 795 | TEST_F(FrameTimelineTest, traceDisplayFrame_invalidTokenDoesNotEmitTracePacket) { |
| 796 | auto tracingSession = getTracingSessionForTest(); |
| 797 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 798 | |
| 799 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 800 | |
| 801 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 802 | mFrameTimeline->setSfWakeUp(-1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 803 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 804 | presentFence1->signalForTest(30); |
| 805 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 806 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 807 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 808 | tracingSession->StopBlocking(); |
| 809 | |
| 810 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 811 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 812 | } |
| 813 | |
| 814 | TEST_F(FrameTimelineTest, traceSurfaceFrame_invalidTokenDoesNotEmitTracePacket) { |
| 815 | auto tracingSession = getTracingSessionForTest(); |
| 816 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 817 | |
| 818 | tracingSession->StartBlocking(); |
| 819 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 820 | auto surfaceFrame1 = |
| 821 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 822 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 823 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 824 | |
| 825 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 826 | mFrameTimeline->setSfWakeUp(token1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 827 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 828 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 829 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 830 | presentFence1->signalForTest(30); |
| 831 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 832 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 833 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 834 | tracingSession->StopBlocking(); |
| 835 | |
| 836 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 837 | // Display Frame 1 has 4 packets (SurfaceFrame shouldn't be traced since it has an invalid |
| 838 | // token). |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 839 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 840 | } |
| 841 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 842 | ProtoExpectedDisplayFrameStart createProtoExpectedDisplayFrameStart(int64_t cookie, int64_t token, |
| 843 | pid_t pid) { |
| 844 | ProtoExpectedDisplayFrameStart proto; |
| 845 | proto.set_cookie(cookie); |
| 846 | proto.set_token(token); |
| 847 | proto.set_pid(pid); |
| 848 | return proto; |
| 849 | } |
| 850 | |
| 851 | ProtoActualDisplayFrameStart createProtoActualDisplayFrameStart( |
| 852 | int64_t cookie, int64_t token, pid_t pid, ProtoPresentType presentType, bool onTimeFinish, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 853 | bool gpuComposition, ProtoJankType jankType, ProtoPredictionType predictionType) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 854 | ProtoActualDisplayFrameStart proto; |
| 855 | proto.set_cookie(cookie); |
| 856 | proto.set_token(token); |
| 857 | proto.set_pid(pid); |
| 858 | proto.set_present_type(presentType); |
| 859 | proto.set_on_time_finish(onTimeFinish); |
| 860 | proto.set_gpu_composition(gpuComposition); |
| 861 | proto.set_jank_type(jankType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 862 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 863 | return proto; |
| 864 | } |
| 865 | |
| 866 | ProtoExpectedSurfaceFrameStart createProtoExpectedSurfaceFrameStart(int64_t cookie, int64_t token, |
| 867 | int64_t displayFrameToken, |
| 868 | pid_t pid, |
| 869 | std::string layerName) { |
| 870 | ProtoExpectedSurfaceFrameStart proto; |
| 871 | proto.set_cookie(cookie); |
| 872 | proto.set_token(token); |
| 873 | proto.set_display_frame_token(displayFrameToken); |
| 874 | proto.set_pid(pid); |
| 875 | proto.set_layer_name(layerName); |
| 876 | return proto; |
| 877 | } |
| 878 | |
| 879 | ProtoActualSurfaceFrameStart createProtoActualSurfaceFrameStart( |
| 880 | int64_t cookie, int64_t token, int64_t displayFrameToken, pid_t pid, std::string layerName, |
| 881 | ProtoPresentType presentType, bool onTimeFinish, bool gpuComposition, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 882 | ProtoJankType jankType, ProtoPredictionType predictionType, bool isBuffer) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 883 | ProtoActualSurfaceFrameStart proto; |
| 884 | proto.set_cookie(cookie); |
| 885 | proto.set_token(token); |
| 886 | proto.set_display_frame_token(displayFrameToken); |
| 887 | proto.set_pid(pid); |
| 888 | proto.set_layer_name(layerName); |
| 889 | proto.set_present_type(presentType); |
| 890 | proto.set_on_time_finish(onTimeFinish); |
| 891 | proto.set_gpu_composition(gpuComposition); |
| 892 | proto.set_jank_type(jankType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 893 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 894 | proto.set_is_buffer(isBuffer); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 895 | return proto; |
| 896 | } |
| 897 | |
| 898 | ProtoFrameEnd createProtoFrameEnd(int64_t cookie) { |
| 899 | ProtoFrameEnd proto; |
| 900 | proto.set_cookie(cookie); |
| 901 | return proto; |
| 902 | } |
| 903 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 904 | void validateTraceEvent(const ProtoExpectedDisplayFrameStart& received, |
| 905 | const ProtoExpectedDisplayFrameStart& source) { |
| 906 | ASSERT_TRUE(received.has_cookie()); |
| 907 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 908 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 909 | ASSERT_TRUE(received.has_token()); |
| 910 | EXPECT_EQ(received.token(), source.token()); |
| 911 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 912 | ASSERT_TRUE(received.has_pid()); |
| 913 | EXPECT_EQ(received.pid(), source.pid()); |
| 914 | } |
| 915 | |
| 916 | void validateTraceEvent(const ProtoActualDisplayFrameStart& received, |
| 917 | const ProtoActualDisplayFrameStart& source) { |
| 918 | ASSERT_TRUE(received.has_cookie()); |
| 919 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 920 | |
| 921 | ASSERT_TRUE(received.has_token()); |
| 922 | EXPECT_EQ(received.token(), source.token()); |
| 923 | |
| 924 | ASSERT_TRUE(received.has_pid()); |
| 925 | EXPECT_EQ(received.pid(), source.pid()); |
| 926 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 927 | ASSERT_TRUE(received.has_present_type()); |
| 928 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 929 | ASSERT_TRUE(received.has_on_time_finish()); |
| 930 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 931 | ASSERT_TRUE(received.has_gpu_composition()); |
| 932 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 933 | ASSERT_TRUE(received.has_jank_type()); |
| 934 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 935 | ASSERT_TRUE(received.has_prediction_type()); |
| 936 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 937 | } |
| 938 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 939 | void validateTraceEvent(const ProtoExpectedSurfaceFrameStart& received, |
| 940 | const ProtoExpectedSurfaceFrameStart& source) { |
| 941 | ASSERT_TRUE(received.has_cookie()); |
| 942 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 943 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 944 | ASSERT_TRUE(received.has_token()); |
| 945 | EXPECT_EQ(received.token(), source.token()); |
| 946 | |
| 947 | ASSERT_TRUE(received.has_display_frame_token()); |
| 948 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 949 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 950 | ASSERT_TRUE(received.has_pid()); |
| 951 | EXPECT_EQ(received.pid(), source.pid()); |
| 952 | |
| 953 | ASSERT_TRUE(received.has_layer_name()); |
| 954 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 955 | } |
| 956 | |
| 957 | void validateTraceEvent(const ProtoActualSurfaceFrameStart& received, |
| 958 | const ProtoActualSurfaceFrameStart& source) { |
| 959 | ASSERT_TRUE(received.has_cookie()); |
| 960 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 961 | |
| 962 | ASSERT_TRUE(received.has_token()); |
| 963 | EXPECT_EQ(received.token(), source.token()); |
| 964 | |
| 965 | ASSERT_TRUE(received.has_display_frame_token()); |
| 966 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 967 | |
| 968 | ASSERT_TRUE(received.has_pid()); |
| 969 | EXPECT_EQ(received.pid(), source.pid()); |
| 970 | |
| 971 | ASSERT_TRUE(received.has_layer_name()); |
| 972 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 973 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 974 | ASSERT_TRUE(received.has_present_type()); |
| 975 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 976 | ASSERT_TRUE(received.has_on_time_finish()); |
| 977 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 978 | ASSERT_TRUE(received.has_gpu_composition()); |
| 979 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 980 | ASSERT_TRUE(received.has_jank_type()); |
| 981 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 982 | ASSERT_TRUE(received.has_prediction_type()); |
| 983 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 984 | ASSERT_TRUE(received.has_is_buffer()); |
| 985 | EXPECT_EQ(received.is_buffer(), source.is_buffer()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 986 | } |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 987 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 988 | void validateTraceEvent(const ProtoFrameEnd& received, const ProtoFrameEnd& source) { |
| 989 | ASSERT_TRUE(received.has_cookie()); |
| 990 | EXPECT_EQ(received.cookie(), source.cookie()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 991 | } |
| 992 | |
| 993 | TEST_F(FrameTimelineTest, traceDisplayFrame_emitsValidTracePacket) { |
| 994 | auto tracingSession = getTracingSessionForTest(); |
| 995 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 996 | |
| 997 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 998 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 30, 30}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 999 | |
| 1000 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1001 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1002 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1003 | presentFence1->signalForTest(31); |
| 1004 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1005 | int64_t traceCookie = snoopCurrentTraceCookie(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1006 | auto protoExpectedDisplayFrameStart = |
| 1007 | createProtoExpectedDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1008 | kSurfaceFlingerPid); |
| 1009 | auto protoExpectedDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1010 | auto protoActualDisplayFrameStart = |
| 1011 | createProtoActualDisplayFrameStart(traceCookie + 2, displayFrameToken1, |
| 1012 | kSurfaceFlingerPid, |
| 1013 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1014 | FrameTimelineEvent::JANK_NONE, |
| 1015 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1016 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1017 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1018 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1019 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1020 | tracingSession->StopBlocking(); |
| 1021 | |
| 1022 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1023 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1024 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1025 | // Packet - 0 : ExpectedDisplayFrameStart |
| 1026 | const auto& packet0 = packets[0]; |
| 1027 | ASSERT_TRUE(packet0.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1028 | EXPECT_EQ(packet0.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1029 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1030 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1031 | const auto& event0 = packet0.frame_timeline_event(); |
| 1032 | ASSERT_TRUE(event0.has_expected_display_frame_start()); |
| 1033 | const auto& expectedDisplayFrameStart = event0.expected_display_frame_start(); |
| 1034 | validateTraceEvent(expectedDisplayFrameStart, protoExpectedDisplayFrameStart); |
| 1035 | |
| 1036 | // Packet - 1 : FrameEnd (ExpectedDisplayFrame) |
| 1037 | const auto& packet1 = packets[1]; |
| 1038 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1039 | EXPECT_EQ(packet1.timestamp(), 30u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1040 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1041 | |
| 1042 | const auto& event1 = packet1.frame_timeline_event(); |
| 1043 | ASSERT_TRUE(event1.has_frame_end()); |
| 1044 | const auto& expectedDisplayFrameEnd = event1.frame_end(); |
| 1045 | validateTraceEvent(expectedDisplayFrameEnd, protoExpectedDisplayFrameEnd); |
| 1046 | |
| 1047 | // Packet - 2 : ActualDisplayFrameStart |
| 1048 | const auto& packet2 = packets[2]; |
| 1049 | ASSERT_TRUE(packet2.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1050 | EXPECT_EQ(packet2.timestamp(), 20u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1051 | ASSERT_TRUE(packet2.has_frame_timeline_event()); |
| 1052 | |
| 1053 | const auto& event2 = packet2.frame_timeline_event(); |
| 1054 | ASSERT_TRUE(event2.has_actual_display_frame_start()); |
| 1055 | const auto& actualDisplayFrameStart = event2.actual_display_frame_start(); |
| 1056 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1057 | |
| 1058 | // Packet - 3 : FrameEnd (ActualDisplayFrame) |
| 1059 | const auto& packet3 = packets[3]; |
| 1060 | ASSERT_TRUE(packet3.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1061 | EXPECT_EQ(packet3.timestamp(), 31u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1062 | ASSERT_TRUE(packet3.has_frame_timeline_event()); |
| 1063 | |
| 1064 | const auto& event3 = packet3.frame_timeline_event(); |
| 1065 | ASSERT_TRUE(event3.has_frame_end()); |
| 1066 | const auto& actualDisplayFrameEnd = event3.frame_end(); |
| 1067 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1068 | } |
| 1069 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1070 | TEST_F(FrameTimelineTest, traceDisplayFrame_predictionExpiredDoesNotTraceExpectedTimeline) { |
| 1071 | auto tracingSession = getTracingSessionForTest(); |
| 1072 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1073 | |
| 1074 | tracingSession->StartBlocking(); |
| 1075 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 25, 30}); |
| 1076 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1077 | flushTokens(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1078 | |
| 1079 | // Set up the display frame |
| 1080 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, Fps::fromPeriodNsecs(11)); |
| 1081 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1082 | presentFence1->signalForTest(31); |
| 1083 | |
| 1084 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1085 | |
| 1086 | auto protoActualDisplayFrameStart = |
| 1087 | createProtoActualDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1088 | kSurfaceFlingerPid, |
| 1089 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1090 | false, FrameTimelineEvent::JANK_UNKNOWN, |
| 1091 | FrameTimelineEvent::PREDICTION_EXPIRED); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1092 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1093 | |
| 1094 | addEmptyDisplayFrame(); |
| 1095 | flushTrace(); |
| 1096 | tracingSession->StopBlocking(); |
| 1097 | |
| 1098 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1099 | // Only actual timeline packets should be in the trace |
| 1100 | EXPECT_EQ(packets.size(), 2u); |
| 1101 | |
| 1102 | // Packet - 0 : ActualDisplayFrameStart |
| 1103 | const auto& packet0 = packets[0]; |
| 1104 | ASSERT_TRUE(packet0.has_timestamp()); |
| 1105 | EXPECT_EQ(packet0.timestamp(), 20u); |
| 1106 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
| 1107 | |
| 1108 | const auto& event0 = packet0.frame_timeline_event(); |
| 1109 | ASSERT_TRUE(event0.has_actual_display_frame_start()); |
| 1110 | const auto& actualDisplayFrameStart = event0.actual_display_frame_start(); |
| 1111 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1112 | |
| 1113 | // Packet - 1 : FrameEnd (ActualDisplayFrame) |
| 1114 | const auto& packet1 = packets[1]; |
| 1115 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1116 | EXPECT_EQ(packet1.timestamp(), 31u); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1117 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1118 | |
| 1119 | const auto& event1 = packet1.frame_timeline_event(); |
| 1120 | ASSERT_TRUE(event1.has_frame_end()); |
| 1121 | const auto& actualDisplayFrameEnd = event1.frame_end(); |
| 1122 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
| 1123 | } |
| 1124 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1125 | TEST_F(FrameTimelineTest, traceSurfaceFrame_emitsValidTracePacket) { |
| 1126 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1127 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1128 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1129 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1130 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1131 | |
| 1132 | tracingSession->StartBlocking(); |
| 1133 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 25, 40}); |
| 1134 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({30, 35, 40}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1135 | |
| 1136 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1137 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1138 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1139 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1140 | auto surfaceFrame2 = |
| 1141 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1142 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1143 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1144 | surfaceFrame1->setActualQueueTime(10); |
| 1145 | surfaceFrame1->setDropTime(15); |
| 1146 | |
| 1147 | surfaceFrame2->setActualQueueTime(15); |
| 1148 | surfaceFrame2->setAcquireFenceTime(20); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1149 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1150 | // First 2 cookies will be used by the DisplayFrame |
| 1151 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1152 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1153 | auto protoDroppedSurfaceFrameExpectedStart = |
| 1154 | createProtoExpectedSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1155 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1156 | auto protoDroppedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 1); |
| 1157 | auto protoDroppedSurfaceFrameActualStart = |
| 1158 | createProtoActualSurfaceFrameStart(traceCookie + 2, surfaceFrameToken, |
| 1159 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1160 | FrameTimelineEvent::PRESENT_DROPPED, false, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1161 | FrameTimelineEvent::JANK_NONE, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1162 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1163 | auto protoDroppedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1164 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1165 | auto protoPresentedSurfaceFrameExpectedStart = |
| 1166 | createProtoExpectedSurfaceFrameStart(traceCookie + 3, surfaceFrameToken, |
| 1167 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1168 | auto protoPresentedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 3); |
| 1169 | auto protoPresentedSurfaceFrameActualStart = |
| 1170 | createProtoActualSurfaceFrameStart(traceCookie + 4, surfaceFrameToken, |
| 1171 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1172 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1173 | FrameTimelineEvent::JANK_NONE, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1174 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1175 | auto protoPresentedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 4); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1176 | |
| 1177 | // Set up the display frame |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1178 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1179 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1180 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1181 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1182 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1183 | mFrameTimeline->setSfPresent(26, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1184 | presentFence1->signalForTest(40); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1185 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1186 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1187 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1188 | tracingSession->StopBlocking(); |
| 1189 | |
| 1190 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1191 | // 4 DisplayFrame + 4 DroppedSurfaceFrame + 4 PresentedSurfaceFrame |
| 1192 | EXPECT_EQ(packets.size(), 12u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1193 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1194 | // Packet - 4 : ExpectedSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1195 | const auto& packet4 = packets[4]; |
| 1196 | ASSERT_TRUE(packet4.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1197 | EXPECT_EQ(packet4.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1198 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1199 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1200 | const auto& event4 = packet4.frame_timeline_event(); |
| 1201 | ASSERT_TRUE(event4.has_expected_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1202 | const auto& expectedSurfaceFrameStart1 = event4.expected_surface_frame_start(); |
| 1203 | validateTraceEvent(expectedSurfaceFrameStart1, protoDroppedSurfaceFrameExpectedStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1204 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1205 | // Packet - 5 : FrameEnd (ExpectedSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1206 | const auto& packet5 = packets[5]; |
| 1207 | ASSERT_TRUE(packet5.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1208 | EXPECT_EQ(packet5.timestamp(), 25u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1209 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1210 | |
| 1211 | const auto& event5 = packet5.frame_timeline_event(); |
| 1212 | ASSERT_TRUE(event5.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1213 | const auto& expectedSurfaceFrameEnd1 = event5.frame_end(); |
| 1214 | validateTraceEvent(expectedSurfaceFrameEnd1, protoDroppedSurfaceFrameExpectedEnd); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1215 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1216 | // Packet - 6 : ActualSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1217 | const auto& packet6 = packets[6]; |
| 1218 | ASSERT_TRUE(packet6.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1219 | EXPECT_EQ(packet6.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1220 | ASSERT_TRUE(packet6.has_frame_timeline_event()); |
| 1221 | |
| 1222 | const auto& event6 = packet6.frame_timeline_event(); |
| 1223 | ASSERT_TRUE(event6.has_actual_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1224 | const auto& actualSurfaceFrameStart1 = event6.actual_surface_frame_start(); |
| 1225 | validateTraceEvent(actualSurfaceFrameStart1, protoDroppedSurfaceFrameActualStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1226 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1227 | // Packet - 7 : FrameEnd (ActualSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1228 | const auto& packet7 = packets[7]; |
| 1229 | ASSERT_TRUE(packet7.has_timestamp()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1230 | EXPECT_EQ(packet7.timestamp(), 15u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1231 | ASSERT_TRUE(packet7.has_frame_timeline_event()); |
| 1232 | |
| 1233 | const auto& event7 = packet7.frame_timeline_event(); |
| 1234 | ASSERT_TRUE(event7.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1235 | const auto& actualSurfaceFrameEnd1 = event7.frame_end(); |
| 1236 | validateTraceEvent(actualSurfaceFrameEnd1, protoDroppedSurfaceFrameActualEnd); |
| 1237 | |
| 1238 | // Packet - 8 : ExpectedSurfaceFrameStart2 |
| 1239 | const auto& packet8 = packets[8]; |
| 1240 | ASSERT_TRUE(packet8.has_timestamp()); |
| 1241 | EXPECT_EQ(packet8.timestamp(), 10u); |
| 1242 | ASSERT_TRUE(packet8.has_frame_timeline_event()); |
| 1243 | |
| 1244 | const auto& event8 = packet8.frame_timeline_event(); |
| 1245 | ASSERT_TRUE(event8.has_expected_surface_frame_start()); |
| 1246 | const auto& expectedSurfaceFrameStart2 = event8.expected_surface_frame_start(); |
| 1247 | validateTraceEvent(expectedSurfaceFrameStart2, protoPresentedSurfaceFrameExpectedStart); |
| 1248 | |
| 1249 | // Packet - 9 : FrameEnd (ExpectedSurfaceFrame2) |
| 1250 | const auto& packet9 = packets[9]; |
| 1251 | ASSERT_TRUE(packet9.has_timestamp()); |
| 1252 | EXPECT_EQ(packet9.timestamp(), 25u); |
| 1253 | ASSERT_TRUE(packet9.has_frame_timeline_event()); |
| 1254 | |
| 1255 | const auto& event9 = packet9.frame_timeline_event(); |
| 1256 | ASSERT_TRUE(event9.has_frame_end()); |
| 1257 | const auto& expectedSurfaceFrameEnd2 = event9.frame_end(); |
| 1258 | validateTraceEvent(expectedSurfaceFrameEnd2, protoPresentedSurfaceFrameExpectedEnd); |
| 1259 | |
| 1260 | // Packet - 10 : ActualSurfaceFrameStart2 |
| 1261 | const auto& packet10 = packets[10]; |
| 1262 | ASSERT_TRUE(packet10.has_timestamp()); |
| 1263 | EXPECT_EQ(packet10.timestamp(), 10u); |
| 1264 | ASSERT_TRUE(packet10.has_frame_timeline_event()); |
| 1265 | |
| 1266 | const auto& event10 = packet10.frame_timeline_event(); |
| 1267 | ASSERT_TRUE(event10.has_actual_surface_frame_start()); |
| 1268 | const auto& actualSurfaceFrameStart2 = event10.actual_surface_frame_start(); |
| 1269 | validateTraceEvent(actualSurfaceFrameStart2, protoPresentedSurfaceFrameActualStart); |
| 1270 | |
| 1271 | // Packet - 11 : FrameEnd (ActualSurfaceFrame2) |
| 1272 | const auto& packet11 = packets[11]; |
| 1273 | ASSERT_TRUE(packet11.has_timestamp()); |
| 1274 | EXPECT_EQ(packet11.timestamp(), 20u); |
| 1275 | ASSERT_TRUE(packet11.has_frame_timeline_event()); |
| 1276 | |
| 1277 | const auto& event11 = packet11.frame_timeline_event(); |
| 1278 | ASSERT_TRUE(event11.has_frame_end()); |
| 1279 | const auto& actualSurfaceFrameEnd2 = event11.frame_end(); |
| 1280 | validateTraceEvent(actualSurfaceFrameEnd2, protoPresentedSurfaceFrameActualEnd); |
| 1281 | } |
| 1282 | |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1283 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredIsAppMissedDeadline) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1284 | auto tracingSession = getTracingSessionForTest(); |
| 1285 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1286 | |
| 1287 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1288 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1289 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1290 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1291 | int64_t surfaceFrameToken = |
| 1292 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1293 | |
| 1294 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1295 | flushTokens(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1296 | auto surfaceFrame1 = |
| 1297 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, /*inputEventId*/ 0}, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1298 | sPidOne, sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1299 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1300 | surfaceFrame1->setActualQueueTime(appEndTime); |
| 1301 | surfaceFrame1->setAcquireFenceTime(appEndTime); |
| 1302 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1303 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(20ms).count(); |
| 1304 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1305 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1306 | int64_t displayFrameToken = |
| 1307 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1308 | |
| 1309 | // First 2 cookies will be used by the DisplayFrame |
| 1310 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1311 | |
| 1312 | auto protoActualSurfaceFrameStart = |
| 1313 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1314 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1315 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1316 | false, FrameTimelineEvent::JANK_APP_DEADLINE_MISSED, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1317 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1318 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1319 | |
| 1320 | // Set up the display frame |
| 1321 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, Fps::fromPeriodNsecs(11)); |
| 1322 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1323 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1324 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1325 | presentFence1->signalForTest(sfPresentTime); |
| 1326 | |
| 1327 | addEmptyDisplayFrame(); |
| 1328 | flushTrace(); |
| 1329 | tracingSession->StopBlocking(); |
| 1330 | |
| 1331 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1332 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1333 | ASSERT_EQ(packets.size(), 6u); |
| 1334 | |
| 1335 | // Packet - 4 : ActualSurfaceFrameStart |
| 1336 | const auto& packet4 = packets[4]; |
| 1337 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1338 | EXPECT_EQ(packet4.timestamp(), |
| 1339 | static_cast<uint64_t>(appEndTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1340 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1341 | |
| 1342 | const auto& event4 = packet4.frame_timeline_event(); |
| 1343 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1344 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1345 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1346 | |
| 1347 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1348 | const auto& packet5 = packets[5]; |
| 1349 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1350 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(appEndTime)); |
| 1351 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1352 | |
| 1353 | const auto& event5 = packet5.frame_timeline_event(); |
| 1354 | ASSERT_TRUE(event5.has_frame_end()); |
| 1355 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1356 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1357 | } |
| 1358 | |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1359 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredDroppedFramesTracedProperly) { |
| 1360 | auto tracingSession = getTracingSessionForTest(); |
| 1361 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1362 | |
| 1363 | tracingSession->StartBlocking(); |
| 1364 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1365 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1366 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1367 | int64_t surfaceFrameToken = |
| 1368 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1369 | |
| 1370 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1371 | flushTokens(); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1372 | auto surfaceFrame1 = |
| 1373 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, /*inputEventId*/ 0}, |
| 1374 | sPidOne, sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1375 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1376 | |
| 1377 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(22ms).count(); |
| 1378 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1379 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1380 | int64_t displayFrameToken = |
| 1381 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1382 | |
| 1383 | // First 2 cookies will be used by the DisplayFrame |
| 1384 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1385 | |
| 1386 | auto protoActualSurfaceFrameStart = |
| 1387 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1388 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1389 | FrameTimelineEvent::PRESENT_DROPPED, false, false, |
| 1390 | FrameTimelineEvent::JANK_NONE, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1391 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1392 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1393 | |
| 1394 | // Set up the display frame |
| 1395 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, Fps::fromPeriodNsecs(11)); |
| 1396 | surfaceFrame1->setDropTime(sfStartTime); |
| 1397 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1398 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1399 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1400 | presentFence1->signalForTest(sfPresentTime); |
| 1401 | |
| 1402 | addEmptyDisplayFrame(); |
| 1403 | flushTrace(); |
| 1404 | tracingSession->StopBlocking(); |
| 1405 | |
| 1406 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1407 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1408 | ASSERT_EQ(packets.size(), 6u); |
| 1409 | |
| 1410 | // Packet - 4 : ActualSurfaceFrameStart |
| 1411 | const auto& packet4 = packets[4]; |
| 1412 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1413 | EXPECT_EQ(packet4.timestamp(), |
| 1414 | static_cast<uint64_t>(sfStartTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1415 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1416 | |
| 1417 | const auto& event4 = packet4.frame_timeline_event(); |
| 1418 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1419 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1420 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1421 | |
| 1422 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1423 | const auto& packet5 = packets[5]; |
| 1424 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1425 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(sfStartTime)); |
| 1426 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1427 | |
| 1428 | const auto& event5 = packet5.frame_timeline_event(); |
| 1429 | ASSERT_TRUE(event5.has_frame_end()); |
| 1430 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
| 1431 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
| 1432 | } |
| 1433 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1434 | // Tests for Jank classification |
| 1435 | TEST_F(FrameTimelineTest, jankClassification_presentOnTimeDoesNotClassify) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1436 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1437 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1438 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1439 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1440 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 30}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1441 | auto surfaceFrame = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1442 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1443 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1444 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1445 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1446 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1447 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 1448 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1449 | auto displayFrame = getDisplayFrame(0); |
| 1450 | auto& presentedSurfaceFrame = getSurfaceFrame(0, 0); |
| 1451 | presentFence1->signalForTest(29); |
| 1452 | |
| 1453 | // Fences haven't been flushed yet, so it should be 0 |
| 1454 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1455 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 0); |
| 1456 | |
| 1457 | addEmptyDisplayFrame(); |
| 1458 | displayFrame = getDisplayFrame(0); |
| 1459 | |
| 1460 | // Fences have flushed, so the present timestamps should be updated |
| 1461 | EXPECT_EQ(displayFrame->getActuals().presentTime, 29); |
| 1462 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 29); |
| 1463 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1464 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1465 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
| 1466 | } |
| 1467 | |
| 1468 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1469 | Fps vsyncRate = Fps::fromPeriodNsecs(11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1470 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1471 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1472 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1473 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1474 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1475 | auto displayFrame = getDisplayFrame(0); |
| 1476 | presentFence1->signalForTest(30); |
| 1477 | |
| 1478 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1479 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1480 | |
| 1481 | // Trigger a flush by finalizing the next DisplayFrame |
| 1482 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1483 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1484 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1485 | displayFrame = getDisplayFrame(0); |
| 1486 | |
| 1487 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1488 | EXPECT_EQ(displayFrame->getActuals().presentTime, 30); |
| 1489 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1490 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1491 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1492 | |
| 1493 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1494 | auto displayFrame2 = getDisplayFrame(1); |
| 1495 | presentFence2->signalForTest(65); |
| 1496 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1497 | addEmptyDisplayFrame(); |
| 1498 | displayFrame2 = getDisplayFrame(1); |
| 1499 | |
| 1500 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1501 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1502 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1503 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1504 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1505 | } |
| 1506 | |
| 1507 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1508 | Fps vsyncRate = Fps::fromPeriodNsecs(11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1509 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1510 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1511 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1512 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1513 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1514 | auto displayFrame = getDisplayFrame(0); |
| 1515 | presentFence1->signalForTest(50); |
| 1516 | |
| 1517 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1518 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1519 | |
| 1520 | // Trigger a flush by finalizing the next DisplayFrame |
| 1521 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1522 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1523 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1524 | displayFrame = getDisplayFrame(0); |
| 1525 | |
| 1526 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1527 | EXPECT_EQ(displayFrame->getActuals().presentTime, 50); |
| 1528 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1529 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1530 | EXPECT_EQ(displayFrame->getJankType(), JankType::DisplayHAL); |
| 1531 | |
| 1532 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1533 | auto displayFrame2 = getDisplayFrame(1); |
| 1534 | presentFence2->signalForTest(75); |
| 1535 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1536 | |
| 1537 | addEmptyDisplayFrame(); |
| 1538 | displayFrame2 = getDisplayFrame(1); |
| 1539 | |
| 1540 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1541 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 75); |
| 1542 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1543 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1544 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1545 | } |
| 1546 | |
| 1547 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishEarlyPresent) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1548 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1549 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({12, 18, 40}); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1550 | mFrameTimeline->setSfWakeUp(sfToken1, 12, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1551 | |
| 1552 | mFrameTimeline->setSfPresent(22, presentFence1); |
| 1553 | auto displayFrame = getDisplayFrame(0); |
| 1554 | presentFence1->signalForTest(28); |
| 1555 | |
| 1556 | // Fences haven't been flushed yet, so it should be 0 |
| 1557 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1558 | |
| 1559 | addEmptyDisplayFrame(); |
| 1560 | displayFrame = getDisplayFrame(0); |
| 1561 | |
| 1562 | // Fences have flushed, so the present timestamps should be updated |
| 1563 | EXPECT_EQ(displayFrame->getActuals().presentTime, 28); |
| 1564 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1565 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1566 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1567 | } |
| 1568 | |
| 1569 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent) { |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1570 | /* |
| 1571 | * Case 1 - cpu time > vsync period but combined time > deadline > deadline -> cpudeadlinemissed |
| 1572 | * Case 2 - cpu time < vsync period but combined time > deadline -> gpudeadlinemissed |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1573 | * Case 3 - previous frame ran longer -> sf_stuffing |
| 1574 | * Case 4 - Long cpu under SF stuffing -> cpudeadlinemissed |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1575 | */ |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1576 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1577 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1578 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1579 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1580 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1581 | auto gpuFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1582 | auto gpuFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1583 | auto gpuFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1584 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1585 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1586 | int64_t sfToken3 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 1587 | int64_t sfToken4 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
| 1588 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1589 | // case 1 - cpu time = 33 - 12 = 21, vsync period = 11 |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1590 | mFrameTimeline->setSfWakeUp(sfToken1, 12, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1591 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 1592 | auto displayFrame0 = getDisplayFrame(0); |
| 1593 | gpuFence1->signalForTest(36); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1594 | presentFence1->signalForTest(52); |
| 1595 | |
| 1596 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1597 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 0); |
| 1598 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1599 | // case 2 - cpu time = 56 - 52 = 4, vsync period = 30 |
| 1600 | mFrameTimeline->setSfWakeUp(sfToken2, 52, Fps::fromPeriodNsecs(30)); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1601 | mFrameTimeline->setSfPresent(56, presentFence2, gpuFence2); |
| 1602 | auto displayFrame1 = getDisplayFrame(1); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1603 | gpuFence2->signalForTest(76); |
| 1604 | presentFence2->signalForTest(90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1605 | |
| 1606 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1607 | // Fences have flushed for first displayFrame, so the present timestamps should be updated |
| 1608 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 52); |
| 1609 | EXPECT_EQ(displayFrame0->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1610 | EXPECT_EQ(displayFrame0->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1611 | EXPECT_EQ(displayFrame0->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1612 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1613 | // case 3 - cpu time = 86 - 82 = 4, vsync period = 30 |
| 1614 | mFrameTimeline->setSfWakeUp(sfToken3, 106, Fps::fromPeriodNsecs(30)); |
| 1615 | mFrameTimeline->setSfPresent(112, presentFence3, gpuFence3); |
| 1616 | auto displayFrame2 = getDisplayFrame(2); |
| 1617 | gpuFence3->signalForTest(116); |
| 1618 | presentFence3->signalForTest(120); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1619 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1620 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1621 | // Fences have flushed for second displayFrame, so the present timestamps should be updated |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1622 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1623 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1624 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1625 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1626 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1627 | // case 4 - cpu time = 86 - 82 = 4, vsync period = 30 |
| 1628 | mFrameTimeline->setSfWakeUp(sfToken4, 120, Fps::fromPeriodNsecs(30)); |
| 1629 | mFrameTimeline->setSfPresent(140, presentFence4, gpuFence4); |
| 1630 | auto displayFrame3 = getDisplayFrame(3); |
| 1631 | gpuFence4->signalForTest(156); |
| 1632 | presentFence4->signalForTest(180); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1633 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1634 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 0); |
| 1635 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 1636 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 1637 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1638 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1639 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerStuffing); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1640 | |
| 1641 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1642 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1643 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 1644 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 180); |
| 1645 | EXPECT_EQ(displayFrame3->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1646 | EXPECT_EQ(displayFrame3->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1647 | EXPECT_EQ(displayFrame3->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1648 | } |
| 1649 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1650 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1651 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1652 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1653 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1654 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1655 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1656 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1657 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1658 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1659 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1660 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1661 | surfaceFrame1->setAcquireFenceTime(16); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1662 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1663 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1664 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1665 | mFrameTimeline->setSfPresent(27, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1666 | auto displayFrame1 = getDisplayFrame(0); |
| 1667 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1668 | presentFence1->signalForTest(30); |
| 1669 | |
| 1670 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1671 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1672 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1673 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1674 | |
| 1675 | // Trigger a flush by finalizing the next DisplayFrame |
| 1676 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1677 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1678 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1679 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1680 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1681 | surfaceFrame2->setAcquireFenceTime(36); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1682 | mFrameTimeline->setSfWakeUp(sfToken2, 52, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1683 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1684 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1685 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1686 | auto displayFrame2 = getDisplayFrame(1); |
| 1687 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1688 | |
| 1689 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1690 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 30); |
| 1691 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1692 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1693 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1694 | |
| 1695 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1696 | EXPECT_EQ(actuals1.presentTime, 30); |
| 1697 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1698 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1699 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::SurfaceFlingerScheduling); |
| 1700 | |
| 1701 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1702 | presentFence2->signalForTest(65); |
| 1703 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1704 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1705 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1706 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1707 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 1708 | |
| 1709 | EXPECT_CALL(*mTimeStats, |
| 1710 | incrementJankyFrames( |
| 1711 | TimeStats::JankyFramesInfo{Fps::fromPeriodNsecs(11), std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1712 | sLayerNameOne, sGameMode, |
| 1713 | JankType::PredictionError, -3, 5, 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1714 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1715 | addEmptyDisplayFrame(); |
| 1716 | |
| 1717 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1718 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1719 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1720 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1721 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1722 | |
| 1723 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1724 | EXPECT_EQ(actuals2.presentTime, 65); |
| 1725 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1726 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1727 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
| 1728 | } |
| 1729 | |
| 1730 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1731 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1732 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1733 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1734 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1735 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1736 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1737 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1738 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1739 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1740 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1741 | surfaceFrame1->setAcquireFenceTime(16); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1742 | mFrameTimeline->setSfWakeUp(sfToken1, 22, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1743 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1744 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1745 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1746 | auto displayFrame1 = getDisplayFrame(0); |
| 1747 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1748 | presentFence1->signalForTest(50); |
| 1749 | |
| 1750 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1751 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1752 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1753 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1754 | |
| 1755 | // Trigger a flush by finalizing the next DisplayFrame |
| 1756 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1757 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1758 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1759 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1760 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1761 | surfaceFrame2->setAcquireFenceTime(36); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1762 | mFrameTimeline->setSfWakeUp(sfToken2, 52, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1763 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1764 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1765 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1766 | auto displayFrame2 = getDisplayFrame(1); |
| 1767 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1768 | |
| 1769 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1770 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 1771 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1772 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1773 | EXPECT_EQ(displayFrame1->getJankType(), JankType::DisplayHAL); |
| 1774 | |
| 1775 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1776 | EXPECT_EQ(actuals1.presentTime, 50); |
| 1777 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1778 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1779 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::DisplayHAL); |
| 1780 | |
| 1781 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1782 | presentFence2->signalForTest(86); |
| 1783 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1784 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1785 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1786 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1787 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 1788 | |
| 1789 | EXPECT_CALL(*mTimeStats, |
| 1790 | incrementJankyFrames( |
| 1791 | TimeStats::JankyFramesInfo{Fps::fromPeriodNsecs(11), std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1792 | sLayerNameOne, sGameMode, |
| 1793 | JankType::PredictionError, -3, 5, 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1794 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1795 | addEmptyDisplayFrame(); |
| 1796 | |
| 1797 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1798 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 86); |
| 1799 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1800 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1801 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1802 | |
| 1803 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1804 | EXPECT_EQ(actuals2.presentTime, 86); |
| 1805 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1806 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1807 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
| 1808 | } |
| 1809 | |
| 1810 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1811 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1812 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1813 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1814 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1815 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 26, 60}); |
| 1816 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1817 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1818 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1819 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1820 | surfaceFrame1->setAcquireFenceTime(40); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1821 | mFrameTimeline->setSfWakeUp(sfToken1, 42, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1822 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1823 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1824 | mFrameTimeline->setSfPresent(46, presentFence1); |
| 1825 | auto displayFrame1 = getDisplayFrame(0); |
| 1826 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1827 | presentFence1->signalForTest(50); |
| 1828 | |
| 1829 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1830 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1831 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1832 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1833 | |
| 1834 | addEmptyDisplayFrame(); |
| 1835 | |
| 1836 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1837 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 1838 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1839 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1840 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1841 | |
| 1842 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1843 | EXPECT_EQ(actuals1.presentTime, 50); |
| 1844 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1845 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1846 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::Unknown); |
| 1847 | } |
| 1848 | |
| 1849 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishLatePresent) { |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 1850 | // First frame - DisplayFrame is not janky. This should classify the SurfaceFrame as only |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1851 | // AppDeadlineMissed. Second frame - DisplayFrame is janky. This should propagate DisplayFrame's |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 1852 | // jank to the SurfaceFrame along with AppDeadlineMissed. |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1853 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1854 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1855 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1856 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({32, 40, 40}); |
| 1857 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1858 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 1859 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 50}); |
| 1860 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1861 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1862 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1863 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1864 | surfaceFrame1->setAcquireFenceTime(26); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1865 | mFrameTimeline->setSfWakeUp(sfToken1, 32, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1866 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1867 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1868 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 1869 | auto displayFrame1 = getDisplayFrame(0); |
| 1870 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1871 | presentFence1->signalForTest(40); |
| 1872 | |
| 1873 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1874 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1875 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1876 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1877 | |
| 1878 | // Trigger a flush by finalizing the next DisplayFrame |
| 1879 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1880 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1881 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1882 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1883 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1884 | surfaceFrame2->setAcquireFenceTime(40); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1885 | mFrameTimeline->setSfWakeUp(sfToken2, 43, Fps::fromPeriodNsecs(11)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1886 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1887 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1888 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1889 | auto displayFrame2 = getDisplayFrame(1); |
| 1890 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1891 | |
| 1892 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1893 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 40); |
| 1894 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1895 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1896 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1897 | |
| 1898 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1899 | EXPECT_EQ(actuals1.presentTime, 40); |
| 1900 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1901 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1902 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 1903 | |
| 1904 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1905 | presentFence2->signalForTest(60); |
| 1906 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1907 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1908 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1909 | |
| 1910 | addEmptyDisplayFrame(); |
| 1911 | |
| 1912 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1913 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 60); |
| 1914 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1915 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1916 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
| 1917 | |
| 1918 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1919 | EXPECT_EQ(actuals2.presentTime, 60); |
| 1920 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1921 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 1922 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 1923 | JankType::SurfaceFlingerCpuDeadlineMissed | JankType::AppDeadlineMissed); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1924 | } |
| 1925 | |
| 1926 | TEST_F(FrameTimelineTest, jankClassification_multiJankBufferStuffingAndAppDeadlineMissed) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1927 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1928 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1929 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1930 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 1931 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 1932 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1933 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 1934 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1935 | auto surfaceFrame1 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1936 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1937 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1938 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1939 | surfaceFrame1->setAcquireFenceTime(50); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1940 | mFrameTimeline->setSfWakeUp(sfToken1, 52, Fps::fromPeriodNsecs(30)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1941 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1942 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1943 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 1944 | auto displayFrame1 = getDisplayFrame(0); |
| 1945 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1946 | presentFence1->signalForTest(60); |
| 1947 | |
| 1948 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1949 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1950 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1951 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1952 | |
| 1953 | // Trigger a flush by finalizing the next DisplayFrame |
| 1954 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1955 | auto surfaceFrame2 = |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1956 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1957 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1958 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1959 | surfaceFrame2->setAcquireFenceTime(84); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1960 | mFrameTimeline->setSfWakeUp(sfToken2, 112, Fps::fromPeriodNsecs(30)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1961 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 1962 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1963 | mFrameTimeline->setSfPresent(116, presentFence2); |
| 1964 | auto displayFrame2 = getDisplayFrame(1); |
| 1965 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1966 | presentFence2->signalForTest(120); |
| 1967 | |
| 1968 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1969 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 1970 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1971 | EXPECT_EQ(actuals1.endTime, 50); |
| 1972 | EXPECT_EQ(actuals1.presentTime, 60); |
| 1973 | |
| 1974 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1975 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1976 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 1977 | |
| 1978 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1979 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1980 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 1981 | |
| 1982 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1983 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1984 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1985 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1986 | |
| 1987 | addEmptyDisplayFrame(); |
| 1988 | |
| 1989 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1990 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 1991 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1992 | EXPECT_EQ(actuals2.presentTime, 120); |
| 1993 | |
| 1994 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1995 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1996 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
| 1997 | |
| 1998 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1999 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2000 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 2001 | JankType::AppDeadlineMissed | JankType::BufferStuffing); |
| 2002 | } |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2003 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2004 | TEST_F(FrameTimelineTest, jankClassification_appDeadlineAdjustedForBufferStuffing) { |
| 2005 | // Layer specific increment |
| 2006 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
| 2007 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2008 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2009 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 2010 | |
| 2011 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2012 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 2013 | auto surfaceFrame1 = |
| 2014 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken1, sInputEventId}, sPidOne, |
| 2015 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2016 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2017 | surfaceFrame1->setAcquireFenceTime(50); |
| 2018 | mFrameTimeline->setSfWakeUp(sfToken1, 52, Fps::fromPeriodNsecs(30)); |
| 2019 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2020 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2021 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 2022 | auto displayFrame1 = getDisplayFrame(0); |
| 2023 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2024 | presentFence1->signalForTest(60); |
| 2025 | |
| 2026 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2027 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2028 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2029 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2030 | |
| 2031 | // Trigger a flush by finalizing the next DisplayFrame |
| 2032 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2033 | auto surfaceFrame2 = |
| 2034 | mFrameTimeline->createSurfaceFrameForToken({surfaceFrameToken2, sInputEventId}, sPidOne, |
| 2035 | sUidOne, sLayerIdOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2036 | sLayerNameOne, /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2037 | surfaceFrame2->setAcquireFenceTime(80); |
| 2038 | mFrameTimeline->setSfWakeUp(sfToken2, 82, Fps::fromPeriodNsecs(30)); |
| 2039 | // Setting previous latch time to 54, adjusted deadline will be 54 + vsyncTime(30) = 84 |
| 2040 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2041 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2042 | mFrameTimeline->setSfPresent(86, presentFence2); |
| 2043 | auto displayFrame2 = getDisplayFrame(1); |
| 2044 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2045 | presentFence2->signalForTest(90); |
| 2046 | |
| 2047 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2048 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2049 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2050 | EXPECT_EQ(actuals1.endTime, 50); |
| 2051 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2052 | |
| 2053 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2054 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2055 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 2056 | |
| 2057 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2058 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2059 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 2060 | |
| 2061 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2062 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2063 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2064 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2065 | |
| 2066 | addEmptyDisplayFrame(); |
| 2067 | |
| 2068 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2069 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2070 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2071 | EXPECT_EQ(actuals2.presentTime, 90); |
| 2072 | |
| 2073 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2074 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2075 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
| 2076 | |
| 2077 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2078 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2079 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::BufferStuffing); |
| 2080 | } |
| 2081 | |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2082 | TEST_F(FrameTimelineTest, computeFps_noLayerIds_returnsZero) { |
| 2083 | EXPECT_EQ(mFrameTimeline->computeFps({}), 0.0f); |
| 2084 | } |
| 2085 | |
| 2086 | TEST_F(FrameTimelineTest, computeFps_singleDisplayFrame_returnsZero) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2087 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2088 | |
| 2089 | auto surfaceFrame1 = |
| 2090 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2091 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2092 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2093 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2094 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2095 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2096 | presentFence1->signalForTest(oneHundredMs); |
| 2097 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2098 | |
| 2099 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2100 | } |
| 2101 | |
| 2102 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_oneLayer) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2103 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2104 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2105 | auto surfaceFrame1 = |
| 2106 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2107 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2108 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2109 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2110 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2111 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2112 | presentFence1->signalForTest(oneHundredMs); |
| 2113 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2114 | |
| 2115 | auto surfaceFrame2 = |
| 2116 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2117 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2118 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2119 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2120 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2121 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2122 | presentFence2->signalForTest(twoHundredMs); |
| 2123 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2124 | |
| 2125 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 10.0); |
| 2126 | } |
| 2127 | |
| 2128 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_twoLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2129 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2130 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2131 | auto surfaceFrame1 = |
| 2132 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2133 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2134 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2135 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2136 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2137 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2138 | presentFence1->signalForTest(oneHundredMs); |
| 2139 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2140 | |
| 2141 | auto surfaceFrame2 = |
| 2142 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2143 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2144 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2145 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2146 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2147 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2148 | presentFence2->signalForTest(twoHundredMs); |
| 2149 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2150 | |
| 2151 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne, sLayerIdTwo}), 10.0f); |
| 2152 | } |
| 2153 | |
| 2154 | TEST_F(FrameTimelineTest, computeFps_filtersOutLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2155 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2156 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2157 | auto surfaceFrame1 = |
| 2158 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2159 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2160 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2161 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2162 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2163 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2164 | presentFence1->signalForTest(oneHundredMs); |
| 2165 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2166 | |
| 2167 | auto surfaceFrame2 = |
| 2168 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2169 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2170 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2171 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2172 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2173 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2174 | presentFence2->signalForTest(twoHundredMs); |
| 2175 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2176 | |
| 2177 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2178 | } |
| 2179 | |
| 2180 | TEST_F(FrameTimelineTest, computeFps_averagesOverMultipleFrames) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2181 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2182 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
| 2183 | const auto threeHundredMs = std::chrono::nanoseconds(300ms).count(); |
| 2184 | const auto fiveHundredMs = std::chrono::nanoseconds(500ms).count(); |
| 2185 | const auto sixHundredMs = std::chrono::nanoseconds(600ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2186 | auto surfaceFrame1 = |
| 2187 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2188 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2189 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2190 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2191 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2192 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2193 | presentFence1->signalForTest(oneHundredMs); |
| 2194 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2195 | |
| 2196 | auto surfaceFrame2 = |
| 2197 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2198 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2199 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2200 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2201 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2202 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2203 | presentFence2->signalForTest(twoHundredMs); |
| 2204 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2205 | |
| 2206 | auto surfaceFrame3 = |
| 2207 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2208 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2209 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2210 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2211 | surfaceFrame3->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2212 | mFrameTimeline->addSurfaceFrame(surfaceFrame3); |
| 2213 | presentFence3->signalForTest(threeHundredMs); |
| 2214 | mFrameTimeline->setSfPresent(threeHundredMs, presentFence3); |
| 2215 | |
| 2216 | auto surfaceFrame4 = |
| 2217 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2218 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2219 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2220 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2221 | surfaceFrame4->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2222 | mFrameTimeline->addSurfaceFrame(surfaceFrame4); |
| 2223 | presentFence4->signalForTest(fiveHundredMs); |
| 2224 | mFrameTimeline->setSfPresent(fiveHundredMs, presentFence4); |
| 2225 | |
| 2226 | auto surfaceFrame5 = |
| 2227 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2228 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2229 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2230 | auto presentFence5 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2231 | // Dropped frames will be excluded from fps computation |
| 2232 | surfaceFrame5->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 2233 | mFrameTimeline->addSurfaceFrame(surfaceFrame5); |
| 2234 | presentFence5->signalForTest(sixHundredMs); |
| 2235 | mFrameTimeline->setSfPresent(sixHundredMs, presentFence5); |
| 2236 | |
| 2237 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 5.0f); |
| 2238 | } |
| 2239 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 2240 | } // namespace android::frametimeline |