Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2021 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #undef LOG_TAG |
| 18 | #define LOG_TAG "LibSurfaceFlingerUnittests" |
| 19 | |
| 20 | #include <gmock/gmock.h> |
| 21 | #include <gtest/gtest.h> |
| 22 | #include <gui/SurfaceComposerClient.h> |
| 23 | #include <log/log.h> |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 24 | #include <renderengine/ExternalTexture.h> |
| 25 | #include <renderengine/mock/RenderEngine.h> |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 26 | #include <utils/String8.h> |
| 27 | |
| 28 | #include "TestableSurfaceFlinger.h" |
| 29 | #include "mock/DisplayHardware/MockComposer.h" |
| 30 | #include "mock/MockEventThread.h" |
| 31 | #include "mock/MockVsyncController.h" |
| 32 | |
| 33 | namespace android { |
| 34 | |
| 35 | using testing::_; |
| 36 | using testing::Mock; |
| 37 | using testing::Return; |
| 38 | using FakeHwcDisplayInjector = TestableSurfaceFlinger::FakeHwcDisplayInjector; |
| 39 | using PresentState = frametimeline::SurfaceFrame::PresentState; |
| 40 | |
| 41 | class TransactionSurfaceFrameTest : public testing::Test { |
| 42 | public: |
| 43 | TransactionSurfaceFrameTest() { |
| 44 | const ::testing::TestInfo* const test_info = |
| 45 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 46 | ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 47 | setupScheduler(); |
Dominik Laskowski | 1394860 | 2021-03-08 20:48:28 -0800 | [diff] [blame] | 48 | mFlinger.setupComposer(std::make_unique<Hwc2::mock::Composer>()); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 49 | } |
| 50 | |
| 51 | ~TransactionSurfaceFrameTest() { |
| 52 | const ::testing::TestInfo* const test_info = |
| 53 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 54 | ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 55 | } |
| 56 | |
| 57 | sp<BufferStateLayer> createBufferStateLayer() { |
| 58 | sp<Client> client; |
| 59 | LayerCreationArgs args(mFlinger.flinger(), client, "buffer-state-layer", 100, 100, 0, |
| 60 | LayerMetadata()); |
| 61 | return new BufferStateLayer(args); |
| 62 | } |
| 63 | |
| 64 | void commitTransaction(Layer* layer) { |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 65 | auto c = layer->getDrawingState(); |
Robert Carr | 0758e5d | 2021-03-11 22:15:04 -0800 | [diff] [blame] | 66 | layer->commitTransaction(c); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 67 | } |
| 68 | |
| 69 | void setupScheduler() { |
| 70 | auto eventThread = std::make_unique<mock::EventThread>(); |
| 71 | auto sfEventThread = std::make_unique<mock::EventThread>(); |
| 72 | |
| 73 | EXPECT_CALL(*eventThread, registerDisplayEventConnection(_)); |
| 74 | EXPECT_CALL(*eventThread, createEventConnection(_, _)) |
| 75 | .WillOnce(Return(new EventThreadConnection(eventThread.get(), /*callingUid=*/0, |
| 76 | ResyncCallback()))); |
| 77 | |
| 78 | EXPECT_CALL(*sfEventThread, registerDisplayEventConnection(_)); |
| 79 | EXPECT_CALL(*sfEventThread, createEventConnection(_, _)) |
| 80 | .WillOnce(Return(new EventThreadConnection(sfEventThread.get(), /*callingUid=*/0, |
| 81 | ResyncCallback()))); |
| 82 | |
| 83 | auto vsyncController = std::make_unique<mock::VsyncController>(); |
| 84 | auto vsyncTracker = std::make_unique<mock::VSyncTracker>(); |
| 85 | |
| 86 | EXPECT_CALL(*vsyncTracker, nextAnticipatedVSyncTimeFrom(_)).WillRepeatedly(Return(0)); |
| 87 | EXPECT_CALL(*vsyncTracker, currentPeriod()) |
| 88 | .WillRepeatedly(Return(FakeHwcDisplayInjector::DEFAULT_VSYNC_PERIOD)); |
| 89 | EXPECT_CALL(*vsyncTracker, nextAnticipatedVSyncTimeFrom(_)).WillRepeatedly(Return(0)); |
| 90 | mFlinger.setupScheduler(std::move(vsyncController), std::move(vsyncTracker), |
| 91 | std::move(eventThread), std::move(sfEventThread)); |
| 92 | } |
| 93 | |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 94 | TestableSurfaceFlinger mFlinger; |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 95 | renderengine::mock::RenderEngine mRenderEngine; |
Dominik Laskowski | 1394860 | 2021-03-08 20:48:28 -0800 | [diff] [blame] | 96 | |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 97 | FenceToFenceTimeMap fenceFactory; |
| 98 | client_cache_t mClientCache; |
| 99 | |
| 100 | void PresentedSurfaceFrameForBufferlessTransaction() { |
| 101 | sp<BufferStateLayer> layer = createBufferStateLayer(); |
| 102 | layer->setFrameTimelineVsyncForBufferlessTransaction({/*vsyncId*/ 1, /*inputEventId*/ 0}, |
| 103 | 10); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 104 | EXPECT_EQ(1u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 105 | ASSERT_TRUE(layer->mDrawingState.bufferSurfaceFrameTX == nullptr); |
| 106 | const auto surfaceFrame = layer->mDrawingState.bufferlessSurfaceFramesTX.at(/*token*/ 1); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 107 | commitTransaction(layer.get()); |
| 108 | EXPECT_EQ(1, surfaceFrame->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 109 | EXPECT_EQ(false, surfaceFrame->getIsBuffer()); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 110 | EXPECT_EQ(PresentState::Presented, surfaceFrame->getPresentState()); |
| 111 | } |
| 112 | |
| 113 | void PresentedSurfaceFrameForBufferTransaction() { |
| 114 | sp<BufferStateLayer> layer = createBufferStateLayer(); |
| 115 | sp<Fence> fence(new Fence()); |
| 116 | auto acquireFence = fenceFactory.createFenceTimeForTest(fence); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 117 | const auto buffer = std::make_shared< |
| 118 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 119 | 1, 0), |
| 120 | mRenderEngine, false); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 121 | layer->setBuffer(buffer, fence, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 122 | {/*vsyncId*/ 1, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 123 | nullptr /* releaseBufferEndpoint */); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 124 | acquireFence->signalForTest(12); |
| 125 | |
| 126 | commitTransaction(layer.get()); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 127 | EXPECT_EQ(0u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 128 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 129 | const auto surfaceFrame = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 130 | // Buffers are presented only at latch time. |
| 131 | EXPECT_EQ(PresentState::Unknown, surfaceFrame->getPresentState()); |
| 132 | |
| 133 | bool computeVisisbleRegions; |
| 134 | layer->updateTexImage(computeVisisbleRegions, 15, 0); |
| 135 | |
| 136 | EXPECT_EQ(1, surfaceFrame->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 137 | EXPECT_EQ(true, surfaceFrame->getIsBuffer()); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 138 | EXPECT_EQ(PresentState::Presented, surfaceFrame->getPresentState()); |
| 139 | } |
| 140 | |
| 141 | void DroppedSurfaceFrameForBufferTransaction() { |
| 142 | sp<BufferStateLayer> layer = createBufferStateLayer(); |
| 143 | |
| 144 | sp<Fence> fence1(new Fence()); |
| 145 | auto acquireFence1 = fenceFactory.createFenceTimeForTest(fence1); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 146 | const auto buffer1 = std::make_shared< |
| 147 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 148 | 1, 0), |
| 149 | mRenderEngine, false); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 150 | layer->setBuffer(buffer1, fence1, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 151 | {/*vsyncId*/ 1, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 152 | nullptr /* releaseBufferEndpoint */); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 153 | EXPECT_EQ(0u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 154 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 155 | const auto droppedSurfaceFrame = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 156 | |
| 157 | sp<Fence> fence2(new Fence()); |
| 158 | auto acquireFence2 = fenceFactory.createFenceTimeForTest(fence2); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 159 | const auto buffer2 = std::make_shared< |
| 160 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 161 | 1, 0), |
| 162 | mRenderEngine, false); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 163 | nsecs_t start = systemTime(); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 164 | layer->setBuffer(buffer2, fence2, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 165 | {/*vsyncId*/ 1, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 166 | nullptr /* releaseBufferEndpoint */); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 167 | nsecs_t end = systemTime(); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 168 | acquireFence2->signalForTest(12); |
| 169 | |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 170 | EXPECT_EQ(0u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 171 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 172 | const auto presentedSurfaceFrame = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 173 | |
| 174 | commitTransaction(layer.get()); |
| 175 | bool computeVisisbleRegions; |
| 176 | layer->updateTexImage(computeVisisbleRegions, 15, 0); |
| 177 | |
| 178 | EXPECT_EQ(1, droppedSurfaceFrame->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 179 | EXPECT_EQ(true, droppedSurfaceFrame->getIsBuffer()); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 180 | EXPECT_EQ(PresentState::Dropped, droppedSurfaceFrame->getPresentState()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 181 | EXPECT_EQ(0u, droppedSurfaceFrame->getActuals().endTime); |
| 182 | auto dropTime = droppedSurfaceFrame->getDropTime(); |
| 183 | EXPECT_TRUE(dropTime > start && dropTime < end); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 184 | |
| 185 | EXPECT_EQ(1, presentedSurfaceFrame->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 186 | EXPECT_EQ(true, presentedSurfaceFrame->getIsBuffer()); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 187 | EXPECT_EQ(PresentState::Presented, presentedSurfaceFrame->getPresentState()); |
| 188 | } |
| 189 | |
| 190 | void BufferlessSurfaceFramePromotedToBufferSurfaceFrame() { |
| 191 | sp<BufferStateLayer> layer = createBufferStateLayer(); |
| 192 | |
| 193 | layer->setFrameTimelineVsyncForBufferlessTransaction({/*vsyncId*/ 1, /*inputEventId*/ 0}, |
| 194 | 10); |
| 195 | |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 196 | EXPECT_EQ(1u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 197 | ASSERT_EQ(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 198 | |
| 199 | sp<Fence> fence(new Fence()); |
| 200 | auto acquireFence = fenceFactory.createFenceTimeForTest(fence); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 201 | const auto buffer = std::make_shared< |
| 202 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 203 | 1, 0), |
| 204 | mRenderEngine, false); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 205 | layer->setBuffer(buffer, fence, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 206 | {/*vsyncId*/ 1, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 207 | nullptr /* releaseBufferEndpoint */); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 208 | acquireFence->signalForTest(12); |
| 209 | |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 210 | EXPECT_EQ(0u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 211 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 212 | const auto surfaceFrame = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 213 | |
| 214 | commitTransaction(layer.get()); |
| 215 | EXPECT_EQ(1, surfaceFrame->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 216 | EXPECT_EQ(true, surfaceFrame->getIsBuffer()); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 217 | // Buffers are presented only at latch time. |
| 218 | EXPECT_EQ(PresentState::Unknown, surfaceFrame->getPresentState()); |
| 219 | |
| 220 | bool computeVisisbleRegions; |
| 221 | layer->updateTexImage(computeVisisbleRegions, 15, 0); |
| 222 | |
| 223 | EXPECT_EQ(PresentState::Presented, surfaceFrame->getPresentState()); |
| 224 | } |
| 225 | |
| 226 | void BufferlessSurfaceFrameNotCreatedIfBufferSufaceFrameExists() { |
| 227 | sp<BufferStateLayer> layer = createBufferStateLayer(); |
| 228 | sp<Fence> fence(new Fence()); |
| 229 | auto acquireFence = fenceFactory.createFenceTimeForTest(fence); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 230 | const auto buffer = std::make_shared< |
| 231 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 232 | 1, 0), |
| 233 | mRenderEngine, false); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 234 | layer->setBuffer(buffer, fence, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 235 | {/*vsyncId*/ 1, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 236 | nullptr /* releaseBufferEndpoint */); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 237 | EXPECT_EQ(0u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 238 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 239 | |
| 240 | layer->setFrameTimelineVsyncForBufferlessTransaction({/*vsyncId*/ 1, /*inputEventId*/ 0}, |
| 241 | 10); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 242 | EXPECT_EQ(0u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 243 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 244 | } |
| 245 | |
| 246 | void MultipleSurfaceFramesPresentedTogether() { |
| 247 | sp<BufferStateLayer> layer = createBufferStateLayer(); |
| 248 | layer->setFrameTimelineVsyncForBufferlessTransaction({/*vsyncId*/ 1, /*inputEventId*/ 0}, |
| 249 | 10); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 250 | EXPECT_EQ(1u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 251 | ASSERT_EQ(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 252 | const auto bufferlessSurfaceFrame1 = |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 253 | layer->mDrawingState.bufferlessSurfaceFramesTX.at(/*token*/ 1); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 254 | |
| 255 | layer->setFrameTimelineVsyncForBufferlessTransaction({/*vsyncId*/ 4, /*inputEventId*/ 0}, |
| 256 | 10); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 257 | EXPECT_EQ(2u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 258 | ASSERT_EQ(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 259 | const auto bufferlessSurfaceFrame2 = layer->mDrawingState.bufferlessSurfaceFramesTX[4]; |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 260 | |
| 261 | sp<Fence> fence(new Fence()); |
| 262 | auto acquireFence = fenceFactory.createFenceTimeForTest(fence); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 263 | const auto buffer = std::make_shared< |
| 264 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 265 | 1, 0), |
| 266 | mRenderEngine, false); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 267 | layer->setBuffer(buffer, fence, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 268 | {/*vsyncId*/ 3, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 269 | nullptr /* releaseBufferEndpoint */); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 270 | EXPECT_EQ(2u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 271 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 272 | const auto bufferSurfaceFrameTX = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 273 | |
| 274 | acquireFence->signalForTest(12); |
| 275 | |
| 276 | commitTransaction(layer.get()); |
| 277 | |
| 278 | EXPECT_EQ(1, bufferlessSurfaceFrame1->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 279 | EXPECT_EQ(false, bufferlessSurfaceFrame1->getIsBuffer()); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 280 | EXPECT_EQ(PresentState::Presented, bufferlessSurfaceFrame1->getPresentState()); |
| 281 | |
| 282 | EXPECT_EQ(4, bufferlessSurfaceFrame2->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 283 | EXPECT_EQ(false, bufferlessSurfaceFrame2->getIsBuffer()); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 284 | EXPECT_EQ(PresentState::Presented, bufferlessSurfaceFrame2->getPresentState()); |
| 285 | |
| 286 | EXPECT_EQ(3, bufferSurfaceFrameTX->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 287 | EXPECT_EQ(true, bufferSurfaceFrameTX->getIsBuffer()); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 288 | // Buffers are presented only at latch time. |
| 289 | EXPECT_EQ(PresentState::Unknown, bufferSurfaceFrameTX->getPresentState()); |
| 290 | |
| 291 | bool computeVisisbleRegions; |
| 292 | layer->updateTexImage(computeVisisbleRegions, 15, 0); |
| 293 | |
| 294 | EXPECT_EQ(PresentState::Presented, bufferSurfaceFrameTX->getPresentState()); |
| 295 | } |
| 296 | |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 297 | void PendingSurfaceFramesRemovedAfterClassification() { |
| 298 | sp<BufferStateLayer> layer = createBufferStateLayer(); |
| 299 | |
| 300 | sp<Fence> fence1(new Fence()); |
| 301 | auto acquireFence1 = fenceFactory.createFenceTimeForTest(fence1); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 302 | const auto buffer1 = std::make_shared< |
| 303 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 304 | 1, 0), |
| 305 | mRenderEngine, false); |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 306 | layer->setBuffer(buffer1, fence1, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 307 | {/*vsyncId*/ 1, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 308 | nullptr /* releaseBufferEndpoint */); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 309 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 310 | const auto droppedSurfaceFrame = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 311 | |
| 312 | sp<Fence> fence2(new Fence()); |
| 313 | auto acquireFence2 = fenceFactory.createFenceTimeForTest(fence2); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 314 | const auto buffer2 = std::make_shared< |
| 315 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 316 | 1, 0), |
| 317 | mRenderEngine, false); |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 318 | layer->setBuffer(buffer2, fence2, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 319 | {/*vsyncId*/ 1, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 320 | nullptr /* releaseBufferEndpoint */); |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 321 | acquireFence2->signalForTest(12); |
| 322 | |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 323 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 324 | auto presentedSurfaceFrame = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 325 | |
| 326 | commitTransaction(layer.get()); |
| 327 | bool computeVisisbleRegions; |
| 328 | layer->updateTexImage(computeVisisbleRegions, 15, 0); |
| 329 | |
| 330 | // Both the droppedSurfaceFrame and presentedSurfaceFrame should be in |
| 331 | // pendingJankClassifications. |
| 332 | EXPECT_EQ(2u, layer->mPendingJankClassifications.size()); |
| 333 | presentedSurfaceFrame->onPresent(20, JankType::None, Fps::fromPeriodNsecs(11), |
| 334 | /*displayDeadlineDelta*/ 0, /*displayPresentDelta*/ 0); |
| 335 | layer->releasePendingBuffer(25); |
| 336 | |
| 337 | EXPECT_EQ(0u, layer->mPendingJankClassifications.size()); |
| 338 | } |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 339 | |
| 340 | void BufferSurfaceFrame_ReplaceValidTokenBufferWithInvalidTokenBuffer() { |
| 341 | sp<BufferStateLayer> layer = createBufferStateLayer(); |
| 342 | |
| 343 | sp<Fence> fence1(new Fence()); |
| 344 | auto acquireFence1 = fenceFactory.createFenceTimeForTest(fence1); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 345 | const auto buffer1 = std::make_shared< |
| 346 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 347 | 1, 0), |
| 348 | mRenderEngine, false); |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 349 | layer->setBuffer(buffer1, fence1, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 350 | {/*vsyncId*/ 1, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 351 | nullptr /* releaseBufferEndpoint */); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 352 | EXPECT_EQ(0u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 353 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 354 | const auto droppedSurfaceFrame1 = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 355 | |
| 356 | sp<Fence> fence2(new Fence()); |
| 357 | auto acquireFence2 = fenceFactory.createFenceTimeForTest(fence2); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 358 | const auto buffer2 = std::make_shared< |
| 359 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 360 | 1, 0), |
| 361 | mRenderEngine, false); |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 362 | auto dropStartTime1 = systemTime(); |
| 363 | layer->setBuffer(buffer2, fence2, 10, 20, false, mClientCache, 1, std::nullopt, |
Vishnu Nair | 1506b18 | 2021-02-22 14:35:15 -0800 | [diff] [blame] | 364 | {/*vsyncId*/ FrameTimelineInfo::INVALID_VSYNC_ID, /*inputEventId*/ 0}, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 365 | nullptr /* releaseBufferCallback */, nullptr /* releaseBufferEndpoint */); |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 366 | auto dropEndTime1 = systemTime(); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 367 | EXPECT_EQ(0u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 368 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 369 | const auto droppedSurfaceFrame2 = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 370 | |
| 371 | sp<Fence> fence3(new Fence()); |
| 372 | auto acquireFence3 = fenceFactory.createFenceTimeForTest(fence3); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 373 | const auto buffer3 = std::make_shared< |
| 374 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, HAL_PIXEL_FORMAT_RGBA_8888, |
| 375 | 1, 0), |
| 376 | mRenderEngine, false); |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 377 | auto dropStartTime2 = systemTime(); |
| 378 | layer->setBuffer(buffer3, fence3, 10, 20, false, mClientCache, 1, std::nullopt, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 379 | {/*vsyncId*/ 2, /*inputEventId*/ 0}, nullptr /* releaseBufferCallback */, |
| 380 | nullptr /* releaseBufferEndpoint */); |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 381 | auto dropEndTime2 = systemTime(); |
| 382 | acquireFence3->signalForTest(12); |
| 383 | |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 384 | EXPECT_EQ(0u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
| 385 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 386 | const auto presentedSurfaceFrame = layer->mDrawingState.bufferSurfaceFrameTX; |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 387 | |
| 388 | commitTransaction(layer.get()); |
| 389 | bool computeVisisbleRegions; |
| 390 | layer->updateTexImage(computeVisisbleRegions, 15, 0); |
| 391 | |
| 392 | EXPECT_EQ(1, droppedSurfaceFrame1->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 393 | EXPECT_EQ(true, droppedSurfaceFrame1->getIsBuffer()); |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 394 | EXPECT_EQ(PresentState::Dropped, droppedSurfaceFrame1->getPresentState()); |
| 395 | EXPECT_EQ(0u, droppedSurfaceFrame1->getActuals().endTime); |
| 396 | auto dropTime1 = droppedSurfaceFrame1->getDropTime(); |
| 397 | EXPECT_TRUE(dropTime1 > dropStartTime1 && dropTime1 < dropEndTime1); |
| 398 | |
| 399 | EXPECT_EQ(FrameTimelineInfo::INVALID_VSYNC_ID, droppedSurfaceFrame2->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 400 | EXPECT_EQ(true, droppedSurfaceFrame2->getIsBuffer()); |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 401 | EXPECT_EQ(PresentState::Dropped, droppedSurfaceFrame2->getPresentState()); |
| 402 | EXPECT_EQ(0u, droppedSurfaceFrame2->getActuals().endTime); |
| 403 | auto dropTime2 = droppedSurfaceFrame2->getDropTime(); |
| 404 | EXPECT_TRUE(dropTime2 > dropStartTime2 && dropTime2 < dropEndTime2); |
| 405 | |
| 406 | EXPECT_EQ(2, presentedSurfaceFrame->getToken()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 407 | EXPECT_EQ(true, presentedSurfaceFrame->getIsBuffer()); |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 408 | EXPECT_EQ(PresentState::Presented, presentedSurfaceFrame->getPresentState()); |
| 409 | } |
Adithya Srinivasan | d11eb6b | 2021-03-09 18:46:28 +0000 | [diff] [blame] | 410 | |
| 411 | void MultipleCommitsBeforeLatch() { |
| 412 | sp<BufferStateLayer> layer = createBufferStateLayer(); |
| 413 | uint32_t surfaceFramesPendingClassification = 0; |
| 414 | std::vector<std::shared_ptr<frametimeline::SurfaceFrame>> bufferlessSurfaceFrames; |
| 415 | for (int i = 0; i < 10; i += 2) { |
| 416 | sp<Fence> fence1(new Fence()); |
Alec Mouri | a90a570 | 2021-04-16 16:36:21 +0000 | [diff] [blame] | 417 | const auto buffer1 = std::make_shared< |
| 418 | renderengine::ExternalTexture>(new GraphicBuffer(1, 1, |
| 419 | HAL_PIXEL_FORMAT_RGBA_8888, 1, |
| 420 | 0), |
| 421 | mRenderEngine, false); |
Adithya Srinivasan | d11eb6b | 2021-03-09 18:46:28 +0000 | [diff] [blame] | 422 | layer->setBuffer(buffer1, fence1, 10, 20, false, mClientCache, 1, std::nullopt, |
Vishnu Nair | 1506b18 | 2021-02-22 14:35:15 -0800 | [diff] [blame] | 423 | {/*vsyncId*/ 1, /*inputEventId*/ 0}, |
chaviw | 0b06a8d | 2021-08-06 11:49:08 -0500 | [diff] [blame^] | 424 | nullptr /* releaseBufferCallback */, |
| 425 | nullptr /* releaseBufferEndpoint */); |
Adithya Srinivasan | d11eb6b | 2021-03-09 18:46:28 +0000 | [diff] [blame] | 426 | layer->setFrameTimelineVsyncForBufferlessTransaction({/*vsyncId*/ 2, |
| 427 | /*inputEventId*/ 0}, |
| 428 | 10); |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 429 | ASSERT_NE(nullptr, layer->mDrawingState.bufferSurfaceFrameTX); |
| 430 | EXPECT_EQ(1u, layer->mDrawingState.bufferlessSurfaceFramesTX.size()); |
Adithya Srinivasan | d11eb6b | 2021-03-09 18:46:28 +0000 | [diff] [blame] | 431 | auto& bufferlessSurfaceFrame = |
Robert Carr | 6a16031 | 2021-05-17 12:08:20 -0700 | [diff] [blame] | 432 | layer->mDrawingState.bufferlessSurfaceFramesTX.at(/*vsyncId*/ 2); |
Adithya Srinivasan | d11eb6b | 2021-03-09 18:46:28 +0000 | [diff] [blame] | 433 | bufferlessSurfaceFrames.push_back(bufferlessSurfaceFrame); |
| 434 | |
| 435 | commitTransaction(layer.get()); |
| 436 | surfaceFramesPendingClassification += 2; |
| 437 | EXPECT_EQ(surfaceFramesPendingClassification, |
| 438 | layer->mPendingJankClassifications.size()); |
| 439 | } |
| 440 | |
| 441 | auto presentedBufferSurfaceFrame = layer->mDrawingState.bufferSurfaceFrameTX; |
| 442 | bool computeVisisbleRegions; |
| 443 | layer->updateTexImage(computeVisisbleRegions, 15, 0); |
| 444 | // BufferlessSurfaceFrames are immediately set to presented and added to the DisplayFrame. |
| 445 | // Since we don't have access to DisplayFrame here, trigger an onPresent directly. |
| 446 | for (auto& surfaceFrame : bufferlessSurfaceFrames) { |
| 447 | surfaceFrame->onPresent(20, JankType::None, Fps::fromPeriodNsecs(11), |
| 448 | /*displayDeadlineDelta*/ 0, /*displayPresentDelta*/ 0); |
| 449 | } |
| 450 | presentedBufferSurfaceFrame->onPresent(20, JankType::None, Fps::fromPeriodNsecs(11), |
| 451 | /*displayDeadlineDelta*/ 0, |
| 452 | /*displayPresentDelta*/ 0); |
| 453 | |
| 454 | // There should be 10 bufferlessSurfaceFrames and 1 bufferSurfaceFrame |
| 455 | ASSERT_EQ(10u, surfaceFramesPendingClassification); |
| 456 | ASSERT_EQ(surfaceFramesPendingClassification, layer->mPendingJankClassifications.size()); |
| 457 | |
| 458 | // For the frames upto 8, the bufferSurfaceFrame should have been dropped while the |
| 459 | // bufferlessSurfaceFrame presented |
| 460 | for (uint32_t i = 0; i < 8; i += 2) { |
| 461 | auto& bufferSurfaceFrame = layer->mPendingJankClassifications[i]; |
| 462 | auto& bufferlessSurfaceFrame = layer->mPendingJankClassifications[i + 1]; |
| 463 | EXPECT_EQ(bufferSurfaceFrame->getPresentState(), PresentState::Dropped); |
| 464 | EXPECT_EQ(bufferlessSurfaceFrame->getPresentState(), PresentState::Presented); |
| 465 | } |
| 466 | { |
| 467 | auto& bufferSurfaceFrame = layer->mPendingJankClassifications[8u]; |
| 468 | auto& bufferlessSurfaceFrame = layer->mPendingJankClassifications[9u]; |
| 469 | EXPECT_EQ(bufferSurfaceFrame->getPresentState(), PresentState::Presented); |
| 470 | EXPECT_EQ(bufferlessSurfaceFrame->getPresentState(), PresentState::Presented); |
| 471 | } |
| 472 | |
| 473 | layer->releasePendingBuffer(25); |
| 474 | |
| 475 | // There shouldn't be any pending classifications. Everything should have been cleared. |
| 476 | EXPECT_EQ(0u, layer->mPendingJankClassifications.size()); |
| 477 | } |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 478 | }; |
| 479 | |
| 480 | TEST_F(TransactionSurfaceFrameTest, PresentedBufferlessSurfaceFrame) { |
| 481 | PresentedSurfaceFrameForBufferlessTransaction(); |
| 482 | } |
| 483 | |
| 484 | TEST_F(TransactionSurfaceFrameTest, PresentedBufferSurfaceFrame) { |
| 485 | PresentedSurfaceFrameForBufferTransaction(); |
| 486 | } |
| 487 | |
| 488 | TEST_F(TransactionSurfaceFrameTest, DroppedBufferSurfaceFrame) { |
| 489 | DroppedSurfaceFrameForBufferTransaction(); |
| 490 | } |
| 491 | |
| 492 | TEST_F(TransactionSurfaceFrameTest, BufferlessSurfaceFramePromotedToBufferSurfaceFrame) { |
| 493 | BufferlessSurfaceFramePromotedToBufferSurfaceFrame(); |
| 494 | } |
| 495 | |
| 496 | TEST_F(TransactionSurfaceFrameTest, BufferlessSurfaceFrameNotCreatedIfBufferSufaceFrameExists) { |
| 497 | BufferlessSurfaceFrameNotCreatedIfBufferSufaceFrameExists(); |
| 498 | } |
| 499 | |
| 500 | TEST_F(TransactionSurfaceFrameTest, MultipleSurfaceFramesPresentedTogether) { |
| 501 | MultipleSurfaceFramesPresentedTogether(); |
| 502 | } |
| 503 | |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 504 | TEST_F(TransactionSurfaceFrameTest, PendingSurfaceFramesRemovedAfterClassification) { |
| 505 | PendingSurfaceFramesRemovedAfterClassification(); |
| 506 | } |
Adithya Srinivasan | 891004e | 2021-02-12 20:20:47 +0000 | [diff] [blame] | 507 | |
| 508 | TEST_F(TransactionSurfaceFrameTest, |
| 509 | BufferSurfaceFrame_ReplaceValidTokenBufferWithInvalidTokenBuffer) { |
| 510 | BufferSurfaceFrame_ReplaceValidTokenBufferWithInvalidTokenBuffer(); |
| 511 | } |
| 512 | |
Adithya Srinivasan | d11eb6b | 2021-03-09 18:46:28 +0000 | [diff] [blame] | 513 | TEST_F(TransactionSurfaceFrameTest, MultipleCommitsBeforeLatch) { |
| 514 | MultipleCommitsBeforeLatch(); |
| 515 | } |
| 516 | |
Robert Carr | 0758e5d | 2021-03-11 22:15:04 -0800 | [diff] [blame] | 517 | } // namespace android |