Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 17 | #include "Link.h" |
| 18 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 19 | #include <sys/stat.h> |
| 20 | |
Mohamed Heikal | d3c5fb6 | 2018-01-12 11:37:26 -0500 | [diff] [blame] | 21 | #include <algorithm> |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 22 | #include <cinttypes> |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 23 | #include <queue> |
| 24 | #include <unordered_map> |
| 25 | #include <vector> |
| 26 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 27 | #include "AppInfo.h" |
| 28 | #include "Debug.h" |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 29 | #include "LoadedApk.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 30 | #include "NameMangler.h" |
Adam Lesinski | 59e04c6 | 2016-02-04 15:59:23 -0800 | [diff] [blame] | 31 | #include "ResourceUtils.h" |
Adam Lesinski | d3ffa844 | 2017-09-28 13:34:35 -0700 | [diff] [blame] | 32 | #include "ResourceValues.h" |
| 33 | #include "ValueVisitor.h" |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 34 | #include "android-base/errors.h" |
| 35 | #include "android-base/expected.h" |
| 36 | #include "android-base/file.h" |
| 37 | #include "android-base/stringprintf.h" |
| 38 | #include "androidfw/IDiagnostics.h" |
| 39 | #include "androidfw/Locale.h" |
| 40 | #include "androidfw/StringPiece.h" |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 41 | #include "cmd/Util.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 42 | #include "compile/IdAssigner.h" |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 43 | #include "compile/XmlIdCollector.h" |
Adam Lesinski | 6a00817 | 2016-02-02 17:02:58 -0800 | [diff] [blame] | 44 | #include "filter/ConfigFilter.h" |
Adam Lesinski | 4670805 | 2017-09-29 14:49:15 -0700 | [diff] [blame] | 45 | #include "format/Archive.h" |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 46 | #include "format/Container.h" |
Adam Lesinski | 4670805 | 2017-09-29 14:49:15 -0700 | [diff] [blame] | 47 | #include "format/binary/TableFlattener.h" |
| 48 | #include "format/binary/XmlFlattener.h" |
| 49 | #include "format/proto/ProtoDeserialize.h" |
| 50 | #include "format/proto/ProtoSerialize.h" |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 51 | #include "io/BigBufferStream.h" |
| 52 | #include "io/FileStream.h" |
Adam Lesinski | a40e972 | 2015-11-24 19:11:46 -0800 | [diff] [blame] | 53 | #include "io/FileSystem.h" |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 54 | #include "io/Util.h" |
Adam Lesinski | a40e972 | 2015-11-24 19:11:46 -0800 | [diff] [blame] | 55 | #include "io/ZipArchive.h" |
Adam Lesinski | ca5638f | 2015-10-21 14:42:43 -0700 | [diff] [blame] | 56 | #include "java/JavaClassGenerator.h" |
| 57 | #include "java/ManifestClassGenerator.h" |
| 58 | #include "java/ProguardRules.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 59 | #include "link/Linkers.h" |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 60 | #include "link/ManifestFixer.h" |
Adam Lesinski | 34a1687 | 2018-02-23 16:18:10 -0800 | [diff] [blame] | 61 | #include "link/NoDefaultResourceRemover.h" |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 62 | #include "link/ReferenceLinker.h" |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 63 | #include "link/ResourceExcluder.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 64 | #include "link/TableMerger.h" |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 65 | #include "link/XmlCompatVersioner.h" |
Adam Lesinski | d48944a | 2017-02-21 14:22:30 -0800 | [diff] [blame] | 66 | #include "optimize/ResourceDeduper.h" |
| 67 | #include "optimize/VersionCollapser.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 68 | #include "process/IResourceTableConsumer.h" |
| 69 | #include "process/SymbolTable.h" |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 70 | #include "split/TableSplitter.h" |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 71 | #include "trace/TraceBuffer.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 72 | #include "util/Files.h" |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 73 | #include "xml/XmlDom.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 74 | |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 75 | using ::aapt::io::FileInputStream; |
MÃ¥rten Kongstad | 24c9aa6 | 2018-06-20 08:46:41 +0200 | [diff] [blame] | 76 | using ::android::ConfigDescription; |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 77 | using ::android::StringPiece; |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 78 | using ::android::base::expected; |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 79 | using ::android::base::StringPrintf; |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 80 | using ::android::base::unexpected; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 81 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 82 | namespace aapt { |
| 83 | |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 84 | namespace { |
| 85 | |
| 86 | expected<ResourceTablePackage*, const char*> GetStaticLibraryPackage(ResourceTable* table) { |
| 87 | // Resource tables built by aapt2 always contain one package. This is a post condition of |
| 88 | // VerifyNoExternalPackages. |
| 89 | if (table->packages.size() != 1u) { |
| 90 | return unexpected("static library contains more than one package"); |
| 91 | } |
| 92 | return table->packages.back().get(); |
| 93 | } |
| 94 | |
| 95 | } // namespace |
| 96 | |
Ryan Mitchell | 22dc531 | 2020-06-01 12:17:07 -0700 | [diff] [blame] | 97 | constexpr uint8_t kAndroidPackageId = 0x01; |
| 98 | |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 99 | class LinkContext : public IAaptContext { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 100 | public: |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 101 | explicit LinkContext(android::IDiagnostics* diagnostics) |
Chris Warrington | 820d72a | 2017-04-27 15:27:01 +0100 | [diff] [blame] | 102 | : diagnostics_(diagnostics), name_mangler_({}), symbols_(&name_mangler_) { |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 103 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 104 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 105 | PackageType GetPackageType() override { |
| 106 | return package_type_; |
| 107 | } |
| 108 | |
| 109 | void SetPackageType(PackageType type) { |
| 110 | package_type_ = type; |
| 111 | } |
| 112 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 113 | android::IDiagnostics* GetDiagnostics() override { |
Chris Warrington | 820d72a | 2017-04-27 15:27:01 +0100 | [diff] [blame] | 114 | return diagnostics_; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 115 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 116 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 117 | NameMangler* GetNameMangler() override { |
| 118 | return &name_mangler_; |
| 119 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 120 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 121 | void SetNameManglerPolicy(const NameManglerPolicy& policy) { |
| 122 | name_mangler_ = NameMangler(policy); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 123 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 124 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 125 | const std::string& GetCompilationPackage() override { |
| 126 | return compilation_package_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 127 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 128 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 129 | void SetCompilationPackage(const StringPiece& package_name) { |
Adam Lesinski | d5083f6 | 2017-01-16 15:07:21 -0800 | [diff] [blame] | 130 | compilation_package_ = package_name.to_string(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 131 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 132 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 133 | uint8_t GetPackageId() override { |
| 134 | return package_id_; |
| 135 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 136 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 137 | void SetPackageId(uint8_t id) { |
| 138 | package_id_ = id; |
| 139 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 140 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 141 | SymbolTable* GetExternalSymbols() override { |
| 142 | return &symbols_; |
| 143 | } |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 144 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 145 | bool IsVerbose() override { |
| 146 | return verbose_; |
| 147 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 148 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 149 | void SetVerbose(bool val) { |
| 150 | verbose_ = val; |
| 151 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 152 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 153 | int GetMinSdkVersion() override { |
| 154 | return min_sdk_version_; |
| 155 | } |
Adam Lesinski | fb6312f | 2016-06-28 14:40:32 -0700 | [diff] [blame] | 156 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 157 | void SetMinSdkVersion(int minSdk) { |
| 158 | min_sdk_version_ = minSdk; |
| 159 | } |
Adam Lesinski | fb6312f | 2016-06-28 14:40:32 -0700 | [diff] [blame] | 160 | |
Udam Saini | b228df3 | 2019-06-18 16:50:34 -0700 | [diff] [blame] | 161 | const std::set<std::string>& GetSplitNameDependencies() override { |
| 162 | return split_name_dependencies_; |
| 163 | } |
| 164 | |
| 165 | void SetSplitNameDependencies(const std::set<std::string>& split_name_dependencies) { |
| 166 | split_name_dependencies_ = split_name_dependencies; |
| 167 | } |
| 168 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 169 | private: |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 170 | DISALLOW_COPY_AND_ASSIGN(LinkContext); |
| 171 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 172 | PackageType package_type_ = PackageType::kApp; |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 173 | android::IDiagnostics* diagnostics_; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 174 | NameMangler name_mangler_; |
| 175 | std::string compilation_package_; |
| 176 | uint8_t package_id_ = 0x0; |
| 177 | SymbolTable symbols_; |
| 178 | bool verbose_ = false; |
| 179 | int min_sdk_version_ = 0; |
Udam Saini | b228df3 | 2019-06-18 16:50:34 -0700 | [diff] [blame] | 180 | std::set<std::string> split_name_dependencies_; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 181 | }; |
| 182 | |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 183 | // A custom delegate that generates compatible pre-O IDs for use with feature splits. |
| 184 | // Feature splits use package IDs > 7f, which in Java (since Java doesn't have unsigned ints) |
| 185 | // is interpreted as a negative number. Some verification was wrongly assuming negative values |
| 186 | // were invalid. |
| 187 | // |
| 188 | // This delegate will attempt to masquerade any '@id/' references with ID 0xPPTTEEEE, |
| 189 | // where PP > 7f, as 0x7fPPEEEE. Any potential overlapping is verified and an error occurs if such |
| 190 | // an overlap exists. |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 191 | // |
| 192 | // See b/37498913. |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 193 | class FeatureSplitSymbolTableDelegate : public DefaultSymbolTableDelegate { |
| 194 | public: |
Chih-Hung Hsieh | 1fc78e1 | 2018-12-20 13:37:44 -0800 | [diff] [blame] | 195 | explicit FeatureSplitSymbolTableDelegate(IAaptContext* context) : context_(context) { |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 196 | } |
| 197 | |
| 198 | virtual ~FeatureSplitSymbolTableDelegate() = default; |
| 199 | |
| 200 | virtual std::unique_ptr<SymbolTable::Symbol> FindByName( |
| 201 | const ResourceName& name, |
| 202 | const std::vector<std::unique_ptr<ISymbolSource>>& sources) override { |
| 203 | std::unique_ptr<SymbolTable::Symbol> symbol = |
| 204 | DefaultSymbolTableDelegate::FindByName(name, sources); |
| 205 | if (symbol == nullptr) { |
| 206 | return {}; |
| 207 | } |
| 208 | |
| 209 | // Check to see if this is an 'id' with the target package. |
Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 210 | if (name.type.type == ResourceType::kId && symbol->id) { |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 211 | ResourceId* id = &symbol->id.value(); |
| 212 | if (id->package_id() > kAppPackageId) { |
| 213 | // Rewrite the resource ID to be compatible pre-O. |
| 214 | ResourceId rewritten_id(kAppPackageId, id->package_id(), id->entry_id()); |
| 215 | |
| 216 | // Check that this doesn't overlap another resource. |
| 217 | if (DefaultSymbolTableDelegate::FindById(rewritten_id, sources) != nullptr) { |
| 218 | // The ID overlaps, so log a message (since this is a weird failure) and fail. |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 219 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 220 | << "Failed to rewrite " << name |
| 221 | << " for pre-O feature split support"); |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 222 | return {}; |
| 223 | } |
| 224 | |
| 225 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 226 | context_->GetDiagnostics()->Note(android::DiagMessage() |
| 227 | << "rewriting " << name << " (" << *id << ") -> (" |
| 228 | << rewritten_id << ")"); |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 229 | } |
| 230 | |
| 231 | *id = rewritten_id; |
| 232 | } |
| 233 | } |
| 234 | return symbol; |
| 235 | } |
| 236 | |
| 237 | private: |
| 238 | DISALLOW_COPY_AND_ASSIGN(FeatureSplitSymbolTableDelegate); |
| 239 | |
| 240 | IAaptContext* context_; |
| 241 | }; |
| 242 | |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 243 | static bool FlattenXml(IAaptContext* context, const xml::XmlResource& xml_res, |
| 244 | const StringPiece& path, bool keep_raw_values, bool utf16, |
| 245 | OutputFormat format, IArchiveWriter* writer) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 246 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 247 | if (context->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 248 | context->GetDiagnostics()->Note(android::DiagMessage(path) |
| 249 | << "writing to archive (keep_raw_values=" |
| 250 | << (keep_raw_values ? "true" : "false") << ")"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 251 | } |
| 252 | |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 253 | switch (format) { |
| 254 | case OutputFormat::kApk: { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 255 | android::BigBuffer buffer(1024); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 256 | XmlFlattenerOptions options = {}; |
| 257 | options.keep_raw_values = keep_raw_values; |
| 258 | options.use_utf16 = utf16; |
| 259 | XmlFlattener flattener(&buffer, options); |
| 260 | if (!flattener.Consume(context, &xml_res)) { |
| 261 | return false; |
| 262 | } |
| 263 | |
| 264 | io::BigBufferInputStream input_stream(&buffer); |
| 265 | return io::CopyInputStreamToArchive(context, &input_stream, path.to_string(), |
| 266 | ArchiveEntry::kCompress, writer); |
| 267 | } break; |
| 268 | |
| 269 | case OutputFormat::kProto: { |
| 270 | pb::XmlNode pb_node; |
Ryan Mitchell | 467b689 | 2018-11-09 15:52:07 -0800 | [diff] [blame] | 271 | // Strip whitespace text nodes from tha AndroidManifest.xml |
| 272 | SerializeXmlOptions options; |
| 273 | options.remove_empty_text_nodes = (path == kAndroidManifestPath); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 274 | SerializeXmlResourceToPb(xml_res, &pb_node); |
| 275 | return io::CopyProtoToArchive(context, &pb_node, path.to_string(), ArchiveEntry::kCompress, |
| 276 | writer); |
| 277 | } break; |
| 278 | } |
| 279 | return false; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 280 | } |
| 281 | |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 282 | // Inflates an XML file from the source path. |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 283 | static std::unique_ptr<xml::XmlResource> LoadXml(const std::string& path, |
| 284 | android::IDiagnostics* diag) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 285 | TRACE_CALL(); |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 286 | FileInputStream fin(path); |
| 287 | if (fin.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 288 | diag->Error(android::DiagMessage(path) << "failed to load XML file: " << fin.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 289 | return {}; |
| 290 | } |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 291 | return xml::Inflate(&fin, diag, android::Source(path)); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 292 | } |
| 293 | |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 294 | struct ResourceFileFlattenerOptions { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 295 | bool no_auto_version = false; |
| 296 | bool no_version_vectors = false; |
Yuichi Araki | 4d35cca | 2017-01-18 20:42:17 +0900 | [diff] [blame] | 297 | bool no_version_transitions = false; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 298 | bool no_xml_namespaces = false; |
| 299 | bool keep_raw_values = false; |
| 300 | bool do_not_compress_anything = false; |
| 301 | bool update_proguard_spec = false; |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 302 | bool do_not_fail_on_missing_resources = false; |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 303 | OutputFormat output_format = OutputFormat::kApk; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 304 | std::unordered_set<std::string> extensions_to_not_compress; |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 305 | std::optional<std::regex> regex_to_not_compress; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 306 | }; |
| 307 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 308 | // A sampling of public framework resource IDs. |
| 309 | struct R { |
| 310 | struct attr { |
| 311 | enum : uint32_t { |
| 312 | paddingLeft = 0x010100d6u, |
| 313 | paddingRight = 0x010100d8u, |
| 314 | paddingHorizontal = 0x0101053du, |
| 315 | |
| 316 | paddingTop = 0x010100d7u, |
| 317 | paddingBottom = 0x010100d9u, |
| 318 | paddingVertical = 0x0101053eu, |
| 319 | |
| 320 | layout_marginLeft = 0x010100f7u, |
| 321 | layout_marginRight = 0x010100f9u, |
| 322 | layout_marginHorizontal = 0x0101053bu, |
| 323 | |
| 324 | layout_marginTop = 0x010100f8u, |
| 325 | layout_marginBottom = 0x010100fau, |
| 326 | layout_marginVertical = 0x0101053cu, |
| 327 | }; |
| 328 | }; |
| 329 | }; |
| 330 | |
Ryan Mitchell | 81dfca0 | 2019-06-07 10:20:27 -0700 | [diff] [blame] | 331 | template <typename T> |
| 332 | uint32_t GetCompressionFlags(const StringPiece& str, T options) { |
| 333 | if (options.do_not_compress_anything) { |
| 334 | return 0; |
| 335 | } |
| 336 | |
| 337 | if (options.regex_to_not_compress |
| 338 | && std::regex_search(str.to_string(), options.regex_to_not_compress.value())) { |
| 339 | return 0; |
| 340 | } |
| 341 | |
| 342 | for (const std::string& extension : options.extensions_to_not_compress) { |
| 343 | if (util::EndsWith(str, extension)) { |
| 344 | return 0; |
| 345 | } |
| 346 | } |
| 347 | return ArchiveEntry::kCompress; |
| 348 | } |
| 349 | |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 350 | class ResourceFileFlattener { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 351 | public: |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 352 | ResourceFileFlattener(const ResourceFileFlattenerOptions& options, IAaptContext* context, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 353 | proguard::KeepSet* keep_set); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 354 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 355 | bool Flatten(ResourceTable* table, IArchiveWriter* archive_writer); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 356 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 357 | private: |
| 358 | struct FileOperation { |
| 359 | ConfigDescription config; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 360 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 361 | // The entry this file came from. |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 362 | ResourceEntry* entry; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 363 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 364 | // The file to copy as-is. |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 365 | io::IFile* file_to_copy; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 366 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 367 | // The XML to process and flatten. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 368 | std::unique_ptr<xml::XmlResource> xml_to_flatten; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 369 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 370 | // The destination to write this file to. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 371 | std::string dst_path; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 372 | }; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 373 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 374 | std::vector<std::unique_ptr<xml::XmlResource>> LinkAndVersionXmlFile(ResourceTable* table, |
| 375 | FileOperation* file_op); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 376 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 377 | ResourceFileFlattenerOptions options_; |
| 378 | IAaptContext* context_; |
| 379 | proguard::KeepSet* keep_set_; |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 380 | XmlCompatVersioner::Rules rules_; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 381 | }; |
| 382 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 383 | ResourceFileFlattener::ResourceFileFlattener(const ResourceFileFlattenerOptions& options, |
| 384 | IAaptContext* context, proguard::KeepSet* keep_set) |
| 385 | : options_(options), context_(context), keep_set_(keep_set) { |
| 386 | SymbolTable* symm = context_->GetExternalSymbols(); |
| 387 | |
| 388 | // Build up the rules for degrading newer attributes to older ones. |
| 389 | // NOTE(adamlesinski): These rules are hardcoded right now, but they should be |
| 390 | // generated from the attribute definitions themselves (b/62028956). |
| 391 | if (const SymbolTable::Symbol* s = symm->FindById(R::attr::paddingHorizontal)) { |
| 392 | std::vector<ReplacementAttr> replacements{ |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 393 | {"paddingLeft", R::attr::paddingLeft, Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
| 394 | {"paddingRight", R::attr::paddingRight, Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 395 | }; |
| 396 | rules_[R::attr::paddingHorizontal] = |
| 397 | util::make_unique<DegradeToManyRule>(std::move(replacements)); |
| 398 | } |
| 399 | |
| 400 | if (const SymbolTable::Symbol* s = symm->FindById(R::attr::paddingVertical)) { |
| 401 | std::vector<ReplacementAttr> replacements{ |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 402 | {"paddingTop", R::attr::paddingTop, Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
| 403 | {"paddingBottom", R::attr::paddingBottom, Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 404 | }; |
| 405 | rules_[R::attr::paddingVertical] = |
| 406 | util::make_unique<DegradeToManyRule>(std::move(replacements)); |
| 407 | } |
| 408 | |
| 409 | if (const SymbolTable::Symbol* s = symm->FindById(R::attr::layout_marginHorizontal)) { |
| 410 | std::vector<ReplacementAttr> replacements{ |
| 411 | {"layout_marginLeft", R::attr::layout_marginLeft, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 412 | Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 413 | {"layout_marginRight", R::attr::layout_marginRight, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 414 | Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 415 | }; |
| 416 | rules_[R::attr::layout_marginHorizontal] = |
| 417 | util::make_unique<DegradeToManyRule>(std::move(replacements)); |
| 418 | } |
| 419 | |
| 420 | if (const SymbolTable::Symbol* s = symm->FindById(R::attr::layout_marginVertical)) { |
| 421 | std::vector<ReplacementAttr> replacements{ |
| 422 | {"layout_marginTop", R::attr::layout_marginTop, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 423 | Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 424 | {"layout_marginBottom", R::attr::layout_marginBottom, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 425 | Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 426 | }; |
| 427 | rules_[R::attr::layout_marginVertical] = |
| 428 | util::make_unique<DegradeToManyRule>(std::move(replacements)); |
| 429 | } |
| 430 | } |
| 431 | |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 432 | static bool IsTransitionElement(const std::string& name) { |
| 433 | return name == "fade" || name == "changeBounds" || name == "slide" || name == "explode" || |
| 434 | name == "changeImageTransform" || name == "changeTransform" || |
| 435 | name == "changeClipBounds" || name == "autoTransition" || name == "recolor" || |
| 436 | name == "changeScroll" || name == "transitionSet" || name == "transition" || |
| 437 | name == "transitionManager"; |
| 438 | } |
| 439 | |
| 440 | static bool IsVectorElement(const std::string& name) { |
| 441 | return name == "vector" || name == "animated-vector" || name == "pathInterpolator" || |
Winson | a00d969 | 2019-01-24 15:55:29 -0800 | [diff] [blame] | 442 | name == "objectAnimator" || name == "gradient" || name == "animated-selector" || |
| 443 | name == "set"; |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 444 | } |
| 445 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 446 | template <typename T> |
| 447 | std::vector<T> make_singleton_vec(T&& val) { |
| 448 | std::vector<T> vec; |
| 449 | vec.emplace_back(std::forward<T>(val)); |
| 450 | return vec; |
| 451 | } |
| 452 | |
| 453 | std::vector<std::unique_ptr<xml::XmlResource>> ResourceFileFlattener::LinkAndVersionXmlFile( |
| 454 | ResourceTable* table, FileOperation* file_op) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 455 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 456 | xml::XmlResource* doc = file_op->xml_to_flatten.get(); |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 457 | const android::Source& src = doc->file.source; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 458 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 459 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 460 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 461 | << "linking " << src.path << " (" << doc->file.name << ")"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 462 | } |
| 463 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 464 | // First, strip out any tools namespace attributes. AAPT stripped them out early, which means |
| 465 | // that existing projects have out-of-date references which pass compilation. |
| 466 | xml::StripAndroidStudioAttributes(doc->root.get()); |
| 467 | |
Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 468 | XmlReferenceLinker xml_linker(table); |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 469 | if (!options_.do_not_fail_on_missing_resources && !xml_linker.Consume(context_, doc)) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 470 | return {}; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 471 | } |
| 472 | |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 473 | if (options_.update_proguard_spec && !proguard::CollectProguardRules(context_, doc, keep_set_)) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 474 | return {}; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 475 | } |
| 476 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 477 | if (options_.no_xml_namespaces) { |
| 478 | XmlNamespaceRemover namespace_remover; |
| 479 | if (!namespace_remover.Consume(context_, doc)) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 480 | return {}; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 481 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 482 | } |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 483 | |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 484 | if (options_.no_auto_version) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 485 | return make_singleton_vec(std::move(file_op->xml_to_flatten)); |
| 486 | } |
Alexandria Cornwall | a7cc3f1 | 2016-08-16 13:33:32 -0700 | [diff] [blame] | 487 | |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 488 | if (options_.no_version_vectors || options_.no_version_transitions) { |
| 489 | // Skip this if it is a vector or animated-vector. |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 490 | xml::Element* el = doc->root.get(); |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 491 | if (el && el->namespace_uri.empty()) { |
| 492 | if ((options_.no_version_vectors && IsVectorElement(el->name)) || |
| 493 | (options_.no_version_transitions && IsTransitionElement(el->name))) { |
| 494 | return make_singleton_vec(std::move(file_op->xml_to_flatten)); |
| 495 | } |
| 496 | } |
| 497 | } |
| 498 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 499 | const ConfigDescription& config = file_op->config; |
| 500 | ResourceEntry* entry = file_op->entry; |
| 501 | |
| 502 | XmlCompatVersioner xml_compat_versioner(&rules_); |
| 503 | const util::Range<ApiVersion> api_range{config.sdkVersion, |
| 504 | FindNextApiVersionForConfig(entry, config)}; |
| 505 | return xml_compat_versioner.Process(context_, doc, api_range); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 506 | } |
| 507 | |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 508 | ResourceFile::Type XmlFileTypeForOutputFormat(OutputFormat format) { |
| 509 | switch (format) { |
| 510 | case OutputFormat::kApk: |
| 511 | return ResourceFile::Type::kBinaryXml; |
| 512 | case OutputFormat::kProto: |
| 513 | return ResourceFile::Type::kProtoXml; |
| 514 | } |
| 515 | LOG_ALWAYS_FATAL("unreachable"); |
| 516 | return ResourceFile::Type::kUnknown; |
| 517 | } |
| 518 | |
Ryan Mitchell | 70f7972 | 2018-08-13 07:37:24 -0700 | [diff] [blame] | 519 | static auto kDrawableVersions = std::map<std::string, ApiVersion>{ |
| 520 | { "adaptive-icon" , SDK_O }, |
| 521 | }; |
| 522 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 523 | bool ResourceFileFlattener::Flatten(ResourceTable* table, IArchiveWriter* archive_writer) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 524 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 525 | bool error = false; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 526 | std::map<std::pair<ConfigDescription, StringPiece>, FileOperation> config_sorted_files; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 527 | |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 528 | proguard::CollectResourceReferences(context_, table, keep_set_); |
| 529 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 530 | for (auto& pkg : table->packages) { |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 531 | CHECK(!pkg->name.empty()) << "Packages must have names when being linked"; |
| 532 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 533 | for (auto& type : pkg->types) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 534 | // Sort by config and name, so that we get better locality in the zip file. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 535 | config_sorted_files.clear(); |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 536 | std::queue<FileOperation> file_operations; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 537 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 538 | // Populate the queue with all files in the ResourceTable. |
| 539 | for (auto& entry : type->entries) { |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 540 | for (auto& config_value : entry->values) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 541 | // WARNING! Do not insert or remove any resources while executing in this scope. It will |
| 542 | // corrupt the iteration order. |
| 543 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 544 | FileReference* file_ref = ValueCast<FileReference>(config_value->value.get()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 545 | if (!file_ref) { |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 546 | continue; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 547 | } |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 548 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 549 | io::IFile* file = file_ref->file; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 550 | if (!file) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 551 | context_->GetDiagnostics()->Error(android::DiagMessage(file_ref->GetSource()) |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 552 | << "file not found"); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 553 | return false; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 554 | } |
| 555 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 556 | FileOperation file_op; |
| 557 | file_op.entry = entry.get(); |
| 558 | file_op.dst_path = *file_ref->path; |
| 559 | file_op.config = config_value->config; |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 560 | file_op.file_to_copy = file; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 561 | |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 562 | if (type->named_type.type != ResourceType::kRaw && |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 563 | (file_ref->type == ResourceFile::Type::kBinaryXml || |
| 564 | file_ref->type == ResourceFile::Type::kProtoXml)) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 565 | std::unique_ptr<io::IData> data = file->OpenAsData(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 566 | if (!data) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 567 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 568 | << "failed to open file"); |
| 569 | return false; |
| 570 | } |
| 571 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 572 | if (file_ref->type == ResourceFile::Type::kProtoXml) { |
| 573 | pb::XmlNode pb_xml_node; |
| 574 | if (!pb_xml_node.ParseFromArray(data->data(), static_cast<int>(data->size()))) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 575 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 576 | << "failed to parse proto XML"); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 577 | return false; |
| 578 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 579 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 580 | std::string error; |
| 581 | file_op.xml_to_flatten = DeserializeXmlResourceFromPb(pb_xml_node, &error); |
| 582 | if (file_op.xml_to_flatten == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 583 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 584 | << "failed to deserialize proto XML: " << error); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 585 | return false; |
| 586 | } |
| 587 | } else { |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 588 | std::string error_str; |
| 589 | file_op.xml_to_flatten = xml::Inflate(data->data(), data->size(), &error_str); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 590 | if (file_op.xml_to_flatten == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 591 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 592 | << "failed to parse binary XML: " << error_str); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 593 | return false; |
| 594 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 595 | } |
| 596 | |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 597 | // Update the type that this file will be written as. |
| 598 | file_ref->type = XmlFileTypeForOutputFormat(options_.output_format); |
| 599 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 600 | file_op.xml_to_flatten->file.config = config_value->config; |
| 601 | file_op.xml_to_flatten->file.source = file_ref->GetSource(); |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 602 | file_op.xml_to_flatten->file.name = |
| 603 | ResourceName(pkg->name, type->named_type, entry->name); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 604 | } |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 605 | |
| 606 | // NOTE(adamlesinski): Explicitly construct a StringPiece here, or |
| 607 | // else we end up copying the string in the std::make_pair() method, |
| 608 | // then creating a StringPiece from the copy, which would cause us |
| 609 | // to end up referencing garbage in the map. |
| 610 | const StringPiece entry_name(entry->name); |
| 611 | config_sorted_files[std::make_pair(config_value->config, entry_name)] = |
| 612 | std::move(file_op); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 613 | } |
| 614 | } |
| 615 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 616 | // Now flatten the sorted values. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 617 | for (auto& map_entry : config_sorted_files) { |
| 618 | const ConfigDescription& config = map_entry.first.first; |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 619 | FileOperation& file_op = map_entry.second; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 620 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 621 | if (file_op.xml_to_flatten) { |
Ryan Mitchell | 70f7972 | 2018-08-13 07:37:24 -0700 | [diff] [blame] | 622 | // Check minimum sdk versions supported for drawables |
| 623 | auto drawable_entry = kDrawableVersions.find(file_op.xml_to_flatten->root->name); |
| 624 | if (drawable_entry != kDrawableVersions.end()) { |
| 625 | if (drawable_entry->second > context_->GetMinSdkVersion() |
| 626 | && drawable_entry->second > config.sdkVersion) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 627 | context_->GetDiagnostics()->Error( |
| 628 | android::DiagMessage(file_op.xml_to_flatten->file.source) |
| 629 | << "<" << drawable_entry->first << "> elements " |
| 630 | << "require a sdk version of at least " << (int16_t)drawable_entry->second); |
Ryan Mitchell | 70f7972 | 2018-08-13 07:37:24 -0700 | [diff] [blame] | 631 | error = true; |
| 632 | continue; |
| 633 | } |
| 634 | } |
| 635 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 636 | std::vector<std::unique_ptr<xml::XmlResource>> versioned_docs = |
| 637 | LinkAndVersionXmlFile(table, &file_op); |
Adam Lesinski | c0a5e1e | 2017-08-07 11:56:32 -0700 | [diff] [blame] | 638 | if (versioned_docs.empty()) { |
| 639 | error = true; |
| 640 | continue; |
| 641 | } |
| 642 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 643 | for (std::unique_ptr<xml::XmlResource>& doc : versioned_docs) { |
| 644 | std::string dst_path = file_op.dst_path; |
| 645 | if (doc->file.config != file_op.config) { |
| 646 | // Only add the new versioned configurations. |
| 647 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 648 | context_->GetDiagnostics()->Note(android::DiagMessage(doc->file.source) |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 649 | << "auto-versioning resource from config '" |
| 650 | << config << "' -> '" << doc->file.config << "'"); |
| 651 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 652 | |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 653 | const ResourceFile& file = doc->file; |
| 654 | dst_path = ResourceUtils::BuildResourceFileName(file, context_->GetNameMangler()); |
| 655 | |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 656 | auto file_ref = |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 657 | util::make_unique<FileReference>(table->string_pool.MakeRef(dst_path)); |
| 658 | file_ref->SetSource(doc->file.source); |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 659 | |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 660 | // Update the output format of this XML file. |
| 661 | file_ref->type = XmlFileTypeForOutputFormat(options_.output_format); |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 662 | bool result = table->AddResource(NewResourceBuilder(file.name) |
| 663 | .SetValue(std::move(file_ref), file.config) |
| 664 | .SetAllowMangled(true) |
| 665 | .Build(), |
| 666 | context_->GetDiagnostics()); |
| 667 | if (!result) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 668 | return false; |
| 669 | } |
| 670 | } |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 671 | |
| 672 | error |= !FlattenXml(context_, *doc, dst_path, options_.keep_raw_values, |
| 673 | false /*utf16*/, options_.output_format, archive_writer); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 674 | } |
| 675 | } else { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 676 | error |= !io::CopyFileToArchive(context_, file_op.file_to_copy, file_op.dst_path, |
Ryan Mitchell | 81dfca0 | 2019-06-07 10:20:27 -0700 | [diff] [blame] | 677 | GetCompressionFlags(file_op.dst_path, options_), |
| 678 | archive_writer); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 679 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 680 | } |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 681 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 682 | } |
| 683 | return !error; |
| 684 | } |
| 685 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 686 | static bool WriteStableIdMapToPath(android::IDiagnostics* diag, |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 687 | const std::unordered_map<ResourceName, ResourceId>& id_map, |
| 688 | const std::string& id_map_path) { |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 689 | io::FileOutputStream fout(id_map_path); |
| 690 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 691 | diag->Error(android::DiagMessage(id_map_path) << "failed to open: " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 692 | return false; |
| 693 | } |
| 694 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 695 | text::Printer printer(&fout); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 696 | for (const auto& entry : id_map) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 697 | const ResourceName& name = entry.first; |
| 698 | const ResourceId& id = entry.second; |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 699 | printer.Print(name.to_string()); |
| 700 | printer.Print(" = "); |
| 701 | printer.Println(id.to_string()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 702 | } |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 703 | fout.Flush(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 704 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 705 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 706 | diag->Error(android::DiagMessage(id_map_path) << "failed writing to file: " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 707 | return false; |
| 708 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 709 | return true; |
| 710 | } |
| 711 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 712 | static bool LoadStableIdMap(android::IDiagnostics* diag, const std::string& path, |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 713 | std::unordered_map<ResourceName, ResourceId>* out_id_map) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 714 | std::string content; |
Adam Lesinski | 2354b56 | 2017-05-26 16:31:38 -0700 | [diff] [blame] | 715 | if (!android::base::ReadFileToString(path, &content, true /*follow_symlinks*/)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 716 | diag->Error(android::DiagMessage(path) << "failed reading stable ID file"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 717 | return false; |
| 718 | } |
| 719 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 720 | out_id_map->clear(); |
| 721 | size_t line_no = 0; |
| 722 | for (StringPiece line : util::Tokenize(content, '\n')) { |
| 723 | line_no++; |
| 724 | line = util::TrimWhitespace(line); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 725 | if (line.empty()) { |
| 726 | continue; |
| 727 | } |
| 728 | |
| 729 | auto iter = std::find(line.begin(), line.end(), '='); |
| 730 | if (iter == line.end()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 731 | diag->Error(android::DiagMessage(android::Source(path, line_no)) << "missing '='"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 732 | return false; |
| 733 | } |
| 734 | |
| 735 | ResourceNameRef name; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 736 | StringPiece res_name_str = |
| 737 | util::TrimWhitespace(line.substr(0, std::distance(line.begin(), iter))); |
| 738 | if (!ResourceUtils::ParseResourceName(res_name_str, &name)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 739 | diag->Error(android::DiagMessage(android::Source(path, line_no)) |
| 740 | << "invalid resource name '" << res_name_str << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 741 | return false; |
| 742 | } |
| 743 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 744 | const size_t res_id_start_idx = std::distance(line.begin(), iter) + 1; |
| 745 | const size_t res_id_str_len = line.size() - res_id_start_idx; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 746 | StringPiece res_id_str = util::TrimWhitespace(line.substr(res_id_start_idx, res_id_str_len)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 747 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 748 | std::optional<ResourceId> maybe_id = ResourceUtils::ParseResourceId(res_id_str); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 749 | if (!maybe_id) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 750 | diag->Error(android::DiagMessage(android::Source(path, line_no)) |
| 751 | << "invalid resource ID '" << res_id_str << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 752 | return false; |
| 753 | } |
| 754 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 755 | (*out_id_map)[name.ToResourceName()] = maybe_id.value(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 756 | } |
| 757 | return true; |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 758 | } |
| 759 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 760 | class Linker { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 761 | public: |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 762 | Linker(LinkContext* context, const LinkOptions& options) |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 763 | : options_(options), |
| 764 | context_(context), |
| 765 | final_table_(), |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 766 | file_collection_(util::make_unique<io::FileCollection>()) { |
| 767 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 768 | |
Ryan Mitchell | a55dc2e | 2019-01-24 10:58:23 -0800 | [diff] [blame] | 769 | void ExtractCompileSdkVersions(android::AssetManager2* assets) { |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 770 | using namespace android; |
| 771 | |
Ryan Mitchell | db21f09a | 2020-11-16 23:08:18 +0000 | [diff] [blame] | 772 | // Find the system package (0x01). AAPT always generates attributes with the type 0x01, so |
| 773 | // we're looking for the first attribute resource in the system package. |
| 774 | android::ApkAssetsCookie cookie; |
| 775 | if (auto value = assets->GetResource(0x01010000, true /** may_be_bag */); value.has_value()) { |
| 776 | cookie = value->cookie; |
| 777 | } else { |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 778 | // No Framework assets loaded. Not a failure. |
| 779 | return; |
| 780 | } |
| 781 | |
| 782 | std::unique_ptr<Asset> manifest( |
Ryan Mitchell | a55dc2e | 2019-01-24 10:58:23 -0800 | [diff] [blame] | 783 | assets->OpenNonAsset(kAndroidManifestPath, cookie, Asset::AccessMode::ACCESS_BUFFER)); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 784 | if (manifest == nullptr) { |
| 785 | // No errors. |
| 786 | return; |
| 787 | } |
| 788 | |
| 789 | std::string error; |
| 790 | std::unique_ptr<xml::XmlResource> manifest_xml = |
| 791 | xml::Inflate(manifest->getBuffer(true /*wordAligned*/), manifest->getLength(), &error); |
| 792 | if (manifest_xml == nullptr) { |
| 793 | // No errors. |
| 794 | return; |
| 795 | } |
| 796 | |
Todd Kennedy | 9f6dec1 | 2018-04-20 12:29:29 -0700 | [diff] [blame] | 797 | if (!options_.manifest_fixer_options.compile_sdk_version) { |
| 798 | xml::Attribute* attr = manifest_xml->root->FindAttribute(xml::kSchemaAndroid, "versionCode"); |
| 799 | if (attr != nullptr) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 800 | auto& compile_sdk_version = options_.manifest_fixer_options.compile_sdk_version; |
Todd Kennedy | 9f6dec1 | 2018-04-20 12:29:29 -0700 | [diff] [blame] | 801 | if (BinaryPrimitive* prim = ValueCast<BinaryPrimitive>(attr->compiled_value.get())) { |
| 802 | switch (prim->value.dataType) { |
| 803 | case Res_value::TYPE_INT_DEC: |
| 804 | compile_sdk_version = StringPrintf("%" PRId32, static_cast<int32_t>(prim->value.data)); |
| 805 | break; |
| 806 | case Res_value::TYPE_INT_HEX: |
| 807 | compile_sdk_version = StringPrintf("%" PRIx32, prim->value.data); |
| 808 | break; |
| 809 | default: |
| 810 | break; |
| 811 | } |
| 812 | } else if (String* str = ValueCast<String>(attr->compiled_value.get())) { |
| 813 | compile_sdk_version = *str->value; |
| 814 | } else { |
| 815 | compile_sdk_version = attr->value; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 816 | } |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 817 | } |
| 818 | } |
| 819 | |
Todd Kennedy | 9f6dec1 | 2018-04-20 12:29:29 -0700 | [diff] [blame] | 820 | if (!options_.manifest_fixer_options.compile_sdk_version_codename) { |
| 821 | xml::Attribute* attr = manifest_xml->root->FindAttribute(xml::kSchemaAndroid, "versionName"); |
| 822 | if (attr != nullptr) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 823 | std::optional<std::string>& compile_sdk_version_codename = |
Todd Kennedy | 9f6dec1 | 2018-04-20 12:29:29 -0700 | [diff] [blame] | 824 | options_.manifest_fixer_options.compile_sdk_version_codename; |
| 825 | if (String* str = ValueCast<String>(attr->compiled_value.get())) { |
| 826 | compile_sdk_version_codename = *str->value; |
| 827 | } else { |
| 828 | compile_sdk_version_codename = attr->value; |
| 829 | } |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 830 | } |
| 831 | } |
| 832 | } |
| 833 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 834 | // Creates a SymbolTable that loads symbols from the various APKs. |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 835 | // Pre-condition: context_->GetCompilationPackage() needs to be set. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 836 | bool LoadSymbolsFromIncludePaths() { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 837 | TRACE_NAME("LoadSymbolsFromIncludePaths: #" + std::to_string(options_.include_paths.size())); |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 838 | auto asset_source = util::make_unique<AssetManagerSymbolSource>(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 839 | for (const std::string& path : options_.include_paths) { |
| 840 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 841 | context_->GetDiagnostics()->Note(android::DiagMessage() << "including " << path); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 842 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 843 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 844 | std::string error; |
| 845 | auto zip_collection = io::ZipFileCollection::Create(path, &error); |
| 846 | if (zip_collection == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 847 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 848 | << "failed to open APK: " << error); |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 849 | return false; |
| 850 | } |
| 851 | |
| 852 | if (zip_collection->FindFile(kProtoResourceTablePath) != nullptr) { |
| 853 | // Load this as a static library include. |
| 854 | std::unique_ptr<LoadedApk> static_apk = LoadedApk::LoadProtoApkFromFileCollection( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 855 | android::Source(path), std::move(zip_collection), context_->GetDiagnostics()); |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 856 | if (static_apk == nullptr) { |
| 857 | return false; |
| 858 | } |
| 859 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 860 | if (context_->GetPackageType() != PackageType::kStaticLib) { |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 861 | // Can't include static libraries when not building a static library (they have no IDs |
| 862 | // assigned). |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 863 | context_->GetDiagnostics()->Error( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 864 | android::DiagMessage(path) |
| 865 | << "can't include static library when not building a static lib"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 866 | return false; |
| 867 | } |
| 868 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 869 | ResourceTable* table = static_apk->GetResourceTable(); |
| 870 | |
| 871 | // If we are using --no-static-lib-packages, we need to rename the package of this table to |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 872 | // our compilation package so the symbol package name does not get mangled into the entry |
| 873 | // name. |
| 874 | if (options_.no_static_lib_packages && !table->packages.empty()) { |
| 875 | auto lib_package_result = GetStaticLibraryPackage(table); |
| 876 | if (!lib_package_result.has_value()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 877 | context_->GetDiagnostics()->Error(android::DiagMessage(path) |
| 878 | << lib_package_result.error()); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 879 | return false; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 880 | } |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 881 | lib_package_result.value()->name = context_->GetCompilationPackage(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 882 | } |
| 883 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 884 | context_->GetExternalSymbols()->AppendSource( |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 885 | util::make_unique<ResourceTableSymbolSource>(table)); |
| 886 | static_library_includes_.push_back(std::move(static_apk)); |
| 887 | } else { |
| 888 | if (!asset_source->AddAssetPath(path)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 889 | context_->GetDiagnostics()->Error(android::DiagMessage() |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 890 | << "failed to load include path " << path); |
| 891 | return false; |
| 892 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 893 | } |
| 894 | } |
| 895 | |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 896 | // Capture the shared libraries so that the final resource table can be properly flattened |
| 897 | // with support for shared libraries. |
| 898 | for (auto& entry : asset_source->GetAssignedPackageIds()) { |
Todd Kennedy | 3251299 | 2018-04-25 16:45:59 -0700 | [diff] [blame] | 899 | if (entry.first == kAppPackageId) { |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 900 | // Capture the included base feature package. |
| 901 | included_feature_base_ = entry.second; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 902 | } else if (entry.first == kFrameworkPackageId) { |
| 903 | // Try to embed which version of the framework we're compiling against. |
| 904 | // First check if we should use compileSdkVersion at all. Otherwise compilation may fail |
| 905 | // when linking our synthesized 'android:compileSdkVersion' attribute. |
| 906 | std::unique_ptr<SymbolTable::Symbol> symbol = asset_source->FindByName( |
| 907 | ResourceName("android", ResourceType::kAttr, "compileSdkVersion")); |
| 908 | if (symbol != nullptr && symbol->is_public) { |
| 909 | // The symbol is present and public, extract the android:versionName and |
| 910 | // android:versionCode from the framework AndroidManifest.xml. |
| 911 | ExtractCompileSdkVersions(asset_source->GetAssetManager()); |
| 912 | } |
Ryan Mitchell | ee4a564 | 2019-10-16 08:32:55 -0700 | [diff] [blame] | 913 | } else if (asset_source->IsPackageDynamic(entry.first, entry.second)) { |
Todd Kennedy | 3251299 | 2018-04-25 16:45:59 -0700 | [diff] [blame] | 914 | final_table_.included_packages_[entry.first] = entry.second; |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 915 | } |
| 916 | } |
| 917 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 918 | context_->GetExternalSymbols()->AppendSource(std::move(asset_source)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 919 | return true; |
| 920 | } |
| 921 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 922 | std::optional<AppInfo> ExtractAppInfoFromManifest(xml::XmlResource* xml_res, |
| 923 | android::IDiagnostics* diag) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 924 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 925 | // Make sure the first element is <manifest> with package attribute. |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 926 | xml::Element* manifest_el = xml::FindRootElement(xml_res->root.get()); |
| 927 | if (manifest_el == nullptr) { |
| 928 | return {}; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 929 | } |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 930 | |
| 931 | AppInfo app_info; |
| 932 | |
| 933 | if (!manifest_el->namespace_uri.empty() || manifest_el->name != "manifest") { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 934 | diag->Error(android::DiagMessage(xml_res->file.source) << "root tag must be <manifest>"); |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 935 | return {}; |
| 936 | } |
| 937 | |
| 938 | xml::Attribute* package_attr = manifest_el->FindAttribute({}, "package"); |
| 939 | if (!package_attr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 940 | diag->Error(android::DiagMessage(xml_res->file.source) |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 941 | << "<manifest> must have a 'package' attribute"); |
| 942 | return {}; |
| 943 | } |
| 944 | app_info.package = package_attr->value; |
| 945 | |
| 946 | if (xml::Attribute* version_code_attr = |
| 947 | manifest_el->FindAttribute(xml::kSchemaAndroid, "versionCode")) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 948 | std::optional<uint32_t> maybe_code = ResourceUtils::ParseInt(version_code_attr->value); |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 949 | if (!maybe_code) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 950 | diag->Error(android::DiagMessage(xml_res->file.source.WithLine(manifest_el->line_number)) |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 951 | << "invalid android:versionCode '" << version_code_attr->value << "'"); |
| 952 | return {}; |
| 953 | } |
| 954 | app_info.version_code = maybe_code.value(); |
| 955 | } |
| 956 | |
Ryan Mitchell | 5fa2bb1 | 2018-07-12 11:24:51 -0700 | [diff] [blame] | 957 | if (xml::Attribute* version_code_major_attr = |
| 958 | manifest_el->FindAttribute(xml::kSchemaAndroid, "versionCodeMajor")) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 959 | std::optional<uint32_t> maybe_code = ResourceUtils::ParseInt(version_code_major_attr->value); |
Ryan Mitchell | 5fa2bb1 | 2018-07-12 11:24:51 -0700 | [diff] [blame] | 960 | if (!maybe_code) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 961 | diag->Error(android::DiagMessage(xml_res->file.source.WithLine(manifest_el->line_number)) |
| 962 | << "invalid android:versionCodeMajor '" << version_code_major_attr->value |
| 963 | << "'"); |
Ryan Mitchell | 5fa2bb1 | 2018-07-12 11:24:51 -0700 | [diff] [blame] | 964 | return {}; |
| 965 | } |
| 966 | app_info.version_code_major = maybe_code.value(); |
| 967 | } |
| 968 | |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 969 | if (xml::Attribute* revision_code_attr = |
| 970 | manifest_el->FindAttribute(xml::kSchemaAndroid, "revisionCode")) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 971 | std::optional<uint32_t> maybe_code = ResourceUtils::ParseInt(revision_code_attr->value); |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 972 | if (!maybe_code) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 973 | diag->Error(android::DiagMessage(xml_res->file.source.WithLine(manifest_el->line_number)) |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 974 | << "invalid android:revisionCode '" << revision_code_attr->value << "'"); |
| 975 | return {}; |
| 976 | } |
| 977 | app_info.revision_code = maybe_code.value(); |
| 978 | } |
| 979 | |
| 980 | if (xml::Attribute* split_name_attr = manifest_el->FindAttribute({}, "split")) { |
| 981 | if (!split_name_attr->value.empty()) { |
| 982 | app_info.split_name = split_name_attr->value; |
| 983 | } |
| 984 | } |
| 985 | |
| 986 | if (xml::Element* uses_sdk_el = manifest_el->FindChild({}, "uses-sdk")) { |
| 987 | if (xml::Attribute* min_sdk = |
| 988 | uses_sdk_el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion")) { |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 989 | app_info.min_sdk_version = ResourceUtils::ParseSdkVersion(min_sdk->value); |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 990 | } |
| 991 | } |
Udam Saini | b228df3 | 2019-06-18 16:50:34 -0700 | [diff] [blame] | 992 | |
| 993 | for (const xml::Element* child_el : manifest_el->GetChildElements()) { |
| 994 | if (child_el->namespace_uri.empty() && child_el->name == "uses-split") { |
| 995 | if (const xml::Attribute* split_name = |
| 996 | child_el->FindAttribute(xml::kSchemaAndroid, "name")) { |
| 997 | if (!split_name->value.empty()) { |
| 998 | app_info.split_name_dependencies.insert(split_name->value); |
| 999 | } |
| 1000 | } |
| 1001 | } |
| 1002 | } |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 1003 | return app_info; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1004 | } |
| 1005 | |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1006 | // Precondition: ResourceTable doesn't have any IDs assigned yet, nor is it linked. |
| 1007 | // Postcondition: ResourceTable has only one package left. All others are |
| 1008 | // stripped, or there is an error and false is returned. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1009 | bool VerifyNoExternalPackages() { |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1010 | auto is_ext_package_func = [&](const std::unique_ptr<ResourceTablePackage>& pkg) -> bool { |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1011 | return context_->GetCompilationPackage() != pkg->name; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1012 | }; |
| 1013 | |
| 1014 | bool error = false; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1015 | for (const auto& package : final_table_.packages) { |
| 1016 | if (is_ext_package_func(package)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1017 | // We have a package that is not related to the one we're building! |
| 1018 | for (const auto& type : package->types) { |
| 1019 | for (const auto& entry : type->entries) { |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 1020 | ResourceNameRef res_name(package->name, type->named_type, entry->name); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1021 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1022 | for (const auto& config_value : entry->values) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1023 | // Special case the occurrence of an ID that is being generated |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1024 | // for the 'android' package. This is due to legacy reasons. |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1025 | if (ValueCast<Id>(config_value->value.get()) && package->name == "android") { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1026 | context_->GetDiagnostics()->Warn( |
| 1027 | android::DiagMessage(config_value->value->GetSource()) |
| 1028 | << "generated id '" << res_name << "' for external package '" << package->name |
| 1029 | << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1030 | } else { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1031 | context_->GetDiagnostics()->Error( |
| 1032 | android::DiagMessage(config_value->value->GetSource()) |
| 1033 | << "defined resource '" << res_name << "' for external package '" |
| 1034 | << package->name << "'"); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1035 | error = true; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1036 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1037 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1038 | } |
| 1039 | } |
| 1040 | } |
| 1041 | } |
| 1042 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1043 | auto new_end_iter = std::remove_if(final_table_.packages.begin(), final_table_.packages.end(), |
| 1044 | is_ext_package_func); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1045 | final_table_.packages.erase(new_end_iter, final_table_.packages.end()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1046 | return !error; |
| 1047 | } |
| 1048 | |
| 1049 | /** |
| 1050 | * Returns true if no IDs have been set, false otherwise. |
| 1051 | */ |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1052 | bool VerifyNoIdsSet() { |
| 1053 | for (const auto& package : final_table_.packages) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1054 | for (const auto& type : package->types) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1055 | for (const auto& entry : type->entries) { |
| 1056 | if (entry->id) { |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 1057 | ResourceNameRef res_name(package->name, type->named_type, entry->name); |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1058 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 1059 | << "resource " << res_name << " has ID " |
| 1060 | << entry->id.value() << " assigned"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1061 | return false; |
| 1062 | } |
| 1063 | } |
| 1064 | } |
| 1065 | } |
| 1066 | return true; |
| 1067 | } |
| 1068 | |
Josh Hou | ec67cb4 | 2022-06-09 19:19:21 +0800 | [diff] [blame^] | 1069 | bool VerifyLocaleFormat(xml::XmlResource* manifest, android::IDiagnostics* diag) { |
| 1070 | // Skip it if the Manifest doesn't declare the localeConfig attribute within the <application> |
| 1071 | // element. |
| 1072 | const xml::Element* application = manifest->root->FindChild("", "application"); |
| 1073 | if (!application) { |
| 1074 | return true; |
| 1075 | } |
| 1076 | const xml::Attribute* localeConfig = |
| 1077 | application->FindAttribute(xml::kSchemaAndroid, "localeConfig"); |
| 1078 | if (!localeConfig) { |
| 1079 | return true; |
| 1080 | } |
| 1081 | |
| 1082 | // Deserialize XML from the compiled file |
| 1083 | if (localeConfig->compiled_value) { |
| 1084 | const auto localeconfig_reference = ValueCast<Reference>(localeConfig->compiled_value.get()); |
| 1085 | const auto localeconfig_entry = |
| 1086 | ResolveTableEntry(context_, &final_table_, localeconfig_reference); |
| 1087 | if (!localeconfig_entry) { |
| 1088 | context_->GetDiagnostics()->Error( |
| 1089 | android::DiagMessage(localeConfig->compiled_value->GetSource()) |
| 1090 | << "no localeConfig entry"); |
| 1091 | return false; |
| 1092 | } |
| 1093 | for (const auto& value : localeconfig_entry->values) { |
| 1094 | const FileReference* file_ref = ValueCast<FileReference>(value->value.get()); |
| 1095 | if (!file_ref) { |
| 1096 | context_->GetDiagnostics()->Error( |
| 1097 | android::DiagMessage(localeConfig->compiled_value->GetSource()) |
| 1098 | << "no file reference"); |
| 1099 | return false; |
| 1100 | } |
| 1101 | io::IFile* file = file_ref->file; |
| 1102 | if (!file) { |
| 1103 | context_->GetDiagnostics()->Error(android::DiagMessage(file_ref->GetSource()) |
| 1104 | << "file not found"); |
| 1105 | return false; |
| 1106 | } |
| 1107 | std::unique_ptr<io::IData> data = file->OpenAsData(); |
| 1108 | if (!data) { |
| 1109 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
| 1110 | << "failed to open file"); |
| 1111 | return false; |
| 1112 | } |
| 1113 | pb::XmlNode pb_xml_node; |
| 1114 | if (!pb_xml_node.ParseFromArray(data->data(), static_cast<int>(data->size()))) { |
| 1115 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
| 1116 | << "failed to parse proto XML"); |
| 1117 | return false; |
| 1118 | } |
| 1119 | |
| 1120 | std::string error; |
| 1121 | std::unique_ptr<xml::XmlResource> localeConfig_xml = |
| 1122 | DeserializeXmlResourceFromPb(pb_xml_node, &error); |
| 1123 | if (!localeConfig_xml) { |
| 1124 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
| 1125 | << "failed to deserialize proto XML: " << error); |
| 1126 | return false; |
| 1127 | } |
| 1128 | xml::Element* localeConfig_el = xml::FindRootElement(localeConfig_xml->root.get()); |
| 1129 | if (!localeConfig_el) { |
| 1130 | diag->Error(android::DiagMessage(file->GetSource()) << "no root tag defined"); |
| 1131 | return false; |
| 1132 | } |
| 1133 | if (localeConfig_el->name != "locale-config") { |
| 1134 | diag->Error(android::DiagMessage(file->GetSource()) |
| 1135 | << "invalid element name: " << localeConfig_el->name |
| 1136 | << ", expected: locale-config"); |
| 1137 | return false; |
| 1138 | } |
| 1139 | for (const xml::Element* child_el : localeConfig_el->GetChildElements()) { |
| 1140 | if (child_el->name == "locale") { |
| 1141 | if (const xml::Attribute* locale_name_attr = |
| 1142 | child_el->FindAttribute(xml::kSchemaAndroid, "name")) { |
| 1143 | const std::string& locale_name = locale_name_attr->value; |
| 1144 | const std::string valid_name = ConvertToBCP47Tag(locale_name); |
| 1145 | // Start to verify the locale format |
| 1146 | ConfigDescription config; |
| 1147 | if (!ConfigDescription::Parse(valid_name, &config)) { |
| 1148 | diag->Error(android::DiagMessage(file->GetSource()) |
| 1149 | << "invalid configuration: " << locale_name); |
| 1150 | return false; |
| 1151 | } |
| 1152 | } else { |
| 1153 | diag->Error(android::DiagMessage(file->GetSource()) |
| 1154 | << "the attribute android:name is not found"); |
| 1155 | return false; |
| 1156 | } |
| 1157 | } else { |
| 1158 | diag->Error(android::DiagMessage(file->GetSource()) |
| 1159 | << "invalid element name: " << child_el->name << ", expected: locale"); |
| 1160 | return false; |
| 1161 | } |
| 1162 | } |
| 1163 | } |
| 1164 | } |
| 1165 | return true; |
| 1166 | } |
| 1167 | |
| 1168 | std::string ConvertToBCP47Tag(const std::string& locale) { |
| 1169 | std::string bcp47tag = "b+"; |
| 1170 | bcp47tag += locale; |
| 1171 | std::replace(bcp47tag.begin(), bcp47tag.end(), '-', '+'); |
| 1172 | return bcp47tag; |
| 1173 | } |
| 1174 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1175 | std::unique_ptr<IArchiveWriter> MakeArchiveWriter(const StringPiece& out) { |
| 1176 | if (options_.output_to_directory) { |
| 1177 | return CreateDirectoryArchiveWriter(context_->GetDiagnostics(), out); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1178 | } else { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1179 | return CreateZipFileArchiveWriter(context_->GetDiagnostics(), out); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1180 | } |
| 1181 | } |
| 1182 | |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1183 | bool FlattenTable(ResourceTable* table, OutputFormat format, IArchiveWriter* writer) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1184 | TRACE_CALL(); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1185 | switch (format) { |
| 1186 | case OutputFormat::kApk: { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1187 | android::BigBuffer buffer(1024); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1188 | TableFlattener flattener(options_.table_flattener_options, &buffer); |
| 1189 | if (!flattener.Consume(context_, table)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1190 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 1191 | << "failed to flatten resource table"); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1192 | return false; |
| 1193 | } |
| 1194 | |
| 1195 | io::BigBufferInputStream input_stream(&buffer); |
| 1196 | return io::CopyInputStreamToArchive(context_, &input_stream, kApkResourceTablePath, |
| 1197 | ArchiveEntry::kAlign, writer); |
| 1198 | } break; |
| 1199 | |
| 1200 | case OutputFormat::kProto: { |
| 1201 | pb::ResourceTable pb_table; |
Ryan Mitchell | ef9e688 | 2019-06-24 11:53:33 -0700 | [diff] [blame] | 1202 | SerializeTableToPb(*table, &pb_table, context_->GetDiagnostics(), |
| 1203 | options_.proto_table_flattener_options); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1204 | return io::CopyProtoToArchive(context_, &pb_table, kProtoResourceTablePath, |
| 1205 | ArchiveEntry::kCompress, writer); |
| 1206 | } break; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1207 | } |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1208 | return false; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1209 | } |
| 1210 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1211 | bool WriteJavaFile(ResourceTable* table, const StringPiece& package_name_to_generate, |
Adam Lesinski | 418763f | 2017-04-11 17:36:53 -0700 | [diff] [blame] | 1212 | const StringPiece& out_package, const JavaClassGeneratorOptions& java_options, |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1213 | const std::optional<std::string>& out_text_symbols_path = {}) { |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1214 | if (!options_.generate_java_class_path && !out_text_symbols_path) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1215 | return true; |
| 1216 | } |
| 1217 | |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1218 | std::string out_path; |
| 1219 | std::unique_ptr<io::FileOutputStream> fout; |
| 1220 | if (options_.generate_java_class_path) { |
| 1221 | out_path = options_.generate_java_class_path.value(); |
| 1222 | file::AppendPath(&out_path, file::PackageToPath(out_package)); |
| 1223 | if (!file::mkdirs(out_path)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1224 | context_->GetDiagnostics()->Error(android::DiagMessage() |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1225 | << "failed to create directory '" << out_path << "'"); |
| 1226 | return false; |
| 1227 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1228 | |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1229 | file::AppendPath(&out_path, "R.java"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1230 | |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1231 | fout = util::make_unique<io::FileOutputStream>(out_path); |
| 1232 | if (fout->HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1233 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 1234 | << "failed writing to '" << out_path |
| 1235 | << "': " << fout->GetError()); |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1236 | return false; |
| 1237 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1238 | } |
| 1239 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1240 | std::unique_ptr<io::FileOutputStream> fout_text; |
Adam Lesinski | 418763f | 2017-04-11 17:36:53 -0700 | [diff] [blame] | 1241 | if (out_text_symbols_path) { |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1242 | fout_text = util::make_unique<io::FileOutputStream>(out_text_symbols_path.value()); |
| 1243 | if (fout_text->HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1244 | context_->GetDiagnostics()->Error(android::DiagMessage() |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1245 | << "failed writing to '" << out_text_symbols_path.value() |
| 1246 | << "': " << fout_text->GetError()); |
Adam Lesinski | 418763f | 2017-04-11 17:36:53 -0700 | [diff] [blame] | 1247 | return false; |
| 1248 | } |
| 1249 | } |
| 1250 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1251 | JavaClassGenerator generator(context_, table, java_options); |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1252 | if (!generator.Generate(package_name_to_generate, out_package, fout.get(), fout_text.get())) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1253 | context_->GetDiagnostics()->Error(android::DiagMessage(out_path) << generator.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1254 | return false; |
| 1255 | } |
| 1256 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1257 | return true; |
| 1258 | } |
| 1259 | |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1260 | bool GenerateJavaClasses() { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1261 | TRACE_CALL(); |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1262 | // The set of packages whose R class to call in the main classes onResourcesLoaded callback. |
| 1263 | std::vector<std::string> packages_to_callback; |
| 1264 | |
| 1265 | JavaClassGeneratorOptions template_options; |
| 1266 | template_options.types = JavaClassGeneratorOptions::SymbolTypes::kAll; |
| 1267 | template_options.javadoc_annotations = options_.javadoc_annotations; |
| 1268 | |
| 1269 | if (context_->GetPackageType() == PackageType::kStaticLib || options_.generate_non_final_ids) { |
| 1270 | template_options.use_final = false; |
| 1271 | } |
| 1272 | |
| 1273 | if (context_->GetPackageType() == PackageType::kSharedLib) { |
| 1274 | template_options.use_final = false; |
| 1275 | template_options.rewrite_callback_options = OnResourcesLoadedCallbackOptions{}; |
| 1276 | } |
| 1277 | |
| 1278 | const StringPiece actual_package = context_->GetCompilationPackage(); |
| 1279 | StringPiece output_package = context_->GetCompilationPackage(); |
| 1280 | if (options_.custom_java_package) { |
| 1281 | // Override the output java package to the custom one. |
| 1282 | output_package = options_.custom_java_package.value(); |
| 1283 | } |
| 1284 | |
| 1285 | // Generate the private symbols if required. |
| 1286 | if (options_.private_symbols) { |
| 1287 | packages_to_callback.push_back(options_.private_symbols.value()); |
| 1288 | |
| 1289 | // If we defined a private symbols package, we only emit Public symbols |
| 1290 | // to the original package, and private and public symbols to the private package. |
| 1291 | JavaClassGeneratorOptions options = template_options; |
| 1292 | options.types = JavaClassGeneratorOptions::SymbolTypes::kPublicPrivate; |
| 1293 | if (!WriteJavaFile(&final_table_, actual_package, options_.private_symbols.value(), |
| 1294 | options)) { |
| 1295 | return false; |
| 1296 | } |
| 1297 | } |
| 1298 | |
| 1299 | // Generate copies of the original package R class but with different package names. |
| 1300 | // This is to support non-namespaced builds. |
| 1301 | for (const std::string& extra_package : options_.extra_java_packages) { |
| 1302 | packages_to_callback.push_back(extra_package); |
| 1303 | |
| 1304 | JavaClassGeneratorOptions options = template_options; |
| 1305 | options.types = JavaClassGeneratorOptions::SymbolTypes::kAll; |
| 1306 | if (!WriteJavaFile(&final_table_, actual_package, extra_package, options)) { |
| 1307 | return false; |
| 1308 | } |
| 1309 | } |
| 1310 | |
| 1311 | // Generate R classes for each package that was merged (static library). |
| 1312 | // Use the actual package's resources only. |
| 1313 | for (const std::string& package : table_merger_->merged_packages()) { |
| 1314 | packages_to_callback.push_back(package); |
| 1315 | |
| 1316 | JavaClassGeneratorOptions options = template_options; |
| 1317 | options.types = JavaClassGeneratorOptions::SymbolTypes::kAll; |
| 1318 | if (!WriteJavaFile(&final_table_, package, package, options)) { |
| 1319 | return false; |
| 1320 | } |
| 1321 | } |
| 1322 | |
| 1323 | // Generate the main public R class. |
| 1324 | JavaClassGeneratorOptions options = template_options; |
| 1325 | |
| 1326 | // Only generate public symbols if we have a private package. |
| 1327 | if (options_.private_symbols) { |
| 1328 | options.types = JavaClassGeneratorOptions::SymbolTypes::kPublic; |
| 1329 | } |
| 1330 | |
| 1331 | if (options.rewrite_callback_options) { |
| 1332 | options.rewrite_callback_options.value().packages_to_callback = |
| 1333 | std::move(packages_to_callback); |
| 1334 | } |
| 1335 | |
| 1336 | if (!WriteJavaFile(&final_table_, actual_package, output_package, options, |
| 1337 | options_.generate_text_symbols_path)) { |
| 1338 | return false; |
| 1339 | } |
| 1340 | |
| 1341 | return true; |
| 1342 | } |
| 1343 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1344 | bool WriteManifestJavaFile(xml::XmlResource* manifest_xml) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1345 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1346 | if (!options_.generate_java_class_path) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1347 | return true; |
| 1348 | } |
| 1349 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1350 | std::unique_ptr<ClassDefinition> manifest_class = |
| 1351 | GenerateManifestClass(context_->GetDiagnostics(), manifest_xml); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1352 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1353 | if (!manifest_class) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1354 | // Something bad happened, but we already logged it, so exit. |
| 1355 | return false; |
| 1356 | } |
| 1357 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1358 | if (manifest_class->empty()) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1359 | // Empty Manifest class, no need to generate it. |
| 1360 | return true; |
| 1361 | } |
| 1362 | |
| 1363 | // Add any JavaDoc annotations to the generated class. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1364 | for (const std::string& annotation : options_.javadoc_annotations) { |
| 1365 | std::string proper_annotation = "@"; |
| 1366 | proper_annotation += annotation; |
| 1367 | manifest_class->GetCommentBuilder()->AppendComment(proper_annotation); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1368 | } |
| 1369 | |
Adam Lesinski | 0d81f70 | 2017-06-27 15:51:09 -0700 | [diff] [blame] | 1370 | const std::string package_utf8 = |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1371 | options_.custom_java_package.value_or(context_->GetCompilationPackage()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1372 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1373 | std::string out_path = options_.generate_java_class_path.value(); |
| 1374 | file::AppendPath(&out_path, file::PackageToPath(package_utf8)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1375 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1376 | if (!file::mkdirs(out_path)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1377 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 1378 | << "failed to create directory '" << out_path << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1379 | return false; |
| 1380 | } |
| 1381 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1382 | file::AppendPath(&out_path, "Manifest.java"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1383 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1384 | io::FileOutputStream fout(out_path); |
| 1385 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1386 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to open '" << out_path |
| 1387 | << "': " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1388 | return false; |
| 1389 | } |
| 1390 | |
Makoto Onuki | de6e6f2 | 2020-06-22 10:17:02 -0700 | [diff] [blame] | 1391 | ClassDefinition::WriteJavaFile(manifest_class.get(), package_utf8, true, |
| 1392 | false /* strip_api_annotations */, &fout); |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1393 | fout.Flush(); |
| 1394 | |
| 1395 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1396 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed writing to '" << out_path |
| 1397 | << "': " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1398 | return false; |
| 1399 | } |
| 1400 | return true; |
| 1401 | } |
| 1402 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1403 | bool WriteProguardFile(const std::optional<std::string>& out, const proguard::KeepSet& keep_set) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1404 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1405 | if (!out) { |
| 1406 | return true; |
| 1407 | } |
| 1408 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1409 | const std::string& out_path = out.value(); |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1410 | io::FileOutputStream fout(out_path); |
| 1411 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1412 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to open '" << out_path |
| 1413 | << "': " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1414 | return false; |
| 1415 | } |
| 1416 | |
Jean-Luc Coelho | 181cbfd | 2019-11-27 12:37:48 -0800 | [diff] [blame] | 1417 | proguard::WriteKeepSet(keep_set, &fout, options_.generate_minimal_proguard_rules, |
| 1418 | options_.no_proguard_location_reference); |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1419 | fout.Flush(); |
| 1420 | |
| 1421 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1422 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed writing to '" << out_path |
| 1423 | << "': " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1424 | return false; |
| 1425 | } |
| 1426 | return true; |
| 1427 | } |
| 1428 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1429 | bool MergeStaticLibrary(const std::string& input, bool override) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1430 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1431 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1432 | context_->GetDiagnostics()->Note(android::DiagMessage() |
| 1433 | << "merging static library " << input); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1434 | } |
| 1435 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 1436 | std::unique_ptr<LoadedApk> apk = LoadedApk::LoadApkFromPath(input, context_->GetDiagnostics()); |
| 1437 | if (apk == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1438 | context_->GetDiagnostics()->Error(android::DiagMessage(input) << "invalid static library"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1439 | return false; |
| 1440 | } |
| 1441 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 1442 | ResourceTable* table = apk->GetResourceTable(); |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1443 | if (table->packages.empty()) { |
| 1444 | return true; |
| 1445 | } |
| 1446 | |
| 1447 | auto lib_package_result = GetStaticLibraryPackage(table); |
| 1448 | if (!lib_package_result.has_value()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1449 | context_->GetDiagnostics()->Error(android::DiagMessage(input) << lib_package_result.error()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1450 | return false; |
| 1451 | } |
| 1452 | |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1453 | ResourceTablePackage* pkg = lib_package_result.value(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1454 | bool result; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1455 | if (options_.no_static_lib_packages) { |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1456 | // Merge all resources as if they were in the compilation package. This is the old behavior |
| 1457 | // of aapt. |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1458 | |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1459 | // Add the package to the set of --extra-packages so we emit an R.java for each library |
| 1460 | // package. |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1461 | if (!pkg->name.empty()) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1462 | options_.extra_java_packages.insert(pkg->name); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1463 | } |
| 1464 | |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1465 | // Clear the package name, so as to make the resources look like they are coming from the |
| 1466 | // local package. |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1467 | pkg->name = ""; |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1468 | result = table_merger_->Merge(android::Source(input), table, override); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1469 | |
| 1470 | } else { |
| 1471 | // This is the proper way to merge libraries, where the package name is |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1472 | // preserved and resource names are mangled. |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1473 | result = table_merger_->MergeAndMangle(android::Source(input), pkg->name, table); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1474 | } |
| 1475 | |
| 1476 | if (!result) { |
| 1477 | return false; |
| 1478 | } |
| 1479 | |
| 1480 | // Make sure to move the collection into the set of IFileCollections. |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 1481 | merged_apks_.push_back(std::move(apk)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1482 | return true; |
| 1483 | } |
| 1484 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1485 | bool MergeExportedSymbols(const android::Source& source, |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1486 | const std::vector<SourcedResourceName>& exported_symbols) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1487 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1488 | // Add the exports of this file to the table. |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1489 | for (const SourcedResourceName& exported_symbol : exported_symbols) { |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1490 | ResourceName res_name = exported_symbol.name; |
| 1491 | if (res_name.package.empty()) { |
| 1492 | res_name.package = context_->GetCompilationPackage(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1493 | } |
| 1494 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1495 | std::optional<ResourceName> mangled_name = context_->GetNameMangler()->MangleName(res_name); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1496 | if (mangled_name) { |
| 1497 | res_name = mangled_name.value(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1498 | } |
| 1499 | |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1500 | auto id = util::make_unique<Id>(); |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1501 | id->SetSource(source.WithLine(exported_symbol.line)); |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1502 | bool result = final_table_.AddResource( |
| 1503 | NewResourceBuilder(res_name).SetValue(std::move(id)).SetAllowMangled(true).Build(), |
| 1504 | context_->GetDiagnostics()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1505 | if (!result) { |
| 1506 | return false; |
| 1507 | } |
| 1508 | } |
| 1509 | return true; |
| 1510 | } |
| 1511 | |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1512 | bool MergeCompiledFile(const ResourceFile& compiled_file, io::IFile* file, bool override) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1513 | TRACE_CALL(); |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1514 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1515 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1516 | << "merging '" << compiled_file.name |
| 1517 | << "' from compiled file " << compiled_file.source); |
| 1518 | } |
| 1519 | |
| 1520 | if (!table_merger_->MergeFile(compiled_file, override, file)) { |
| 1521 | return false; |
| 1522 | } |
| 1523 | return MergeExportedSymbols(compiled_file.source, compiled_file.exported_symbols); |
| 1524 | } |
| 1525 | |
Ryan Mitchell | 4ea9075 | 2020-07-31 08:21:43 -0700 | [diff] [blame] | 1526 | // Takes a path to load as a ZIP file and merges the files within into the main ResourceTable. |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1527 | // If override is true, conflicting resources are allowed to override each other, in order of last |
| 1528 | // seen. |
| 1529 | // An io::IFileCollection is created from the ZIP file and added to the set of |
| 1530 | // io::IFileCollections that are open. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1531 | bool MergeArchive(const std::string& input, bool override) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1532 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1533 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1534 | context_->GetDiagnostics()->Note(android::DiagMessage() << "merging archive " << input); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1535 | } |
| 1536 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1537 | std::string error_str; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1538 | std::unique_ptr<io::ZipFileCollection> collection = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1539 | io::ZipFileCollection::Create(input, &error_str); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1540 | if (!collection) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1541 | context_->GetDiagnostics()->Error(android::DiagMessage(input) << error_str); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1542 | return false; |
| 1543 | } |
| 1544 | |
| 1545 | bool error = false; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1546 | for (auto iter = collection->Iterator(); iter->HasNext();) { |
| 1547 | if (!MergeFile(iter->Next(), override)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1548 | error = true; |
| 1549 | } |
| 1550 | } |
| 1551 | |
| 1552 | // Make sure to move the collection into the set of IFileCollections. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1553 | collections_.push_back(std::move(collection)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1554 | return !error; |
| 1555 | } |
| 1556 | |
Ryan Mitchell | 4ea9075 | 2020-07-31 08:21:43 -0700 | [diff] [blame] | 1557 | // Takes a path to load and merge into the main ResourceTable. If override is true, |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1558 | // conflicting resources are allowed to override each other, in order of last seen. |
| 1559 | // If the file path ends with .flata, .jar, .jack, or .zip the file is treated |
| 1560 | // as ZIP archive and the files within are merged individually. |
| 1561 | // Otherwise the file is processed on its own. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1562 | bool MergePath(const std::string& path, bool override) { |
| 1563 | if (util::EndsWith(path, ".flata") || util::EndsWith(path, ".jar") || |
| 1564 | util::EndsWith(path, ".jack") || util::EndsWith(path, ".zip")) { |
| 1565 | return MergeArchive(path, override); |
| 1566 | } else if (util::EndsWith(path, ".apk")) { |
| 1567 | return MergeStaticLibrary(path, override); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1568 | } |
| 1569 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1570 | io::IFile* file = file_collection_->InsertFile(path); |
| 1571 | return MergeFile(file, override); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1572 | } |
| 1573 | |
Ryan Mitchell | 4ea9075 | 2020-07-31 08:21:43 -0700 | [diff] [blame] | 1574 | // Takes an AAPT Container file (.apc/.flat) to load and merge into the main ResourceTable. |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1575 | // If override is true, conflicting resources are allowed to override each other, in order of last |
| 1576 | // seen. |
| 1577 | // All other file types are ignored. This is because these files could be coming from a zip, |
| 1578 | // where we could have other files like classes.dex. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1579 | bool MergeFile(io::IFile* file, bool override) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1580 | TRACE_CALL(); |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1581 | const android::Source& src = file->GetSource(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1582 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1583 | if (util::EndsWith(src.path, ".xml") || util::EndsWith(src.path, ".png")) { |
Adam Lesinski | 6a396c1 | 2016-10-20 14:38:23 -0700 | [diff] [blame] | 1584 | // Since AAPT compiles these file types and appends .flat to them, seeing |
| 1585 | // their raw extensions is a sign that they weren't compiled. |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1586 | const StringPiece file_type = util::EndsWith(src.path, ".xml") ? "XML" : "PNG"; |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1587 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
| 1588 | << "uncompiled " << file_type |
| 1589 | << " file passed as argument. Must be " |
| 1590 | "compiled first into .flat file."); |
Adam Lesinski | 6a396c1 | 2016-10-20 14:38:23 -0700 | [diff] [blame] | 1591 | return false; |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1592 | } else if (!util::EndsWith(src.path, ".apc") && !util::EndsWith(src.path, ".flat")) { |
| 1593 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1594 | context_->GetDiagnostics()->Warn(android::DiagMessage(src) << "ignoring unrecognized file"); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1595 | return true; |
| 1596 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1597 | } |
| 1598 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1599 | std::unique_ptr<io::InputStream> input_stream = file->OpenInputStream(); |
| 1600 | if (input_stream == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1601 | context_->GetDiagnostics()->Error(android::DiagMessage(src) << "failed to open file"); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1602 | return false; |
| 1603 | } |
| 1604 | |
| 1605 | if (input_stream->HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1606 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1607 | << "failed to open file: " << input_stream->GetError()); |
| 1608 | return false; |
| 1609 | } |
| 1610 | |
| 1611 | ContainerReaderEntry* entry; |
| 1612 | ContainerReader reader(input_stream.get()); |
Mohamed Heikal | 1084432 | 2018-02-07 15:17:38 -0500 | [diff] [blame] | 1613 | |
| 1614 | if (reader.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1615 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
Mohamed Heikal | 1084432 | 2018-02-07 15:17:38 -0500 | [diff] [blame] | 1616 | << "failed to read file: " << reader.GetError()); |
| 1617 | return false; |
| 1618 | } |
| 1619 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1620 | while ((entry = reader.Next()) != nullptr) { |
| 1621 | if (entry->Type() == ContainerEntryType::kResTable) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1622 | TRACE_NAME(std::string("Process ResTable:") + file->GetSource().path); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1623 | pb::ResourceTable pb_table; |
| 1624 | if (!entry->GetResTable(&pb_table)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1625 | context_->GetDiagnostics()->Error( |
| 1626 | android::DiagMessage(src) << "failed to read resource table: " << entry->GetError()); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1627 | return false; |
| 1628 | } |
| 1629 | |
| 1630 | ResourceTable table; |
| 1631 | std::string error; |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 1632 | if (!DeserializeTableFromPb(pb_table, nullptr /*files*/, &table, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1633 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1634 | << "failed to deserialize resource table: " << error); |
| 1635 | return false; |
| 1636 | } |
| 1637 | |
| 1638 | if (!table_merger_->Merge(src, &table, override)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1639 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
| 1640 | << "failed to merge resource table"); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1641 | return false; |
| 1642 | } |
| 1643 | } else if (entry->Type() == ContainerEntryType::kResFile) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1644 | TRACE_NAME(std::string("Process ResFile") + file->GetSource().path); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1645 | pb::internal::CompiledFile pb_compiled_file; |
| 1646 | off64_t offset; |
| 1647 | size_t len; |
| 1648 | if (!entry->GetResFileOffsets(&pb_compiled_file, &offset, &len)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1649 | context_->GetDiagnostics()->Error( |
| 1650 | android::DiagMessage(src) << "failed to get resource file: " << entry->GetError()); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1651 | return false; |
| 1652 | } |
| 1653 | |
| 1654 | ResourceFile resource_file; |
| 1655 | std::string error; |
| 1656 | if (!DeserializeCompiledFileFromPb(pb_compiled_file, &resource_file, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1657 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1658 | << "failed to read compiled header: " << error); |
| 1659 | return false; |
| 1660 | } |
| 1661 | |
| 1662 | if (!MergeCompiledFile(resource_file, file->CreateFileSegment(offset, len), override)) { |
| 1663 | return false; |
| 1664 | } |
| 1665 | } |
| 1666 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1667 | return true; |
| 1668 | } |
| 1669 | |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1670 | bool CopyAssetsDirsToApk(IArchiveWriter* writer) { |
| 1671 | std::map<std::string, std::unique_ptr<io::RegularFile>> merged_assets; |
| 1672 | for (const std::string& assets_dir : options_.assets_dirs) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1673 | std::optional<std::vector<std::string>> files = |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1674 | file::FindFiles(assets_dir, context_->GetDiagnostics(), nullptr); |
| 1675 | if (!files) { |
| 1676 | return false; |
| 1677 | } |
| 1678 | |
| 1679 | for (const std::string& file : files.value()) { |
| 1680 | std::string full_key = "assets/" + file; |
| 1681 | std::string full_path = assets_dir; |
| 1682 | file::AppendPath(&full_path, file); |
| 1683 | |
| 1684 | auto iter = merged_assets.find(full_key); |
| 1685 | if (iter == merged_assets.end()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1686 | merged_assets.emplace(std::move(full_key), util::make_unique<io::RegularFile>( |
| 1687 | android::Source(std::move(full_path)))); |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1688 | } else if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1689 | context_->GetDiagnostics()->Warn(android::DiagMessage(iter->second->GetSource()) |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1690 | << "asset file overrides '" << full_path << "'"); |
| 1691 | } |
| 1692 | } |
| 1693 | } |
| 1694 | |
| 1695 | for (auto& entry : merged_assets) { |
Ryan Mitchell | 81dfca0 | 2019-06-07 10:20:27 -0700 | [diff] [blame] | 1696 | uint32_t compression_flags = GetCompressionFlags(entry.first, options_); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1697 | if (!io::CopyFileToArchive(context_, entry.second.get(), entry.first, compression_flags, |
| 1698 | writer)) { |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1699 | return false; |
| 1700 | } |
| 1701 | } |
| 1702 | return true; |
| 1703 | } |
| 1704 | |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1705 | ResourceEntry* ResolveTableEntry(LinkContext* context, ResourceTable* table, |
| 1706 | Reference* reference) { |
| 1707 | if (!reference || !reference->name) { |
| 1708 | return nullptr; |
| 1709 | } |
| 1710 | auto name_ref = ResourceNameRef(reference->name.value()); |
| 1711 | if (name_ref.package.empty()) { |
| 1712 | name_ref.package = context->GetCompilationPackage(); |
| 1713 | } |
| 1714 | const auto search_result = table->FindResource(name_ref); |
| 1715 | if (!search_result) { |
| 1716 | return nullptr; |
| 1717 | } |
| 1718 | return search_result.value().entry; |
| 1719 | } |
| 1720 | |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1721 | void AliasAdaptiveIcon(xml::XmlResource* manifest, ResourceTable* table) { |
Ryan Mitchell | 30cd9b2 | 2020-02-13 10:42:44 -0800 | [diff] [blame] | 1722 | const xml::Element* application = manifest->root->FindChild("", "application"); |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1723 | if (!application) { |
| 1724 | return; |
| 1725 | } |
| 1726 | |
Ryan Mitchell | 30cd9b2 | 2020-02-13 10:42:44 -0800 | [diff] [blame] | 1727 | const xml::Attribute* icon = application->FindAttribute(xml::kSchemaAndroid, "icon"); |
| 1728 | const xml::Attribute* round_icon = application->FindAttribute(xml::kSchemaAndroid, "roundIcon"); |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1729 | if (!icon || !round_icon) { |
| 1730 | return; |
| 1731 | } |
| 1732 | |
| 1733 | // Find the icon resource defined within the application. |
Ryan Mitchell | 30cd9b2 | 2020-02-13 10:42:44 -0800 | [diff] [blame] | 1734 | const auto icon_reference = ValueCast<Reference>(icon->compiled_value.get()); |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1735 | const auto icon_entry = ResolveTableEntry(context_, table, icon_reference); |
| 1736 | if (!icon_entry) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1737 | return; |
| 1738 | } |
| 1739 | |
| 1740 | int icon_max_sdk = 0; |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1741 | for (auto& config_value : icon_entry->values) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1742 | icon_max_sdk = (icon_max_sdk < config_value->config.sdkVersion) |
| 1743 | ? config_value->config.sdkVersion : icon_max_sdk; |
| 1744 | } |
| 1745 | if (icon_max_sdk < SDK_O) { |
| 1746 | // Adaptive icons must be versioned with v26 qualifiers, so this is not an adaptive icon. |
| 1747 | return; |
| 1748 | } |
| 1749 | |
| 1750 | // Find the roundIcon resource defined within the application. |
Ryan Mitchell | 30cd9b2 | 2020-02-13 10:42:44 -0800 | [diff] [blame] | 1751 | const auto round_icon_reference = ValueCast<Reference>(round_icon->compiled_value.get()); |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1752 | const auto round_icon_entry = ResolveTableEntry(context_, table, round_icon_reference); |
| 1753 | if (!round_icon_entry) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1754 | return; |
| 1755 | } |
| 1756 | |
| 1757 | int round_icon_max_sdk = 0; |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1758 | for (auto& config_value : round_icon_entry->values) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1759 | round_icon_max_sdk = (round_icon_max_sdk < config_value->config.sdkVersion) |
| 1760 | ? config_value->config.sdkVersion : round_icon_max_sdk; |
| 1761 | } |
| 1762 | if (round_icon_max_sdk >= SDK_O) { |
| 1763 | // The developer explicitly used a v26 compatible drawable as the roundIcon, meaning we should |
| 1764 | // not generate an alias to the icon drawable. |
| 1765 | return; |
| 1766 | } |
| 1767 | |
| 1768 | // Add an equivalent v26 entry to the roundIcon for each v26 variant of the regular icon. |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1769 | for (auto& config_value : icon_entry->values) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1770 | if (config_value->config.sdkVersion < SDK_O) { |
| 1771 | continue; |
| 1772 | } |
| 1773 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1774 | context_->GetDiagnostics()->Note(android::DiagMessage() |
| 1775 | << "generating " << round_icon_reference->name.value() |
| 1776 | << " with config \"" << config_value->config |
| 1777 | << "\" for round icon compatibility"); |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1778 | |
Ryan Mitchell | efcdb95 | 2021-04-14 17:31:37 -0700 | [diff] [blame] | 1779 | CloningValueTransformer cloner(&table->string_pool); |
| 1780 | auto value = icon_reference->Transform(cloner); |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1781 | auto round_config_value = |
| 1782 | round_icon_entry->FindOrCreateValue(config_value->config, config_value->product); |
Ryan Mitchell | efcdb95 | 2021-04-14 17:31:37 -0700 | [diff] [blame] | 1783 | round_config_value->value = std::move(value); |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1784 | } |
| 1785 | } |
| 1786 | |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1787 | bool VerifySharedUserId(xml::XmlResource* manifest, ResourceTable* table) { |
| 1788 | const xml::Element* manifest_el = xml::FindRootElement(manifest->root.get()); |
| 1789 | if (manifest_el == nullptr) { |
| 1790 | return true; |
| 1791 | } |
| 1792 | if (!manifest_el->namespace_uri.empty() || manifest_el->name != "manifest") { |
| 1793 | return true; |
| 1794 | } |
| 1795 | const xml::Attribute* attr = manifest_el->FindAttribute(xml::kSchemaAndroid, "sharedUserId"); |
| 1796 | if (!attr) { |
| 1797 | return true; |
| 1798 | } |
| 1799 | const auto validate = [&](const std::string& shared_user_id) -> bool { |
| 1800 | if (util::IsAndroidSharedUserId(context_->GetCompilationPackage(), shared_user_id)) { |
| 1801 | return true; |
| 1802 | } |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1803 | android::DiagMessage error_msg(manifest_el->line_number); |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1804 | error_msg << "attribute 'sharedUserId' in <manifest> tag is not a valid shared user id: '" |
| 1805 | << shared_user_id << "'"; |
| 1806 | if (options_.manifest_fixer_options.warn_validation) { |
| 1807 | // Treat the error only as a warning. |
| 1808 | context_->GetDiagnostics()->Warn(error_msg); |
| 1809 | return true; |
| 1810 | } |
| 1811 | context_->GetDiagnostics()->Error(error_msg); |
| 1812 | return false; |
| 1813 | }; |
| 1814 | // If attr->compiled_value is not null, check if it is a ref |
| 1815 | if (attr->compiled_value) { |
| 1816 | const auto ref = ValueCast<Reference>(attr->compiled_value.get()); |
| 1817 | if (ref == nullptr) { |
| 1818 | return true; |
| 1819 | } |
| 1820 | const auto shared_user_id_entry = ResolveTableEntry(context_, table, ref); |
| 1821 | if (!shared_user_id_entry) { |
| 1822 | return true; |
| 1823 | } |
| 1824 | for (const auto& value : shared_user_id_entry->values) { |
| 1825 | const auto str_value = ValueCast<String>(value->value.get()); |
| 1826 | if (str_value != nullptr && !validate(*str_value->value)) { |
| 1827 | return false; |
| 1828 | } |
| 1829 | } |
| 1830 | return true; |
| 1831 | } |
| 1832 | |
| 1833 | // Fallback to checking the raw value |
| 1834 | return validate(attr->value); |
| 1835 | } |
| 1836 | |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1837 | // Writes the AndroidManifest, ResourceTable, and all XML files referenced by the ResourceTable |
| 1838 | // to the IArchiveWriter. |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1839 | bool WriteApk(IArchiveWriter* writer, proguard::KeepSet* keep_set, xml::XmlResource* manifest, |
| 1840 | ResourceTable* table) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1841 | TRACE_CALL(); |
Ryan Mitchell | 479fa39 | 2019-01-02 17:15:39 -0800 | [diff] [blame] | 1842 | const bool keep_raw_values = (context_->GetPackageType() == PackageType::kStaticLib) |
| 1843 | || options_.keep_raw_values; |
Ryan Mitchell | 467b689 | 2018-11-09 15:52:07 -0800 | [diff] [blame] | 1844 | bool result = FlattenXml(context_, *manifest, kAndroidManifestPath, keep_raw_values, |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1845 | true /*utf16*/, options_.output_format, writer); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1846 | if (!result) { |
| 1847 | return false; |
| 1848 | } |
| 1849 | |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1850 | // When a developer specifies an adaptive application icon, and a non-adaptive round application |
| 1851 | // icon, create an alias from the round icon to the regular icon for v26 APIs and up. We do this |
| 1852 | // because certain devices prefer android:roundIcon over android:icon regardless of the API |
| 1853 | // levels of the drawables set for either. This auto-aliasing behaviour allows an app to prefer |
| 1854 | // the android:roundIcon on API 25 devices, and prefer the adaptive icon on API 26 devices. |
| 1855 | // See (b/34829129) |
| 1856 | AliasAdaptiveIcon(manifest, table); |
| 1857 | |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1858 | // Verify the shared user id here to handle the case of reference value. |
| 1859 | if (!VerifySharedUserId(manifest, table)) { |
| 1860 | return false; |
| 1861 | } |
| 1862 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1863 | ResourceFileFlattenerOptions file_flattener_options; |
| 1864 | file_flattener_options.keep_raw_values = keep_raw_values; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1865 | file_flattener_options.do_not_compress_anything = options_.do_not_compress_anything; |
| 1866 | file_flattener_options.extensions_to_not_compress = options_.extensions_to_not_compress; |
Izabela Orlowska | 0faba5f | 2018-06-01 12:06:31 +0100 | [diff] [blame] | 1867 | file_flattener_options.regex_to_not_compress = options_.regex_to_not_compress; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1868 | file_flattener_options.no_auto_version = options_.no_auto_version; |
| 1869 | file_flattener_options.no_version_vectors = options_.no_version_vectors; |
Yuichi Araki | 4d35cca | 2017-01-18 20:42:17 +0900 | [diff] [blame] | 1870 | file_flattener_options.no_version_transitions = options_.no_version_transitions; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1871 | file_flattener_options.no_xml_namespaces = options_.no_xml_namespaces; |
| 1872 | file_flattener_options.update_proguard_spec = |
| 1873 | static_cast<bool>(options_.generate_proguard_rules_path); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1874 | file_flattener_options.output_format = options_.output_format; |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 1875 | file_flattener_options.do_not_fail_on_missing_resources = options_.merge_only; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1876 | |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 1877 | ResourceFileFlattener file_flattener(file_flattener_options, context_, keep_set); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1878 | if (!file_flattener.Flatten(table, writer)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1879 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed linking file resources"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1880 | return false; |
| 1881 | } |
| 1882 | |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1883 | // Hack to fix b/68820737. |
| 1884 | // We need to modify the ResourceTable's package name, but that should NOT affect |
| 1885 | // anything else being generated, which includes the Java classes. |
| 1886 | // If required, the package name is modifed before flattening, and then modified back |
| 1887 | // to its original name. |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1888 | ResourceTablePackage* package_to_rewrite = nullptr; |
Todd Kennedy | 3251299 | 2018-04-25 16:45:59 -0700 | [diff] [blame] | 1889 | // Pre-O, the platform treats negative resource IDs [those with a package ID of 0x80 |
| 1890 | // or higher] as invalid. In order to work around this limitation, we allow the use |
| 1891 | // of traditionally reserved resource IDs [those between 0x02 and 0x7E]. Allow the |
| 1892 | // definition of what a valid "split" package ID is to account for this. |
| 1893 | const bool isSplitPackage = (options_.allow_reserved_package_id && |
| 1894 | context_->GetPackageId() != kAppPackageId && |
| 1895 | context_->GetPackageId() != kFrameworkPackageId) |
| 1896 | || (!options_.allow_reserved_package_id && context_->GetPackageId() > kAppPackageId); |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1897 | if (isSplitPackage && included_feature_base_ == context_->GetCompilationPackage()) { |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1898 | // The base APK is included, and this is a feature split. If the base package is |
| 1899 | // the same as this package, then we are building an old style Android Instant Apps feature |
| 1900 | // split and must apply this workaround to avoid requiring namespaces support. |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1901 | if (!table->packages.empty() && |
| 1902 | table->packages.back()->name == context_->GetCompilationPackage()) { |
| 1903 | package_to_rewrite = table->packages.back().get(); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1904 | std::string new_package_name = |
| 1905 | StringPrintf("%s.%s", package_to_rewrite->name.c_str(), |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1906 | app_info_.split_name.value_or("feature").c_str()); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1907 | |
| 1908 | if (context_->IsVerbose()) { |
| 1909 | context_->GetDiagnostics()->Note( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1910 | android::DiagMessage() << "rewriting resource package name for feature split to '" |
| 1911 | << new_package_name << "'"); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1912 | } |
| 1913 | package_to_rewrite->name = new_package_name; |
| 1914 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1915 | } |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1916 | |
| 1917 | bool success = FlattenTable(table, options_.output_format, writer); |
| 1918 | |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1919 | if (package_to_rewrite != nullptr) { |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1920 | // Change the name back. |
| 1921 | package_to_rewrite->name = context_->GetCompilationPackage(); |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1922 | |
| 1923 | // TableFlattener creates an `included_packages_` mapping entry for each package with a |
| 1924 | // non-standard package id (not 0x01 or 0x7f). Since this is a feature split and not a shared |
| 1925 | // library, do not include a mapping from the feature package name to the feature package id |
| 1926 | // in the feature's dynamic reference table. |
| 1927 | table->included_packages_.erase(context_->GetPackageId()); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1928 | } |
| 1929 | |
| 1930 | if (!success) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1931 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to write resource table"); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1932 | } |
| 1933 | return success; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1934 | } |
| 1935 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1936 | int Run(const std::vector<std::string>& input_files) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1937 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1938 | // Load the AndroidManifest.xml |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1939 | std::unique_ptr<xml::XmlResource> manifest_xml = |
| 1940 | LoadXml(options_.manifest_path, context_->GetDiagnostics()); |
| 1941 | if (!manifest_xml) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1942 | return 1; |
| 1943 | } |
| 1944 | |
Ryan Mitchell | 2b7e847 | 2020-05-06 11:26:48 -0700 | [diff] [blame] | 1945 | // First extract the Package name without modifying it (via --rename-manifest-package). |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1946 | if (std::optional<AppInfo> maybe_app_info = |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1947 | ExtractAppInfoFromManifest(manifest_xml.get(), context_->GetDiagnostics())) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1948 | const AppInfo& app_info = maybe_app_info.value(); |
| 1949 | context_->SetCompilationPackage(app_info.package); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1950 | } |
| 1951 | |
Ryan Mitchell | 2b7e847 | 2020-05-06 11:26:48 -0700 | [diff] [blame] | 1952 | // Determine the package name under which to merge resources. |
| 1953 | if (options_.rename_resources_package) { |
| 1954 | if (!options_.custom_java_package) { |
| 1955 | // Generate the R.java under the original package name instead of the package name specified |
| 1956 | // through --rename-resources-package. |
| 1957 | options_.custom_java_package = context_->GetCompilationPackage(); |
| 1958 | } |
| 1959 | context_->SetCompilationPackage(options_.rename_resources_package.value()); |
| 1960 | } |
| 1961 | |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 1962 | // Now that the compilation package is set, load the dependencies. This will also extract |
| 1963 | // the Android framework's versionCode and versionName, if they exist. |
| 1964 | if (!LoadSymbolsFromIncludePaths()) { |
| 1965 | return 1; |
| 1966 | } |
| 1967 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1968 | ManifestFixer manifest_fixer(options_.manifest_fixer_options); |
| 1969 | if (!manifest_fixer.Consume(context_, manifest_xml.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1970 | return 1; |
| 1971 | } |
| 1972 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1973 | std::optional<AppInfo> maybe_app_info = |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1974 | ExtractAppInfoFromManifest(manifest_xml.get(), context_->GetDiagnostics()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1975 | if (!maybe_app_info) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1976 | return 1; |
| 1977 | } |
| 1978 | |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1979 | app_info_ = maybe_app_info.value(); |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1980 | context_->SetMinSdkVersion(app_info_.min_sdk_version.value_or(0)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1981 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1982 | context_->SetNameManglerPolicy(NameManglerPolicy{context_->GetCompilationPackage()}); |
Udam Saini | b228df3 | 2019-06-18 16:50:34 -0700 | [diff] [blame] | 1983 | context_->SetSplitNameDependencies(app_info_.split_name_dependencies); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 1984 | |
| 1985 | // Override the package ID when it is "android". |
| 1986 | if (context_->GetCompilationPackage() == "android") { |
Ryan Mitchell | 22dc531 | 2020-06-01 12:17:07 -0700 | [diff] [blame] | 1987 | context_->SetPackageId(kAndroidPackageId); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 1988 | |
| 1989 | // Verify we're building a regular app. |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 1990 | if (context_->GetPackageType() != PackageType::kApp) { |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 1991 | context_->GetDiagnostics()->Error( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1992 | android::DiagMessage() << "package 'android' can only be built as a regular app"); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 1993 | return 1; |
| 1994 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1995 | } |
| 1996 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1997 | TableMergerOptions table_merger_options; |
| 1998 | table_merger_options.auto_add_overlay = options_.auto_add_overlay; |
Donald Chai | 121c6e8 | 2019-06-12 12:51:57 -0700 | [diff] [blame] | 1999 | table_merger_options.override_styles_instead_of_overlaying = |
| 2000 | options_.override_styles_instead_of_overlaying; |
Izabela Orlowska | d51efe8 | 2018-04-24 18:18:29 +0100 | [diff] [blame] | 2001 | table_merger_options.strict_visibility = options_.strict_visibility; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2002 | table_merger_ = util::make_unique<TableMerger>(context_, &final_table_, table_merger_options); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2003 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2004 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2005 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2006 | << StringPrintf("linking package '%s' using package ID %02x", |
| 2007 | context_->GetCompilationPackage().data(), |
| 2008 | context_->GetPackageId())); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2009 | } |
| 2010 | |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 2011 | // Extract symbols from AndroidManifest.xml, since this isn't merged like the other XML files |
| 2012 | // in res/**/*. |
| 2013 | { |
| 2014 | XmlIdCollector collector; |
| 2015 | if (!collector.Consume(context_, manifest_xml.get())) { |
| 2016 | return false; |
| 2017 | } |
| 2018 | |
| 2019 | if (!MergeExportedSymbols(manifest_xml->file.source, manifest_xml->file.exported_symbols)) { |
| 2020 | return false; |
| 2021 | } |
| 2022 | } |
| 2023 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2024 | for (const std::string& input : input_files) { |
| 2025 | if (!MergePath(input, false)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2026 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed parsing input"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2027 | return 1; |
| 2028 | } |
| 2029 | } |
| 2030 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2031 | for (const std::string& input : options_.overlay_files) { |
| 2032 | if (!MergePath(input, true)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2033 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed parsing overlays"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2034 | return 1; |
| 2035 | } |
| 2036 | } |
| 2037 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2038 | if (!VerifyNoExternalPackages()) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2039 | return 1; |
| 2040 | } |
| 2041 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2042 | if (context_->GetPackageType() != PackageType::kStaticLib) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2043 | PrivateAttributeMover mover; |
Ryan Mitchell | 22dc531 | 2020-06-01 12:17:07 -0700 | [diff] [blame] | 2044 | if (context_->GetPackageId() == kAndroidPackageId && |
| 2045 | !mover.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2046 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 2047 | << "failed moving private attributes"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2048 | return 1; |
| 2049 | } |
| 2050 | |
| 2051 | // Assign IDs if we are building a regular app. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2052 | IdAssigner id_assigner(&options_.stable_id_map); |
| 2053 | if (!id_assigner.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2054 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed assigning IDs"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2055 | return 1; |
| 2056 | } |
| 2057 | |
| 2058 | // Now grab each ID and emit it as a file. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2059 | if (options_.resource_id_map_path) { |
| 2060 | for (auto& package : final_table_.packages) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2061 | for (auto& type : package->types) { |
| 2062 | for (auto& entry : type->entries) { |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 2063 | ResourceName name(package->name, type->named_type, entry->name); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2064 | // The IDs are guaranteed to exist. |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 2065 | options_.stable_id_map[std::move(name)] = entry->id.value(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2066 | } |
| 2067 | } |
| 2068 | } |
| 2069 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2070 | if (!WriteStableIdMapToPath(context_->GetDiagnostics(), options_.stable_id_map, |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2071 | options_.resource_id_map_path.value())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2072 | return 1; |
| 2073 | } |
| 2074 | } |
| 2075 | } else { |
| 2076 | // Static libs are merged with other apps, and ID collisions are bad, so |
| 2077 | // verify that |
| 2078 | // no IDs have been set. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2079 | if (!VerifyNoIdsSet()) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2080 | return 1; |
| 2081 | } |
| 2082 | } |
| 2083 | |
| 2084 | // Add the names to mangle based on our source merge earlier. |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2085 | context_->SetNameManglerPolicy( |
| 2086 | NameManglerPolicy{context_->GetCompilationPackage(), table_merger_->merged_packages()}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2087 | |
| 2088 | // Add our table to the symbol table. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2089 | context_->GetExternalSymbols()->PrependSource( |
| 2090 | util::make_unique<ResourceTableSymbolSource>(&final_table_)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2091 | |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 2092 | // Workaround for pre-O runtime that would treat negative resource IDs |
| 2093 | // (any ID with a package ID > 7f) as invalid. Intercept any ID (PPTTEEEE) with PP > 0x7f |
| 2094 | // and type == 'id', and return the ID 0x7fPPEEEE. IDs don't need to be real resources, they |
| 2095 | // are just identifiers. |
| 2096 | if (context_->GetMinSdkVersion() < SDK_O && context_->GetPackageType() == PackageType::kApp) { |
| 2097 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2098 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 2099 | << "enabling pre-O feature split ID rewriting"); |
| 2100 | } |
| 2101 | context_->GetExternalSymbols()->SetDelegate( |
| 2102 | util::make_unique<FeatureSplitSymbolTableDelegate>(context_)); |
| 2103 | } |
| 2104 | |
Adam Lesinski | 34a1687 | 2018-02-23 16:18:10 -0800 | [diff] [blame] | 2105 | // Before we process anything, remove the resources whose default values don't exist. |
| 2106 | // We want to force any references to these to fail the build. |
MÃ¥rten Kongstad | d8d2901 | 2018-06-11 14:13:37 +0200 | [diff] [blame] | 2107 | if (!options_.no_resource_removal) { |
| 2108 | if (!NoDefaultResourceRemover{}.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2109 | context_->GetDiagnostics()->Error(android::DiagMessage() |
MÃ¥rten Kongstad | d8d2901 | 2018-06-11 14:13:37 +0200 | [diff] [blame] | 2110 | << "failed removing resources with no defaults"); |
| 2111 | return 1; |
| 2112 | } |
Adam Lesinski | 34a1687 | 2018-02-23 16:18:10 -0800 | [diff] [blame] | 2113 | } |
| 2114 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2115 | ReferenceLinker linker; |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 2116 | if (!options_.merge_only && !linker.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2117 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed linking references"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2118 | return 1; |
| 2119 | } |
| 2120 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2121 | if (context_->GetPackageType() == PackageType::kStaticLib) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2122 | if (!options_.products.empty()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2123 | context_->GetDiagnostics()->Warn(android::DiagMessage() |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 2124 | << "can't select products when building static library"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2125 | } |
| 2126 | } else { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2127 | ProductFilter product_filter(options_.products); |
| 2128 | if (!product_filter.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2129 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed stripping products"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2130 | return 1; |
| 2131 | } |
| 2132 | } |
| 2133 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2134 | if (!options_.no_auto_version) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2135 | AutoVersioner versioner; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2136 | if (!versioner.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2137 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed versioning styles"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2138 | return 1; |
| 2139 | } |
| 2140 | } |
| 2141 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2142 | if (context_->GetPackageType() != PackageType::kStaticLib && context_->GetMinSdkVersion() > 0) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2143 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2144 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2145 | << "collapsing resource versions for minimum SDK " |
| 2146 | << context_->GetMinSdkVersion()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2147 | } |
| 2148 | |
| 2149 | VersionCollapser collapser; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2150 | if (!collapser.Consume(context_, &final_table_)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2151 | return 1; |
| 2152 | } |
| 2153 | } |
| 2154 | |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 2155 | if (!options_.exclude_configs_.empty()) { |
| 2156 | std::vector<ConfigDescription> excluded_configs; |
| 2157 | |
| 2158 | for (auto& config_string : options_.exclude_configs_) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 2159 | TRACE_NAME("ConfigDescription::Parse"); |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 2160 | ConfigDescription config_description; |
| 2161 | |
| 2162 | if (!ConfigDescription::Parse(config_string, &config_description)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2163 | context_->GetDiagnostics()->Error( |
| 2164 | android::DiagMessage() << "failed to parse --excluded-configs " << config_string); |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 2165 | return 1; |
| 2166 | } |
| 2167 | |
| 2168 | excluded_configs.push_back(config_description); |
| 2169 | } |
| 2170 | |
| 2171 | ResourceExcluder excluder(excluded_configs); |
| 2172 | if (!excluder.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2173 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 2174 | << "failed excluding configurations"); |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 2175 | return 1; |
| 2176 | } |
| 2177 | } |
| 2178 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2179 | if (!options_.no_resource_deduping) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2180 | ResourceDeduper deduper; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2181 | if (!deduper.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2182 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed deduping resources"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2183 | return 1; |
| 2184 | } |
| 2185 | } |
| 2186 | |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 2187 | proguard::KeepSet proguard_keep_set = |
| 2188 | proguard::KeepSet(options_.generate_conditional_proguard_rules); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2189 | proguard::KeepSet proguard_main_dex_keep_set; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2190 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2191 | if (context_->GetPackageType() == PackageType::kStaticLib) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2192 | if (options_.table_splitter_options.config_filter != nullptr || |
Pierre Lecesne | 672384b | 2017-02-06 10:29:02 +0000 | [diff] [blame] | 2193 | !options_.table_splitter_options.preferred_densities.empty()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2194 | context_->GetDiagnostics()->Warn(android::DiagMessage() |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 2195 | << "can't strip resources when building static library"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2196 | } |
| 2197 | } else { |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2198 | // Adjust the SplitConstraints so that their SDK version is stripped if it is less than or |
| 2199 | // equal to the minSdk. |
Todd Kennedy | 9fbdf89 | 2018-08-28 16:31:15 -0700 | [diff] [blame] | 2200 | const size_t origConstraintSize = options_.split_constraints.size(); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2201 | options_.split_constraints = |
| 2202 | AdjustSplitConstraintsForMinSdk(context_->GetMinSdkVersion(), options_.split_constraints); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2203 | |
Todd Kennedy | 9fbdf89 | 2018-08-28 16:31:15 -0700 | [diff] [blame] | 2204 | if (origConstraintSize != options_.split_constraints.size()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2205 | context_->GetDiagnostics()->Warn(android::DiagMessage() |
Todd Kennedy | 9fbdf89 | 2018-08-28 16:31:15 -0700 | [diff] [blame] | 2206 | << "requested to split resources prior to min sdk of " |
| 2207 | << context_->GetMinSdkVersion()); |
| 2208 | } |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2209 | TableSplitter table_splitter(options_.split_constraints, options_.table_splitter_options); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2210 | if (!table_splitter.VerifySplitConstraints(context_)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2211 | return 1; |
| 2212 | } |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2213 | table_splitter.SplitTable(&final_table_); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2214 | |
| 2215 | // Now we need to write out the Split APKs. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2216 | auto path_iter = options_.split_paths.begin(); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2217 | auto split_constraints_iter = options_.split_constraints.begin(); |
| 2218 | for (std::unique_ptr<ResourceTable>& split_table : table_splitter.splits()) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2219 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2220 | context_->GetDiagnostics()->Note(android::DiagMessage(*path_iter) |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2221 | << "generating split with configurations '" |
| 2222 | << util::Joiner(split_constraints_iter->configs, ", ") |
| 2223 | << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2224 | } |
| 2225 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2226 | std::unique_ptr<IArchiveWriter> archive_writer = MakeArchiveWriter(*path_iter); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2227 | if (!archive_writer) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2228 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to create archive"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2229 | return 1; |
| 2230 | } |
| 2231 | |
| 2232 | // Generate an AndroidManifest.xml for each split. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2233 | std::unique_ptr<xml::XmlResource> split_manifest = |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 2234 | GenerateSplitManifest(app_info_, *split_constraints_iter); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2235 | |
Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 2236 | XmlReferenceLinker linker(&final_table_); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2237 | if (!linker.Consume(context_, split_manifest.get())) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2238 | context_->GetDiagnostics()->Error(android::DiagMessage() |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2239 | << "failed to create Split AndroidManifest.xml"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2240 | return 1; |
| 2241 | } |
| 2242 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2243 | if (!WriteApk(archive_writer.get(), &proguard_keep_set, split_manifest.get(), |
| 2244 | split_table.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2245 | return 1; |
| 2246 | } |
| 2247 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2248 | ++path_iter; |
| 2249 | ++split_constraints_iter; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2250 | } |
| 2251 | } |
| 2252 | |
| 2253 | // Start writing the base APK. |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 2254 | std::unique_ptr<IArchiveWriter> archive_writer = MakeArchiveWriter(options_.output_path); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2255 | if (!archive_writer) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2256 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to create archive"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2257 | return 1; |
| 2258 | } |
| 2259 | |
| 2260 | bool error = false; |
| 2261 | { |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 2262 | // AndroidManifest.xml has no resource name, but the CallSite is built from the name |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2263 | // (aka, which package the AndroidManifest.xml is coming from). |
| 2264 | // So we give it a package name so it can see local resources. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2265 | manifest_xml->file.name.package = context_->GetCompilationPackage(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2266 | |
Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 2267 | XmlReferenceLinker manifest_linker(&final_table_); |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 2268 | if (options_.merge_only || manifest_linker.Consume(context_, manifest_xml.get())) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2269 | if (options_.generate_proguard_rules_path && |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 2270 | !proguard::CollectProguardRulesForManifest(manifest_xml.get(), &proguard_keep_set)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2271 | error = true; |
| 2272 | } |
| 2273 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2274 | if (options_.generate_main_dex_proguard_rules_path && |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 2275 | !proguard::CollectProguardRulesForManifest(manifest_xml.get(), |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 2276 | &proguard_main_dex_keep_set, true)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2277 | error = true; |
Alexandria Cornwall | 637b482 | 2016-08-11 09:53:16 -0700 | [diff] [blame] | 2278 | } |
| 2279 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2280 | if (options_.generate_java_class_path) { |
| 2281 | if (!WriteManifestJavaFile(manifest_xml.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2282 | error = true; |
| 2283 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2284 | } |
| 2285 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2286 | if (options_.no_xml_namespaces) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2287 | // PackageParser will fail if URIs are removed from |
| 2288 | // AndroidManifest.xml. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2289 | XmlNamespaceRemover namespace_remover(true /* keepUris */); |
| 2290 | if (!namespace_remover.Consume(context_, manifest_xml.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2291 | error = true; |
| 2292 | } |
Rohit Agrawal | e49bb30 | 2016-04-22 12:27:55 -0700 | [diff] [blame] | 2293 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2294 | } else { |
| 2295 | error = true; |
| 2296 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2297 | } |
Adam Lesinski | fb48d29 | 2015-11-07 15:52:13 -0800 | [diff] [blame] | 2298 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2299 | if (error) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2300 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed processing manifest"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2301 | return 1; |
| 2302 | } |
Adam Lesinski | a6fe345 | 2015-12-09 15:20:52 -0800 | [diff] [blame] | 2303 | |
Josh Hou | ec67cb4 | 2022-06-09 19:19:21 +0800 | [diff] [blame^] | 2304 | if (!VerifyLocaleFormat(manifest_xml.get(), context_->GetDiagnostics())) { |
| 2305 | return 1; |
| 2306 | }; |
| 2307 | |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 2308 | if (!WriteApk(archive_writer.get(), &proguard_keep_set, manifest_xml.get(), &final_table_)) { |
| 2309 | return 1; |
| 2310 | } |
| 2311 | |
| 2312 | if (!CopyAssetsDirsToApk(archive_writer.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2313 | return 1; |
| 2314 | } |
Adam Lesinski | fb48d29 | 2015-11-07 15:52:13 -0800 | [diff] [blame] | 2315 | |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 2316 | if (options_.generate_java_class_path || options_.generate_text_symbols_path) { |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 2317 | if (!GenerateJavaClasses()) { |
Adam Lesinski | b5dc4bd | 2017-02-22 19:29:29 -0800 | [diff] [blame] | 2318 | return 1; |
| 2319 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2320 | } |
| 2321 | |
Adam Lesinski | b5dc4bd | 2017-02-22 19:29:29 -0800 | [diff] [blame] | 2322 | if (!WriteProguardFile(options_.generate_proguard_rules_path, proguard_keep_set)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2323 | return 1; |
| 2324 | } |
| 2325 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2326 | if (!WriteProguardFile(options_.generate_main_dex_proguard_rules_path, |
| 2327 | proguard_main_dex_keep_set)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2328 | return 1; |
| 2329 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2330 | return 0; |
| 2331 | } |
| 2332 | |
| 2333 | private: |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2334 | LinkOptions options_; |
| 2335 | LinkContext* context_; |
| 2336 | ResourceTable final_table_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2337 | |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 2338 | AppInfo app_info_; |
| 2339 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2340 | std::unique_ptr<TableMerger> table_merger_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2341 | |
| 2342 | // A pointer to the FileCollection representing the filesystem (not archives). |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2343 | std::unique_ptr<io::FileCollection> file_collection_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2344 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 2345 | // A vector of IFileCollections. This is mainly here to retain ownership of the |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2346 | // collections. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2347 | std::vector<std::unique_ptr<io::IFileCollection>> collections_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2348 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 2349 | // The set of merged APKs. This is mainly here to retain ownership of the APKs. |
| 2350 | std::vector<std::unique_ptr<LoadedApk>> merged_apks_; |
| 2351 | |
| 2352 | // The set of included APKs (not merged). This is mainly here to retain ownership of the APKs. |
| 2353 | std::vector<std::unique_ptr<LoadedApk>> static_library_includes_; |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 2354 | |
| 2355 | // The set of shared libraries being used, mapping their assigned package ID to package name. |
| 2356 | std::map<size_t, std::string> shared_libs_; |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 2357 | |
| 2358 | // The package name of the base application, if it is included. |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 2359 | std::optional<std::string> included_feature_base_; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2360 | }; |
| 2361 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2362 | int LinkCommand::Action(const std::vector<std::string>& args) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 2363 | TRACE_FLUSH(trace_folder_ ? trace_folder_.value() : "", "LinkCommand::Action"); |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2364 | LinkContext context(diag_); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2365 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2366 | // Expand all argument-files passed into the command line. These start with '@'. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2367 | std::vector<std::string> arg_list; |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2368 | for (const std::string& arg : args) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2369 | if (util::StartsWith(arg, "@")) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2370 | const std::string path = arg.substr(1, arg.size() - 1); |
| 2371 | std::string error; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2372 | if (!file::AppendArgsFromFile(path, &arg_list, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2373 | context.GetDiagnostics()->Error(android::DiagMessage(path) << error); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2374 | return 1; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2375 | } |
| 2376 | } else { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2377 | arg_list.push_back(arg); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2378 | } |
| 2379 | } |
| 2380 | |
| 2381 | // Expand all argument-files passed to -R. |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2382 | for (const std::string& arg : overlay_arg_list_) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2383 | if (util::StartsWith(arg, "@")) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2384 | const std::string path = arg.substr(1, arg.size() - 1); |
| 2385 | std::string error; |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2386 | if (!file::AppendArgsFromFile(path, &options_.overlay_files, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2387 | context.GetDiagnostics()->Error(android::DiagMessage(path) << error); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2388 | return 1; |
| 2389 | } |
| 2390 | } else { |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2391 | options_.overlay_files.push_back(arg); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2392 | } |
| 2393 | } |
| 2394 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2395 | if (verbose_) { |
| 2396 | context.SetVerbose(verbose_); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2397 | } |
| 2398 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2399 | if (int{shared_lib_} + int{static_lib_} + int{proto_format_} > 1) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2400 | context.GetDiagnostics() |
| 2401 | ->Error(android::DiagMessage() |
| 2402 | << "only one of --shared-lib, --static-lib, or --proto_format can be defined"); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2403 | return 1; |
| 2404 | } |
| 2405 | |
Ryan Mitchell | 5855de7 | 2021-02-24 14:39:13 -0800 | [diff] [blame] | 2406 | if (shared_lib_ && options_.private_symbols) { |
| 2407 | // If a shared library styleable in a public R.java uses a private attribute, attempting to |
| 2408 | // reference the private attribute within the styleable array will cause a link error because |
| 2409 | // the private attribute will not be emitted in the public R.java. |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2410 | context.GetDiagnostics()->Error(android::DiagMessage() |
Ryan Mitchell | 5855de7 | 2021-02-24 14:39:13 -0800 | [diff] [blame] | 2411 | << "--shared-lib cannot currently be used in combination with" |
| 2412 | << " --private-symbols"); |
| 2413 | return 1; |
| 2414 | } |
| 2415 | |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 2416 | if (options_.merge_only && !static_lib_) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2417 | context.GetDiagnostics() |
| 2418 | ->Error(android::DiagMessage() |
| 2419 | << "the --merge-only flag can be only used when building a static library"); |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 2420 | return 1; |
| 2421 | } |
| 2422 | |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 2423 | // The default build type. |
| 2424 | context.SetPackageType(PackageType::kApp); |
| 2425 | context.SetPackageId(kAppPackageId); |
| 2426 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2427 | if (shared_lib_) { |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2428 | context.SetPackageType(PackageType::kSharedLib); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2429 | context.SetPackageId(0x00); |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2430 | } else if (static_lib_) { |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2431 | context.SetPackageType(PackageType::kStaticLib); |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2432 | options_.output_format = OutputFormat::kProto; |
| 2433 | } else if (proto_format_) { |
| 2434 | options_.output_format = OutputFormat::kProto; |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2435 | } |
| 2436 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2437 | if (package_id_) { |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2438 | if (context.GetPackageType() != PackageType::kApp) { |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2439 | context.GetDiagnostics()->Error( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2440 | android::DiagMessage() << "can't specify --package-id when not building a regular app"); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2441 | return 1; |
| 2442 | } |
| 2443 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 2444 | const std::optional<uint32_t> maybe_package_id_int = |
| 2445 | ResourceUtils::ParseInt(package_id_.value()); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2446 | if (!maybe_package_id_int) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2447 | context.GetDiagnostics()->Error(android::DiagMessage() |
| 2448 | << "package ID '" << package_id_.value() |
| 2449 | << "' is not a valid integer"); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2450 | return 1; |
| 2451 | } |
| 2452 | |
| 2453 | const uint32_t package_id_int = maybe_package_id_int.value(); |
Todd Kennedy | 3251299 | 2018-04-25 16:45:59 -0700 | [diff] [blame] | 2454 | if (package_id_int > std::numeric_limits<uint8_t>::max() |
| 2455 | || package_id_int == kFrameworkPackageId |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2456 | || (!options_.allow_reserved_package_id && package_id_int < kAppPackageId)) { |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2457 | context.GetDiagnostics()->Error( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2458 | android::DiagMessage() << StringPrintf( |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2459 | "invalid package ID 0x%02x. Must be in the range 0x7f-0xff.", package_id_int)); |
| 2460 | return 1; |
| 2461 | } |
| 2462 | context.SetPackageId(static_cast<uint8_t>(package_id_int)); |
| 2463 | } |
| 2464 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2465 | // Populate the set of extra packages for which to generate R.java. |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2466 | for (std::string& extra_package : extra_java_packages_) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2467 | // A given package can actually be a colon separated list of packages. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2468 | for (StringPiece package : util::Split(extra_package, ':')) { |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2469 | options_.extra_java_packages.insert(package.to_string()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2470 | } |
| 2471 | } |
| 2472 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2473 | if (product_list_) { |
| 2474 | for (StringPiece product : util::Tokenize(product_list_.value(), ',')) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2475 | if (product != "" && product != "default") { |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2476 | options_.products.insert(product.to_string()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2477 | } |
| 2478 | } |
| 2479 | } |
| 2480 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2481 | std::unique_ptr<IConfigFilter> filter; |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2482 | if (!configs_.empty()) { |
| 2483 | filter = ParseConfigFilterParameters(configs_, context.GetDiagnostics()); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2484 | if (filter == nullptr) { |
| 2485 | return 1; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2486 | } |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2487 | options_.table_splitter_options.config_filter = filter.get(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2488 | } |
| 2489 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2490 | if (preferred_density_) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 2491 | std::optional<uint16_t> density = |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2492 | ParseTargetDensityParameter(preferred_density_.value(), context.GetDiagnostics()); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2493 | if (!density) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2494 | return 1; |
Adam Lesinski | c51562c | 2016-04-28 11:12:38 -0700 | [diff] [blame] | 2495 | } |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2496 | options_.table_splitter_options.preferred_densities.push_back(density.value()); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2497 | } |
Adam Lesinski | c51562c | 2016-04-28 11:12:38 -0700 | [diff] [blame] | 2498 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2499 | // Parse the split parameters. |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2500 | for (const std::string& split_arg : split_args_) { |
| 2501 | options_.split_paths.push_back({}); |
| 2502 | options_.split_constraints.push_back({}); |
| 2503 | if (!ParseSplitParameter(split_arg, context.GetDiagnostics(), &options_.split_paths.back(), |
| 2504 | &options_.split_constraints.back())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2505 | return 1; |
Adam Lesinski | 1e21ff0 | 2016-06-24 14:57:58 -0700 | [diff] [blame] | 2506 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2507 | } |
Adam Lesinski | 1e21ff0 | 2016-06-24 14:57:58 -0700 | [diff] [blame] | 2508 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2509 | if (context.GetPackageType() != PackageType::kStaticLib && stable_id_file_path_) { |
| 2510 | if (!LoadStableIdMap(context.GetDiagnostics(), stable_id_file_path_.value(), |
| 2511 | &options_.stable_id_map)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2512 | return 1; |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 2513 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2514 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 2515 | |
Izabela Orlowska | 0faba5f | 2018-06-01 12:06:31 +0100 | [diff] [blame] | 2516 | if (no_compress_regex) { |
| 2517 | std::string regex = no_compress_regex.value(); |
| 2518 | if (util::StartsWith(regex, "@")) { |
| 2519 | const std::string path = regex.substr(1, regex.size() -1); |
| 2520 | std::string error; |
| 2521 | if (!file::AppendSetArgsFromFile(path, &options_.extensions_to_not_compress, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2522 | context.GetDiagnostics()->Error(android::DiagMessage(path) << error); |
Izabela Orlowska | 0faba5f | 2018-06-01 12:06:31 +0100 | [diff] [blame] | 2523 | return 1; |
| 2524 | } |
| 2525 | } else { |
| 2526 | options_.regex_to_not_compress = GetRegularExpression(no_compress_regex.value()); |
| 2527 | } |
| 2528 | } |
| 2529 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2530 | // Populate some default no-compress extensions that are already compressed. |
Ryan Mitchell | bf511dd | 2020-09-14 10:28:14 -0700 | [diff] [blame] | 2531 | options_.extensions_to_not_compress.insert({ |
| 2532 | // Image extensions |
| 2533 | ".jpg", ".jpeg", ".png", ".gif", ".webp", |
| 2534 | // Audio extensions |
| 2535 | ".wav", ".mp2", ".mp3", ".ogg", ".aac", ".mid", ".midi", ".smf", ".jet", ".rtttl", ".imy", |
| 2536 | ".xmf", ".amr", ".awb", |
| 2537 | // Audio/video extensions |
| 2538 | ".mpg", ".mpeg", ".mp4", ".m4a", ".m4v", ".3gp", ".3gpp", ".3g2", ".3gpp2", ".wma", ".wmv", |
| 2539 | ".webm", ".mkv"}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2540 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2541 | // Turn off auto versioning for static-libs. |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2542 | if (context.GetPackageType() == PackageType::kStaticLib) { |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2543 | options_.no_auto_version = true; |
| 2544 | options_.no_version_vectors = true; |
| 2545 | options_.no_version_transitions = true; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2546 | } |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 2547 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2548 | Linker cmd(&context, options_); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2549 | return cmd.Run(arg_list); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2550 | } |
| 2551 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2552 | } // namespace aapt |