Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 17 | #include "link/ManifestFixer.h" |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 18 | |
| 19 | #include <unordered_set> |
| 20 | |
| 21 | #include "android-base/logging.h" |
| 22 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 23 | #include "ResourceUtils.h" |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 24 | #include "trace/TraceBuffer.h" |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 25 | #include "util/Util.h" |
Adam Lesinski | cc5609d | 2016-04-05 12:41:07 -0700 | [diff] [blame] | 26 | #include "xml/XmlActionExecutor.h" |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 27 | #include "xml/XmlDom.h" |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 28 | |
Adam Lesinski | d5083f6 | 2017-01-16 15:07:21 -0800 | [diff] [blame] | 29 | using android::StringPiece; |
| 30 | |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 31 | namespace aapt { |
| 32 | |
Brandon Liu | 3cff255 | 2022-10-19 18:51:07 +0000 | [diff] [blame] | 33 | // This is to detect whether an <intent-filter> contains deeplink. |
| 34 | // See https://developer.android.com/training/app-links/deep-linking. |
| 35 | static bool HasDeepLink(xml::Element* intent_filter_el) { |
| 36 | xml::Element* action_el = intent_filter_el->FindChild({}, "action"); |
| 37 | xml::Element* category_el = intent_filter_el->FindChild({}, "category"); |
| 38 | xml::Element* data_el = intent_filter_el->FindChild({}, "data"); |
| 39 | if (action_el == nullptr || category_el == nullptr || data_el == nullptr) { |
| 40 | return false; |
| 41 | } |
| 42 | |
| 43 | // Deeplinks must specify the ACTION_VIEW intent action. |
| 44 | constexpr const char* action_view = "android.intent.action.VIEW"; |
| 45 | if (intent_filter_el->FindChildWithAttribute({}, "action", xml::kSchemaAndroid, "name", |
| 46 | action_view) == nullptr) { |
| 47 | return false; |
| 48 | } |
| 49 | |
| 50 | // Deeplinks must have scheme included in <data> tag. |
| 51 | xml::Attribute* data_scheme_attr = data_el->FindAttribute(xml::kSchemaAndroid, "scheme"); |
| 52 | if (data_scheme_attr == nullptr || data_scheme_attr->value.empty()) { |
| 53 | return false; |
| 54 | } |
| 55 | |
| 56 | // Deeplinks must include BROWSABLE category. |
| 57 | constexpr const char* category_browsable = "android.intent.category.BROWSABLE"; |
| 58 | if (intent_filter_el->FindChildWithAttribute({}, "category", xml::kSchemaAndroid, "name", |
| 59 | category_browsable) == nullptr) { |
| 60 | return false; |
| 61 | } |
| 62 | return true; |
| 63 | } |
| 64 | |
| 65 | static bool VerifyDeeplinkPathAttribute(xml::Element* data_el, android::SourcePathDiagnostics* diag, |
| 66 | const std::string& attr_name) { |
| 67 | xml::Attribute* attr = data_el->FindAttribute(xml::kSchemaAndroid, attr_name); |
| 68 | if (attr != nullptr && !attr->value.empty()) { |
| 69 | StringPiece attr_value = attr->value; |
| 70 | const char* startChar = attr_value.begin(); |
| 71 | if (attr_name == "pathPattern") { |
Brandon Liu | a35bf78 | 2022-11-03 19:04:31 +0000 | [diff] [blame] | 72 | // pathPattern starts with '.' or '*' does not need leading slash. |
| 73 | // Reference starts with @ does not need leading slash. |
| 74 | if (*startChar == '/' || *startChar == '.' || *startChar == '*' || *startChar == '@') { |
Brandon Liu | 3cff255 | 2022-10-19 18:51:07 +0000 | [diff] [blame] | 75 | return true; |
| 76 | } else { |
| 77 | diag->Error(android::DiagMessage(data_el->line_number) |
| 78 | << "attribute 'android:" << attr_name << "' in <" << data_el->name |
| 79 | << "> tag has value of '" << attr_value |
| 80 | << "', it must be in a pattern start with '.' or '*', otherwise must start " |
| 81 | "with a leading slash '/'"); |
| 82 | return false; |
| 83 | } |
| 84 | } else { |
Brandon Liu | a35bf78 | 2022-11-03 19:04:31 +0000 | [diff] [blame] | 85 | // Reference starts with @ does not need leading slash. |
| 86 | if (*startChar == '/' || *startChar == '@') { |
Brandon Liu | 3cff255 | 2022-10-19 18:51:07 +0000 | [diff] [blame] | 87 | return true; |
| 88 | } else { |
| 89 | diag->Error(android::DiagMessage(data_el->line_number) |
| 90 | << "attribute 'android:" << attr_name << "' in <" << data_el->name |
| 91 | << "> tag has value of '" << attr_value |
| 92 | << "', it must start with a leading slash '/'"); |
| 93 | return false; |
| 94 | } |
| 95 | } |
| 96 | } |
| 97 | return true; |
| 98 | } |
| 99 | |
| 100 | static bool VerifyDeepLinkIntentAction(xml::Element* intent_filter_el, |
| 101 | android::SourcePathDiagnostics* diag) { |
| 102 | if (!HasDeepLink(intent_filter_el)) { |
| 103 | return true; |
| 104 | } |
| 105 | |
| 106 | xml::Element* data_el = intent_filter_el->FindChild({}, "data"); |
| 107 | if (data_el != nullptr) { |
| 108 | if (!VerifyDeeplinkPathAttribute(data_el, diag, "path")) { |
| 109 | return false; |
| 110 | } |
| 111 | if (!VerifyDeeplinkPathAttribute(data_el, diag, "pathPrefix")) { |
| 112 | return false; |
| 113 | } |
| 114 | if (!VerifyDeeplinkPathAttribute(data_el, diag, "pathPattern")) { |
| 115 | return false; |
| 116 | } |
| 117 | } |
| 118 | return true; |
| 119 | } |
| 120 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 121 | static bool RequiredNameIsNotEmpty(xml::Element* el, android::SourcePathDiagnostics* diag) { |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 122 | xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "name"); |
| 123 | if (attr == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 124 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 125 | << "<" << el->name << "> is missing attribute 'android:name'"); |
| 126 | return false; |
| 127 | } |
| 128 | |
| 129 | if (attr->value.empty()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 130 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 131 | << "attribute 'android:name' in <" << el->name << "> tag must not be empty"); |
| 132 | return false; |
| 133 | } |
| 134 | return true; |
| 135 | } |
| 136 | |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 137 | // This is how PackageManager builds class names from AndroidManifest.xml entries. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 138 | static bool NameIsJavaClassName(xml::Element* el, xml::Attribute* attr, |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 139 | android::SourcePathDiagnostics* diag) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 140 | // We allow unqualified class names (ie: .HelloActivity) |
| 141 | // Since we don't know the package name, we can just make a fake one here and |
| 142 | // the test will be identical as long as the real package name is valid too. |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 143 | std::optional<std::string> fully_qualified_class_name = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 144 | util::GetFullyQualifiedClassName("a", attr->value); |
Adam Lesinski | cc5609d | 2016-04-05 12:41:07 -0700 | [diff] [blame] | 145 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 146 | StringPiece qualified_class_name = fully_qualified_class_name |
| 147 | ? fully_qualified_class_name.value() |
| 148 | : attr->value; |
Adam Lesinski | d0f116b | 2016-07-08 15:00:32 -0700 | [diff] [blame] | 149 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 150 | if (!util::IsJavaClassName(qualified_class_name)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 151 | diag->Error(android::DiagMessage(el->line_number) << "attribute 'android:name' in <" << el->name |
| 152 | << "> tag must be a valid Java class name"); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 153 | return false; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 154 | } |
| 155 | return true; |
| 156 | } |
| 157 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 158 | static bool OptionalNameIsJavaClassName(xml::Element* el, android::SourcePathDiagnostics* diag) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 159 | if (xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "name")) { |
| 160 | return NameIsJavaClassName(el, attr, diag); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 161 | } |
| 162 | return true; |
| 163 | } |
| 164 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 165 | static bool RequiredNameIsJavaClassName(xml::Element* el, android::SourcePathDiagnostics* diag) { |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 166 | xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "name"); |
| 167 | if (attr == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 168 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 169 | << "<" << el->name << "> is missing attribute 'android:name'"); |
| 170 | return false; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 171 | } |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 172 | return NameIsJavaClassName(el, attr, diag); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 173 | } |
| 174 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 175 | static bool RequiredNameIsJavaPackage(xml::Element* el, android::SourcePathDiagnostics* diag) { |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 176 | xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "name"); |
| 177 | if (attr == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 178 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 179 | << "<" << el->name << "> is missing attribute 'android:name'"); |
| 180 | return false; |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 181 | } |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 182 | |
| 183 | if (!util::IsJavaPackageName(attr->value)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 184 | diag->Error(android::DiagMessage(el->line_number) << "attribute 'android:name' in <" << el->name |
| 185 | << "> tag must be a valid Java package name"); |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 186 | return false; |
| 187 | } |
| 188 | return true; |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 189 | } |
| 190 | |
Adam Lesinski | b5dc4bd | 2017-02-22 19:29:29 -0800 | [diff] [blame] | 191 | static xml::XmlNodeAction::ActionFuncWithDiag RequiredAndroidAttribute(const std::string& attr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 192 | return [=](xml::Element* el, android::SourcePathDiagnostics* diag) -> bool { |
Adam Lesinski | b5dc4bd | 2017-02-22 19:29:29 -0800 | [diff] [blame] | 193 | if (el->FindAttribute(xml::kSchemaAndroid, attr) == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 194 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | b5dc4bd | 2017-02-22 19:29:29 -0800 | [diff] [blame] | 195 | << "<" << el->name << "> is missing required attribute 'android:" << attr << "'"); |
| 196 | return false; |
| 197 | } |
| 198 | return true; |
| 199 | }; |
| 200 | } |
| 201 | |
Todd Kennedy | ce3e129 | 2020-10-29 17:14:24 -0700 | [diff] [blame] | 202 | static xml::XmlNodeAction::ActionFuncWithDiag RequiredOneAndroidAttribute( |
| 203 | const std::string& attrName1, const std::string& attrName2) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 204 | return [=](xml::Element* el, android::SourcePathDiagnostics* diag) -> bool { |
Todd Kennedy | ce3e129 | 2020-10-29 17:14:24 -0700 | [diff] [blame] | 205 | xml::Attribute* attr1 = el->FindAttribute(xml::kSchemaAndroid, attrName1); |
| 206 | xml::Attribute* attr2 = el->FindAttribute(xml::kSchemaAndroid, attrName2); |
| 207 | if (attr1 == nullptr && attr2 == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 208 | diag->Error(android::DiagMessage(el->line_number) |
Todd Kennedy | ce3e129 | 2020-10-29 17:14:24 -0700 | [diff] [blame] | 209 | << "<" << el->name << "> is missing required attribute 'android:" << attrName1 |
| 210 | << "' or 'android:" << attrName2 << "'"); |
| 211 | return false; |
| 212 | } |
| 213 | if (attr1 != nullptr && attr2 != nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 214 | diag->Error(android::DiagMessage(el->line_number) |
Todd Kennedy | ce3e129 | 2020-10-29 17:14:24 -0700 | [diff] [blame] | 215 | << "<" << el->name << "> can only specify one of attribute 'android:" << attrName1 |
| 216 | << "' or 'android:" << attrName2 << "'"); |
| 217 | return false; |
| 218 | } |
| 219 | return true; |
| 220 | }; |
| 221 | } |
| 222 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 223 | static bool AutoGenerateIsFeatureSplit(xml::Element* el, android::SourcePathDiagnostics* diag) { |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 224 | constexpr const char* kFeatureSplit = "featureSplit"; |
| 225 | constexpr const char* kIsFeatureSplit = "isFeatureSplit"; |
| 226 | |
| 227 | xml::Attribute* attr = el->FindAttribute({}, kFeatureSplit); |
| 228 | if (attr != nullptr) { |
| 229 | // Rewrite the featureSplit attribute to be "split". This is what the |
| 230 | // platform recognizes. |
| 231 | attr->name = "split"; |
| 232 | |
| 233 | // Now inject the android:isFeatureSplit="true" attribute. |
| 234 | xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, kIsFeatureSplit); |
| 235 | if (attr != nullptr) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 236 | if (!ResourceUtils::ParseBool(attr->value).value_or(false)) { |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 237 | // The isFeatureSplit attribute is false, which conflicts with the use |
| 238 | // of "featureSplit". |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 239 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 240 | << "attribute 'featureSplit' used in <manifest> but 'android:isFeatureSplit' " |
| 241 | "is not 'true'"); |
| 242 | return false; |
| 243 | } |
| 244 | |
| 245 | // The attribute is already there and set to true, nothing to do. |
| 246 | } else { |
| 247 | el->attributes.push_back(xml::Attribute{xml::kSchemaAndroid, kIsFeatureSplit, "true"}); |
| 248 | } |
| 249 | } |
| 250 | return true; |
| 251 | } |
| 252 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 253 | static bool AutoGenerateIsSplitRequired(xml::Element* el, android::SourcePathDiagnostics* diag) { |
Jackal Guo | 0c01abb | 2021-07-30 22:17:43 +0800 | [diff] [blame] | 254 | constexpr const char* kRequiredSplitTypes = "requiredSplitTypes"; |
| 255 | constexpr const char* kIsSplitRequired = "isSplitRequired"; |
| 256 | |
| 257 | xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, kRequiredSplitTypes); |
| 258 | if (attr != nullptr) { |
| 259 | // Now inject the android:isSplitRequired="true" attribute. |
| 260 | xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, kIsSplitRequired); |
| 261 | if (attr != nullptr) { |
| 262 | if (!ResourceUtils::ParseBool(attr->value).value_or(false)) { |
| 263 | // The isFeatureSplit attribute is false, which conflicts with the use |
| 264 | // of "featureSplit". |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 265 | diag->Error(android::DiagMessage(el->line_number) |
Jackal Guo | 0c01abb | 2021-07-30 22:17:43 +0800 | [diff] [blame] | 266 | << "attribute 'requiredSplitTypes' used in <manifest> but " |
| 267 | "'android:isSplitRequired' is not 'true'"); |
| 268 | return false; |
| 269 | } |
| 270 | // The attribute is already there and set to true, nothing to do. |
| 271 | } else { |
| 272 | el->attributes.push_back(xml::Attribute{xml::kSchemaAndroid, kIsSplitRequired, "true"}); |
| 273 | } |
| 274 | } |
| 275 | return true; |
| 276 | } |
| 277 | |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 278 | static bool VerifyManifest(xml::Element* el, xml::XmlActionExecutorPolicy policy, |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 279 | android::SourcePathDiagnostics* diag) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 280 | xml::Attribute* attr = el->FindAttribute({}, "package"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 281 | if (!attr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 282 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 283 | << "<manifest> tag is missing 'package' attribute"); |
| 284 | return false; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 285 | } else if (ResourceUtils::IsReference(attr->value)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 286 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 287 | << "attribute 'package' in <manifest> tag must not be a reference"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 288 | return false; |
Adam Lesinski | 96ea08f | 2017-11-06 10:44:46 -0800 | [diff] [blame] | 289 | } else if (!util::IsAndroidPackageName(attr->value)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 290 | android::DiagMessage error_msg(el->line_number); |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 291 | error_msg << "attribute 'package' in <manifest> tag is not a valid Android package name: '" |
| 292 | << attr->value << "'"; |
| 293 | if (policy == xml::XmlActionExecutorPolicy::kAllowListWarning) { |
| 294 | // Treat the error only as a warning. |
| 295 | diag->Warn(error_msg); |
| 296 | } else { |
| 297 | diag->Error(error_msg); |
| 298 | return false; |
| 299 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 300 | } |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 301 | |
| 302 | attr = el->FindAttribute({}, "split"); |
| 303 | if (attr) { |
| 304 | if (!util::IsJavaPackageName(attr->value)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 305 | diag->Error(android::DiagMessage(el->line_number) |
| 306 | << "attribute 'split' in <manifest> tag is not a " |
| 307 | "valid split name"); |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 308 | return false; |
| 309 | } |
| 310 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 311 | return true; |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 312 | } |
| 313 | |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 314 | // The coreApp attribute in <manifest> is not a regular AAPT attribute, so type |
| 315 | // checking on it is manual. |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 316 | static bool FixCoreAppAttribute(xml::Element* el, android::SourcePathDiagnostics* diag) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 317 | if (xml::Attribute* attr = el->FindAttribute("", "coreApp")) { |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 318 | std::unique_ptr<BinaryPrimitive> result = ResourceUtils::TryParseBool(attr->value); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 319 | if (!result) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 320 | diag->Error(android::DiagMessage(el->line_number) << "attribute coreApp must be a boolean"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 321 | return false; |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 322 | } |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 323 | attr->compiled_value = std::move(result); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 324 | } |
| 325 | return true; |
Adam Lesinski | 6b17d2c | 2016-08-10 11:37:06 -0700 | [diff] [blame] | 326 | } |
| 327 | |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 328 | // Checks that <uses-feature> has android:glEsVersion or android:name, not both (or neither). |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 329 | static bool VerifyUsesFeature(xml::Element* el, android::SourcePathDiagnostics* diag) { |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 330 | bool has_name = false; |
| 331 | if (xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "name")) { |
| 332 | if (attr->value.empty()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 333 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 334 | << "android:name in <uses-feature> must not be empty"); |
| 335 | return false; |
| 336 | } |
| 337 | has_name = true; |
| 338 | } |
| 339 | |
| 340 | bool has_gl_es_version = false; |
Yi Kong | d650788 | 2023-12-05 17:06:08 +0900 | [diff] [blame^] | 341 | if (el->FindAttribute(xml::kSchemaAndroid, "glEsVersion")) { |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 342 | if (has_name) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 343 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 344 | << "cannot define both android:name and android:glEsVersion in <uses-feature>"); |
| 345 | return false; |
| 346 | } |
| 347 | has_gl_es_version = true; |
| 348 | } |
| 349 | |
| 350 | if (!has_name && !has_gl_es_version) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 351 | diag->Error(android::DiagMessage(el->line_number) |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 352 | << "<uses-feature> must have either android:name or android:glEsVersion attribute"); |
| 353 | return false; |
| 354 | } |
| 355 | return true; |
| 356 | } |
| 357 | |
Donald Chai | 6e49735 | 2019-05-19 21:07:50 -0700 | [diff] [blame] | 358 | // Ensure that 'ns_decls' contains a declaration for 'uri', using 'prefix' as |
| 359 | // the xmlns prefix if possible. |
| 360 | static void EnsureNamespaceIsDeclared(const std::string& prefix, const std::string& uri, |
| 361 | std::vector<xml::NamespaceDecl>* ns_decls) { |
| 362 | if (std::find_if(ns_decls->begin(), ns_decls->end(), [&](const xml::NamespaceDecl& ns_decl) { |
| 363 | return ns_decl.uri == uri; |
| 364 | }) != ns_decls->end()) { |
| 365 | return; |
| 366 | } |
| 367 | |
| 368 | std::set<std::string> used_prefixes; |
| 369 | for (const auto& ns_decl : *ns_decls) { |
| 370 | used_prefixes.insert(ns_decl.prefix); |
| 371 | } |
| 372 | |
| 373 | // Make multiple attempts in the unlikely event that 'prefix' is already taken. |
| 374 | std::string disambiguator; |
| 375 | for (int i = 0; i < used_prefixes.size() + 1; i++) { |
| 376 | std::string attempted_prefix = prefix + disambiguator; |
| 377 | if (used_prefixes.find(attempted_prefix) == used_prefixes.end()) { |
| 378 | ns_decls->push_back(xml::NamespaceDecl{attempted_prefix, uri}); |
| 379 | return; |
| 380 | } |
| 381 | disambiguator = std::to_string(i); |
| 382 | } |
| 383 | } |
| 384 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 385 | bool ManifestFixer::BuildRules(xml::XmlActionExecutor* executor, android::IDiagnostics* diag) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 386 | // First verify some options. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 387 | if (options_.rename_manifest_package) { |
| 388 | if (!util::IsJavaPackageName(options_.rename_manifest_package.value())) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 389 | diag->Error(android::DiagMessage() << "invalid manifest package override '" |
| 390 | << options_.rename_manifest_package.value() << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 391 | return false; |
| 392 | } |
| 393 | } |
| 394 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 395 | if (options_.rename_instrumentation_target_package) { |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 396 | if (!util::IsJavaPackageName(options_.rename_instrumentation_target_package.value())) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 397 | diag->Error(android::DiagMessage() |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 398 | << "invalid instrumentation target package override '" |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 399 | << options_.rename_instrumentation_target_package.value() << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 400 | return false; |
| 401 | } |
| 402 | } |
| 403 | |
Roshan Pius | ae12ce4 | 2020-04-25 16:08:55 -0700 | [diff] [blame] | 404 | if (options_.rename_overlay_target_package) { |
| 405 | if (!util::IsJavaPackageName(options_.rename_overlay_target_package.value())) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 406 | diag->Error(android::DiagMessage() << "invalid overlay target package override '" |
| 407 | << options_.rename_overlay_target_package.value() << "'"); |
Roshan Pius | ae12ce4 | 2020-04-25 16:08:55 -0700 | [diff] [blame] | 408 | return false; |
| 409 | } |
| 410 | } |
| 411 | |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 412 | // Common <intent-filter> actions. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 413 | xml::XmlNodeAction intent_filter_action; |
Brandon Liu | 3cff255 | 2022-10-19 18:51:07 +0000 | [diff] [blame] | 414 | intent_filter_action.Action(VerifyDeepLinkIntentAction); |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 415 | intent_filter_action["action"].Action(RequiredNameIsNotEmpty); |
| 416 | intent_filter_action["category"].Action(RequiredNameIsNotEmpty); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 417 | intent_filter_action["data"]; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 418 | |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 419 | // Common <meta-data> actions. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 420 | xml::XmlNodeAction meta_data_action; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 421 | |
Todd Kennedy | ce3e129 | 2020-10-29 17:14:24 -0700 | [diff] [blame] | 422 | // Common <property> actions. |
| 423 | xml::XmlNodeAction property_action; |
| 424 | property_action.Action(RequiredOneAndroidAttribute("resource", "value")); |
| 425 | |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 426 | // Common <uses-feature> actions. |
| 427 | xml::XmlNodeAction uses_feature_action; |
| 428 | uses_feature_action.Action(VerifyUsesFeature); |
| 429 | |
| 430 | // Common component actions. |
| 431 | xml::XmlNodeAction component_action; |
| 432 | component_action.Action(RequiredNameIsJavaClassName); |
| 433 | component_action["intent-filter"] = intent_filter_action; |
Ryan Mitchell | 28afe68 | 2018-09-07 14:33:14 -0700 | [diff] [blame] | 434 | component_action["preferred"] = intent_filter_action; |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 435 | component_action["meta-data"] = meta_data_action; |
Todd Kennedy | ce3e129 | 2020-10-29 17:14:24 -0700 | [diff] [blame] | 436 | component_action["property"] = property_action; |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 437 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 438 | // Manifest actions. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 439 | xml::XmlNodeAction& manifest_action = (*executor)["manifest"]; |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 440 | manifest_action.Action(AutoGenerateIsFeatureSplit); |
Jackal Guo | 0c01abb | 2021-07-30 22:17:43 +0800 | [diff] [blame] | 441 | manifest_action.Action(AutoGenerateIsSplitRequired); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 442 | manifest_action.Action(VerifyManifest); |
| 443 | manifest_action.Action(FixCoreAppAttribute); |
| 444 | manifest_action.Action([&](xml::Element* el) -> bool { |
Donald Chai | 6e49735 | 2019-05-19 21:07:50 -0700 | [diff] [blame] | 445 | EnsureNamespaceIsDeclared("android", xml::kSchemaAndroid, &el->namespace_decls); |
| 446 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 447 | if (options_.version_name_default) { |
Colin Cross | dcd58c4 | 2018-05-25 22:46:35 -0700 | [diff] [blame] | 448 | if (options_.replace_version) { |
| 449 | el->RemoveAttribute(xml::kSchemaAndroid, "versionName"); |
| 450 | } |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 451 | if (el->FindAttribute(xml::kSchemaAndroid, "versionName") == nullptr) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 452 | el->attributes.push_back( |
| 453 | xml::Attribute{xml::kSchemaAndroid, "versionName", |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 454 | options_.version_name_default.value()}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 455 | } |
Adam Lesinski | cc5609d | 2016-04-05 12:41:07 -0700 | [diff] [blame] | 456 | } |
| 457 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 458 | if (options_.version_code_default) { |
Colin Cross | dcd58c4 | 2018-05-25 22:46:35 -0700 | [diff] [blame] | 459 | if (options_.replace_version) { |
| 460 | el->RemoveAttribute(xml::kSchemaAndroid, "versionCode"); |
| 461 | } |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 462 | if (el->FindAttribute(xml::kSchemaAndroid, "versionCode") == nullptr) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 463 | el->attributes.push_back( |
| 464 | xml::Attribute{xml::kSchemaAndroid, "versionCode", |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 465 | options_.version_code_default.value()}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 466 | } |
Adam Lesinski | cc5609d | 2016-04-05 12:41:07 -0700 | [diff] [blame] | 467 | } |
Ryan Mitchell | 7cb82a8 | 2018-05-10 15:35:31 -0700 | [diff] [blame] | 468 | |
Ryan Mitchell | 704090e | 2018-07-31 14:59:25 -0700 | [diff] [blame] | 469 | if (options_.version_code_major_default) { |
| 470 | if (options_.replace_version) { |
| 471 | el->RemoveAttribute(xml::kSchemaAndroid, "versionCodeMajor"); |
| 472 | } |
| 473 | if (el->FindAttribute(xml::kSchemaAndroid, "versionCodeMajor") == nullptr) { |
| 474 | el->attributes.push_back( |
| 475 | xml::Attribute{xml::kSchemaAndroid, "versionCodeMajor", |
| 476 | options_.version_code_major_default.value()}); |
| 477 | } |
| 478 | } |
| 479 | |
Rhed Jao | b9ccb8a4 | 2020-11-30 21:42:16 +0800 | [diff] [blame] | 480 | if (options_.revision_code_default) { |
| 481 | if (options_.replace_version) { |
| 482 | el->RemoveAttribute(xml::kSchemaAndroid, "revisionCode"); |
| 483 | } |
| 484 | if (el->FindAttribute(xml::kSchemaAndroid, "revisionCode") == nullptr) { |
| 485 | el->attributes.push_back(xml::Attribute{xml::kSchemaAndroid, "revisionCode", |
| 486 | options_.revision_code_default.value()}); |
| 487 | } |
| 488 | } |
| 489 | |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 490 | return true; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 491 | }); |
| 492 | |
| 493 | // Meta tags. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 494 | manifest_action["eat-comment"]; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 495 | |
| 496 | // Uses-sdk actions. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 497 | manifest_action["uses-sdk"].Action([&](xml::Element* el) -> bool { |
| 498 | if (options_.min_sdk_version_default && |
| 499 | el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion") == nullptr) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 500 | // There was no minSdkVersion defined and we have a default to assign. |
| 501 | el->attributes.push_back( |
| 502 | xml::Attribute{xml::kSchemaAndroid, "minSdkVersion", |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 503 | options_.min_sdk_version_default.value()}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 504 | } |
| 505 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 506 | if (options_.target_sdk_version_default && |
| 507 | el->FindAttribute(xml::kSchemaAndroid, "targetSdkVersion") == nullptr) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 508 | // There was no targetSdkVersion defined and we have a default to assign. |
| 509 | el->attributes.push_back( |
| 510 | xml::Attribute{xml::kSchemaAndroid, "targetSdkVersion", |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 511 | options_.target_sdk_version_default.value()}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 512 | } |
| 513 | return true; |
| 514 | }); |
Anton Hansson | b2f709d | 2020-01-09 10:25:23 +0000 | [diff] [blame] | 515 | manifest_action["uses-sdk"]["extension-sdk"]; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 516 | |
| 517 | // Instrumentation actions. |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 518 | manifest_action["instrumentation"].Action(RequiredNameIsJavaClassName); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 519 | manifest_action["instrumentation"].Action([&](xml::Element* el) -> bool { |
| 520 | if (!options_.rename_instrumentation_target_package) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 521 | return true; |
| 522 | } |
| 523 | |
| 524 | if (xml::Attribute* attr = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 525 | el->FindAttribute(xml::kSchemaAndroid, "targetPackage")) { |
| 526 | attr->value = options_.rename_instrumentation_target_package.value(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 527 | } |
| 528 | return true; |
| 529 | }); |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 530 | manifest_action["instrumentation"]["meta-data"] = meta_data_action; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 531 | |
Philip P. Moltmann | 12ac3f4 | 2020-03-05 15:01:29 -0800 | [diff] [blame] | 532 | manifest_action["attribution"]; |
| 533 | manifest_action["attribution"]["inherit-from"]; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 534 | manifest_action["original-package"]; |
Roshan Pius | ae12ce4 | 2020-04-25 16:08:55 -0700 | [diff] [blame] | 535 | manifest_action["overlay"].Action([&](xml::Element* el) -> bool { |
Jeremy Meyer | 6b05b7d | 2022-09-30 22:22:24 +0000 | [diff] [blame] | 536 | if (options_.rename_overlay_target_package) { |
| 537 | if (xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "targetPackage")) { |
| 538 | attr->value = options_.rename_overlay_target_package.value(); |
| 539 | } |
Roshan Pius | ae12ce4 | 2020-04-25 16:08:55 -0700 | [diff] [blame] | 540 | } |
Jeremy Meyer | 6b05b7d | 2022-09-30 22:22:24 +0000 | [diff] [blame] | 541 | if (options_.rename_overlay_category) { |
| 542 | if (xml::Attribute* attr = el->FindAttribute(xml::kSchemaAndroid, "category")) { |
| 543 | attr->value = options_.rename_overlay_category.value(); |
| 544 | } else { |
| 545 | el->attributes.push_back(xml::Attribute{xml::kSchemaAndroid, "category", |
| 546 | options_.rename_overlay_category.value()}); |
| 547 | } |
Roshan Pius | ae12ce4 | 2020-04-25 16:08:55 -0700 | [diff] [blame] | 548 | } |
| 549 | return true; |
| 550 | }); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 551 | manifest_action["protected-broadcast"]; |
Alan Viverette | cf5326f | 2018-01-05 16:03:50 -0500 | [diff] [blame] | 552 | manifest_action["adopt-permissions"]; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 553 | manifest_action["uses-permission"]; |
Sergey Nikolaienkov | 65f9099 | 2020-09-30 08:17:09 +0000 | [diff] [blame] | 554 | manifest_action["uses-permission"]["required-feature"].Action(RequiredNameIsNotEmpty); |
| 555 | manifest_action["uses-permission"]["required-not-feature"].Action(RequiredNameIsNotEmpty); |
Adam Lesinski | 4b585db | 2017-05-12 15:25:50 -0700 | [diff] [blame] | 556 | manifest_action["uses-permission-sdk-23"]; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 557 | manifest_action["permission"]; |
Ryan Mitchell | 66f6cfb | 2018-07-25 16:15:17 -0700 | [diff] [blame] | 558 | manifest_action["permission"]["meta-data"] = meta_data_action; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 559 | manifest_action["permission-tree"]; |
| 560 | manifest_action["permission-group"]; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 561 | manifest_action["uses-configuration"]; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 562 | manifest_action["supports-screens"]; |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 563 | manifest_action["uses-feature"] = uses_feature_action; |
| 564 | manifest_action["feature-group"]["uses-feature"] = uses_feature_action; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 565 | manifest_action["compatible-screens"]; |
| 566 | manifest_action["compatible-screens"]["screen"]; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 567 | manifest_action["supports-gl-texture"]; |
Ryan Mitchell | 66f6cfb | 2018-07-25 16:15:17 -0700 | [diff] [blame] | 568 | manifest_action["restrict-update"]; |
MÃ¥rten Kongstad | b0502bb | 2022-05-16 15:23:40 +0200 | [diff] [blame] | 569 | manifest_action["install-constraints"]["fingerprint-prefix"]; |
Ryan Mitchell | 66f6cfb | 2018-07-25 16:15:17 -0700 | [diff] [blame] | 570 | manifest_action["package-verifier"]; |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 571 | manifest_action["meta-data"] = meta_data_action; |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 572 | manifest_action["uses-split"].Action(RequiredNameIsJavaPackage); |
Patrick Baumann | a4ffb45 | 2019-06-24 15:01:49 -0700 | [diff] [blame] | 573 | manifest_action["queries"]["package"].Action(RequiredNameIsJavaPackage); |
| 574 | manifest_action["queries"]["intent"] = intent_filter_action; |
Patrick Baumann | 9918123 | 2020-01-28 10:55:25 -0800 | [diff] [blame] | 575 | manifest_action["queries"]["provider"].Action(RequiredAndroidAttribute("authorities")); |
Patrick Baumann | a4ffb45 | 2019-06-24 15:01:49 -0700 | [diff] [blame] | 576 | // TODO: more complicated component name tag |
Adam Lesinski | 5119e51 | 2016-12-05 19:48:20 -0800 | [diff] [blame] | 577 | |
Adam Lesinski | 87f1e0f | 2017-06-27 16:21:58 -0700 | [diff] [blame] | 578 | manifest_action["key-sets"]["key-set"]["public-key"]; |
| 579 | manifest_action["key-sets"]["upgrade-key-set"]; |
| 580 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 581 | // Application actions. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 582 | xml::XmlNodeAction& application_action = manifest_action["application"]; |
| 583 | application_action.Action(OptionalNameIsJavaClassName); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 584 | |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 585 | application_action["uses-library"].Action(RequiredNameIsNotEmpty); |
Jiyong Park | 6a5b8b1 | 2020-06-30 13:23:36 +0900 | [diff] [blame] | 586 | application_action["uses-native-library"].Action(RequiredNameIsNotEmpty); |
Adam Lesinski | fca5e42 | 2017-12-20 15:03:36 -0800 | [diff] [blame] | 587 | application_action["library"].Action(RequiredNameIsNotEmpty); |
Chris Craik | 335b565 | 2019-04-04 12:46:47 -0700 | [diff] [blame] | 588 | application_action["profileable"]; |
Todd Kennedy | ce3e129 | 2020-10-29 17:14:24 -0700 | [diff] [blame] | 589 | application_action["property"] = property_action; |
Adam Lesinski | b5dc4bd | 2017-02-22 19:29:29 -0800 | [diff] [blame] | 590 | |
| 591 | xml::XmlNodeAction& static_library_action = application_action["static-library"]; |
| 592 | static_library_action.Action(RequiredNameIsJavaPackage); |
| 593 | static_library_action.Action(RequiredAndroidAttribute("version")); |
| 594 | |
| 595 | xml::XmlNodeAction& uses_static_library_action = application_action["uses-static-library"]; |
| 596 | uses_static_library_action.Action(RequiredNameIsJavaPackage); |
| 597 | uses_static_library_action.Action(RequiredAndroidAttribute("version")); |
| 598 | uses_static_library_action.Action(RequiredAndroidAttribute("certDigest")); |
Ryan Mitchell | 66f6cfb | 2018-07-25 16:15:17 -0700 | [diff] [blame] | 599 | uses_static_library_action["additional-certificate"]; |
Adam Lesinski | b5dc4bd | 2017-02-22 19:29:29 -0800 | [diff] [blame] | 600 | |
Alex Buynytskyy | a1613705 | 2021-12-02 13:26:54 +0000 | [diff] [blame] | 601 | xml::XmlNodeAction& sdk_library_action = application_action["sdk-library"]; |
| 602 | sdk_library_action.Action(RequiredNameIsJavaPackage); |
| 603 | sdk_library_action.Action(RequiredAndroidAttribute("versionMajor")); |
| 604 | |
| 605 | xml::XmlNodeAction& uses_sdk_library_action = application_action["uses-sdk-library"]; |
| 606 | uses_sdk_library_action.Action(RequiredNameIsJavaPackage); |
| 607 | uses_sdk_library_action.Action(RequiredAndroidAttribute("versionMajor")); |
| 608 | uses_sdk_library_action.Action(RequiredAndroidAttribute("certDigest")); |
| 609 | uses_sdk_library_action["additional-certificate"]; |
| 610 | |
Dianne Hackborn | 813d750 | 2018-10-02 16:59:46 -0700 | [diff] [blame] | 611 | xml::XmlNodeAction& uses_package_action = application_action["uses-package"]; |
| 612 | uses_package_action.Action(RequiredNameIsJavaPackage); |
| 613 | uses_package_action["additional-certificate"]; |
| 614 | |
Ryan Mitchell | e5b38a6 | 2018-03-23 13:35:00 -0700 | [diff] [blame] | 615 | if (options_.debug_mode) { |
| 616 | application_action.Action([&](xml::Element* el) -> bool { |
| 617 | xml::Attribute *attr = el->FindOrCreateAttribute(xml::kSchemaAndroid, "debuggable"); |
| 618 | attr->value = "true"; |
| 619 | return true; |
| 620 | }); |
| 621 | } |
| 622 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 623 | application_action["meta-data"] = meta_data_action; |
Adam Lesinski | 7a917a2 | 2017-06-02 12:55:24 -0700 | [diff] [blame] | 624 | |
Dianne Hackborn | fc0839a | 2020-01-31 11:02:28 -0800 | [diff] [blame] | 625 | application_action["processes"]; |
| 626 | application_action["processes"]["deny-permission"]; |
| 627 | application_action["processes"]["allow-permission"]; |
| 628 | application_action["processes"]["process"]["deny-permission"]; |
| 629 | application_action["processes"]["process"]["allow-permission"]; |
| 630 | |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 631 | application_action["activity"] = component_action; |
Adam Lesinski | 7a917a2 | 2017-06-02 12:55:24 -0700 | [diff] [blame] | 632 | application_action["activity"]["layout"]; |
| 633 | |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 634 | application_action["activity-alias"] = component_action; |
| 635 | application_action["service"] = component_action; |
| 636 | application_action["receiver"] = component_action; |
Gavin Corkery | ad5d4ba | 2021-10-26 12:24:43 +0100 | [diff] [blame] | 637 | application_action["apex-system-service"] = component_action; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 638 | |
| 639 | // Provider actions. |
Adam Lesinski | 86d67df | 2017-01-31 13:47:27 -0800 | [diff] [blame] | 640 | application_action["provider"] = component_action; |
Adam Lesinski | c10c0d0 | 2017-04-28 12:54:08 -0700 | [diff] [blame] | 641 | application_action["provider"]["grant-uri-permission"]; |
Adam Lesinski | 25783ca | 2017-04-24 13:33:47 -0700 | [diff] [blame] | 642 | application_action["provider"]["path-permission"]; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 643 | |
Ryan Mitchell | 28afe68 | 2018-09-07 14:33:14 -0700 | [diff] [blame] | 644 | manifest_action["package"] = manifest_action; |
| 645 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 646 | return true; |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 647 | } |
| 648 | |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 649 | static void FullyQualifyClassName(StringPiece package, StringPiece attr_ns, StringPiece attr_name, |
| 650 | xml::Element* el) { |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 651 | xml::Attribute* attr = el->FindAttribute(attr_ns, attr_name); |
| 652 | if (attr != nullptr) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 653 | if (std::optional<std::string> new_value = |
| 654 | util::GetFullyQualifiedClassName(package, attr->value)) { |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 655 | attr->value = std::move(new_value.value()); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 656 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 657 | } |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 658 | } |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 659 | |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 660 | static bool RenameManifestPackage(StringPiece package_override, xml::Element* manifest_el) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 661 | xml::Attribute* attr = manifest_el->FindAttribute({}, "package"); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 662 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 663 | // We've already verified that the manifest element is present, with a package |
| 664 | // name specified. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 665 | CHECK(attr != nullptr); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 666 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 667 | std::string original_package = std::move(attr->value); |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 668 | attr->value.assign(package_override); |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 669 | |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 670 | xml::Element* application_el = manifest_el->FindChild({}, "application"); |
| 671 | if (application_el != nullptr) { |
| 672 | FullyQualifyClassName(original_package, xml::kSchemaAndroid, "name", application_el); |
| 673 | FullyQualifyClassName(original_package, xml::kSchemaAndroid, "backupAgent", application_el); |
| 674 | |
| 675 | for (xml::Element* child_el : application_el->GetChildElements()) { |
| 676 | if (child_el->namespace_uri.empty()) { |
| 677 | if (child_el->name == "activity" || child_el->name == "activity-alias" || |
| 678 | child_el->name == "provider" || child_el->name == "receiver" || |
| 679 | child_el->name == "service") { |
| 680 | FullyQualifyClassName(original_package, xml::kSchemaAndroid, "name", child_el); |
Makoto Onuki | 808fd19 | 2021-12-10 09:40:54 -0800 | [diff] [blame] | 681 | continue; |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 682 | } |
| 683 | |
| 684 | if (child_el->name == "activity-alias") { |
| 685 | FullyQualifyClassName(original_package, xml::kSchemaAndroid, "targetActivity", child_el); |
Makoto Onuki | 808fd19 | 2021-12-10 09:40:54 -0800 | [diff] [blame] | 686 | continue; |
| 687 | } |
| 688 | |
| 689 | if (child_el->name == "processes") { |
| 690 | for (xml::Element* grand_child_el : child_el->GetChildElements()) { |
| 691 | if (grand_child_el->name == "process") { |
| 692 | FullyQualifyClassName(original_package, xml::kSchemaAndroid, "name", grand_child_el); |
| 693 | } |
| 694 | } |
| 695 | continue; |
Adam Lesinski | 23034b9 | 2017-11-29 16:27:44 -0800 | [diff] [blame] | 696 | } |
| 697 | } |
| 698 | } |
| 699 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 700 | return true; |
Adam Lesinski | 52364f7 | 2016-01-11 13:10:24 -0800 | [diff] [blame] | 701 | } |
| 702 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 703 | bool ManifestFixer::Consume(IAaptContext* context, xml::XmlResource* doc) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 704 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 705 | xml::Element* root = xml::FindRootElement(doc->root.get()); |
| 706 | if (!root || !root->namespace_uri.empty() || root->name != "manifest") { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 707 | context->GetDiagnostics()->Error(android::DiagMessage(doc->file.source) |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 708 | << "root tag must be <manifest>"); |
| 709 | return false; |
| 710 | } |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 711 | |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 712 | if ((options_.min_sdk_version_default || options_.target_sdk_version_default) && |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 713 | root->FindChild({}, "uses-sdk") == nullptr) { |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 714 | // Auto insert a <uses-sdk> element. This must be inserted before the |
| 715 | // <application> tag. The device runtime PackageParser will make SDK version |
| 716 | // decisions while parsing <application>. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 717 | std::unique_ptr<xml::Element> uses_sdk = util::make_unique<xml::Element>(); |
| 718 | uses_sdk->name = "uses-sdk"; |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 719 | root->InsertChild(0, std::move(uses_sdk)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 720 | } |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 721 | |
Alan Viverette | 07287be | 2023-05-02 16:34:27 -0400 | [diff] [blame] | 722 | if (!options_.no_compile_sdk_metadata && options_.compile_sdk_version) { |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 723 | xml::Attribute* attr = root->FindOrCreateAttribute(xml::kSchemaAndroid, "compileSdkVersion"); |
| 724 | |
| 725 | // Make sure we un-compile the value if it was set to something else. |
| 726 | attr->compiled_value = {}; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 727 | attr->value = options_.compile_sdk_version.value(); |
Ryan Mitchell | aada89c | 2019-02-12 08:06:26 -0800 | [diff] [blame] | 728 | |
| 729 | attr = root->FindOrCreateAttribute("", "platformBuildVersionCode"); |
| 730 | |
| 731 | // Make sure we un-compile the value if it was set to something else. |
| 732 | attr->compiled_value = {}; |
| 733 | attr->value = options_.compile_sdk_version.value(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 734 | } |
| 735 | |
Alan Viverette | 07287be | 2023-05-02 16:34:27 -0400 | [diff] [blame] | 736 | if (!options_.no_compile_sdk_metadata && options_.compile_sdk_version_codename) { |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 737 | xml::Attribute* attr = |
| 738 | root->FindOrCreateAttribute(xml::kSchemaAndroid, "compileSdkVersionCodename"); |
| 739 | |
| 740 | // Make sure we un-compile the value if it was set to something else. |
| 741 | attr->compiled_value = {}; |
Ryan Mitchell | aada89c | 2019-02-12 08:06:26 -0800 | [diff] [blame] | 742 | attr->value = options_.compile_sdk_version_codename.value(); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 743 | |
Ryan Mitchell | aada89c | 2019-02-12 08:06:26 -0800 | [diff] [blame] | 744 | attr = root->FindOrCreateAttribute("", "platformBuildVersionName"); |
| 745 | |
| 746 | // Make sure we un-compile the value if it was set to something else. |
| 747 | attr->compiled_value = {}; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 748 | attr->value = options_.compile_sdk_version_codename.value(); |
| 749 | } |
| 750 | |
Andrei Onea | 7109b70 | 2023-02-23 17:43:25 +0000 | [diff] [blame] | 751 | if (!options_.fingerprint_prefixes.empty()) { |
| 752 | xml::Element* install_constraints_el = root->FindChild({}, "install-constraints"); |
| 753 | if (install_constraints_el == nullptr) { |
| 754 | std::unique_ptr<xml::Element> install_constraints = std::make_unique<xml::Element>(); |
| 755 | install_constraints->name = "install-constraints"; |
| 756 | install_constraints_el = install_constraints.get(); |
| 757 | root->AppendChild(std::move(install_constraints)); |
| 758 | } |
| 759 | for (const std::string& prefix : options_.fingerprint_prefixes) { |
| 760 | std::unique_ptr<xml::Element> prefix_el = std::make_unique<xml::Element>(); |
| 761 | prefix_el->name = "fingerprint-prefix"; |
| 762 | xml::Attribute* attr = prefix_el->FindOrCreateAttribute(xml::kSchemaAndroid, "value"); |
| 763 | attr->value = prefix; |
| 764 | install_constraints_el->AppendChild(std::move(prefix_el)); |
| 765 | } |
| 766 | } |
| 767 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 768 | xml::XmlActionExecutor executor; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 769 | if (!BuildRules(&executor, context->GetDiagnostics())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 770 | return false; |
| 771 | } |
Adam Lesinski | cc5609d | 2016-04-05 12:41:07 -0700 | [diff] [blame] | 772 | |
Izabela Orlowska | ad9e132 | 2017-12-19 16:22:42 +0000 | [diff] [blame] | 773 | xml::XmlActionExecutorPolicy policy = options_.warn_validation |
Ryan Mitchell | 4ea9075 | 2020-07-31 08:21:43 -0700 | [diff] [blame] | 774 | ? xml::XmlActionExecutorPolicy::kAllowListWarning |
| 775 | : xml::XmlActionExecutorPolicy::kAllowList; |
Izabela Orlowska | ad9e132 | 2017-12-19 16:22:42 +0000 | [diff] [blame] | 776 | if (!executor.Execute(policy, context->GetDiagnostics(), doc)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 777 | return false; |
| 778 | } |
Adam Lesinski | cc5609d | 2016-04-05 12:41:07 -0700 | [diff] [blame] | 779 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 780 | if (options_.rename_manifest_package) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 781 | // Rename manifest package outside of the XmlActionExecutor. |
Adam Lesinski | e343eb1 | 2016-10-27 16:31:58 -0700 | [diff] [blame] | 782 | // We need to extract the old package name and FullyQualify all class |
| 783 | // names. |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 784 | if (!RenameManifestPackage(options_.rename_manifest_package.value(), root)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 785 | return false; |
Adam Lesinski | cc5609d | 2016-04-05 12:41:07 -0700 | [diff] [blame] | 786 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 787 | } |
| 788 | return true; |
Adam Lesinski | 2ae4a87 | 2015-11-02 16:10:55 -0800 | [diff] [blame] | 789 | } |
| 790 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 791 | } // namespace aapt |