Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 17 | #include "Link.h" |
| 18 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 19 | #include <sys/stat.h> |
| 20 | |
Mohamed Heikal | d3c5fb6 | 2018-01-12 11:37:26 -0500 | [diff] [blame] | 21 | #include <algorithm> |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 22 | #include <cinttypes> |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 23 | #include <queue> |
| 24 | #include <unordered_map> |
| 25 | #include <vector> |
| 26 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 27 | #include "AppInfo.h" |
| 28 | #include "Debug.h" |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 29 | #include "LoadedApk.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 30 | #include "NameMangler.h" |
Adam Lesinski | 59e04c6 | 2016-02-04 15:59:23 -0800 | [diff] [blame] | 31 | #include "ResourceUtils.h" |
Adam Lesinski | d3ffa844 | 2017-09-28 13:34:35 -0700 | [diff] [blame] | 32 | #include "ResourceValues.h" |
| 33 | #include "ValueVisitor.h" |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 34 | #include "android-base/errors.h" |
| 35 | #include "android-base/expected.h" |
| 36 | #include "android-base/file.h" |
| 37 | #include "android-base/stringprintf.h" |
| 38 | #include "androidfw/IDiagnostics.h" |
| 39 | #include "androidfw/Locale.h" |
| 40 | #include "androidfw/StringPiece.h" |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 41 | #include "cmd/Util.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 42 | #include "compile/IdAssigner.h" |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 43 | #include "compile/XmlIdCollector.h" |
Adam Lesinski | 6a00817 | 2016-02-02 17:02:58 -0800 | [diff] [blame] | 44 | #include "filter/ConfigFilter.h" |
Adam Lesinski | 4670805 | 2017-09-29 14:49:15 -0700 | [diff] [blame] | 45 | #include "format/Archive.h" |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 46 | #include "format/Container.h" |
Adam Lesinski | 4670805 | 2017-09-29 14:49:15 -0700 | [diff] [blame] | 47 | #include "format/binary/TableFlattener.h" |
| 48 | #include "format/binary/XmlFlattener.h" |
| 49 | #include "format/proto/ProtoDeserialize.h" |
| 50 | #include "format/proto/ProtoSerialize.h" |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 51 | #include "io/BigBufferStream.h" |
| 52 | #include "io/FileStream.h" |
Adam Lesinski | a40e972 | 2015-11-24 19:11:46 -0800 | [diff] [blame] | 53 | #include "io/FileSystem.h" |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 54 | #include "io/Util.h" |
Adam Lesinski | a40e972 | 2015-11-24 19:11:46 -0800 | [diff] [blame] | 55 | #include "io/ZipArchive.h" |
Adam Lesinski | ca5638f | 2015-10-21 14:42:43 -0700 | [diff] [blame] | 56 | #include "java/JavaClassGenerator.h" |
| 57 | #include "java/ManifestClassGenerator.h" |
| 58 | #include "java/ProguardRules.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 59 | #include "link/Linkers.h" |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 60 | #include "link/ManifestFixer.h" |
Adam Lesinski | 34a1687 | 2018-02-23 16:18:10 -0800 | [diff] [blame] | 61 | #include "link/NoDefaultResourceRemover.h" |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 62 | #include "link/ReferenceLinker.h" |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 63 | #include "link/ResourceExcluder.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 64 | #include "link/TableMerger.h" |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 65 | #include "link/XmlCompatVersioner.h" |
Adam Lesinski | d48944a | 2017-02-21 14:22:30 -0800 | [diff] [blame] | 66 | #include "optimize/ResourceDeduper.h" |
| 67 | #include "optimize/VersionCollapser.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 68 | #include "process/IResourceTableConsumer.h" |
Inseob Kim | 5fe521e | 2023-09-15 16:38:50 +0900 | [diff] [blame] | 69 | #include "process/ProductFilter.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 70 | #include "process/SymbolTable.h" |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 71 | #include "split/TableSplitter.h" |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 72 | #include "trace/TraceBuffer.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 73 | #include "util/Files.h" |
Adam Lesinski | 467f171 | 2015-11-16 17:35:44 -0800 | [diff] [blame] | 74 | #include "xml/XmlDom.h" |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 75 | |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 76 | using ::aapt::io::FileInputStream; |
MÃ¥rten Kongstad | 24c9aa6 | 2018-06-20 08:46:41 +0200 | [diff] [blame] | 77 | using ::android::ConfigDescription; |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 78 | using ::android::StringPiece; |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 79 | using ::android::base::expected; |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 80 | using ::android::base::StringPrintf; |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 81 | using ::android::base::unexpected; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 82 | |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 83 | namespace aapt { |
| 84 | |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 85 | namespace { |
| 86 | |
| 87 | expected<ResourceTablePackage*, const char*> GetStaticLibraryPackage(ResourceTable* table) { |
| 88 | // Resource tables built by aapt2 always contain one package. This is a post condition of |
| 89 | // VerifyNoExternalPackages. |
| 90 | if (table->packages.size() != 1u) { |
| 91 | return unexpected("static library contains more than one package"); |
| 92 | } |
| 93 | return table->packages.back().get(); |
| 94 | } |
| 95 | |
| 96 | } // namespace |
| 97 | |
Ryan Mitchell | 22dc531 | 2020-06-01 12:17:07 -0700 | [diff] [blame] | 98 | constexpr uint8_t kAndroidPackageId = 0x01; |
| 99 | |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 100 | class LinkContext : public IAaptContext { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 101 | public: |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 102 | explicit LinkContext(android::IDiagnostics* diagnostics) |
Chris Warrington | 820d72a | 2017-04-27 15:27:01 +0100 | [diff] [blame] | 103 | : diagnostics_(diagnostics), name_mangler_({}), symbols_(&name_mangler_) { |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 104 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 105 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 106 | PackageType GetPackageType() override { |
| 107 | return package_type_; |
| 108 | } |
| 109 | |
| 110 | void SetPackageType(PackageType type) { |
| 111 | package_type_ = type; |
| 112 | } |
| 113 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 114 | android::IDiagnostics* GetDiagnostics() override { |
Chris Warrington | 820d72a | 2017-04-27 15:27:01 +0100 | [diff] [blame] | 115 | return diagnostics_; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 116 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 117 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 118 | NameMangler* GetNameMangler() override { |
| 119 | return &name_mangler_; |
| 120 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 121 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 122 | void SetNameManglerPolicy(const NameManglerPolicy& policy) { |
| 123 | name_mangler_ = NameMangler(policy); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 124 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 125 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 126 | const std::string& GetCompilationPackage() override { |
| 127 | return compilation_package_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 128 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 129 | |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 130 | void SetCompilationPackage(StringPiece package_name) { |
| 131 | compilation_package_ = std::string(package_name); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 132 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 133 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 134 | uint8_t GetPackageId() override { |
| 135 | return package_id_; |
| 136 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 137 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 138 | void SetPackageId(uint8_t id) { |
| 139 | package_id_ = id; |
| 140 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 141 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 142 | SymbolTable* GetExternalSymbols() override { |
| 143 | return &symbols_; |
| 144 | } |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 145 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 146 | bool IsVerbose() override { |
| 147 | return verbose_; |
| 148 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 149 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 150 | void SetVerbose(bool val) { |
| 151 | verbose_ = val; |
Brandon Liu | 48d229d | 2023-05-04 23:54:03 +0000 | [diff] [blame] | 152 | diagnostics_->SetVerbose(val); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 153 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 154 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 155 | int GetMinSdkVersion() override { |
| 156 | return min_sdk_version_; |
| 157 | } |
Adam Lesinski | fb6312f | 2016-06-28 14:40:32 -0700 | [diff] [blame] | 158 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 159 | void SetMinSdkVersion(int minSdk) { |
| 160 | min_sdk_version_ = minSdk; |
| 161 | } |
Adam Lesinski | fb6312f | 2016-06-28 14:40:32 -0700 | [diff] [blame] | 162 | |
Udam Saini | b228df3 | 2019-06-18 16:50:34 -0700 | [diff] [blame] | 163 | const std::set<std::string>& GetSplitNameDependencies() override { |
| 164 | return split_name_dependencies_; |
| 165 | } |
| 166 | |
| 167 | void SetSplitNameDependencies(const std::set<std::string>& split_name_dependencies) { |
| 168 | split_name_dependencies_ = split_name_dependencies; |
| 169 | } |
| 170 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 171 | private: |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 172 | DISALLOW_COPY_AND_ASSIGN(LinkContext); |
| 173 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 174 | PackageType package_type_ = PackageType::kApp; |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 175 | android::IDiagnostics* diagnostics_; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 176 | NameMangler name_mangler_; |
| 177 | std::string compilation_package_; |
| 178 | uint8_t package_id_ = 0x0; |
| 179 | SymbolTable symbols_; |
| 180 | bool verbose_ = false; |
| 181 | int min_sdk_version_ = 0; |
Udam Saini | b228df3 | 2019-06-18 16:50:34 -0700 | [diff] [blame] | 182 | std::set<std::string> split_name_dependencies_; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 183 | }; |
| 184 | |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 185 | // A custom delegate that generates compatible pre-O IDs for use with feature splits. |
| 186 | // Feature splits use package IDs > 7f, which in Java (since Java doesn't have unsigned ints) |
| 187 | // is interpreted as a negative number. Some verification was wrongly assuming negative values |
| 188 | // were invalid. |
| 189 | // |
| 190 | // This delegate will attempt to masquerade any '@id/' references with ID 0xPPTTEEEE, |
| 191 | // where PP > 7f, as 0x7fPPEEEE. Any potential overlapping is verified and an error occurs if such |
| 192 | // an overlap exists. |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 193 | // |
| 194 | // See b/37498913. |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 195 | class FeatureSplitSymbolTableDelegate : public DefaultSymbolTableDelegate { |
| 196 | public: |
Chih-Hung Hsieh | 1fc78e1 | 2018-12-20 13:37:44 -0800 | [diff] [blame] | 197 | explicit FeatureSplitSymbolTableDelegate(IAaptContext* context) : context_(context) { |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 198 | } |
| 199 | |
| 200 | virtual ~FeatureSplitSymbolTableDelegate() = default; |
| 201 | |
| 202 | virtual std::unique_ptr<SymbolTable::Symbol> FindByName( |
| 203 | const ResourceName& name, |
| 204 | const std::vector<std::unique_ptr<ISymbolSource>>& sources) override { |
| 205 | std::unique_ptr<SymbolTable::Symbol> symbol = |
| 206 | DefaultSymbolTableDelegate::FindByName(name, sources); |
| 207 | if (symbol == nullptr) { |
| 208 | return {}; |
| 209 | } |
| 210 | |
| 211 | // Check to see if this is an 'id' with the target package. |
Iurii Makhno | cff10ce | 2022-02-15 19:33:50 +0000 | [diff] [blame] | 212 | if (name.type.type == ResourceType::kId && symbol->id) { |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 213 | ResourceId* id = &symbol->id.value(); |
| 214 | if (id->package_id() > kAppPackageId) { |
| 215 | // Rewrite the resource ID to be compatible pre-O. |
| 216 | ResourceId rewritten_id(kAppPackageId, id->package_id(), id->entry_id()); |
| 217 | |
| 218 | // Check that this doesn't overlap another resource. |
| 219 | if (DefaultSymbolTableDelegate::FindById(rewritten_id, sources) != nullptr) { |
| 220 | // The ID overlaps, so log a message (since this is a weird failure) and fail. |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 221 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 222 | << "Failed to rewrite " << name |
| 223 | << " for pre-O feature split support"); |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 224 | return {}; |
| 225 | } |
| 226 | |
| 227 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 228 | context_->GetDiagnostics()->Note(android::DiagMessage() |
| 229 | << "rewriting " << name << " (" << *id << ") -> (" |
| 230 | << rewritten_id << ")"); |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 231 | } |
| 232 | |
| 233 | *id = rewritten_id; |
| 234 | } |
| 235 | } |
| 236 | return symbol; |
| 237 | } |
| 238 | |
| 239 | private: |
| 240 | DISALLOW_COPY_AND_ASSIGN(FeatureSplitSymbolTableDelegate); |
| 241 | |
| 242 | IAaptContext* context_; |
| 243 | }; |
| 244 | |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 245 | static bool FlattenXml(IAaptContext* context, const xml::XmlResource& xml_res, StringPiece path, |
| 246 | bool keep_raw_values, bool utf16, OutputFormat format, |
| 247 | IArchiveWriter* writer) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 248 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 249 | if (context->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 250 | context->GetDiagnostics()->Note(android::DiagMessage(path) |
| 251 | << "writing to archive (keep_raw_values=" |
| 252 | << (keep_raw_values ? "true" : "false") << ")"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 253 | } |
| 254 | |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 255 | switch (format) { |
| 256 | case OutputFormat::kApk: { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 257 | android::BigBuffer buffer(1024); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 258 | XmlFlattenerOptions options = {}; |
| 259 | options.keep_raw_values = keep_raw_values; |
| 260 | options.use_utf16 = utf16; |
| 261 | XmlFlattener flattener(&buffer, options); |
| 262 | if (!flattener.Consume(context, &xml_res)) { |
| 263 | return false; |
| 264 | } |
| 265 | |
| 266 | io::BigBufferInputStream input_stream(&buffer); |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 267 | return io::CopyInputStreamToArchive(context, &input_stream, path, ArchiveEntry::kCompress, |
| 268 | writer); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 269 | } break; |
| 270 | |
| 271 | case OutputFormat::kProto: { |
| 272 | pb::XmlNode pb_node; |
Ryan Mitchell | 467b689 | 2018-11-09 15:52:07 -0800 | [diff] [blame] | 273 | // Strip whitespace text nodes from tha AndroidManifest.xml |
| 274 | SerializeXmlOptions options; |
| 275 | options.remove_empty_text_nodes = (path == kAndroidManifestPath); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 276 | SerializeXmlResourceToPb(xml_res, &pb_node); |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 277 | return io::CopyProtoToArchive(context, &pb_node, path, ArchiveEntry::kCompress, writer); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 278 | } break; |
| 279 | } |
| 280 | return false; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 281 | } |
| 282 | |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 283 | // Inflates an XML file from the source path. |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 284 | static std::unique_ptr<xml::XmlResource> LoadXml(const std::string& path, |
| 285 | android::IDiagnostics* diag) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 286 | TRACE_CALL(); |
Adam Lesinski | efeb7af | 2017-08-02 14:57:43 -0700 | [diff] [blame] | 287 | FileInputStream fin(path); |
| 288 | if (fin.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 289 | diag->Error(android::DiagMessage(path) << "failed to load XML file: " << fin.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 290 | return {}; |
| 291 | } |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 292 | return xml::Inflate(&fin, diag, android::Source(path)); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 293 | } |
| 294 | |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 295 | struct ResourceFileFlattenerOptions { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 296 | bool no_auto_version = false; |
| 297 | bool no_version_vectors = false; |
Yuichi Araki | 4d35cca | 2017-01-18 20:42:17 +0900 | [diff] [blame] | 298 | bool no_version_transitions = false; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 299 | bool no_xml_namespaces = false; |
| 300 | bool keep_raw_values = false; |
| 301 | bool do_not_compress_anything = false; |
| 302 | bool update_proguard_spec = false; |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 303 | bool do_not_fail_on_missing_resources = false; |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 304 | OutputFormat output_format = OutputFormat::kApk; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 305 | std::unordered_set<std::string> extensions_to_not_compress; |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 306 | std::optional<std::regex> regex_to_not_compress; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 307 | }; |
| 308 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 309 | // A sampling of public framework resource IDs. |
| 310 | struct R { |
| 311 | struct attr { |
| 312 | enum : uint32_t { |
| 313 | paddingLeft = 0x010100d6u, |
| 314 | paddingRight = 0x010100d8u, |
| 315 | paddingHorizontal = 0x0101053du, |
| 316 | |
| 317 | paddingTop = 0x010100d7u, |
| 318 | paddingBottom = 0x010100d9u, |
| 319 | paddingVertical = 0x0101053eu, |
| 320 | |
| 321 | layout_marginLeft = 0x010100f7u, |
| 322 | layout_marginRight = 0x010100f9u, |
| 323 | layout_marginHorizontal = 0x0101053bu, |
| 324 | |
| 325 | layout_marginTop = 0x010100f8u, |
| 326 | layout_marginBottom = 0x010100fau, |
| 327 | layout_marginVertical = 0x0101053cu, |
| 328 | }; |
| 329 | }; |
| 330 | }; |
| 331 | |
Ryan Mitchell | 81dfca0 | 2019-06-07 10:20:27 -0700 | [diff] [blame] | 332 | template <typename T> |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 333 | uint32_t GetCompressionFlags(StringPiece str, T options) { |
Ryan Mitchell | 81dfca0 | 2019-06-07 10:20:27 -0700 | [diff] [blame] | 334 | if (options.do_not_compress_anything) { |
| 335 | return 0; |
| 336 | } |
| 337 | |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 338 | if (options.regex_to_not_compress && |
| 339 | std::regex_search(str.begin(), str.end(), options.regex_to_not_compress.value())) { |
Ryan Mitchell | 81dfca0 | 2019-06-07 10:20:27 -0700 | [diff] [blame] | 340 | return 0; |
| 341 | } |
| 342 | |
| 343 | for (const std::string& extension : options.extensions_to_not_compress) { |
| 344 | if (util::EndsWith(str, extension)) { |
| 345 | return 0; |
| 346 | } |
| 347 | } |
| 348 | return ArchiveEntry::kCompress; |
| 349 | } |
| 350 | |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 351 | class ResourceFileFlattener { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 352 | public: |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 353 | ResourceFileFlattener(const ResourceFileFlattenerOptions& options, IAaptContext* context, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 354 | proguard::KeepSet* keep_set); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 355 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 356 | bool Flatten(ResourceTable* table, IArchiveWriter* archive_writer); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 357 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 358 | private: |
| 359 | struct FileOperation { |
| 360 | ConfigDescription config; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 361 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 362 | // The entry this file came from. |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 363 | ResourceEntry* entry; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 364 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 365 | // The file to copy as-is. |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 366 | io::IFile* file_to_copy; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 367 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 368 | // The XML to process and flatten. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 369 | std::unique_ptr<xml::XmlResource> xml_to_flatten; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 370 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 371 | // The destination to write this file to. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 372 | std::string dst_path; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 373 | }; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 374 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 375 | std::vector<std::unique_ptr<xml::XmlResource>> LinkAndVersionXmlFile(ResourceTable* table, |
| 376 | FileOperation* file_op); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 377 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 378 | ResourceFileFlattenerOptions options_; |
| 379 | IAaptContext* context_; |
| 380 | proguard::KeepSet* keep_set_; |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 381 | XmlCompatVersioner::Rules rules_; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 382 | }; |
| 383 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 384 | ResourceFileFlattener::ResourceFileFlattener(const ResourceFileFlattenerOptions& options, |
| 385 | IAaptContext* context, proguard::KeepSet* keep_set) |
| 386 | : options_(options), context_(context), keep_set_(keep_set) { |
| 387 | SymbolTable* symm = context_->GetExternalSymbols(); |
| 388 | |
| 389 | // Build up the rules for degrading newer attributes to older ones. |
| 390 | // NOTE(adamlesinski): These rules are hardcoded right now, but they should be |
| 391 | // generated from the attribute definitions themselves (b/62028956). |
| 392 | if (const SymbolTable::Symbol* s = symm->FindById(R::attr::paddingHorizontal)) { |
| 393 | std::vector<ReplacementAttr> replacements{ |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 394 | {"paddingLeft", R::attr::paddingLeft, Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
| 395 | {"paddingRight", R::attr::paddingRight, Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 396 | }; |
| 397 | rules_[R::attr::paddingHorizontal] = |
| 398 | util::make_unique<DegradeToManyRule>(std::move(replacements)); |
| 399 | } |
| 400 | |
| 401 | if (const SymbolTable::Symbol* s = symm->FindById(R::attr::paddingVertical)) { |
| 402 | std::vector<ReplacementAttr> replacements{ |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 403 | {"paddingTop", R::attr::paddingTop, Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
| 404 | {"paddingBottom", R::attr::paddingBottom, Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 405 | }; |
| 406 | rules_[R::attr::paddingVertical] = |
| 407 | util::make_unique<DegradeToManyRule>(std::move(replacements)); |
| 408 | } |
| 409 | |
| 410 | if (const SymbolTable::Symbol* s = symm->FindById(R::attr::layout_marginHorizontal)) { |
| 411 | std::vector<ReplacementAttr> replacements{ |
| 412 | {"layout_marginLeft", R::attr::layout_marginLeft, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 413 | Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 414 | {"layout_marginRight", R::attr::layout_marginRight, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 415 | Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 416 | }; |
| 417 | rules_[R::attr::layout_marginHorizontal] = |
| 418 | util::make_unique<DegradeToManyRule>(std::move(replacements)); |
| 419 | } |
| 420 | |
| 421 | if (const SymbolTable::Symbol* s = symm->FindById(R::attr::layout_marginVertical)) { |
| 422 | std::vector<ReplacementAttr> replacements{ |
| 423 | {"layout_marginTop", R::attr::layout_marginTop, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 424 | Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 425 | {"layout_marginBottom", R::attr::layout_marginBottom, |
Adam Lesinski | 73bff1e | 2017-12-08 16:06:10 -0800 | [diff] [blame] | 426 | Attribute(android::ResTable_map::TYPE_DIMENSION)}, |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 427 | }; |
| 428 | rules_[R::attr::layout_marginVertical] = |
| 429 | util::make_unique<DegradeToManyRule>(std::move(replacements)); |
| 430 | } |
| 431 | } |
| 432 | |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 433 | static bool IsTransitionElement(const std::string& name) { |
| 434 | return name == "fade" || name == "changeBounds" || name == "slide" || name == "explode" || |
| 435 | name == "changeImageTransform" || name == "changeTransform" || |
| 436 | name == "changeClipBounds" || name == "autoTransition" || name == "recolor" || |
| 437 | name == "changeScroll" || name == "transitionSet" || name == "transition" || |
| 438 | name == "transitionManager"; |
| 439 | } |
| 440 | |
| 441 | static bool IsVectorElement(const std::string& name) { |
| 442 | return name == "vector" || name == "animated-vector" || name == "pathInterpolator" || |
Winson | a00d969 | 2019-01-24 15:55:29 -0800 | [diff] [blame] | 443 | name == "objectAnimator" || name == "gradient" || name == "animated-selector" || |
| 444 | name == "set"; |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 445 | } |
| 446 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 447 | template <typename T> |
| 448 | std::vector<T> make_singleton_vec(T&& val) { |
| 449 | std::vector<T> vec; |
| 450 | vec.emplace_back(std::forward<T>(val)); |
| 451 | return vec; |
| 452 | } |
| 453 | |
| 454 | std::vector<std::unique_ptr<xml::XmlResource>> ResourceFileFlattener::LinkAndVersionXmlFile( |
| 455 | ResourceTable* table, FileOperation* file_op) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 456 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 457 | xml::XmlResource* doc = file_op->xml_to_flatten.get(); |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 458 | const android::Source& src = doc->file.source; |
Adam Lesinski | 5eeaadd | 2016-08-25 12:26:56 -0700 | [diff] [blame] | 459 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 460 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 461 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 462 | << "linking " << src.path << " (" << doc->file.name << ")"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 463 | } |
| 464 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 465 | // First, strip out any tools namespace attributes. AAPT stripped them out early, which means |
| 466 | // that existing projects have out-of-date references which pass compilation. |
| 467 | xml::StripAndroidStudioAttributes(doc->root.get()); |
| 468 | |
Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 469 | XmlReferenceLinker xml_linker(table); |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 470 | if (!options_.do_not_fail_on_missing_resources && !xml_linker.Consume(context_, doc)) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 471 | return {}; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 472 | } |
| 473 | |
Ryan Mitchell | 9a2f6e6 | 2018-05-23 14:23:18 -0700 | [diff] [blame] | 474 | if (options_.update_proguard_spec && !proguard::CollectProguardRules(context_, doc, keep_set_)) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 475 | return {}; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 476 | } |
| 477 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 478 | if (options_.no_xml_namespaces) { |
| 479 | XmlNamespaceRemover namespace_remover; |
| 480 | if (!namespace_remover.Consume(context_, doc)) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 481 | return {}; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 482 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 483 | } |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 484 | |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 485 | if (options_.no_auto_version) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 486 | return make_singleton_vec(std::move(file_op->xml_to_flatten)); |
| 487 | } |
Alexandria Cornwall | a7cc3f1 | 2016-08-16 13:33:32 -0700 | [diff] [blame] | 488 | |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 489 | if (options_.no_version_vectors || options_.no_version_transitions) { |
| 490 | // Skip this if it is a vector or animated-vector. |
Adam Lesinski | 6b37299 | 2017-08-09 10:54:23 -0700 | [diff] [blame] | 491 | xml::Element* el = doc->root.get(); |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 492 | if (el && el->namespace_uri.empty()) { |
| 493 | if ((options_.no_version_vectors && IsVectorElement(el->name)) || |
| 494 | (options_.no_version_transitions && IsTransitionElement(el->name))) { |
| 495 | return make_singleton_vec(std::move(file_op->xml_to_flatten)); |
| 496 | } |
| 497 | } |
| 498 | } |
| 499 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 500 | const ConfigDescription& config = file_op->config; |
| 501 | ResourceEntry* entry = file_op->entry; |
| 502 | |
| 503 | XmlCompatVersioner xml_compat_versioner(&rules_); |
| 504 | const util::Range<ApiVersion> api_range{config.sdkVersion, |
| 505 | FindNextApiVersionForConfig(entry, config)}; |
| 506 | return xml_compat_versioner.Process(context_, doc, api_range); |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 507 | } |
| 508 | |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 509 | ResourceFile::Type XmlFileTypeForOutputFormat(OutputFormat format) { |
| 510 | switch (format) { |
| 511 | case OutputFormat::kApk: |
| 512 | return ResourceFile::Type::kBinaryXml; |
| 513 | case OutputFormat::kProto: |
| 514 | return ResourceFile::Type::kProtoXml; |
| 515 | } |
| 516 | LOG_ALWAYS_FATAL("unreachable"); |
| 517 | return ResourceFile::Type::kUnknown; |
| 518 | } |
| 519 | |
Ryan Mitchell | 70f7972 | 2018-08-13 07:37:24 -0700 | [diff] [blame] | 520 | static auto kDrawableVersions = std::map<std::string, ApiVersion>{ |
| 521 | { "adaptive-icon" , SDK_O }, |
| 522 | }; |
| 523 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 524 | bool ResourceFileFlattener::Flatten(ResourceTable* table, IArchiveWriter* archive_writer) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 525 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 526 | bool error = false; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 527 | std::map<std::pair<ConfigDescription, StringPiece>, FileOperation> config_sorted_files; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 528 | |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 529 | proguard::CollectResourceReferences(context_, table, keep_set_); |
| 530 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 531 | for (auto& pkg : table->packages) { |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 532 | CHECK(!pkg->name.empty()) << "Packages must have names when being linked"; |
| 533 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 534 | for (auto& type : pkg->types) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 535 | // Sort by config and name, so that we get better locality in the zip file. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 536 | config_sorted_files.clear(); |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 537 | std::queue<FileOperation> file_operations; |
Adam Lesinski | 355f285 | 2016-02-13 20:26:45 -0800 | [diff] [blame] | 538 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 539 | // Populate the queue with all files in the ResourceTable. |
| 540 | for (auto& entry : type->entries) { |
Adam Lesinski | bb94f32 | 2017-07-12 07:41:55 -0700 | [diff] [blame] | 541 | for (auto& config_value : entry->values) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 542 | // WARNING! Do not insert or remove any resources while executing in this scope. It will |
| 543 | // corrupt the iteration order. |
| 544 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 545 | FileReference* file_ref = ValueCast<FileReference>(config_value->value.get()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 546 | if (!file_ref) { |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 547 | continue; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 548 | } |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 549 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 550 | io::IFile* file = file_ref->file; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 551 | if (!file) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 552 | context_->GetDiagnostics()->Error(android::DiagMessage(file_ref->GetSource()) |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 553 | << "file not found"); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 554 | return false; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 555 | } |
| 556 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 557 | FileOperation file_op; |
| 558 | file_op.entry = entry.get(); |
| 559 | file_op.dst_path = *file_ref->path; |
| 560 | file_op.config = config_value->config; |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 561 | file_op.file_to_copy = file; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 562 | |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 563 | if (type->named_type.type != ResourceType::kRaw && |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 564 | (file_ref->type == ResourceFile::Type::kBinaryXml || |
| 565 | file_ref->type == ResourceFile::Type::kProtoXml)) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 566 | std::unique_ptr<io::IData> data = file->OpenAsData(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 567 | if (!data) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 568 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 569 | << "failed to open file"); |
| 570 | return false; |
| 571 | } |
| 572 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 573 | if (file_ref->type == ResourceFile::Type::kProtoXml) { |
| 574 | pb::XmlNode pb_xml_node; |
| 575 | if (!pb_xml_node.ParseFromArray(data->data(), static_cast<int>(data->size()))) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 576 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 577 | << "failed to parse proto XML"); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 578 | return false; |
| 579 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 580 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 581 | std::string error; |
| 582 | file_op.xml_to_flatten = DeserializeXmlResourceFromPb(pb_xml_node, &error); |
| 583 | if (file_op.xml_to_flatten == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 584 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 585 | << "failed to deserialize proto XML: " << error); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 586 | return false; |
| 587 | } |
| 588 | } else { |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 589 | std::string error_str; |
| 590 | file_op.xml_to_flatten = xml::Inflate(data->data(), data->size(), &error_str); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 591 | if (file_op.xml_to_flatten == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 592 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 593 | << "failed to parse binary XML: " << error_str); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 594 | return false; |
| 595 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 596 | } |
| 597 | |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 598 | // Update the type that this file will be written as. |
| 599 | file_ref->type = XmlFileTypeForOutputFormat(options_.output_format); |
| 600 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 601 | file_op.xml_to_flatten->file.config = config_value->config; |
| 602 | file_op.xml_to_flatten->file.source = file_ref->GetSource(); |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 603 | file_op.xml_to_flatten->file.name = |
| 604 | ResourceName(pkg->name, type->named_type, entry->name); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 605 | } |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 606 | |
| 607 | // NOTE(adamlesinski): Explicitly construct a StringPiece here, or |
| 608 | // else we end up copying the string in the std::make_pair() method, |
| 609 | // then creating a StringPiece from the copy, which would cause us |
| 610 | // to end up referencing garbage in the map. |
| 611 | const StringPiece entry_name(entry->name); |
| 612 | config_sorted_files[std::make_pair(config_value->config, entry_name)] = |
| 613 | std::move(file_op); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 614 | } |
| 615 | } |
| 616 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 617 | // Now flatten the sorted values. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 618 | for (auto& map_entry : config_sorted_files) { |
| 619 | const ConfigDescription& config = map_entry.first.first; |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 620 | FileOperation& file_op = map_entry.second; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 621 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 622 | if (file_op.xml_to_flatten) { |
Ryan Mitchell | 70f7972 | 2018-08-13 07:37:24 -0700 | [diff] [blame] | 623 | // Check minimum sdk versions supported for drawables |
| 624 | auto drawable_entry = kDrawableVersions.find(file_op.xml_to_flatten->root->name); |
| 625 | if (drawable_entry != kDrawableVersions.end()) { |
| 626 | if (drawable_entry->second > context_->GetMinSdkVersion() |
| 627 | && drawable_entry->second > config.sdkVersion) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 628 | context_->GetDiagnostics()->Error( |
| 629 | android::DiagMessage(file_op.xml_to_flatten->file.source) |
| 630 | << "<" << drawable_entry->first << "> elements " |
| 631 | << "require a sdk version of at least " << (int16_t)drawable_entry->second); |
Ryan Mitchell | 70f7972 | 2018-08-13 07:37:24 -0700 | [diff] [blame] | 632 | error = true; |
| 633 | continue; |
| 634 | } |
| 635 | } |
| 636 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 637 | std::vector<std::unique_ptr<xml::XmlResource>> versioned_docs = |
| 638 | LinkAndVersionXmlFile(table, &file_op); |
Adam Lesinski | c0a5e1e | 2017-08-07 11:56:32 -0700 | [diff] [blame] | 639 | if (versioned_docs.empty()) { |
| 640 | error = true; |
| 641 | continue; |
| 642 | } |
| 643 | |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 644 | for (std::unique_ptr<xml::XmlResource>& doc : versioned_docs) { |
| 645 | std::string dst_path = file_op.dst_path; |
| 646 | if (doc->file.config != file_op.config) { |
| 647 | // Only add the new versioned configurations. |
| 648 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 649 | context_->GetDiagnostics()->Note(android::DiagMessage(doc->file.source) |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 650 | << "auto-versioning resource from config '" |
| 651 | << config << "' -> '" << doc->file.config << "'"); |
| 652 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 653 | |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 654 | const ResourceFile& file = doc->file; |
| 655 | dst_path = ResourceUtils::BuildResourceFileName(file, context_->GetNameMangler()); |
| 656 | |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 657 | auto file_ref = |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 658 | util::make_unique<FileReference>(table->string_pool.MakeRef(dst_path)); |
| 659 | file_ref->SetSource(doc->file.source); |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 660 | |
Adam Lesinski | a65bbdf | 2018-02-15 12:39:44 -0800 | [diff] [blame] | 661 | // Update the output format of this XML file. |
| 662 | file_ref->type = XmlFileTypeForOutputFormat(options_.output_format); |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 663 | bool result = table->AddResource(NewResourceBuilder(file.name) |
| 664 | .SetValue(std::move(file_ref), file.config) |
| 665 | .SetAllowMangled(true) |
| 666 | .Build(), |
| 667 | context_->GetDiagnostics()); |
| 668 | if (!result) { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 669 | return false; |
| 670 | } |
| 671 | } |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 672 | |
| 673 | error |= !FlattenXml(context_, *doc, dst_path, options_.keep_raw_values, |
| 674 | false /*utf16*/, options_.output_format, archive_writer); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 675 | } |
| 676 | } else { |
Adam Lesinski | c744ae8 | 2017-05-17 19:28:38 -0700 | [diff] [blame] | 677 | error |= !io::CopyFileToArchive(context_, file_op.file_to_copy, file_op.dst_path, |
Ryan Mitchell | 81dfca0 | 2019-06-07 10:20:27 -0700 | [diff] [blame] | 678 | GetCompressionFlags(file_op.dst_path, options_), |
| 679 | archive_writer); |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 680 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 681 | } |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 682 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 683 | } |
| 684 | return !error; |
| 685 | } |
| 686 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 687 | static bool WriteStableIdMapToPath(android::IDiagnostics* diag, |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 688 | const std::unordered_map<ResourceName, ResourceId>& id_map, |
| 689 | const std::string& id_map_path) { |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 690 | io::FileOutputStream fout(id_map_path); |
| 691 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 692 | diag->Error(android::DiagMessage(id_map_path) << "failed to open: " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 693 | return false; |
| 694 | } |
| 695 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 696 | text::Printer printer(&fout); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 697 | for (const auto& entry : id_map) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 698 | const ResourceName& name = entry.first; |
| 699 | const ResourceId& id = entry.second; |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 700 | printer.Print(name.to_string()); |
| 701 | printer.Print(" = "); |
| 702 | printer.Println(id.to_string()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 703 | } |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 704 | fout.Flush(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 705 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 706 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 707 | diag->Error(android::DiagMessage(id_map_path) << "failed writing to file: " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 708 | return false; |
| 709 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 710 | return true; |
| 711 | } |
| 712 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 713 | static bool LoadStableIdMap(android::IDiagnostics* diag, const std::string& path, |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 714 | std::unordered_map<ResourceName, ResourceId>* out_id_map) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 715 | std::string content; |
Adam Lesinski | 2354b56 | 2017-05-26 16:31:38 -0700 | [diff] [blame] | 716 | if (!android::base::ReadFileToString(path, &content, true /*follow_symlinks*/)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 717 | diag->Error(android::DiagMessage(path) << "failed reading stable ID file"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 718 | return false; |
| 719 | } |
| 720 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 721 | out_id_map->clear(); |
| 722 | size_t line_no = 0; |
| 723 | for (StringPiece line : util::Tokenize(content, '\n')) { |
| 724 | line_no++; |
| 725 | line = util::TrimWhitespace(line); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 726 | if (line.empty()) { |
| 727 | continue; |
| 728 | } |
| 729 | |
| 730 | auto iter = std::find(line.begin(), line.end(), '='); |
| 731 | if (iter == line.end()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 732 | diag->Error(android::DiagMessage(android::Source(path, line_no)) << "missing '='"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 733 | return false; |
| 734 | } |
| 735 | |
| 736 | ResourceNameRef name; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 737 | StringPiece res_name_str = |
| 738 | util::TrimWhitespace(line.substr(0, std::distance(line.begin(), iter))); |
| 739 | if (!ResourceUtils::ParseResourceName(res_name_str, &name)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 740 | diag->Error(android::DiagMessage(android::Source(path, line_no)) |
| 741 | << "invalid resource name '" << res_name_str << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 742 | return false; |
| 743 | } |
| 744 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 745 | const size_t res_id_start_idx = std::distance(line.begin(), iter) + 1; |
| 746 | const size_t res_id_str_len = line.size() - res_id_start_idx; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 747 | StringPiece res_id_str = util::TrimWhitespace(line.substr(res_id_start_idx, res_id_str_len)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 748 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 749 | std::optional<ResourceId> maybe_id = ResourceUtils::ParseResourceId(res_id_str); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 750 | if (!maybe_id) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 751 | diag->Error(android::DiagMessage(android::Source(path, line_no)) |
| 752 | << "invalid resource ID '" << res_id_str << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 753 | return false; |
| 754 | } |
| 755 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 756 | (*out_id_map)[name.ToResourceName()] = maybe_id.value(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 757 | } |
| 758 | return true; |
Adam Lesinski | bf0bd0f | 2016-06-01 15:31:50 -0700 | [diff] [blame] | 759 | } |
| 760 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 761 | class Linker { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 762 | public: |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 763 | Linker(LinkContext* context, const LinkOptions& options) |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 764 | : options_(options), |
| 765 | context_(context), |
| 766 | final_table_(), |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 767 | file_collection_(util::make_unique<io::FileCollection>()) { |
| 768 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 769 | |
Ryan Mitchell | a55dc2e | 2019-01-24 10:58:23 -0800 | [diff] [blame] | 770 | void ExtractCompileSdkVersions(android::AssetManager2* assets) { |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 771 | using namespace android; |
| 772 | |
Ryan Mitchell | db21f09a | 2020-11-16 23:08:18 +0000 | [diff] [blame] | 773 | // Find the system package (0x01). AAPT always generates attributes with the type 0x01, so |
| 774 | // we're looking for the first attribute resource in the system package. |
| 775 | android::ApkAssetsCookie cookie; |
| 776 | if (auto value = assets->GetResource(0x01010000, true /** may_be_bag */); value.has_value()) { |
| 777 | cookie = value->cookie; |
| 778 | } else { |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 779 | // No Framework assets loaded. Not a failure. |
| 780 | return; |
| 781 | } |
| 782 | |
| 783 | std::unique_ptr<Asset> manifest( |
Ryan Mitchell | a55dc2e | 2019-01-24 10:58:23 -0800 | [diff] [blame] | 784 | assets->OpenNonAsset(kAndroidManifestPath, cookie, Asset::AccessMode::ACCESS_BUFFER)); |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 785 | if (manifest == nullptr) { |
| 786 | // No errors. |
| 787 | return; |
| 788 | } |
| 789 | |
| 790 | std::string error; |
| 791 | std::unique_ptr<xml::XmlResource> manifest_xml = |
| 792 | xml::Inflate(manifest->getBuffer(true /*wordAligned*/), manifest->getLength(), &error); |
| 793 | if (manifest_xml == nullptr) { |
| 794 | // No errors. |
| 795 | return; |
| 796 | } |
| 797 | |
Todd Kennedy | 9f6dec1 | 2018-04-20 12:29:29 -0700 | [diff] [blame] | 798 | if (!options_.manifest_fixer_options.compile_sdk_version) { |
| 799 | xml::Attribute* attr = manifest_xml->root->FindAttribute(xml::kSchemaAndroid, "versionCode"); |
| 800 | if (attr != nullptr) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 801 | auto& compile_sdk_version = options_.manifest_fixer_options.compile_sdk_version; |
Todd Kennedy | 9f6dec1 | 2018-04-20 12:29:29 -0700 | [diff] [blame] | 802 | if (BinaryPrimitive* prim = ValueCast<BinaryPrimitive>(attr->compiled_value.get())) { |
| 803 | switch (prim->value.dataType) { |
| 804 | case Res_value::TYPE_INT_DEC: |
| 805 | compile_sdk_version = StringPrintf("%" PRId32, static_cast<int32_t>(prim->value.data)); |
| 806 | break; |
| 807 | case Res_value::TYPE_INT_HEX: |
| 808 | compile_sdk_version = StringPrintf("%" PRIx32, prim->value.data); |
| 809 | break; |
| 810 | default: |
| 811 | break; |
| 812 | } |
| 813 | } else if (String* str = ValueCast<String>(attr->compiled_value.get())) { |
| 814 | compile_sdk_version = *str->value; |
| 815 | } else { |
| 816 | compile_sdk_version = attr->value; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 817 | } |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 818 | } |
| 819 | } |
| 820 | |
Todd Kennedy | 9f6dec1 | 2018-04-20 12:29:29 -0700 | [diff] [blame] | 821 | if (!options_.manifest_fixer_options.compile_sdk_version_codename) { |
| 822 | xml::Attribute* attr = manifest_xml->root->FindAttribute(xml::kSchemaAndroid, "versionName"); |
| 823 | if (attr != nullptr) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 824 | std::optional<std::string>& compile_sdk_version_codename = |
Todd Kennedy | 9f6dec1 | 2018-04-20 12:29:29 -0700 | [diff] [blame] | 825 | options_.manifest_fixer_options.compile_sdk_version_codename; |
| 826 | if (String* str = ValueCast<String>(attr->compiled_value.get())) { |
| 827 | compile_sdk_version_codename = *str->value; |
| 828 | } else { |
| 829 | compile_sdk_version_codename = attr->value; |
| 830 | } |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 831 | } |
| 832 | } |
| 833 | } |
| 834 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 835 | // Creates a SymbolTable that loads symbols from the various APKs. |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 836 | // Pre-condition: context_->GetCompilationPackage() needs to be set. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 837 | bool LoadSymbolsFromIncludePaths() { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 838 | TRACE_NAME("LoadSymbolsFromIncludePaths: #" + std::to_string(options_.include_paths.size())); |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 839 | auto asset_source = util::make_unique<AssetManagerSymbolSource>(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 840 | for (const std::string& path : options_.include_paths) { |
| 841 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 842 | context_->GetDiagnostics()->Note(android::DiagMessage() << "including " << path); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 843 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 844 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 845 | std::string error; |
| 846 | auto zip_collection = io::ZipFileCollection::Create(path, &error); |
| 847 | if (zip_collection == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 848 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 849 | << "failed to open APK: " << error); |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 850 | return false; |
| 851 | } |
| 852 | |
| 853 | if (zip_collection->FindFile(kProtoResourceTablePath) != nullptr) { |
| 854 | // Load this as a static library include. |
| 855 | std::unique_ptr<LoadedApk> static_apk = LoadedApk::LoadProtoApkFromFileCollection( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 856 | android::Source(path), std::move(zip_collection), context_->GetDiagnostics()); |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 857 | if (static_apk == nullptr) { |
| 858 | return false; |
| 859 | } |
| 860 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 861 | if (context_->GetPackageType() != PackageType::kStaticLib) { |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 862 | // Can't include static libraries when not building a static library (they have no IDs |
| 863 | // assigned). |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 864 | context_->GetDiagnostics()->Error( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 865 | android::DiagMessage(path) |
| 866 | << "can't include static library when not building a static lib"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 867 | return false; |
| 868 | } |
| 869 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 870 | ResourceTable* table = static_apk->GetResourceTable(); |
| 871 | |
| 872 | // If we are using --no-static-lib-packages, we need to rename the package of this table to |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 873 | // our compilation package so the symbol package name does not get mangled into the entry |
| 874 | // name. |
| 875 | if (options_.no_static_lib_packages && !table->packages.empty()) { |
| 876 | auto lib_package_result = GetStaticLibraryPackage(table); |
| 877 | if (!lib_package_result.has_value()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 878 | context_->GetDiagnostics()->Error(android::DiagMessage(path) |
| 879 | << lib_package_result.error()); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 880 | return false; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 881 | } |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 882 | lib_package_result.value()->name = context_->GetCompilationPackage(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 883 | } |
| 884 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 885 | context_->GetExternalSymbols()->AppendSource( |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 886 | util::make_unique<ResourceTableSymbolSource>(table)); |
| 887 | static_library_includes_.push_back(std::move(static_apk)); |
| 888 | } else { |
| 889 | if (!asset_source->AddAssetPath(path)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 890 | context_->GetDiagnostics()->Error(android::DiagMessage() |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 891 | << "failed to load include path " << path); |
| 892 | return false; |
| 893 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 894 | } |
| 895 | } |
| 896 | |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 897 | // Capture the shared libraries so that the final resource table can be properly flattened |
| 898 | // with support for shared libraries. |
| 899 | for (auto& entry : asset_source->GetAssignedPackageIds()) { |
Todd Kennedy | 3251299 | 2018-04-25 16:45:59 -0700 | [diff] [blame] | 900 | if (entry.first == kAppPackageId) { |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 901 | // Capture the included base feature package. |
| 902 | included_feature_base_ = entry.second; |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 903 | } else if (entry.first == kFrameworkPackageId) { |
| 904 | // Try to embed which version of the framework we're compiling against. |
| 905 | // First check if we should use compileSdkVersion at all. Otherwise compilation may fail |
| 906 | // when linking our synthesized 'android:compileSdkVersion' attribute. |
| 907 | std::unique_ptr<SymbolTable::Symbol> symbol = asset_source->FindByName( |
| 908 | ResourceName("android", ResourceType::kAttr, "compileSdkVersion")); |
| 909 | if (symbol != nullptr && symbol->is_public) { |
| 910 | // The symbol is present and public, extract the android:versionName and |
| 911 | // android:versionCode from the framework AndroidManifest.xml. |
| 912 | ExtractCompileSdkVersions(asset_source->GetAssetManager()); |
| 913 | } |
Ryan Mitchell | ee4a564 | 2019-10-16 08:32:55 -0700 | [diff] [blame] | 914 | } else if (asset_source->IsPackageDynamic(entry.first, entry.second)) { |
Todd Kennedy | 3251299 | 2018-04-25 16:45:59 -0700 | [diff] [blame] | 915 | final_table_.included_packages_[entry.first] = entry.second; |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 916 | } |
| 917 | } |
| 918 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 919 | context_->GetExternalSymbols()->AppendSource(std::move(asset_source)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 920 | return true; |
| 921 | } |
| 922 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 923 | std::optional<AppInfo> ExtractAppInfoFromManifest(xml::XmlResource* xml_res, |
| 924 | android::IDiagnostics* diag) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 925 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 926 | // Make sure the first element is <manifest> with package attribute. |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 927 | xml::Element* manifest_el = xml::FindRootElement(xml_res->root.get()); |
| 928 | if (manifest_el == nullptr) { |
| 929 | return {}; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 930 | } |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 931 | |
| 932 | AppInfo app_info; |
| 933 | |
| 934 | if (!manifest_el->namespace_uri.empty() || manifest_el->name != "manifest") { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 935 | diag->Error(android::DiagMessage(xml_res->file.source) << "root tag must be <manifest>"); |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 936 | return {}; |
| 937 | } |
| 938 | |
| 939 | xml::Attribute* package_attr = manifest_el->FindAttribute({}, "package"); |
| 940 | if (!package_attr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 941 | diag->Error(android::DiagMessage(xml_res->file.source) |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 942 | << "<manifest> must have a 'package' attribute"); |
| 943 | return {}; |
| 944 | } |
| 945 | app_info.package = package_attr->value; |
| 946 | |
| 947 | if (xml::Attribute* version_code_attr = |
| 948 | manifest_el->FindAttribute(xml::kSchemaAndroid, "versionCode")) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 949 | std::optional<uint32_t> maybe_code = ResourceUtils::ParseInt(version_code_attr->value); |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 950 | if (!maybe_code) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 951 | diag->Error(android::DiagMessage(xml_res->file.source.WithLine(manifest_el->line_number)) |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 952 | << "invalid android:versionCode '" << version_code_attr->value << "'"); |
| 953 | return {}; |
| 954 | } |
| 955 | app_info.version_code = maybe_code.value(); |
| 956 | } |
| 957 | |
Ryan Mitchell | 5fa2bb1 | 2018-07-12 11:24:51 -0700 | [diff] [blame] | 958 | if (xml::Attribute* version_code_major_attr = |
| 959 | manifest_el->FindAttribute(xml::kSchemaAndroid, "versionCodeMajor")) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 960 | std::optional<uint32_t> maybe_code = ResourceUtils::ParseInt(version_code_major_attr->value); |
Ryan Mitchell | 5fa2bb1 | 2018-07-12 11:24:51 -0700 | [diff] [blame] | 961 | if (!maybe_code) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 962 | diag->Error(android::DiagMessage(xml_res->file.source.WithLine(manifest_el->line_number)) |
| 963 | << "invalid android:versionCodeMajor '" << version_code_major_attr->value |
| 964 | << "'"); |
Ryan Mitchell | 5fa2bb1 | 2018-07-12 11:24:51 -0700 | [diff] [blame] | 965 | return {}; |
| 966 | } |
| 967 | app_info.version_code_major = maybe_code.value(); |
| 968 | } |
| 969 | |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 970 | if (xml::Attribute* revision_code_attr = |
| 971 | manifest_el->FindAttribute(xml::kSchemaAndroid, "revisionCode")) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 972 | std::optional<uint32_t> maybe_code = ResourceUtils::ParseInt(revision_code_attr->value); |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 973 | if (!maybe_code) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 974 | diag->Error(android::DiagMessage(xml_res->file.source.WithLine(manifest_el->line_number)) |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 975 | << "invalid android:revisionCode '" << revision_code_attr->value << "'"); |
| 976 | return {}; |
| 977 | } |
| 978 | app_info.revision_code = maybe_code.value(); |
| 979 | } |
| 980 | |
| 981 | if (xml::Attribute* split_name_attr = manifest_el->FindAttribute({}, "split")) { |
| 982 | if (!split_name_attr->value.empty()) { |
| 983 | app_info.split_name = split_name_attr->value; |
| 984 | } |
| 985 | } |
| 986 | |
| 987 | if (xml::Element* uses_sdk_el = manifest_el->FindChild({}, "uses-sdk")) { |
| 988 | if (xml::Attribute* min_sdk = |
| 989 | uses_sdk_el->FindAttribute(xml::kSchemaAndroid, "minSdkVersion")) { |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 990 | app_info.min_sdk_version = ResourceUtils::ParseSdkVersion(min_sdk->value); |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 991 | } |
| 992 | } |
Udam Saini | b228df3 | 2019-06-18 16:50:34 -0700 | [diff] [blame] | 993 | |
| 994 | for (const xml::Element* child_el : manifest_el->GetChildElements()) { |
| 995 | if (child_el->namespace_uri.empty() && child_el->name == "uses-split") { |
| 996 | if (const xml::Attribute* split_name = |
| 997 | child_el->FindAttribute(xml::kSchemaAndroid, "name")) { |
| 998 | if (!split_name->value.empty()) { |
| 999 | app_info.split_name_dependencies.insert(split_name->value); |
| 1000 | } |
| 1001 | } |
| 1002 | } |
| 1003 | } |
Adam Lesinski | b0c47ef | 2017-03-06 20:05:57 -0800 | [diff] [blame] | 1004 | return app_info; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1005 | } |
| 1006 | |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1007 | // Precondition: ResourceTable doesn't have any IDs assigned yet, nor is it linked. |
| 1008 | // Postcondition: ResourceTable has only one package left. All others are |
| 1009 | // stripped, or there is an error and false is returned. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1010 | bool VerifyNoExternalPackages() { |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1011 | auto is_ext_package_func = [&](const std::unique_ptr<ResourceTablePackage>& pkg) -> bool { |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1012 | return context_->GetCompilationPackage() != pkg->name; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1013 | }; |
| 1014 | |
| 1015 | bool error = false; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1016 | for (const auto& package : final_table_.packages) { |
| 1017 | if (is_ext_package_func(package)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1018 | // We have a package that is not related to the one we're building! |
| 1019 | for (const auto& type : package->types) { |
| 1020 | for (const auto& entry : type->entries) { |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 1021 | ResourceNameRef res_name(package->name, type->named_type, entry->name); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1022 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1023 | for (const auto& config_value : entry->values) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1024 | // Special case the occurrence of an ID that is being generated |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1025 | // for the 'android' package. This is due to legacy reasons. |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1026 | if (ValueCast<Id>(config_value->value.get()) && package->name == "android") { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1027 | context_->GetDiagnostics()->Warn( |
| 1028 | android::DiagMessage(config_value->value->GetSource()) |
| 1029 | << "generated id '" << res_name << "' for external package '" << package->name |
| 1030 | << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1031 | } else { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1032 | context_->GetDiagnostics()->Error( |
| 1033 | android::DiagMessage(config_value->value->GetSource()) |
| 1034 | << "defined resource '" << res_name << "' for external package '" |
| 1035 | << package->name << "'"); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1036 | error = true; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1037 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 1038 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1039 | } |
| 1040 | } |
| 1041 | } |
| 1042 | } |
| 1043 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1044 | auto new_end_iter = std::remove_if(final_table_.packages.begin(), final_table_.packages.end(), |
| 1045 | is_ext_package_func); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1046 | final_table_.packages.erase(new_end_iter, final_table_.packages.end()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1047 | return !error; |
| 1048 | } |
| 1049 | |
| 1050 | /** |
| 1051 | * Returns true if no IDs have been set, false otherwise. |
| 1052 | */ |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1053 | bool VerifyNoIdsSet() { |
| 1054 | for (const auto& package : final_table_.packages) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1055 | for (const auto& type : package->types) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1056 | for (const auto& entry : type->entries) { |
| 1057 | if (entry->id) { |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 1058 | ResourceNameRef res_name(package->name, type->named_type, entry->name); |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1059 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 1060 | << "resource " << res_name << " has ID " |
| 1061 | << entry->id.value() << " assigned"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1062 | return false; |
| 1063 | } |
| 1064 | } |
| 1065 | } |
| 1066 | } |
| 1067 | return true; |
| 1068 | } |
| 1069 | |
Josh Hou | ec67cb4 | 2022-06-09 19:19:21 +0800 | [diff] [blame] | 1070 | bool VerifyLocaleFormat(xml::XmlResource* manifest, android::IDiagnostics* diag) { |
| 1071 | // Skip it if the Manifest doesn't declare the localeConfig attribute within the <application> |
| 1072 | // element. |
| 1073 | const xml::Element* application = manifest->root->FindChild("", "application"); |
| 1074 | if (!application) { |
| 1075 | return true; |
| 1076 | } |
| 1077 | const xml::Attribute* localeConfig = |
| 1078 | application->FindAttribute(xml::kSchemaAndroid, "localeConfig"); |
| 1079 | if (!localeConfig) { |
| 1080 | return true; |
| 1081 | } |
| 1082 | |
| 1083 | // Deserialize XML from the compiled file |
| 1084 | if (localeConfig->compiled_value) { |
| 1085 | const auto localeconfig_reference = ValueCast<Reference>(localeConfig->compiled_value.get()); |
| 1086 | const auto localeconfig_entry = |
| 1087 | ResolveTableEntry(context_, &final_table_, localeconfig_reference); |
| 1088 | if (!localeconfig_entry) { |
Iurii Makhno | a7ba6b6 | 2022-11-11 17:59:57 +0000 | [diff] [blame] | 1089 | // If locale config is resolved from external symbols - skip validation. |
| 1090 | if (context_->GetExternalSymbols()->FindByReference(*localeconfig_reference)) { |
| 1091 | return true; |
| 1092 | } |
Josh Hou | ec67cb4 | 2022-06-09 19:19:21 +0800 | [diff] [blame] | 1093 | context_->GetDiagnostics()->Error( |
| 1094 | android::DiagMessage(localeConfig->compiled_value->GetSource()) |
| 1095 | << "no localeConfig entry"); |
| 1096 | return false; |
| 1097 | } |
| 1098 | for (const auto& value : localeconfig_entry->values) { |
| 1099 | const FileReference* file_ref = ValueCast<FileReference>(value->value.get()); |
| 1100 | if (!file_ref) { |
| 1101 | context_->GetDiagnostics()->Error( |
| 1102 | android::DiagMessage(localeConfig->compiled_value->GetSource()) |
| 1103 | << "no file reference"); |
| 1104 | return false; |
| 1105 | } |
| 1106 | io::IFile* file = file_ref->file; |
| 1107 | if (!file) { |
| 1108 | context_->GetDiagnostics()->Error(android::DiagMessage(file_ref->GetSource()) |
| 1109 | << "file not found"); |
| 1110 | return false; |
| 1111 | } |
| 1112 | std::unique_ptr<io::IData> data = file->OpenAsData(); |
| 1113 | if (!data) { |
| 1114 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
| 1115 | << "failed to open file"); |
| 1116 | return false; |
| 1117 | } |
| 1118 | pb::XmlNode pb_xml_node; |
| 1119 | if (!pb_xml_node.ParseFromArray(data->data(), static_cast<int>(data->size()))) { |
| 1120 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
| 1121 | << "failed to parse proto XML"); |
| 1122 | return false; |
| 1123 | } |
| 1124 | |
| 1125 | std::string error; |
| 1126 | std::unique_ptr<xml::XmlResource> localeConfig_xml = |
| 1127 | DeserializeXmlResourceFromPb(pb_xml_node, &error); |
| 1128 | if (!localeConfig_xml) { |
| 1129 | context_->GetDiagnostics()->Error(android::DiagMessage(file->GetSource()) |
| 1130 | << "failed to deserialize proto XML: " << error); |
| 1131 | return false; |
| 1132 | } |
| 1133 | xml::Element* localeConfig_el = xml::FindRootElement(localeConfig_xml->root.get()); |
| 1134 | if (!localeConfig_el) { |
| 1135 | diag->Error(android::DiagMessage(file->GetSource()) << "no root tag defined"); |
| 1136 | return false; |
| 1137 | } |
| 1138 | if (localeConfig_el->name != "locale-config") { |
| 1139 | diag->Error(android::DiagMessage(file->GetSource()) |
| 1140 | << "invalid element name: " << localeConfig_el->name |
| 1141 | << ", expected: locale-config"); |
| 1142 | return false; |
| 1143 | } |
| 1144 | for (const xml::Element* child_el : localeConfig_el->GetChildElements()) { |
| 1145 | if (child_el->name == "locale") { |
| 1146 | if (const xml::Attribute* locale_name_attr = |
| 1147 | child_el->FindAttribute(xml::kSchemaAndroid, "name")) { |
| 1148 | const std::string& locale_name = locale_name_attr->value; |
| 1149 | const std::string valid_name = ConvertToBCP47Tag(locale_name); |
| 1150 | // Start to verify the locale format |
| 1151 | ConfigDescription config; |
| 1152 | if (!ConfigDescription::Parse(valid_name, &config)) { |
| 1153 | diag->Error(android::DiagMessage(file->GetSource()) |
| 1154 | << "invalid configuration: " << locale_name); |
| 1155 | return false; |
| 1156 | } |
| 1157 | } else { |
| 1158 | diag->Error(android::DiagMessage(file->GetSource()) |
| 1159 | << "the attribute android:name is not found"); |
| 1160 | return false; |
| 1161 | } |
| 1162 | } else { |
| 1163 | diag->Error(android::DiagMessage(file->GetSource()) |
| 1164 | << "invalid element name: " << child_el->name << ", expected: locale"); |
| 1165 | return false; |
| 1166 | } |
| 1167 | } |
| 1168 | } |
| 1169 | } |
| 1170 | return true; |
| 1171 | } |
| 1172 | |
| 1173 | std::string ConvertToBCP47Tag(const std::string& locale) { |
| 1174 | std::string bcp47tag = "b+"; |
| 1175 | bcp47tag += locale; |
| 1176 | std::replace(bcp47tag.begin(), bcp47tag.end(), '-', '+'); |
| 1177 | return bcp47tag; |
| 1178 | } |
| 1179 | |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 1180 | std::unique_ptr<IArchiveWriter> MakeArchiveWriter(StringPiece out) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1181 | if (options_.output_to_directory) { |
| 1182 | return CreateDirectoryArchiveWriter(context_->GetDiagnostics(), out); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1183 | } else { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1184 | return CreateZipFileArchiveWriter(context_->GetDiagnostics(), out); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1185 | } |
| 1186 | } |
| 1187 | |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1188 | bool FlattenTable(ResourceTable* table, OutputFormat format, IArchiveWriter* writer) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1189 | TRACE_CALL(); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1190 | switch (format) { |
| 1191 | case OutputFormat::kApk: { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1192 | android::BigBuffer buffer(1024); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1193 | TableFlattener flattener(options_.table_flattener_options, &buffer); |
| 1194 | if (!flattener.Consume(context_, table)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1195 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 1196 | << "failed to flatten resource table"); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1197 | return false; |
| 1198 | } |
| 1199 | |
| 1200 | io::BigBufferInputStream input_stream(&buffer); |
| 1201 | return io::CopyInputStreamToArchive(context_, &input_stream, kApkResourceTablePath, |
| 1202 | ArchiveEntry::kAlign, writer); |
| 1203 | } break; |
| 1204 | |
| 1205 | case OutputFormat::kProto: { |
| 1206 | pb::ResourceTable pb_table; |
Ryan Mitchell | ef9e688 | 2019-06-24 11:53:33 -0700 | [diff] [blame] | 1207 | SerializeTableToPb(*table, &pb_table, context_->GetDiagnostics(), |
| 1208 | options_.proto_table_flattener_options); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1209 | return io::CopyProtoToArchive(context_, &pb_table, kProtoResourceTablePath, |
| 1210 | ArchiveEntry::kCompress, writer); |
| 1211 | } break; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1212 | } |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1213 | return false; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1214 | } |
| 1215 | |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 1216 | bool WriteJavaFile(ResourceTable* table, StringPiece package_name_to_generate, |
| 1217 | StringPiece out_package, const JavaClassGeneratorOptions& java_options, |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1218 | const std::optional<std::string>& out_text_symbols_path = {}) { |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1219 | if (!options_.generate_java_class_path && !out_text_symbols_path) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1220 | return true; |
| 1221 | } |
| 1222 | |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1223 | std::string out_path; |
| 1224 | std::unique_ptr<io::FileOutputStream> fout; |
| 1225 | if (options_.generate_java_class_path) { |
| 1226 | out_path = options_.generate_java_class_path.value(); |
| 1227 | file::AppendPath(&out_path, file::PackageToPath(out_package)); |
| 1228 | if (!file::mkdirs(out_path)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1229 | context_->GetDiagnostics()->Error(android::DiagMessage() |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1230 | << "failed to create directory '" << out_path << "'"); |
| 1231 | return false; |
| 1232 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1233 | |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1234 | file::AppendPath(&out_path, "R.java"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1235 | |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1236 | fout = util::make_unique<io::FileOutputStream>(out_path); |
| 1237 | if (fout->HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1238 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 1239 | << "failed writing to '" << out_path |
| 1240 | << "': " << fout->GetError()); |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1241 | return false; |
| 1242 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1243 | } |
| 1244 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1245 | std::unique_ptr<io::FileOutputStream> fout_text; |
Adam Lesinski | 418763f | 2017-04-11 17:36:53 -0700 | [diff] [blame] | 1246 | if (out_text_symbols_path) { |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1247 | fout_text = util::make_unique<io::FileOutputStream>(out_text_symbols_path.value()); |
| 1248 | if (fout_text->HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1249 | context_->GetDiagnostics()->Error(android::DiagMessage() |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1250 | << "failed writing to '" << out_text_symbols_path.value() |
| 1251 | << "': " << fout_text->GetError()); |
Adam Lesinski | 418763f | 2017-04-11 17:36:53 -0700 | [diff] [blame] | 1252 | return false; |
| 1253 | } |
| 1254 | } |
| 1255 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1256 | JavaClassGenerator generator(context_, table, java_options); |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 1257 | if (!generator.Generate(package_name_to_generate, out_package, fout.get(), fout_text.get())) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1258 | context_->GetDiagnostics()->Error(android::DiagMessage(out_path) << generator.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1259 | return false; |
| 1260 | } |
| 1261 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1262 | return true; |
| 1263 | } |
| 1264 | |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1265 | bool GenerateJavaClasses() { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1266 | TRACE_CALL(); |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1267 | // The set of packages whose R class to call in the main classes onResourcesLoaded callback. |
| 1268 | std::vector<std::string> packages_to_callback; |
| 1269 | |
| 1270 | JavaClassGeneratorOptions template_options; |
| 1271 | template_options.types = JavaClassGeneratorOptions::SymbolTypes::kAll; |
| 1272 | template_options.javadoc_annotations = options_.javadoc_annotations; |
| 1273 | |
| 1274 | if (context_->GetPackageType() == PackageType::kStaticLib || options_.generate_non_final_ids) { |
| 1275 | template_options.use_final = false; |
| 1276 | } |
| 1277 | |
| 1278 | if (context_->GetPackageType() == PackageType::kSharedLib) { |
| 1279 | template_options.use_final = false; |
| 1280 | template_options.rewrite_callback_options = OnResourcesLoadedCallbackOptions{}; |
| 1281 | } |
| 1282 | |
| 1283 | const StringPiece actual_package = context_->GetCompilationPackage(); |
| 1284 | StringPiece output_package = context_->GetCompilationPackage(); |
| 1285 | if (options_.custom_java_package) { |
| 1286 | // Override the output java package to the custom one. |
| 1287 | output_package = options_.custom_java_package.value(); |
| 1288 | } |
| 1289 | |
| 1290 | // Generate the private symbols if required. |
| 1291 | if (options_.private_symbols) { |
| 1292 | packages_to_callback.push_back(options_.private_symbols.value()); |
| 1293 | |
| 1294 | // If we defined a private symbols package, we only emit Public symbols |
| 1295 | // to the original package, and private and public symbols to the private package. |
| 1296 | JavaClassGeneratorOptions options = template_options; |
| 1297 | options.types = JavaClassGeneratorOptions::SymbolTypes::kPublicPrivate; |
| 1298 | if (!WriteJavaFile(&final_table_, actual_package, options_.private_symbols.value(), |
| 1299 | options)) { |
| 1300 | return false; |
| 1301 | } |
| 1302 | } |
| 1303 | |
| 1304 | // Generate copies of the original package R class but with different package names. |
| 1305 | // This is to support non-namespaced builds. |
| 1306 | for (const std::string& extra_package : options_.extra_java_packages) { |
| 1307 | packages_to_callback.push_back(extra_package); |
| 1308 | |
| 1309 | JavaClassGeneratorOptions options = template_options; |
| 1310 | options.types = JavaClassGeneratorOptions::SymbolTypes::kAll; |
| 1311 | if (!WriteJavaFile(&final_table_, actual_package, extra_package, options)) { |
| 1312 | return false; |
| 1313 | } |
| 1314 | } |
| 1315 | |
| 1316 | // Generate R classes for each package that was merged (static library). |
| 1317 | // Use the actual package's resources only. |
| 1318 | for (const std::string& package : table_merger_->merged_packages()) { |
| 1319 | packages_to_callback.push_back(package); |
| 1320 | |
| 1321 | JavaClassGeneratorOptions options = template_options; |
| 1322 | options.types = JavaClassGeneratorOptions::SymbolTypes::kAll; |
| 1323 | if (!WriteJavaFile(&final_table_, package, package, options)) { |
| 1324 | return false; |
| 1325 | } |
| 1326 | } |
| 1327 | |
| 1328 | // Generate the main public R class. |
| 1329 | JavaClassGeneratorOptions options = template_options; |
| 1330 | |
| 1331 | // Only generate public symbols if we have a private package. |
| 1332 | if (options_.private_symbols) { |
| 1333 | options.types = JavaClassGeneratorOptions::SymbolTypes::kPublic; |
| 1334 | } |
| 1335 | |
| 1336 | if (options.rewrite_callback_options) { |
| 1337 | options.rewrite_callback_options.value().packages_to_callback = |
| 1338 | std::move(packages_to_callback); |
| 1339 | } |
| 1340 | |
| 1341 | if (!WriteJavaFile(&final_table_, actual_package, output_package, options, |
| 1342 | options_.generate_text_symbols_path)) { |
| 1343 | return false; |
| 1344 | } |
| 1345 | |
| 1346 | return true; |
| 1347 | } |
| 1348 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1349 | bool WriteManifestJavaFile(xml::XmlResource* manifest_xml) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1350 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1351 | if (!options_.generate_java_class_path) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1352 | return true; |
| 1353 | } |
| 1354 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1355 | std::unique_ptr<ClassDefinition> manifest_class = |
| 1356 | GenerateManifestClass(context_->GetDiagnostics(), manifest_xml); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1357 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1358 | if (!manifest_class) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1359 | // Something bad happened, but we already logged it, so exit. |
| 1360 | return false; |
| 1361 | } |
| 1362 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1363 | if (manifest_class->empty()) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1364 | // Empty Manifest class, no need to generate it. |
| 1365 | return true; |
| 1366 | } |
| 1367 | |
| 1368 | // Add any JavaDoc annotations to the generated class. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1369 | for (const std::string& annotation : options_.javadoc_annotations) { |
| 1370 | std::string proper_annotation = "@"; |
| 1371 | proper_annotation += annotation; |
| 1372 | manifest_class->GetCommentBuilder()->AppendComment(proper_annotation); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1373 | } |
| 1374 | |
Adam Lesinski | 0d81f70 | 2017-06-27 15:51:09 -0700 | [diff] [blame] | 1375 | const std::string package_utf8 = |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1376 | options_.custom_java_package.value_or(context_->GetCompilationPackage()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1377 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1378 | std::string out_path = options_.generate_java_class_path.value(); |
| 1379 | file::AppendPath(&out_path, file::PackageToPath(package_utf8)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1380 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1381 | if (!file::mkdirs(out_path)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1382 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 1383 | << "failed to create directory '" << out_path << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1384 | return false; |
| 1385 | } |
| 1386 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1387 | file::AppendPath(&out_path, "Manifest.java"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1388 | |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1389 | io::FileOutputStream fout(out_path); |
| 1390 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1391 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to open '" << out_path |
| 1392 | << "': " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1393 | return false; |
| 1394 | } |
| 1395 | |
Makoto Onuki | de6e6f2 | 2020-06-22 10:17:02 -0700 | [diff] [blame] | 1396 | ClassDefinition::WriteJavaFile(manifest_class.get(), package_utf8, true, |
| 1397 | false /* strip_api_annotations */, &fout); |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1398 | fout.Flush(); |
| 1399 | |
| 1400 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1401 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed writing to '" << out_path |
| 1402 | << "': " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1403 | return false; |
| 1404 | } |
| 1405 | return true; |
| 1406 | } |
| 1407 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1408 | bool WriteProguardFile(const std::optional<std::string>& out, const proguard::KeepSet& keep_set) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1409 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1410 | if (!out) { |
| 1411 | return true; |
| 1412 | } |
| 1413 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1414 | const std::string& out_path = out.value(); |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1415 | io::FileOutputStream fout(out_path); |
| 1416 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1417 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to open '" << out_path |
| 1418 | << "': " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1419 | return false; |
| 1420 | } |
| 1421 | |
Jean-Luc Coelho | 181cbfd | 2019-11-27 12:37:48 -0800 | [diff] [blame] | 1422 | proguard::WriteKeepSet(keep_set, &fout, options_.generate_minimal_proguard_rules, |
| 1423 | options_.no_proguard_location_reference); |
Adam Lesinski | a693c4a | 2017-11-09 11:29:39 -0800 | [diff] [blame] | 1424 | fout.Flush(); |
| 1425 | |
| 1426 | if (fout.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1427 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed writing to '" << out_path |
| 1428 | << "': " << fout.GetError()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1429 | return false; |
| 1430 | } |
| 1431 | return true; |
| 1432 | } |
| 1433 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1434 | bool MergeStaticLibrary(const std::string& input, bool override) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1435 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1436 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1437 | context_->GetDiagnostics()->Note(android::DiagMessage() |
| 1438 | << "merging static library " << input); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1439 | } |
| 1440 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 1441 | std::unique_ptr<LoadedApk> apk = LoadedApk::LoadApkFromPath(input, context_->GetDiagnostics()); |
| 1442 | if (apk == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1443 | context_->GetDiagnostics()->Error(android::DiagMessage(input) << "invalid static library"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1444 | return false; |
| 1445 | } |
| 1446 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 1447 | ResourceTable* table = apk->GetResourceTable(); |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1448 | if (table->packages.empty()) { |
| 1449 | return true; |
| 1450 | } |
| 1451 | |
| 1452 | auto lib_package_result = GetStaticLibraryPackage(table); |
| 1453 | if (!lib_package_result.has_value()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1454 | context_->GetDiagnostics()->Error(android::DiagMessage(input) << lib_package_result.error()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1455 | return false; |
| 1456 | } |
| 1457 | |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1458 | ResourceTablePackage* pkg = lib_package_result.value(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1459 | bool result; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1460 | if (options_.no_static_lib_packages) { |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1461 | // Merge all resources as if they were in the compilation package. This is the old behavior |
| 1462 | // of aapt. |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1463 | |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1464 | // Add the package to the set of --extra-packages so we emit an R.java for each library |
| 1465 | // package. |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1466 | if (!pkg->name.empty()) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1467 | options_.extra_java_packages.insert(pkg->name); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1468 | } |
| 1469 | |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 1470 | // Clear the package name, so as to make the resources look like they are coming from the |
| 1471 | // local package. |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1472 | pkg->name = ""; |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1473 | result = table_merger_->Merge(android::Source(input), table, override); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1474 | |
| 1475 | } else { |
| 1476 | // This is the proper way to merge libraries, where the package name is |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1477 | // preserved and resource names are mangled. |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1478 | result = table_merger_->MergeAndMangle(android::Source(input), pkg->name, table); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1479 | } |
| 1480 | |
| 1481 | if (!result) { |
| 1482 | return false; |
| 1483 | } |
| 1484 | |
| 1485 | // Make sure to move the collection into the set of IFileCollections. |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 1486 | merged_apks_.push_back(std::move(apk)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1487 | return true; |
| 1488 | } |
| 1489 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1490 | bool MergeExportedSymbols(const android::Source& source, |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1491 | const std::vector<SourcedResourceName>& exported_symbols) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1492 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1493 | // Add the exports of this file to the table. |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1494 | for (const SourcedResourceName& exported_symbol : exported_symbols) { |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1495 | ResourceName res_name = exported_symbol.name; |
| 1496 | if (res_name.package.empty()) { |
| 1497 | res_name.package = context_->GetCompilationPackage(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1498 | } |
| 1499 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1500 | std::optional<ResourceName> mangled_name = context_->GetNameMangler()->MangleName(res_name); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1501 | if (mangled_name) { |
| 1502 | res_name = mangled_name.value(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1503 | } |
| 1504 | |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1505 | auto id = util::make_unique<Id>(); |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1506 | id->SetSource(source.WithLine(exported_symbol.line)); |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 1507 | bool result = final_table_.AddResource( |
| 1508 | NewResourceBuilder(res_name).SetValue(std::move(id)).SetAllowMangled(true).Build(), |
| 1509 | context_->GetDiagnostics()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1510 | if (!result) { |
| 1511 | return false; |
| 1512 | } |
| 1513 | } |
| 1514 | return true; |
| 1515 | } |
| 1516 | |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1517 | bool MergeCompiledFile(const ResourceFile& compiled_file, io::IFile* file, bool override) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1518 | TRACE_CALL(); |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1519 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1520 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 1521 | << "merging '" << compiled_file.name |
| 1522 | << "' from compiled file " << compiled_file.source); |
| 1523 | } |
| 1524 | |
| 1525 | if (!table_merger_->MergeFile(compiled_file, override, file)) { |
| 1526 | return false; |
| 1527 | } |
| 1528 | return MergeExportedSymbols(compiled_file.source, compiled_file.exported_symbols); |
| 1529 | } |
| 1530 | |
Ryan Mitchell | 4ea9075 | 2020-07-31 08:21:43 -0700 | [diff] [blame] | 1531 | // Takes a path to load as a ZIP file and merges the files within into the main ResourceTable. |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1532 | // If override is true, conflicting resources are allowed to override each other, in order of last |
| 1533 | // seen. |
| 1534 | // An io::IFileCollection is created from the ZIP file and added to the set of |
| 1535 | // io::IFileCollections that are open. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1536 | bool MergeArchive(const std::string& input, bool override) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1537 | TRACE_CALL(); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1538 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1539 | context_->GetDiagnostics()->Note(android::DiagMessage() << "merging archive " << input); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1540 | } |
| 1541 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1542 | std::string error_str; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1543 | std::unique_ptr<io::ZipFileCollection> collection = |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1544 | io::ZipFileCollection::Create(input, &error_str); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1545 | if (!collection) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1546 | context_->GetDiagnostics()->Error(android::DiagMessage(input) << error_str); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1547 | return false; |
| 1548 | } |
| 1549 | |
| 1550 | bool error = false; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1551 | for (auto iter = collection->Iterator(); iter->HasNext();) { |
| 1552 | if (!MergeFile(iter->Next(), override)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1553 | error = true; |
| 1554 | } |
| 1555 | } |
| 1556 | |
| 1557 | // Make sure to move the collection into the set of IFileCollections. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1558 | collections_.push_back(std::move(collection)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1559 | return !error; |
| 1560 | } |
| 1561 | |
Ryan Mitchell | 4ea9075 | 2020-07-31 08:21:43 -0700 | [diff] [blame] | 1562 | // Takes a path to load and merge into the main ResourceTable. If override is true, |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1563 | // conflicting resources are allowed to override each other, in order of last seen. |
| 1564 | // If the file path ends with .flata, .jar, .jack, or .zip the file is treated |
| 1565 | // as ZIP archive and the files within are merged individually. |
| 1566 | // Otherwise the file is processed on its own. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1567 | bool MergePath(const std::string& path, bool override) { |
| 1568 | if (util::EndsWith(path, ".flata") || util::EndsWith(path, ".jar") || |
| 1569 | util::EndsWith(path, ".jack") || util::EndsWith(path, ".zip")) { |
| 1570 | return MergeArchive(path, override); |
| 1571 | } else if (util::EndsWith(path, ".apk")) { |
| 1572 | return MergeStaticLibrary(path, override); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1573 | } |
| 1574 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1575 | io::IFile* file = file_collection_->InsertFile(path); |
| 1576 | return MergeFile(file, override); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1577 | } |
| 1578 | |
Ryan Mitchell | 4ea9075 | 2020-07-31 08:21:43 -0700 | [diff] [blame] | 1579 | // Takes an AAPT Container file (.apc/.flat) to load and merge into the main ResourceTable. |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1580 | // If override is true, conflicting resources are allowed to override each other, in order of last |
| 1581 | // seen. |
| 1582 | // All other file types are ignored. This is because these files could be coming from a zip, |
| 1583 | // where we could have other files like classes.dex. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1584 | bool MergeFile(io::IFile* file, bool override) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1585 | TRACE_CALL(); |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1586 | const android::Source& src = file->GetSource(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1587 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1588 | if (util::EndsWith(src.path, ".xml") || util::EndsWith(src.path, ".png")) { |
Adam Lesinski | 6a396c1 | 2016-10-20 14:38:23 -0700 | [diff] [blame] | 1589 | // Since AAPT compiles these file types and appends .flat to them, seeing |
| 1590 | // their raw extensions is a sign that they weren't compiled. |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1591 | const StringPiece file_type = util::EndsWith(src.path, ".xml") ? "XML" : "PNG"; |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1592 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
| 1593 | << "uncompiled " << file_type |
| 1594 | << " file passed as argument. Must be " |
| 1595 | "compiled first into .flat file."); |
Adam Lesinski | 6a396c1 | 2016-10-20 14:38:23 -0700 | [diff] [blame] | 1596 | return false; |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1597 | } else if (!util::EndsWith(src.path, ".apc") && !util::EndsWith(src.path, ".flat")) { |
| 1598 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1599 | context_->GetDiagnostics()->Warn(android::DiagMessage(src) << "ignoring unrecognized file"); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1600 | return true; |
| 1601 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1602 | } |
| 1603 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1604 | std::unique_ptr<io::InputStream> input_stream = file->OpenInputStream(); |
| 1605 | if (input_stream == nullptr) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1606 | context_->GetDiagnostics()->Error(android::DiagMessage(src) << "failed to open file"); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1607 | return false; |
| 1608 | } |
| 1609 | |
| 1610 | if (input_stream->HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1611 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1612 | << "failed to open file: " << input_stream->GetError()); |
| 1613 | return false; |
| 1614 | } |
| 1615 | |
| 1616 | ContainerReaderEntry* entry; |
| 1617 | ContainerReader reader(input_stream.get()); |
Mohamed Heikal | 1084432 | 2018-02-07 15:17:38 -0500 | [diff] [blame] | 1618 | |
| 1619 | if (reader.HadError()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1620 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
Mohamed Heikal | 1084432 | 2018-02-07 15:17:38 -0500 | [diff] [blame] | 1621 | << "failed to read file: " << reader.GetError()); |
| 1622 | return false; |
| 1623 | } |
| 1624 | |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1625 | while ((entry = reader.Next()) != nullptr) { |
| 1626 | if (entry->Type() == ContainerEntryType::kResTable) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1627 | TRACE_NAME(std::string("Process ResTable:") + file->GetSource().path); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1628 | pb::ResourceTable pb_table; |
| 1629 | if (!entry->GetResTable(&pb_table)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1630 | context_->GetDiagnostics()->Error( |
| 1631 | android::DiagMessage(src) << "failed to read resource table: " << entry->GetError()); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1632 | return false; |
| 1633 | } |
| 1634 | |
| 1635 | ResourceTable table; |
| 1636 | std::string error; |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 1637 | if (!DeserializeTableFromPb(pb_table, nullptr /*files*/, &table, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1638 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1639 | << "failed to deserialize resource table: " << error); |
| 1640 | return false; |
| 1641 | } |
| 1642 | |
| 1643 | if (!table_merger_->Merge(src, &table, override)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1644 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
| 1645 | << "failed to merge resource table"); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1646 | return false; |
| 1647 | } |
| 1648 | } else if (entry->Type() == ContainerEntryType::kResFile) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1649 | TRACE_NAME(std::string("Process ResFile") + file->GetSource().path); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1650 | pb::internal::CompiledFile pb_compiled_file; |
| 1651 | off64_t offset; |
| 1652 | size_t len; |
| 1653 | if (!entry->GetResFileOffsets(&pb_compiled_file, &offset, &len)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1654 | context_->GetDiagnostics()->Error( |
| 1655 | android::DiagMessage(src) << "failed to get resource file: " << entry->GetError()); |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1656 | return false; |
| 1657 | } |
| 1658 | |
| 1659 | ResourceFile resource_file; |
| 1660 | std::string error; |
| 1661 | if (!DeserializeCompiledFileFromPb(pb_compiled_file, &resource_file, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1662 | context_->GetDiagnostics()->Error(android::DiagMessage(src) |
Adam Lesinski | 0045116 | 2017-10-03 07:44:08 -0700 | [diff] [blame] | 1663 | << "failed to read compiled header: " << error); |
| 1664 | return false; |
| 1665 | } |
| 1666 | |
| 1667 | if (!MergeCompiledFile(resource_file, file->CreateFileSegment(offset, len), override)) { |
| 1668 | return false; |
| 1669 | } |
| 1670 | } |
| 1671 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1672 | return true; |
| 1673 | } |
| 1674 | |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1675 | bool CopyAssetsDirsToApk(IArchiveWriter* writer) { |
| 1676 | std::map<std::string, std::unique_ptr<io::RegularFile>> merged_assets; |
| 1677 | for (const std::string& assets_dir : options_.assets_dirs) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1678 | std::optional<std::vector<std::string>> files = |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1679 | file::FindFiles(assets_dir, context_->GetDiagnostics(), nullptr); |
| 1680 | if (!files) { |
| 1681 | return false; |
| 1682 | } |
| 1683 | |
| 1684 | for (const std::string& file : files.value()) { |
| 1685 | std::string full_key = "assets/" + file; |
| 1686 | std::string full_path = assets_dir; |
| 1687 | file::AppendPath(&full_path, file); |
| 1688 | |
| 1689 | auto iter = merged_assets.find(full_key); |
| 1690 | if (iter == merged_assets.end()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1691 | merged_assets.emplace(std::move(full_key), util::make_unique<io::RegularFile>( |
| 1692 | android::Source(std::move(full_path)))); |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1693 | } else if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1694 | context_->GetDiagnostics()->Warn(android::DiagMessage(iter->second->GetSource()) |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1695 | << "asset file overrides '" << full_path << "'"); |
| 1696 | } |
| 1697 | } |
| 1698 | } |
| 1699 | |
| 1700 | for (auto& entry : merged_assets) { |
Ryan Mitchell | 81dfca0 | 2019-06-07 10:20:27 -0700 | [diff] [blame] | 1701 | uint32_t compression_flags = GetCompressionFlags(entry.first, options_); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1702 | if (!io::CopyFileToArchive(context_, entry.second.get(), entry.first, compression_flags, |
| 1703 | writer)) { |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 1704 | return false; |
| 1705 | } |
| 1706 | } |
| 1707 | return true; |
| 1708 | } |
| 1709 | |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1710 | ResourceEntry* ResolveTableEntry(LinkContext* context, ResourceTable* table, |
| 1711 | Reference* reference) { |
| 1712 | if (!reference || !reference->name) { |
| 1713 | return nullptr; |
| 1714 | } |
| 1715 | auto name_ref = ResourceNameRef(reference->name.value()); |
| 1716 | if (name_ref.package.empty()) { |
| 1717 | name_ref.package = context->GetCompilationPackage(); |
| 1718 | } |
| 1719 | const auto search_result = table->FindResource(name_ref); |
| 1720 | if (!search_result) { |
| 1721 | return nullptr; |
| 1722 | } |
| 1723 | return search_result.value().entry; |
| 1724 | } |
| 1725 | |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1726 | void AliasAdaptiveIcon(xml::XmlResource* manifest, ResourceTable* table) { |
Ryan Mitchell | 30cd9b2 | 2020-02-13 10:42:44 -0800 | [diff] [blame] | 1727 | const xml::Element* application = manifest->root->FindChild("", "application"); |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1728 | if (!application) { |
| 1729 | return; |
| 1730 | } |
| 1731 | |
Ryan Mitchell | 30cd9b2 | 2020-02-13 10:42:44 -0800 | [diff] [blame] | 1732 | const xml::Attribute* icon = application->FindAttribute(xml::kSchemaAndroid, "icon"); |
| 1733 | const xml::Attribute* round_icon = application->FindAttribute(xml::kSchemaAndroid, "roundIcon"); |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1734 | if (!icon || !round_icon) { |
| 1735 | return; |
| 1736 | } |
| 1737 | |
| 1738 | // Find the icon resource defined within the application. |
Ryan Mitchell | 30cd9b2 | 2020-02-13 10:42:44 -0800 | [diff] [blame] | 1739 | const auto icon_reference = ValueCast<Reference>(icon->compiled_value.get()); |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1740 | const auto icon_entry = ResolveTableEntry(context_, table, icon_reference); |
| 1741 | if (!icon_entry) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1742 | return; |
| 1743 | } |
| 1744 | |
| 1745 | int icon_max_sdk = 0; |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1746 | for (auto& config_value : icon_entry->values) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1747 | icon_max_sdk = (icon_max_sdk < config_value->config.sdkVersion) |
| 1748 | ? config_value->config.sdkVersion : icon_max_sdk; |
| 1749 | } |
| 1750 | if (icon_max_sdk < SDK_O) { |
| 1751 | // Adaptive icons must be versioned with v26 qualifiers, so this is not an adaptive icon. |
| 1752 | return; |
| 1753 | } |
| 1754 | |
| 1755 | // Find the roundIcon resource defined within the application. |
Ryan Mitchell | 30cd9b2 | 2020-02-13 10:42:44 -0800 | [diff] [blame] | 1756 | const auto round_icon_reference = ValueCast<Reference>(round_icon->compiled_value.get()); |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1757 | const auto round_icon_entry = ResolveTableEntry(context_, table, round_icon_reference); |
| 1758 | if (!round_icon_entry) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1759 | return; |
| 1760 | } |
| 1761 | |
| 1762 | int round_icon_max_sdk = 0; |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1763 | for (auto& config_value : round_icon_entry->values) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1764 | round_icon_max_sdk = (round_icon_max_sdk < config_value->config.sdkVersion) |
| 1765 | ? config_value->config.sdkVersion : round_icon_max_sdk; |
| 1766 | } |
| 1767 | if (round_icon_max_sdk >= SDK_O) { |
| 1768 | // The developer explicitly used a v26 compatible drawable as the roundIcon, meaning we should |
| 1769 | // not generate an alias to the icon drawable. |
| 1770 | return; |
| 1771 | } |
| 1772 | |
| 1773 | // Add an equivalent v26 entry to the roundIcon for each v26 variant of the regular icon. |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1774 | for (auto& config_value : icon_entry->values) { |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1775 | if (config_value->config.sdkVersion < SDK_O) { |
| 1776 | continue; |
| 1777 | } |
| 1778 | |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1779 | context_->GetDiagnostics()->Note(android::DiagMessage() |
| 1780 | << "generating " << round_icon_reference->name.value() |
| 1781 | << " with config \"" << config_value->config |
| 1782 | << "\" for round icon compatibility"); |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1783 | |
Ryan Mitchell | efcdb95 | 2021-04-14 17:31:37 -0700 | [diff] [blame] | 1784 | CloningValueTransformer cloner(&table->string_pool); |
| 1785 | auto value = icon_reference->Transform(cloner); |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1786 | auto round_config_value = |
| 1787 | round_icon_entry->FindOrCreateValue(config_value->config, config_value->product); |
Ryan Mitchell | efcdb95 | 2021-04-14 17:31:37 -0700 | [diff] [blame] | 1788 | round_config_value->value = std::move(value); |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1789 | } |
| 1790 | } |
| 1791 | |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1792 | bool VerifySharedUserId(xml::XmlResource* manifest, ResourceTable* table) { |
| 1793 | const xml::Element* manifest_el = xml::FindRootElement(manifest->root.get()); |
| 1794 | if (manifest_el == nullptr) { |
| 1795 | return true; |
| 1796 | } |
| 1797 | if (!manifest_el->namespace_uri.empty() || manifest_el->name != "manifest") { |
| 1798 | return true; |
| 1799 | } |
| 1800 | const xml::Attribute* attr = manifest_el->FindAttribute(xml::kSchemaAndroid, "sharedUserId"); |
| 1801 | if (!attr) { |
| 1802 | return true; |
| 1803 | } |
| 1804 | const auto validate = [&](const std::string& shared_user_id) -> bool { |
| 1805 | if (util::IsAndroidSharedUserId(context_->GetCompilationPackage(), shared_user_id)) { |
| 1806 | return true; |
| 1807 | } |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1808 | android::DiagMessage error_msg(manifest_el->line_number); |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1809 | error_msg << "attribute 'sharedUserId' in <manifest> tag is not a valid shared user id: '" |
| 1810 | << shared_user_id << "'"; |
| 1811 | if (options_.manifest_fixer_options.warn_validation) { |
| 1812 | // Treat the error only as a warning. |
| 1813 | context_->GetDiagnostics()->Warn(error_msg); |
| 1814 | return true; |
| 1815 | } |
| 1816 | context_->GetDiagnostics()->Error(error_msg); |
| 1817 | return false; |
| 1818 | }; |
| 1819 | // If attr->compiled_value is not null, check if it is a ref |
| 1820 | if (attr->compiled_value) { |
| 1821 | const auto ref = ValueCast<Reference>(attr->compiled_value.get()); |
| 1822 | if (ref == nullptr) { |
| 1823 | return true; |
| 1824 | } |
| 1825 | const auto shared_user_id_entry = ResolveTableEntry(context_, table, ref); |
| 1826 | if (!shared_user_id_entry) { |
| 1827 | return true; |
| 1828 | } |
| 1829 | for (const auto& value : shared_user_id_entry->values) { |
| 1830 | const auto str_value = ValueCast<String>(value->value.get()); |
| 1831 | if (str_value != nullptr && !validate(*str_value->value)) { |
| 1832 | return false; |
| 1833 | } |
| 1834 | } |
| 1835 | return true; |
| 1836 | } |
| 1837 | |
| 1838 | // Fallback to checking the raw value |
| 1839 | return validate(attr->value); |
| 1840 | } |
| 1841 | |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1842 | // Writes the AndroidManifest, ResourceTable, and all XML files referenced by the ResourceTable |
| 1843 | // to the IArchiveWriter. |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1844 | bool WriteApk(IArchiveWriter* writer, proguard::KeepSet* keep_set, xml::XmlResource* manifest, |
| 1845 | ResourceTable* table) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1846 | TRACE_CALL(); |
Ryan Mitchell | 479fa39 | 2019-01-02 17:15:39 -0800 | [diff] [blame] | 1847 | const bool keep_raw_values = (context_->GetPackageType() == PackageType::kStaticLib) |
| 1848 | || options_.keep_raw_values; |
Ryan Mitchell | 467b689 | 2018-11-09 15:52:07 -0800 | [diff] [blame] | 1849 | bool result = FlattenXml(context_, *manifest, kAndroidManifestPath, keep_raw_values, |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1850 | true /*utf16*/, options_.output_format, writer); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1851 | if (!result) { |
| 1852 | return false; |
| 1853 | } |
| 1854 | |
Ryan Mitchell | dba6456 | 2019-06-07 17:07:37 -0700 | [diff] [blame] | 1855 | // When a developer specifies an adaptive application icon, and a non-adaptive round application |
| 1856 | // icon, create an alias from the round icon to the regular icon for v26 APIs and up. We do this |
| 1857 | // because certain devices prefer android:roundIcon over android:icon regardless of the API |
| 1858 | // levels of the drawables set for either. This auto-aliasing behaviour allows an app to prefer |
| 1859 | // the android:roundIcon on API 25 devices, and prefer the adaptive icon on API 26 devices. |
| 1860 | // See (b/34829129) |
| 1861 | AliasAdaptiveIcon(manifest, table); |
| 1862 | |
Rhed Jao | 2c43442 | 2020-11-12 10:48:03 +0800 | [diff] [blame] | 1863 | // Verify the shared user id here to handle the case of reference value. |
| 1864 | if (!VerifySharedUserId(manifest, table)) { |
| 1865 | return false; |
| 1866 | } |
| 1867 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1868 | ResourceFileFlattenerOptions file_flattener_options; |
| 1869 | file_flattener_options.keep_raw_values = keep_raw_values; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1870 | file_flattener_options.do_not_compress_anything = options_.do_not_compress_anything; |
| 1871 | file_flattener_options.extensions_to_not_compress = options_.extensions_to_not_compress; |
Izabela Orlowska | 0faba5f | 2018-06-01 12:06:31 +0100 | [diff] [blame] | 1872 | file_flattener_options.regex_to_not_compress = options_.regex_to_not_compress; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1873 | file_flattener_options.no_auto_version = options_.no_auto_version; |
| 1874 | file_flattener_options.no_version_vectors = options_.no_version_vectors; |
Yuichi Araki | 4d35cca | 2017-01-18 20:42:17 +0900 | [diff] [blame] | 1875 | file_flattener_options.no_version_transitions = options_.no_version_transitions; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1876 | file_flattener_options.no_xml_namespaces = options_.no_xml_namespaces; |
| 1877 | file_flattener_options.update_proguard_spec = |
| 1878 | static_cast<bool>(options_.generate_proguard_rules_path); |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 1879 | file_flattener_options.output_format = options_.output_format; |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 1880 | file_flattener_options.do_not_fail_on_missing_resources = options_.merge_only; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1881 | |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 1882 | ResourceFileFlattener file_flattener(file_flattener_options, context_, keep_set); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1883 | if (!file_flattener.Flatten(table, writer)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1884 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed linking file resources"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1885 | return false; |
| 1886 | } |
| 1887 | |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1888 | // Hack to fix b/68820737. |
| 1889 | // We need to modify the ResourceTable's package name, but that should NOT affect |
| 1890 | // anything else being generated, which includes the Java classes. |
| 1891 | // If required, the package name is modifed before flattening, and then modified back |
| 1892 | // to its original name. |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1893 | ResourceTablePackage* package_to_rewrite = nullptr; |
Todd Kennedy | 3251299 | 2018-04-25 16:45:59 -0700 | [diff] [blame] | 1894 | // Pre-O, the platform treats negative resource IDs [those with a package ID of 0x80 |
| 1895 | // or higher] as invalid. In order to work around this limitation, we allow the use |
| 1896 | // of traditionally reserved resource IDs [those between 0x02 and 0x7E]. Allow the |
| 1897 | // definition of what a valid "split" package ID is to account for this. |
| 1898 | const bool isSplitPackage = (options_.allow_reserved_package_id && |
| 1899 | context_->GetPackageId() != kAppPackageId && |
| 1900 | context_->GetPackageId() != kFrameworkPackageId) |
| 1901 | || (!options_.allow_reserved_package_id && context_->GetPackageId() > kAppPackageId); |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1902 | if (isSplitPackage && included_feature_base_ == context_->GetCompilationPackage()) { |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1903 | // The base APK is included, and this is a feature split. If the base package is |
| 1904 | // the same as this package, then we are building an old style Android Instant Apps feature |
| 1905 | // split and must apply this workaround to avoid requiring namespaces support. |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1906 | if (!table->packages.empty() && |
| 1907 | table->packages.back()->name == context_->GetCompilationPackage()) { |
| 1908 | package_to_rewrite = table->packages.back().get(); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1909 | std::string new_package_name = |
| 1910 | StringPrintf("%s.%s", package_to_rewrite->name.c_str(), |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1911 | app_info_.split_name.value_or("feature").c_str()); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1912 | |
| 1913 | if (context_->IsVerbose()) { |
| 1914 | context_->GetDiagnostics()->Note( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1915 | android::DiagMessage() << "rewriting resource package name for feature split to '" |
| 1916 | << new_package_name << "'"); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1917 | } |
| 1918 | package_to_rewrite->name = new_package_name; |
| 1919 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1920 | } |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1921 | |
| 1922 | bool success = FlattenTable(table, options_.output_format, writer); |
| 1923 | |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1924 | if (package_to_rewrite != nullptr) { |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1925 | // Change the name back. |
| 1926 | package_to_rewrite->name = context_->GetCompilationPackage(); |
Ryan Mitchell | 87d30dd | 2021-03-30 08:22:39 -0700 | [diff] [blame] | 1927 | |
| 1928 | // TableFlattener creates an `included_packages_` mapping entry for each package with a |
| 1929 | // non-standard package id (not 0x01 or 0x7f). Since this is a feature split and not a shared |
| 1930 | // library, do not include a mapping from the feature package name to the feature package id |
| 1931 | // in the feature's dynamic reference table. |
| 1932 | table->included_packages_.erase(context_->GetPackageId()); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1933 | } |
| 1934 | |
| 1935 | if (!success) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1936 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to write resource table"); |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1937 | } |
| 1938 | return success; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1939 | } |
| 1940 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1941 | int Run(const std::vector<std::string>& input_files) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 1942 | TRACE_CALL(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1943 | // Load the AndroidManifest.xml |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1944 | std::unique_ptr<xml::XmlResource> manifest_xml = |
| 1945 | LoadXml(options_.manifest_path, context_->GetDiagnostics()); |
| 1946 | if (!manifest_xml) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1947 | return 1; |
| 1948 | } |
| 1949 | |
Ryan Mitchell | 2b7e847 | 2020-05-06 11:26:48 -0700 | [diff] [blame] | 1950 | // First extract the Package name without modifying it (via --rename-manifest-package). |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1951 | if (std::optional<AppInfo> maybe_app_info = |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1952 | ExtractAppInfoFromManifest(manifest_xml.get(), context_->GetDiagnostics())) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1953 | const AppInfo& app_info = maybe_app_info.value(); |
| 1954 | context_->SetCompilationPackage(app_info.package); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1955 | } |
| 1956 | |
Ryan Mitchell | 2b7e847 | 2020-05-06 11:26:48 -0700 | [diff] [blame] | 1957 | // Determine the package name under which to merge resources. |
| 1958 | if (options_.rename_resources_package) { |
| 1959 | if (!options_.custom_java_package) { |
| 1960 | // Generate the R.java under the original package name instead of the package name specified |
| 1961 | // through --rename-resources-package. |
| 1962 | options_.custom_java_package = context_->GetCompilationPackage(); |
| 1963 | } |
| 1964 | context_->SetCompilationPackage(options_.rename_resources_package.value()); |
| 1965 | } |
| 1966 | |
Adam Lesinski | c628437 | 2017-12-04 13:46:23 -0800 | [diff] [blame] | 1967 | // Now that the compilation package is set, load the dependencies. This will also extract |
| 1968 | // the Android framework's versionCode and versionName, if they exist. |
| 1969 | if (!LoadSymbolsFromIncludePaths()) { |
| 1970 | return 1; |
| 1971 | } |
| 1972 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1973 | ManifestFixer manifest_fixer(options_.manifest_fixer_options); |
| 1974 | if (!manifest_fixer.Consume(context_, manifest_xml.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1975 | return 1; |
| 1976 | } |
| 1977 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1978 | std::optional<AppInfo> maybe_app_info = |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1979 | ExtractAppInfoFromManifest(manifest_xml.get(), context_->GetDiagnostics()); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 1980 | if (!maybe_app_info) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1981 | return 1; |
| 1982 | } |
| 1983 | |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 1984 | app_info_ = maybe_app_info.value(); |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 1985 | context_->SetMinSdkVersion(app_info_.min_sdk_version.value_or(0)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 1986 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 1987 | context_->SetNameManglerPolicy(NameManglerPolicy{context_->GetCompilationPackage()}); |
Udam Saini | b228df3 | 2019-06-18 16:50:34 -0700 | [diff] [blame] | 1988 | context_->SetSplitNameDependencies(app_info_.split_name_dependencies); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 1989 | |
| 1990 | // Override the package ID when it is "android". |
| 1991 | if (context_->GetCompilationPackage() == "android") { |
Ryan Mitchell | 22dc531 | 2020-06-01 12:17:07 -0700 | [diff] [blame] | 1992 | context_->SetPackageId(kAndroidPackageId); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 1993 | |
| 1994 | // Verify we're building a regular app. |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 1995 | if (context_->GetPackageType() != PackageType::kApp) { |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 1996 | context_->GetDiagnostics()->Error( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 1997 | android::DiagMessage() << "package 'android' can only be built as a regular app"); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 1998 | return 1; |
| 1999 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2000 | } |
| 2001 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2002 | TableMergerOptions table_merger_options; |
| 2003 | table_merger_options.auto_add_overlay = options_.auto_add_overlay; |
Donald Chai | 121c6e8 | 2019-06-12 12:51:57 -0700 | [diff] [blame] | 2004 | table_merger_options.override_styles_instead_of_overlaying = |
| 2005 | options_.override_styles_instead_of_overlaying; |
Izabela Orlowska | d51efe8 | 2018-04-24 18:18:29 +0100 | [diff] [blame] | 2006 | table_merger_options.strict_visibility = options_.strict_visibility; |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2007 | table_merger_ = util::make_unique<TableMerger>(context_, &final_table_, table_merger_options); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2008 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2009 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2010 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2011 | << StringPrintf("linking package '%s' using package ID %02x", |
| 2012 | context_->GetCompilationPackage().data(), |
| 2013 | context_->GetPackageId())); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2014 | } |
| 2015 | |
Adam Lesinski | 2427dce | 2017-11-30 15:10:28 -0800 | [diff] [blame] | 2016 | // Extract symbols from AndroidManifest.xml, since this isn't merged like the other XML files |
| 2017 | // in res/**/*. |
| 2018 | { |
| 2019 | XmlIdCollector collector; |
| 2020 | if (!collector.Consume(context_, manifest_xml.get())) { |
| 2021 | return false; |
| 2022 | } |
| 2023 | |
| 2024 | if (!MergeExportedSymbols(manifest_xml->file.source, manifest_xml->file.exported_symbols)) { |
| 2025 | return false; |
| 2026 | } |
| 2027 | } |
| 2028 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2029 | for (const std::string& input : input_files) { |
| 2030 | if (!MergePath(input, false)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2031 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed parsing input"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2032 | return 1; |
| 2033 | } |
| 2034 | } |
| 2035 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2036 | for (const std::string& input : options_.overlay_files) { |
| 2037 | if (!MergePath(input, true)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2038 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed parsing overlays"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2039 | return 1; |
| 2040 | } |
| 2041 | } |
| 2042 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2043 | if (!VerifyNoExternalPackages()) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2044 | return 1; |
| 2045 | } |
| 2046 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2047 | if (context_->GetPackageType() != PackageType::kStaticLib) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2048 | PrivateAttributeMover mover; |
Ryan Mitchell | 22dc531 | 2020-06-01 12:17:07 -0700 | [diff] [blame] | 2049 | if (context_->GetPackageId() == kAndroidPackageId && |
| 2050 | !mover.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2051 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 2052 | << "failed moving private attributes"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2053 | return 1; |
| 2054 | } |
| 2055 | |
| 2056 | // Assign IDs if we are building a regular app. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2057 | IdAssigner id_assigner(&options_.stable_id_map); |
| 2058 | if (!id_assigner.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2059 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed assigning IDs"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2060 | return 1; |
| 2061 | } |
| 2062 | |
| 2063 | // Now grab each ID and emit it as a file. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2064 | if (options_.resource_id_map_path) { |
| 2065 | for (auto& package : final_table_.packages) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2066 | for (auto& type : package->types) { |
| 2067 | for (auto& entry : type->entries) { |
Iurii Makhno | f0c5ff4 | 2022-02-22 13:31:02 +0000 | [diff] [blame] | 2068 | ResourceName name(package->name, type->named_type, entry->name); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2069 | // The IDs are guaranteed to exist. |
Ryan Mitchell | 9634efb | 2021-03-19 14:53:17 -0700 | [diff] [blame] | 2070 | options_.stable_id_map[std::move(name)] = entry->id.value(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2071 | } |
| 2072 | } |
| 2073 | } |
| 2074 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2075 | if (!WriteStableIdMapToPath(context_->GetDiagnostics(), options_.stable_id_map, |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2076 | options_.resource_id_map_path.value())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2077 | return 1; |
| 2078 | } |
| 2079 | } |
| 2080 | } else { |
| 2081 | // Static libs are merged with other apps, and ID collisions are bad, so |
| 2082 | // verify that |
| 2083 | // no IDs have been set. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2084 | if (!VerifyNoIdsSet()) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2085 | return 1; |
| 2086 | } |
| 2087 | } |
| 2088 | |
| 2089 | // Add the names to mangle based on our source merge earlier. |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2090 | context_->SetNameManglerPolicy( |
| 2091 | NameManglerPolicy{context_->GetCompilationPackage(), table_merger_->merged_packages()}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2092 | |
| 2093 | // Add our table to the symbol table. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2094 | context_->GetExternalSymbols()->PrependSource( |
| 2095 | util::make_unique<ResourceTableSymbolSource>(&final_table_)); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2096 | |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 2097 | // Workaround for pre-O runtime that would treat negative resource IDs |
| 2098 | // (any ID with a package ID > 7f) as invalid. Intercept any ID (PPTTEEEE) with PP > 0x7f |
| 2099 | // and type == 'id', and return the ID 0x7fPPEEEE. IDs don't need to be real resources, they |
| 2100 | // are just identifiers. |
| 2101 | if (context_->GetMinSdkVersion() < SDK_O && context_->GetPackageType() == PackageType::kApp) { |
| 2102 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2103 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | 1e4b0e5 | 2017-04-27 15:01:10 -0700 | [diff] [blame] | 2104 | << "enabling pre-O feature split ID rewriting"); |
| 2105 | } |
| 2106 | context_->GetExternalSymbols()->SetDelegate( |
| 2107 | util::make_unique<FeatureSplitSymbolTableDelegate>(context_)); |
| 2108 | } |
| 2109 | |
Adam Lesinski | 34a1687 | 2018-02-23 16:18:10 -0800 | [diff] [blame] | 2110 | // Before we process anything, remove the resources whose default values don't exist. |
| 2111 | // We want to force any references to these to fail the build. |
MÃ¥rten Kongstad | d8d2901 | 2018-06-11 14:13:37 +0200 | [diff] [blame] | 2112 | if (!options_.no_resource_removal) { |
| 2113 | if (!NoDefaultResourceRemover{}.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2114 | context_->GetDiagnostics()->Error(android::DiagMessage() |
MÃ¥rten Kongstad | d8d2901 | 2018-06-11 14:13:37 +0200 | [diff] [blame] | 2115 | << "failed removing resources with no defaults"); |
| 2116 | return 1; |
| 2117 | } |
Adam Lesinski | 34a1687 | 2018-02-23 16:18:10 -0800 | [diff] [blame] | 2118 | } |
| 2119 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2120 | ReferenceLinker linker; |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 2121 | if (!options_.merge_only && !linker.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2122 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed linking references"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2123 | return 1; |
| 2124 | } |
| 2125 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2126 | if (context_->GetPackageType() == PackageType::kStaticLib) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2127 | if (!options_.products.empty()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2128 | context_->GetDiagnostics()->Warn(android::DiagMessage() |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 2129 | << "can't select products when building static library"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2130 | } |
| 2131 | } else { |
Inseob Kim | 5fe521e | 2023-09-15 16:38:50 +0900 | [diff] [blame] | 2132 | ProductFilter product_filter(options_.products, /* remove_default_config_values = */ false); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2133 | if (!product_filter.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2134 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed stripping products"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2135 | return 1; |
| 2136 | } |
| 2137 | } |
| 2138 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2139 | if (!options_.no_auto_version) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2140 | AutoVersioner versioner; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2141 | if (!versioner.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2142 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed versioning styles"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2143 | return 1; |
| 2144 | } |
| 2145 | } |
| 2146 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2147 | if (context_->GetPackageType() != PackageType::kStaticLib && context_->GetMinSdkVersion() > 0) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2148 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2149 | context_->GetDiagnostics()->Note(android::DiagMessage() |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2150 | << "collapsing resource versions for minimum SDK " |
| 2151 | << context_->GetMinSdkVersion()); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2152 | } |
| 2153 | |
| 2154 | VersionCollapser collapser; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2155 | if (!collapser.Consume(context_, &final_table_)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2156 | return 1; |
| 2157 | } |
| 2158 | } |
| 2159 | |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 2160 | if (!options_.exclude_configs_.empty()) { |
| 2161 | std::vector<ConfigDescription> excluded_configs; |
| 2162 | |
| 2163 | for (auto& config_string : options_.exclude_configs_) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 2164 | TRACE_NAME("ConfigDescription::Parse"); |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 2165 | ConfigDescription config_description; |
| 2166 | |
| 2167 | if (!ConfigDescription::Parse(config_string, &config_description)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2168 | context_->GetDiagnostics()->Error( |
| 2169 | android::DiagMessage() << "failed to parse --excluded-configs " << config_string); |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 2170 | return 1; |
| 2171 | } |
| 2172 | |
| 2173 | excluded_configs.push_back(config_description); |
| 2174 | } |
| 2175 | |
| 2176 | ResourceExcluder excluder(excluded_configs); |
| 2177 | if (!excluder.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2178 | context_->GetDiagnostics()->Error(android::DiagMessage() |
| 2179 | << "failed excluding configurations"); |
Winson | 3c918b8 | 2019-01-25 14:25:37 -0800 | [diff] [blame] | 2180 | return 1; |
| 2181 | } |
| 2182 | } |
| 2183 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2184 | if (!options_.no_resource_deduping) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2185 | ResourceDeduper deduper; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2186 | if (!deduper.Consume(context_, &final_table_)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2187 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed deduping resources"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2188 | return 1; |
| 2189 | } |
| 2190 | } |
| 2191 | |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 2192 | proguard::KeepSet proguard_keep_set = |
| 2193 | proguard::KeepSet(options_.generate_conditional_proguard_rules); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2194 | proguard::KeepSet proguard_main_dex_keep_set; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2195 | |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2196 | if (context_->GetPackageType() == PackageType::kStaticLib) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2197 | if (options_.table_splitter_options.config_filter != nullptr || |
Pierre Lecesne | 672384b | 2017-02-06 10:29:02 +0000 | [diff] [blame] | 2198 | !options_.table_splitter_options.preferred_densities.empty()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2199 | context_->GetDiagnostics()->Warn(android::DiagMessage() |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 2200 | << "can't strip resources when building static library"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2201 | } |
| 2202 | } else { |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2203 | // Adjust the SplitConstraints so that their SDK version is stripped if it is less than or |
| 2204 | // equal to the minSdk. |
Todd Kennedy | 9fbdf89 | 2018-08-28 16:31:15 -0700 | [diff] [blame] | 2205 | const size_t origConstraintSize = options_.split_constraints.size(); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2206 | options_.split_constraints = |
| 2207 | AdjustSplitConstraintsForMinSdk(context_->GetMinSdkVersion(), options_.split_constraints); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2208 | |
Todd Kennedy | 9fbdf89 | 2018-08-28 16:31:15 -0700 | [diff] [blame] | 2209 | if (origConstraintSize != options_.split_constraints.size()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2210 | context_->GetDiagnostics()->Warn(android::DiagMessage() |
Todd Kennedy | 9fbdf89 | 2018-08-28 16:31:15 -0700 | [diff] [blame] | 2211 | << "requested to split resources prior to min sdk of " |
| 2212 | << context_->GetMinSdkVersion()); |
| 2213 | } |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2214 | TableSplitter table_splitter(options_.split_constraints, options_.table_splitter_options); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2215 | if (!table_splitter.VerifySplitConstraints(context_)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2216 | return 1; |
| 2217 | } |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2218 | table_splitter.SplitTable(&final_table_); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2219 | |
| 2220 | // Now we need to write out the Split APKs. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2221 | auto path_iter = options_.split_paths.begin(); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2222 | auto split_constraints_iter = options_.split_constraints.begin(); |
| 2223 | for (std::unique_ptr<ResourceTable>& split_table : table_splitter.splits()) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2224 | if (context_->IsVerbose()) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2225 | context_->GetDiagnostics()->Note(android::DiagMessage(*path_iter) |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2226 | << "generating split with configurations '" |
| 2227 | << util::Joiner(split_constraints_iter->configs, ", ") |
| 2228 | << "'"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2229 | } |
| 2230 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2231 | std::unique_ptr<IArchiveWriter> archive_writer = MakeArchiveWriter(*path_iter); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2232 | if (!archive_writer) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2233 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to create archive"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2234 | return 1; |
| 2235 | } |
| 2236 | |
| 2237 | // Generate an AndroidManifest.xml for each split. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2238 | std::unique_ptr<xml::XmlResource> split_manifest = |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 2239 | GenerateSplitManifest(app_info_, *split_constraints_iter); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2240 | |
Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 2241 | XmlReferenceLinker linker(&final_table_); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2242 | if (!linker.Consume(context_, split_manifest.get())) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2243 | context_->GetDiagnostics()->Error(android::DiagMessage() |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2244 | << "failed to create Split AndroidManifest.xml"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2245 | return 1; |
| 2246 | } |
| 2247 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2248 | if (!WriteApk(archive_writer.get(), &proguard_keep_set, split_manifest.get(), |
| 2249 | split_table.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2250 | return 1; |
| 2251 | } |
| 2252 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2253 | ++path_iter; |
| 2254 | ++split_constraints_iter; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2255 | } |
| 2256 | } |
| 2257 | |
| 2258 | // Start writing the base APK. |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 2259 | std::unique_ptr<IArchiveWriter> archive_writer = MakeArchiveWriter(options_.output_path); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2260 | if (!archive_writer) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2261 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed to create archive"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2262 | return 1; |
| 2263 | } |
| 2264 | |
| 2265 | bool error = false; |
| 2266 | { |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 2267 | // AndroidManifest.xml has no resource name, but the CallSite is built from the name |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2268 | // (aka, which package the AndroidManifest.xml is coming from). |
| 2269 | // So we give it a package name so it can see local resources. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2270 | manifest_xml->file.name.package = context_->GetCompilationPackage(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2271 | |
Ryan Mitchell | 326e35ff | 2021-04-12 07:50:42 -0700 | [diff] [blame] | 2272 | XmlReferenceLinker manifest_linker(&final_table_); |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 2273 | if (options_.merge_only || manifest_linker.Consume(context_, manifest_xml.get())) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2274 | if (options_.generate_proguard_rules_path && |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 2275 | !proguard::CollectProguardRulesForManifest(manifest_xml.get(), &proguard_keep_set)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2276 | error = true; |
| 2277 | } |
| 2278 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2279 | if (options_.generate_main_dex_proguard_rules_path && |
Adam Koski | dc21dea | 2017-07-21 10:55:27 -0700 | [diff] [blame] | 2280 | !proguard::CollectProguardRulesForManifest(manifest_xml.get(), |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 2281 | &proguard_main_dex_keep_set, true)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2282 | error = true; |
Alexandria Cornwall | 637b482 | 2016-08-11 09:53:16 -0700 | [diff] [blame] | 2283 | } |
| 2284 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2285 | if (options_.generate_java_class_path) { |
| 2286 | if (!WriteManifestJavaFile(manifest_xml.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2287 | error = true; |
| 2288 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2289 | } |
| 2290 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2291 | if (options_.no_xml_namespaces) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2292 | // PackageParser will fail if URIs are removed from |
| 2293 | // AndroidManifest.xml. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2294 | XmlNamespaceRemover namespace_remover(true /* keepUris */); |
| 2295 | if (!namespace_remover.Consume(context_, manifest_xml.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2296 | error = true; |
| 2297 | } |
Rohit Agrawal | e49bb30 | 2016-04-22 12:27:55 -0700 | [diff] [blame] | 2298 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2299 | } else { |
| 2300 | error = true; |
| 2301 | } |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2302 | } |
Adam Lesinski | fb48d29 | 2015-11-07 15:52:13 -0800 | [diff] [blame] | 2303 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2304 | if (error) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2305 | context_->GetDiagnostics()->Error(android::DiagMessage() << "failed processing manifest"); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2306 | return 1; |
| 2307 | } |
Adam Lesinski | a6fe345 | 2015-12-09 15:20:52 -0800 | [diff] [blame] | 2308 | |
Josh Hou | ec67cb4 | 2022-06-09 19:19:21 +0800 | [diff] [blame] | 2309 | if (!VerifyLocaleFormat(manifest_xml.get(), context_->GetDiagnostics())) { |
| 2310 | return 1; |
| 2311 | }; |
| 2312 | |
Adam Lesinski | b39ad7c | 2017-03-13 11:40:48 -0700 | [diff] [blame] | 2313 | if (!WriteApk(archive_writer.get(), &proguard_keep_set, manifest_xml.get(), &final_table_)) { |
| 2314 | return 1; |
| 2315 | } |
| 2316 | |
| 2317 | if (!CopyAssetsDirsToApk(archive_writer.get())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2318 | return 1; |
| 2319 | } |
Adam Lesinski | fb48d29 | 2015-11-07 15:52:13 -0800 | [diff] [blame] | 2320 | |
Izabela Orlowska | 23a6e1e | 2017-12-05 14:52:07 +0000 | [diff] [blame] | 2321 | if (options_.generate_java_class_path || options_.generate_text_symbols_path) { |
Adam Lesinski | 1ef0fa9 | 2017-08-15 21:32:49 -0700 | [diff] [blame] | 2322 | if (!GenerateJavaClasses()) { |
Adam Lesinski | b5dc4bd | 2017-02-22 19:29:29 -0800 | [diff] [blame] | 2323 | return 1; |
| 2324 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2325 | } |
| 2326 | |
Adam Lesinski | b5dc4bd | 2017-02-22 19:29:29 -0800 | [diff] [blame] | 2327 | if (!WriteProguardFile(options_.generate_proguard_rules_path, proguard_keep_set)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2328 | return 1; |
| 2329 | } |
| 2330 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2331 | if (!WriteProguardFile(options_.generate_main_dex_proguard_rules_path, |
| 2332 | proguard_main_dex_keep_set)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2333 | return 1; |
| 2334 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2335 | return 0; |
| 2336 | } |
| 2337 | |
| 2338 | private: |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2339 | LinkOptions options_; |
| 2340 | LinkContext* context_; |
| 2341 | ResourceTable final_table_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2342 | |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 2343 | AppInfo app_info_; |
| 2344 | |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2345 | std::unique_ptr<TableMerger> table_merger_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2346 | |
| 2347 | // A pointer to the FileCollection representing the filesystem (not archives). |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2348 | std::unique_ptr<io::FileCollection> file_collection_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2349 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 2350 | // A vector of IFileCollections. This is mainly here to retain ownership of the |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2351 | // collections. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2352 | std::vector<std::unique_ptr<io::IFileCollection>> collections_; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2353 | |
Adam Lesinski | 8780eb6 | 2017-10-31 17:44:39 -0700 | [diff] [blame] | 2354 | // The set of merged APKs. This is mainly here to retain ownership of the APKs. |
| 2355 | std::vector<std::unique_ptr<LoadedApk>> merged_apks_; |
| 2356 | |
| 2357 | // The set of included APKs (not merged). This is mainly here to retain ownership of the APKs. |
| 2358 | std::vector<std::unique_ptr<LoadedApk>> static_library_includes_; |
Adam Lesinski | ceb9b2f | 2017-02-16 12:05:42 -0800 | [diff] [blame] | 2359 | |
| 2360 | // The set of shared libraries being used, mapping their assigned package ID to package name. |
| 2361 | std::map<size_t, std::string> shared_libs_; |
Adam Lesinski | 490595a | 2017-11-07 17:08:07 -0800 | [diff] [blame] | 2362 | |
| 2363 | // The package name of the base application, if it is included. |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 2364 | std::optional<std::string> included_feature_base_; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2365 | }; |
| 2366 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2367 | int LinkCommand::Action(const std::vector<std::string>& args) { |
Fabien Sanglard | 2d34e76 | 2019-02-21 15:13:29 -0800 | [diff] [blame] | 2368 | TRACE_FLUSH(trace_folder_ ? trace_folder_.value() : "", "LinkCommand::Action"); |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2369 | LinkContext context(diag_); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2370 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2371 | // Expand all argument-files passed into the command line. These start with '@'. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2372 | std::vector<std::string> arg_list; |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2373 | for (const std::string& arg : args) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2374 | if (util::StartsWith(arg, "@")) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2375 | const std::string path = arg.substr(1, arg.size() - 1); |
| 2376 | std::string error; |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2377 | if (!file::AppendArgsFromFile(path, &arg_list, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2378 | context.GetDiagnostics()->Error(android::DiagMessage(path) << error); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2379 | return 1; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2380 | } |
| 2381 | } else { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2382 | arg_list.push_back(arg); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2383 | } |
| 2384 | } |
| 2385 | |
| 2386 | // Expand all argument-files passed to -R. |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2387 | for (const std::string& arg : overlay_arg_list_) { |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2388 | if (util::StartsWith(arg, "@")) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2389 | const std::string path = arg.substr(1, arg.size() - 1); |
| 2390 | std::string error; |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2391 | if (!file::AppendArgsFromFile(path, &options_.overlay_files, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2392 | context.GetDiagnostics()->Error(android::DiagMessage(path) << error); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2393 | return 1; |
| 2394 | } |
| 2395 | } else { |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2396 | options_.overlay_files.push_back(arg); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2397 | } |
| 2398 | } |
| 2399 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2400 | if (verbose_) { |
| 2401 | context.SetVerbose(verbose_); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2402 | } |
| 2403 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2404 | if (int{shared_lib_} + int{static_lib_} + int{proto_format_} > 1) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2405 | context.GetDiagnostics() |
| 2406 | ->Error(android::DiagMessage() |
| 2407 | << "only one of --shared-lib, --static-lib, or --proto_format can be defined"); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2408 | return 1; |
| 2409 | } |
| 2410 | |
Ryan Mitchell | 5855de7 | 2021-02-24 14:39:13 -0800 | [diff] [blame] | 2411 | if (shared_lib_ && options_.private_symbols) { |
| 2412 | // If a shared library styleable in a public R.java uses a private attribute, attempting to |
| 2413 | // reference the private attribute within the styleable array will cause a link error because |
| 2414 | // the private attribute will not be emitted in the public R.java. |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2415 | context.GetDiagnostics()->Error(android::DiagMessage() |
Ryan Mitchell | 5855de7 | 2021-02-24 14:39:13 -0800 | [diff] [blame] | 2416 | << "--shared-lib cannot currently be used in combination with" |
| 2417 | << " --private-symbols"); |
| 2418 | return 1; |
| 2419 | } |
| 2420 | |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 2421 | if (options_.merge_only && !static_lib_) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2422 | context.GetDiagnostics() |
| 2423 | ->Error(android::DiagMessage() |
| 2424 | << "the --merge-only flag can be only used when building a static library"); |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 2425 | return 1; |
| 2426 | } |
Iurii Makhno | da06e4d | 2022-08-24 14:17:32 +0000 | [diff] [blame] | 2427 | if (options_.use_sparse_encoding) { |
| 2428 | options_.table_flattener_options.sparse_entries = SparseEntriesMode::Enabled; |
| 2429 | } |
Izabela Orlowska | 84febea | 2019-06-03 18:34:12 +0100 | [diff] [blame] | 2430 | |
Adam Lesinski | e59f0d8 | 2017-10-13 09:36:53 -0700 | [diff] [blame] | 2431 | // The default build type. |
| 2432 | context.SetPackageType(PackageType::kApp); |
| 2433 | context.SetPackageId(kAppPackageId); |
| 2434 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2435 | if (shared_lib_) { |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2436 | context.SetPackageType(PackageType::kSharedLib); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2437 | context.SetPackageId(0x00); |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2438 | } else if (static_lib_) { |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2439 | context.SetPackageType(PackageType::kStaticLib); |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2440 | options_.output_format = OutputFormat::kProto; |
| 2441 | } else if (proto_format_) { |
| 2442 | options_.output_format = OutputFormat::kProto; |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2443 | } |
| 2444 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2445 | if (package_id_) { |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2446 | if (context.GetPackageType() != PackageType::kApp) { |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2447 | context.GetDiagnostics()->Error( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2448 | android::DiagMessage() << "can't specify --package-id when not building a regular app"); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2449 | return 1; |
| 2450 | } |
| 2451 | |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 2452 | const std::optional<uint32_t> maybe_package_id_int = |
| 2453 | ResourceUtils::ParseInt(package_id_.value()); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2454 | if (!maybe_package_id_int) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2455 | context.GetDiagnostics()->Error(android::DiagMessage() |
| 2456 | << "package ID '" << package_id_.value() |
| 2457 | << "' is not a valid integer"); |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2458 | return 1; |
| 2459 | } |
| 2460 | |
| 2461 | const uint32_t package_id_int = maybe_package_id_int.value(); |
Todd Kennedy | 3251299 | 2018-04-25 16:45:59 -0700 | [diff] [blame] | 2462 | if (package_id_int > std::numeric_limits<uint8_t>::max() |
| 2463 | || package_id_int == kFrameworkPackageId |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2464 | || (!options_.allow_reserved_package_id && package_id_int < kAppPackageId)) { |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2465 | context.GetDiagnostics()->Error( |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2466 | android::DiagMessage() << StringPrintf( |
Adam Lesinski | f34b6f4 | 2017-03-03 16:33:26 -0800 | [diff] [blame] | 2467 | "invalid package ID 0x%02x. Must be in the range 0x7f-0xff.", package_id_int)); |
| 2468 | return 1; |
| 2469 | } |
| 2470 | context.SetPackageId(static_cast<uint8_t>(package_id_int)); |
| 2471 | } |
| 2472 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2473 | // Populate the set of extra packages for which to generate R.java. |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2474 | for (std::string& extra_package : extra_java_packages_) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2475 | // A given package can actually be a colon separated list of packages. |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2476 | for (StringPiece package : util::Split(extra_package, ':')) { |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 2477 | options_.extra_java_packages.emplace(package); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2478 | } |
| 2479 | } |
| 2480 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2481 | if (product_list_) { |
| 2482 | for (StringPiece product : util::Tokenize(product_list_.value(), ',')) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2483 | if (product != "" && product != "default") { |
Yurii Zubrytskyi | a577514 | 2022-11-02 17:49:49 -0700 | [diff] [blame] | 2484 | options_.products.emplace(product); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2485 | } |
| 2486 | } |
| 2487 | } |
| 2488 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2489 | std::unique_ptr<IConfigFilter> filter; |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2490 | if (!configs_.empty()) { |
| 2491 | filter = ParseConfigFilterParameters(configs_, context.GetDiagnostics()); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2492 | if (filter == nullptr) { |
| 2493 | return 1; |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2494 | } |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2495 | options_.table_splitter_options.config_filter = filter.get(); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2496 | } |
| 2497 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2498 | if (preferred_density_) { |
Ryan Mitchell | 4382e44 | 2021-07-14 12:53:01 -0700 | [diff] [blame] | 2499 | std::optional<uint16_t> density = |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2500 | ParseTargetDensityParameter(preferred_density_.value(), context.GetDiagnostics()); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2501 | if (!density) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2502 | return 1; |
Adam Lesinski | c51562c | 2016-04-28 11:12:38 -0700 | [diff] [blame] | 2503 | } |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2504 | options_.table_splitter_options.preferred_densities.push_back(density.value()); |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2505 | } |
Adam Lesinski | c51562c | 2016-04-28 11:12:38 -0700 | [diff] [blame] | 2506 | |
Adam Lesinski | d0f492d | 2017-04-03 18:12:45 -0700 | [diff] [blame] | 2507 | // Parse the split parameters. |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2508 | for (const std::string& split_arg : split_args_) { |
| 2509 | options_.split_paths.push_back({}); |
| 2510 | options_.split_constraints.push_back({}); |
| 2511 | if (!ParseSplitParameter(split_arg, context.GetDiagnostics(), &options_.split_paths.back(), |
| 2512 | &options_.split_constraints.back())) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2513 | return 1; |
Adam Lesinski | 1e21ff0 | 2016-06-24 14:57:58 -0700 | [diff] [blame] | 2514 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2515 | } |
Adam Lesinski | 1e21ff0 | 2016-06-24 14:57:58 -0700 | [diff] [blame] | 2516 | |
Mark Punzalan | 5579cad | 2023-10-30 13:47:51 -0700 | [diff] [blame] | 2517 | // Parse the feature flag values. An argument that starts with '@' points to a file to read flag |
| 2518 | // values from. |
| 2519 | std::vector<std::string> all_feature_flags_args; |
| 2520 | for (const std::string& arg : feature_flags_args_) { |
| 2521 | if (util::StartsWith(arg, "@")) { |
| 2522 | const std::string path = arg.substr(1, arg.size() - 1); |
| 2523 | std::string error; |
| 2524 | if (!file::AppendArgsFromFile(path, &all_feature_flags_args, &error)) { |
| 2525 | context.GetDiagnostics()->Error(android::DiagMessage(path) << error); |
| 2526 | return 1; |
| 2527 | } |
| 2528 | } else { |
| 2529 | all_feature_flags_args.push_back(arg); |
| 2530 | } |
| 2531 | } |
| 2532 | |
| 2533 | for (const std::string& arg : all_feature_flags_args) { |
| 2534 | if (ParseFeatureFlagsParameter(arg, context.GetDiagnostics(), &options_.feature_flag_values)) { |
| 2535 | return 1; |
| 2536 | } |
| 2537 | } |
| 2538 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2539 | if (context.GetPackageType() != PackageType::kStaticLib && stable_id_file_path_) { |
| 2540 | if (!LoadStableIdMap(context.GetDiagnostics(), stable_id_file_path_.value(), |
| 2541 | &options_.stable_id_map)) { |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2542 | return 1; |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 2543 | } |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2544 | } |
Adam Lesinski | 64587af | 2016-02-18 18:33:06 -0800 | [diff] [blame] | 2545 | |
Izabela Orlowska | 0faba5f | 2018-06-01 12:06:31 +0100 | [diff] [blame] | 2546 | if (no_compress_regex) { |
| 2547 | std::string regex = no_compress_regex.value(); |
| 2548 | if (util::StartsWith(regex, "@")) { |
| 2549 | const std::string path = regex.substr(1, regex.size() -1); |
| 2550 | std::string error; |
| 2551 | if (!file::AppendSetArgsFromFile(path, &options_.extensions_to_not_compress, &error)) { |
Jeremy Meyer | 56f36e8 | 2022-05-20 20:35:42 +0000 | [diff] [blame] | 2552 | context.GetDiagnostics()->Error(android::DiagMessage(path) << error); |
Izabela Orlowska | 0faba5f | 2018-06-01 12:06:31 +0100 | [diff] [blame] | 2553 | return 1; |
| 2554 | } |
| 2555 | } else { |
| 2556 | options_.regex_to_not_compress = GetRegularExpression(no_compress_regex.value()); |
| 2557 | } |
| 2558 | } |
| 2559 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2560 | // Populate some default no-compress extensions that are already compressed. |
Ryan Mitchell | bf511dd | 2020-09-14 10:28:14 -0700 | [diff] [blame] | 2561 | options_.extensions_to_not_compress.insert({ |
| 2562 | // Image extensions |
| 2563 | ".jpg", ".jpeg", ".png", ".gif", ".webp", |
| 2564 | // Audio extensions |
| 2565 | ".wav", ".mp2", ".mp3", ".ogg", ".aac", ".mid", ".midi", ".smf", ".jet", ".rtttl", ".imy", |
| 2566 | ".xmf", ".amr", ".awb", |
| 2567 | // Audio/video extensions |
| 2568 | ".mpg", ".mpeg", ".mp4", ".m4a", ".m4v", ".3gp", ".3gpp", ".3g2", ".3gpp2", ".wma", ".wmv", |
| 2569 | ".webm", ".mkv"}); |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2570 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2571 | // Turn off auto versioning for static-libs. |
Adam Lesinski | b522f04 | 2017-04-21 16:57:59 -0700 | [diff] [blame] | 2572 | if (context.GetPackageType() == PackageType::kStaticLib) { |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2573 | options_.no_auto_version = true; |
| 2574 | options_.no_version_vectors = true; |
| 2575 | options_.no_version_transitions = true; |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2576 | } |
Adam Lesinski | e4bb9eb | 2016-02-12 22:18:51 -0800 | [diff] [blame] | 2577 | |
Ryan Mitchell | 833a1a6 | 2018-07-10 13:51:36 -0700 | [diff] [blame] | 2578 | Linker cmd(&context, options_); |
Adam Lesinski | ce5e56e | 2016-10-21 17:56:45 -0700 | [diff] [blame] | 2579 | return cmd.Run(arg_list); |
Adam Lesinski | 1ab598f | 2015-08-14 14:26:04 -0700 | [diff] [blame] | 2580 | } |
| 2581 | |
Adam Lesinski | cacb28f | 2016-10-19 12:18:14 -0700 | [diff] [blame] | 2582 | } // namespace aapt |