Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2015 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Alexandru Gheorghe | 0f5abd7 | 2018-05-01 14:37:10 +0100 | [diff] [blame] | 17 | #define LOG_TAG "hwc-drm-device" |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 18 | |
Roman Stratiienko | 13cc366 | 2020-08-29 21:35:39 +0300 | [diff] [blame] | 19 | #include "DrmDevice.h" |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 20 | |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 21 | #include <xf86drm.h> |
| 22 | #include <xf86drmMode.h> |
| 23 | |
Roman Stratiienko | 13cc366 | 2020-08-29 21:35:39 +0300 | [diff] [blame] | 24 | #include <cinttypes> |
Roman Stratiienko | e2f2c92 | 2021-02-13 10:57:47 +0200 | [diff] [blame] | 25 | #include <cstdint> |
Roman Kovalivskyi | d07c370 | 2019-11-04 17:54:31 +0200 | [diff] [blame] | 26 | #include <string> |
| 27 | |
Roman Stratiienko | 4e99405 | 2022-02-09 17:40:35 +0200 | [diff] [blame] | 28 | #include "drm/DrmAtomicStateManager.h" |
Roman Stratiienko | 24a7fc4 | 2021-12-23 16:25:20 +0200 | [diff] [blame] | 29 | #include "drm/DrmPlane.h" |
Roman Stratiienko | 5f21dbc | 2022-05-03 18:31:13 +0300 | [diff] [blame] | 30 | #include "drm/ResourceManager.h" |
Roman Stratiienko | d518a05 | 2021-02-25 19:15:14 +0200 | [diff] [blame] | 31 | #include "utils/log.h" |
| 32 | #include "utils/properties.h" |
| 33 | |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 34 | namespace android { |
| 35 | |
Roman Stratiienko | 5f21dbc | 2022-05-03 18:31:13 +0300 | [diff] [blame] | 36 | auto DrmDevice::CreateInstance(std::string const &path, |
| 37 | ResourceManager *res_man) |
| 38 | -> std::unique_ptr<DrmDevice> { |
| 39 | if (!IsKMSDev(path.c_str())) { |
| 40 | return {}; |
| 41 | } |
| 42 | |
| 43 | auto device = std::unique_ptr<DrmDevice>(new DrmDevice(res_man)); |
| 44 | |
| 45 | if (device->Init(path.c_str()) != 0) { |
| 46 | return {}; |
| 47 | } |
| 48 | |
| 49 | return device; |
| 50 | } |
| 51 | |
| 52 | DrmDevice::DrmDevice(ResourceManager *res_man) : res_man_(res_man) { |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 53 | drm_fb_importer_ = std::make_unique<DrmFbImporter>(*this); |
Sean Paul | 047b9b2 | 2015-07-28 14:15:42 -0400 | [diff] [blame] | 54 | } |
| 55 | |
Roman Stratiienko | 3dacd47 | 2022-01-11 19:18:34 +0200 | [diff] [blame] | 56 | auto DrmDevice::Init(const char *path) -> int { |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 57 | /* TODO: Use drmOpenControl here instead */ |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 58 | fd_ = MakeSharedFd(open(path, O_RDWR | O_CLOEXEC)); |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 59 | if (!fd_) { |
Roman Stratiienko | 5f2f3ce | 2021-12-22 11:46:03 +0200 | [diff] [blame] | 60 | // NOLINTNEXTLINE(concurrency-mt-unsafe): Fixme |
Peter Collingbourne | c77052e | 2020-02-19 11:25:08 -0800 | [diff] [blame] | 61 | ALOGE("Failed to open dri %s: %s", path, strerror(errno)); |
Roman Stratiienko | 3dacd47 | 2022-01-11 19:18:34 +0200 | [diff] [blame] | 62 | return -ENODEV; |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 63 | } |
| 64 | |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 65 | int ret = drmSetClientCap(*GetFd(), DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1); |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 66 | if (ret != 0) { |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 67 | ALOGE("Failed to set universal plane cap %d", ret); |
Roman Stratiienko | 3dacd47 | 2022-01-11 19:18:34 +0200 | [diff] [blame] | 68 | return ret; |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 69 | } |
| 70 | |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 71 | ret = drmSetClientCap(*GetFd(), DRM_CLIENT_CAP_ATOMIC, 1); |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 72 | if (ret != 0) { |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 73 | ALOGE("Failed to set atomic cap %d", ret); |
Roman Stratiienko | 3dacd47 | 2022-01-11 19:18:34 +0200 | [diff] [blame] | 74 | return ret; |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 75 | } |
| 76 | |
Alexandru Gheorghe | b46b930 | 2018-03-21 14:19:58 +0000 | [diff] [blame] | 77 | #ifdef DRM_CLIENT_CAP_WRITEBACK_CONNECTORS |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 78 | ret = drmSetClientCap(*GetFd(), DRM_CLIENT_CAP_WRITEBACK_CONNECTORS, 1); |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 79 | if (ret != 0) { |
Alexandru Gheorghe | b46b930 | 2018-03-21 14:19:58 +0000 | [diff] [blame] | 80 | ALOGI("Failed to set writeback cap %d", ret); |
Alexandru Gheorghe | b46b930 | 2018-03-21 14:19:58 +0000 | [diff] [blame] | 81 | } |
| 82 | #endif |
| 83 | |
Roman Stratiienko | 8666dc9 | 2021-02-09 17:49:55 +0200 | [diff] [blame] | 84 | uint64_t cap_value = 0; |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 85 | if (drmGetCap(*GetFd(), DRM_CAP_ADDFB2_MODIFIERS, &cap_value) != 0) { |
Roman Stratiienko | 8666dc9 | 2021-02-09 17:49:55 +0200 | [diff] [blame] | 86 | ALOGW("drmGetCap failed. Fallback to no modifier support."); |
| 87 | cap_value = 0; |
| 88 | } |
| 89 | HasAddFb2ModifiersSupport_ = cap_value != 0; |
| 90 | |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 91 | drmSetMaster(*GetFd()); |
| 92 | if (drmIsMaster(*GetFd()) == 0) { |
John Stultz | fa00233 | 2021-02-02 01:34:45 +0000 | [diff] [blame] | 93 | ALOGE("DRM/KMS master access required"); |
Roman Stratiienko | 3dacd47 | 2022-01-11 19:18:34 +0200 | [diff] [blame] | 94 | return -EACCES; |
Roman Stratiienko | 3b24cd9 | 2021-01-13 10:32:04 +0200 | [diff] [blame] | 95 | } |
| 96 | |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 97 | auto res = MakeDrmModeResUnique(*GetFd()); |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 98 | if (!res) { |
Alexandru Gheorghe | 0f5abd7 | 2018-05-01 14:37:10 +0100 | [diff] [blame] | 99 | ALOGE("Failed to get DrmDevice resources"); |
Roman Stratiienko | 3dacd47 | 2022-01-11 19:18:34 +0200 | [diff] [blame] | 100 | return -ENODEV; |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 101 | } |
| 102 | |
Sean Paul | f72cccd | 2018-08-27 13:59:08 -0400 | [diff] [blame] | 103 | min_resolution_ = std::pair<uint32_t, uint32_t>(res->min_width, |
| 104 | res->min_height); |
| 105 | max_resolution_ = std::pair<uint32_t, uint32_t>(res->max_width, |
| 106 | res->max_height); |
Sean Paul | 406dbfc | 2016-02-10 15:35:17 -0800 | [diff] [blame] | 107 | |
Roman Stratiienko | 10be875 | 2022-01-30 20:28:46 +0200 | [diff] [blame] | 108 | for (int i = 0; i < res->count_crtcs; ++i) { |
| 109 | // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) |
| 110 | auto crtc = DrmCrtc::CreateInstance(*this, res->crtcs[i], i); |
| 111 | if (crtc) { |
| 112 | crtcs_.emplace_back(std::move(crtc)); |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 113 | } |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 114 | } |
| 115 | |
Roman Stratiienko | 027987b | 2022-01-30 21:06:35 +0200 | [diff] [blame] | 116 | for (int i = 0; i < res->count_encoders; ++i) { |
| 117 | // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) |
| 118 | auto enc = DrmEncoder::CreateInstance(*this, res->encoders[i], i); |
| 119 | if (enc) { |
| 120 | encoders_.emplace_back(std::move(enc)); |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 121 | } |
Alexandru Gheorghe | e8b668c | 2018-03-22 11:31:29 +0000 | [diff] [blame] | 122 | } |
| 123 | |
Roman Stratiienko | 650299a | 2022-01-30 23:46:10 +0200 | [diff] [blame] | 124 | for (int i = 0; i < res->count_connectors; ++i) { |
| 125 | // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) |
| 126 | auto conn = DrmConnector::CreateInstance(*this, res->connectors[i], i); |
| 127 | |
| 128 | if (!conn) { |
| 129 | continue; |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 130 | } |
| 131 | |
Roman Stratiienko | 650299a | 2022-01-30 23:46:10 +0200 | [diff] [blame] | 132 | if (conn->IsWriteback()) { |
Alexandru Gheorghe | b46b930 | 2018-03-21 14:19:58 +0000 | [diff] [blame] | 133 | writeback_connectors_.emplace_back(std::move(conn)); |
Roman Stratiienko | 650299a | 2022-01-30 23:46:10 +0200 | [diff] [blame] | 134 | } else { |
Alexandru Gheorghe | b46b930 | 2018-03-21 14:19:58 +0000 | [diff] [blame] | 135 | connectors_.emplace_back(std::move(conn)); |
Roman Stratiienko | 650299a | 2022-01-30 23:46:10 +0200 | [diff] [blame] | 136 | } |
Robert Foss | 610d989 | 2017-11-01 12:50:04 -0500 | [diff] [blame] | 137 | } |
| 138 | |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 139 | auto plane_res = MakeDrmModePlaneResUnique(*GetFd()); |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 140 | if (!plane_res) { |
| 141 | ALOGE("Failed to get plane resources"); |
Roman Stratiienko | 3dacd47 | 2022-01-11 19:18:34 +0200 | [diff] [blame] | 142 | return -ENOENT; |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 143 | } |
| 144 | |
| 145 | for (uint32_t i = 0; i < plane_res->count_planes; ++i) { |
Roman Stratiienko | b671fab | 2022-01-29 00:50:22 +0200 | [diff] [blame] | 146 | // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) |
| 147 | auto plane = DrmPlane::CreateInstance(*this, plane_res->planes[i]); |
| 148 | |
| 149 | if (plane) { |
| 150 | planes_.emplace_back(std::move(plane)); |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 151 | } |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 152 | } |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 153 | |
Roman Stratiienko | 3dacd47 | 2022-01-11 19:18:34 +0200 | [diff] [blame] | 154 | return 0; |
Sean Paul | 877be97 | 2015-06-03 14:08:27 -0400 | [diff] [blame] | 155 | } |
| 156 | |
Roman Stratiienko | 6ede466 | 2021-09-30 10:18:28 +0300 | [diff] [blame] | 157 | auto DrmDevice::RegisterUserPropertyBlob(void *data, size_t length) const |
| 158 | -> DrmModeUserPropertyBlobUnique { |
Roman Stratiienko | b3b5c1e | 2021-02-15 13:44:19 +0200 | [diff] [blame] | 159 | struct drm_mode_create_blob create_blob {}; |
Sean Paul | 877be97 | 2015-06-03 14:08:27 -0400 | [diff] [blame] | 160 | create_blob.length = length; |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 161 | // NOLINTNEXTLINE(cppcoreguidelines-pro-type-cstyle-cast) |
Sean Paul | 877be97 | 2015-06-03 14:08:27 -0400 | [diff] [blame] | 162 | create_blob.data = (__u64)data; |
| 163 | |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 164 | auto ret = drmIoctl(*GetFd(), DRM_IOCTL_MODE_CREATEPROPBLOB, &create_blob); |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 165 | if (ret != 0) { |
Sean Paul | 877be97 | 2015-06-03 14:08:27 -0400 | [diff] [blame] | 166 | ALOGE("Failed to create mode property blob %d", ret); |
Roman Stratiienko | 780f7da | 2022-01-10 16:04:15 +0200 | [diff] [blame] | 167 | return {}; |
Sean Paul | 877be97 | 2015-06-03 14:08:27 -0400 | [diff] [blame] | 168 | } |
Sean Paul | 877be97 | 2015-06-03 14:08:27 -0400 | [diff] [blame] | 169 | |
Roman Stratiienko | 6ede466 | 2021-09-30 10:18:28 +0300 | [diff] [blame] | 170 | return DrmModeUserPropertyBlobUnique( |
| 171 | new uint32_t(create_blob.blob_id), [this](const uint32_t *it) { |
| 172 | struct drm_mode_destroy_blob destroy_blob {}; |
| 173 | destroy_blob.blob_id = (__u32)*it; |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 174 | auto err = drmIoctl(*GetFd(), DRM_IOCTL_MODE_DESTROYPROPBLOB, |
Roman Stratiienko | a7913de | 2022-10-20 13:18:57 +0300 | [diff] [blame] | 175 | &destroy_blob); |
Roman Stratiienko | 6ede466 | 2021-09-30 10:18:28 +0300 | [diff] [blame] | 176 | if (err != 0) { |
| 177 | ALOGE("Failed to destroy mode property blob %" PRIu32 "/%d", *it, |
| 178 | err); |
| 179 | } |
| 180 | // NOLINTNEXTLINE(cppcoreguidelines-owning-memory) |
| 181 | delete it; |
| 182 | }); |
Sean Paul | 877be97 | 2015-06-03 14:08:27 -0400 | [diff] [blame] | 183 | } |
| 184 | |
Alexandru Gheorghe | 0f5abd7 | 2018-05-01 14:37:10 +0100 | [diff] [blame] | 185 | int DrmDevice::GetProperty(uint32_t obj_id, uint32_t obj_type, |
Roman Stratiienko | e2f2c92 | 2021-02-13 10:57:47 +0200 | [diff] [blame] | 186 | const char *prop_name, DrmProperty *property) const { |
Roman Stratiienko | b3b5c1e | 2021-02-15 13:44:19 +0200 | [diff] [blame] | 187 | drmModeObjectPropertiesPtr props = nullptr; |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 188 | |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 189 | props = drmModeObjectGetProperties(*GetFd(), obj_id, obj_type); |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 190 | if (props == nullptr) { |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 191 | ALOGE("Failed to get properties for %d/%x", obj_id, obj_type); |
| 192 | return -ENODEV; |
| 193 | } |
| 194 | |
| 195 | bool found = false; |
| 196 | for (int i = 0; !found && (size_t)i < props->count_props; ++i) { |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 197 | // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 198 | drmModePropertyPtr p = drmModeGetProperty(*GetFd(), props->props[i]); |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 199 | if (strcmp(p->name, prop_name) == 0) { |
| 200 | // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) |
Roman Stratiienko | 7fd8f88 | 2021-09-29 12:46:54 +0300 | [diff] [blame] | 201 | property->Init(obj_id, p, props->prop_values[i]); |
Sean Paul | 6a55e9f | 2015-04-30 15:31:06 -0400 | [diff] [blame] | 202 | found = true; |
| 203 | } |
| 204 | drmModeFreeProperty(p); |
| 205 | } |
| 206 | |
| 207 | drmModeFreeObjectProperties(props); |
| 208 | return found ? 0 : -ENOENT; |
| 209 | } |
| 210 | |
Roman Stratiienko | e2f2c92 | 2021-02-13 10:57:47 +0200 | [diff] [blame] | 211 | std::string DrmDevice::GetName() const { |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 212 | auto *ver = drmGetVersion(*GetFd()); |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 213 | if (ver == nullptr) { |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 214 | ALOGW("Failed to get drm version for fd=%d", *GetFd()); |
Matvii Zorin | ef3c797 | 2020-08-11 15:15:44 +0300 | [diff] [blame] | 215 | return "generic"; |
| 216 | } |
| 217 | |
| 218 | std::string name(ver->name); |
| 219 | drmFreeVersion(ver); |
| 220 | return name; |
| 221 | } |
Roman Stratiienko | 56f4adc | 2021-09-29 12:47:12 +0300 | [diff] [blame] | 222 | |
| 223 | auto DrmDevice::IsKMSDev(const char *path) -> bool { |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 224 | auto fd = MakeUniqueFd(open(path, O_RDWR | O_CLOEXEC)); |
Roman Stratiienko | 56f4adc | 2021-09-29 12:47:12 +0300 | [diff] [blame] | 225 | if (!fd) { |
| 226 | return false; |
| 227 | } |
| 228 | |
Roman Stratiienko | 7689278 | 2023-01-16 17:15:53 +0200 | [diff] [blame^] | 229 | auto res = MakeDrmModeResUnique(*fd); |
Roman Stratiienko | 56f4adc | 2021-09-29 12:47:12 +0300 | [diff] [blame] | 230 | if (!res) { |
| 231 | return false; |
| 232 | } |
| 233 | |
Roman Stratiienko | a7913de | 2022-10-20 13:18:57 +0300 | [diff] [blame] | 234 | auto is_kms = res->count_crtcs > 0 && res->count_connectors > 0 && |
Roman Stratiienko | 56f4adc | 2021-09-29 12:47:12 +0300 | [diff] [blame] | 235 | res->count_encoders > 0; |
| 236 | |
| 237 | return is_kms; |
| 238 | } |
| 239 | |
Roman Stratiienko | 7d89911 | 2022-01-31 11:30:27 +0200 | [diff] [blame] | 240 | auto DrmDevice::GetConnectors() |
| 241 | -> const std::vector<std::unique_ptr<DrmConnector>> & { |
| 242 | return connectors_; |
| 243 | } |
| 244 | |
| 245 | auto DrmDevice::GetPlanes() -> const std::vector<std::unique_ptr<DrmPlane>> & { |
| 246 | return planes_; |
| 247 | } |
| 248 | |
| 249 | auto DrmDevice::GetCrtcs() -> const std::vector<std::unique_ptr<DrmCrtc>> & { |
| 250 | return crtcs_; |
| 251 | } |
| 252 | |
| 253 | auto DrmDevice::GetEncoders() |
| 254 | -> const std::vector<std::unique_ptr<DrmEncoder>> & { |
| 255 | return encoders_; |
| 256 | } |
| 257 | |
Sean Paul | f72cccd | 2018-08-27 13:59:08 -0400 | [diff] [blame] | 258 | } // namespace android |