blob: a30414c295f2afef828f7bf75f99cf03e360454c [file] [log] [blame]
Roman Stratiienkocef5c772021-12-22 16:22:24 +02001
Roman Stratiienko2a93e4c2022-12-19 18:24:47 +02002BASE_DIR:=../aospless
3
Roman Stratiienkocef5c772021-12-22 16:22:24 +02004SYSTEM_INCLUDE_DIRS := /usr/include/libdrm
5
Roman Stratiienkoa7913de2022-10-20 13:18:57 +03006CLANG := clang++-15
7CLANG_TIDY := clang-tidy-15
Roman Stratiienko5741bbd2021-12-30 18:12:26 +02008OUT_DIR := /tmp/drm_hwcomposer/build
Roman Stratiienkocef5c772021-12-22 16:22:24 +02009SRC_DIR := .
10
Roman Stratiienko2a93e4c2022-12-19 18:24:47 +020011CXXFLAGS := -Wall -Wextra -Werror
Roman Stratiienkocef5c772021-12-22 16:22:24 +020012CXXFLAGS += -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS
13CXXFLAGS += -fvisibility-inlines-hidden -std=gnu++17 -DHWC2_USE_CPP11 -DHWC2_INCLUDE_STRINGIFICATION -fno-rtti
14
Roman Stratiienko2a93e4c2022-12-19 18:24:47 +020015CXXARGS := $(shell cat $(BASE_DIR)/build_flags/sharedlib.cppflags)
16CXXARGS := $(subst [BASE_DIR],$(BASE_DIR),$(CXXARGS))
17# clang-tidy doesn't like -mcpu=xxx flag
18CXXARGS := $(patsubst -mcpu=%,,$(CXXARGS))
19# TODO: build aospless with gtest enabled and remove line below
20CXXARGS := $(subst -nostdlibinc,,$(CXXARGS))
21CXXARGS += -I. -I./tests/test_include $(CXXFLAGS)
Roman Stratiienkocef5c772021-12-22 16:22:24 +020022
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020023TIDY_FILES_OVERRIDE := \
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020024 bufferinfo/legacy/BufferInfoImagination.cpp:COARSE \
25 bufferinfo/legacy/BufferInfoLibdrm.cpp:COARSE \
26 bufferinfo/legacy/BufferInfoMaliHisi.cpp:COARSE \
27 bufferinfo/legacy/BufferInfoMaliMediatek.cpp:COARSE \
28 bufferinfo/legacy/BufferInfoMaliMeson.cpp:COARSE \
29 bufferinfo/legacy/BufferInfoMinigbm.cpp:COARSE \
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020030 drm/DrmFbImporter.h:FINE \
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020031 drm/DrmUnique.h:FINE \
Roman Stratiienko3e168902022-01-04 16:13:12 +020032 hwc2_device/DrmHwcTwo.cpp:COARSE \
33 hwc2_device/DrmHwcTwo.h:COARSE \
Roman Stratiienko3627beb2022-01-04 16:02:55 +020034 hwc2_device/HwcDisplay.cpp:COARSE \
35 hwc2_device/HwcDisplay.h:COARSE \
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020036 utils/log.h:FINE \
37 utils/properties.h:FINE \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020038
Roman Stratiienkoc46896d2022-01-04 11:10:22 +020039TIDY_CHECKS_FINE := * \
40 -llvmlibc* -fuchsia-* -altera-* \
41 -llvm-header-guard \
42 -cppcoreguidelines-pro-type-vararg \
43 -hicpp-vararg \
44 -hicpp-signed-bitwise \
Roman Stratiienkocf80b9b2022-04-28 15:42:36 +030045 -readability-identifier-length \
Roman Stratiienkoc46896d2022-01-04 11:10:22 +020046
47TIDY_CHECKS_NORMAL := \
48 $(TIDY_CHECKS_FINE) \
49 -hicpp* \
Roman Stratiienko780f7da2022-01-10 16:04:15 +020050 -bugprone-easily-swappable-parameters \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020051 -cppcoreguidelines-special-member-functions \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020052 -cppcoreguidelines-avoid-c-arrays \
Roman Stratiienkofc014f52021-12-23 19:04:29 +020053 -cppcoreguidelines-pro-bounds-array-to-pointer-decay \
54 -cppcoreguidelines-pro-bounds-constant-array-index \
55 -cppcoreguidelines-avoid-magic-numbers \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020056 -google-readability-braces-around-statements \
57 -google-readability-casting \
58 -misc-non-private-member-variables-in-classes \
59 -modernize-avoid-c-arrays \
Roman Stratiienkofc014f52021-12-23 19:04:29 +020060 -modernize-use-nodiscard \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020061 -modernize-use-trailing-return-type \
62 -readability-braces-around-statements \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020063
64TIDY_CHECKS_COARSE := \
65 $(TIDY_CHECKS_NORMAL) \
Roman Stratiienkoe78235c2021-12-23 17:36:12 +020066 -cppcoreguidelines-non-private-member-variables-in-classes \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020067 -cppcoreguidelines-pro-bounds-pointer-arithmetic \
68 -cppcoreguidelines-pro-type-cstyle-cast \
Roman Stratiienkoe78235c2021-12-23 17:36:12 +020069 -cppcoreguidelines-pro-type-reinterpret-cast \
70 -cppcoreguidelines-pro-type-static-cast-downcast \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020071 -cppcoreguidelines-pro-type-union-access \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020072 -cppcoreguidelines-macro-usage \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020073 -readability-convert-member-functions-to-static \
74 -readability-implicit-bool-conversion \
75 -readability-identifier-naming \
76 -readability-magic-numbers \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020077
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020078.PHONY: all build tidy clean
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020079
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020080all: build tidy
Roman Stratiienkocef5c772021-12-22 16:22:24 +020081
82clean:
83 rm -rf $(OUT_DIR)/
84
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020085# Build
86
Roman Stratiienkobd973172022-02-18 16:51:53 +020087BUILD_FILES_AUTO := $(shell find -L $(SRC_DIR) -not -path '*/\.*' -not -path '*/tests/test_include/*' -path '*.cpp')
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020088SKIP_FILES_path := $(foreach file,$(SKIP_FILES),$(SRC_DIR)/$(file))
89
90BUILD_FILES := $(subst ./,,$(filter-out $(SKIP_FILES_path),$(BUILD_FILES_AUTO)))
91
Roman Stratiienkocef5c772021-12-22 16:22:24 +020092_OBJ := $(BUILD_FILES:.cpp=.o)
93OBJ := $(patsubst %,$(OUT_DIR)/%,$(_OBJ))
94
Roman Stratiienkocef5c772021-12-22 16:22:24 +020095DEPS := $(patsubst %.cpp,$(OUT_DIR)/%.d,$(BUILD_FILES))
96
97build: $(OBJ)
98
Roman Stratiienkocef5c772021-12-22 16:22:24 +020099$(OUT_DIR)/%.o: $(SRC_DIR)/%.cpp
Roman Stratiienko2a93e4c2022-12-19 18:24:47 +0200100 @mkdir -p $(dir $@)
101 @echo "CC $<"
102 @$(CLANG) $< $(CXXARGS) -c -o $@
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200103
104$(OUT_DIR)/%.d: $(SRC_DIR)/%.cpp
Roman Stratiienko2a93e4c2022-12-19 18:24:47 +0200105 @mkdir -p $(dir $@)
106 @$(CLANG) $(CXXARGS) $< -MM -MT $(OUT_DIR)/$(patsubst %.cpp,%.o,$<) -o $@
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200107
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200108# TIDY
Roman Stratiienkobd973172022-02-18 16:51:53 +0200109TIDY_FILES_AUTO := $(shell find -L $(SRC_DIR) -not -path '*/\.*' -not -path '*/tests/test_include/*' \( -path '*.cpp' -o -path '*.h' \))
Roman Stratiienko5741bbd2021-12-30 18:12:26 +0200110
111TIDY_FILES_AUTO_filtered := $(filter-out $(SKIP_FILES_path),$(TIDY_FILES_AUTO))
112
113TIDY_FILES_OVERRIDE_path := $(foreach pair,$(TIDY_FILES_OVERRIDE),$(SRC_DIR)/$(pair))
114
115TIDY_FILES_OVERRIDE_name_only := $(foreach pair,$(TIDY_FILES_OVERRIDE_path),$(word 1, $(subst :, ,$(pair))))
116
117TIDY_FILES := $(sort $(TIDY_FILES_AUTO_filtered) $(TIDY_FILES_OVERRIDE_name_only))
118
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200119space := $(subst ,, )
120comma := ,
121
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200122TIDY_ARGS_NONE := --checks="-*,llvm-include-order"
123TIDY_ARGS_ := --checks="-*,llvm-include-order"
Roman Stratiienkoc46896d2022-01-04 11:10:22 +0200124TIDY_ARGS_FINE := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_FINE)))"
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200125TIDY_ARGS_NORMAL := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_NORMAL)))"
126TIDY_ARGS_COARSE := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_COARSE)))"
127
128define process-tidy
129
130_TARG := $(OUT_DIR)/$1.tidy.ts
Roman Stratiienko2a93e4c2022-12-19 18:24:47 +0200131_DEP := $1
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200132
133TIDY_DEPS += $(_TARG)
134
Roman Stratiienko5741bbd2021-12-30 18:12:26 +0200135TIDY_LEVEL_1 := $$(strip $$(foreach pair,$$(TIDY_FILES_OVERRIDE_path),$$(if $$(filter $$(word 1, $$(subst :, ,$$(pair))),$1),$$(word 2, $$(subst :, ,$$(pair))),)))
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200136
Roman Stratiienko5741bbd2021-12-30 18:12:26 +0200137TIDY_LEVEL_2 := $$(if $$(TIDY_LEVEL_1),$$(TIDY_LEVEL_1),NORMAL)
138
139TIDY_ARGS := $$(TIDY_ARGS_$$(TIDY_LEVEL_2))
140
141$$(_TARG): _DEP := $$(_DEP)
142$$(_TARG): _TARG := $$(_TARG)
143$$(_TARG): TIDY_ARGS := $$(TIDY_ARGS)
144$$(_TARG): $$(_DEP)
Roman Stratiienko2a93e4c2022-12-19 18:24:47 +0200145 @mkdir -p $$(dir $$(_TARG))
146 @echo "TIDY $$<"
147 @$$(CLANG_TIDY) $$(_DEP) $$(TIDY_ARGS) --quiet -- -x c++ $$(CXXARGS) -Wno-pragma-once-outside-header
148 @touch $$(_TARG)
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200149
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200150endef
151
Roman Stratiienko5741bbd2021-12-30 18:12:26 +0200152$(foreach file,$(TIDY_FILES),$(eval $(call process-tidy,$(file))))
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200153
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200154tidy: $(TIDY_DEPS)
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200155
156ifneq ($(MAKECMDGOALS), clean)
157-include $(DEPS)
158endif