blob: f4690620c612719e6e489ab1a1b62ef61fb1ab74 [file] [log] [blame]
Jiyong Park09d77522019-11-18 11:16:27 +09001// Copyright (C) 2019 The Android Open Source Project
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package apex
16
17import (
18 "fmt"
19 "io"
20 "path/filepath"
21 "strings"
22
23 "android/soong/android"
24 "android/soong/cc"
Jaewoong Jung87a33e72020-03-26 14:01:48 -070025 "android/soong/java"
Jiyong Parkc7a46882023-02-02 11:33:39 +090026 "android/soong/rust"
Jiyong Park09d77522019-11-18 11:16:27 +090027)
28
29func (a *apexBundle) AndroidMk() android.AndroidMkData {
30 if a.properties.HideFromMake {
31 return android.AndroidMkData{
32 Disabled: true,
33 }
34 }
Jooyung Han2ed99d02020-06-24 23:26:26 +090035 return a.androidMkForType()
Jiyong Park09d77522019-11-18 11:16:27 +090036}
37
Jiyong Parkc0ec6f92020-11-19 23:00:52 +090038// nameInMake converts apexFileClass into the corresponding class name in Make.
39func (class apexFileClass) nameInMake() string {
40 switch class {
41 case etc:
42 return "ETC"
43 case nativeSharedLib:
44 return "SHARED_LIBRARIES"
45 case nativeExecutable, shBinary, pyBinary, goBinary:
46 return "EXECUTABLES"
47 case javaSharedLib:
48 return "JAVA_LIBRARIES"
49 case nativeTest:
50 return "NATIVE_TESTS"
51 case app, appSet:
52 // b/142537672 Why isn't this APP? We want to have full control over
53 // the paths and file names of the apk file under the flattend APEX.
54 // If this is set to APP, then the paths and file names are modified
55 // by the Make build system. For example, it is installed to
56 // /system/apex/<apexname>/app/<Appname>/<apexname>.<Appname>/ instead of
57 // /system/apex/<apexname>/app/<Appname> because the build system automatically
58 // appends module name (which is <apexname>.<Appname> to the path.
59 return "ETC"
60 default:
61 panic(fmt.Errorf("unknown class %d", class))
62 }
63}
64
Bob Badourb4999222021-01-07 03:34:31 +000065// Return the full module name for a dependency module, which appends the apex module name unless re-using a system lib.
Jingwen Chen2d37b642023-03-14 16:11:38 +000066func (a *apexBundle) fullModuleName(apexBundleName string, linkToSystemLib bool, fi *apexFile) string {
Bob Badourb4999222021-01-07 03:34:31 +000067 if linkToSystemLib {
68 return fi.androidMkModuleName
69 }
70 return fi.androidMkModuleName + "." + apexBundleName + a.suffix
71}
72
Jingwen Chen2d37b642023-03-14 16:11:38 +000073// androidMkForFiles generates Make definitions for the contents of an
74// apexBundle (apexBundle#filesInfo). The filesInfo structure can either be
75// populated by Soong for unconverted APEXes, or Bazel in mixed mode. Use
76// apexFile#isBazelPrebuilt to differentiate.
Jooyung Han63dff462023-02-09 00:11:27 +000077func (a *apexBundle) androidMkForFiles(w io.Writer, apexBundleName, moduleDir string,
Jooyung Han07931c72020-09-11 17:19:20 +090078 apexAndroidMkData android.AndroidMkData) []string {
79
Jooyung Han63dff462023-02-09 00:11:27 +000080 // apexBundleName comes from the 'name' property or soong module.
81 // apexName comes from 'name' property of apex_manifest.
Jiyong Parkdb334862020-02-05 17:19:28 +090082 // An apex is installed to /system/apex/<apexBundleName> and is activated at /apex/<apexName>
83 // In many cases, the two names are the same, but could be different in general.
Jooyung Han63dff462023-02-09 00:11:27 +000084 // However, symbol files for apex files are installed under /apex/<apexBundleName> to avoid
85 // conflicts between two apexes with the same apexName.
Jiyong Parkdb334862020-02-05 17:19:28 +090086
Jiyong Park09d77522019-11-18 11:16:27 +090087 moduleNames := []string{}
Jiyong Park09d77522019-11-18 11:16:27 +090088 // To avoid creating duplicate build rules, run this function only when primaryApexType is true
89 // to install symbol files in $(PRODUCT_OUT}/apex.
Jooyung Haneec1b3f2023-06-20 16:25:59 +090090 if !a.primaryApexType {
Jiyong Park09d77522019-11-18 11:16:27 +090091 return moduleNames
92 }
93
94 for _, fi := range a.filesInfo {
Jiyong Parkc0ec6f92020-11-19 23:00:52 +090095 linkToSystemLib := a.linkToSystemLib && fi.transitiveDep && fi.availableToPlatform()
Jingwen Chen2d37b642023-03-14 16:11:38 +000096 moduleName := a.fullModuleName(apexBundleName, linkToSystemLib, &fi)
Jiyong Park7cd10e32020-01-14 09:22:18 +090097
Jiyong Park57621b22021-01-20 20:33:11 +090098 // This name will be added to LOCAL_REQUIRED_MODULES of the APEX. We need to be
99 // arch-specific otherwise we will end up installing both ABIs even when only
100 // either of the ABI is requested.
101 aName := moduleName
102 switch fi.multilib {
103 case "lib32":
104 aName = aName + ":32"
105 case "lib64":
106 aName = aName + ":64"
107 }
108 if !android.InList(aName, moduleNames) {
109 moduleNames = append(moduleNames, aName)
Jiyong Park7cd10e32020-01-14 09:22:18 +0900110 }
111
112 if linkToSystemLib {
113 // No need to copy the file since it's linked to the system file
114 continue
Jiyong Park09d77522019-11-18 11:16:27 +0900115 }
116
Sasha Smundak5c4729d2022-12-01 10:49:23 -0800117 fmt.Fprintln(w, "\ninclude $(CLEAR_VARS) # apex.apexBundle.files")
Jiyong Park1833cef2019-12-13 13:28:36 +0900118 if fi.moduleDir != "" {
119 fmt.Fprintln(w, "LOCAL_PATH :=", fi.moduleDir)
120 } else {
121 fmt.Fprintln(w, "LOCAL_PATH :=", moduleDir)
122 }
Jiyong Park7cd10e32020-01-14 09:22:18 +0900123 fmt.Fprintln(w, "LOCAL_MODULE :=", moduleName)
Jingwen Chen2d37b642023-03-14 16:11:38 +0000124
Anton Hansson1ee62c02020-06-30 11:51:53 +0100125 if fi.module != nil && fi.module.Owner() != "" {
126 fmt.Fprintln(w, "LOCAL_MODULE_OWNER :=", fi.module.Owner())
127 }
Jooyung Han63dff462023-02-09 00:11:27 +0000128 // /apex/<apexBundleName>/{lib|framework|...}
129 pathForSymbol := filepath.Join("$(PRODUCT_OUT)", "apex", apexBundleName, fi.installDir)
Jooyung Haneec1b3f2023-06-20 16:25:59 +0900130 modulePath := pathForSymbol
131 fmt.Fprintln(w, "LOCAL_MODULE_PATH :=", modulePath)
Jiyong Park19972c72020-01-28 20:05:29 +0900132
Jooyung Haneec1b3f2023-06-20 16:25:59 +0900133 // For non-flattend APEXes, the merged notice file is attached to the APEX itself.
134 // We don't need to have notice file for the individual modules in it. Otherwise,
135 // we will have duplicated notice entries.
136 fmt.Fprintln(w, "LOCAL_NO_NOTICE_FILE := true")
Colin Cross6340ea52021-11-04 12:01:18 -0700137 fmt.Fprintln(w, "LOCAL_SOONG_INSTALLED_MODULE :=", filepath.Join(modulePath, fi.stem()))
138 fmt.Fprintln(w, "LOCAL_SOONG_INSTALL_PAIRS :=", fi.builtFile.String()+":"+filepath.Join(modulePath, fi.stem()))
Jiyong Park09d77522019-11-18 11:16:27 +0900139 fmt.Fprintln(w, "LOCAL_PREBUILT_MODULE_FILE :=", fi.builtFile.String())
Jiyong Parkc0ec6f92020-11-19 23:00:52 +0900140 fmt.Fprintln(w, "LOCAL_MODULE_CLASS :=", fi.class.nameInMake())
Jiyong Park09d77522019-11-18 11:16:27 +0900141 if fi.module != nil {
Jingwen Chen2d37b642023-03-14 16:11:38 +0000142 // This apexFile's module comes from Soong
Jiyong Park09d77522019-11-18 11:16:27 +0900143 archStr := fi.module.Target().Arch.ArchType.String()
144 host := false
145 switch fi.module.Target().Os.Class {
146 case android.Host:
Jiyong Park1613e552020-09-14 19:43:17 +0900147 if fi.module.Target().HostCross {
148 if fi.module.Target().Arch.ArchType != android.Common {
149 fmt.Fprintln(w, "LOCAL_MODULE_HOST_CROSS_ARCH :=", archStr)
150 }
151 } else {
152 if fi.module.Target().Arch.ArchType != android.Common {
153 fmt.Fprintln(w, "LOCAL_MODULE_HOST_ARCH :=", archStr)
154 }
Jiyong Park09d77522019-11-18 11:16:27 +0900155 }
156 host = true
157 case android.Device:
158 if fi.module.Target().Arch.ArchType != android.Common {
159 fmt.Fprintln(w, "LOCAL_MODULE_TARGET_ARCH :=", archStr)
160 }
161 }
162 if host {
163 makeOs := fi.module.Target().Os.String()
Colin Crossc74ea4b2021-08-16 14:46:46 -0700164 if fi.module.Target().Os == android.Linux || fi.module.Target().Os == android.LinuxBionic || fi.module.Target().Os == android.LinuxMusl {
Jiyong Park09d77522019-11-18 11:16:27 +0900165 makeOs = "linux"
166 }
167 fmt.Fprintln(w, "LOCAL_MODULE_HOST_OS :=", makeOs)
168 fmt.Fprintln(w, "LOCAL_IS_HOST_MODULE := true")
169 }
Jingwen Chen2d37b642023-03-14 16:11:38 +0000170 } else if fi.isBazelPrebuilt && fi.arch != "" {
171 // This apexFile comes from Bazel
172 fmt.Fprintln(w, "LOCAL_MODULE_TARGET_ARCH :=", fi.arch)
Jiyong Park09d77522019-11-18 11:16:27 +0900173 }
Jiyong Park618922e2020-01-08 13:35:43 +0900174 if fi.jacocoReportClassesFile != nil {
175 fmt.Fprintln(w, "LOCAL_SOONG_JACOCO_REPORT_CLASSES_JAR :=", fi.jacocoReportClassesFile.String())
176 }
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700177 switch fi.class {
178 case javaSharedLib:
Jiyong Park09d77522019-11-18 11:16:27 +0900179 // soong_java_prebuilt.mk sets LOCAL_MODULE_SUFFIX := .jar Therefore
180 // we need to remove the suffix from LOCAL_MODULE_STEM, otherwise
181 // we will have foo.jar.jar
Jiyong Parkc0ec6f92020-11-19 23:00:52 +0900182 fmt.Fprintln(w, "LOCAL_MODULE_STEM :=", strings.TrimSuffix(fi.stem(), ".jar"))
Paul Duffin44b481b2020-06-17 16:59:43 +0100183 if javaModule, ok := fi.module.(java.ApexDependency); ok {
Jiyong Park9e83f0b2020-06-11 00:35:03 +0900184 fmt.Fprintln(w, "LOCAL_SOONG_CLASSES_JAR :=", javaModule.ImplementationAndResourcesJars()[0].String())
185 fmt.Fprintln(w, "LOCAL_SOONG_HEADER_JAR :=", javaModule.HeaderJars()[0].String())
186 } else {
187 fmt.Fprintln(w, "LOCAL_SOONG_CLASSES_JAR :=", fi.builtFile.String())
188 fmt.Fprintln(w, "LOCAL_SOONG_HEADER_JAR :=", fi.builtFile.String())
189 }
Jiyong Park09d77522019-11-18 11:16:27 +0900190 fmt.Fprintln(w, "LOCAL_SOONG_DEX_JAR :=", fi.builtFile.String())
191 fmt.Fprintln(w, "LOCAL_DEX_PREOPT := false")
192 fmt.Fprintln(w, "include $(BUILD_SYSTEM)/soong_java_prebuilt.mk")
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700193 case app:
Colin Cross503c1d02020-01-28 14:00:53 -0800194 fmt.Fprintln(w, "LOCAL_CERTIFICATE :=", fi.certificate.AndroidMkString())
Jiyong Park618922e2020-01-08 13:35:43 +0900195 // soong_app_prebuilt.mk sets LOCAL_MODULE_SUFFIX := .apk Therefore
196 // we need to remove the suffix from LOCAL_MODULE_STEM, otherwise
197 // we will have foo.apk.apk
Jiyong Parkc0ec6f92020-11-19 23:00:52 +0900198 fmt.Fprintln(w, "LOCAL_MODULE_STEM :=", strings.TrimSuffix(fi.stem(), ".apk"))
Colin Cross403cc152020-07-06 14:15:24 -0700199 if app, ok := fi.module.(*java.AndroidApp); ok {
Sasha Smundakdcb61292022-12-08 10:41:33 -0800200 android.AndroidMkEmitAssignList(w, "LOCAL_PREBUILT_COVERAGE_ARCHIVE", app.JniCoverageOutputs().Strings())
Colin Cross403cc152020-07-06 14:15:24 -0700201 if jniLibSymbols := app.JNISymbolsInstalls(modulePath); len(jniLibSymbols) > 0 {
202 fmt.Fprintln(w, "LOCAL_SOONG_JNI_LIBS_SYMBOLS :=", jniLibSymbols.String())
203 }
Jaewoong Jung87a33e72020-03-26 14:01:48 -0700204 }
Jiyong Park618922e2020-01-08 13:35:43 +0900205 fmt.Fprintln(w, "include $(BUILD_SYSTEM)/soong_app_prebuilt.mk")
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700206 case appSet:
207 as, ok := fi.module.(*java.AndroidAppSet)
208 if !ok {
209 panic(fmt.Sprintf("Expected %s to be AndroidAppSet", fi.module))
210 }
Colin Crossffbcd1d2021-11-12 12:19:42 -0800211 fmt.Fprintln(w, "LOCAL_APK_SET_INSTALL_FILE :=", as.PackedAdditionalOutputs().String())
Colin Cross4fb652d2020-07-09 19:05:35 -0700212 fmt.Fprintln(w, "LOCAL_APKCERTS_FILE :=", as.APKCertsFile().String())
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700213 fmt.Fprintln(w, "include $(BUILD_SYSTEM)/soong_android_app_set.mk")
214 case nativeSharedLib, nativeExecutable, nativeTest:
Jiyong Parkc0ec6f92020-11-19 23:00:52 +0900215 fmt.Fprintln(w, "LOCAL_MODULE_STEM :=", fi.stem())
Jingwen Chen2d37b642023-03-14 16:11:38 +0000216 if fi.isBazelPrebuilt {
217 fmt.Fprintln(w, "LOCAL_SOONG_UNSTRIPPED_BINARY :=", fi.unstrippedBuiltFile)
218 } else {
219 if ccMod, ok := fi.module.(*cc.Module); ok {
220 if ccMod.UnstrippedOutputFile() != nil {
221 fmt.Fprintln(w, "LOCAL_SOONG_UNSTRIPPED_BINARY :=", ccMod.UnstrippedOutputFile().String())
222 }
223 ccMod.AndroidMkWriteAdditionalDependenciesForSourceAbiDiff(w)
224 if ccMod.CoverageOutputFile().Valid() {
225 fmt.Fprintln(w, "LOCAL_PREBUILT_COVERAGE_ARCHIVE :=", ccMod.CoverageOutputFile().String())
226 }
227 } else if rustMod, ok := fi.module.(*rust.Module); ok {
228 if rustMod.UnstrippedOutputFile() != nil {
229 fmt.Fprintln(w, "LOCAL_SOONG_UNSTRIPPED_BINARY :=", rustMod.UnstrippedOutputFile().String())
230 }
Jiyong Parkc7a46882023-02-02 11:33:39 +0900231 }
Jiyong Park09d77522019-11-18 11:16:27 +0900232 }
Ivan Lozanod06cc742021-11-12 13:27:58 -0500233 fmt.Fprintln(w, "include $(BUILD_SYSTEM)/soong_cc_rust_prebuilt.mk")
Sasha Smundak18d98bc2020-05-27 16:36:07 -0700234 default:
Jiyong Parkc0ec6f92020-11-19 23:00:52 +0900235 fmt.Fprintln(w, "LOCAL_MODULE_STEM :=", fi.stem())
Jiyong Park09d77522019-11-18 11:16:27 +0900236 fmt.Fprintln(w, "include $(BUILD_PREBUILT)")
237 }
Jiyong Park31af2672020-02-11 09:36:25 +0900238
239 // m <module_name> will build <module_name>.<apex_name> as well.
Yo Chiange8128052020-07-23 20:09:18 +0800240 if fi.androidMkModuleName != moduleName && a.primaryApexType {
241 fmt.Fprintf(w, ".PHONY: %s\n", fi.androidMkModuleName)
242 fmt.Fprintf(w, "%s: %s\n", fi.androidMkModuleName, moduleName)
Jiyong Park31af2672020-02-11 09:36:25 +0900243 }
Jiyong Park09d77522019-11-18 11:16:27 +0900244 }
245 return moduleNames
246}
247
Jiakai Zhangd70dff72022-02-24 15:06:05 +0000248func (a *apexBundle) writeRequiredModules(w io.Writer, moduleNames []string) {
Jiyong Park7afd1072019-12-30 16:56:33 +0900249 var required []string
250 var targetRequired []string
251 var hostRequired []string
Jiyong Parkcacc4f32021-10-28 14:26:03 +0900252 required = append(required, a.RequiredModuleNames()...)
253 targetRequired = append(targetRequired, a.TargetRequiredModuleNames()...)
254 hostRequired = append(hostRequired, a.HostRequiredModuleNames()...)
Jiyong Park7afd1072019-12-30 16:56:33 +0900255 for _, fi := range a.filesInfo {
256 required = append(required, fi.requiredModuleNames...)
257 targetRequired = append(targetRequired, fi.targetRequiredModuleNames...)
258 hostRequired = append(hostRequired, fi.hostRequiredModuleNames...)
259 }
Jingwen Chen29743c82023-01-25 17:49:46 +0000260 android.AndroidMkEmitAssignList(w, "LOCAL_REQUIRED_MODULES", moduleNames, a.makeModulesToInstall, required)
Sasha Smundakdcb61292022-12-08 10:41:33 -0800261 android.AndroidMkEmitAssignList(w, "LOCAL_TARGET_REQUIRED_MODULES", targetRequired)
262 android.AndroidMkEmitAssignList(w, "LOCAL_HOST_REQUIRED_MODULES", hostRequired)
Jiyong Park7afd1072019-12-30 16:56:33 +0900263}
264
Jiyong Park09d77522019-11-18 11:16:27 +0900265func (a *apexBundle) androidMkForType() android.AndroidMkData {
266 return android.AndroidMkData{
267 Custom: func(w io.Writer, name, prefix, moduleDir string, data android.AndroidMkData) {
Diwas Sharmabb9202e2023-01-26 18:42:21 +0000268 moduleNames := []string{}
Jiyong Park09d77522019-11-18 11:16:27 +0900269 apexType := a.properties.ApexType
Diwas Sharmabb9202e2023-01-26 18:42:21 +0000270 if a.installable() {
Jooyung Han63dff462023-02-09 00:11:27 +0000271 moduleNames = a.androidMkForFiles(w, name, moduleDir, data)
Diwas Sharmabb9202e2023-01-26 18:42:21 +0000272 }
Jiyong Park09d77522019-11-18 11:16:27 +0900273
Jooyung Haneec1b3f2023-06-20 16:25:59 +0900274 fmt.Fprintln(w, "\ninclude $(CLEAR_VARS) # apex.apexBundle")
275 fmt.Fprintln(w, "LOCAL_PATH :=", moduleDir)
276 fmt.Fprintln(w, "LOCAL_MODULE :=", name+a.suffix)
277 data.Entries.WriteLicenseVariables(w)
278 fmt.Fprintln(w, "LOCAL_MODULE_CLASS := ETC") // do we need a new class?
279 fmt.Fprintln(w, "LOCAL_PREBUILT_MODULE_FILE :=", a.outputFile.String())
280 fmt.Fprintln(w, "LOCAL_MODULE_PATH :=", a.installDir.String())
281 stemSuffix := apexType.suffix()
282 if a.isCompressed {
283 stemSuffix = imageCapexSuffix
Jiyong Park09d77522019-11-18 11:16:27 +0900284 }
Jooyung Haneec1b3f2023-06-20 16:25:59 +0900285 fmt.Fprintln(w, "LOCAL_MODULE_STEM :=", name+stemSuffix)
286 fmt.Fprintln(w, "LOCAL_UNINSTALLABLE_MODULE :=", !a.installable())
287 if a.installable() {
288 fmt.Fprintln(w, "LOCAL_SOONG_INSTALLED_MODULE :=", a.installedFile.String())
289 fmt.Fprintln(w, "LOCAL_SOONG_INSTALL_PAIRS :=", a.outputFile.String()+":"+a.installedFile.String())
290 }
291
292 // Because apex writes .mk with Custom(), we need to write manually some common properties
293 // which are available via data.Entries
294 commonProperties := []string{
295 "LOCAL_FULL_INIT_RC", "LOCAL_FULL_VINTF_FRAGMENTS",
296 "LOCAL_PROPRIETARY_MODULE", "LOCAL_VENDOR_MODULE", "LOCAL_ODM_MODULE", "LOCAL_PRODUCT_MODULE", "LOCAL_SYSTEM_EXT_MODULE",
297 "LOCAL_MODULE_OWNER",
298 }
299 for _, name := range commonProperties {
300 if value, ok := data.Entries.EntryMap[name]; ok {
301 android.AndroidMkEmitAssignList(w, name, value)
302 }
303 }
304
305 android.AndroidMkEmitAssignList(w, "LOCAL_OVERRIDES_MODULES", a.overridableProperties.Overrides)
306 a.writeRequiredModules(w, moduleNames)
307
308 fmt.Fprintln(w, "include $(BUILD_PREBUILT)")
309
310 if apexType == imageApex {
311 fmt.Fprintln(w, "ALL_MODULES.$(my_register_name).BUNDLE :=", a.bundleModuleFile.String())
312 }
313 android.AndroidMkEmitAssignList(w, "ALL_MODULES.$(my_register_name).LINT_REPORTS", a.lintReports.Strings())
314
315 if a.installedFilesFile != nil {
316 goal := "checkbuild"
317 distFile := name + "-installed-files.txt"
318 fmt.Fprintln(w, ".PHONY:", goal)
319 fmt.Fprintf(w, "$(call dist-for-goals,%s,%s:%s)\n",
320 goal, a.installedFilesFile.String(), distFile)
321 fmt.Fprintf(w, "$(call declare-0p-target,%s)\n", a.installedFilesFile.String())
322 }
323 for _, dist := range data.Entries.GetDistForGoals(a) {
324 fmt.Fprintf(w, dist)
325 }
326
327 distCoverageFiles(w, "ndk_apis_usedby_apex", a.nativeApisUsedByModuleFile.String())
328 distCoverageFiles(w, "ndk_apis_backedby_apex", a.nativeApisBackedByModuleFile.String())
329 distCoverageFiles(w, "java_apis_used_by_apex", a.javaApisUsedByModuleFile.String())
Jiyong Park09d77522019-11-18 11:16:27 +0900330 }}
331}
sophiez02347372021-11-02 17:58:02 -0700332
333func distCoverageFiles(w io.Writer, dir string, distfile string) {
334 if distfile != "" {
335 goal := "apps_only"
336 fmt.Fprintf(w, "ifneq (,$(filter $(my_register_name),$(TARGET_BUILD_APPS)))\n"+
337 " $(call dist-for-goals,%s,%s:%s/$(notdir %s))\n"+
338 "endif\n", goal, distfile, dir, distfile)
339 }
340}