blob: 04f536f7fcbcaab899010a8dc79be7425d879edd [file] [log] [blame]
Colin Cross4d9c2d12016-07-29 12:48:20 -07001// Copyright 2016 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package cc
16
17import (
18 "fmt"
19 "path/filepath"
20 "strings"
21
Colin Cross4b963f82016-09-29 14:06:02 -070022 "github.com/google/blueprint/proptools"
23
Colin Cross4d9c2d12016-07-29 12:48:20 -070024 "android/soong/android"
Colin Crossb98c8b02016-07-29 13:44:28 -070025 "android/soong/cc/config"
Colin Cross4d9c2d12016-07-29 12:48:20 -070026)
27
28// This file contains the basic C/C++/assembly to .o compliation steps
29
30type BaseCompilerProperties struct {
31 // list of source files used to compile the C/C++ module. May be .c, .cpp, or .S files.
32 Srcs []string `android:"arch_variant"`
33
34 // list of source files that should not be used to build the C/C++ module.
35 // This is most useful in the arch/multilib variants to remove non-common files
36 Exclude_srcs []string `android:"arch_variant"`
37
38 // list of module-specific flags that will be used for C and C++ compiles.
39 Cflags []string `android:"arch_variant"`
40
41 // list of module-specific flags that will be used for C++ compiles
42 Cppflags []string `android:"arch_variant"`
43
44 // list of module-specific flags that will be used for C compiles
45 Conlyflags []string `android:"arch_variant"`
46
47 // list of module-specific flags that will be used for .S compiles
48 Asflags []string `android:"arch_variant"`
49
50 // list of module-specific flags that will be used for C and C++ compiles when
51 // compiling with clang
52 Clang_cflags []string `android:"arch_variant"`
53
54 // list of module-specific flags that will be used for .S compiles when
55 // compiling with clang
56 Clang_asflags []string `android:"arch_variant"`
57
58 // list of module-specific flags that will be used for .y and .yy compiles
59 Yaccflags []string
60
61 // the instruction set architecture to use to compile the C/C++
62 // module.
63 Instruction_set string `android:"arch_variant"`
64
65 // list of directories relative to the root of the source tree that will
66 // be added to the include path using -I.
67 // If possible, don't use this. If adding paths from the current directory use
68 // local_include_dirs, if adding paths from other modules use export_include_dirs in
69 // that module.
70 Include_dirs []string `android:"arch_variant"`
71
72 // list of directories relative to the Blueprints file that will
73 // be added to the include path using -I
74 Local_include_dirs []string `android:"arch_variant"`
75
76 // list of generated sources to compile. These are the names of gensrcs or
77 // genrule modules.
78 Generated_sources []string `android:"arch_variant"`
79
80 // list of generated headers to add to the include path. These are the names
81 // of genrule modules.
82 Generated_headers []string `android:"arch_variant"`
83
84 // pass -frtti instead of -fno-rtti
85 Rtti *bool
86
Colin Cross948f0cb2016-10-17 14:24:56 -070087 // if set to false, use -std=c++* instead of -std=gnu++*
88 Gnu_extensions *bool
89
Colin Cross4d9c2d12016-07-29 12:48:20 -070090 Debug, Release struct {
91 // list of module-specific flags that will be used for C and C++ compiles in debug or
92 // release builds
93 Cflags []string `android:"arch_variant"`
94 } `android:"arch_variant"`
95}
96
Colin Crossb916a382016-07-29 17:28:03 -070097func NewBaseCompiler() *baseCompiler {
98 return &baseCompiler{}
99}
100
Colin Cross4d9c2d12016-07-29 12:48:20 -0700101type baseCompiler struct {
102 Properties BaseCompilerProperties
Colin Cross0c461f12016-10-20 16:11:43 -0700103 Proto ProtoProperties
Colin Cross2f336352016-10-26 10:03:47 -0700104 deps android.Paths
Colin Cross4d9c2d12016-07-29 12:48:20 -0700105}
106
107var _ compiler = (*baseCompiler)(nil)
108
109func (compiler *baseCompiler) appendCflags(flags []string) {
110 compiler.Properties.Cflags = append(compiler.Properties.Cflags, flags...)
111}
112
113func (compiler *baseCompiler) appendAsflags(flags []string) {
114 compiler.Properties.Asflags = append(compiler.Properties.Asflags, flags...)
115}
116
Colin Cross42742b82016-08-01 13:20:05 -0700117func (compiler *baseCompiler) compilerProps() []interface{} {
Colin Cross0feb1692016-11-03 14:38:52 -0700118 return []interface{}{&compiler.Properties, &compiler.Proto}
Colin Cross4d9c2d12016-07-29 12:48:20 -0700119}
120
Colin Cross42742b82016-08-01 13:20:05 -0700121func (compiler *baseCompiler) compilerInit(ctx BaseModuleContext) {}
Colin Cross4d9c2d12016-07-29 12:48:20 -0700122
Colin Cross42742b82016-08-01 13:20:05 -0700123func (compiler *baseCompiler) compilerDeps(ctx BaseModuleContext, deps Deps) Deps {
Colin Cross4d9c2d12016-07-29 12:48:20 -0700124 deps.GeneratedSources = append(deps.GeneratedSources, compiler.Properties.Generated_sources...)
125 deps.GeneratedHeaders = append(deps.GeneratedHeaders, compiler.Properties.Generated_headers...)
126
Dan Willemsene1a3ce32016-11-02 20:44:08 -0700127 if compiler.hasSrcExt(".proto") {
Colin Cross0c461f12016-10-20 16:11:43 -0700128 deps = protoDeps(ctx, deps, &compiler.Proto)
129 }
130
Colin Cross4d9c2d12016-07-29 12:48:20 -0700131 return deps
132}
133
134// Create a Flags struct that collects the compile flags from global values,
135// per-target values, module type values, and per-module Blueprints properties
Colin Cross42742b82016-08-01 13:20:05 -0700136func (compiler *baseCompiler) compilerFlags(ctx ModuleContext, flags Flags) Flags {
Colin Crossb98c8b02016-07-29 13:44:28 -0700137 tc := ctx.toolchain()
Colin Cross4d9c2d12016-07-29 12:48:20 -0700138
139 CheckBadCompilerFlags(ctx, "cflags", compiler.Properties.Cflags)
140 CheckBadCompilerFlags(ctx, "cppflags", compiler.Properties.Cppflags)
141 CheckBadCompilerFlags(ctx, "conlyflags", compiler.Properties.Conlyflags)
142 CheckBadCompilerFlags(ctx, "asflags", compiler.Properties.Asflags)
143
Colin Cross4b963f82016-09-29 14:06:02 -0700144 esc := proptools.NinjaAndShellEscape
145
146 flags.CFlags = append(flags.CFlags, esc(compiler.Properties.Cflags)...)
147 flags.CppFlags = append(flags.CppFlags, esc(compiler.Properties.Cppflags)...)
148 flags.ConlyFlags = append(flags.ConlyFlags, esc(compiler.Properties.Conlyflags)...)
149 flags.AsFlags = append(flags.AsFlags, esc(compiler.Properties.Asflags)...)
Colin Cross91e90042016-12-02 17:13:24 -0800150 flags.YasmFlags = append(flags.YasmFlags, esc(compiler.Properties.Asflags)...)
Colin Cross4b963f82016-09-29 14:06:02 -0700151 flags.YaccFlags = append(flags.YaccFlags, esc(compiler.Properties.Yaccflags)...)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700152
153 // Include dir cflags
Colin Cross4d9c2d12016-07-29 12:48:20 -0700154 localIncludeDirs := android.PathsForModuleSrc(ctx, compiler.Properties.Local_include_dirs)
Dan Willemsen273af7f2016-11-03 15:53:42 -0700155 if len(localIncludeDirs) > 0 {
156 flags.GlobalFlags = append(flags.GlobalFlags, includeDirsToFlags(localIncludeDirs))
157 }
158 rootIncludeDirs := android.PathsForSource(ctx, compiler.Properties.Include_dirs)
159 if len(rootIncludeDirs) > 0 {
160 flags.GlobalFlags = append(flags.GlobalFlags, includeDirsToFlags(rootIncludeDirs))
161 }
Colin Cross4d9c2d12016-07-29 12:48:20 -0700162
163 if !ctx.noDefaultCompilerFlags() {
Dan Willemsend2ede872016-11-18 14:54:24 -0800164 if !(ctx.sdk() || ctx.vndk()) || ctx.Host() {
Colin Cross4d9c2d12016-07-29 12:48:20 -0700165 flags.GlobalFlags = append(flags.GlobalFlags,
Colin Crossb98c8b02016-07-29 13:44:28 -0700166 "${config.CommonGlobalIncludes}",
Colin Cross1cfd89a2016-09-15 09:30:46 -0700167 "${config.CommonGlobalSystemIncludes}",
Colin Crossb98c8b02016-07-29 13:44:28 -0700168 tc.IncludeFlags(),
169 "${config.CommonNativehelperInclude}")
Colin Cross4d9c2d12016-07-29 12:48:20 -0700170 }
171
Colin Cross0c461f12016-10-20 16:11:43 -0700172 flags.GlobalFlags = append(flags.GlobalFlags, "-I"+android.PathForModuleSrc(ctx).String())
Colin Cross4d9c2d12016-07-29 12:48:20 -0700173 }
174
Dan Willemsend2ede872016-11-18 14:54:24 -0800175 if ctx.sdk() || ctx.vndk() {
Colin Cross4d9c2d12016-07-29 12:48:20 -0700176 // The NDK headers are installed to a common sysroot. While a more
177 // typical Soong approach would be to only make the headers for the
178 // library you're using available, we're trying to emulate the NDK
179 // behavior here, and the NDK always has all the NDK headers available.
180 flags.GlobalFlags = append(flags.GlobalFlags,
181 "-isystem "+getCurrentIncludePath(ctx).String(),
Colin Crossb98c8b02016-07-29 13:44:28 -0700182 "-isystem "+getCurrentIncludePath(ctx).Join(ctx, tc.ClangTriple()).String())
Colin Cross4d9c2d12016-07-29 12:48:20 -0700183
184 // Traditionally this has come from android/api-level.h, but with the
185 // libc headers unified it must be set by the build system since we
186 // don't have per-API level copies of that header now.
Dan Albertebedf672016-11-08 15:06:22 -0800187 version := ctx.sdkVersion()
188 if version == "current" {
189 version = "__ANDROID_API_FUTURE__"
190 }
Colin Cross4d9c2d12016-07-29 12:48:20 -0700191 flags.GlobalFlags = append(flags.GlobalFlags,
Dan Albertebedf672016-11-08 15:06:22 -0800192 "-D__ANDROID_API__="+version)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700193
194 // Until the full NDK has been migrated to using ndk_headers, we still
195 // need to add the legacy sysroot includes to get the full set of
196 // headers.
197 legacyIncludes := fmt.Sprintf(
198 "prebuilts/ndk/current/platforms/android-%s/arch-%s/usr/include",
199 ctx.sdkVersion(), ctx.Arch().ArchType.String())
200 flags.GlobalFlags = append(flags.GlobalFlags, "-isystem "+legacyIncludes)
201 }
202
203 instructionSet := compiler.Properties.Instruction_set
204 if flags.RequiredInstructionSet != "" {
205 instructionSet = flags.RequiredInstructionSet
206 }
Colin Crossb98c8b02016-07-29 13:44:28 -0700207 instructionSetFlags, err := tc.InstructionSetFlags(instructionSet)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700208 if flags.Clang {
Colin Crossb98c8b02016-07-29 13:44:28 -0700209 instructionSetFlags, err = tc.ClangInstructionSetFlags(instructionSet)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700210 }
211 if err != nil {
212 ctx.ModuleErrorf("%s", err)
213 }
214
215 CheckBadCompilerFlags(ctx, "release.cflags", compiler.Properties.Release.Cflags)
216
217 // TODO: debug
Colin Cross4b963f82016-09-29 14:06:02 -0700218 flags.CFlags = append(flags.CFlags, esc(compiler.Properties.Release.Cflags)...)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700219
220 if flags.Clang {
221 CheckBadCompilerFlags(ctx, "clang_cflags", compiler.Properties.Clang_cflags)
222 CheckBadCompilerFlags(ctx, "clang_asflags", compiler.Properties.Clang_asflags)
223
Colin Crossb98c8b02016-07-29 13:44:28 -0700224 flags.CFlags = config.ClangFilterUnknownCflags(flags.CFlags)
Colin Cross4b963f82016-09-29 14:06:02 -0700225 flags.CFlags = append(flags.CFlags, esc(compiler.Properties.Clang_cflags)...)
226 flags.AsFlags = append(flags.AsFlags, esc(compiler.Properties.Clang_asflags)...)
Colin Crossb98c8b02016-07-29 13:44:28 -0700227 flags.CppFlags = config.ClangFilterUnknownCflags(flags.CppFlags)
228 flags.ConlyFlags = config.ClangFilterUnknownCflags(flags.ConlyFlags)
229 flags.LdFlags = config.ClangFilterUnknownCflags(flags.LdFlags)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700230
Colin Crossb98c8b02016-07-29 13:44:28 -0700231 target := "-target " + tc.ClangTriple()
Colin Cross4d9c2d12016-07-29 12:48:20 -0700232 var gccPrefix string
233 if !ctx.Darwin() {
Colin Crossb98c8b02016-07-29 13:44:28 -0700234 gccPrefix = "-B" + filepath.Join(tc.GccRoot(), tc.GccTriple(), "bin")
Colin Cross4d9c2d12016-07-29 12:48:20 -0700235 }
236
237 flags.CFlags = append(flags.CFlags, target, gccPrefix)
238 flags.AsFlags = append(flags.AsFlags, target, gccPrefix)
239 flags.LdFlags = append(flags.LdFlags, target, gccPrefix)
240 }
241
Colin Crossb98c8b02016-07-29 13:44:28 -0700242 hod := "Host"
Colin Cross4d9c2d12016-07-29 12:48:20 -0700243 if ctx.Os().Class == android.Device {
Colin Crossb98c8b02016-07-29 13:44:28 -0700244 hod = "Device"
Colin Cross4d9c2d12016-07-29 12:48:20 -0700245 }
246
247 if !ctx.noDefaultCompilerFlags() {
248 flags.GlobalFlags = append(flags.GlobalFlags, instructionSetFlags)
Colin Crossb6688262016-11-22 12:32:47 -0800249 flags.ConlyFlags = append([]string{"${config.CommonGlobalConlyflags}"}, flags.ConlyFlags...)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700250
251 if flags.Clang {
Colin Crossb98c8b02016-07-29 13:44:28 -0700252 flags.AsFlags = append(flags.AsFlags, tc.ClangAsflags())
Colin Crossb6688262016-11-22 12:32:47 -0800253 flags.CppFlags = append([]string{"${config.CommonClangGlobalCppflags}"}, flags.CppFlags...)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700254 flags.GlobalFlags = append(flags.GlobalFlags,
Colin Crossb98c8b02016-07-29 13:44:28 -0700255 tc.ClangCflags(),
256 "${config.CommonClangGlobalCflags}",
257 fmt.Sprintf("${config.%sClangGlobalCflags}", hod))
Colin Cross4d9c2d12016-07-29 12:48:20 -0700258 } else {
Colin Crossb6688262016-11-22 12:32:47 -0800259 flags.CppFlags = append([]string{"${config.CommonGlobalCppflags}"}, flags.CppFlags...)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700260 flags.GlobalFlags = append(flags.GlobalFlags,
Colin Crossb98c8b02016-07-29 13:44:28 -0700261 tc.Cflags(),
262 "${config.CommonGlobalCflags}",
263 fmt.Sprintf("${config.%sGlobalCflags}", hod))
Colin Cross4d9c2d12016-07-29 12:48:20 -0700264 }
265
266 if Bool(ctx.AConfig().ProductVariables.Brillo) {
267 flags.GlobalFlags = append(flags.GlobalFlags, "-D__BRILLO__")
268 }
269
270 if ctx.Device() {
271 if Bool(compiler.Properties.Rtti) {
272 flags.CppFlags = append(flags.CppFlags, "-frtti")
273 } else {
274 flags.CppFlags = append(flags.CppFlags, "-fno-rtti")
275 }
276 }
277
278 flags.AsFlags = append(flags.AsFlags, "-D__ASSEMBLY__")
279
280 if flags.Clang {
Colin Crossb98c8b02016-07-29 13:44:28 -0700281 flags.CppFlags = append(flags.CppFlags, tc.ClangCppflags())
Colin Cross4d9c2d12016-07-29 12:48:20 -0700282 } else {
Colin Crossb98c8b02016-07-29 13:44:28 -0700283 flags.CppFlags = append(flags.CppFlags, tc.Cppflags())
Colin Cross4d9c2d12016-07-29 12:48:20 -0700284 }
Colin Cross91e90042016-12-02 17:13:24 -0800285
286 flags.YasmFlags = append(flags.YasmFlags, tc.YasmFlags())
Colin Cross4d9c2d12016-07-29 12:48:20 -0700287 }
288
289 if flags.Clang {
Colin Crossb98c8b02016-07-29 13:44:28 -0700290 flags.GlobalFlags = append(flags.GlobalFlags, tc.ToolchainClangCflags())
Colin Cross4d9c2d12016-07-29 12:48:20 -0700291 } else {
Colin Crossb98c8b02016-07-29 13:44:28 -0700292 flags.GlobalFlags = append(flags.GlobalFlags, tc.ToolchainCflags())
Colin Cross4d9c2d12016-07-29 12:48:20 -0700293 }
294
295 if !ctx.sdk() {
Colin Cross6f6a4282016-10-17 14:19:06 -0700296 cStd := config.CStdVersion
297 cppStd := config.CppStdVersion
298
299 if !flags.Clang {
300 // GCC uses an invalid C++14 ABI (emits calls to
301 // __cxa_throw_bad_array_length, which is not a valid C++ RT ABI).
302 // http://b/25022512
303 cppStd = config.GccCppStdVersion
304 } else if ctx.Host() && !flags.Clang {
Colin Cross4d9c2d12016-07-29 12:48:20 -0700305 // The host GCC doesn't support C++14 (and is deprecated, so likely
306 // never will). Build these modules with C++11.
Colin Cross6f6a4282016-10-17 14:19:06 -0700307 cppStd = config.GccCppStdVersion
Colin Cross4d9c2d12016-07-29 12:48:20 -0700308 }
Colin Cross6f6a4282016-10-17 14:19:06 -0700309
Colin Cross948f0cb2016-10-17 14:24:56 -0700310 if compiler.Properties.Gnu_extensions != nil && *compiler.Properties.Gnu_extensions == false {
311 cStd = gnuToCReplacer.Replace(cStd)
312 cppStd = gnuToCReplacer.Replace(cppStd)
313 }
314
Colin Cross6f6a4282016-10-17 14:19:06 -0700315 flags.ConlyFlags = append([]string{"-std=" + cStd}, flags.ConlyFlags...)
316 flags.CppFlags = append([]string{"-std=" + cppStd}, flags.CppFlags...)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700317 }
318
319 // We can enforce some rules more strictly in the code we own. strict
320 // indicates if this is code that we can be stricter with. If we have
321 // rules that we want to apply to *our* code (but maybe can't for
322 // vendor/device specific things), we could extend this to be a ternary
323 // value.
324 strict := true
325 if strings.HasPrefix(android.PathForModuleSrc(ctx).String(), "external/") {
326 strict = false
327 }
328
329 // Can be used to make some annotations stricter for code we can fix
330 // (such as when we mark functions as deprecated).
331 if strict {
332 flags.CFlags = append(flags.CFlags, "-DANDROID_STRICT")
333 }
334
Dan Willemsene1a3ce32016-11-02 20:44:08 -0700335 if compiler.hasSrcExt(".proto") {
Colin Cross0c461f12016-10-20 16:11:43 -0700336 flags = protoFlags(ctx, flags, &compiler.Proto)
337 }
338
Dan Willemsene1a3ce32016-11-02 20:44:08 -0700339 if compiler.hasSrcExt(".y") || compiler.hasSrcExt(".yy") {
340 flags.GlobalFlags = append(flags.GlobalFlags,
341 "-I"+android.PathForModuleGen(ctx, "yacc", ctx.ModuleDir()).String())
342 }
343
Colin Cross4d9c2d12016-07-29 12:48:20 -0700344 return flags
345}
346
Dan Willemsene1a3ce32016-11-02 20:44:08 -0700347func (compiler *baseCompiler) hasSrcExt(ext string) bool {
Colin Cross0c461f12016-10-20 16:11:43 -0700348 for _, src := range compiler.Properties.Srcs {
Dan Willemsene1a3ce32016-11-02 20:44:08 -0700349 if filepath.Ext(src) == ext {
Colin Cross0c461f12016-10-20 16:11:43 -0700350 return true
351 }
352 }
353
354 return false
355}
356
Colin Cross948f0cb2016-10-17 14:24:56 -0700357var gnuToCReplacer = strings.NewReplacer("gnu", "c")
358
Colin Cross4d9c2d12016-07-29 12:48:20 -0700359func ndkPathDeps(ctx ModuleContext) android.Paths {
Dan Willemsend2ede872016-11-18 14:54:24 -0800360 if ctx.sdk() || ctx.vndk() {
Colin Cross4d9c2d12016-07-29 12:48:20 -0700361 // The NDK sysroot timestamp file depends on all the NDK sysroot files
362 // (headers and libraries).
363 return android.Paths{getNdkSysrootTimestampFile(ctx)}
364 }
365 return nil
366}
367
Dan Willemsen5cb580f2016-09-26 17:33:01 -0700368func (compiler *baseCompiler) compile(ctx ModuleContext, flags Flags, deps PathDeps) Objects {
Colin Cross4d9c2d12016-07-29 12:48:20 -0700369 pathDeps := deps.GeneratedHeaders
370 pathDeps = append(pathDeps, ndkPathDeps(ctx)...)
Colin Cross2f336352016-10-26 10:03:47 -0700371
372 srcs := ctx.ExpandSources(compiler.Properties.Srcs, compiler.Properties.Exclude_srcs)
373 srcs = append(srcs, deps.GeneratedSources...)
374
375 buildFlags := flagsToBuilderFlags(flags)
376
377 srcs, genDeps := genSources(ctx, srcs, buildFlags)
378
379 pathDeps = append(pathDeps, genDeps...)
380 pathDeps = append(pathDeps, flags.CFlagsDeps...)
381
382 compiler.deps = pathDeps
383
Colin Cross4d9c2d12016-07-29 12:48:20 -0700384 // Compile files listed in c.Properties.Srcs into objects
Dan Willemsen5cb580f2016-09-26 17:33:01 -0700385 objs := compileObjs(ctx, buildFlags, "", srcs, compiler.deps)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700386
387 if ctx.Failed() {
Dan Willemsen5cb580f2016-09-26 17:33:01 -0700388 return Objects{}
Colin Cross4d9c2d12016-07-29 12:48:20 -0700389 }
390
Dan Willemsen5cb580f2016-09-26 17:33:01 -0700391 return objs
Colin Cross4d9c2d12016-07-29 12:48:20 -0700392}
393
394// Compile a list of source files into objects a specified subdirectory
Colin Cross2f336352016-10-26 10:03:47 -0700395func compileObjs(ctx android.ModuleContext, flags builderFlags,
Dan Willemsen5cb580f2016-09-26 17:33:01 -0700396 subdir string, srcFiles, deps android.Paths) Objects {
Colin Cross4d9c2d12016-07-29 12:48:20 -0700397
Colin Cross2f336352016-10-26 10:03:47 -0700398 return TransformSourceToObj(ctx, subdir, srcFiles, flags, deps)
Colin Cross4d9c2d12016-07-29 12:48:20 -0700399}