Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 1 | // Copyright 2015 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 15 | package android |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 16 | |
| 17 | import ( |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 18 | "fmt" |
| 19 | "reflect" |
| 20 | "runtime" |
| 21 | "strings" |
Colin Cross | f6566ed | 2015-03-24 11:13:38 -0700 | [diff] [blame] | 22 | |
| 23 | "github.com/google/blueprint" |
| 24 | "github.com/google/blueprint/proptools" |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 25 | ) |
| 26 | |
| 27 | var ( |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 28 | archTypeList []ArchType |
| 29 | |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 30 | Arm = newArch("arm", "lib32") |
| 31 | Arm64 = newArch("arm64", "lib64") |
| 32 | Mips = newArch("mips", "lib32") |
| 33 | Mips64 = newArch("mips64", "lib64") |
| 34 | X86 = newArch("x86", "lib32") |
| 35 | X86_64 = newArch("x86_64", "lib64") |
Colin Cross | 2fe6687 | 2015-03-30 17:20:39 -0700 | [diff] [blame] | 36 | |
| 37 | Common = ArchType{ |
| 38 | Name: "common", |
| 39 | } |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 40 | ) |
| 41 | |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 42 | var archTypeMap = map[string]ArchType{ |
| 43 | "arm": Arm, |
| 44 | "arm64": Arm64, |
| 45 | "mips": Mips, |
Colin Cross | 3b336c2 | 2015-11-23 16:28:31 -0800 | [diff] [blame] | 46 | "mips64": Mips64, |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 47 | "x86": X86, |
| 48 | "x86_64": X86_64, |
| 49 | } |
| 50 | |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 51 | /* |
| 52 | Example blueprints file containing all variant property groups, with comment listing what type |
| 53 | of variants get properties in that group: |
| 54 | |
| 55 | module { |
| 56 | arch: { |
| 57 | arm: { |
| 58 | // Host or device variants with arm architecture |
| 59 | }, |
| 60 | arm64: { |
| 61 | // Host or device variants with arm64 architecture |
| 62 | }, |
| 63 | mips: { |
| 64 | // Host or device variants with mips architecture |
| 65 | }, |
| 66 | mips64: { |
| 67 | // Host or device variants with mips64 architecture |
| 68 | }, |
| 69 | x86: { |
| 70 | // Host or device variants with x86 architecture |
| 71 | }, |
| 72 | x86_64: { |
| 73 | // Host or device variants with x86_64 architecture |
| 74 | }, |
| 75 | }, |
| 76 | multilib: { |
| 77 | lib32: { |
| 78 | // Host or device variants for 32-bit architectures |
| 79 | }, |
| 80 | lib64: { |
| 81 | // Host or device variants for 64-bit architectures |
| 82 | }, |
| 83 | }, |
| 84 | target: { |
| 85 | android: { |
| 86 | // Device variants |
| 87 | }, |
| 88 | host: { |
| 89 | // Host variants |
| 90 | }, |
| 91 | linux: { |
| 92 | // Linux host variants |
| 93 | }, |
| 94 | darwin: { |
| 95 | // Darwin host variants |
| 96 | }, |
| 97 | windows: { |
| 98 | // Windows host variants |
| 99 | }, |
| 100 | not_windows: { |
| 101 | // Non-windows host variants |
| 102 | }, |
| 103 | }, |
| 104 | } |
| 105 | */ |
Colin Cross | 7d5136f | 2015-05-11 13:39:40 -0700 | [diff] [blame] | 106 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 107 | var archVariants = map[ArchType][]string{} |
| 108 | var archFeatures = map[ArchType][]string{} |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 109 | var archFeatureMap = map[ArchType]map[string][]string{} |
| 110 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 111 | func RegisterArchVariants(arch ArchType, variants ...string) { |
| 112 | checkCalledFromInit() |
| 113 | archVariants[arch] = append(archVariants[arch], variants...) |
| 114 | } |
| 115 | |
| 116 | func RegisterArchFeatures(arch ArchType, features ...string) { |
| 117 | checkCalledFromInit() |
| 118 | archFeatures[arch] = append(archFeatures[arch], features...) |
| 119 | } |
| 120 | |
| 121 | func RegisterArchVariantFeatures(arch ArchType, variant string, features ...string) { |
| 122 | checkCalledFromInit() |
| 123 | if variant != "" && !inList(variant, archVariants[arch]) { |
| 124 | panic(fmt.Errorf("Invalid variant %q for arch %q", variant, arch)) |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 125 | } |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 126 | |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 127 | for _, feature := range features { |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 128 | if !inList(feature, archFeatures[arch]) { |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 129 | panic(fmt.Errorf("Invalid feature %q for arch %q variant %q", feature, arch, variant)) |
| 130 | } |
| 131 | } |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 132 | |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 133 | if archFeatureMap[arch] == nil { |
| 134 | archFeatureMap[arch] = make(map[string][]string) |
| 135 | } |
| 136 | archFeatureMap[arch][variant] = features |
| 137 | } |
| 138 | |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 139 | // An Arch indicates a single CPU architecture. |
| 140 | type Arch struct { |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 141 | ArchType ArchType |
| 142 | ArchVariant string |
| 143 | CpuVariant string |
| 144 | Abi []string |
| 145 | ArchFeatures []string |
Dan Willemsen | 17f0526 | 2016-05-31 16:27:00 -0700 | [diff] [blame] | 146 | Native bool |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 147 | } |
| 148 | |
| 149 | func (a Arch) String() string { |
Colin Cross | d3ba039 | 2015-05-07 14:11:29 -0700 | [diff] [blame] | 150 | s := a.ArchType.String() |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 151 | if a.ArchVariant != "" { |
| 152 | s += "_" + a.ArchVariant |
| 153 | } |
| 154 | if a.CpuVariant != "" { |
| 155 | s += "_" + a.CpuVariant |
| 156 | } |
| 157 | return s |
| 158 | } |
| 159 | |
| 160 | type ArchType struct { |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 161 | Name string |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 162 | Field string |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 163 | Multilib string |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 164 | } |
| 165 | |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 166 | func newArch(name, multilib string) ArchType { |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 167 | archType := ArchType{ |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 168 | Name: name, |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 169 | Field: proptools.FieldNameForProperty(name), |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 170 | Multilib: multilib, |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 171 | } |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 172 | archTypeList = append(archTypeList, archType) |
| 173 | return archType |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 174 | } |
| 175 | |
| 176 | func (a ArchType) String() string { |
| 177 | return a.Name |
| 178 | } |
| 179 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 180 | var BuildOs = func() OsType { |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 181 | switch runtime.GOOS { |
| 182 | case "linux": |
| 183 | return Linux |
| 184 | case "darwin": |
| 185 | return Darwin |
| 186 | default: |
| 187 | panic(fmt.Sprintf("unsupported OS: %s", runtime.GOOS)) |
| 188 | } |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 189 | }() |
| 190 | |
| 191 | var ( |
Nan Zhang | db0b9a3 | 2017-02-27 10:12:13 -0800 | [diff] [blame^] | 192 | osTypeList []OsType |
| 193 | commonTargetMap = make(map[string]Target) |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 194 | |
Dan Willemsen | 00fcbde | 2016-11-17 00:25:59 -0800 | [diff] [blame] | 195 | NoOsType OsType |
| 196 | Linux = NewOsType("linux", Host, false) |
| 197 | Darwin = NewOsType("darwin", Host, false) |
| 198 | LinuxBionic = NewOsType("linux_bionic", Host, true) |
| 199 | Windows = NewOsType("windows", HostCross, true) |
| 200 | Android = NewOsType("android", Device, false) |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 201 | |
| 202 | osArchTypeMap = map[OsType][]ArchType{ |
Dan Willemsen | 00fcbde | 2016-11-17 00:25:59 -0800 | [diff] [blame] | 203 | Linux: []ArchType{X86, X86_64}, |
| 204 | LinuxBionic: []ArchType{X86_64}, |
| 205 | Darwin: []ArchType{X86, X86_64}, |
| 206 | Windows: []ArchType{X86, X86_64}, |
| 207 | Android: []ArchType{Arm, Arm64, Mips, Mips64, X86, X86_64}, |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 208 | } |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 209 | ) |
| 210 | |
| 211 | type OsType struct { |
| 212 | Name, Field string |
| 213 | Class OsClass |
Dan Willemsen | 0a37a2a | 2016-11-13 10:16:05 -0800 | [diff] [blame] | 214 | |
| 215 | DefaultDisabled bool |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 216 | } |
| 217 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 218 | type OsClass int |
| 219 | |
| 220 | const ( |
Dan Willemsen | 0e2d97b | 2016-11-28 17:50:06 -0800 | [diff] [blame] | 221 | Generic OsClass = iota |
| 222 | Device |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 223 | Host |
| 224 | HostCross |
| 225 | ) |
| 226 | |
| 227 | func (os OsType) String() string { |
| 228 | return os.Name |
Colin Cross | 54c7112 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 229 | } |
| 230 | |
Dan Willemsen | 0a37a2a | 2016-11-13 10:16:05 -0800 | [diff] [blame] | 231 | func NewOsType(name string, class OsClass, defDisabled bool) OsType { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 232 | os := OsType{ |
| 233 | Name: name, |
| 234 | Field: strings.Title(name), |
| 235 | Class: class, |
Dan Willemsen | 0a37a2a | 2016-11-13 10:16:05 -0800 | [diff] [blame] | 236 | |
| 237 | DefaultDisabled: defDisabled, |
Colin Cross | 54c7112 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 238 | } |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 239 | osTypeList = append(osTypeList, os) |
Nan Zhang | db0b9a3 | 2017-02-27 10:12:13 -0800 | [diff] [blame^] | 240 | |
| 241 | if _, found := commonTargetMap[name]; found { |
| 242 | panic(fmt.Errorf("Found Os type duplicate during OsType registration: %q", name)) |
| 243 | } else { |
| 244 | commonTargetMap[name] = Target{Os: os, Arch: Arch{ArchType: Common}} |
| 245 | } |
| 246 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 247 | return os |
| 248 | } |
| 249 | |
| 250 | func osByName(name string) OsType { |
| 251 | for _, os := range osTypeList { |
| 252 | if os.Name == name { |
| 253 | return os |
| 254 | } |
| 255 | } |
| 256 | |
| 257 | return NoOsType |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 258 | } |
| 259 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 260 | type Target struct { |
| 261 | Os OsType |
| 262 | Arch Arch |
Colin Cross | d3ba039 | 2015-05-07 14:11:29 -0700 | [diff] [blame] | 263 | } |
| 264 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 265 | func (target Target) String() string { |
| 266 | return target.Os.String() + "_" + target.Arch.String() |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 267 | } |
| 268 | |
Colin Cross | 1e676be | 2016-10-12 14:38:15 -0700 | [diff] [blame] | 269 | func archMutator(mctx BottomUpMutatorContext) { |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 270 | var module Module |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 271 | var ok bool |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 272 | if module, ok = mctx.Module().(Module); !ok { |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 273 | return |
| 274 | } |
| 275 | |
Dan Willemsen | 0b24c74 | 2016-10-04 15:13:37 -0700 | [diff] [blame] | 276 | if !module.base().ArchSpecific() { |
Colin Cross | b9db480 | 2016-06-03 01:50:47 +0000 | [diff] [blame] | 277 | return |
| 278 | } |
| 279 | |
Dan Willemsen | 0b24c74 | 2016-10-04 15:13:37 -0700 | [diff] [blame] | 280 | osClasses := module.base().OsClassSupported() |
| 281 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 282 | var moduleTargets []Target |
Colin Cross | 8b74d17 | 2016-09-13 09:59:14 -0700 | [diff] [blame] | 283 | primaryModules := make(map[int]bool) |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 284 | |
| 285 | for _, class := range osClasses { |
| 286 | targets := mctx.AConfig().Targets[class] |
| 287 | if len(targets) == 0 { |
| 288 | continue |
| 289 | } |
Colin Cross | 69617d3 | 2016-09-06 10:39:07 -0700 | [diff] [blame] | 290 | var multilib string |
| 291 | switch class { |
| 292 | case Device: |
| 293 | multilib = module.base().commonProperties.Target.Android.Compile_multilib |
| 294 | case Host, HostCross: |
| 295 | multilib = module.base().commonProperties.Target.Host.Compile_multilib |
| 296 | } |
| 297 | if multilib == "" { |
| 298 | multilib = module.base().commonProperties.Compile_multilib |
| 299 | } |
| 300 | if multilib == "" { |
| 301 | multilib = module.base().commonProperties.Default_multilib |
| 302 | } |
Colin Cross | 628a88c | 2016-09-13 15:15:51 -0700 | [diff] [blame] | 303 | var prefer32 bool |
| 304 | switch class { |
| 305 | case Device: |
Colin Cross | 8b74d17 | 2016-09-13 09:59:14 -0700 | [diff] [blame] | 306 | prefer32 = mctx.AConfig().DevicePrefer32BitExecutables() |
Colin Cross | 628a88c | 2016-09-13 15:15:51 -0700 | [diff] [blame] | 307 | case HostCross: |
| 308 | // Windows builds always prefer 32-bit |
| 309 | prefer32 = true |
Colin Cross | 8b74d17 | 2016-09-13 09:59:14 -0700 | [diff] [blame] | 310 | } |
| 311 | targets, err := decodeMultilib(multilib, targets, prefer32) |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 312 | if err != nil { |
| 313 | mctx.ModuleErrorf("%s", err.Error()) |
| 314 | } |
Colin Cross | 8b74d17 | 2016-09-13 09:59:14 -0700 | [diff] [blame] | 315 | if len(targets) > 0 { |
| 316 | primaryModules[len(moduleTargets)] = true |
| 317 | moduleTargets = append(moduleTargets, targets...) |
| 318 | } |
Colin Cross | b9db480 | 2016-06-03 01:50:47 +0000 | [diff] [blame] | 319 | } |
| 320 | |
Dan Willemsen | 3f32f03 | 2016-07-11 14:36:48 -0700 | [diff] [blame] | 321 | if len(moduleTargets) == 0 { |
| 322 | module.base().commonProperties.Enabled = boolPtr(false) |
| 323 | return |
| 324 | } |
| 325 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 326 | targetNames := make([]string, len(moduleTargets)) |
Colin Cross | b9db480 | 2016-06-03 01:50:47 +0000 | [diff] [blame] | 327 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 328 | for i, target := range moduleTargets { |
| 329 | targetNames[i] = target.String() |
| 330 | } |
| 331 | |
| 332 | modules := mctx.CreateVariations(targetNames...) |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 333 | for i, m := range modules { |
Colin Cross | 8b74d17 | 2016-09-13 09:59:14 -0700 | [diff] [blame] | 334 | m.(Module).base().SetTarget(moduleTargets[i], primaryModules[i]) |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 335 | m.(Module).base().setArchProperties(mctx) |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 336 | } |
| 337 | } |
| 338 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 339 | func filterArchStruct(prop reflect.Type) (reflect.Type, bool) { |
| 340 | var fields []reflect.StructField |
| 341 | |
| 342 | ptr := prop.Kind() == reflect.Ptr |
| 343 | if ptr { |
| 344 | prop = prop.Elem() |
| 345 | } |
| 346 | |
| 347 | for i := 0; i < prop.NumField(); i++ { |
| 348 | field := prop.Field(i) |
| 349 | if !proptools.HasTag(field, "android", "arch_variant") { |
| 350 | continue |
| 351 | } |
| 352 | |
| 353 | // The arch_variant field isn't necessary past this point |
| 354 | // Instead of wasting space, just remove it. Go also has a |
| 355 | // 16-bit limit on structure name length. The name is constructed |
| 356 | // based on the Go source representation of the structure, so |
| 357 | // the tag names count towards that length. |
| 358 | // |
| 359 | // TODO: handle the uncommon case of other tags being involved |
| 360 | if field.Tag == `android:"arch_variant"` { |
| 361 | field.Tag = "" |
| 362 | } |
| 363 | |
| 364 | // Recurse into structs |
| 365 | switch field.Type.Kind() { |
| 366 | case reflect.Struct: |
| 367 | var ok bool |
| 368 | field.Type, ok = filterArchStruct(field.Type) |
| 369 | if !ok { |
| 370 | continue |
| 371 | } |
| 372 | case reflect.Ptr: |
| 373 | if field.Type.Elem().Kind() == reflect.Struct { |
| 374 | nestedType, ok := filterArchStruct(field.Type.Elem()) |
| 375 | if !ok { |
| 376 | continue |
| 377 | } |
| 378 | field.Type = reflect.PtrTo(nestedType) |
| 379 | } |
| 380 | case reflect.Interface: |
| 381 | panic("Interfaces are not supported in arch_variant properties") |
| 382 | } |
| 383 | |
| 384 | fields = append(fields, field) |
| 385 | } |
| 386 | if len(fields) == 0 { |
| 387 | return nil, false |
| 388 | } |
| 389 | |
| 390 | ret := reflect.StructOf(fields) |
| 391 | if ptr { |
| 392 | ret = reflect.PtrTo(ret) |
| 393 | } |
| 394 | return ret, true |
| 395 | } |
| 396 | |
| 397 | func createArchType(props reflect.Type) reflect.Type { |
| 398 | props, ok := filterArchStruct(props) |
| 399 | if !ok { |
| 400 | return nil |
| 401 | } |
| 402 | |
| 403 | variantFields := func(names []string) []reflect.StructField { |
| 404 | ret := make([]reflect.StructField, len(names)) |
| 405 | |
| 406 | for i, name := range names { |
| 407 | ret[i].Name = name |
| 408 | ret[i].Type = props |
| 409 | } |
| 410 | |
| 411 | return ret |
| 412 | } |
| 413 | |
| 414 | archFields := make([]reflect.StructField, len(archTypeList)) |
| 415 | for i, arch := range archTypeList { |
| 416 | variants := []string{} |
| 417 | |
| 418 | for _, archVariant := range archVariants[arch] { |
Colin Cross | 0906f17 | 2017-04-26 14:00:43 -0700 | [diff] [blame] | 419 | archVariant := variantReplacer.Replace(archVariant) |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 420 | variants = append(variants, proptools.FieldNameForProperty(archVariant)) |
| 421 | } |
| 422 | for _, feature := range archFeatures[arch] { |
Colin Cross | 0906f17 | 2017-04-26 14:00:43 -0700 | [diff] [blame] | 423 | feature := variantReplacer.Replace(feature) |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 424 | variants = append(variants, proptools.FieldNameForProperty(feature)) |
| 425 | } |
| 426 | |
| 427 | fields := variantFields(variants) |
| 428 | |
| 429 | fields = append([]reflect.StructField{reflect.StructField{ |
| 430 | Name: "BlueprintEmbed", |
| 431 | Type: props, |
| 432 | Anonymous: true, |
| 433 | }}, fields...) |
| 434 | |
| 435 | archFields[i] = reflect.StructField{ |
| 436 | Name: arch.Field, |
| 437 | Type: reflect.StructOf(fields), |
| 438 | } |
| 439 | } |
| 440 | archType := reflect.StructOf(archFields) |
| 441 | |
| 442 | multilibType := reflect.StructOf(variantFields([]string{"Lib32", "Lib64"})) |
| 443 | |
| 444 | targets := []string{ |
| 445 | "Host", |
| 446 | "Android64", |
| 447 | "Android32", |
| 448 | "Not_windows", |
Colin Cross | bb2e2b7 | 2016-12-08 17:23:53 -0800 | [diff] [blame] | 449 | "Arm_on_x86", |
| 450 | "Arm_on_x86_64", |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 451 | } |
| 452 | for _, os := range osTypeList { |
| 453 | targets = append(targets, os.Field) |
| 454 | |
| 455 | for _, archType := range osArchTypeMap[os] { |
| 456 | targets = append(targets, os.Field+"_"+archType.Name) |
| 457 | } |
| 458 | } |
| 459 | |
| 460 | targetType := reflect.StructOf(variantFields(targets)) |
| 461 | return reflect.StructOf([]reflect.StructField{ |
| 462 | reflect.StructField{ |
| 463 | Name: "Arch", |
| 464 | Type: archType, |
| 465 | }, |
| 466 | reflect.StructField{ |
| 467 | Name: "Multilib", |
| 468 | Type: multilibType, |
| 469 | }, |
| 470 | reflect.StructField{ |
| 471 | Name: "Target", |
| 472 | Type: targetType, |
| 473 | }, |
| 474 | }) |
| 475 | } |
| 476 | |
| 477 | var archPropTypeMap OncePer |
| 478 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 479 | func InitArchModule(m Module, |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 480 | propertyStructs ...interface{}) (blueprint.Module, []interface{}) { |
| 481 | |
| 482 | base := m.base() |
| 483 | |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 484 | base.generalProperties = append(base.generalProperties, |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 485 | propertyStructs...) |
| 486 | |
| 487 | for _, properties := range base.generalProperties { |
| 488 | propertiesValue := reflect.ValueOf(properties) |
Colin Cross | 62496a0 | 2016-08-08 15:49:17 -0700 | [diff] [blame] | 489 | t := propertiesValue.Type() |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 490 | if propertiesValue.Kind() != reflect.Ptr { |
Colin Cross | ca860ac | 2016-01-04 14:34:37 -0800 | [diff] [blame] | 491 | panic(fmt.Errorf("properties must be a pointer to a struct, got %T", |
| 492 | propertiesValue.Interface())) |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 493 | } |
| 494 | |
| 495 | propertiesValue = propertiesValue.Elem() |
| 496 | if propertiesValue.Kind() != reflect.Struct { |
Colin Cross | ca860ac | 2016-01-04 14:34:37 -0800 | [diff] [blame] | 497 | panic(fmt.Errorf("properties must be a pointer to a struct, got %T", |
| 498 | propertiesValue.Interface())) |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 499 | } |
| 500 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 501 | archPropType := archPropTypeMap.Once(t, func() interface{} { |
| 502 | return createArchType(t) |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 503 | }) |
| 504 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 505 | if archPropType != nil { |
| 506 | base.archProperties = append(base.archProperties, reflect.New(archPropType.(reflect.Type)).Interface()) |
| 507 | } else { |
| 508 | base.archProperties = append(base.archProperties, nil) |
| 509 | } |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 510 | } |
| 511 | |
| 512 | var allProperties []interface{} |
| 513 | allProperties = append(allProperties, base.generalProperties...) |
| 514 | for _, asp := range base.archProperties { |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 515 | if asp != nil { |
| 516 | allProperties = append(allProperties, asp) |
| 517 | } |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 518 | } |
| 519 | |
Colin Cross | a120ec1 | 2016-08-19 16:07:38 -0700 | [diff] [blame] | 520 | base.customizableProperties = allProperties |
| 521 | |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 522 | return m, allProperties |
| 523 | } |
| 524 | |
Colin Cross | a716add | 2015-12-16 11:07:39 -0800 | [diff] [blame] | 525 | var variantReplacer = strings.NewReplacer("-", "_", ".", "_") |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 526 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 527 | func (a *ModuleBase) appendProperties(ctx BottomUpMutatorContext, |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 528 | dst interface{}, src reflect.Value, field, srcPrefix string) reflect.Value { |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 529 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 530 | src = src.FieldByName(field) |
| 531 | if !src.IsValid() { |
Colin Cross | eeabb89 | 2015-11-20 13:07:51 -0800 | [diff] [blame] | 532 | ctx.ModuleErrorf("field %q does not exist", srcPrefix) |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 533 | return src |
Colin Cross | 85a8897 | 2015-11-23 13:29:51 -0800 | [diff] [blame] | 534 | } |
| 535 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 536 | ret := src |
Colin Cross | 85a8897 | 2015-11-23 13:29:51 -0800 | [diff] [blame] | 537 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 538 | if src.Kind() == reflect.Struct { |
| 539 | src = src.FieldByName("BlueprintEmbed") |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 540 | } |
| 541 | |
Colin Cross | 6ee75b6 | 2016-05-05 15:57:15 -0700 | [diff] [blame] | 542 | order := func(property string, |
| 543 | dstField, srcField reflect.StructField, |
| 544 | dstValue, srcValue interface{}) (proptools.Order, error) { |
| 545 | if proptools.HasTag(dstField, "android", "variant_prepend") { |
| 546 | return proptools.Prepend, nil |
| 547 | } else { |
| 548 | return proptools.Append, nil |
| 549 | } |
| 550 | } |
| 551 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 552 | err := proptools.ExtendMatchingProperties([]interface{}{dst}, src.Interface(), nil, order) |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 553 | if err != nil { |
| 554 | if propertyErr, ok := err.(*proptools.ExtendPropertyError); ok { |
| 555 | ctx.PropertyErrorf(propertyErr.Property, "%s", propertyErr.Err.Error()) |
| 556 | } else { |
| 557 | panic(err) |
| 558 | } |
| 559 | } |
Colin Cross | 85a8897 | 2015-11-23 13:29:51 -0800 | [diff] [blame] | 560 | |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 561 | return ret |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 562 | } |
| 563 | |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 564 | // Rewrite the module's properties structs to contain arch-specific values. |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 565 | func (a *ModuleBase) setArchProperties(ctx BottomUpMutatorContext) { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 566 | arch := a.Arch() |
| 567 | os := a.Os() |
Colin Cross | d3ba039 | 2015-05-07 14:11:29 -0700 | [diff] [blame] | 568 | |
Colin Cross | 2fe6687 | 2015-03-30 17:20:39 -0700 | [diff] [blame] | 569 | if arch.ArchType == Common { |
| 570 | return |
| 571 | } |
| 572 | |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 573 | for i := range a.generalProperties { |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 574 | genProps := a.generalProperties[i] |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 575 | if a.archProperties[i] == nil { |
| 576 | continue |
| 577 | } |
| 578 | archProps := reflect.ValueOf(a.archProperties[i]).Elem() |
| 579 | |
| 580 | archProp := archProps.FieldByName("Arch") |
| 581 | multilibProp := archProps.FieldByName("Multilib") |
| 582 | targetProp := archProps.FieldByName("Target") |
| 583 | |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 584 | // Handle arch-specific properties in the form: |
Colin Cross | b05bff2 | 2015-04-30 15:08:04 -0700 | [diff] [blame] | 585 | // arch: { |
| 586 | // arm64: { |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 587 | // key: value, |
| 588 | // }, |
| 589 | // }, |
| 590 | t := arch.ArchType |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 591 | |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 592 | field := proptools.FieldNameForProperty(t.Name) |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 593 | prefix := "arch." + t.Name |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 594 | archStruct := a.appendProperties(ctx, genProps, archProp, field, prefix) |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 595 | |
| 596 | // Handle arch-variant-specific properties in the form: |
| 597 | // arch: { |
| 598 | // variant: { |
| 599 | // key: value, |
| 600 | // }, |
| 601 | // }, |
Colin Cross | a716add | 2015-12-16 11:07:39 -0800 | [diff] [blame] | 602 | v := variantReplacer.Replace(arch.ArchVariant) |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 603 | if v != "" { |
| 604 | field := proptools.FieldNameForProperty(v) |
Colin Cross | 85a8897 | 2015-11-23 13:29:51 -0800 | [diff] [blame] | 605 | prefix := "arch." + t.Name + "." + v |
| 606 | a.appendProperties(ctx, genProps, archStruct, field, prefix) |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 607 | } |
| 608 | |
| 609 | // Handle cpu-variant-specific properties in the form: |
| 610 | // arch: { |
| 611 | // variant: { |
| 612 | // key: value, |
| 613 | // }, |
| 614 | // }, |
Colin Cross | 0801633 | 2016-12-20 09:53:14 -0800 | [diff] [blame] | 615 | if arch.CpuVariant != arch.ArchVariant { |
| 616 | c := variantReplacer.Replace(arch.CpuVariant) |
| 617 | if c != "" { |
| 618 | field := proptools.FieldNameForProperty(c) |
| 619 | prefix := "arch." + t.Name + "." + c |
| 620 | a.appendProperties(ctx, genProps, archStruct, field, prefix) |
| 621 | } |
Colin Cross | ec19363 | 2015-07-06 17:49:43 -0700 | [diff] [blame] | 622 | } |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 623 | |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 624 | // Handle arch-feature-specific properties in the form: |
| 625 | // arch: { |
| 626 | // feature: { |
| 627 | // key: value, |
| 628 | // }, |
| 629 | // }, |
| 630 | for _, feature := range arch.ArchFeatures { |
| 631 | field := proptools.FieldNameForProperty(feature) |
Colin Cross | 85a8897 | 2015-11-23 13:29:51 -0800 | [diff] [blame] | 632 | prefix := "arch." + t.Name + "." + feature |
| 633 | a.appendProperties(ctx, genProps, archStruct, field, prefix) |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 634 | } |
| 635 | |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 636 | // Handle multilib-specific properties in the form: |
Colin Cross | b05bff2 | 2015-04-30 15:08:04 -0700 | [diff] [blame] | 637 | // multilib: { |
| 638 | // lib32: { |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 639 | // key: value, |
| 640 | // }, |
| 641 | // }, |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 642 | field = proptools.FieldNameForProperty(t.Multilib) |
| 643 | prefix = "multilib." + t.Multilib |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 644 | a.appendProperties(ctx, genProps, multilibProp, field, prefix) |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 645 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 646 | // Handle host-specific properties in the form: |
Colin Cross | b05bff2 | 2015-04-30 15:08:04 -0700 | [diff] [blame] | 647 | // target: { |
| 648 | // host: { |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 649 | // key: value, |
| 650 | // }, |
| 651 | // }, |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 652 | if os.Class == Host || os.Class == HostCross { |
| 653 | field = "Host" |
| 654 | prefix = "target.host" |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 655 | a.appendProperties(ctx, genProps, targetProp, field, prefix) |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 656 | } |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 657 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 658 | // Handle target OS properties in the form: |
Colin Cross | b05bff2 | 2015-04-30 15:08:04 -0700 | [diff] [blame] | 659 | // target: { |
| 660 | // linux: { |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 661 | // key: value, |
| 662 | // }, |
Colin Cross | b05bff2 | 2015-04-30 15:08:04 -0700 | [diff] [blame] | 663 | // not_windows: { |
| 664 | // key: value, |
| 665 | // }, |
| 666 | // linux_x86: { |
| 667 | // key: value, |
| 668 | // }, |
| 669 | // linux_arm: { |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 670 | // key: value, |
| 671 | // }, |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 672 | // android { |
| 673 | // key: value, |
| 674 | // }, |
| 675 | // android_arm { |
| 676 | // key: value, |
| 677 | // }, |
| 678 | // android_x86 { |
| 679 | // key: value, |
| 680 | // }, |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 681 | // }, |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 682 | // }, |
| 683 | field = os.Field |
| 684 | prefix = "target." + os.Name |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 685 | a.appendProperties(ctx, genProps, targetProp, field, prefix) |
Colin Cross | b9db480 | 2016-06-03 01:50:47 +0000 | [diff] [blame] | 686 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 687 | field = os.Field + "_" + t.Name |
| 688 | prefix = "target." + os.Name + "_" + t.Name |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 689 | a.appendProperties(ctx, genProps, targetProp, field, prefix) |
Colin Cross | b9db480 | 2016-06-03 01:50:47 +0000 | [diff] [blame] | 690 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 691 | if (os.Class == Host || os.Class == HostCross) && os != Windows { |
| 692 | field := "Not_windows" |
| 693 | prefix := "target.not_windows" |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 694 | a.appendProperties(ctx, genProps, targetProp, field, prefix) |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 695 | } |
| 696 | |
Colin Cross | f820941 | 2015-03-26 14:44:26 -0700 | [diff] [blame] | 697 | // Handle 64-bit device properties in the form: |
| 698 | // target { |
| 699 | // android64 { |
| 700 | // key: value, |
| 701 | // }, |
| 702 | // android32 { |
| 703 | // key: value, |
| 704 | // }, |
| 705 | // }, |
| 706 | // WARNING: this is probably not what you want to use in your blueprints file, it selects |
| 707 | // options for all targets on a device that supports 64-bit binaries, not just the targets |
| 708 | // that are being compiled for 64-bit. Its expected use case is binaries like linker and |
| 709 | // debuggerd that need to know when they are a 32-bit process running on a 64-bit device |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 710 | if os.Class == Device { |
| 711 | if ctx.AConfig().Android64() { |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 712 | field := "Android64" |
| 713 | prefix := "target.android64" |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 714 | a.appendProperties(ctx, genProps, targetProp, field, prefix) |
Colin Cross | f820941 | 2015-03-26 14:44:26 -0700 | [diff] [blame] | 715 | } else { |
Colin Cross | 06a931b | 2015-10-28 17:23:31 -0700 | [diff] [blame] | 716 | field := "Android32" |
| 717 | prefix := "target.android32" |
Dan Willemsen | b1957a5 | 2016-06-23 23:44:54 -0700 | [diff] [blame] | 718 | a.appendProperties(ctx, genProps, targetProp, field, prefix) |
Colin Cross | f820941 | 2015-03-26 14:44:26 -0700 | [diff] [blame] | 719 | } |
Colin Cross | bb2e2b7 | 2016-12-08 17:23:53 -0800 | [diff] [blame] | 720 | |
Colin Cross | 4247f0d | 2017-04-13 16:56:14 -0700 | [diff] [blame] | 721 | if arch.ArchType == X86 && (hasArmAbi(arch) || |
| 722 | hasArmAndroidArch(ctx.AConfig().Targets[Device])) { |
| 723 | field := "Arm_on_x86" |
| 724 | prefix := "target.arm_on_x86" |
| 725 | a.appendProperties(ctx, genProps, targetProp, field, prefix) |
| 726 | } |
| 727 | if arch.ArchType == X86_64 && (hasArmAbi(arch) || |
| 728 | hasArmAndroidArch(ctx.AConfig().Targets[Device])) { |
| 729 | field := "Arm_on_x86_64" |
| 730 | prefix := "target.arm_on_x86_64" |
| 731 | a.appendProperties(ctx, genProps, targetProp, field, prefix) |
| 732 | } |
Colin Cross | bb2e2b7 | 2016-12-08 17:23:53 -0800 | [diff] [blame] | 733 | } |
Colin Cross | 3f40fa4 | 2015-01-30 17:27:36 -0800 | [diff] [blame] | 734 | } |
| 735 | } |
| 736 | |
| 737 | func forEachInterface(v reflect.Value, f func(reflect.Value)) { |
| 738 | switch v.Kind() { |
| 739 | case reflect.Interface: |
| 740 | f(v) |
| 741 | case reflect.Struct: |
| 742 | for i := 0; i < v.NumField(); i++ { |
| 743 | forEachInterface(v.Field(i), f) |
| 744 | } |
| 745 | case reflect.Ptr: |
| 746 | forEachInterface(v.Elem(), f) |
| 747 | default: |
| 748 | panic(fmt.Errorf("Unsupported kind %s", v.Kind())) |
| 749 | } |
| 750 | } |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 751 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 752 | // Convert the arch product variables into a list of targets for each os class structs |
Colin Cross | 9272ade | 2016-08-17 15:24:12 -0700 | [diff] [blame] | 753 | func decodeTargetProductVariables(config *config) (map[OsClass][]Target, error) { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 754 | variables := config.ProductVariables |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 755 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 756 | targets := make(map[OsClass][]Target) |
| 757 | var targetErr error |
| 758 | |
| 759 | addTarget := func(os OsType, archName string, archVariant, cpuVariant *string, abi *[]string) { |
| 760 | if targetErr != nil { |
| 761 | return |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 762 | } |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 763 | |
| 764 | arch, err := decodeArch(archName, archVariant, cpuVariant, abi) |
| 765 | if err != nil { |
| 766 | targetErr = err |
| 767 | return |
| 768 | } |
| 769 | |
| 770 | targets[os.Class] = append(targets[os.Class], |
| 771 | Target{ |
| 772 | Os: os, |
| 773 | Arch: arch, |
| 774 | }) |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 775 | } |
| 776 | |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 777 | if variables.HostArch == nil { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 778 | return nil, fmt.Errorf("No host primary architecture set") |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 779 | } |
| 780 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 781 | addTarget(BuildOs, *variables.HostArch, nil, nil, nil) |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 782 | |
Colin Cross | eeabb89 | 2015-11-20 13:07:51 -0800 | [diff] [blame] | 783 | if variables.HostSecondaryArch != nil && *variables.HostSecondaryArch != "" { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 784 | addTarget(BuildOs, *variables.HostSecondaryArch, nil, nil, nil) |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 785 | } |
| 786 | |
Dan Willemsen | 01a405a | 2016-06-13 17:19:03 -0700 | [diff] [blame] | 787 | if config.Host_bionic != nil && *config.Host_bionic { |
| 788 | addTarget(LinuxBionic, "x86_64", nil, nil, nil) |
| 789 | } |
| 790 | |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 791 | if variables.CrossHost != nil && *variables.CrossHost != "" { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 792 | crossHostOs := osByName(*variables.CrossHost) |
| 793 | if crossHostOs == NoOsType { |
| 794 | return nil, fmt.Errorf("Unknown cross host OS %q", *variables.CrossHost) |
| 795 | } |
| 796 | |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 797 | if variables.CrossHostArch == nil || *variables.CrossHostArch == "" { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 798 | return nil, fmt.Errorf("No cross-host primary architecture set") |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 799 | } |
| 800 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 801 | addTarget(crossHostOs, *variables.CrossHostArch, nil, nil, nil) |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 802 | |
| 803 | if variables.CrossHostSecondaryArch != nil && *variables.CrossHostSecondaryArch != "" { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 804 | addTarget(crossHostOs, *variables.CrossHostSecondaryArch, nil, nil, nil) |
Dan Willemsen | 490fd49 | 2015-11-24 17:53:15 -0800 | [diff] [blame] | 805 | } |
| 806 | } |
| 807 | |
Dan Willemsen | 3f32f03 | 2016-07-11 14:36:48 -0700 | [diff] [blame] | 808 | if variables.DeviceArch != nil && *variables.DeviceArch != "" { |
| 809 | addTarget(Android, *variables.DeviceArch, variables.DeviceArchVariant, |
| 810 | variables.DeviceCpuVariant, variables.DeviceAbi) |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 811 | |
Dan Willemsen | 3f32f03 | 2016-07-11 14:36:48 -0700 | [diff] [blame] | 812 | if variables.DeviceSecondaryArch != nil && *variables.DeviceSecondaryArch != "" { |
| 813 | addTarget(Android, *variables.DeviceSecondaryArch, |
| 814 | variables.DeviceSecondaryArchVariant, variables.DeviceSecondaryCpuVariant, |
| 815 | variables.DeviceSecondaryAbi) |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 816 | |
Dan Willemsen | 3f32f03 | 2016-07-11 14:36:48 -0700 | [diff] [blame] | 817 | deviceArches := targets[Device] |
| 818 | if deviceArches[0].Arch.ArchType.Multilib == deviceArches[1].Arch.ArchType.Multilib { |
| 819 | deviceArches[1].Arch.Native = false |
| 820 | } |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 821 | } |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 822 | } |
| 823 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 824 | if targetErr != nil { |
| 825 | return nil, targetErr |
| 826 | } |
| 827 | |
| 828 | return targets, nil |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 829 | } |
| 830 | |
Colin Cross | bb2e2b7 | 2016-12-08 17:23:53 -0800 | [diff] [blame] | 831 | // hasArmAbi returns true if arch has at least one arm ABI |
| 832 | func hasArmAbi(arch Arch) bool { |
| 833 | for _, abi := range arch.Abi { |
| 834 | if strings.HasPrefix(abi, "arm") { |
| 835 | return true |
| 836 | } |
| 837 | } |
| 838 | return false |
| 839 | } |
| 840 | |
Colin Cross | 4247f0d | 2017-04-13 16:56:14 -0700 | [diff] [blame] | 841 | // hasArmArch returns true if targets has at least arm Android arch |
| 842 | func hasArmAndroidArch(targets []Target) bool { |
| 843 | for _, target := range targets { |
| 844 | if target.Os == Android && target.Arch.ArchType == Arm { |
| 845 | return true |
| 846 | } |
| 847 | } |
| 848 | return false |
| 849 | } |
| 850 | |
Dan Albert | 4098deb | 2016-10-19 14:04:41 -0700 | [diff] [blame] | 851 | type archConfig struct { |
| 852 | arch string |
| 853 | archVariant string |
| 854 | cpuVariant string |
| 855 | abi []string |
| 856 | } |
| 857 | |
| 858 | func getMegaDeviceConfig() []archConfig { |
| 859 | return []archConfig{ |
Dan Willemsen | 110a89d | 2016-01-14 15:17:19 -0800 | [diff] [blame] | 860 | // armv5 is only used for unbundled apps |
| 861 | //{"arm", "armv5te", "", []string{"armeabi"}}, |
| 862 | {"arm", "armv7-a", "generic", []string{"armeabi-v7a"}}, |
| 863 | {"arm", "armv7-a-neon", "generic", []string{"armeabi-v7a"}}, |
Dan Willemsen | 322acaf | 2016-01-12 23:07:05 -0800 | [diff] [blame] | 864 | {"arm", "armv7-a-neon", "cortex-a7", []string{"armeabi-v7a"}}, |
| 865 | {"arm", "armv7-a-neon", "cortex-a8", []string{"armeabi-v7a"}}, |
Dan Willemsen | 110a89d | 2016-01-14 15:17:19 -0800 | [diff] [blame] | 866 | {"arm", "armv7-a-neon", "cortex-a9", []string{"armeabi-v7a"}}, |
Dan Willemsen | 322acaf | 2016-01-12 23:07:05 -0800 | [diff] [blame] | 867 | {"arm", "armv7-a-neon", "cortex-a15", []string{"armeabi-v7a"}}, |
| 868 | {"arm", "armv7-a-neon", "cortex-a53", []string{"armeabi-v7a"}}, |
| 869 | {"arm", "armv7-a-neon", "cortex-a53.a57", []string{"armeabi-v7a"}}, |
| 870 | {"arm", "armv7-a-neon", "denver", []string{"armeabi-v7a"}}, |
| 871 | {"arm", "armv7-a-neon", "krait", []string{"armeabi-v7a"}}, |
Alex Naidis | ae4fc18 | 2016-08-20 00:14:56 +0200 | [diff] [blame] | 872 | {"arm", "armv7-a-neon", "kryo", []string{"armeabi-v7a"}}, |
Dan Willemsen | 110a89d | 2016-01-14 15:17:19 -0800 | [diff] [blame] | 873 | {"arm64", "armv8-a", "cortex-a53", []string{"arm64-v8a"}}, |
| 874 | {"arm64", "armv8-a", "denver64", []string{"arm64-v8a"}}, |
Alex Naidis | ac01ff5 | 2016-08-30 15:56:33 +0200 | [diff] [blame] | 875 | {"arm64", "armv8-a", "kryo", []string{"arm64-v8a"}}, |
Dan Willemsen | 468cc31 | 2016-01-13 23:25:19 -0800 | [diff] [blame] | 876 | {"mips", "mips32-fp", "", []string{"mips"}}, |
| 877 | {"mips", "mips32r2-fp", "", []string{"mips"}}, |
| 878 | {"mips", "mips32r2-fp-xburst", "", []string{"mips"}}, |
Dan Willemsen | 65fb981 | 2016-07-19 21:37:28 -0700 | [diff] [blame] | 879 | //{"mips", "mips32r6", "", []string{"mips"}}, |
Colin Cross | 1837b80 | 2017-04-26 19:10:34 -0700 | [diff] [blame] | 880 | {"mips", "mips32r2dsp-fp", "", []string{"mips"}}, |
| 881 | {"mips", "mips32r2dspr2-fp", "", []string{"mips"}}, |
Dan Willemsen | 322acaf | 2016-01-12 23:07:05 -0800 | [diff] [blame] | 882 | // mips64r2 is mismatching 64r2 and 64r6 libraries during linking to libgcc |
| 883 | //{"mips64", "mips64r2", "", []string{"mips64"}}, |
| 884 | {"mips64", "mips64r6", "", []string{"mips64"}}, |
| 885 | {"x86", "", "", []string{"x86"}}, |
| 886 | {"x86", "atom", "", []string{"x86"}}, |
| 887 | {"x86", "haswell", "", []string{"x86"}}, |
| 888 | {"x86", "ivybridge", "", []string{"x86"}}, |
| 889 | {"x86", "sandybridge", "", []string{"x86"}}, |
| 890 | {"x86", "silvermont", "", []string{"x86"}}, |
Dan Willemsen | 8a35405 | 2016-05-10 14:30:51 -0700 | [diff] [blame] | 891 | {"x86", "x86_64", "", []string{"x86"}}, |
Dan Willemsen | 322acaf | 2016-01-12 23:07:05 -0800 | [diff] [blame] | 892 | {"x86_64", "", "", []string{"x86_64"}}, |
| 893 | {"x86_64", "haswell", "", []string{"x86_64"}}, |
| 894 | {"x86_64", "ivybridge", "", []string{"x86_64"}}, |
| 895 | {"x86_64", "sandybridge", "", []string{"x86_64"}}, |
| 896 | {"x86_64", "silvermont", "", []string{"x86_64"}}, |
| 897 | } |
Dan Albert | 4098deb | 2016-10-19 14:04:41 -0700 | [diff] [blame] | 898 | } |
Dan Willemsen | 322acaf | 2016-01-12 23:07:05 -0800 | [diff] [blame] | 899 | |
Dan Albert | 4098deb | 2016-10-19 14:04:41 -0700 | [diff] [blame] | 900 | func getNdkAbisConfig() []archConfig { |
| 901 | return []archConfig{ |
| 902 | {"arm", "armv5te", "", []string{"armeabi"}}, |
| 903 | {"arm64", "armv8-a", "", []string{"arm64-v8a"}}, |
| 904 | {"mips", "mips32-fp", "", []string{"mips"}}, |
| 905 | {"mips64", "mips64r6", "", []string{"mips64"}}, |
| 906 | {"x86", "", "", []string{"x86"}}, |
| 907 | {"x86_64", "", "", []string{"x86_64"}}, |
| 908 | } |
| 909 | } |
| 910 | |
| 911 | func decodeArchSettings(archConfigs []archConfig) ([]Target, error) { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 912 | var ret []Target |
Dan Willemsen | 322acaf | 2016-01-12 23:07:05 -0800 | [diff] [blame] | 913 | |
Dan Albert | 4098deb | 2016-10-19 14:04:41 -0700 | [diff] [blame] | 914 | for _, config := range archConfigs { |
Dan Willemsen | 322acaf | 2016-01-12 23:07:05 -0800 | [diff] [blame] | 915 | arch, err := decodeArch(config.arch, &config.archVariant, |
| 916 | &config.cpuVariant, &config.abi) |
| 917 | if err != nil { |
| 918 | return nil, err |
| 919 | } |
Dan Willemsen | 17f0526 | 2016-05-31 16:27:00 -0700 | [diff] [blame] | 920 | arch.Native = false |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 921 | ret = append(ret, Target{ |
| 922 | Os: Android, |
| 923 | Arch: arch, |
| 924 | }) |
Dan Willemsen | 322acaf | 2016-01-12 23:07:05 -0800 | [diff] [blame] | 925 | } |
| 926 | |
| 927 | return ret, nil |
| 928 | } |
| 929 | |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 930 | // Convert a set of strings from product variables into a single Arch struct |
| 931 | func decodeArch(arch string, archVariant, cpuVariant *string, abi *[]string) (Arch, error) { |
| 932 | stringPtr := func(p *string) string { |
| 933 | if p != nil { |
| 934 | return *p |
| 935 | } |
| 936 | return "" |
| 937 | } |
| 938 | |
| 939 | slicePtr := func(p *[]string) []string { |
| 940 | if p != nil { |
| 941 | return *p |
| 942 | } |
| 943 | return nil |
| 944 | } |
| 945 | |
Colin Cross | eeabb89 | 2015-11-20 13:07:51 -0800 | [diff] [blame] | 946 | archType, ok := archTypeMap[arch] |
| 947 | if !ok { |
| 948 | return Arch{}, fmt.Errorf("unknown arch %q", arch) |
| 949 | } |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 950 | |
Colin Cross | eeabb89 | 2015-11-20 13:07:51 -0800 | [diff] [blame] | 951 | a := Arch{ |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 952 | ArchType: archType, |
| 953 | ArchVariant: stringPtr(archVariant), |
| 954 | CpuVariant: stringPtr(cpuVariant), |
| 955 | Abi: slicePtr(abi), |
Dan Willemsen | 17f0526 | 2016-05-31 16:27:00 -0700 | [diff] [blame] | 956 | Native: true, |
Colin Cross | eeabb89 | 2015-11-20 13:07:51 -0800 | [diff] [blame] | 957 | } |
| 958 | |
| 959 | if a.ArchVariant == a.ArchType.Name || a.ArchVariant == "generic" { |
| 960 | a.ArchVariant = "" |
| 961 | } |
| 962 | |
| 963 | if a.CpuVariant == a.ArchType.Name || a.CpuVariant == "generic" { |
| 964 | a.CpuVariant = "" |
| 965 | } |
| 966 | |
| 967 | for i := 0; i < len(a.Abi); i++ { |
| 968 | if a.Abi[i] == "" { |
| 969 | a.Abi = append(a.Abi[:i], a.Abi[i+1:]...) |
| 970 | i-- |
| 971 | } |
| 972 | } |
| 973 | |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 974 | if featureMap, ok := archFeatureMap[archType]; ok { |
Dan Willemsen | b485099 | 2016-05-06 17:21:20 -0700 | [diff] [blame] | 975 | a.ArchFeatures = featureMap[a.ArchVariant] |
Colin Cross | c5c24ad | 2015-11-20 15:35:00 -0800 | [diff] [blame] | 976 | } |
| 977 | |
Colin Cross | eeabb89 | 2015-11-20 13:07:51 -0800 | [diff] [blame] | 978 | return a, nil |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 979 | } |
| 980 | |
Colin Cross | 69617d3 | 2016-09-06 10:39:07 -0700 | [diff] [blame] | 981 | func filterMultilibTargets(targets []Target, multilib string) []Target { |
| 982 | var ret []Target |
| 983 | for _, t := range targets { |
| 984 | if t.Arch.ArchType.Multilib == multilib { |
| 985 | ret = append(ret, t) |
| 986 | } |
| 987 | } |
| 988 | return ret |
| 989 | } |
| 990 | |
Nan Zhang | db0b9a3 | 2017-02-27 10:12:13 -0800 | [diff] [blame^] | 991 | func getCommonTargets(targets []Target) []Target { |
| 992 | var ret []Target |
| 993 | set := make(map[string]bool) |
| 994 | |
| 995 | for _, t := range targets { |
| 996 | if _, found := set[t.Os.String()]; !found { |
| 997 | set[t.Os.String()] = true |
| 998 | ret = append(ret, commonTargetMap[t.Os.String()]) |
| 999 | } |
| 1000 | } |
| 1001 | |
| 1002 | return ret |
| 1003 | } |
| 1004 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 1005 | // Use the module multilib setting to select one or more targets from a target list |
Colin Cross | 8b74d17 | 2016-09-13 09:59:14 -0700 | [diff] [blame] | 1006 | func decodeMultilib(multilib string, targets []Target, prefer32 bool) ([]Target, error) { |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 1007 | buildTargets := []Target{} |
Colin Cross | 8b74d17 | 2016-09-13 09:59:14 -0700 | [diff] [blame] | 1008 | if multilib == "first" { |
| 1009 | if prefer32 { |
| 1010 | multilib = "prefer32" |
| 1011 | } else { |
| 1012 | multilib = "prefer64" |
| 1013 | } |
| 1014 | } |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 1015 | switch multilib { |
| 1016 | case "common": |
Nan Zhang | db0b9a3 | 2017-02-27 10:12:13 -0800 | [diff] [blame^] | 1017 | buildTargets = append(buildTargets, getCommonTargets(targets)...) |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 1018 | case "both": |
Colin Cross | 8b74d17 | 2016-09-13 09:59:14 -0700 | [diff] [blame] | 1019 | if prefer32 { |
| 1020 | buildTargets = append(buildTargets, filterMultilibTargets(targets, "lib32")...) |
| 1021 | buildTargets = append(buildTargets, filterMultilibTargets(targets, "lib64")...) |
| 1022 | } else { |
| 1023 | buildTargets = append(buildTargets, filterMultilibTargets(targets, "lib64")...) |
| 1024 | buildTargets = append(buildTargets, filterMultilibTargets(targets, "lib32")...) |
| 1025 | } |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 1026 | case "32": |
Colin Cross | 69617d3 | 2016-09-06 10:39:07 -0700 | [diff] [blame] | 1027 | buildTargets = filterMultilibTargets(targets, "lib32") |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 1028 | case "64": |
Colin Cross | 69617d3 | 2016-09-06 10:39:07 -0700 | [diff] [blame] | 1029 | buildTargets = filterMultilibTargets(targets, "lib64") |
| 1030 | case "prefer32": |
| 1031 | buildTargets = filterMultilibTargets(targets, "lib32") |
| 1032 | if len(buildTargets) == 0 { |
| 1033 | buildTargets = filterMultilibTargets(targets, "lib64") |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 1034 | } |
Colin Cross | 8b74d17 | 2016-09-13 09:59:14 -0700 | [diff] [blame] | 1035 | case "prefer64": |
| 1036 | buildTargets = filterMultilibTargets(targets, "lib64") |
| 1037 | if len(buildTargets) == 0 { |
| 1038 | buildTargets = filterMultilibTargets(targets, "lib32") |
| 1039 | } |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 1040 | default: |
Colin Cross | 69617d3 | 2016-09-06 10:39:07 -0700 | [diff] [blame] | 1041 | return nil, fmt.Errorf(`compile_multilib must be "both", "first", "32", "64", or "prefer32" found %q`, |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 1042 | multilib) |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 1043 | } |
| 1044 | |
Colin Cross | a1ad8d1 | 2016-06-01 17:09:44 -0700 | [diff] [blame] | 1045 | return buildTargets, nil |
Colin Cross | 4225f65 | 2015-09-17 14:33:42 -0700 | [diff] [blame] | 1046 | } |