Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 1 | // Copyright 2019 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package java |
| 16 | |
| 17 | import ( |
| 18 | "path/filepath" |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 19 | "sort" |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 20 | "strings" |
| 21 | |
| 22 | "android/soong/android" |
| 23 | "android/soong/dexpreopt" |
| 24 | |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 25 | "github.com/google/blueprint/proptools" |
| 26 | ) |
| 27 | |
Paul Duffin | 1ab6186 | 2021-01-20 17:44:53 +0000 | [diff] [blame] | 28 | // ================================================================================================= |
| 29 | // WIP - see http://b/177892522 for details |
| 30 | // |
| 31 | // The build support for boot images is currently being migrated away from singleton to modules so |
| 32 | // the documentation may not be strictly accurate. Rather than update the documentation at every |
| 33 | // step which will create a lot of churn the changes that have been made will be listed here and the |
| 34 | // documentation will be updated once it is closer to the final result. |
| 35 | // |
| 36 | // Changes: |
| 37 | // 1) dex_bootjars is now a singleton module and not a plain singleton. |
Paul Duffin | 3451e16 | 2021-01-20 15:16:56 +0000 | [diff] [blame] | 38 | // 2) Boot images are now represented by the boot_image module type. |
| 39 | // 3) The art boot image is called "art-boot-image", the framework boot image is called |
| 40 | // "framework-boot-image". |
| 41 | // 4) They are defined in art/build/boot/Android.bp and frameworks/base/boot/Android.bp |
| 42 | // respectively. |
| 43 | // 5) Each boot_image retrieves the appropriate boot image configuration from the map returned by |
| 44 | // genBootImageConfigs() using the image_name specified in the boot_image module. |
Paul Duffin | 1ab6186 | 2021-01-20 17:44:53 +0000 | [diff] [blame] | 45 | // ================================================================================================= |
| 46 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 47 | // This comment describes: |
| 48 | // 1. ART boot images in general (their types, structure, file layout, etc.) |
| 49 | // 2. build system support for boot images |
| 50 | // |
| 51 | // 1. ART boot images |
| 52 | // ------------------ |
| 53 | // |
| 54 | // A boot image in ART is a set of files that contain AOT-compiled native code and a heap snapshot |
| 55 | // of AOT-initialized classes for the bootclasspath Java libraries. A boot image is compiled from a |
| 56 | // set of DEX jars by the dex2oat compiler. A boot image is used for two purposes: 1) it is |
| 57 | // installed on device and loaded at runtime, and 2) other Java libraries and apps are compiled |
| 58 | // against it (compilation may take place either on host, known as "dexpreopt", or on device, known |
| 59 | // as "dexopt"). |
| 60 | // |
| 61 | // A boot image is not a single file, but a collection of interrelated files. Each boot image has a |
| 62 | // number of components that correspond to the Java libraries that constitute it. For each component |
| 63 | // there are multiple files: |
| 64 | // - *.oat or *.odex file with native code (architecture-specific, one per instruction set) |
| 65 | // - *.art file with pre-initialized Java classes (architecture-specific, one per instruction set) |
| 66 | // - *.vdex file with verification metadata for the DEX bytecode (architecture independent) |
| 67 | // |
| 68 | // *.vdex files for the boot images do not contain the DEX bytecode itself, because the |
| 69 | // bootclasspath DEX files are stored on disk in uncompressed and aligned form. Consequently a boot |
| 70 | // image is not self-contained and cannot be used without its DEX files. To simplify the management |
| 71 | // of boot image files, ART uses a certain naming scheme and associates the following metadata with |
| 72 | // each boot image: |
| 73 | // - A stem, which is a symbolic name that is prepended to boot image file names. |
| 74 | // - A location (on-device path to the boot image files). |
| 75 | // - A list of boot image locations (on-device paths to dependency boot images). |
| 76 | // - A set of DEX locations (on-device paths to the DEX files, one location for one DEX file used |
| 77 | // to compile the boot image). |
| 78 | // |
| 79 | // There are two kinds of boot images: |
| 80 | // - primary boot images |
| 81 | // - boot image extensions |
| 82 | // |
| 83 | // 1.1. Primary boot images |
| 84 | // ------------------------ |
| 85 | // |
| 86 | // A primary boot image is compiled for a core subset of bootclasspath Java libraries. It does not |
| 87 | // depend on any other images, and other boot images may depend on it. |
| 88 | // |
| 89 | // For example, assuming that the stem is "boot", the location is /apex/com.android.art/javalib/, |
| 90 | // the set of core bootclasspath libraries is A B C, and the boot image is compiled for ARM targets |
| 91 | // (32 and 64 bits), it will have three components with the following files: |
| 92 | // - /apex/com.android.art/javalib/{arm,arm64}/boot.{art,oat,vdex} |
| 93 | // - /apex/com.android.art/javalib/{arm,arm64}/boot-B.{art,oat,vdex} |
| 94 | // - /apex/com.android.art/javalib/{arm,arm64}/boot-C.{art,oat,vdex} |
| 95 | // |
| 96 | // The files of the first component are special: they do not have the component name appended after |
| 97 | // the stem. This naming convention dates back to the times when the boot image was not split into |
| 98 | // components, and there were just boot.oat and boot.art. The decision to split was motivated by |
| 99 | // licensing reasons for one of the bootclasspath libraries. |
| 100 | // |
| 101 | // As of November 2020 the only primary boot image in Android is the image in the ART APEX |
| 102 | // com.android.art. The primary ART boot image contains the Core libraries that are part of the ART |
| 103 | // module. When the ART module gets updated, the primary boot image will be updated with it, and all |
| 104 | // dependent images will get invalidated (the checksum of the primary image stored in dependent |
| 105 | // images will not match), unless they are updated in sync with the ART module. |
| 106 | // |
| 107 | // 1.2. Boot image extensions |
| 108 | // -------------------------- |
| 109 | // |
| 110 | // A boot image extension is compiled for a subset of bootclasspath Java libraries (in particular, |
| 111 | // this subset does not include the Core bootclasspath libraries that go into the primary boot |
| 112 | // image). A boot image extension depends on the primary boot image and optionally some other boot |
| 113 | // image extensions. Other images may depend on it. In other words, boot image extensions can form |
| 114 | // acyclic dependency graphs. |
| 115 | // |
| 116 | // The motivation for boot image extensions comes from the Mainline project. Consider a situation |
| 117 | // when the list of bootclasspath libraries is A B C, and both A and B are parts of the Android |
| 118 | // platform, but C is part of an updatable APEX com.android.C. When the APEX is updated, the Java |
| 119 | // code for C might have changed compared to the code that was used to compile the boot image. |
| 120 | // Consequently, the whole boot image is obsolete and invalidated (even though the code for A and B |
| 121 | // that does not depend on C is up to date). To avoid this, the original monolithic boot image is |
| 122 | // split in two parts: the primary boot image that contains A B, and the boot image extension that |
| 123 | // contains C and depends on the primary boot image (extends it). |
| 124 | // |
| 125 | // For example, assuming that the stem is "boot", the location is /system/framework, the set of |
| 126 | // bootclasspath libraries is D E (where D is part of the platform and is located in |
| 127 | // /system/framework, and E is part of a non-updatable APEX com.android.E and is located in |
| 128 | // /apex/com.android.E/javalib), and the boot image is compiled for ARM targets (32 and 64 bits), |
| 129 | // it will have two components with the following files: |
| 130 | // - /system/framework/{arm,arm64}/boot-D.{art,oat,vdex} |
| 131 | // - /system/framework/{arm,arm64}/boot-E.{art,oat,vdex} |
| 132 | // |
| 133 | // As of November 2020 the only boot image extension in Android is the Framework boot image |
| 134 | // extension. It extends the primary ART boot image and contains Framework libraries and other |
| 135 | // bootclasspath libraries from the platform and non-updatable APEXes that are not included in the |
| 136 | // ART image. The Framework boot image extension is updated together with the platform. In the |
| 137 | // future other boot image extensions may be added for some updatable modules. |
| 138 | // |
| 139 | // |
| 140 | // 2. Build system support for boot images |
| 141 | // --------------------------------------- |
| 142 | // |
| 143 | // The primary ART boot image needs to be compiled with one dex2oat invocation that depends on DEX |
| 144 | // jars for the core libraries. Framework boot image extension needs to be compiled with one dex2oat |
| 145 | // invocation that depends on the primary ART boot image and all bootclasspath DEX jars except the |
Paul Duffin | 1ab6186 | 2021-01-20 17:44:53 +0000 | [diff] [blame] | 146 | // core libraries as they are already part of the primary ART boot image. |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 147 | // |
| 148 | // 2.1. Libraries that go in the boot images |
| 149 | // ----------------------------------------- |
| 150 | // |
| 151 | // The contents of each boot image are determined by the PRODUCT variables. The primary ART APEX |
| 152 | // boot image contains libraries listed in the ART_APEX_JARS variable in the AOSP makefiles. The |
| 153 | // Framework boot image extension contains libraries specified in the PRODUCT_BOOT_JARS and |
| 154 | // PRODUCT_BOOT_JARS_EXTRA variables. The AOSP makefiles specify some common Framework libraries, |
| 155 | // but more product-specific libraries can be added in the product makefiles. |
| 156 | // |
Martin Stjernholm | 1d51ea9 | 2021-07-05 20:33:42 +0100 | [diff] [blame] | 157 | // Each component of the PRODUCT_BOOT_JARS and PRODUCT_BOOT_JARS_EXTRA variables is a |
| 158 | // colon-separated pair <apex>:<library>, where <apex> is the variant name of a non-updatable APEX, |
| 159 | // "platform" if the library is a part of the platform in the system partition, or "system_ext" if |
| 160 | // it's in the system_ext partition. |
| 161 | // |
| 162 | // In these variables APEXes are identified by their "variant names", i.e. the names they get |
| 163 | // mounted as in /apex on device. In Soong modules that is the name set in the "apex_name" |
| 164 | // properties, which default to the "name" values. For example, many APEXes have both |
| 165 | // com.android.xxx and com.google.android.xxx modules in Soong, but take the same place |
| 166 | // /apex/com.android.xxx at runtime. In these cases the variant name is always com.android.xxx, |
| 167 | // regardless which APEX goes into the product. See also android.ApexInfo.ApexVariationName and |
| 168 | // apex.apexBundleProperties.Apex_name. |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 169 | // |
satayev | d604b21 | 2021-07-21 14:23:52 +0100 | [diff] [blame] | 170 | // A related variable PRODUCT_APEX_BOOT_JARS contains bootclasspath libraries that are in APEXes. |
| 171 | // They are not included in the boot image. The only exception here are ART jars and core-icu4j.jar |
| 172 | // that have been historically part of the boot image and are now in apexes; they are in boot images |
| 173 | // and core-icu4j.jar is generally treated as being part of PRODUCT_BOOT_JARS. |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 174 | // |
| 175 | // One exception to the above rules are "coverage" builds (a special build flavor which requires |
| 176 | // setting environment variable EMMA_INSTRUMENT_FRAMEWORK=true). In coverage builds the Java code in |
| 177 | // boot image libraries is instrumented, which means that the instrumentation library (jacocoagent) |
| 178 | // needs to be added to the list of bootclasspath DEX jars. |
| 179 | // |
| 180 | // In general, there is a requirement that the source code for a boot image library must be |
| 181 | // available at build time (e.g. it cannot be a stub that has a separate implementation library). |
| 182 | // |
| 183 | // 2.2. Static configs |
| 184 | // ------------------- |
| 185 | // |
| 186 | // Because boot images are used to dexpreopt other Java modules, the paths to boot image files must |
| 187 | // be known by the time dexpreopt build rules for the dependent modules are generated. Boot image |
| 188 | // configs are constructed very early during the build, before build rule generation. The configs |
| 189 | // provide predefined paths to boot image files (these paths depend only on static build |
| 190 | // configuration, such as PRODUCT variables, and use hard-coded directory names). |
| 191 | // |
| 192 | // 2.3. Singleton |
| 193 | // -------------- |
| 194 | // |
| 195 | // Build rules for the boot images are generated with a Soong singleton. Because a singleton has no |
| 196 | // dependencies on other modules, it has to find the modules for the DEX jars using VisitAllModules. |
| 197 | // Soong loops through all modules and compares each module against a list of bootclasspath library |
| 198 | // names. Then it generates build rules that copy DEX jars from their intermediate module-specific |
| 199 | // locations to the hard-coded locations predefined in the boot image configs. |
| 200 | // |
| 201 | // It would be possible to use a module with proper dependencies instead, but that would require |
| 202 | // changes in the way Soong generates variables for Make: a singleton can use one MakeVars() method |
| 203 | // that writes variables to out/soong/make_vars-*.mk, which is included early by the main makefile, |
| 204 | // but module(s) would have to use out/soong/Android-*.mk which has a group of LOCAL_* variables |
| 205 | // for each module, and is included later. |
| 206 | // |
| 207 | // 2.4. Install rules |
| 208 | // ------------------ |
| 209 | // |
| 210 | // The primary boot image and the Framework extension are installed in different ways. The primary |
| 211 | // boot image is part of the ART APEX: it is copied into the APEX intermediate files, packaged |
| 212 | // together with other APEX contents, extracted and mounted on device. The Framework boot image |
| 213 | // extension is installed by the rules defined in makefiles (make/core/dex_preopt_libart.mk). Soong |
| 214 | // writes out a few DEXPREOPT_IMAGE_* variables for Make; these variables contain boot image names, |
| 215 | // paths and so on. |
| 216 | // |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 217 | |
Martin Stjernholm | db51382 | 2021-02-16 19:55:58 +0000 | [diff] [blame] | 218 | var artApexNames = []string{ |
| 219 | "com.android.art", |
| 220 | "com.android.art.debug", |
Roland Levillain | d603c7d | 2021-03-24 14:23:57 +0000 | [diff] [blame] | 221 | "com.android.art.testing", |
Martin Stjernholm | db51382 | 2021-02-16 19:55:58 +0000 | [diff] [blame] | 222 | "com.google.android.art", |
| 223 | "com.google.android.art.debug", |
| 224 | "com.google.android.art.testing", |
| 225 | } |
| 226 | |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 227 | func init() { |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 228 | RegisterDexpreoptBootJarsComponents(android.InitRegistrationContext) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 229 | } |
| 230 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 231 | // Target-independent description of a boot image. |
Paul Duffin | a8df7e1 | 2022-10-04 15:21:47 +0100 | [diff] [blame] | 232 | // |
| 233 | // WARNING: All fields in this struct should be initialized in the genBootImageConfigs function. |
| 234 | // Failure to do so can lead to data races if there is no synchronization enforced ordering between |
| 235 | // the writer and the reader. Fields which break this rule are marked as deprecated and should be |
| 236 | // removed and replaced with something else, e.g. providers. |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 237 | type bootImageConfig struct { |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 238 | // If this image is an extension, the image that it extends. |
| 239 | extends *bootImageConfig |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 240 | |
| 241 | // Image name (used in directory names and ninja rule names). |
| 242 | name string |
| 243 | |
| 244 | // Basename of the image: the resulting filenames are <stem>[-<jar>].{art,oat,vdex}. |
| 245 | stem string |
| 246 | |
| 247 | // Output directory for the image files. |
| 248 | dir android.OutputPath |
| 249 | |
| 250 | // Output directory for the image files with debug symbols. |
| 251 | symbolsDir android.OutputPath |
| 252 | |
Jiakai Zhang | 09d88df | 2023-05-10 17:04:53 +0100 | [diff] [blame] | 253 | // The relative location where the image files are installed. On host, the location is relative to |
| 254 | // $ANDROID_PRODUCT_OUT. |
| 255 | // |
| 256 | // Only the configs that are built by platform_bootclasspath are installable on device. On device, |
| 257 | // the location is relative to "/". |
| 258 | installDir string |
Jeongik Cha | 4dda75e | 2021-04-27 23:56:44 +0900 | [diff] [blame] | 259 | |
Jiakai Zhang | 49b1eb6 | 2021-11-26 18:09:27 +0000 | [diff] [blame] | 260 | // Install path of the boot image profile if it needs to be installed in the APEX, or empty if not |
| 261 | // needed. |
| 262 | profileInstallPathInApex string |
| 263 | |
Ulya Trafimovich | 249386a | 2020-07-01 14:31:13 +0100 | [diff] [blame] | 264 | // A list of (location, jar) pairs for the Java modules in this image. |
| 265 | modules android.ConfiguredJarList |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 266 | |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 267 | // File paths to jars. |
| 268 | dexPaths android.WritablePaths // for this image |
| 269 | dexPathsDeps android.WritablePaths // for the dependency images and in this image |
| 270 | |
Paul Duffin | 5f148ca | 2021-06-02 17:24:22 +0100 | [diff] [blame] | 271 | // Map from module name (without prebuilt_ prefix) to the predefined build path. |
| 272 | dexPathsByModule map[string]android.WritablePath |
| 273 | |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 274 | // File path to a zip archive with all image files (or nil, if not needed). |
| 275 | zip android.WritablePath |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 276 | |
| 277 | // Rules which should be used in make to install the outputs. |
Paul Duffin | a8df7e1 | 2022-10-04 15:21:47 +0100 | [diff] [blame] | 278 | // |
| 279 | // Deprecated: Not initialized correctly, see struct comment. |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 280 | profileInstalls android.RuleBuilderInstalls |
| 281 | |
Colin Cross | e7fe096 | 2022-03-15 17:49:24 -0700 | [diff] [blame] | 282 | // Path to the license metadata file for the module that built the profile. |
Paul Duffin | a8df7e1 | 2022-10-04 15:21:47 +0100 | [diff] [blame] | 283 | // |
| 284 | // Deprecated: Not initialized correctly, see struct comment. |
Colin Cross | e7fe096 | 2022-03-15 17:49:24 -0700 | [diff] [blame] | 285 | profileLicenseMetadataFile android.OptionalPath |
| 286 | |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 287 | // Target-dependent fields. |
| 288 | variants []*bootImageVariant |
Nicolas Geoffray | b9a46fb | 2022-03-14 15:31:47 +0000 | [diff] [blame] | 289 | |
| 290 | // Path of the preloaded classes file. |
| 291 | preloadedClassesFile string |
Jiakai Zhang | 8e9ea8b | 2023-02-23 17:50:46 +0000 | [diff] [blame] | 292 | |
| 293 | // The "--compiler-filter" argument. |
| 294 | compilerFilter string |
Jiakai Zhang | b879620 | 2023-03-06 19:16:48 +0000 | [diff] [blame] | 295 | |
| 296 | // The "--single-image" argument. |
| 297 | singleImage bool |
Jiakai Zhang | c08c162 | 2023-05-10 18:38:34 +0100 | [diff] [blame^] | 298 | |
| 299 | // Profiles imported from other boot image configs. Each element must represent a |
| 300 | // `bootclasspath_fragment` of an APEX (i.e., the `name` field of each element must refer to the |
| 301 | // `image_name` property of a `bootclasspath_fragment`). |
| 302 | profileImports []*bootImageConfig |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 303 | } |
| 304 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 305 | // Target-dependent description of a boot image. |
Paul Duffin | a8df7e1 | 2022-10-04 15:21:47 +0100 | [diff] [blame] | 306 | // |
| 307 | // WARNING: The warning comment on bootImageConfig applies here too. |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 308 | type bootImageVariant struct { |
| 309 | *bootImageConfig |
| 310 | |
| 311 | // Target for which the image is generated. |
| 312 | target android.Target |
| 313 | |
David Srbecky | ab99498 | 2020-03-30 17:24:13 +0100 | [diff] [blame] | 314 | // The "locations" of jars. |
| 315 | dexLocations []string // for this image |
| 316 | dexLocationsDeps []string // for the dependency images and in this image |
| 317 | |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 318 | // Paths to image files. |
Paul Duffin | bff50e2 | 2021-06-04 17:25:28 +0100 | [diff] [blame] | 319 | imagePathOnHost android.OutputPath // first image file path on host |
| 320 | imagePathOnDevice string // first image file path on device |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 321 | |
Paul Duffin | bff50e2 | 2021-06-04 17:25:28 +0100 | [diff] [blame] | 322 | // All the files that constitute this image variant, i.e. .art, .oat and .vdex files. |
| 323 | imagesDeps android.OutputPaths |
| 324 | |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 325 | // The path to the base image variant's imagePathOnHost field, where base image variant |
Paul Duffin | bff50e2 | 2021-06-04 17:25:28 +0100 | [diff] [blame] | 326 | // means the image variant that this extends. |
| 327 | // |
| 328 | // This is only set for a variant of an image that extends another image. |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 329 | baseImages android.OutputPaths |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 330 | |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 331 | // The paths to the base image variant's imagesDeps field, where base image variant |
Paul Duffin | bff50e2 | 2021-06-04 17:25:28 +0100 | [diff] [blame] | 332 | // means the image variant that this extends. |
| 333 | // |
| 334 | // This is only set for a variant of an image that extends another image. |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 335 | baseImagesDeps android.Paths |
Paul Duffin | bff50e2 | 2021-06-04 17:25:28 +0100 | [diff] [blame] | 336 | |
Jiakai Zhang | 6decef9 | 2022-01-12 17:56:19 +0000 | [diff] [blame] | 337 | // Rules which should be used in make to install the outputs on host. |
Paul Duffin | a8df7e1 | 2022-10-04 15:21:47 +0100 | [diff] [blame] | 338 | // |
| 339 | // Deprecated: Not initialized correctly, see struct comment. |
| 340 | installs android.RuleBuilderInstalls |
| 341 | |
| 342 | // Rules which should be used in make to install the vdex outputs on host. |
| 343 | // |
| 344 | // Deprecated: Not initialized correctly, see struct comment. |
| 345 | vdexInstalls android.RuleBuilderInstalls |
| 346 | |
| 347 | // Rules which should be used in make to install the unstripped outputs on host. |
| 348 | // |
| 349 | // Deprecated: Not initialized correctly, see struct comment. |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 350 | unstrippedInstalls android.RuleBuilderInstalls |
Jiakai Zhang | 6decef9 | 2022-01-12 17:56:19 +0000 | [diff] [blame] | 351 | |
Colin Cross | e7fe096 | 2022-03-15 17:49:24 -0700 | [diff] [blame] | 352 | // Path to the license metadata file for the module that built the image. |
Paul Duffin | a8df7e1 | 2022-10-04 15:21:47 +0100 | [diff] [blame] | 353 | // |
| 354 | // Deprecated: Not initialized correctly, see struct comment. |
Colin Cross | e7fe096 | 2022-03-15 17:49:24 -0700 | [diff] [blame] | 355 | licenseMetadataFile android.OptionalPath |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 356 | } |
| 357 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 358 | // Get target-specific boot image variant for the given boot image config and target. |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 359 | func (image bootImageConfig) getVariant(target android.Target) *bootImageVariant { |
| 360 | for _, variant := range image.variants { |
| 361 | if variant.target.Os == target.Os && variant.target.Arch.ArchType == target.Arch.ArchType { |
| 362 | return variant |
| 363 | } |
| 364 | } |
| 365 | return nil |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 366 | } |
| 367 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 368 | // Return any (the first) variant which is for the device (as opposed to for the host). |
David Srbecky | ab99498 | 2020-03-30 17:24:13 +0100 | [diff] [blame] | 369 | func (image bootImageConfig) getAnyAndroidVariant() *bootImageVariant { |
| 370 | for _, variant := range image.variants { |
| 371 | if variant.target.Os == android.Android { |
| 372 | return variant |
| 373 | } |
| 374 | } |
| 375 | return nil |
| 376 | } |
| 377 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 378 | // Return the name of a boot image module given a boot image config and a component (module) index. |
| 379 | // A module name is a combination of the Java library name, and the boot image stem (that is stored |
| 380 | // in the config). |
Ulya Trafimovich | 8640ab9 | 2020-05-11 18:06:15 +0100 | [diff] [blame] | 381 | func (image bootImageConfig) moduleName(ctx android.PathContext, idx int) string { |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 382 | // The first module of the primary boot image is special: its module name has only the stem, but |
| 383 | // not the library name. All other module names are of the form <stem>-<library name> |
Ulya Trafimovich | 249386a | 2020-07-01 14:31:13 +0100 | [diff] [blame] | 384 | m := image.modules.Jar(idx) |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 385 | name := image.stem |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 386 | if idx != 0 || image.extends != nil { |
Ulya Trafimovich | 249386a | 2020-07-01 14:31:13 +0100 | [diff] [blame] | 387 | name += "-" + android.ModuleStem(m) |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 388 | } |
| 389 | return name |
| 390 | } |
Dan Willemsen | 0f41678 | 2019-06-13 21:44:53 +0000 | [diff] [blame] | 391 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 392 | // Return the name of the first boot image module, or stem if the list of modules is empty. |
Ulya Trafimovich | 8640ab9 | 2020-05-11 18:06:15 +0100 | [diff] [blame] | 393 | func (image bootImageConfig) firstModuleNameOrStem(ctx android.PathContext) string { |
Ulya Trafimovich | 249386a | 2020-07-01 14:31:13 +0100 | [diff] [blame] | 394 | if image.modules.Len() > 0 { |
Ulya Trafimovich | 8640ab9 | 2020-05-11 18:06:15 +0100 | [diff] [blame] | 395 | return image.moduleName(ctx, 0) |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 396 | } else { |
| 397 | return image.stem |
| 398 | } |
| 399 | } |
| 400 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 401 | // Return filenames for the given boot image component, given the output directory and a list of |
| 402 | // extensions. |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 403 | func (image bootImageConfig) moduleFiles(ctx android.PathContext, dir android.OutputPath, exts ...string) android.OutputPaths { |
Ulya Trafimovich | 249386a | 2020-07-01 14:31:13 +0100 | [diff] [blame] | 404 | ret := make(android.OutputPaths, 0, image.modules.Len()*len(exts)) |
| 405 | for i := 0; i < image.modules.Len(); i++ { |
Ulya Trafimovich | 8640ab9 | 2020-05-11 18:06:15 +0100 | [diff] [blame] | 406 | name := image.moduleName(ctx, i) |
Dan Willemsen | 0f41678 | 2019-06-13 21:44:53 +0000 | [diff] [blame] | 407 | for _, ext := range exts { |
| 408 | ret = append(ret, dir.Join(ctx, name+ext)) |
| 409 | } |
Jiakai Zhang | b879620 | 2023-03-06 19:16:48 +0000 | [diff] [blame] | 410 | if image.singleImage { |
| 411 | break |
| 412 | } |
Dan Willemsen | 0f41678 | 2019-06-13 21:44:53 +0000 | [diff] [blame] | 413 | } |
Dan Willemsen | 0f41678 | 2019-06-13 21:44:53 +0000 | [diff] [blame] | 414 | return ret |
| 415 | } |
| 416 | |
Paul Duffin | 5466a36 | 2021-06-07 10:25:31 +0100 | [diff] [blame] | 417 | // apexVariants returns a list of all *bootImageVariant that could be included in an apex. |
| 418 | func (image *bootImageConfig) apexVariants() []*bootImageVariant { |
| 419 | variants := []*bootImageVariant{} |
| 420 | for _, variant := range image.variants { |
| 421 | // We also generate boot images for host (for testing), but we don't need those in the apex. |
| 422 | // TODO(b/177892522) - consider changing this to check Os.OsClass = android.Device |
| 423 | if variant.target.Os == android.Android { |
| 424 | variants = append(variants, variant) |
| 425 | } |
| 426 | } |
| 427 | return variants |
| 428 | } |
| 429 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 430 | // Return boot image locations (as a list of symbolic paths). |
| 431 | // |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 432 | // The image "location" is a symbolic path that, with multiarchitecture support, doesn't really |
| 433 | // exist on the device. Typically it is /apex/com.android.art/javalib/boot.art and should be the |
| 434 | // same for all supported architectures on the device. The concrete architecture specific files |
| 435 | // actually end up in architecture-specific sub-directory such as arm, arm64, x86, or x86_64. |
| 436 | // |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 437 | // For example a physical file /apex/com.android.art/javalib/x86/boot.art has "image location" |
| 438 | // /apex/com.android.art/javalib/boot.art (which is not an actual file). |
| 439 | // |
| 440 | // For a primary boot image the list of locations has a single element. |
| 441 | // |
| 442 | // For a boot image extension the list of locations contains a location for all dependency images |
| 443 | // (including the primary image) and the location of the extension itself. For example, for the |
| 444 | // Framework boot image extension that depends on the primary ART boot image the list contains two |
| 445 | // elements. |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 446 | // |
| 447 | // The location is passed as an argument to the ART tools like dex2oat instead of the real path. |
| 448 | // ART tools will then reconstruct the architecture-specific real path. |
Jeongik Cha | 4dda75e | 2021-04-27 23:56:44 +0900 | [diff] [blame] | 449 | func (image *bootImageVariant) imageLocations() (imageLocationsOnHost []string, imageLocationsOnDevice []string) { |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 450 | if image.extends != nil { |
Jeongik Cha | 4dda75e | 2021-04-27 23:56:44 +0900 | [diff] [blame] | 451 | imageLocationsOnHost, imageLocationsOnDevice = image.extends.getVariant(image.target).imageLocations() |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 452 | } |
Jeongik Cha | 4dda75e | 2021-04-27 23:56:44 +0900 | [diff] [blame] | 453 | return append(imageLocationsOnHost, dexpreopt.PathToLocation(image.imagePathOnHost, image.target.Arch.ArchType)), |
| 454 | append(imageLocationsOnDevice, dexpreopt.PathStringToLocation(image.imagePathOnDevice, image.target.Arch.ArchType)) |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 455 | } |
| 456 | |
Jiakai Zhang | 8e9ea8b | 2023-02-23 17:50:46 +0000 | [diff] [blame] | 457 | func (image *bootImageConfig) isProfileGuided() bool { |
| 458 | return image.compilerFilter == "speed-profile" |
| 459 | } |
| 460 | |
Paul Duffin | 1ab6186 | 2021-01-20 17:44:53 +0000 | [diff] [blame] | 461 | func dexpreoptBootJarsFactory() android.SingletonModule { |
| 462 | m := &dexpreoptBootJars{} |
| 463 | android.InitAndroidModule(m) |
| 464 | return m |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 465 | } |
| 466 | |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 467 | func RegisterDexpreoptBootJarsComponents(ctx android.RegistrationContext) { |
Paul Duffin | 1ab6186 | 2021-01-20 17:44:53 +0000 | [diff] [blame] | 468 | ctx.RegisterSingletonModuleType("dex_bootjars", dexpreoptBootJarsFactory) |
Ulya Trafimovich | b28cc37 | 2020-01-13 15:18:16 +0000 | [diff] [blame] | 469 | } |
| 470 | |
Ulya Trafimovich | a4a1c4e | 2021-01-15 18:40:04 +0000 | [diff] [blame] | 471 | func SkipDexpreoptBootJars(ctx android.PathContext) bool { |
| 472 | return dexpreopt.GetGlobalConfig(ctx).DisablePreoptBootImages |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 473 | } |
| 474 | |
Paul Duffin | 1ab6186 | 2021-01-20 17:44:53 +0000 | [diff] [blame] | 475 | // Singleton module for generating boot image build rules. |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 476 | type dexpreoptBootJars struct { |
Paul Duffin | 1ab6186 | 2021-01-20 17:44:53 +0000 | [diff] [blame] | 477 | android.SingletonModuleBase |
| 478 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 479 | // Default boot image config (currently always the Framework boot image extension). It should be |
| 480 | // noted that JIT-Zygote builds use ART APEX image instead of the Framework boot image extension, |
| 481 | // but the switch is handled not here, but in the makefiles (triggered with |
| 482 | // DEXPREOPT_USE_ART_IMAGE=true). |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 483 | defaultBootImage *bootImageConfig |
Colin Cross | 2d00f0d | 2019-05-09 21:50:00 -0700 | [diff] [blame] | 484 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 485 | // Other boot image configs (currently the list contains only the primary ART APEX image. It |
| 486 | // used to contain an experimental JIT-Zygote image (now replaced with the ART APEX image). In |
| 487 | // the future other boot image extensions may be added. |
| 488 | otherImages []*bootImageConfig |
| 489 | |
| 490 | // Build path to a config file that Soong writes for Make (to be used in makefiles that install |
| 491 | // the default boot image). |
Colin Cross | 2d00f0d | 2019-05-09 21:50:00 -0700 | [diff] [blame] | 492 | dexpreoptConfigForMake android.WritablePath |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 493 | } |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 494 | |
Paul Duffin | 1ab6186 | 2021-01-20 17:44:53 +0000 | [diff] [blame] | 495 | // Provide paths to boot images for use by modules that depend upon them. |
| 496 | // |
| 497 | // The build rules are created in GenerateSingletonBuildActions(). |
| 498 | func (d *dexpreoptBootJars) GenerateAndroidBuildActions(ctx android.ModuleContext) { |
| 499 | // Placeholder for now. |
| 500 | } |
| 501 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 502 | // Generate build rules for boot images. |
Paul Duffin | 1ab6186 | 2021-01-20 17:44:53 +0000 | [diff] [blame] | 503 | func (d *dexpreoptBootJars) GenerateSingletonBuildActions(ctx android.SingletonContext) { |
Martin Stjernholm | 6d41527 | 2020-01-31 17:10:36 +0000 | [diff] [blame] | 504 | if dexpreopt.GetCachedGlobalSoongConfig(ctx) == nil { |
| 505 | // No module has enabled dexpreopting, so we assume there will be no boot image to make. |
| 506 | return |
| 507 | } |
Jeongik Cha | 4753b39 | 2023-04-19 23:25:41 +0900 | [diff] [blame] | 508 | archType := ctx.Config().Targets[android.Android][0].Arch.ArchType |
| 509 | d.dexpreoptConfigForMake = android.PathForOutput(ctx, toDexpreoptDirName(archType), "dexpreopt.config") |
Colin Cross | 2d00f0d | 2019-05-09 21:50:00 -0700 | [diff] [blame] | 510 | writeGlobalConfigForMake(ctx, d.dexpreoptConfigForMake) |
| 511 | |
Martin Stjernholm | 40f9f3c | 2020-01-20 18:12:23 +0000 | [diff] [blame] | 512 | global := dexpreopt.GetGlobalConfig(ctx) |
Paul Duffin | ad19d38 | 2021-04-26 16:44:00 +0100 | [diff] [blame] | 513 | if !shouldBuildBootImages(ctx.Config(), global) { |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 514 | return |
| 515 | } |
| 516 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 517 | defaultImageConfig := defaultBootImageConfig(ctx) |
Paul Duffin | 4793293 | 2021-04-29 11:46:29 +0100 | [diff] [blame] | 518 | d.defaultBootImage = defaultImageConfig |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 519 | imageConfigs := genBootImageConfigs(ctx) |
| 520 | d.otherImages = make([]*bootImageConfig, 0, len(imageConfigs)-1) |
| 521 | for _, config := range imageConfigs { |
| 522 | if config != defaultImageConfig { |
| 523 | d.otherImages = append(d.otherImages, config) |
| 524 | } |
| 525 | } |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 526 | } |
| 527 | |
Paul Duffin | ad19d38 | 2021-04-26 16:44:00 +0100 | [diff] [blame] | 528 | // shouldBuildBootImages determines whether boot images should be built. |
| 529 | func shouldBuildBootImages(config android.Config, global *dexpreopt.GlobalConfig) bool { |
| 530 | // Skip recompiling the boot image for the second sanitization phase. We'll get separate paths |
| 531 | // and invalidate first-stage artifacts which are crucial to SANITIZE_LITE builds. |
| 532 | // Note: this is technically incorrect. Compiled code contains stack checks which may depend |
| 533 | // on ASAN settings. |
| 534 | if len(config.SanitizeDevice()) == 1 && config.SanitizeDevice()[0] == "address" && global.SanitizeLite { |
| 535 | return false |
| 536 | } |
| 537 | return true |
| 538 | } |
| 539 | |
Paul Duffin | 5f148ca | 2021-06-02 17:24:22 +0100 | [diff] [blame] | 540 | // copyBootJarsToPredefinedLocations generates commands that will copy boot jars to predefined |
| 541 | // paths in the global config. |
| 542 | func copyBootJarsToPredefinedLocations(ctx android.ModuleContext, srcBootDexJarsByModule bootDexJarByModule, dstBootJarsByModule map[string]android.WritablePath) { |
| 543 | // Create the super set of module names. |
| 544 | names := []string{} |
Cole Faust | 18994c7 | 2023-02-28 16:02:16 -0800 | [diff] [blame] | 545 | names = append(names, android.SortedKeys(srcBootDexJarsByModule)...) |
| 546 | names = append(names, android.SortedKeys(dstBootJarsByModule)...) |
Paul Duffin | 5f148ca | 2021-06-02 17:24:22 +0100 | [diff] [blame] | 547 | names = android.SortedUniqueStrings(names) |
| 548 | for _, name := range names { |
| 549 | src := srcBootDexJarsByModule[name] |
| 550 | dst := dstBootJarsByModule[name] |
Paul Duffin | 7ebebfd | 2021-04-27 19:36:57 +0100 | [diff] [blame] | 551 | |
Paul Duffin | 5f148ca | 2021-06-02 17:24:22 +0100 | [diff] [blame] | 552 | if src == nil { |
Martin Stjernholm | ed3df44 | 2021-12-08 16:26:07 +0000 | [diff] [blame] | 553 | // A dex boot jar should be provided by the source java module. It needs to be installable or |
| 554 | // have compile_dex=true - cf. assignments to java.Module.dexJarFile. |
| 555 | // |
| 556 | // However, the source java module may be either replaced or overridden (using prefer:true) by |
| 557 | // a prebuilt java module with the same name. In that case the dex boot jar needs to be |
| 558 | // provided by the corresponding prebuilt APEX module. That APEX is the one that refers |
| 559 | // through a exported_(boot|systemserver)classpath_fragments property to a |
| 560 | // prebuilt_(boot|systemserver)classpath_fragment module, which in turn lists the prebuilt |
| 561 | // java module in the contents property. If that chain is broken then this dependency will |
| 562 | // fail. |
Spandan Das | 10ea4bf | 2021-08-20 19:18:16 +0000 | [diff] [blame] | 563 | if !ctx.Config().AllowMissingDependencies() { |
Martin Stjernholm | ed3df44 | 2021-12-08 16:26:07 +0000 | [diff] [blame] | 564 | ctx.ModuleErrorf("module %s does not provide a dex boot jar (see comment next to this message in Soong for details)", name) |
Spandan Das | 10ea4bf | 2021-08-20 19:18:16 +0000 | [diff] [blame] | 565 | } else { |
| 566 | ctx.AddMissingDependencies([]string{name}) |
| 567 | } |
Paul Duffin | 5f148ca | 2021-06-02 17:24:22 +0100 | [diff] [blame] | 568 | } else if dst == nil { |
| 569 | ctx.ModuleErrorf("module %s is not part of the boot configuration", name) |
Paul Duffin | 57e2e7d | 2021-04-26 13:24:42 +0100 | [diff] [blame] | 570 | } else { |
| 571 | ctx.Build(pctx, android.BuildParams{ |
| 572 | Rule: android.Cp, |
Paul Duffin | 5f148ca | 2021-06-02 17:24:22 +0100 | [diff] [blame] | 573 | Input: src, |
| 574 | Output: dst, |
Paul Duffin | 57e2e7d | 2021-04-26 13:24:42 +0100 | [diff] [blame] | 575 | }) |
| 576 | } |
| 577 | } |
Ulya Trafimovich | fa2b1cf | 2021-03-22 12:37:10 +0000 | [diff] [blame] | 578 | } |
| 579 | |
Paul Duffin | a56be7d | 2021-07-02 13:00:43 +0100 | [diff] [blame] | 580 | // buildBootImageVariantsForAndroidOs generates rules to build the boot image variants for the |
| 581 | // android.Android OsType and returns a map from the architectures to the paths of the generated |
| 582 | // boot image files. |
| 583 | // |
| 584 | // The paths are returned because they are needed elsewhere in Soong, e.g. for populating an APEX. |
Paul Duffin | 9f6ac0b | 2022-10-04 15:36:44 +0100 | [diff] [blame] | 585 | func buildBootImageVariantsForAndroidOs(ctx android.ModuleContext, image *bootImageConfig, profile android.WritablePath) bootImageOutputs { |
Paul Duffin | a56be7d | 2021-07-02 13:00:43 +0100 | [diff] [blame] | 586 | return buildBootImageForOsType(ctx, image, profile, android.Android) |
| 587 | } |
| 588 | |
| 589 | // buildBootImageVariantsForBuildOs generates rules to build the boot image variants for the |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 590 | // config.BuildOS OsType, i.e. the type of OS on which the build is being running. |
Paul Duffin | a56be7d | 2021-07-02 13:00:43 +0100 | [diff] [blame] | 591 | // |
| 592 | // The files need to be generated into their predefined location because they are used from there |
| 593 | // both within Soong and outside, e.g. for ART based host side testing and also for use by some |
| 594 | // cloud based tools. However, they are not needed by callers of this function and so the paths do |
| 595 | // not need to be returned from this func, unlike the buildBootImageVariantsForAndroidOs func. |
| 596 | func buildBootImageVariantsForBuildOs(ctx android.ModuleContext, image *bootImageConfig, profile android.WritablePath) { |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 597 | buildBootImageForOsType(ctx, image, profile, ctx.Config().BuildOS) |
Paul Duffin | a56be7d | 2021-07-02 13:00:43 +0100 | [diff] [blame] | 598 | } |
| 599 | |
Jiakai Zhang | b47cacc | 2023-05-10 16:40:18 +0100 | [diff] [blame] | 600 | // bootImageFilesByArch is a map from android.ArchType to the paths to the boot image files. |
| 601 | // |
| 602 | // The paths include the .art, .oat and .vdex files, one for each of the modules from which the boot |
| 603 | // image is created. |
| 604 | type bootImageFilesByArch map[android.ArchType]android.Paths |
| 605 | |
Paul Duffin | 9f6ac0b | 2022-10-04 15:36:44 +0100 | [diff] [blame] | 606 | // bootImageOutputs encapsulates information about boot images that were created/obtained by |
| 607 | // commonBootclasspathFragment.produceBootImageFiles. |
| 608 | type bootImageOutputs struct { |
| 609 | // Map from arch to the paths to the boot image files created/obtained for that arch. |
| 610 | byArch bootImageFilesByArch |
| 611 | |
Paul Duffin | e10a9f2 | 2022-10-04 16:39:18 +0100 | [diff] [blame] | 612 | variants []bootImageVariantOutputs |
| 613 | |
Paul Duffin | 9f6ac0b | 2022-10-04 15:36:44 +0100 | [diff] [blame] | 614 | // The path to the profile file created/obtained for the boot image. |
| 615 | profile android.WritablePath |
| 616 | } |
| 617 | |
Paul Duffin | a56be7d | 2021-07-02 13:00:43 +0100 | [diff] [blame] | 618 | // buildBootImageForOsType takes a bootImageConfig, a profile file and an android.OsType |
| 619 | // boot image files are required for and it creates rules to build the boot image |
| 620 | // files for all the required architectures for them. |
Paul Duffin | 56afb27 | 2021-07-01 22:04:22 +0100 | [diff] [blame] | 621 | // |
| 622 | // It returns a map from android.ArchType to the predefined paths of the boot image files. |
Paul Duffin | 9f6ac0b | 2022-10-04 15:36:44 +0100 | [diff] [blame] | 623 | func buildBootImageForOsType(ctx android.ModuleContext, image *bootImageConfig, profile android.WritablePath, requiredOsType android.OsType) bootImageOutputs { |
Paul Duffin | 56afb27 | 2021-07-01 22:04:22 +0100 | [diff] [blame] | 624 | filesByArch := bootImageFilesByArch{} |
Paul Duffin | e10a9f2 | 2022-10-04 16:39:18 +0100 | [diff] [blame] | 625 | imageOutputs := bootImageOutputs{ |
| 626 | byArch: filesByArch, |
| 627 | profile: profile, |
| 628 | } |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 629 | for _, variant := range image.variants { |
Paul Duffin | a56be7d | 2021-07-02 13:00:43 +0100 | [diff] [blame] | 630 | if variant.target.Os == requiredOsType { |
Paul Duffin | e10a9f2 | 2022-10-04 16:39:18 +0100 | [diff] [blame] | 631 | variantOutputs := buildBootImageVariant(ctx, variant, profile) |
| 632 | imageOutputs.variants = append(imageOutputs.variants, variantOutputs) |
Paul Duffin | 56afb27 | 2021-07-01 22:04:22 +0100 | [diff] [blame] | 633 | filesByArch[variant.target.Arch.ArchType] = variant.imagesDeps.Paths() |
Ulya Trafimovich | 9ab4933 | 2020-06-10 15:44:25 +0100 | [diff] [blame] | 634 | } |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 635 | } |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 636 | |
Paul Duffin | e10a9f2 | 2022-10-04 16:39:18 +0100 | [diff] [blame] | 637 | return imageOutputs |
Paul Duffin | 56afb27 | 2021-07-01 22:04:22 +0100 | [diff] [blame] | 638 | } |
Colin Cross | df8eebe | 2019-04-09 15:29:41 -0700 | [diff] [blame] | 639 | |
Paul Duffin | 56afb27 | 2021-07-01 22:04:22 +0100 | [diff] [blame] | 640 | // buildBootImageZipInPredefinedLocation generates a zip file containing all the boot image files. |
| 641 | // |
| 642 | // The supplied filesByArch is nil when the boot image files have not been generated. Otherwise, it |
| 643 | // is a map from android.ArchType to the predefined locations. |
| 644 | func buildBootImageZipInPredefinedLocation(ctx android.ModuleContext, image *bootImageConfig, filesByArch bootImageFilesByArch) { |
| 645 | if filesByArch == nil { |
| 646 | return |
Colin Cross | df8eebe | 2019-04-09 15:29:41 -0700 | [diff] [blame] | 647 | } |
Paul Duffin | 56afb27 | 2021-07-01 22:04:22 +0100 | [diff] [blame] | 648 | |
| 649 | // Compute the list of files from all the architectures. |
| 650 | zipFiles := android.Paths{} |
| 651 | for _, archType := range android.ArchTypeList() { |
| 652 | zipFiles = append(zipFiles, filesByArch[archType]...) |
| 653 | } |
| 654 | |
| 655 | rule := android.NewRuleBuilder(pctx, ctx) |
| 656 | rule.Command(). |
| 657 | BuiltTool("soong_zip"). |
| 658 | FlagWithOutput("-o ", image.zip). |
| 659 | FlagWithArg("-C ", image.dir.Join(ctx, android.Android.String()).String()). |
| 660 | FlagWithInputList("-f ", zipFiles, " -f ") |
| 661 | |
| 662 | rule.Build("zip_"+image.name, "zip "+image.name+" image") |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 663 | } |
| 664 | |
Paul Duffin | e10a9f2 | 2022-10-04 16:39:18 +0100 | [diff] [blame] | 665 | type bootImageVariantOutputs struct { |
Jiakai Zhang | b47cacc | 2023-05-10 16:40:18 +0100 | [diff] [blame] | 666 | config *bootImageVariant |
Paul Duffin | e10a9f2 | 2022-10-04 16:39:18 +0100 | [diff] [blame] | 667 | } |
| 668 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 669 | // Generate boot image build rules for a specific target. |
Paul Duffin | e10a9f2 | 2022-10-04 16:39:18 +0100 | [diff] [blame] | 670 | func buildBootImageVariant(ctx android.ModuleContext, image *bootImageVariant, profile android.Path) bootImageVariantOutputs { |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 671 | |
Paul Duffin | 8fc51a8 | 2021-07-06 10:55:35 +0100 | [diff] [blame] | 672 | globalSoong := dexpreopt.GetGlobalSoongConfig(ctx) |
Martin Stjernholm | 40f9f3c | 2020-01-20 18:12:23 +0000 | [diff] [blame] | 673 | global := dexpreopt.GetGlobalConfig(ctx) |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 674 | |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 675 | arch := image.target.Arch.ArchType |
David Srbecky | 7f8dac1 | 2020-02-13 16:00:45 +0000 | [diff] [blame] | 676 | os := image.target.Os.String() // We need to distinguish host-x86 and device-x86. |
Jiakai Zhang | 09d88df | 2023-05-10 17:04:53 +0100 | [diff] [blame] | 677 | symbolsDir := image.symbolsDir.Join(ctx, os, image.installDir, arch.String()) |
Ulyana Trafimovich | de53441 | 2019-11-08 10:51:01 +0000 | [diff] [blame] | 678 | symbolsFile := symbolsDir.Join(ctx, image.stem+".oat") |
Jiakai Zhang | 09d88df | 2023-05-10 17:04:53 +0100 | [diff] [blame] | 679 | outputDir := image.dir.Join(ctx, os, image.installDir, arch.String()) |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 680 | outputPath := outputDir.Join(ctx, image.stem+".oat") |
| 681 | oatLocation := dexpreopt.PathToLocation(outputPath, arch) |
| 682 | imagePath := outputPath.ReplaceExtension(ctx, "art") |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 683 | |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 684 | rule := android.NewRuleBuilder(pctx, ctx) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 685 | |
| 686 | rule.Command().Text("mkdir").Flag("-p").Flag(symbolsDir.String()) |
| 687 | rule.Command().Text("rm").Flag("-f"). |
| 688 | Flag(symbolsDir.Join(ctx, "*.art").String()). |
| 689 | Flag(symbolsDir.Join(ctx, "*.oat").String()). |
| 690 | Flag(symbolsDir.Join(ctx, "*.invocation").String()) |
| 691 | rule.Command().Text("rm").Flag("-f"). |
| 692 | Flag(outputDir.Join(ctx, "*.art").String()). |
| 693 | Flag(outputDir.Join(ctx, "*.oat").String()). |
| 694 | Flag(outputDir.Join(ctx, "*.invocation").String()) |
| 695 | |
| 696 | cmd := rule.Command() |
| 697 | |
| 698 | extraFlags := ctx.Config().Getenv("ART_BOOT_IMAGE_EXTRA_ARGS") |
| 699 | if extraFlags == "" { |
| 700 | // Use ANDROID_LOG_TAGS to suppress most logging by default... |
| 701 | cmd.Text(`ANDROID_LOG_TAGS="*:e"`) |
| 702 | } else { |
| 703 | // ...unless the boot image is generated specifically for testing, then allow all logging. |
| 704 | cmd.Text(`ANDROID_LOG_TAGS="*:v"`) |
| 705 | } |
| 706 | |
| 707 | invocationPath := outputPath.ReplaceExtension(ctx, "invocation") |
| 708 | |
Martin Stjernholm | 75a48d8 | 2020-01-10 20:32:59 +0000 | [diff] [blame] | 709 | cmd.Tool(globalSoong.Dex2oat). |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 710 | Flag("--avoid-storing-invocation"). |
Colin Cross | 69f59a3 | 2019-02-15 10:39:37 -0800 | [diff] [blame] | 711 | FlagWithOutput("--write-invocation-to=", invocationPath).ImplicitOutput(invocationPath). |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 712 | Flag("--runtime-arg").FlagWithArg("-Xms", global.Dex2oatImageXms). |
| 713 | Flag("--runtime-arg").FlagWithArg("-Xmx", global.Dex2oatImageXmx) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 714 | |
Colin Cross | 69f59a3 | 2019-02-15 10:39:37 -0800 | [diff] [blame] | 715 | if profile != nil { |
Colin Cross | 69f59a3 | 2019-02-15 10:39:37 -0800 | [diff] [blame] | 716 | cmd.FlagWithInput("--profile-file=", profile) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 717 | } |
| 718 | |
Jiakai Zhang | c08c162 | 2023-05-10 18:38:34 +0100 | [diff] [blame^] | 719 | fragments := make(map[string]commonBootclasspathFragment) |
| 720 | ctx.VisitDirectDepsWithTag(bootclasspathFragmentDepTag, func(child android.Module) { |
| 721 | fragment := child.(commonBootclasspathFragment) |
| 722 | if fragment.getImageName() != nil && android.IsModulePreferred(child) { |
| 723 | fragments[*fragment.getImageName()] = fragment |
| 724 | } |
| 725 | }) |
| 726 | |
| 727 | for _, profileImport := range image.profileImports { |
| 728 | fragment := fragments[profileImport.name] |
| 729 | if fragment == nil { |
| 730 | ctx.ModuleErrorf("Boot image config '%[1]s' imports profile from '%[2]s', but a "+ |
| 731 | "bootclasspath_fragment with image name '%[2]s' doesn't exist or is not added as a "+ |
| 732 | "dependency of '%[1]s'", |
| 733 | image.name, |
| 734 | profileImport.name) |
| 735 | return bootImageVariantOutputs{} |
| 736 | } |
| 737 | if fragment.getProfilePath() == nil { |
| 738 | ctx.ModuleErrorf("Boot image config '%[1]s' imports profile from '%[2]s', but '%[2]s' "+ |
| 739 | "doesn't provide a profile", |
| 740 | image.name, |
| 741 | profileImport.name) |
| 742 | return bootImageVariantOutputs{} |
| 743 | } |
| 744 | cmd.FlagWithInput("--profile-file=", fragment.getProfilePath()) |
| 745 | } |
| 746 | |
Nicolas Geoffray | 1086e60 | 2021-01-20 14:30:40 +0000 | [diff] [blame] | 747 | dirtyImageFile := "frameworks/base/config/dirty-image-objects" |
| 748 | dirtyImagePath := android.ExistentPathForSource(ctx, dirtyImageFile) |
| 749 | if dirtyImagePath.Valid() { |
| 750 | cmd.FlagWithInput("--dirty-image-objects=", dirtyImagePath.Path()) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 751 | } |
| 752 | |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 753 | if image.extends != nil { |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 754 | // It is a boot image extension, so it needs the boot images that it depends on. |
| 755 | baseImageLocations := make([]string, 0, len(image.baseImages)) |
| 756 | for _, image := range image.baseImages { |
| 757 | baseImageLocations = append(baseImageLocations, dexpreopt.PathToLocation(image, arch)) |
| 758 | } |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 759 | cmd. |
| 760 | Flag("--runtime-arg").FlagWithInputList("-Xbootclasspath:", image.dexPathsDeps.Paths(), ":"). |
| 761 | Flag("--runtime-arg").FlagWithList("-Xbootclasspath-locations:", image.dexLocationsDeps, ":"). |
Paul Duffin | bff50e2 | 2021-06-04 17:25:28 +0100 | [diff] [blame] | 762 | // Add the path to the first file in the boot image with the arch specific directory removed, |
| 763 | // dex2oat will reconstruct the path to the actual file when it needs it. As the actual path |
| 764 | // to the file cannot be passed to the command make sure to add the actual path as an Implicit |
| 765 | // dependency to ensure that it is built before the command runs. |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 766 | FlagWithList("--boot-image=", baseImageLocations, ":").Implicits(image.baseImages.Paths()). |
Paul Duffin | bff50e2 | 2021-06-04 17:25:28 +0100 | [diff] [blame] | 767 | // Similarly, the dex2oat tool will automatically find the paths to other files in the base |
| 768 | // boot image so make sure to add them as implicit dependencies to ensure that they are built |
| 769 | // before this command is run. |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 770 | Implicits(image.baseImagesDeps) |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 771 | } else { |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 772 | // It is a primary image, so it needs a base address. |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 773 | cmd.FlagWithArg("--base=", ctx.Config().LibartImgDeviceBaseAddress()) |
| 774 | } |
| 775 | |
Jiakai Zhang | 8e9ea8b | 2023-02-23 17:50:46 +0000 | [diff] [blame] | 776 | if len(image.preloadedClassesFile) > 0 { |
| 777 | // We always expect a preloaded classes file to be available. However, if we cannot find it, it's |
| 778 | // OK to not pass the flag to dex2oat. |
| 779 | preloadedClassesPath := android.ExistentPathForSource(ctx, image.preloadedClassesFile) |
| 780 | if preloadedClassesPath.Valid() { |
| 781 | cmd.FlagWithInput("--preloaded-classes=", preloadedClassesPath.Path()) |
| 782 | } |
Nicolas Geoffray | b9a46fb | 2022-03-14 15:31:47 +0000 | [diff] [blame] | 783 | } |
| 784 | |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 785 | cmd. |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 786 | FlagForEachInput("--dex-file=", image.dexPaths.Paths()). |
| 787 | FlagForEachArg("--dex-location=", image.dexLocations). |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 788 | Flag("--generate-debug-info"). |
| 789 | Flag("--generate-build-id"). |
Mathieu Chartier | 54fd807 | 2019-07-26 13:50:04 -0700 | [diff] [blame] | 790 | Flag("--image-format=lz4hc"). |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 791 | FlagWithArg("--oat-symbols=", symbolsFile.String()). |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 792 | Flag("--strip"). |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 793 | FlagWithArg("--oat-file=", outputPath.String()). |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 794 | FlagWithArg("--oat-location=", oatLocation). |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 795 | FlagWithArg("--image=", imagePath.String()). |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 796 | FlagWithArg("--instruction-set=", arch.String()). |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 797 | FlagWithArg("--android-root=", global.EmptyDirectory). |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 798 | FlagWithArg("--no-inline-from=", "core-oj.jar"). |
Ulya Trafimovich | c0c98d5 | 2020-03-09 12:46:06 +0000 | [diff] [blame] | 799 | Flag("--force-determinism"). |
Jiakai Zhang | 63086d7 | 2023-02-28 15:13:44 +0000 | [diff] [blame] | 800 | Flag("--abort-on-hard-verifier-error") |
| 801 | |
| 802 | // If the image is profile-guided but the profile is disabled, we omit "--compiler-filter" to |
| 803 | // leave the decision to dex2oat to pick the compiler filter. |
| 804 | if !(image.isProfileGuided() && global.DisableGenerateProfile) { |
| 805 | cmd.FlagWithArg("--compiler-filter=", image.compilerFilter) |
| 806 | } |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 807 | |
Jiakai Zhang | b879620 | 2023-03-06 19:16:48 +0000 | [diff] [blame] | 808 | if image.singleImage { |
| 809 | cmd.Flag("--single-image") |
| 810 | } |
| 811 | |
David Srbecky | 7f8dac1 | 2020-02-13 16:00:45 +0000 | [diff] [blame] | 812 | // Use the default variant/features for host builds. |
| 813 | // The map below contains only device CPU info (which might be x86 on some devices). |
| 814 | if image.target.Os == android.Android { |
| 815 | cmd.FlagWithArg("--instruction-set-variant=", global.CpuVariant[arch]) |
| 816 | cmd.FlagWithArg("--instruction-set-features=", global.InstructionSetFeatures[arch]) |
| 817 | } |
| 818 | |
Jiakai Zhang | 616be06 | 2022-11-16 11:50:59 +0000 | [diff] [blame] | 819 | if global.EnableUffdGc { |
| 820 | cmd.Flag("--runtime-arg").Flag("-Xgc:CMC") |
| 821 | } |
| 822 | |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 823 | if global.BootFlags != "" { |
| 824 | cmd.Flag(global.BootFlags) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 825 | } |
| 826 | |
| 827 | if extraFlags != "" { |
| 828 | cmd.Flag(extraFlags) |
| 829 | } |
| 830 | |
Colin Cross | 0b9f31f | 2019-02-28 11:00:01 -0800 | [diff] [blame] | 831 | cmd.Textf(`|| ( echo %s ; false )`, proptools.ShellEscape(failureMessage)) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 832 | |
Jiakai Zhang | 09d88df | 2023-05-10 17:04:53 +0100 | [diff] [blame] | 833 | installDir := filepath.Dir(image.imagePathOnDevice) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 834 | |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 835 | var vdexInstalls android.RuleBuilderInstalls |
| 836 | var unstrippedInstalls android.RuleBuilderInstalls |
| 837 | |
Dan Willemsen | 0f41678 | 2019-06-13 21:44:53 +0000 | [diff] [blame] | 838 | for _, artOrOat := range image.moduleFiles(ctx, outputDir, ".art", ".oat") { |
| 839 | cmd.ImplicitOutput(artOrOat) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 840 | |
Dan Willemsen | 0f41678 | 2019-06-13 21:44:53 +0000 | [diff] [blame] | 841 | // Install the .oat and .art files |
| 842 | rule.Install(artOrOat, filepath.Join(installDir, artOrOat.Base())) |
| 843 | } |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 844 | |
Dan Willemsen | 0f41678 | 2019-06-13 21:44:53 +0000 | [diff] [blame] | 845 | for _, vdex := range image.moduleFiles(ctx, outputDir, ".vdex") { |
| 846 | cmd.ImplicitOutput(vdex) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 847 | |
David Srbecky | 7f8dac1 | 2020-02-13 16:00:45 +0000 | [diff] [blame] | 848 | // Note that the vdex files are identical between architectures. |
| 849 | // Make rules will create symlinks to share them between architectures. |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 850 | vdexInstalls = append(vdexInstalls, |
David Srbecky | 7f8dac1 | 2020-02-13 16:00:45 +0000 | [diff] [blame] | 851 | android.RuleBuilderInstall{vdex, filepath.Join(installDir, vdex.Base())}) |
Dan Willemsen | 0f41678 | 2019-06-13 21:44:53 +0000 | [diff] [blame] | 852 | } |
| 853 | |
| 854 | for _, unstrippedOat := range image.moduleFiles(ctx, symbolsDir, ".oat") { |
| 855 | cmd.ImplicitOutput(unstrippedOat) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 856 | |
| 857 | // Install the unstripped oat files. The Make rules will put these in $(TARGET_OUT_UNSTRIPPED) |
| 858 | unstrippedInstalls = append(unstrippedInstalls, |
Colin Cross | 69f59a3 | 2019-02-15 10:39:37 -0800 | [diff] [blame] | 859 | android.RuleBuilderInstall{unstrippedOat, filepath.Join(installDir, unstrippedOat.Base())}) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 860 | } |
| 861 | |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 862 | rule.Build(image.name+"JarsDexpreopt_"+image.target.String(), "dexpreopt "+image.name+" jars "+arch.String()) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 863 | |
| 864 | // save output and installed files for makevars |
Paul Duffin | 20d90e3 | 2022-10-04 20:01:04 +0100 | [diff] [blame] | 865 | // TODO - these are always the same and so should be initialized in genBootImageConfigs |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 866 | image.installs = rule.Installs() |
| 867 | image.vdexInstalls = vdexInstalls |
| 868 | image.unstrippedInstalls = unstrippedInstalls |
Paul Duffin | 20d90e3 | 2022-10-04 20:01:04 +0100 | [diff] [blame] | 869 | |
| 870 | // Only set the licenseMetadataFile from the active module. |
| 871 | if isActiveModule(ctx.Module()) { |
| 872 | image.licenseMetadataFile = android.OptionalPathForPath(ctx.LicenseMetadataFile()) |
| 873 | } |
Paul Duffin | e10a9f2 | 2022-10-04 16:39:18 +0100 | [diff] [blame] | 874 | |
| 875 | return bootImageVariantOutputs{ |
| 876 | image, |
Paul Duffin | e10a9f2 | 2022-10-04 16:39:18 +0100 | [diff] [blame] | 877 | } |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 878 | } |
| 879 | |
| 880 | const failureMessage = `ERROR: Dex2oat failed to compile a boot image. |
| 881 | It is likely that the boot classpath is inconsistent. |
| 882 | Rebuild with ART_BOOT_IMAGE_EXTRA_ARGS="--runtime-arg -verbose:verifier" to see verification errors.` |
| 883 | |
Paul Duffin | 2fc82ad | 2021-04-29 23:36:12 +0100 | [diff] [blame] | 884 | func bootImageProfileRule(ctx android.ModuleContext, image *bootImageConfig) android.WritablePath { |
Jiakai Zhang | 8e9ea8b | 2023-02-23 17:50:46 +0000 | [diff] [blame] | 885 | if !image.isProfileGuided() { |
| 886 | return nil |
| 887 | } |
| 888 | |
Paul Duffin | 8fc51a8 | 2021-07-06 10:55:35 +0100 | [diff] [blame] | 889 | globalSoong := dexpreopt.GetGlobalSoongConfig(ctx) |
Martin Stjernholm | 40f9f3c | 2020-01-20 18:12:23 +0000 | [diff] [blame] | 890 | global := dexpreopt.GetGlobalConfig(ctx) |
Nicolas Geoffray | 27c7cc6 | 2019-02-24 16:04:52 +0000 | [diff] [blame] | 891 | |
Ulya Trafimovich | a4a1c4e | 2021-01-15 18:40:04 +0000 | [diff] [blame] | 892 | if global.DisableGenerateProfile { |
Nicolas Geoffray | 27c7cc6 | 2019-02-24 16:04:52 +0000 | [diff] [blame] | 893 | return nil |
| 894 | } |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 895 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 896 | defaultProfile := "frameworks/base/config/boot-image-profile.txt" |
Nicolas Geoffray | 58d349c | 2022-07-11 14:59:14 +0100 | [diff] [blame] | 897 | extraProfile := "frameworks/base/config/boot-image-profile-extra.txt" |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 898 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 899 | rule := android.NewRuleBuilder(pctx, ctx) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 900 | |
Nicolas Geoffray | 58d349c | 2022-07-11 14:59:14 +0100 | [diff] [blame] | 901 | var profiles android.Paths |
| 902 | if len(global.BootImageProfiles) > 0 { |
| 903 | profiles = append(profiles, global.BootImageProfiles...) |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 904 | } else if path := android.ExistentPathForSource(ctx, defaultProfile); path.Valid() { |
Nicolas Geoffray | 58d349c | 2022-07-11 14:59:14 +0100 | [diff] [blame] | 905 | profiles = append(profiles, path.Path()) |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 906 | } else { |
| 907 | // No profile (not even a default one, which is the case on some branches |
| 908 | // like master-art-host that don't have frameworks/base). |
| 909 | // Return nil and continue without profile. |
| 910 | return nil |
Ulyana Trafimovich | de53441 | 2019-11-08 10:51:01 +0000 | [diff] [blame] | 911 | } |
Nicolas Geoffray | 58d349c | 2022-07-11 14:59:14 +0100 | [diff] [blame] | 912 | if path := android.ExistentPathForSource(ctx, extraProfile); path.Valid() { |
| 913 | profiles = append(profiles, path.Path()) |
| 914 | } |
| 915 | bootImageProfile := image.dir.Join(ctx, "boot-image-profile.txt") |
| 916 | rule.Command().Text("cat").Inputs(profiles).Text(">").Output(bootImageProfile) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 917 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 918 | profile := image.dir.Join(ctx, "boot.prof") |
| 919 | |
| 920 | rule.Command(). |
| 921 | Text(`ANDROID_LOG_TAGS="*:e"`). |
| 922 | Tool(globalSoong.Profman). |
| 923 | Flag("--output-profile-type=boot"). |
| 924 | FlagWithInput("--create-profile-from=", bootImageProfile). |
| 925 | FlagForEachInput("--apk=", image.dexPathsDeps.Paths()). |
| 926 | FlagForEachArg("--dex-location=", image.getAnyAndroidVariant().dexLocationsDeps). |
| 927 | FlagWithOutput("--reference-profile-file=", profile) |
| 928 | |
Jiakai Zhang | 49b1eb6 | 2021-11-26 18:09:27 +0000 | [diff] [blame] | 929 | if image == defaultBootImageConfig(ctx) { |
| 930 | rule.Install(profile, "/system/etc/boot-image.prof") |
| 931 | image.profileInstalls = append(image.profileInstalls, rule.Installs()...) |
Colin Cross | e7fe096 | 2022-03-15 17:49:24 -0700 | [diff] [blame] | 932 | image.profileLicenseMetadataFile = android.OptionalPathForPath(ctx.LicenseMetadataFile()) |
Jiakai Zhang | 49b1eb6 | 2021-11-26 18:09:27 +0000 | [diff] [blame] | 933 | } |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 934 | |
| 935 | rule.Build("bootJarsProfile", "profile boot jars") |
| 936 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 937 | return profile |
| 938 | } |
Nicolas Geoffray | 72892f1 | 2019-02-22 15:34:40 +0000 | [diff] [blame] | 939 | |
Paul Duffin | ad19d38 | 2021-04-26 16:44:00 +0100 | [diff] [blame] | 940 | // bootFrameworkProfileRule generates the rule to create the boot framework profile and |
| 941 | // returns a path to the generated file. |
| 942 | func bootFrameworkProfileRule(ctx android.ModuleContext, image *bootImageConfig) android.WritablePath { |
| 943 | globalSoong := dexpreopt.GetGlobalSoongConfig(ctx) |
Martin Stjernholm | 40f9f3c | 2020-01-20 18:12:23 +0000 | [diff] [blame] | 944 | global := dexpreopt.GetGlobalConfig(ctx) |
Nicolas Geoffray | e710242 | 2019-07-24 13:19:29 +0100 | [diff] [blame] | 945 | |
Dan Willemsen | 9f43597 | 2020-05-28 15:28:00 -0700 | [diff] [blame] | 946 | if global.DisableGenerateProfile || ctx.Config().UnbundledBuild() { |
Nicolas Geoffray | e710242 | 2019-07-24 13:19:29 +0100 | [diff] [blame] | 947 | return nil |
| 948 | } |
Nicolas Geoffray | e710242 | 2019-07-24 13:19:29 +0100 | [diff] [blame] | 949 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 950 | defaultProfile := "frameworks/base/config/boot-profile.txt" |
Paul Duffin | 2ac45f0 | 2021-04-26 17:08:38 +0100 | [diff] [blame] | 951 | bootFrameworkProfile := android.PathForSource(ctx, defaultProfile) |
Nicolas Geoffray | e710242 | 2019-07-24 13:19:29 +0100 | [diff] [blame] | 952 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 953 | profile := image.dir.Join(ctx, "boot.bprof") |
Nicolas Geoffray | e710242 | 2019-07-24 13:19:29 +0100 | [diff] [blame] | 954 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 955 | rule := android.NewRuleBuilder(pctx, ctx) |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 956 | rule.Command(). |
| 957 | Text(`ANDROID_LOG_TAGS="*:e"`). |
| 958 | Tool(globalSoong.Profman). |
| 959 | Flag("--output-profile-type=bprof"). |
| 960 | FlagWithInput("--create-profile-from=", bootFrameworkProfile). |
| 961 | FlagForEachInput("--apk=", image.dexPathsDeps.Paths()). |
| 962 | FlagForEachArg("--dex-location=", image.getAnyAndroidVariant().dexLocationsDeps). |
| 963 | FlagWithOutput("--reference-profile-file=", profile) |
Nicolas Geoffray | e710242 | 2019-07-24 13:19:29 +0100 | [diff] [blame] | 964 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 965 | rule.Install(profile, "/system/etc/boot-image.bprof") |
| 966 | rule.Build("bootFrameworkProfile", "profile boot framework jars") |
| 967 | image.profileInstalls = append(image.profileInstalls, rule.Installs()...) |
Colin Cross | e7fe096 | 2022-03-15 17:49:24 -0700 | [diff] [blame] | 968 | image.profileLicenseMetadataFile = android.OptionalPathForPath(ctx.LicenseMetadataFile()) |
Nicolas Geoffray | e710242 | 2019-07-24 13:19:29 +0100 | [diff] [blame] | 969 | |
Paul Duffin | 5861242 | 2021-04-26 12:51:07 +0100 | [diff] [blame] | 970 | return profile |
Nicolas Geoffray | e710242 | 2019-07-24 13:19:29 +0100 | [diff] [blame] | 971 | } |
| 972 | |
Paul Duffin | f7a5592 | 2021-04-26 23:09:15 +0100 | [diff] [blame] | 973 | func dumpOatRules(ctx android.ModuleContext, image *bootImageConfig) { |
Colin Cross | c9a4c36 | 2019-02-26 21:13:48 -0800 | [diff] [blame] | 974 | var allPhonies android.Paths |
David Srbecky | c177ebe | 2020-02-18 20:43:06 +0000 | [diff] [blame] | 975 | for _, image := range image.variants { |
| 976 | arch := image.target.Arch.ArchType |
David Srbecky | 4667232 | 2020-03-16 13:27:55 +0000 | [diff] [blame] | 977 | suffix := arch.String() |
| 978 | // Host and target might both use x86 arch. We need to ensure the names are unique. |
| 979 | if image.target.Os.Class == android.Host { |
| 980 | suffix = "host-" + suffix |
| 981 | } |
Colin Cross | c9a4c36 | 2019-02-26 21:13:48 -0800 | [diff] [blame] | 982 | // Create a rule to call oatdump. |
David Srbecky | 7f8dac1 | 2020-02-13 16:00:45 +0000 | [diff] [blame] | 983 | output := android.PathForOutput(ctx, "boot."+suffix+".oatdump.txt") |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 984 | rule := android.NewRuleBuilder(pctx, ctx) |
Jeongik Cha | 4dda75e | 2021-04-27 23:56:44 +0900 | [diff] [blame] | 985 | imageLocationsOnHost, _ := image.imageLocations() |
Colin Cross | c9a4c36 | 2019-02-26 21:13:48 -0800 | [diff] [blame] | 986 | rule.Command(). |
Martin Stjernholm | 0780372 | 2021-05-18 17:39:56 +0100 | [diff] [blame] | 987 | BuiltTool("oatdump"). |
Ulya Trafimovich | 4d2eeed | 2019-11-08 10:54:21 +0000 | [diff] [blame] | 988 | FlagWithInputList("--runtime-arg -Xbootclasspath:", image.dexPathsDeps.Paths(), ":"). |
| 989 | FlagWithList("--runtime-arg -Xbootclasspath-locations:", image.dexLocationsDeps, ":"). |
Jeongik Cha | 4dda75e | 2021-04-27 23:56:44 +0900 | [diff] [blame] | 990 | FlagWithArg("--image=", strings.Join(imageLocationsOnHost, ":")).Implicits(image.imagesDeps.Paths()). |
Colin Cross | c9a4c36 | 2019-02-26 21:13:48 -0800 | [diff] [blame] | 991 | FlagWithOutput("--output=", output). |
| 992 | FlagWithArg("--instruction-set=", arch.String()) |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 993 | rule.Build("dump-oat-boot-"+suffix, "dump oat boot "+arch.String()) |
Colin Cross | c9a4c36 | 2019-02-26 21:13:48 -0800 | [diff] [blame] | 994 | |
| 995 | // Create a phony rule that depends on the output file and prints the path. |
David Srbecky | 7f8dac1 | 2020-02-13 16:00:45 +0000 | [diff] [blame] | 996 | phony := android.PathForPhony(ctx, "dump-oat-boot-"+suffix) |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 997 | rule = android.NewRuleBuilder(pctx, ctx) |
Colin Cross | c9a4c36 | 2019-02-26 21:13:48 -0800 | [diff] [blame] | 998 | rule.Command(). |
| 999 | Implicit(output). |
| 1000 | ImplicitOutput(phony). |
| 1001 | Text("echo").FlagWithArg("Output in ", output.String()) |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 1002 | rule.Build("phony-dump-oat-boot-"+suffix, "dump oat boot "+arch.String()) |
Colin Cross | c9a4c36 | 2019-02-26 21:13:48 -0800 | [diff] [blame] | 1003 | |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 1004 | allPhonies = append(allPhonies, phony) |
Colin Cross | c9a4c36 | 2019-02-26 21:13:48 -0800 | [diff] [blame] | 1005 | } |
| 1006 | |
| 1007 | phony := android.PathForPhony(ctx, "dump-oat-boot") |
| 1008 | ctx.Build(pctx, android.BuildParams{ |
| 1009 | Rule: android.Phony, |
| 1010 | Output: phony, |
| 1011 | Inputs: allPhonies, |
| 1012 | Description: "dump-oat-boot", |
| 1013 | }) |
Colin Cross | c9a4c36 | 2019-02-26 21:13:48 -0800 | [diff] [blame] | 1014 | } |
| 1015 | |
Colin Cross | 2d00f0d | 2019-05-09 21:50:00 -0700 | [diff] [blame] | 1016 | func writeGlobalConfigForMake(ctx android.SingletonContext, path android.WritablePath) { |
Martin Stjernholm | 40f9f3c | 2020-01-20 18:12:23 +0000 | [diff] [blame] | 1017 | data := dexpreopt.GetGlobalConfigRawData(ctx) |
Colin Cross | 2d00f0d | 2019-05-09 21:50:00 -0700 | [diff] [blame] | 1018 | |
Colin Cross | cf371cc | 2020-11-13 11:48:42 -0800 | [diff] [blame] | 1019 | android.WriteFileRule(ctx, path, string(data)) |
Colin Cross | 2d00f0d | 2019-05-09 21:50:00 -0700 | [diff] [blame] | 1020 | } |
| 1021 | |
Ulya Trafimovich | 3bfabf2 | 2020-11-20 17:28:51 +0000 | [diff] [blame] | 1022 | // Define Make variables for boot image names, paths, etc. These variables are used in makefiles |
| 1023 | // (make/core/dex_preopt_libart.mk) to generate install rules that copy boot image files to the |
| 1024 | // correct output directories. |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 1025 | func (d *dexpreoptBootJars) MakeVars(ctx android.MakeVarsContext) { |
Jiakai Zhang | bc698cd | 2023-05-08 16:28:38 +0000 | [diff] [blame] | 1026 | if d.dexpreoptConfigForMake != nil && !SkipDexpreoptBootJars(ctx) { |
Colin Cross | 2d00f0d | 2019-05-09 21:50:00 -0700 | [diff] [blame] | 1027 | ctx.Strict("DEX_PREOPT_CONFIG_FOR_MAKE", d.dexpreoptConfigForMake.String()) |
Martin Stjernholm | c52aaf1 | 2020-01-06 23:11:37 +0000 | [diff] [blame] | 1028 | ctx.Strict("DEX_PREOPT_SOONG_CONFIG_FOR_MAKE", android.PathForOutput(ctx, "dexpreopt_soong.config").String()) |
Colin Cross | 2d00f0d | 2019-05-09 21:50:00 -0700 | [diff] [blame] | 1029 | } |
| 1030 | |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 1031 | image := d.defaultBootImage |
| 1032 | if image != nil { |
Colin Cross | 44df581 | 2019-02-15 23:06:46 -0800 | [diff] [blame] | 1033 | ctx.Strict("DEXPREOPT_IMAGE_PROFILE_BUILT_INSTALLED", image.profileInstalls.String()) |
Colin Cross | e7fe096 | 2022-03-15 17:49:24 -0700 | [diff] [blame] | 1034 | if image.profileLicenseMetadataFile.Valid() { |
| 1035 | ctx.Strict("DEXPREOPT_IMAGE_PROFILE_LICENSE_METADATA", image.profileLicenseMetadataFile.String()) |
| 1036 | } |
Ulya Trafimovich | 9023b02 | 2021-03-22 16:02:28 +0000 | [diff] [blame] | 1037 | |
Jiakai Zhang | bc698cd | 2023-05-08 16:28:38 +0000 | [diff] [blame] | 1038 | if SkipDexpreoptBootJars(ctx) { |
| 1039 | return |
| 1040 | } |
| 1041 | |
Ulya Trafimovich | 9023b02 | 2021-03-22 16:02:28 +0000 | [diff] [blame] | 1042 | global := dexpreopt.GetGlobalConfig(ctx) |
| 1043 | dexPaths, dexLocations := bcpForDexpreopt(ctx, global.PreoptWithUpdatableBcp) |
| 1044 | ctx.Strict("DEXPREOPT_BOOTCLASSPATH_DEX_FILES", strings.Join(dexPaths.Strings(), " ")) |
| 1045 | ctx.Strict("DEXPREOPT_BOOTCLASSPATH_DEX_LOCATIONS", strings.Join(dexLocations, " ")) |
Nicolas Geoffray | 72892f1 | 2019-02-22 15:34:40 +0000 | [diff] [blame] | 1046 | |
| 1047 | var imageNames []string |
Ulya Trafimovich | 442ec7f | 2022-04-20 10:53:26 +0100 | [diff] [blame] | 1048 | // The primary ART boot image is exposed to Make for testing (gtests) and benchmarking |
| 1049 | // (golem) purposes. |
Nicolas Geoffray | 72892f1 | 2019-02-22 15:34:40 +0000 | [diff] [blame] | 1050 | for _, current := range append(d.otherImages, image) { |
| 1051 | imageNames = append(imageNames, current.name) |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 1052 | for _, variant := range current.variants { |
David Srbecky | 7f8dac1 | 2020-02-13 16:00:45 +0000 | [diff] [blame] | 1053 | suffix := "" |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 1054 | if variant.target.Os.Class == android.Host { |
David Srbecky | 7f8dac1 | 2020-02-13 16:00:45 +0000 | [diff] [blame] | 1055 | suffix = "_host" |
| 1056 | } |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 1057 | sfx := variant.name + suffix + "_" + variant.target.Arch.ArchType.String() |
| 1058 | ctx.Strict("DEXPREOPT_IMAGE_VDEX_BUILT_INSTALLED_"+sfx, variant.vdexInstalls.String()) |
Jeongik Cha | a596909 | 2021-05-07 18:53:21 +0900 | [diff] [blame] | 1059 | ctx.Strict("DEXPREOPT_IMAGE_"+sfx, variant.imagePathOnHost.String()) |
David Srbecky | 1aacc6c | 2020-03-26 11:10:45 +0000 | [diff] [blame] | 1060 | ctx.Strict("DEXPREOPT_IMAGE_DEPS_"+sfx, strings.Join(variant.imagesDeps.Strings(), " ")) |
| 1061 | ctx.Strict("DEXPREOPT_IMAGE_BUILT_INSTALLED_"+sfx, variant.installs.String()) |
| 1062 | ctx.Strict("DEXPREOPT_IMAGE_UNSTRIPPED_BUILT_INSTALLED_"+sfx, variant.unstrippedInstalls.String()) |
Colin Cross | e7fe096 | 2022-03-15 17:49:24 -0700 | [diff] [blame] | 1063 | if variant.licenseMetadataFile.Valid() { |
| 1064 | ctx.Strict("DEXPREOPT_IMAGE_LICENSE_METADATA_"+sfx, variant.licenseMetadataFile.String()) |
| 1065 | } |
Nicolas Geoffray | 72892f1 | 2019-02-22 15:34:40 +0000 | [diff] [blame] | 1066 | } |
Jeongik Cha | e3165c8 | 2021-06-23 23:18:50 +0900 | [diff] [blame] | 1067 | imageLocationsOnHost, imageLocationsOnDevice := current.getAnyAndroidVariant().imageLocations() |
| 1068 | ctx.Strict("DEXPREOPT_IMAGE_LOCATIONS_ON_HOST"+current.name, strings.Join(imageLocationsOnHost, ":")) |
| 1069 | ctx.Strict("DEXPREOPT_IMAGE_LOCATIONS_ON_DEVICE"+current.name, strings.Join(imageLocationsOnDevice, ":")) |
Colin Cross | 31bf00d | 2019-12-04 13:16:01 -0800 | [diff] [blame] | 1070 | ctx.Strict("DEXPREOPT_IMAGE_ZIP_"+current.name, current.zip.String()) |
Nicolas Geoffray | 72892f1 | 2019-02-22 15:34:40 +0000 | [diff] [blame] | 1071 | } |
Jiakai Zhang | 8fe3a41 | 2023-02-23 17:37:16 +0000 | [diff] [blame] | 1072 | // Ensure determinism. |
| 1073 | sort.Strings(imageNames) |
Nicolas Geoffray | 72892f1 | 2019-02-22 15:34:40 +0000 | [diff] [blame] | 1074 | ctx.Strict("DEXPREOPT_IMAGE_NAMES", strings.Join(imageNames, " ")) |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 1075 | } |
Colin Cross | 800fe13 | 2019-02-11 14:21:24 -0800 | [diff] [blame] | 1076 | } |