blob: 0da3ec7d04df38ef0167d11e9a97808e6799a2c0 [file] [log] [blame]
Colin Cross6362e272015-10-29 15:25:03 -07001// Copyright 2015 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
Colin Cross635c3b02016-05-18 15:37:25 -070015package android
Colin Cross6362e272015-10-29 15:25:03 -070016
Colin Cross795c3772017-03-16 16:50:10 -070017import (
Colin Cross984223f2024-02-01 17:10:23 -080018 "sync"
19
Colin Cross795c3772017-03-16 16:50:10 -070020 "github.com/google/blueprint"
21)
Colin Cross6362e272015-10-29 15:25:03 -070022
Jeff Gastonaf3cc2d2017-09-27 17:01:44 -070023// Phases:
24// run Pre-arch mutators
25// run archMutator
26// run Pre-deps mutators
27// run depsMutator
28// run PostDeps mutators
Colin Cross1e954b62024-09-13 13:50:00 -070029// run FinalDeps mutators (TransitionMutators disallowed in this phase)
Jeff Gastonaf3cc2d2017-09-27 17:01:44 -070030// continue on to GenerateAndroidBuildActions
Colin Cross1e676be2016-10-12 14:38:15 -070031
Paul Duffinc05b0342021-03-06 13:28:13 +000032// collateGloballyRegisteredMutators constructs the list of mutators that have been registered
33// with the InitRegistrationContext and will be used at runtime.
34func collateGloballyRegisteredMutators() sortableComponents {
Colin Crossf22fe412024-10-01 14:02:12 -070035 return collateRegisteredMutators(preArch, preDeps, postDeps, postApex, finalDeps)
Paul Duffinc05b0342021-03-06 13:28:13 +000036}
37
38// collateRegisteredMutators constructs a single list of mutators from the separate lists.
Colin Crossf22fe412024-10-01 14:02:12 -070039func collateRegisteredMutators(preArch, preDeps, postDeps, postApex, finalDeps []RegisterMutatorFunc) sortableComponents {
Colin Crosscec81712017-07-13 14:43:27 -070040 mctx := &registerMutatorsContext{}
Nan Zhangdb0b9a32017-02-27 10:12:13 -080041
42 register := func(funcs []RegisterMutatorFunc) {
43 for _, f := range funcs {
Colin Crosscec81712017-07-13 14:43:27 -070044 f(mctx)
Nan Zhangdb0b9a32017-02-27 10:12:13 -080045 }
46 }
47
Colin Crosscec81712017-07-13 14:43:27 -070048 register(preArch)
Nan Zhangdb0b9a32017-02-27 10:12:13 -080049
Colin Crosscec81712017-07-13 14:43:27 -070050 register(preDeps)
51
Liz Kammer356f7d42021-01-26 09:18:53 -050052 register([]RegisterMutatorFunc{registerDepsMutator})
Colin Crosscec81712017-07-13 14:43:27 -070053
54 register(postDeps)
55
Colin Crossf22fe412024-10-01 14:02:12 -070056 register(postApex)
57
Martin Stjernholm710ec3a2020-01-16 15:12:04 +000058 mctx.finalPhase = true
59 register(finalDeps)
60
Paul Duffinc05b0342021-03-06 13:28:13 +000061 return mctx.mutators
Colin Cross795c3772017-03-16 16:50:10 -070062}
63
64type registerMutatorsContext struct {
Colin Crossb63d7b32023-12-07 16:54:51 -080065 mutators sortableComponents
66 finalPhase bool
Colin Cross795c3772017-03-16 16:50:10 -070067}
Colin Cross1e676be2016-10-12 14:38:15 -070068
69type RegisterMutatorsContext interface {
Colin Cross25de6c32019-06-06 14:29:25 -070070 TopDown(name string, m TopDownMutator) MutatorHandle
71 BottomUp(name string, m BottomUpMutator) MutatorHandle
Colin Cross617b88a2020-08-24 18:04:09 -070072 BottomUpBlueprint(name string, m blueprint.BottomUpMutator) MutatorHandle
Lukacs T. Berki6c716762022-06-13 20:50:39 +020073 Transition(name string, m TransitionMutator)
Colin Cross1e676be2016-10-12 14:38:15 -070074}
75
76type RegisterMutatorFunc func(RegisterMutatorsContext)
77
Colin Crosscec81712017-07-13 14:43:27 -070078var preArch = []RegisterMutatorFunc{
Dan Willemsen6e72ef72018-01-26 18:27:02 -080079 RegisterNamespaceMutator,
Paul Duffinaa4162e2020-05-05 11:35:43 +010080
Paul Duffinaa4162e2020-05-05 11:35:43 +010081 // Check the visibility rules are valid.
82 //
83 // This must run after the package renamer mutators so that any issues found during
84 // validation of the package's default_visibility property are reported using the
85 // correct package name and not the synthetic name.
86 //
87 // This must also be run before defaults mutators as the rules for validation are
88 // different before checking the rules than they are afterwards. e.g.
89 // visibility: ["//visibility:private", "//visibility:public"]
90 // would be invalid if specified in a module definition but is valid if it results
91 // from something like this:
92 //
93 // defaults {
94 // name: "defaults",
95 // // Be inaccessible outside a package by default.
96 // visibility: ["//visibility:private"]
97 // }
98 //
99 // defaultable_module {
100 // name: "defaultable_module",
101 // defaults: ["defaults"],
102 // // Override the default.
103 // visibility: ["//visibility:public"]
104 // }
105 //
Paul Duffin593b3c92019-12-05 14:31:48 +0000106 RegisterVisibilityRuleChecker,
Paul Duffinaa4162e2020-05-05 11:35:43 +0100107
Bob Badour37af0462021-01-07 03:34:31 +0000108 // Record the default_applicable_licenses for each package.
109 //
110 // This must run before the defaults so that defaults modules can pick up the package default.
111 RegisterLicensesPackageMapper,
112
Paul Duffinaa4162e2020-05-05 11:35:43 +0100113 // Apply properties from defaults modules to the referencing modules.
Paul Duffinafa9fa12020-04-29 16:47:28 +0100114 //
115 // Any mutators that are added before this will not see any modules created by
116 // a DefaultableHook.
Colin Cross89536d42017-07-07 14:35:50 -0700117 RegisterDefaultsPreArchMutators,
Paul Duffinaa4162e2020-05-05 11:35:43 +0100118
Paul Duffin44f1d842020-06-26 20:17:02 +0100119 // Add dependencies on any components so that any component references can be
120 // resolved within the deps mutator.
121 //
122 // Must be run after defaults so it can be used to create dependencies on the
123 // component modules that are creating in a DefaultableHook.
124 //
125 // Must be run before RegisterPrebuiltsPreArchMutators, i.e. before prebuilts are
126 // renamed. That is so that if a module creates components using a prebuilt module
127 // type that any dependencies (which must use prebuilt_ prefixes) are resolved to
128 // the prebuilt module and not the source module.
129 RegisterComponentsMutator,
130
Paul Duffinc988c8e2020-04-29 18:27:14 +0100131 // Create an association between prebuilt modules and their corresponding source
132 // modules (if any).
Paul Duffinafa9fa12020-04-29 16:47:28 +0100133 //
134 // Must be run after defaults mutators to ensure that any modules created by
135 // a DefaultableHook can be either a prebuilt or a source module with a matching
136 // prebuilt.
Paul Duffinc988c8e2020-04-29 18:27:14 +0100137 RegisterPrebuiltsPreArchMutators,
138
Bob Badour37af0462021-01-07 03:34:31 +0000139 // Gather the licenses properties for all modules for use during expansion and enforcement.
140 //
141 // This must come after the defaults mutators to ensure that any licenses supplied
142 // in a defaults module has been successfully applied before the rules are gathered.
143 RegisterLicensesPropertyGatherer,
144
Paul Duffinaa4162e2020-05-05 11:35:43 +0100145 // Gather the visibility rules for all modules for us during visibility enforcement.
146 //
147 // This must come after the defaults mutators to ensure that any visibility supplied
148 // in a defaults module has been successfully applied before the rules are gathered.
Paul Duffin593b3c92019-12-05 14:31:48 +0000149 RegisterVisibilityRuleGatherer,
Colin Crosscec81712017-07-13 14:43:27 -0700150}
151
Colin Crossae4c6182017-09-15 17:33:55 -0700152func registerArchMutator(ctx RegisterMutatorsContext) {
Colin Cross8bbc3d52024-09-11 15:33:54 -0700153 ctx.Transition("os", &osTransitionMutator{})
Jihoon Kang5402bbd2024-07-31 18:37:49 +0000154 ctx.Transition("image", &imageTransitionMutator{})
Colin Cross8bbc3d52024-09-11 15:33:54 -0700155 ctx.Transition("arch", &archTransitionMutator{})
Colin Crossae4c6182017-09-15 17:33:55 -0700156}
157
Colin Crosscec81712017-07-13 14:43:27 -0700158var preDeps = []RegisterMutatorFunc{
Colin Crossae4c6182017-09-15 17:33:55 -0700159 registerArchMutator,
Colin Crosscec81712017-07-13 14:43:27 -0700160}
161
162var postDeps = []RegisterMutatorFunc{
Colin Cross1b488422019-03-04 22:33:56 -0800163 registerPathDepsMutator,
Colin Cross5ea9bcc2017-07-27 15:41:32 -0700164 RegisterPrebuiltsPostDepsMutators,
Paul Duffin593b3c92019-12-05 14:31:48 +0000165 RegisterVisibilityRuleEnforcer,
Bob Badour37af0462021-01-07 03:34:31 +0000166 RegisterLicensesDependencyChecker,
Paul Duffin45338f02021-03-30 23:07:52 +0100167 registerNeverallowMutator,
Jaewoong Jungb639a6a2019-05-10 15:16:29 -0700168 RegisterOverridePostDepsMutators,
Colin Crosscec81712017-07-13 14:43:27 -0700169}
Colin Cross1e676be2016-10-12 14:38:15 -0700170
Colin Crossf22fe412024-10-01 14:02:12 -0700171var postApex = []RegisterMutatorFunc{}
172
Martin Stjernholm710ec3a2020-01-16 15:12:04 +0000173var finalDeps = []RegisterMutatorFunc{}
174
Colin Cross1e676be2016-10-12 14:38:15 -0700175func PreArchMutators(f RegisterMutatorFunc) {
176 preArch = append(preArch, f)
177}
178
179func PreDepsMutators(f RegisterMutatorFunc) {
180 preDeps = append(preDeps, f)
181}
182
183func PostDepsMutators(f RegisterMutatorFunc) {
184 postDeps = append(postDeps, f)
185}
186
Colin Crossf22fe412024-10-01 14:02:12 -0700187func PostApexMutators(f RegisterMutatorFunc) {
188 postApex = append(postApex, f)
189}
190
Martin Stjernholm710ec3a2020-01-16 15:12:04 +0000191func FinalDepsMutators(f RegisterMutatorFunc) {
192 finalDeps = append(finalDeps, f)
193}
194
Chris Parsons637458d2023-09-19 20:09:00 +0000195type TopDownMutator func(TopDownMutatorContext)
196
197type TopDownMutatorContext interface {
Colin Crossb2388e32024-10-07 15:05:23 -0700198 BaseModuleContext
Chris Parsons637458d2023-09-19 20:09:00 +0000199}
200
Colin Cross25de6c32019-06-06 14:29:25 -0700201type topDownMutatorContext struct {
Colin Crossdc35e212019-06-06 16:13:11 -0700202 bp blueprint.TopDownMutatorContext
Colin Cross0ea8ba82019-06-06 14:33:29 -0700203 baseModuleContext
Colin Cross6362e272015-10-29 15:25:03 -0700204}
205
Colin Cross25de6c32019-06-06 14:29:25 -0700206type BottomUpMutator func(BottomUpMutatorContext)
Colin Cross6362e272015-10-29 15:25:03 -0700207
Colin Cross635c3b02016-05-18 15:37:25 -0700208type BottomUpMutatorContext interface {
Colin Crossb2388e32024-10-07 15:05:23 -0700209 BaseModuleContext
Colin Crossb63d7b32023-12-07 16:54:51 -0800210
211 // AddDependency adds a dependency to the given module. It returns a slice of modules for each
212 // dependency (some entries may be nil).
213 //
214 // If the mutator is parallel (see MutatorHandle.Parallel), this method will pause until the
215 // new dependencies have had the current mutator called on them. If the mutator is not
216 // parallel this method does not affect the ordering of the current mutator pass, but will
217 // be ordered correctly for all future mutator passes.
218 AddDependency(module blueprint.Module, tag blueprint.DependencyTag, name ...string) []blueprint.Module
Colin Crossaabf6792017-11-29 00:27:14 -0800219
Colin Cross9f35c3d2020-09-16 19:04:41 -0700220 // AddReverseDependency adds a dependency from the destination to the given module.
221 // Does not affect the ordering of the current mutator pass, but will be ordered
222 // correctly for all future mutator passes. All reverse dependencies for a destination module are
223 // collected until the end of the mutator pass, sorted by name, and then appended to the destination
Colin Crossb8533a82024-10-05 15:25:09 -0700224 // module's dependency list. May only be called by mutators that were marked with
225 // UsesReverseDependencies during registration.
Colin Crossaabf6792017-11-29 00:27:14 -0800226 AddReverseDependency(module blueprint.Module, tag blueprint.DependencyTag, name string)
Colin Cross9f35c3d2020-09-16 19:04:41 -0700227
Colin Cross9f35c3d2020-09-16 19:04:41 -0700228 // AddVariationDependencies adds deps as dependencies of the current module, but uses the variations
Colin Cross4f1dcb02020-09-16 18:45:04 -0700229 // argument to select which variant of the dependency to use. It returns a slice of modules for
230 // each dependency (some entries may be nil). A variant of the dependency must exist that matches
Usta Shresthac725f472022-01-11 02:44:21 -0500231 // all the non-local variations of the current module, plus the variations argument.
Colin Cross4f1dcb02020-09-16 18:45:04 -0700232 //
233 // If the mutator is parallel (see MutatorHandle.Parallel), this method will pause until the
234 // new dependencies have had the current mutator called on them. If the mutator is not
235 // parallel this method does not affect the ordering of the current mutator pass, but will
236 // be ordered correctly for all future mutator passes.
Usta Shresthac725f472022-01-11 02:44:21 -0500237 AddVariationDependencies(variations []blueprint.Variation, tag blueprint.DependencyTag, names ...string) []blueprint.Module
Colin Cross9f35c3d2020-09-16 19:04:41 -0700238
Colin Crossb8533a82024-10-05 15:25:09 -0700239 // AddReverseVariationDependency adds a dependency from the named module to the current
Cole Faustf4992e82024-09-30 15:16:18 -0700240 // module. The given variations will be added to the current module's varations, and then the
241 // result will be used to find the correct variation of the depending module, which must exist.
242 //
243 // Does not affect the ordering of the current mutator pass, but will be ordered
244 // correctly for all future mutator passes. All reverse dependencies for a destination module are
245 // collected until the end of the mutator pass, sorted by name, and then appended to the destination
Colin Crossb8533a82024-10-05 15:25:09 -0700246 // module's dependency list. May only be called by mutators that were marked with
247 // UsesReverseDependencies during registration.
Cole Faustf4992e82024-09-30 15:16:18 -0700248 AddReverseVariationDependency([]blueprint.Variation, blueprint.DependencyTag, string)
249
Colin Cross9f35c3d2020-09-16 19:04:41 -0700250 // AddFarVariationDependencies adds deps as dependencies of the current module, but uses the
Colin Cross4f1dcb02020-09-16 18:45:04 -0700251 // variations argument to select which variant of the dependency to use. It returns a slice of
252 // modules for each dependency (some entries may be nil). A variant of the dependency must
253 // exist that matches the variations argument, but may also have other variations.
Colin Cross9f35c3d2020-09-16 19:04:41 -0700254 // For any unspecified variation the first variant will be used.
255 //
256 // Unlike AddVariationDependencies, the variations of the current module are ignored - the
257 // dependency only needs to match the supplied variations.
Colin Cross4f1dcb02020-09-16 18:45:04 -0700258 //
259 // If the mutator is parallel (see MutatorHandle.Parallel), this method will pause until the
260 // new dependencies have had the current mutator called on them. If the mutator is not
261 // parallel this method does not affect the ordering of the current mutator pass, but will
262 // be ordered correctly for all future mutator passes.
263 AddFarVariationDependencies([]blueprint.Variation, blueprint.DependencyTag, ...string) []blueprint.Module
Colin Cross9f35c3d2020-09-16 19:04:41 -0700264
Colin Cross86771322024-05-01 14:19:51 -0700265 // ReplaceDependencies finds all the variants of the module with the specified name, then
266 // replaces all dependencies onto those variants with the current variant of this module.
Colin Crossb8533a82024-10-05 15:25:09 -0700267 // Replacements don't take effect until after the mutator pass is finished. May only
268 // be called by mutators that were marked with UsesReplaceDependencies during registration.
Colin Crossaabf6792017-11-29 00:27:14 -0800269 ReplaceDependencies(string)
Colin Cross9f35c3d2020-09-16 19:04:41 -0700270
Colin Cross86771322024-05-01 14:19:51 -0700271 // ReplaceDependenciesIf finds all the variants of the module with the specified name, then
272 // replaces all dependencies onto those variants with the current variant of this module
273 // as long as the supplied predicate returns true.
Colin Crossb8533a82024-10-05 15:25:09 -0700274 // Replacements don't take effect until after the mutator pass is finished. May only
275 // be called by mutators that were marked with UsesReplaceDependencies during registration.
Paul Duffin80342d72020-06-26 22:08:43 +0100276 ReplaceDependenciesIf(string, blueprint.ReplaceDependencyPredicate)
Colin Crossb2388e32024-10-07 15:05:23 -0700277
278 // Rename all variants of a module. The new name is not visible to calls to ModuleName,
Colin Crossb8533a82024-10-05 15:25:09 -0700279 // AddDependency or OtherModuleName until after this mutator pass is complete. May only be called
280 // by mutators that were marked with UsesRename during registration.
Colin Crossb2388e32024-10-07 15:05:23 -0700281 Rename(name string)
282
283 // CreateModule creates a new module by calling the factory method for the specified moduleType, and applies
Colin Crossb8533a82024-10-05 15:25:09 -0700284 // the specified property structs to it as if the properties were set in a blueprint file. May only
285 // be called by mutators that were marked with UsesCreateModule during registration.
Colin Crossb2388e32024-10-07 15:05:23 -0700286 CreateModule(ModuleFactory, ...interface{}) Module
Colin Cross6362e272015-10-29 15:25:03 -0700287}
288
Colin Cross984223f2024-02-01 17:10:23 -0800289// An outgoingTransitionContextImpl and incomingTransitionContextImpl is created for every dependency of every module
290// for each transition mutator. bottomUpMutatorContext and topDownMutatorContext are created once for every module
291// for every BottomUp or TopDown mutator. Use a global pool for each to avoid reallocating every time.
292var (
293 outgoingTransitionContextPool = sync.Pool{
294 New: func() any { return &outgoingTransitionContextImpl{} },
295 }
296 incomingTransitionContextPool = sync.Pool{
297 New: func() any { return &incomingTransitionContextImpl{} },
298 }
299 bottomUpMutatorContextPool = sync.Pool{
300 New: func() any { return &bottomUpMutatorContext{} },
301 }
302
303 topDownMutatorContextPool = sync.Pool{
304 New: func() any { return &topDownMutatorContext{} },
305 }
306)
307
Colin Cross25de6c32019-06-06 14:29:25 -0700308type bottomUpMutatorContext struct {
Colin Crossdc35e212019-06-06 16:13:11 -0700309 bp blueprint.BottomUpMutatorContext
Colin Cross0ea8ba82019-06-06 14:33:29 -0700310 baseModuleContext
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400311 finalPhase bool
Colin Cross6362e272015-10-29 15:25:03 -0700312}
313
Colin Cross984223f2024-02-01 17:10:23 -0800314// callers must immediately follow the call to this function with defer bottomUpMutatorContextPool.Put(mctx).
Colin Cross617b88a2020-08-24 18:04:09 -0700315func bottomUpMutatorContextFactory(ctx blueprint.BottomUpMutatorContext, a Module,
Colin Crossb63d7b32023-12-07 16:54:51 -0800316 finalPhase bool) BottomUpMutatorContext {
Colin Cross617b88a2020-08-24 18:04:09 -0700317
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400318 moduleContext := a.base().baseModuleContextFactory(ctx)
Colin Cross984223f2024-02-01 17:10:23 -0800319 mctx := bottomUpMutatorContextPool.Get().(*bottomUpMutatorContext)
320 *mctx = bottomUpMutatorContext{
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400321 bp: ctx,
Cole Faust0abd4b42023-01-10 10:49:18 -0800322 baseModuleContext: moduleContext,
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400323 finalPhase: finalPhase,
Colin Cross617b88a2020-08-24 18:04:09 -0700324 }
Colin Cross984223f2024-02-01 17:10:23 -0800325 return mctx
Colin Cross617b88a2020-08-24 18:04:09 -0700326}
327
Colin Cross25de6c32019-06-06 14:29:25 -0700328func (x *registerMutatorsContext) BottomUp(name string, m BottomUpMutator) MutatorHandle {
Martin Stjernholm710ec3a2020-01-16 15:12:04 +0000329 finalPhase := x.finalPhase
Colin Cross798bfce2016-10-12 14:28:16 -0700330 f := func(ctx blueprint.BottomUpMutatorContext) {
Colin Cross635c3b02016-05-18 15:37:25 -0700331 if a, ok := ctx.Module().(Module); ok {
Colin Cross984223f2024-02-01 17:10:23 -0800332 mctx := bottomUpMutatorContextFactory(ctx, a, finalPhase)
333 defer bottomUpMutatorContextPool.Put(mctx)
334 m(mctx)
Colin Cross6362e272015-10-29 15:25:03 -0700335 }
Colin Cross798bfce2016-10-12 14:28:16 -0700336 }
Liz Kammer356f7d42021-01-26 09:18:53 -0500337 mutator := &mutator{name: x.mutatorName(name), bottomUpMutator: f}
Colin Cross795c3772017-03-16 16:50:10 -0700338 x.mutators = append(x.mutators, mutator)
Colin Cross798bfce2016-10-12 14:28:16 -0700339 return mutator
Colin Cross6362e272015-10-29 15:25:03 -0700340}
341
Colin Cross617b88a2020-08-24 18:04:09 -0700342func (x *registerMutatorsContext) BottomUpBlueprint(name string, m blueprint.BottomUpMutator) MutatorHandle {
343 mutator := &mutator{name: name, bottomUpMutator: m}
344 x.mutators = append(x.mutators, mutator)
345 return mutator
346}
347
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200348type IncomingTransitionContext interface {
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800349 ArchModuleContext
Colin Crossaf333f52024-04-15 15:20:23 -0700350 ModuleProviderContext
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800351
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200352 // Module returns the target of the dependency edge for which the transition
353 // is being computed
354 Module() Module
355
356 // Config returns the configuration for the build.
357 Config() Config
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800358
359 DeviceConfig() DeviceConfig
Colin Crosse1a85552024-06-14 12:17:37 -0700360
361 // IsAddingDependency returns true if the transition is being called while adding a dependency
362 // after the transition mutator has already run, or false if it is being called when the transition
363 // mutator is running. This should be used sparingly, all uses will have to be removed in order
364 // to support creating variants on demand.
365 IsAddingDependency() bool
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200366}
367
368type OutgoingTransitionContext interface {
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800369 ArchModuleContext
Colin Crossaf333f52024-04-15 15:20:23 -0700370 ModuleProviderContext
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800371
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200372 // Module returns the target of the dependency edge for which the transition
373 // is being computed
374 Module() Module
375
376 // DepTag() Returns the dependency tag through which this dependency is
377 // reached
378 DepTag() blueprint.DependencyTag
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800379
380 // Config returns the configuration for the build.
381 Config() Config
382
383 DeviceConfig() DeviceConfig
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200384}
Lukacs T. Berki0e691c12022-06-24 10:15:55 +0200385
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800386// TransitionMutator implements a top-down mechanism where a module tells its
Lukacs T. Berki0e691c12022-06-24 10:15:55 +0200387// direct dependencies what variation they should be built in but the dependency
388// has the final say.
389//
390// When implementing a transition mutator, one needs to implement four methods:
391// - Split() that tells what variations a module has by itself
392// - OutgoingTransition() where a module tells what it wants from its
393// dependency
394// - IncomingTransition() where a module has the final say about its own
395// variation
396// - Mutate() that changes the state of a module depending on its variation
397//
398// That the effective variation of module B when depended on by module A is the
399// composition the outgoing transition of module A and the incoming transition
400// of module B.
401//
402// the outgoing transition should not take the properties of the dependency into
403// account, only those of the module that depends on it. For this reason, the
404// dependency is not even passed into it as an argument. Likewise, the incoming
405// transition should not take the properties of the depending module into
406// account and is thus not informed about it. This makes for a nice
407// decomposition of the decision logic.
408//
409// A given transition mutator only affects its own variation; other variations
410// stay unchanged along the dependency edges.
411//
412// Soong makes sure that all modules are created in the desired variations and
413// that dependency edges are set up correctly. This ensures that "missing
414// variation" errors do not happen and allows for more flexible changes in the
415// value of the variation among dependency edges (as oppposed to bottom-up
416// mutators where if module A in variation X depends on module B and module B
417// has that variation X, A must depend on variation X of B)
418//
419// The limited power of the context objects passed to individual mutators
420// methods also makes it more difficult to shoot oneself in the foot. Complete
421// safety is not guaranteed because no one prevents individual transition
422// mutators from mutating modules in illegal ways and for e.g. Split() or
423// Mutate() to run their own visitations of the transitive dependency of the
424// module and both of these are bad ideas, but it's better than no guardrails at
425// all.
426//
427// This model is pretty close to Bazel's configuration transitions. The mapping
428// between concepts in Soong and Bazel is as follows:
429// - Module == configured target
430// - Variant == configuration
431// - Variation name == configuration flag
432// - Variation == configuration flag value
433// - Outgoing transition == attribute transition
434// - Incoming transition == rule transition
435//
436// The Split() method does not have a Bazel equivalent and Bazel split
437// transitions do not have a Soong equivalent.
438//
439// Mutate() does not make sense in Bazel due to the different models of the
440// two systems: when creating new variations, Soong clones the old module and
441// thus some way is needed to change it state whereas Bazel creates each
442// configuration of a given configured target anew.
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200443type TransitionMutator interface {
444 // Split returns the set of variations that should be created for a module no
445 // matter who depends on it. Used when Make depends on a particular variation
446 // or when the module knows its variations just based on information given to
447 // it in the Blueprint file. This method should not mutate the module it is
448 // called on.
449 Split(ctx BaseModuleContext) []string
450
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800451 // OutgoingTransition is called on a module to determine which variation it wants
452 // from its direct dependencies. The dependency itself can override this decision.
453 // This method should not mutate the module itself.
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200454 OutgoingTransition(ctx OutgoingTransitionContext, sourceVariation string) string
455
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800456 // IncomingTransition is called on a module to determine which variation it should
457 // be in based on the variation modules that depend on it want. This gives the module
458 // a final say about its own variations. This method should not mutate the module
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200459 // itself.
460 IncomingTransition(ctx IncomingTransitionContext, incomingVariation string) string
461
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800462 // Mutate is called after a module was split into multiple variations on each variation.
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200463 // It should not split the module any further but adding new dependencies is
464 // fine. Unlike all the other methods on TransitionMutator, this method is
465 // allowed to mutate the module.
466 Mutate(ctx BottomUpMutatorContext, variation string)
467}
468
469type androidTransitionMutator struct {
Colin Crossb63d7b32023-12-07 16:54:51 -0800470 finalPhase bool
471 mutator TransitionMutator
Colin Crossd67425d2024-04-15 15:17:05 -0700472 name string
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200473}
474
475func (a *androidTransitionMutator) Split(ctx blueprint.BaseModuleContext) []string {
Colin Crossd27205e2024-09-12 22:41:37 -0700476 if a.finalPhase {
477 panic("TransitionMutator not allowed in FinalDepsMutators")
478 }
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200479 if m, ok := ctx.Module().(Module); ok {
480 moduleContext := m.base().baseModuleContextFactory(ctx)
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200481 return a.mutator.Split(&moduleContext)
482 } else {
483 return []string{""}
484 }
485}
486
487type outgoingTransitionContextImpl struct {
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800488 archModuleContext
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200489 bp blueprint.OutgoingTransitionContext
490}
491
492func (c *outgoingTransitionContextImpl) Module() Module {
493 return c.bp.Module().(Module)
494}
495
496func (c *outgoingTransitionContextImpl) DepTag() blueprint.DependencyTag {
497 return c.bp.DepTag()
498}
499
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800500func (c *outgoingTransitionContextImpl) Config() Config {
501 return c.bp.Config().(Config)
502}
503
504func (c *outgoingTransitionContextImpl) DeviceConfig() DeviceConfig {
505 return DeviceConfig{c.bp.Config().(Config).deviceConfig}
506}
507
Colin Crossaf333f52024-04-15 15:20:23 -0700508func (c *outgoingTransitionContextImpl) provider(provider blueprint.AnyProviderKey) (any, bool) {
509 return c.bp.Provider(provider)
510}
511
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800512func (a *androidTransitionMutator) OutgoingTransition(bpctx blueprint.OutgoingTransitionContext, sourceVariation string) string {
513 if m, ok := bpctx.Module().(Module); ok {
Colin Cross984223f2024-02-01 17:10:23 -0800514 ctx := outgoingTransitionContextPool.Get().(*outgoingTransitionContextImpl)
515 defer outgoingTransitionContextPool.Put(ctx)
516 *ctx = outgoingTransitionContextImpl{
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800517 archModuleContext: m.base().archModuleContextFactory(bpctx),
518 bp: bpctx,
519 }
520 return a.mutator.OutgoingTransition(ctx, sourceVariation)
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200521 } else {
522 return ""
523 }
524}
525
526type incomingTransitionContextImpl struct {
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800527 archModuleContext
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200528 bp blueprint.IncomingTransitionContext
529}
530
531func (c *incomingTransitionContextImpl) Module() Module {
532 return c.bp.Module().(Module)
533}
534
535func (c *incomingTransitionContextImpl) Config() Config {
536 return c.bp.Config().(Config)
537}
538
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800539func (c *incomingTransitionContextImpl) DeviceConfig() DeviceConfig {
540 return DeviceConfig{c.bp.Config().(Config).deviceConfig}
541}
542
Colin Crosse1a85552024-06-14 12:17:37 -0700543func (c *incomingTransitionContextImpl) IsAddingDependency() bool {
544 return c.bp.IsAddingDependency()
545}
546
Colin Crossaf333f52024-04-15 15:20:23 -0700547func (c *incomingTransitionContextImpl) provider(provider blueprint.AnyProviderKey) (any, bool) {
548 return c.bp.Provider(provider)
549}
550
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800551func (a *androidTransitionMutator) IncomingTransition(bpctx blueprint.IncomingTransitionContext, incomingVariation string) string {
552 if m, ok := bpctx.Module().(Module); ok {
Colin Cross984223f2024-02-01 17:10:23 -0800553 ctx := incomingTransitionContextPool.Get().(*incomingTransitionContextImpl)
554 defer incomingTransitionContextPool.Put(ctx)
555 *ctx = incomingTransitionContextImpl{
Colin Cross4aa3e0a2024-01-18 17:22:58 -0800556 archModuleContext: m.base().archModuleContextFactory(bpctx),
557 bp: bpctx,
558 }
559 return a.mutator.IncomingTransition(ctx, incomingVariation)
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200560 } else {
561 return ""
562 }
563}
564
565func (a *androidTransitionMutator) Mutate(ctx blueprint.BottomUpMutatorContext, variation string) {
566 if am, ok := ctx.Module().(Module); ok {
Colin Cross888046f2024-05-01 14:20:31 -0700567 if variation != "" {
568 // TODO: this should really be checking whether the TransitionMutator affected this module, not
569 // the empty variant, but TransitionMutator has no concept of skipping a module.
570 base := am.base()
571 base.commonProperties.DebugMutators = append(base.commonProperties.DebugMutators, a.name)
572 base.commonProperties.DebugVariations = append(base.commonProperties.DebugVariations, variation)
573 }
574
Colin Cross984223f2024-02-01 17:10:23 -0800575 mctx := bottomUpMutatorContextFactory(ctx, am, a.finalPhase)
576 defer bottomUpMutatorContextPool.Put(mctx)
577 a.mutator.Mutate(mctx, variation)
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200578 }
579}
580
581func (x *registerMutatorsContext) Transition(name string, m TransitionMutator) {
582 atm := &androidTransitionMutator{
Colin Crossb63d7b32023-12-07 16:54:51 -0800583 finalPhase: x.finalPhase,
584 mutator: m,
Colin Crossd67425d2024-04-15 15:17:05 -0700585 name: name,
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200586 }
587 mutator := &mutator{
588 name: name,
589 transitionMutator: atm}
590 x.mutators = append(x.mutators, mutator)
591}
592
Liz Kammer356f7d42021-01-26 09:18:53 -0500593func (x *registerMutatorsContext) mutatorName(name string) string {
Liz Kammer356f7d42021-01-26 09:18:53 -0500594 return name
595}
596
Colin Cross25de6c32019-06-06 14:29:25 -0700597func (x *registerMutatorsContext) TopDown(name string, m TopDownMutator) MutatorHandle {
Colin Cross798bfce2016-10-12 14:28:16 -0700598 f := func(ctx blueprint.TopDownMutatorContext) {
Colin Cross635c3b02016-05-18 15:37:25 -0700599 if a, ok := ctx.Module().(Module); ok {
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400600 moduleContext := a.base().baseModuleContextFactory(ctx)
Colin Cross984223f2024-02-01 17:10:23 -0800601 actx := topDownMutatorContextPool.Get().(*topDownMutatorContext)
602 defer topDownMutatorContextPool.Put(actx)
603 *actx = topDownMutatorContext{
Colin Crossdc35e212019-06-06 16:13:11 -0700604 bp: ctx,
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400605 baseModuleContext: moduleContext,
Colin Cross6362e272015-10-29 15:25:03 -0700606 }
Colin Cross798bfce2016-10-12 14:28:16 -0700607 m(actx)
Colin Cross6362e272015-10-29 15:25:03 -0700608 }
Colin Cross798bfce2016-10-12 14:28:16 -0700609 }
Liz Kammer356f7d42021-01-26 09:18:53 -0500610 mutator := &mutator{name: x.mutatorName(name), topDownMutator: f}
Colin Cross795c3772017-03-16 16:50:10 -0700611 x.mutators = append(x.mutators, mutator)
Colin Cross798bfce2016-10-12 14:28:16 -0700612 return mutator
613}
614
Paul Duffin1d2d42f2021-03-06 20:08:12 +0000615func (mutator *mutator) componentName() string {
616 return mutator.name
617}
618
619func (mutator *mutator) register(ctx *Context) {
620 blueprintCtx := ctx.Context
621 var handle blueprint.MutatorHandle
622 if mutator.bottomUpMutator != nil {
623 handle = blueprintCtx.RegisterBottomUpMutator(mutator.name, mutator.bottomUpMutator)
624 } else if mutator.topDownMutator != nil {
625 handle = blueprintCtx.RegisterTopDownMutator(mutator.name, mutator.topDownMutator)
Lukacs T. Berki6c716762022-06-13 20:50:39 +0200626 } else if mutator.transitionMutator != nil {
627 blueprintCtx.RegisterTransitionMutator(mutator.name, mutator.transitionMutator)
Paul Duffin1d2d42f2021-03-06 20:08:12 +0000628 }
Colin Crossb8533a82024-10-05 15:25:09 -0700629
630 // Forward booleans set on the MutatorHandle to the blueprint.MutatorHandle.
Paul Duffin1d2d42f2021-03-06 20:08:12 +0000631 if mutator.parallel {
632 handle.Parallel()
633 }
Colin Crossb8533a82024-10-05 15:25:09 -0700634 if mutator.usesRename {
635 handle.UsesRename()
636 }
637 if mutator.usesReverseDependencies {
638 handle.UsesReverseDependencies()
639 }
640 if mutator.usesReplaceDependencies {
641 handle.UsesReplaceDependencies()
642 }
643 if mutator.usesCreateModule {
644 handle.UsesCreateModule()
645 }
646 if mutator.mutatesDependencies {
647 handle.MutatesDependencies()
648 }
649 if mutator.mutatesGlobalState {
650 handle.MutatesGlobalState()
651 }
Paul Duffin1d2d42f2021-03-06 20:08:12 +0000652}
653
Colin Cross798bfce2016-10-12 14:28:16 -0700654type MutatorHandle interface {
Colin Crossb8533a82024-10-05 15:25:09 -0700655 // Parallel sets the mutator to visit modules in parallel while maintaining ordering. Calling any
656 // method on the mutator context is thread-safe, but the mutator must handle synchronization
657 // for any modifications to global state or any modules outside the one it was invoked on.
Colin Cross798bfce2016-10-12 14:28:16 -0700658 Parallel() MutatorHandle
Colin Crossb8533a82024-10-05 15:25:09 -0700659
660 // UsesRename marks the mutator as using the BottomUpMutatorContext.Rename method, which prevents
661 // coalescing adjacent mutators into a single mutator pass.
662 UsesRename() MutatorHandle
663
664 // UsesReverseDependencies marks the mutator as using the BottomUpMutatorContext.AddReverseDependency
665 // method, which prevents coalescing adjacent mutators into a single mutator pass.
666 UsesReverseDependencies() MutatorHandle
667
668 // UsesReplaceDependencies marks the mutator as using the BottomUpMutatorContext.ReplaceDependencies
669 // method, which prevents coalescing adjacent mutators into a single mutator pass.
670 UsesReplaceDependencies() MutatorHandle
671
672 // UsesCreateModule marks the mutator as using the BottomUpMutatorContext.CreateModule method,
673 // which prevents coalescing adjacent mutators into a single mutator pass.
674 UsesCreateModule() MutatorHandle
675
676 // MutatesDependencies marks the mutator as modifying properties in dependencies, which prevents
677 // coalescing adjacent mutators into a single mutator pass.
678 MutatesDependencies() MutatorHandle
679
680 // MutatesGlobalState marks the mutator as modifying global state, which prevents coalescing
681 // adjacent mutators into a single mutator pass.
682 MutatesGlobalState() MutatorHandle
Colin Cross798bfce2016-10-12 14:28:16 -0700683}
684
685func (mutator *mutator) Parallel() MutatorHandle {
686 mutator.parallel = true
687 return mutator
Colin Cross6362e272015-10-29 15:25:03 -0700688}
Colin Cross1e676be2016-10-12 14:38:15 -0700689
Colin Crossb8533a82024-10-05 15:25:09 -0700690func (mutator *mutator) UsesRename() MutatorHandle {
691 mutator.usesRename = true
692 return mutator
693}
694
695func (mutator *mutator) UsesReverseDependencies() MutatorHandle {
696 mutator.usesReverseDependencies = true
697 return mutator
698}
699
700func (mutator *mutator) UsesReplaceDependencies() MutatorHandle {
701 mutator.usesReplaceDependencies = true
702 return mutator
703}
704
705func (mutator *mutator) UsesCreateModule() MutatorHandle {
706 mutator.usesCreateModule = true
707 return mutator
708}
709
710func (mutator *mutator) MutatesDependencies() MutatorHandle {
711 mutator.mutatesDependencies = true
712 return mutator
713}
714
715func (mutator *mutator) MutatesGlobalState() MutatorHandle {
716 mutator.mutatesGlobalState = true
717 return mutator
718}
719
Paul Duffin44f1d842020-06-26 20:17:02 +0100720func RegisterComponentsMutator(ctx RegisterMutatorsContext) {
721 ctx.BottomUp("component-deps", componentDepsMutator).Parallel()
722}
723
724// A special mutator that runs just prior to the deps mutator to allow the dependencies
725// on component modules to be added so that they can depend directly on a prebuilt
726// module.
727func componentDepsMutator(ctx BottomUpMutatorContext) {
Cole Fausta963b942024-04-11 17:43:00 -0700728 ctx.Module().ComponentDepsMutator(ctx)
Paul Duffin44f1d842020-06-26 20:17:02 +0100729}
730
Colin Cross1e676be2016-10-12 14:38:15 -0700731func depsMutator(ctx BottomUpMutatorContext) {
Cole Fausta963b942024-04-11 17:43:00 -0700732 if m := ctx.Module(); m.Enabled(ctx) {
Ronald Braunstein73b08ff2023-12-19 10:24:47 -0800733 m.base().baseDepsMutator(ctx)
Colin Cross1e676be2016-10-12 14:38:15 -0700734 m.DepsMutator(ctx)
735 }
736}
Colin Crossd11fcda2017-10-23 17:59:01 -0700737
Liz Kammer356f7d42021-01-26 09:18:53 -0500738func registerDepsMutator(ctx RegisterMutatorsContext) {
Colin Crossb8533a82024-10-05 15:25:09 -0700739 ctx.BottomUp("deps", depsMutator).Parallel().UsesReverseDependencies()
Liz Kammer356f7d42021-01-26 09:18:53 -0500740}
741
Colin Crossdc35e212019-06-06 16:13:11 -0700742// android.topDownMutatorContext either has to embed blueprint.TopDownMutatorContext, in which case every method that
743// has an overridden version in android.BaseModuleContext has to be manually forwarded to BaseModuleContext to avoid
744// ambiguous method errors, or it has to store a blueprint.TopDownMutatorContext non-embedded, in which case every
745// non-overridden method has to be forwarded. There are fewer non-overridden methods, so use the latter. The following
746// methods forward to the identical blueprint versions for topDownMutatorContext and bottomUpMutatorContext.
747
Colin Crossdc35e212019-06-06 16:13:11 -0700748func (b *bottomUpMutatorContext) Rename(name string) {
749 b.bp.Rename(name)
Colin Cross9a362232019-07-01 15:32:45 -0700750 b.Module().base().commonProperties.DebugName = name
Colin Crossdc35e212019-06-06 16:13:11 -0700751}
752
Colin Crossda279cf2024-09-17 14:25:45 -0700753func (b *bottomUpMutatorContext) createModule(factory blueprint.ModuleFactory, name string, props ...interface{}) blueprint.Module {
754 return b.bp.CreateModule(factory, name, props...)
755}
756
757func (b *bottomUpMutatorContext) CreateModule(factory ModuleFactory, props ...interface{}) Module {
758 return createModule(b, factory, "_bottomUpMutatorModule", props...)
759}
760
Colin Cross4f1dcb02020-09-16 18:45:04 -0700761func (b *bottomUpMutatorContext) AddDependency(module blueprint.Module, tag blueprint.DependencyTag, name ...string) []blueprint.Module {
Liz Kammerc13f7852023-05-17 13:01:48 -0400762 if b.baseModuleContext.checkedMissingDeps() {
763 panic("Adding deps not allowed after checking for missing deps")
764 }
Colin Cross4f1dcb02020-09-16 18:45:04 -0700765 return b.bp.AddDependency(module, tag, name...)
Colin Crossdc35e212019-06-06 16:13:11 -0700766}
767
768func (b *bottomUpMutatorContext) AddReverseDependency(module blueprint.Module, tag blueprint.DependencyTag, name string) {
Liz Kammerc13f7852023-05-17 13:01:48 -0400769 if b.baseModuleContext.checkedMissingDeps() {
770 panic("Adding deps not allowed after checking for missing deps")
771 }
Colin Crossdc35e212019-06-06 16:13:11 -0700772 b.bp.AddReverseDependency(module, tag, name)
773}
Cole Faustf4992e82024-09-30 15:16:18 -0700774
775func (b *bottomUpMutatorContext) AddReverseVariationDependency(variations []blueprint.Variation, tag blueprint.DependencyTag, name string) {
776 if b.baseModuleContext.checkedMissingDeps() {
777 panic("Adding deps not allowed after checking for missing deps")
778 }
779 b.bp.AddReverseVariationDependency(variations, tag, name)
780}
781
Colin Crossdc35e212019-06-06 16:13:11 -0700782func (b *bottomUpMutatorContext) AddVariationDependencies(variations []blueprint.Variation, tag blueprint.DependencyTag,
Colin Cross4f1dcb02020-09-16 18:45:04 -0700783 names ...string) []blueprint.Module {
Liz Kammerc13f7852023-05-17 13:01:48 -0400784 if b.baseModuleContext.checkedMissingDeps() {
785 panic("Adding deps not allowed after checking for missing deps")
786 }
Colin Cross4f1dcb02020-09-16 18:45:04 -0700787 return b.bp.AddVariationDependencies(variations, tag, names...)
Colin Crossdc35e212019-06-06 16:13:11 -0700788}
789
790func (b *bottomUpMutatorContext) AddFarVariationDependencies(variations []blueprint.Variation,
Colin Cross4f1dcb02020-09-16 18:45:04 -0700791 tag blueprint.DependencyTag, names ...string) []blueprint.Module {
Liz Kammerc13f7852023-05-17 13:01:48 -0400792 if b.baseModuleContext.checkedMissingDeps() {
793 panic("Adding deps not allowed after checking for missing deps")
794 }
Colin Crossdc35e212019-06-06 16:13:11 -0700795
Colin Cross4f1dcb02020-09-16 18:45:04 -0700796 return b.bp.AddFarVariationDependencies(variations, tag, names...)
Colin Crossdc35e212019-06-06 16:13:11 -0700797}
798
Colin Crossdc35e212019-06-06 16:13:11 -0700799func (b *bottomUpMutatorContext) ReplaceDependencies(name string) {
Liz Kammerc13f7852023-05-17 13:01:48 -0400800 if b.baseModuleContext.checkedMissingDeps() {
801 panic("Adding deps not allowed after checking for missing deps")
802 }
Colin Crossdc35e212019-06-06 16:13:11 -0700803 b.bp.ReplaceDependencies(name)
804}
Jaewoong Jung9f88ce22019-11-15 10:57:34 -0800805
Paul Duffin80342d72020-06-26 22:08:43 +0100806func (b *bottomUpMutatorContext) ReplaceDependenciesIf(name string, predicate blueprint.ReplaceDependencyPredicate) {
Liz Kammerc13f7852023-05-17 13:01:48 -0400807 if b.baseModuleContext.checkedMissingDeps() {
808 panic("Adding deps not allowed after checking for missing deps")
809 }
Paul Duffin80342d72020-06-26 22:08:43 +0100810 b.bp.ReplaceDependenciesIf(name, predicate)
811}