blob: e5214dfc8c7de13c7cf857cd54e2f82d3e33ed9b [file] [log] [blame]
Paul Duffindfa10832021-05-13 17:31:51 +01001#!/usr/bin/env python
2#
3# Copyright (C) 2018 The Android Open Source Project
4#
5# Licensed under the Apache License, Version 2.0 (the "License");
6# you may not use this file except in compliance with the License.
7# You may obtain a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS,
13# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14# See the License for the specific language governing permissions and
15# limitations under the License.
Paul Duffinb5cd5222022-02-28 19:06:49 +000016"""Verify that one set of hidden API flags is a subset of another."""
Paul Duffindfa10832021-05-13 17:31:51 +010017
18import argparse
19import csv
Paul Duffinc11f6672021-07-20 00:04:21 +010020import sys
Paul Duffin53a76072021-07-21 17:27:09 +010021from itertools import chain
Paul Duffindfa10832021-05-13 17:31:51 +010022
Paul Duffinb5cd5222022-02-28 19:06:49 +000023from signature_trie import signature_trie
Paul Duffinc11f6672021-07-20 00:04:21 +010024
Spandan Das559132f2021-08-25 18:17:33 +000025
26def dict_reader(csvfile):
27 return csv.DictReader(
28 csvfile, delimiter=",", quotechar="|", fieldnames=["signature"])
29
Paul Duffindfa10832021-05-13 17:31:51 +010030
Paul Duffinc11f6672021-07-20 00:04:21 +010031def read_flag_trie_from_file(file):
Spandan Das559132f2021-08-25 18:17:33 +000032 with open(file, "r") as stream:
Paul Duffinc11f6672021-07-20 00:04:21 +010033 return read_flag_trie_from_stream(stream)
34
Spandan Das559132f2021-08-25 18:17:33 +000035
Paul Duffinc11f6672021-07-20 00:04:21 +010036def read_flag_trie_from_stream(stream):
Paul Duffinb5cd5222022-02-28 19:06:49 +000037 trie = signature_trie()
Paul Duffinc11f6672021-07-20 00:04:21 +010038 reader = dict_reader(stream)
39 for row in reader:
Spandan Das559132f2021-08-25 18:17:33 +000040 signature = row["signature"]
Paul Duffinc11f6672021-07-20 00:04:21 +010041 trie.add(signature, row)
42 return trie
43
Spandan Das559132f2021-08-25 18:17:33 +000044
45def extract_subset_from_monolithic_flags_as_dict_from_file(
46 monolithicTrie, patternsFile):
Paul Duffinb5cd5222022-02-28 19:06:49 +000047 """Extract a subset of flags from the dict of monolithic flags.
Paul Duffin53a76072021-07-21 17:27:09 +010048
49 :param monolithicFlagsDict: the dict containing all the monolithic flags.
Paul Duffin67b9d612021-07-21 17:38:47 +010050 :param patternsFile: a file containing a list of signature patterns that
51 define the subset.
52 :return: the dict from signature to row.
53 """
Spandan Das559132f2021-08-25 18:17:33 +000054 with open(patternsFile, "r") as stream:
55 return extract_subset_from_monolithic_flags_as_dict_from_stream(
56 monolithicTrie, stream)
Paul Duffin67b9d612021-07-21 17:38:47 +010057
Spandan Das559132f2021-08-25 18:17:33 +000058
59def extract_subset_from_monolithic_flags_as_dict_from_stream(
60 monolithicTrie, stream):
Paul Duffinb5cd5222022-02-28 19:06:49 +000061 """Extract a subset of flags from the trie of monolithic flags.
Paul Duffin67b9d612021-07-21 17:38:47 +010062
Paul Duffinc11f6672021-07-20 00:04:21 +010063 :param monolithicTrie: the trie containing all the monolithic flags.
Paul Duffin67b9d612021-07-21 17:38:47 +010064 :param stream: a stream containing a list of signature patterns that define
65 the subset.
Paul Duffin53a76072021-07-21 17:27:09 +010066 :return: the dict from signature to row.
67 """
Spandan Das559132f2021-08-25 18:17:33 +000068 dict_signature_to_row = {}
Paul Duffinc11f6672021-07-20 00:04:21 +010069 for pattern in stream:
70 pattern = pattern.rstrip()
Paul Duffinb5cd5222022-02-28 19:06:49 +000071 rows = monolithicTrie.get_matching_rows(pattern)
Paul Duffinc11f6672021-07-20 00:04:21 +010072 for row in rows:
Spandan Das559132f2021-08-25 18:17:33 +000073 signature = row["signature"]
74 dict_signature_to_row[signature] = row
75 return dict_signature_to_row
76
Paul Duffin53a76072021-07-21 17:27:09 +010077
Paul Duffin428c6512021-07-21 15:33:22 +010078def read_signature_csv_from_stream_as_dict(stream):
Paul Duffinb5cd5222022-02-28 19:06:49 +000079 """Read the csv contents from the stream into a dict.
80
81 The first column is assumed to be the signature and used as the
82 key.
Paul Duffin428c6512021-07-21 15:33:22 +010083
Spandan Das559132f2021-08-25 18:17:33 +000084 The whole row is stored as the value.
Paul Duffin428c6512021-07-21 15:33:22 +010085 :param stream: the csv contents to read
86 :return: the dict from signature to row.
87 """
Spandan Das559132f2021-08-25 18:17:33 +000088 dict_signature_to_row = {}
Paul Duffin428c6512021-07-21 15:33:22 +010089 reader = dict_reader(stream)
90 for row in reader:
Spandan Das559132f2021-08-25 18:17:33 +000091 signature = row["signature"]
92 dict_signature_to_row[signature] = row
93 return dict_signature_to_row
94
Paul Duffindfa10832021-05-13 17:31:51 +010095
Paul Duffin428c6512021-07-21 15:33:22 +010096def read_signature_csv_from_file_as_dict(csvFile):
Paul Duffinb5cd5222022-02-28 19:06:49 +000097 """Read the csvFile into a dict.
98
99 The first column is assumed to be the signature and used as the
100 key.
Paul Duffin428c6512021-07-21 15:33:22 +0100101
Spandan Das559132f2021-08-25 18:17:33 +0000102 The whole row is stored as the value.
Paul Duffin428c6512021-07-21 15:33:22 +0100103 :param csvFile: the csv file to read
104 :return: the dict from signature to row.
105 """
Spandan Das559132f2021-08-25 18:17:33 +0000106 with open(csvFile, "r") as f:
Paul Duffin428c6512021-07-21 15:33:22 +0100107 return read_signature_csv_from_stream_as_dict(f)
108
Spandan Das559132f2021-08-25 18:17:33 +0000109
Paul Duffin428c6512021-07-21 15:33:22 +0100110def compare_signature_flags(monolithicFlagsDict, modularFlagsDict):
Spandan Das559132f2021-08-25 18:17:33 +0000111 """Compare the signature flags between the two dicts.
Paul Duffin428c6512021-07-21 15:33:22 +0100112
113 :param monolithicFlagsDict: the dict containing the subset of the monolithic
114 flags that should be equal to the modular flags.
115 :param modularFlagsDict:the dict containing the flags produced by a single
116 bootclasspath_fragment module.
117 :return: list of mismatches., each mismatch is a tuple where the first item
118 is the signature, and the second and third items are lists of the flags from
119 modular dict, and monolithic dict respectively.
120 """
Paul Duffindfa10832021-05-13 17:31:51 +0100121 mismatchingSignatures = []
Paul Duffin53a76072021-07-21 17:27:09 +0100122 # Create a sorted set of all the signatures from both the monolithic and
123 # modular dicts.
Spandan Das559132f2021-08-25 18:17:33 +0000124 allSignatures = sorted(
125 set(chain(monolithicFlagsDict.keys(), modularFlagsDict.keys())))
Paul Duffin53a76072021-07-21 17:27:09 +0100126 for signature in allSignatures:
Paul Duffin428c6512021-07-21 15:33:22 +0100127 monolithicRow = monolithicFlagsDict.get(signature, {})
128 monolithicFlags = monolithicRow.get(None, [])
Paul Duffin280bae62021-07-20 18:03:53 +0100129 if signature in modularFlagsDict:
130 modularRow = modularFlagsDict.get(signature, {})
131 modularFlags = modularRow.get(None, [])
132 else:
133 modularFlags = ["blocked"]
Paul Duffin428c6512021-07-21 15:33:22 +0100134 if monolithicFlags != modularFlags:
Spandan Das559132f2021-08-25 18:17:33 +0000135 mismatchingSignatures.append(
136 (signature, modularFlags, monolithicFlags))
Paul Duffin428c6512021-07-21 15:33:22 +0100137 return mismatchingSignatures
Paul Duffindfa10832021-05-13 17:31:51 +0100138
Spandan Das559132f2021-08-25 18:17:33 +0000139
Paul Duffin428c6512021-07-21 15:33:22 +0100140def main(argv):
Spandan Das559132f2021-08-25 18:17:33 +0000141 args_parser = argparse.ArgumentParser(
142 description="Verify that sets of hidden API flags are each a subset of "
Paul Duffinb5cd5222022-02-28 19:06:49 +0000143 "the monolithic flag file.")
Spandan Das559132f2021-08-25 18:17:33 +0000144 args_parser.add_argument("monolithicFlags", help="The monolithic flag file")
145 args_parser.add_argument(
146 "modularFlags",
147 nargs=argparse.REMAINDER,
148 help="Flags produced by individual bootclasspath_fragment modules")
Paul Duffin428c6512021-07-21 15:33:22 +0100149 args = args_parser.parse_args(argv[1:])
Paul Duffindfa10832021-05-13 17:31:51 +0100150
Paul Duffinc11f6672021-07-20 00:04:21 +0100151 # Read in all the flags into the trie
Paul Duffin7be96332021-07-21 16:13:03 +0100152 monolithicFlagsPath = args.monolithicFlags
Paul Duffinc11f6672021-07-20 00:04:21 +0100153 monolithicTrie = read_flag_trie_from_file(monolithicFlagsPath)
Paul Duffindfa10832021-05-13 17:31:51 +0100154
Paul Duffin53a76072021-07-21 17:27:09 +0100155 # For each subset specified on the command line, create dicts for the flags
Paul Duffinc11f6672021-07-20 00:04:21 +0100156 # provided by the subset and the corresponding flags from the complete set
157 # of flags and compare them.
Paul Duffin428c6512021-07-21 15:33:22 +0100158 failed = False
Paul Duffin67b9d612021-07-21 17:38:47 +0100159 for modularPair in args.modularFlags:
160 parts = modularPair.split(":")
161 modularFlagsPath = parts[0]
162 modularPatternsPath = parts[1]
Spandan Das559132f2021-08-25 18:17:33 +0000163 modularFlagsDict = read_signature_csv_from_file_as_dict(
164 modularFlagsPath)
165 monolithicFlagsSubsetDict = \
166 extract_subset_from_monolithic_flags_as_dict_from_file(
167 monolithicTrie, modularPatternsPath)
168 mismatchingSignatures = compare_signature_flags(
169 monolithicFlagsSubsetDict, modularFlagsDict)
Paul Duffin428c6512021-07-21 15:33:22 +0100170 if mismatchingSignatures:
171 failed = True
172 print("ERROR: Hidden API flags are inconsistent:")
Paul Duffin7be96332021-07-21 16:13:03 +0100173 print("< " + modularFlagsPath)
174 print("> " + monolithicFlagsPath)
Paul Duffin428c6512021-07-21 15:33:22 +0100175 for mismatch in mismatchingSignatures:
176 signature = mismatch[0]
177 print()
Spandan Das559132f2021-08-25 18:17:33 +0000178 print("< " + ",".join([signature] + mismatch[1]))
179 print("> " + ",".join([signature] + mismatch[2]))
Paul Duffin428c6512021-07-21 15:33:22 +0100180
181 if failed:
182 sys.exit(1)
183
Spandan Das559132f2021-08-25 18:17:33 +0000184
Paul Duffin428c6512021-07-21 15:33:22 +0100185if __name__ == "__main__":
186 main(sys.argv)