blob: 29daa67fb7cdcced19452ae5ed761ff14e911087 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Paul Duffin2e7ed652020-05-26 18:13:57 +010022 "regexp"
Paul Duffin64e61992020-05-15 10:20:31 +010023 "sort"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070033 "android/soong/genrule"
Colin Cross72bb3632017-07-13 16:23:21 -070034)
35
36var buildDir string
37
38func setUp() {
39 var err error
40 buildDir, err = ioutil.TempDir("", "soong_java_test")
41 if err != nil {
42 panic(err)
43 }
44}
45
46func tearDown() {
47 os.RemoveAll(buildDir)
48}
49
50func TestMain(m *testing.M) {
51 run := func() int {
52 setUp()
53 defer tearDown()
54
55 return m.Run()
56 }
57
58 os.Exit(run())
59}
Colin Cross527012a2017-11-30 22:56:16 -080060
Colin Cross98be1bb2019-12-13 20:41:13 -080061func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000062 bp += dexpreopt.BpToolModulesForTest()
63
Martin Stjernholm75a48d82020-01-10 20:32:59 +000064 config := TestConfig(buildDir, env, bp, fs)
65
66 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
67 // it doesn't create a real one, which would fail.
68 _ = dexpreopt.GlobalSoongConfigForTests(config)
69
70 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070071}
72
Colin Cross98be1bb2019-12-13 20:41:13 -080073func testContext() *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070074
Colin Cross4c428df2017-09-15 17:36:05 -070075 ctx := android.NewTestArchContext()
Paul Duffinf9b1da02019-12-18 19:51:55 +000076 RegisterJavaBuildComponents(ctx)
77 RegisterAppBuildComponents(ctx)
78 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000079 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000080 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080081 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
83 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000084 RegisterDocsBuildComponents(ctx)
85 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000086 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070087 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffina48f7582019-12-19 11:25:19 +000088
89 RegisterPrebuiltApisBuildComponents(ctx)
90
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070091 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross3bc7ffa2017-11-22 16:19:37 -080092 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -070093 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070094
95 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +000096 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -070097
Martin Stjernholmd90676f2020-01-11 00:37:30 +000098 dexpreopt.RegisterToolModulesForTest(ctx)
99
Colin Cross527012a2017-11-30 22:56:16 -0800100 return ctx
101}
102
103func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800104 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800105
Colin Cross98be1bb2019-12-13 20:41:13 -0800106 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000107 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800108
Colin Cross98be1bb2019-12-13 20:41:13 -0800109 ctx.Register(config)
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100110 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800111 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700112 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800113 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800114}
115
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900116func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900117 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800118 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900119}
120
Colin Cross98be1bb2019-12-13 20:41:13 -0800121func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900122 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800123 ctx := testContext()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900124
Colin Cross98be1bb2019-12-13 20:41:13 -0800125 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000126 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900127
Colin Cross98be1bb2019-12-13 20:41:13 -0800128 ctx.Register(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900129 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
130 if len(errs) > 0 {
131 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900132 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900133 }
134 _, errs = ctx.PrepareBuildActions(config)
135 if len(errs) > 0 {
136 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900137 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900138 }
139
140 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900141 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900142}
143
Colin Crossf5f663b2020-06-07 16:58:18 -0700144func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
145 t.Helper()
146 return testJavaWithConfig(t, testConfig(nil, bp, fs))
147}
148
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700149func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800150 t.Helper()
Colin Crossf5f663b2020-06-07 16:58:18 -0700151 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900152}
153
Colin Cross98be1bb2019-12-13 20:41:13 -0800154func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900155 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800156 ctx := testContext()
Colin Cross527012a2017-11-30 22:56:16 -0800157 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700158
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700159 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700160}
161
Colin Cross2acdae82017-09-15 19:44:24 -0700162func moduleToPath(name string) string {
163 switch {
164 case name == `""`:
165 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700166 case strings.HasSuffix(name, ".jar"):
167 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700168 default:
169 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700170 }
171}
172
Jeongik Chae403e9e2019-12-07 00:16:24 +0900173func TestJavaLinkType(t *testing.T) {
174 testJava(t, `
175 java_library {
176 name: "foo",
177 srcs: ["a.java"],
178 libs: ["bar"],
179 static_libs: ["baz"],
180 }
181
182 java_library {
183 name: "bar",
184 sdk_version: "current",
185 srcs: ["b.java"],
186 }
187
188 java_library {
189 name: "baz",
190 sdk_version: "system_current",
191 srcs: ["c.java"],
192 }
193 `)
194
195 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
196 java_library {
197 name: "foo",
198 srcs: ["a.java"],
199 libs: ["bar"],
200 sdk_version: "current",
201 static_libs: ["baz"],
202 }
203
204 java_library {
205 name: "bar",
206 sdk_version: "current",
207 srcs: ["b.java"],
208 }
209
210 java_library {
211 name: "baz",
212 sdk_version: "system_current",
213 srcs: ["c.java"],
214 }
215 `)
216
217 testJava(t, `
218 java_library {
219 name: "foo",
220 srcs: ["a.java"],
221 libs: ["bar"],
222 sdk_version: "system_current",
223 static_libs: ["baz"],
224 }
225
226 java_library {
227 name: "bar",
228 sdk_version: "current",
229 srcs: ["b.java"],
230 }
231
232 java_library {
233 name: "baz",
234 sdk_version: "system_current",
235 srcs: ["c.java"],
236 }
237 `)
238
239 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
240 java_library {
241 name: "foo",
242 srcs: ["a.java"],
243 libs: ["bar"],
244 sdk_version: "system_current",
245 static_libs: ["baz"],
246 }
247
248 java_library {
249 name: "bar",
250 sdk_version: "current",
251 srcs: ["b.java"],
252 }
253
254 java_library {
255 name: "baz",
256 srcs: ["c.java"],
257 }
258 `)
259}
260
Colin Cross72bb3632017-07-13 16:23:21 -0700261func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700262 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700263 java_library {
264 name: "foo",
265 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700266 libs: ["bar"],
267 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700268 }
269
270 java_library {
271 name: "bar",
272 srcs: ["b.java"],
273 }
274
275 java_library {
276 name: "baz",
277 srcs: ["c.java"],
278 }
Colin Crossd5934c82017-10-02 13:55:26 -0700279 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700280
Colin Cross4c428df2017-09-15 17:36:05 -0700281 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700282 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700283
284 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
285 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
286 }
287
Colin Cross1ee23172017-10-18 14:44:18 -0700288 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700289 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
290 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700291
Nan Zhanged19fc32017-10-19 13:06:22 -0700292 if !strings.Contains(javac.Args["classpath"], barTurbine) {
293 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700294 }
295
Nan Zhanged19fc32017-10-19 13:06:22 -0700296 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
297 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700298 }
299
300 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
301 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700302 }
303}
304
Artur Satayev9cf46692019-11-26 18:08:34 +0000305func TestExportedPlugins(t *testing.T) {
306 type Result struct {
307 library string
308 processors string
309 }
310 var tests = []struct {
311 name string
312 extra string
313 results []Result
314 }{
315 {
316 name: "Exported plugin is not a direct plugin",
317 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
318 results: []Result{{library: "exports", processors: "-proc:none"}},
319 },
320 {
321 name: "Exports plugin to dependee",
322 extra: `
323 java_library{name: "exports", exported_plugins: ["plugin"]}
324 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
325 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
326 `,
327 results: []Result{
328 {library: "foo", processors: "-processor com.android.TestPlugin"},
329 {library: "bar", processors: "-processor com.android.TestPlugin"},
330 },
331 },
332 {
333 name: "Exports plugin to android_library",
334 extra: `
335 java_library{name: "exports", exported_plugins: ["plugin"]}
336 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
337 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
338 `,
339 results: []Result{
340 {library: "foo", processors: "-processor com.android.TestPlugin"},
341 {library: "bar", processors: "-processor com.android.TestPlugin"},
342 },
343 },
344 {
345 name: "Exports plugin is not propagated via transitive deps",
346 extra: `
347 java_library{name: "exports", exported_plugins: ["plugin"]}
348 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
349 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
350 `,
351 results: []Result{
352 {library: "foo", processors: "-processor com.android.TestPlugin"},
353 {library: "bar", processors: "-proc:none"},
354 },
355 },
356 {
357 name: "Exports plugin appends to plugins",
358 extra: `
359 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
360 java_library{name: "exports", exported_plugins: ["plugin"]}
361 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
362 `,
363 results: []Result{
364 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
365 },
366 },
367 }
368
369 for _, test := range tests {
370 t.Run(test.name, func(t *testing.T) {
371 ctx, _ := testJava(t, `
372 java_plugin {
373 name: "plugin",
374 processor_class: "com.android.TestPlugin",
375 }
376 `+test.extra)
377
378 for _, want := range test.results {
379 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
380 if javac.Args["processor"] != want.processors {
381 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
382 }
383 }
384 })
385 }
386}
387
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900388func TestSdkVersionByPartition(t *testing.T) {
389 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900390 java_library {
391 name: "foo",
392 srcs: ["a.java"],
393 vendor: true,
394 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900395 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900396
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900397 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900398 java_library {
399 name: "bar",
400 srcs: ["b.java"],
401 }
402 `)
403
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900404 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900405 bp := `
406 java_library {
407 name: "foo",
408 srcs: ["a.java"],
409 product_specific: true,
410 }
411 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800412
413 config := testConfig(nil, bp, nil)
414 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900415 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800416 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900417 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800418 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900419 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900420 }
421}
422
Colin Crossd5934c82017-10-02 13:55:26 -0700423func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700424 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700425 java_library {
426 name: "foo",
427 srcs: ["a.java"],
428 target: {
429 android: {
430 srcs: ["b.java"],
431 },
432 },
433 }
434 `)
435
436 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
437 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
438 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
439 }
440}
441
Colin Cross6b4a32d2017-12-05 13:42:45 -0800442func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700443 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800444 java_library_host {
445 name: "foo",
446 srcs: ["a.java"],
447 }
448
449 java_binary_host {
450 name: "bar",
451 srcs: ["b.java"],
452 static_libs: ["foo"],
453 }
454 `)
455
456 buildOS := android.BuildOs.String()
457
458 bar := ctx.ModuleForTests("bar", buildOS+"_common")
459 barJar := bar.Output("bar.jar").Output.String()
460 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
461 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
462
463 // Test that the install binary wrapper depends on the installed jar file
464 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
465 t.Errorf("expected binary wrapper implicits [%q], got %v",
466 barJar, barWrapperDeps)
467 }
468
469}
470
Colin Cross72bb3632017-07-13 16:23:21 -0700471func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700472 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700473 java_library {
474 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000475 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000476 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700477 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700478 }
479
Colin Cross74d73e22017-08-02 11:05:49 -0700480 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700481 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700482 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700483 }
484
Colin Cross74d73e22017-08-02 11:05:49 -0700485 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700486 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700487 jars: ["b.jar"],
Liz Kammer4f68ee72020-08-05 15:40:41 -0700488 sdk_version: "current",
489 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700490 }
Colin Cross42be7612019-02-21 18:12:14 -0800491
492 dex_import {
493 name: "qux",
494 jars: ["b.jar"],
495 }
Colin Cross79c7c262019-04-17 11:11:46 -0700496
497 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000498 name: "sdklib",
499 public: {
500 jars: ["c.jar"],
501 },
502 }
503
Paul Duffin91547182019-11-12 19:39:36 +0000504 prebuilt_stubs_sources {
505 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000506 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000507 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000508
509 java_test_import {
510 name: "test",
511 jars: ["a.jar"],
512 test_suites: ["cts"],
513 test_config: "AndroidTest.xml",
514 }
Colin Cross72bb3632017-07-13 16:23:21 -0700515 `)
516
Paul Duffin9b478b02019-12-10 13:41:51 +0000517 fooModule := ctx.ModuleForTests("foo", "android_common")
518 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700519 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammer4f68ee72020-08-05 15:40:41 -0700520 barModule := ctx.ModuleForTests("bar", "android_common")
521 barJar := barModule.Rule("combineJar").Output
522 bazModule := ctx.ModuleForTests("baz", "android_common")
523 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700524 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700525
Paul Duffin9b478b02019-12-10 13:41:51 +0000526 fooLibrary := fooModule.Module().(*Library)
527 assertDeepEquals(t, "foo java sources incorrect",
528 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000529
Paul Duffin9b478b02019-12-10 13:41:51 +0000530 assertDeepEquals(t, "foo java source jars incorrect",
531 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
532 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000533
Colin Cross37f6d792018-07-12 12:28:41 -0700534 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
535 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700536 }
537
Liz Kammer4f68ee72020-08-05 15:40:41 -0700538 barDexJar := barModule.Module().(*Import).DexJar()
539 if barDexJar != nil {
540 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
541 }
542
Colin Cross79c7c262019-04-17 11:11:46 -0700543 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
544 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
545 }
546
Colin Cross37f6d792018-07-12 12:28:41 -0700547 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
548 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700549 }
Colin Cross42be7612019-02-21 18:12:14 -0800550
Liz Kammer4f68ee72020-08-05 15:40:41 -0700551 bazDexJar := bazModule.Module().(*Import).DexJar().String()
552 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
553 if bazDexJar != expectedDexJar {
554 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
555 }
556
Colin Cross42be7612019-02-21 18:12:14 -0800557 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700558}
559
Paul Duffin9b478b02019-12-10 13:41:51 +0000560func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
561 if !reflect.DeepEqual(expected, actual) {
562 t.Errorf("%s: expected %q, found %q", message, expected, actual)
563 }
564}
565
Paul Duffin56d44902020-01-31 13:36:25 +0000566func TestJavaSdkLibraryImport(t *testing.T) {
567 ctx, _ := testJava(t, `
568 java_library {
569 name: "foo",
570 srcs: ["a.java"],
571 libs: ["sdklib"],
572 sdk_version: "current",
573 }
574
575 java_library {
576 name: "foo.system",
577 srcs: ["a.java"],
578 libs: ["sdklib"],
579 sdk_version: "system_current",
580 }
581
582 java_library {
583 name: "foo.test",
584 srcs: ["a.java"],
585 libs: ["sdklib"],
586 sdk_version: "test_current",
587 }
588
589 java_sdk_library_import {
590 name: "sdklib",
591 public: {
592 jars: ["a.jar"],
593 },
594 system: {
595 jars: ["b.jar"],
596 },
597 test: {
598 jars: ["c.jar"],
Paul Duffin533f9c72020-05-20 16:18:00 +0100599 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000600 },
601 }
602 `)
603
604 for _, scope := range []string{"", ".system", ".test"} {
605 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
606 javac := fooModule.Rule("javac")
607
608 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
609 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
610 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
611 }
612 }
613}
614
Colin Cross89536d42017-07-07 14:35:50 -0700615func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700616 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700617 java_defaults {
618 name: "defaults",
619 srcs: ["a.java"],
620 libs: ["bar"],
621 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700622 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700623 }
624
625 java_library {
626 name: "foo",
627 defaults: ["defaults"],
628 }
629
630 java_library {
631 name: "bar",
632 srcs: ["b.java"],
633 }
634
635 java_library {
636 name: "baz",
637 srcs: ["c.java"],
638 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700639
640 android_test {
641 name: "atestOptimize",
642 defaults: ["defaults"],
643 optimize: {enabled: true},
644 }
645
646 android_test {
647 name: "atestNoOptimize",
648 defaults: ["defaults"],
649 }
650
651 android_test {
652 name: "atestDefault",
653 srcs: ["a.java"],
654 }
Colin Cross89536d42017-07-07 14:35:50 -0700655 `)
656
Colin Cross4c428df2017-09-15 17:36:05 -0700657 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700658 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700659
660 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
661 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
662 }
663
Nan Zhanged19fc32017-10-19 13:06:22 -0700664 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
665 if !strings.Contains(javac.Args["classpath"], barTurbine) {
666 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700667 }
668
Colin Cross1ee23172017-10-18 14:44:18 -0700669 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700670 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
671 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700672 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700673
674 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
675 if atestOptimize.Output == nil {
676 t.Errorf("atestOptimize should optimize APK")
677 }
678
679 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
680 if atestNoOptimize.Output == nil {
681 t.Errorf("atestNoOptimize should not optimize APK")
682 }
683
684 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
685 if atestDefault.Output == nil {
686 t.Errorf("atestDefault should optimize APK")
687 }
Colin Cross89536d42017-07-07 14:35:50 -0700688}
689
Colin Cross0f37af02017-09-27 17:42:05 -0700690func TestResources(t *testing.T) {
691 var table = []struct {
692 name string
693 prop string
694 extra string
695 args string
696 }{
697 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700698 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700699 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800700 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700701 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700702 },
703 {
704 // Test that a module with java_resources includes the files
705 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700706 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
707 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700708 },
709 {
710 // Test that a module with a filegroup in java_resources includes the files with the
711 // path prefix
712 name: "resource filegroup",
713 prop: `java_resources: [":foo-res"]`,
714 extra: `
715 filegroup {
716 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800717 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700718 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700719 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700720 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700721 },
722 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700723 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
724 name: "wildcard dirs",
725 prop: `java_resource_dirs: ["java-res/*"]`,
726 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
727 },
728 {
729 // Test that a module exclude_java_resource_dirs excludes the files
730 name: "wildcard dirs",
731 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
732 args: "-C java-res/a -f java-res/a/a",
733 },
Colin Crosscedd4762018-09-13 11:26:19 -0700734 {
735 // Test wildcards in java_resources
736 name: "wildcard files",
737 prop: `java_resources: ["java-res/**/*"]`,
738 args: "-C . -f java-res/a/a -f java-res/b/b",
739 },
740 {
741 // Test exclude_java_resources with java_resources
742 name: "wildcard files with exclude",
743 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
744 args: "-C . -f java-res/a/a",
745 },
746 {
747 // Test exclude_java_resources with java_resource_dirs
748 name: "resource dirs with exclude files",
749 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
750 args: "-C java-res -f java-res/a/a",
751 },
752 {
753 // Test exclude_java_resource_dirs with java_resource_dirs
754 name: "resource dirs with exclude files",
755 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
756 args: "-C java-res -f java-res/a/a -f java-res/b/b",
757 },
Colin Cross0f37af02017-09-27 17:42:05 -0700758 }
759
760 for _, test := range table {
761 t.Run(test.name, func(t *testing.T) {
Colin Crossf5f663b2020-06-07 16:58:18 -0700762 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700763 java_library {
764 name: "foo",
765 srcs: [
766 "a.java",
767 "b.java",
768 "c.java",
769 ],
770 `+test.prop+`,
771 }
Colin Crossf5f663b2020-06-07 16:58:18 -0700772 `+test.extra,
773 map[string][]byte{
774 "java-res/a/a": nil,
775 "java-res/b/b": nil,
776 "java-res2/a": nil,
777 },
778 )
Colin Cross0f37af02017-09-27 17:42:05 -0700779
Colin Cross331a1212018-08-15 20:40:52 -0700780 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700781 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700782
783 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
784 t.Errorf("foo combined jars %v does not contain %q",
785 foo.Inputs.Strings(), fooRes.Output.String())
786 }
787
Colin Crossaf9c55b2017-10-03 14:50:08 -0700788 if fooRes.Args["jarArgs"] != test.args {
789 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700790 fooRes.Args["jarArgs"], test.args)
791 }
792 })
793 }
794}
795
Colin Cross0c4ce212019-05-03 15:28:19 -0700796func TestIncludeSrcs(t *testing.T) {
Colin Crossf5f663b2020-06-07 16:58:18 -0700797 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700798 java_library {
799 name: "foo",
800 srcs: [
801 "a.java",
802 "b.java",
803 "c.java",
804 ],
805 include_srcs: true,
806 }
807
808 java_library {
809 name: "bar",
810 srcs: [
811 "a.java",
812 "b.java",
813 "c.java",
814 ],
815 java_resource_dirs: ["java-res"],
816 include_srcs: true,
817 }
Colin Crossf5f663b2020-06-07 16:58:18 -0700818 `, map[string][]byte{
819 "java-res/a/a": nil,
820 "java-res/b/b": nil,
821 "java-res2/a": nil,
822 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700823
824 // Test a library with include_srcs: true
825 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
826 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
827
828 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
829 t.Errorf("foo combined jars %v does not contain %q", w, g)
830 }
831
832 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
833 t.Errorf("foo source jar args %q is not %q", w, g)
834 }
835
836 // Test a library with include_srcs: true and resources
837 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
838 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
839 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
840 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
841
842 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
843 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
844 }
845
846 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
847 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
848 }
849
850 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
851 t.Errorf("bar combined jars %v does not contain %q", w, g)
852 }
853
854 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
855 t.Errorf("bar source jar args %q is not %q", w, g)
856 }
857
858 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
859 t.Errorf("bar resource jar args %q is not %q", w, g)
860 }
861}
862
Pedro Loureiroa763c6d2021-02-15 15:41:33 +0000863func TestJavaLint(t *testing.T) {
864 ctx, _ := testJavaWithFS(t, `
865 java_library {
866 name: "foo",
867 srcs: [
868 "a.java",
869 "b.java",
870 "c.java",
871 ],
872 min_sdk_version: "29",
873 sdk_version: "system_current",
874 }
875 `, map[string][]byte{
876 "lint-baseline.xml": nil,
877 })
878
879 foo := ctx.ModuleForTests("foo", "android_common")
880 rule := foo.Rule("lint")
881
882 if !strings.Contains(rule.RuleParams.Command, "--baseline lint-baseline.xml") {
883 t.Error("did not pass --baseline flag")
884 }
885}
886
887func TestJavaLintWithoutBaseline(t *testing.T) {
888 ctx, _ := testJavaWithFS(t, `
889 java_library {
890 name: "foo",
891 srcs: [
892 "a.java",
893 "b.java",
894 "c.java",
895 ],
896 min_sdk_version: "29",
897 sdk_version: "system_current",
898 }
899 `, map[string][]byte{})
900
901 foo := ctx.ModuleForTests("foo", "android_common")
902 rule := foo.Rule("lint")
903
904 if strings.Contains(rule.RuleParams.Command, "--baseline") {
905 t.Error("passed --baseline flag for non existent file")
906 }
907}
908
909func TestJavaLintRequiresCustomLintFileToExist(t *testing.T) {
910 config := testConfig(
911 nil,
912 `
913 java_library {
914 name: "foo",
915 srcs: [
916 ],
917 min_sdk_version: "29",
918 sdk_version: "system_current",
919 lint: {
920 baseline_filename: "mybaseline.xml",
921 },
922 }
923 `, map[string][]byte{
924 "build/soong/java/lint_defaults.txt": nil,
925 "prebuilts/cmdline-tools/tools/bin/lint": nil,
926 "prebuilts/cmdline-tools/tools/lib/lint-classpath.jar": nil,
927 "framework/aidl": nil,
928 "a.java": nil,
929 "AndroidManifest.xml": nil,
930 "build/make/target/product/security": nil,
931 })
932 config.TestAllowNonExistentPaths = false
933 testJavaErrorWithConfig(t,
934 "source path \"mybaseline.xml\" does not exist",
935 config,
936 )
937}
938
939func TestJavaLintUsesCorrectBpConfig(t *testing.T) {
940 ctx, _ := testJavaWithFS(t, `
941 java_library {
942 name: "foo",
943 srcs: [
944 "a.java",
945 "b.java",
946 "c.java",
947 ],
948 min_sdk_version: "29",
949 sdk_version: "system_current",
950 lint: {
951 error_checks: ["SomeCheck"],
952 baseline_filename: "mybaseline.xml",
953 },
954 }
955 `, map[string][]byte{
956 "mybaseline.xml": nil,
957 })
958
959 foo := ctx.ModuleForTests("foo", "android_common")
960 rule := foo.Rule("lint")
961
962 if !strings.Contains(rule.RuleParams.Command, "--baseline mybaseline.xml") {
963 t.Error("did not use the correct file for baseline")
964 }
965}
966
Colin Cross54190b32017-10-09 15:34:10 -0700967func TestGeneratedSources(t *testing.T) {
Colin Crossf5f663b2020-06-07 16:58:18 -0700968 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -0700969 java_library {
970 name: "foo",
971 srcs: [
972 "a*.java",
973 ":gen",
974 "b*.java",
975 ],
976 }
977
978 genrule {
979 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800980 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700981 out: ["gen.java"],
982 }
Colin Crossf5f663b2020-06-07 16:58:18 -0700983 `, map[string][]byte{
984 "a.java": nil,
985 "b.java": nil,
986 })
Colin Cross54190b32017-10-09 15:34:10 -0700987
988 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
989 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
990
Colin Cross15e86d92017-10-20 15:07:08 -0700991 if filepath.Base(genrule.Output.String()) != "gen.java" {
992 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700993 }
994
995 if len(javac.Inputs) != 3 ||
996 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -0700997 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -0700998 javac.Inputs[2].String() != "b.java" {
999 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1000 }
1001}
1002
Nan Zhang61eaedb2017-11-02 13:28:15 -07001003func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001004 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001005 java_library {
1006 name: "foo",
1007 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001008 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001009 }
1010
1011 java_library {
1012 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001013 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001014 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001015 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001016 }
1017
1018 java_library {
1019 name: "baz",
1020 srcs: ["c.java"],
1021 libs: ["bar"],
1022 sdk_version: "14",
1023 }
1024 `)
1025
1026 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1027 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1028 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1029 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1030 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1031
1032 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1033 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1034 }
1035
1036 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1037 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1038 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1039 }
1040 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1041 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1042 }
1043 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1044 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1045 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001046 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001047 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001048 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001049 }
1050}
1051
1052func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001053 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001054 java_library {
1055 name: "bar",
1056 srcs: ["a.java","b.java","c.java"],
1057 javac_shard_size: 1
1058 }
1059 `)
1060
1061 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1062 for i := 0; i < 3; i++ {
1063 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1064 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1065 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1066 }
1067 }
1068}
1069
Nan Zhang581fd212018-01-10 16:06:12 -08001070func TestDroiddoc(t *testing.T) {
Colin Crossf5f663b2020-06-07 16:58:18 -07001071 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001072 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001073 name: "droiddoc-templates-sdk",
1074 path: ".",
1075 }
Jiyong Park29074592019-07-07 16:27:47 +09001076 filegroup {
1077 name: "bar-doc-aidl-srcs",
1078 srcs: ["bar-doc/IBar.aidl"],
1079 path: "bar-doc",
1080 }
Nan Zhang581fd212018-01-10 16:06:12 -08001081 droiddoc {
1082 name: "bar-doc",
1083 srcs: [
Colin Crossf5f663b2020-06-07 16:58:18 -07001084 "bar-doc/a.java",
Jiyong Park1e440682018-05-23 18:42:04 +09001085 "bar-doc/IFoo.aidl",
Jiyong Park29074592019-07-07 16:27:47 +09001086 ":bar-doc-aidl-srcs",
Nan Zhang581fd212018-01-10 16:06:12 -08001087 ],
1088 exclude_srcs: [
1089 "bar-doc/b.java"
1090 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001091 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001092 hdf: [
1093 "android.whichdoc offline",
1094 ],
1095 knowntags: [
1096 "bar-doc/known_oj_tags.txt",
1097 ],
1098 proofread_file: "libcore-proofread.txt",
1099 todo_file: "libcore-docs-todo.html",
1100 args: "-offlinemode -title \"libcore\"",
1101 }
Colin Crossf5f663b2020-06-07 16:58:18 -07001102 `,
1103 map[string][]byte{
1104 "bar-doc/a.java": nil,
1105 "bar-doc/b.java": nil,
1106 })
Liz Kammer10ed7632020-07-30 15:07:22 -07001107 barDocModule := ctx.ModuleForTests("bar-doc", "android_common")
1108 barDoc := barDocModule.Rule("javadoc")
1109 notExpected := " -stubs "
1110 if strings.Contains(barDoc.RuleParams.Command, notExpected) {
1111 t.Errorf("bar-doc command contains flag %q to create stubs, but should not", notExpected)
1112 }
Nan Zhang581fd212018-01-10 16:06:12 -08001113
Jiyong Park1e440682018-05-23 18:42:04 +09001114 var javaSrcs []string
Colin Crossc0806172019-06-14 18:51:47 -07001115 for _, i := range barDoc.Inputs {
Jiyong Park1e440682018-05-23 18:42:04 +09001116 javaSrcs = append(javaSrcs, i.Base())
1117 }
Colin Crossc0806172019-06-14 18:51:47 -07001118 if len(javaSrcs) != 1 || javaSrcs[0] != "a.java" {
1119 t.Errorf("inputs of bar-doc must be []string{\"a.java\"}, but was %#v.", javaSrcs)
Jiyong Park29074592019-07-07 16:27:47 +09001120 }
1121
Liz Kammer10ed7632020-07-30 15:07:22 -07001122 aidl := barDocModule.Rule("aidl")
Colin Crossc0806172019-06-14 18:51:47 -07001123 if g, w := barDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
1124 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1125 }
1126
1127 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1128 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001129 }
Nan Zhang581fd212018-01-10 16:06:12 -08001130}
1131
Liz Kammer9ba460f2020-08-04 09:55:13 -07001132func TestDroidstubs(t *testing.T) {
1133 ctx, _ := testJavaWithFS(t, `
1134 droiddoc_exported_dir {
1135 name: "droiddoc-templates-sdk",
1136 path: ".",
1137 }
1138
1139 droidstubs {
1140 name: "bar-stubs",
1141 srcs: [
1142 "bar-doc/a.java",
1143 ],
1144 api_levels_annotations_dirs: [
1145 "droiddoc-templates-sdk",
1146 ],
1147 api_levels_annotations_enabled: true,
1148 }
1149
1150 droidstubs {
1151 name: "bar-stubs-other",
1152 srcs: [
1153 "bar-doc/a.java",
1154 ],
1155 api_levels_annotations_dirs: [
1156 "droiddoc-templates-sdk",
1157 ],
1158 api_levels_annotations_enabled: true,
1159 api_levels_jar_filename: "android.other.jar",
1160 }
1161 `,
1162 map[string][]byte{
1163 "bar-doc/a.java": nil,
1164 })
1165 testcases := []struct {
1166 moduleName string
1167 expectedJarFilename string
1168 }{
1169 {
1170 moduleName: "bar-stubs",
1171 expectedJarFilename: "android.jar",
1172 },
1173 {
1174 moduleName: "bar-stubs-other",
1175 expectedJarFilename: "android.other.jar",
1176 },
1177 }
1178 for _, c := range testcases {
1179 m := ctx.ModuleForTests(c.moduleName, "android_common")
1180 metalava := m.Rule("metalava")
1181 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
1182 if actual := metalava.RuleParams.Command; !strings.Contains(actual, expected) {
1183 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1184 }
1185 }
1186}
1187
Paul Duffin83a2d962019-11-19 19:44:10 +00001188func TestDroidstubsWithSystemModules(t *testing.T) {
1189 ctx, _ := testJava(t, `
1190 droidstubs {
1191 name: "stubs-source-system-modules",
1192 srcs: [
Colin Crossf5f663b2020-06-07 16:58:18 -07001193 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001194 ],
1195 sdk_version: "none",
1196 system_modules: "source-system-modules",
1197 }
1198
1199 java_library {
1200 name: "source-jar",
1201 srcs: [
1202 "a.java",
1203 ],
1204 }
1205
1206 java_system_modules {
1207 name: "source-system-modules",
1208 libs: ["source-jar"],
1209 }
1210
1211 droidstubs {
1212 name: "stubs-prebuilt-system-modules",
1213 srcs: [
Colin Crossf5f663b2020-06-07 16:58:18 -07001214 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001215 ],
1216 sdk_version: "none",
1217 system_modules: "prebuilt-system-modules",
1218 }
1219
1220 java_import {
1221 name: "prebuilt-jar",
1222 jars: ["a.jar"],
1223 }
1224
1225 java_system_modules_import {
1226 name: "prebuilt-system-modules",
1227 libs: ["prebuilt-jar"],
1228 }
1229 `)
1230
1231 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1232
1233 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1234}
1235
1236func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1237 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1238 var systemJars []string
1239 for _, i := range metalavaRule.Implicits {
1240 systemJars = append(systemJars, i.Base())
1241 }
Ramy Medhat8e9b63b2020-04-30 03:08:37 -04001242 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001243 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1244 }
1245}
1246
Colin Cross54250902017-12-05 09:28:08 -08001247func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001248 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001249 java_library {
1250 name: "foo",
1251 srcs: ["a.java"],
1252 }
1253
1254 java_genrule {
1255 name: "jargen",
1256 tool_files: ["b.java"],
1257 cmd: "$(location b.java) $(in) $(out)",
1258 out: ["jargen.jar"],
1259 srcs: [":foo"],
1260 }
1261
1262 java_library {
1263 name: "bar",
1264 static_libs: ["jargen"],
1265 srcs: ["c.java"],
1266 }
1267
1268 java_library {
1269 name: "baz",
1270 libs: ["jargen"],
1271 srcs: ["c.java"],
1272 }
1273 `)
1274
1275 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1276 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1277 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1278 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1279 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1280
1281 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
1282 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
1283 }
1284
1285 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1286 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1287 }
1288
1289 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1290 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1291 }
1292
1293 if len(barCombined.Inputs) != 2 ||
1294 barCombined.Inputs[0].String() != bar.Output.String() ||
1295 barCombined.Inputs[1].String() != jargen.Output.String() {
1296 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1297 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1298 }
1299}
1300
Nan Zhang27e284d2018-02-09 21:03:53 +00001301func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001302 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001303 java_library {
1304 name: "foo",
1305 srcs: ["a.java", ":foo-srcs"],
1306 exclude_srcs: ["a.java", ":foo-excludes"],
1307 }
1308
1309 filegroup {
1310 name: "foo-srcs",
1311 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1312 }
1313
1314 filegroup {
1315 name: "foo-excludes",
1316 srcs: ["java-fg/a.java", "java-fg/b.java"],
1317 }
1318 `)
1319
1320 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1321
1322 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1323 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1324 }
1325}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001326
Paul Duffin52d398a2019-06-11 12:31:14 +01001327func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001328 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001329 "libcore/Android.bp": []byte(`
1330 java_library {
1331 name: "core",
1332 sdk_version: "none",
1333 system_modules: "none",
1334 }`),
1335 })
Colin Cross98be1bb2019-12-13 20:41:13 -08001336 ctx := testContext()
Paul Duffin52d398a2019-06-11 12:31:14 +01001337 run(t, ctx, config)
1338}
1339
Jiyong Parkc678ad32018-04-10 13:07:10 +09001340func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001341 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001342 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001343 name: "droiddoc-templates-sdk",
1344 path: ".",
1345 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001346 java_sdk_library {
1347 name: "foo",
1348 srcs: ["a.java", "b.java"],
1349 api_packages: ["foo"],
1350 }
1351 java_sdk_library {
1352 name: "bar",
1353 srcs: ["a.java", "b.java"],
1354 api_packages: ["bar"],
1355 }
1356 java_library {
1357 name: "baz",
1358 srcs: ["c.java"],
Paul Duffin64e61992020-05-15 10:20:31 +01001359 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001360 sdk_version: "system_current",
1361 }
Paul Duffind11e78e2020-05-15 20:37:11 +01001362 java_sdk_library {
1363 name: "barney",
1364 srcs: ["c.java"],
1365 api_only: true,
1366 }
1367 java_sdk_library {
1368 name: "betty",
1369 srcs: ["c.java"],
1370 shared_library: false,
1371 }
Paul Duffin64e61992020-05-15 10:20:31 +01001372 java_sdk_library_import {
1373 name: "quuz",
1374 public: {
1375 jars: ["c.jar"],
1376 },
1377 }
1378 java_sdk_library_import {
1379 name: "fred",
1380 public: {
1381 jars: ["b.jar"],
1382 },
1383 }
Paul Duffind11e78e2020-05-15 20:37:11 +01001384 java_sdk_library_import {
1385 name: "wilma",
1386 public: {
1387 jars: ["b.jar"],
1388 },
1389 shared_library: false,
1390 }
Jiyong Park1be96912018-05-28 18:02:19 +09001391 java_library {
1392 name: "qux",
1393 srcs: ["c.java"],
Paul Duffind11e78e2020-05-15 20:37:11 +01001394 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001395 sdk_version: "system_current",
1396 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001397 java_library {
1398 name: "baz-test",
1399 srcs: ["c.java"],
1400 libs: ["foo"],
1401 sdk_version: "test_current",
1402 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001403 java_library {
1404 name: "baz-29",
1405 srcs: ["c.java"],
1406 libs: ["foo"],
1407 sdk_version: "system_29",
1408 }
Paul Duffin5a6cfa02020-09-30 15:17:25 +01001409 java_library {
1410 name: "baz-module-30",
1411 srcs: ["c.java"],
1412 libs: ["foo"],
1413 sdk_version: "module_30",
1414 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001415 `)
1416
1417 // check the existence of the internal modules
1418 ctx.ModuleForTests("foo", "android_common")
Paul Duffin1c094a02020-05-08 15:52:37 +01001419 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1420 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1421 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1422 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1423 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1424 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001425 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001426 ctx.ModuleForTests("foo.api.public.28", "")
1427 ctx.ModuleForTests("foo.api.system.28", "")
1428 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001429
1430 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1431 // tests if baz is actually linked to the stubs lib
1432 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1433 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1434 "foo.stubs.system.jar")
1435 }
1436 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001437 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001438 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001439 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001440 }
1441 // test if baz is not linked to the system variant of foo
1442 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1443 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1444 "foo.stubs.jar")
1445 }
Jiyong Park1be96912018-05-28 18:02:19 +09001446
Paul Duffin726d23c2020-01-22 16:30:37 +00001447 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1448 // tests if baz-test is actually linked to the test stubs lib
1449 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1450 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1451 "foo.stubs.test.jar")
1452 }
1453
Paul Duffina2db18f2020-01-22 17:11:15 +00001454 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1455 // tests if baz-29 is actually linked to the system 29 stubs lib
1456 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1457 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1458 "prebuilts/sdk/29/system/foo.jar")
1459 }
1460
Paul Duffin5a6cfa02020-09-30 15:17:25 +01001461 bazModule30Javac := ctx.ModuleForTests("baz-module-30", "android_common").Rule("javac")
1462 // tests if "baz-module-30" is actually linked to the module 30 stubs lib
1463 if !strings.Contains(bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar") {
1464 t.Errorf("baz-module-30 javac classpath %v does not contain %q", bazModule30Javac.Args["classpath"],
1465 "prebuilts/sdk/30/module-lib/foo.jar")
1466 }
1467
Jiyong Park1be96912018-05-28 18:02:19 +09001468 // test if baz has exported SDK lib names foo and bar to qux
1469 qux := ctx.ModuleForTests("qux", "android_common")
1470 if quxLib, ok := qux.Module().(*Library); ok {
1471 sdkLibs := quxLib.ExportedSdkLibs()
Paul Duffin64e61992020-05-15 10:20:31 +01001472 sort.Strings(sdkLibs)
1473 if w := []string{"bar", "foo", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
1474 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001475 }
1476 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001477}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001478
Paul Duffin2e7ed652020-05-26 18:13:57 +01001479func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1480 ctx, _ := testJava(t, `
1481 java_sdk_library {
1482 name: "foo",
1483 srcs: ["a.java"],
1484 api_only: true,
1485 public: {
1486 enabled: true,
1487 },
1488 }
1489
1490 java_library {
1491 name: "bar",
1492 srcs: ["b.java"],
1493 libs: ["foo"],
1494 }
1495 `)
1496
1497 // The bar library should depend on the stubs jar.
1498 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1499 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1500 t.Errorf("expected %q, found %#q", expected, actual)
1501 }
1502}
1503
Paul Duffin46fdda82020-05-14 15:39:10 +01001504func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1505 testJava(t, `
1506 java_sdk_library {
1507 name: "foo",
1508 srcs: ["a.java"],
1509 api_packages: ["foo"],
1510 public: {
1511 enabled: true,
1512 },
1513 }
1514
1515 java_library {
1516 name: "bar",
1517 srcs: ["b.java", ":foo{.public.stubs.source}"],
1518 }
1519 `)
1520}
1521
1522func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1523 testJavaError(t, `"foo" does not provide api scope system`, `
1524 java_sdk_library {
1525 name: "foo",
1526 srcs: ["a.java"],
1527 api_packages: ["foo"],
1528 public: {
1529 enabled: true,
1530 },
1531 }
1532
1533 java_library {
1534 name: "bar",
1535 srcs: ["b.java", ":foo{.system.stubs.source}"],
1536 }
1537 `)
1538}
1539
1540func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1541 testJava(t, `
1542 java_sdk_library_import {
1543 name: "foo",
1544 public: {
1545 jars: ["a.jar"],
1546 stub_srcs: ["a.java"],
1547 current_api: "api/current.txt",
1548 removed_api: "api/removed.txt",
1549 },
1550 }
1551
1552 java_library {
1553 name: "bar",
1554 srcs: [":foo{.public.stubs.source}"],
1555 java_resources: [
1556 ":foo{.public.api.txt}",
1557 ":foo{.public.removed-api.txt}",
1558 ],
1559 }
1560 `)
1561}
1562
1563func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1564 bp := `
1565 java_sdk_library_import {
1566 name: "foo",
1567 public: {
1568 jars: ["a.jar"],
1569 },
1570 }
1571 `
1572
1573 t.Run("stubs.source", func(t *testing.T) {
1574 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1575 java_library {
1576 name: "bar",
1577 srcs: [":foo{.public.stubs.source}"],
1578 java_resources: [
1579 ":foo{.public.api.txt}",
1580 ":foo{.public.removed-api.txt}",
1581 ],
1582 }
1583 `)
1584 })
1585
1586 t.Run("api.txt", func(t *testing.T) {
1587 testJavaError(t, `api.txt not available for api scope public`, bp+`
1588 java_library {
1589 name: "bar",
1590 srcs: ["a.java"],
1591 java_resources: [
1592 ":foo{.public.api.txt}",
1593 ],
1594 }
1595 `)
1596 })
1597
1598 t.Run("removed-api.txt", func(t *testing.T) {
1599 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1600 java_library {
1601 name: "bar",
1602 srcs: ["a.java"],
1603 java_resources: [
1604 ":foo{.public.removed-api.txt}",
1605 ],
1606 }
1607 `)
1608 })
1609}
1610
Paul Duffin3a254982020-04-28 10:44:03 +01001611func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1612 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1613 java_sdk_library {
1614 name: "foo",
1615 srcs: ["a.java", "b.java"],
1616 api_packages: ["foo"],
1617 // Explicitly disable public to test the check that ensures the set of enabled
1618 // scopes is consistent.
1619 public: {
1620 enabled: false,
1621 },
1622 system: {
1623 enabled: true,
1624 },
1625 }
1626 `)
1627}
1628
Paul Duffin080f5ee2020-05-12 11:50:28 +01001629func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1630 testJava(t, `
1631 java_sdk_library {
1632 name: "foo",
1633 srcs: ["a.java", "b.java"],
1634 api_packages: ["foo"],
1635 system: {
1636 enabled: true,
1637 sdk_version: "module_current",
1638 },
1639 }
1640 `)
1641}
1642
Paul Duffin5a757b12020-06-02 13:00:08 +01001643func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
1644 testJava(t, `
1645 java_sdk_library {
1646 name: "foo",
1647 srcs: ["a.java", "b.java"],
1648 api_packages: ["foo"],
1649 system: {
1650 enabled: true,
1651 },
1652 module_lib: {
1653 enabled: true,
1654 },
1655 }
1656 `)
1657}
1658
1659func TestJavaSdkLibrary_SystemServer(t *testing.T) {
1660 testJava(t, `
1661 java_sdk_library {
1662 name: "foo",
1663 srcs: ["a.java", "b.java"],
1664 api_packages: ["foo"],
1665 system: {
1666 enabled: true,
1667 },
1668 system_server: {
1669 enabled: true,
1670 },
1671 }
1672 `)
1673}
1674
Paul Duffin5ae30792020-05-20 11:52:25 +01001675func TestJavaSdkLibrary_MissingScope(t *testing.T) {
1676 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1677 java_sdk_library {
1678 name: "foo",
1679 srcs: ["a.java"],
1680 public: {
1681 enabled: false,
1682 },
1683 }
1684
1685 java_library {
1686 name: "baz",
1687 srcs: ["a.java"],
1688 libs: ["foo"],
1689 sdk_version: "module_current",
1690 }
1691 `)
1692}
1693
1694func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
1695 testJava(t, `
1696 java_sdk_library {
1697 name: "foo",
1698 srcs: ["a.java"],
1699 system: {
1700 enabled: true,
1701 },
1702 }
1703
1704 java_library {
1705 name: "baz",
1706 srcs: ["a.java"],
1707 libs: ["foo"],
1708 // foo does not have module-lib scope so it should fallback to system
1709 sdk_version: "module_current",
1710 }
1711 `)
1712}
1713
Jiyong Park27fc4142020-05-28 00:19:53 +09001714func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
1715 ctx, _ := testJava(t, `
1716 java_sdk_library {
1717 name: "foo",
1718 srcs: ["a.java"],
1719 system: {
1720 enabled: true,
1721 },
1722 default_to_stubs: true,
1723 }
1724
1725 java_library {
1726 name: "baz",
1727 srcs: ["a.java"],
1728 libs: ["foo"],
1729 // does not have sdk_version set, should fallback to module,
1730 // which will then fallback to system because the module scope
1731 // is not enabled.
1732 }
1733 `)
1734 // The baz library should depend on the system stubs jar.
1735 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1736 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1737 t.Errorf("expected %q, found %#q", expected, actual)
1738 }
1739}
1740
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001741var compilerFlagsTestCases = []struct {
1742 in string
1743 out bool
1744}{
1745 {
1746 in: "a",
1747 out: false,
1748 },
1749 {
1750 in: "-a",
1751 out: true,
1752 },
1753 {
1754 in: "-no-jdk",
1755 out: false,
1756 },
1757 {
1758 in: "-no-stdlib",
1759 out: false,
1760 },
1761 {
1762 in: "-kotlin-home",
1763 out: false,
1764 },
1765 {
1766 in: "-kotlin-home /some/path",
1767 out: false,
1768 },
1769 {
1770 in: "-include-runtime",
1771 out: false,
1772 },
1773 {
1774 in: "-Xintellij-plugin-root",
1775 out: false,
1776 },
1777}
1778
1779type mockContext struct {
1780 android.ModuleContext
1781 result bool
1782}
1783
1784func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1785 // CheckBadCompilerFlags calls this function when the flag should be rejected
1786 ctx.result = false
1787}
1788
1789func TestCompilerFlags(t *testing.T) {
1790 for _, testCase := range compilerFlagsTestCases {
1791 ctx := &mockContext{result: true}
1792 CheckKotlincFlags(ctx, []string{testCase.in})
1793 if ctx.result != testCase.out {
1794 t.Errorf("incorrect output:")
1795 t.Errorf(" input: %#v", testCase.in)
1796 t.Errorf(" expected: %#v", testCase.out)
1797 t.Errorf(" got: %#v", ctx.result)
1798 }
1799 }
1800}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001801
1802// TODO(jungjw): Consider making this more robust by ignoring path order.
1803func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
1804 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
1805 flags := strings.Split(variables["javacFlags"], " ")
1806 got := ""
1807 for _, flag := range flags {
1808 keyEnd := strings.Index(flag, "=")
1809 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1810 got = flag[keyEnd+1:]
1811 break
1812 }
1813 }
1814 if expected != got {
1815 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1816 }
1817}
1818
1819func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001820 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001821 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001822 bp := `
1823 java_library {
1824 name: "foo",
1825 srcs: ["a.java"],
1826 java_version: "1.8",
1827 }
1828
1829 java_library {
1830 name: "bar",
1831 srcs: ["b.java"],
1832 sdk_version: "none",
1833 system_modules: "none",
1834 patch_module: "java.base",
1835 java_version: "1.8",
1836 }
1837
1838 java_library {
1839 name: "baz",
1840 srcs: ["c.java"],
1841 patch_module: "java.base",
1842 java_version: "1.8",
1843 }
1844 `
1845 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001846
1847 checkPatchModuleFlag(t, ctx, "foo", "")
1848 checkPatchModuleFlag(t, ctx, "bar", "")
1849 checkPatchModuleFlag(t, ctx, "baz", "")
1850 })
1851
Pete Gillin0c2143e2019-05-02 15:32:11 +01001852 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001853 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001854 bp := `
1855 java_library {
1856 name: "foo",
1857 srcs: ["a.java"],
1858 }
1859
1860 java_library {
1861 name: "bar",
1862 srcs: ["b.java"],
1863 sdk_version: "none",
1864 system_modules: "none",
1865 patch_module: "java.base",
1866 }
1867
1868 java_library {
1869 name: "baz",
1870 srcs: ["c.java"],
1871 patch_module: "java.base",
1872 }
1873 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001874 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001875
1876 checkPatchModuleFlag(t, ctx, "foo", "")
1877 expected := "java.base=.:" + buildDir
1878 checkPatchModuleFlag(t, ctx, "bar", expected)
Jiyong Park231d0562019-12-18 17:28:17 +09001879 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001880 checkPatchModuleFlag(t, ctx, "baz", expected)
1881 })
1882}
Paul Duffina7b9f422020-01-10 17:12:18 +00001883
1884func TestJavaSystemModules(t *testing.T) {
1885 ctx, _ := testJava(t, `
1886 java_system_modules {
1887 name: "system-modules",
1888 libs: ["system-module1", "system-module2"],
1889 }
1890 java_library {
1891 name: "system-module1",
1892 srcs: ["a.java"],
1893 sdk_version: "none",
1894 system_modules: "none",
1895 }
1896 java_library {
1897 name: "system-module2",
1898 srcs: ["b.java"],
1899 sdk_version: "none",
1900 system_modules: "none",
1901 }
1902 `)
1903
1904 // check the existence of the module
1905 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1906
1907 cmd := systemModules.Rule("jarsTosystemModules")
1908
1909 // make sure the command compiles against the supplied modules.
1910 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1911 if !strings.Contains(cmd.Args["classpath"], module) {
1912 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1913 module)
1914 }
1915 }
1916}
Paul Duffin90169ba2020-01-10 17:16:44 +00001917
1918func TestJavaSystemModulesImport(t *testing.T) {
1919 ctx, _ := testJava(t, `
1920 java_system_modules_import {
1921 name: "system-modules",
1922 libs: ["system-module1", "system-module2"],
1923 }
1924 java_import {
1925 name: "system-module1",
1926 jars: ["a.jar"],
1927 }
1928 java_import {
1929 name: "system-module2",
1930 jars: ["b.jar"],
1931 }
1932 `)
1933
1934 // check the existence of the module
1935 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1936
1937 cmd := systemModules.Rule("jarsTosystemModules")
1938
1939 // make sure the command compiles against the supplied modules.
1940 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1941 if !strings.Contains(cmd.Args["classpath"], module) {
1942 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1943 module)
1944 }
1945 }
1946}
Paul Duffin83a2d962019-11-19 19:44:10 +00001947
1948func TestJavaLibraryWithSystemModules(t *testing.T) {
1949 ctx, _ := testJava(t, `
1950 java_library {
1951 name: "lib-with-source-system-modules",
1952 srcs: [
1953 "a.java",
1954 ],
1955 sdk_version: "none",
1956 system_modules: "source-system-modules",
1957 }
1958
1959 java_library {
1960 name: "source-jar",
1961 srcs: [
1962 "a.java",
1963 ],
1964 }
1965
1966 java_system_modules {
1967 name: "source-system-modules",
1968 libs: ["source-jar"],
1969 }
1970
1971 java_library {
1972 name: "lib-with-prebuilt-system-modules",
1973 srcs: [
1974 "a.java",
1975 ],
1976 sdk_version: "none",
1977 system_modules: "prebuilt-system-modules",
1978 }
1979
1980 java_import {
1981 name: "prebuilt-jar",
1982 jars: ["a.jar"],
1983 }
1984
1985 java_system_modules_import {
1986 name: "prebuilt-system-modules",
1987 libs: ["prebuilt-jar"],
1988 }
1989 `)
1990
1991 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
1992
1993 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
1994}
1995
1996func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
1997 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
1998 bootClasspath := javacRule.Args["bootClasspath"]
1999 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2000 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2001 }
2002}