blob: 6f62f552c446b37b2c74a96301edf7d4e49eb2a5 [file] [log] [blame]
Jiyong Parkd1063c12019-07-17 20:08:41 +09001// Copyright (C) 2019 The Android Open Source Project
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package android
16
17import (
Paul Duffin255f18e2019-12-13 11:22:16 +000018 "sort"
Jiyong Parkd1063c12019-07-17 20:08:41 +090019 "strings"
20
Paul Duffin13879572019-11-28 14:31:38 +000021 "github.com/google/blueprint"
Jiyong Parkd1063c12019-07-17 20:08:41 +090022 "github.com/google/blueprint/proptools"
23)
24
Paul Duffin923e8a52020-03-30 15:33:32 +010025// Extracted from SdkAware to make it easier to define custom subsets of the
26// SdkAware interface and improve code navigation within the IDE.
27//
28// In addition to its use in SdkAware this interface must also be implemented by
29// APEX to specify the SDKs required by that module and its contents. e.g. APEX
30// is expected to implement RequiredSdks() by reading its own properties like
31// `uses_sdks`.
32type RequiredSdks interface {
33 // The set of SDKs required by an APEX and its contents.
34 RequiredSdks() SdkRefs
35}
36
Jiyong Parkd1063c12019-07-17 20:08:41 +090037// SdkAware is the interface that must be supported by any module to become a member of SDK or to be
38// built with SDK
39type SdkAware interface {
40 Module
Paul Duffin923e8a52020-03-30 15:33:32 +010041 RequiredSdks
42
Jiyong Parkd1063c12019-07-17 20:08:41 +090043 sdkBase() *SdkBase
44 MakeMemberOf(sdk SdkRef)
45 IsInAnySdk() bool
46 ContainingSdk() SdkRef
47 MemberName() string
48 BuildWithSdks(sdks SdkRefs)
Jiyong Parkd1063c12019-07-17 20:08:41 +090049}
50
51// SdkRef refers to a version of an SDK
52type SdkRef struct {
53 Name string
54 Version string
55}
56
Jiyong Park9b409bc2019-10-11 14:59:13 +090057// Unversioned determines if the SdkRef is referencing to the unversioned SDK module
58func (s SdkRef) Unversioned() bool {
59 return s.Version == ""
Jiyong Parkd1063c12019-07-17 20:08:41 +090060}
61
Jiyong Parka7bc8ad2019-10-15 15:20:07 +090062// String returns string representation of this SdkRef for debugging purpose
63func (s SdkRef) String() string {
64 if s.Name == "" {
65 return "(No Sdk)"
66 }
67 if s.Unversioned() {
68 return s.Name
69 }
70 return s.Name + string(SdkVersionSeparator) + s.Version
71}
72
Jiyong Park9b409bc2019-10-11 14:59:13 +090073// SdkVersionSeparator is a character used to separate an sdk name and its version
74const SdkVersionSeparator = '@'
Jiyong Parkd1063c12019-07-17 20:08:41 +090075
Jiyong Park9b409bc2019-10-11 14:59:13 +090076// ParseSdkRef parses a `name@version` style string into a corresponding SdkRef struct
Jiyong Parkd1063c12019-07-17 20:08:41 +090077func ParseSdkRef(ctx BaseModuleContext, str string, property string) SdkRef {
Jiyong Park9b409bc2019-10-11 14:59:13 +090078 tokens := strings.Split(str, string(SdkVersionSeparator))
Jiyong Parkd1063c12019-07-17 20:08:41 +090079 if len(tokens) < 1 || len(tokens) > 2 {
80 ctx.PropertyErrorf(property, "%q does not follow name#version syntax", str)
81 return SdkRef{Name: "invalid sdk name", Version: "invalid sdk version"}
82 }
83
84 name := tokens[0]
85
Jiyong Park9b409bc2019-10-11 14:59:13 +090086 var version string
Jiyong Parkd1063c12019-07-17 20:08:41 +090087 if len(tokens) == 2 {
88 version = tokens[1]
89 }
90
91 return SdkRef{Name: name, Version: version}
92}
93
94type SdkRefs []SdkRef
95
Jiyong Park9b409bc2019-10-11 14:59:13 +090096// Contains tells if the given SdkRef is in this list of SdkRef's
Jiyong Parkd1063c12019-07-17 20:08:41 +090097func (refs SdkRefs) Contains(s SdkRef) bool {
98 for _, r := range refs {
99 if r == s {
100 return true
101 }
102 }
103 return false
104}
105
106type sdkProperties struct {
107 // The SDK that this module is a member of. nil if it is not a member of any SDK
108 ContainingSdk *SdkRef `blueprint:"mutated"`
109
110 // The list of SDK names and versions that are used to build this module
111 RequiredSdks SdkRefs `blueprint:"mutated"`
112
113 // Name of the module that this sdk member is representing
114 Sdk_member_name *string
115}
116
117// SdkBase is a struct that is expected to be included in module types to implement the SdkAware
118// interface. InitSdkAwareModule should be called to initialize this struct.
119type SdkBase struct {
120 properties sdkProperties
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000121 module SdkAware
Jiyong Parkd1063c12019-07-17 20:08:41 +0900122}
123
124func (s *SdkBase) sdkBase() *SdkBase {
125 return s
126}
127
Jiyong Park9b409bc2019-10-11 14:59:13 +0900128// MakeMemberOf sets this module to be a member of a specific SDK
Jiyong Parkd1063c12019-07-17 20:08:41 +0900129func (s *SdkBase) MakeMemberOf(sdk SdkRef) {
130 s.properties.ContainingSdk = &sdk
131}
132
133// IsInAnySdk returns true if this module is a member of any SDK
134func (s *SdkBase) IsInAnySdk() bool {
135 return s.properties.ContainingSdk != nil
136}
137
138// ContainingSdk returns the SDK that this module is a member of
139func (s *SdkBase) ContainingSdk() SdkRef {
140 if s.properties.ContainingSdk != nil {
141 return *s.properties.ContainingSdk
142 }
Jiyong Park9b409bc2019-10-11 14:59:13 +0900143 return SdkRef{Name: "", Version: ""}
Jiyong Parkd1063c12019-07-17 20:08:41 +0900144}
145
Jiyong Park9b409bc2019-10-11 14:59:13 +0900146// MemberName returns the name of the module that this SDK member is overriding
Jiyong Parkd1063c12019-07-17 20:08:41 +0900147func (s *SdkBase) MemberName() string {
148 return proptools.String(s.properties.Sdk_member_name)
149}
150
151// BuildWithSdks is used to mark that this module has to be built with the given SDK(s).
152func (s *SdkBase) BuildWithSdks(sdks SdkRefs) {
153 s.properties.RequiredSdks = sdks
154}
155
156// RequiredSdks returns the SDK(s) that this module has to be built with
157func (s *SdkBase) RequiredSdks() SdkRefs {
158 return s.properties.RequiredSdks
159}
160
161// InitSdkAwareModule initializes the SdkBase struct. This must be called by all modules including
162// SdkBase.
163func InitSdkAwareModule(m SdkAware) {
164 base := m.sdkBase()
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000165 base.module = m
Jiyong Parkd1063c12019-07-17 20:08:41 +0900166 m.AddProperties(&base.properties)
167}
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000168
169// Provide support for generating the build rules which will build the snapshot.
170type SnapshotBuilder interface {
171 // Copy src to the dest (which is a snapshot relative path) and add the dest
172 // to the zip
173 CopyToSnapshot(src Path, dest string)
174
Paul Duffin91547182019-11-12 19:39:36 +0000175 // Unzip the supplied zip into the snapshot relative directory destDir.
176 UnzipToSnapshot(zipPath Path, destDir string)
177
Paul Duffinb645ec82019-11-27 17:43:54 +0000178 // Add a new prebuilt module to the snapshot. The returned module
179 // must be populated with the module type specific properties. The following
180 // properties will be automatically populated.
181 //
182 // * name
183 // * sdk_member_name
184 // * prefer
185 //
186 // This will result in two Soong modules being generated in the Android. One
187 // that is versioned, coupled to the snapshot version and marked as
188 // prefer=true. And one that is not versioned, not marked as prefer=true and
189 // will only be used if the equivalently named non-prebuilt module is not
190 // present.
Paul Duffin9d8d6092019-12-05 18:19:29 +0000191 AddPrebuiltModule(member SdkMember, moduleType string) BpModule
Paul Duffin7b81f5e2020-01-13 21:03:22 +0000192
193 // The property tag to use when adding a property to a BpModule that contains
194 // references to other sdk members. Using this will ensure that the reference
195 // is correctly output for both versioned and unversioned prebuilts in the
196 // snapshot.
197 //
Paul Duffin13f02712020-03-06 12:30:43 +0000198 // "required: true" means that the property must only contain references
199 // to other members of the sdk. Passing a reference to a module that is not a
200 // member of the sdk will result in a build error.
201 //
202 // "required: false" means that the property can contain references to modules
203 // that are either members or not members of the sdk. If a reference is to a
204 // module that is a non member then the reference is left unchanged, i.e. it
205 // is not transformed as references to members are.
206 //
207 // The handling of the member names is dependent on whether it is an internal or
208 // exported member. An exported member is one whose name is specified in one of
209 // the member type specific properties. An internal member is one that is added
210 // due to being a part of an exported (or other internal) member and is not itself
211 // an exported member.
212 //
213 // Member names are handled as follows:
214 // * When creating the unversioned form of the module the name is left unchecked
215 // unless the member is internal in which case it is transformed into an sdk
216 // specific name, i.e. by prefixing with the sdk name.
217 //
218 // * When creating the versioned form of the module the name is transformed into
219 // a versioned sdk specific name, i.e. by prefixing with the sdk name and
220 // suffixing with the version.
221 //
Paul Duffin7b81f5e2020-01-13 21:03:22 +0000222 // e.g.
Paul Duffin13f02712020-03-06 12:30:43 +0000223 // bpPropertySet.AddPropertyWithTag("libs", []string{"member1", "member2"}, builder.SdkMemberReferencePropertyTag(true))
224 SdkMemberReferencePropertyTag(required bool) BpPropertyTag
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000225}
226
Paul Duffin5b511a22020-01-15 14:23:52 +0000227type BpPropertyTag interface{}
228
Paul Duffinb645ec82019-11-27 17:43:54 +0000229// A set of properties for use in a .bp file.
230type BpPropertySet interface {
231 // Add a property, the value can be one of the following types:
232 // * string
233 // * array of the above
234 // * bool
235 // * BpPropertySet
236 //
Paul Duffin5b511a22020-01-15 14:23:52 +0000237 // It is an error if multiple properties with the same name are added.
Paul Duffinb645ec82019-11-27 17:43:54 +0000238 AddProperty(name string, value interface{})
239
Paul Duffin5b511a22020-01-15 14:23:52 +0000240 // Add a property with an associated tag
241 AddPropertyWithTag(name string, value interface{}, tag BpPropertyTag)
242
Paul Duffinb645ec82019-11-27 17:43:54 +0000243 // Add a property set with the specified name and return so that additional
244 // properties can be added.
245 AddPropertySet(name string) BpPropertySet
246}
247
248// A .bp module definition.
249type BpModule interface {
250 BpPropertySet
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000251}
Paul Duffin13879572019-11-28 14:31:38 +0000252
253// An individual member of the SDK, includes all of the variants that the SDK
254// requires.
255type SdkMember interface {
256 // The name of the member.
257 Name() string
258
259 // All the variants required by the SDK.
260 Variants() []SdkAware
261}
262
Paul Duffinf8539922019-11-19 19:44:10 +0000263type SdkMemberTypeDependencyTag interface {
264 blueprint.DependencyTag
265
266 SdkMemberType() SdkMemberType
267}
268
269type sdkMemberDependencyTag struct {
270 blueprint.BaseDependencyTag
271 memberType SdkMemberType
272}
273
274func (t *sdkMemberDependencyTag) SdkMemberType() SdkMemberType {
275 return t.memberType
276}
277
278func DependencyTagForSdkMemberType(memberType SdkMemberType) SdkMemberTypeDependencyTag {
279 return &sdkMemberDependencyTag{memberType: memberType}
280}
281
Paul Duffin13879572019-11-28 14:31:38 +0000282// Interface that must be implemented for every type that can be a member of an
283// sdk.
284//
285// The basic implementation should look something like this, where ModuleType is
286// the name of the module type being supported.
287//
Paul Duffin255f18e2019-12-13 11:22:16 +0000288// type moduleTypeSdkMemberType struct {
289// android.SdkMemberTypeBase
Paul Duffin13879572019-11-28 14:31:38 +0000290// }
291//
Paul Duffin255f18e2019-12-13 11:22:16 +0000292// func init() {
293// android.RegisterSdkMemberType(&moduleTypeSdkMemberType{
294// SdkMemberTypeBase: android.SdkMemberTypeBase{
295// PropertyName: "module_types",
296// },
297// }
Paul Duffin13879572019-11-28 14:31:38 +0000298// }
299//
300// ...methods...
301//
302type SdkMemberType interface {
Paul Duffin255f18e2019-12-13 11:22:16 +0000303 // The name of the member type property on an sdk module.
304 SdkPropertyName() string
305
Paul Duffine6029182019-12-16 17:43:48 +0000306 // True if the member type supports the sdk/sdk_snapshot, false otherwise.
307 UsableWithSdkAndSdkSnapshot() bool
308
Paul Duffinf4ae4f12020-01-13 20:58:25 +0000309 // Return true if modules of this type can have dependencies which should be
310 // treated as if they are sdk members.
311 //
312 // Any dependency that is to be treated as a member of the sdk needs to implement
313 // SdkAware and be added with an SdkMemberTypeDependencyTag tag.
314 HasTransitiveSdkMembers() bool
315
Martin Stjernholmcd07bce2020-03-10 22:37:59 +0000316 // Add dependencies from the SDK module to all the module variants the member
317 // type contributes to the SDK. `names` is the list of module names given in
318 // the member type property (as returned by SdkPropertyName()) in the SDK
319 // module. The exact set of variants required is determined by the SDK and its
320 // properties. The dependencies must be added with the supplied tag.
Paul Duffin13879572019-11-28 14:31:38 +0000321 //
322 // The BottomUpMutatorContext provided is for the SDK module.
323 AddDependencies(mctx BottomUpMutatorContext, dependencyTag blueprint.DependencyTag, names []string)
324
325 // Return true if the supplied module is an instance of this member type.
326 //
327 // This is used to check the type of each variant before added to the
328 // SdkMember. Returning false will cause an error to be logged expaining that
329 // the module is not allowed in whichever sdk property it was added.
330 IsInstance(module Module) bool
331
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000332 // Add a prebuilt module that the sdk will populate.
333 //
334 // Returning nil from this will cause the sdk module type to use the deprecated BuildSnapshot
335 // method to build the snapshot. That method is deprecated because it requires the SdkMemberType
336 // implementation to do all the word.
337 //
338 // Otherwise, returning a non-nil value from this will cause the sdk module type to do the
339 // majority of the work to generate the snapshot. The sdk module code generates the snapshot
340 // as follows:
341 //
342 // * A properties struct of type SdkMemberProperties is created for each variant and
343 // populated with information from the variant by calling PopulateFromVariant(SdkAware)
344 // on the struct.
345 //
346 // * An additional properties struct is created into which the common properties will be
347 // added.
348 //
349 // * The variant property structs are analysed to find exported (capitalized) fields which
350 // have common values. Those fields are cleared and the common value added to the common
Paul Duffinb07fa512020-03-10 22:17:04 +0000351 // properties. A field annotated with a tag of `sdk:"keep"` will be treated as if it
352 // was not capitalized, i.e. not optimized for common values.
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000353 //
354 // * The sdk module type populates the BpModule structure, creating the arch specific
355 // structure and calls AddToPropertySet(...) on the properties struct to add the member
356 // specific properties in the correct place in the structure.
357 //
Paul Duffin3a4eb502020-03-19 16:11:18 +0000358 AddPrebuiltModule(ctx SdkMemberContext, member SdkMember) BpModule
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000359
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000360 // Create a structure into which variant specific properties can be added.
361 CreateVariantPropertiesStruct() SdkMemberProperties
Paul Duffin13879572019-11-28 14:31:38 +0000362}
Paul Duffin255f18e2019-12-13 11:22:16 +0000363
Paul Duffine6029182019-12-16 17:43:48 +0000364// Base type for SdkMemberType implementations.
Paul Duffin255f18e2019-12-13 11:22:16 +0000365type SdkMemberTypeBase struct {
Paul Duffinf4ae4f12020-01-13 20:58:25 +0000366 PropertyName string
367 SupportsSdk bool
368 TransitiveSdkMembers bool
Paul Duffin255f18e2019-12-13 11:22:16 +0000369}
370
371func (b *SdkMemberTypeBase) SdkPropertyName() string {
372 return b.PropertyName
373}
374
Paul Duffine6029182019-12-16 17:43:48 +0000375func (b *SdkMemberTypeBase) UsableWithSdkAndSdkSnapshot() bool {
376 return b.SupportsSdk
377}
378
Paul Duffinf4ae4f12020-01-13 20:58:25 +0000379func (b *SdkMemberTypeBase) HasTransitiveSdkMembers() bool {
380 return b.TransitiveSdkMembers
381}
382
Paul Duffin255f18e2019-12-13 11:22:16 +0000383// Encapsulates the information about registered SdkMemberTypes.
384type SdkMemberTypesRegistry struct {
385 // The list of types sorted by property name.
386 list []SdkMemberType
387
388 // The key that uniquely identifies this registry instance.
389 key OnceKey
390}
391
Paul Duffine6029182019-12-16 17:43:48 +0000392func (r *SdkMemberTypesRegistry) copyAndAppend(memberType SdkMemberType) *SdkMemberTypesRegistry {
393 oldList := r.list
Paul Duffin255f18e2019-12-13 11:22:16 +0000394
395 // Copy the slice just in case this is being read while being modified, e.g. when testing.
396 list := make([]SdkMemberType, 0, len(oldList)+1)
397 list = append(list, oldList...)
398 list = append(list, memberType)
399
400 // Sort the member types by their property name to ensure that registry order has no effect
401 // on behavior.
402 sort.Slice(list, func(i1, i2 int) bool {
403 t1 := list[i1]
404 t2 := list[i2]
405
406 return t1.SdkPropertyName() < t2.SdkPropertyName()
407 })
408
409 // Generate a key that identifies the slice of SdkMemberTypes by joining the property names
410 // from all the SdkMemberType .
411 var properties []string
412 for _, t := range list {
413 properties = append(properties, t.SdkPropertyName())
414 }
415 key := NewOnceKey(strings.Join(properties, "|"))
416
417 // Create a new registry so the pointer uniquely identifies the set of registered types.
Paul Duffine6029182019-12-16 17:43:48 +0000418 return &SdkMemberTypesRegistry{
Paul Duffin255f18e2019-12-13 11:22:16 +0000419 list: list,
420 key: key,
421 }
422}
Paul Duffine6029182019-12-16 17:43:48 +0000423
424func (r *SdkMemberTypesRegistry) RegisteredTypes() []SdkMemberType {
425 return r.list
426}
427
428func (r *SdkMemberTypesRegistry) UniqueOnceKey() OnceKey {
429 // Use the pointer to the registry as the unique key.
430 return NewCustomOnceKey(r)
431}
432
433// The set of registered SdkMemberTypes, one for sdk module and one for module_exports.
434var ModuleExportsMemberTypes = &SdkMemberTypesRegistry{}
435var SdkMemberTypes = &SdkMemberTypesRegistry{}
436
437// Register an SdkMemberType object to allow them to be used in the sdk and sdk_snapshot module
438// types.
439func RegisterSdkMemberType(memberType SdkMemberType) {
440 // All member types are usable with module_exports.
441 ModuleExportsMemberTypes = ModuleExportsMemberTypes.copyAndAppend(memberType)
442
443 // Only those that explicitly indicate it are usable with sdk.
444 if memberType.UsableWithSdkAndSdkSnapshot() {
445 SdkMemberTypes = SdkMemberTypes.copyAndAppend(memberType)
446 }
447}
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000448
449// Base structure for all implementations of SdkMemberProperties.
450//
Paul Duffina04c1072020-03-02 10:16:35 +0000451// Contains common properties that apply across many different member types. These
452// are not affected by the optimization to extract common values.
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000453type SdkMemberPropertiesBase struct {
Paul Duffina04c1072020-03-02 10:16:35 +0000454 // The number of unique os types supported by the member variants.
Paul Duffina551a1c2020-03-17 21:04:24 +0000455 //
456 // If a member has a variant with more than one os type then it will need to differentiate
457 // the locations of any of their prebuilt files in the snapshot by os type to prevent them
458 // from colliding. See OsPrefix().
459 //
460 // This property is the same for all variants of a member and so would be optimized away
461 // if it was not explicitly kept.
Paul Duffinb07fa512020-03-10 22:17:04 +0000462 Os_count int `sdk:"keep"`
Paul Duffina04c1072020-03-02 10:16:35 +0000463
464 // The os type for which these properties refer.
Paul Duffina551a1c2020-03-17 21:04:24 +0000465 //
466 // Provided to allow a member to differentiate between os types in the locations of their
467 // prebuilt files when it supports more than one os type.
468 //
469 // This property is the same for all os type specific variants of a member and so would be
470 // optimized away if it was not explicitly kept.
Paul Duffinb07fa512020-03-10 22:17:04 +0000471 Os OsType `sdk:"keep"`
Paul Duffina551a1c2020-03-17 21:04:24 +0000472
473 // The setting to use for the compile_multilib property.
474 //
475 // This property is set after optimization so there is no point in trying to optimize it.
476 Compile_multilib string `sdk:"keep"`
Paul Duffina04c1072020-03-02 10:16:35 +0000477}
478
479// The os prefix to use for any file paths in the sdk.
480//
481// Is an empty string if the member only provides variants for a single os type, otherwise
482// is the OsType.Name.
483func (b *SdkMemberPropertiesBase) OsPrefix() string {
484 if b.Os_count == 1 {
485 return ""
486 } else {
487 return b.Os.Name
488 }
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000489}
490
491func (b *SdkMemberPropertiesBase) Base() *SdkMemberPropertiesBase {
492 return b
493}
494
495// Interface to be implemented on top of a structure that contains variant specific
496// information.
497//
498// Struct fields that are capitalized are examined for common values to extract. Fields
499// that are not capitalized are assumed to be arch specific.
500type SdkMemberProperties interface {
501 // Access the base structure.
502 Base() *SdkMemberPropertiesBase
503
Paul Duffin3a4eb502020-03-19 16:11:18 +0000504 // Populate this structure with information from the variant.
505 PopulateFromVariant(ctx SdkMemberContext, variant Module)
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000506
Paul Duffin3a4eb502020-03-19 16:11:18 +0000507 // Add the information from this structure to the property set.
508 AddToPropertySet(ctx SdkMemberContext, propertySet BpPropertySet)
509}
510
511// Provides access to information common to a specific member.
512type SdkMemberContext interface {
513
514 // The module context of the sdk common os variant which is creating the snapshot.
515 SdkModuleContext() ModuleContext
516
517 // The builder of the snapshot.
518 SnapshotBuilder() SnapshotBuilder
Paul Duffina551a1c2020-03-17 21:04:24 +0000519
520 // The type of the member.
521 MemberType() SdkMemberType
522
523 // The name of the member.
524 //
525 // Provided for use by sdk members to create a member specific location within the snapshot
526 // into which to copy the prebuilt files.
527 Name() string
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000528}